[LFC][Floats] Remove redundant intersecting logic
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-19  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][Floats] Remove redundant intersecting logic
4         https://bugs.webkit.org/show_bug.cgi?id=194804
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2019-02-19  Dean Jackson  <dino@apple.com>
11
12         Clean-up output from generate-xcfilelists so it can be filtered
13         https://bugs.webkit.org/show_bug.cgi?id=194795
14
15         Reviewed by Joseph Pecoraro (and Keith Rollin).
16
17         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
18         make a slight tweak to filter-build-webkit so such lines are marked
19         as plain.
20
21         * Scripts/filter-build-webkit:
22         * Scripts/generate-xcfilelists:
23
24 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
25
26         pytest is not correctly auto-installed
27         https://bugs.webkit.org/show_bug.cgi?id=194707
28
29         Reviewed by Carlos Garcia Campos.
30
31         * Scripts/webkitpy/thirdparty/__init__.py:
32         (AutoinstallImportHook._install_pytest):
33
34 2019-02-18  Chris Dumez  <cdumez@apple.com>
35
36         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
37         https://bugs.webkit.org/show_bug.cgi?id=194797
38         <rdar://problem/48055151>
39
40         Reviewed by Geoffrey Garen.
41
42         Add API test coverage.
43
44         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
45
46 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
47
48         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
49         https://bugs.webkit.org/show_bug.cgi?id=194670
50         <rdar://problem/39066529>
51
52         Reviewed by Tim Horton.
53
54         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
55         pasted in an editable area as attachment elements.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
58         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
59         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
60         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
61         (TestWebKitAPI::TEST):
62         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
63         (WTR::InjectedBundlePage::InjectedBundlePage):
64
65 2019-02-18  Alex Christensen  <achristensen@webkit.org>
66
67         Fix API test after r241728
68        ​https://bugs.webkit.org/show_bug.cgi?id=194723
69
70         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
71         (TEST):
72         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
73
74 2019-02-18  Daniel Bates  <dabates@apple.com>
75
76         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
77         https://bugs.webkit.org/show_bug.cgi?id=192824
78         <rdar://problem/47100332>
79
80         Reviewed by Wenson Hsieh.
81
82         Fix a bug where the wrong usage code was used for F13 thru F24.
83
84         * WebKitTestRunner/ios/HIDEventGenerator.mm:
85         (keyCodeForDOMFunctionKey):
86
87 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
88
89         Bytecode cache should a have a boot-specific validation
90         https://bugs.webkit.org/show_bug.cgi?id=194769
91         <rdar://problem/48149509>
92
93         Reviewed by Keith Miller.
94
95         Add test for WTF::bootSessionUUIDString()
96
97         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
98         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
99         (TEST):
100
101 2019-02-18  Alex Christensen  <achristensen@webkit.org>
102
103         Disable safe browsing in WKWebView and remove its WKPreferences API
104         https://bugs.webkit.org/show_bug.cgi?id=194723
105         <rdar://problem/48122993>
106
107         Reviewed by Geoffrey Garen.
108
109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
110         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
111         (TEST):
112         (safeBrowsingView):
113         Make tests use SPI instead of API.
114
115 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
116
117         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
118         https://bugs.webkit.org/show_bug.cgi?id=194586
119
120         Reviewed by Ross Kirsling.
121
122         * DumpRenderTree/win/DumpRenderTree.cpp:
123         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
124         * Scripts/webkitpy/port/driver.py:
125         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
126
127 2019-02-17  David Kilzer  <ddkilzer@apple.com>
128
129         Unreviewed, rolling out r241620.
130
131         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
132         (Requested by ddkilzer on #webkit.)
133
134         Reverted changeset:
135
136         "[WTF] Add environment variable helpers"
137         https://bugs.webkit.org/show_bug.cgi?id=192405
138         https://trac.webkit.org/changeset/241620
139
140 2019-02-16  Zalan Bujtas  <zalan@apple.com>
141
142         [LFC] RenderImage's default intrinsic size is 0.
143         https://bugs.webkit.org/show_bug.cgi?id=194745
144
145         Reviewed by Antti Koivisto.
146
147         * LayoutReloaded/misc/LFC-passing-tests.txt:
148
149 2019-02-16  Zalan Bujtas  <zalan@apple.com>
150
151         [LFC][BFC] Add support for block replaced intrinsic width.
152         https://bugs.webkit.org/show_bug.cgi?id=194705
153
154         Reviewed by Simon Fraser.
155
156         * LayoutReloaded/misc/LFC-passing-tests.txt:
157
158 2019-02-16  Zalan Bujtas  <zalan@apple.com>
159
160         [LFC] Apply min/max width constraints to preferred width computation
161         https://bugs.webkit.org/show_bug.cgi?id=194739
162
163         Reviewed by Simon Fraser.
164
165         * LayoutReloaded/misc/LFC-passing-tests.txt:
166
167 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
168
169         [WTF] Add environment variable helpers
170         https://bugs.webkit.org/show_bug.cgi?id=192405
171
172         Reviewed by Michael Catanzaro.
173
174         * DumpRenderTree/mac/DumpRenderTree.mm:
175         (libraryPathForDumpRenderTree):
176         * DumpRenderTree/win/DumpRenderTree.cpp:
177         (libraryPathForDumpRenderTree):
178         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
179         (setUpIOSLayoutTestCommunication):
180         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
181         (beforeAll):
182         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
183         (main):
184         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
185         (WebKitTestBus::run):
186         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
187         (WTR::getOutputDir):
188         (WTR::initializeFontConfigSetting):
189         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
190         (WTR::InjectedBundle::platformInitialize):
191         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
192         (WTR::topLevelPath):
193         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
194         (WTR::topLevelPath):
195         (WTR::getOutputDir):
196         (WTR::activateFonts):
197         * WebKitTestRunner/TestController.cpp:
198         (WTR::TestController::libraryPathForTesting):
199         (WTR::TestController::generateContextConfiguration const):
200         (WTR::TestController::generatePageConfiguration):
201         (WTR::TestController::decideDestinationWithSuggestedFilename):
202         (WTR::TestController::platformAdjustContext):
203         * WebKitTestRunner/TestController.h:
204         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
205         (WTR::TestController::cocoaPlatformInitialize):
206         (WTR::TestController::platformAdjustContext):
207         * WebKitTestRunner/gtk/main.cpp:
208         (main):
209         * WebKitTestRunner/mac/TestControllerMac.mm:
210         (WTR::TestController::configureContentExtensionForTest):
211         * WebKitTestRunner/wpe/main.cpp:
212         (main):
213         Utilize WTF::Environment where possible.
214
215 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
216
217         [iOS] WKWebView callout bar is missing Change Writing Direction item
218         https://bugs.webkit.org/show_bug.cgi?id=190015
219         <rdar://problem/44810366>
220
221         Reviewed by Tim Horton.
222
223         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
224         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
225
226         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
227         (TestWebKitAPI::TEST):
228
229 2019-02-15  Chris Dumez  <cdumez@apple.com>
230
231         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
232         https://bugs.webkit.org/show_bug.cgi?id=194717
233         <rdar://problem/47884404>
234
235         Reviewed by Brady Eidson.
236
237         Add API test coverage.
238
239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
240
241 2019-02-15  Youenn Fablet  <youenn@apple.com>
242
243         Make navigator.mediaDevices SecureContext
244         https://bugs.webkit.org/show_bug.cgi?id=194666
245
246         Reviewed by Eric Carlson.
247
248         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
249         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
250         (TEST_F):
251
252 2019-02-15  Brian Burg  <bburg@apple.com>
253
254         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
255         https://bugs.webkit.org/show_bug.cgi?id=194411
256         <rdar://problem/47787614>
257
258         Reviewed by Joseph Pecoraro.
259
260         Remove unnecessary soft linking macro usage.
261
262         * DumpRenderTree/mac/TestRunnerMac.mm:
263         (TestRunner::inspectorTestStubURL):
264         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
265         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
266         (WTR::TestRunner::inspectorTestStubURL):
267
268 2019-02-15  Commit Queue  <commit-queue@webkit.org>
269
270         Unreviewed, rolling out r241559 and r241566.
271         https://bugs.webkit.org/show_bug.cgi?id=194710
272
273         Causes layout test crashes under GuardMalloc (Requested by
274         ryanhaddad on #webkit).
275
276         Reverted changesets:
277
278         "[WTF] Add environment variable helpers"
279         https://bugs.webkit.org/show_bug.cgi?id=192405
280         https://trac.webkit.org/changeset/241559
281
282         "Unreviewed build fix for WinCairo Debug after r241559."
283         https://trac.webkit.org/changeset/241566
284
285 2019-02-15  Zalan Bujtas  <zalan@apple.com>
286
287         [LFC] Out-of-flow box is never a float box
288         https://bugs.webkit.org/show_bug.cgi?id=194704
289
290         Reviewed by Antti Koivisto.
291
292         * LayoutReloaded/misc/LFC-passing-tests.txt:
293
294 2019-02-10  Darin Adler  <darin@apple.com>
295
296         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
297         https://bugs.webkit.org/show_bug.cgi?id=194487
298
299         Reviewed by Daniel Bates.
300
301         * DumpRenderTree/win/DumpRenderTree.cpp:
302         (applicationId): Use makeString instead of String::format.
303         (main): Ditto.
304         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
305         (TestWebKitAPI::Util::createURLForResource): Ditto.
306         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
307         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
308
309         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
310         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
311         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
312         (WTR::createStringWithAttributes): Use appendLiteral.
313         (WTR::AccessibilityUIElement::helpText const): Ditto.
314         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
315         directly instead of using String::format.
316         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
317         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
318
319 2019-02-15  Truitt Savell  <tsavell@apple.com>
320
321         Unreviewed, rolling out r241564.
322
323         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
324
325         Reverted changeset:
326
327         "[Mac] WebInspectorUI.framework does not need to be soft-
328         linked anymore"
329         https://bugs.webkit.org/show_bug.cgi?id=194411
330         https://trac.webkit.org/changeset/241564
331
332 2019-02-15  Saam barati  <sbarati@apple.com>
333
334         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
335         https://bugs.webkit.org/show_bug.cgi?id=194036
336
337         Reviewed by Yusuke Suzuki.
338
339         * Scripts/run-jsc-stress-tests:
340
341 2019-02-14  Tim Horton  <timothy_horton@apple.com>
342
343         Fix the build.
344
345         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
346         (WTR::UIScriptController::drawSquareInEditableImage):
347         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
348         (TestWebKitAPI::drawSquareInEditableImage):
349
350 2019-02-14  Tim Horton  <timothy_horton@apple.com>
351
352         Fix the build.
353
354         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
355         (WTR::UIScriptController::drawSquareInEditableImage):
356         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
357         (TestWebKitAPI::drawSquareInEditableImage):
358
359 2019-02-14  Brian Burg  <bburg@apple.com>
360
361         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
362         https://bugs.webkit.org/show_bug.cgi?id=194411
363         <rdar://problem/47787614>
364
365         Reviewed by Joseph Pecoraro.
366
367         Remove unnecessary soft linking macro usage.
368
369         * DumpRenderTree/mac/TestRunnerMac.mm:
370         (TestRunner::inspectorTestStubURL):
371         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
372         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
373         (WTR::TestRunner::inspectorTestStubURL):
374
375 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
376
377         [ews-app] status bubble should fetch builder name info from BuilderMapping table
378         https://bugs.webkit.org/show_bug.cgi?id=194599
379
380         Reviewed by Lucas Forschler.
381
382         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
383         (StatusBubble._build_bubble):
384
385 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
386
387         [ews-app] Set Foreign Key in Django build model
388         https://bugs.webkit.org/show_bug.cgi?id=194667
389
390         Reviewed by Lucas Forschler.
391
392         * BuildSlaveSupport/ews-app/ews/models/build.py:
393         (Build):
394
395 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
396
397         [WTF] Add environment variable helpers
398         https://bugs.webkit.org/show_bug.cgi?id=192405
399
400         Reviewed by Michael Catanzaro.
401
402         * DumpRenderTree/mac/DumpRenderTree.mm:
403         (libraryPathForDumpRenderTree):
404         * DumpRenderTree/win/DumpRenderTree.cpp:
405         (libraryPathForDumpRenderTree):
406         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
407         (setUpIOSLayoutTestCommunication):
408         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
409         (TestWebKitAPI::strip):
410         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
411         (beforeAll):
412         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
413         (main):
414         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
415         (WebKitTestBus::run):
416         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
417         (WTR::getOutputDir):
418         (WTR::initializeFontConfigSetting):
419         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
420         (WTR::InjectedBundle::platformInitialize):
421         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
422         (WTR::topLevelPath):
423         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
424         (WTR::topLevelPath):
425         (WTR::getOutputDir):
426         (WTR::activateFonts):
427         * WebKitTestRunner/TestController.cpp:
428         (WTR::TestController::libraryPathForTesting):
429         (WTR::TestController::generateContextConfiguration const):
430         (WTR::TestController::generatePageConfiguration):
431         (WTR::TestController::decideDestinationWithSuggestedFilename):
432         (WTR::TestController::platformAdjustContext):
433         * WebKitTestRunner/TestController.h:
434         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
435         (WTR::TestController::cocoaPlatformInitialize):
436         (WTR::TestController::platformAdjustContext):
437         * WebKitTestRunner/gtk/main.cpp:
438         (main):
439         * WebKitTestRunner/mac/TestControllerMac.mm:
440         (WTR::TestController::configureContentExtensionForTest):
441         * WebKitTestRunner/wpe/main.cpp:
442         (main):
443         Utilize WTF::Environment where possible.
444
445 2019-02-14  Chris Dumez  <cdumez@apple.com>
446
447         [PSON] Introduce a WebContent Process cache
448         https://bugs.webkit.org/show_bug.cgi?id=194594
449         <rdar://problem/46793397>
450
451         Reviewed by Geoff Garen.
452
453         Update API tests to turn on the WebContent Process cache.
454
455         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
456
457 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
458
459         Unreviewed, build fix after r241480
460
461         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
462         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
463         (-[DragAndDropSimulator initWithWebView:]):
464
465 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
466
467         AX: ARIA Reflection was disabled in error
468         https://bugs.webkit.org/show_bug.cgi?id=194647
469         <rdar://problem/48068336>
470
471         Reviewed by Ryosuke Niwa.
472
473         Remove test override now that this feature should be enabled by default.
474
475         * WebKitTestRunner/TestController.cpp:
476         (WTR::TestController::resetPreferencesToConsistentValues):
477
478 2019-02-14  Commit Queue  <commit-queue@webkit.org>
479
480         Unreviewed, rolling out r241486.
481         https://bugs.webkit.org/show_bug.cgi?id=194655
482
483         causing API failures in builds (Requested by ShawnRoberts on
484         #webkit).
485
486         Reverted changeset:
487
488         "[Cocoa] Media elements will restart network buffering just
489         before suspending"
490         https://bugs.webkit.org/show_bug.cgi?id=193691
491         https://trac.webkit.org/changeset/241486
492
493 2019-02-14  Zalan Bujtas  <zalan@apple.com>
494
495         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
496         https://bugs.webkit.org/show_bug.cgi?id=194622
497
498         Reviewed by Antti Koivisto.
499
500         * LayoutReloaded/misc/LFC-passing-tests.txt:
501
502 2019-02-14  Zalan Bujtas  <zalan@apple.com>
503
504         [LFC] Shrink-to-fit-width should be constrained by min/max width
505         https://bugs.webkit.org/show_bug.cgi?id=194653
506
507         Reviewed by Antti Koivisto.
508
509         * LayoutReloaded/misc/LFC-passing-tests.txt:
510
511 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
512
513         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
514         https://bugs.webkit.org/show_bug.cgi?id=194641
515
516         Reviewed by Geoffrey Garen.
517
518         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
519         so that the test would fail without this fix.
520
521         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
522         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
523
524 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
525
526         [ews-app] Change log level for a log statement
527
528         Unreviewed minor fix.
529
530         * BuildSlaveSupport/ews-app/ews/models/patch.py:
531         (Patch.save_patch):
532
533 2019-02-13  Jer Noble  <jer.noble@apple.com>
534
535         [Cocoa] Media elements will restart network buffering just before suspending
536         https://bugs.webkit.org/show_bug.cgi?id=193691
537
538         Reviewed by Eric Carlson.
539
540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
541         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
542         (TEST):
543
544 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
545
546         [ews-app] Fetch builder id to name mapping
547         https://bugs.webkit.org/show_bug.cgi?id=194355
548
549         Reviewed by Lucas Forschler.
550
551         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
552         (Buildbot.get_builder_id_to_name_mapping):
553         (Buildbot._get_display_name_from_builder_name):
554
555 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
556
557         Further restricting webarchive loads
558         https://bugs.webkit.org/show_bug.cgi?id=194567
559         <rdar://problem/47610130>
560
561         Reviewed by Youenn Fablet.
562
563         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
564         navigations on drop.
565
566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
567         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
568         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
569         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
570         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
571         (TestWebKitAPI::TEST):
572         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
573         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
574         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
575         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
576         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
577         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
578         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
579
580 2019-02-13  John Wilander  <wilander@apple.com>
581
582         Store Ad Click Attribution requests in the network process
583         https://bugs.webkit.org/show_bug.cgi?id=194510
584         <rdar://problem/47650118>
585
586         Reviewed by Alex Christensen and Daniel Bates.
587
588         This patch adds two TestRunner functions:
589         - dumpAdClickAttribution()
590         - clearAdClickAttribution()
591
592         They call into the network process to dump and clear Ad Click
593         Attribution state, respectively.
594
595         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
597         (WTR::TestRunner::dumpAdClickAttribution):
598         (WTR::TestRunner::clearAdClickAttribution):
599         * WebKitTestRunner/InjectedBundle/TestRunner.h:
600         * WebKitTestRunner/TestController.cpp:
601         (WTR::TestController::resetStateToConsistentValues):
602         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
603         (WTR::adClickAttributionStringResultCallback):
604         (WTR::TestController::dumpAdClickAttribution):
605         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
606         (WTR::adClickAttributionVoidCallback):
607         (WTR::TestController::clearAdClickAttribution):
608         * WebKitTestRunner/TestController.h:
609         * WebKitTestRunner/TestInvocation.cpp:
610         (WTR::TestInvocation::dumpResults):
611         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
612         (WTR::TestInvocation::dumpAdClickAttribution):
613         * WebKitTestRunner/TestInvocation.h:
614
615 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
616
617         [ews-app] Generate status-bubble
618         https://bugs.webkit.org/show_bug.cgi?id=194572
619
620         Reviewed by Lucas Forschler.
621
622         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
623         (StatusBubble._build_bubble):
624         (StatusBubble._should_show_bubble_for):
625         (StatusBubble._build_bubbles_for_patch):
626
627 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
628
629         [ews-app] Add status bubble html template
630         https://bugs.webkit.org/show_bug.cgi?id=194571
631
632         Reviewed by Lucas Forschler.
633
634         * BuildSlaveSupport/ews-app/ews/templates: Added.
635         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
636
637 2019-02-12  Chris Dumez  <cdumez@apple.com>
638
639         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
640         https://bugs.webkit.org/show_bug.cgi?id=194568
641         <rdar://problem/47944490>
642
643         Reviewed by Ryosuke Niwa.
644
645         Add API test coverage.
646
647         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
648         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
649
650 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
651
652         webkitpy: Remove bug_dummy from parsed test expectations
653         https://bugs.webkit.org/show_bug.cgi?id=194562
654         <rdar://problem/47853999>
655
656         Reviewed by Lucas Forschler.
657
658         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
659         (TestExpectationParser):
660         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
661         skipped tests.
662         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
663
664 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
665
666         [ews-app] Add method to fetch patch
667         https://bugs.webkit.org/show_bug.cgi?id=194518
668
669         Reviewed by Lucas Forschler.
670
671         * BuildSlaveSupport/ews-app/ews/models/patch.py:
672         (Patch.get_patch):
673
674 2019-02-12  Zalan Bujtas  <zalan@apple.com>
675
676         [LFC] Expand tests coverage (60 new tests -> 860)
677
678         Unreviewed test gardening (run-singly, --child-processes=1).
679
680         * LayoutReloaded/misc/LFC-passing-tests.txt:
681
682 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
683
684         Allow pages to trigger programmatic paste from script on iOS
685         https://bugs.webkit.org/show_bug.cgi?id=194271
686         <rdar://problem/47808810>
687
688         Reviewed by Tim Horton.
689
690         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
691
692         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
693         (WTR::UIScriptController::platformSetDidShowMenuCallback):
694         (WTR::UIScriptController::platformSetDidHideMenuCallback):
695         (WTR::UIScriptController::rectForMenuAction const):
696
697         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
698         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
699         for when the menu is shown or hidden.
700
701         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
702         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
703         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
704         (WTR::UIScriptController::setDidShowMenuCallback):
705         (WTR::UIScriptController::didShowMenuCallback const):
706         (WTR::UIScriptController::setDidHideMenuCallback):
707         (WTR::UIScriptController::didHideMenuCallback const):
708         (WTR::UIScriptController::platformSetDidShowMenuCallback):
709         (WTR::UIScriptController::platformSetDidHideMenuCallback):
710         (WTR::UIScriptController::rectForMenuAction const):
711         * TestRunnerShared/UIScriptContext/UIScriptController.h:
712         * WebKitTestRunner/TestController.cpp:
713         (WTR::TestController::resetPreferencesToConsistentValues):
714         (WTR::updateTestOptionsFromTestHeader):
715         * WebKitTestRunner/TestOptions.h:
716
717         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
718         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
719
720         (WTR::TestOptions::hasSameInitializationOptions const):
721         * WebKitTestRunner/UIScriptControllerCocoa.mm:
722         (WTR::UIScriptController::calendarType const):
723         (WTR::UIScriptController::platformUndoManager const):
724         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
725         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
726         (-[TestRunnerWKWebView initWithFrame:configuration:]):
727         (-[TestRunnerWKWebView dealloc]):
728         (-[TestRunnerWKWebView _didShowMenu]):
729         (-[TestRunnerWKWebView _didHideMenu]):
730
731         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
732
733         * WebKitTestRunner/ios/TestControllerIOS.mm:
734         (WTR::handleMenuWillHideNotification):
735         (WTR::handleMenuDidHideNotification):
736         (WTR::TestController::platformInitialize):
737         (WTR::TestController::platformDestroy):
738         (WTR::TestController::platformResetStateToConsistentValues):
739
740         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
741         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
742
743         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
744         (WTR::forEachViewInHierarchy):
745         (WTR::findViewInHierarchyOfType):
746
747         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
748         functions that dig through a given view's hierarchy in search of a view of a given class.
749
750         (WTR::UIScriptController::selectionStartGrabberViewRect const):
751         (WTR::UIScriptController::selectionEndGrabberViewRect const):
752         (WTR::UIScriptController::selectionCaretViewRect const):
753         (WTR::UIScriptController::selectionRangeViewRects const):
754         (WTR::UIScriptController::platformSetDidShowMenuCallback):
755         (WTR::UIScriptController::platformSetDidHideMenuCallback):
756
757         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
758
759         (WTR::UIScriptController::rectForMenuAction const):
760
761         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
762         callout bar) whose label matches the given string.
763
764         (WTR::UIScriptController::platformContentView const):
765
766         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
767         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
768         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
769
770         (WTR::UIScriptController::platformUndoManager const): Deleted.
771         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
772         (WTR::UIScriptController::platformContentView const):
773         (WTR::UIScriptController::platformUndoManager const): Deleted.
774
775 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
776
777         webkitpy: No option to only show unexpected failures in results.html for iPad
778         https://bugs.webkit.org/show_bug.cgi?id=194554
779         <rdar://problem/47922442>
780
781         Rubber-stamped by Aakash Jain.
782
783         Just because a TestExpecations file does not exist for a specific platform does not mean that
784         TestExpecations are not being used, given that platforms inherit test expectations.
785
786         * Scripts/webkitpy/port/base.py:
787         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
788         * Scripts/webkitpy/port/base_unittest.py:
789         (PortTest.test_uses_test_expectations_file):
790
791 2019-02-12  Alex Christensen  <achristensen@webkit.org>
792
793         Remove setDefersLoading infrastructure from WebKit2
794         https://bugs.webkit.org/show_bug.cgi?id=194506
795
796         Reviewed by Brady Eidson.
797
798         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
800         (WTR::TestRunner::setDefersLoading): Deleted.
801         * WebKitTestRunner/InjectedBundle/TestRunner.h:
802
803 2019-02-12  Alex Christensen  <achristensen@webkit.org>
804
805         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
806         https://bugs.webkit.org/show_bug.cgi?id=194522
807         <rdar://problem/47789393>
808
809         Reviewed by Chris Dumez.
810
811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
812         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
813         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
814         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
815
816 2019-02-12  Andy Estes  <aestes@apple.com>
817
818         [iOSMac] Enable Parental Controls Content Filtering
819         https://bugs.webkit.org/show_bug.cgi?id=194521
820         <rdar://39732376>
821
822         Reviewed by Tim Horton.
823
824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
825
826 2019-02-12  Zalan Bujtas  <zalan@apple.com>
827
828         [LFC][IFC] Add intrinsic width support for float boxes.
829         https://bugs.webkit.org/show_bug.cgi?id=194528
830
831         Reviewed by Antti Koivisto.
832
833         Expand tests coverage (2 new tests -> 800).
834         (This is the correct test ordering --runs-singly --child-processes=1)
835
836         * LayoutReloaded/misc/LFC-passing-tests.txt:
837
838 2019-02-12  Rob Buis  <rbuis@igalia.com>
839
840         Implement serializing in MIME type parser
841         https://bugs.webkit.org/show_bug.cgi?id=193909
842
843         Reviewed by Darin Adler.
844
845         Add various tests involving upper case, non-ASCII, control/null characters,
846         various HTTP whitespace, single quotes and an unpaired surrogate.
847
848         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
849         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
850         (TestWebKitAPI::serializeIfValid):
851         (TestWebKitAPI::TEST):
852
853 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
854
855         [Cocoa] Ask platform for generic font family mappings
856         https://bugs.webkit.org/show_bug.cgi?id=187723
857         <rdar://problem/41892438>
858
859         Reviewed by Brent Fulgham.
860
861         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
862
863         * DumpRenderTree/mac/DumpRenderTree.mm:
864         (allowedFontFamilySet):
865         * WebKitTestRunner/mac/TestControllerMac.mm:
866         (WTR::allowedFontFamilySet):
867
868 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
869
870         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
871         https://bugs.webkit.org/show_bug.cgi?id=193622
872
873         Reviewed by Michael Catanzaro.
874
875         This adds support for loading content extension rule sets from the JSON files which
876         accompany the corresponding layout test, using the C API. The Cocoa specific parts
877         of WKTR for this could be removed, but that is left for a follow-up patch with
878         cleanups.
879
880         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
881         * WebKitTestRunner/TestController.cpp:
882         (WTR::testPath): Subtract one from the length when constructing the result std::string to
883         avoid having the null-terminator copied into the result.
884         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
885         part of the preparations to run a test.
886         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
887         (WTR::contentExtensionStoreCallback): Added.
888         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
889         used for content extensions test.
890         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
891         extensions and compiling the JSON rule set for tests involving content extensions.
892         (WTR::TestController::resetContentExtensions): Removes the content extension built for
893         testing and disables content extensions.
894         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
895         resetContentExtensions().
896         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
897         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
898         configureContentExtensionForTest(), and userContentController().
899
900 2019-02-11  Daniel Bates  <dabates@apple.com>
901
902         [iOS] Mouse/Touch/Pointer events are missing modifier keys
903         https://bugs.webkit.org/show_bug.cgi?id=191446
904         <rdar://problem/45929460>
905
906         Reviewed by Tim Horton.
907
908         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
909
910         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
911         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
912         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
913         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
914         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
915         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
916         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
917         * TestRunnerShared/UIScriptContext/UIScriptController.h:
918         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
919         (WTR::arrayLength):
920         (WTR::parseModifierArray):
921         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
922         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
923         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
924         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
925
926 2019-02-11  Commit Queue  <commit-queue@webkit.org>
927
928         Unreviewed, rolling out r241272 and r241276.
929         https://bugs.webkit.org/show_bug.cgi?id=194514
930
931         Broke the Apple Internal build and the fix requires human
932         intervention :( (Requested by dydz on #webkit).
933
934         Reverted changesets:
935
936         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
937         https://bugs.webkit.org/show_bug.cgi?id=191446
938         https://trac.webkit.org/changeset/241272
939
940         "Fix internal iOS build after r241272"
941         https://bugs.webkit.org/show_bug.cgi?id=191446
942         https://trac.webkit.org/changeset/241276
943
944 2019-02-11  Truitt Savell  <tsavell@apple.com>
945
946         Unreviewed, rolling out r241269.
947
948         Caused 5 layout tests crashes on Mac WK1
949
950         Reverted changeset:
951
952         "DumpRenderTree should report unknown options"
953         https://bugs.webkit.org/show_bug.cgi?id=191303
954         https://trac.webkit.org/changeset/241269
955
956 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
957
958         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
959         https://bugs.webkit.org/show_bug.cgi?id=194313
960
961         Reviewed by Tim Horton.
962
963         Add a helper to determine whether the web view is presenting modal UI.
964
965         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
966         (WTR::UIScriptController::isPresentingModally const):
967         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
968         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
969         (WTR::UIScriptController::isPresentingModally const):
970         * TestRunnerShared/UIScriptContext/UIScriptController.h:
971         * WebKitTestRunner/UIScriptControllerCocoa.mm:
972         (WTR::UIScriptController::calendarType const): Deleted.
973         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
974         (WTR::UIScriptController::isPresentingModally const):
975         (WTR::UIScriptController::calendarType const):
976         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
977         (WTR::UIScriptController::calendarType const):
978
979 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
980
981         GCHeapInspector: Show the retained sizes in more places
982         https://bugs.webkit.org/show_bug.cgi?id=194464
983
984         Reviewed by Simon Fraser.
985
986         * GCHeapInspector/gc-heap-inspector.html:
987         * GCHeapInspector/script/interface.js:
988         (HeapInspectorUtils.humanReadableSize):
989         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
990         (HeapInspectorUtils.spanForNode.span.span):
991         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
992         (HeapSnapshotInspector.prototype.buildRoots):
993
994 2019-02-11  Daniel Bates  <dabates@apple.com>
995
996         [iOS] Mouse/Touch/Pointer events are missing modifier keys
997         https://bugs.webkit.org/show_bug.cgi?id=191446
998         <rdar://problem/45929460>
999
1000         Reviewed by Tim Horton.
1001
1002         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1003
1004         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1005         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1006         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1007         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1008         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1009         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1010         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1011         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1012         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1013         (WTR::arrayLength):
1014         (WTR::parseModifierArray):
1015         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1016         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1017         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1018         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1019
1020 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1021
1022         DumpRenderTree should report unknown options
1023         https://bugs.webkit.org/show_bug.cgi?id=191303
1024
1025         Reviewed by Frédéric Wang.
1026
1027         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1028         to report unknown options.
1029         Added and assigned test options which are currently used in tests.
1030
1031         * DumpRenderTree/TestOptions.cpp:
1032         (TestOptions::TestOptions):
1033
1034 2019-02-11  Truitt Savell  <tsavell@apple.com>
1035
1036         Unreviewed, rolling out r241229.
1037
1038         Revision broke internal builds for watchOS.
1039
1040         Reverted changeset:
1041
1042         "[Cocoa] Ask platform for generic font family mappings"
1043         https://bugs.webkit.org/show_bug.cgi?id=187723
1044         https://trac.webkit.org/changeset/241229
1045
1046 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1047
1048         [WinCairo][MiniBrowser] Basic authentication always fails.
1049         https://bugs.webkit.org/show_bug.cgi?id=194496
1050
1051         Reviewed by Don Olmstead.
1052
1053         * MiniBrowser/win/DialogHelper.h:
1054         (Dialog::getText):
1055
1056 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1057
1058         [GStreamer] GstMappedBuffer testsuite build fails
1059         https://bugs.webkit.org/show_bug.cgi?id=194495
1060
1061         Reviewed by Carlos Garcia Campos.
1062
1063         Fix the build by explicitely adding the gstreamer1.0-audio include
1064         directories to the include path.
1065
1066         * TestWebKitAPI/PlatformGTK.cmake:
1067         * TestWebKitAPI/PlatformWPE.cmake:
1068
1069 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1070
1071         [GTK][WPE] Add enable-javascript-markup setting
1072         https://bugs.webkit.org/show_bug.cgi?id=193439
1073
1074         Reviewed by Michael Catanzaro.
1075
1076         Add test cases to check the new setting.
1077
1078         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1079         (testWebKitSettings):
1080         (testWebKitSettingsJavaScriptMarkup):
1081         (beforeAll):
1082
1083 2019-02-10  Darin Adler  <darin@apple.com>
1084
1085         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1086         https://bugs.webkit.org/show_bug.cgi?id=194485
1087
1088         Reviewed by Daniel Bates.
1089
1090         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1091
1092 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1093
1094         Add more tests for clampTo<>()
1095         https://bugs.webkit.org/show_bug.cgi?id=194462
1096
1097         Reviewed by Geoffrey Garen.
1098
1099         Darin suggested to test the very last floating point number
1100         at the boundaries when truncating to integer.
1101         I added test for max/min and max-1/min-1.
1102
1103         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1104         (TestWebKitAPI::TEST):
1105
1106 2019-02-09  Darin Adler  <darin@apple.com>
1107
1108         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1109         https://bugs.webkit.org/show_bug.cgi?id=194021
1110
1111         Reviewed by Geoffrey Garen.
1112
1113         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1114         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1115         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1116
1117 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1118
1119         [LFC][IFC] Add intrinsic width support for basic inline containers
1120         https://bugs.webkit.org/show_bug.cgi?id=194473
1121
1122         Reviewed by Antti Koivisto.
1123
1124         Expand tests coverage (11 new tests -> 798)
1125
1126         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1127
1128 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1129
1130         Fix MiniBrowser's entitlements
1131         https://bugs.webkit.org/show_bug.cgi?id=192431
1132
1133         Reviewed by Joseph Pecoraro.
1134
1135         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1136         files, making it impossible to load any extension.
1137
1138         * MiniBrowser/MiniBrowser.entitlements:
1139
1140 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1141
1142         [Cocoa] Ask platform for generic font family mappings
1143         https://bugs.webkit.org/show_bug.cgi?id=187723
1144         <rdar://problem/41892438>
1145
1146         Reviewed by Brent Fulgham.
1147
1148         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1149
1150         * DumpRenderTree/mac/DumpRenderTree.mm:
1151         (allowedFontFamilySet):
1152         * WebKitTestRunner/mac/TestControllerMac.mm:
1153         (WTR::allowedFontFamilySet):
1154
1155 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1156
1157         [GTK] Implement back/forward touchpad gesture
1158         https://bugs.webkit.org/show_bug.cgi?id=193919
1159
1160         Reviewed by Michael Catanzaro.
1161
1162         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1163         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1164
1165 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1166
1167         Add SPI to use networking daemon instead of XPC service
1168         https://bugs.webkit.org/show_bug.cgi?id=194427
1169
1170         Reviewed by Geoffrey Garen
1171
1172         * MiniBrowser/MiniBrowser.entitlements:
1173
1174 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1175
1176         [ews-build] Ensure that every builder in config.json has short name
1177         https://bugs.webkit.org/show_bug.cgi?id=194461
1178
1179         Reviewed by Lucas Forschler.
1180
1181         * BuildSlaveSupport/ews-build/loadConfig.py:
1182         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1183
1184 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1185
1186         [ews-build] Add short name to config.json
1187         https://bugs.webkit.org/show_bug.cgi?id=194456
1188
1189         Reviewed by Lucas Forschler.
1190
1191         * BuildSlaveSupport/ews-build/config.json: Added short name.
1192         * BuildSlaveSupport/ews-build/loadConfig.py:
1193         (loadBuilderConfig): Set the short name as the builder description.
1194
1195 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1196
1197         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1198         https://bugs.webkit.org/show_bug.cgi?id=194418
1199
1200         Reviewed by Lucas Forschler.
1201
1202         Do not include errors trying when finding crashlogs at the end of
1203         a run-webkit-tests run since we don't process those errors.
1204
1205         * Scripts/webkitpy/port/darwin.py:
1206         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1207         * Scripts/webkitpy/port/ios_device.py:
1208         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1209         * Scripts/webkitpy/port/watch_device.py:
1210         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1211
1212 2019-02-08  Beth Dakin  <bdakin@apple.com>
1213
1214         Add afterScreenUpdates to WKSnapshotConfiguration
1215         https://bugs.webkit.org/show_bug.cgi?id=194362
1216         -and corresponding-
1217         <rdar://problem/40655528> Please add an "after screen updates" property to 
1218         WKSnapshotConfiguration (to solve blank snapshots)
1219
1220         Reviewed by Tim Horton.
1221
1222         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1223         (TEST):
1224
1225 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1226
1227         clampTo(): do not convert the input to double when dealing with integers
1228         https://bugs.webkit.org/show_bug.cgi?id=194263
1229         <rdar://problem/47692312>
1230
1231         Reviewed by Darin Adler.
1232
1233         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1234         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1235         (TestWebKitAPI::testClampFloatingPointToInteger):
1236         (TestWebKitAPI::testClampSameSignIntegers):
1237         (TestWebKitAPI::testClampUnsignedToSigned):
1238         (TestWebKitAPI::testClampSignedToUnsigned):
1239
1240 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1241
1242         webkitpy: Respect --dedicated-simulators flag
1243         https://bugs.webkit.org/show_bug.cgi?id=194416
1244         <rdar://problem/47894722>
1245
1246         Reviewed by Lucas Forschler.
1247
1248         * Scripts/webkitpy/port/device_port.py:
1249         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1250         available devices can be safely ignored.
1251
1252 2019-02-07  Keith Rollin  <krollin@apple.com>
1253
1254         Remove extra copy of 100x100-red.tga
1255         https://bugs.webkit.org/show_bug.cgi?id=194371
1256         <rdar://problem/47873465>
1257
1258         Reviewed by Said Abou-Hallawa.
1259
1260         In order to help it pass its tests, Bug 194190 added a second copy of
1261         the file 100x100-red.tga. However, it turns out that this additional
1262         file wasn't actually needed, and that that sole previous copy was
1263         sufficient. At the same time, this second copy -- which was copied to
1264         the same location in the build output as the first copy -- now caused
1265         XCBuild to complain because there were two production rules for the
1266         same output file. Address this by removing the newly-added extra copy.
1267
1268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1269         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1270
1271 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1272
1273         Deprecate WKBundlePageSetDefersLoading
1274         https://bugs.webkit.org/show_bug.cgi?id=191394
1275
1276         Reviewed by Dean Jackson.
1277
1278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1279         (WTR::TestRunner::setDefersLoading):
1280
1281 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1282
1283         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1284         https://bugs.webkit.org/show_bug.cgi?id=194391
1285
1286         Reviewed by Antti Koivisto.
1287
1288         * LayoutReloaded/misc/LFC-passing-tests.txt:
1289
1290 2019-02-06  Keith Rollin  <krollin@apple.com>
1291
1292         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1293         https://bugs.webkit.org/show_bug.cgi?id=193975
1294         <rdar://problem/47643306>
1295
1296         Reviewed by Tim Horton.
1297
1298         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1299         the Info.plist file into the bundle. This step is not necessary as the
1300         implicit "bundle up all the build products into a framework" build
1301         phase does this already. Having the Copy Bundle Resources phase do
1302         this causes a conflict under XCBuild, which objects to two build
1303         phases producing the same file (Info.plist). Address this by removing
1304         Info.plist from the Copy Bundle Resources phase.
1305
1306         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1307
1308 2019-02-06  Keith Rollin  <krollin@apple.com>
1309
1310         Really enable the automatic checking and regenerations of .xcfilelists during builds
1311         https://bugs.webkit.org/show_bug.cgi?id=194357
1312         <rdar://problem/47861231>
1313
1314         Reviewed by Chris Dumez.
1315
1316         Bug 194124 was supposed to enable the automatic checking and
1317         regenerating of .xcfilelist files during the build. While related
1318         changes were included in that patch, the change to actually enable the
1319         operation somehow was omitted. This patch actually enables the
1320         operation. The check-xcfilelist.sh scripts now check
1321         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1322         from the checking.
1323
1324         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1325         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1326
1327 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1328
1329         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1330         <https://webkit.org/b/194286>
1331         <rdar://problem/47815558>
1332
1333         Reviewed by Alexey Proskuryakov.
1334
1335         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1336         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1337         WKRetainPtr<> to avoid leaking the WKDataRef.
1338
1339 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1340
1341         Unreviewed, fix a typo
1342
1343         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1344
1345 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1346
1347         [GTK][WPE] force libpsl build to use ICU in jhbuild
1348         https://bugs.webkit.org/show_bug.cgi?id=194288
1349
1350         Reviewed by Carlos Garcia Campos.
1351
1352         * gtk/jhbuild.modules:
1353         Require ICU for libpsl build in jhbuild, like done in WPE.
1354
1355 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1356
1357         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1358         https://bugs.webkit.org/show_bug.cgi?id=194209
1359
1360         Reviewed by Carlos Garcia Campos.
1361
1362         Enhance TestCookieManager to ensure this doesn't happen again.
1363
1364         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1365         (testCookieManagerPersistentStorage):
1366         (beforeAll):
1367
1368 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1369
1370         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1371         https://bugs.webkit.org/show_bug.cgi?id=194324
1372
1373         Reviewed by Andy Estes.
1374
1375         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1376         part of the name is already implicit, since this is in testing code in TestOptions.
1377
1378         * WebKitTestRunner/TestController.cpp:
1379         (WTR::TestController::generateContextConfiguration const):
1380         (WTR::updateTestOptionsFromTestHeader):
1381         * WebKitTestRunner/TestOptions.h:
1382         (WTR::TestOptions::hasSameInitializationOptions const):
1383
1384 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1385
1386         [ews-build] Allow * as platform for builders and workers
1387         https://bugs.webkit.org/show_bug.cgi?id=188533
1388
1389         Reviewed by Lucas Forschler.
1390
1391         * BuildSlaveSupport/ews-build/loadConfig.py:
1392         (checkWorkersAndBuildersForConsistency):
1393
1394 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1395
1396         [ews-build] Add few bots to config.json
1397         https://bugs.webkit.org/show_bug.cgi?id=194304
1398
1399         Reviewed by Lucas Forschler.
1400
1401         * BuildSlaveSupport/ews-build/config.json:
1402
1403 2019-02-05  Keith Rollin  <krollin@apple.com>
1404
1405         Enable the automatic checking and regenerations of .xcfilelists during builds
1406         https://bugs.webkit.org/show_bug.cgi?id=194124
1407         <rdar://problem/47721277>
1408
1409         Reviewed by Tim Horton.
1410
1411         Bug 193790 add a facility for checking -- during build time -- that
1412         any needed .xcfilelist files are up-to-date and for updating them if
1413         they are not. This facility was initially opt-in by setting
1414         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1415         the process seemed robust. Its now time to enable this facility and
1416         make it opt-out. If there is a need to disable this facility, set and
1417         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1418         running `make` or `build-webkit`, or before running Xcode from the
1419         command line.
1420
1421         Additionally, remove the step that generates a list of source files
1422         going into the UnifiedSources build step. It's only necessarily to
1423         specify Sources.txt and SourcesCocoa.txt as inputs.
1424
1425         * Scripts/generate-xcfilelists:
1426
1427 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1428
1429         [GTK][WPE] force libpsl build to use ICU in jhbuild
1430         https://bugs.webkit.org/show_bug.cgi?id=194288
1431
1432         Reviewed by Philippe Normand.
1433
1434         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1435         This can cause build failures if libidn is detected but libunistring is not available.
1436
1437         Make sure that ICU is used for runtime and builtin PSL data.
1438
1439         * gtk/jhbuild.modules:
1440         * wpe/jhbuild.modules:
1441
1442 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1443
1444         [ews-app] Modified timestamp should be updated on updating data
1445         https://bugs.webkit.org/show_bug.cgi?id=194295
1446
1447         Reviewed by Lucas Forschler.
1448
1449         * BuildSlaveSupport/ews-app/ews/models/build.py:
1450         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1451         * BuildSlaveSupport/ews-app/ews/models/step.py:
1452
1453 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1454
1455         Unreviewed, rolling out r240742.
1456
1457         Causes crashes on iOS simulator.
1458
1459         Reverted changeset:
1460
1461         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1462         not focused in a content-editable element"
1463         https://bugs.webkit.org/show_bug.cgi?id=192824
1464         https://trac.webkit.org/changeset/240742
1465
1466 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1467
1468         run-webkit-tests emits message "...running None" when running tests
1469         https://bugs.webkit.org/show_bug.cgi?id=194133
1470         <rdar://problem/47724738>
1471
1472         Reviewed by Lucas Forschler.
1473
1474         * Scripts/webkitpy/xcode/device_type.py:
1475         (DeviceType.__str__): Use both version mapping tables and use just the variant
1476         name if no version name is available.
1477         * Scripts/webkitpy/xcode/device_type_unittest.py:
1478         (DeviceTypeTest):
1479         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1480         an associated named.
1481
1482 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1483
1484         [WPE] require python3-setuptools for meson build in jhbuild
1485         https://bugs.webkit.org/show_bug.cgi?id=194287
1486
1487         Reviewed by Philippe Normand.
1488
1489         python3-setuptools is needed to build meson in jhbuild.
1490         It is already required by the GTK port.
1491
1492         * wpe/install-dependencies:
1493
1494 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1495
1496         [ews-app] Add method to save BuilderMapping to database
1497         https://bugs.webkit.org/show_bug.cgi?id=194264
1498
1499         Reviewed by Lucas Forschler.
1500
1501         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1502         (BuilderMapping.__str__):
1503         (BuilderMapping):
1504         (BuilderMapping.save_mapping):
1505         (BuilderMapping.update_mapping):
1506         (BuilderMapping.get_existing_mapping):
1507         (BuilderMapping.is_valid_mapping):
1508
1509 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1510
1511         [ews-app] Add timestamp fields for BuilderMappings
1512         https://bugs.webkit.org/show_bug.cgi?id=194266
1513
1514         Reviewed by Lucas Forschler.
1515
1516         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1517         (BuilderMapping):
1518
1519 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1520
1521         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1522         https://bugs.webkit.org/show_bug.cgi?id=174816
1523
1524         Reviewed by Michael Catanzaro.
1525
1526         Add tests for webkit_uri_for_display().
1527
1528         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1529         (testURIForDisplayUnaffected):
1530         (testURIForDisplayAffected):
1531         (beforeAll):
1532         (afterAll):
1533         * TestWebKitAPI/glib/CMakeLists.txt:
1534
1535 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1536
1537         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1538         https://bugs.webkit.org/show_bug.cgi?id=194158
1539         <rdar://problem/47737268>
1540
1541         Rubber-stamped by Aakash Jain.
1542
1543         * Scripts/webkitpy/port/device_port.py:
1544         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1545
1546 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1547
1548         [CG] Enable setAdditionalSupportedImageTypes for WK1
1549         https://bugs.webkit.org/show_bug.cgi?id=194190
1550
1551         Reviewed by Tim Horton.
1552
1553         Add a test similar to the one under WebKit Cocoa but make it create a
1554         WebView instead of a WKWebView.
1555
1556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1557         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1558         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1559         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1560         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1561         (TestWebKitAPI::runTest):
1562         (TestWebKitAPI::TEST):
1563
1564 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1565
1566         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1567         https://bugs.webkit.org/show_bug.cgi?id=194168
1568
1569         Reviewed by Simon Fraser.
1570
1571         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1572
1573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1574         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1575         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1576         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1577         (TEST):
1578         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1579         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1580
1581 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1582
1583         REGRESSION (r237269): webkit-patch what-broke is broken 
1584         https://bugs.webkit.org/show_bug.cgi?id=193025
1585
1586         Reviewed by Aakash Jain.
1587
1588         * Scripts/webkitpy/common/host.py:
1589         (Host.buildbot):
1590         (Host.bugzilla): Renamed to 'buildbot'.
1591
1592 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1593
1594         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1595         https://bugs.webkit.org/show_bug.cgi?id=194207
1596
1597         Reviewed by Tim Horton.
1598
1599         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1600         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1601         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1602         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1603         start and delete forwards to remove the original attachment.
1604
1605         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1606         (TestWebKitAPI::TEST):
1607
1608 2019-02-04  Youenn Fablet  <youenn@apple.com>
1609
1610         Capture state should be managed consistently when doing process swapping
1611         https://bugs.webkit.org/show_bug.cgi?id=194122
1612         <rdar://problem/47609293>
1613
1614         Reviewed by Eric Carlson.
1615
1616         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1617         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1618         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1619         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1620         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1621         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1622         (WTR::TestRunner::isDoingMediaCapture const):
1623         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1624         * WebKitTestRunner/TestController.cpp:
1625         (WTR::TestController::isDoingMediaCapture const):
1626         * WebKitTestRunner/TestController.h:
1627         * WebKitTestRunner/TestInvocation.cpp:
1628         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1629         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1630         (WTR::TestController::isDoingMediaCapture const):
1631
1632 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1633
1634         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1635         https://bugs.webkit.org/show_bug.cgi?id=194142
1636
1637         Reviewed by Ross Kirsling.
1638
1639         There three 'separator' variables in TestController.cpp. Renamed
1640         it 'pathSeparator', and unified them.
1641
1642         * WebKitTestRunner/TestController.cpp:
1643         (WTR::TestController::generateContextConfiguration const):
1644         (WTR::createTestURL):
1645         (WTR::TestController::platformAdjustContext):
1646
1647 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1648
1649         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1650         https://bugs.webkit.org/show_bug.cgi?id=194198
1651
1652         Reviewed by Antti Koivisto.
1653
1654         No need to set the banner heights on navigation now, since Page stores them.
1655
1656         * MiniBrowser/mac/WK2BrowserWindowController.m:
1657         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1658
1659 2019-02-03  John Wilander  <wilander@apple.com>
1660
1661         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1662         https://bugs.webkit.org/show_bug.cgi?id=194104
1663         <rdar://problem/47649991>
1664
1665         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1666
1667         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1668         (TestWebKitAPI::TEST):
1669             Changed numeric types from unsigned short to uint32_t.
1670
1671 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1672
1673         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1674         <https://webkit.org/b/194178>
1675         <rdar://problem/47753473>
1676
1677         Reviewed by Alexey Proskuryakov.
1678
1679         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1680         (WTR::uninstallFakeHelvetica): Pass nullptr into
1681         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1682
1683 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1684
1685         [LFC] Initialize ICB's style with fixed width/height.
1686         https://bugs.webkit.org/show_bug.cgi?id=194188
1687
1688         Reviewed by Antti Koivisto.
1689
1690         * LayoutReloaded/misc/LFC-passing-tests.txt:
1691
1692 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1693
1694         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1695         https://bugs.webkit.org/show_bug.cgi?id=194185
1696
1697         Reviewed by Antti Koivisto.
1698
1699         * LayoutReloaded/misc/LFC-passing-tests.txt:
1700
1701 2018-12-16  Darin Adler  <darin@apple.com>
1702
1703         Convert additional String::format clients to alternative approaches
1704         https://bugs.webkit.org/show_bug.cgi?id=192746
1705
1706         Reviewed by Alexey Proskuryakov.
1707
1708         * WebKitTestRunner/TestController.cpp:
1709         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1710         as an intermediate in code that ultimately constructs a WTF::String.
1711         (WTR::userMediaOriginHash): Use makeString.
1712         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1713         (WTR::TestController::didPerformClientRedirect): Ditto.
1714         (WTR::TestController::didPerformServerRedirect): Ditto.
1715         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1716
1717 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1718
1719         [ews-build] Add unit test to verify builder keys
1720         https://bugs.webkit.org/show_bug.cgi?id=194152
1721
1722         Reviewed by Lucas Forschler.
1723
1724         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1725         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1726
1727 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1728
1729         [LFC] Expand tests coverage (12 new tests -> 787)
1730
1731         Unreviewed test gardening.
1732
1733         * LayoutReloaded/misc/LFC-passing-tests.txt:
1734
1735 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1736
1737         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1738         https://bugs.webkit.org/show_bug.cgi?id=194163
1739
1740         Reviewed by Simon Fraser.
1741
1742         775
1743
1744         * LayoutReloaded/misc/LFC-passing-tests.txt:
1745
1746 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1747
1748         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1749         https://bugs.webkit.org/show_bug.cgi?id=194140
1750         <rdar://problem/47728098>
1751
1752         Reviewed by Tim Horton.
1753
1754         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1755         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1756         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1757
1758         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1759         test to induce an IPC deadlock when presenting a modal alert during touch start.
1760
1761         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1762         * WebKitTestRunner/TestController.cpp:
1763         (WTR::runJavaScriptAlert):
1764
1765         Add a client callback function for running JavaScript alerts.
1766
1767         (WTR::TestController::createOtherPage):
1768         (WTR::TestController::generateContextConfiguration const):
1769
1770         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1771         the fix in this patch.
1772
1773         (WTR::TestController::createWebViewWithOptions):
1774
1775         Plumb TestOptions to generateContextConfiguration.
1776
1777         (WTR::TestController::resetPreferencesToConsistentValues):
1778         (WTR::TestController::resetStateToConsistentValues):
1779         (WTR::updateTestOptionsFromTestHeader):
1780         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1781         (WTR::TestController::handleJavaScriptAlert):
1782         * WebKitTestRunner/TestController.h:
1783         * WebKitTestRunner/TestInvocation.cpp:
1784         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1785         * WebKitTestRunner/TestOptions.h:
1786         (WTR::TestOptions::hasSameInitializationOptions const):
1787
1788 2019-02-01  Chris Dumez  <cdumez@apple.com>
1789
1790         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1791         https://bugs.webkit.org/show_bug.cgi?id=193740
1792         <rdar://problem/47527267>
1793
1794         Reviewed by Alex Christensen.
1795
1796         Add API test coverage.
1797
1798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1799
1800 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1801
1802         [ews-app] Add display name field to BuilderMapping model
1803         https://bugs.webkit.org/show_bug.cgi?id=194153
1804
1805         Reviewed by Lucas Forschler.
1806
1807         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1808         (BuilderMapping):
1809
1810 2019-02-01  Youenn Fablet  <youenn@apple.com>
1811
1812         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1813         https://bugs.webkit.org/show_bug.cgi?id=194155
1814
1815         Reviewed by Eric Carlson.
1816
1817         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1818         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1819         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1820
1821 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1822
1823         [LFC] Adjust replaced element's intrinsic ratio
1824         https://bugs.webkit.org/show_bug.cgi?id=194154
1825
1826         Reviewed by Antti Koivisto.
1827
1828         761
1829
1830         * LayoutReloaded/misc/LFC-passing-tests.txt:
1831
1832 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1833
1834         [WPE] Show test results in minibrowser
1835         https://bugs.webkit.org/show_bug.cgi?id=194150
1836
1837         Reviewed by Žan Doberšek.
1838
1839         * Scripts/webkitpy/port/wpe.py:
1840         (WPEPort.show_results_html_file):
1841
1842 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1843
1844         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1845         https://bugs.webkit.org/show_bug.cgi?id=194151
1846
1847         Reviewed by Žan Doberšek.
1848
1849         ALT + <- go back
1850         ALT + -> go forward
1851
1852         * MiniBrowser/wpe/main.cpp:
1853         (main):
1854
1855 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1856
1857         [LFC] Set intrinsic size on Layout::Replaced
1858         https://bugs.webkit.org/show_bug.cgi?id=194139
1859
1860         Reviewed by Antti Koivisto.
1861
1862         744
1863
1864         * LayoutReloaded/misc/LFC-passing-tests.txt:
1865
1866 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1867
1868         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1869         https://bugs.webkit.org/show_bug.cgi?id=194146
1870
1871         Reviewed by Xabier Rodriguez-Calvar.
1872
1873         It allows to open relative paths.
1874
1875         * MiniBrowser/wpe/main.cpp:
1876         (main):
1877
1878 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1879
1880         Update flakiness dashboard configuration after recent queue changes
1881         https://bugs.webkit.org/show_bug.cgi?id=194127
1882
1883         Rubber-stamped by Aakash Jain.
1884
1885         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1886
1887         * TestResultServer/static-dashboards/builders.jsonp:
1888
1889 2019-01-31  Youenn Fablet  <youenn@apple.com>
1890
1891         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1892         https://bugs.webkit.org/show_bug.cgi?id=194106
1893         <rdar://problem/47676333>
1894
1895         Reviewed by Ryosuke Niwa.
1896
1897         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1898         (TestWebKitAPI::didFinishNavigation):
1899         (TestWebKitAPI::TEST):
1900         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1901
1902 2019-01-31  Chris Dumez  <cdumez@apple.com>
1903
1904         Page zoom level is lost after a process swap or a crash
1905         https://bugs.webkit.org/show_bug.cgi?id=194105
1906         <rdar://problem/47610781>
1907
1908         Reviewed by Alex Christensen.
1909
1910         Add API test coverage.
1911
1912         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1913         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1914
1915 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1916
1917         Revert r238819 which is unneeded and caused a performance regression.
1918         https://bugs.webkit.org/show_bug.cgi?id=192272
1919         <rdar://problem/46664625>
1920
1921         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1922         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1923         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1924
1925 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1926
1927         Formalize WebKitAdditions mechanism of LoadOptimizer
1928         https://bugs.webkit.org/show_bug.cgi?id=193886
1929         <rdar://problem/47696809>
1930
1931         Reviewed by Brent Fulgham.
1932
1933         * MiniBrowser/MiniBrowser.entitlements:
1934         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1935
1936 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1937
1938         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1939         https://bugs.webkit.org/show_bug.cgi?id=194090
1940
1941         Reviewed by Antti Koivisto.
1942
1943         * LayoutReloaded/misc/LFC-passing-tests.txt:
1944
1945 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1946
1947         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1948         https://bugs.webkit.org/show_bug.cgi?id=194074
1949
1950         Reviewed by Antti Koivisto.
1951
1952         * LayoutReloaded/misc/LFC-passing-tests.txt:
1953
1954 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1955
1956         [LFC][BFC] Add support for block level replaced box.
1957         https://bugs.webkit.org/show_bug.cgi?id=194071
1958
1959         Reviewed by Antti Koivisto.
1960
1961         * LayoutReloaded/misc/LFC-passing-tests.txt:
1962
1963 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1964
1965         Fix WebKitTestRunner's testPath with Windows full paths
1966         https://bugs.webkit.org/show_bug.cgi?id=194012
1967
1968         Reviewed by Alex Christensen.
1969
1970         updateTestOptionsFromTestHeader failed to open test files because
1971         testPath returned wrong file paths. It returned a path "/C:/..."
1972         if a URL "file:///C:/..." was given.
1973
1974         * WebKitTestRunner/TestController.cpp:
1975         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1976
1977 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1978
1979         [WPE] Bump font related dependencies to match the GTK+ port
1980         https://bugs.webkit.org/show_bug.cgi?id=194017
1981
1982         Reviewed by Žan Doberšek.
1983
1984         * wpe/jhbuild.modules:
1985         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1986         * wpe/patches/icudata-stdlibs.patch: Added.
1987
1988 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1989
1990         Enable swipe tests on iOS
1991         https://bugs.webkit.org/show_bug.cgi?id=194076
1992
1993         Reviewed by Geoffrey Garen.
1994
1995         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1996         it causes a debug assertion failure in runUIScript.
1997
1998         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1999         (WTR::UIScriptController::beginBackSwipe):
2000         (WTR::UIScriptController::completeBackSwipe):
2001
2002 2019-01-30  Keith Rollin  <krollin@apple.com>
2003
2004         Use correct printf format specifier
2005         https://bugs.webkit.org/show_bug.cgi?id=194062
2006         <rdar://problem/47686167>
2007
2008         Reviewed by Alexey Proskuryakov.
2009
2010         LayoutTestSpellChecker.mm is trying to format a variable of type
2011         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2012         actually an unsigned long long. Fix this by formatting with %llu.
2013
2014         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2015         (-[LayoutTestTextCheckingResult description]):
2016
2017 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2018
2019         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2020         https://bugs.webkit.org/show_bug.cgi?id=193979
2021
2022         Reviewed by Wenson Hsieh.
2023
2024         Fix the test for iOS. Make the test work with iOS UA string.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2027
2028 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2029
2030         Replace High Sierra LLINT CLoop bot due to hardware failure
2031         https://bugs.webkit.org/show_bug.cgi?id=194066
2032
2033         Reviewed by Aakash Jain.
2034
2035         * BuildSlaveSupport/build.webkit.org-config/config.json:
2036
2037 2019-01-30  Keith Rollin  <krollin@apple.com>
2038
2039         [NSDragItem init] is unavailable
2040         https://bugs.webkit.org/show_bug.cgi?id=194059
2041         <rdar://problem/47685715>
2042
2043         Reviewed by Wenson Hsieh.
2044
2045         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2046         DumpRenderTree and TestWebKitAPI, which both try to create an
2047         NSDragItem in a manner that invokes this method. Address this by using
2048         -initWithPasteboardWriter instead.
2049
2050         Note that the parameter passed to initWithPasteboardWriter is likely
2051         incorrect. In both cases, the object passed does not conform to
2052         NSPasteboardWriting. However, with this fix, we're no worse off than
2053         before, and can now perform builds with newer compilers and SDKs until
2054         a real fix can be crafted. That work is tracked in
2055         https://bugs.webkit.org/show_bug.cgi?id=194060
2056
2057         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2058         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2059         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2060         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2061
2062 2019-01-30  Daniel Bates  <dabates@apple.com>
2063
2064         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2065         https://bugs.webkit.org/show_bug.cgi?id=192824
2066         <rdar://problem/47100332>
2067
2068         Reviewed by Wenson Hsieh.
2069
2070         Fix a bug where the wrong usage code was used for F13 thru F24.
2071
2072         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2073         (keyCodeForDOMFunctionKey):
2074
2075 2019-01-30  Chris Dumez  <cdumez@apple.com>
2076
2077         Regression(PSON) Load hang can occur on history navigation
2078         https://bugs.webkit.org/show_bug.cgi?id=194030
2079         <rdar://problem/47656939>
2080
2081         Reviewed by Antti Koivisto.
2082
2083         Add API test coverage.
2084
2085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2086
2087 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2088
2089         [LFC] Expand tests coverage.
2090
2091         Unreviewed test gardening.
2092
2093         * LayoutReloaded/misc/LFC-passing-tests.txt:
2094
2095 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2096
2097         [Flatpak] Add openjpeg support
2098         https://bugs.webkit.org/show_bug.cgi?id=194019
2099
2100         Reviewed by Michael Catanzaro.
2101
2102         * flatpak/org.webkit.CommonModules.yaml:
2103
2104 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2105
2106         Unreviewed, rolling out r240708.
2107         https://bugs.webkit.org/show_bug.cgi?id=194022
2108
2109         It broke WPE build (Requested by KaL on #webkit).
2110
2111         Reverted changeset:
2112
2113         "[WPE] Bump font related dependencies to match the GTK+ port"
2114         https://bugs.webkit.org/show_bug.cgi?id=194017
2115         https://trac.webkit.org/changeset/240708
2116
2117 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2118
2119         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2120         https://bugs.webkit.org/show_bug.cgi?id=194001
2121
2122         Reviewed by Antti Koivisto.
2123
2124         * LayoutReloaded/misc/LFC-passing-tests.txt:
2125
2126 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2127
2128         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2129         https://bugs.webkit.org/show_bug.cgi?id=194020
2130
2131         Reviewed by Antti Koivisto.
2132
2133         * LayoutReloaded/misc/LFC-passing-tests.txt:
2134
2135 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2136
2137         AX: Support color well on iOS
2138         https://bugs.webkit.org/show_bug.cgi?id=194010
2139
2140         Reviewed by Joanmarie Diggs.
2141
2142         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2143         (WTR::AccessibilityUIElement::stringAttributeValue):
2144
2145 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2146
2147         [WPE] Bump font related dependencies to match the GTK+ port
2148         https://bugs.webkit.org/show_bug.cgi?id=194017
2149
2150         Reviewed by Žan Doberšek.
2151
2152         * wpe/jhbuild.modules:
2153         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2154         * wpe/patches/icudata-stdlibs.patch: Added.
2155
2156 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2157
2158         [Mac] Update window scale API usage
2159         https://bugs.webkit.org/show_bug.cgi?id=193991
2160         rdar://problem/47614795
2161
2162         Reviewed by Tim Horton.
2163
2164         * DumpRenderTree/mac/DumpRenderTree.mm:
2165         (changeWindowScaleIfNeeded):
2166         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2167         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2168         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2169
2170 2019-01-29  Chris Dumez  <cdumez@apple.com>
2171
2172         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2173         https://bugs.webkit.org/show_bug.cgi?id=193977
2174         <rdar://problem/47643716>
2175
2176         Reviewed by Geoff Garen.
2177
2178         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2179         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2180         to the previous provisional committing *before* we make the last load. 
2181
2182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2183
2184 2019-01-29  Youenn Fablet  <youenn@apple.com>
2185
2186         Adopt new SPI to evaluate server certificate trust
2187         https://bugs.webkit.org/show_bug.cgi?id=193355
2188
2189         Reviewed by Alex Christensen.
2190
2191         Add infrastructure to handle HTTPS server trust evaluation testing.
2192
2193         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2194         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2195         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2196         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2197         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2198         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2199         * WebKitTestRunner/TestController.cpp:
2200         (WTR::TestController::resetPreferencesToConsistentValues):
2201         (WTR::TestController::didReceiveAuthenticationChallenge):
2202         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2203         * WebKitTestRunner/TestController.h:
2204         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2205         * WebKitTestRunner/TestInvocation.cpp:
2206         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2207         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2208         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2209
2210 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2211
2212         [ews-build] Add build step to print bot Configuration
2213         https://bugs.webkit.org/show_bug.cgi?id=193887
2214
2215         Reviewed by Lucas Forschler.
2216
2217         * BuildSlaveSupport/ews-build/steps.py:
2218         (PrintConfiguration): Build step to print configuration.
2219         * BuildSlaveSupport/ews-build/factories.py:
2220
2221 2019-01-29  Chris Dumez  <cdumez@apple.com>
2222
2223         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2224         https://bugs.webkit.org/show_bug.cgi?id=193967
2225         <rdar://problem/47635348>
2226
2227         Reviewed by Alex Christensen.
2228
2229         Add API test coverage.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2232         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2233
2234 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2235
2236         [ews-app] Handle incoming results data
2237         https://bugs.webkit.org/show_bug.cgi?id=193973
2238
2239         Reviewed by Lucas Forschler.
2240
2241         * BuildSlaveSupport/ews-app/ews/views/results.py:
2242
2243 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2244
2245         [ews-app] Make the results url generic
2246         https://bugs.webkit.org/show_bug.cgi?id=193928
2247
2248         Reviewed by Lucas Forschler.
2249
2250         * BuildSlaveSupport/ews-app/ews/urls.py:
2251
2252 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2253
2254         [ews-build] Configure buildbot to send events to ews-app
2255         https://bugs.webkit.org/show_bug.cgi?id=193968
2256
2257         Reviewed by Lucas Forschler.
2258
2259         * BuildSlaveSupport/ews-build/events.py: Added.
2260         * BuildSlaveSupport/ews-build/master.cfg:
2261
2262 2019-01-29  Keith Rollin  <krollin@apple.com>
2263
2264         Add .xcfilelists to Run Script build phases
2265         https://bugs.webkit.org/show_bug.cgi?id=193792
2266         <rdar://problem/47201785>
2267
2268         Reviewed by Alex Christensen.
2269
2270         As part of supporting XCBuild, update the necessary Run Script build
2271         phases in their Xcode projects to refer to their associated
2272         .xcfilelist files.
2273
2274         Note that the addition of these files bumps the Xcode project version
2275         number to something that's Xcode 10 compatible. This change means that
2276         older versions of the Xcode IDE can't read these projects. Nor can it
2277         fully load workspaces that refer to these projects (the updated
2278         projects are shown as non-expandable placeholders). `xcodebuild` can
2279         still build these projects; it's just that the IDE can't open them.
2280
2281         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2282         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2283
2284 2019-01-29  John Wilander  <wilander@apple.com>
2285
2286         Add data abstraction and validation for Ad Click Attribution
2287         https://bugs.webkit.org/show_bug.cgi?id=193916
2288         <rdar://problem/47603481>
2289
2290         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2291
2292         Ad click attribution has two steps. First, the storage of an ad
2293         campaign ID for a click that takes the user to a destination
2294         site. Second, a conversion on the destination site that can be
2295         attributed to the ad click.
2296
2297         This patch adds a class that represents a request for ad click
2298         attribution. Validation makes sure that the bits of entropy
2299         reported through this mechanism is limited.
2300
2301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2302         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2303         (TestWebKitAPI::TEST):
2304
2305 2019-01-29  Chris Dumez  <cdumez@apple.com>
2306
2307         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2308         https://bugs.webkit.org/show_bug.cgi?id=193932
2309         <rdar://problem/47598947>
2310
2311         Reviewed by Brady Eidson.
2312
2313         Add API test coverage.
2314
2315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2316
2317 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2318
2319         Adding new passing LFC tests.
2320
2321         Unreviewed test gardening.
2322
2323         * LayoutReloaded/misc/LFC-passing-tests.txt:
2324
2325 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2326
2327         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2328         https://bugs.webkit.org/show_bug.cgi?id=193964
2329
2330         Reviewed by Antti Koivisto.
2331
2332         * LayoutReloaded/misc/LFC-passing-tests.txt:
2333
2334 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2335
2336         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2337         https://bugs.webkit.org/show_bug.cgi?id=193954
2338
2339         Reviewed by Antti Koivisto.
2340
2341         * LayoutReloaded/misc/LFC-passing-tests.txt:
2342
2343 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2344
2345         WebDriver: add support for running subtests
2346         https://bugs.webkit.org/show_bug.cgi?id=193904
2347
2348         Reviewed by Michael Catanzaro.
2349
2350         pytest already supports it by passing test.py::subtest, so we can do the same.
2351
2352         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2353         (get_item_name): Made this global.
2354         (CollectRecorder.__init__): Receive the parameter to ignore.
2355         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2356         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2357         (collect): Add parameter to ignore.
2358         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2359         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2360         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2361         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2362         (WebDriverTestRunnerSelenium.run): Ditto.
2363         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2364         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2365         (WebDriverTestRunnerW3C.run): Ditto.
2366
2367 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2368
2369         User agent string override for navigator.userAgent should be site specific quirks
2370         https://bugs.webkit.org/show_bug.cgi?id=193950
2371
2372         Reviewed by Brent Fulgham.
2373
2374         Updated per the _WKWebsitePolicies rename.
2375
2376         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2377         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2378
2379 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2380
2381         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2382         https://bugs.webkit.org/show_bug.cgi?id=193941
2383
2384         Reviewed by Alex Christensen.
2385
2386         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2387         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2388         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2389         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2390         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2391         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2392         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2393         * TestWebKitAPI/Tests/WTF/Time.cpp:
2394         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2395         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2396         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2397         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2398
2399 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2400
2401         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2402
2403         * Scripts/webkitpy/common/config/contributors.json:
2404
2405 2019-01-28  Andy Estes  <aestes@apple.com>
2406
2407         [watchOS] Enable Parental Controls content filtering
2408         https://bugs.webkit.org/show_bug.cgi?id=193939
2409         <rdar://problem/46641912>
2410
2411         Reviewed by Ryosuke Niwa.
2412
2413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2414
2415 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2416
2417         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2418         <https://webkit.org/b/193884>
2419
2420         Reviewed by Jiewen Tan.
2421
2422         * Scripts/webkitpy/style/checkers/cpp.py:
2423         (check_language): Add LocalAuthentication to
2424         `frameworks_with_soft_links`.
2425
2426 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2427
2428         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2429         https://bugs.webkit.org/show_bug.cgi?id=193891
2430
2431         Reviewed by Ross Kirsling.
2432
2433         There were three problems in window sizes of WebView and the host window.
2434         1. The sizes of pixel image output were incorrect.
2435         2. The host window is going to appear after window.resize was invoked.
2436         3. window.resize resized only the host window, not WebView.
2437
2438         This change solves them with a following approach.
2439         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2440         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2441            as well as DumpRenderTree in order to match the client area and the window area.
2442         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2443         d. PlatformWebView::setWindowFrame changes both window sizes.
2444         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2445
2446         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2447         (WTR::PlatformWebView::PlatformWebView): Create the host window
2448         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2449         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2450         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2451
2452 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2453
2454         [ews-app] Add method to save Step data to database
2455         https://bugs.webkit.org/show_bug.cgi?id=193890
2456
2457         Reviewed by Lucas Forschler.
2458
2459         * BuildSlaveSupport/ews-app/ews/models/step.py:
2460         (Step.save_step): Method to save step data.
2461         (Step.update_step): Method to update step data.
2462         (Step.get_existing_step): Method to fetch existing step from database.
2463         (Step.is_valid_result): Method to validate valid step result.
2464
2465 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2466
2467         [ews-app] Add method to save Build data to database
2468         https://bugs.webkit.org/show_bug.cgi?id=193735
2469
2470         Reviewed by Lucas Forschler.
2471
2472         * BuildSlaveSupport/ews-app/ews/models/build.py:
2473         (Build.save_build): Method to save build information to database.
2474         (Build.get_existing_build): Method to fetch existing build from database.
2475         (Build.is_valid_result): Method to validate build result.
2476         * BuildSlaveSupport/ews-app/ews/common/util.py:
2477         (is_valid_int_id): Method to validate valid id.
2478
2479 2019-01-28  Chris Dumez  <cdumez@apple.com>
2480
2481         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2482         https://bugs.webkit.org/show_bug.cgi?id=193915
2483         <rdar://problem/47560907>
2484
2485         Reviewed by Alex Christensen.
2486
2487         Add API test coverage.
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2490
2491 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2492
2493         [ews-app] Rename id variables
2494         https://bugs.webkit.org/show_bug.cgi?id=193883
2495
2496         Reviewed by Lucas Forschler.
2497
2498         * BuildSlaveSupport/ews-app/ews/models/build.py:
2499         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2500         * BuildSlaveSupport/ews-app/ews/models/step.py:
2501         * BuildSlaveSupport/ews-app/ews/urls.py:
2502         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2503         * BuildSlaveSupport/ews-app/ews/views/results.py:
2504         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2505
2506 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews-app] Allow certain fields to be empty
2509         https://bugs.webkit.org/show_bug.cgi?id=193892
2510
2511         Reviewed by Lucas Forschler.
2512
2513         * BuildSlaveSupport/ews-app/ews/models/build.py:
2514         * BuildSlaveSupport/ews-app/ews/models/step.py:
2515
2516 2019-01-28  Rob Buis  <rbuis@igalia.com>
2517
2518         Update MIME type parser
2519         https://bugs.webkit.org/show_bug.cgi?id=180526
2520
2521         Reviewed by Frédéric Wang.
2522
2523         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2524         (TestWebKitAPI::TEST):
2525
2526 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2527
2528         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2529         https://bugs.webkit.org/show_bug.cgi?id=193896
2530
2531         Reviewed by Antti Koivisto.
2532
2533         * LayoutReloaded/misc/LFC-passing-tests.txt:
2534
2535 2018-12-15  Darin Adler  <darin@apple.com>
2536
2537         Replace many uses of String::format with more type-safe alternatives
2538         https://bugs.webkit.org/show_bug.cgi?id=192742
2539
2540         Reviewed by Mark Lam.
2541
2542         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2543         (WTR::cacheTestRunnerCallback): Use makeString.
2544         * WebKitTestRunner/TestController.cpp:
2545         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2546         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2547
2548 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2549
2550         Use a load optimizer for some sites
2551         https://bugs.webkit.org/show_bug.cgi?id=193881
2552         <rdar://problem/46325455>
2553
2554         Reviewed by Brent Fulgham.
2555
2556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2557         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2558
2559 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2560
2561         AX: Introduce a static accessibility tree
2562         https://bugs.webkit.org/show_bug.cgi?id=193348
2563         <rdar://problem/47203295>
2564
2565         Reviewed by Ryosuke Niwa.
2566
2567         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2568
2569 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2570
2571         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2572         https://bugs.webkit.org/show_bug.cgi?id=193867
2573
2574         Reviewed by Antti Koivisto.
2575
2576         * LayoutReloaded/misc/LFC-passing-tests.txt:
2577
2578 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2579
2580         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2581         https://bugs.webkit.org/show_bug.cgi?id=193865
2582
2583         Reviewed by Antti Koivisto.
2584
2585         * LayoutReloaded/misc/LFC-passing-tests.txt:
2586
2587 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2588
2589         Need a mechanism to override navigator.userAgent
2590         https://bugs.webkit.org/show_bug.cgi?id=193762
2591         <rdar://problem/47504939>
2592
2593         Reviewed by Brent Fulgham.
2594
2595         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2596
2597         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2598         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2599         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2600
2601 2019-01-25  Dean Jackson  <dino@apple.com>
2602
2603         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2604         https://bugs.webkit.org/show_bug.cgi?id=193831
2605         <rdar://problem/47399263>
2606
2607         Reviewed by Chris Dumez.
2608
2609         Two new tests that exercise cross-origin and same-origin System
2610         Previews.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2613
2614 2019-01-25  Keith Rollin  <krollin@apple.com>
2615
2616         Update Xcode projects with "Check .xcfilelists" build phase
2617         https://bugs.webkit.org/show_bug.cgi?id=193790
2618         <rdar://problem/47201374>
2619
2620         Reviewed by Alex Christensen.
2621
2622         Support for XCBuild includes specifying inputs and outputs to various
2623         Run Script build phases. These inputs and outputs are specified as
2624         .xcfilelist files. Once created, these .xcfilelist files need to be
2625         kept up-to-date. In order to check that they are up-to-date or not,
2626         add an Xcode build step that invokes an external script that performs
2627         the checking. If the .xcfilelists are found to be out-of-date, update
2628         them, halt the build, and instruct the developer to restart the build
2629         with up-to-date files.
2630
2631         At this time, the checking and regenerating is performed only if the
2632         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2633         who want to use this facility can set this variable and test out the
2634         checking/regenerating. Once it seems like there are no egregious
2635         issues that upset a developer's workflow, we'll unconditionally enable
2636         this facility.
2637
2638         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2639         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2640         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2641         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2642
2643 2019-01-25  Keith Rollin  <krollin@apple.com>
2644
2645         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2646         https://bugs.webkit.org/show_bug.cgi?id=193781
2647         <rdar://problem/47201153>
2648
2649         Reviewed by Alex Christensen.
2650
2651         Part of generating the .xcfilelists used as part of adopting XCBuild
2652         includes running `make DerivedSources.make` from a standalone script.
2653         It’s important for this invocation to have the same environment as
2654         when the actual build invokes `make DerivedSources.make`. If the
2655         environments are different, then the two invocations will provide
2656         different results. In order to get the same environment in the
2657         standalone script, have the script launch xcodebuild targeting the
2658         "Apply Configuration to XCFileLists" build target, which will then
2659         re-invoke our standalone script. The script is now running again, this
2660         time in an environment with all workspace, project, target, xcconfig
2661         and other environment variables established.
2662
2663         The "Apply Configuration to XCFileLists" build target accomplishes
2664         this task via a small embedded shell script that consists only of:
2665
2666             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2667
2668         The process that invokes "Apply Configuration to XCFileLists" first
2669         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2670         evaluated and exports it into the shell environment. When xcodebuild
2671         is invoked, it inherits the value of this variable and can `eval` the
2672         contents of that variable. Our external standalone script can then set
2673         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2674         of command-line parameters needed to restart itself in the appropriate
2675         state.
2676
2677         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2678         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2679
2680 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2681
2682         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2683         https://bugs.webkit.org/show_bug.cgi?id=193802
2684         <rdar://problem/46010580>
2685
2686         Reviewed by Andy Estes.
2687
2688         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2689         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2690         (TEST):
2691
2692 2019-01-25  Daniel Bates  <dabates@apple.com>
2693
2694         [iOS] uiController.keyDown() does not translate Control modified key
2695         https://bugs.webkit.org/show_bug.cgi?id=192898
2696
2697         Reviewed by Wenson Hsieh.
2698
2699         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2700         key translation, as applicable. Among other cases, key translation occurs when performing
2701         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2702         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2703         human pressing down and releasing key(s) using a hardware keyboard.
2704
2705         * WebKitTestRunner/ios/HIDEventGenerator.h:
2706         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2707         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2708
2709         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2710         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2711         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2712         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2713         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2714         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2715         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2716         (-[HIDEventGenerator longPress:completionBlock:]):
2717         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2718         Update code for above renaming.
2719
2720         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2721         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2722
2723         (-[HIDEventGenerator keyDown:]): Added.
2724         (-[HIDEventGenerator keyUp:]): Added.
2725         (-[HIDEventGenerator keyPress:completionBlock:]):
2726         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2727         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2728         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2729         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2730         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2731         (WTR::parseModifier): Deleted.
2732
2733 2019-01-25  Keith Rollin  <krollin@apple.com>
2734
2735         Complete the implementation of generate-xcfilelists
2736         https://bugs.webkit.org/show_bug.cgi?id=193782
2737
2738         Reviewed by Alex Christensen.
2739
2740         A preliminary version of generate-xcfilelists was added in r238008.
2741         This patch updates that script in order to:
2742
2743         - Support checking of .xcfilelists
2744         - Perform better execution of `make DerivedSources.make` by
2745           relaunching generate-xcfilelists under xcodebuild
2746         - Support incremental generation and checking of .xcfilelists
2747         - Support supplementary .xcfilelists files from WebKitAdditions
2748         - Support being wrapped by parallel version of generate-xcfilelists in
2749           Internal that adds support for (re)generating WebKit projects in
2750           that repo.
2751         - Support builds that have been performed in WebKitBuild as well as
2752           ~/Library/Developer/code/DerivedData
2753         - Increase robustness and debugging facilities.
2754
2755         * Scripts/generate-xcfilelists:
2756
2757 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2758
2759         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2760         https://bugs.webkit.org/show_bug.cgi?id=193297
2761         <rdar://problem/47158841>
2762
2763         Unreviewed test case fix.
2764
2765         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2766         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2767
2768         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2769         (TEST):
2770
2771 2019-01-25  Keith Rollin  <krollin@apple.com>
2772
2773         Update existing .xcfilelists
2774         https://bugs.webkit.org/show_bug.cgi?id=193791
2775         <rdar://problem/47201706>
2776
2777         Reviewed by Alex Christensen.
2778
2779         Many .xcfilelist files were added in r238824 in order to support
2780         XCBuild. Update these with recent changes to the set of build files
2781         and with the current generate-xcfilelist script.
2782
2783         * DumpRenderTree/DerivedSources-input.xcfilelist:
2784         * DumpRenderTree/DerivedSources-output.xcfilelist:
2785         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2786         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2787
2788 2019-01-25  Keith Rollin  <krollin@apple.com>
2789
2790         Fix missing dependencies in extract-dependencies-from-makefile
2791         https://bugs.webkit.org/show_bug.cgi?id=193783
2792         <rdar://problem/47201571>
2793
2794         Reviewed by Alex Christensen.
2795
2796         The extract-dependencies-from-makefile script generates .xcfilelists
2797         for XCBuild by invoking a makefile in --debug mode, parsing the
2798         dependency information in the output, and extracting information
2799         regarding targets and dependents. However, the way `make` emits this
2800         dependency information is not rigorous, and so we need to determine
2801         what lines to look for and parse by trial and error. This approach
2802         didn't coriginally atch all the information we needed to collect, so
2803         update the script to look for the additional lines we now know to look
2804         for.
2805
2806         * Scripts/extract-dependencies-from-makefile:
2807         (Parser):
2808         (Parser.addTarget):
2809         (Parser.addPrereq):
2810         (Parser.doParse):
2811
2812 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2813
2814         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2815         https://bugs.webkit.org/show_bug.cgi?id=193297
2816         <rdar://problem/47158841>
2817
2818         Reviewed by Alex Christensen.
2819
2820         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2821             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2822         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2823         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2824         activating the message used to trigger the callback when it is set.
2825
2826 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2827
2828         WKWebView.goBack should reload if there is a safe browsing warning
2829         https://bugs.webkit.org/show_bug.cgi?id=193805
2830         <rdar://problem/46908216>
2831
2832         Reviewed by Geoff Garen.
2833
2834         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2835         (+[Simple3LookupContext sharedLookupContext]):
2836         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2837         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2838         (TEST):
2839
2840 2019-01-25  Chris Dumez  <cdumez@apple.com>
2841
2842         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2843         https://bugs.webkit.org/show_bug.cgi?id=193788
2844         <rdar://problem/47531231>
2845
2846         Reviewed by Alex Christensen.
2847
2848         Add API test coverage.
2849
2850         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2851         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2852
2853 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2854
2855         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2856         https://bugs.webkit.org/show_bug.cgi?id=193771
2857
2858         Unreviewed infrastructure fix.
2859
2860         * Scripts/webkitpy/port/darwin.py:
2861         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2862
2863 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2864
2865         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2866
2867 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2868
2869         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2870
2871         * Scripts/webkitpy/common/config/contributors.json:
2872
2873 2019-01-25  Chris Dumez  <cdumez@apple.com>
2874
2875         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2876         https://bugs.webkit.org/show_bug.cgi?id=193779
2877         <rdar://problem/46170903>
2878
2879         Reviewed by Antti Koivisto.
2880
2881         Add API test that quickly navigates forward to a previous process without waiting for it to
2882         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2883         the process' previous page when reconnecting the it for the forward navigation.
2884
2885         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2886
2887 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2888
2889         Need a way for JavaScript (or bundle) code to participate in undo
2890         https://bugs.webkit.org/show_bug.cgi?id=190009
2891         <rdar://problem/44807048>
2892
2893         Reviewed by Ryosuke Niwa.
2894
2895         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2896         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2897
2898         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2899         (WTR::UIScriptController::lastUndoLabel const):
2900         (WTR::UIScriptController::firstRedoLabel const):
2901         (WTR::UIScriptController::platformUndoManager const):
2902         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2903         (WTR::UIScriptController::lastUndoLabel const):
2904         (WTR::UIScriptController::firstRedoLabel const):
2905         (WTR::UIScriptController::platformUndoManager const):
2906         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2907         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2908         (WTR::UIScriptController::lastUndoLabel const):
2909         (WTR::UIScriptController::firstRedoLabel const):
2910         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2911         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2912         (WTR::UIScriptController::lastUndoLabel const):
2913         (WTR::UIScriptController::firstRedoLabel const):
2914         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2915         (WTR::UIScriptController::platformUndoManager const):
2916         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2917         (WTR::UIScriptController::platformUndoManager const):
2918
2919 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2920
2921         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2922         https://bugs.webkit.org/show_bug.cgi?id=193824
2923
2924         Reviewed by Antti Koivisto.
2925
2926         * LayoutReloaded/misc/LFC-passing-tests.txt:
2927
2928 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2929
2930         Update macOS JSC bot configurations
2931         https://bugs.webkit.org/show_bug.cgi?id=193739
2932
2933         Reviewed by Alexey Proskuryakov.
2934
2935         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2937         (BubbleQueueServer): Move JSC EWS to Mojave section.
2938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2939         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2940         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2941
2942 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2943
2944         [Win][WebKitTestRunner] Implement EventSenderProxy
2945         https://bugs.webkit.org/show_bug.cgi?id=193755
2946
2947         Reviewed by Don Olmstead.
2948
2949         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2950         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2951         (WTR::EventSenderProxy::dispatchMessage):
2952         (WTR::EventSenderProxy::EventSenderProxy):
2953         (WTR::EventSenderProxy::mouseDown):
2954         (WTR::EventSenderProxy::mouseUp):
2955         (WTR::EventSenderProxy::mouseMoveTo):
2956         (WTR::EventSenderProxy::mouseScrollBy):
2957         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2958
2959 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2960
2961         Unreviewed fix for API test failure after r240437.
2962
2963         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2964
2965         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2966
2967 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2968
2969         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2970         https://bugs.webkit.org/show_bug.cgi?id=193787
2971         <rdar://problem/47497634>
2972
2973         Reviewed by Alexey Proskuryakov.
2974
2975         * Scripts/webkitdirs.pm:
2976         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2977
2978 2019-01-24  Truitt Savell  <tsavell@apple.com>
2979
2980         Unreviewed, rolling out r240446.
2981
2982         Casued 5 API failures
2983
2984         Reverted changeset:
2985
2986         "Activate the WebResourceLoadStatisticsStore in the
2987         NetworkProcess and deactivate it in the UIProcess."
2988         https://bugs.webkit.org/show_bug.cgi?id=193297
2989         https://trac.webkit.org/changeset/240446
2990
2991 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2992
2993         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2994         https://bugs.webkit.org/show_bug.cgi?id=193741
2995         <rdar://problem/47135030>
2996
2997         Reviewed by Antti Koivisto and Simon Fraser.
2998
2999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3000         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3001         (TestWebKitAPI::TEST):
3002
3003 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3004
3005         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3006         https://bugs.webkit.org/show_bug.cgi?id=193297
3007         <rdar://problem/47158841>
3008
3009         Reviewed by Alex Christensen.
3010
3011         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3012         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3013         activating the message used to trigger the callback when it is set.
3014
3015 2019-01-24  John Wilander  <wilander@apple.com>
3016
3017         Add Ad Click Attribution as an internal/experimental feature
3018         https://bugs.webkit.org/show_bug.cgi?id=193685
3019         <rdar://problem/47450399>
3020
3021         Reviewed by Brent Fulgham.
3022
3023         Added test option adClickAttributionEnabled.
3024
3025         * DumpRenderTree/TestOptions.cpp:
3026         (TestOptions::TestOptions):
3027         * DumpRenderTree/TestOptions.h:
3028         * DumpRenderTree/mac/DumpRenderTree.mm:
3029         (setWebPreferencesForTestOptions):
3030
3031 2019-01-24  Antti Koivisto  <antti@apple.com>
3032
3033         [PSON] Flash on back navigation on Mac
3034         https://bugs.webkit.org/show_bug.cgi?id=193716
3035         <rdar://problem/47148458>
3036
3037         Reviewed by Chris Dumez.
3038
3039         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3040
3041         Closing of the previous page is delayed so waiting for didFinishNavigation is
3042         not sufficient to guarantee we have received all the messages. Wait for them.
3043
3044 2019-01-24  Chris Dumez  <cdumez@apple.com>
3045
3046         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3047         https://bugs.webkit.org/show_bug.cgi?id=193761
3048         <rdar://problem/47456405>
3049
3050         Reviewed by Alex Christensen.
3051
3052         Add API test coverage.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3055
3056 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3057
3058         webkitpy: Missing PID in crashlog name should not be fatal
3059         https://bugs.webkit.org/show_bug.cgi?id=193771
3060
3061         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3062         of raising an exception.
3063
3064         Reviewed by Lucas Forschler.
3065
3066         * Scripts/webkitpy/port/darwin.py:
3067         (DarwinPort._merge_crash_logs):
3068
3069 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3070
3071         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3072         https://bugs.webkit.org/show_bug.cgi?id=193746
3073
3074         Reviewed by Youenn Fablet.
3075
3076         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3077         so we'd best just not call it.
3078
3079         * Scripts/webkitpy/w3c/test_exporter.py:
3080         (WebPlatformTestExporter.create_branch_with_patch):
3081
3082 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3083
3084         Move FileSystem to WTF
3085         https://bugs.webkit.org/show_bug.cgi?id=193602
3086
3087         Reviewed by Yusuke Suzuki.
3088
3089         * DumpRenderTree/win/DumpRenderTree.cpp:
3090         * TestWebKitAPI/CMakeLists.txt:
3091         * TestWebKitAPI/PlatformGTK.cmake:
3092         * TestWebKitAPI/PlatformJSCOnly.cmake:
3093         * TestWebKitAPI/PlatformPlayStation.cmake:
3094         * TestWebKitAPI/PlatformWPE.cmake:
3095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3096         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3097         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3098         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3099         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3100         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3101         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3102         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3103         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3104         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3105
3106 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3107
3108         [WPE] Remove hard dependency on subprocess32 for the API tests
3109
3110         Rubber-stamped by Carlos Garcia Campos.
3111
3112         * glib/api_test_runner.py:
3113         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3114         its presence only when running WPEQt tests.
3115
3116 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GLIB] Expose JavaScriptCore options in GLib public API
3119         https://bugs.webkit.org/show_bug.cgi?id=188742
3120
3121         Reviewed by Michael Catanzaro.
3122
3123         Add a test for the new API.
3124
3125         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3126         (testsJSCOptions):
3127         (main):
3128
3129 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [GTK][WPE] Support JPEG 2000 images
3132         https://bugs.webkit.org/show_bug.cgi?id=186272
3133
3134         Reviewed by Žan Doberšek.
3135
3136         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3137
3138         * gtk/jhbuild.modules:
3139         * wpe/jhbuild.modules:
3140
3141 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3142
3143         check-webkit-style should warn when using soft-linking macros in a header
3144         <https://webkit.org/b/193750>
3145
3146         Reviewed by Darin Adler.
3147
3148         * Scripts/webkitpy/style/checkers/cpp.py:
3149         (check_language): Add softlink/header check by refactoring the
3150         softlink/framework check.
3151         (CppChecker): Enable softlink/header check by default.
3152         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3153         (CppStyleTest.test_softlink_framework): Rename from
3154         CppStyleTest.test_softlink() and change test framework name in
3155         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3156         files. Set file_name for macros that only appear in headers.
3157         (CppStyleTest.test_softlink_header): Add tests for using
3158         soft-link macros in headers.
3159
3160 2019-01-23  Chris Dumez  <cdumez@apple.com>
3161
3162         Deprecate API to limit the maximum number of WebProcesses
3163         https://bugs.webkit.org/show_bug.cgi?id=193725
3164         <rdar://problem/47464879>
3165
3166         Reviewed by Geoff Garen.
3167
3168         Update existing API tests to stop using deprecated API.
3169
3170         * MiniBrowser/mac/AppDelegate.m:
3171         (defaultConfiguration):
3172         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3173         (TestWebKitAPI::TEST):
3174         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3175         (TestWebKitAPI::TEST):
3176         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3177         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3178         (TEST):
3179         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3180         (TEST):
3181
3182 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3183
3184         [ews-app] Rename ews model buildermappings to buildermapping
3185         https://bugs.webkit.org/show_bug.cgi?id=193729
3186
3187         Reviewed by Lucas Forschler.
3188
3189         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3190         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3191         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3192
3193 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3194
3195         [ews-app] Rename ews model steps to step
3196         https://bugs.webkit.org/show_bug.cgi?id=193697
3197
3198         Reviewed by Lucas Forschler.
3199
3200         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3201         (Step): Renamed Steps to Step.
3202
3203 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3204
3205         Clean up IndexedDB files between tests
3206         https://bugs.webkit.org/show_bug.cgi?id=192796
3207         <rdar://problem/46824999>
3208
3209         Reviewed by Geoffrey Garen.
3210
3211         * DumpRenderTree/mac/DumpRenderTree.mm:
3212         (runTest):
3213         * WebKitTestRunner/TestController.cpp:
3214         (WTR::TestController::resetStateToConsistentValues):
3215         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3216         (WTR::RemoveAllIndexedDatabasesCallback):
3217         (WTR::TestController::ClearIndexedDatabases):
3218         * WebKitTestRunner/TestController.h:
3219         * WebKitTestRunner/TestInvocation.cpp:
3220         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3221
3222 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3223
3224         [ews-app] Rename ews model Builds to Build
3225         https://bugs.webkit.org/show_bug.cgi?id=193695
3226
3227         Reviewed by Lucas Forschler.
3228
3229         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3230         (Build): Renamed Builds to Build.
3231
3232 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3233
3234         webkitpy: Wait longer when launching WebKitTestRunner
3235         https://bugs.webkit.org/show_bug.cgi?id=193734
3236
3237         Reviewed by Aakash Jain.
3238
3239         * Scripts/webkitpy/port/simulator_process.py:
3240         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3241
3242 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3243
3244         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3245         https://bugs.webkit.org/show_bug.cgi?id=193182
3246         <rdar://problem/47452154>
3247
3248         Reviewed by Tim Horton.
3249
3250         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3251         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3252         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3253
3254         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3255         preventing later tests from recognizing gestures.
3256
3257         * WebKitTestRunner/ios/TestControllerIOS.mm:
3258         (WTR::TestController::platformResetStateToConsistentValues):
3259
3260         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3261
3262 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3263
3264         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3265         https://bugs.webkit.org/show_bug.cgi?id=193722
3266         <rdar://problem/47481475>
3267
3268         Reviewed by Lucas Forschler.
3269
3270         iPhone and iPad ports should both use the iOS config.
3271
3272         * Scripts/webkitpy/port/ios_simulator.py:
3273         (IPhoneSimulatorPort.__init__):
3274         (IPadSimulatorPort.__init__):
3275
3276 2019-01-23  Rob Buis  <rbuis@igalia.com>
3277
3278         Update MIME type parser
3279         https://bugs.webkit.org/show_bug.cgi?id=180526
3280
3281         Reviewed by Frédéric Wang.
3282
3283         Add unit tests for both parse modes of ParsedContentType.
3284
3285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3286         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3287         (TestWebKitAPI::TEST):
3288
3289 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3290
3291         [ews-app] fetch loop should not stop on network issues
3292         https://bugs.webkit.org/show_bug.cgi?id=193666
3293
3294         Reviewed by Lucas Forschler.
3295
3296         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3297         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3298
3299 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3300
3301         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3302         https://bugs.webkit.org/show_bug.cgi?id=189165
3303         <rdar://problem/47433765>
3304
3305         Reviewed by Tim Horton.
3306
3307         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3308         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3309         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3310         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3311         would make its way to the UI process by the time the layer tree commit is finished.
3312
3313         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3314         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3315         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3316         will fail because it asks for -_autofillContext too early.
3317
3318         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3319         is handled in the UI process.
3320
3321         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3322
3323         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3324         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3325         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3326         input session.
3327
3328         (-[AutofillTestView textInputHasAutofillContext]):
3329
3330         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3331
3332         * TestWebKitAPI/cocoa/TestWKWebView.h:
3333         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3334         (nextInputSessionChangeCount):
3335
3336         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3337         This includes changing the focused element from one to another.
3338
3339         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3340         (-[TestWKWebView didStartFormControlInteraction]):
3341         (-[TestWKWebView didEndFormControlInteraction]):
3342         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3343
3344         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3345         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3346         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3347         that doesn't require an input session to one that doesn't.
3348
3349 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3350
3351         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3352         <https://webkit.org/b/193676>
3353
3354         Reviewed by Alexey Proskuryakov.
3355
3356         * Scripts/webkitpy/style/checkers/cpp.py:
3357         (check_member_initialization_list):
3358         - Don't report missing whitespace around colon if the colon at
3359           the start of the line is formatted correctly.
3360         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3361         (WebKitStyleTest.test_member_initialization_list):
3362         - Add a test for a missing permutation of existing tests.
3363         - Add a test this false-positive.
3364         - Add blank lines between subtests to make them easier to read.
3365
3366 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3367
3368         [build.webkit.org] Unit-test failure after r237113
3369         https://bugs.webkit.org/show_bug.cgi?id=193669
3370
3371         Reviewed by Michael Catanzaro.
3372
3373         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3374         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3375         multiple or zero flags.
3376
3377 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3378
3379         Cache bytecode to disk
3380         https://bugs.webkit.org/show_bug.cgi?id=192782
3381         <rdar://problem/46084932>
3382
3383         Reviewed by Keith Miller.
3384
3385         Add test helper to execute bytecode-cache tests: it executes each test
3386         twice, the first with JSC_diskCachePath set to a temporary directory
3387         and second with JSC_forceDiskCache=true (in addition to the cache path)
3388         to guarantee that only the disk cache is being used and no new
3389         UnlinkedCodeBlocks are being created.
3390
3391         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3392         * Scripts/run-jsc-stress-tests:
3393
3394 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3395
3396         [css-logical] Implement flow-relative margin, padding and border shorthands
3397         https://bugs.webkit.org/show_bug.cgi?id=188697
3398
3399         Reviewed by Simon Fraser and Antti Koivisto.
3400
3401         * DumpRenderTree/TestOptions.cpp:
3402         (TestOptions::TestOptions):
3403         * DumpRenderTree/TestOptions.h:
3404         * DumpRenderTree/mac/DumpRenderTree.mm:
3405         (setWebPreferencesForTestOptions):
3406         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3407
3408         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3409         (JSONCSSPropertiesChecker.check_codegen_properties):
3410         Allow CSS property definitions to have a 'runtime-flag' parameter which
3411         disables the property when the specified runtime flag is disabled.
3412
3413 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3414
3415         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3416         https://bugs.webkit.org/show_bug.cgi?id=193643
3417
3418         Reviewed by Michael Catanzaro.
3419
3420         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3421         * wpe/jhbuild.modules: Ditto.
3422
3423 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3424
3425         [LFC][Floats] Take float top position into account when computing containing block height.
3426         https://bugs.webkit.org/show_bug.cgi?id=193655
3427
3428         Reviewed by Antti Koivisto.
3429
3430         * LayoutReloaded/misc/LFC-passing-tests.txt:
3431
3432 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3433
3434         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3435         <https://webkit.org/b/193645>
3436         <rdar://problem/47421574>
3437
3438         Reviewed by Alex Christensen.
3439
3440         - Now checks for local soft-linking of all frameworks that have
3441           their own *SoftLinking.{cpp,h,mm} files.
3442         - Changes softlink/uikit warning to softlink/framework.
3443
3444         * Scripts/webkitpy/style/checkers/cpp.py:
3445         (check_language):
3446         (CppChecker):
3447         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3448         (CppStyleTest):
3449
3450 2019-01-20  Saam Barati  <sbarati@apple.com>
3451
3452         Rollout r240210: It broke tests on iOS
3453         https://bugs.webkit.org/show_bug.cgi?id=193640
3454
3455         Unreviewed.
3456
3457         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3458         * Scripts/run-jsc-stress-tests:
3459
3460 2019-01-20  chris fleizach  <cfleizach@apple.com>
3461
3462         AX: Support returning relative frames for accessibility
3463         https://bugs.webkit.org/show_bug.cgi?id=193414
3464         <rdar://problem/47268501>
3465
3466         Reviewed by Zalan Bujtas.
3467
3468         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3469         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3470         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3471         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3472         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3473         (WTR::attributesOfElement):
3474         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3475
3476 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3477
3478         Unreviewed, add my new email address
3479
3480         * Scripts/webkitpy/common/config/contributors.json:
3481
3482 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3483
3484         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3485         https://bugs.webkit.org/show_bug.cgi?id=193617
3486
3487         Reviewed by Antti Koivisto.
3488
3489         * LayoutReloaded/misc/LFC-passing-tests.txt:
3490
3491 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3492
3493         Unreviewed, rolling out r240209.
3494
3495         Broke GTK/WPE injected bundle
3496
3497         Reverted changeset:
3498
3499         "AX: Support returning relative frames for accessibility"
3500         https://bugs.webkit.org/show_bug.cgi?id=193414
3501         https://trac.webkit.org/changeset/240209
3502
3503 2019-01-12  Dan Bernstein  <mitz@apple.com>
3504
3505         [Cocoa] Avoid importing directly from subumbrella frameworks
3506         https://bugs.webkit.org/show_bug.cgi?id=186016
3507         <rdar://problem/40591038>
3508
3509         Reviewed by Sam Weinig.
3510
3511         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3512           LaunchServices header.
3513         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3514           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3515         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3516           when using SDKs earlier than 10.13.
3517         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3518           and OTHER_CPLUSPLUSFLAGS.
3519         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3520           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3521         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3522           LaunchServices header.
3523
3524 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3525
3526         Cache bytecode to disk
3527         https://bugs.webkit.org/show_bug.cgi?id=192782
3528         <rdar://problem/46084932>
3529
3530         Reviewed by Keith Miller.
3531
3532         Add test helper to execute bytecode-cache tests: it executes each test
3533         twice, the first with JSC_diskCachePath set to a temporary directory
3534         and second with JSC_forceDiskCache=true (in addition to the cache path)
3535         to guarantee that only the disk cache is being used and no new
3536         UnlinkedCodeBlocks are being created.
3537
3538         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3539         * Scripts/run-jsc-stress-tests:
3540
3541 2019-01-20  chris fleizach  <cfleizach@apple.com>
3542
3543         AX: Support returning relative frames for accessibility
3544         https://bugs.webkit.org/show_bug.cgi?id=193414
3545         <rdar://problem/47268501>
3546
3547         Reviewed by Zalan Bujtas.
3548
3549         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3550         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3551         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3552         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3553         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3554         (WTR::attributesOfElement):
3555         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3556
3557 2019-01-20  Antoine Quint  <graouts@apple.com>
3558
3559         Add a POINTER_EVENTS feature flag
3560         https://bugs.webkit.org/show_bug.cgi?id=193577
3561         <rdar://problem/47408511>
3562
3563         Unreviewed. Also enable Pointer Events for iosmac.
3564
3565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3566
3567 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3568
3569         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3570         https://bugs.webkit.org/show_bug.cgi?id=193613
3571
3572         Reviewed by Antti Koivisto.
3573
3574         * LayoutReloaded/misc/LFC-passing-tests.txt:
3575
3576 2019-01-19  Antoine Quint  <graouts@apple.com>
3577
3578         Add a POINTER_EVENTS feature flag
3579         https://bugs.webkit.org/show_bug.cgi?id=193577
3580
3581         Reviewed by Dean Jackson.
3582
3583         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3584
3585 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3586
3587         Disable the run-jsc-stress-test remote host key check [second round].
3588         https://bugs.webkit.org/show_bug.cgi?id=192988
3589
3590         Reviewed by Dewei Zhu.
3591
3592         * Scripts/run-jsc-stress-tests:
3593
3594 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3595
3596         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3597         https://bugs.webkit.org/show_bug.cgi?id=193597
3598
3599         Reviewed by Lucas Forschler.
3600
3601         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3602
3603 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3604
3605         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3606         https://bugs.webkit.org/show_bug.cgi?id=193595
3607
3608         Reviewed by Lucas Forschler.
3609
3610         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3611         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3612         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3613
3614 2019-01-18  Chris Dumez  <cdumez@apple.com>
3615
3616         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3617         https://bugs.webkit.org/show_bug.cgi?id=193588
3618         <rdar://problem/47131566>
3619
3620         Reviewed by Alex Christensen.
3621
3622         Add layout test coverage.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3625
3626 2019-01-18  Jer Noble  <jer.noble@apple.com>
3627
3628         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3629         https://bugs.webkit.org/show_bug.cgi?id=189553
3630
3631         Reviewed by Tim Horton.
3632
3633         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3634
3635         * ContentExtensionTester/Configurations/Base.xcconfig:
3636         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3637         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3638         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3639         * ImageDiff/cg/Configurations/Base.xcconfig:
3640         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3641         * MiniBrowser/Configurations/Base.xcconfig:
3642         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3643         * MobileMiniBrowser/Configurations/Base.xcconfig:
3644         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3645         * Scripts/webkitpy/style/checker.py:
3646         (_all_categories):
3647         (FileType):
3648         (CheckerDispatcher._file_type):
3649         (CheckerDispatcher._create_checker):
3650         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3651         (SDKVariantChecker):
3652         (SDKVariantChecker.__init__):
3653         (SDKVariantChecker.check):
3654         * TestWebKitAPI/Configurations/Base.xcconfig:
3655         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3656         * WebEditingTester/Configurations/Base.xcconfig:
3657         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3658         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3659         * WebKitTestRunner/Configurations/Base.xcconfig:
3660         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3661         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3662         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3663
3664 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3665
3666         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3667         <https://webkit.org/b/193568>
3668         <rdar://problem/47381130>
3669
3670         Reviewed by Alex Christensen.
3671
3672         Make sure no one re-introduces UIKit soft-linking by adding a
3673         style rule.
3674
3675         * Scripts/webkitpy/style/checkers/cpp.py:
3676         (check_language): Add softlink/uikit check.
3677         (CppChecker): Enable softlink/uikit check.
3678         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3679         (CppStyleTest): Add test for softlink/uikit.
3680
3681 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3682
3683         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3684         https://bugs.webkit.org/show_bug.cgi?id=193584
3685
3686         Change "-dev" to "-devel".
3687
3688         Reviewed by Michael Catanzaro.
3689
3690         * gtk/install-dependencies:
3691
3692 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3693
3694         webkitpy: Add iPhone and iPad ports
3695         https://bugs.webkit.org/show_bug.cgi?id=193537
3696         <rdar://problem/47353390>
3697
3698