25d08e624aacfabb387cee7245c43cae405e0978
[WebKit-https.git] / Tools / ChangeLog
1 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2
3         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
4         highlight after being tapped to style a selection"
5         https://bugs.webkit.org/show_bug.cgi?id=147278
6
7         Reviewed by Ryosuke Niwa.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10
11         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
12         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
13         (TestWebKitAPI::TEST):
14         Load a page with the string "Hello, world!", then select "world" and
15         underline it. Test that the typing attributes for the current selection
16         include the underline attribute.
17
18 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
19
20         Unreviewed, updated my nick name in contributors.json
21
22         * Scripts/webkitpy/common/config/contributors.json:
23
24 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
25
26         AX: scrollable elements do not allow 3-finger swipe
27         https://bugs.webkit.org/show_bug.cgi?id=141893
28
29         Reviewed by Mario Sanchez Prada.
30
31         Support global notification listeners for iOS code.
32         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
33         Implement scrollUp/Down/Left/Right.
34
35         * DumpRenderTree/AccessibilityController.h:
36         * DumpRenderTree/AccessibilityUIElement.cpp:
37         (increaseTextSelectionCallback):
38         (scrollPageUpCallback):
39         (scrollPageDownCallback):
40         (scrollPageLeftCallback):
41         (scrollPageRightCallback):
42         (decreaseTextSelectionCallback):
43         (getElementTextLengthCallback):
44         (AccessibilityUIElement::getJSClass):
45         * DumpRenderTree/AccessibilityUIElement.h:
46         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
47         (AccessibilityController::~AccessibilityController):
48         (AccessibilityController::elementAtPoint):
49         (AccessibilityController::addNotificationListener):
50         (AccessibilityController::platformResetToConsistentState):
51         (AccessibilityController::removeNotificationListener):
52         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
53         (AccessibilityUIElement::AccessibilityUIElement):
54         (AccessibilityUIElement::subrole):
55         (AccessibilityUIElement::scrollPageUp):
56         (AccessibilityUIElement::scrollPageDown):
57         (AccessibilityUIElement::scrollPageLeft):
58         (AccessibilityUIElement::scrollPageRight):
59         (AccessibilityUIElement::roleDescription):
60         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
61         (-[AccessibilityNotificationHandler _notificationReceived:]):
62         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
63         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
64         (WTR::AccessibilityUIElement::linkedElement):
65         (WTR::AccessibilityUIElement::headerElementAtIndex):
66         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
67         (WTR::AccessibilityUIElement::scrollPageUp):
68         (WTR::AccessibilityUIElement::scrollPageDown):
69         (WTR::AccessibilityUIElement::scrollPageLeft):
70         (WTR::AccessibilityUIElement::scrollPageRight):
71         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
72         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
73         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
74         (WTR::AccessibilityController::addNotificationListener):
75         (WTR::AccessibilityController::removeNotificationListener):
76         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
77         (WTR::AccessibilityUIElement::AccessibilityUIElement):
78         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
79         (WTR::AccessibilityUIElement::scrollPageUp):
80         (WTR::AccessibilityUIElement::scrollPageDown):
81         (WTR::AccessibilityUIElement::scrollPageLeft):
82         (WTR::AccessibilityUIElement::scrollPageRight):
83         (WTR::AccessibilityUIElement::increaseTextSelection):
84
85 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
86
87         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
88         https://bugs.webkit.org/show_bug.cgi?id=147279
89         <rdar://problem/21990767>
90
91         Reviewed by Dean Jackson.
92
93         * DumpRenderTree/win/TestRunnerWin.cpp:
94         (TestRunner::addUserScript):
95         (TestRunner::addUserStyleSheet):
96         (TestRunner::setDeveloperExtrasEnabled):
97
98 2015-07-24  Basile Clement  <basile_clement@apple.com>
99
100         Call fixChangeLogPatch when generating patches from webkit-patch
101         https://bugs.webkit.org/show_bug.cgi?id=147248
102
103         Reviewed by Geoffrey Garen.
104
105         When two consecutive patches are from the same author, diff tools
106         create wrong-looking diffs for ChangeLog files where the apparent added
107         author is actually the previous patch's author line, making it awkward
108         to read - and things only get worse when committing a patch and a
109         followup fix for the same bug shortly after.
110
111         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
112         this, which we use in perl scripts (svn-create-patch et al). But it is
113         not used by webkit-patch, which is a python script, and thus creates
114         "bad" diffs.
115
116         In the long term, we should probably port fixChangeLogPatch to python -
117         but in the short term, let's make webkit-patch call perl to run
118         fixChangeLogPatch. We are already making various external calls there
119         anyway.
120
121         * Scripts/webkitpy/common/checkout/scm/git.py:
122         (Git.create_patch):
123         * Scripts/webkitpy/common/checkout/scm/scm.py:
124         (SCM.fix_changelog_patch):
125         * Scripts/webkitpy/common/checkout/scm/svn.py:
126         (SVN.create_patch):
127
128 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
129
130         commit-queue flags in webkit-patch are confusing
131         https://bugs.webkit.org/show_bug.cgi?id=88694
132
133         Reviewed by Csaba Osztrogonác.
134
135         * Scripts/webkitpy/tool/steps/options.py:
136         (Options): Updated help string to be more descriptive.
137
138 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
139
140         [Win] Implement proper High DPI support features
141         https://bugs.webkit.org/show_bug.cgi?id=146335
142         <rdar://problem/21558269>
143
144         Reviewed by Alex Christensen.
145
146         Update WinLauncher to take device scaling factor into account.
147
148         * WinLauncher/Common.cpp:
149         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
150         a valid font.
151         (computeFullDesktopFrame): Handle high DPI desktops.
152         (WndProc): Make comments more precise.
153         * WinLauncher/WinLauncher.cpp:
154         (WinLauncher::init): Determine device scale factor at launch.
155         (WinLauncher::updateDeviceScaleFactor): Added.
156         * WinLauncher/WinLauncher.h:
157         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
158         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
159         (wWinMain): Ditto.
160         * win/DLLLauncher/DLLLauncherMain.cpp:
161         (wWinMain): Tell Windows we understand high DPI.
162
163 2015-07-23  Alex Christensen  <achristensen@webkit.org>
164
165         [Win] Unreviewed build fix after r187169.
166
167         * Scripts/build-webkit:
168         Correctly find WebKit.sln.
169
170 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
171
172         [GTK] Add API to allow executing editing commands that require an argument
173         https://bugs.webkit.org/show_bug.cgi?id=146781
174
175         Reviewed by Gustavo Noronha Silva.
176
177         Add buttons to insert image/link to the MiniBrowser edit toolbar,
178         and test cases for insert image/link commands too.
179
180         * MiniBrowser/gtk/BrowserWindow.c:
181         (insertImageCommandCallback):
182         (insertLinkCommandCallback):
183         (browserWindowSetupEditorToolbar):
184         (browserWindowConstructed):
185         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
186         (testWebViewEditorInsertImage):
187         (testWebViewEditorCreateLink):
188         (beforeAll):
189
190 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
191
192         Unregistering and re-registering a user message handler does not work
193         https://bugs.webkit.org/show_bug.cgi?id=138142
194
195         Reviewed by Martin Robinson.
196
197         This has probably been fixed in r184846, enable the test case
198         blocked on it.
199
200         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
201         (testUserContentManagerScriptMessageReceived):
202
203 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
204
205         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
206         https://bugs.webkit.org/show_bug.cgi?id=147212
207
208         Reviewed by Filip Pizlo.
209
210         * Scripts/webkitperl/FeatureList.pm:
211
212 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
213
214         Add --ios-simulator to run-api-tests --help.
215
216         Rubber-stamped by Dan Bates.
217
218         * Scripts/run-api-tests:
219
220 2015-07-22  Jason Marcell  <jmarcell@apple.com>
221
222         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
223         https://bugs.webkit.org/show_bug.cgi?id=147043
224
225         Reviewed by Daniel Bates and Alexey Proskuryakov.
226
227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
228         (Buildbot.prototype._normalizeQueueInfo):
229         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
230         in cases where the queue.branch property is not set and the queue is not a combined queue.
231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
232         (BuildbotCombinedQueueView):
233         Ensuring uniformity of repository branches within a combined queue.
234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
235         (WebKitBuildbot.prototype.get defaultBranches):
236         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
237         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
238         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
239         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
240         implement defaultBranches so that a person can either update the definition of the sub-queue or
241         implement defaultBranches in the derived Buildbot class they are using.
242
243 2015-07-22  Alex Christensen  <achristensen@webkit.org>
244
245         Switch WinCairo build to use CMake.
246         https://bugs.webkit.org/show_bug.cgi?id=147169
247
248         Reviewed by Brent Fulgham.
249
250         * Scripts/build-webkit:
251         * Scripts/webkitdirs.pm:
252         (determineConfiguration):
253         (determineArchitecture):
254         (determinePassedConfiguration):
255         (passedConfiguration):
256         (jhbuildWrapperPrefixIfNeeded):
257         (generateBuildSystemFromCMakeProject):
258         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
259
260 2015-07-22  Alex Christensen  <achristensen@webkit.org>
261
262         Fix quirks in CMake build on Mac and Windows
263         https://bugs.webkit.org/show_bug.cgi?id=147174
264
265         Reviewed by Gyuyoung Kim.
266
267         * CMakeLists.txt:
268         Don't build DumpRenderTree with CMake for now (until we get that working).
269         * WinLauncher/CMakeLists.txt:
270         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
271
272 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
273
274         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
275         https://bugs.webkit.org/show_bug.cgi?id=147146
276
277         Reviewed by Darin Adler.
278
279         * Scripts/webkitpy/style/checkers/cpp.py:
280         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
281         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
282         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
283
284 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
285
286         Fixed VM pool allocation should have a reserve for allocations that cannot fail
287         https://bugs.webkit.org/show_bug.cgi?id=147154
288         rdar://problem/21847618
289
290         Reviewed by Geoffrey Garen.
291         
292         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
293         mitigations work, these should all pass. Prior to this patch there were >20 failures.
294
295         * Scripts/run-jsc-stress-tests:
296
297 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
298
299         [GTK] Add API to be notified about editor state changes
300         https://bugs.webkit.org/show_bug.cgi?id=145875
301
302         Reviewed by Gustavo Noronha Silva.
303
304         Update the typing attributes toggle buttons state according to the
305         editor state in MiniBrowser, and add a test case to the
306         WebViewEditor unit tests.
307
308         * MiniBrowser/gtk/BrowserWindow.c:
309         (browserWindowEditingCommandToggleButtonSetActive):
310         (typingAttributesChanged):
311         (browserWindowSetupEditorToolbar):
312         (browserWindowConstructed):
313         (browser_window_init):
314         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
315         (testWebViewEditorEditorStateTypingAttributes):
316         (beforeAll):
317
318 2015-07-20  Tomas Popela  <tpopela@redhat.com>
319
320         [GTK] Add selection-changed signal to the WebKit2 API
321         https://bugs.webkit.org/show_bug.cgi?id=137116
322
323         Reviewed by Carlos Garcia Campos.
324
325         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
326         (namely the selection-changed signal).
327
328         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
329         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
330         (WebKitWebEditorTest::create):
331         (WebKitWebEditorTest::selectionChangedCallback):
332         (WebKitWebEditorTest::testSelectionSelectAll):
333         (WebKitWebEditorTest::testSelectionCollapse):
334         (WebKitWebEditorTest::testSelectionModifyMove):
335         (WebKitWebEditorTest::testSelectionModifyExtend):
336         (WebKitWebEditorTest::testSelectionUnselect):
337         (registerTests):
338         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
339         (testWebKitWebEditorSelectionChanged):
340         (beforeAll):
341         (afterAll):
342
343 2015-07-20  Alex Christensen  <achristensen@webkit.org>
344
345         Resurrect CMake build on Windows.
346         https://bugs.webkit.org/show_bug.cgi?id=147083
347
348         Reviewed by Gyuyoung Kim.
349
350         * DumpRenderTree/CMakeLists.txt:
351         * DumpRenderTree/PlatformWin.cmake: Added.
352         * WinLauncher/CMakeLists.txt:
353
354 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
355
356         [GTK] Enable seccomp filter API tests
357         https://bugs.webkit.org/show_bug.cgi?id=140071
358
359         Reviewed by Žan Doberšek.
360
361         These tests will now be run by the run-gtk-tests script.
362
363         * TestWebKitAPI/PlatformGTK.cmake:
364
365 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
366
367         [GTK] Add seccomp filters support
368         https://bugs.webkit.org/show_bug.cgi?id=110014
369
370         Reviewed by Žan Doberšek.
371
372         Add libseccomp to jhbuild modulesets.
373
374         * gtk/jhbuild.modules:
375
376 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
377
378         MiniBrowser window title is just "Window" when page has no <title>
379         https://bugs.webkit.org/show_bug.cgi?id=147076
380
381         Reviewed by Tim Horton.
382         
383         Make MiniBrowser windows show the filename from the URL if we never get a title changed
384         notification.
385
386         * MiniBrowser/mac/WK1BrowserWindowController.m:
387         (-[WK1BrowserWindowController updateTitle:]):
388         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
389         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
390         * MiniBrowser/mac/WK2BrowserWindowController.m:
391         (-[WK2BrowserWindowController updateTitle:]):
392         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
393         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
394
395 2015-07-17  Andy Estes  <aestes@apple.com>
396
397         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
398         https://bugs.webkit.org/show_bug.cgi?id=147044
399         rdar://problem/21567820
400
401         Reviewed by Brady Eidson.
402
403         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
404         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
405         This matches the behavior of DumpRenderTree.
406
407 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
408
409         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
410         https://bugs.webkit.org/show_bug.cgi?id=147032
411
412         Reviewed by Alex Christensen.
413
414         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
415         Test that the useless terms are eliminated by counting
416         the number of NFA nodes generated.
417
418 2015-07-17  Dan Bernstein  <mitz@apple.com>
419
420         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
421         https://bugs.webkit.org/show_bug.cgi?id=147040
422
423         Reviewed by Dean Jackson.
424
425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
426         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
427         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
428         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
429         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
430         (TEST):
431
432 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
433
434         webkit-patch uses incorrect credentials from keychain to login until account lockout
435         https://bugs.webkit.org/show_bug.cgi?id=146923
436
437         Reviewed by Daniel Bates.
438
439         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
440         provide incorrect credentials then ask for them to be saved to the keychain
441         webkit-patch will then use those incorrect credentials until 5 total attempts
442         have been made to log in. This will lock the user out of Bugzilla for a
443         half hour.
444
445         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
446         (Bugzilla.authenticate): Added argument to read_credentials() that
447         passes in whether or not to use stored credentials.
448         * Scripts/webkitpy/common/net/credentials.py:
449         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
450         that specifies whether or not to use credentials stored on the system. If it
451         does, we do not auto-fill credentials since either the credentials caused
452         the failure, or they weren't used in the first place so there is no reason
453         to try and use them again if a failure happened.
454         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
455         use_stored_credentials argument.
456         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
457         retrieve username/password information from the local system (environment, Git, keychain,
458         keyring) are never called. It also tests that we get back our mocked username and password.
459         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
460         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
461         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
462         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
463         is never called.
464         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
465         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
466         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
467         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
468         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
469         against.
470
471 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
472
473         Unreviewed, remove my redundant email information.
474
475         * Scripts/webkitpy/common/config/contributors.json:
476
477 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
478
479         Unreviewed. Add Hyungwook Lee as a committer.
480
481         * Scripts/webkitpy/common/config/contributors.json:
482
483 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
484
485         Added myself to the list of contributors.
486
487         Reviewed by Brent Fulgham.
488
489         * Scripts/webkitpy/common/config/contributors.json:
490
491 2015-07-16  Alex Christensen  <achristensen@webkit.org>
492
493         [Content Extensions] Cache domain actions
494         https://bugs.webkit.org/show_bug.cgi?id=146817
495
496         Reviewed by Benjamin Poulain.
497
498         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
499         (TestWebKitAPI::TEST_F):
500         Test if-domain and unless-domain with multiple load types.
501
502 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
503
504         [Content extensions] Combine suffixes when generating NFAs
505         https://bugs.webkit.org/show_bug.cgi?id=146961
506
507         Reviewed by Alex Christensen.
508
509         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
510         (TestWebKitAPI::compareContents):
511         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
512
513 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
514
515         [GTK] Input method filter is always enabled when the view is focused
516         https://bugs.webkit.org/show_bug.cgi?id=146965
517
518         Reviewed by Martin Robinson.
519
520         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
521
522         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
523         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
524
525 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
526
527         [EFL] Bump libseccomp version to 2.2.3
528         https://bugs.webkit.org/show_bug.cgi?id=146980
529
530         Reviewed by Gyuyoung Kim.
531
532         * efl/jhbuild.modules:
533
534 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
535
536         [Win] Maintain consistent COM Interfaces
537         https://bugs.webkit.org/show_bug.cgi?id=146983
538         <rdar://problem/21822278>
539
540         Reviewed by Dean Jackson.
541
542         Update DumpRenderTree and WinLauncher to use the properly
543         versioned COM interface objects.
544
545         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
546         (AccessibilityController::rootElement):
547         * DumpRenderTree/win/DumpRenderTree.cpp:
548         (resetWebPreferencesToConsistentValues):
549         (resetWebViewToConsistentStateBeforeTesting):
550         (runTest):
551         (createWebViewAndOffscreenWindow):
552         * DumpRenderTree/win/EditingDelegate.cpp:
553         (EditingDelegate::QueryInterface):
554         (EditingDelegate::shouldEndEditingInDOMRange):
555         (EditingDelegate::shouldInsertNode):
556         * DumpRenderTree/win/EditingDelegate.h:
557         * DumpRenderTree/win/EventSender.cpp:
558         (scalePageByCallback):
559         * DumpRenderTree/win/FrameLoadDelegate.cpp:
560         (FrameLoadDelegate::didCommitLoadForFrame):
561         * DumpRenderTree/win/TestRunnerWin.cpp:
562         (TestRunner::callShouldCloseOnWebView):
563         (TestRunner::applicationCacheDiskUsageForOrigin):
564         (TestRunner::clearApplicationCacheForOrigin):
565         (TestRunner::setDefersLoading):
566         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
567         (TestRunner::setTabKeyCyclesThroughElements):
568         (TestRunner::setValueForUser):
569         (TestRunner::dispatchPendingLoadRequests):
570         (TestRunner::setWindowIsKey):
571         (TestRunner::execCommand):
572         (TestRunner::addOriginAccessWhitelistEntry):
573         (TestRunner::removeOriginAccessWhitelistEntry):
574         (TestRunner::addUserScript):
575         (TestRunner::addUserStyleSheet):
576         (TestRunner::showWebInspector):
577         (TestRunner::closeWebInspector):
578         (TestRunner::evaluateInWebInspector):
579         (TestRunner::setSerializeHTTPLoads):
580         * DumpRenderTree/win/TextInputControllerWin.cpp:
581         (TextInputController::setMarkedText):
582         (TextInputController::hasMarkedText):
583         (TextInputController::unmarkText):
584         (TextInputController::markedRange):
585         (TextInputController::insertText):
586         (TextInputController::firstRectForCharacterRange):
587         (TextInputController::selectedRange):
588         * DumpRenderTree/win/UIDelegate.h:
589         (UIDelegate::unused2):
590         (UIDelegate::unused3):
591         (UIDelegate::webViewScrolled):
592         (UIDelegate::webViewShouldInterruptJavaScript):
593         (UIDelegate::webViewReceivedFocus):
594         (UIDelegate::unused4): Deleted.
595         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
596         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
597         * WinLauncher/PageLoadTestClient.cpp:
598         (PageLoadTestClient::didStartProvisionalLoad):
599         * WinLauncher/WinLauncher.cpp:
600         (WinLauncher::init):
601         * WinLauncher/WinLauncher.h:
602         * WinLauncher/WinLauncherWebHost.cpp:
603         (WinLauncherWebHost::didFinishLoadForFrame):
604         (WinLauncherWebHost::didFirstLayoutInFrame):
605         * WinLauncher/WinLauncherWebHost.h:
606
607 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
608
609         Many test failures in scm_unittest.py
610         https://bugs.webkit.org/show_bug.cgi?id=143967
611
612         Reviewed by Daniel Bates. 
613
614         * Scripts/webkitpy/common/checkout/scm/detection.py:
615         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
616         absolute canonical file paths. Two mutually exclusive issues cause this
617         to be a problem.
618             1) Python's os.path.relpath() function does not return correct relative
619             paths between two filepaths that point to the same file, if symlinks are
620             involved.
621                 On Mac, /tmp points to /private/tmp
622                 ex. os.path.relpath('/tmp', '/private/tmp')
623                     returns '../../tmp'
624             What we want is actually just '.'
625             2) Git does not allow file paths to trace outside of
626             the Git repository. This means that if you have a repository in
627             /tmp and you refer to that repository when invoking a git command as
628             ../tmp, Git will produce errors about working outside of the repository.
629         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
630         its default behavior and such, needed to be updated.
631         (Git.changed_files): '--' was added into the command so that patch_directories
632         were taken as positional arguments.
633         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
634         in the GitSVNTest class to more closely emulate the version of Git that the tests
635         assumed a system had. Also fixed a small side-effect from the absolute canonical
636         path fix in SCMDetector.detect_scm_system
637         (SVNTestRepository.setup): A relative filepath was previously passed as the
638         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
639         an absolute canonical path before being passed in. The failing test
640         was a "sanity check" that the svn.checkout_root and scm.checkout_root
641         were the same.
642         (GitSVNTest._setup_git_checkout):
643             1) Added "--prefix ''" option to `git clone` since Git changed its default
644             behavior in version 2.0.
645             2) The branch master was renamed to trunk to more closely emulate what
646             tests expected when they were written. 
647         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
648         original tests failed because the tests expected the trunk branch
649         to produce its parent's commit, whereas Git merely provides the HEAD commit
650         for a given branch (trunk in this case). Based on other tests written
651         in the same commit, it appears these tests were failing from the point they
652         were written.
653
654 2015-07-14  Anders Carlsson  <andersca@apple.com>
655
656         Assertions.h should include ExportMacros.h
657         https://bugs.webkit.org/show_bug.cgi?id=146948
658
659         Reviewed by Tim Horton.
660
661         Remove now unneeded WTF_EXPORT_PRIVATE define.
662
663         * DumpRenderTree/cg/ImageDiffCG.cpp:
664
665 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
666
667         [GTK] [Wayland] Build by default the X11 and Wayland targets.
668         https://bugs.webkit.org/show_bug.cgi?id=146057
669
670         Reviewed by Carlos Garcia Campos.
671
672         * gtk/install-dependencies:
673
674 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
675
676         [Mac] Unable to dismiss context menu during test runs
677         https://bugs.webkit.org/show_bug.cgi?id=146836
678
679         Reviewed by Tim Horton.
680
681         Since Context Menus are modal, the test system would block on the displayed context menu,
682         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
683         mouse click and generate the menu contents, but not ask AppKit to display it.
684
685         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
686
687         * DumpRenderTree/mac/EventSendingController.mm:
688         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
689         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
690         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
691         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
692         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
693         work without actually calling on AppKit to display the menu.
694         ask WebCore to do all the work EXCEPT displaying the menu.
695         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
696         * WebKitTestRunner/mac/EventSenderProxy.mm:
697         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
698
699 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
700
701         It should be possible to run the OSR exit fuzzer
702         https://bugs.webkit.org/show_bug.cgi?id=146814
703
704         Reviewed by Mark Lam.
705         
706         This runs a test command to detect how many static OSR exit sites it had, and then for
707         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
708         middle opportunity), plus a mode where the check always exits. This is an exhaustive
709         search, so in the future it'll be very appropriate for cases where we have a simple test
710         and we want to see what happens when you eventually exit in this test.
711         
712         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
713         and it seems to do the right thing.
714
715         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
716         (fail):
717
718 2015-07-10  Alex Christensen  <achristensen@webkit.org>
719
720         Add tests for r186649
721         https://bugs.webkit.org/show_bug.cgi?id=146821
722
723         Reviewed by Darin Adler.
724
725         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
726         (TestWebKitAPI::TEST_F):
727         (TestWebKitAPI::compareContents):
728         (TestWebKitAPI::expectedIndex):
729         Add some larger tests to test large jumps.
730
731 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
732
733         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
734         https://bugs.webkit.org/show_bug.cgi?id=146820
735
736         Reviewed by Ryosuke Niwa.
737
738         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
739         (OSXBrowserDriver):
740         (OSXBrowserDriver.close_browsers):
741         (OSXBrowserDriver._terminiate_processes):
742         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
743         (OSXChromeDriver):
744         (OSXChromeCanaryDriver):
745         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
746         (OSXFirefoxDriver):
747         (OSXFirefoxNightlyDriver):
748         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
749         (OSXSafariDriver):
750
751 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
752
753         [GTK] pango should be included in the default jhbuild moduleset
754         https://bugs.webkit.org/show_bug.cgi?id=146683
755
756         Reviewed by Martin Robinson.
757
758         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
759         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
760         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
761         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
762         the same problem again the next time pango wants to use a new fontconfig feature), or remove
763         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
764         best.
765
766         * gtk/jhbuild-optional.modules: Remove pango
767         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
768
769 2015-07-09  Devin Rousso  <drousso@apple.com>
770
771         Unreviewed.  Added myself as a committer.
772
773         * Scripts/webkitpy/common/config/contributors.json:
774
775 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
776
777         Add a way to set the default URL from Minibrowser UI
778         https://bugs.webkit.org/show_bug.cgi?id=146780
779
780         Reviewed by Simon Fraser.
781
782         * MiniBrowser/mac/AppDelegate.m:
783         (-[BrowserAppDelegate didChangeSettings]):
784         * MiniBrowser/mac/BrowserWindowController.h:
785         * MiniBrowser/mac/BrowserWindowController.m:
786         (-[BrowserWindowController fetch:]):
787         (-[BrowserWindowController reload:]):
788         (-[BrowserWindowController forceRepaint:]):
789         (-[BrowserWindowController goBack:]):
790         (-[BrowserWindowController goForward:]):
791         (-[BrowserWindowController showHideWebView:]):
792         (-[BrowserWindowController removeReinsertWebView:]):
793         (-[BrowserWindowController zoomIn:]):
794         (-[BrowserWindowController zoomOut:]):
795         (-[BrowserWindowController resetZoom:]):
796         (-[BrowserWindowController canZoomIn]):
797         (-[BrowserWindowController canZoomOut]):
798         (-[BrowserWindowController canResetZoom]):
799         (-[BrowserWindowController toggleZoomMode:]):
800         (-[BrowserWindowController setScale:]):
801         (-[BrowserWindowController toggleShrinkToFit:]):
802         (-[BrowserWindowController dumpSourceToConsole:]):
803         (-[BrowserWindowController find:]):
804         (-[BrowserWindowController didChangeSettings]):
805         (-[BrowserWindowController currentURL]):
806         Get rid of the BrowserController protocol. It was a bad idea and confused
807         Interface Builder more than I thought possible.
808
809         * MiniBrowser/mac/SettingsController.m:
810         (-[SettingsController _populateMenu]):
811         (-[SettingsController setDefaultURLToCurrentURL:]):
812         If we have a BrowserWindowController, grab its URL and set the relevant default.
813
814         * MiniBrowser/mac/WK1BrowserWindowController.h:
815         * MiniBrowser/mac/WK1BrowserWindowController.m:
816         (-[WK1BrowserWindowController currentURL]):
817         * MiniBrowser/mac/WK2BrowserWindowController.h:
818         * MiniBrowser/mac/WK2BrowserWindowController.m:
819         (-[WK2BrowserWindowController currentURL]):
820         Retrieve the current URL from the WKView/WebView.
821
822 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
823
824         Increase MiniBrowser location bar maximum width
825         https://bugs.webkit.org/show_bug.cgi?id=146779
826
827         Reviewed by Simon Fraser.
828
829         * MiniBrowser/mac/BrowserWindow.xib:
830         Have an enormous maximum width on the location bar, so that it doesn't
831         stop expanding with the window at 800px.
832
833 2015-07-08  Brady Eidson  <beidson@apple.com>
834
835         Crash calling [WebView close] in didFinishLoadForFrame callback.
836         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
837
838         Reviewed by David Kilzer.
839
840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
841         
842         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
843         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
844         (TestWebKitAPI::TEST):
845
846 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
847
848         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
849         https://bugs.webkit.org/show_bug.cgi?id=146546
850
851         Reviewed by Darin Adler.
852
853         We did't reset pendingNavigationID value when request url is empty.
854         Hence we need to ignore ASSERT check in this case.
855
856         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
857         (TestWebKitAPI::TEST):
858
859 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
860
861         [Content Extensions] Fuse undistinguishable actions as much as possible
862         https://bugs.webkit.org/show_bug.cgi?id=146762
863
864         Reviewed by Alex Christensen.
865
866         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
867         Test that combinations and flags still work as expected.
868
869 2015-07-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
870
871         [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset.
872         https://bugs.webkit.org/show_bug.cgi?id=146056
873
874         Reviewed by Martin Robinson.
875
876         * gtk/install-dependencies: libepoxy is now required for building GTK+.
877         * gtk/jhbuild-wayland.modules: Removed. Not longer needed.
878         * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building:
879         Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1).
880         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed.
881         Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb.
882         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed.
883         GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98.
884
885 2015-07-06  Matt Rajca  <mrajca@apple.com>
886
887         Media Session: propagate metadata changes to UI clients
888         https://bugs.webkit.org/show_bug.cgi?id=146660
889
890         Reviewed by Tim Horton.
891
892         * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient.
893         (WTR::TestController::createOtherPage):
894         (WTR::TestController::createWebViewWithOptions):
895
896 2015-07-07  Brady Eidson  <beidson@apple.com>
897
898         HTTP Auth cached after disabling private browsing/reset.
899         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
900
901         Reviewed by Tim Horton.
902
903         * DumpRenderTree/mac/DumpRenderTree.mm:
904         (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs.
905
906 2015-07-06  Alex Christensen  <achristensen@webkit.org>
907
908         [Content Extensions] Remove memory page reporting
909         https://bugs.webkit.org/show_bug.cgi?id=146659
910
911         Reviewed by Benjamin Poulain.
912
913         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
914         (TestWebKitAPI::TEST_F):
915
916 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
917
918         [Content Extensions] Make the DFA transitions ranges instead of characters
919         https://bugs.webkit.org/show_bug.cgi?id=146575
920
921         Reviewed by Alex Christensen.
922
923         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
924         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
925         Since the minimizer is perfect, we get the minimal solution now,
926         which is really cool!
927
928 2015-07-06  Brady Eidson  <beidson@apple.com>
929
930         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
931         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
932
933         Reviewed by Geoff Garen.
934
935         * WebKitTestRunner/TestInvocation.cpp:
936         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
937           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
938
939 2015-07-06  Daniel Bates  <dabates@apple.com>
940
941         Unreviewed, rolling out r170639.
942
943         Broke using webkit-patch apply-attachment to apply an
944         attachment from a security bug. The patch incorrectly assumed
945         that Bugzilla returns a non-HTTP 200 status code in its HTTP
946         response when authentication is required.
947
948         Reverted changeset:
949
950         "webkit-patch apply-from-bug / apply-attachment should not ask
951         for credentials if none are required"
952         https://bugs.webkit.org/show_bug.cgi?id=40095
953         http://trac.webkit.org/changeset/170639
954
955 2015-07-04  Chris Dumez  <cdumez@apple.com>
956
957         Drop RefPtr::clear() method
958         https://bugs.webkit.org/show_bug.cgi?id=146556
959
960         Reviewed by Brady Eidson.
961
962         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
963
964 2015-07-03  Dan Bernstein  <mitz@apple.com>
965
966         Fixed the iOS build.
967
968         * DumpRenderTree/mac/EventSendingController.mm:
969         (+[EventSendingController isSelectorExcludedFromWebScript:]):
970         (+[EventSendingController webScriptNameForSelector:]):
971
972 2015-07-03  Dan Bernstein  <mitz@apple.com>
973
974         [Xcode] Update some build settings as recommended by Xcode 7
975         https://bugs.webkit.org/show_bug.cgi?id=146597
976
977         Reviewed by Sam Weinig.
978
979         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
980
981         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
982         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
983         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
984         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
985         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
986
987         * DumpRenderTree/mac/EventSendingController.mm:
988         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
989         which was removed in r19101.
990
991         * DumpRenderTree/mac/TextInputController.m:
992         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
993         around used of a selector not that is not declared anywhere.
994
995         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
996
997         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
998
999         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
1000         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
1001         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
1002         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
1003         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
1004
1005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
1006
1007 2015-07-02  Daniel Bates  <dabates@apple.com>
1008
1009         [iOS] Add WebKitSystemInterface for iOS 8.4
1010         https://bugs.webkit.org/show_bug.cgi?id=146548
1011
1012         Rubber-stamped by Zalan Bujtas.
1013
1014         * Scripts/copy-webkitlibraries-to-product-directory:
1015
1016 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1017
1018         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
1019         https://bugs.webkit.org/show_bug.cgi?id=146234
1020
1021         Reviewed by Sergio Villar Senin.
1022
1023         Enable the WebSQL directory test that was disabled because of this bug.
1024
1025         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1026         (testWebContextConfiguration):
1027
1028 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
1029
1030         Enabled MEDIA_STREAM flag
1031         https://bugs.webkit.org/show_bug.cgi?id=145947
1032         <rdar://problem/21365829>
1033         
1034         Reviewed by Eric Carlson.
1035
1036         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1037
1038 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
1039
1040         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
1041         https://bugs.webkit.org/show_bug.cgi?id=144828
1042
1043         Reviewed by Carlos Garcia Campos.
1044
1045         * WebKitTestRunner/gtk/main.cpp:
1046         (main): Use the new WKTextChecker API to set the spell checking languages
1047         when the process is starting up.
1048
1049 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
1050
1051         Implement ECMAScript Internationalization API
1052         https://bugs.webkit.org/show_bug.cgi?id=90906
1053
1054         Reviewed by Benjamin Poulain.
1055
1056         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
1057
1058 2015-06-30  Jonathan Davis  <jond@apple.com>
1059
1060         Unreviewed. Added myself as a committer.
1061
1062         * Scripts/webkitpy/common/config/contributors.json:
1063
1064 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
1065
1066         Unreviewed build fix.
1067
1068         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
1069         to developer.apple.com to get update libraries.
1070
1071 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
1072
1073         Add timeout in run-webkit-tests for launching the simulator
1074         https://bugs.webkit.org/show_bug.cgi?id=146371
1075
1076         Reviewed by Darin Adler.
1077
1078         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
1079         for the otherwise infinitely patient wait_until_device_is_in_state method.
1080
1081         * Scripts/webkitpy/xcode/simulator.py:
1082         (Simulator.DeviceState):
1083         (Simulator):
1084         (Simulator.wait_until_device_is_in_state):
1085         (Simulator.device_state):
1086
1087 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
1088
1089         Make the NFA transitions range-based
1090         https://bugs.webkit.org/show_bug.cgi?id=146338
1091
1092         Reviewed by Alex Christensen.
1093
1094         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1095         Test some new interesting cases.
1096
1097 2015-06-28  Dan Bernstein  <mitz@apple.com>
1098
1099         [Xcode] Use the same environment for command-line and IDE builds
1100         https://bugs.webkit.org/show_bug.cgi?id=146401
1101
1102         Reviewed by Anders Carlsson.
1103
1104         * Scripts/webkitdirs.pm:
1105         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
1106         xcodebuild use the same environment Xcode uses.
1107
1108 2015-06-28  Dan Bernstein  <mitz@apple.com>
1109
1110         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
1111         https://bugs.webkit.org/show_bug.cgi?id=146396
1112
1113         Reviewed by Anders Carlsson.
1114
1115         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1116         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
1117         (TestWebKitAPI::TEST): Updated for renames.
1118         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1119         (runJavaScriptAlert): Removed suffix.
1120         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
1121         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1122         (runJavaScriptAlert): Removed suffix.
1123         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
1124
1125 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1126
1127         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
1128         https://bugs.webkit.org/show_bug.cgi?id=146318
1129
1130         Reviewed by Sergio Villar Senin.
1131
1132         Copy mac PublicSuffix test to the common directory and add it to
1133         the GTK+ build.
1134
1135         * TestWebKitAPI/PlatformGTK.cmake:
1136         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
1137         (TestWebKitAPI::TEST_F):
1138
1139 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
1140
1141         WinLauncher fails to download files.
1142         https://bugs.webkit.org/show_bug.cgi?id=146242
1143
1144         Reviewed by Alex Christensen.
1145
1146         Added WinLauncher download delegate.
1147
1148         * WinLauncher/Common.cpp:
1149         * WinLauncher/WebDownloadDelegate.cpp: Added.
1150         (WebDownloadDelegate::WebDownloadDelegate):
1151         (WebDownloadDelegate::~WebDownloadDelegate):
1152         (WebDownloadDelegate::QueryInterface):
1153         (WebDownloadDelegate::AddRef):
1154         (WebDownloadDelegate::Release):
1155         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
1156         (WebDownloadDelegate::didCancelAuthenticationChallenge):
1157         (WebDownloadDelegate::didCreateDestination):
1158         (WebDownloadDelegate::didFailWithError):
1159         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
1160         (WebDownloadDelegate::didReceiveDataOfLength):
1161         (WebDownloadDelegate::didReceiveResponse):
1162         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
1163         (WebDownloadDelegate::willResumeWithResponse):
1164         (WebDownloadDelegate::willSendRequest):
1165         (WebDownloadDelegate::didBegin):
1166         (WebDownloadDelegate::didFinish):
1167         * WinLauncher/WebDownloadDelegate.h: Added.
1168         * WinLauncher/WinLauncher.cpp:
1169         (WinLauncher::setAccessibilityDelegate):
1170         (WinLauncher::setResourceLoadDelegate):
1171         (WinLauncher::setDownloadDelegate):
1172         (WinLauncher::mainFrame):
1173         * WinLauncher/WinLauncher.h:
1174         (WinLauncher::standardPreferences):
1175         (WinLauncher::privatePreferences):
1176         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1177         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1178         * WinLauncher/WinMain.cpp:
1179         (wWinMain):
1180
1181 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
1182
1183         [EFL] Bump libseccomp version to 2.2.1
1184         https://bugs.webkit.org/show_bug.cgi?id=146341
1185
1186         Reviewed by Gyuyoung Kim.
1187
1188         * efl/jhbuild.modules:
1189         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
1190         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
1191
1192 2015-06-25  Alex Christensen  <achristensen@webkit.org>
1193
1194         [Content Extensions] Add a way to match a domain but not subdomains
1195         https://bugs.webkit.org/show_bug.cgi?id=146241
1196         rdar://problem/21557754
1197
1198         Reviewed by Darin Adler.
1199
1200         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1201         (TestWebKitAPI::TEST_F):
1202         Update subdomain test because of changed behavior and add test for new '*' functionality.
1203
1204 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
1205
1206         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
1207         https://bugs.webkit.org/show_bug.cgi?id=146308
1208
1209         Reviewed by Csaba Osztrogonác.
1210
1211         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
1212
1213         * Scripts/webkitperl/FeatureList.pm:
1214
1215 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1216
1217         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
1218         https://bugs.webkit.org/show_bug.cgi?id=146149
1219
1220         Reviewed by Sergio Villar Senin.
1221
1222         Update unit tests to use WebKitWebsiteDataManager.
1223
1224         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1225         (testWebContextConfiguration):
1226         (serverCallback):
1227         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1228         (Test::Test): Use WebKitWebsiteDataManager and set all possible
1229         values to ensure unit tests don't write outside the temporary directory.
1230         (Test::~Test): Explicitly reset the web context to ensure its
1231         objects are released before the leaks check.
1232         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1233         (WebViewTest::wait): Fix the GSource used, since we are receiving
1234         a double in seconds, but using g_timeout_add_seconds() that
1235         expects an unsigned in seconds. Use GMainLoopSource to correctly
1236         handle the value and simplify the code.
1237
1238 2015-06-24  Jason Marcell  <jmarcell@apple.com>
1239
1240         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
1241         https://bugs.webkit.org/show_bug.cgi?id=146126
1242         <rdar://problem/18226291>
1243
1244         Reviewed by Alexey Proskuryakov.
1245
1246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1247         (documentReady): Using combined queues to display iOS projects
1248
1249 2015-06-24  Doug Russell  <d_russell@apple.com>
1250
1251         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
1252         when posting a selection notification when on the border between two accessibilityObjects
1253         https://bugs.webkit.org/show_bug.cgi?id=146177
1254
1255         Reviewed by Darin Adler.
1256
1257         Add support for mapping WebCore Accessibility types into JSValueRef types
1258         so they can be used in tests.
1259
1260         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1261         (webAccessibilityObjectWrapperClass):
1262         (-[AccessibilityNotificationHandler startObserving]):
1263         (makeValueRefForValue):
1264         (makeArrayRefForArray):
1265         (makeObjectRefForDictionary):
1266         (-[AccessibilityNotificationHandler _notificationReceived:]):
1267         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1268         (webAccessibilityObjectWrapperClass):
1269         (-[AccessibilityNotificationHandler startObserving]):
1270         (makeValueRefForValue):
1271         (makeArrayRefForArray):
1272         (makeObjectRefForDictionary):
1273         (-[AccessibilityNotificationHandler _notificationReceived:]):
1274
1275 2015-06-24  Zalan Bujtas  <zalan@apple.com>
1276
1277         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
1278         https://bugs.webkit.org/show_bug.cgi?id=146273
1279         rdar://problem/18509840
1280
1281         Reviewed by Simon Fraser.
1282
1283         Due to the floating point approximate representation, we can't always produce
1284         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
1285         and by changing the rounding in roundToDevicePixel() from float to double.
1286
1287         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1288         (TestWebKitAPI::TEST):
1289
1290 2015-06-24  Brady Eidson  <beidson@apple.com>
1291
1292         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
1293         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
1294
1295         Reviewed by Alex Christensen.
1296
1297         - Update WKTR to the new client structure.
1298         - Update existing TestWebKitAPI tests to either use the new client structure or
1299           assign the old function signature to the updated variable name.
1300         - Include a new test.
1301
1302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1303
1304         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
1305         (TestWebKitAPI::runJavaScriptAlert):
1306
1307         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1308         (TestWebKitAPI::TEST):
1309
1310         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
1311         (TestWebKitAPI::analyzeDialogArguments):
1312         (TestWebKitAPI::runJavaScriptAlert):
1313         (TestWebKitAPI::runJavaScriptConfirm):
1314         (TestWebKitAPI::runJavaScriptPrompt):
1315         (TestWebKitAPI::createNewPage):
1316         (TestWebKitAPI::TEST):
1317
1318         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1319         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1320
1321         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1322         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1323
1324         * WebKitTestRunner/TestController.cpp:
1325         (WTR::TestController::createOtherPage):
1326         (WTR::TestController::createWebViewWithOptions):
1327
1328 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
1329
1330         Refactoring benchmark runner script to follow pep8 code style.
1331         https://bugs.webkit.org/show_bug.cgi?id=146264
1332
1333         Reviewed by Ryosuke Niwa.
1334
1335         Refactor benchmark runner script to follow pep8 code style.
1336
1337         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1338         (GenericBenchmarkBuilder.prepare):
1339         (GenericBenchmarkBuilder._run_create_script):
1340         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
1341         (GenericBenchmarkBuilder._fetch_remote_archive):
1342         (GenericBenchmarkBuilder):
1343         (GenericBenchmarkBuilder._checkout_with_subversion):
1344         (GenericBenchmarkBuilder._apply_patch):
1345         (GenericBenchmarkBuilder.clean):
1346         (GenericBenchmarkBuilder._runCreateScript): Deleted.
1347         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
1348         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
1349         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
1350         (GenericBenchmarkBuilder._applyPatch): Deleted.
1351         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1352         (BenchmarkRunner.__init__):
1353         (BenchmarkRunner._find_plan_file):
1354         (BenchmarkRunner.execute):
1355         (BenchmarkRunner._cleanup):
1356         (BenchmarkRunner._dump):
1357         (BenchmarkRunner._wrap):
1358         (BenchmarkRunner._merge):
1359         (BenchmarkRunner._show_results):
1360         (BenchmarkRunner._findPlanFile): Deleted.
1361         (BenchmarkRunner.cleanup): Deleted.
1362         (BenchmarkRunner.dump): Deleted.
1363         (BenchmarkRunner.wrap): Deleted.
1364         (BenchmarkRunner.merge): Deleted.
1365         (BenchmarkRunner.show_results): Deleted.
1366         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1367         (BrowserDriver.prepare_env):
1368         (BrowserDriver.launch_url):
1369         (BrowserDriver.close_browsers):
1370         (BrowserDriver.prepareEnv): Deleted.
1371         (BrowserDriver.launchUrl): Deleted.
1372         (BrowserDriver.closeBrowser): Deleted.
1373         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1374         (OSXBrowserDriver):
1375         (OSXBrowserDriver.prepare_env):
1376         (OSXBrowserDriver.close_browsers):
1377         (OSXBrowserDriver._launch_process):
1378         (OSXBrowserDriver._terminiate_processes):
1379         (OSXBrowserDriver._launch_process_with_caffinate):
1380         (OSXBrowserDriver._screen_size):
1381         (OSXBrowserDriver.prepareEnv): Deleted.
1382         (OSXBrowserDriver.closeBrowsers): Deleted.
1383         (OSXBrowserDriver.launchProcess): Deleted.
1384         (OSXBrowserDriver.terminateProcesses): Deleted.
1385         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
1386         (OSXBrowserDriver.screenSize): Deleted.
1387         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1388         (OSXChromeDriver):
1389         (OSXChromeDriver.launch_url):
1390         (OSXChromeCanaryDriver):
1391         (OSXChromeCanaryDriver.launch_url):
1392         (OSXChromeDriver.launchUrl): Deleted.
1393         (OSXChromeCanaryDriver.launchUrl): Deleted.
1394         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1395         (OSXFirefoxDriver):
1396         (OSXFirefoxDriver.launch_url):
1397         (OSXFirefoxNightlyDriver):
1398         (OSXFirefoxNightlyDriver.launch_url):
1399         (OSXFirefoxDriver.launchUrl): Deleted.
1400         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
1401         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1402         (OSXSafariDriver):
1403         (OSXSafariDriver.prepare_env):
1404         (OSXSafariDriver.launch_url):
1405         (OSXSafariDriver.close_browsers):
1406         (OSXSafariDriver._maximize_window):
1407         (OSXSafariDriver.prepareEnv): Deleted.
1408         (OSXSafariDriver.launchUrl): Deleted.
1409         (OSXSafariDriver.closeBrowsers): Deleted.
1410         (OSXSafariDriver.maximizeWindow): Deleted.
1411         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1412         (HTTPServerDriver.fetch_result):
1413         (HTTPServerDriver.kill_server):
1414         (HTTPServerDriver.get_return_code):
1415         (HTTPServerDriver.set_device_id):
1416         (HTTPServerDriver.fetchResult): Deleted.
1417         (HTTPServerDriver.killServer): Deleted.
1418         (HTTPServerDriver.getReturnCode): Deleted.
1419         (HTTPServerDriver.setDeviceID): Deleted.
1420         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1421         (SimpleHTTPServerDriver.serve):
1422         (SimpleHTTPServerDriver.base_url):
1423         (SimpleHTTPServerDriver.fetch_result):
1424         (SimpleHTTPServerDriver.kill_server):
1425         (SimpleHTTPServerDriver.get_return_code):
1426         (SimpleHTTPServerDriver): Deleted.
1427         (SimpleHTTPServerDriver.baseUrl): Deleted.
1428         (SimpleHTTPServerDriver.fetchResult): Deleted.
1429         (SimpleHTTPServerDriver.killServer): Deleted.
1430         (SimpleHTTPServerDriver.getReturnCode): Deleted.
1431         * Scripts/webkitpy/benchmark_runner/utils.py:
1432         (get_path_from_project_root):
1433         (force_remove):
1434         (getPathFromProjectRoot): Deleted.
1435         (forceRemove): Deleted.
1436
1437 2015-06-23  Anders Carlsson  <andersca@apple.com>
1438
1439         Add operator! and copy/move constructors to WeakObjCPtr
1440         https://bugs.webkit.org/show_bug.cgi?id=146255
1441
1442         Reviewed by Andreas Kling.
1443
1444         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1445         (TEST):
1446
1447 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
1448
1449         Expose some more rendering progress events, and have MiniBrowser log for each of them
1450         https://bugs.webkit.org/show_bug.cgi?id=146227
1451
1452         Reviewed by Darin Adler.
1453
1454         Register for layout milestones/rendering progress events in the WK1 and WK2
1455         browser window controllers, and, if logging is turned on, log when they are
1456         reached.
1457
1458         * MiniBrowser/mac/WK1BrowserWindowController.m:
1459         (-[WK1BrowserWindowController awakeFromNib]):
1460         (-[WK1BrowserWindowController webView:didLayout:]):
1461         * MiniBrowser/mac/WK2BrowserWindowController.m:
1462         (-[WK2BrowserWindowController awakeFromNib]):
1463         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
1464
1465 2015-06-23  Brady Eidson  <beidson@apple.com>
1466
1467         WKFrameInfo should have an accessor for the Frame's current security origin.
1468         https://bugs.webkit.org/show_bug.cgi?id=146162
1469
1470         Reviewed by Dan Bernstein.
1471
1472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1473         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
1474         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
1475         (sawDialog):
1476         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1477         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1478         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1479         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1480         (TEST):
1481
1482 2015-06-23  Tanay C  <tanay.c@samsung.com>
1483
1484         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
1485         https://bugs.webkit.org/show_bug.cgi?id=146007
1486
1487         Reviewed by Darin Adler.
1488
1489         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1490         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
1491         (pluginLogWithWindowObject):
1492         (pluginLogWithArguments):
1493         (pluginLog):
1494         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
1495         (PluginTest::executeScript):
1496         (PluginTest::log):
1497
1498 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
1499
1500         [EFL] Add libhyphen-dev as dependency after r185862
1501         https://bugs.webkit.org/show_bug.cgi?id=146230
1502
1503         Reviewed by Gyuyoung Kim.
1504
1505         * efl/install-dependencies:
1506
1507 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
1508
1509         [EFL] Hyphenation is not supported
1510         https://bugs.webkit.org/show_bug.cgi?id=89830
1511
1512         Reviewed by Gyuyoung Kim.
1513
1514         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
1515
1516 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
1517
1518         Get rid of factory json files in benchmark_runner
1519         https://bugs.webkit.org/show_bug.cgi?id=146175
1520
1521         Reviewed by Ryosuke Niwa.
1522
1523         Get rid of factory json files in benchmark_runner and refactoring the code.
1524
1525         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
1526         (benchmark_builder_loader):
1527         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
1528         (BenchmarkBuilderFactory):
1529         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
1530         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1531         (GenericBenchmarkBuilder):
1532         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1533         (BenchmarkRunner.__init__):
1534         (BenchmarkRunner.execute):
1535         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
1536         (browser_driver_loader):
1537         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1538         (BrowserDriver):
1539         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1540         (BrowserDriverFactory):
1541         (BrowserDriverFactory.available_platforms):
1542         (BrowserDriverFactory.available_browsers):
1543         (BrowserDriverFactory.add_browser_driver):
1544         (BrowserDriverFactory.create):
1545         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
1546         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1547         (OSXBrowserDriver):
1548         (OSXBrowserDriver.prepareEnv):
1549         (OSXBrowserDriver.terminateProcesses):
1550         (OSXBrowserDriver.screenSize):
1551         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1552         (OSXChromeDriver):
1553         (OSXChromeCanaryDriver):
1554         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1555         (OSXFirefoxDriver):
1556         (OSXFirefoxNightlyDriver):
1557         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1558         (OSXSafariDriver):
1559         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1560         (GenericFactory.create):
1561         (GenericFactory.add):
1562         (GenericFactory.iterateGetItem): Deleted.
1563         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
1564         (http_server_driver_loader):
1565         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1566         (HTTPServerDriver):
1567         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
1568         (HTTPServerDriverFactory):
1569         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
1570         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1571         (SimpleHTTPServerDriver):
1572         * Scripts/webkitpy/benchmark_runner/utils.py:
1573         (is_subclass):
1574         (load_subclasses):
1575         (ModuleNotFoundError): Deleted.
1576         (loadModule): Deleted.
1577         (loadJSONFromFile): Deleted.
1578
1579 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
1580
1581         Make it possible to enable incremental rendering suppression in MiniBrowser
1582         https://bugs.webkit.org/show_bug.cgi?id=146223
1583         
1584         Reviewed by Tim Horton.
1585
1586         Add a menu item to enable incremental rendering suppression to MiniBrowser.
1587         
1588         For WK1, this just toggles a pref, and takes effect immediately.
1589         
1590         For WK2, this is a WKConfiguration property, so only affects new web views.
1591         
1592         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
1593         logging on launch.
1594
1595         * MiniBrowser/mac/AppDelegate.m:
1596         (defaultConfiguration):
1597         * MiniBrowser/mac/BrowserWindow.xib:
1598         * MiniBrowser/mac/SettingsController.h:
1599         * MiniBrowser/mac/SettingsController.m:
1600         (-[SettingsController _populateMenu]):
1601         (-[SettingsController validateMenuItem:]):
1602         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
1603         (-[SettingsController incrementalRenderingSuppressed]):
1604         * MiniBrowser/mac/WK1BrowserWindowController.m:
1605         (-[WK1BrowserWindowController didChangeSettings]):
1606
1607 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
1608
1609         Run CDjs as part of JSC stress testing
1610         https://bugs.webkit.org/show_bug.cgi?id=146174
1611
1612         Reviewed by Geoffrey Garen.
1613
1614         * Scripts/run-javascriptcore-tests:
1615         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
1616         * Scripts/run-jsc-stress-tests:
1617         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
1618         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
1619         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
1620
1621 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
1622
1623         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
1624         https://bugs.webkit.org/show_bug.cgi?id=146121
1625         rdar://problem/21395180
1626
1627         Reviewed by Darin Adler.
1628
1629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
1631         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
1632         (TestWebKitAPI::overrideAppleLanguages):
1633         (TestWebKitAPI::languageForSystemLanguage):
1634         (TestWebKitAPI::TEST):
1635
1636 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1637
1638         [CMake] Ignore warnings from system headers when compiling Tools
1639         https://bugs.webkit.org/show_bug.cgi?id=146185
1640
1641         Reviewed by Martin Robinson.
1642
1643         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
1644         from system headers that we don't control.
1645
1646         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1647         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
1648         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
1649         * ImageDiff/PlatformGTK.cmake:
1650         * MiniBrowser/efl/CMakeLists.txt:
1651         * MiniBrowser/gtk/CMakeLists.txt:
1652         * TestWebKitAPI/PlatformEfl.cmake:
1653         * TestWebKitAPI/PlatformGTK.cmake:
1654         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1655         * WebKitTestRunner/CMakeLists.txt:
1656         * WebKitTestRunner/PlatformEfl.cmake:
1657         * WebKitTestRunner/PlatformGTK.cmake:
1658
1659 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1660
1661         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
1662         https://bugs.webkit.org/show_bug.cgi?id=146186
1663
1664         Reviewed by Martin Robinson.
1665
1666         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
1667         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
1668
1669         * MiniBrowser/gtk/CMakeLists.txt:
1670
1671 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
1672
1673         Build fix after r146125.
1674
1675         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1676         (OSXSafariDriver):
1677         (OSXSafariDriver.prepareEnv):
1678
1679 2015-06-19  Brady Eidson  <beidson@apple.com>
1680
1681         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
1682         https://bugs.webkit.org/show_bug.cgi?id=146152
1683
1684         Reviewed by Dan Bernstein.
1685
1686         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1687         * WebKitTestRunner/WebNotificationProvider.cpp:
1688
1689 2015-06-19  Mark Lam  <mark.lam@apple.com>
1690
1691         CheckedArithmetic's operator bool() and operator==() is broken.
1692         https://bugs.webkit.org/show_bug.cgi?id=146129
1693
1694         Reviewed by Geoffrey Garen and Oliver Hunt.
1695
1696         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
1697         and overflow scenarios in usage of the Checked arithmetic class.
1698
1699         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1700         (TestWebKitAPI::OverflowCrashLogger::overflowed):
1701         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
1702         (TestWebKitAPI::OverflowCrashLogger::crash):
1703         (TestWebKitAPI::OverflowCrashLogger::reset):
1704         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
1705         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
1706         (TestWebKitAPI::OverflowCrashLogger::didCrash):
1707         - crash logger for verifying that a crash occurs when expected. 
1708
1709         (TestWebKitAPI::resetOverflow):
1710         - convenience function for resetting a test value to an initial overflowed state
1711           before a crash.  We will use this value in the overflow testing.
1712
1713         (TestWebKitAPI::CheckedArithmeticTester::run):
1714         - Added new tests for all the comparison operators.
1715
1716 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
1717
1718         Fix the Windows build after r185721
1719         https://bugs.webkit.org/show_bug.cgi?id=146146
1720
1721         Reviewed by Csaba Osztrogonác.
1722
1723         Speculative buildfix.
1724
1725         * DumpRenderTree/win/UIDelegate.h:
1726         (UIDelegate::unused4): Added.
1727         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
1728
1729 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
1730
1731         Unreviewed. Add myself as a committer.
1732
1733         * Scripts/webkitpy/common/config/contributors.json:
1734
1735 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
1736
1737         Remove unnecessary svn:executable flags
1738         https://bugs.webkit.org/show_bug.cgi?id=146107
1739
1740         Reviewed by Alexey Proskuryakov.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
1743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
1745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
1747         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
1748         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
1749         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
1750         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
1751         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
1752         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
1753         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
1754         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
1755         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
1756
1757 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
1758
1759         Disable tests on the WinCairo buildbot
1760         https://bugs.webkit.org/show_bug.cgi?id=146106
1761
1762         Reviewed by Alexey Proskuryakov.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/config.json:
1765         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1766
1767 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
1768
1769         [EFL] Fix the minibrowser after r185725
1770         https://bugs.webkit.org/show_bug.cgi?id=146135
1771
1772         Reviewed by Gyuyoung Kim.
1773
1774         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
1775         for the elm_config_accel_preference_set() to set the config of acceleration preference.
1776
1777         * MiniBrowser/efl/main.c:
1778         (elm_main): Deleted the HAVE_ECORE_X guard.
1779
1780 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
1781
1782         Extend capability of run-benchmark script to support mobile device
1783         https://bugs.webkit.org/show_bug.cgi?id=146125
1784
1785         Reviewed by Ryosuke Niwa.
1786
1787         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
1788         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
1789
1790         * Scripts/run-benchmark:
1791         (main): Deleted.
1792         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1793         (BenchmarkRunner.__init__):
1794         (BenchmarkRunner.execute):
1795         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1796         (BrowserDriver.prepareEnv):
1797         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1798         (OSXBrowserDriver.prepareEnv):
1799         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1800         (OSXSafariDriver.prepareEnv):
1801         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1802         (HTTPServerDriver.getReturnCode):
1803         (HTTPServerDriver):
1804         (HTTPServerDriver.setDeviceID):
1805         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
1806         (parse_args):
1807         (start):
1808         (main):
1809         * Scripts/webkitpy/benchmark_runner/utils.py:
1810         (getPathFromProjectRoot):
1811
1812 2015-06-18  Jon Lee  <jonlee@apple.com>
1813
1814         Unreviewed. Add Matt Daiter as a contributor.
1815
1816         * Scripts/webkitpy/common/config/contributors.json:
1817
1818 2015-06-18  Mark Lam  <mark.lam@apple.com>
1819
1820         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
1821         https://bugs.webkit.org/show_bug.cgi?id=146103
1822
1823         Not reviewed.
1824
1825         Follow up to fix some typos not caught before original patch was landed.
1826
1827         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1828         (TestWebKitAPI::CheckedArithmeticTester::run):
1829         (TestWebKitAPI::AllowMixedSignednessTest::run):
1830         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
1831
1832 2015-06-18  Daniel Bates  <dabates@apple.com>
1833
1834         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
1835         https://bugs.webkit.org/show_bug.cgi?id=146082
1836
1837         Reviewed by Darin Adler.
1838
1839         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
1840         working directory after being invoked in a different Git checkout. In particular,
1841         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
1842         a pure Git checkout g will fail to update g.
1843
1844         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
1845         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
1846         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
1847         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
1848         different than the current working directory). Instead runGitUpdate() should check
1849         whether the current working directory is a Git SVN checkout on each invocation.
1850
1851         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
1852         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
1853         SVN directory from isGitSVN().
1854         (isGitSVN): Implemented in terms of isGitSVNDirectory().
1855         * Scripts/webkitdirs.pm:
1856         (runGitUpdate): Modified to use isGitSVNDirectory().
1857
1858 2015-06-18  Mark Lam  <mark.lam@apple.com>
1859
1860         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
1861         https://bugs.webkit.org/show_bug.cgi?id=146103
1862
1863         Reviewed by Anders Carlsson.
1864
1865         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
1866         part of a large macro.  This makes them harder to:
1867
1868         1. write: no editor help with indentations, have to add trailing '\'s,
1869            inconvenient to add line breaks and comments.
1870
1871         2. read: no chroma coding / syntax highlighting.
1872
1873         3. debug: compile time errors are reported as being on the single line where
1874            the macro is used.
1875
1876         Refactoring the tests to use C++ templates solves all these issues.
1877
1878         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1879         (TestWebKitAPI::CheckedArithmeticTester::run):
1880         (TestWebKitAPI::AllowMixedSignednessTest::run):
1881         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
1882         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
1883         (TestWebKitAPI::CoerceLiteralNop::coerce):
1884
1885 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1886
1887         [EFL][WK2] Use Web Browser cache model in MiniBrowser
1888         https://bugs.webkit.org/show_bug.cgi?id=112273
1889
1890         Reviewed by Laszlo Gombos.
1891
1892         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
1893         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
1894         This way we have a decent cache capacity and the page cache actually works.
1895
1896         * MiniBrowser/efl/main.c:
1897         (elm_main):
1898
1899 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1900
1901         Remove redundant Chromium bug keyword
1902         https://bugs.webkit.org/show_bug.cgi?id=146097
1903
1904         Reviewed by Csaba Osztrogonác.
1905
1906         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1907         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
1908         (TestExpectationLine._format_line): Deleted.
1909
1910 2015-06-17  Daniel Bates  <dabates@apple.com>
1911
1912         Client may receive began editing callback for already focused text field
1913         https://bugs.webkit.org/show_bug.cgi?id=146074
1914         <rdar://problem/21293562>
1915
1916         Reviewed by Darin Adler.
1917
1918         Add a unit test to ensure that a client receives exactly one began editing
1919         callback when a text field is newly focused. In particular, dispatching
1920         a DOM focus event at an already focused text field does not dispatch a
1921         began editing callback to the client.
1922
1923         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1924         (TestWebKitAPI::TEST_F):
1925
1926 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1927
1928         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
1929         https://bugs.webkit.org/show_bug.cgi?id=26481
1930
1931         Reviewed by Darin Adler.
1932
1933         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
1934
1935         * DumpRenderTree/win/TestRunnerWin.cpp:
1936         (TestRunner::dispatchPendingLoadRequests):
1937         (TestRunner::overridePreference):
1938
1939 2015-06-17  Alex Christensen  <achristensen@webkit.org>
1940
1941         [Content Extensions] Fail to parse invalid arrays
1942         https://bugs.webkit.org/show_bug.cgi?id=146079
1943         rdar://problem/21422649
1944
1945         Reviewed by Benjamin Poulain.
1946
1947         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1948         (TestWebKitAPI::TEST_F):
1949         Correct and add parsing tests with invalid arrays.
1950
1951 2015-06-17  Matt Rajca  <mrajca@apple.com>
1952
1953         Unreviewed. Added myself as a committer.
1954
1955         * Scripts/webkitpy/common/config/contributors.json:
1956
1957 2015-06-17  Daniel Bates  <dabates@apple.com>
1958
1959         Export VCSUtils::gitTreeDirectory()
1960         <rdar://problem/21248901>
1961
1962         Rubber-stamped by Alexey Proskuryakov.
1963
1964         * Scripts/VCSUtils.pm:
1965
1966 2015-06-17  Tim Horton  <timothy_horton@apple.com>
1967
1968         Safari tabs still have shrunken content after coming out of fullscreen
1969         https://bugs.webkit.org/show_bug.cgi?id=146037
1970         <rdar://problem/21105960>
1971
1972         Reviewed by Simon Fraser and Darin Adler.
1973
1974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1975         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
1976         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
1977         (TEST):
1978         Add a test that ensures that disabling scale-to-fit mode correctly updates
1979         the page's layout.
1980
1981 2015-06-17  Dan Bernstein  <mitz@apple.com>
1982
1983         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
1984         https://bugs.webkit.org/show_bug.cgi?id=145957
1985
1986         Reviewed by Darin Adler.
1987
1988         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1989         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
1990
1991 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
1992
1993         AX:  iOS accessibility tests are not running because we need WKTR support
1994         https://bugs.webkit.org/show_bug.cgi?id=145991
1995
1996         Reviewed by Daniel Bates.
1997
1998         Add support for WKTR iOS accessibility.
1999         Utilize the notification handling mechanisms that Mac already uses.
2000         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
2001
2002         * DumpRenderTree/AccessibilityUIElement.cpp:
2003         (stringForSelectionCallback):
2004         (getIdentifierCallback):
2005         (getTraitsCallback):
2006         (getElementTextPositionCallback):
2007         (getElementTextLengthCallback):
2008         (AccessibilityUIElement::getJSClass):
2009         (getIPhoneLabelCallback): Deleted.
2010         (getIPhoneHintCallback): Deleted.
2011         (getIPhoneValueCallback): Deleted.
2012         (getIPhoneIdentifierCallback): Deleted.
2013         (getIPhoneTraitsCallback): Deleted.
2014         (getIPhoneIsElementCallback): Deleted.
2015         (getIPhoneElementTextPositionCallback): Deleted.
2016         (getIPhoneElementTextLengthCallback): Deleted.
2017         * DumpRenderTree/AccessibilityUIElement.h:
2018         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2019         (AccessibilityUIElement::identifier):
2020         (AccessibilityUIElement::traits):
2021         (AccessibilityUIElement::elementTextPosition):
2022         (AccessibilityUIElement::elementTextLength):
2023         (AccessibilityUIElement::description):
2024         (AccessibilityUIElement::orientation):
2025         (AccessibilityUIElement::stringValue):
2026         (AccessibilityUIElement::language):
2027         (AccessibilityUIElement::helpText):
2028         (AccessibilityUIElement::intValue):
2029         (AccessibilityUIElement::isSelected):
2030         (AccessibilityUIElement::isExpanded):
2031         (AccessibilityUIElement::documentURI):
2032         (AccessibilityUIElement::addNotificationListener):
2033         (AccessibilityUIElement::removeNotificationListener):
2034         (AccessibilityUIElement::isFocusable):
2035         (AccessibilityUIElement::isIgnored):
2036         (AccessibilityUIElement::hasPopup):
2037         (AccessibilityUIElement::iphoneLabel): Deleted.
2038         (AccessibilityUIElement::iphoneHint): Deleted.
2039         (AccessibilityUIElement::iphoneValue): Deleted.
2040         (AccessibilityUIElement::iphoneIdentifier): Deleted.
2041         (AccessibilityUIElement::iphoneTraits): Deleted.
2042         (AccessibilityUIElement::iphoneIsElement): Deleted.
2043         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
2044         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
2045         (_accessibilityNotificationCallback): Deleted.
2046         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2047         (WTR::AccessibilityUIElement::isValid):
2048         (WTR::AccessibilityUIElement::identifier):
2049         (WTR::AccessibilityUIElement::traits):
2050         (WTR::AccessibilityUIElement::elementTextPosition):
2051         (WTR::AccessibilityUIElement::elementTextLength):
2052         (WTR::AccessibilityUIElement::stringForSelection):
2053         (WTR::AccessibilityUIElement::elementsForRange):
2054         (WTR::AccessibilityUIElement::increaseTextSelection):
2055         (WTR::AccessibilityUIElement::decreaseTextSelection):
2056         (WTR::AccessibilityUIElement::linkedElement):
2057         (WTR::AccessibilityUIElement::headerElementAtIndex):
2058         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2059         (WTR::AccessibilityUIElement::characterAtOffset):
2060         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2061         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2062         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2063         (WTR::findAccessibleObjectById):
2064         (WTR::AccessibilityController::accessibleElementById):
2065         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2066         (+[NSString stringWithJSStringRef:]):
2067         (-[NSString createJSStringRef]):
2068         (WTR::convertNSArrayToVector):
2069         (WTR::concatenateAttributeAndValue):
2070         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2071         (WTR::AccessibilityUIElement::isEqual):
2072         (WTR::AccessibilityUIElement::headerElementAtIndex):
2073         (WTR::AccessibilityUIElement::linkedElement):
2074         (WTR::AccessibilityUIElement::getLinkedUIElements):
2075         (WTR::AccessibilityUIElement::elementAtPoint):
2076         (WTR::convertElementsToObjectArray):
2077         (WTR::AccessibilityUIElement::elementsForRange):
2078         (WTR::AccessibilityUIElement::indexOfChild):
2079         (WTR::AccessibilityUIElement::stringAttributeValue):
2080         (WTR::AccessibilityUIElement::description):
2081         (WTR::AccessibilityUIElement::orientation):
2082         (WTR::AccessibilityUIElement::stringValue):
2083         (WTR::AccessibilityUIElement::language):
2084         (WTR::AccessibilityUIElement::helpText):
2085         (WTR::AccessibilityUIElement::x):
2086         (WTR::AccessibilityUIElement::clickPointX):
2087         (WTR::AccessibilityUIElement::clickPointY):
2088         (WTR::AccessibilityUIElement::intValue):
2089         (WTR::AccessibilityUIElement::minValue):
2090         (WTR::AccessibilityUIElement::maxValue):
2091         (WTR::AccessibilityUIElement::valueDescription):
2092         (WTR::AccessibilityUIElement::isSelected):
2093         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2094         (WTR::AccessibilityUIElement::stringForRange):
2095         (WTR::AccessibilityUIElement::attributedStringForRange):
2096         (WTR::AccessibilityUIElement::attributesOfHeader):
2097         (WTR::AccessibilityUIElement::traits):
2098         (WTR::AccessibilityUIElement::identifier):
2099         (WTR::AccessibilityUIElement::rowCount):
2100         (WTR::AccessibilityUIElement::rowIndexRange):
2101         (WTR::AccessibilityUIElement::columnIndexRange):
2102         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2103         (WTR::AccessibilityUIElement::horizontalScrollbar):
2104         (WTR::AccessibilityUIElement::documentURI):
2105         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2106         (WTR::AccessibilityUIElement::increaseTextSelection):
2107         (WTR::AccessibilityUIElement::decreaseTextSelection):
2108         (WTR::AccessibilityUIElement::stringForSelection):
2109         (WTR::AccessibilityUIElement::elementTextPosition):
2110         (WTR::AccessibilityUIElement::elementTextLength):
2111         (WTR::AccessibilityUIElement::url):
2112         (WTR::AccessibilityUIElement::addNotificationListener):
2113         (WTR::AccessibilityUIElement::removeNotificationListener):
2114         (WTR::AccessibilityUIElement::isFocusable):
2115         (WTR::AccessibilityUIElement::isIgnored):
2116         (WTR::AccessibilityUIElement::hasPopup):
2117         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2118         (WTR::_CGPathEnumerationIteration):
2119         (WTR::AccessibilityUIElement::pathDescription):
2120         (WTR::AccessibilityUIElement::supportedActions):
2121
2122 2015-06-16  Mark Lam  <mark.lam@apple.com>
2123
2124         Use NakedPtr<Exception>& to return exception results.
2125         https://bugs.webkit.org/show_bug.cgi?id=145870
2126
2127         Reviewed by Anders Carlsson and Filip Pizlo.
2128
2129         * TestWebKitAPI/CMakeLists.txt:
2130         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2131         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
2134         (TestWebKitAPI::TEST):
2135         (TestWebKitAPI::nakedPtrFoo):
2136
2137 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
2138
2139         Unreviewed. Adding myself as a committer.
2140
2141         * Scripts/webkitpy/common/config/contributors.json:
2142
2143 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
2144
2145         Add test expectations for El Capitan
2146         https://bugs.webkit.org/show_bug.cgi?id=146005
2147
2148         Rubber-stamped by Dan Bernstein.
2149
2150         Add appropriate tools code.
2151
2152         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
2153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
2154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2156         Added dashboard support.
2157
2158         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2159         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2160         Trigger the right build queues on check-in.
2161
2162         * Scripts/webkitpy/common/system/platforminfo.py:
2163         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2164         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2165         * Scripts/webkitpy/port/mac.py:
2166         * Scripts/webkitpy/port/mac_unittest.py:
2167         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2168         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2169         Added cases for El Capitan, and updated tests for new baseline search paths.
2170
2171 2015-06-15  Alex Christensen  <achristensen@webkit.org>
2172
2173         [Content Extensions] Make max NFA size and max rule count user defaults.
2174         https://bugs.webkit.org/show_bug.cgi?id=145663
2175
2176         Reviewed by Benjamin Poulain.
2177
2178         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2179         (TestWebKitAPI::TEST_F):
2180
2181 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
2182
2183         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
2184         https://bugs.webkit.org/show_bug.cgi?id=145900
2185
2186         Reviewed by Sam Weinig.
2187
2188         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2189         (TEST): Added tests.
2190
2191 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2192
2193         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
2194         https://bugs.webkit.org/show_bug.cgi?id=145969
2195
2196         Reviewed by Sergio Villar Senin.
2197
2198         Add a test case to the custom URI schemes unit test.
2199
2200         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2201         (testWebContextURIScheme):
2202
2203 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
2204
2205         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
2206         https://bugs.webkit.org/show_bug.cgi?id=145922
2207
2208         Reviewed by Carlos Garcia Campos.
2209
2210         * gtk/jhbuild.modules:
2211         * gtk/patches/glib-warning-fix.patch: Added.
2212
2213 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
2214
2215         Update springLoadingHighlight type
2216         https://bugs.webkit.org/show_bug.cgi?id=145939
2217         rdar://problem/20880213
2218
2219         Reviewed by Darin Adler.
2220
2221         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2222         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2223         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2224         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2225
2226 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
2227
2228         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
2229         https://bugs.webkit.org/show_bug.cgi?id=145945
2230
2231         Reviewed by Stephanie Lewis.
2232
2233         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2234         (OSXBrowserDriver.prepareEnv):
2235         (OSXBrowserDriver.moveCursor): Deleted.
2236         (OSXBrowserDriver): Deleted.
2237         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2238         (OSXSafariDriver.prepareEnv):
2239
2240 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
2241
2242         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
2243         https://bugs.webkit.org/show_bug.cgi?id=145938
2244
2245         Reviewed by Alexey Proskuryakov.
2246
2247         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
2248         LWP::UserAgent to get access to more robust HTTPS support.
2249
2250 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2251
2252         [GTK] Fix return type warning in WebViewTest.cpp
2253         https://bugs.webkit.org/show_bug.cgi?id=145914
2254
2255         Reviewed by Darin Adler.
2256
2257         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2258         (WebViewTest::isEditable):
2259
2260 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
2261
2262         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
2263         https://bugs.webkit.org/show_bug.cgi?id=145799
2264
2265         Reviewed by Carlos Garcia Campos.
2266
2267         Update header inclusions for headers that have been moved
2268         to Source/WTF/wtf/glib/.
2269
2270         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
2271         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
2272
2273         * TestWebKitAPI/PlatformGTK.cmake:
2274         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
2275         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2276         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2277         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2278         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
2279         (TestWebKitAPI::GMainLoopSourceTest::finish):
2280         (TestWebKitAPI::GMainLoopSourceTest::source):
2281         (TestWebKitAPI::basicRescheduling):
2282         (TestWebKitAPI::TEST):
2283         (TestWebKitAPI::reentrantRescheduling):
2284         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2285         (TestWebKitAPI::basicDestroyCallbacks):
2286         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2287         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2288         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
2289         (log):
2290         (takeLogStr):
2291         (TestWebKitAPI::TEST):
2292         (TestWebKitAPI::returnOutChar):
2293         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2294         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2295         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
2296         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
2297         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
2298         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
2299         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
2300         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
2301         (TestWebKitAPI::basicRescheduling): Deleted.
2302         (TestWebKitAPI::TEST): Deleted.
2303         (TestWebKitAPI::reentrantRescheduling): Deleted.
2304         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
2305         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
2306         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
2307         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
2308         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
2309         (log): Deleted.
2310         (takeLogStr): Deleted.
2311         (TestWebKitAPI::TEST): Deleted.
2312         (TestWebKitAPI::returnOutChar): Deleted.
2313         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
2314         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2315         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2316         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2317         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2318         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2319         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2320         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2321         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2322         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2323         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2324         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2325         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2326         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
2327         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2328         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
2329         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
2330         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2331         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2332         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2333         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2334         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2335         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2336         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2337         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2338         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
2339         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2340         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2341         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
2342         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
2343         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2344         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
2345         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2346         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2347         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2348         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2349         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
2350         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2351         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2352         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2353         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2354         * WebKitTestRunner/PlatformGTK.cmake:
2355         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2356         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2357
2358 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2359
2360         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
2361         https://bugs.webkit.org/show_bug.cgi?id=145913
2362
2363         Reviewed by Gyuyoung Kim.
2364
2365         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2366         (TestWebKitAPI::setupGeolocationProvider):
2367         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2368         (TestWebKitAPI::setPageLoaderClient):
2369         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2370         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2371         * WebKitTestRunner/GeolocationProviderMock.cpp:
2372         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2373         * WebKitTestRunner/WebNotificationProvider.cpp:
2374         (WTR::WebNotificationProvider::provider):
2375
2376 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2377
2378         Fix the libusrsctp build with clang
2379         https://bugs.webkit.org/show_bug.cgi?id=145128
2380
2381         Reviewed by Gyuyoung Kim.
2382
2383         * efl/jhbuild.modules:
2384         * gtk/jhbuild.modules:
2385
2386 2015-06-11  Mark Lam  <mark.lam@apple.com>
2387
2388         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
2389         https://bugs.webkit.org/show_bug.cgi?id=145872
2390
2391         Reviewed by Michael Saboff.
2392
2393         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
2394         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2395         - Exercises the JSC ObjC API to call a function which throws an exception.  That
2396           exception will be returned as a JSValue instead of an Exception object.  We
2397           will use this JSValue to test WebCore::reportException() to confirm that it is
2398           able to handle an exception value which is not an Exception object.
2399
2400 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
2401
2402         Move cursor to corner and fix safari window size before running benchmark
2403         https://bugs.webkit.org/show_bug.cgi?id=145858
2404
2405         Reviewed by Ryosuke Niwa
2406
2407         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2408         (OSXBrowserDriver.prepareEnv):
2409         (OSXBrowserDriver):
2410         (OSXBrowserDriver.moveCursor):
2411         (OSXBrowserDriver.getScreenSize):
2412         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2413         (OSXChromeDriver.launchUrl):
2414         (OSXChromeCanaryDriver.launchUrl):
2415         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2416         (OSXFirefoxDriver.launchUrl):
2417         (OSXFirefoxNightlyDriver.launchUrl):
2418         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2419         (OSXSafariDriver.prepareEnv):
2420         (OSXSafariDriver):
2421         (OSXSafariDriver.maximizeWindow):
2422
2423 2015-06-11  Daniel Bates  <dabates@apple.com>
2424
2425         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
2426         https://bugs.webkit.org/show_bug.cgi?id=145319
2427
2428         Reviewed by David Kilzer.
2429
2430         Add SPI wrapper header for CoreSimulator and update the source files to reference
2431         it instead of directly referencing the CoreSimulator header.
2432
2433         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
2434         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
2435         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2436         * LayoutTestRelay/LayoutTestRelay/main.m:
2437
2438 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
2439
2440         [EFL] dimmed area for popup does not cover the fullscreen mode.
2441         https://bugs.webkit.org/show_bug.cgi?id=145133
2442
2443         Reviewed by Gyuyoung Kim.
2444
2445         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
2446         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
2447
2448         * MiniBrowser/efl/main.c:
2449         (on_fullscreen_accept):
2450         (on_fullscreen_deny):
2451         (on_fullscreen_enter):
2452
2453 2015-06-10  Commit Queue  <commit-queue@webkit.org>
2454
2455         Unreviewed, rolling out r185442.
2456         https://bugs.webkit.org/show_bug.cgi?id=145871
2457
2458         seems to have broken WTF.StringOperators test (Requested by
2459         alexchristensen on #webkit).
2460
2461         Reverted changeset:
2462
2463         "[Content Extensions] Limit number of rules."
2464         https://bugs.webkit.org/show_bug.cgi?id=145663
2465         http://trac.webkit.org/changeset/185442
2466
2467 2015-06-10  Alex Christensen  <achristensen@webkit.org>
2468
2469         [Content Extensions] Make max NFA size and max rule count user defaults.
2470         https://bugs.webkit.org/show_bug.cgi?id=145663
2471         rdar://problem/21242407
2472
2473         Reviewed by Benjamin Poulain.
2474
2475         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2476         (TestWebKitAPI::TEST_F):
2477
2478 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2479
2480         [EFL] Execute Javascript method in mini browser address bar.
2481         https://bugs.webkit.org/show_bug.cgi?id=145725
2482
2483         Reviewed by Gyuyoung Kim.
2484
2485         Support 'javascript:' scheme in WebKit EFL Mini Browser.
2486
2487         * MiniBrowser/efl/main.c:
2488         (url_from_user_input):
2489         (url_load_from_user_input):
2490         (on_url_bar_activated):
2491         (elm_main):
2492
2493 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2494
2495         Implement dumpProgressFinishedCallback() for Win layoutTestController.
2496         https://bugs.webkit.org/show_bug.cgi?id=66773
2497
2498         Reviewed by Darin Adler.
2499
2500         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2501         * DumpRenderTree/win/FrameLoadDelegate.h:
2502
2503 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
2504
2505         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
2506         https://bugs.webkit.org/show_bug.cgi?id=145764
2507
2508         Reviewed by Darin Adler.
2509
2510         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
2511         JetStream and SunSpider.
2512
2513         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2514         (GenericBenchmarkBuilder):
2515         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
2516         the whole JSON as the input.
2517         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
2518         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
2519         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2520         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
2521         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
2522         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2523         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2524
2525 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2526
2527         Remove ewstool scripts used by chromium port
2528         https://bugs.webkit.org/show_bug.cgi?id=145789
2529
2530         Reviewed by Csaba Osztrogonác.
2531
2532         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
2533         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
2534         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
2535         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
2536         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
2537
2538 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2539
2540         Unreviewed, updated my list of email addresses.
2541
2542         * Scripts/webkitpy/common/config/contributors.json:
2543
2544 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
2545
2546         [cmake] Fix the style issues in cmake project files
2547         https://bugs.webkit.org/show_bug.cgi?id=145755
2548
2549         Reviewed by Darin Adler.
2550
2551         * TestWebKitAPI/CMakeLists.txt:
2552         * TestWebKitAPI/PlatformEfl.cmake:
2553
2554 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2555
2556         Fix a typo in r185345.
2557
2558         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2559         (OSXSafariDriver.closeBrowsers):
2560
2561 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2562
2563         Yet another unreviewed build fix :(
2564
2565         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2566         (OSXSafariDriver):
2567         (OSXSafariDriver.launchUrl):
2568         (OSXSafariDriver.closeBrowsers):
2569
2570 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2571
2572         Unreviewed build fix. Initialize result in the case things blow up below.
2573
2574         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2575         (BenchmarkRunner.execute):
2576
2577 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2578
2579         Partially revert and fix after r185243.
2580
2581         * Scripts/benchmark_runner/benchmark_runner.py:
2582         * Scripts/run-benchmark:
2583
2584 2015-06-08  Daniel Bates  <dabates@apple.com>
2585
2586         Many LayoutTests/http tests time out in DumpRenderTree
2587         https://bugs.webkit.org/show_bug.cgi?id=145770
2588         <rdar://problem/19593910>
2589
2590         Reviewed by Alexey Proskuryakov.
2591
2592         * DumpRenderTree/ios/Info.plist: Add ATS key.
2593         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2594         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
2595         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
2596         that make use of testRunner.pathToLocalResource().
2597
2598 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
2599
2600         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
2601         https://bugs.webkit.org/show_bug.cgi?id=145759
2602
2603         Reviewed by Carlos Garcia Campos.
2604
2605         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2606         (testWebViewSave):
2607
2608 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2609
2610         [GTK] Add editor mode to MiniBrowser
2611         https://bugs.webkit.org/show_bug.cgi?id=145595
2612
2613         Reviewed by Sergio Villar Senin.
2614
2615         It loads an empty editable web view with an edit toolbar. It makes
2616         easier to test the editor, editing commands and input methods.
2617
2618         * MiniBrowser/gtk/BrowserWindow.c:
2619         (editingCommandCallback):
2620         (browserWindowSetupEditorToolbar):
2621         (browserWindowConstructed):
2622         * MiniBrowser/gtk/main.c:
2623         (createBrowserWindow):
2624
2625 2015-06-05  Zalan Bujtas  <zalan@apple.com>
2626
2627         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
2628
2629         Reviewed by Dan Bernstein.
2630
2631         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2632         (TestWebKitAPI::TEST):
2633
2634 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2635
2636         [EFL] API test has been broken since r184357
2637         https://bugs.webkit.org/show_bug.cgi?id=145635
2638
2639         Reviewed by Darin Adler.
2640
2641         r184357 suppress cmake build warning using TARGET_FILE property. However
2642         many EFL API test cases have been broken after applying it.
2643
2644         * TestWebKitAPI/CMakeLists.txt:
2645
2646 2015-06-05  Anders Carlsson  <andersca@apple.com>
2647
2648         Make the network cache directory part of WKContextConfigurationRef
2649         https://bugs.webkit.org/show_bug.cgi?id=145711
2650
2651         Reviewed by Antti Koivisto.
2652
2653         * WebKitTestRunner/TestController.cpp:
2654         (WTR::TestController::initialize):
2655
2656 2015-06-05  Anders Carlsson  <andersca@apple.com>
2657
2658         Make the application cache directory part of WKContextConfigurationRef
2659         https://bugs.webkit.org/show_bug.cgi?id=145704
2660
2661         Reviewed by Geoffrey Garen.
2662
2663         * WebKitTestRunner/TestController.cpp:
2664         (WTR::TestController::initialize):
2665
2666 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2667
2668         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
2669         https://bugs.webkit.org/show_bug.cgi?id=145680
2670
2671         Reviewed by Brent Fulgham.
2672
2673         * Scripts/webkitpy/style/checkers/cpp.py:
2674         (check_for_null):
2675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2676         (WebKitStyleTest.test_null_false_zero):
2677
2678 2015-06-05  Stephanie Lewis  <slewis@apple.com>
2679
2680         Make the web server more robust to timing issues..
2681
2682         Reviewed by Ryosuke Niwa.
2683
2684         Cleaned up exception handling.
2685         Test server is actually serving pages before returning.
2686         Clean up some style issues.
2687
2688         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2689         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2690         (SimpleHTTPServerDriver.__init__):
2691         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
2692         (SimpleHTTPServerDriver.baseUrl): 
2693         (SimpleHTTPServerDriver.fetchResult):
2694         (SimpleHTTPServerDriver.killServer):
2695         (SimpleHTTPServerDriver.getReturnCode):
2696
2697 2015-06-05  Stephanie Lewis  <slewis@apple.com>
2698
2699
2700         Add errors to run-benchmark exception handling.
2701
2702         Reviewed by Ryosuke Niwa.
2703
2704         * Scripts/run-benchmark:
2705         (main):
2706         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2707         (GenericBenchmarkBuilder.prepare):
2708         (GenericBenchmarkBuilder._runCreateScript):
2709         (GenericBenchmarkBuilder._applyPatch):
2710         (GenericBenchmarkBuilder.clean):
2711         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2712         (BenchmarkRunner.__init__):
2713         (BenchmarkRunner.execute):
2714         (BenchmarkRunner):
2715         (BenchmarkRunner.cleanup):
2716         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
2717         (GenericFactory.iterateGetItem):
2718         (GenericFactory.create):
2719         * Scripts/webkitpy/benchmark_runner/utils.py:
2720         (loadModule):
2721         (loadJSONFromFile):
2722         (forceRemove):
2723
2724 2015-06-05  Stephanie Lewis  <slewis@apple.com>
2725
2726         Streamline run-benchmark browser
2727
2728         Reviewed by Ryosuke Niwa.
2729
2730         Add Caffeinate so computer won't sleep while running.
2731         Remove calls to collect output since we were just dumping to stdout anyway.
2732         Add xpc dyld_path.
2733         Default to system safari.
2734
2735         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2736         (OSXBrowserDriver.launchProcess):
2737         (OSXBrowserDriver.terminateProcesses):
2738         (OSXBrowserDriver):
2739         (OSXBrowserDriver.launchCaffeinateForProcess):
2740         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2741         (OSXSafariDriver.launchUrl):
2742         (OSXSafariDriver.closeBrowsers):
2743
2744 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
2745
2746         Combine tiny DFAs into slightly larger ones
2747         https://bugs.webkit.org/show_bug.cgi?id=145572
2748
2749         Reviewed by Alex Christensen.
2750
2751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2752         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
2753         (TestWebKitAPI::DFACombinerTest::SetUp):
2754         (TestWebKitAPI::combine):
2755         (TestWebKitAPI::TEST_F):
2756         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
2757         (TestWebKitAPI::countLiveNodes):
2758         (TestWebKitAPI::createNFAs):
2759         (TestWebKitAPI::buildDFAFromPatterns):
2760         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2761         (TestWebKitAPI::countLiveNodes): Deleted.
2762         (TestWebKitAPI::createNFAs): Deleted.
2763         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
2764
2765 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
2766
2767         WebKitTestRunner leaks strings in generateWhitelist()
2768         https://bugs.webkit.org/show_bug.cgi?id=145665
2769
2770         Reviewed by Myles C. Maxfield.
2771
2772         * WebKitTestRunner/mac/TestControllerMac.mm:
2773         (WTR::generateWhitelist):
2774
2775 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2776
2777         Fix options in build-jsc for CMake builds
2778         https://bugs.webkit.org/show_bug.cgi?id=145636
2779
2780         Reviewed by Gyuyoung Kim.
2781
2782         CMake only accepts -DXXX=YYY style options.
2783         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
2784
2785         * Scripts/build-jsc:
2786
2787 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
2788
2789         Added a patch so that the colors displayed on the page could be toggled
2790         in case people need accessibility colors displayed in their browser.
2791         https://bugs.webkit.org/show_bug.cgi?id=145570
2792         <rdar://problem/20994468>
2793
2794         Added in CSS colors and toggle buttons for checkmarks in the page, so that
2795         the page could be rendered in a specific way for accessibility needs if needed.
2796
2797         Reviewed by Alexey Proskuryakov.
2798
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2800         (updateHiddenPlatforms):
2801         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
2802         (toggleAccessibilityColors): Toggle colors on and off
2803         (documentReady): Needed to make changes to the initialization
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2805         (a:hover):
2806         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
2807         (div.cellButton.hide, div.accessibilityButton.hide):
2808         (div.cellButton.unhide, div.accessibilityButton.unhide):
2809         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
2810         (.popover-tracking:hover):
2811         (.accessibilityButton):
2812         (div.cellButton): Deleted.
2813         (div.cellButton.hide): Deleted.
2814         (div.cellButton.unhide): Deleted.
2815         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2817         (.status-line.neutral .bubble):
2818         (.status-line.unauthorized .bubble):
2819         (.status-line.danger .bubble.pictogram):
2820         (.status-line.bad .bubble.pictogram):
2821         (.status-line.no-bubble .message):
2822         (.status-line.bad .bubble):
2823         (.status-line.good .bubble):
2824         (.status-line.good .message):
2825         (.status-line.bad .message):
2826         (body.accessibility-colors .status-line.good .bubble):
2827         (body.accessibility-colors .status-line.bad .bubble):
2828         (body.accessibility-colors .status-line.good .message):
2829         (body.accessibility-colors .status-line.bad .message):
2830         (.status-line.danger .message):
2831         (.status-line.unauthorized .message):
2832
2833 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
2834
2835         Unreviewed build fix for Dromaeo.
2836
2837         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2838         (BenchmarkResults._aggregate_results_for_test):
2839
2840 2015-06-03  Anders Carlsson  <andersca@apple.com>
2841
2842         Fix build.
2843
2844         * DumpRenderTree/mac/TestRunnerMac.mm:
2845
2846 2015-06-03  Daniel Bates  <dabates@apple.com>
2847
2848         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
2849         https://bugs.webkit.org/show_bug.cgi?id=145616
2850
2851         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
2852         of the test. Further investigation is needed.
2853
2854         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
2855         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
2856
2857 2015-06-03  Brady Eidson  <beidson@apple.com>
2858
2859         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
2860         https://bugs.webkit.org/show_bug.cgi?id=145580
2861
2862         Reviewed by Mark Lam.
2863
2864         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2865         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
2866
2867 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
2868
2869         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
2870
2871         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2872         (TestWebKitAPI::TEST): Update the syntax.
2873
2874 2015-06-02  Mark Lam  <mark.lam@apple.com>
2875
2876         build-jsc's --cloop option is broken.
2877         https://bugs.webkit.org/show_bug.cgi?id=145516
2878
2879         Reviewed by Darin Adler.
2880
2881         * Scripts/build-jsc:
2882         - Make sure to disable the JIT when --cloop is specified.
2883           Did analogous fix for --ftljit.
2884
2885 2015-06-02  Daniel Bates  <dabates@apple.com>
2886
2887         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
2888
2889         Rubber-stamped by Alexey Proskuryakov.
2890
2891         * MiniBrowser/mac/Info.plist:
2892         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2893
2894 2015-06-01  Commit Queue  <commit-queue@webkit.org>
2895
2896         Unreviewed, rolling out r185066.
2897         https://bugs.webkit.org/show_bug.cgi?id=145543
2898
2899         it breaks the FTL JIT builds with a local checkout of llvm
2900         (Requested by pizlo on #webkit).
2901
2902         Reverted changeset:
2903
2904         "build-jsc's --cloop option is broken."
2905         https://bugs.webkit.org/show_bug.cgi?id=145516
2906         http://trac.webkit.org/changeset/185066
2907
2908 2015-06-01  Daniel Bates  <dabates@apple.com>
2909
2910         Notify client that we began editing when text field is focused
2911         https://bugs.webkit.org/show_bug.cgi?id=145439
2912         <rdar://problem/21142108>
2913
2914         Reviewed by Anders Carlsson.
2915
2916         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
2917         a text field is focused and defocused.
2918
2919         * TestWebKitAPI/CMakeLists.txt:
2920         * TestWebKitAPI/PlatformEfl.cmake:
2921         * TestWebKitAPI/PlatformGTK.cmake:
2922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2923         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
2924         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
2925         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
2926         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
2927         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
2928         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
2929         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
2930         (TestWebKitAPI::TEST_F):
2931         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
2932         (TestWebKitAPI::textFieldDidBeginEditing):
2933         (TestWebKitAPI::textFieldDidEndEditing):
2934         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
2935         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
2936         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
2937
2938 2015-06-01  Alex Christensen  <achristensen@webkit.org>
2939
2940         [Content Extensions] resource-type and load-type should be independent.
2941         https://bugs.webkit.org/show_bug.cgi?id=145528
2942         rdar://problem/21190765
2943
2944         Reviewed by Benjamin Poulain.
2945
2946         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2947         (TestWebKitAPI::TEST_F):
2948
2949 2015-06-01  Daniel Bates  <dabates@apple.com>
2950
2951         Add ATS keys to WebKitTestRunnerApp
2952         https://bugs.webkit.org/show_bug.cgi?id=145519
2953
2954         Reviewed by Alexey Proskuryakov.
2955
2956         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
2957
2958         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2959
2960 2015-06-01  Brady Eidson  <beidson@apple.com>
2961
2962         Add WKTR support for "should open external URLs".
2963         https://bugs.webkit.org/show_bug.cgi?id=145505
2964
2965         Reviewed by Darin Adler.
2966
2967         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
2968           "should open external URLs" bit set.
2969         
2970         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
2971           the policy delegate, including whether or not the bit was set.
2972         
2973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2974         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2975         (WTR::TestRunner::queueLoad):
2976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2977         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
2978         (WTR::TestRunner::shouldDumpPolicyCallbacks):
2979         
2980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2981         (WTR::InjectedBundle::queueLoad):
2982         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2983
2984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2985         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2986
2987         * WebKitTestRunner/TestInvocation.cpp:
2988         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2989
2990         * WebKitTestRunner/WorkQueueManager.cpp:
2991         (WTR::WorkQueueManager::queueLoad):
2992         * WebKitTestRunner/WorkQueueManager.h:
2993
2994 2015-06-01  Mark Lam  <mark.lam@apple.com>
2995
2996         build-jsc's --cloop option is broken.
2997         https://bugs.webkit.org/show_bug.cgi?id=145516
2998
2999         Reviewed by Darin Adler.
3000
3001         * Scripts/build-jsc:
3002         - Make sure to disable the JIT when --cloop is specified.
3003           Did analogous fix for --ftljit.
3004
3005 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
3006
3007         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
3008         https://bugs.webkit.org/show_bug.cgi?id=144959
3009
3010         Reviewed by Darin Adler.
3011
3012         * Scripts/webkitpy/style/checkers/cmake.py:
3013         (CMakeChecker.check): Use enumerate instead of xrange.
3014         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
3015         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
3016         (CMakeCheckerTest.test_check): Update the expected results.
3017
3018 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
3019
3020         Fix the webkitpy scm unittests after r174051
3021         https://bugs.webkit.org/show_bug.cgi?id=145511
3022
3023         Reviewed by Darin Adler.
3024
3025         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3026         (GitTestWithMock.make_scm):
3027
3028 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
3029
3030         EWS provides misleading information for not applyable patches
3031         https://bugs.webkit.org/show_bug.cgi?id=145307
3032
3033         Reviewed by Alexey Proskuryakov.
3034
3035         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
3036
3037 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
3038
3039         Further tweak results of WebKit1.StringTruncator after r184965.
3040
3041         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3042
3043 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
3044
3045         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
3046         https://bugs.webkit.org/show_bug.cgi?id=145264
3047
3048         Reviewed by Carlos Garcia Campos.
3049
3050         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
3051
3052 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3053
3054         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
3055
3056         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
3057         (BenchmarkResults._lint_subtest_results):
3058         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
3059         (test_aggregate_nested_results):
3060         (test_lint_results):
3061         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
3062
3063 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         run-benchmark should print out the results
3066         https://bugs.webkit.org/show_bug.cgi?id=145398
3067
3068         Reviewed by Antti Koivisto.
3069
3070         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
3071         of the output to catch early errors.
3072
3073         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
3074         (BenchmarkResults): Added.
3075         (BenchmarkResults.__init__): Added.
3076         (BenchmarkResults.format): Added.
3077         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
3078         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
3079         Uses the sample standard deviation to compute the significant figures for the value.
3080         (BenchmarkResults._unit_from_metric): Added.
3081         (BenchmarkResults._aggregate_results): Added.
3082         (BenchmarkResults._aggregate_results_for_test): Added.
3083         (BenchmarkResults._flatten_list): Added.
3084         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
3085         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
3086         (BenchmarkResults._aggregate_values): Added.
3087         (BenchmarkResults._lint_results): Added.
3088         (BenchmarkResults._lint_subtest_results): Added.
3089         (BenchmarkResults._lint_aggregator_list): Added.
3090         (BenchmarkResults._lint_configuration): Added.
3091         (BenchmarkResults._lint_values): Added.
3092         (BenchmarkResults._is_numeric): Added.
3093         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
3094         (BenchmarkResultsTest):
3095         (BenchmarkResultsTest.test_init):
3096         (BenchmarkResultsTest.test_format):
3097         (test_format_values_with_large_error):
3098         (test_format_values_with_small_error):
3099         (test_format_values_with_time):
3100         (test_format_values_with_no_error):
3101         (test_format_values_with_small_difference):
3102         (test_aggregate_results):
3103         (test_aggregate_results_with_gropus):
3104         (test_aggregate_nested_results):
3105         (test_lint_results):
3106         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3107         (BenchmarkRunner.execute): Added a call to show_results
3108         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
3109         (BenchmarkRunner.show_results): Added.
3110
3111 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
3112
3113         run_benchmark should have an option to specify the number of runs
3114         https://bugs.webkit.org/show_bug.cgi?id=145091
3115
3116         Reviewed by Antti Koivisto.
3117
3118         Added --count option.
3119
3120         * Scripts/run-benchmark:
3121         (main):
3122         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3123         (BenchmarkRunner.__init__):
3124
3125 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
3126
3127         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
3128
3129         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
3130
3131 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
3132
3133         Update results of WebKit1.StringTruncator after r184965.
3134
3135         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
3136
3137 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3138
3139         Unreviewed, updated my list of email addresses.
3140
3141         * Scripts/webkitpy/common/config/contributors.json:
3142
3143 2015-05-27  Dean Jackson  <dino@apple.com>
3144
3145         img.currentSrc problem in strict mode with old picturefill
3146         https://bugs.webkit.org/show_bug.cgi?id=144095
3147         <rdar://problem/21087013>
3148
3149         Reviewed by Simon Fraser.
3150
3151         Add a PICTURE_SIZES flag.
3152
3153         * Scripts/webkitperl/FeatureList.pm:
3154
3155 2015-05-26  Dana Burkart  <dburkart@apple.com>
3156
3157         Fixes compatibility issues with recent dashboard cleanup.
3158         https://bugs.webkit.org/show_bug.cgi?id=144814
3159
3160         Reviewed by Alexey Proskuryakov.
3161
3162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
3163         (BuildbotStaticAnalyzerQueueView):
3164         (BuildbotStaticAnalyzerQueueView.prototype.update):
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3166         (documentReady):
3167
3168 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
3169
3170         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
3171         https://bugs.webkit.org/show_bug.cgi?id=143091
3172         rdar://problem/19330328
3173
3174         Reviewed by Darin Adler and Timothy Hatcher.
3175
3176         We have many of these, which are hard to fit on the dashboard. Added a view that
3177         collapses to a single green bubble when everything is good, and expands when there
3178         are failures (or manually).
3179
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
3181
3182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3183         (Buildbot.prototype.set isAuthenticated):
3184         (Buildbot.prototype._normalizeQueueInfo):
3185         (Buildbot.prototype._normalizeQueuesInfo):
3186         (Buildbot.prototype.updateQueues):
3187         Moved queue info normalization here from BuildbitQueue. The latter is a model class
3188         that shouldn't have to know about presentation, and this lets us leep the knowledge
3189         about combined queues out if it. Later, we can refactor existing code, and move out
3190         all knowledge about headings and such.
3191
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3193         Added the new view. It's not quite universal, and doesn't have as helpful popovers
3194         as other views, but we can extend it when/if we use it for more than JSC.
3195
3196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3197         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
3198
3199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3200         (documentReady): Added support for combined queues. These are currently always ending up
3201         in Other column, but it's easy to customize in the future if we need to.
3202
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3204         (WebKitBuildbot): Added JSC queus.
3205
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3207         (.combined-queue-popover):
3208         (.combined-queue-popover .revision):
3209         Added styles for the combined view.
3210
3211 2015-05-26  Dan Bernstein  <mitz@apple.com>
3212
3213         Changed a file to use Unix line endings.
3214
3215         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3216
3217 2015-05-26  Dan Bernstein  <mitz@apple.com>
3218
3219         <rdar://problem/21104551> Update build settings
3220
3221         Reviewed by Anders Carlsson.
3222
3223         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3224         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3225         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3226         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3227         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3228         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3229         * asan/asan.xcconfig:
3230
3231 2015-05-26  Anders Carlsson  <andersca@apple.com>
3232
3233         Fix build.
3234
3235         * WebKitTestRunner/mac/EventSenderProxy.mm:
3236         (WTR::EventSenderProxy::mouseForceDown):
3237         (WTR::EventSenderProxy::mouseForceUp):
3238         (WTR::EventSenderProxy::mouseForceChanged):
3239
3240 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
3241
3242         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
3243         https://bugs.webkit.org/show_bug.cgi?id=145342
3244
3245         Reviewed by Darin Adler.
3246
3247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3248         (BuildbotIteration.prototype._parseData):
3249
3250 2015-05-26  Milan Crha  <mcrha@redhat.com>
3251
3252         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
3253         https://bugs.webkit.org/show_bug.cgi?id=138134
3254
3255         Reviewed by Žan Doberšek.
3256
3257         * gtk/generate-inspector-gresource-manifest.py:
3258         (get_filenames): Command line with expanded resources exceeds 32KB, which
3259         is a limit on Windows. It's better to expand wildcards inside the python script.
3260
3261 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3262
3263         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
3264         https://bugs.webkit.org/show_bug.cgi?id=140882
3265
3266         Reviewed by Gustavo Noronha Silva.
3267
3268         Make sure unit tests write IndexedDB databases to the temporary
3269         directory, and add a test case to check that the directory is
3270         correctly created at the expected path.
3271
3272         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3273         (testWebContextConfiguration):
3274         (serverCallback):
3275         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3276         (Test::Test):
3277
3278 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3279
3280         [GTK] Enable IndexedDB
3281         https://bugs.webkit.org/show_bug.cgi?id=98932
3282
3283         Reviewed by Žan Doberšek.
3284
3285         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
3286
3287 2015-05-24  Sam Weinig  <sam@webkit.org>
3288
3289         Crash when using a removed ScriptMessageHandler
3290         <rdar://problem/20888499>
3291         https://bugs.webkit.org/show_bug.cgi?id=145359
3292
3293         Reviewed by Dan Bernstein.
3294
3295         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3296         Add tests for removing script message handlers.
3297
3298 2015-05-23  Dan Bernstein  <mitz@apple.com>
3299
3300         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
3301         https://bugs.webkit.org/show_bug.cgi?id=145345
3302
3303         Reviewed by Sam Weinig.
3304
3305         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3306         * LayoutTestRelay/Configurations/Base.xcconfig:
3307         * TestWebKitAPI/Configurations/Base.xcconfig:
3308         * WebKitTestRunner/Configurations/Base.xcconfig:
3309
3310 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3311
3312         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
3313         https://bugs.webkit.org/show_bug.cgi?id=144848
3314
3315         Reviewed by Darin Adler.
3316
3317         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
3318
3319         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3320
3321 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
3322
3323         Fix one more merge error in static analyzer support.
3324
3325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
3326         (BuildbotStaticAnalyzerQueueView):
3327
3328 2015-05-22  Dana Burkart  <dburkart@apple.com>
3329
3330         Fix internal dashboard breakage from recent commit.
3331         https://bugs.webkit.org/show_bug.cgi?id=144814
3332
3333         Unreviewed build fix.
3334
3335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
3336         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
3337         (BuildbotStaticAnalyzerQueueView.prototype.update):
3338
3339 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
3340
3341         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3342         https://bugs.webkit.org/show_bug.cgi?id=130463
3343         rdar://problem/20461342
3344
3345         Reviewed by Tim Horton.
3346
3347         This was more of a timing related flakiness than an actual OS version specific bug,
3348         we weren't getting window visibility notifications.
3349         
3350         I will look into adding this function call to DumpRenderTree separately, layout tests
3351         might actually rely on the broken behavior.
3352
3353         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3354         (TestWebKitAPI::TEST_F):
3355         * TestWebKitAPI/mac/mainMac.mm:
3356         (main):
3357
3358 2015-05-22  Dana Burkart  <dburkart@apple.com>
3359
3360         Add missing file from r184804 (mis-applied diff).
3361         https://bugs.webkit.org/show_bug.cgi?id=144814
3362
3363         Reviewed by Alexey Proskuryakov.
3364
3365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
3366         (BuildbotStaticAnalyzerQueueView):
3367         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
3368         (BuildbotStaticAnalyzerQueueView.prototype.update):
3369
3370 2015-05-22  Dana Burkart  <dburkart@apple.com>
3371
3372         Add support to the botwatchers dashboard for a static analyzer bot.
3373         https://bugs.webkit.org/show_bug.cgi?id=144814
3374
3375         Reviewed by Alexey Proskuryakov.
3376
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3378         scan-build should be considered a productive step.
3379
3380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3381         (BuildbotQueue):
3382         Adds support for the staticAnalyzer property
3383
3384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3385         (BuildbotTestResults.prototype._parseResults):
3386         Get bug count from the scan-build step output
3387
3388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3389         (documentReady):
3390         Rename the performance column 'Other', and merge the current 'Other' column with it.
3391
3392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3393         (WebKitBuildbot):
3394         Now that performance bots are part of the 'Other' column, give them better headings.
3395
3396 2015-05-22  Tim Horton  <timothy_horton@apple.com>
3397
3398         Turn on autosaving of toolbar configuration in MiniBrowser
3399
3400         Rubber-stamped by Dan Bernstein.
3401
3402         * MiniBrowser/mac/BrowserWindow.xib:
3403
3404 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
3405
3406         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
3407         https://bugs.webkit.org/show_bug.cgi?id=145297
3408
3409         Reviewed by Tim Horton.
3410
3411         This is a refactoring to simplify code, and to make it more logical.
3412
3413         It is up to the view to decide how to present the queues, and whether to split
3414         them into debug and release, or in some different way.
3415
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3417         (BuildbotBuilderQueueView.filterQueues):
3418         (BuildbotBuilderQueueView):
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3420         (BuildbotLeaksQueueView):
3421         (BuildbotLeaksQueueView.prototype.update):
3422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3423         (BuildbotPerformanceQueueView):
3424         (BuildbotPerformanceQueueView.prototype.update):
3425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3426         (BuildbotQueueView):
3427         (BuildbotQueueView.prototype._updateQueues):
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3429         (BuildbotTesterQueueView):
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3431         (documentReady):
3432
3433 2015-05-22  Tim Horton  <timothy_horton@apple.com>
3434
3435         Remove action menu support
3436         https://bugs.webkit.org/show_bug.cgi?id=145305
3437         <rdar://problem/21070771>
3438
3439         Reviewed by Anders Carlsson.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
3443         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
3444         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
3445         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
3446         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
3447         Remove the tests.
3448
3449 2015-05-22  Dan Bernstein  <mitz@apple.com>
3450
3451         Removed the Use Shrink To Fit button from the toolbar’s default set.
3452
3453         Rubber-stamped by Tim Horton.
3454
3455         * MiniBrowser/mac/BrowserWindow.xib:
3456
3457 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
3458
3459         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
3460         https://bugs.webkit.org/show_bug.cgi?id=128420
3461
3462         Reviewed by Chris Fleizach.
3463
3464         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3465         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
3466
3467 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
3468
3469         [EFL] Bump libsoup version to 2.50.0
3470         https://bugs.webkit.org/show_bug.cgi?id=145127
3471
3472         Reviewed by Gyuyoung Kim.
3473
3474         * efl/jhbuild.modules:
3475         * efl/patches/soup-clang-warning-fix1.patch: Removed.
3476         * efl/patches/soup-clang-warning-fix2.patch: Removed.
3477
3478 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
3479
3480         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
3481         https://bugs.webkit.org/show_bug.cgi?id=145117
3482
3483         Reviewed by Csaba Osztrogonác.
3484
3485         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
3486         Tools/TestWebKitAPI/Tests/WTF/glib/.
3487
3488         * TestWebKitAPI/PlatformGTK.cmake:
3489         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
3490         (TestWebKitAPI::TEST):
3491
3492 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
3493
3494         [EFL] fix efreet error
3495         https://bugs.webkit.org/show_bug.cgi?id=143670
3496
3497         Reviewed by Gyuyoung Kim.
3498
3499         Fix efreet error by using external variable efreet_cache_update.
3500         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
3501         efreet error for efreet_cache does not occur.
3502
3503         * MiniBrowser/efl/main.c:
3504         (elm_main):
3505
3506 2015-05-20  Michael Saboff  <msaboff@apple.com>
3507
3508         Add option to run_jsc_stress_tests to disable JIT testing
3509         https://bugs.webkit.org/show_bug.cgi?id=145233
3510
3511         Reviewed by Mark Lam.
3512
3513         Added --no-jit option.
3514
3515         * Scripts/run-jsc-stress-tests:
3516
3517 2015-05-20  Alex Christensen  <achristensen@webkit.org>
3518
3519         Use correct String for StringView in WTF API tests
3520         https://bugs.webkit.org/show_bug.cgi?id=145226
3521         rdar://problem/20361786
3522
3523         Reviewed by Benjamin Poulain.
3524
3525         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3526         (TestWebKitAPI::TEST):
3527         Use patternHolder for pattern.
3528
3529 2015-05-20  Alex Christensen  <achristensen@webkit.org>
3530
3531         [Content Extensions] Relax restrictions on triggers that match everything.
3532         https://bugs.webkit.org/show_bug.cgi?id=145069
3533
3534         Reviewed by Benjamin Poulain.
3535
3536         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3537         (TestWebKitAPI::TEST_F):
3538         Update and add tests for new possibilities with .*
3539
3540 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
3541
3542         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
3543         https://bugs.webkit.org/show_bug.cgi?id=144992
3544
3545         Reviewed by Gyuyoung Kim.
3546
3547         * MiniBrowser/efl/main.c:
3548         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
3549         (on_key_down):
3550         (on_fullscreen_enter):
3551         (on_fullscreen_exit):
3552         (window_create):
3553
3554 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3555
3556         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
3557         https://bugs.webkit.org/show_bug.cgi?id=145109
3558
3559         Reviewed by Darin Adler.
3560
3561         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3562         (TestWebKitAPI::TEST):
3563
3564 2015-05-19  Anders Carlsson  <andersca@apple.com>
3565
3566         Add alternate menu items for performing operations on the default data store
3567         https://bugs.webkit.org/show_bug.cgi?id=145184
3568
3569         Reviewed by Sam Weinig.
3570
3571         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
3572         associated with a data store.
3573
3574         * MiniBrowser/mac/AppDelegate.m:
3575         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
3576         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
3577         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
3578         * MiniBrowser/mac/MainMenu.xib:
3579
3580 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
3581
3582         Fix tautological-compare warning in AtomicString.cpp
3583         https://bugs.webkit.org/show_bug.cgi?id=145120
3584
3585         Reviewed by Alexey Proskuryakov.
3586
3587         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3588         (TestWebKitAPI::TEST): Removed always true assert.
3589
3590 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
3591
3592         [EFL] Fix unsequenced warning in MiniBrowser's main.c
3593         https://bugs.webkit.org/show_bug.cgi?id=145123
3594
3595         Reviewed by Gyuyoung Kim.
3596
3597         * MiniBrowser/efl/main.c:
3598         (on_key_down):
3599
3600 2015-05-18  Daniel Bates  <dabates@apple.com>
3601
3602         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
3603         when staged non-empty file for commit
3604         https://bugs.webkit.org/show_bug.cgi?id=145082
3605
3606         Reviewed by Darin Adler.
3607
3608         Fixes two issues when running prepare-ChangeLog:
3609             1. The function above a deleted function is reported as changed.
3610             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
3611             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
3612             included in this patch).
3613
3614         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
3615         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
3616         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
3617         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
3618         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
3619         VCSUtil::parseChunkRange() has existing test coverage.
3620
3621         * Scripts/prepare-ChangeLog:
3622         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
3623         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
3624         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
3625         examine files that only have deletions. Currently this works as a side effect of the behavior of
3626         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
3627         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
3628         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
3629         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
3630         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
3631         We return (-1, -1) when the change represents a deletion.
3632         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
3633         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
3634         We return (-1, -1) when the change represents an addition.
3635         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
3636         unit tests.
3637
3638 2015-05-18  Anders Carlsson  <andersca@apple.com>
3639
3640         Add ATS keys to MiniBrowser
3641         https://bugs.webkit.org/show_bug.cgi?id=145141
3642
3643         Reviewed by Sam Weinig.
3644
3645         * MiniBrowser/mac/Info.plist:
3646
3647 2015-05-17  David Kilzer  <ddkilzer@apple.com>
3648
3649         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
3650         <http://webkit.org/b/145100>
3651
3652         Reviewed by Darin Adler.
3653
3654         * Scripts/bisect-builds:
3655         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
3656         - Switch to using PROMPT_RESPONSE_* constants when testing the
3657           value of $didReproduceBug.
3658         - Add do { } while loops to implement 'retry' mode.
3659         (promptForTest):
3660         - Switch to returning PROMPT_RESPONSE_* constants.
3661         - Add support for 'retry' response.
3662
3663 2015-05-16  Tanay C  <tanay.c@samsung.com>
3664
3665         [EFL][WK2] Minibrowser : Add search icon to search bar
3666         https://bugs.webkit.org/show_bug.cgi?id=139773
3667
3668         Reviewed by Gyuyoung Kim.
3669
3670         * MiniBrowser/efl/main.c: 
3671         (search_icon_show): Added.
3672         (search_box_show): Modified.
3673
3674 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
3675
3676         run_benchmark should have an option to specify the number of runs
3677         https://bugs.webkit.org/show_bug.cgi?id=145091
3678
3679         Reviewed by Stephanie Lewis.
3680
3681         Added --count option.
3682
3683         * Scripts/run-benchmark:
3684         (main):
3685         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3686         (BenchmarkRunner.__init__):
3687
3688 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
3689
3690         Temporarily disable failing API test.
3691
3692         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3693         (TestWebKitAPI::TEST):
3694
3695 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
3696
3697         User interruption while running of run-webkit-tests should also generate results.html
3698         https://bugs.webkit.org/show_bug.cgi?id=122154
3699
3700         Reviewed by Csaba Osztrogonác.
3701
3702         Generation of results.html on execution of run-webkit-tests happens only
3703         on completion of entire layout tests run. It should be created even when
3704         the execution has been interrupted - either by user (by pressing Ctrl+C)
3705         or because of other interruptions (like exit-after-n-failures option).
3706
3707         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3708         (LayoutTestRunner.run_tests):
3709         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3710         (Manager.run):
3711         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3712         (TestRunResults.__init__):
3713         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3714         (main):
3715         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3716         (RunTest.test_keyboard_interrupt):
3717         (MainTest.test_exception_handling):
3718
3719 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
3720
3721         [buildbot] Fix the URL of the performance bots
3722         https://bugs.webkit.org/show_bug.cgi?id=145043
3723
3724         Reviewed by Ryosuke Niwa.
3725
3726         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3727
3728 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
3729
3730         Add a layout mode that scales down the view to try to fit the document
3731         https://bugs.webkit.org/show_bug.cgi?id=145022
3732         <rdar://problem/19790341>
3733
3734         Reviewed by Dean Jackson.
3735
3736         * MiniBrowser/mac/BrowserWindow.xib:
3737         * MiniBrowser/mac/BrowserWindowController.h:
3738         * MiniBrowser/mac/WK2BrowserWindowController.m:
3739         (-[WK2BrowserWindowController toggleShrinkToFit:]):
3740         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
3741         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
3742
3743 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3744
3745         [CMake] Don't read the LOCATION property of targets
3746         https://bugs.webkit.org/show_bug.cgi?id=145018
3747
3748         Reviewed by Martin Robinson.
3749
3750         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
3751         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
3752         be the same at configure-time as it is at generate-time.
3753
3754         * TestWebKitAPI/CMakeLists.txt:
3755
3756 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
3757
3758         Add String literal overloads to equalIgnoringASCIICase()
3759         https://bugs.webkit.org/show_bug.cgi?id=145008
3760
3761         Reviewed by Benjamin Poulain.
3762
3763         Test changes to WTF.
3764
3765         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3766         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
3767         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
3768         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3769         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
3770         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
3771
3772 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3773
3774         SharedBuffer::createWithContentsOfFile should use map file routines
3775         https://bugs.webkit.org/show_bug.cgi?id=144192
3776
3777         Reviewed by Darin Adler.
3778
3779         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
3780
3781         * TestWebKitAPI/PlatformGTK.cmake:
3782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3783         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
3784         (TestWebKitAPI::FileSystemTest::tempFilePath):
3785         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
3786         (TestWebKitAPI::TEST_F):
3787         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
3788         (TestWebKitAPI::SharedBufferTest::tempFilePath):
3789         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
3790         (TestWebKitAPI::TEST_F):
3791
3792 2015-05-13  Alex Christensen  <achristensen@webkit.org>
3793
3794         [Content Extensions] Test interactions between multiple extensions and multiple domains.
3795         https://bugs.webkit.org/show_bug.cgi?id=144967
3796
3797         Reviewed by Benjamin Poulain.
3798
3799         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3800         Xcode wanted to fix an alphabetization issue.
3801         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3802         (TestWebKitAPI::TEST_F):
3803         Test interactions that worked but were not explicitly tested before.
3804
3805 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
3806
3807         Unreviewed build fix.
3808
3809         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
3810
3811         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
3812
3813 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
3814
3815         Fix the previous commit, which made both bubbles green.
3816
3817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3818         (.status-line.good .bubble):
3819         (.status-line.bad .bubble):
3820         (.status-line.good .message):
3821
3822 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
3823
3824         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
3825         https://bugs.webkit.org/show_bug.cgi?id=144929
3826
3827         Reviewed by Eric Carlson.
3828
3829         Tweaked colors as I see fit.
3830
3831         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3832         (.status-line.good .bubble):
3833         (.status-line.bad .bubble):
3834
3835 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
3836
3837         [Mac] Share cookie storage between UI process and secondary processes
3838         https://bugs.webkit.org/show_bug.cgi?id=144820
3839         rdar://problem/20572830
3840
3841         Reviewed by Darin Adler.
3842
3843         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3844         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
3845         for testing.
3846
3847 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
3848
3849         Fix internal build configuration issues
3850         https://bugs.webkit.org/show_bug.cgi?id=144762
3851
3852         Reviewed by David Kilzer.
3853
3854         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
3855
3856         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3857         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3858         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3859         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3860         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
3861         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
3862         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
3863         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
3864
3865 2015-05-12  David Kilzer  <ddkilzer@apple.com>
3866
3867         Switch to launching iOS Simulator using bundle ID
3868         <rdar://problem/20916096>
3869
3870         This is required to fix the layout tests on internal bots.
3871
3872         * Scripts/webkitdirs.pm:
3873         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
3874         Simulator.  Add FIXME.
3875         (quitIOSSimulator): Add FIXME.
3876         * Scripts/webkitpy/port/ios.py:
3877         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
3878         launch iOS Simulator.  Add FIXME.
3879         (IOSSimulatorPort.check_sys_deps): Add FIXME.
3880
3881 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
3882
3883         Fix run-javascriptcore-tests step on the WinCairo bot
3884         https://bugs.webkit.org/show_bug.cgi?id=144866
3885
3886         Reviewed by Csaba Osztrogonác.
3887
3888         Catch exception when failing to create soft link, so we can fall back to copy.
3889
3890         * Scripts/run-jsc-stress-tests:
3891
3892 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
3893
3894         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
3895         https://bugs.webkit.org/show_bug.cgi?id=116971
3896
3897         Reviewed by Chris Fleizach.
3898
3899         Implement rowAtIndex for ATK.
3900
3901         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3902         (WTR::AccessibilityUIElement::rowAtIndex):
3903
3904 2015-05-11  Dan Bernstein  <mitz@apple.com>
3905
3906         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
3907
3908         Reviewed by Alexey Proskuryakov.
3909
3910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3911         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
3912         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
3913         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
3914
3915 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
3916
3917         Fix internal build configuration issues
3918         https://bugs.webkit.org/show_bug.cgi?id=144762
3919
3920         Reviewed by Darin Adler.
3921
3922         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
3923
3924         * TestWebKitAPI/Configurations/Base.xcconfig:
3925         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3926         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3927         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3928         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3929         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3930         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3931
3932 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
3933
3934         [Win] Move Windows build target to Windows 7 (or newer)
3935         https://bugs.webkit.org/show_bug.cgi?id=144890
3936         <rdar://problem/20707307>
3937
3938         Reviewed by Anders Carlsson.
3939
3940         Update linked SDK and minimal Windows level to be compatible with
3941         Windows 7 or newer.
3942
3943         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3944         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3945         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3946         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3947         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3948         * DumpRenderTree/config.h:
3949         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3950         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3951         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3952         * WinLauncher/stdafx.h:
3953
3954 2015-05-11  Commit Queue  <commit-queue@webkit.org>
3955
3956         Unreviewed, rolling out r184119.
3957         https://bugs.webkit.org/show_bug.cgi?id=144888
3958
3959         broke JSC tests on Apple Windows bots (Requested by kling on
3960         #webkit).
3961
3962         Reverted changeset:
3963
3964         "Fix run-javascriptcore-tests step on the WinCairo bot"
3965         https://bugs.webkit.org/show_bug.cgi?id=144866
3966         http://trac.webkit.org/changeset/184119
3967
3968 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3969
3970         run-benchmark should support Dromaeo
3971         https://bugs.webkit.org/show_bug.cgi?id=144849
3972
3973         Reviewed by Chris Dumez.
3974
3975         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
3976         they can take as much as 15 minutes to run each.
3977
3978         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
3979         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
3980         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
3981         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
3982
3983 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3984
3985         Build fix. jetstream has a local copy, not remote archive.
3986
3987         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3988
3989 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3990
3991         run-benchmark should support SunSpider, Kraken and Octane
3992         https://bugs.webkit.org/show_bug.cgi?id=144840
3993
3994         Reviewed by Darin Adler.
3995
3996         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
3997         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
3998         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
3999         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
4000
4001         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
4002         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
4003
4004         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
4005         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
4006
4007         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
4008         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
4009         now has the ability to run an arbitrary "create script".
4010
4011         * Scripts/run-benchmark:
4012         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
4013         This also overrides the remote archive URL specified in the plan.
4014
4015         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
4016
4017         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
4018         JetStreamBenchmarkBuilder.
4019
4020         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
4021         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
4022         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
4023         _runCreateScript and _applyPatch to clean after themselves.
4024         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
4025         JetStream, SunSpider, Kraken all use this feature.
4026         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
4027         the leaf directory name since the latter is not available when a remote ZIP file is used.
4028         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
4029         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
4030         the benchmark name in the patches.
4031
4032         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
4033
4034         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4035         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
4036         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
4037         the browser opens by planName as the plan file no longer contains that.
4038
4039         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
4040         the top directory of JetStream instead of its parent.
4041         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
4042         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
4043         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
4044         the top directory of JetStream instead of its parent.
4045         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
4046         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
4047         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
4048         done in JetStream.patch.
4049         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
4050         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
4051         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
4052         path from the top directory of JetStream as done in JetStream.patch.
4053         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
4054
4055 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
4056
4057         Fix run-javascriptcore-tests step on the WinCairo bot
4058         https://bugs.webkit.org/show_bug.cgi?id=144866
4059
4060         Reviewed by Darin Adler.
4061
4062         * Scripts/run-jsc-stress-tests:
4063
4064 2015-05-11  Alex Christensen  <achristensen@webkit.org>
4065
4066         [Content Extensions] Support domain-specific rules and exceptions.
4067         https://bugs.webkit.org/show_bug.cgi?id=144833
4068
4069         Reviewed by Darin Adler.
4070
4071         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4072         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
4073         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
4074         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
4075         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
4076         (TestWebKitAPI::mainDocumentRequest):
4077         (TestWebKitAPI::subResourceRequest):
4078         (TestWebKitAPI::TEST_F):
4079         (TestWebKitAPI::checkCompilerError):
4080         Added tests for parsing and functionality of if-domain and unless-domain.
4081
4082 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
4083
4084         run-benchmark should support Chrome Canary and Firefox Nightly
4085         https://bugs.webkit.org/show_bug.cgi?id=144850
4086
4087         Reviewed by Darin Adler.
4088
4089         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
4090
4091         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
4092
4093         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
4094         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
4095         (OSXBrowserDriver):
4096         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
4097         (OSXBrowserDriver.closeBrowsers): Ditto.
4098         (OSXBrowserDriver.launchProcess): Ditto.
4099         (OSXBrowserDriver.terminateProcesses): Ditto.
4100         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
4101         (OSXChromeDriver): Removed the unused self.chromePreferences.
4102         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
4103         (OSXChromeDriver.closeBrowsers): Ditto.
4104         (OSXChromeDriver.launchUrl):
4105         (OSXChromeCanaryDriver): Added.
4106         (OSXChromeCanaryDriver.launchUrl):
4107         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
4108         (OSXFirefoxDriver): Added.
4109         (OSXFirefoxDriver.launchUrl):
4110         (OSXFirefoxNightlyDriver): Added.
4111         (OSXFirefoxNightlyDriver.launchUrl):
4112         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4113         (OSXSafariDriver):
4114         (OSXSafariDriver.closeBrowsers):
4115
4116 2015-05-11  Tim Horton  <timothy_horton@apple.com>
4117
4118         Page overlay action context override should indicate the source of the request
4119         https://bugs.webkit.org/show_bug.cgi?id=144832
4120         <rdar://problem/20562594>
4121
4122         Reviewed by Darin Adler.
4123
4124         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
4125         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
4126
4127 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
4128
4129         [GTK] fast/events/page-visibility-transition-test.html is timing out
4130         https://bugs.webkit.org/show_bug.cgi?id=114789
4131
4132         Reviewed by Darin Adler.
4133
4134         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4135         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
4136         requests visibility changes.
4137
4138 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
4139
4140         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
4141         https://bugs.webkit.org/show_bug.cgi?id=144798
4142
4143         Reviewed by Darin Adler.
4144
4145         * efl/install-dependencies:
4146
4147 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
4148
4149         Make arguments of run-benchmark more user friendly
4150         https://bugs.webkit.org/show_bug.cgi?id=144835
4151
4152         Reviewed by Darin Adler.
4153
4154         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
4155         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
4156         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
4157         default values from --platform and --browser as they are required arguments.
4158
4159         * Scripts/run-benchmark:
4160         (main): Made --build-directory optional, and removed default values from --platform and --browser.
4161         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
4162         are not dynamically obtained via BrowserDriverFactory.
4163         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4164         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
4165         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
4166         run any benchmark in that case.
4167         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
4168         the specified file isn't a valid relative or an absolute path.
4169         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
4170         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
4171         and browsers.
4172         (BrowserDriverFactory.available_browsers): Ditto.
4173         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
4174         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
4175         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
4176         browserBuildPath was None.
4177         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4178         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
4179         so that we can use locally built WebKit to launch Safari.
4180
4181 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
4182
4183         Remove the PICTURE_SIZES build flag
4184         https://bugs.webkit.org/show_bug.cgi?id=144679
4185
4186         Reviewed by Benjamin Poulain.
4187
4188         Removed the PICTURE_SIZES build time flag.
4189
4190         * Scripts/webkitperl/FeatureList.pm:
4191
4192 2015-05-09  David Kilzer  <ddkilzer@apple.com>
4193
4194         Layout tests broke due to unexpected simctl output
4195
4196         * Scripts/webkitpy/xcode/simulator.py:
4197         (Simulator._parse_devices): Handle new Device Pairs header.
4198         * Scripts/webkitpy/xcode/simulator_unittest.py:
4199         (test_device_pairs): Add unit test for Device Pairs header.
4200
4201 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
4202
4203         Remove convenience constructors for TextRun
4204         https://bugs.webkit.org/show_bug.cgi?id=144752
4205
4206         Reviewed by Anders Carlsson.
4207
4208         Test the StringView which takes a StringImpl*.
4209
4210         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4211         (StringView8Bit): Testing is8Bit() on StringView
4212
4213 2015-05-07  Sam Weinig  <sam@webkit.org>
4214
4215         [Content Extensions] Add simple tester that takes an extension and compiles it
4216         https://bugs.webkit.org/show_bug.cgi?id=144781
4217
4218         Reviewed by Dan Bates.
4219
4220         * ContentExtensionTester: Added.
4221         * ContentExtensionTester/Configurations: Added.
4222         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
4223         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
4224         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
4225         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
4226         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
4227         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
4228         * ContentExtensionTester/main.m: Added.
4229         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
4230
4231 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
4232
4233         Build fix.
4234
4235         Reviewed by Dan Bernstein.
4236
4237         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
4238         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
4239         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
4240         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
4241         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
4242         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
4243         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
4244         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
4245
4246 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
4247
4248         [GTK] Some tests fail because they do not assume the popup menu captures click events
4249         https://bugs.webkit.org/show_bug.cgi?id=40601
4250
4251         Reviewed by Carlos Garcia Campos.
4252
4253         Popdown all attached menus when moving between tests and between each new
4254         event sent to the WebView. This prevents context and popup menus from eating
4255         events.
4256
4257         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
4258         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
4259         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4260         (WTR::dispatchEvent): Popdown all menus between dispatching events.
4261         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
4262         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
4263         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4264         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
4265         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4266         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
4267         longer in the platform-independent file.
4268         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
4269
4270 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
4271
4272         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
4273         https://bugs.webkit.org/show_bug.cgi?id=144746
4274
4275         Reviewed by Carlos Garcia Campos.
4276
4277         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
4278
4279         * MiniBrowser/gtk/main.c:
4280         (main):
4281
4282 2015-05-08  Commit Queue  <commit-queue@webkit.org>
4283
4284         Unreviewed, rolling out r183996.
4285         https://bugs.webkit.org/show_bug.cgi?id=144806
4286
4287         ASan detected use-after free (Requested by ap on #webkit).
4288
4289         Reverted changeset: