2521294dd4e9f6e13e5db688f9eb2e8fef58fd01
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
2
3         [BlackBerry] Enable blob for the BlackBerry porting
4         https://bugs.webkit.org/show_bug.cgi?id=75074
5
6         Reviewed by George Staikos.
7
8         * Scripts/build-webkit:
9
10 2011-12-22  Kentaro Hara  <haraken@chromium.org>
11
12         Add unittests for the Perl parser of prepare-ChangeLog
13         https://bugs.webkit.org/show_bug.cgi?id=74994
14
15         Reviewed by David Kilzer.
16
17         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
18
19         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
20
21         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
22         Runs unittests specified in @testFiles.
23         You can reset expected results by specifying a --reset-results option.
24         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
25         Contains simple methods.
26         (func1):
27         (func2):
28         (func3):
29         (func4):
30         (func5):
31         (func6):
32         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
33         This test result is generated by the --reset-results option.
34
35 2011-12-21  Eric Seidel  <eric@webkit.org>
36
37         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
38         so that they appear in the bugzilla autocomplete CC list.
39         I also removed the "radar" irc nick (which I believe does not exist)
40         and removed the uneeded [] around the radar bugzilla email.
41
42         Unreviewed.
43
44         * Scripts/webkitpy/common/config/committers.py:
45
46 2011-12-21  Daniel Bates  <dbates@rim.com>
47
48         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
49         https://bugs.webkit.org/show_bug.cgi?id=74985
50
51         Reviewed by Eric Seidel.
52
53         * Scripts/build-jsc:
54         * Scripts/webkitdirs.pm:
55         (cmakeBasedPortName): Added.
56
57 2011-12-21  Daniel Bates  <dbates@rim.com>
58
59         Extract BlackBerry CMake arguments from build-webkit into separate function
60         https://bugs.webkit.org/show_bug.cgi?id=74981
61
62         Reviewed by Rob Buis.
63
64         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
65         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
66         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
67         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
68         that we can pass them to the CMake build system when building JavaScriptCore.
69
70         * Scripts/build-webkit: Move construction of CMake argument list from here to
71         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
72         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
73         call it from build-webkit.
74         * Scripts/webkitdirs.pm:
75         (blackberryCMakeArguments): Added.
76         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
77         BlackBerry port.
78
79 2011-12-21  Daniel Bates  <dbates@webkit.org>
80
81         Extract WinCE CMake arguments from build-webkit into separate function
82         https://bugs.webkit.org/show_bug.cgi?id=74983
83
84         Reviewed by Rob Buis.
85
86         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
87         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
88         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
89         that we can pass it to the CMake build system when building JavaScriptCore.
90
91         * Scripts/build-webkit:
92         * Scripts/webkitdirs.pm:
93         (cmakeBasedPortArguments): Added.
94
95 2011-12-21  Kentaro Hara  <haraken@chromium.org>
96
97         In prepare-ChangeLog, replace constant global variables with "use constant"
98         https://bugs.webkit.org/show_bug.cgi?id=74992
99
100         Reviewed by Ryosuke Niwa.
101
102         This patch replaces the following constant global variables with "use constant"s.
103             - $changeLogTimeZone
104             - $SVN
105             - $GIT
106             - %supportedTestExtensions
107
108         * Scripts/prepare-ChangeLog:
109         (changeLogNameFromArgs):
110         (changeLogEmailAddressFromArgs):
111         (resolveConflictedChangeLogs):
112         (generateNewChangeLogs):
113         (diffCommand):
114         (statusCommand):
115         (createPatchCommand):
116         (findOriginalFileFromSvn):
117         (determinePropertyChanges):
118         (generateFileList):
119         (reviewerAndDescriptionForGitCommit):
120
121 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
122
123         nrwt: rename field references from _fs to _filesystem
124         https://bugs.webkit.org/show_bug.cgi?id=74898
125
126         Reviewed by Adam Barth.
127
128         This is a simple cleanup; most of the code uses
129         self._filesystem, but some used self._fs; this change renames
130         the latter to the former to be more consistent.
131
132         * Scripts/webkitpy/layout_tests/controllers/manager.py:
133         (Manager.__init__):
134         (Manager.collect_tests):
135         (Manager._strip_test_dir_prefix):
136         (Manager._split_into_chunks_if_necessary):
137         (Manager.results_directory):
138         (Manager._clobber_old_results):
139         (Manager._upload_json_files):
140         (Manager.print_config):
141         (Manager._copy_results_html_file):
142         (Manager._show_results_html_file):
143         (Manager._log_worker_stack):
144         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
145         (JSONLayoutResultsGenerator._normalize_results_json):
146         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
147         (JSONResultsGeneratorBase.__init__):
148         (JSONResultsGeneratorBase.generate_json_output):
149         (JSONResultsGeneratorBase.generate_times_ms_file):
150         (JSONResultsGeneratorBase.upload_json_files):
151         (JSONResultsGeneratorBase._get_svn_revision):
152         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
153         (Base.__init__):
154
155 2011-12-20  Kentaro Hara  <haraken@chromium.org>
156
157         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
158         https://bugs.webkit.org/show_bug.cgi?id=74836
159
160         Reviewed by David Kilzer.
161
162         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
163         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
164         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
165         of prepare-ChangeLog.
166
167         Using LoadAsModule.pm, you can load a Perl script as follows.
168         The first argument is the arbitrary package name you want to use, and the second argument
169         is the name of the Perl script you want to load.
170
171             use LoadAsModule qw(RunLeaks run-leaks);
172             RunLeaks::someFunctionDefinedInRunLeaks(...);
173
174         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
175                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
176                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
177
178         * Scripts/webkitperl/LoadAsModule.pm: Added.
179         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
180         (import):
181         (readFile):
182         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
183         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
184         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
185
186 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
187
188         [Qt] WK2 Debugging quirks need some improvement
189         https://bugs.webkit.org/show_bug.cgi?id=74859
190
191         Reviewed by Simon Hausmann.
192
193         Improvements added to make debugging WebKit2 more
194         confortable and efficient:
195         1. Unify debugging quirks. From now all of them are controlled
196         by the QT_WEBKIT2_DEBUG environment variable.
197         2. Disable crash handlers for WebKitTestRunner if debugging quirks
198         are used to make it possible to use postmortem debugging via core dumps
199         which is extremely useful for debugging bugs triggered by layout tests.
200         3. Disable test timeout for WebKitTestRunner if debugging quirks
201         are used because that makes debugging impossible.
202
203         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
204         (WTR::InjectedBundle::platformInitialize):
205         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
206         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
207         * WebKitTestRunner/qt/TestControllerQt.cpp:
208         (WTR::TestController::platformRunUntil):
209
210 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
211
212         [Qt][WK2] Implement favicon support
213         https://bugs.webkit.org/show_bug.cgi?id=71082
214
215         Reviewed by Simon Hausmann.
216
217         A favorite icon was added on MiniBrowser's url bar as example.
218         We display a default icon when the page doesn't have an icon ready.
219
220         * MiniBrowser/qt/MiniBrowser.qrc:
221         * MiniBrowser/qt/icons/favicon.png: Added.
222         * MiniBrowser/qt/qml/BrowserWindow.qml:
223
224 2011-12-19  Sam Weinig  <sam@webkit.org>
225
226         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
227         https://bugs.webkit.org/show_bug.cgi?id=74907
228
229         Reviewed by Dan Bernstein.
230
231         Add ScrollByLineCommands API test.
232
233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
234         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
235         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
236
237 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
238
239         webkitpy: remove port.executive, port.filesystem, port.user properties
240         https://bugs.webkit.org/show_bug.cgi?id=74896
241
242         Reviewed by Eric Seidel.
243
244         Following on the refactoring of the port and host objects, this
245         removes the public executive, filesystem, and user properties
246         from the Port interface (protected versions of executive and
247         filesystem still exist). There is still some more clean up to
248         make the code more consistent and rearrange some other files to
249         talk to Hosts directly instead of getting them off of the Port
250         class.
251
252         * Scripts/webkitpy/layout_tests/controllers/manager.py:
253         (Manager.__init__):
254         (Manager.results_directory):
255         (Manager._log_worker_stack):
256         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
257         (ManagerTest.test_fallback_path_in_config):
258         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
259         (_InlineManager.start_worker):
260         (_InlineWorkerConnection.__init__):
261         * Scripts/webkitpy/layout_tests/controllers/worker.py:
262         (Worker.safe_init):
263         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
264         (TestConfiguration.from_port):
265         * Scripts/webkitpy/layout_tests/port/base.py:
266         (Port.__init__):
267         (Port.tests):
268         (Port.show_results_html_file):
269         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
270         (PortTest.test_layout_tests_skipping):
271         (PortTest.test_test_dirs):
272         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
273         (_set_up_derived_options):
274         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
275         (PerfTestsRunner.__init__):
276         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
277         (HtmlGenerator.__init__):
278         (HtmlGenerator.show_html):
279         (real_main):
280         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
281         (TestHtmlGenerator.make_generator):
282
283 2011-12-19  Daniel Bates  <dbates@webkit.org>
284
285         Pass command line arguments to GDB when debugging a Mac WebKit application
286         https://bugs.webkit.org/show_bug.cgi?id=72829
287
288         Reviewed by David Kilzer.
289
290         Pass through any command line arguments given to debug-{safari, minibrowser}
291         to GDB so that they may influence the application instance launched by GDB.
292
293         * Scripts/webkitdirs.pm:
294         (execMacWebKitAppForDebugging):
295
296 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
297
298         webkitpy: remove executive,filesystem,user parameters from Port constructor
299         https://bugs.webkit.org/show_bug.cgi?id=74878
300
301         Reviewed by Eric Seidel.
302
303         This change concludes the refactoring that makes Host a required
304         parameter for Port and ensures that all access to filesystem,
305         executives, etc. is going through the Host.
306
307         * Scripts/webkitpy/layout_tests/port/base.py:
308         (Port.__init__):
309
310 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
311
312         webkitpy: finish refactoring port classes to make a host mandatory
313         https://bugs.webkit.org/show_bug.cgi?id=74566
314
315         Reviewed by Eric Seidel.
316
317         This change makes all Port objects take a required (System)Host
318         parameter, and updates the TestPort object to no longer create a
319         mock filesystem or add files to the existing filesystem by
320         default.
321
322         * Scripts/webkitpy/layout_tests/port/base.py:
323         (Port.__init__):
324         * Scripts/webkitpy/layout_tests/port/factory.py:
325         (PortFactory.__init__):
326         (PortFactory._get_kwargs):
327         * Scripts/webkitpy/layout_tests/port/test.py:
328         (TestInstance.__init__):
329         (TestPort.__init__):
330         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
331         (passing_run):
332         (logging_run):
333         (get_tests_run):
334         (MainTest.test_single_file):
335         (MainTest.test_stderr_is_saved):
336         (MainTest.test_test_list):
337         (MainTest.test_test_list_with_prefix):
338         (MainTest.test_missing_and_unexpected_results):
339         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
340         (MainTest.test_crash_with_stderr):
341         (MainTest.test_no_image_failure_with_image_diff):
342         (MainTest.test_crash_log):
343         (MainTest.test_web_process_crash_log):
344         (MainTest.test_exit_after_n_failures_upload):
345         (MainTest.test_results_directory_absolute):
346         (MainTest.test_results_directory_relative):
347         (MainTest.test_retries_directory):
348         (MainTest.test_tolerance.get_port_for_run):
349         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
350         (EndToEndTest.test_end_to_end):
351         (EndToEndTest.test_reftest_with_two_notrefs):
352         (RebaselineTest.test_reset_results):
353         (RebaselineTest.test_missing_results):
354         (RebaselineTest.test_new_baseline):
355         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
356         (Rebaseliner.__init__):
357         (main):
358         (real_main):
359         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
360         (test_host_port_and_filesystem):
361         (TestRebaseliner.make_rebaseliner):
362         (TestRealMain.test_all_platforms):
363         (TestHtmlGenerator.make_generator):
364
365 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
366
367         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
368         https://bugs.webkit.org/show_bug.cgi?id=74562
369
370         Reviewed by Eric Seidel.
371
372         Apart from a minor change to style/checkers/test_expectations.py
373         to take a host as a parameter to a TestExpectationsChecker(),
374         there are only refactoring changes to unit tests here.
375
376         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
377         (TestResultWriterTest.test_reftest_diff_image):
378         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
379         (JSONGeneratorTest._test_json_generation):
380         (JSONGeneratorTest.test_test_timings_trie):
381         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
382         (Base.__init__):
383         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
384         (PortTest.make_port):
385         (PortTest.test_layout_tests_skipping):
386         (PortTest.test_test_dirs):
387         (PortTest.test_additional_platform_directory):
388         (PortTest.test_uses_test_expectations_file):
389         (PortTest.test_find_no_paths_specified):
390         (PortTest.test_find_one_test):
391         (PortTest.test_find_glob):
392         (PortTest.test_find_with_skipped_directories):
393         (PortTest.test_find_with_skipped_directories_2):
394         (PortTest.test_parse_reftest_list):
395         * Scripts/webkitpy/layout_tests/port/dryrun.py:
396         (DryRunPort.__init__):
397         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
398         (FactoryTest.setUp):
399         (FactoryTest.tearDown):
400         (FactoryTest.assert_port):
401         (FactoryTest.assert_platform_port):
402         (FactoryTest.test_unknown_specified):
403         (FactoryTest.test_unknown_default):
404         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
405         (GetGoogleChromePortTest._verify_expectations_overrides):
406         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
407         (MockDRTPortTest.make_port):
408         (MockDRTTest.assertTest):
409         (MockDRTTest.test_main):
410         (MockChromiumDRTTest.test_pixeltest__fails):
411         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
412         (QtPortTest._assert_search_path):
413         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
414         (TestWebKitPort.__init__):
415         (WebKitPortTest.test_skipped_directories_for_symbols):
416         (test_skipped_directories_for_features):
417         (test_skipped_layout_tests):
418         (test_skipped_file_search_paths):
419         (test_root_option):
420         (test_test_expectations):
421         (test_build_driver):
422         (test_linux_distro_detection):
423         (test_apache_config_file_name_for_platform):
424         (test_path_to_apache_config_file):
425         (WebKitDriverTest.test_read_block):
426         * Scripts/webkitpy/style/checkers/test_expectations.py:
427         (TestExpectationsChecker.__init__):
428         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
429         (TestExpectationsTestCase._expect_port_for_expectations_path):
430         (TestExpectationsTestCase.assert_lines_lint):
431         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
432         (get_test_config.TestMacPort):
433
434 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
435
436         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
437         https://bugs.webkit.org/show_bug.cgi?id=74854
438
439         Reviewed by Csaba Osztrogonác.
440
441         Since r101052, libewebkit.so is built in a different location, so we
442         need to adjust the path returned by builtDylibPathForName.
443
444         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
445         port also respects Release/Debug configurations.
446
447         These changes should make run-launcher finally work correctly with
448         webkit-efl.
449
450         * Scripts/webkitdirs.pm:
451         (usesPerConfigurationBuildDirectory):
452         (builtDylibPathForName):
453
454 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
455
456         [Qt][WK2] Add support for modal event loop processing for WTR
457         https://bugs.webkit.org/show_bug.cgi?id=74852
458
459         Reviewed by Kenneth Rohde Christiansen.
460
461         Rewrote event loop processing: Instead of terminating the event loop
462         in notifyDone() - something no other platform does - we now respect the
463         "bool& condition" parameter passed to platformRunUntil. This ensures
464         proper termination even when the condition is changed from within a
465         nested event loop, because only when we _exit_ from the nested event
466         loop we will check the condition and terminate the test properly.
467
468         In addition this patch implements TestController::runModal by means of
469         a nested event loop, which is passed to the platform webview that is
470         supposed to be modal. It is that view's responsibility to exit the
471         loop, upon destruction. I believe that's similar to how it works on the Mac,
472         where it doesn't seem that NSApp's runModalForWindow is terminate via
473         abort/stopModal but simply because the window is closed.
474
475         * WebKitTestRunner/PlatformWebView.h:
476         (WTR::PlatformWebView::setModalEventLoop):
477         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
478         (WTR::PlatformWebView::PlatformWebView):
479         (WTR::PlatformWebView::~PlatformWebView):
480         * WebKitTestRunner/qt/TestControllerQt.cpp:
481         (WTR::TestController::notifyDone):
482         (WTR::TestController::platformRunUntil):
483         (WTR::TestController::runModal):
484
485 2011-12-18  Kentaro Hara  <haraken@chromium.org>
486
487         REGRESSION(r103149): prepare-ChangeLog outputs a warning
488         https://bugs.webkit.org/show_bug.cgi?id=74808
489
490         Reviewed by David Kilzer.
491
492         Added the prototype declaration of main() to avoid warning messages.
493         Sorted subroutine declarations in the alphabetical order.
494
495         * Scripts/prepare-ChangeLog:
496
497 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
498
499         [Qt] Fix QtTestBrowser compilation with QtWidgets module
500         https://bugs.webkit.org/show_bug.cgi?id=74791
501
502         Reviewed by Andreas Kling.
503
504         * QtTestBrowser/QtTestBrowser.pro:
505
506 2011-12-17  Kentaro Hara  <haraken@chromium.org>
507
508         Remove top-level code completely from prepare-ChangeLog
509         https://bugs.webkit.org/show_bug.cgi?id=74698
510
511         Reviewed by Darin Adler.
512
513         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
514         This patch just moves all top-level code into main().
515
516         * Scripts/prepare-ChangeLog:
517         (main):
518
519 2011-12-16  Dean Jackson  <dino@apple.com>
520
521         Move webkit-bug-importer to Contributor. It won't
522         autocomplete as an Account.
523         See https://bugs.webkit.org/show_bug.cgi?id=74739
524         for some discussion.
525
526         Unreviewed.
527
528         * Scripts/webkitpy/common/config/committers.py:
529
530 2011-12-16  Dean Jackson  <dino@apple.com>
531
532         Add webkit-bug-importer@group.apple.com to accounts
533         so that it autocompletes in bugzilla.
534
535         Unreviewed.
536
537         * Scripts/webkitpy/common/config/committers.py:
538
539 2011-12-16  Philippe Normand  <pnormand@igalia.com>
540
541         Unreviewed, skipping 3 failing GTK API tests.
542
543         * Scripts/run-gtk-tests:
544
545 2011-12-16  Philippe Normand  <pnormand@igalia.com>
546
547         Unreviewed, GTK API tests build fix attempt.
548
549         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
550
551 2011-12-16  Philippe Normand  <pnormand@igalia.com>
552
553         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
554
555         * Scripts/run-gtk-tests:
556
557 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
558
559         [Qt] Fix the build for newer Qt5
560         https://bugs.webkit.org/show_bug.cgi?id=74703
561
562         Reviewed by Csaba Osztrogonác.
563
564         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
565         * DumpRenderTree/qt/EventSenderQt.cpp:
566         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
567         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
568         (WTR::EventSenderProxy::sendTouchEvent):
569         * MiniBrowser/qt/MiniBrowserApplication.cpp:
570         (MiniBrowserApplication::sendTouchEvent): Ditto.
571         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
572
573 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
574
575         [Qt] Detect and force clean build when feature defines are added
576
577         Reviewed by Ossy.
578
579         https://bugs.webkit.org/show_bug.cgi?id=74689
580
581         * Scripts/webkitdirs.pm:
582
583 2011-12-16  Kentaro Hara  <haraken@chromium.org>
584
585         [Refactoring] Remove all global variables from prepare-ChangeLog
586         https://bugs.webkit.org/show_bug.cgi?id=74681
587
588         Reviewed by Ryosuke Niwa.
589
590         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
591         manner. This bug is one of the incremental refactorings to remove all top-level
592         code and global variables from prepare-ChangeLog. In this patch,
593         we make the following global variables be used only through parameter passing.
594         This patch removes all global variables from prepare-ChangeLog.
595             - $mergeBase
596             - $gitCommit
597             - $gitIndex
598
599         * Scripts/prepare-ChangeLog:
600         (generateFunctionLists):
601         (changeLogNameFromArgs):
602         (changeLogEmailAddressFromArgs):
603         (generateNewChangeLogs):
604         (printDiff):
605         (diffFromToString):
606         (diffCommand):
607         (statusCommand):
608         (createPatchCommand):
609         (generateFileList):
610         (isConflictStatus):
611
612 2011-12-15  Philippe Normand  <pnormand@igalia.com>
613
614         [GTK] Rounding errors on 32-bit machines causes tests to fail
615         https://bugs.webkit.org/show_bug.cgi?id=72254
616
617         Initial patch by vanuan@gmail.com.
618         Reviewed by Martin Robinson.
619
620         * Scripts/webkitdirs.pm:
621         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
622         CXXFLAGS to autogen in an attempt to harmonize floating point
623         values between 32-bit and 64-bit architectures.
624
625 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
626
627         [GTK] Make distcheck fails during the install
628         https://bugs.webkit.org/show_bug.cgi?id=74274
629
630         No review, since this is a build fix.
631
632         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
633         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
634         always runs. This means that the gtkdoc step was always running when make was
635         invoked. Generating gtkdoc during 'make install' was triggering a race condition
636         with the library file. Later we can fix generate-forwarding-headers and unbreak
637         'make docs,' but this bandaid is sufficient to let us release.
638
639 2011-12-15  Eric Seidel  <eric@webkit.org>
640
641         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
642         https://bugs.webkit.org/show_bug.cgi?id=74650
643
644         Reviewed by Adam Barth.
645
646         * Scripts/webkitpy/common/system/platforminfo.py:
647         (PlatformInfo._compute_bytes_from_vm_stat_output):
648         * Scripts/webkitpy/layout_tests/port/base.py:
649         (Port.default_child_processes):
650         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
651         (PortTest.test_default_child_processes):
652
653 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
654
655         bencher script should support remote benchmarking on platforms that don't have ruby
656         https://bugs.webkit.org/show_bug.cgi?id=74659
657
658         Rubber-stamped by Sam Weinig.
659         
660         Added the ability to have bencher generate a benchmarking playload that consists of
661         copies of all of the benchmarks, optionally copies of all of the frameworks and
662         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
663         order, which then spits out a raw results file that bencher can parse.
664         
665         In normal operating mode, you never see this, as it just generates the payload and
666         script internally, runs it, parses the results, and spits them out.
667         
668         The --remote mode has been changed to use this style, so any remote host that has
669         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
670         a sh-compatible shell can be used for remote benchmarking.
671         
672         The feature to include VMs in the benchmarking payload is by default only activated
673         when using --remote, but it can also be activated when doing local benchmarking; the
674         benefit is that you remove any pathname-related performance pathologies. All VMs
675         become equal because they are all located in
676         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
677         (usually 0 or 1).
678         
679         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
680         through DumpRenderTree. This is only a bit slower than running in jsc.
681
682         * Scripts/bencher:
683
684 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
685
686         webkitpy: clean up TestPort to (mostly) not create a new filesystem
687         https://bugs.webkit.org/show_bug.cgi?id=74556
688
689         This change modifies the TestPort to be ready to add tests to an
690         existing filesystem instead of creating a new filesystem; we
691         leave unit_test_filesystem() in for now for compatibility.
692
693         * Scripts/webkitpy/common/host_mock.py:
694         (MockHost.__init__):
695           - call add_unit_tests_to_mock_filesystem by default to make
696             the MockHost more generally useful for layout_test unit tests.
697         * Scripts/webkitpy/layout_tests/port/test.py:
698         (TestInstance.__init__):
699         (add_unit_tests_to_mock_filesystem):
700         (add_file):
701         (unit_test_filesystem):
702         (TestPort.__init__):
703         (TestPort._set_default_overriding_none):
704
705 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
706
707         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
708         https://bugs.webkit.org/show_bug.cgi?id=74551
709
710         This is some minor cleanup prior to making all of the host/port
711         changes described in bug 74138.
712
713         * Scripts/webkitpy/common/host_mock.py:
714         (MockHost.__init__):
715           - make sure the scm object is initialized with the same mock
716             executive and filesystem objects.
717
718         * Scripts/webkitpy/common/system/filesystem_mock.py:
719         (MockFileSystem.clear_written_files):
720           - add a routine that will be useful in testing.
721         (MockFileSystem.maybe_make_directory):
722         (MockFileSystem.write_binary_file):
723           - fix bugs to make sure directories are created properly.
724         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
725         (_Process.run):
726           - add clarifying comments.
727         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
728         (MockDRTPort.__init__):
729         (MockDRT.__init__):
730           - add clarifying comments.
731
732 2011-12-15  Anders Carlsson  <andersca@apple.com>
733
734         Regression (r102866): Navigating away from or closing a page with a plugin crashes
735         https://bugs.webkit.org/show_bug.cgi?id=74655
736
737         Reviewed by Sam Weinig.
738
739         Add a bunch of tests.
740
741         * TestWebKitAPI/Tests/WTF/Functional.cpp:
742
743 2011-12-15  Stephanie Lewis  <slewis@apple.com>
744
745         https://bugs.webkit.org/show_bug.cgi?id=74469
746         Escape paths to svn commands so our tools can handle filenames with @ symbols.
747
748         Reviewed by Adam Roben.
749
750         * Scripts/VCSUtils.pm:
751         (scmMoveOrRenameFile):
752         (scmAddExecutableBit):
753         (scmRemoveExecutableBit):
754         (determineSVNRoot):
755         (svnRevisionForDirectory):
756         (pathRelativeToSVNRepositoryRootForPath):
757         (svnStatus):
758         (escapeSubversionPath):
759         * Scripts/parse-malloc-history:
760         (main):
761         * Scripts/prepare-ChangeLog:
762         (diffCommand):
763         (statusCommand):
764         (findOriginalFileFromSvn):
765         (determinePropertyChanges):
766         * Scripts/resolve-ChangeLogs:
767         (conflictFiles):
768         (resolveConflict):
769         (showStatus):
770         * Scripts/svn-apply:
771         (patch):
772         (scmCopy):
773         (scmAdd):
774         (scmRemove):
775         * Scripts/svn-create-patch:
776         (findBaseUrl):
777         (findMimeType):
778         (findSourceFileAndRevision):
779         (generateDiff):
780         (generateFileList):
781         (manufacturePatchForAdditionWithHistory):
782         * Scripts/svn-unapply:
783         (patch):
784         (revertDirectories):
785
786 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
787
788         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
789         https://bugs.webkit.org/show_bug.cgi?id=74617
790
791         Reviewed by Kenneth Rohde Christiansen.
792
793         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
794         for viewport info button, adjusted height and added rounded corners.
795
796 2011-12-15  Andy Estes  <aestes@apple.com>
797
798         TestFailures: store the name of the buildbot results directory in a property
799         https://bugs.webkit.org/show_bug.cgi?id=74663
800
801         Reviewed by Adam Barth.
802         
803         Store the name of the results directory as a property on Buildbot's
804         prototype. This allows subclasses of Buildbot to customize the results
805         directory.
806
807         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
808         (Buildbot.prototype.resultsDirectoryURL):
809
810 2011-12-15  Tony Chang  <tony@chromium.org>
811
812         [chromium] pass --delete_unversioned_trees to gclient on the bots
813         https://bugs.webkit.org/show_bug.cgi?id=74565
814
815         Reviewed by Kenneth Russell.
816
817         It was temporarily removed in r102891 to keep the bots green.  Now
818         that the bots have cycled, we can add it back.
819
820         * Scripts/update-webkit-chromium:
821
822 2011-12-15  Kentaro Hara  <haraken@chromium.org>
823
824         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
825         https://bugs.webkit.org/show_bug.cgi?id=74497
826
827         Reviewed by Ryosuke Niwa.
828
829         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
830         manner. This bug is one of the incremental refactorings to remove all top-level
831         code and global variables from prepare-ChangeLog. In this patch,
832         we make the following global variables be used only through parameter passing.
833             - $bugDescription
834             - $bugNumber
835             - $name
836             - $emailAddress
837             - $gitReviewer
838             - $writeChangeLogs
839
840         * Scripts/prepare-ChangeLog:
841         (fetchBugDescriptionFromURL):
842         (generateNewChangeLogs):
843         (reviewerAndDescriptionForGitCommit):
844
845 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
846
847         [EFL] Add a few more web database functions to ewk_settings.
848         https://bugs.webkit.org/show_bug.cgi?id=72148
849
850         Reviewed by Antonio Gomes.
851
852         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
853         (LayoutTestController::clearAllDatabases):
854         (LayoutTestController::setDatabaseQuota):
855
856 2011-12-15  Martin Kosiba  <mkosiba@google.com>
857
858         Fix find on web pages with -webkit-user-select: none for Chromium
859         https://bugs.webkit.org/show_bug.cgi?id=72281
860
861         Reviewed by Ryosuke Niwa.
862
863         Provided a partial findString implementation. This doesn't support
864         all of the FindOptions since they're not exposed via WebFindOptions.
865
866         * DumpRenderTree/chromium/LayoutTestController.cpp:
867         (LayoutTestController::LayoutTestController):
868         (LayoutTestController::findString):
869         * DumpRenderTree/chromium/LayoutTestController.h:
870
871 2011-12-15  Kenneth Russell  <kbr@google.com>
872
873         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
874         https://bugs.webkit.org/show_bug.cgi?id=74581
875
876         Reviewed by Darin Fisher.
877
878         * DumpRenderTree/chromium/LayoutTestController.cpp:
879         (LayoutTestController::overridePreference):
880         * DumpRenderTree/chromium/WebPreferences.cpp:
881         (WebPreferences::reset):
882         (WebPreferences::applyTo):
883         * DumpRenderTree/chromium/WebPreferences.h:
884
885 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
886
887         [Qt] Improve the look of the viewport info overlay
888
889         Reviewed by Tor Arne Vestbø.
890
891         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
892
893 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
894
895         [Qt] Support requestAnimationFrame API
896         https://bugs.webkit.org/show_bug.cgi?id=74528
897
898         Add build-option for requestAnimationFrame feature.
899
900         Reviewed by Kenneth Rohde Christiansen.
901
902         * qmake/mkspecs/features/features.prf:
903
904 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
905
906         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
907
908         Reviewed by Simon Hausmann.
909
910         * qmake/mkspecs/features/webcore.prf:
911
912 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
913
914         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
915         https://bugs.webkit.org/show_bug.cgi?id=72893
916
917         Reviewed by Kenneth Rohde Christiansen.
918
919         This patch extends QQuickWebViewExperimental by a property named
920         viewportInfo, which contains the viewport scalability and
921         layout and contents size information. This property is exposed to
922         QML through the experimental extension for QQuickWebView.
923
924         * MiniBrowser/qt/MiniBrowser.pro:
925         * MiniBrowser/qt/MiniBrowser.qrc:
926         * MiniBrowser/qt/icons/info.png: Added.
927         * MiniBrowser/qt/qml/BrowserWindow.qml:
928         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
929
930 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
931
932         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
933         https://bugs.webkit.org/show_bug.cgi?id=74586
934
935         Reviewed by Hajime Morita.
936
937         No new tests. Covered by existing tests.
938
939         * DumpRenderTree/chromium/WebViewHost.cpp:
940         (WebViewHost::requestCheckingOfText):
941           Returns immediately if text is empty.
942
943 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
944
945         [Qt] QtWebKit fails to build on Mac OS X after r102776
946         https://bugs.webkit.org/show_bug.cgi?id=74593
947
948         Reviewed by Simon Hausmann.
949
950         CONFIG =+ link_pkgconfig is needed such that the correct parameters
951         are passed to the compiler.
952
953         * DumpRenderTree/qt/DumpRenderTree.pro:
954
955 2011-12-14  Tony Chang  <tony@chromium.org>
956
957         [chromium] Remove redundant third_party entries from chromium DEPS
958         https://bugs.webkit.org/show_bug.cgi?id=74472
959
960         Reviewed by Kenneth Russell.
961
962         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
963
964 2011-12-14  Kentaro Hara  <haraken@chromium.org>
965
966         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
967         VCSUtils::isGit() and VCSUtils::isSVN().
968         https://bugs.webkit.org/show_bug.cgi?id=74485
969
970         Reviewed by David Kilzer.
971
972         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
973         manner. This bug is one of the incremental refactorings to remove all top-level
974         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
975         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
976         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
977         just by looking at the current working directory.
978
979         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
980         (diffFromToString):
981         (diffCommand):
982         (statusCommand):
983         (createPatchCommand):
984         (diffHeaderFormat):
985         (generateFileList):
986         (isAddedStatus):
987         (isConflictStatus):
988         (statusDescription):
989         (extractLineRange):
990
991 2011-12-14  Sam Weinig  <weinig@apple.com>
992
993         Remove whitespace from InheritedPropertySheets attributes in
994         vsprops files to appease the Visual Studio project migrator.
995
996         Reviewed by Adam Roben.
997
998         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
999         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
1000         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
1001         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1002         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1003         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1004         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
1005         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
1006         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
1007         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1008         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1009         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1010         * DumpRenderTree/win/ImageDiffDebug.vsprops:
1011         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
1012         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
1013         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1014         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1015         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1016         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
1017         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
1018         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
1019         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1020         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1021         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1022         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1023         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1024         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
1025         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
1026         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
1027         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1028         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1029         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1030         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
1031         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
1032         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
1033         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1034         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1035         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1036         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
1037         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
1038         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
1039         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1040         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1041         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1042         * WinLauncher/WinLauncherDebug.vsprops:
1043         * WinLauncher/WinLauncherDebugAll.vsprops:
1044         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
1045         * WinLauncher/WinLauncherProduction.vsprops:
1046         * WinLauncher/WinLauncherRelease.vsprops:
1047         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1048         * record-memory-win/record-memory-winDebug.vsprops:
1049         * record-memory-win/record-memory-winDebugAll.vsprops:
1050         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
1051         * record-memory-win/record-memory-winProduction.vsprops:
1052         * record-memory-win/record-memory-winRelease.vsprops:
1053         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1054
1055 2011-12-14  Anders Carlsson  <andersca@apple.com>
1056
1057         Windows build fix.
1058
1059         Move CHECKs out of the destructor.
1060
1061         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1062         (TestWebKitAPI::B::~B):
1063         (TestWebKitAPI::TEST):
1064
1065 2011-12-14  Anders Carlsson  <andersca@apple.com>
1066
1067         binding a member function should ref/deref the object pointer if needed
1068         https://bugs.webkit.org/show_bug.cgi?id=74552
1069
1070         Reviewed by Sam Weinig.
1071
1072         Add new tests.
1073
1074         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1075         (TestWebKitAPI::B::B):
1076         (TestWebKitAPI::B::~B):
1077         (TestWebKitAPI::B::ref):
1078         (TestWebKitAPI::B::deref):
1079         (TestWebKitAPI::B::f):
1080         (TestWebKitAPI::B::g):
1081         (TestWebKitAPI::TEST):
1082
1083 2011-12-14  Hajime Morrita  <morrita@chromium.org>
1084
1085         JS_INLINE and WTF_INLINE should be visible from WebCore
1086         https://bugs.webkit.org/show_bug.cgi?id=73191
1087
1088         Reviewed by Kevin Ollivier.
1089
1090         Removed macro definitions which is now provided by Platform.h
1091
1092         * DumpRenderTree/chromium/config.h:
1093         * DumpRenderTree/config.h:
1094         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
1095         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
1096         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
1097         * TestWebKitAPI/config.h:
1098         * WebKitTestRunner/config.h:
1099
1100 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1101
1102         Unreviewed, rolling out r102761.
1103         http://trac.webkit.org/changeset/102761
1104         https://bugs.webkit.org/show_bug.cgi?id=74485
1105
1106         we came up with a better fix than this (see comments in bug
1107         74485)
1108
1109         * Scripts/prepare-ChangeLog:
1110         (generateFunctionLists):
1111         (printDiff):
1112         (diffCommand):
1113         (statusCommand):
1114         (createPatchCommand):
1115         (generateFileList):
1116         (isAddedStatus):
1117         (isConflictStatus):
1118         (statusDescription):
1119         (extractLineRange):
1120
1121 2011-12-14  Anders Carlsson  <andersca@apple.com>
1122
1123         Work around a bug in the MSVC2005 compiler
1124         https://bugs.webkit.org/show_bug.cgi?id=74550
1125
1126         Reviewed by Sam Weinig.
1127
1128         Re-enable tests.
1129
1130         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1131
1132 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1133
1134         [Qt] Test fonts are not used with Qt5
1135         https://bugs.webkit.org/show_bug.cgi?id=72513
1136
1137         My last unreviewed buildfix for this crazy bug.
1138
1139         * qmake/mkspecs/features/features.prf:
1140
1141 2011-12-14  Anders Carlsson  <andersca@apple.com>
1142
1143         Another attempt at fixing the Windows build.
1144
1145         Disable all the tests until I can figure out what's going on here.
1146
1147         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1148
1149 2011-12-14  Anders Carlsson  <andersca@apple.com>
1150
1151         Fix the Windows build.
1152
1153         Disable some of the tests for now.
1154
1155         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1156
1157 2011-12-14  Anders Carlsson  <andersca@apple.com>
1158
1159         bind should handle member functions
1160         https://bugs.webkit.org/show_bug.cgi?id=74529
1161
1162         Reviewed by Sam Weinig.
1163
1164         Add tests.
1165
1166         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1167         (TestWebKitAPI::A::A):
1168         (TestWebKitAPI::A::f):
1169         (TestWebKitAPI::A::addF):
1170         (TestWebKitAPI::TEST):
1171
1172 2011-12-14  Anders Carlsson  <andersca@apple.com>
1173
1174         Add unary and binary bind overloads
1175         https://bugs.webkit.org/show_bug.cgi?id=74524
1176
1177         Reviewed by Sam Weinig.
1178
1179         Add tests.
1180
1181         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1182         (TestWebKitAPI::TEST):
1183         (TestWebKitAPI::multiplyByTwo):
1184         (TestWebKitAPI::multiplyByOneAndAHalf):
1185         (TestWebKitAPI::multiply):
1186         (TestWebKitAPI::subtract):
1187
1188 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1189
1190         [Qt] Test fonts are not used with Qt5
1191         https://bugs.webkit.org/show_bug.cgi?id=72513
1192
1193         MIPS and SH4 buildfix after r102776 and r102795.
1194
1195         Reviewed by Csaba Osztrogonác.
1196
1197         * qmake/mkspecs/features/features.prf:
1198
1199 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1200
1201         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
1202
1203         * qmake/mkspecs/features/features.prf:
1204
1205 2011-12-14  Andreas Kling  <kling@webkit.org>
1206
1207         Make my e-mail address a little more awesome.
1208
1209         * Scripts/webkitpy/common/config/committers.py:
1210
1211 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1212
1213         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
1214
1215         * qmake/mkspecs/features/webcore.prf:
1216
1217 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
1218
1219         [Qt] Test fonts are not used with Qt5
1220         https://bugs.webkit.org/show_bug.cgi?id=72513
1221
1222         Reviewed by Simon Hausmann.
1223
1224         Don't depend on Q_WS_X11 anymore since it's not the Qt5
1225         way to detect the platform. Make the guards depend
1226         on our own configtest for fontconfig. For Qt4 we can still
1227         use the preassumption that we have it on Linux.
1228
1229         * DumpRenderTree/qt/DumpRenderTree.pro:
1230         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1231         (WebCore::DumpRenderTree::open):
1232         (WebCore::DumpRenderTree::initializeFonts):
1233         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1234         * DumpRenderTree/qt/main.cpp:
1235         (main): Additionally remove a nonsense piece of code that was
1236         trying to reset the font settings - which is not necessary -
1237         after we have already returned from main.
1238         * WebKitTestRunner/InjectedBundle/Target.pri:
1239         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1240         (WTR::activateFonts):
1241         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
1242         from WTR. It is not needed. We set up the fonts via the injected bundle.
1243         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
1244         (main):
1245         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
1246         * qmake/mkspecs/features/features.prf:
1247         * qmake/sync.profile:
1248
1249 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1250
1251         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1252
1253         Followup to r102679
1254
1255         https://bugs.webkit.org/show_bug.cgi?id=74413
1256
1257         Reviewed by Simon Hausmann.
1258
1259         * qmake/mkspecs/features/webcore.prf:
1260
1261 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
1262
1263         [Qt] Mobile theme could use a little refresh
1264         https://bugs.webkit.org/show_bug.cgi?id=74293
1265
1266         Have MiniBrowser use the mobile theme when not
1267         passed --desktop.
1268
1269         Reviewed by Kenneth Rohde Christiansen.
1270
1271         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1272         (MiniBrowserApplication::handleUserOptions):
1273
1274 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
1275
1276         [Qt] [Gardening] Remove qt-4.7 layout tests dir
1277         https://bugs.webkit.org/show_bug.cgi?id=74426
1278
1279         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
1280         on the tree.
1281
1282         Reviewed by Csaba Osztrogonác.
1283
1284         * Scripts/webkitpy/layout_tests/port/qt.py:
1285         (QtPort.qt_version):
1286         (QtPort.baseline_search_path):
1287         (QtPort._skipped_file_search_paths):
1288         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1289         (QtPortTest._assert_search_path):
1290
1291 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1292
1293         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
1294         through parameter passing
1295         https://bugs.webkit.org/show_bug.cgi?id=74485
1296
1297         Reviewed by Ryosuke Niwa.
1298
1299         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1300         manner. This bug is one of the incremental refactorings to remove all top-level
1301         code and global variables from prepare-ChangeLog. In this patch,
1302         we make the following global variables be used only through parameter passing.
1303             - $isGit
1304             - $isSVN
1305
1306         * Scripts/prepare-ChangeLog:
1307         (generateFunctionLists):
1308         (printDiff):
1309         (diffFromToString):
1310         (diffCommand):
1311         (statusCommand):
1312         (createPatchCommand):
1313         (diffHeaderFormat):
1314         (generateFileList):
1315         (isAddedStatus):
1316         (isConflictStatus):
1317         (statusDescription):
1318         (extractLineRange):
1319
1320 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
1321
1322         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
1323         https://bugs.webkit.org/show_bug.cgi?id=74417
1324
1325         Reviewed by Simon Hausmann.
1326
1327         Based on original patch by Kenneth Christiansen.
1328
1329         Already covered by current tests.
1330
1331         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1332         (WebCore::DumpRenderTree::DumpRenderTree):
1333         (WebCore::DumpRenderTree::~DumpRenderTree):
1334         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1335         (LayoutTestController::setMockDeviceOrientation):
1336
1337 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1338
1339         [GTK] Bad text rendering since r101343
1340         https://bugs.webkit.org/show_bug.cgi?id=73744
1341
1342         Reviewed by Martin Robinson.
1343
1344         Turn cairo hint metrics off for better font metrics reporting in
1345         the tests. This is especially important for SVG.
1346
1347         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1348         (initializeGtkFontSettings):
1349         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1350         (WTR::initializeGtkSettings):
1351
1352 2011-12-13  Kentaro Hara  <haraken@chromium.org>
1353
1354         [Refactoring] Remove several global variables from prepare-ChangeLog
1355         https://bugs.webkit.org/show_bug.cgi?id=74389
1356
1357         Reviewed by David Kilzer.
1358
1359         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1360         manner. This bug is one of the incremental refactorings to remove all top-level
1361         code and global variables from prepare-ChangeLog. In this patch,
1362         we make the following global variables being used only through parameter passing.
1363             - %paths
1364             - $changedFiles
1365             - $conflictFiles
1366             - $functionLists
1367             - $bugURL
1368
1369         * Scripts/prepare-ChangeLog:
1370         (findChangeLogs):
1371         (generateNewChangeLogs):
1372         (processPaths):
1373         (generateFileList):
1374         (firstDirectoryOrCwd):
1375
1376 2011-12-13  Anders Carlsson  <andersca@apple.com>
1377
1378         Add a very bare-bones implementation of bind and Function to WTF
1379         https://bugs.webkit.org/show_bug.cgi?id=74462
1380
1381         Reviewed by Sam Weinig.
1382
1383         Add basic tests for WTF::Function and WTF::bind.
1384
1385         * TestWebKitAPI/TestWebKitAPI.gypi:
1386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1387         * TestWebKitAPI/Tests/Functional.cpp: Added.
1388         (TestWebKitAPI::returnFortyTwo):
1389         (TestWebKitAPI::TEST):
1390         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1391
1392 2011-12-13  Robin Dunn  <robin@alldunn.com>
1393
1394         [wx] Add a URL argument to wxWebView constructor.
1395         https://bugs.webkit.org/show_bug.cgi?id=74316
1396         
1397         Reviewed by Kevin Ollivier.
1398
1399         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1400         (MyApp::OnInit):
1401         * wx/browser/browser.cpp:
1402         (MyApp::OnInit):
1403
1404 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1405
1406         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
1407         https://bugs.webkit.org/show_bug.cgi?id=74430
1408
1409         Reviewed by David Levin.
1410
1411         * Scripts/webkitpy/common/config/watchlist:
1412
1413 2011-12-13  Peter Beverloo  <peter@chromium.org>
1414
1415         [Chromium] Pull in FreeType and decrease check-out complexity for Android
1416         https://bugs.webkit.org/show_bug.cgi?id=74401
1417
1418         Decrease the check-out complexity by removing the need to first run
1419         "update-webkit-chromium --chromium" prior to running it with
1420         "--chromium-android", which was caused by an unversioned third_party/
1421         directory being created. This moves the Android NDK to Source/WebKit/
1422         chromium/, coming from third_party/ in that directory.
1423
1424         Reviewed by Adam Barth.
1425
1426         * Scripts/update-webkit-chromium:
1427         * Scripts/webkitdirs.pm:
1428         (buildChromiumMakefile):
1429
1430 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
1431
1432         build-jsc passing incorrect args to buildGtkProject
1433         https://bugs.webkit.org/show_bug.cgi?id=74308
1434
1435         Reviewed by Gustavo Noronha Silva.
1436
1437         * Scripts/build-webkit: Instead of invoking buildGtkProject with
1438         another argument about webkit2, unshift a --disable-webkit2
1439         argument onto the buildArgs.
1440         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1441         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1442         and build-jsc are run one after the other.
1443
1444 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1445
1446         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1447         https://bugs.webkit.org/show_bug.cgi?id=74413
1448
1449         Unreviewed buildfix.
1450
1451         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1452
1453 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1454
1455         [Qt] Unreviewed speculativ debug buildfix after r102679.
1456
1457         * QtTestBrowser/QtTestBrowser.pro:
1458         * QtTestBrowser/main.cpp:
1459
1460 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1461
1462         [Qt] Get rid of layering violations in includes
1463
1464         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1465         in the webcore.prf, but rather in each target that specificly needs
1466         headers in these location. We used to include them directly in webcore
1467         since we had layering violations between WebCore and WebKit, but now
1468         that they are gone there's no reason to do that.
1469
1470         Reviewed by Simon Hausmann.
1471
1472         * DumpRenderTree/qt/DumpRenderTree.pro:
1473         * QtTestBrowser/launcherwindow.h:
1474         * WebKitTestRunner/InjectedBundle/Target.pri:
1475         * qmake/mkspecs/features/webcore.prf:
1476         * qmake/mkspecs/features/webkit2.prf:
1477
1478 2011-12-13  János Badics  <dicska@gmail.com>
1479
1480         [NRWT] It crashes intermittently when there are WebProcess crashes
1481         https://bugs.webkit.org/show_bug.cgi?id=73451
1482
1483         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1484
1485         Reviewed by Kenneth Rohde Christiansen.
1486
1487         * Scripts/webkitpy/layout_tests/port/server_process.py:
1488         (ServerProcess._check_for_crash):
1489
1490 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1491
1492         Unreviewed. Fix GTK+ API docs build.
1493
1494         * gtk/generate-gtkdoc:
1495         (get_webkit2_options): Ignore WebKitUIClient since it's private
1496         API.
1497
1498 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1499
1500         Reviewed, removed one of my email addresses to use the apprpriate one.
1501
1502         * Scripts/webkitpy/common/config/committers.py:
1503
1504 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1505
1506         [Qt] Fix skip list search path and expected file search path in ORWT
1507         https://bugs.webkit.org/show_bug.cgi?id=74281
1508
1509         Expected file search path fixed.
1510
1511         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1512
1513         Reviewed by Csaba Osztrogonác.
1514
1515         * Scripts/old-run-webkit-tests:
1516         (buildPlatformResultHierarchy):
1517         (buildPlatformTestHierarchy):
1518         (readSkippedFiles):
1519
1520 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1521
1522         [Qt] Missing layoutTestController.dumpWillCacheResponse
1523         https://bugs.webkit.org/show_bug.cgi?id=74287
1524
1525         Reviewed by Csaba Osztrogonác.
1526
1527         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1528         (LayoutTestController::reset):
1529         (LayoutTestController::dumpWillCacheResponse):
1530         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1531
1532 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1533
1534         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1535         https://bugs.webkit.org/show_bug.cgi?id=73771
1536
1537         Reviewed by Gustavo Noronha Silva.
1538
1539         When using a fallback font during testing, always use DejaVu Sans. This prevents
1540         falling back to DejaVu Serif on some systems.
1541
1542         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1543
1544 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1545
1546         Add myself as a committer
1547
1548         * Scripts/webkitpy/common/config/committers.py:
1549
1550 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1551
1552         [Qt] [WK2] Support customizing popup menus with QML
1553         https://bugs.webkit.org/show_bug.cgi?id=73560
1554
1555         Reviewed by Tor Arne Vestbø.
1556
1557         Add an Item Selector to our WebView using the experimental API.
1558
1559         * MiniBrowser/qt/MiniBrowser.pro:
1560         * MiniBrowser/qt/MiniBrowser.qrc:
1561         * MiniBrowser/qt/qml/BrowserWindow.qml:
1562         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1563
1564 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1565
1566         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1567         https://bugs.webkit.org/show_bug.cgi?id=74283
1568
1569         Reviewed by Simon Hausmann.
1570
1571         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1572         (MiniBrowserApplication::sendTouchEvent):
1573
1574 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1575
1576         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1577         to show ChangeLogs diff and open ChangeLogs in an editor
1578         https://bugs.webkit.org/show_bug.cgi?id=74266
1579
1580         Reviewed by Ryosuke Niwa.
1581
1582         We are planning to write unit-tests for prepare-ChangeLog
1583         in a run-leaks_unittest manner. This patch is one of the incremental
1584         refactorings to remove all top-level code and global variables from
1585         prepare-ChangeLog.
1586
1587         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1588         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1589         Renamed @changed_files to @changedFiles.
1590         Renamed %conflict_files to %conflictFiles.
1591         (generateFunctionLists):
1592         (printDiff):
1593         (openChangeLogs):
1594
1595 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1596
1597         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1598         https://bugs.webkit.org/show_bug.cgi?id=74257
1599
1600         Reviewed by Ryosuke Niwa.
1601
1602         We are planning to write unit-tests for prepare-ChangeLog
1603         in a run-leaks_unittest/ manner. This patch is one of the incremental
1604         refactorings to remove all top-level code and global variables from
1605         prepare-ChangeLog.
1606
1607         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1608         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1609         into resolveConflictedChangeLogs().
1610         (getLatestChangeLogs):
1611         (resolveConflictedChangeLogs):
1612
1613 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1614
1615         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1616         https://bugs.webkit.org/show_bug.cgi?id=74253
1617
1618         Reviewed by David Kilzer.
1619
1620         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1621         which requires to remove top-level code and global variables. This patch is one of
1622         the incremental refactorings for that.
1623
1624         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1625         (generateFunctionLists):
1626         (findChangeLogs):
1627         (generateNewChangeLogs):
1628         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1629
1630 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1631
1632         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1633         https://bugs.webkit.org/show_bug.cgi?id=74175
1634
1635         Reviewed by Ryosuke Niwa.
1636
1637         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1638         This requires to remove top-level code. This patch is one of the incremental refactorings
1639         for that.
1640
1641         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1642         (findChangeLogs):
1643
1644 2011-12-10  Andreas Kling  <kling@webkit.org>
1645
1646         Add my Apple e-mail to committers.py.
1647
1648         * Scripts/webkitpy/common/config/committers.py:
1649
1650 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1651
1652         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1653         https://bugs.webkit.org/show_bug.cgi?id=74225
1654
1655         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1656         the "All.gyp" solution doesn't work on windows.
1657
1658         * Scripts/webkitdirs.pm:
1659         (buildChromium):
1660
1661 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1662
1663         [Qt] Click's count is limited to three continuous clicks.
1664         https://bugs.webkit.org/show_bug.cgi?id=45666
1665
1666         Reviewed by Kenneth Rohde Christiansen.
1667
1668         Update m_time at every call to leapForward, so double clicks
1669         event are correctly sent by EventSender.
1670
1671         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1672         (WTR::EventSenderProxy::updateClickCountForButton):
1673         (WTR::EventSenderProxy::leapForward):
1674
1675 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1676
1677         [Refactoring] Reduce top-level code in prepare-ChangeLog
1678         https://bugs.webkit.org/show_bug.cgi?id=74172
1679
1680         Reviewed by Ryosuke Niwa.
1681
1682         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1683         This requires to remove top-level code. This patch is one of the incremental refactorings
1684         for that.
1685
1686         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1687         (generateFunctionLists):
1688
1689 2011-12-09  Sam Weinig  <sam@webkit.org>
1690
1691         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1692         https://bugs.webkit.org/show_bug.cgi?id=74218
1693
1694         Reviewed by Anders Carlsson.
1695
1696         Add a test of the WKConnectionRef API.
1697
1698         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1699         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1700         (TestWebKitAPI::didCreateConnection):
1701         (TestWebKitAPI::connectionDidReceiveMessage):
1702         (TestWebKitAPI::connectionDidClose):
1703         (TestWebKitAPI::TEST):
1704         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1705         (TestWebKitAPI::connectionDidReceiveMessage):
1706         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1707         (TestWebKitAPI::WKConnectionTest::initialize):
1708
1709 2011-12-09  David Levin  <levin@chromium.org>
1710
1711         Hash* iterators should allow comparison between const and const versions.
1712         https://bugs.webkit.org/show_bug.cgi?id=73370
1713
1714         Reviewed by Darin Adler.
1715
1716         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1718         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1719         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1720         (TestWebKitAPI::TEST): Add a test for the new functionality.
1721
1722 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1723
1724         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1725         https://bugs.webkit.org/show_bug.cgi?id=74212
1726
1727         Reviewed by Tony Chang.
1728
1729         The change introduced in r102201 to split the executables out of
1730         WebKit.gyp apparently doesn't work right on Windows, since
1731         WebKit.gyp and Tools.gyp refer to dependent projects by
1732         different relative paths (it appears gyp doesn't normalize the
1733         paths). This change moves Tools.gyp to be in the same directory
1734         as WebKit.gyp (and All.gyp), which should fix this and
1735         conveniently will also solve the problem of how to add Tools.gyp
1736         to the chromium DEPS file.
1737
1738         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1739
1740 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1741
1742         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1743         https://bugs.webkit.org/show_bug.cgi?id=74173
1744
1745         Reviewed by Ryosuke Niwa.
1746
1747         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1748         This requires to remove top-level code. This patch is one of the incremental refactorings
1749         for that.
1750
1751         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1752         (fetchBugDescriptionFromURL):
1753
1754 2011-12-09  Tony Chang  <tony@chromium.org>
1755
1756         Switch the chromium mac bots to using skia test results
1757         https://bugs.webkit.org/show_bug.cgi?id=74201
1758
1759         Reviewed by Ryosuke Niwa.
1760
1761         This is reverting http://trac.webkit.org/changeset/97781 and changing
1762         the name in master.cfg to no longer have cg in the name.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/config.json:
1765         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1766         (appendCustomBuildFlags):
1767         (RunWebKitTests.start):
1768
1769 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1770
1771         [Qt] Remove a wrongly placed ASSERT.
1772
1773         Reviewed by Tor Arne Vestbø.
1774
1775         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1776         (MiniBrowserApplication::notify):
1777
1778 2011-12-09  Cary Clark  <caryclark@google.com>
1779
1780         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1781         https://bugs.webkit.org/show_bug.cgi?id=74118
1782
1783         Reviewed by Adam Barth.
1784
1785         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1786         (get):
1787         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1788         (ChromiumMacPort.__init__):
1789         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1790         (ChromiumMacPortTest.test_versions):
1791         (ChromiumMacPortTest.test_graphics_type):
1792
1793 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1794
1795         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1796
1797         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
1798         this failed when moving files in the source tree, as the .d file would contain
1799         stale dependencies on the old source file location. By keeping the object files
1800         (and hence the depdendency files) in a proper tree structure inside the objects
1801         directory we can prevent this failure.
1802
1803         A side benefit is that we can also have objects with the same name inside the
1804         same project.
1805
1806         Reviewed by Simon Hausmann.
1807
1808         * qmake/mkspecs/features/unix/default_pre.prf:
1809
1810 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1811
1812         Unreviewed. Update unit test after r102412.
1813
1814         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1815         (IRCCommandTest.test_whois):
1816
1817 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1818
1819         REGRESSION(r102105): run-bindings-tests should output full diff results
1820         https://bugs.webkit.org/show_bug.cgi?id=74166
1821
1822         Reviewed by Adam Barth.
1823
1824         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
1825         run-bindings-tests should output full diff results.
1826
1827         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
1828         (BindingsTests.generate_from_idl):
1829         (BindingsTests.generate_supplemental_dependency):
1830         (BindingsTests.detect_changes):
1831
1832 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
1833
1834         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
1835         https://bugs.webkit.org/show_bug.cgi?id=73990
1836
1837         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
1838
1839         Fix QtQuick includes after move from QtDeclarative to QtQuick.
1840
1841         * MiniBrowser/qt/BrowserWindow.h:
1842         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1843
1844 2011-12-08  Adam Klein  <adamk@chromium.org>
1845
1846         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
1847         https://bugs.webkit.org/show_bug.cgi?id=73492
1848
1849         Reviewed by Adam Barth.
1850
1851         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
1852         keypress event without any script on the stack.
1853
1854         * DumpRenderTree/chromium/EventSender.cpp:
1855         (EventSender::EventSender):
1856         (EventSender::keyDown):
1857         (KeyDownTask::KeyDownTask):
1858         (KeyDownTask::runIfValid):
1859         (EventSender::scheduleAsynchronousKeyDown):
1860         * DumpRenderTree/chromium/EventSender.h:
1861
1862 2011-12-08  Hayato Ito  <hayato@chromium.org>
1863
1864         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
1865         https://bugs.webkit.org/show_bug.cgi?id=73980
1866
1867         Reviewed by Tony Chang.
1868
1869         * gdb/webkit.py:
1870         (guess_string_length):
1871         (ustring_to_string):
1872         (lstring_to_string):
1873         (LCharStringPrinter):
1874         (LCharStringPrinter.to_string):
1875         (WTFStringImplPrinter.get_length):
1876         (WTFStringImplPrinter.to_string):
1877         (WTFStringImplPrinter.is_8bit):
1878         (WTFStringPrinter.stringimpl_ptr):
1879         (WTFStringPrinter.get_length):
1880         (WTFStringPrinter.to_string):
1881         (add_pretty_printers.lookup_function):
1882
1883 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1884
1885         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
1886         https://bugs.webkit.org/show_bug.cgi?id=73916
1887
1888         Reviewed by Kent Tamura.
1889
1890         * qmake/mkspecs/features/features.prf:
1891
1892 2011-12-08  Adrienne Walker  <enne@google.com>
1893
1894         Unreviewed contributor additions to committers.py.
1895
1896         * Scripts/webkitpy/common/config/committers.py:
1897
1898 2011-12-08  David Reveman  <reveman@chromium.org>
1899
1900         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
1901         https://bugs.webkit.org/show_bug.cgi?id=74017
1902
1903         Reviewed by James Robinson.
1904         
1905         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
1906
1907         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1908         (main):
1909         * DumpRenderTree/chromium/TestShell.cpp:
1910         (TestShell::TestShell):
1911         (TestShell::resetWebSettings):
1912         * DumpRenderTree/chromium/TestShell.h:
1913         (TestShell::setAcceleratedPaintingEnabled):
1914         (TestShell::setPerTilePaintingEnabled):
1915         * DumpRenderTree/chromium/WebPreferences.cpp:
1916         (WebPreferences::reset):
1917         (WebPreferences::applyTo):
1918         * DumpRenderTree/chromium/WebPreferences.h:
1919         * Scripts/webkitpy/layout_tests/port/chromium.py:
1920         (ChromiumDriver._wrapper_options):
1921         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1922         (parse_args):
1923
1924 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1925
1926         create a "SystemHost" object for webkitpy to slim down the Host object
1927         https://bugs.webkit.org/show_bug.cgi?id=72680
1928
1929         Reviewed by Eric Siedel.
1930
1931         This creates a SystemHost object that other objects that should
1932         only have dependencies on functionality in webkitpy.common.system
1933         can use; this will allow them to not require a full Host.
1934
1935         * Scripts/webkitpy/common/host.py:
1936         * Scripts/webkitpy/common/host_mock.py:
1937         * Scripts/webkitpy/common/system/systemhost.py: Added.
1938         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
1939
1940 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
1941
1942         AX: platform/mac/accessibility/search-with-frames.html crashes
1943         https://bugs.webkit.org/show_bug.cgi?id=74093
1944
1945         Reviewed by Darin Adler.
1946
1947         Take care of the case when an incoming element is null.
1948
1949         * DumpRenderTree/AccessibilityUIElement.cpp:
1950         (uiElementForSearchPredicateCallback):
1951         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1952         (AccessibilityUIElement::uiElementForSearchPredicate):
1953         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1954         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1955
1956 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
1957
1958         [Qt] Visualize mock point ID's in the MiniBrowser
1959         https://bugs.webkit.org/show_bug.cgi?id=74098
1960
1961         Reviewed by Tor Arne Vestbø.
1962
1963         * MiniBrowser/qt/BrowserWindow.cpp:
1964         (BrowserWindow::updateVisualMockTouchPoints):
1965         * MiniBrowser/qt/qml/MockTouchPoint.qml:
1966
1967 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
1968
1969         Accessibility: AccessibilityController should support listening to notifications on all elements.
1970         https://bugs.webkit.org/show_bug.cgi?id=72866
1971
1972         Adds addNotificationListener and removeNotificationListener methods
1973         to AccessibilityController, to listen to notifications on any element
1974         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
1975         implementations are all contained in this change.
1976
1977         On Mac, refactors AccessibilityNotificationHandler into its own
1978         source file that can be used by both AccessibilityController and
1979         AccessibilityUIElement. (Both DRT and WKTR.)
1980
1981         Reviewed by Chris Fleizach.
1982
1983         * DumpRenderTree/AccessibilityController.cpp:
1984         (addNotificationListenerCallback):
1985         (removeNotificationListenerCallback):
1986         (AccessibilityController::getJSClass):
1987         * DumpRenderTree/AccessibilityController.h:
1988         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1989         * DumpRenderTree/chromium/AccessibilityController.cpp:
1990         (AccessibilityController::AccessibilityController):
1991         (AccessibilityController::notificationReceived):
1992         (AccessibilityController::addNotificationListenerCallback):
1993         (AccessibilityController::removeNotificationListenerCallback):
1994         * DumpRenderTree/chromium/AccessibilityController.h:
1995         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1996         (AccessibilityController::addNotificationListener):
1997         (AccessibilityController::removeNotificationListener):
1998         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1999         (AccessibilityController::~AccessibilityController):
2000         (AccessibilityController::addNotificationListener):
2001         (AccessibilityController::removeNotificationListener):
2002         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
2003         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
2004         (-[NSString createJSStringRef]):
2005         (-[AccessibilityNotificationHandler init]):
2006         (-[AccessibilityNotificationHandler setPlatformElement:]):
2007         (-[AccessibilityNotificationHandler dealloc]):
2008         (-[AccessibilityNotificationHandler setCallback:]):
2009         (-[AccessibilityNotificationHandler startObserving]):
2010         (-[AccessibilityNotificationHandler _notificationReceived:]):
2011         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2012         (AccessibilityUIElement::addNotificationListener):
2013         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2014         (notificationListenerProc):
2015         (AccessibilityController::addNotificationListener):
2016         (AccessibilityController::removeNotificationListener):
2017         (AccessibilityController::winNotificationReceived):
2018         (AccessibilityController::winAddNotificationListener):
2019         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2020         (AccessibilityUIElement::addNotificationListener):
2021         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2022         (WTR::AccessibilityController::addNotificationListener):
2023         (WTR::AccessibilityController::removeNotificationListener):
2024         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2025         (WTR::AccessibilityController::logAccessibilityEvents):
2026         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2027         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2028         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2029         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2030         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2031         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
2032         (WTR::AccessibilityController::addNotificationListener):
2033         (WTR::AccessibilityController::removeNotificationListener):
2034         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
2035         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
2036         (-[NSString createJSStringRef]):
2037         (-[AccessibilityNotificationHandler init]):
2038         (-[AccessibilityNotificationHandler setPlatformElement:]):
2039         (-[AccessibilityNotificationHandler dealloc]):
2040         (-[AccessibilityNotificationHandler setCallback:]):
2041         (-[AccessibilityNotificationHandler startObserving]):
2042         (-[AccessibilityNotificationHandler _notificationReceived:]):
2043         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2044         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2045         (WTR::AccessibilityUIElement::verticalScrollbar):
2046         (WTR::AccessibilityUIElement::addNotificationListener):
2047         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2048
2049 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
2050
2051         [Qt][WK2] Unreviewed buildfix after r102352.
2052
2053         * qmake/mkspecs/features/webkit2.prf:
2054
2055 2011-12-08  Adam Roben  <aroben@apple.com>
2056
2057         Make finding crash logs by PID work on Snow Leopard
2058
2059         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
2060         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
2061         read the first line of the crash log and pull the PID out of there.
2062
2063         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
2064         Snow Leopard
2065
2066         Reviewed by Darin Adler.
2067
2068         * Scripts/webkitpy/common/system/crashlogs.py:
2069         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
2070         name and PID for the log, rather than checking the Lion-only app_description extended
2071         attribute. We now also reject the log if the process name doesn't match what we expect.
2072
2073         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2074         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
2075         PID.
2076         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
2077         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
2078         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
2079         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
2080         read, files that actually contain a crash log for some other process, and files that are
2081         misformatted.
2082
2083         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
2084         unused.
2085
2086         * Scripts/webkitpy/common/system/filesystem_mock.py:
2087         (MockFileSystem.__init__): Removed xattr support, which is now unused.
2088         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
2089         ReadableTextFileObject. This function was completely broken before!
2090         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
2091         bugs like the above.
2092         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
2093         things like readline() and seek().
2094
2095         (ReadableTextFileObject.close):
2096         (ReadableTextFileObject.read):
2097         Added. We override the superclass implementation to account for using a StringIO object.
2098
2099         (ReadableTextFileObject.readline):
2100         (ReadableTextFileObject.seek):
2101         Added. These just call through to StringIO.
2102
2103         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2104         (MainTest.test_crash_log):
2105         (MainTest.test_web_process_crash_log):
2106         Changed to use make_mock_crash_report_darwin.
2107
2108 2011-12-06  Jon Lee  <jonlee@apple.com>
2109
2110         [WK2] Add permissions support (73960)
2111         https://bugs.webkit.org/show_bug.cgi?id=73960
2112         <rdar://problem/10357008>
2113
2114         Reviewed by Darin Adler.
2115
2116         Add null function item to comply with added callback to WKPageUIClient.
2117
2118         * MiniBrowser/mac/BrowserWindowController.m:
2119         (-[BrowserWindowController awakeFromNib]):
2120         * WebKitTestRunner/TestController.cpp:
2121         (WTR::TestController::createOtherPage):
2122         (WTR::TestController::initialize):
2123
2124 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
2125
2126         [Qt] Visualize mock points in the Qt MiniBrowser
2127         https://bugs.webkit.org/show_bug.cgi?id=74074
2128
2129         Reviewed by Tor Arne Vestbø.
2130
2131         * MiniBrowser/qt/BrowserWindow.cpp:
2132         (BrowserWindow::updateVisualMockTouchPoints):
2133         * MiniBrowser/qt/BrowserWindow.h:
2134         * MiniBrowser/qt/MiniBrowser.qrc:
2135         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2136         (MiniBrowserApplication::notify):
2137         (MiniBrowserApplication::sendTouchEvent):
2138         * MiniBrowser/qt/MiniBrowserApplication.h:
2139         * MiniBrowser/qt/icons/touchpoint.png: Added.
2140         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
2141
2142 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
2143
2144         [Qt] WebKitTestRunner crashes with debug builds
2145         https://bugs.webkit.org/show_bug.cgi?id=74090
2146
2147         Reviewed by Tor Arne Vestbø.
2148
2149         * WebKitTestRunner/qt/TestControllerQt.cpp:
2150         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
2151         to ensure WTF/JSC threading is initialized.
2152
2153 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2154
2155         fix build-webkit --chromium after breakage in r102201
2156         https://bugs.webkit.org/show_bug.cgi?id=74031
2157
2158         Reviewed by Tony Chang.
2159
2160         * Scripts/webkitdirs.pm:
2161         (buildChromium):
2162
2163 2011-12-08  Kentaro Hara  <haraken@chromium.org>
2164
2165         Unreviewed, rolling out r102280.
2166         http://trac.webkit.org/changeset/102280
2167         https://bugs.webkit.org/show_bug.cgi?id=74031
2168
2169         Chromium/Windows build is broken
2170
2171         * Scripts/webkitdirs.pm:
2172         (buildChromium):
2173
2174 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
2175
2176         Adding myself to committers list.
2177
2178         Unreviewed.
2179
2180         * Scripts/webkitpy/common/config/committers.py:
2181
2182 2011-12-07  Michael Saboff  <msaboff@apple.com>
2183
2184         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
2185         https://bugs.webkit.org/show_bug.cgi?id=73995
2186
2187         Reenabled failing tests that the code part of the patch fixes.
2188
2189         Reviewed by Geoffrey Garen.
2190
2191         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2192         (TestWebKitAPI::TEST):
2193
2194 2011-12-07  MORITA Hajime  <morrita@google.com>
2195
2196         [filter-build-webkit] should not emit reset color when --no-color is given
2197         https://bugs.webkit.org/show_bug.cgi?id=73992
2198
2199         Reviewed by Daniel Bates.
2200
2201         Stop printing control sequences when --no-color is given.
2202         After this change, the filter runs nicely even on environments
2203         like Emacs compilation-mode which cannot understand the control sequence.
2204
2205         * Scripts/filter-build-webkit:
2206         (printLine):
2207
2208 2011-12-07  Eric Seidel  <eric@webkit.org>
2209
2210         Use free memory to determine if we have space for DRT instances instead of total memory
2211         https://bugs.webkit.org/show_bug.cgi?id=74021
2212
2213         Reviewed by Adam Barth.
2214
2215         This will hopefully make the Mac buildbots behave better.
2216
2217         I also reduced the expected memory needed per DRT now that
2218         we're properly accounting for the system memory in our calculations.
2219
2220         * Scripts/webkitpy/common/system/platforminfo.py:
2221         (PlatformInfo.total_bytes_memory):
2222         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
2223         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2224         (MockPlatformInfo.total_bytes_memory):
2225         * Scripts/webkitpy/layout_tests/port/base.py:
2226         (Port.default_child_processes):
2227         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2228         (PortTest.test_default_child_processes):
2229
2230 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
2231
2232         fix build-webkit --chromium after breakage in r102201
2233         https://bugs.webkit.org/show_bug.cgi?id=74031
2234
2235         Reviewed by Tony Chang.
2236
2237         r102201 introduced a change to the chromium build that splits
2238         the executables out of WebKit.gyp into other gyp files, and adds
2239         a new "All.gyp" that builds everything. However, I forgot to
2240         update the build script to use All.gyp.
2241
2242         * Scripts/webkitdirs.pm:
2243         (buildChromium):
2244
2245 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
2246
2247         Moved myself to the committers list.
2248
2249         * Scripts/webkitpy/common/config/committers.py:
2250
2251 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2252
2253         [Qt] Fix debug shlib build with V8.
2254
2255         Reviewed by Tor Arne Vestbø.
2256
2257         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
2258         v8 builds.
2259
2260 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2261
2262         [Qt] V8 build fixes.
2263
2264         Reviewed by Tor Arne Vestbø.
2265
2266         * qmake/mkspecs/features/javascriptcore.prf: Don't add
2267         Source/Thirdparty to the include search path here.
2268         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
2269         used when building WebCore as well as using it, because header files like
2270         GraphicsContext3D.h include stuff from ThirdParty.
2271
2272 2011-12-07  Peter Beverloo  <peter@chromium.org>
2273
2274         [Chromium] Fix project file generation for the Android bot after r102201
2275         https://bugs.webkit.org/show_bug.cgi?id=73996
2276
2277         The gyp refactoring in r102201 was didn't explicitly exclude
2278         the Android operating system in Tools/Tools.gyp, which broke
2279         as gcc_version is not defined for that configuration.
2280
2281         Reviewed by Andreas Kling.
2282
2283         * Tools.gyp:
2284
2285 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
2286
2287         Unreviewed. Disabled failing tests on chromium.
2288
2289         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2290         (TestWebKitAPI::TEST):
2291
2292 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
2293
2294         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
2295         https://bugs.webkit.org/show_bug.cgi?id=73382
2296
2297         Reviewed by Tony Chang.
2298
2299         XCode (and hence GYP) can't handle circular dependencies between
2300         files (and projects). Accordingly, although the binaries in
2301         WebKit.gyp depend on webkit_support and webkit_support depends
2302         on webkit, we don't mention the latter dependency in the file.
2303         To fix this, this change moves the binaries like DRT into a new
2304         GYP file, and modifies gyp_webkit to build from that file
2305         instead of WebKit.gyp.
2306
2307         * Tools.gyp: Added.
2308
2309 2011-12-06  Adam Roben  <aroben@apple.com>
2310
2311         Add a pid parameter to CrashLogs.find_newest_log
2312
2313         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
2314         considered.
2315
2316         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
2317         process whose crash log you want to find
2318
2319         Reviewed by Dirk Pranke.
2320
2321         * Scripts/webkitpy/common/system/crashlogs.py:
2322         (CrashLogs.find_newest_log): Added an optional pid parameter.
2323         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
2324         candidate log's app_description extended attribute to see if that log corresponds to a
2325         crashed process with the specified PID.
2326
2327         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2328         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
2329         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
2330         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
2331
2332         * Scripts/webkitpy/common/system/filesystem.py:
2333         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
2334         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
2335         present.
2336
2337         * Scripts/webkitpy/common/system/filesystem_mock.py:
2338         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
2339         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
2340         dictionary.
2341
2342         * Scripts/webkitpy/tool/commands/queries.py:
2343         (CrashLog): Added help text. Added an optional PID parameter.
2344         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
2345
2346 2011-12-06  Adam Roben  <aroben@apple.com>
2347
2348         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
2349
2350         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
2351         alive beyond the normal timeout limit. In cases where the crashed process was able to die
2352         faster, NRWT would assume that Crash Reporter had finished even though it often was still
2353         running, which would lead to an incorrect crash log being picked up.
2354
2355         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
2356
2357         Reviewed by Dirk Pranke.
2358
2359         * Scripts/webkitpy/layout_tests/port/server_process.py:
2360         (ServerProcess._reset):
2361         (ServerProcess.write):
2362         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
2363         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
2364         set_crashed.
2365
2366         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
2367         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
2368         we bail out of handling the failure as a timeout if we find out that the process in fact
2369         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
2370         so.
2371         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
2372         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
2373         disk.
2374
2375         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2376         (TrivialMockPort.is_crash_reporter): Added.
2377
2378         * Scripts/webkitpy/layout_tests/port/webkit.py:
2379         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
2380         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
2381
2382 2011-12-06  Adam Barth  <abarth@webkit.org>
2383
2384         NRWT fails on unreleased versions of Mac OS X
2385         https://bugs.webkit.org/show_bug.cgi?id=72748
2386
2387         Reviewed by Dirk Pranke.
2388
2389         Hopefully this patch will make NRWT work on future versions on Mac OS X.
2390         Most of the infrastructure was already in place, but there were some
2391         asserts that failed.  I've tested this patch by haxoring the version
2392         detection logic to simulate an unknown version.  We might need to
2393         iterate based on feedback from folks with a real future version.
2394
2395         * Scripts/webkitpy/layout_tests/port/apple.py:
2396         (ApplePort.__init__):
2397             - mac-future is an allowed port_name that's used internally by
2398               webkitpy to represent future versions of Mac OS X.
2399         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2400         (test_versions):
2401             - Test that we don't throw exceptions when dealing with future
2402               versions of Mac OS X.
2403         * Scripts/webkitpy/layout_tests/port/webkit.py:
2404         (WebKitPort._expectations_from_skipped_files):
2405             - Demote this logging message to "debug".  It's expected that
2406               mac-future doesn't have a Skipped file.
2407         * Scripts/webkitpy/layout_tests/port/mac.py:
2408         (MacPort.__init__):
2409         * Scripts/webkitpy/layout_tests/port/win.py:
2410         (WinPort.__init__):
2411             - Re-order some code in these constructors so that
2412               self._operating_system is available to the ApplePort constructor.
2413
2414 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
2415
2416         Added myself as a committer.
2417
2418         * Scripts/webkitpy/common/config/committers.py:
2419
2420 2011-12-06  Peter Beverloo  <peter@chromium.org>
2421
2422         Added myself as a committer.
2423
2424         * Scripts/webkitpy/common/config/committers.py:
2425
2426 2011-12-06  Kentaro Hara  <haraken@chromium.org>
2427
2428         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
2429         https://bugs.webkit.org/show_bug.cgi?id=73637
2430
2431         Reviewed by Adam Barth.
2432
2433         This patch replaces subprocess.Popen() with Executive, similar to other
2434         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2435         works well for cases where no exception is raised, no exception is raised
2436         but diff is found, and ScriptError is raised.
2437
2438         * Scripts/run-bindings-tests:
2439         (main):
2440         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2441         (BindingsTests.__init__):
2442         (BindingsTests.generate_from_idl):
2443         (BindingsTests.generate_supplemental_dependency):
2444         (BindingsTests.detect_changes):
2445
2446 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2447
2448         [Qt] MiniBrowser should default to touch behavior
2449         https://bugs.webkit.org/show_bug.cgi?id=73863
2450
2451         Reviewed by Chang Shu.
2452
2453         MiniBrowser currently defaults to the traditional desktop behaviour
2454         instead of touch behaviour which is prefered.
2455
2456         * MiniBrowser/qt/BrowserWindow.cpp:
2457         (BrowserWindow::BrowserWindow):
2458         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2459         (printHelp):
2460         (MiniBrowserApplication::handleUserOptions):
2461         * MiniBrowser/qt/MiniBrowserApplication.h:
2462         (WindowOptions::WindowOptions):
2463         (WindowOptions::setUseTraditionalDesktopBehavior):
2464         (WindowOptions::useTraditionalDesktopBehavior):
2465
2466 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2467
2468         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2469         https://bugs.webkit.org/show_bug.cgi?id=73878
2470
2471         Reviewed by Tony Chang.
2472
2473         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2474         r98785 made webkit.py always use m_data16, which does not work when
2475         the string is an 8-bit string (such as KURL::string()).
2476
2477         I was not able to directly call StringImpl::is8Bit() in the Python
2478         code, so I just reproduced the implementation there.
2479
2480         * gdb/webkit.py:
2481         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2482         (WTFStringPrinter.to_string):
2483         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2484         (JSCUStringPrinter.to_string):
2485
2486 2011-12-05  Eric Seidel  <eric@webkit.org>
2487
2488         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2489         in hopes of making the Snow Leopard bot stop timing out.
2490
2491         Unreviewed.
2492
2493         * Scripts/webkitpy/layout_tests/port/base.py:
2494         (Port.default_child_processes):
2495         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2496         (PortTest.test_default_child_processes):
2497
2498 2011-12-05  Eric Seidel  <eric@webkit.org>
2499
2500         NRWT creates too many workers on RAM-limited machines
2501         https://bugs.webkit.org/show_bug.cgi?id=73847
2502
2503         Reviewed by Dirk Pranke.
2504
2505         Make NRWT restrict its number of workers when there isn't enough
2506         RAM to support them.
2507         Also re-enable parallel testing on the Mac bots which were
2508         failing due to not enough ram.
2509
2510         * Scripts/run-webkit-tests:
2511         (platformIsReadyForParallelTesting):
2512         * Scripts/webkitpy/common/host.py:
2513         (Host.__init__):
2514         * Scripts/webkitpy/common/system/executive_mock.py:
2515         (MockExecutive.cpu_count):
2516         * Scripts/webkitpy/common/system/platforminfo.py:
2517         (PlatformInfo.__init__):
2518         (PlatformInfo.display_name):
2519         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2520         (MockPlatformInfo.display_name):
2521         * Scripts/webkitpy/layout_tests/port/base.py:
2522         (Port.default_child_processes):
2523         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2524         (PortTest.test_default_child_processes):
2525         (PortTest.test_pretty_patch_os_error):
2526
2527 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2528
2529         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2530         https://bugs.webkit.org/show_bug.cgi?id=73366
2531
2532         Reviewed by Kenneth Rohde Christiansen.
2533
2534         Empty the entire event queue when requested besides using
2535         sendEvent instead of postEvent to make sure all events were
2536         delivered.
2537
2538         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2539         (WTR::EventSenderProxy::EventSenderProxy):
2540         (WTR::EventSenderProxy::sendOrQueueEvent):
2541         (WTR::EventSenderProxy::replaySavedEvents):
2542
2543 2011-12-05  Adam Barth  <abarth@webkit.org>
2544
2545         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2546         https://bugs.webkit.org/show_bug.cgi?id=73845
2547
2548         Reviewed by Darin Fisher.
2549
2550         Update includes to point to the new header locations.
2551
2552         * DumpRenderTree/chromium/AccessibilityController.cpp:
2553         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2554         * DumpRenderTree/chromium/CppBoundClass.cpp:
2555         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2556         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2557         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2558         * DumpRenderTree/chromium/EventSender.cpp:
2559         * DumpRenderTree/chromium/EventSender.h:
2560         * DumpRenderTree/chromium/GamepadController.h:
2561         * DumpRenderTree/chromium/LayoutTestController.cpp:
2562         * DumpRenderTree/chromium/LayoutTestController.h:
2563         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2564         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2565         * DumpRenderTree/chromium/PlainTextController.cpp:
2566         * DumpRenderTree/chromium/Task.cpp:
2567         * DumpRenderTree/chromium/TestNavigationController.h:
2568         * DumpRenderTree/chromium/TestShell.cpp:
2569         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2570         * DumpRenderTree/chromium/TestWebPlugin.h:
2571         * DumpRenderTree/chromium/TextInputController.cpp:
2572         * DumpRenderTree/chromium/WebPermissions.cpp:
2573         * DumpRenderTree/chromium/WebPreferences.h:
2574         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2575         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2576         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2577         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2578         * DumpRenderTree/chromium/WebViewHost.cpp:
2579
2580 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         Add Aharon Lanin to the contributors list.
2583
2584         * Scripts/webkitpy/common/config/committers.py:
2585
2586 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2587
2588         Moving myself from contributors to committers.
2589
2590         * Scripts/webkitpy/common/config/committers.py:
2591
2592 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2593
2594         Add myself as a committer.
2595
2596         * Scripts/webkitpy/common/config/committers.py:
2597
2598 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2599
2600         [Qt] Rename QQuickWebView::canStop property to just loading 
2601         https://bugs.webkit.org/show_bug.cgi?id=73813
2602
2603         Reviewed by Kenneth Rohde Christiansen.
2604
2605         Replaced references to WebView.canStop with WebView.loading.
2606
2607         * MiniBrowser/qt/qml/BrowserWindow.qml:
2608
2609 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2610
2611         run-webkit-tests: limit --child-processes properly on apple mac
2612         https://bugs.webkit.org/show_bug.cgi?id=73856
2613
2614         Reviewed by Adam Roben.
2615
2616         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2617         the apple mac bots temporarily.
2618
2619         * Scripts/run-webkit-tests:
2620         (platformIsReadyForParallelTesting):
2621
2622 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2623
2624         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2625         https://bugs.webkit.org/show_bug.cgi?id=73840
2626
2627         Reviewed by Simon Fraser.
2628
2629         Temporarily go back to single process mode on Mac.
2630
2631         * Scripts/run-webkit-tests:
2632         (platformIsReadyForParallelTesting):
2633
2634 2011-12-05  Adam Roben  <aroben@apple.com>
2635
2636         Redeploy apple-macpro-7 and apple-xserve-1
2637
2638         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2639
2640         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2641         sitting idle
2642
2643         Reviewed by Sam Weinig.
2644
2645         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2646         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2647         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2648         (WebKit2 Tests)".
2649
2650 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2651
2652         [Qt] Make the UI of the MiniBrowser slightly nicer
2653
2654         Rubberstamped by Simon Hausmann.
2655
2656         - Add proper padding
2657         - Show feedback when pressing on the toolbar icons
2658         - Make the text entry better looking
2659
2660         * MiniBrowser/qt/qml/BrowserWindow.qml:
2661
2662 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2663
2664         NRWT should handle duplicated expectations
2665         https://bugs.webkit.org/show_bug.cgi?id=69750
2666
2667         Reviewed by Dirk Pranke.
2668
2669         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2670         (TestExpectations.__init__):
2671         (TestExpectations._report_errors):
2672         (TestExpectations._add_expectations):
2673         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2674         (test_add_skipped_tests):
2675         * Scripts/webkitpy/layout_tests/port/base.py:
2676         (Port.skipped_tests):
2677         * Scripts/webkitpy/layout_tests/port/webkit.py:
2678         (WebKitPort.test_expectations):
2679         (WebKitPort.skipped_tests):
2680         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2681         (test_test_expectations):
2682
2683 2011-12-04  Eric Seidel  <eric@webkit.org>
2684
2685         After success with Mac, Win and Gtk, turning on parallel testing
2686         by default for all platforms (except Qt).
2687
2688         We'll add more platforms to the blacklist if we see problems.
2689
2690         Unreviewed.
2691
2692         * Scripts/run-webkit-tests:
2693         (platformIsReadyForParallelTesting):
2694
2695 2011-12-04  Sam Weinig  <sam@webkit.org>
2696
2697         Add tests for RetainPtr::adoptNS/adoptCF
2698         https://bugs.webkit.org/show_bug.cgi?id=73470
2699
2700         Reviewed by Adam Roben and Darin Adler.
2701
2702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2703         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2704         (TestWebKitAPI::TEST):
2705         Test that adopting using adoptCF creates a RetainPtr with a
2706         value whose retain count is 1.
2707
2708         * TestWebKitAPI/Tests/WTF/ns: Added.
2709         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2710         (TestWebKitAPI::TEST):
2711         Test that adopting using adoptNS creates a RetainPtr with a
2712         value whose retain count is 1.
2713
2714 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2715
2716         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2717         https://bugs.webkit.org/show_bug.cgi?id=73748
2718
2719         Reviewed by Gustavo Noronha Silva.
2720
2721         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2722
2723 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2724
2725         Another GTK build fix after r101922.
2726
2727         Rubber-stamped by Martin Robinson.
2728
2729         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2730         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2731
2732 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2733
2734         Fix compiler warning in LayoutTestController
2735
2736         Reviewed by Philippe Normand.
2737
2738         * DumpRenderTree/LayoutTestController.cpp:
2739         (LayoutTestController::LayoutTestController): fix warning.
2740
2741 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2742
2743         Add missing methods used by fast/notifications tests to LayoutTestController
2744         https://bugs.webkit.org/show_bug.cgi?id=63616
2745
2746         Reviewed by Martin Robinson.
2747
2748         Add missing simulateDesktopNotificationClick method used by
2749         fast/notifications. Provide a default implementation for
2750         areDesktopNotificationPermissionRequestsIgnored and
2751         ignoreDesktopNotificationPermissionRequests.
2752
2753         * DumpRenderTree/LayoutTestController.cpp:
2754         (LayoutTestController::LayoutTestController): call into the port implementation.
2755         (simulateDesktopNotificationClickCallback): ditto.
2756         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2757         (LayoutTestController::staticFunctions): declare new methods.
2758         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2759         * DumpRenderTree/LayoutTestController.h:
2760         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2761         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2762         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2763         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2764         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2765         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2766         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2767         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2768         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2769         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2770         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2771
2772 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2773
2774         [GTK] Don't log document events in DRT
2775         https://bugs.webkit.org/show_bug.cgi?id=73746
2776
2777         Reviewed by Martin Robinson.
2778
2779         Stop connecting globally to document-related events.
2780
2781         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2782         (connectAccessibilityCallbacks): Removed connections.
2783         (disconnectAccessibilityCallbacks): Removed disconnections.
2784
2785 2011-12-03  Dan Bernstein  <mitz@apple.com>
2786
2787         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2788
2789         Reviewed by Darin Adler.
2790
2791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2792         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2793         (TestWebKitAPI::TEST):
2794
2795 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2796
2797         Another GTK build fix after r101922.
2798
2799         Rubber-stamped by Martin James Robinson.
2800
2801         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2802         (LayoutTestController::pathToLocalResource): return value needs to
2803         be a URI.
2804
2805 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2806
2807         Small fix for my previous patch. Do not try to delete a member
2808         of a dictionary that does not exist.
2809
2810         Reviewed by Gustavo Noronha Silva.
2811
2812         * gtk/run-with-jhbuild:
2813         (install_and_run_jhbuild):
2814
2815 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2816
2817         Fix jhbuild installation for people who have unusual MAKE environment
2818         variables such as 'make -j4' as the jhbuild build does not handle it.
2819
2820         Reviewed by Gustavo Noronha Silva.
2821
2822         * gtk/run-with-jhbuild:
2823         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
2824
2825 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2826
2827         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
2828         when run for the first time.
2829
2830         Reviewed by Gustavo Noronha Silva.
2831
2832         * Scripts/update-webkitgtk-libs: Fix first run.
2833
2834 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2835
2836         Unreviewed, GTK build fix after r101922.
2837
2838         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2839         (LayoutTestController::pathToLocalResource): Added sentinel in
2840         g_build_filename call.
2841
2842 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2843
2844         GTK API tests build fix. Run the tests inside jhbuild.
2845
2846         Rubber-stamped by Gustavo Noronha Silva.
2847
2848         * Scripts/run-gtk-tests:
2849         (TestRunner.__init__):
2850         (TestRunner.run._error_handler):
2851         (TestRunner):
2852         (TestRunner.run):
2853
2854 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2855
2856         Small build fix. Properly specify the path to the locally installed jhbuild.
2857
2858         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
2859
2860 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2861
2862         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2863         https://bugs.webkit.org/show_bug.cgi?id=67256
2864
2865         Reviewed by Philippe Normand.
2866
2867         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
2868         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
2869         which points to the more generic top-level path of the WebKit checkout. This code is
2870         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
2871         share code here.
2872
2873         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
2874         location. This will cause the fallback to fail if you build into a non-typical location
2875         or even fake it with a symlink. In this case it's important to use the environment variable.
2876
2877         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2878         (getTopLevelPath): Added.
2879         (initializeFonts): Use the new helper to get the font path.
2880         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
2881         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2882         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
2883         test paths.
2884         * Scripts/webkitpy/layout_tests/port/gtk.py:
2885         (GtkPort.setup_environ_for_server):Pass the top-level path of the
2886         checkout instead of passing the font path.
2887         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2888         (WTR::getTopLevelPath): Added this helper.
2889         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
2890
2891 2011-12-02  David Levin  <levin@chromium.org>
2892
2893         Rename WTF class from TemporarilyChange to TemporaryChange.
2894         https://bugs.webkit.org/show_bug.cgi?id=73479
2895
2896         Reviewed by Eric Seidel.
2897
2898         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
2899         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
2900         * TestWebKitAPI/TestWebKitAPI.gypi:
2901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2902         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
2903         (TestWebKitAPI::TEST):
2904         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2905
2906 2011-12-02  Tony Chang  <tony@chromium.org>
2907
2908         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
2909         https://bugs.webkit.org/show_bug.cgi?id=73453
2910
2911         Reviewed by Ryosuke Niwa.
2912
2913         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
2914         The verbose output will include the failure reason.
2915
2916         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
2917         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2918         (write_test_result):
2919         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
2920         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
2921         (determine_result_type):
2922         (FailureReftestNoImagesGenerated.__init__):
2923         (FailureReftestNoImagesGenerated):
2924         (FailureReftestNoImagesGenerated.message):
2925         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
2926         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
2927         (MainTest.test_run_singly_actually_runs_tests):
2928         (MainTest.test_unexpected_failures):
2929         (EndToEndTest.test_end_to_end):
2930
2931 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2932
2933         ChangeLog should be able to parse annotated changelogs
2934         https://bugs.webkit.org/show_bug.cgi?id=72703
2935
2936         Reviewed by Eric Seidel.
2937
2938         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
2939         and extract the revision number for each entry.
2940
2941         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
2942
2943         * Scripts/webkitpy/common/checkout/changelog.py:
2944         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2945         * Scripts/webkitpy/common/checkout/scm/git.py:
2946         * Scripts/webkitpy/common/checkout/scm/scm.py:
2947         * Scripts/webkitpy/common/checkout/scm/svn.py:
2948
2949 2011-12-02  Eric Seidel  <eric@webkit.org>
2950
2951         Enable parallel testing for Win and Gtk bots
2952         after confirming with Lucas and Martin the bots should be OK.
2953
2954         Unreviewed. (I ran the idea by Lucas and Martin.)
2955
2956         * Scripts/run-webkit-tests:
2957         (platformIsReadyForParallelTesting):
2958
2959 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2960
2961         Try to fix the GTK+ build.
2962
2963         * gtk/jhbuild.modules: Properly specify the glib-networking
2964         dependency for soup.
2965
2966 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2967
2968         Fix a syntax error in the committers.py file.
2969
2970         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
2971
2972 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2973
2974         Add Alan Stearns and Peter Linss to the contributors list.
2975
2976         * Scripts/webkitpy/common/config/committers.py:
2977
2978 2011-12-02  Kent Tamura  <tkent@chromium.org>
2979
2980         [Chromium] Fix compilation warnings for ASSERT()
2981         https://bugs.webkit.org/show_bug.cgi?id=73623
2982
2983         Reviewed by Tony Chang.
2984
2985         * DumpRenderTree/chromium/ImageDiff.cpp:
2986          - Fix fprintf format: %s -> %d for __LINE__
2987          - Do nothing for ASSERT() if NDEBUG.
2988
2989 2011-12-02  Eric Seidel  <eric@webkit.org>
2990
2991         Enable parallel testing for all Mac bots.
2992
2993         Unreviewed.
2994
2995         * Scripts/run-webkit-tests:
2996         (platformIsReadyForParallelTesting):
2997
2998 2011-12-02  Eric Seidel  <eric@webkit.org>
2999
3000         Enable parallel testing for run-webkit-tests on Mac Lion.
3001         I plan to move all the machines to parallel testing shortly
3002         but we're starting with Lion.
3003
3004         Unreviewed.
3005
3006         * Scripts/run-webkit-tests:
3007         (platformIsReadyForParallelTesting):
3008
3009 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3010
3011         Added helper method to identify whether the page has custom page size style.
3012         https://bugs.webkit.org/show_bug.cgi?id=73585
3013
3014         Reviewed by Darin Fisher.
3015
3016         * DumpRenderTree/chromium/LayoutTestController.cpp:
3017         (LayoutTestController::LayoutTestController):
3018         (LayoutTestController::hasCustomPageSizeStyle):
3019         * DumpRenderTree/chromium/LayoutTestController.h:
3020
3021 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3022
3023         [NRWT] reftest should support having multiple references per test
3024         https://bugs.webkit.org/show_bug.cgi?id=73613
3025
3026         Reviewed by Dirk Pranke.
3027
3028         Add a support for having multiple reference files for a single test.
3029
3030         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
3031         at least one of expected mismatches, we compare expected mismatches first in order to minimize
3032         the number of reference files to open on DRT.
3033
3034         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3035         (interpret_test_failures): Remove checks no longer applicable.
3036         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3037         (ResultSummaryTest.test_interpret_test_failures): Ditto.
3038         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3039         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
3040         (SingleTestRunner._driver_input):
3041         (SingleTestRunner.run):
3042         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
3043         * Scripts/webkitpy/layout_tests/models/test_input.py:
3044         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
3045         * Scripts/webkitpy/layout_tests/port/base.py:
3046         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
3047         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
3048         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3049         (PortTest.test_parse_reftest_list):
3050         * Scripts/webkitpy/layout_tests/port/test.py:
3051         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3052         (MainTest.test_unexpected_failures):
3053         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
3054         (EndToEndTest.test_end_to_end):
3055         (EndToEndTest.test_reftest_with_two_notrefs): Added.
3056
3057 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3058
3059         Build libsoup without gnome dependencies (like keyring).
3060
3061         * gtk/jhbuild.modules:
3062
3063 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3064
3065         Also build gcrypt and p11-kit, and make them dependencies of
3066         gnutls.
3067
3068         * gtk/jhbuild.modules:
3069
3070 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
3071
3072         [wx] Unreviewed build fixes for Windows build.
3073
3074         * waf/build/wxpresets.py:
3075
3076 2011-12-01  Eric Seidel  <eric@webkit.org>
3077
3078         Reviewed by Adam Barth.
3079
3080         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
3081         https://bugs.webkit.org/show_bug.cgi?id=32006
3082
3083         I decided not to make it warn, and just have it re-open the bug.
3084         That's not that different from today's behavior which will
3085         just silently attach the patch.
3086
3087         This patch makes behavior between upload and land-safely consistent
3088         (previously one would assign patches and the other would not)
3089         as well as adds the ability for both to ensure that the bug is open.
3090
3091         To test this I had to add a few more methods to MockBugzilla which
3092         (positively) affected a few other test results.
3093
3094         I also made AbstractStep keep a cached copy of the Bug object
3095         and used the cached copy where appropriate (including for 'bug_title').
3096         This should reduce the number of bug fetches we perform.
3097
3098         * Scripts/webkitpy/tool/commands/download_unittest.py:
3099         * Scripts/webkitpy/tool/commands/upload.py:
3100         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3101         * Scripts/webkitpy/tool/mocktool.py:
3102         * Scripts/webkitpy/tool/steps/__init__.py:
3103         * Scripts/webkitpy/tool/steps/abstractstep.py:
3104         * Scripts/webkitpy/tool/steps/closebug.py:
3105         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
3106         * Scripts/webkitpy/tool/steps/postdiff.py:
3107         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3108         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3109         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3110         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3111
3112 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3113
3114         Also pass --no-interact to jhbuild when updating dependencies.
3115
3116         * Scripts/update-webkitgtk-libs:
3117
3118 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
3119
3120         Make _build_path check more thoroughly that build paths exist.
3121         https://bugs.webkit.org/show_bug.cgi?id=73601
3122
3123         Reviewed by Ojan Vafai.
3124
3125         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3126         (ChromiumMacPort._build_path):
3127
3128 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3129
3130         Add libffi to the jhbuild modules list as a glib dependency.
3131
3132         Rubber-stamped by Martin Robinson.
3133
3134         * gtk/jhbuild.modules:
3135
3136 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3137
3138         Build fix. Use internal pcre on glib, make gnutls a dependency of
3139         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
3140         in non-interactive mode.
3141
3142         * Scripts/update-webkitgtk-libs:
3143         * gtk/jhbuild.modules:
3144         * gtk/run-with-jhbuild:
3145
3146 2011-12-02  Adam Roben  <aroben@apple.com>
3147
3148         Fix for Python 2.6
3149
3150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3151         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
3152         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
3153         searching for "Tests that timed out:" etc. This makes our check less strict, but it
3154         shouldn't matter given the kinds of content we parse.
3155
3156 2011-12-02  Adam Roben  <aroben@apple.com>
3157
3158         Fix names of failed/timed out tests in run-api-tests output
3159
3160         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
3161         out tests
3162
3163         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
3164
3165         Reviewed by Simon Fraser.
3166
3167         * Scripts/run-api-tests:
3168         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
3169         of this function.
3170
3171 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
3172
3173         [GTK] generate-gtkdoc should respect build type
3174         https://bugs.webkit.org/show_bug.cgi?id=73296
3175
3176         Reviewed by Philippe Normand.
3177
3178         * Scripts/webkitdirs.pm:
3179         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
3180         * gtk/common.py: If --build is passed give preference to the Debug build directory.
3181
3182 2011-12-02  Tony Chang  <tony@chromium.org>
3183
3184         [nrwt] fix wdiff output
3185         https://bugs.webkit.org/show_bug.cgi?id=73604
3186
3187         Reviewed by Adam Barth.
3188
3189         * Scripts/webkitpy/layout_tests/port/base.py:
3190         (Port.wdiff_text):
3191         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3192         (PortTest.test_wdiff_text):
3193
3194 2011-12-02  Adam Roben  <aroben@apple.com>
3195
3196         Teach build.webkit.org to display how many unit tests failed or timed out
3197
3198         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
3199         build.webkit.org
3200
3201         We now display something like "5 unit tests failed or timed out". Eventually we might want
3202         to split out how many failure vs. timeouts there were.
3203
3204         Reviewed by Darin Adler.
3205
3206         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3207         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
3208         classes that may want to subclass it.
3209         (RunUnitTests): Changed to inherit from TestWithFailureCount.
3210         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
3211         timed out:" and "Tests that failed:" lines, if present.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3214         (StubStdio):
3215         (StubRemoteCommand):
3216         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
3217
3218         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
3219         the test run correctly.
3220
3221         (RunUnitTestsTest.test_no_failures_or_timeouts):
3222         (RunUnitTestsTest.test_one_failure):
3223         (RunUnitTestsTest.test_multiple_failures):
3224         (RunUnitTestsTest.test_one_timeout):
3225         (RunUnitTestsTest.test_multiple_timeouts):
3226         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
3227         Test various cases.
3228
3229 2011-12-02  Adam Roben  <aroben@apple.com>
3230
3231         Teach prepare-ChangeLog to treat master.cfg as a Python file
3232
3233         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
3234         in buildbot's master.cfg
3235
3236         Reviewed by Darin Adler.
3237
3238         * Scripts/prepare-ChangeLog:
3239         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
3240         master.cfg.
3241
3242 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3243
3244         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
3245         https://bugs.webkit.org/show_bug.cgi?id=73669
3246
3247         Reviewed by Gustavo Noronha Silva.
3248
3249         Add a wrapper script that knows how to install jhbuild and also to wrap commands
3250         in the jhbuild shell.
3251
3252         * Scripts/webkitdirs.pm:
3253         (runAutogenForAutotoolsProject): Use the new wrapper script.
3254         (mustReRunAutogen): Ditto.
3255         (buildAutotoolsProject): Ditto.
3256         * Scripts/webkitpy/layout_tests/port/gtk.py:
3257         (GtkDriver.cmd_line): Ditto.
3258         * gtk/run-with-jhbuild: Added.
3259
3260 2011-12-01  Adam Roben  <aroben@apple.com>
3261
3262         Teach check-webkit-style how to check the syntax of JSON files
3263
3264         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3265
3266         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
3267         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
3268         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
3269         been removed, since its output differs by platform.
3270
3271         Reviewed by Darin Adler.
3272
3273         * Scripts/webkitpy/style/checker.py:
3274         (_all_categories): Added JSONChecker's categories to the set of all categories.
3275         (FileType): Added a JSON type. Incremented other types.
3276         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3277         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3278
3279         * Scripts/webkitpy/style/checker_unittest.py:
3280         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3281         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3282
3283         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3284         which would have matched our other checkers, because I couldn't figure out how to call
3285         "json.loads" without hitting namespace conflicts.)
3286         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3287         just the modified lines from a patch.
3288         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3289         exception.
3290         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3291         try to extract a line number.
3292
3293         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3294         (MockErrorHandler.__init__):
3295         (MockErrorHandler.turn_off_line_filtering):
3296         (MockErrorHandler.__call__):
3297         Helper class. Copied from xml_unittest.py.
3298
3299         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3300         line_number_from_json_exception helper method.
3301
3302         (JSONCheckerTest.assert_no_error):
3303         (JSONCheckerTest.assert_error):
3304         Helper methods to assert that we did or didn't get an error.
3305
3306         (JSONCheckerTest.mock_handle_style_error): Helper method.
3307
3308         (JSONCheckerTest.test_conflict_marker):
3309         (JSONCheckerTest.test_single_quote):
3310         (JSONCheckerTest.test_init):
3311         (JSONCheckerTest.test_no_error):
3312         Test various cases.
3313
3314 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3315
3316         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
3317         https://bugs.webkit.org/show_bug.cgi?id=73664
3318
3319         Reviewed by Martin Robinson.
3320
3321         This patch adds our HTTP library and its main dependencies; this
3322         should not affect layout or rendering.
3323
3324         * gtk/jhbuild.modules:
3325
3326 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3327
3328         [GTK] Also run DumpRenderTree under jhbuild
3329         https://bugs.webkit.org/show_bug.cgi?id=73646
3330
3331         Reviewed by Martin Robinson.
3332
3333         * Scripts/webkitpy/layout_tests/port/gtk.py:
3334         (GtkDriver.cmd_line):
3335
3336 2011-12-02  Hajime Morrita  <morrita@chromium.org>
3337
3338         Unreviewed, rolling out r101751 and r101775.
3339         http://trac.webkit.org/changeset/101751
3340         http://trac.webkit.org/changeset/101775
3341         https://bugs.webkit.org/show_bug.cgi?id=73191
3342
3343         breaks Windows build
3344
3345         * DumpRenderTree/chromium/config.h:
3346         * DumpRenderTree/config.h:
3347         * TestWebKitAPI/config.h:
3348         * WebKitTestRunner/config.h:
3349
3350 2011-12-02  Kentaro Hara  <haraken@chromium.org>
3351
3352         Move run-bindings-tests implementation to webkitpy/bindings/main.py
3353         https://bugs.webkit.org/show_bug.cgi?id=73619
3354
3355         Reviewed by Adam Barth.
3356
3357         As run-bindings-tests has been growing, this patch just moves its implementation
3358         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
3359
3360         No change in behavior.
3361
3362         * Scripts/run-bindings-tests:
3363         (main):
3364         * Scripts/webkitpy/bindings/__init__.py: Added.
3365         * Scripts/webkitpy/bindings/main.py: Added.
3366         (BindingsTests.__init__):
3367         (BindingsTests.generate_from_idl):
3368         (BindingsTests.generate_supplemental_dependency):
3369         (BindingsTests.detect_changes):
3370         (BindingsTests.run_tests):
3371
3372 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
3373
3374         Tools/Scripts: eliminate find_test_files from Port class.
3375         https://bugs.webkit.org/show_bug.cgi?id=73553
3376
3377         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
3378         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
3379         Also I'll move _is_test_file() and related functions close to Port.tests().
3380
3381         Reviewed by Dirk Pranke.
3382
3383         * Scripts/webkitpy/layout_tests/port/base.py:
3384         (Port.tests):
3385         (Port.is_reference_html_file):
3386         (Port._has_supported_extension):
3387         (Port._is_test_file):
3388         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3389         (PortTest.test_find_no_paths_specified):
3390         (PortTest.test_find_one_test):
3391         (PortTest.test_find_glob):
3392         (PortTest.test_find_with_skipped_directories):
3393         (PortTest.test_find_with_skipped_directories_2):
3394         (PortTest.test_is_test_file):
3395         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3396         (_default_tests_paths):
3397         (ChromiumGpuLinuxPort.tests):
3398         (ChromiumGpuCgMacPort.tests):
3399         (ChromiumGpuMacPort.tests):
3400         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3401         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3402         (ChromiumGpuTest.test_default_tests_paths):
3403         (ChromiumGpuTest.test_test_files.test_paths):
3404         (ChromiumGpuTest):
3405         (ChromiumGpuTest.test_test_files):
3406         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3407         (get_tests_run.RecordingTestDriver.run_test):
3408         * Scripts/webkitpy/tool/commands/rebaseline.py:
3409         (OptimizeBaselines._optimize_baseline):
3410         (OptimizeBaselines.execute):
3411         (AnalyzeBaselines._analyze_baseline):
3412         (AnalyzeBaselines.execute):
3413
3414 2011-12-01  Hajime Morrita  <morrita@chromium.org>
3415
3416         JS_INLINE and WTF_INLINE should be visible from WebCore
3417         https://bugs.webkit.org/show_bug.cgi?id=73191
3418
3419         Reviewed by Kevin Ollivier.
3420
3421         Removed macro definitions which is now provided by Platform.h
3422
3423         * DumpRenderTree/chromium/config.h:
3424         * DumpRenderTree/config.h:
3425         * TestWebKitAPI/config.h:
3426         * WebKitTestRunner/config.h:
3427
3428 2011-12-01  Hayato Ito  <hayato@chromium.org>
3429
3430         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
3431         https://bugs.webkit.org/show_bug.cgi?id=73406
3432
3433         Reviewed by Ryosuke Niwa.
3434
3435         WebKitPort's image_diff uses tolerance='0.1' in default.
3436         When reftests fail, we should use tolerace=0 when diff-ing images.
3437
3438         Since ImageDiff on chromium port doesn't use tolerance value as of now,
3439         this change doesn't affect chromium port's behavior.
3440
3441         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3442         (write_test_result):
3443         * Scripts/webkitpy/layout_tests/port/base.py:
3444         (Port.diff_image):
3445         * Scripts/webkitpy/layout_tests/port/chromium.py:
3446         (ChromiumPort.diff_image):
3447         * Scripts/webkitpy/layout_tests/port/test.py:
3448         (TestPort.diff_image):
3449         * Scripts/webkitpy/layout_tests/port/webkit.py:
3450         (WebKitPort.diff_image):
3451         (WebKitPort._start_image_diff_process):
3452         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3453         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3454
3455 2011-12-01  Adam Klein  <adamk@chromium.org>
3456
3457         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
3458         https://bugs.webkit.org/show_bug.cgi?id=73599
3459
3460         Reviewed by Ojan Vafai.
3461
3462         * TestResultServer/static-dashboards/builders.js:
3463         * TestResultServer/static-dashboards/dashboard_base.js:
3464         ():
3465         (htmlForTestTypeSwitcher):
3466         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3467         (testHtmlForTestTypeSwitcherGroup):
3468
3469 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3470
3471         Parse reftest.list and extract types of ref tests
3472         https://bugs.webkit.org/show_bug.cgi?id=66837
3473
3474         Reviewed by Dirk Pranke.
3475
3476         Add support for reftest.list to base port.
3477
3478         * Scripts/webkitpy/common/find_files.py:
3479         (find):
3480         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3481         (SingleTestRunner.__init__):
3482         * Scripts/webkitpy/layout_tests/port/base.py:
3483         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
3484         to a dictionary of {test path: ("==" or "!=", reference file path)}
3485         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
3486         (Port._reference_file_for): Added; obtains the reference file name given a test name.
3487         (Port.is_reftest): Added; Calls _reference_file_for.
3488         (Port.reftest_expected_filename): Calls _reference_file_for.
3489         (Port.reftest_expected_mismatch_filename): Ditto.
3490         (Port.find_test_files):
3491         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
3492         -expected, -expected-mismach, -ref, or -notref as a reference file.
3493         (_is_test_file):
3494         (_parse_reftest_list): Added.
3495         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3496         (PortTest.test_is_test_file):
3497         (PortTest.test_parse_reftest_list):
3498         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3499         (DryrunDriver.run_test):
3500         * Scripts/webkitpy/layout_tests/port/test.py:
3501         (unit_test_filesystem.add_test_file):
3502         (unit_test_filesystem.add_file):
3503         (unit_test_filesystem):
3504         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3505         (get_tests_run.RecordingTestDriver.run_test):
3506         (MainTest.test_unexpected_failures):
3507         (MainTest.test_missing_and_unexpected_results):
3508         (EndToEndTest.test_end_to_end):
3509         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3510         (Rebaseliner._compile_rebaselining_tests):
3511
3512 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3513
3514         Unreviewed, rolling out r101711.
3515         http://trac.webkit.org/changeset/101711
3516         https://bugs.webkit.org/show_bug.cgi?id=73605
3517
3518         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
3519
3520         * Scripts/webkitpy/style/checker.py:
3521         (_all_categories):
3522         (FileType):
3523         (CheckerDispatcher._file_type):
3524         (CheckerDispatcher._create_checker):
3525         * Scripts/webkitpy/style/checker_unittest.py:
3526         (CheckerDispatcherDispatchTest.assert_checker_cpp):
3527         (CheckerDispatcherDispatchTest.test_cpp_paths):
3528         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
3529         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
3530
3531 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3532
3533         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
3534
3535         * Scripts/webkitpy/common/config/watchlist:
3536
3537 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3538
3539         [GTK] Read fonts from the jhbuild root
3540         https://bugs.webkit.org/show_bug.cgi?id=73487
3541
3542         Reviewed by Gustavo Noronha Silva.
3543
3544         Read fonts from the jhbuild root instead of from the system. This will ensure
3545         that all testers use the same fonts instead of leaving this up to luck.
3546
3547         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3548         (initializeFonts): Load fonts from jhbuild root.
3549         * Scripts/webkitpy/layout_tests/port/gtk.py:
3550         (GtkPort.setup_environ_for_server): Pass an environment variable containing
3551         the path to the jhbuild root.
3552         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3553         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
3554
3555 2011-12-01  Adam Roben  <aroben@apple.com>
3556
3557         Teach check-webkit-style how to check the syntax of JSON files
3558
3559         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3560
3561         Reviewed by Darin Adler.
3562
3563         * Scripts/webkitpy/style/checker.py:
3564         (_all_categories): Added JSONChecker's categories to the set of all categories.
3565         (FileType): Added a JSON type. Incremented other types.
3566         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3567         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3568
3569         * Scripts/webkitpy/style/checker_unittest.py:
3570         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3571         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3572
3573         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3574         which would have matched our other checkers, because I couldn't figure out how to call
3575         "json.loads" without hitting namespace conflicts.)
3576         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3577         just the modified lines from a patch.
3578         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3579         exception.
3580         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3581         try to extract a line number.
3582
3583         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3584         (MockErrorHandler.__init__):
3585         (MockErrorHandler.turn_off_line_filtering):
3586         (MockErrorHandler.__call__):
3587         Helper class. Copied from xml_unittest.py.
3588
3589         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3590         line_number_from_json_exception helper method.
3591
3592         (JSONCheckerTest.assert_no_error):
3593         (JSONCheckerTest.assert_error):
3594         Helper methods to assert that we did or didn't get an error.
3595
3596         (JSONCheckerTest.mock_handle_style_error): Helper method.
3597
3598         (JSONCheckerTest.test_conflict_marker):
3599         (JSONCheckerTest.test_single_quote):
3600         (JSONCheckerTest.test_init):
3601         (JSONCheckerTest.test_missing_closing_brace):
3602         (JSONCheckerTest.test_no_error):
3603         Test various cases.
3604
3605 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3606
3607         [GTK] Add a helper function to find the current executable's path
3608         https://bugs.webkit.org/show_bug.cgi?id=73473
3609
3610         Reviewed by Gustavo Noronha Silva.
3611
3612         Update MiniBrowser to not pass the binary directory as an environment variable.
3613         This means that you can move the binaries around without it breaking.
3614
3615         * MiniBrowser/gtk/main.c:
3616         (main): No longer set the environment variable.
3617         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
3618         * WebKitTestRunner/gtk/main.cpp:  Ditto.
3619
3620 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3621
3622         Unreviewed. Fix bad file =(.
3623
3624         * gtk/jhbuild.modules:
3625         * Scripts/webkitdirs.pm:
3626         (runAutogenForAutotoolsProject):
3627
3628 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3629
3630         [GTK] Add freetype to our jhbuild setup
3631         https://bugs.webkit.org/show_bug.cgi?id=73488
3632
3633         Reviewed by Martin Robinson.
3634
3635         This adds the first library to our jhbuild setup, and makes sure
3636         build-webkit calls autogen.sh and make with jhbuild, so that the
3637         environment is properly set.
3638
3639         * Scripts/webkitdirs.pm:
3640         (saveSum):
3641         (hashFile):
3642         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
3643         call autogen under jhbuild run;
3644         (mustRunAutogen): generalized the arguments change checking to also force
3645         running autogen when jhbuild files change;
3646         (buildAutotoolsProject): run make under jhbuild;
3647         * gtk/jhbuild.modules: add freetype.
3648
3649 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
3650
3651         Fix WebKitTestRunner compile warnings with XCode 3.2
3652         https://bugs.webkit.org/show_bug.cgi?id=73378
3653
3654         Reviewed by Chris Fleizach.
3655
3656         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3657         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
3658         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3659         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3660         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3661         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3662         (WTR::AccessibilityUIElement::verticalScrollbar):
3663
3664 2011-12-01  Adam Roben  <aroben@apple.com>
3665
3666         Allow committers to use their Trac credentials to force builds on the buildbots
3667
3668         Fixes <http://webkit.org/b/73353>
3669
3670         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
3671         three files to do its job: a config file that contains a list of WebKit committer usernames,
3672         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
3673         those two files.
3674
3675         Reviewed by Darin Adler.
3676
3677         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
3678         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
3679         whether credentials were valid or not.
3680         (CommitterAuth.__init__): Just store the path to auth.json.
3681         (CommitterAuth.auth_json): Load, parse, and return auth.json.
3682         (CommitterAuth.auth_json_filename): Return the path to auth.json.
3683         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
3684         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
3685         checking those conditions.
3686         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
3687         false otherwise or if an exception was thrown.
3688         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
3689         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
3690
3691         (CommitterAuth.open_auth_json_file):
3692         (CommitterAuth.open_trac_credentials_file):
3693         (CommitterAuth.open_webkit_committers_file):
3694         Open the specified file. These are mostly useful for testing purposes.
3695
3696         (CommitterAuth.trac_credentials_filename):
3697         (CommitterAuth.webkit_committers_filename):
3698         Return the path to the specified file by retrieving it from auth.json.
3699
3700         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
3701         of WebKit committers from it.
3702
3703         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
3704         (CMStringIO.__enter__):
3705         (CMStringIO.__exit__):
3706         Helper class that makes it possible to use StringIO with the "with" statement.
3707
3708         (open_override): Helper context manager for overriding the global "open" function
3709         temporarily.
3710
3711         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
3712         tests.
3713         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
3714         "open" to test that the expected path was opened.
3715         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
3716         successfully.
3717         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
3718         somehow have no Trac account can't authenticate.
3719
3720         (CommitterAuthTest.test_fail_to_open_auth_json_file):
3721         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
3722         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
3723         Test what happens when we can't open the three files we depend upon.
3724
3725         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
3726         an authentication class.
3727
3728         (CommitterAuthTest.test_invalid_auth_json_file):
3729         (CommitterAuthTest.test_invalid_committers_file):
3730         (CommitterAuthTest.test_invalid_trac_credentials_file):
3731         (CommitterAuthTest.test_missing_auth_json_keys):
3732         Test what happens when the three files we depend upon are invalid in some way.
3733
3734         (CommitterAuthTest.test_open_auth_json_file):
3735         (CommitterAuthTest.test_open_trac_credentials_file):
3736         (CommitterAuthTest.test_open_webkit_committers_file):
3737         Test that we open the expected paths.
3738
3739         (CommitterAuthTest.test_trac_credentials_filename):
3740         (CommitterAuthTest.test_webkit_committers_filename):
3741         Test that we extract filenames out of auth.json correctly.
3742
3743         (CommitterAuthTest.test_non_committer_fails):
3744         (CommitterAuthTest.test_unknown_user_fails):
3745         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
3746         (CommitterAuthTest.test_wrong_password_fails):
3747         Test various failed authentication attempts.
3748
3749         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
3750         committers out of the committers file correctly.
3751
3752         (CommitterAuthTest.fake_auth_json_file):
3753         (CommitterAuthTest.invalid_auth_json_file):
3754         (CommitterAuthTest.fake_committers_file):
3755         (CommitterAuthTest.invalid_committers_file):
3756         (CommitterAuthTest.fake_htdigest_file):
3757         (CommitterAuthTest.invalid_htdigest_file):
3758         Return various fake files for testing.
3759
3760         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
3761         to be used for authentication in the web interface, and specify that only authenticated
3762         users may force builds.
3763
3764 2011-12-01  Adam Roben  <aroben@apple.com>
3765
3766         Add an HTDigestParser class to webkitpy
3767
3768         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
3769
3770         This class can be used to parse Apache's htdigest files and check whether a given
3771         username/realm/password tuple is present in the file. Eventually this will be used for
3772         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
3773
3774         Reviewed by Eric Seidel.
3775
3776         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
3777         (HTDigestParser.__init__): Stores the parsed representation of the file.
3778         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
3779         password and returns whether the resulting tuple is present in the file.
3780         (HTDigestParser.entries): Just returns the parsed representation of the file.
3781         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
3782         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
3783         whole file as invalid and all authentication attempts will fail.
3784
3785         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
3786         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
3787         optionally appended with some extra data, generates the expected entries.
3788         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
3789         authenticate, and tuples not present cannot.
3790         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
3791         fake_htdigest_file.
3792
3793         (HTDigestParserTest.test_empty_file):
3794         (HTDigestParserTest.test_too_few_colons):
3795         (HTDigestParserTest.test_too_many_colons):
3796         (HTDigestParserTest.test_invalid_hash):
3797         Test various forms of invalid files.
3798
3799         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
3800
3801 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3802
3803         [GTK] Make the new 64-bit Release bot part of the core set
3804         https://bugs.webkit.org/show_bug.cgi?id=73570
3805
3806         Reviewed by Adam Roben.
3807
3808         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
3809         Debug bot which was already part of the core set. The GTK
3810         gardeners are willing to actively maintain it.
3811
3812         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3813         (BuildBot.__init__):
3814         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3815         (test_builder_name_regexps):
3816
3817 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3818
3819         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
3820         https://bugs.webkit.org/show_bug.cgi?id=73547
3821
3822         Reviewed by Adam Roben.
3823
3824         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
3825         the 32-bit Debug configuration to 64-bit Release. The new slave is
3826         a 64-bit machine already. The 32-bit slave will be shut down.
3827
3828 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3829
3830         [GTK] build-jsc should not trigger gtkdoc generation
3831         https://bugs.webkit.org/show_bug.cgi?id=73552
3832
3833         Reviewed by Philippe Normand.
3834
3835         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
3836         that build-jsc does not try to generate gtkdoc.
3837
3838         * Scripts/webkitdirs.pm:
3839         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
3840
3841 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3842
3843         tests_run0.txt gets clobbered when re-running failing tests
3844         https://bugs.webkit.org/show_bug.cgi?id=63844
3845
3846         Reviewed by Dirk Pranke.
3847
3848         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3849         (Manager.results_directory):
3850         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3851         (AbstractWorker.__init__):
3852         (_ManagerConnection.start_worker):
3853         (_InlineManager.start_worker):
3854         (_MultiProcessManager.start_worker):
3855         (_WorkerConnection.__init__):
3856         (_InlineWorkerConnection.__init__):
3857         (_MultiProcessWorkerConnection.__init__):
3858         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3859         (_TestWorker.__init__):
3860         (_TestsMixin.test_cancel):
3861         (_TestsMixin.test_done):
3862         (_TestsMixin.test_unknown_message):
3863         (InterfaceTest.test_managerconnection_is_abstract):
3864         (InterfaceTest.test_workerconnection_is_abstract):
3865         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3866         (Worker.__init__):
3867         (Worker.safe_init):
3868         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3869         (MainTest.test_retries_directory):
3870
3871 2011-12-01  Adam Roben  <aroben@apple.com>
3872
3873         Buildbot fix
3874
3875         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
3876         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
3877         it possible for build steps to reference things like the buildbotURL property of the config.
3878
3879 2011-11-30  Adam Roben  <aroben@apple.com>
3880
3881         Use curl for downloading builds to test slaves
3882
3883         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
3884         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
3885         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
3886         overhead (courtesy of the Twisted framework).
3887
3888         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
3889         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
3890         This should make the test slaves quite a bit faster, and should ease the CPU load on
3891         build.webkit.org a bit.
3892
3893         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
3894
3895         Reviewed by Mark Rowe.
3896
3897         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
3898         to Test slaves. It's run just before DownloadBuiltProduct.
3899         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
3900         download.
3901         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
3902         FileDownload used to do this for us automatically.
3903
3904 2011-11-21  Philippe Normand  <pnormand@igalia.com>
3905
3906         [GTK] enable-webaudio websetting
3907         https://bugs.webkit.org/show_bug.cgi?id=69836
3908
3909         Reviewed by Martin Robinson.
3910
3911         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3912         (LayoutTestController::overridePreference): Update WebKitGTK
3913         enable-webaudio setting when a layout test requests it.
3914
3915 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
3916
3917         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
3918         https://bugs.webkit.org/show_bug.cgi?id=73079
3919
3920         The idea is to have performance tests for WebInspector.
3921         I was suggested to put these tests into PerformanceTests/inspector.
3922         They produce output in a format that is suitable for chromium perf bot drawing scripts.
3923
3924         I'd like to reuse code for scanning folders for test files.
3925         Because of the fact that original test_files.py has common and layout specific parts
3926         I decided to extract the generic part and put it into webkitpy/common
3927         I think the two packages with name test_files look strange but I have no idea about a better name.
3928
3929         Reviewed by Dirk Pranke.
3930
3931         * Scripts/run-inspector-perf-tests.py: Added.
3932         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
3933         (find):
3934         (_normalize):
3935         * Scripts/webkitpy/common/find_files_unittest.py: Added.
3936         (MockWinFileSystem.join):
3937         (MockWinFileSystem):
3938         (MockWinFileSystem.normpath):
3939         (TestWinNormalize.assert_filesystem_normalizes):
3940         (TestWinNormalize.test_mocked_win):
3941         (TestWinNormalize):
3942         (TestWinNormalize.test_win):
3943         * Scripts/webkitpy/layout_tests/port/base.py:
3944         (Port.tests):
3945         (Port.find_test_files):
3946         (Port._driver_class):
3947         (is_reference_html_file):
3948         (_has_supported_extension):
3949         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3950         (PortTest.test_find_no_paths_specified):
3951         (PortTest.test_find_one_test):
3952         (PortTest.test_find_glob):
3953         (PortTest.test_find_with_skipped_directories):
3954         (PortTest.test_find_with_skipped_directories_2):
3955         (PortTest):
3956         (PortTest.test_is_test_file):
3957         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3958         (_tests):
3959         * Scripts/webkitpy/layout_tests/port/test.py:
3960         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
3961         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3962         * Scripts/webkitpy/performance_tests/__init__.py: Added.
3963         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
3964         (PerfTestsRunner.__init__):
3965         (PerfTestsRunner._parse_args):
3966         (PerfTestsRunner._collect_tests._is_test_file):
3967         (PerfTestsRunner._collect_tests):
3968         (PerfTestsRunner.run):
3969         (PerfTestsRunner._run_tests_set):
3970         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
3971         (MainTest.TestPort):
3972         (MainTest.TestPort.create_driver):
3973         (MainTest.TestDriver.run_test):
3974         (MainTest.TestDriver):
3975         (MainTest.TestDriver.stop):
3976         (MainTest.create_runner):
3977         (MainTest.run_test):
3978         (MainTest.test_run_passing_test):
3979         (MainTest.test_run_silent_test):
3980         (MainTest.test_run_failed_test):
3981         (MainTest.test_run_tonguey_test):
3982         (MainTest.test_run_timeout_test):
3983         (MainTest.test_run_crash_test):
3984         (MainTest.test_run_test_set):
3985         (MainTest.test_collect_tests):
3986         (MainTest):
3987         (MainTest.test_parse_args):
3988         * Scripts/webkitpy/tool/commands/rebaseline.py:
3989         (OptimizeBaselines.execute):
3990         (AnalyzeBaselines.execute):
3991
3992 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
3993
3994         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
3995         https://bugs.webkit.org/show_bug.cgi?id=70838
3996
3997         Reviewed by James Robinson.
3998
3999         * DumpRenderTree/chromium/TestShell.cpp:
4000         (TestShell::resetWebSettings):
4001         * DumpRenderTree/chromium/TestShell.h:
4002         (TestShell::threadedCompositingEnabled):
4003         * DumpRenderTree/chromium/WebPreferences.cpp:
4004         (WebPreferences::reset):
4005         (WebPreferences::applyTo):
4006         * DumpRenderTree/chromium/WebPreferences.h:
4007         * DumpRenderTree/chromium/WebViewHost.cpp:
4008         (WebViewHost::WebViewHost):
4009         (WebViewHost::~WebViewHost):
4010
4011 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
4012
4013         AX: Nodes are reporting that focus can be set when they really can't
4014         https://bugs.webkit.org/show_bug.cgi?id=72791
4015
4016         Reviewed by Beth Dakin.
4017
4018         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4019         (AccessibilityUIElement::isFocusable):
4020         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4021         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4022         (WTR::AccessibilityUIElement::isFocusable):
4023
4024 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
4025
4026         Moved myself to the reviewers list.
4027
4028         * Scripts/webkitpy/common/config/committers.py:
4029
4030 2011-11-30  David Levin  <levin@chromium.org>
4031
4032         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
4033         https://bugs.webkit.org/show_bug.cgi?id=73415
4034
4035         Reviewed by Darin Fisher.
4036
4037         * DumpRenderTree/chromium/WebViewHost.cpp:
4038         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
4039         it being moved to a new interface and having the parameter removed.
4040         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
4041
4042 2011-11-30  Adam Roben  <aroben@apple.com>
4043
4044         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
4045
4046         This will make it a lot easier to investigate build failures on the bots.
4047
4048         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
4049
4050         Reviewed by Eric Seidel.
4051
4052         * Scripts/webkitpy/common/system/executive_mock.py:
4053         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
4054         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
4055         seen in practice.
4056
4057         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4058         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
4059         The Printer was modifying the root logger in way that would cause my new tests in
4060         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
4061         seem important to the functioning of this test, and passing False makes Printer not modify
4062         the root logger.
4063
4064         * Scripts/webkitpy/layout_tests/port/webkit.py:
4065         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
4066         up when --verbose is passed but not otherwise.
4067         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
4068         output at the ERROR level so it will always show up.
4069
4070         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4071         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
4072         cases. Test that the build scripts' output is logged when --verbose is passed or the build
4073         fails.
4074
4075 2011-11-30  Adam Roben  <aroben@apple.com>
4076
4077         Add a way to set OutputCapture's log level
4078
4079         This will be used by some unit tests I'm planning to add.
4080
4081         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
4082
4083         Reviewed by Eric Seidel.
4084
4085         * Scripts/webkitpy/common/system/outputcapture.py:
4086         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
4087         level we ever used before this patch.
4088         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
4089         being tested uses. Sets the log level for any current or future logging handlers.
4090         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
4091
4092         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
4093         (OutputCaptureTest.setUp): Create an OutputCapture to test.
4094         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
4095         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
4096         was logged.
4097         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
4098         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
4099         level.
4100
4101 2011-11-29  Beth Dakin  <bdakin@apple.com>
4102
4103         https://bugs.webkit.org/show_bug.cgi?id=72751
4104         WebKit2.MouseMoveAfterCrash API test is failing 
4105
4106         Reviewed by Sam Weinig.
4107
4108         Like DumpRenderTree, the NSWindow should act as an active window.
4109         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4110         (-[ActiveOffscreenWindow isKeyWindow]):
4111         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4112
4113 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
4114
4115         Add step to update gtk dependencies to the buildbot
4116         https://bugs.webkit.org/show_bug.cgi?id=73455
4117
4118         Reviewed by Martin Robinson.
4119
4120         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4121
4122 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4123
4124         [Qt] Add a fullscreen option to MiniBrowser.
4125         https://bugs.webkit.org/show_bug.cgi?id=73445
4126
4127         Reviewed by Noam Rosenthal.
4128
4129         This bypasses the compositor on the N9 to increase performances
4130         and remove the huge useless gray bar part of the window frame
4131         at the bottom.
4132
4133         * MiniBrowser/qt/BrowserWindow.cpp:
4134         (BrowserWindow::BrowserWindow):
4135         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4136         (printHelp):
4137         (MiniBrowserApplication::handleUserOptions):
4138         * MiniBrowser/qt/MiniBrowserApplication.h:
4139         (WindowOptions::setStartFullScreen):
4140         (WindowOptions::startFullScreen):
4141
4142 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
4143
4144         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
4145         https://bugs.webkit.org/show_bug.cgi?id=73425
4146
4147         Reviewed by Gustavo Noronha Silva.
4148
4149         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
4150         ensure that the jhbuild root is up-to-date. Currently the only module is
4151         the font module.
4152
4153         * Scripts/update-webkitgtk-libs: Added.
4154         * gtk/common.py: Added a helper to get the number of CPUs.
4155         * gtk/jhbuild.modules: Added.
4156         * gtk/jhbuildrc: Added.
4157
4158 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
4159
4160         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
4161
4162         Reviewed by Csaba Osztrogonác.
4163
4164         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
4165         instead of one that pulls in JavaScriptCore headers.
4166         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
4167         with load(javascriptcore).
4168
4169 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
4170
4171         Unreviewed, rolling out r101440 and r101442.
4172         http://trac.webkit.org/changeset/101440
4173         http://trac.webkit.org/changeset/101442
4174         https://bugs.webkit.org/show_bug.cgi?id=73429
4175
4176         multiple crashes on layout tests (Requested by hayato on
4177         #webkit).
4178
4179         * DumpRenderTree/chromium/TestShell.cpp:
4180         (TestShell::resetWebSettings):
4181         * DumpRenderTree/chromium/TestShell.h:
4182         * DumpRenderTree/chromium/WebPreferences.cpp:
4183         (WebPreferences::reset):
4184         (WebPreferences::applyTo):
4185         * DumpRenderTree/chromium/WebPreferences.h:
4186         * DumpRenderTree/chromium/WebViewHost.cpp:
4187         (WebViewHost::WebViewHost):
4188         (WebViewHost::~WebViewHost):
4189
4190 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
4191
4192         [Chromium] Fix broken DRT build for Aura Linux
4193         https://bugs.webkit.org/show_bug.cgi?id=72667
4194
4195         Reviewed by Tony Chang.
4196
4197         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
4198
4199         The following changes have been made:
4200
4201           1. Renamed TestShellAndroid to TestShellLinux.
4202           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
4203           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
4204
4205         * DumpRenderTree/DumpRenderTree.gypi:
4206         * DumpRenderTree/chromium/EventSender.cpp:
4207         (EventSender::keyDown):
4208         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
4209         * DumpRenderTree/chromium/TestShellGtk.cpp:
4210         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
4211         (AlarmHandler):
4212         (TestShell::waitTestFinished):
4213         (setupFontconfig):
4214         (platformInit):
4215         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
4216         (checkLayoutTestSystemDependencies):
4217         (openStartupDialog):
4218
4219 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
4220
4221         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
4222         https://bugs.webkit.org/show_bug.cgi?id=73328
4223
4224         Reviewed by Kent Tamura.
4225
4226         * DumpRenderTree/chromium/LayoutTestController.cpp:
4227         (LayoutTestController::enableFixedLayoutMode):
4228         (LayoutTestController::setFixedLayoutSize):
4229
4230 2011-11-29  Hayato Ito  <hayato@chromium.org>
4231
4232         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
4233         https://bugs.webkit.org/show_bug.cgi?id=73381
4234
4235         Reviewed by Ryosuke Niwa.
4236
4237         This is a quick fix for the breakage of tests on non-chromium port.
4238         We should implement diff_image later on non-chromium ports.
4239
4240         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4241         (write_test_result):
4242
4243 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
4244
4245         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
4246         https://bugs.webkit.org/show_bug.cgi?id=72489
4247
4248         Reviewed by Eric Seidel.
4249
4250         Before the this fix always added "qt" option for the option list
4251         * Scripts/run-webkit-tests:
4252         * Scripts/webkitpy/layout_tests/port/qt.py:
4253
4254 2011-11-29  David Levin  <levin@chromium.org>
4255
4256         Add a way to revert a variable to its previous value after leaving a scope.
4257         https://bugs.webkit.org/show_bug.cgi?id=73371
4258
4259         Reviewed by Adam Barth.
4260
4261         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
4262         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
4263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
4264         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
4265         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
4266         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
4267
4268 2011-11-28  Kentaro Hara  <haraken@chromium.org>
4269
4270         Implement [Supplemental] IDL and support it in run-bindings-tests
4271         https://bugs.webkit.org/show_bug.cgi?id=73162
4272
4273         Reviewed by Adam Barth.
4274
4275         run-bindings-tests supports the [Supplemental] IDL in the following way.
4276             (1) It creates a file |x| listing all IDL files.
4277             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
4278             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
4279                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
4280                 including all attributes in IDL files that are supplementing the IDL file |z|.
4281
4282         * Scripts/run-bindings-tests:
4283         (generate_from_idl):
4284         (generate_supplemental_dependency):
4285         (detect_changes):
4286         (run_tests):
4287         (main):
4288
4289 2011-11-18  Nat Duca  <nduca@chromium.org>
4290
4291         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
4292         https://bugs.webkit.org/show_bug.cgi?id=70838
4293
4294         Reviewed by James Robinson.
4295
4296         * DumpRenderTree/chromium/TestShell.cpp:
4297         (TestShell::resetWebSettings):
4298