Roll out r108309, r108323, and r108326
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-21  Adam Roben  <aroben@apple.com>
2
3         Roll out r108309, r108323, and r108326
4
5         They broke the 32-bit Lion build.
6
7         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
8
9         * DumpRenderTree/efl/CMakeLists.txt:
10
11 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
12
13         [Qt][WK2] Get rid of the dependency to QtWidgets
14         https://bugs.webkit.org/show_bug.cgi?id=76276
15
16         Reviewed by Simon Hausmann.
17
18         * MiniBrowser/qt/MiniBrowser.pro:
19         * MiniBrowser/qt/MiniBrowserApplication.cpp:
20         (MiniBrowserApplication::MiniBrowserApplication):
21         (MiniBrowserApplication::notify):
22         (MiniBrowserApplication::sendTouchEvent):
23         * MiniBrowser/qt/MiniBrowserApplication.h:
24         (MiniBrowserApplication):
25         * QtTestBrowser/locationedit.h:
26         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
27         (WTR::activateFonts):
28         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
29
30 2012-02-20  Adam Barth  <abarth@webkit.org>
31
32         mastercfg_unittest.py fails without simplejson
33         https://bugs.webkit.org/show_bug.cgi?id=79070
34
35         Reviewed by Csaba Osztrogonác.
36
37         Now that we require Python 2.6 (and higher) we can import json rather
38         than simplejson.  We still need to use the simplejson name because
39         that's what the master.cfg script expects.
40
41         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
42         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
43
44 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
45
46         JSC should be a triple-tier VM
47         https://bugs.webkit.org/show_bug.cgi?id=75812
48         <rdar://problem/10079694>
49
50         Reviewed by Gavin Barraclough.
51
52         Changed EFL's build system to include a new directory in JavaScriptCore.
53
54         * DumpRenderTree/efl/CMakeLists.txt:
55
56 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
57
58         Update pywebsocket to 0.7.2
59         https://bugs.webkit.org/show_bug.cgi?id=79066
60
61         This version includes vendor-prefixed deflate-frame extension support.
62
63         Reviewed by Kent Tamura.
64
65         * Scripts/webkitpy/thirdparty/__init__.py:
66         (AutoinstallImportHook._install_pywebsocket):
67
68 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
69
70         [UNIX] Plugin information fields are not interpreted as UTF-8
71         https://bugs.webkit.org/show_bug.cgi?id=78635
72
73         Reviewed by Gustavo Noronha Silva.
74
75         Interpret plugin metadata as UTF8 aways. This matches the behavior
76         of Chromium and the Totem plugin.
77
78         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
79         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
80
81 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
82
83         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
84         https://bugs.webkit.org/show_bug.cgi?id=78935
85
86         Reviewed by Gustavo Noronha Silva.
87
88         Move the TestNetscapePlugin headers to a more appropriate directory and update
89         the build files to match.
90
91         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
92         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
93         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
94         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
95         * GNUmakefile.am: Ditto.
96
97 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
98
99         Add a new API for the Vibration API(W3C).
100         https://bugs.webkit.org/show_bug.cgi?id=72010
101
102         Reviewed by Hajime Morita.
103
104         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
105
106 2012-02-20  János Badics  <dicska@gmail.com>
107
108         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
109         https://bugs.webkit.org/show_bug.cgi?id=71816
110
111         RunQtAPITests will notify if a timeout occurs during testing.
112         Added unittest to the master.cfg
113
114         Reviewed by Csaba Osztrogonác.
115
116         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
117         (RunQtAPITests.evaluateCommand):
118         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
119         (RunQtAPITestsTest):
120         (RunQtAPITestsTest.assertResults):
121         (RunQtAPITestsTest.test_timeout):
122         (test_success):
123         (test_failure):
124         (test_timeout_and_failure):
125
126 2012-02-20  Andy Wingo  <wingo@igalia.com>
127
128         Add wingo as a committer.
129
130         Unreviewed.
131
132         * Scripts/webkitpy/common/config/committers.py: Add myself to the
133         committers list.
134
135 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
136
137         [chromium] check that we're not running multiple modal dialogs at the same time
138         https://bugs.webkit.org/show_bug.cgi?id=78486
139
140         Reviewed by Kent Tamura.
141
142         * DumpRenderTree/chromium/TestShell.cpp:
143         (TestShell::TestShell):
144         * DumpRenderTree/chromium/TestShell.h:
145         (TestShell::setIsDisplayingModalDialog):
146         (TestShell::isDisplayingModalDialog):
147         (TestShell):
148         * DumpRenderTree/chromium/WebViewHost.cpp:
149         (WebViewHost::runModal):
150
151 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
152
153         Fix WebKit2GTK+ for 'make distcheck'.
154
155         Instead of conditionally including WebKit2 GNUmakefiles, always
156         include them and conditionally activate the final targets.
157
158         * MiniBrowser/gtk/GNUmakefile.am:
159         * WebKitTestRunner/GNUmakefile.am:
160
161 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
162
163         Enable video option for EFL port in build-webkit.
164         https://bugs.webkit.org/show_bug.cgi?id=79006
165
166         Reviewed by Daniel Bates.
167
168         * Scripts/build-webkit:
169
170 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
171
172         [EFL] Use modifier keys to execute pre-rendering.
173         https://bugs.webkit.org/show_bug.cgi?id=77933
174
175         Reviewed by Chang Shu.
176
177         Use modifier key to execute pre-rendering instead of using reserved function keys.
178
179         * EWebLauncher/main.c:
180         (on_key_down):
181
182 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
183
184         Fix one more dangling reference to worker_connection.name, delete unused code.
185
186         Unreviewed, build fix.
187
188         * Scripts/webkitpy/layout_tests/controllers/manager.py:
189         (Manager.update):
190         (_WorkerState.__init__):
191
192 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
193
194         Add a change that should've been in r108005.
195
196         Unreviewed, build fix.
197
198         In the refactoring/cleanup in r108005 I should've changed the
199         implementation of WorkerConnection to make it match BrokerClient
200         (and everything else) so that objects had a name() method
201         instead of a name property.
202
203         * Scripts/webkitpy/layout_tests/controllers/manager.py:
204         (Manager._run_tests):
205         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
206         (_WorkerConnection.__init__):
207         (_WorkerConnection.name):
208         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
209         (_TestWorker.__init__):
210         (_TestsMixin.name):
211         (_TestsMixin.test_name):
212         (_TestsMixin.test_cancel):
213         (_TestsMixin.test_unknown_message):
214
215 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
216
217         webkitpy: remove webkitpy.common.array_stream
218         https://bugs.webkit.org/show_bug.cgi?id=78952
219
220         Reviewed by Eric Seidel.
221
222         Turns out array_stream didn't really do anything that StringIO
223         didn't do (at least as of Python 2.6). This change removes it
224         and updates all of the callers. Where possible, I changed the
225         test assertions in order to capture the intent more clearly,
226         e.g., instead of calling self.assertTrue('foo' in stream.get()),
227         we have self.assertContainsLine(stream, 'foo'), and instead of
228         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
229         the latter isn't that much more readable, but StringIO doesn't
230         export an empty() method.
231
232         * Scripts/webkitpy/common/array_stream.py: Removed.
233         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
234         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
235         (passing_run):
236         (run_and_capture):
237         (StreamTestingMixin):
238         (StreamTestingMixin.assertContains):
239         (StreamTestingMixin.assertContainsLine):
240         (StreamTestingMixin.assertEmpty):
241         (StreamTestingMixin.assertNotEmpty):
242         (LintTest):
243         (LintTest.test_lint_test_files):
244         (LintTest.test_lint_test_files__errors):
245         (MainTest):
246         (MainTest.test_child_process_1):
247         (MainTest.test_child_processes_2):
248         (MainTest.test_child_processes_min):
249         (MainTest.test_help_printing):
250         (MainTest.test_hung_thread):
251         (MainTest.test_no_tests_found):
252         (MainTest.test_no_tests_found_2):
253         (MainTest.test_repeat_each_iterations_num_tests):
254         (MainTest.test_test_list):
255         (MainTest.test_unexpected_failures):
256         (MainTest.test_worker_model__inline_with_child_processes):
257         (MainTest.test_additional_platform_directory):
258         (RebaselineTest):
259         (RebaselineTest.assertBaselines):
260         (RebaselineTest.test_reset_results):
261         (RebaselineTest.test_missing_results):
262         (RebaselineTest.test_new_baseline):
263         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
264         (MeteredStream.update):
265         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
266         (TestMeteredStream.test_regular):
267         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
268         (TestUtilityFunctions.assertEmpty):
269         (TestUtilityFunctions):
270         (TestUtilityFunctions.assertNotEmpty):
271         (TestUtilityFunctions.assertWritten):
272         (TestUtilityFunctions.test_configure_logging):
273         (Testprinter.assertEmpty):
274         (Testprinter):
275         (Testprinter.assertNotEmpty):
276         (Testprinter.assertWritten):
277         (Testprinter.reset):
278         (Testprinter.get_printer):
279         (Testprinter.test_help_printer):
280         (Testprinter.do_switch_tests.do_helper):
281         (Testprinter.test_print_one_line_summary):
282         (Testprinter.test_print_test_result):
283         (Testprinter.test_print_progress):
284         (Testprinter.test_write_nothing):
285         (Testprinter.test_write_misc):
286         (Testprinter.test_write_everything):
287         (Testprinter.test_write_verbose):
288         (Testprinter.test_print_unexpected_results):
289         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
290         (MainTest.assertWritten):
291         (create_runner):
292         (test_run_test_set):
293         (test_run_test_set_kills_drt_per_run):
294         (test_run_test_set_for_parser_tests):
295         (test_run_test_set_with_json_output):
296         (test_run_test_set_with_json_source):
297         (test_run_test_set_with_multiple_repositories):
298         (test_upload_json):
299
300 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
301
302         [wx] Add the WebCore/page/scrolling directory to the build dirs.
303
304         * waf/build/settings.py:
305
306 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
307
308         [wx] Unreviewed build fix. Don't error out or hang if we have
309         downloaded dependencies but server update check fails.
310
311         * waf/build/build_utils.py:
312         (download_if_newer):
313
314 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
315
316         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
317         https://bugs.webkit.org/show_bug.cgi?id=69444
318
319         Reviewed by Tony Chang.
320
321         Currently if a test's image checksum doesn't match the checksum
322         in the baseline, but the images themselves match according to
323         ImageDiff, new-run-webkit-tests ignores the problem. This is
324         probably bad, but it's not yet clear what the right thing to do
325         is. This patch will log a warning to stderr, at least (but the
326         test will still pass).
327
328         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
329         (SingleTestRunner._compare_image):
330         (SingleTestRunner._run_reftest):
331         * Scripts/webkitpy/layout_tests/port/test.py:
332         (unit_test_list):
333         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
334
335 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
336
337         NRWT does not report failure for a skipped test
338         https://bugs.webkit.org/show_bug.cgi?id=78750
339
340         Reviewed by Eric Seidel.
341
342         If a test is listed in a Skipped file and you run it anyway
343         with --force, and the test fails, currently NRWT will print
344         "test ran as expected"; this is confusing, because you probably
345         expect the test to fail and yet this might lead you to think the
346         test passed. This patch changes the expected behavior to "PASS",
347         so tests that fail will be reported.
348
349         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
350         (result_was_expected):
351         (TestExpectationParser):
352         (TestExpectationParser.expectation_for_skipped_test):
353         (TestExpectations):
354         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
355         (test_add_skipped_tests):
356         * Scripts/webkitpy/layout_tests/port/test.py:
357         (unit_test_list): Add some tests that are expected to be in a Skipped file.
358         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
359
360 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
361
362         webkitpy: fix test code after bug 78181
363         https://bugs.webkit.org/show_bug.cgi?id=78870
364
365         Reviewed by Adam Barth.
366
367         I forgot to update the test code as per Tony's suggestion in
368         bug 78181 (r108005). This change does that, and in doing so
369         it revealed a subtle bug in _InlineWorkerConnection.run() that
370         I am fixing as part of this (_alive would not be cleared if an
371         exception was thrown).
372
373         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
374         (_InlineWorkerConnection.run):
375         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
376         (_TestWorker.__init__):
377         (_TestWorker.handle_stop):
378         (_TestWorker.handle_test):
379         (_TestWorker.run):
380         (_TestsMixin.handle_exception):
381         (_TestsMixin.test_unknown_message):
382
383 2012-02-17  Adam Roben  <aroben@apple.com>
384
385         Mac build fix after r108119
386
387         * DumpRenderTree/mac/DumpRenderTree.mm:
388         (runThread):
389         (runPthread):
390         (testThreadIdentifierMap):
391         Updated to match current WTF threading APIs.
392
393 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
394
395         revert r107147 - breaks webkit-patch on Mac SL
396         https://bugs.webkit.org/show_bug.cgi?id=78866
397
398         Reviewed by Adam Barth.
399
400         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
401         which is the version that ships on Mac SL. Reverting this
402         change until we no longer have to worry about that version.
403
404         * Scripts/webkitpy/common/system/autoinstall.py:
405         (AutoInstaller):
406         (AutoInstaller._extract_all): Added a comment about SL.
407         (AutoInstaller._unzip):
408
409 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
410
411         CSS regions enabled by default
412         https://bugs.webkit.org/show_bug.cgi?id=78525
413
414         Reviewed by David Hyatt.
415
416         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
417         CSSRegions are still enabled by default.
418         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
419
420         * DumpRenderTree/chromium/LayoutTestController.cpp:
421         (LayoutTestController::overridePreference):
422         * DumpRenderTree/chromium/WebPreferences.cpp:
423         (WebPreferences::reset):
424         (WebPreferences::applyTo):
425         * DumpRenderTree/chromium/WebPreferences.h:
426         (WebPreferences):
427         * DumpRenderTree/mac/DumpRenderTree.mm:
428         (resetDefaultsToConsistentValues):
429
430 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
431
432         Some API tests erroneously use = instead of == (causing build failures)
433         https://bugs.webkit.org/show_bug.cgi?id=78915
434
435         Reviewed by Sam Weinig.
436
437         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
438         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
439         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
440
441 2012-02-17  Peter Beverloo  <peter@chromium.org>
442
443         [Chromium] Include TestShellLinux.cpp in the build for Android
444         https://bugs.webkit.org/show_bug.cgi?id=78865
445
446         Reviewed by Eric Seidel.
447
448         Android will be re-using the TestShellLinux.cpp file. I already
449         added this r104033, but it seems to have gotten lost in the
450         recent refactorings.
451
452         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
453
454 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
455
456         Unreviewed, disable video build on EFL until it can be
457         supported by EFL build bot.
458
459         * Scripts/build-webkit:
460
461 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
462
463         [GTK] Implement zoom in/out in MiniBrowser
464         https://bugs.webkit.org/show_bug.cgi?id=75253
465
466         Reviewed by Gustavo Noronha Silva.
467
468         * MiniBrowser/gtk/BrowserWindow.c:
469         (browserWindowCanZoomIn):
470         (browserWindowCanZoomOut):
471         (browserWindowUpdateZoomActions):
472         (webViewZoomLevelChanged):
473         (zoomInCallback):
474         (zoomOutCallback):
475         (browser_window_init):
476         (browserWindowConstructed):
477
478 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
479
480         layoutTestController.display() is flaky for SVG tests
481         https://bugs.webkit.org/show_bug.cgi?id=78021
482
483         Reviewed by Adam Roben.
484
485         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
486         Size the web view before running the test, not when dumping.
487         All platforms handle this correctly now.
488
489         * DumpRenderTree/win/DumpRenderTree.cpp:
490         (dump):
491         (sizeWebViewForCurrentTest):
492         (runTest):
493
494 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
495
496         [GTK] Make install is broken when building without --enable-gtk-doc
497         https://bugs.webkit.org/show_bug.cgi?id=78828
498
499         Reviewed by Martin Robinson.
500
501         * gtk/generate-gtkdoc:
502         (rebase_installed_docs): Check documentation has been generated
503         before trying to rebase it.
504
505 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
506
507         nrwt: simplify worker interface
508         https://bugs.webkit.org/show_bug.cgi?id=78181
509
510         Reviewed by Tony Chang.
511
512         This change moves code in name(), is_done(), run(), and cancel()
513         from Worker to AbstractWorker, since the logic is pretty much
514         boilerplate code that any implementation would want to use.
515
516         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
517         (get.should):
518         (AbstractWorker.__init__):
519         (AbstractWorker):
520         (AbstractWorker.name):
521         (AbstractWorker.stop_handling_messages):
522         (AbstractWorker.run):
523         (AbstractWorker.is_done):
524         (AbstractWorker.cancel):
525         * Scripts/webkitpy/layout_tests/controllers/worker.py:
526         (Worker.__init__):
527         (Worker.run):
528         (Worker.handle_stop):
529
530 2012-02-16  Michael Saboff  <msaboff@apple.com>
531
532         ENH: Add ability to run subset of JavaScript layout tests with JSC
533         https://bugs.webkit.org/show_bug.cgi?id=78764
534
535         Reviewed by Gavin Barraclough.
536
537         New simple test drive shell script that runs a defined
538         list of javascript tests using jsc and the standalone-{pre,post}.js
539         wrappers.
540
541         * Scripts/run-fast-jsc: Added.
542
543 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
544
545         Add new Qt performance tester bot to build.webkit.org
546         https://bugs.webkit.org/show_bug.cgi?id=78795
547
548         Reviewed by Adam Roben.
549
550         * BuildSlaveSupport/build.webkit.org-config/config.json:
551
552 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
553
554         Disable inspector on WinCE.
555
556         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
557
558         * Scripts/build-webkit:
559
560 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
561
562         WinCE build fix after r107656.
563
564         Disable FTPDIR on WinCE, since it does not compile there.
565
566         * Scripts/build-webkit:
567
568 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
569
570         Build fix after r107863.
571
572         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
573
574 2012-02-15  Tony Chang  <tony@chromium.org>
575
576         [chromium] add linux dbg back to garden-o-matic
577         https://bugs.webkit.org/show_bug.cgi?id=78752
578
579         Reviewed by Adam Barth.
580
581         This reflects the current linux debug bot name (there's only one bot).
582         I'm also remove the mac clang builder since it doesn't exist (mac
583         always uses clang now).
584
585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
586         * Scripts/webkitpy/layout_tests/port/builders.py:
587
588 2012-02-15  Sam Weinig  <sam@webkit.org>
589
590         Add style check for ctype functions that are generally frowned upon in WebKit
591         https://bugs.webkit.org/show_bug.cgi?id=78748
592
593         Reviewed by Anders Carlsson.
594
595         Not every platform has DisallowCType.h to check for uses of the ctype.h
596         functions, so add a style check for them as well.
597
598         * Scripts/webkitpy/style/checkers/cpp.py:
599         (check_ctype_functions):
600         (check_style):
601         (CppChecker):
602         Add check.
603
604         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
605         (WebKitStyleTest.test_ctype_fucntion):
606         Add checker.
607
608 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
609
610         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
611         https://bugs.webkit.org/show_bug.cgi?id=76546
612
613         Reviewed by Simon Hausmann.
614
615         Resize the web view programatically because the declarative property binding
616         does not work. Seems like our qml environment is not initialized fully but it
617         needs more investigation.
618
619         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
620         (WTR::WrapperWindow::handleStatusChanged):
621         (WTR::PlatformWebView::resizeTo):
622
623 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
624
625         webkitpy: add a worker_args concept to start_worker()
626         https://bugs.webkit.org/show_bug.cgi?id=78572
627
628         Reviewed by Tony Chang.
629
630         This change replaces the three NRWT-specific arguments passed
631         through the broker to the worker with a generic WorkerArguments
632         wrapper class and a separate set_inline_arguments() call that can
633         be used to pass additional data to the worker when it is running
634         in the same process as the manager (this is needed for testing).
635         With the addition of set_inline_arguments() we also no longer
636         need to pass an optional argument to the worker.run() call.
637
638         Note that this method is *only* implemented on inline workers,
639         so calling this on a regular (child process) worker will result
640         in a runtime error.
641
642         * Scripts/webkitpy/layout_tests/controllers/manager.py:
643         (Manager._run_tests):
644         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
645         (AbstractWorker.__init__):
646         (AbstractWorker.run):
647         (_ManagerConnection.start_worker):
648         (_InlineManager.start_worker):
649         (_InlineManager.set_inline_arguments):
650         (_InlineManager.run_message_loop):
651         (_MultiProcessManager.start_worker): Reworked signature.
652         (_WorkerConnection.__init__):
653         (_InlineWorkerConnection.__init__):
654         (_InlineWorkerConnection.set_inline_arguments): New method.
655         (_InlineWorkerConnection):
656         (_InlineWorkerConnection.run):
657         (_Process.run):
658         (_MultiProcessWorkerConnection.__init__):
659         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
660         (_TestWorker.__init__):
661         (_TestWorker.set_inline_arguments):
662         (_TestWorker.handle_test):
663         (_TestWorker.run):
664         (_TestsMixin.test_cancel):
665         (_TestsMixin.test_done):
666         (_TestsMixin.test_unknown_message):
667         (InlineBrokerTests): New class for more testing.
668         (InlineBrokerTests.setUp):
669         (InlineBrokerTests.test_inline_arguments): New test.
670         (InterfaceTest.test_managerconnection_is_abstract):
671         (InterfaceTest.test_workerconnection_is_abstract):
672         * Scripts/webkitpy/layout_tests/controllers/worker.py:
673         (WorkerArguments):
674         (WorkerArguments.__init__):
675         (Worker.__init__):
676         (Worker.set_inline_arguments):
677         (Worker):
678         (Worker.run):
679         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
680         (WorkerTest.test_default_platform_in_worker):
681
682 2012-02-15  Adam Klein  <adamk@chromium.org>
683
684         Unreviewed, rolling out r107704.
685         http://trac.webkit.org/changeset/107704
686         https://bugs.webkit.org/show_bug.cgi?id=78486
687
688         Caused layout test crashes in debug builds.
689
690         Specific crashing tests:
691
692         fast/events/show-modal-dialog-onblur-onfocus.html
693         fast/harness/show-modal-dialog.html
694         inspector/console/console-long-eval-crash.html
695
696         * DumpRenderTree/chromium/TestShell.cpp:
697         (TestShell::TestShell):
698         * DumpRenderTree/chromium/TestShell.h:
699         (TestShell):
700         * DumpRenderTree/chromium/WebViewHost.cpp:
701         (WebViewHost::runModal):
702
703 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
704
705         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
706         https://bugs.webkit.org/show_bug.cgi?id=76347
707
708         Reviewed by Kenneth Rohde Christiansen.
709
710         * MiniBrowser/qt/MiniBrowser.qrc:
711         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
712         * MiniBrowser/qt/qml/BrowserWindow.qml:
713         * MiniBrowser/qt/qml/DialogLineInput.qml:
714
715 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
716
717         [Qt] Fix WebGL in QtTestBrowser
718
719         Reviewed by Tor Arne Vestbø.
720
721         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
722         the options for enabling GL we also pass them on properly.
723
724 2012-02-14  Sam Weinig  <sam@webkit.org>
725
726         Add #include of unistd.h on the mac for getcwd. 
727
728         Reviewed by Anders Carlsson.
729
730         This is necessary when building with libc++.
731
732         * WebKitTestRunner/TestInvocation.cpp:
733
734 2012-02-14  Sam Weinig  <sam@webkit.org>
735
736         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
737         https://bugs.webkit.org/show_bug.cgi?id=78663
738
739         Reviewed by Anders Carlsson.
740
741         * DumpRenderTree/DumpRenderTreePrefix.h:
742         * DumpRenderTree/cg/ImageDiffCG.cpp:
743
744 2012-02-14  Adam Barth  <abarth@webkit.org>
745
746         Implement an adb-based driver for the ChromiumAndroidPort
747         https://bugs.webkit.org/show_bug.cgi?id=78627
748
749         Reviewed by Eric Seidel.
750
751         This driver mostly just wires up the ChromiumDriver through adb.  In
752         some cases, it translates protocol elements, such as URIs, so that the
753         rest of webkitpy is insulated from the "remoteness" of the target device.
754
755         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
756         (ChromiumAndroidPort.start_helper):
757         (ChromiumAndroidPort._driver_class):
758         (ChromiumAndroidPort._update_version):
759         (ChromiumAndroidPort._get_stderr):
760         (ChromiumAndroidPort):
761         (ChromiumAndroidPort._get_last_stacktrace):
762         (ChromiumAndroidPort._teardown_performance):
763         (ChromiumAndroidDriver):
764         (ChromiumAndroidDriver.__init__):
765         (ChromiumAndroidDriver._start):
766         (ChromiumAndroidDriver.run_test):
767         (ChromiumAndroidDriver.stop):
768         (ChromiumAndroidDriver._test_shell_command):
769         (ChromiumAndroidDriver._write_command_and_read_line):
770         (ChromiumAndroidDriver._output_image):
771         (ChromiumAndroidDriver._has_crash_hint):
772
773 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
774
775         webkitpy: the real_name() method in the Port class is no longer needed
776         https://bugs.webkit.org/show_bug.cgi?id=78651
777
778         Reviewed by Eric Seidel.
779
780         The change in bug 78565 / r107718 made it no longer necessary
781         (we can use options.platform instead).
782
783         * Scripts/webkitpy/layout_tests/port/base.py:
784         (Port.name):
785         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
786         (MockDRTPort.__init__):
787
788 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
789
790         webkitpy: clean up options, port handling in manager_worker_broker
791         https://bugs.webkit.org/show_bug.cgi?id=78568
792
793         Reviewed by Tony Chang.
794
795         manager_worker_broker no longer needs options or port objects
796         directly, so we make them only be passed in start_worker().
797
798         * Scripts/webkitpy/layout_tests/controllers/manager.py:
799         (Manager._run_tests):
800         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
801         (get):
802         (_ManagerConnection.__init__):
803         (_ManagerConnection.start_worker):
804         (_InlineManager.__init__):
805         (_InlineManager.start_worker):
806         (_InlineManager.run_message_loop):
807         (_MultiProcessManager.__init__):
808         (_MultiProcessManager):
809         (_MultiProcessManager.start_worker):
810         (_InlineWorkerConnection.__init__):
811         (_InlineWorkerConnection.run):
812         (_Process.__init__):
813         (_MultiProcessWorkerConnection.__init__):
814         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
815         (make_broker):
816         (_TestWorker.run):
817         (_TestsMixin.test_cancel):
818         (_TestsMixin.test_done):
819         (_TestsMixin.test_unknown_message):
820         (MultiProcessBrokerTests.setUp):
821         (InterfaceTest.test_managerconnection_is_abstract):
822         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
823         (Broker.__init__):
824
825 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
826
827         nrwt: add a unit test for regression introduced in bug 78565
828         https://bugs.webkit.org/show_bug.cgi?id=78646
829
830         Reviewed by Tony Chang.
831
832         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
833         (FakeConnection):
834         (FakeConnection.run_message_loop):
835         (FakeConnection.post_message):
836         (WorkerTest):
837         (WorkerTest.test_default_platform_in_worker):
838
839 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
840
841         NRWT is broken for the default port
842         https://bugs.webkit.org/show_bug.cgi?id=78640
843     
844         Reviewed by Tony Chang.
845
846         The change in r107718 (bug 78565) broke NRWT if you didn't
847         specify any sort of --platform flag or equivalent. I didn't
848         catch this because it's a full integration test (which we don't
849         have an automated test for) and I missed this command line
850         variant when testing interactively.
851
852         * Scripts/webkitpy/layout_tests/controllers/worker.py:
853         (Worker.run):
854
855 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
856
857         Last character display for passwords in Android.
858         https://bugs.webkit.org/show_bug.cgi?id=78532
859
860         Reviewed by Adam Barth.
861
862         * DumpRenderTree/chromium/WebPreferences.cpp:
863         (WebPreferences::applyTo):
864
865 2012-02-14  Adam Barth  <abarth@webkit.org>
866
867         Finish implementing start_helper for ChromiumAndroidPort
868         https://bugs.webkit.org/show_bug.cgi?id=78582
869
870         Reviewed by Eric Seidel.
871
872         This patch contains the remaining odds and ends for the start_helper function.
873
874         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
875         (ChromiumAndroidPort.start_helper):
876         (ChromiumAndroidPort._synchronize_datetime):
877         (ChromiumAndroidPort):
878         (ChromiumAndroidPort._check_version):
879         (ChromiumAndroidPort._run_adb_command):
880         (ChromiumAndroidPort._copy_device_file):
881
882 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
883
884         webkitpy: create ports in Workers, not in manager_worker_broker
885         https://bugs.webkit.org/show_bug.cgi?id=78565
886
887         Reviewed by Tony Chang.
888
889         We will now create the Port object (if necessary) in the Worker
890         directly, so that the manager_worker_broker module doesn't need
891         all of this layout_test-specific logic. Part of the fixes for
892         bug 78171.
893
894         These changes are all well-tested by the existing tests in
895         run_webkit_tests_integrationtest.py.
896
897         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
898         (_Process.run):
899         * Scripts/webkitpy/layout_tests/controllers/worker.py:
900         (Worker.__init__):
901         (Worker.safe_init):
902         (Worker.run):
903         (Worker.cleanup):
904         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
905         (parse_args):
906         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
907
908 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
909
910         [chromium] check that we're not running multiple modal dialogs at the same time
911         https://bugs.webkit.org/show_bug.cgi?id=78486
912
913         Reviewed by Kent Tamura.
914
915         * DumpRenderTree/chromium/TestShell.cpp:
916         (TestShell::TestShell):
917         * DumpRenderTree/chromium/TestShell.h:
918         (TestShell::setIsDisplayingModalDialog):
919         (TestShell::isDisplayingModalDialog):
920         (TestShell):
921         * DumpRenderTree/chromium/WebViewHost.cpp:
922         (WebViewHost::runModal):
923
924 2012-02-14  Adam Barth  <abarth@webkit.org>
925
926         Enable the GPU codepath in the chromium-android port
927         https://bugs.webkit.org/show_bug.cgi?id=78580
928
929         Reviewed by James Robinson.
930
931         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
932         Android always uses the GPU codepath, so we set the GPU flags on the
933         main chromium-android port instead.
934
935         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
936         (ChromiumAndroidPort.__init__):
937
938 2012-02-14  Adam Barth  <abarth@webkit.org>
939
940         NRWT should expose --adb-args flag for Android
941         https://bugs.webkit.org/show_bug.cgi?id=78579
942
943         Reviewed by Eric Seidel.
944
945         This flag is already wired up to the ChromiumAndroidPort.
946
947         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
948         (parse_args):
949
950 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
951
952         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
953         https://bugs.webkit.org/show_bug.cgi?id=78541
954         <rdar://problem/10036695>
955
956         Reviewed by Kent Tamura.
957
958         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
959         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
960         After each test, reset to using new protocol.
961
962 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
963
964         Convert svg/animations to use SMIL methods for driving the timeline
965         https://bugs.webkit.org/show_bug.cgi?id=78422
966
967         Reviewed by Dirk Schulze.
968
969         Remove no longer needed SVG specific animation sampling functionality from DRT.
970         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
971
972         * DumpRenderTree/LayoutTestController.cpp:
973         (LayoutTestController::staticFunctions):
974         * DumpRenderTree/LayoutTestController.h:
975         (LayoutTestController):
976         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
977         * DumpRenderTree/chromium/LayoutTestController.cpp:
978         (LayoutTestController::LayoutTestController):
979         * DumpRenderTree/chromium/LayoutTestController.h:
980         (LayoutTestController):
981         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
982         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
983         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
984         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
985         * DumpRenderTree/qt/LayoutTestControllerQt.h:
986         (LayoutTestController):
987         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
988         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
989
990 2012-02-13  Rob Flack  <flackr@chromium.org>
991
992         Add Linux ChromiumOS test results to flakiness dashboard.
993         https://bugs.webkit.org/show_bug.cgi?id=78495
994
995         Reviewed by Ojan Vafai.
996
997         * TestResultServer/static-dashboards/builders.js:
998         * TestResultServer/static-dashboards/dashboard_base.js:
999
1000 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
1001
1002         [GTK] Mutation Observers build is broken
1003         https://bugs.webkit.org/show_bug.cgi?id=78433
1004
1005         Reviewed by Martin Robinson.
1006
1007         Enabled mutation observers as a default feature for GTK port, too.
1008
1009         * Scripts/build-webkit:
1010
1011 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
1012
1013         Allow to configure ENABLE_FTPDIR in build-webkit
1014         https://bugs.webkit.org/show_bug.cgi?id=65098
1015
1016         Reviewed by Eric Seidel.
1017
1018         Allow to disable ENABLE_FTPDIR by command line.
1019         Remove ENABLE_FTPDIR from --minimal build
1020
1021         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
1022         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
1023         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
1024
1025 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
1026
1027         Add shinyak as committer.
1028
1029         Unreviewed.
1030
1031         * Scripts/webkitpy/common/config/committers.py:
1032
1033 2012-02-13  Adam Barth  <abarth@webkit.org>
1034
1035         Implement start/stop_helper for ChromiumAndroidPort
1036         https://bugs.webkit.org/show_bug.cgi?id=78558
1037
1038         Reviewed by Dirk Pranke.
1039
1040         These functions (and their dependencies) set up the Android device for
1041         testing.
1042
1043         This patch also includes a few tweaks on the previous patch recommended
1044         by dpranke.
1045
1046         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1047         (ChromiumAndroidPort.__init__):
1048         (ChromiumAndroidPort.start_helper):
1049         (ChromiumAndroidPort.stop_helper):
1050         (ChromiumAndroidPort._shut_down_http_server):
1051         (ChromiumAndroidPort):
1052         (ChromiumAndroidPort._push_executable):
1053         (ChromiumAndroidPort._push_fonts):
1054         (ChromiumAndroidPort._restore_system_font):
1055         (ChromiumAndroidPort._push_test_resources):
1056         (ChromiumAndroidPort._push_to_device):
1057         (ChromiumAndroidPort._pull_from_device):
1058         (ChromiumAndroidPort._kill_device_process):
1059         (ChromiumAndroidPort._setup_performance):
1060         (ChromiumAndroidPort._teardown_performance):
1061         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1062         (ChromiumAndroidPortTest):
1063         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1064         (PortTestCase):
1065         (PortTestCase.make_port):
1066         (PortTestCase.test_default_worker_model):
1067
1068 2012-02-13  Adam Barth  <abarth@webkit.org>
1069
1070         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
1071         https://bugs.webkit.org/show_bug.cgi?id=78550
1072
1073         Reviewed by Eric Seidel.
1074
1075         Much of this code just forwards to the "host" port, which seems like a
1076         reasonable thing to do.
1077
1078         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1079         (ChromiumAndroidPort.__init__):
1080         (ChromiumAndroidPort.stop_helper):
1081         (ChromiumAndroidPort):
1082         (ChromiumAndroidPort._build_path):
1083         (ChromiumAndroidPort._path_to_apache):
1084         (ChromiumAndroidPort._path_to_apache_config_file):
1085         (ChromiumAndroidPort._path_to_driver):
1086         (ChromiumAndroidPort._path_to_helper):
1087         (ChromiumAndroidPort._path_to_image_diff):
1088         (ChromiumAndroidPort._path_to_lighttpd):
1089         (ChromiumAndroidPort._path_to_lighttpd_modules):
1090         (ChromiumAndroidPort._path_to_lighttpd_php):
1091         (ChromiumAndroidPort._path_to_wdiff):
1092         (ChromiumAndroidPort._shut_down_http_server):
1093         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1094         (ChromiumAndroidPortTest):
1095         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1096         (PortTestCase):
1097         (PortTestCase.make_port):
1098         (PortTestCase.test_default_worker_model):
1099
1100 2012-02-13  Adam Barth  <abarth@webkit.org>
1101
1102         chromium_android.py should implement "virtual" methods from ChromiumPort
1103         https://bugs.webkit.org/show_bug.cgi?id=78545
1104
1105         Reviewed by Dirk Pranke.
1106
1107         This patch adds basic implementations that specialize a bunch of
1108         functions from ChromiumPort.
1109
1110         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1111         (ChromiumAndroidPort):
1112         (ChromiumAndroidPort.__init__):
1113         (ChromiumAndroidPort.default_child_processes):
1114         (ChromiumAndroidPort.baseline_search_path):
1115         (ChromiumAndroidPort.check_build):
1116         (ChromiumAndroidPort.check_sys_deps):
1117         (ChromiumAndroidPort.default_worker_model):
1118         (ChromiumAndroidPort.test_expectations):
1119         (ChromiumAndroidPort.start_http_server):
1120         (ChromiumAndroidPort.stop_http_server):
1121         (ChromiumAndroidPort.start_helper):
1122         (ChromiumAndroidPort.stop_helper):
1123
1124 2012-02-13  Adam Barth  <abarth@webkit.org>
1125
1126         Add a skeleton ChromiumAndroid port to webkitpy
1127         https://bugs.webkit.org/show_bug.cgi?id=78543
1128
1129         Reviewed by Eric Seidel.
1130
1131         This patch just adds an empty ChromiumAndroid port object to webkitpy
1132         and wires it up to the factory objects.  An actual implementation will
1133         follow.
1134
1135         * Scripts/webkitpy/layout_tests/port/chromium.py:
1136         (ChromiumPort):
1137         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
1138         (ChromiumAndroidPort):
1139         (ChromiumAndroidPort.__init__):
1140         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1141         (ChromiumPortTest.test_all_test_configurations):
1142         * Scripts/webkitpy/layout_tests/port/factory.py:
1143         (PortFactory):
1144
1145 2012-02-13  Adam Barth  <abarth@webkit.org>
1146
1147         NRWT's HTTP servers should support additional directories for resources
1148         https://bugs.webkit.org/show_bug.cgi?id=78528
1149
1150         Reviewed by Eric Seidel.
1151
1152         This functionality will be used by the Chromium-Android port.
1153
1154         * Scripts/webkitpy/layout_tests/port/base.py:
1155         (Port.to.start_http_server):
1156         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1157         (LayoutTestApacheHttpd.__init__):
1158         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1159         (Lighttpd.__init__):
1160         (Lighttpd._prepare_config):
1161
1162 2012-02-13  Ami Fischman  <fischman@chromium.org>
1163
1164         Add fischman as committer.
1165
1166         Unreviewed
1167
1168         * Scripts/webkitpy/common/config/committers.py:
1169
1170 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1171
1172         [EFL] Drop support for the Curl network backend.
1173         https://bugs.webkit.org/show_bug.cgi?id=77874
1174
1175         Reviewed by Eric Seidel.
1176
1177         Nobody seems to be maintaining the Curl backend in WebCore, the
1178         EFL port developers all seem to be using the Soup backend and the
1179         port itself has many features which are only implemented for the
1180         latter.
1181
1182         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
1183         and always add the required include directories.
1184         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
1185         include directories and link to them.
1186
1187 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
1188
1189         [WebSocket] Update pywebsocket to 0.7.1
1190         https://bugs.webkit.org/show_bug.cgi?id=78484
1191
1192         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
1193
1194         Reviewed by Kent Tamura.
1195
1196         * Scripts/webkitpy/thirdparty/__init__.py:
1197         (AutoinstallImportHook._install_pywebsocket):
1198
1199 2012-02-12  Kangil Han  <kangil.han@samsung.com>
1200
1201         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
1202         https://bugs.webkit.org/show_bug.cgi?id=78091
1203
1204         Reviewed by Hajime Morita.
1205
1206         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
1207         This patch will activate around 1,900 test cases from skipped list in EFL port.
1208
1209         * DumpRenderTree/efl/EventSender.cpp:
1210         (textZoom):
1211         (pageZoom):
1212         (textZoomInCallback):
1213         (textZoomOutCallback):
1214         (zoomPageInCallback):
1215         (zoomPageOutCallback):
1216
1217 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
1218
1219         KeywordLookupGenerator.py script fails in some cases
1220         https://bugs.webkit.org/show_bug.cgi?id=77886
1221
1222         Reviewed by Benjamin Poulain.
1223
1224         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
1225         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
1226         (GlobalVariablesTest.test_path_rules_specifier):
1227
1228 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1229
1230         Add toText and isTextNode helpers in Text class.
1231         https://bugs.webkit.org/show_bug.cgi?id=78140
1232
1233         Unit test case for the new style checker introduced.
1234
1235         Reviewed by Adam Barth.
1236
1237         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1238         (CppStyleTest):
1239         (CppStyleTest.test_static_cast_readability): Added a unit test case.
1240
1241 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1242
1243         Enable features supported by EFL port in build-webkit.
1244         https://bugs.webkit.org/show_bug.cgi?id=78348
1245
1246         Reviewed by Ryosuke Niwa.
1247
1248         Sync build-webkit with OptionEfl.cmake, as some features enabled in
1249         OptionEfl.cmake are not enabled in build-webkit.
1250
1251         * Scripts/build-webkit:
1252
1253 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1254
1255         Add toText and isTextNode helpers in Text class.
1256         https://bugs.webkit.org/show_bug.cgi?id=78140
1257
1258         Added a style checker to use toText rather than static_cast<Text*>.
1259
1260         Reviewed by Adam Barth.
1261
1262         * Scripts/webkitpy/style/checkers/cpp.py:
1263         (check_language): Style checker for static_cast<Text*>.
1264
1265 2012-02-12  Philippe Normand  <pnormand@igalia.com>
1266
1267         Unreviewed, disable Mutation observers build on GTK until it can
1268         actually build.
1269
1270         * Scripts/build-webkit:
1271
1272 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
1273
1274         Add back WTFURL to WebKit
1275         https://bugs.webkit.org/show_bug.cgi?id=77291
1276
1277         Reviewed by Adam Barth.
1278
1279         Add a flag to build-webkit to easily build WebKit with WTFURL.
1280
1281         * Scripts/build-webkit:
1282
1283 2012-02-10  Adam Klein  <adamk@chromium.org>
1284
1285         Enable MUTATION_OBSERVERS by default on all platforms
1286         https://bugs.webkit.org/show_bug.cgi?id=78196
1287
1288         Reviewed by Ojan Vafai.
1289
1290         * Scripts/build-webkit:
1291
1292 2012-02-10  Adam Barth  <abarth@webkit.org>
1293
1294         Move garden-o-matic's All Failures out of experimental
1295         https://bugs.webkit.org/show_bug.cgi?id=78395
1296
1297         Reviewed by Dimitri Glazkov.
1298
1299         Several folks have tried this feature and found it useful.
1300
1301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1302
1303 2012-02-10  Tim Horton  <timothy_horton@apple.com>
1304
1305         NRWT should categorize options in --help
1306         https://bugs.webkit.org/show_bug.cgi?id=76221
1307
1308         Reviewed by Eric Seidel.
1309         
1310         Use optparse's OptionGroup mechanism to logically group NRWT's options,
1311         providing a better experience when scanning all the options.
1312
1313         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1314         (parse_args):
1315
1316 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1317
1318         [Qt][WK2] Refactor on Qt5 Layout tests' structure
1319         https://bugs.webkit.org/show_bug.cgi?id=77450
1320
1321         Reviewed by Csaba Osztrogonác.
1322
1323         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
1324         to qt-5.0-wk2 and qt-5.0-wk1.
1325
1326         * Scripts/old-run-webkit-tests:
1327         (buildPlatformResultHierarchy):
1328         (readSkippedFiles):
1329         * Scripts/webkitpy/layout_tests/port/qt.py:
1330         (QtPort._wk2_port_name):
1331         (QtPort._skipped_file_search_paths):
1332         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1333         (QtPortTest.test_baseline_search_path):
1334         * Scripts/webkitpy/layout_tests/port/webkit.py:
1335         (WebKitPort._wk2_port_name):
1336
1337 2012-02-09  Philippe Normand  <pnormand@igalia.com>
1338
1339         [GTK] EWS command-line option to run the tests
1340         https://bugs.webkit.org/show_bug.cgi?id=78211
1341
1342         Reviewed by Adam Barth.
1343
1344         New --run-tests option (defaults to False) for the EWS commands.
1345
1346         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1347         (AbstractEarlyWarningSystem):
1348         (AbstractEarlyWarningSystem.__init__):
1349         (AbstractEarlyWarningSystem.review_patch):
1350         (ChromiumLinuxEWS):
1351         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1352         (EarlyWarningSytemTest._test_builder_ews):
1353
1354 2012-02-09  Eric Seidel  <eric@webkit.org>
1355
1356         Rename compare_text and compare_audio to make it clear that they're !=
1357         https://bugs.webkit.org/show_bug.cgi?id=78301
1358
1359         Reviewed by Adam Barth.
1360
1361         I also removed the maybe_create_directory function which was redundant.
1362
1363         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1364         (Manager.set_up_run):
1365         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1366         (TestResultWriter._make_output_directory):
1367         * Scripts/webkitpy/layout_tests/port/base.py:
1368         (Port.do_text_results_differ):
1369         (Port.do_audio_results_differ):
1370         (Port.diff_text):
1371         (Port.driver_name):
1372         (Port.skips_perf_test):
1373         * Scripts/webkitpy/layout_tests/port/win.py:
1374         (WinPort.do_text_results_differ):
1375         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1376         (WinPortTest.test_do_text_results_differ):
1377         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1378         (LayoutTestApacheHttpd.__init__):
1379         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1380         (HttpServerBase.__init__):
1381         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1382         (Rebaseliner._diff_baselines):
1383
1384 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1385
1386         [GTK] Add DRT support for modal dialogs
1387         https://bugs.webkit.org/show_bug.cgi?id=53600
1388
1389         Reviewed by Martin Robinson.
1390
1391         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
1392         Most significantly, when creating a new web view in GtkLauncher, the window
1393         of the web view opener is passed around. In DumpRenderTree, the window of
1394         the main web view is always considered as the opener. This is required so
1395         the modal dialog's toplevel can be made transient for the opener's toplevel.
1396
1397         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1398         (webViewRunModalDialog):
1399         (createWebView):
1400         * GtkLauncher/main.c:
1401         (createWebViewCb):
1402         (runModalDialogCb):
1403         (createBrowser):
1404         (createWindow):
1405         (main):
1406
1407 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1408
1409         [Gtk] security/set-form-autocomplete-attribute.html fails
1410         https://bugs.webkit.org/show_bug.cgi?id=78261
1411
1412         Reviewed by Martin Robinson.
1413
1414         Use the new helper in DumpRenderTreeSupportGtk to properly
1415         test whether an element performs autocompletion.
1416
1417         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1418         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1419
1420 2012-02-09  James Robinson  <jamesr@chromium.org>
1421
1422         [chromium] Enable mock scrollbars for compositing layout tests
1423         https://bugs.webkit.org/show_bug.cgi?id=78299
1424
1425         Reviewed by Dirk Pranke.
1426
1427         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
1428         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
1429         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
1430
1431         * DumpRenderTree/chromium/TestShell.cpp:
1432         (TestShell::runFileTest):
1433         * DumpRenderTree/chromium/WebPreferences.cpp:
1434         (WebPreferences::reset):
1435         (WebPreferences::applyTo):
1436         * DumpRenderTree/chromium/WebPreferences.h:
1437         (WebPreferences):
1438
1439 2012-02-09  Eric Seidel  <eric@webkit.org>
1440
1441         Remove more uses of "os" from our webkitpy code
1442         https://bugs.webkit.org/show_bug.cgi?id=78292
1443
1444         Reviewed by Adam Barth.
1445
1446         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1447         (MockCheckout.__init__):
1448         (MockCheckout.is_path_to_changelog):
1449         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1450         * Scripts/webkitpy/common/system/filesystem_mock.py:
1451         (MockFileSystem._split):
1452         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1453         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1454         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1455         * Scripts/webkitpy/layout_tests/port/webkit.py:
1456         * Scripts/webkitpy/tool/bot/queueengine.py:
1457         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1458         * Scripts/webkitpy/tool/commands/download.py:
1459         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1460         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1461         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1462         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1463         * Scripts/webkitpy/tool/commands/upload.py:
1464         (CreateBug.prompt_for_bug_title_and_comment):
1465         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1466         * Scripts/webkitpy/tool/steps/attachtobug.py:
1467         (AttachToBug.run):
1468         * Scripts/webkitpy/tool/steps/checkstyle.py:
1469         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1470         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1471         * Scripts/webkitpy/tool/steps/editchangelog.py:
1472         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1473         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1474         (PrepareChangeLogTest.test_ensure_bug_url):
1475         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1476         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1477         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1478         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1479
1480 2012-02-09  Eric Seidel  <eric@webkit.org>
1481
1482         Remove the cr-mac-ews (it's long been dead)
1483         https://bugs.webkit.org/show_bug.cgi?id=78267
1484
1485         Reviewed by Adam Barth.
1486
1487         * QueueStatusServer/model/queues.py:
1488         (Queue):
1489         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1490         (ChromiumWindowsEWS):
1491         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1492         (EarlyWarningSytemTest._test_builder_ews):
1493         (EarlyWarningSytemTest._test_testing_ews):
1494
1495 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
1496
1497         some tests in webkitpy are being run three times
1498         https://bugs.webkit.org/show_bug.cgi?id=78283
1499
1500         Reviewed by Ryosuke Niwa.
1501
1502         It turns out that if you import a class derived from
1503         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
1504         the unittest framework treats it as if the class was defined in
1505         the file (as well in the original file). This led us to running
1506         the tests in ChangeLogTest three times.
1507
1508         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1509         (PrepareChangeLogTest):
1510         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1511         (_assert_message_for_revert_output):
1512
1513 2012-02-09  Adam Barth  <abarth@webkit.org>
1514
1515         Remove extraneous line in previous patch.  I forgot to remove this
1516         before landing.
1517
1518         * Scripts/webkitpy/layout_tests/port/driver.py:
1519         (DriverProxy.start):
1520
1521 2012-02-09  Adam Barth  <abarth@webkit.org>
1522
1523         run-perf-tests should have an option to pause before running tests so we can attach Instruments
1524         https://bugs.webkit.org/show_bug.cgi?id=78271
1525
1526         Reviewed by Ryosuke Niwa.
1527
1528         This lets me attach instruments to profile the performance of the test.
1529
1530         * Scripts/webkitpy/layout_tests/port/chromium.py:
1531         (ChromiumDriver.start):
1532         * Scripts/webkitpy/layout_tests/port/driver.py:
1533         (Driver.start):
1534         (DriverProxy.start):
1535         * Scripts/webkitpy/layout_tests/port/server_process.py:
1536         (ServerProcess.start):
1537         * Scripts/webkitpy/layout_tests/port/test.py:
1538         (TestDriver.start):
1539         * Scripts/webkitpy/layout_tests/port/webkit.py:
1540         (WebKitDriver.start):
1541         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1542         (get_tests_run.RecordingTestDriver.start):
1543         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1544         (PerfTestsRunner._parse_args):
1545         (PerfTestsRunner._run_tests_set):
1546         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1547         (start):
1548         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1549         (test_run_test_set_kills_drt_per_run):
1550         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
1551         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
1552
1553 2012-02-09  Adam Barth  <abarth@webkit.org>
1554
1555         run-perf-tests --chromium should run the chromium port
1556         https://bugs.webkit.org/show_bug.cgi?id=78266
1557
1558         Reviewed by Ryosuke Niwa.
1559
1560         This patch makes run-perf-tests work more like run-webkit-tests.
1561
1562         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1563         (PerfTestsRunner._parse_args):
1564
1565 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1566
1567         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
1568         https://bugs.webkit.org/show_bug.cgi?id=77466
1569
1570         Reviewed by Dirk Pranke.
1571
1572         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
1573         is set or if we should raise an error. A unit test was added.
1574
1575         * Scripts/webkitpy/layout_tests/port/qt.py:
1576         (QtPort.operating_system):
1577         (QtPort):
1578         (QtPort.check_sys_deps):
1579         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1580         (QtPortTest.test_operating_system):
1581         (QtPortTest):
1582         (QtPortTest.test_check_sys_deps):
1583
1584 2012-02-09  Eric Seidel  <eric@webkit.org>
1585
1586         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
1587         https://bugs.webkit.org/show_bug.cgi?id=78263
1588
1589         Reviewed by Adam Barth.
1590
1591         * Scripts/webkitpy/common/config/ports.py:
1592         (DeprecatedPort):
1593         (DeprecatedPort.name):
1594         (DeprecatedPort.flag):
1595         (DeprecatedPort.script_path):
1596         (DeprecatedPort.script_shell_command):
1597         (DeprecatedPort.port):
1598         (DeprecatedPort.makeArgs):
1599         (DeprecatedPort.update_webkit_command):
1600         (DeprecatedPort.check_webkit_style_command):
1601         (DeprecatedPort.prepare_changelog_command):
1602         (DeprecatedPort.build_webkit_command):
1603         (DeprecatedPort.run_javascriptcore_tests_command):
1604         (DeprecatedPort.run_webkit_unit_tests_command):
1605         (DeprecatedPort.run_webkit_tests_command):
1606         (DeprecatedPort.run_python_unittests_command):
1607         (DeprecatedPort.run_perl_unittests_command):
1608         (DeprecatedPort.layout_tests_results_path):
1609         (MacPort):
1610         (WinPort):
1611         (GtkPort):
1612         (GtkPort.build_webkit_command):
1613         (GtkPort.run_webkit_tests_command):
1614         (QtPort):
1615         (QtPort.build_webkit_command):
1616         (EflPort):
1617         (EflPort.build_webkit_command):
1618         (ChromiumPort):
1619         (ChromiumPort.update_webkit_command):
1620         (ChromiumPort.build_webkit_command):
1621         (ChromiumPort.run_webkit_tests_command):
1622         (ChromiumPort.run_javascriptcore_tests_command):
1623         (ChromiumXVFBPort):
1624         (ChromiumXVFBPort.run_webkit_tests_command):
1625         * Scripts/webkitpy/common/config/ports_unittest.py:
1626         (DeprecatedPortTest):
1627         (DeprecatedPortTest.test_mac_port):
1628         (DeprecatedPortTest.test_gtk_port):
1629         (DeprecatedPortTest.test_qt_port):
1630         (DeprecatedPortTest.test_chromium_port):
1631         (DeprecatedPortTest.test_chromium_xvfb_port):
1632         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1633         (AbstractEarlyWarningSystem.__init__):
1634         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1635         * Scripts/webkitpy/tool/main.py:
1636         (WebKitPatch):
1637         (WebKitPatch.handle_global_options):
1638         * Scripts/webkitpy/tool/steps/abstractstep.py:
1639         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1640         (StepsTest.test_runtests_args):
1641
1642 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
1643
1644         [chromium] always initialize makeArgs in buildChromiumNinja
1645         https://bugs.webkit.org/show_bug.cgi?id=78231
1646
1647         Reviewed by Tony Gentilcore.
1648
1649         * Scripts/webkitdirs.pm:
1650         (buildChromiumNinja):
1651
1652 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1653
1654         [GTK] Show url of current hovered link in MiniBrowser
1655         https://bugs.webkit.org/show_bug.cgi?id=78098
1656
1657         Reviewed by Martin Robinson.
1658
1659         * MiniBrowser/gtk/BrowserWindow.c:
1660         (webViewMouseTargetChanged): Check whether hit test result is a
1661         link and use the url to update the status bar text.
1662         (browserWindowConstructed): Connect to
1663         WebKitWebView::mouse-target-changed signal.
1664
1665 2012-02-09  Rob Buis  <rbuis@rim.com>
1666
1667         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1668         https://bugs.webkit.org/show_bug.cgi?id=78042
1669
1670         Reviewed by Antonio Gomes.
1671
1672         Upstream final part of our DRT implementation.
1673
1674         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
1675         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
1676         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
1677         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
1678         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
1679
1680 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
1681
1682         kill-old-processes should kill gcc and clang
1683         https://bugs.webkit.org/show_bug.cgi?id=78189
1684
1685         Reviewed by Eric Seidel.
1686
1687         Added a bunch of processes names of gcc and clang to the list.
1688
1689         * BuildSlaveSupport/kill-old-processes:
1690
1691 2012-02-07  MORITA Hajime  <morrita@google.com>
1692
1693         Replacement text should be available from the marker.
1694         https://bugs.webkit.org/show_bug.cgi?id=77934
1695
1696         Made the mock requestCheckingOfText() implementation to return
1697         a replacement text for each misspelled word if available.
1698
1699         Reviewed by Kent Tamura.
1700
1701         * DumpRenderTree/chromium/WebViewHost.cpp:
1702         (WebViewHost::finishLastTextCheck):
1703
1704 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1705
1706         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
1707         https://bugs.webkit.org/show_bug.cgi?id=78146
1708
1709         Reviewed by Ryosuke Niwa.
1710
1711         Our DumpRenderTree should support --no-timeout and --timeout options in order
1712         to be able to use run-perf-tests and have a Performance Bot.
1713         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
1714         and the necessary code to handle such command line arguments to our DumpRenderTree.
1715
1716         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1717         (WebCore::DumpRenderTree::setTimeout):
1718         (WebCore):
1719         (WebCore::DumpRenderTree::setShouldTimeout):
1720         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1721         (DumpRenderTree):
1722         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1723         (LayoutTestController::LayoutTestController):
1724         (LayoutTestController::waitUntilDone):
1725         (LayoutTestController::notifyDone):
1726         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1727         (LayoutTestController::setTimeout):
1728         (LayoutTestController::setShouldTimeout):
1729         (LayoutTestController):
1730         * DumpRenderTree/qt/main.cpp:
1731         (isOption):
1732         (printUsage):
1733         (main):
1734
1735 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1736
1737         Rubber-stamped by Martin Robinson.
1738
1739         * gtk/common.py:
1740         (get_build_path): Move test for current directory being a valid
1741         directory up so it takes precedence over WebKitBuild/Release and
1742         WebKitBuild/Debug when they exist as well.
1743
1744 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1745
1746         [GTK] doc rebasing does not respect DESTDIR
1747         https://bugs.webkit.org/show_bug.cgi?id=78177
1748
1749         Reviewed by Martin Robinson.
1750
1751         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
1752         calling it for rebasing.
1753         * gtk/generate-gtkdoc:
1754         (get_common_options): Handle the new --virtual-root option.
1755         * gtk/gtkdoc.py:
1756         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
1757         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
1758
1759 2012-02-08  Adam Barth  <abarth@webkit.org>
1760
1761         Remove Python 2.5 support from WebKit
1762         https://bugs.webkit.org/show_bug.cgi?id=71593
1763
1764         Reviewed by Eric Seidel.
1765
1766         This is the last vestige of our Python 2.5 support.
1767
1768         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1769         (AbstractQueueTest.test_log_from_script_error_for_upload):
1770
1771 2012-02-08  Adam Barth  <abarth@webkit.org>
1772
1773         version_check.py should inform users that we don't support Python 2.5 anymore
1774         https://bugs.webkit.org/show_bug.cgi?id=78179
1775
1776         Reviewed by Eric Seidel.
1777
1778         We don't support Python 2.5 anymore.
1779
1780         * Scripts/webkitpy/common/version_check.py:
1781
1782 2012-02-08  Adam Barth  <abarth@webkit.org>
1783
1784         test_configuration.py shouldn't re-implement itertools
1785         https://bugs.webkit.org/show_bug.cgi?id=78178
1786
1787         Reviewed by Eric Seidel.
1788
1789         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1790         (TestConfigurationConverter.to_specifiers_list):
1791         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1792         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1793         (TestConfigurationConverter):
1794
1795 2012-02-08  Adam Barth  <abarth@webkit.org>
1796
1797         webkitpy should reply upon the multiprocessing package existing
1798         https://bugs.webkit.org/show_bug.cgi?id=78176
1799
1800         Reviewed by Eric Seidel.
1801
1802         Now that we don't support Python 2.5, this import can't fail.
1803
1804         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1805         (get):
1806         (_Process):
1807         (_Process.__init__):
1808         (_Process.run):
1809         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1810         (FunctionTests.test_get__processes):
1811         (MultiProcessBrokerTests.setUp):
1812         * Scripts/webkitpy/layout_tests/port/base.py:
1813         (Port.__init__):
1814         (Port.default_worker_model):
1815         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1816         (ChromiumMacPort.check_build):
1817         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1818         (PortTestCase.test_default_worker_model):
1819         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1820
1821 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1822
1823         Unreviewed typo fix that makes docs build again for the gtk2-based
1824         library.
1825
1826         * gtk/generate-gtkdoc:
1827
1828 2012-02-08  Adam Barth  <abarth@webkit.org>
1829
1830         Don't re-implement ZipFile.extractall
1831         https://bugs.webkit.org/show_bug.cgi?id=78173
1832
1833         Reviewed by Eric Seidel.
1834
1835         We can use ZipFile.extractall now that we don't support Python 2.5.
1836
1837         * Scripts/webkitpy/common/system/autoinstall.py:
1838         (AutoInstaller._extract_targz):
1839         (AutoInstaller._unzip):
1840
1841 2012-02-08  Adam Barth  <abarth@webkit.org>
1842
1843         Remove the ospath compat shim from webkitpy
1844         https://bugs.webkit.org/show_bug.cgi?id=78170
1845
1846         Reviewed by Eric Seidel.
1847
1848         We no longer need this compat shim now that we don't support Python 2.5.
1849
1850         * Scripts/webkitpy/common/checkout/scm/git.py:
1851         * Scripts/webkitpy/common/checkout/scm/svn.py:
1852         * Scripts/webkitpy/common/system/filesystem.py:
1853         (FileSystem.relpath):
1854         * Scripts/webkitpy/common/system/filesystem_mock.py:
1855         (MockFileSystem.relpath):
1856         * Scripts/webkitpy/common/system/ospath.py: Removed.
1857         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
1858
1859 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1860
1861         Build fix attempt after r107053.
1862
1863         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1864         (test_collect_tests):
1865
1866 2012-02-08  Adam Barth  <abarth@webkit.org>
1867
1868         Remove simplejson because it's no longer used by webkitpy
1869         https://bugs.webkit.org/show_bug.cgi?id=78164
1870
1871         Reviewed by Eric Seidel.
1872
1873         All the importers of this code were removed in a previous patch.
1874
1875         * Scripts/webkitpy/thirdparty/simplejson: Removed.
1876         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
1877         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
1878         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
1879         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
1880         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
1881         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
1882         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
1883         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
1884         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
1885         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
1886
1887 2012-02-08  Adam Barth  <abarth@webkit.org>
1888
1889         webkitpy still imports simplejson
1890         https://bugs.webkit.org/show_bug.cgi?id=78161
1891
1892         Reviewed by Eric Seidel.
1893
1894         We no longer support Python 2.5, so we can rely upon Python's built-in
1895         JSON package.
1896
1897         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1898         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1899         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
1900         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1901         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1902         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1903         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1904         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1905         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1906         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1907         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1908
1909 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1910
1911         [GTK] Fails to build docs with non-standard build directories
1912         https://bugs.webkit.org/show_bug.cgi?id=78118
1913
1914         * gtk/common.py:
1915         (get_build_path): add comment to document changes done in r107098,
1916         as requested by the reviewer and forgotten by me.
1917
1918 2012-02-08  Adam Barth  <abarth@webkit.org>
1919
1920         Stop importing with_statement from the mysterious future
1921         https://bugs.webkit.org/show_bug.cgi?id=78156
1922
1923         Reviewed by Eric Seidel.
1924
1925         The future is now!  (Well, at least 2008, when Python 2.6 was released,
1926         is no longer the __future__.)
1927
1928         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1929         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1930         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1931         * Scripts/webkitpy/common/net/credentials_unittest.py:
1932         * Scripts/webkitpy/common/net/file_uploader.py:
1933         * Scripts/webkitpy/common/newstringio_unittest.py:
1934         * Scripts/webkitpy/common/system/autoinstall.py:
1935         * Scripts/webkitpy/common/system/crashlogs.py:
1936         * Scripts/webkitpy/common/system/fileset.py:
1937         * Scripts/webkitpy/common/system/filesystem.py:
1938         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1939         * Scripts/webkitpy/common/system/path.py:
1940         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
1941         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1942         * Scripts/webkitpy/layout_tests/port/base.py:
1943         (of):
1944         * Scripts/webkitpy/layout_tests/port/gtk.py:
1945         * Scripts/webkitpy/layout_tests/port/test.py:
1946         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1947         * Scripts/webkitpy/style/filereader_unittest.py:
1948         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1949         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1950         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1951         * Scripts/webkitpy/tool/commands/queues.py:
1952         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1953         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1954
1955 2012-02-08  Rob Buis  <rbuis@rim.com>
1956
1957         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1958         https://bugs.webkit.org/show_bug.cgi?id=78042
1959
1960         Reviewed by Antonio Gomes.
1961
1962         Upstream more parts of our DRT implementation.
1963
1964         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
1965         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
1966         * DumpRenderTree/blackberry/EventSender.cpp: Added.
1967         * DumpRenderTree/blackberry/EventSender.h: Added.
1968         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
1969         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
1970
1971 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
1972
1973         check-webkit-style failing with "Path does not exist."
1974         https://bugs.webkit.org/show_bug.cgi?id=77873
1975
1976         Reviewed by Ojan Vafai.
1977
1978         This change fixes the way the style checker determines which
1979         Port class to use for a given test_expectations.txt path; the
1980         previous version used a heuristic that didn't really work in the
1981         first place.
1982
1983         * Scripts/webkitpy/style/checkers/test_expectations.py:
1984         (TestExpectationsChecker._determine_port_from_expectations_path):
1985         (TestExpectationsChecker.__init__):
1986         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1987         (TestExpectationsTestCase._expect_port_for_expectations_path):
1988         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1989
1990 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
1991
1992         nrwt: make --skip-pixel-test-if-no-baseline option
1993         https://bugs.webkit.org/show_bug.cgi?id=70484
1994
1995         Reviewed by Dirk Pranke.
1996
1997         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1998         (SingleTestRunner.__init__):
1999         (SingleTestRunner._should_fetch_expected_checksum):
2000         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2001         (Worker.handle_test_list):
2002         * Scripts/webkitpy/layout_tests/models/test_input.py:
2003         (TestInput.__init__):
2004         * Scripts/webkitpy/layout_tests/port/webkit.py:
2005         (WebKitDriver.cmd_line):
2006         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2007         (_set_up_derived_options):
2008         (parse_args):
2009         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2010         (MainTest.test_skip_pixel_test_if_no_baseline_option):
2011         * WebKitTestRunner/TestController.cpp:
2012         (WTR::TestController::TestController):
2013         (WTR::TestController::initialize):
2014         (WTR::TestController::runTest):
2015         * WebKitTestRunner/TestController.h:
2016         (TestController):
2017         * WebKitTestRunner/TestInvocation.cpp:
2018         (WTR::TestInvocation::TestInvocation):
2019         (WTR::TestInvocation::setIsPixelTest):
2020         * WebKitTestRunner/TestInvocation.h:
2021         (WTR::TestInvocation::setSkipPixelTestOption):
2022         (TestInvocation):
2023
2024 2012-02-08  Rob Buis  <rbuis@rim.com>
2025
2026         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2027         https://bugs.webkit.org/show_bug.cgi?id=78042
2028
2029         Reviewed by Antonio Gomes.
2030
2031         Add implementation for our DumpRenderTree solution.
2032
2033         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
2034         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
2035
2036 2012-02-08  Antti Koivisto  <antti@apple.com>
2037
2038         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2039         https://bugs.webkit.org/show_bug.cgi?id=78080
2040
2041         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2042         
2043         Add API test.
2044
2045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2046         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
2047         (TestWebKitAPI):
2048         (TestWebKitAPI::TEST):
2049
2050 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2051
2052         [GTK] Fails to build docs with non-standard build directories
2053         https://bugs.webkit.org/show_bug.cgi?id=78118
2054
2055         Reviewed by Martin Robinson.
2056
2057         * gtk/common.py:
2058         (get_build_path): also try the current directory as a valid build
2059         dir, which makes non-standard build directories such as build-2.0
2060         and build-3.0 work
2061
2062 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2063
2064         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2065         https://bugs.webkit.org/show_bug.cgi?id=78099
2066
2067         Reviewed by Martin Robinson.
2068
2069         * MiniBrowser/gtk/BrowserWindow.c:
2070         (webViewDecidePolicy): Check whether it's a link clicked with the
2071         middle mouse button and load the request in a new window.
2072         (browserWindowConstructed): Connect to
2073         WebKitWebView::decide-policy signal.
2074
2075 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2076
2077         Revert a part of the change in r106687 as a build fix.
2078
2079         Since Chromium port doesn't checkout the entire WebKit trunk,
2080         we can't run "svn info" on webkit_base.
2081
2082         * Scripts/webkitpy/layout_tests/port/base.py:
2083         (Port.repository_paths):
2084
2085 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2086
2087         run-perf-tests doesn't recognize paths that start with PerformanceTests
2088         https://bugs.webkit.org/show_bug.cgi?id=78012
2089
2090         Reviewed by Adam Barth.
2091
2092         Use resolve paths using filesystem.relpath before passing it to find_files.find.
2093
2094         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2095         (PerfTestsRunner):
2096         (PerfTestsRunner._collect_tests):
2097         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2098         (test_collect_tests):
2099         (test_collect_tests.add_file):
2100
2101 2012-02-07  Justin Novosad  <junov@chromium.org>
2102
2103         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
2104         https://bugs.webkit.org/show_bug.cgi?id=78039
2105
2106         Reviewed by Stephen White.
2107
2108         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
2109
2110         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2111         (main):
2112         * DumpRenderTree/chromium/TestShell.cpp:
2113         (TestShell::TestShell):
2114         (TestShell::resetWebSettings):
2115         (TestShell::runFileTest):
2116         * DumpRenderTree/chromium/TestShell.h:
2117         (TestShell::setDeferred2dCanvasEnabled):
2118         (TestShell):
2119         * DumpRenderTree/chromium/WebPreferences.cpp:
2120         (WebPreferences::reset):
2121         (WebPreferences::applyTo):
2122         * DumpRenderTree/chromium/WebPreferences.h:
2123         (WebPreferences):
2124
2125 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2126
2127         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
2128         https://bugs.webkit.org/show_bug.cgi?id=77928
2129
2130         Reviewed by Daniel Bates.
2131
2132         CMake has used *Programs* directory for executable. In addition, shared libraries are being
2133         built in source directory. It is better to set common places in order to maintain executable
2134         and libraries. *bin* is for executable and *lib* is for library.
2135
2136         * DumpRenderTree/efl/CMakeLists.txt:
2137         * EWebLauncher/CMakeLists.txt:
2138         * Scripts/run-launcher:
2139         * Scripts/webkitdirs.pm:
2140         (jscProductDir):
2141         * Scripts/webkitpy/layout_tests/port/efl.py:
2142         (EflPort._path_to_driver):
2143         (EflPort._path_to_image_diff):
2144
2145 2012-02-07  Adam Klein  <adamk@chromium.org>
2146
2147         Add JSC support for delivering mutations when the outermost script context exits
2148         https://bugs.webkit.org/show_bug.cgi?id=70289
2149
2150         Reviewed by Eric Seidel.
2151
2152         * DumpRenderTree/mac/EventSendingController.mm: Add support for
2153         eventSender.scheduleAsynchronousKeyDown.
2154         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2155         (+[EventSendingController webScriptNameForSelector:]):
2156         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
2157         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
2158         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
2159
2160 2012-02-07  Chris Rogers  <crogers@google.com>
2161
2162         Add Chris Rogers to reviewers section
2163         https://bugs.webkit.org/show_bug.cgi?id=78016
2164
2165         Reviewed by Adam Barth.
2166
2167         * Scripts/webkitpy/common/config/committers.py:
2168
2169 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2170
2171         layoutTestController.display() is flaky for SVG tests
2172         https://bugs.webkit.org/show_bug.cgi?id=78021
2173
2174         Reviewed by Dan Bernstein.
2175
2176         Fix race condition in repaint rect tracking. When running a test using the repaint.js
2177         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
2178         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
2179         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
2180         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
2181         the repaint test already run, thus invalidating the previously tracked repaint rects.
2182
2183         * DumpRenderTree/mac/DumpRenderTree.mm:
2184         (dump):
2185         (runTest):
2186
2187 2012-02-07  Hans Wennborg  <hans@chromium.org>
2188
2189         Chromium: remove WebSpeechInputResult::set
2190         https://bugs.webkit.org/show_bug.cgi?id=77977
2191
2192         Reviewed by Darin Fisher.
2193
2194         It was renamed to assign() in r106475.
2195
2196         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2197         (makeRectResult):
2198
2199 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2200
2201         [Qt] Give emulated touch-point a radius
2202         https://bugs.webkit.org/show_bug.cgi?id=77985
2203         
2204         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
2205
2206         Reviewed by Kenneth Rohde Christiansen.
2207
2208         * MiniBrowser/qt/BrowserWindow.cpp:
2209         (BrowserWindow::updateVisualMockTouchPoints):
2210         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2211         (MiniBrowserApplication::notify):
2212         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2213
2214 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
2215
2216         [GTK] Include gdk-pixbuf in the jhbuild modules
2217         https://bugs.webkit.org/show_bug.cgi?id=77980
2218
2219         Reviewed by Gustavo Noronha Silva.
2220
2221         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
2222
2223 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
2224
2225         [Qt] Prevent early test termination with newer Qt 5
2226         https://bugs.webkit.org/show_bug.cgi?id=77945
2227
2228         Reviewed by Csaba Osztrogonác.
2229
2230         QTBUG-24120 tracks a regression in Qt that would make layout tests
2231         terminate early. This patch works around it in a Qt 4 + 5 safe manner
2232         by disabling the quitOnLastWindowClosed feature, which we don't want/need
2233         for DRT anyway.
2234
2235         * DumpRenderTree/qt/main.cpp:
2236         (main): Don't quit on last window closed.
2237
2238 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2239
2240         Fix some miscellaneous 'make dist' error for WebKitGTK+.
2241
2242         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
2243         files should not be distributed.
2244
2245 2012-02-02  Hajime Morrita  <morrita@chromium.org>
2246
2247         [PerformanceTests] Each Dromaeo test needs its landing html.
2248         https://bugs.webkit.org/show_bug.cgi?id=77504
2249
2250         Reviewed by Ryosuke Niwa.
2251
2252         Added an ignorable pattern which happens in some Dromaeo tests.
2253
2254         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2255         (PerfTestsRunner):
2256
2257 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
2258
2259         [GTK] Add missing pango include dir to fix build
2260         https://bugs.webkit.org/show_bug.cgi?id=77832
2261
2262         Reviewed by Martin Robinson.
2263
2264         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
2265
2266 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2267
2268         [GTK] Fix remaining errors in GTK+ WebKit2 API
2269         https://bugs.webkit.org/show_bug.cgi?id=77890
2270
2271         Reviewed by Gustavo Noronha Silva.
2272
2273         Verify that WebKit2 GTK+ test files are not skipped during style checks.
2274         Skip soup_server_new when checking for NULL versus 0 usage.
2275
2276         * Scripts/webkitpy/style/checker_unittest.py:
2277         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2278         * Scripts/webkitpy/style/checkers/cpp.py:
2279         (check_for_null):
2280
2281 2012-02-06  Eric Seidel  <eric@webkit.org>
2282
2283         webkit-patch apply-from-bug should be able to apply non-reviewed patches
2284         https://bugs.webkit.org/show_bug.cgi?id=77883
2285
2286         Reviewed by Adam Barth.
2287
2288         This is very helpful if you use bugzilla as a replacement for git-stash.
2289         Makes it simpler to re-apply the patch w/o having to look up the patch id.
2290
2291         * Scripts/webkitpy/tool/commands/download.py:
2292         (ProcessBugsMixin._fetch_list_of_patches_to_process):
2293         * Scripts/webkitpy/tool/commands/download_unittest.py:
2294         (DownloadCommandsTest.test_apply_from_bug):
2295
2296 2012-02-06  Philippe Normand  <pnormand@igalia.com>
2297
2298         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
2299         https://bugs.webkit.org/show_bug.cgi?id=77866
2300
2301         Reviewed by Martin Robinson.
2302
2303         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
2304         errors in some gstreamer source code files defining new GStreamer elements.
2305         * Scripts/webkitpy/style/checker_unittest.py:
2306         (GlobalVariablesTest.test_path_rules_specifier):
2307
2308 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2309
2310         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
2311         https://bugs.webkit.org/show_bug.cgi?id=77869
2312
2313         Reviewed by Philippe Normand.
2314
2315         * gtk/gtkdoc.py:
2316         (GTKDoc.rebase_installed_docs): Check html_dir exists.
2317
2318 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2319
2320         [Qt] Don't version QtWebKit.experimental.
2321         https://bugs.webkit.org/show_bug.cgi?id=77739
2322
2323         Reviewed by Tor Arne Vestbø.
2324
2325         * MiniBrowser/qt/qml/BrowserWindow.qml:
2326
2327 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2328
2329         [GTK] Fix several gtkdoc-fixxref warnings
2330         https://bugs.webkit.org/show_bug.cgi?id=77613
2331
2332         Reviewed by Martin Robinson.
2333
2334         * gtk/generate-gtkdoc:
2335         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
2336         of ignored files, since it's private.
2337         * gtk/gtkdoc.py:
2338         (GTKDoc._ignored_files_basenames): Helper function that returns a
2339         string with the list of ignored files basenames separated by a
2340         spaces, as expected by several gtkdoc commands.
2341         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
2342         --ignore-headers option.
2343         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
2344         --ignore-files option.
2345
2346 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2347
2348         [GTK] Fix xrefs after installing API documentation
2349         https://bugs.webkit.org/show_bug.cgi?id=77551
2350
2351         Reviewed by Martin Robinson.
2352
2353         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
2354         api docs.
2355         * gtk/common.py:
2356         (prefix_of_pkg_config_file): Get the prefix variable of the given
2357         pkg-config file.
2358         (gtk_version_of_pkg_config_file): Get the gtk version required by
2359         the given pkg-config file.
2360         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
2361         installed documentation.
2362         (get_gtkdoc_module_paths): Get paths where API doc is installed
2363         for the dependencies of the given pkg-config file.
2364         (get_common_xref_deps): Get API doc directories of dependencies
2365         common to WebKit1 and WebKit2.
2366         (get_webkit2_options): Add cross_reference_deps option.
2367         (get_webkit1_options): Ditto
2368         (rebase_installed_docs): Helper function to create a generator for
2369         the given pkg-config file and options and call rebase_installed_docs.
2370         * gtk/gtkdoc.py:
2371         (GTKDoc.__init__): Initialize cross_reference_deps.
2372         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
2373         dependencies.
2374         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
2375         links of installed documentation.
2376         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
2377         file.
2378
2379 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
2380
2381         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
2382         https://bugs.webkit.org/show_bug.cgi?id=77672
2383
2384         Reviewed by Dirk Pranke.
2385
2386         Test repetitions must be taken into account when working out
2387         the statistics shown by run-webkit-tests.
2388
2389         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2390         (Manager.prepare_lists_and_print_output):
2391         (Manager._print_result_summary):
2392         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2393         (ResultSummary.__init__):
2394         (ResultSummary.add):
2395         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2396         (MainTest.test_repeat_each_iterations_num_tests):
2397
2398 2012-02-05  Dan Bernstein  <mitz@apple.com>
2399
2400         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
2401         https://bugs.webkit.org/show_bug.cgi?id=77823
2402
2403         Reviewed by Anders Carlsson.
2404
2405         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2406         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2407
2408 2012-02-04  Dan Bernstein  <mitz@apple.com>
2409
2410         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
2411         https://bugs.webkit.org/show_bug.cgi?id=77822
2412
2413         Reviewed by Sam Weinig.
2414
2415         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2416         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2417
2418 2012-02-04  Sam Weinig  <sam@webkit.org>
2419
2420         Add ability to send WKURLRequests in WebKit2 API user messages
2421         https://bugs.webkit.org/show_bug.cgi?id=77819
2422
2423         Reviewed by Anders Carlsson.
2424
2425         Add testing for round-tripping WKTypes from the UIProcess,
2426         to the WebProcess, and back.
2427
2428         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
2429           More can easily be added.
2430
2431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2432         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
2433         (TestWebKitAPI):
2434         (WebKit2UserMessageRoundTripTest):
2435         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
2436         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
2437         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
2438         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2439         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2440         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
2441         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
2442         (TestWebKitAPI::TEST_F):
2443         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
2444         (TestWebKitAPI):
2445         (UserMessageTest):
2446         (TestWebKitAPI::UserMessageTest::UserMessageTest):
2447         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
2448         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2449         (TestWebKitAPI::PlatformWebView::resizeTo):
2450         (TestWebKitAPI):
2451         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2452         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2453
2454 2012-02-04  Dan Bernstein  <mitz@apple.com>
2455
2456         <rdar://problem/10772406> WKPreferences instances cannot be copied
2457         https://bugs.webkit.org/show_bug.cgi?id=77816
2458
2459         Reviewed by Sam Weinig.
2460
2461         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2462         (TestWebKitAPI::TEST):
2463
2464 2012-02-04  Adam Barth  <abarth@webkit.org>
2465
2466         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
2467         https://bugs.webkit.org/show_bug.cgi?id=77802
2468
2469         Reviewed by Eric Seidel.
2470
2471         This patch refactors our directory grouping code into base.js where it
2472         can be shared between failures.js and notifications.js.  It then adds
2473         an Examine action to each group of failures that triggers the "results"
2474         view.
2475
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2482
2483 2012-02-04  Ojan Vafai  <ojan@chromium.org>
2484
2485         check-webkit-style is throwing an exception
2486         https://bugs.webkit.org/show_bug.cgi?id=77744
2487
2488         Reviewed by David Levin.
2489
2490         If the test_list is None, then we don't need to check for unsupported
2491         feature tests to skip.
2492
2493         * Scripts/webkitpy/layout_tests/port/webkit.py:
2494         (WebKitPort._has_test_in_directories):
2495         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2496         (test_skipped_tests_for_unsupported_features_empty_test_list):
2497
2498 2012-02-03  Adam Barth  <abarth@webkit.org>
2499
2500         List of all failures in garden-o-matic should actually list all the failures
2501         https://bugs.webkit.org/show_bug.cgi?id=77796
2502
2503         Reviewed by Eric Seidel.
2504
2505         This patch wires a bit more data into the new "All Failures" tab.  I've
2506         also iterated on how we enable this experimental feature.  The tab is
2507         still just a dumb list, but we'll make it smarter.
2508
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2513
2514 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2515
2516         Windows build fix after r106692.
2517
2518         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2519         (PortTest.test_reference_files):
2520
2521 2012-02-03  Beth Dakin  <bdakin@apple.com>
2522
2523         https://bugs.webkit.org/show_bug.cgi?id=77782
2524         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
2525         once on some pages with frames
2526         -and corresponding-
2527         <rdar://problem/10798474>
2528
2529         Reviewed by Sam Weinig.
2530
2531         One new test.
2532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2533         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
2534         (TestWebKitAPI):
2535         (TestWebKitAPI::didForceRepaint):
2536         (TestWebKitAPI::didFinishLoadForFrame):
2537         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2538         (TestWebKitAPI::setPageLoaderClient):
2539         (TestWebKitAPI::TEST):
2540         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
2541         (TestWebKitAPI):
2542         (NewFirstVisuallyNonEmptyLayoutFramesTest):
2543         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
2544         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2545         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
2546
2547 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2548
2549         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
2550         https://bugs.webkit.org/show_bug.cgi?id=77781
2551
2552         Reviewed by Eric Seidel.
2553
2554         This change fixes a couple of issues discovered while debugging
2555         test-webkitpy; both calling exit() instead of sys.exit() --
2556         which is discouraged in program code instead of the interpreter
2557         -- and a particular usage of outputcapture were stdin to get whacked
2558         and preventing debugging.
2559        
2560         This change introduces a couple of common _exit() methods that
2561         will standardize how webkit-patch exit's, in case we need to do
2562         something different in the future.
2563
2564         * Scripts/webkitpy/common/system/deprecated_logging.py:
2565         (error):
2566         * Scripts/webkitpy/common/system/outputcapture.py:
2567         (OutputCapture.assert_outputs):
2568         * Scripts/webkitpy/tool/bot/queueengine.py:
2569         (QueueEngine.exit_after_handled_error):
2570         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2571         (AbstractSequencedCommand.execute):
2572         * Scripts/webkitpy/tool/commands/queues.py:
2573         (StyleQueue.handle_script_error):
2574         * Scripts/webkitpy/tool/commands/upload.py:
2575         (MarkBugFixed.execute):
2576         * Scripts/webkitpy/tool/multicommandtool.py:
2577         (Command._exit):
2578         * Scripts/webkitpy/tool/steps/abstractstep.py:
2579         (AbstractStep._exit):
2580         * Scripts/webkitpy/tool/steps/checkstyle.py:
2581         (CheckStyle.run):
2582         * Scripts/webkitpy/tool/steps/commit.py:
2583         (Commit._check_test_expectations):
2584         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2585         (ConfirmDiff.run):
2586
2587 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2588
2589         Perf bot build fix.
2590
2591         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2592         (PerfTestsRunner._generate_json):
2593
2594 2012-02-03  Adam Barth  <abarth@webkit.org>
2595
2596         Add a blank "Expected Failures" tab to garden-o-matic
2597         https://bugs.webkit.org/show_bug.cgi?id=77793
2598
2599         Reviewed by Eric Seidel.
2600
2601         This tab will help us explore and manage our expected failures.  The
2602         tab is hidden by default via a new "experimental features" flag.
2603
2604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2609         (#unexpected):
2610         (#onebar.partytime #unexpected):
2611
2612 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2613
2614         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
2615         https://bugs.webkit.org/show_bug.cgi?id=77785
2616
2617         Fix the build bots.
2618         
2619         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
2620
2621         * Scripts/update-webkit-support-libs:
2622         (downloadExpectedVersionNumber):
2623
2624 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2625
2626         Add a Mac Lion Performance bot.
2627         https://bugs.webkit.org/show_bug.cgi?id=77765
2628
2629         Reviewed by Adam Roben.
2630
2631         This will update the master configuration in the following ways:
2632             Add a new performance slave (apple-xseve-11)
2633             Add a new Factory to download a build and run perf tests.
2634             
2635         * BuildSlaveSupport/build.webkit.org-config/config.json:
2636         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2637         (DownloadAndPerfTestFactory):
2638         (DownloadAndPerfTestFactory.__init__):
2639
2640 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2641
2642         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
2643         https://bugs.webkit.org/show_bug.cgi?id=77752
2644
2645         Reviewed by James Robinson.
2646
2647         Delete unneeded file accidentally checked in in r106481.
2648
2649         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
2650
2651 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2652
2653         Ref Tests should support plain SVG files
2654         https://bugs.webkit.org/show_bug.cgi?id=77685
2655
2656         Reviewed by Tony Chang.
2657
2658         Don't assume reference files always use .html as the extension.
2659         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
2660
2661         Also fix various bugs in MockFileSystem and TestPort.
2662
2663         * Scripts/webkitpy/common/system/filesystem_mock.py:
2664         (MockFileSystem.isdir):
2665         * Scripts/webkitpy/layout_tests/port/base.py:
2666         (Port.reference_files):
2667         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2668         (PortTest.test_is_test_file):
2669         (PortTest.test_reference_files):
2670         * Scripts/webkitpy/layout_tests/port/test.py:
2671         (TestInstance.__init__):
2672
2673 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2674
2675         perf-o-matic should store chromium svn revision
2676         https://bugs.webkit.org/show_bug.cgi?id=77725
2677
2678         Reviewed by Dirk Pranke.
2679
2680         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
2681         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
2682         is implemented in terms of newly added svn_revision.
2683
2684         * Scripts/webkitpy/common/checkout/scm/git.py:
2685         (Git.svn_revision):
2686         * Scripts/webkitpy/common/checkout/scm/scm.py:
2687         (SCM.head_svn_revision):
2688         (SCM):
2689         (SCM.svn_revision):
2690         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2691         (MockSCM.svn_revision):
2692         * Scripts/webkitpy/common/checkout/scm/svn.py:
2693         (SVN.svn_revision):
2694         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2695         (JSONLayoutResultsGenerator.__init__):
2696         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2697         (JSONResultsGeneratorBase._insert_generic_metadata):
2698         * Scripts/webkitpy/layout_tests/port/base.py:
2699         (Port.repository_paths):
2700         * Scripts/webkitpy/layout_tests/port/chromium.py:
2701         (ChromiumPort.repository_paths):
2702         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2703         (PerfTestsRunner._generate_json):
2704         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2705         (test_run_test_set_with_json_output):
2706         (test_run_test_set_with_json_source):
2707         (test_run_test_set_with_multiple_repositories):
2708
2709 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2710
2711         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
2712         https://bugs.webkit.org/show_bug.cgi?id=77632
2713
2714         Reviewed by Kenneth Rohde Christiansen.
2715
2716         * MiniBrowser/qt/BrowserWindow.cpp:
2717         (BrowserWindow::BrowserWindow):
2718         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2719         (MiniBrowserApplication::sendTouchEvent):
2720         (MiniBrowserApplication::handleUserOptions):
2721         * MiniBrowser/qt/MiniBrowserApplication.h:
2722         (WindowOptions):
2723         (WindowOptions::WindowOptions):
2724         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2725         (WTR::PlatformWebView::PlatformWebView):
2726         * WebKitTestRunner/qt/main.cpp:
2727         (main):
2728         * qmake/mkspecs/features/default_post.prf:
2729
2730 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
2731
2732         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
2733         https://bugs.webkit.org/show_bug.cgi?id=77723
2734
2735         Reviewed by Tor Arne Vestbø.
2736
2737         * Tools.pro: Compile WTR again on all platforms with WK2.
2738
2739 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
2740
2741         Ensure that inspector disabled build works
2742         https://bugs.webkit.org/show_bug.cgi?id=77604
2743
2744         Reviewed by Tor Arne Vestbø.
2745
2746         * qmake/mkspecs/features/features.prf:
2747
2748 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
2749
2750         [chromium] add support for --makeargs to the ninja-based build
2751         https://bugs.webkit.org/show_bug.cgi?id=77688
2752
2753         Reviewed by Adam Barth.
2754
2755         * Scripts/webkitdirs.pm:
2756         (buildChromiumNinja):
2757
2758 2012-02-02  Eric Seidel  <eric@webkit.org>
2759
2760         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
2761         https://bugs.webkit.org/show_bug.cgi?id=75145
2762
2763         Reviewed by Dirk Pranke.
2764
2765         * Scripts/webkitpy/layout_tests/port/mac.py:
2766         (MacPort.default_child_processes):
2767         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2768         (test_operating_system):
2769         (test_default_child_processes):
2770
2771 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
2772
2773        nrwt shouldn't blow up when there are errors in test_expectations.txt
2774        https://bugs.webkit.org/show_bug.cgi?id=73603
2775
2776        Reviewed by Ojan Vafai.
2777
2778        This change removes the distinction between 'errors' and 'warnings'
2779        in the test expectations parser. Now, any problem is a
2780        'warning', and if we are linting the file, warnings become fatal (errors).
2781
2782         This will allow a normal run-webkit-tests run to proceed even if
2783         there are bad lines.
2784
2785         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2786         (ParseError.__init__):
2787         (ParseError.__str__):
2788         (ParseError.__repr__):
2789         (TestExpectationSerializer.to_string):
2790         (TestExpectationParser._parse_modifiers):
2791         (TestExpectationParser._parse_expectations):
2792         (TestExpectationParser._check_modifiers_against_expectations):
2793         (TestExpectationParser._tokenize):
2794         (TestExpectationLine.__init__):
2795         (TestExpectationLine.is_invalid):
2796         (TestExpectationsModel.add_expectation_line):
2797         (TestExpectationsModel._already_seen_better_match):
2798         (TestExpectations.__init__):
2799         (TestExpectations._report_warnings):
2800         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2801         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2802         (assert_bad_expectations):
2803         (test_parse_warning):
2804         (test_overrides__duplicate):
2805         (ExpectationSyntaxTests.test_missing_expectation):
2806         (ExpectationSyntaxTests.test_missing_colon):
2807         (ExpectationSyntaxTests.test_too_many_colons):
2808         (ExpectationSyntaxTests.test_too_many_equals_signs):
2809         (ExpectationSyntaxTests.test_unrecognized_expectation):
2810         (SemanticTests.test_bug_format):
2811         (SemanticTests.test_bad_bugid):
2812         (SemanticTests.test_slow_and_timeout):
2813         (test_ambiguous):
2814         (test_more_modifiers):
2815         (test_order_in_file):
2816         (test_macro_overrides):
2817         (RebaseliningTest.assertRemove):
2818         (TestExpectationParserTests.test_tokenize_blank):
2819         (TestExpectationParserTests.test_tokenize_missing_colon):
2820         (TestExpectationParserTests.test_tokenize_extra_colon):
2821         (TestExpectationParserTests.test_tokenize_empty_comment):
2822         (TestExpectationParserTests.test_tokenize_comment):
2823         (TestExpectationParserTests.test_tokenize_missing_equal):
2824         (TestExpectationParserTests.test_tokenize_extra_equal):
2825         (TestExpectationParserTests.test_tokenize_valid):
2826         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2827         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2828         (TestExpectationSerializerTests.test_unparsed_to_string):
2829         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2830         (lint):
2831         * Scripts/webkitpy/style/checkers/test_expectations.py:
2832         (TestExpectationsChecker.check_test_expectations):
2833
2834 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2835
2836         Unreviewed, rolling out r106543.
2837         http://trac.webkit.org/changeset/106543
2838         https://bugs.webkit.org/show_bug.cgi?id=77671
2839
2840         Made tests less stable (Requested by rniwa on #webkit).
2841
2842         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2843         (PerfTestsRunner):
2844         (PerfTestsRunner.__init__):
2845         (PerfTestsRunner._run_tests_set):
2846         (PerfTestsRunner._run_single_test):
2847         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2848         (MainTest.TestDriver.run_test):
2849         (run_test):
2850
2851 2012-02-02  Beth Dakin  <bdakin@apple.com>
2852
2853         https://bugs.webkit.org/show_bug.cgi?id=77664
2854         Add API tests for didNewFirstVisuallyNonEmptyLayout
2855
2856         Reviewed by Darin Adler.
2857
2858         Two new tests.
2859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2860         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
2861         (TestWebKitAPI):
2862         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2863         (TestWebKitAPI::setPageLoaderClient):
2864         (TestWebKitAPI::TEST):
2865         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
2866         (TestWebKitAPI):
2867         (TestWebKitAPI::didForceRepaint):
2868         (TestWebKitAPI::didFinishLoadForFrame):
2869         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2870         (TestWebKitAPI::setPageLoaderClient):
2871         (TestWebKitAPI::TEST):
2872         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
2873         (TestWebKitAPI):
2874         (NewFirstVisuallyNonEmptyLayoutFailsTest):
2875         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
2876         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
2877         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
2878         (TestWebKitAPI):
2879         (NewFirstVisuallyNonEmptyLayoutTest):
2880         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
2881         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
2882
2883 2012-02-02  Michael Saboff  <msaboff@apple.com>
2884
2885         Add Michael Saboff to reviewers list.
2886
2887         Rubber-stamped by Gavin Barraclough.
2888
2889         * Scripts/webkitpy/common/config/committers.py:
2890
2891 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2892
2893         Add myself as a committer
2894
2895         Unreviewed
2896
2897         * Scripts/webkitpy/common/config/committers.py:
2898
2899 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2900
2901         [PerformanceTests] tests have dependencies
2902         https://bugs.webkit.org/show_bug.cgi?id=77506
2903
2904         Reviewed by Hajime Morita.
2905
2906         Load an initialization page before each test after starting a DRT so that
2907         warming up DRT won't affect the performance test results.
2908
2909         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2910         (PerfTestsRunner):
2911         (PerfTestsRunner.__init__):
2912         (PerfTestsRunner._run_tests_set):
2913         (PerfTestsRunner._run_single_test):
2914         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2915         (MainTest.TestDriver.run_test):
2916         (test_initial_page_loaded):
2917         (test_initial_page_loaded.run_test):
2918
2919 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2920
2921         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
2922
2923         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2924         (PerfTestsRunner._run_tests_set):
2925         (PerfTestsRunner._run_single_test):
2926         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2927         (create_runner):
2928         (test_run_passing_test):
2929         (test_run_silent_test):
2930         (test_run_failed_test):
2931         (test_run_tonguey_test):
2932         (test_run_timeout_test):
2933         (test_run_crash_test):
2934         (test_run_test_set_kills_drt_per_run):
2935         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2936         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
2937         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
2938
2939 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
2940
2941         Webkit generate-coverage-data script needs update to use new test script
2942         https://bugs.webkit.org/show_bug.cgi?id=77597
2943
2944         Reviewed by Dirk Schulze.
2945
2946         * Scripts/generate-coverage-data:
2947
2948 2012-02-01  Adam Barth  <abarth@webkit.org>
2949
2950         Update the tests to show that the mac-ews processes patches from
2951         non-committers.
2952
2953         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2954         (EarlyWarningSytemTest.test_committer_only_ewses):
2955         (EarlyWarningSytemTest.test_builder_ewses):
2956
2957 2012-02-01  Adam Barth  <abarth@webkit.org>
2958
2959         Mac-ews logs are huge
2960         https://bugs.webkit.org/show_bug.cgi?id=77045
2961
2962         Reviewed by Eric Seidel.
2963
2964         In order to get the cr-linux-ews bot to run tests on EC2, we created
2965         the chromium-xvfb port, which contained a number of tweaks to the
2966         Chromium port's behavior.  This patch refactors those tweaks so they
2967         can be shared with the mac-ews, mostly by moving them into the
2968         non-interactive mode of RunTests.
2969
2970         * Scripts/webkitpy/common/config/ports.py:
2971         (WebKitPort):
2972         (WebKitPort.layout_tests_results_path):
2973         (ChromiumPort.run_javascriptcore_tests_command):
2974         (ChromiumXVFBPort):
2975         (ChromiumXVFBPort.run_webkit_tests_command):
2976         * Scripts/webkitpy/common/config/ports_mock.py:
2977         (MockPort):
2978         (MockPort.layout_tests_results_path):
2979         * Scripts/webkitpy/common/config/ports_unittest.py:
2980         (WebKitPortTest.test_chromium_xvfb_port):
2981         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2982         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2983         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2984         (CommitQueueTest.test_commit_queue):
2985         (test_rollout):
2986         (test_manual_reject_during_processing):
2987         * Scripts/webkitpy/tool/steps/runtests.py:
2988         (RunTests.run):
2989         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2990         (RunTestsTest.test_no_unit_tests):
2991         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2992         (StepsTest.test_runtests_args):
2993
2994 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
2995
2996         Roll out r106442. It made some tests more stable but others less stable.
2997
2998         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2999         (PerfTestsRunner._run_tests_set):
3000         (PerfTestsRunner._run_single_test):
3001         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3002         (create_runner):
3003         (test_run_passing_test):
3004         (test_run_silent_test):
3005         (test_run_failed_test):
3006         (test_run_tonguey_test):
3007         (test_run_timeout_test):
3008         (test_run_crash_test):
3009         (test_run_test_set):
3010
3011 2012-02-01  Lucas Forschler  <lforschler@apple.com>
3012
3013         Enable EWS for non-contributers.
3014         https://bugs.webkit.org/show_bug.cgi?id=77576
3015         
3016         Reviewed by Adam Barth.
3017
3018         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3019         (MacEWS):
3020
3021 2012-02-01  Beth Dakin  <bdakin@apple.com>
3022
3023         https://bugs.webkit.org/show_bug.cgi?id=77383
3024         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
3025         -and corresponding-
3026         <rdar://problem/10709560>
3027
3028         Reviewed by Sam Weinig.
3029
3030         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
3031         for.
3032         * MiniBrowser/mac/BrowserWindowController.m:
3033         (-[BrowserWindowController awakeFromNib]):
3034         * WebKitTestRunner/TestController.cpp:
3035         (WTR::TestController::initialize):
3036
3037 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
3038
3039         TestWebKitAPI isn't being built on chromium bots any more
3040         https://bugs.webkit.org/show_bug.cgi?id=77563
3041
3042         Reviewed by Dimitri Glazkov.
3043
3044         I accidentally dropped it in the refactoring in r105449.
3045
3046         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
3047
3048 2012-02-01  Hans Wennborg  <hans@chromium.org>
3049
3050         Rename WebSpeechInputResult::set() to assign()
3051         https://bugs.webkit.org/show_bug.cgi?id=77540
3052
3053         Reviewed by Darin Fisher.
3054
3055         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3056         (MockWebSpeechInputController::addMockRecognitionResult):
3057         (MockWebSpeechInputController::speechTaskFired):
3058
3059 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3060
3061         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
3062         https://bugs.webkit.org/show_bug.cgi?id=77542
3063
3064         Reviewed by Martin Robinson.
3065
3066         * gtk/generate-gtkdoc: Check first whether there's
3067         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
3068         instead.
3069         (get_webkit2_options): Return just the options since the
3070         pkg_config_path doesn't depend on options
3071         (get_webkit1_options): Ditto.
3072         (generate_doc): Helper function to create a generator and generate
3073         documentation for the given pkg-config file with the given options.
3074         * gtk/gtkdoc.py:
3075         (GTKDoc.__init__): Don't use ** for args parameter, since it's
3076         used as a dict and never expanded.
3077         (PkgConfigGTKDoc.__init__): Ditto.
3078
3079 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3080
3081         [GTK] API documentation is not installed even when building with --enable-gtk-doc
3082         https://bugs.webkit.org/show_bug.cgi?id=77094
3083
3084         Reviewed by Martin Robinson.
3085
3086         * GNUmakefile.am: Add install-data-local and uninstall-local rules
3087         to install/uninstall WebKit1 and WebKit2 API documentation.
3088
3089 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3090
3091         Unreviewed, rolling out r106460.
3092         http://trac.webkit.org/changeset/106460
3093         https://bugs.webkit.org/show_bug.cgi?id=77552
3094
3095         It break unit tests if WEBKIT_TESTFONTS isn't defined.
3096         (Requested by Ossy on #webkit).
3097
3098         * Scripts/webkitpy/layout_tests/port/qt.py:
3099
3100 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
3101
3102         [Qt] Automatic clean build feature always do clean build with --no-webkit2
3103         https://bugs.webkit.org/show_bug.cgi?id=74519
3104
3105         Reviewed by Tor Arne Vestbø.
3106
3107         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
3108
3109         * qmake/mkspecs/features/features.prf:
3110
3111 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3112
3113         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
3114         https://bugs.webkit.org/show_bug.cgi?id=77466
3115
3116         Reviewed by Kenneth Rohde Christiansen.
3117
3118         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
3119         is set or if we should raise an error.
3120
3121         * Scripts/webkitpy/layout_tests/port/qt.py:
3122         (QtPort.setup_environ_for_server):
3123
3124 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
3125
3126         Reviewed by Martin Robinson.
3127
3128         [GTK] Improve FrameLoader signals. Resource loading
3129         https://bugs.webkit.org/show_bug.cgi?id=49543
3130
3131         Support for the new loader signals in DRT.
3132
3133         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3134         (urlPath):
3135         (willSendRequestCallback):
3136         (urlSuitableForTestResult):
3137         (descriptionSuitableForTestResult):
3138         (didReceiveResponse):
3139         (didFinishLoading):
3140         (didFailLoadingWithError):
3141         (createWebView):
3142
3143 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3144
3145         run-perf-tests should restart DRT for each test
3146         https://bugs.webkit.org/show_bug.cgi?id=77506
3147
3148         Reviewed by Adam Barth.
3149
3150         Always restart DRT when running performance tests in order to minimize the dependency between tests.
3151
3152         * Scripts/webkitpy/layout_tests/port/chromium.py:
3153         (ChromiumDriver.stop):
3154         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3155         (PerfTestsRunner._run_tests_set):
3156         (PerfTestsRunner._run_single_test):
3157         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3158         (create_runner):
3159         (test_run_passing_test):
3160         (test_run_silent_test):
3161         (test_run_failed_test):
3162         (test_run_tonguey_test):
3163         (test_run_timeout_test):
3164         (test_run_crash_test):
3165         (test_run_test_set_kills_drt_per_run):
3166         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3167         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
3168         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
3169
3170 2012-01-31  Hans Wennborg  <hans@chromium.org>
3171
3172         Speech Input: Report speech element rect relative to window rather than frame
3173         https://bugs.webkit.org/show_bug.cgi?id=76443
3174
3175         Reviewed by Darin Fisher.
3176
3177         Update LayoutTestController to allow for retrieving the speech
3178         element's position used in a request.
3179
3180         In Chromium this is handled by the MockWebSpeechInputController;
3181         adding stubs for the other implementations.
3182
3183         * DumpRenderTree/LayoutTestController.cpp:
3184         (setMockSpeechInputDumpRectCallback):
3185         (LayoutTestController::staticFunctions):
3186         * DumpRenderTree/LayoutTestController.h:
3187         (LayoutTestController):
3188         * DumpRenderTree/chromium/LayoutTestController.cpp:
3189         (LayoutTestController::LayoutTestController):
3190         (LayoutTestController::setMockSpeechInputDumpRect):
3191         * DumpRenderTree/chromium/LayoutTestController.h:
3192         (LayoutTestController):
3193         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3194         (MockWebSpeechInputController::setDumpRect):
3195         (MockWebSpeechInputController::clearResults):
3196         (MockWebSpeechInputController::startRecognition):
3197         (MockWebSpeechInputController::MockWebSpeechInputController):
3198         (makeRectResult):
3199         (MockWebSpeechInputController::speechTaskFired):
3200         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3201         (MockWebSpeechInputController):
3202         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3203         (LayoutTestController::setMockSpeechInputDumpRect):
3204         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3205         (LayoutTestController::setMockSpeechInputDumpRect):
3206         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3207         (LayoutTestController::setMockSpeechInputDumpRect):
3208         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3209         (LayoutTestController::setMockSpeechInputDumpRect):
3210         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3211         (LayoutTestController):
3212         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3213         (LayoutTestController::setMockSpeechInputDumpRect):
3214         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3215         (LayoutTestController::setMockSpeechInputDumpRect):
3216
3217 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
3218
3219         [EFL] Add basic DRT/Efl implementation to support viewport test.
3220         https://bugs.webkit.org/show_bug.cgi?id=77320
3221
3222         Reviewed by Andreas Kling.
3223
3224         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3225         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
3226
3227 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
3228
3229         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
3230         https://bugs.webkit.org/show_bug.cgi?id=77473
3231         <rdar://problem/10751357>
3232
3233         Reviewed by Darin Adler.
3234
3235         * DumpRenderTree/mac/EventSendingController.mm:
3236         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3237         * WebKitTestRunner/mac/EventSenderProxy.mm:
3238         (WTR::EventSenderProxy::keyDown):
3239         Added a new special keyDown value to test this.
3240
3241 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
3242
3243         nrwt: fix the mock port to work with DriverProxy, reftests
3244         https://bugs.webkit.org/show_bug.cgi?id=77170
3245
3246         Reviewed by Eric Seidel.
3247
3248         The DryrunPort used for benchmarking and testing NRWT has been
3249         broken since we added the DriverProxy code. It isn't really
3250         needed any more, so I've removed it.
3251
3252         The MockDRT port was also broken by DriverProxy, and moreover,
3253         never worked w/ reftests. Since we don't exercise this module in
3254         the unit tests, the code had also bitrotted some. I have cleaned
3255         it up and made it use DriverInput and DriverOutput for
3256         consistency.
3257
3258         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3259         (DryRunPort.__init__):
3260         (DryRunPort):
3261         (DryRunPort.real_name):
3262         (DryRunPort.create_driver):
3263         (DryRunPort.driver_cmd_line):
3264         (DryRunPort._driver_class):
3265         (DryrunDriver):
3266         (DryrunDriver.run_test):
3267         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3268         (MockDRTPort.create_driver):
3269         (MockChromiumDRT.run_one_test):
3270
3271 2012-01-31  Ojan Vafai  <ojan@chromium.org>
3272
3273         run-webkit-tests calls out to webkit-build-directory twice
3274         https://bugs.webkit.org/show_bug.cgi?id=77248
3275
3276         Reviewed by Dirk Pranke.
3277
3278         * Scripts/webkit-build-directory:
3279         If called with no arguments, print out both the top-level directory and the 
3280         configuration directory
3281
3282         * Scripts/webkitpy/layout_tests/port/config.py:
3283         (Config.build_directory):
3284         When called with no arguments, get and cache both the top-level and configuration directories.
3285
3286         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3287         (main):
3288         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3289         (ConfigTest.assert_configuration):
3290         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3291         (ConfigTest.test_build_directory):
3292         (ConfigTest.test_default_configuration__notfound):
3293         * Scripts/webkitpy/layout_tests/port/webkit.py:
3294         (WebKitPort._build_path):
3295         Cache the build directory in the options object so that other users
3296         of the options object don't need to call out to webkit-build-directory.
3297         Also, properly support the existing --build-directory argument.
3298
3299 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
3300
3301         Bump up the timeout for performance tests since DOM/DOMTable.html
3302         and Parser/html5-full-render.html are timing out on the bot.
3303
3304         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3305         (PerfTestsRunner._parse_args):
3306
3307 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
3308
3309         Fix the update_webgl_conformance_tests.py script in order to enable it
3310         to detect the SCM being used correctly.
3311         https://bugs.webkit.org/show_bug.cgi?id=77462
3312
3313         Reviewed by Kenneth Russell.
3314
3315         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3316         (default_out_dir):
3317
3318 2012-01-31  Eric Seidel  <eric@webkit.org>
3319
3320         webkit-patch apply-from-bug should work regardless of your CWD
3321         https://bugs.webkit.org/show_bug.cgi?id=77482
3322
3323         Reviewed by Adam Barth.
3324
3325         webkit-patch only ever works with patches made from the root
3326         directory.  We should pass the CWD to svn-apply in the case
3327         where we're running not from the webkit root.  I believe
3328         this used to work in the past and regressed.
3329
3330         * Scripts/webkitpy/common/checkout/checkout.py:
3331         (Checkout.apply_patch):
3332         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3333         (CheckoutTest.test_apply_patch):
3334
3335 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3336
3337         Unreviewed, rolling out r106302.
3338         http://trac.webkit.org/changeset/106302
3339         https://bugs.webkit.org/show_bug.cgi?id=77472
3340
3341         Broke building DRT before running the tests (Requested by ojan
3342         on #webkit).
3343
3344         * Scripts/webkit-build-directory:
3345         * Scripts/webkitpy/layout_tests/port/config.py:
3346         (Config.build_directory):
3347         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3348         (main):
3349         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3350         (ConfigTest.assert_configuration):
3351         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3352         (ConfigTest.test_build_directory):
3353         (ConfigTest.test_default_configuration__notfound):
3354         * Scripts/webkitpy/layout_tests/port/webkit.py:
3355         (WebKitPort._build_path):
3356
3357 2012-01-31  Antoine Labour  <piman@chromium.org>
3358
3359         Merge WebGraphicsContext3D creation and initialization, and move it to
3360         WebViewClient.
3361         https://bugs.webkit.org/show_bug.cgi?id=76593
3362
3363         Reviewed by Darin Fisher.
3364
3365         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3366         (TestWebPlugin::TestWebPlugin):
3367         (TestWebPlugin::initialize):
3368         * DumpRenderTree/chromium/TestWebPlugin.h:
3369         * DumpRenderTree/chromium/WebViewHost.cpp:
3370         (WebViewHost::createGraphicsContext3D):
3371         (WebViewHost::createPlugin):
3372         * DumpRenderTree/chromium/WebViewHost.h:
3373
3374 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
3375
3376         [GTK] build-webkit warning.
3377         https://bugs.webkit.org/show_bug.cgi?id=77411
3378
3379         Reviewed by Philippe Normand.
3380
3381         * Scripts/webkitdirs.pm:
3382         (isCrossCompilation):
3383
3384 2012-01-31  Dan Bernstein  <mitz@apple.com>
3385
3386         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
3387
3388         Reviewed by Anders Carlsson.
3389
3390         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3391
3392 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
3393
3394         If the QTDIR environment variable is set, the build system fails to compile WinCairo
3395         https://bugs.webkit.org/show_bug.cgi?id=77112
3396
3397         Reviewed by Daniel Bates.
3398
3399         * Scripts/webkitdirs.pm:
3400         (determineIsQt):
3401
3402 2012-01-31  Adam Roben  <aroben@apple.com>
3403
3404         Only call -typingAttributes on WebViews, not WebHTMLViews
3405
3406         Looks like this case was just missed in r105908.
3407
3408         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
3409
3410         Reviewed by Antti Koivisto.
3411
3412         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3413         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
3414         earlier.
3415
3416 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3417
3418         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
3419         https://bugs.webkit.org/show_bug.cgi?id=77221
3420
3421         Reviewed by Kenneth Rohde Christiansen.
3422
3423         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
3424
3425         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3426         (MiniBrowserApplication::sendTouchEvent):
3427
3428 2012-01-26  Hans Wennborg  <hans@chromium.org>
3429
3430         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
3431         https://bugs.webkit.org/show_bug.cgi?id=77083
3432
3433         Reviewed by Darin Fisher.
3434
3435         Add MockWebSpeechInputController which provides a mock implementation
3436         of the WebSpeechInputController interface, and use that in
3437         DumpRenderTree.
3438
3439         * DumpRenderTree/DumpRenderTree.gypi:
3440         * DumpRenderTree/chromium/LayoutTestController.cpp:
3441         (LayoutTestController::addMockSpeechInputResult):
3442         * DumpRenderTree/chromium/LayoutTestController.h:
3443         ():
3444         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
3445         (MockWebSpeechInputController::create):
3446         (MockWebSpeechInputController::addMockRecognitionResult):
3447         (MockWebSpeechInputController::clearResults):
3448         (MockWebSpeechInputController::startRecognition):
3449         (MockWebSpeechInputController::cancelRecognition):
3450         (MockWebSpeechInputController::stopRecording):
3451         (MockWebSpeechInputController::MockWebSpeechInputController):
3452         (MockWebSpeechInputController::speechTaskFired):
3453         (MockWebSpeechInputController::SpeechTask::SpeechTask):
3454         (MockWebSpeechInputController::SpeechTask::stop):
3455         (MockWebSpeechInputController::SpeechTask::runIfValid):
3456         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
3457         (WebKit):
3458         (MockWebSpeechInputController):
3459         (MockWebSpeechInputController::taskList):
3460         (SpeechTask):
3461         * DumpRenderTree/chromium/TestShell.cpp:
3462         * DumpRenderTree/chromium/WebViewHost.cpp:
3463         (WebViewHost::speechInputController):
3464         * DumpRenderTree/chromium/WebViewHost.h:
3465         (WebKit):
3466         (WebViewHost::speechInputControllerMock):
3467         (WebViewHost):
3468         ():
3469
3470 2012-01-31  Hajime Morrita  <morrita@chromium.org>
3471
3472         [PerformanceTests] Add landing html for Dromaeo dom-query test
3473         https://bugs.webkit.org/show_bug.cgi?id=77329
3474
3475         Reviewed by Ryosuke Niwa.
3476
3477         Added some more ignorable output patterns to allow warnings
3478         from a third party test suite.
3479
3480         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3481         (PerfTestsRunner):
3482         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
3483
3484 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3485
3486         [wx] Unreviewed. Update download URLs to new domain.
3487         
3488         * waf/build/build_utils.py:
3489         (update_wx_deps):
3490
3491 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3492
3493         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
3494         to the list of build directories.
3495         
3496         * waf/build/settings.py:
3497
3498 2012-01-30  Kentaro Hara  <haraken@chromium.org>
3499
3500         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
3501         output an empty method name (i.e. "()")
3502         https://bugs.webkit.org/show_bug.cgi?id=77336
3503
3504         Reviewed by Darin Adler.
3505
3506         r105797 tried to detect a change outside methods, but it causes a bug that
3507         prepare-ChangeLog can output an empty method name, like this:
3508
3509             * foo/bar/baz.cpp:
3510             (method1):
3511             ():
3512             (method2):
3513
3514         This is because the cpp parser in prepare-ChangeLog cannot distinguish
3515         '{' as the beginning of a method with '{' as the beginning of an array definition
3516         at the top level.
3517
3518             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
3519
3520             void func() { // This '{' is the beginning of a method.
3521                 ...;
3522             }
3523
3524         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
3525
3526         * Scripts/prepare-ChangeLog:
3527         (get_function_line_ranges_for_cpp): Modified as described above.
3528         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
3529         an empty method name. Ideally this should not happen but may happen, since the
3530         parsers are not perfect.
3531         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
3532         (NameSpace7):
3533         (NameSpace8):
3534         (Class109):
3535         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3536
3537 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3538
3539         run-webkit-tests calls out to webkit-build-directory twice
3540         https://bugs.webkit.org/show_bug.cgi?id=77248
3541
3542         Reviewed by Dirk Pranke.
3543
3544         This reduces to calls to webkit-build-directory to one call and
3545         saves 500ms for run-webkit-tests over a single file.
3546
3547         * Scripts/webkit-build-directory:
3548         If called with no arguments, print out both the top-level directory and the 
3549         configuration directory.
3550
3551         * Scripts/webkit-build-directory:
3552         * Scripts/webkitpy/layout_tests/port/config.py:
3553         (Config.build_directory):
3554         When called with no arguments, get and cache both the top-level and configuration directories.
3555
3556         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3557         (main):
3558         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3559         (ConfigTest.assert_configuration):
3560         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3561         (ConfigTest.test_build_directory):
3562         (ConfigTest.test_default_configuration__notfound):
3563         * Scripts/webkitpy/layout_tests/port/webkit.py:
3564         (WebKitPort._build_path):
3565         Cache the root directory in the options object so that other users
3566         of the options object don't need to call out to webkit-build-directory.
3567
3568 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3569
3570         Parsing test_expecations.txt + Skipped lists takes too long
3571         https://bugs.webkit.org/show_bug.cgi?id=77059
3572
3573         Reviewed by Dirk Pranke.
3574
3575         This saves ~100ms on the Apple Mac port.
3576         -memoize a bunch of path methods.
3577         -Avoid doing multiple disk accesses per line.
3578         -Parse the skipped list directly instead of turning it into a test_expecations.txt
3579         formatting string and parsing that.
3580
3581         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3582         (TestExpectationParser):
3583         (TestExpectationParser.expectation_for_skipped_test):
3584         (TestExpectationParser._parse_line):
3585         (TestExpectationParser._collect_matching_tests):
3586         (TestExpectations.__init__):
3587         (TestExpectations._add_skipped_tests):
3588         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3589         (test_add_skipped_tests):
3590         (test_add_skipped_tests_duplicate):
3591         * Scripts/webkitpy/layout_tests/port/base.py:
3592         (Port):
3593         (Port.test_isfile):
3594         (Port.normalize_test_name):
3595         (Port.layout_tests_dir):
3596         (Port.abspath_for_test):
3597         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3598
3599 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
3600
3601         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
3602         
3603         * Scripts/webkitpy/common/config/watchlist:
3604
3605 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
3606
3607         Unreviewed build fix following bug#76855
3608
3609         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3610         ():
3611         (TestWebKitAPI::TEST_F):
3612
3613 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3614
3615         [Qt] WKTR: Use a software rendering pipiline when running tests.
3616         https://bugs.webkit.org/show_bug.cgi?id=76708
3617
3618         Reviewed by Kenneth Rohde Christiansen.
3619
3620         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3621         (WTR::WrapperWindow::WrapperWindow):
3622         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
3623
3624 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3625
3626         [Qt] Store build config immediately instead of waiting for a successfull build
3627
3628         Otherwise we will not pick up changes to the config if the build is aborted,
3629         for example due to build errors or if the user pressed Ctrl+Z. We now write
3630         the new config before starting a build, but still defer to write the SVN
3631         revision once the build completes successfully.
3632
3633         Reviewed by Ossy.
3634
3635         * Scripts/webkitdirs.pm:
3636         (buildQMakeProjects):
3637
3638 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
3639
3640         [Qt] Add "New Window" button to the Qt MiniBrowser
3641         https://bugs.webkit.org/show_bug.cgi?id=77281
3642
3643         Reviewed by Tor Arne Vestbø.
3644
3645         * MiniBrowser/qt/BrowserWindow.cpp:
3646         (BrowserWindow::BrowserWindow):
3647         * MiniBrowser/qt/MiniBrowser.qrc:
3648         * MiniBrowser/qt/icons/plus.png: Added.
3649         * MiniBrowser/qt/qml/BrowserWindow.qml:
3650
3651 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
3652
3653         Unreviewed rolling out r106222.
3654
3655         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3656         (SingleTestRunner.__init__):
3657         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3658         (Worker.handle_test_list):
3659         * Scripts/webkitpy/layout_tests/models/test_input.py:
3660         (TestInput.__init__):
3661         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3662         (_set_up_derived_options):
3663         (parse_args):
3664         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3665         (MainTest.test_repeat_each):
3666         * WebKitTestRunner/TestInvocation.cpp:
3667         (WTR::TestInvocation::setIsPixelTest):
3668
3669 2012-01-30  Hans Wennborg  <hans@chromium.org>
3670
3671         Unreviewed, rolling out r106219.
3672         http://trac.webkit.org/changeset/106219
3673         https://bugs.webkit.org/show_bug.cgi?id=77083
3674
3675         This broke Chromium's test_shell.
3676
3677         * DumpRenderTree/DumpRenderTree.gypi:
3678         * DumpRenderTree/chromium/LayoutTestController.cpp:
3679         (LayoutTestController::addMockSpeechInputResult):
3680         * DumpRenderTree/chromium/LayoutTestController.h:
3681         (WebKit):
3682         (LayoutTestController):
3683         ():
3684         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
3685         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
3686         * DumpRenderTree/chromium/TestShell.cpp:
3687         * DumpRenderTree/chromium/WebViewHost.cpp:
3688         (WebViewHost::speechInputController):
3689         * DumpRenderTree/chromium/WebViewHost.h:
3690         (WebKit):
3691         (WebViewHost::speechInputControllerMock):
3692         (WebViewHost):
3693         ():
3694
3695 2012-01-26  Hans Wennborg  <hans@chromium.org>
3696
3697         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
3698         https://bugs.webkit.org/show_bug.cgi?id=77083
<