1 2015-11-19 Alexey Proskuryakov <ap@apple.com>
3 build.webkit.org/dashboard: Move layoutTestResultsDirectoryURLForIteration implementation to base class
4 https://bugs.webkit.org/show_bug.cgi?id=151425
6 Reviewed by Tim Horton.
8 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
9 (Buildbot.prototype.layoutTestResultsDirectoryURLForIteration):
10 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
11 (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Deleted.
13 2015-11-19 Youenn Fablet <youenn.fablet@crf.canon.fr>
15 WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
16 https://bugs.webkit.org/show_bug.cgi?id=150332
18 Reviewed by Darin Adler and Ryosuke Niwa.
20 Removing testharness.js overwriting from LayoutTests/resources to LayoutTests/imported/w3c/web-platform-tests/resources.
21 Adding support for file comparison in python filesystem.
24 * Scripts/webkitpy/common/system/filesystem.py:
25 (FileSystem.compare): Adding compare as a wrapper around filecmp.cmp.
26 * Scripts/webkitpy/common/system/filesystem_mock.py:
27 (MockFileSystem.compare): Adding a mock compare.
28 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
29 (WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
30 (WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
31 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
32 (TestWebPlatformTestServer.test_previously_spawned_instance): Updated tests to add testharness.js to mock filesystem.
33 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
35 2015-11-18 Jiewen Tan <jiewen_tan@apple.com>
37 [WK1] Crash loading Blink layout test fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
38 https://bugs.webkit.org/show_bug.cgi?id=150198
39 <rdar://problem/23136026>
41 Reviewed by Brent Fulgham.
43 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
44 (WTR::TestRunner::inspectorTestStubURL):
45 Since WebInspectorUI.framework is not available for iOS, the framework
46 and corresponding functions are disabled in iOS.
48 2015-11-18 Alexey Proskuryakov <ap@apple.com>
50 [Mac] Swipe tests depend on user preferences
51 https://bugs.webkit.org/show_bug.cgi?id=151403
53 Reviewed by Tim Horton.
55 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
56 * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
57 Override these preferences to match the default for a new OS X installation.
59 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
60 Swipe tests are not enabled in WK1, but let's override the default anyway.
62 2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
64 [GTK] Update xserver version in jhbuild
65 https://bugs.webkit.org/show_bug.cgi?id=151383
67 Reviewed by Alejandro G. Castro.
69 In r192568 I assumed the bots would have a recent enough Xvfb
70 to use the -displayfd option, but I forgot we build our own
71 xserver just for Xvfb. The version we build is too old, so
72 we could just use an updated version (the same bots have
73 installed, for example) to use the -displayfd option.
75 * gtk/jhbuild.modules: Update xserver to 1.16.4.
76 * gtk/patches/xserver-fix-glx-init.patch: Deleted.
77 * gtk/patches/xserver-remove-bogus-dependencies.patch: Updated to
80 2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
82 Unreviewed. Fix webkitpy tests after r192568.
84 Instead of ignoring exception when closing mock fds, use a helper
85 function that the unit test can override to do nothing.
87 * Scripts/webkitpy/port/xvfbdriver.py:
88 (XvfbDriver._xvfb_close_pipe):
89 (XvfbDriver._xvfb_run):
90 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
91 (XvfbDriverTest.make_driver):
93 2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
95 [XvfbDriver] Fail to run all layout tests when X server started with -displayfd option
96 https://bugs.webkit.org/show_bug.cgi?id=151135
98 Reviewed by Darin Adler.
100 The XvfbDriver uses the x server command line to check the
101 displays that are currently in use. This doesn't work when X
102 server was started with -displayfd option. This option is used to let
103 the server find the display id available that is written to the
104 given file descriptor. With this option xorg doesn't need to
105 create the lock files in tmp either. The -displayfd option is also
106 available in Xvfb, so we could use it too. That would simplify the
107 code, fixing also race conditions between the check for available
108 displays and Xvfb opening the connection, we wouldn't need to wait
109 for 4 seconds after launching Xvfb, and all lock files we are
110 using won't be needed either.
112 * Scripts/webkitpy/port/xvfbdriver.py:
113 (XvfbDriver._xvfb_pipe): Helper function to create the pipe, only
114 needed to be overriden by unit tests.
115 (XvfbDriver._xvfb_read_display_id): Helper function to read from
116 the pipe, only needed to be overriden by unit tests.
117 (XvfbDriver._xvfb_run): Run Xvfb with -displayfd option, using a
118 pipe to read the display id.
119 (XvfbDriver._start): Call _xvfb_run() and remove the code to run
120 Xvfb for a given display.
121 (XvfbDriver.stop): Remove code to release and delete file locks.
122 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
123 (XvfbDriverTest.make_driver):
124 (XvfbDriverTest.test_start):
125 (XvfbDriverTest.test_start_arbitrary_worker_number):
126 (XvfbDriverTest.test_stop):
127 (XvfbDriverTest.assertDriverStartSuccessful): Deleted.
128 (XvfbDriverTest): Deleted.
129 (XvfbDriverTest.test_stop.FakeXvfbProcess): Deleted.
131 2015-11-17 Alexey Proskuryakov <ap@apple.com>
133 run-webkit-tests should not truncate persistent lines
134 https://bugs.webkit.org/show_bug.cgi?id=151376
135 rdar://problem/23162775
137 Reviewed by Antti Koivisto.
139 It is OK to truncate progress lines, but it's not OK to truncate error (or otherwise
140 unexpected result) messages that remain on the screen to be read. In practice, this
141 almost always truncates the test path, which is important to see.
143 * Scripts/webkitpy/layout_tests/views/printing.py:
144 (Printer._test_status_line):
145 (Printer.print_finished_test):
146 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
147 (Testprinter.test_test_status_line):
149 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
151 Unreviewed. Fix GTK+ unit tests after r192469.
153 In r192469 jhbuild version was updated and coinfig lcas API changed.
155 * jhbuild/jhbuildutils.py:
156 (enter_jhbuild_environment_if_available): Pass an empty list for
157 conditions to the Config constructor.
159 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
161 Unreviewed. Use commit id instead of tag name for jhbuild revision.
163 In r192469 I updated the jhbuild version to 3.12.0, and used the
164 tag instead of the commit id to make it easier to read and
165 remember. But we use the commit id to check if the current
166 revision is up to date, and when compared to the tag id it always
167 fails and jhbuild is always updated.
169 * jhbuild/jhbuild-wrapper: Use commit id and add a comment to
170 remember this is the id of 3.12.0.
172 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
174 Unreviewed. Fix GTK+ layout tests running after r192469.
176 We fail to find the Gallium llvmpipe driver because of the build
177 directory change in r192469.
179 * gtk/jhbuildrc: Use buildroot instead of checkoutdir to build
180 the LLVMPIPE_LIBGL_PATH.
182 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
184 [GTK] Use FTL by default when LLVM 3.7 is available
185 https://bugs.webkit.org/show_bug.cgi?id=142128
187 Reviewed by Csaba Osztrogonác.
189 * Scripts/run-javascriptcore-tests: Enable FTL for GTK+ port when
190 architecture is x86_64.
191 * Scripts/update-webkit-libs-jhbuild:
192 (cleanJhbuild): Remove also the separate Build directory used by
194 * Scripts/webkitdirs.pm:
196 * Scripts/webkitperl/FeatureList.pm: Enable FTL by default for
197 GTK+ port when architecture is x86_64.
198 * gtk/jhbuild-optional.modules: Remove llvm.
199 * gtk/jhbuild.modules: Add llvm 3.7 and include it as dependecy
200 only when architecture is x86_64.
201 * gtk/jhbuildrc: Set a buildroot to use a separate build
202 directory. LLVM 3.7 fails to build if configure script is run from
203 source dir. Since it's not possible to use a separate build dir
204 only for llvm, we do it now globally. Modules not supporting non
205 source build dirs are marked in the moduleset. Also set x86_64
206 condition when the architecture is x86_64.
207 * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
208 * gtk/patches/llvm-elf-add-stackmaps.patch: Removed.
209 * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
210 * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed.
211 * jhbuild/jhbuild-wrapper: Use a newer jhbuild version to be able
214 2015-11-15 Commit Queue <commit-queue@webkit.org>
216 Unreviewed, rolling out r192462.
217 https://bugs.webkit.org/show_bug.cgi?id=151295
219 failing python tests (Requested by youenn on #webkit).
223 "WPT server should use its own testharness.js file and
224 generate a warning when it does not match WebKit version"
225 https://bugs.webkit.org/show_bug.cgi?id=150332
226 http://trac.webkit.org/changeset/192462
228 2015-11-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
230 WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
231 https://bugs.webkit.org/show_bug.cgi?id=150332
233 Reviewed by Darin Adler.
235 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
236 (WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
237 (WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
239 2015-11-14 Nan Wang <n_wang@apple.com>
241 AX: add a new trait for elements in fieldset on iOS
242 https://bugs.webkit.org/show_bug.cgi?id=151281
244 Reviewed by Chris Fleizach.
246 * DumpRenderTree/AccessibilityUIElement.cpp:
247 (assistiveTechnologySimulatedFocusCallback):
248 (fieldsetAncestorElementCallback):
249 (childAtIndexCallback):
250 (getElementTextLengthCallback):
251 (hasContainedByFieldsetTraitCallback):
252 (AccessibilityUIElement::getJSClass):
253 * DumpRenderTree/AccessibilityUIElement.h:
254 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
255 (AccessibilityUIElement::elementTextLength):
256 (AccessibilityUIElement::hasContainedByFieldsetTrait):
257 (AccessibilityUIElement::fieldsetAncestorElement):
258 (AccessibilityUIElement::url):
259 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
260 (WTR::AccessibilityUIElement::scrollPageDown):
261 (WTR::AccessibilityUIElement::scrollPageLeft):
262 (WTR::AccessibilityUIElement::scrollPageRight):
263 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
264 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
265 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
266 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
267 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
268 (WTR::AccessibilityUIElement::identifier):
269 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
270 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
271 (WTR::AccessibilityUIElement::rowCount):
273 2015-11-13 Keith Miller <keith_miller@apple.com>
275 Unreviewed, change JavaScriptCore watchlist to exclude inspector things.
277 * Scripts/webkitpy/common/config/watchlist:
279 2015-11-13 Tim Horton <timothy_horton@apple.com>
281 Support printing in WKWebView
282 https://bugs.webkit.org/show_bug.cgi?id=151276
283 <rdar://problem/23525715>
285 Reviewed by Beth Dakin.
287 * MiniBrowser/mac/MainMenu.xib:
288 * MiniBrowser/mac/WK1BrowserWindowController.m:
289 (-[WK1BrowserWindowController printWebView:]):
290 * MiniBrowser/mac/WK2BrowserWindowController.m:
291 (-[WK2BrowserWindowController printWebView:]):
292 Hook up printing to Minibrowser!
294 2015-11-13 Tim Horton <timothy_horton@apple.com>
296 Hardware keyboard spacebar scrolls too far on iOS
297 https://bugs.webkit.org/show_bug.cgi?id=151227
298 <rdar://problem/23500681>
300 Reviewed by Simon Fraser.
302 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
303 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
304 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
305 (WTR::UIScriptController::setDidEndScrollingCallback):
306 (WTR::UIScriptController::didEndScrollingCallback):
307 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
308 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
309 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
310 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
311 (-[TestRunnerWKWebView dealloc]):
312 (-[TestRunnerWKWebView _didFinishScrolling]):
313 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
314 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
315 (WTR::UIScriptController::platformClearAllCallbacks):
316 Expose _didFinishScrolling on WKWebView to the UIScriptController.
318 2015-11-13 Brent Fulgham <bfulgham@apple.com>
320 [Win] Unreviewed test fix.
322 * Scripts/webkitpy/port/win.py:
323 (WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
324 using Cygwin), but should be in DOS format for non-Cygwin clients.
326 2015-11-12 Daniel Bates <dabates@apple.com>
328 Add my apple.com email address to contributors.json
330 * Scripts/webkitpy/common/config/contributors.json:
332 2015-11-12 Daniel Bates <dabates@apple.com>
334 webkitpy: Remove extraneous word "the" from the description of command attach-to-bug
336 * Scripts/webkitpy/tool/commands/upload.py:
339 2015-11-12 Brent Fulgham <bfulgham@apple.com>
341 [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
342 https://bugs.webkit.org/show_bug.cgi?id=151156
344 Reviewed by Anders Carlsson.
346 My earlier patch was incomplete. There are some Python libraries that want
347 to receive UNIX style paths, even though all of our applications and tools
348 use DOS paths. To handle this special case, we need to track a UNIX-style
349 absolute path that can be given to things like the Python socket server.
351 When we cut over to all-native Windows Python we can get rid of this
354 * Scripts/webkitpy/common/system/filesystem.py:
355 (FileSystem.abspath): Add special code for Cygwin to convert a DOS-style
356 path into something Cygwin can use internally.
357 * Scripts/webkitpy/port/base.py:
358 (Port.results_directory): Remove custom Windows code. Instead, override
359 the method in the windows port object.
360 (Port.abs_results_directory): Add stub.
361 (Port.to.start_websocket_server): For Cygwin, use special cygwin absolute
363 * Scripts/webkitpy/port/win.py:
364 (WinPort.__init__): Added to initialze new _abs_results_directory value.
365 (WinPort.abs_results_directory): Added,
366 (WinPort.results_directory): Modified to also create a value for
367 _abs_results_directory
369 2015-11-12 Keith Miller <keith_miller@apple.com>
371 Unreviewed, add Michael Saboff to the JavaScriptCore watchlist, per request.
373 * Scripts/webkitpy/common/config/watchlist:
375 2015-11-12 Keith Miller <keith_miller@apple.com>
377 Unreviewed, add watchlist for Source/JavaScriptCore and add myself, Saam, and Mark.
379 * Scripts/webkitpy/common/config/watchlist:
381 2015-11-12 Daniel Bates <dabates@apple.com>
383 Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
384 https://bugs.webkit.org/show_bug.cgi?id=151191
386 Reviewed by Andy Estes.
388 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove hardcoded SKIP_INTALL.
389 Will override this setting in DumpRenderTree.xcconfig.
390 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: When building for iOS we now
391 compile source file DumpRenderTreeMain.mm to produce a built product and make the Apple
392 Internal build system happy. Do not waste time coping OpenType font files (*.otf files)
393 and skip installation when building for iOS since we are not interested in the build product
394 and are only building this target to make the Apple Internal build system happy.
395 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
396 (main): Added dummy implementation for iOS so that we build an actual command line tool to
397 make the Apple Internal build system happy.
398 * WebKitTestRunner/Configurations/Base.xcconfig: Add iOS-specific definition for WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
399 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Remove variable WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
400 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Build file WebKitTestRunner/mac/main.mm
401 on iOS Only to produce a built product and make the Apple Internal build system happy. No need
402 to define OTHER_LDFLAGS when building this target for iOS as the default linker flags are sufficient.
403 * WebKitTestRunner/mac/main.mm:
404 (main): Added dummy implementation for iOS so that we build an actual command line tool to
405 make the Apple Internal build system happy.
407 2015-11-12 Chris Dumez <cdumez@apple.com>
409 Unreviewed, add watchlist for history/ and add myself.
411 * Scripts/webkitpy/common/config/watchlist:
413 2015-11-12 Chris Dumez <cdumez@apple.com>
415 Unreviewed, update my watchlists.
417 * Scripts/webkitpy/common/config/watchlist:
419 2015-11-12 Daniel Bates <dabates@apple.com>
421 Rename webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() to willUseIOS{Device, Simulator}SDK()
422 https://bugs.webkit.org/show_bug.cgi?id=151207
424 Rubber-stamped by Alexey Proskuryakov.
426 The functions webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() are not specific to building
427 iOS software. We should rename these functions to webkitdirs::willUseIOS{Device, Simulator}SDK() to
428 convey their general-purpose nature of determining whether we are using the iphoneos or iphonesimulator SDK.
431 * Scripts/build-layouttestrelay:
432 * Scripts/build-webkit:
433 * Scripts/copy-webkitlibraries-to-product-directory:
434 * Scripts/run-api-tests:
436 (prepareEnvironmentForRunningTestTool):
437 * Scripts/run-javascriptcore-tests:
438 * Scripts/webkitdirs.pm:
440 (willUseIOSDeviceSDK): Formerly named willUseIOSDeviceSDKWhenBuilding.
441 (willUseIOSSimulatorSDK): Formerly name willUseIOSSimulatorSDKWhenBuilding.
444 (willUseIOSDeviceSDKWhenBuilding): Deleted.
445 (willUseIOSSimulatorSDKWhenBuilding): Deleted.
447 2015-11-12 Daniel Bates <dabates@apple.com>
449 run-api-tests fails to run with public iOS SDK
450 https://bugs.webkit.org/show_bug.cgi?id=151076
452 Reviewed by Alexey Proskuryakov.
454 Use the command line tool simctl as the sim tool was removed from the public iOS 9 SDK.
456 A side benefit of this change it is sufficient to run the tests without launching Simulator.app
457 to boot the simulator device beforehand because simctl will boot the device for us.
459 Additionally, use Perl pragma sigtrap to install signal handlers to catch SIG{HUP, INT, PIPE, TERM}
460 signals and ultimately run our END block so that we shutdown the simulator device (if applicable).
461 This makes Control-C terminate the app gracefully.
463 * Scripts/run-api-tests:
466 (prepareEnvironmentForRunningTestTool): When running for iOS Simulator use setupIOSWebKitEnvironment()
467 to setup the environment variables for iOS instead of using setupMacWebKitEnvironment(). We also
468 prefix the name of these environment variables with "SIMCTL_CHILD_" so that simctl sets these environment
469 variables in the simulator environment.
470 * Scripts/webkitdirs.pm:
471 (shutDownIOSSimulatorDevice): Added.
472 (restartIOSSimulatorDevice): Added.
474 2015-11-12 KwangHyuk Kim <hyuki.kim@samsung.com>
476 [EFL] fix EvasGL configuration error
477 https://bugs.webkit.org/show_bug.cgi?id=151180
479 Reviewed by Csaba Osztrogonác.
481 EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet.
482 Additionally, duplicated elm_config_accel_preference_set() call is eleminated.
484 * MiniBrowser/efl/main.c:
488 2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
490 [EFL] Fix EFL 1.16 with enabled NEON support
491 https://bugs.webkit.org/show_bug.cgi?id=151188
493 Unreviewed buildfix, disable NEON temporarily after r192358.
495 * efl/jhbuild.modules:
497 2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
499 [EFL] Bump EFL version to 1.16.0
500 https://bugs.webkit.org/show_bug.cgi?id=150228
502 Reviewed by Gyuyoung Kim.
504 * efl/jhbuild.modules:
505 * efl/patches/efl-remove-XPrint.patch: Removed.
507 2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
509 Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
510 https://bugs.webkit.org/show_bug.cgi?id=150972
512 Reviewed by Darin Adler.
514 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
516 2015-11-12 KwangHyuk Kim <hyuki.kim@samsung.com>
518 [EFL] fix EvasGL configuration error
519 https://bugs.webkit.org/show_bug.cgi?id=151180
521 Reviewed by Gyuyoung Kim.
523 EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet
525 * MiniBrowser/efl/main.c:
528 2015-11-11 Brent Fulgham <bfulgham@apple.com>
530 [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
531 https://bugs.webkit.org/show_bug.cgi?id=151156
533 Reviewed by Anders Carlsson.
535 * Scripts/webkitpy/port/base.py:
536 (Port.results_directory): Don't pass paths through 'abspath'
537 (Port._build_path): Ditto.
538 * Scripts/webkitpy/port/win.py:
539 (WinPort._build_path): Ditto.
541 2015-11-11 Akos Kiss <akiss@inf.u-szeged.hu>
543 Unreviewed, add myself to the committers list.
545 * Scripts/webkitpy/common/config/contributors.json:
547 2015-11-11 Anders Carlsson <andersca@apple.com>
549 _WKRemoteObjectInterface should handle specifying allowed classes for reply block arguments
550 https://bugs.webkit.org/show_bug.cgi?id=151144
552 Reviewed by Tim Horton.
554 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
555 (remoteObjectInterface):
556 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
558 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
559 (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
560 (-[RemoteObjectRegistryPlugIn selectionAndClickInformationForClickAtPoint:completionHandler:]):
562 2015-11-10 Wenson Hsieh <wenson_hsieh@apple.com>
564 UI-side scripts in WebKitTestRunner should wait until event handling completes before finishing
565 https://bugs.webkit.org/show_bug.cgi?id=151101
566 <rdar://problem/23428601>
568 Reviewed by Simon Fraser.
570 WebKitTestRunner may still crash in the scenario where a marker event is dequeued and handled
571 after uiScriptComplete has been called. This patch teaches the UI script execution context to
572 defer script completion until all non-persistent tasks (currently tap, double tap and hardware
573 keyboard) have been handled, so marker events will no longer bleed through tests.
575 We accomplish this by changing the behavior of uiScriptComplete. When calling uiScriptComplete,
576 we store that a request to complete the UI-side script for the current parent callback has been
577 made. Subsequently, when a callback (either persistent or non-persistent) finishes invoking and
578 a request has been made to complete the UI script (this request may have been made when running
579 a previous callback) we check if all the non-persistent callbacks that have the same parent
580 callback as the current one have finished. If so, we complete the callback immediately;
581 otherwise, we wait until the in-flight non-persistent callbacks finish execution to complete the
584 This patch also refactors some logic in UIScriptContext. It introduces a new convention for
585 assigning IDs to callbacks: IDs 1000 and above are treated as non-persistent callbacks, whereas
586 IDs between 0 and 999 are persistent task callbacks. This is similar to the existing convention
587 for assigning IDs in the 100s range to parent callbacks, and allows us to easily differentiate
588 between callbacks that are persistent and non-persistent, as well as determine when an existing
589 persistent callback must be unregistered before a new callback function can be set.
591 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
592 (isPersistentCallbackID):
593 (UIScriptContext::runUIScript):
594 (UIScriptContext::nextTaskCallbackID):
595 (UIScriptContext::prepareForAsyncTask):
596 (UIScriptContext::asyncTaskComplete):
597 (UIScriptContext::registerCallback):
598 (UIScriptContext::fireCallback):
599 (UIScriptContext::requestUIScriptCompletion):
600 (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
601 (UIScriptContext::currentParentCallbackHasOutstandingAsyncTasks):
602 (UIScriptContext::uiScriptComplete): Deleted.
603 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
604 (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
605 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
606 (WTR::UIScriptController::setWillBeginZoomingCallback):
607 (WTR::UIScriptController::willBeginZoomingCallback):
608 (WTR::UIScriptController::setDidEndZoomingCallback):
609 (WTR::UIScriptController::didEndZoomingCallback):
610 (WTR::UIScriptController::setDidShowKeyboardCallback):
611 (WTR::UIScriptController::didShowKeyboardCallback):
612 (WTR::UIScriptController::setDidHideKeyboardCallback):
613 (WTR::UIScriptController::didHideKeyboardCallback):
614 (WTR::UIScriptController::uiScriptComplete):
615 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
616 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
617 (WTR::UIScriptController::doAsyncTask):
618 (WTR::UIScriptController::zoomToScale):
619 (WTR::UIScriptController::singleTapAtPoint):
620 (WTR::UIScriptController::doubleTapAtPoint):
621 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
622 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
623 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
624 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
625 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
626 (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
627 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
628 (WTR::UIScriptController::doAsyncTask):
630 2015-11-10 Daniel Bates <dabates@apple.com>
632 Teach Makefile to build LayoutTestRelay when building for iOS Simulator
633 https://bugs.webkit.org/show_bug.cgi?id=150849
635 Reviewed by Alexey Proskuryakov.
637 Unless variable DO_NOT_BUILD_LAYOUT_TEST_RELAY is non-empty, build LayoutTestRelay when
638 building WebKit tools.
642 2015-11-10 David Kilzer <ddkilzer@apple.com>
644 [check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members
645 <http://webkit.org/b/104417>
647 Reviewed by Brent Fulgham.
649 * Scripts/webkitpy/style/checkers/cpp.py:
650 (_EnumState.process_clean_line): Allow 'k' to start enums.
651 (check_enum_casing): Update error message to discuss 'k'.
652 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
653 (NoNonVirtualDestructorsTest.test_enum_casing): Update error
654 messages, and add new tests for enums that start with lowercase
657 2015-11-10 Geoffrey Garen <ggaren@apple.com>
659 run-jsc-benchmarks doesn't work with internal benchmarks
660 https://bugs.webkit.org/show_bug.cgi?id=151047
662 Reviewed by Filip Pizlo.
664 * Scripts/run-jsc-benchmarks: Use Pathname so we get a "/" inserted when
667 2015-11-10 Carlos Garcia Campos <cgarcia@igalia.com>
669 [GTK] Use CROSS_PLATFORM_CONTEXT_MENUS
670 https://bugs.webkit.org/show_bug.cgi?id=150642
672 Reviewed by Martin Robinson.
674 Remove test for input methods submenu.
676 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
678 2015-11-09 Joonghun Park <jh718.park@samsung.com>
680 Unreviewed, add myself to the committers list.
682 * Scripts/webkitpy/common/config/contributors.json:
684 2015-11-09 Ryuan Choi <ryuan.choi@navercorp.com>
686 [EFL] Crash while opening child webview with EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
687 https://bugs.webkit.org/show_bug.cgi?id=145924
689 Reviewed by Gyuyoung Kim.
691 * MiniBrowser/efl/main.c:
694 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
695 (TestWebKitAPI::TEST):
696 * TestWebKitAPI/efl/PlatformWebView.cpp:
697 (TestWebKitAPI::PlatformWebView::PlatformWebView):
698 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
699 (WTR::PlatformWebView::PlatformWebView):
701 2015-11-09 Anders Carlsson <andersca@apple.com>
703 Add reply blocks to _WKRemoteObjectInterface similar to NSXPCConnection
704 https://bugs.webkit.org/show_bug.cgi?id=151056
705 rdar://problem/23222609
707 Reviewed by Tim Horton.
711 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
713 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
714 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
716 2015-11-09 Tim Horton <timothy_horton@apple.com>
718 Add drawsBackground SPI to WKWebView, and get rid of drawsTransparentBackground from WebKit2
719 https://bugs.webkit.org/show_bug.cgi?id=151054
720 <rdar://problem/22907994>
722 Reviewed by Simon Fraser.
724 * MiniBrowser/mac/WK1BrowserWindowController.m:
725 (-[WK1BrowserWindowController didChangeSettings]):
726 * MiniBrowser/mac/WK2BrowserWindowController.m:
727 (-[WK2BrowserWindowController didChangeSettings]):
728 Use drawsBackground instead, and make sure to set the window background color,
729 otherwise it might end up being gray anyway!
731 WebKit1 still doesn't work unless you turn off toolbar blurring, but at least
732 WebKit2 is working now!
734 2015-11-09 Isaac Devine <isaac@devinesystems.co.nz>
736 Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h
737 https://bugs.webkit.org/show_bug.cgi?id=151013
739 Use the variable defined in the CMake scripts to determine the cairo include location, rather
740 than relying on a environment variable to be set correctly. Otherwise the DumpRenderTreeLib.vcxproj will
741 contain "\include\cairo" rather than the fully qualified path to the cairo include location.
743 Reviewed by Darin Adler.
745 * DumpRenderTree/PlatformWin.cmake:
747 2015-11-09 Csaba Osztrogonác <ossy@webkit.org>
749 [EFL] Fix the gst-plugins-bad jhbuild module build on Ubuntu 15.10
750 https://bugs.webkit.org/show_bug.cgi?id=150928
752 Reviewed by Gyuyoung Kim.
754 * efl/jhbuild.modules:
756 2015-11-07 Daniel Bates <dabates@apple.com>
758 Attempt to fix the Windows EWS bot after r192087
759 (https://bugs.webkit.org/show_bug.cgi?id=150859)
761 Following r192087 Port._build_path() stores the computed root directory path in option
762 _cached_root instead of overwriting option root. We need to teach the Windows-specific
763 logic to make use of option _cached_root instead of option root when computing its adjusted
764 path and to cache its adjusted in _cached_root instead of root.
766 * Scripts/webkitpy/port/win.py:
767 (WinPort._build_path):
769 2015-11-06 Daniel Bates <dabates@apple.com>
771 Do not build LayoutTestRelay when --root is specified to run-webkit-tests
772 https://bugs.webkit.org/show_bug.cgi?id=150989
774 Reviewed by Alexey Proskuryakov.
776 The script run-webkit-tests should only check if LayoutTestRelay exists when invoked with
777 --root and exit with an error if it does not exist. That is, we should not build LayoutTestRelay
778 when it does not exist and an explicit directory of built executables was specified via --root.
779 This will make the criterion for building LayoutTestRelay match the criterion for building
780 DumpRenderTree/WebKitTestRunner.
782 * Scripts/webkitpy/port/ios.py:
783 (IOSSimulatorPort._check_port_build): Moved logic from IOSSimulatorPort.{_check_build_relay, check_build} to here.
784 (IOSSimulatorPort._check_build_relay): Deleted.
785 (IOSSimulatorPort.check_build): Deleted.
787 2015-11-06 Tim Horton <timothy_horton@apple.com>
789 Add preliminary (SPI) support for NSTextFinder on WKWebView
790 https://bugs.webkit.org/show_bug.cgi?id=150907
791 <rdar://problem/19171624>
793 Reviewed by Darin Adler.
795 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
796 * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Added.
797 (-[FindInPageNavigationDelegate webView:didFinishNavigation:]):
801 * WebEditingTester/WK1WebDocumentController.m:
802 * WebEditingTester/WK2WebDocumentController.m:
803 (-[WK2WebDocumentController awakeFromNib]):
804 (-[WK2WebDocumentController contentView]):
805 Use incremental find, and show the overlay/indicator.
807 2015-11-06 Alexey Proskuryakov <ap@apple.com>
809 iOS test results are not visible on the flakiness dashboard
810 https://bugs.webkit.org/show_bug.cgi?id=150884
812 Reviewed by Darin Adler.
814 One more change was needed for the minimal fix.
816 * TestResultServer/static-dashboards/flakiness_dashboard.js:
818 2015-11-06 Daniel Bates <dabates@apple.com>
820 Teach Makefile to build LayoutTestRelay when building for iOS Simulator
821 https://bugs.webkit.org/show_bug.cgi?id=150849
823 Reviewed by Alexey Proskuryakov.
825 Override the user-specified arguments SDKROOT and ARCHS to use the default SDK
826 and default ARCHS since LayoutTestRelay is a Mac command line tool.
828 * LayoutTestRelay/Makefile: Define OVERRIDE_SDKROOT and OVERRIDE_ARCHS.
830 2015-11-05 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
832 Add runtime and compile time flags for enabling Web Animations API and model.
833 https://bugs.webkit.org/show_bug.cgi?id=150914
835 Reviewed by Benjamin Poulain.
837 Add ENABLE_WEB_ANIMATIONS compile time flag, runtime flag webAnimationsEnabled and Expose WK2 preference for runtime flag.
839 * Scripts/webkitperl/FeatureList.pm:
841 2015-11-05 Ryuan Choi <ryuan.choi@navercorp.com>
843 [EFL] Separate beforeunload confirm callback from confirm callback
844 https://bugs.webkit.org/show_bug.cgi?id=150964
846 Reviewed by Gyuyoung Kim.
848 * MiniBrowser/efl/main.c:
849 (on_javascript_before_unload_confirm):
852 2015-11-05 Jason Marcell <jmarcell@apple.com>
854 run-webkit-test should look in --root directory for LayoutTestRelay
855 https://bugs.webkit.org/show_bug.cgi?id=150859
857 Reviewed by Daniel Bates.
859 For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
860 LayoutTestRelay in the Mac build directory when --root is unspecified.
862 * Scripts/webkitpy/port/base.py:
863 (Port._build_path): Use '_cached_root' instead of 'root' so that we don't overwrite the
864 argument that was passed in via the --root argument.
865 * Scripts/webkitpy/port/ios.py:
866 (IOSSimulatorPort.relay_path):
868 2015-11-05 David Kilzer <ddkilzer@apple.com>
870 TestWebKitAPI crashed in TestWebKitAPI: TestWebKitAPI::SharedBufferTest_copyBufferCreatedWithContentsOfExistingFile_Test::TestBody
871 <http://webkit.org/b/150931>
872 <rdar://problem/23409384>
874 Reviewed by Youenn Fablet.
876 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
877 (TestWebKitAPI::TEST_F(SharedBufferTest, copyBufferCreatedWithContentsOfExistingFile)):
878 - Switch from strnstr() to memcmp() since strings are
879 not guaranteed to be NULL-terminated.
880 - Add another expectation that the size is greater than
881 zero since memcmp() returns 0 (matching) if the length
883 (TestWebKitAPI::TEST_F(SharedBufferTest, appendBufferCreatedWithContentsOfExistingFile)):
884 - Same change to keep tests consistent, although the
885 second string is NULL-terminated in this case.
887 2015-11-05 Commit Queue <commit-queue@webkit.org>
889 Unreviewed, rolling out r192073.
890 https://bugs.webkit.org/show_bug.cgi?id=150962
892 "Broke the internal iOS build; will investigate offline"
893 (Requested by dydz on #webkit).
897 "Teach Makefile to build LayoutTestRelay when building for iOS
899 https://bugs.webkit.org/show_bug.cgi?id=150849
900 http://trac.webkit.org/changeset/192073
902 2015-11-05 Daniel Bates <dabates@apple.com>
904 Teach Makefile to build LayoutTestRelay when building for iOS Simulator
905 https://bugs.webkit.org/show_bug.cgi?id=150849
907 Reviewed by Alexey Proskuryakov.
909 * LayoutTestRelay/Makefile: Temporarily override SDKROOT when it is iphonesimulator so
910 that we build with the default SDK. We assume that the default SDK is the OS X SDK.
911 * Makefile: Append LayoutTestRelay to the list of modules to build when building with
914 2015-11-05 Ryuan Choi <ryuan.choi@navercorp.com>
916 [EFL] Add try_close API to handle beforeunload event
917 https://bugs.webkit.org/show_bug.cgi?id=150705
919 Reviewed by Gyuyoung Kim.
921 * MiniBrowser/efl/main.c:
922 (on_window_deletion):
923 Call ewk_view_try_close instead of removing object directly.
924 (window_create): Fixed that passes wrong data.
926 2015-11-04 Wenson Hsieh <wenson_hsieh@apple.com>
928 Fix crashing and flaky UIScriptController-based tests in fast/events/ios
929 https://bugs.webkit.org/show_bug.cgi?id=150901
930 <rdar://problem/23261499>
932 Reviewed by Simon Fraser.
934 Clear out zooming and keyboard-related callbacks after uiScriptComplete has been invoked. This prevents
935 later tests from calling into code which previous tests attached to these callbacks and causing
936 WebKitTestRunner to crash due to accessing a deallocated UIScriptController.
938 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
939 (WTR::UIScriptController::platformClearAllCallbacks):
940 (WTR::UIScriptController::uiScriptComplete):
941 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
942 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
943 (WTR::UIScriptController::platformClearAllCallbacks):
945 2015-11-04 Jer Noble <jer.noble@apple.com>
947 [iOS] <video> elements without audio tracks should not interrupt music
948 https://bugs.webkit.org/show_bug.cgi?id=149888
950 Reviewed by Eric Carlson.
952 Add tests to ensure that the AVAudioSession category is correctly set when playing
953 back media both with and without audio tracks.
955 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
956 * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Added.
957 (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
958 (TestWebKitAPI::TEST):
959 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Added.
960 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Added.
961 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Added.
962 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Added.
964 2015-11-04 Alexey Proskuryakov <ap@apple.com>
966 iOS test results are not visible on the flakiness dashboard
967 https://bugs.webkit.org/show_bug.cgi?id=150884
969 Reviewed by Darin Adler.
971 Re-generated builders.jsonp using generate_builders_json.py.
973 I think that this is all that's needed for basic support. There is more work needed
974 to display test expectations, but that's already mostly broken even for Mac.
976 * TestResultServer/static-dashboards/builders.jsonp:
978 2015-11-03 Commit Queue <commit-queue@webkit.org>
980 Unreviewed, rolling out r191995.
981 https://bugs.webkit.org/show_bug.cgi?id=150880
983 Broke iOS tests (Requested by ap on #webkit).
987 "run-webkit-test should look in --root directory for
989 https://bugs.webkit.org/show_bug.cgi?id=150859
990 http://trac.webkit.org/changeset/191995
992 2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
994 Add graphics benchmark to performance bot
995 https://bugs.webkit.org/show_bug.cgi?id=150450
997 Reviewed by Chris Dumez.
999 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Added.
1000 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Added.
1001 Add a patch and a plan to set the defaults of the benchmark, run it,
1002 collect the result and report it to the benchmark runner.
1004 2015-11-03 Jason Marcell <jmarcell@apple.com>
1006 run-webkit-test should look in --root directory for LayoutTestRelay
1007 https://bugs.webkit.org/show_bug.cgi?id=150859
1009 Reviewed by Daniel Bates.
1011 For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
1012 LayoutTestRelay in the Mac build directory when --root is unspecified.
1014 * Scripts/webkitpy/port/ios.py:
1015 (IOSSimulatorPort.relay_path):
1017 2015-11-03 Alexey Proskuryakov <ap@apple.com>
1019 build.webkit.org/dashboard should use ISO dates in Trac URLs
1020 https://bugs.webkit.org/show_bug.cgi?id=150855
1022 Reviewed by Darin Adler.
1024 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1025 (Trac.prototype._xmlTimelineURL):
1027 2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
1029 Unreviewed, add myself to the SVG watchlist.
1031 * Scripts/webkitpy/common/config/watchlist:
1033 2015-11-03 Wenson Hsieh <wenson_hsieh@apple.com>
1035 Fix touch event sending crash in WebKitTestRunner
1036 https://bugs.webkit.org/show_bug.cgi?id=150848
1037 <rdar://problem/23360841>
1039 Reviewed by Simon Fraser.
1041 Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
1043 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1044 (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
1046 2015-11-03 Brent Fulgham <bfulgham@apple.com>
1048 [Win] Unreviewed build fix after r191958.
1050 * MiniBrowser/win/MiniBrowser.h: Add missing include.
1051 * MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
1053 2015-11-02 Jiewen Tan <jiewen_tan@apple.com>
1055 Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
1057 * Scripts/webkitpy/common/config/contributors.json:
1059 2015-11-03 Csaba Osztrogonác <ossy@webkit.org>
1061 Unreviewed, add unittest after r191827.
1063 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1065 2015-11-02 Andy Estes <aestes@apple.com>
1067 [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
1068 https://bugs.webkit.org/show_bug.cgi?id=150819
1070 Reviewed by Dan Bernstein.
1072 This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
1074 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1075 * MiniBrowser/Configurations/Base.xcconfig:
1076 * TestWebKitAPI/Configurations/Base.xcconfig:
1077 * WebKitTestRunner/Configurations/Base.xcconfig:
1079 2015-11-02 Anders Carlsson <andersca@apple.com>
1081 Begin work on supporting reply blocks in _WKRemoteObjectRegistry
1082 https://bugs.webkit.org/show_bug.cgi?id=150739
1084 Reviewed by Tim Horton.
1086 Add a test. We only test the encoding right now.
1088 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1089 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1091 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1092 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
1094 2015-11-02 Tim Horton <timothy_horton@apple.com>
1096 Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
1097 https://bugs.webkit.org/show_bug.cgi?id=150174
1099 Reviewed by Anders Carlsson.
1101 * WebKitTestRunner/mac/EventSenderProxy.mm:
1102 (WTR::EventSenderProxy::mouseUp):
1103 (WTR::EventSenderProxy::mouseMoveTo):
1104 Revert some parts of r188828 which no longer apply.
1106 2015-10-30 Dana Burkart <dburkart@apple.com>
1108 svn-apply should handle unified diffs
1109 https://bugs.webkit.org/show_bug.cgi?id=150650
1111 Reviewed by Darin Adler.
1113 * Scripts/VCSUtils.pm:
1114 (parseUnifiedDiffHeader):
1115 This method parses a unified diff header, and returns a information in the
1116 style of parseGitDiffHeader and parseSvnDiffHeader.
1119 Teach parseDiffHeader to recognize unified diff headers.
1122 Teach parseDiff to recognize unified diffs.
1124 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1125 * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
1127 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1129 Fix the FTL JIT build with system LLVM on Linux
1130 https://bugs.webkit.org/show_bug.cgi?id=150795
1132 Reviewed by Filip Pizlo.
1134 * efl/install-dependencies:
1135 * gtk/install-dependencies:
1137 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1139 [EFL] Bump harfbuzz versions to 0.9.35
1140 https://bugs.webkit.org/show_bug.cgi?id=150448
1142 Reviewed by Gyuyoung Kim.
1144 * efl/jhbuild.modules:
1146 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1148 [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
1149 https://bugs.webkit.org/show_bug.cgi?id=150622
1151 Reviewed by Gyuyoung Kim.
1153 * efl/install-dependencies:
1154 * efl/jhbuild.modules:
1156 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1158 Fix EFL jhbuild module build on Ubuntu 15.10
1159 https://bugs.webkit.org/show_bug.cgi?id=150621
1161 Reviewed by Gyuyoung Kim.
1163 * efl/jhbuild.modules:
1164 * efl/patches/efl-remove-XPrint.patch: Added.
1166 2015-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
1168 [GLIB] Remove delete on destroy GMainLoopSources
1169 https://bugs.webkit.org/show_bug.cgi?id=150771
1171 Reviewed by Žan Doberšek.
1173 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
1174 (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
1175 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1176 (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
1178 2015-11-01 Yusuke Suzuki <utatane.tea@gmail.com>
1180 [ES6] Support Generator Syntax
1181 https://bugs.webkit.org/show_bug.cgi?id=150769
1183 Reviewed by Geoffrey Garen.
1185 Added ENABLE_ES6_GENERATORS flag.
1187 * Scripts/webkitperl/FeatureList.pm:
1189 2015-11-01 Alexey Proskuryakov <ap@apple.com>
1191 Sort EWS bots in popovers
1192 https://bugs.webkit.org/show_bug.cgi?id=150782
1194 Reviewed by Darin Adler.
1196 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1197 (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1199 2015-10-31 Filip Pizlo <fpizlo@apple.com>
1201 B3::reduceStrength's DCE should be more agro and less wrong
1202 https://bugs.webkit.org/show_bug.cgi?id=150748
1204 Reviewed by Geoffrey Garen.
1206 Add an LLVM version of testb3's "testComplex".
1208 * ReducedFTL/ComplexTest.cpp: Added.
1210 2015-11-01 Commit Queue <commit-queue@webkit.org>
1212 Unreviewed, rolling out r191831.
1213 https://bugs.webkit.org/show_bug.cgi?id=150774
1215 The new test fails (Requested by ap on #webkit).
1219 "Begin work on supporting reply blocks in
1220 _WKRemoteObjectRegistry"
1221 https://bugs.webkit.org/show_bug.cgi?id=150739
1222 http://trac.webkit.org/changeset/191831
1224 2015-10-31 Andreas Kling <akling@apple.com>
1226 Add a debug overlay with information about web process resource usage.
1227 <https://webkit.org/b/150599>
1229 Reviewed by Darin Adler.
1231 Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
1233 * MiniBrowser/mac/SettingsController.h:
1234 * MiniBrowser/mac/SettingsController.m:
1235 (-[SettingsController _populateMenu]):
1236 (-[SettingsController validateMenuItem:]):
1237 (-[SettingsController toggleShowResourceUsageOverlay:]):
1238 (-[SettingsController resourceUsageOverlayVisible]):
1239 * MiniBrowser/mac/WK2BrowserWindowController.m:
1240 (-[WK2BrowserWindowController didChangeSettings]):
1242 2015-10-31 Lucas Forschler <lforschler@apple.com>
1244 Teach the CompileWebKit step to look for additional arguments.
1246 Unreviewed config change.
1248 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1249 (CompileWebKit.start):
1251 2015-10-30 Anders Carlsson <andersca@apple.com>
1253 Begin work on supporting reply blocks in _WKRemoteObjectRegistry
1254 https://bugs.webkit.org/show_bug.cgi?id=150739
1256 Reviewed by Tim Horton.
1258 Add a test. We only test the encoding right now.
1260 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1261 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1263 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1264 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
1266 2015-10-30 Lucas Forschler <lforschler@apple.com>
1268 Add CMAke builder to build.webkit.org
1269 https://bugs.webkit.org/show_bug.cgi?id=150738
1271 Reviewed by Alex Christensen.
1273 * BuildSlaveSupport/build.webkit.org-config/config.json:
1275 2015-10-30 Brent Fulgham <bfulgham@apple.com>
1277 [Win] build-jsc and run-javascriptcore-tests do not work
1278 https://bugs.webkit.org/show_bug.cgi?id=150700
1280 Reviewed by Mark Lam.
1282 Correct our build system so that it expects Windows to be using CMake,
1283 and to build the correct sub-projects for our JSC helper scripts.
1285 * Scripts/build-jsc: Make sure to build the testapi harness when
1286 building for Windows.
1287 * Scripts/build-webkit:
1288 (1) Use the existing 'cmakeBasedPortName()'
1289 (2) Use File::Spec rather than hard-coding path delimeters.
1290 (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
1291 method rather than hard-coding the name based on conditional.
1292 * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
1293 LLVM libraries on Apple Windows build.
1294 * Scripts/run-javascriptcore-tests:
1295 (testapiPath): Use File::Spec rather than hard-coding path delimeters.
1296 * Scripts/run-jsc: Ditto.
1297 * Scripts/webkitdirs.pm:
1298 (cmakeBasedPortName): Update to return the right value for the Apple
1299 Windows port and the WinCairo port.
1300 (isCMakeBuild): Expect CMake build for all Windows ports.
1302 2015-10-30 Carlos Garcia Campos <cgarcia@igalia.com>
1304 [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
1305 https://bugs.webkit.org/show_bug.cgi?id=150665
1307 Reviewed by Csaba Osztrogonác.
1309 We check it only to wipe the directory or not, but we are still
1310 tryihng to update every module even when the configuration hasn't
1311 changed. This is problematic because it makes the whole build fail
1312 when any repository fails to checkout an already checked out
1313 revision, because the server is down for example. This is even
1314 more problematic for the bots that skip perfectly valid revisions.
1315 It's still possible to force an update passing --force command
1318 * Scripts/update-webkit-libs-jhbuild:
1319 (deleteJhbuildMd5): Delete the md5sum files if exist.
1320 (runJhbuild): Return early if the md5sum files haven't
1321 changed. Only write them after a successful build and delete them
1322 if the build fails to ensure we don't skip next run.
1324 2015-10-30 Philippe Normand <pnormand@igalia.com>
1326 [GTK] Fix MacCLang build errors in Tools
1327 https://bugs.webkit.org/show_bug.cgi?id=150031
1329 Reviewed by Carlos Garcia Campos.
1331 * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
1332 * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
1333 * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
1334 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
1336 2015-10-29 Hunseop Jeong <hs85.jeong@samsung.com>
1338 [EFL] MiniBrowser didn't work after r191749.
1339 https://bugs.webkit.org/show_bug.cgi?id=150706
1341 Reviewed by Alex Christensen.
1343 Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
1345 * Scripts/run-minibrowser:
1347 2015-10-29 Commit Queue <commit-queue@webkit.org>
1349 Unreviewed, rolling out r191766.
1350 https://bugs.webkit.org/show_bug.cgi?id=150707
1352 Problem with Cygwin build (Requested by bfulgham_ on #webkit).
1356 "[Win] build-jsc and run-javascriptcore-tests do not work"
1357 https://bugs.webkit.org/show_bug.cgi?id=150700
1358 http://trac.webkit.org/changeset/191766
1360 2015-10-29 Brent Fulgham <bfulgham@apple.com>
1362 [Win] build-jsc and run-javascriptcore-tests do not work
1363 https://bugs.webkit.org/show_bug.cgi?id=150700
1365 Reviewed by Mark Lam.
1367 Correct our build system so that it expects Windows to be using CMake,
1368 and to build the correct sub-projects for our JSC helper scripts.
1370 * Scripts/build-jsc: Make sure to build the testapi harness when
1371 building for Windows.
1372 * Scripts/build-webkit:
1373 (1) Use the existing 'cmakeBasedPortName()'
1374 (2) Use File::Spec rather than hard-coding path delimeters.
1375 (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
1376 method rather than hard-coding the name based on conditional.
1377 * Scripts/run-javascriptcore-tests:
1378 (testapiPath): Use File::Spec rather than hard-coding path delimeters.
1379 * Scripts/run-jsc: Ditto.
1380 * Scripts/webkitdirs.pm:
1381 (cmakeBasedPortName): Update to return the right value for the Apple
1382 Windows port and the WinCairo port.
1383 (isCMakeBuild): Expect CMake build for all Windows ports.
1385 2015-10-29 Alex Christensen <achristensen@webkit.org>
1387 Fix build-jsc on Mac after r191749.
1389 * Scripts/build-jsc:
1390 Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
1392 2015-10-29 Alex Christensen <achristensen@webkit.org>
1395 https://bugs.webkit.org/show_bug.cgi?id=150686
1397 Reviewed by Filip Pizlo.
1399 * Scripts/build-webkit:
1400 * Scripts/webkitdirs.pm:
1401 (isCachedArgumentfileOutOfDate):
1402 (wrapperPrefixIfNeeded):
1403 (generateBuildSystemFromCMakeProject):
1404 (buildCMakeGeneratedProject):
1405 (cmakeBasedPortName):
1406 (determineIsCMakeBuild):
1409 (jhbuildWrapperPrefixIfNeeded): Deleted.
1411 2015-10-29 Lucas Forschler <lforschler@apple.com>
1413 Teach JSC bots to build 32bit instead of x86_64
1415 Reviewed by Mark Lam.
1417 * BuildSlaveSupport/build.webkit.org-config/config.json:
1419 2015-10-29 Per Arne Vollan <peavo@outlook.com>
1421 [WinCairo] Fall back to AppleWin results in layout tests.
1422 https://bugs.webkit.org/show_bug.cgi?id=150672
1424 Reviewed by Alex Christensen.
1426 * Scripts/webkitpy/port/win.py:
1428 (WinCairoPort.default_baseline_search_path):
1430 2015-10-28 Keith Rollin <krollin@apple.com>
1432 Do not sanitize user input for input[type=url]
1433 https://bugs.webkit.org/show_bug.cgi?id=150346
1434 <rdar://problem/23243240>
1436 Reviewed by Brent Fulgham.
1438 The Windows version of DumpRenderTree's eventSender.keyDown handler
1439 simulates user-entry by decomposing the given character into a virtual
1440 key code and a set of modifier keys. The code that determines if the
1441 shift key should be simulated only worked if the character was an
1442 upper case character. Extend this support to also include symbols that
1443 (on the U.S. keyboard) require holding down the shift key.
1445 This change allows fast/forms/input-user-input-sanitization.html
1446 to succeed, which requires us to simulate the entering of '@' and ':'.
1448 * DumpRenderTree/win/EventSender.cpp:
1451 2015-10-28 Alex Christensen <achristensen@webkit.org>
1453 Compile and link with CMake on Mac
1454 https://bugs.webkit.org/show_bug.cgi?id=150632
1456 Reviewed by Tim Horton.
1458 * TestWebKitAPI/PlatformMac.cmake:
1460 2015-10-28 Xabier Rodriguez Calvar <calvaris@igalia.com>
1464 * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
1466 2015-10-28 Per Arne Vollan <peavo@outlook.com>
1468 Add WinCairo to list of ports in run-webkit-tests.
1469 https://bugs.webkit.org/show_bug.cgi?id=150625
1471 Reviewed by Brent Fulgham.
1473 * Scripts/webkitpy/common/config/ports.py:
1474 (DeprecatedPort.port):
1475 (WinPort.run_webkit_tests_command):
1478 * Scripts/webkitpy/port/factory.py:
1480 * Scripts/webkitpy/port/win.py:
1481 (WinPort.find_system_pid):
1484 2015-10-27 Alexey Proskuryakov <ap@apple.com>
1486 WebKitTestRunner leaks in generateWhitelist()
1487 https://bugs.webkit.org/show_bug.cgi?id=150563
1489 Reviewed by Andreas Kling.
1491 * WebKitTestRunner/mac/TestControllerMac.mm:
1492 (WTR::generateWhitelist):
1494 2015-10-27 Anders Carlsson <andersca@apple.com>
1496 Add an API test for _WKRemoteObjectRegistry
1497 https://bugs.webkit.org/show_bug.cgi?id=150597
1499 Reviewed by Andreas Kling.
1501 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1502 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
1503 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
1505 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
1506 (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1507 (-[RemoteObjectRegistryPlugIn sayHello:]):
1509 2015-10-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
1511 Add myself to the reviewers list
1512 https://bugs.webkit.org/show_bug.cgi?id=150581
1516 * Scripts/webkitpy/common/config/contributors.json:
1518 2015-10-26 Ryan Haddad <ryanhaddad@apple.com>
1520 Adding myself to contributors.json
1522 * Scripts/webkitpy/common/config/contributors.json:
1524 2015-10-26 Tim Horton <timothy_horton@apple.com>
1526 Don't expose the whitelist/blacklist in _WKUserStyleSheet
1527 https://bugs.webkit.org/show_bug.cgi?id=150566
1529 Reviewed by Anders Carlsson.
1531 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1534 2015-10-26 Philippe Normand <pnormand@igalia.com>
1536 Unreviewed, rolling out r191576.
1542 "[GStreamer] Bump internal jhbuild versions to 1.6.0"
1543 https://bugs.webkit.org/show_bug.cgi?id=149594
1544 http://trac.webkit.org/changeset/191576
1546 2015-10-26 ChangSeok Oh <changseok.oh@collabora.com>
1548 [GStreamer] Bump internal jhbuild versions to 1.6.0
1549 https://bugs.webkit.org/show_bug.cgi?id=149594
1551 Reviewed by Philippe Normand.
1553 Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
1554 useful so they are removed accordingly.
1556 * gtk/jhbuild.modules:
1557 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
1558 * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
1559 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
1561 2015-10-25 Alexey Proskuryakov <ap@apple.com>
1563 API tests fail on El Capitan after r191543
1564 https://bugs.webkit.org/show_bug.cgi?id=150547
1566 Reviewed by Dan Bernstein.
1568 * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
1570 2015-10-24 Tim Horton <timothy_horton@apple.com>
1572 Add a way to add user style sheets to WKUserContentController
1573 https://bugs.webkit.org/show_bug.cgi?id=150531
1574 <rdar://problem/23191691>
1576 Reviewed by Darin Adler.
1578 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1581 2015-10-24 Tim Horton <timothy_horton@apple.com>
1583 Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
1584 https://bugs.webkit.org/show_bug.cgi?id=150525
1586 Reviewed by Darin Adler.
1588 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1590 Test the various new keys.
1592 2015-10-24 Frederic Wang <fred.wang@free.fr>
1594 check-webkit-style complains about missing operator whitespace inside character literal
1595 https://bugs.webkit.org/show_bug.cgi?id=150396
1597 Reviewed by Darin Adler.
1599 * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
1600 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1601 (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
1603 2015-10-23 Michael Saboff <msaboff@apple.com>
1605 REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
1606 https://bugs.webkit.org/show_bug.cgi?id=150513
1608 Reviewed by Saam Barati.
1610 Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
1612 * DumpRenderTree/TestRunner.cpp:
1613 (simulateWebNotificationClickCallback):
1614 (failNextCodeBlock):
1615 (numberOfDFGCompiles):
1616 (TestRunner::staticFunctions):
1617 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1618 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1619 (WTR::TestRunner::setBlockAllPlugins):
1620 (WTR::TestRunner::failNextCodeBlock):
1621 (WTR::TestRunner::numberOfDFGCompiles):
1622 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1624 2015-10-23 Anders Carlsson <andersca@apple.com>
1626 Simplify the WebKitLegacy menu conversion code
1627 https://bugs.webkit.org/show_bug.cgi?id=150509
1629 Reviewed by Andreas Kling.
1631 Implement the context menu delegate method so we'll test that code path.
1633 * MiniBrowser/mac/WK1BrowserWindowController.m:
1634 (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
1636 2015-10-23 Per Arne Vollan <peavo@outlook.com>
1638 [WinCairo] Improve test results for fast layouttests.
1639 https://bugs.webkit.org/show_bug.cgi?id=150464
1641 Reviewed by Alex Christensen.
1643 Set custom device scale factor to 1.0.
1645 * DumpRenderTree/win/DumpRenderTree.cpp:
1646 (createWebViewAndOffscreenWindow):
1648 2015-10-23 Mark Salisbury <mark.salisbury@hp.com>
1650 [GTK] update-webkitgtk-libs should use mesa tarball
1652 https://bugs.webkit.org/show_bug.cgi?id=150470
1654 update-webkitgtk-libs downloads all build dependencies; in fixing
1655 bug 148941 mesa was switched from ftp to git access. Now an http
1656 tarball is available, which is preferred over accessing via git.
1658 Reviewed by Philippe Normand
1660 * gtk/jhbuild.modules:
1661 Mesa access changed to http tarball.
1663 2015-10-22 Sam Weinig <sam@webkit.org>
1665 Navigations on the same host (but with different schemes and ports) should not trigger universal links
1666 <rdar://problem/22811325>
1667 https://bugs.webkit.org/show_bug.cgi?id=150481
1669 Reviewed by Dan Bernstein.
1671 * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1672 Update test to test that navigations on the same host but with different schemes does not
1673 trigger universal links, but that changes in the host do.
1675 2015-10-22 Ryosuke Niwa <rniwa@webkit.org>
1677 REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
1678 https://bugs.webkit.org/show_bug.cgi?id=150428
1680 Reviewed by Antti Koivisto.
1682 Added a regression test using WebKit API test.
1684 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1685 * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
1686 (TestWebKitAPI::didFinishLoadForFrame):
1687 (TestWebKitAPI::TEST):
1689 2015-10-22 Carlos Garcia Campos <cgarcia@igalia.com>
1691 Unreviewed. Fix GTK+ build after r191423.
1693 Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
1696 (WebKitDOMDocGenerator):
1698 2015-10-22 Aakash Jain <aakash_jain@apple.com>
1700 [Win][EFL][GTK] webkitpy test failed after r191374.
1701 https://bugs.webkit.org/show_bug.cgi?id=150433
1703 Reviewed by Alexey Proskuryakov.
1705 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1706 (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
1707 (CrashLogsTest.test_find_log_darwin): Same.
1709 2015-10-21 Brian Burg <bburg@apple.com>
1711 Unreviewed, update watchlist for JS builtins.
1713 Add a category for JS builtins code generator, similar to other generators.
1715 Add a nag message to rebaseline builtins generator tests when touching
1716 code generator files in Source/JavaScriptCore/Scripts/builtins/.
1718 * Scripts/webkitpy/common/config/watchlist:
1720 2015-10-21 Brian Burg <bburg@apple.com>
1722 Restructure generate-js-bindings script to be modular and testable
1723 https://bugs.webkit.org/show_bug.cgi?id=149929
1725 Reviewed by Alex Christensen.
1727 Add a stub shell script and basic webkitpy support for running builtins
1730 * Scripts/run-builtins-generator-tests: Added.
1732 * Scripts/webkitpy/codegen/__init__.py: Added.
1733 * Scripts/webkitpy/codegen/main.py: Added.
1735 The only interesting difference here from the inspector protocol
1736 generator equivalent is that this implementation decodes the target
1737 framework and output mode (combined or separate) from the test's file name.
1739 (BuiltinsGeneratorTests):
1740 (BuiltinsGeneratorTests.__init__):
1741 (BuiltinsGeneratorTests.generate_from_js_builtins):
1742 (BuiltinsGeneratorTests.write_error_file):
1743 (BuiltinsGeneratorTests.detect_changes):
1744 (BuiltinsGeneratorTests.run_tests):
1745 (BuiltinsGeneratorTests.main):
1747 2015-10-21 Aakash Jain <aakash_jain@apple.com>
1749 run-webkit-tests does not copy all crash logs for layout test failures on Mac
1750 https://bugs.webkit.org/show_bug.cgi?id=150407
1751 <rdar://problem/22239750>
1753 Reviewed by Alexey Proskuryakov.
1755 * Scripts/webkitpy/port/mac.py:
1756 (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
1757 (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
1759 (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
1760 from log directory and merge them with the list of already crashed tests.
1762 2015-10-21 Filip Pizlo <fpizlo@apple.com>
1764 Failures in PutStackSinkingPhase should be less severe
1765 https://bugs.webkit.org/show_bug.cgi?id=150400
1767 Reviewed by Geoffrey Garen.
1769 Add a test mode for no PutStackSinkingPhase.
1771 * Scripts/run-jsc-stress-tests:
1773 2015-10-21 Nan Wang <n_wang@apple.com>
1775 AX: Expose table size and cell indexes on iOS
1776 https://bugs.webkit.org/show_bug.cgi?id=150366
1778 Reviewed by Chris Fleizach.
1780 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1781 (AccessibilityUIElement::rowCount):
1782 (AccessibilityUIElement::columnCount):
1783 (AccessibilityUIElement::indexInTable):
1784 (AccessibilityUIElement::numberAttributeValue):
1785 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1786 (WTR::AccessibilityUIElement::numberAttributeValue):
1787 (WTR::AccessibilityUIElement::rowCount):
1788 (WTR::AccessibilityUIElement::columnCount):
1789 (WTR::AccessibilityUIElement::indexInTable):
1791 2015-10-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
1793 W3C test importer should not import reference files as regular tests
1794 https://bugs.webkit.org/show_bug.cgi?id=150331
1796 Reviewed by Darin Adler.
1798 Updated test_parser to return information that a file can be a referencefile or a manual test.
1799 Updated test importer to skip those files.
1800 Updated/Added test parser unit tests accordingly.
1802 Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
1803 Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
1804 to mark these files as Skip, since they are not direct tests.
1806 * Scripts/webkitpy/w3c/test_importer.py:
1807 (TestImporter.__init__):
1808 (TestImporter.find_importable_tests):
1809 (TestImporter.import_tests):
1810 * Scripts/webkitpy/w3c/test_parser.py:
1811 (TestParser.analyze_test):
1812 * Scripts/webkitpy/w3c/test_parser_unittest.py:
1813 (test_analyze_non_html_file):
1814 (test_reference_test):
1816 2015-10-20 Aakash Jain <aakash_jain@apple.com>
1818 run-webkit-tests does not copy all crash logs for layout test failures on iOS
1819 https://bugs.webkit.org/show_bug.cgi?id=150056
1820 <rdar://problem/9280656>
1822 Reviewed by Alexey Proskuryakov.
1824 * Scripts/webkitpy/common/system/crashlogs.py:
1825 (CrashLogs.find_all_logs): Generic method to find all crash logs.
1826 (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
1827 It iterates through log directory and returns all the logs based on timestamp.
1828 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1829 (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
1830 (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
1831 (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
1832 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1833 (Manager.run): Modified start_time to start counting before simulator launch
1834 so that we can capture crashes during simualator launch.
1835 (Manager._look_for_new_crash_logs): Browse through list of crashes and append
1836 any test which is not already marked as CRASH to the run_results.
1837 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1838 (TestExpectationsModel.get_expectations_string): return PASS in case there
1839 are no expectations defined for this test.
1840 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1841 (summarize_results): Add other_crashes in a separte category in full_results.json.
1842 * Scripts/webkitpy/port/ios.py:
1843 (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
1844 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
1845 from the log directory.
1846 (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
1847 logs from log directory and merge them with the list of already crashed tests.
1849 2015-10-20 Dana Burkart <dburkart@apple.com>
1855 My previous patch was missing a necessary space character.
1857 * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1859 2015-10-20 Dana Burkart <dburkart@apple.com>
1861 svn-apply fails to apply binary diffs in some cases
1862 https://bugs.webkit.org/show_bug.cgi?id=64647
1864 Reviewed by Daniel Bates.
1866 * Scripts/VCSUtils.pm:
1867 (decodeGitBinaryPatchDeltaSize): Modified.
1868 We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
1869 * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
1871 2015-10-20 Alexey Proskuryakov <ap@apple.com>
1873 Mac Debug EWS never finishes when there are failures
1874 https://bugs.webkit.org/show_bug.cgi?id=150334
1876 Reviewed by Daniel Bates.
1878 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1879 * Scripts/webkitpy/tool/commands/queues.py:
1881 2015-10-20 Philippe Normand <pnormand@igalia.com>
1883 [GTK] Enable OpenWebRTC test video/audio sources in tests
1885 This is needed because we can't expect the buildbots to have
1886 webcam/mic devices plugged in.
1888 Rubber-stamped by Carlos Garcia Campos.
1890 * Scripts/run-gtk-tests:
1891 (TestRunner._setup_testing_environment):
1892 * Scripts/webkitpy/port/gtk.py:
1893 (GtkPort.setup_environ_for_server):
1895 2015-10-20 Yoav Weiss <yoav@yoav.ws>
1897 Rename the PICTURE_SIZES flag to CURRENTSRC
1898 https://bugs.webkit.org/show_bug.cgi?id=150275
1900 Reviewed by Dean Jackson.
1902 * Scripts/webkitperl/FeatureList.pm:
1904 2015-10-19 Hunseop Jeong <hs85.jeong@samsung.com>
1906 Unreviewed, add myself to the committers list.
1908 * Scripts/webkitpy/common/config/contributors.json:
1910 2015-10-19 Alexey Proskuryakov <ap@apple.com>
1912 Add new EWS queues to bot watcher's dashboard
1913 https://bugs.webkit.org/show_bug.cgi?id=150297
1915 Reviewed by Darin Adler.
1917 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1918 (BubbleQueueServer):
1920 2015-10-19 ChangSeok Oh <changseok.oh@collabora.com>
1922 REGRESSION(r190262): User media unit test failures after r190262
1923 https://bugs.webkit.org/show_bug.cgi?id=149580
1925 Reviewed by Carlos Garcia Campos.
1927 The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
1928 So we do not need to skip them anymore.
1930 * Scripts/run-gtk-tests:
1931 (TestRunner): Deleted.
1933 2015-10-19 Csaba Osztrogonác <ossy@webkit.org>
1935 Add historical addresses to contributors.json
1936 https://bugs.webkit.org/show_bug.cgi?id=150227
1938 Reviewed by Darin Adler.
1940 * Scripts/webkitpy/common/config/contributors.json:
1942 2015-10-18 Sungmann Cho <sungmann.cho@navercorp.com>
1944 [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
1945 https://bugs.webkit.org/show_bug.cgi?id=150307
1947 Reviewed by Brent Fulgham.
1949 The DLL build rules have been changed to generate "{Name}Lib.DLL",
1950 but these changes have not yet been applied to the Visual Studio builds.
1952 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
1954 2015-10-16 Andreas Kling <akling@apple.com>
1956 [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
1957 <https://webkit.org/b/150153>
1961 Just use simple arrays of LChar and UChar for this test instead of creating String
1962 objects and then getting the characters8()/characters16() from them, since that
1963 doesn't guarantee null-termination (the bug.)
1965 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1966 (TestWebKitAPI::TEST):
1967 (TestWebKitAPI::build): Deleted.
1969 2015-10-16 Tim Horton <timothy_horton@apple.com>
1971 WebKit2.AutoLayoutIntegration API test is failing on some of the bots
1972 https://bugs.webkit.org/show_bug.cgi?id=150255
1974 Reviewed by Simon Fraser.
1976 * Scripts/run-api-tests:
1978 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1979 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
1980 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
1981 (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
1982 (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
1983 Don't set the layout size until after the load finishes and we're waiting
1984 for the reply, so that there is no race between the new size coming in
1985 and us waiting for it.
1987 2015-10-16 Anders Carlsson <andersca@apple.com>
1989 WebEditingDelegate should be a formal protocol
1990 https://bugs.webkit.org/show_bug.cgi?id=150254
1991 <rdar://problem/23149847>
1993 Reviewed by Dan Bernstein.
1995 * DumpRenderTree/mac/EditingDelegate.h:
1996 Conform to the WebEditingDelegate protocol.
1998 2015-10-16 Tim Horton <timothy_horton@apple.com>
2000 Hook up autolayout intrinsic sizing for WKWebView
2001 https://bugs.webkit.org/show_bug.cgi?id=150219
2002 <rdar://problem/20016905>
2004 Reviewed by Simon Fraser.
2006 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2007 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
2008 (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
2009 (-[AutoLayoutWKWebView load:expectingContentSize:]):
2010 (-[AutoLayoutWKWebView expectContentSizeChange:]):
2011 (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
2013 Add a variety of tests, including one which catches the bug that
2014 the WebCore part of this patch fixes.
2016 2015-10-15 Csaba Osztrogonác <ossy@webkit.org>
2018 Update the help message of --system-malloc
2019 https://bugs.webkit.org/show_bug.cgi?id=150169
2021 Reviewed by Geoffrey Garen.
2023 * Scripts/webkitperl/FeatureList.pm:
2025 2015-10-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
2027 Update ImportExpectations according currently imported wpt tests
2028 https://bugs.webkit.org/show_bug.cgi?id=150158
2030 Reviewed by Chris Dumez.
2032 * Scripts/webkitpy/w3c/test_downloader.py:
2033 (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
2035 2015-10-15 Eunmi Lee <eunmi15.lee@samsung.com>
2037 Unreviewed, Update my email address.
2039 * Scripts/webkitpy/common/config/contributors.json:
2041 2015-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
2043 [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
2044 https://bugs.webkit.org/show_bug.cgi?id=84960
2046 Reviewed by Žan Doberšek.
2048 * Scripts/run-gtk-tests:
2049 (TestRunner): Unskip tests using SessionState.
2050 * TestWebKitAPI/PlatformGTK.cmake: Add
2051 WKPageCopySessionStateWithFiltering test.
2053 2015-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
2055 [GTK] Missing return value on TestWebExtensions.cpp:193
2056 https://bugs.webkit.org/show_bug.cgi?id=149755
2058 Unreviewed. Add missing return value.
2060 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2061 (permissionRequestCallback):
2063 2015-10-14 Andy Estes <aestes@apple.com>
2065 [iOS] build-dumprendertree does not build ImageDiff
2066 https://bugs.webkit.org/show_bug.cgi?id=150152
2068 Reviewed by Tim Horton.
2070 run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
2071 On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
2072 as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
2073 WebKit.xcworkspace), tests that rely on image diffing won't work properly.
2075 There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
2076 fine on that platform, and results in ImageDiff being built.
2078 * Scripts/build-dumprendertree:
2080 2015-10-14 Brent Fulgham <bfulgham@apple.com>
2082 [Win] Enforce launcher/library naming scheme
2083 https://bugs.webkit.org/show_bug.cgi?id=150124
2085 Reviewed by Alex Christensen.
2087 * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
2088 * MiniBrowser/win/CMakeLists.txt: Ditto.
2089 * TestWebKitAPI/PlatformWin.cmake: Ditto.
2090 * win/DLLLauncher/DLLLauncherMain.cpp:
2091 (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
2092 original {name}.dll.
2094 2015-10-14 Andreas Kling <akling@apple.com>
2096 REGRESSION(r190882): Concatenating a character array and an empty string is broken.
2097 <https://webkit.org/b/150135>
2099 Reviewed by Geoffrey Garen.
2101 Add a new WTF API test that covers this issue.
2103 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2104 (TestWebKitAPI::build):
2105 (TestWebKitAPI::TEST):
2107 2015-10-14 Alex Christensen <achristensen@webkit.org>
2109 Add SPI for reloading without content blockers
2110 https://bugs.webkit.org/show_bug.cgi?id=150058
2111 rdar://problem/22742222
2113 Reviewed by Sam Weinig.
2115 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2116 (WTR::TestController::cocoaResetStateToConsistentValues):
2117 * WebKitTestRunner/mac/TestControllerMac.mm:
2118 (WTR::TestController::platformConfigureViewForTest):
2120 2015-10-14 Mark Lam <mark.lam@apple.com>
2122 Rename some JSC option names to be more uniform.
2123 https://bugs.webkit.org/show_bug.cgi?id=150127
2125 Reviewed by Geoffrey Garen.
2127 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
2128 * Scripts/run-jsc-stress-tests:
2130 2015-10-14 Anders Carlsson <andersca@apple.com>
2132 Change the bundle app cache APIs to take a page
2133 https://bugs.webkit.org/show_bug.cgi?id=150123
2135 Reviewed by Sam Weinig.
2139 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2140 (WTR::InjectedBundle::beginTesting):
2141 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2142 (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2143 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2144 (WTR::TestRunner::clearAllApplicationCaches):
2145 (WTR::TestRunner::clearApplicationCacheForOrigin):
2146 (WTR::TestRunner::setAppCacheMaximumSize):
2147 (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2148 (WTR::TestRunner::originsWithApplicationCache):
2150 2015-10-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
2152 Update web-platform-tests tools to the latest revision
2153 https://bugs.webkit.org/show_bug.cgi?id=149645
2155 Reviewed by Darin Adler.
2157 Disabling git submodules information conversion to json install file for web-platform-tests.
2158 Disabling related python unit tests.
2159 The tools submodules contain submodules and the conversion tool does not support that yet.
2161 Updating wpt launcher script to aling it with web-platform-test main script.
2163 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2165 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2166 (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
2167 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2168 (TestImporterTest.test_submodules_generation):
2170 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2172 More debug queue build fixing.
2174 Preserve the build style in one more place. Changed mock build_style from "both"
2175 to "release", as we don't support testing both debug and release.
2177 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2178 (MockCommitQueue.archive_last_test_results):
2180 (MockCommitQueue.build_style):
2181 (MockCommitQueue.did_pass_testing_ews):
2182 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2183 (PatchAnalysisTask._test):
2184 (PatchAnalysisTask._build_and_test_without_patch):
2185 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2186 (EarlyWarningSystemTest._default_expected_logs):
2187 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2189 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2191 More debug queue build fixing.
2193 Add build_style argument to derived classes as well.
2195 * Scripts/webkitpy/common/config/ports.py:
2197 (MacPort.run_webkit_tests_command):
2198 (WinPort.run_bindings_tests_command):
2200 (WinPort.run_webkit_tests_command):
2201 (GtkWK2Port.build_webkit_command):
2203 (GtkWK2Port.run_webkit_tests_command):
2205 2015-10-13 Myles C. Maxfield <mmaxfield@apple.com>
2211 Mach-O section names are limited to 16 characters.
2213 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2214 * DumpRenderTree/mac/DumpRenderTree.mm:
2217 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2219 Build fix for mac-debug EWS queue.
2223 Pass --debug to run-webkit-tests.
2225 While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
2226 will need to be substantially modified to work in EWS, so the dummy implementation
2229 * Scripts/webkitpy/common/config/ports.py:
2230 (DeprecatedPort.run_javascriptcore_tests_command):
2232 (DeprecatedPort.run_webkit_tests_command):
2233 (DeprecatedPort.run_python_unittests_command):
2234 (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
2235 * Scripts/webkitpy/common/config/ports_mock.py:
2236 (MockPort.run_javascriptcore_tests_command):
2238 (MockPort.run_webkit_tests_command):
2239 (MockPort.run_bindings_tests_command):
2240 (MockPort.run_webkit_unit_tests_command): Deleted.
2241 * Scripts/webkitpy/tool/commands/download_unittest.py:
2242 * Scripts/webkitpy/tool/steps/runtests.py:
2244 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2245 (RunTestsTest.test_webkit_run_unit_tests):
2246 * Scripts/webkitpy/tool/steps/steps_unittest.py:
2247 (StepsTest.test_runtests_args):
2249 2015-10-13 Brent Fulgham <bfulgham@apple.com>
2251 [Win] Generate Crash Traces
2252 https://bugs.webkit.org/show_bug.cgi?id=150103
2254 Reviewed by Daniel Bates.
2256 We were using an exception filter to try to emit "#CRASHED" to stderr
2257 when a test program crashed. However, the modern Python implementation
2258 seems capable of recognizing crashes on its own. Furthermore, registering
2259 the exception handler was preventing the JIT debugger (NTSD) from
2260 automatically attaching to the crashing program, so we were not getting
2263 * DumpRenderTree/win/DumpRenderTree.cpp:
2264 (main): Don't register an exception filter.
2265 (exceptionFilter): Deleted.
2266 * Scripts/webkitpy/common/system/crashlogs.py:
2267 (CrashLogs): Add another regular expression to handle a second crash trace
2268 syntax I encountered during testing.
2269 (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
2270 try the new one. The PID found by the new expression is in hexadecimal, so
2271 convert it to an integer before returning it.
2272 * Scripts/webkitpy/port/driver.py:
2273 (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
2274 the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
2275 check for "#CRASHED" after stripping off the EOL characters.
2276 * Scripts/webkitpy/port/win.py:
2277 (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
2278 invocation. This is apparently used to signal an event when the debugger is finished.
2280 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2282 Mac Debug and 32-bit queues should be separate
2283 https://bugs.webkit.org/show_bug.cgi?id=150092
2285 Reviewed by Lucas Forschler.
2287 * QueueStatusServer/config/queues.py:
2288 * QueueStatusServer/model/queues.py:
2289 (Queue._capitalize_after_dash):
2290 (Queue._caplitalize_after_dash): Deleted.
2291 * Scripts/webkitpy/common/config/ews.json:
2293 2015-10-13 Sergio Villar Senin <svillar@igalia.com>
2295 [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
2296 https://bugs.webkit.org/show_bug.cgi?id=150085
2298 Reviewed by Carlos Garcia Campos.
2300 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2302 2015-10-13 Sebastian Dröge <sebastian@centricular.com>
2304 Unreviewed, add myself to the committers list.
2306 * Scripts/webkitpy/common/config/contributors.json:
2308 2015-10-12 Alexey Proskuryakov <ap@apple.com>
2310 Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
2311 https://bugs.webkit.org/show_bug.cgi?id=149983
2313 Reviewed by Dan Bates.
2315 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2316 (BubbleQueueServer):
2317 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2319 2015-10-12 Alexey Proskuryakov <ap@apple.com>
2321 Fix webkitpy tests after r190922.
2323 * Scripts/webkitpy/common/config/ews.json:
2324 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2325 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2327 2015-10-12 Alexey Proskuryakov <ap@apple.com>
2329 Add a Mac debug EWS queue
2330 https://bugs.webkit.org/show_bug.cgi?id=150069
2332 Reviewed by Geoffrey Garen.
2334 * QueueStatusServer/config/queues.py:
2335 * Scripts/webkitpy/common/config/ews.json:
2336 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2337 (AbstractEarlyWarningSystem):
2338 (AbstractEarlyWarningSystem.archive_last_test_results):
2339 (AbstractEarlyWarningSystem.build_style):
2340 (AbstractEarlyWarningSystem.refetch_patch):
2341 (AbstractEarlyWarningSystem.load_ews_classes):
2343 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
2345 [GTK] Update jhbuild's version of harfbuzz
2346 https://bugs.webkit.org/show_bug.cgi?id=149749
2348 Reviewed by Martin Robinson.
2350 Update harfbuzz to 0.9.35, following the lead of Debian Stable.
2352 * gtk/jhbuild.modules: Updated details for harfbuzz.
2354 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
2356 [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
2357 https://bugs.webkit.org/show_bug.cgi?id=150026
2359 Reviewed by Philippe Normand.
2361 Backport upstream patch from gst-plugins-bad so that the right version
2362 of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
2363 gets compiled properly, avoiding crashes on runtime while running tests.
2365 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
2366 * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
2368 2015-10-11 Myles C. Maxfield <mmaxfield@apple.com>
2370 Test font-variant-* and font-feature-settings with mocked preinstalled fonts
2371 https://bugs.webkit.org/show_bug.cgi?id=149777
2373 Reviewed by Simon Fraser.
2375 Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
2376 to the list of tests to preinstall at startup time.
2378 Also, update the generation of the 'name' table in the FontWithFeatures font.
2380 * DumpRenderTree/mac/DumpRenderTree.mm:
2381 (allowedFontFamilySet):
2382 (activateTestingFonts):
2384 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2385 (Generator::generate):
2386 (Generator::appendCFFTable):
2387 (Generator::appendNameSubtable):
2388 (Generator::appendNAMETable):
2389 * FontWithFeatures/FontWithFeatures/main.cpp:
2391 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2392 (WTR::allowedFontFamilySet):
2393 (WTR::activateFonts):
2394 * WebKitTestRunner/mac/TestControllerMac.mm:
2395 (WTR::allowedFontFamilySet):
2397 2015-10-11 Jinyoung Hur <hur.ims@navercorp.com>
2399 Unreviewed. Add Jinyoung Hur as a committer.
2401 * Scripts/webkitpy/common/config/contributors.json:
2403 2015-10-10 Dan Bernstein <mitz@apple.com>
2405 [iOS] Remove unnecessary iOS version checks
2406 https://bugs.webkit.org/show_bug.cgi?id=150002
2408 Reviewed by Alexey Proskuryakov.
2410 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2411 (-[HIDEventGenerator _createIOHIDEventType:]):
2412 (-[HIDEventGenerator _sendHIDEvent:]):
2413 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2414 * WebKitTestRunner/ios/UIKitSPI.h:
2416 2015-10-09 Myles C. Maxfield <mmaxfield@apple.com>
2418 Unreviewed, rolling out r190689
2419 https://bugs.webkit.org/show_bug.cgi?id=149992
2421 Fixed in other repository.
2423 Reverted changesets:
2425 "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
2426 https://bugs.webkit.org/show_bug.cgi?id=149897
2428 2015-10-09 Brian Burg <bburg@apple.com>
2430 Teach webkitperl how to figure out IOS versions from the SDK
2431 https://bugs.webkit.org/show_bug.cgi?id=149963
2433 Reviewed by Daniel Bates.
2435 It should be easier to check the major and minor version of IOS SDKs.
2437 * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
2438 * Scripts/webkitdirs.pm:
2439 (splitVersionString): Added.
2440 (determineOSXVersion): Use splitVersionString.
2441 (determineIOSVersion): Added. Look at the SDK version and make a tuple.
2442 (iosVersion): Added.
2444 2015-10-09 Simon Fraser <simon.fraser@apple.com>
2446 [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
2447 https://bugs.webkit.org/show_bug.cgi?id=149960
2449 Reviewed by Tim Horton.
2451 Use adoptWK(), and null out some members (file is not using ARC).
2453 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2454 (UIScriptContext::uiScriptComplete):
2455 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2456 (-[TestRunnerWKWebView dealloc]):
2458 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
2460 Remove ENABLE_SUID_SANDBOX_LINUX cruft
2461 https://bugs.webkit.org/show_bug.cgi?id=149954
2463 Reviewed by Darin Adler.
2465 * Scripts/webkitperl/FeatureList.pm:
2467 2015-10-09 Daniel Bates <dabates@apple.com>
2469 Make iOS builders generate debug information in a separate dSYM file
2470 https://bugs.webkit.org/show_bug.cgi?id=149696
2472 Reviewed by Darin Adler.
2474 Similar to the Mac builders, the iOS builders should write debug information
2475 into a separate dSYM file instead of including such information in the binary
2476 itself (default Xcode behavior)
2478 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2479 (CompileWebKit.start):
2481 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
2483 Fix webkitpy tests after r190779
2484 https://bugs.webkit.org/show_bug.cgi?id=149949
2486 Reviewed by Ryosuke Niwa.
2488 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2489 (BenchmarkResults.format):
2490 (BenchmarkResults._format_values):
2492 2015-10-08 Dewei Zhu <dewei_zhu@apple.com>
2494 Extend run-benchmark script to support human-readable results conversion.
2495 https://bugs.webkit.org/show_bug.cgi?id=149944
2497 Reviewed by Ryosuke Niwa.
2499 Add '--read-results-json' and '--no-adjust-unit' options.
2500 '--read-results-json' option converts result file to human readable format.
2501 '--no-adjust-unit' option skips scientific notation convertion.
2502 '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
2504 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2505 (BenchmarkResults.format):
2506 (BenchmarkResults._format_tests):
2507 (BenchmarkResults._format_values):
2508 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2509 (BenchmarkRunner.__init__):
2510 (BenchmarkRunner._run_benchmark):
2511 (BenchmarkRunner._dump):
2512 (BenchmarkRunner.show_results):
2513 (BenchmarkRunner._show_results): Deleted.
2514 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2518 2015-10-08 Daniel Bates <dabates@apple.com>
2520 Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
2521 https://bugs.webkit.org/show_bug.cgi?id=149945
2523 Reviewed by Dan Bernstein.
2525 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
2526 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
2527 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2528 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2530 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2531 (table.queue-grid tr.platform.ios-9 img.logo):
2533 2015-10-08 Daniel Bates <dabates@apple.com>
2535 Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
2536 https://bugs.webkit.org/show_bug.cgi?id=149943
2538 Reviewed by Dan Bernstein.
2540 Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
2541 teach build-webkit to install them when building for iOS device using the public iOS SDK.
2543 * Scripts/build-webkit:
2545 2015-10-08 Daniel Bates <dabates@apple.com>
2547 Add LLVM binaries for iOS 9 device
2548 https://bugs.webkit.org/show_bug.cgi?id=149913
2550 Reviewed by Filip Pizlo.
2552 Implement support for building LLVM for ARM64-based iOS devices.
2554 * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
2555 * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
2556 an existing build earlier in the file such that remove previously built
2557 libraries before building/copying new ones (if applicable).
2558 (fileContains): Moved function outside of if-block.
2559 (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
2560 (buildLLVM): Added. Extracted machinery to build LLVM into this function and
2561 added logic to build LLVM for ARM64-based iOS devices.
2562 (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
2563 LLVM into the WebKitBuild directory.
2565 2015-10-08 Alexey Proskuryakov <ap@apple.com>
2567 Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
2568 https://bugs.webkit.org/show_bug.cgi?id=149848
2570 Reviewed by Darin Adler.
2572 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2574 2015-10-07 Brent Fulgham <bfulgham@apple.com>
2576 [Win] Support 64-bit Build and Testing
2577 https://bugs.webkit.org/show_bug.cgi?id=149904
2579 Reviewed by Daniel Bates.
2581 Extend our existing scripts to support 64-bit build and test operations on
2584 * Scripts/build-dumprendertree: We don't need to build DRT on its own;
2585 Windows always builds the whole stack.
2586 * Scripts/webkit-build-directory: Add an option to return the location of
2587 the executable files produced by a specific configuration. This change is
2588 actually useful for Gtk and EFL, too.
2589 * Scripts/webkitdirs.pm:
2590 (executableProductDir): Added. This function appends the proper binary
2591 path to the productDir. This is useful for Windows, Gtk, and EFL ports.
2592 (jscProductDir): Use the new 'executableProductDir' method.
2593 (setPathForRunningWebKitApp): Ditto.
2595 (runMiniBrowser): Ditto.
2596 * Scripts/webkitpy/port/factory.py:
2597 (configuration_options): Add a 64-bit option, used on Windows to specify
2598 which binary target should be used for testing.
2599 * Scripts/webkitpy/port/win.py:
2600 (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
2601 processes when needed.
2602 (WinPort._build_path): Add the correct binary target path to _build_path.
2603 (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
2604 64-bit paths for 64-bit tests.
2605 (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
2606 NTSD debugger does not understand this argument.
2608 2015-10-07 Myles C. Maxfield <mmaxfield@apple.com>
2610 Test font-variant-* and font-feature-settings with TrueType fonts
2611 https://bugs.webkit.org/show_bug.cgi?id=149776
2613 Reviewed by Simon Fraser.
2615 This test extends our existing FontWithFeatures project to be able to generate a
2616 TrueType font. This font is conceptually similar as the existing OpenType font,
2617 except the feature -> character mapping is different.
2619 The font itself only supports the following characters:
2620 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2621 However, the shape of these letters are either an X or a check mark.
2622 The letter "A" always is a check mark.
2623 The letter "B" always is an X.
2624 Each font feature has an letter associated with it. When the font feature is enabled,
2625 that letter is shown as a check mark. For example, when
2626 "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
2629 Here are the mappings of font features to letters:
2630 kLigaturesType / kCommonLigaturesOnSelector: C
2631 kLigaturesType / kContextualLigaturesOnSelector: D
2632 kLigaturesType / kRareLigaturesOnSelector: G
2633 kLigaturesType / kHistoricalLigaturesOnSelector: I
2634 kContextualAlternatesType / kContextualAlternatesOnSelector: L
2635 kVerticalPositionType / kInferiorsSelector: O
2636 kVerticalPositionType / kSuperiorsSelector: P
2637 kLowerCaseType / kLowerCaseSmallCapsSelector: S
2638 kUpperCaseType / kUpperCaseSmallCapsSelector: V
2639 kLowerCaseType / kLowerCasePetiteCapsSelector: T
2640 kUpperCaseType / kUpperCasePetiteCapsSelector: W
2641 kLetterCaseType / 14: Y
2642 kStyleOptionsType / kTitlingCapsSelector: a
2643 kNumberCaseType / kUpperCaseNumbersSelector: c
2644 kNumberCaseType / kLowerCaseNumbersSelector: d
2645 kNumberSpacingType / kProportionalNumbersSelector: f
2646 kNumberSpacingType / kMonospacedNumbersSelector: g
2647 kFractionsType / kDiagonalFractionsSelector: i
2648 kFractionsType / kVerticalFractionsSelector: j
2649 kVerticalPositionType / kOrdinalsSelector: Q
2650 kTypographicExtrasType / kSlashedZeroOnSelector: k
2651 kLigaturesType / kHistoricalLigaturesOnSelector: K
2652 kCharacterShapeType / kJIS1978CharactersSelector: m
2653 kCharacterShapeType / kJIS1983CharactersSelector: n
2654 kCharacterShapeType / kJIS1990CharactersSelector: o
2655 kCharacterShapeType / kJIS2004CharactersSelector: p
2656 kCharacterShapeType / kSimplifiedCharactersSelector: q
2657 kCharacterShapeType / kTraditionalCharactersSelector: r
2658 kTextSpacingType / kMonospacedTextSelector: t
2659 kTextSpacingType / kProportionalTextSelector: u
2660 kRubyKanaType / kRubyKanaOnSelector: v
2662 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
2663 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2664 (CFFBuilder::moveTo):
2665 (CFFBuilder::lineTo):
2666 (GLYFBuilder::GLYFBuilder):
2667 (GLYFBuilder::takeResult):
2668 (GLYFBuilder::moveTo):
2669 (GLYFBuilder::lineTo):
2670 (GLYFBuilder::closePath):
2671 (GLYFBuilder::writePoint):
2672 (GLYFBuilder::append16):
2673 (generateBoxCharString):
2674 (generateCheckCharString):
2675 (generateXCharString):
2677 (Generator::generate):
2678 (Generator::insertSelector):
2679 (Generator::insertFeature):
2680 (Generator::generateFeatureDescription):
2681 (Generator::appendCFFTable):
2682 (Generator::appendGLYFTable):
2683 (Generator::appendLOCATable):
2684 (Generator::appendFEATTable):
2685 (Generator::appendMetamorphosisChain):
2686 (Generator::appendMORXTable):
2687 (Generator::appendHEADTable):
2688 (Generator::appendHMTXTable):
2689 (Generator::appendNameSubtable):
2690 (Generator::append2ByteASCIIString):
2691 (Generator::appendNAMETable):
2693 (CFFBuilder::curveToCubic): Deleted.
2694 (charStringForGlyph): Deleted.
2695 * FontWithFeatures/FontWithFeatures/FontCreator.h:
2696 * FontWithFeatures/FontWithFeatures/main.cpp:
2697 (constructFontWithTrueTypeFeature):
2698 (constructFontWithOpenTypeFeature):
2701 (drawTextWithFeature): Deleted.
2703 2015-10-07 Commit Queue <commit-queue@webkit.org>
2705 Unreviewed, rolling out r190572, r190593, r190594, and
2707 https://bugs.webkit.org/show_bug.cgi?id=149897
2709 Breaks Mavericks build (Requested by litherum on #webkit).
2711 Reverted changesets:
2713 "Allow WKRetainPtrs to be used as keys in hashing data
2715 https://bugs.webkit.org/show_bug.cgi?id=149762
2716 http://trac.webkit.org/changeset/190572
2718 "REGRESSION(189668?): http/tests/notifications/events.html
2719 flakily asserts or times out"
2720 https://bugs.webkit.org/show_bug.cgi?id=149218
2721 http://trac.webkit.org/changeset/190593
2723 "Prospective Mavericks build fix."
2724 http://trac.webkit.org/changeset/190594
2726 "Post-review cleanup after r190572."
2727 http://trac.webkit.org/changeset/190639
2729 2015-10-06 Michael Catanzaro <mcatanzaro@igalia.com>
2731 [GTK] Add autocleanups
2732 https://bugs.webkit.org/show_bug.cgi?id=149588
2734 Reviewed by Darin Adler.
2736 * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
2737 (AutocleanupsTest::create):
2738 (AutocleanupsTest::testWebProcessAutocleanups):
2740 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2741 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
2742 (testUIProcessAutocleanups):
2743 (testWebProcessAutocleanups):
2747 2015-10-06 Brian Burg <bburg@apple.com>
2749 Unreviewed, try to fix the iOS 8 build after r190368.
2751 On older versions, IOHIDEventCreateForceEvent is not available.
2753 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2754 (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
2756 2015-10-06 Keith Miller <keith_miller@apple.com>
2758 Add gmalloc option to run-javascriptcore-tests.
2759 https://bugs.webkit.org/show_bug.cgi?id=149858
2761 Reviewed by Geoffrey Garen.
2763 run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
2764 If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
2766 * Scripts/run-javascriptcore-tests:
2768 2015-10-06 Myles C. Maxfield <mmaxfield@apple.com>
2770 Post-review cleanup after r190572.
2774 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
2776 2015-10-06 Brent Fulgham <bfulgham@apple.com>
2778 [Win] Unreviewed build correction.
2780 * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
2781 are soft-linked at runtime.
2783 2015-10-06 Keith Miller <keith_miller@apple.com>
2785 Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
2786 https://bugs.webkit.org/show_bug.cgi?id=149815
2788 Reviewed by Filip Pizlo.
2790 Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
2791 Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
2792 running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
2793 Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
2794 so should just use one test runner.
2796 * Scripts/run-javascriptcore-tests:
2797 (runJSCStressTests):
2798 (runMozillaTests): Deleted.
2799 (defaultJsDriverArgsForMozillaTests): Deleted.
2800 * Scripts/run-jsc-stress-tests:
2802 2015-10-06 Mark Salisbury <mark.salisbury@hp.com>
2804 [GTK] Make update-webkitgtk-libs work behind firewall
2806 update-webkitgtk-libs can work behind a firewall with changes to
2807 a few packages. Where outbound git and active FTP connections
2808 fail, using http protocol succeeds. Most packages are
2809 already accessed using http.
2811 https://bugs.webkit.org/show_bug.cgi?id=148941
2813 Reviewed by Martin Robinson.
2816 * gtk/jhbuild.modules:
2817 Replace git URLs with http. Remove no longer used ftp repositories.
2818 Update argument for libxml2's autogen.sh script (--without-python
2819 is ignored; --with-python=no is correct).
2820 * jhbuild/jhbuild-wrapper:
2821 Instead of connecting to git://git.gnome.org/jhbuild, connect to
2822 http://git.gnome.org/browse/jhbuild.
2824 2015-10-06 Daniel Bates <dbates@webkit.org>
2826 Enable XSLT when building WebKit for iOS using the public iOS SDK
2827 https://bugs.webkit.org/show_bug.cgi?id=149827
2829 Reviewed by Alexey Proskuryakov.
2831 Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
2832 and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
2833 run this script before building WebKit for iOS or the build will fail because one or more XSLT
2834 headers cannot be found.
2836 * Scripts/configure-xcode-for-ios-development:
2837 (copyMissingXSLTHeadersToSDKIfNeeded): Added.
2839 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
2841 REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
2842 https://bugs.webkit.org/show_bug.cgi?id=149218
2844 Reviewed by Alexey Proskuryakov.
2846 Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
2847 when the TestOptions change. Previously, WebNotificationProvider only could handle a single
2848 WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
2849 and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
2850 the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
2851 WebNotificationProvider must be updated to appropriately handle multiple
2852 WKNotificationManagerRefs in flight at the same time.
2854 * WebKitTestRunner/WebNotificationProvider.cpp:
2855 (WTR::WebNotificationProvider::~WebNotificationProvider):
2856 (WTR::WebNotificationProvider::showWebNotification):
2857 (WTR::WebNotificationProvider::closeWebNotification):
2858 (WTR::WebNotificationProvider::addNotificationManager):
2859 (WTR::WebNotificationProvider::removeNotificationManager):
2860 (WTR::WebNotificationProvider::simulateWebNotificationClick):
2861 (WTR::WebNotificationProvider::reset):
2862 * WebKitTestRunner/WebNotificationProvider.h:
2864 2015-10-05 Daniel Bates <dabates@apple.com>
2866 Disable Bitcode when building for iOS device
2867 https://bugs.webkit.org/show_bug.cgi?id=149818
2869 Reviewed by Alexey Proskuryakov.
2871 Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
2872 when building for iOS device.
2874 * Scripts/webkitdirs.pm:
2877 2015-10-05 Daniel Bates <dabates@apple.com>
2879 [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
2880 https://bugs.webkit.org/show_bug.cgi?id=140828
2881 <rdar://problem/19520599>
2883 Reviewed by Alexey Proskuryakov.
2885 Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
2886 we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
2887 to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
2890 * Scripts/webkitdirs.pm:
2891 (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
2892 to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
2893 Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
2894 (hasIOSDevelopmentCertificate): Added.
2896 2015-10-05 Daniel Bates <dabates@apple.com>
2898 DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
2899 https://bugs.webkit.org/show_bug.cgi?id=149766
2901 Reviewed by Alexey Proskuryakov.
2903 Create network storage testing session on iOS.
2905 Currently we do not create a network storage testing session on iOS. A network storage testing session always
2906 has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
2907 returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
2908 NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
2909 NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
2910 it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
2911 create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
2912 testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
2913 DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
2915 As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
2916 when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
2917 returns a non-null pointer to a cookie store.
2919 * DumpRenderTree/mac/DumpRenderTree.mm:
2920 (prepareConsistentTestingEnvironment):
2922 2015-10-05 Simon Fraser <simon.fraser@apple.com>
2924 Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
2927 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2928 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2930 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
2932 Allow WKRetainPtrs to be used as keys in hashing data structures
2933 https://bugs.webkit.org/show_bug.cgi?id=149762
2935 Reviewed by Anders Carlsson.
2937 * TestWebKitAPI/PlatformGTK.cmake:
2938 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2939 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
2940 (TestWebKitAPI::TEST):
2942 2015-10-05 Simon Fraser <simon.fraser@apple.com>
2944 Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
2945 available, and tidy up the #ifdefs in the UIKitSPI header.
2947 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2948 (-[HIDEventGenerator _sendHIDEvent:]):
2949 * WebKitTestRunner/ios/UIKitSPI.h:
2951 2015-10-04 Zan Dobersek <zdobersek@igalia.com>
2953 [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
2954 https://bugs.webkit.org/show_bug.cgi?id=149792
2956 Reviewed by Martin Robinson.
2958 * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
2959 for WebKitTestRunner multiple times.
2961 2015-10-04 Daniel Bates <dabates@apple.com>
2963 Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
2964 (https://bugs.webkit.org/show_bug.cgi?id=149753)
2966 For now, support calling build-layouttestrelay without --ios-simulator so long
2967 as we are building on a Mac.
2969 * Scripts/build-layouttestrelay:
2971 2015-10-04 Alexey Proskuryakov <ap@apple.com>
2973 Support Trac 1.0.x XML timeline link format
2974 https://bugs.webkit.org/show_bug.cgi?id=149786
2976 Reviewed by Lucas Forschler.
2978 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2979 (Trac.prototype._convertCommitInfoElementToObject):
2981 2015-10-04 Alexey Proskuryakov <ap@apple.com>
2983 Fix some errors on bot watcher's dashboard
2984 https://bugs.webkit.org/show_bug.cgi?id=149789
2986 Reviewed by Lucas Forschler.
2988 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2989 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
2990 tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
2992 2015-10-04 Alexey Proskuryakov <ap@apple.com>
2994 Bot watcher's dashboard builders should turn yellow when svn fails
2995 https://bugs.webkit.org/show_bug.cgi?id=149791
2997 Reviewed by Lucas Forschler.
2999 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3000 (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
3001 (BuildbotBuilderQueueView.prototype.update):
3003 2015-10-02 Daniel Bates <dabates@apple.com>
3005 Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
3006 https://bugs.webkit.org/show_bug.cgi?id=149769
3008 Reviewed by Alexey Proskuryakov.
3010 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
3011 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
3012 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3013 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3015 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3016 (table.queue-grid tr.platform.ios-simulator-9 img.logo):
3018 2015-10-02 Ryosuke Niwa <rniwa@webkit.org>
3020 REGRESSION(r190370): Speedometer spits out an extra console message
3021 https://bugs.webkit.org/show_bug.cgi?id=149720
3023 Unreviewed. Temporarily ignore the console error message.
3025 * Scripts/webkitpy/performance_tests/perftest.py:
3026 (PerfTest._filter_output):
3028 2015-10-02 Brent Fulgham <bfulgham@apple.com>
3030 Provide "--no-ninja" option to avoid using Ninja
3031 https://bugs.webkit.org/show_bug.cgi?id=149757
3033 Reviewed by Alex Christensen.
3035 Add a new command line argument understood by webkitdirs.pm so
3036 that we can conditionally avoid using Ninja. This is an
3037 'opt-out' argument, so no existing Ninja users should be affected.
3039 * Scripts/webkitdirs.pm:
3040 (canUseNinja): Check for option and block ninja if present.
3042 2015-10-02 Aakash Jain <aakash_jain@apple.com>
3044 Flakiness dashboard should support OS X El Capitan
3045 https://bugs.webkit.org/show_bug.cgi?id=149648
3047 Reviewed by Alexey Proskuryakov.
3049 * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
3051 2015-10-02 Daniel Bates <dabates@apple.com>
3053 Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
3054 (https://bugs.webkit.org/show_bug.cgi?id=149753)
3056 For now, pass --ios-simulator.
3058 * Scripts/webkitpy/port/ios.py:
3059 (IOSSimulatorPort._build_relay):
3061 2015-10-02 Simon Fraser <simon.fraser@apple.com>
3063 Remove a "nullable" that breaks the iOS 8 build.
3065 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3066 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
3068 2015-10-02 Daniel Bates <dabates@apple.com>
3070 LayoutTestRelay is not built and archived when building for iOS Simulator
3071 https://bugs.webkit.org/show_bug.cgi?id=149753
3073 Reviewed by Alexey Proskuryakov and Andy Estes.
3075 Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
3076 and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
3077 product archive when building for iOS Simulator, respectively.
3079 * BuildSlaveSupport/built-product-archive:
3080 (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
3081 differentiate between iOS device and iOS Simulator platforms.
3082 (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
3083 from determineWebKitBuildDirectories() into this function so that it can be used by both
3084 determineWebKitBuildDirectories() and archiveBuiltProduct().
3085 (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
3086 webkitBuildDirectoryForConfigurationAndPlatform().
3087 (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
3088 we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
3089 argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
3090 when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
3091 and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
3092 for the limitation that ditto(1) can only accept a single directory to archive on its command line.
3093 (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
3094 For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
3095 build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
3096 LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
3097 * Scripts/build-layouttestrelay:
3098 - Remove unnecessary include of Perl module POSIX.
3099 - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
3100 * Scripts/build-webkit:
3101 - Invoke script build-layouttestrelay when building for iOS Simulator.
3103 2015-10-02 Brent Fulgham <bfulgham@apple.com>
3105 [Win] Unreviewed test fix.
3107 You cannot run 'run-webkit-tests' from the command line because it does not know
3108 to append the binary subdirectory (bin32/bin64). We don't see this on our builders
3109 because they explicitly set use the 'root' argument to provide the full path to
3112 * Scripts/webkitpy/port/win.py:
3113 (WinPort._build_path): Added.
3115 2015-10-02 Alex Christensen <achristensen@webkit.org>
3117 Reloading without content blockers doesn't apply to resource loads after the main frame finishes
3118 https://bugs.webkit.org/show_bug.cgi?id=149430
3119 rdar://problem/22742222
3121 Reviewed by Geoffrey Garen.
3123 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3124 (WTR::TestController::cocoaResetStateToConsistentValues):
3125 * WebKitTestRunner/mac/TestControllerMac.mm:
3126 (WTR::TestController::platformConfigureViewForTest):
3127 Test what happens when you disable content blockers from the SPI.
3129 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3131 [Win] Unreviewed build fix for run-api-tests
3133 * Scripts/run-api-tests:
3134 (testToolPaths): Windows run needs to specify the binary path.
3136 2015-10-01 Daniel Bates <dabates@apple.com>
3138 Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
3139 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3141 Following r190424 we can now rely on webkit-build-directory to return the path to
3142 the correct configuration-specific build directory on Windows.
3144 * BuildSlaveSupport/built-product-archive:
3145 (archiveBuiltProduct):
3147 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3149 [Win] Unreviewed build fix.
3151 * Scripts/webkitdirs.pm:
3152 (setupAppleWinEnv): Use 64-bit build tools if available
3154 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3156 [Win] Fix TestWebKitAPI build under CMake.
3158 Reviewed by Alex Christensen.
3160 * TestWebKitAPI/PlatformWin.cmake: Add missing link command
3163 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3165 [Win] Fix behavior of webkit-build-directory script
3166 https://bugs.webkit.org/show_bug.cgi?id=149718
3168 Reviewed by Alex Christensen.
3170 * Scripts/webkitdirs.pm:
3171 (determineConfigurationProductDir): Do not include the binary
3172 sub-directory in the configuration product directory output.
3173 (jscProductDir): Append correct binary path for Windows build.
3174 (setPathForRunningWebKitApp): Include properly binary subdirectories.
3175 (runSafari): Update for revised productDir behavior.
3176 (runMiniBrowser): Ditto.
3178 2015-10-01 Alexey Proskuryakov <ap@apple.com>
3180 Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
3181 use iOS SDK, like with all the others.
3183 * Scripts/build-webkit:
3185 2015-10-01 Daniel Bates <dabates@apple.com>
3187 Attempt to fix the iOS 9 Simulator testers
3189 Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
3190 build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
3191 LayoutTestRelay when building for iOS Simulator.
3193 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3194 * Scripts/build-webkit:
3196 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
3198 [GTK] Websites with invalid auth header keep loading forever
3199 https://bugs.webkit.org/show_bug.cgi?id=149710
3201 Reviewed by Martin Robinson.
3203 Add test case to check that we can authenticate sites with an
3206 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3207 (testWebViewAuthenticationEmptyRealm):
3211 2015-10-01 Alexey Proskuryakov <ap@apple.com>
3213 [Mac] Make run-api-tests work with System Integrity Protection
3214 https://bugs.webkit.org/show_bug.cgi?id=149711
3215 rdar://problem/22928202
3217 Reviewed by Dan Bernstein.
3219 * Scripts/run-api-tests:
3221 (archCommandLineArgumentsForRestrictedEnvironmentVariables):
3223 2015-10-01 Daniel Bates <dabates@apple.com>
3225 Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
3226 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3228 For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
3229 For now, use the path to the top-level WebKit build directory instead of using the configuration-
3230 specific build directory.
3232 * BuildSlaveSupport/built-product-archive:
3233 (archiveBuiltProduct):
3235 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
3237 [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
3238 https://bugs.webkit.org/show_bug.cgi?id=145837
3240 Reviewed by Philippe Normand.
3242 * efl/jhbuild.modules:
3243 * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
3244 * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
3246 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
3248 Unreviewed. Fix the iOS build after r190407.
3250 * WebKitTestRunner/ios/IOKitSPI.h:
3252 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
3254 Implement keyboard event sending for iOS in WebKitTestRunner
3255 https://bugs.webkit.org/show_bug.cgi?id=149676
3257 Reviewed by Simon Fraser.
3259 Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
3260 way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
3261 allows us to run code when the keyboard is shown or hidden.
3263 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
3264 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3265 (WTR::UIScriptController::setDidShowKeyboardCallback):
3266 (WTR::UIScriptController::didShowKeyboardCallback):
3267 (WTR::UIScriptController::setDidHideKeyboardCallback):
3268 (WTR::UIScriptController::didHideKeyboardCallback):
3269 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
3270 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
3271 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
3272 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3273 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3274 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3275 (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
3276 the notifications that the keyboard has been raised or lowered.
3277 (-[TestRunnerWKWebView _keyboardDidShow:]):
3278 (-[TestRunnerWKWebView _keyboardDidHide:]):
3279 * WebKitTestRunner/ios/HIDEventGenerator.h:
3280 * WebKitTestRunner/ios/HIDEventGenerator.m:
3281 (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
3282 (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
3283 (hidUsageCodeForCharacter): Ditto.
3284 (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
3285 a keyDown event in WebKit.
3286 * WebKitTestRunner/ios/IOKitSPI.h:
3287 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3289 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
3291 Unreviewed, rolling out r190399.
3293 Tests are still failing even after r190362
3297 "Unreviewed. Unskip GTK+ user media unit tests after r190362."
3298 http://trac.webkit.org/changeset/190399
3300 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
3302 [jhbuild] switch to new upstream usrsctp library
3303 https://bugs.webkit.org/show_bug.cgi?id=149494
3305 Reviewed by Philippe Normand.
3307 * efl/jhbuild.modules:
3308 * gtk/jhbuild.modules:
3310 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
3312 Unreviewed. Unskip GTK+ user media unit tests after r190362.
3314 They should pass now.
3316 * Scripts/run-gtk-tests:
3319 2015-09-30 Daniel Bates <dabates@apple.com>
3321 Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
3322 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3324 * BuildSlaveSupport/built-product-archive:
3325 (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
3326 (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
3328 2015-09-30 Daniel Bates <dabates@apple.com>
3330 Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
3331 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3333 Actually, we need to pass --configuration to script webkit-build-directory to have
3334 it return the path to the configuration-specific build directory.
3336 * BuildSlaveSupport/built-product-archive:
3337 (determineWebKitBuildDirectories):
3339 2015-09-30 Daniel Bates <dabates@apple.com>
3341 built-product-archive archives incorrect build directory for iOS port
3342 https://bugs.webkit.org/show_bug.cgi?id=149695
3344 Reviewed by Darin Adler.
3346 Fixes an issue where the script built-product-archive archives a non-existent
3347 build directory for the iOS port. Without loss of generality, the script assumes
3348 the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
3349 But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
3351 Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
3352 to determine the top-level build directory and computes the configuration-specific
3353 build directory to be the concatenation of the the top-level build directory and
3354 the configuration (e.g. Release). This is incorrect. Instead we should call
3355 webkit-build-directory omitting the flag --top-level to compute the path to the
3356 configuration-specific build directory.
3358 * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
3359 (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
3360 its purpose and added global variable _configurationBuildDirectory to store the path
3361 to the configuration-specific build directory. Ensure that we have a non-empty string
3362 for both the top-level and configuration-specific build directories.
3363 (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
3364 Compute the configuration-specific build directory and store it in the global variable
3365 _configurationBuildDirectory.
3366 (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
3367 (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
3369 (determineWebKitBuildDirectory): Deleted.
3371 2015-09-30 Hunseop Jeong <hs85.jeong@samsung.com>
3373 [EFL] css3/device-adapt/* tests failed after r190335.
3374 https://bugs.webkit.org/show_bug.cgi?id=149655
3376 Reviewed by Simon Fraser.
3378 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3379 overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
3381 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3382 (WTR::shouldUseFixedLayout):
3384 2015-09-30 Dewei Zhu <dewei_zhu@apple.com>
3386 Extend JetStream timeout for slow devices.
3388 Reviewed by Chris Dumez.
3390 Extend JetStream timeout to 20 minutes.
3392 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3394 2015-09-30 Daniel Bates <dabates@apple.com>
3396 Rename iOS builders/testers to include version
3397 https://bugs.webkit.org/show_bug.cgi?id=149685
3399 Reviewed by Simon Fraser.
3401 Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
3402 make it clear to a reader the version of iOS these builders/testers are using.
3404 * BuildSlaveSupport/build.webkit.org-config/config.json:
3405 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3407 2015-09-30 Daniel Bates <dabates@apple.com>
3409 Add iOS criterion for triggering a build
3410 https://bugs.webkit.org/show_bug.cgi?id=149679
3412 Rubber-stamped by Alexey Proskuryakov.
3414 First pass at defining criterion for triggering an iOS build.
3416 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3417 (_should_file_trigger_build):
3418 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3420 (ShouldBuildTest.test_should_build):
3422 2015-09-29 Simon Fraser <simon.fraser@apple.com>
3424 [iOS] Allow tests to generate user gestures for UI testing
3425 https://bugs.webkit.org/show_bug.cgi?id=149653
3427 Reviewed by Tim Horton.
3429 Expose functionality in UIScriptController to allow for testing single- and double-tap,
3430 and to listen for completion of scrolling and zooming in the WKWebView.
3432 Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
3433 which hides the complexity of creating these events. Event dispatch is asynchronous.
3434 We detect when the last event has been handled by dispatching a vendor-specific event,
3435 which is detected via -_handleHIDEvent: in our UIApplication subclass.
3437 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
3438 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
3439 for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
3440 single and double taps.
3441 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
3442 (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
3443 Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
3444 (UIScriptContext::unregisterCallback):
3445 (UIScriptContext::callbackWithID):
3446 (UIScriptContext::fireCallback):
3447 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
3448 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3449 (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
3450 (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
3451 (WTR::UIScriptController::setDidEndZoomingCallback):
3452 (WTR::UIScriptController::didEndZoomingCallback):
3453 (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
3454 (WTR::UIScriptController::doubleTapAtPoint): Ditto.
3455 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
3456 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
3457 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3458 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3459 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
3460 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3461 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
3462 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
3463 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
3464 (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
3465 * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
3466 * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
3468 (calculateNextLocation):
3470 (+[HIDEventGenerator sharedHIDEventGenerator]):
3471 (+[HIDEventGenerator nextEventCallbackID]):
3472 (-[HIDEventGenerator init]):
3473 (-[HIDEventGenerator _createIOHIDEventType:]):
3474 (-[HIDEventGenerator _sendHIDEvent:]):
3475 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
3476 (-[HIDEventGenerator _updateTouchPoints:count:]):
3477 (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
3478 (-[HIDEventGenerator touchDown:touchCount:]):
3479 (-[HIDEventGenerator touchDown:]):
3480 (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
3481 (-[HIDEventGenerator liftUp:touchCount:]):
3482 (-[HIDEventGenerator liftUp:]):
3483 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
3484 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3485 (-[HIDEventGenerator tap:completionBlock:]):
3486 (-[HIDEventGenerator doubleTap:completionBlock:]):
3487 (-[HIDEventGenerator twoFingerTap:completionBlock:]):
3488 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3489 (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
3490 (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
3491 (-[HIDEventGenerator markerEventReceived:]):
3492 * WebKitTestRunner/ios/IOKitSPI.h: Added.
3493 * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
3494 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3495 (WTR::globalToContentCoordinates):
3496 (WTR::UIScriptController::singleTapAtPoint):
3497 (WTR::UIScriptController::doubleTapAtPoint):
3498 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
3499 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
3500 * WebKitTestRunner/ios/mainIOS.mm:
3501 (-[WebKitTestRunnerApp _handleHIDEvent:]):
3503 2015-09-30 Dana Burkart <dburkart@apple.com>
3505 git-add-reviewer should trim trailing spaces/newlines
3506 https://bugs.webkit.org/show_bug.cgi?id=149513
3508 Reviewed by Darin Adler.
3510 * Scripts/git-add-reviewer:
3513 2015-09-30 Eric Carlson <eric.carlson@apple.com>
3515 REGRESSION(r190262): User media unit test failures after r190262
3516 https://bugs.webkit.org/show_bug.cgi?id=149580
3518 Reviewed by Darin Adler.
3520 * WebKitTestRunner/TestController.cpp:
3521 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
3522 order to WKUserMediaPermissionRequestAllow.
3524 2015-09-30 Daniel Bates <dabates@apple.com>
3526 Add iOS builders and testers
3527 https://bugs.webkit.org/show_bug.cgi?id=149549
3529 Reviewed by Alexey Proskuryakov.
3531 Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
3532 builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
3534 * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
3535 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
3537 2015-09-30 Timothy Hatcher <timothy@apple.com>
3539 Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
3540 https://bugs.webkit.org/show_bug.cgi?id=149674
3542 Reviewed by Lucas Forschler.
3544 * WebKitLauncher/WebKitLauncher.entitlements: Added.
3545 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3547 2015-09-30 Jason Marcell <jmarcell@apple.com>
3549 BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
3550 have an associated trac instance.
3551 https://bugs.webkit.org/show_bug.cgi?id=149673
3553 Reviewed by Alexey Proskuryakov.
3555 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3556 (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
3557 have an associated trac instance.
3559 2015-09-30 Daniel Bates <dabates@apple.com>
3561 Prioritize testing latest build request on iOS test bots
3562 https://bugs.webkit.org/show_bug.cgi?id=149669
3564 Reviewed by Darin Adler.
3566 We should prioritize testing of the latest build request on the iOS test bots
3567 as we do for Mac and Windows test bots.
3569 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3570 (loadBuilderConfig):
3572 2015-09-30 Daniel Bates <dabates@apple.com>
3574 Add buildbot category for iOS builders and testers
3575 https://bugs.webkit.org/show_bug.cgi?id=149667
3577 Reviewed by Darin Adler.
3579 Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
3580 for iOS to the build.webkit.org home page.
3582 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3583 (loadBuilderConfig):
3584 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3586 2015-09-30 Daniel Bates <dabates@apple.com>
3588 Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
3589 (https://bugs.webkit.org/show_bug.cgi?id=149539)
3591 I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
3592 in <http://trac.webkit.org/changeset/190351>.
3594 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3595 (CompileWebKit.start):
3597 2015-09-30 Daniel Bates <dabates@apple.com>
3599 Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
3600 (https://bugs.webkit.org/show_bug.cgi?id=149539)
3602 {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
3603 respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
3605 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3606 (CompileWebKit.start):
3608 2015-09-30 Lucas Forschler <lforschler@apple.com>
3610 bot210 was configured for a queue instead of bot126.
3612 Unreviewed config.json fix.
3614 * BuildSlaveSupport/build.webkit.org-config/config.json:
3616 2015-09-30 Lucas Forschler <lforschler@apple.com>
3618 Bring El Capitan buildbot infrastructure online.
3619 https://bugs.webkit.org/show_bug.cgi?id=149605
3621 Reviewed by Darin Adler.
3623 * BuildSlaveSupport/build.webkit.org-config/config.json:
3625 2015-09-30 Tomas Popela <tpopela@redhat.com>
3627 [GTK] Deprecation warnings in DOMNodeTest
3628 https://bugs.webkit.org/show_bug.cgi?id=149663
3630 After the webkit_dom_document_get_elements_by_tag_name deprecation we
3631 need to update the tests to use webkit_dom_document_query_selector_all
3632 to avoid compilation warnings.
3634 Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection