2484c6f913e626de878858941f8c35fa1dd91849
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2
3         Add SPI WKNavigationResponse._downloadAttribute
4         https://bugs.webkit.org/show_bug.cgi?id=196755
5         <rdar://49587365>
6
7         Reviewed by Brady Eidson.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
10         (-[NavigationResponseTestDelegate navigationResponse]):
11         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
12         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
13         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
14         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
15         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
16         (readRequest):
17         (writeResponse):
18         (TEST):
19
20 2019-04-10  Tim Horton  <timothy_horton@apple.com>
21
22         Add modern API for overriding the page's specified viewport configuration
23         https://bugs.webkit.org/show_bug.cgi?id=167734
24         <rdar://problem/30331795>
25
26         Reviewed by Simon Fraser.
27
28         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
30
31 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
32
33         Add support for incremental bytecode cache updates
34         https://bugs.webkit.org/show_bug.cgi?id=195000
35
36         Reviewed by Filip Pizlo.
37
38         Exit when the initial run to generate bytecode fails.
39
40         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
41
42 2019-04-10  Alex Christensen  <achristensen@webkit.org>
43
44         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
45         https://bugs.webkit.org/show_bug.cgi?id=196744
46         <rdar://49415309>
47
48         Reviewed by Chris Dumez.
49
50         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
51         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
52
53 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
54
55         Add a way to opt into modern compatibility mode in layout tests
56         https://bugs.webkit.org/show_bug.cgi?id=196770
57         <rdar://problem/49777550>
58
59         Reviewed by Antoine Quint.
60
61         Add a new test option to enable modern compatibility mode in layout tests.
62
63         * WebKitTestRunner/TestController.cpp:
64         (WTR::updateTestOptionsFromTestHeader):
65         * WebKitTestRunner/TestController.h:
66         * WebKitTestRunner/TestOptions.h:
67         (WTR::TestOptions::hasSameInitializationOptions const):
68         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
69         (WTR::TestController::platformCreateWebView):
70         (WTR::TestController::enableModernCompatibilityMode):
71
72 2019-04-10  Andy Estes  <aestes@apple.com>
73
74         Try to fix the 32-bit watchOS build.
75
76         * TestWebKitAPI/cocoa/TestWKWebView.mm:
77         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
78
79 2019-04-10  Antoine Quint  <graouts@apple.com>
80
81         Enable Pointer Events on watchOS
82         https://bugs.webkit.org/show_bug.cgi?id=196771
83         <rdar://problem/49040909>
84
85         Reviewed by Dean Jackson.
86
87         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
88
89 2019-04-10  Philippe Normand  <pnormand@igalia.com>
90
91         Unreviewed. Fix WPE accessibility tests after r244059.
92
93         We are failing to load the injected bundle due to undefined symbol
94         AccessibilityUIElement::replaceTextInRange().
95
96         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
97         (WTR::AccessibilityUIElement::replaceTextInRange):
98
99 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
100
101         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
102         https://bugs.webkit.org/show_bug.cgi?id=196727
103
104         Reviewed by Fujii Hironori.
105
106         * MiniBrowser/win/WebKitBrowserWindow.cpp:
107         (WebKitBrowserWindow::create):
108
109 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
110
111         [ews-build] Add unit tests for PrintConfiguration
112         https://bugs.webkit.org/show_bug.cgi?id=196752
113
114         Reviewed by Dewei Zhu.
115
116         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
117
118 2019-04-09  Keith Rollin  <krollin@apple.com>
119
120         Unreviewed build maintenance -- update .xcfilelists.
121
122         * DumpRenderTree/DerivedSources-input.xcfilelist:
123         * DumpRenderTree/DerivedSources-output.xcfilelist:
124
125 2019-04-09  Zalan Bujtas  <zalan@apple.com>
126
127         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
128         https://bugs.webkit.org/show_bug.cgi?id=196743
129         <rdar://problem/43897551>
130
131         Reviewed by Tim Horton.
132
133         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
134         (TEST):
135
136 2019-04-09  Youenn Fablet  <youenn@apple.com>
137
138         Close service worker database on network process suspension
139         https://bugs.webkit.org/show_bug.cgi?id=196623
140         <rdar://problem/48930869>
141
142         Reviewed by Alex Christensen.
143
144         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
145
146 2019-04-09  Daniel Bates  <dabates@apple.com>
147
148         [iPad] Should open popover when the spacebar is pressed
149         https://bugs.webkit.org/show_bug.cgi?id=196360
150         <rdar://problem/49389129>
151
152         Reviewed by Brent Fulgham.
153
154         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
155
156         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
157         (WTR::UIScriptController::isShowingPopover const): Added.
158         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
159         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
160         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
161         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
162         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
163         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
164         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
165         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
166         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
167         (WTR::UIScriptController::isShowingPopover const): Added.
168         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
169         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
170         * TestRunnerShared/UIScriptContext/UIScriptController.h:
171         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
172         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
173         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
174         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
175         (-[TestRunnerWKWebView _willPresentPopover]): Added.
176         (-[TestRunnerWKWebView _didDismissPopover]): Added.
177         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
178         (WTR::UIScriptController::isShowingPopover const): Added.
179         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
180         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
181
182 2019-04-09  Alex Christensen  <achristensen@webkit.org>
183
184         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
185         https://bugs.webkit.org/show_bug.cgi?id=196665
186         <rdar://45115669>
187
188         Reviewed by Geoff Garen.
189
190         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
191         (goBack):
192         (+[SimpleLookupContext sharedLookupContext]):
193         (-[SimpleLookupContext lookUpURL:completionHandler:]):
194         (TEST):
195         (+[Simple3LookupContext sharedLookupContext]): Deleted.
196         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
197
198 2019-04-09  John Wilander  <wilander@apple.com>
199
200         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
201         https://bugs.webkit.org/show_bug.cgi?id=196558
202         <rdar://problem/47650245>
203
204         Reviewed by Youenn Fablet.
205
206         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
207         (TestWebKitAPI::TEST):
208             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
209
210 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
211
212         [CMake] Apple builds should use ICU_INCLUDE_DIRS
213         https://bugs.webkit.org/show_bug.cgi?id=196720
214
215         Reviewed by Konstantin Tokarev.
216
217         * TestWebKitAPI/PlatformMac.cmake:
218
219 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
220
221         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
222         https://bugs.webkit.org/show_bug.cgi?id=196694
223         <rdar://problem/48388734>
224
225         Rubber-stamped by Aakash Jain.
226
227         * Scripts/webkitpy/port/image_diff.py:
228         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
229         * Scripts/webkitpy/port/server_process.py:
230         (ServerProcess.has_available_stdout): Check if stdout has data in it.
231         (ServerProcess._wait_for_data_and_update_buffers_using_select):
232         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
233         * Scripts/webkitpy/port/server_process_mock.py:
234         (MockServerProcess.has_available_stdout):
235         * Scripts/webkitpy/port/server_process_unittest.py:
236         (TestServerProcess.serial_test_basic):
237
238 2019-04-09  Jer Noble  <jer.noble@apple.com>
239
240         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
241         https://bugs.webkit.org/show_bug.cgi?id=196097
242
243         Reviewed by Eric Carlson.
244
245         Drive-by bug fix: allow tests to play audio without a user gesture by default.
246
247         * DumpRenderTree/mac/DumpRenderTree.mm:
248         (resetWebPreferencesToConsistentValues):
249         * WebKitTestRunner/TestController.cpp:
250         (WTR::TestController::resetPreferencesToConsistentValues):
251
252 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
253
254         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
255         https://bugs.webkit.org/show_bug.cgi?id=196690
256
257         Reviewed by Michael Catanzaro.
258
259         * QueueStatusServer/config/queues.py:
260         * Scripts/webkitpy/common/config/ews.json:
261         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
262         (test_ews_name):
263
264 2019-04-09  Chris Dumez  <cdumez@apple.com>
265
266         Loads using loadHTMLString() cause flashing when process-swapping
267         https://bugs.webkit.org/show_bug.cgi?id=196714
268         <rdar://problem/49637354>
269
270         Reviewed by Antti Koivisto.
271
272         Add API test coverage.
273
274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
275
276 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
277
278         Unreviewed. Fix ATK accessibility tests after r244059.
279
280         We are failing to load the injected bundle due to undefined symbol
281         AccessibilityUIElement::replaceTextInRange().
282
283         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
284         (WTR::AccessibilityUIElement::replaceTextInRange):
285
286 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
287
288         AX: Support API: accessibilityReplaceRange:withText
289         https://bugs.webkit.org/show_bug.cgi?id=196636
290
291         Unreviewed build fix for Windows port.
292
293         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
294         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
295
296 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
297
298         [CMake][WinCairo] Separate copied headers into different directories
299         https://bugs.webkit.org/show_bug.cgi?id=196655
300
301         Reviewed by Michael Catanzaro.
302
303         * DumpRenderTree/CMakeLists.txt:
304         * MiniBrowser/win/CMakeLists.txt:
305         * TestWebKitAPI/CMakeLists.txt:
306         * TestWebKitAPI/PlatformWin.cmake:
307
308 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
309
310         Log stack-trace for run-webkit-tests when interrupted
311         https://bugs.webkit.org/show_bug.cgi?id=176393
312         <rdar://problem/34262310>
313
314         Reviewed by Lucas Forschler.
315
316         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
317         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
318         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
319         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
320         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
321         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
322         (main): Set handlers to log stack trace on interruption.
323
324 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
325
326         AX: Support API: accessibilityReplaceRange:withText
327         https://bugs.webkit.org/show_bug.cgi?id=196636
328
329         Unreviewed build fix for Windows port.
330
331         * DumpRenderTree/AccessibilityUIElement.cpp:
332         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
333
334 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
335
336         [ews-build] Scripts using Buildbot API have CORS error
337         https://bugs.webkit.org/show_bug.cgi?id=196709
338
339         Reviewed by Alexey Proskuryakov.
340
341         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
342
343 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
344
345         AX: Support API: accessibilityReplaceRange:withText
346         https://bugs.webkit.org/show_bug.cgi?id=196636
347
348         Reviewed by Daniel Bates.
349
350         * DumpRenderTree/AccessibilityUIElement.cpp:
351         (replaceTextInRangeCallback):
352         (AccessibilityUIElement::replaceTextInRange):
353         (AccessibilityUIElement::getJSClass):
354         * DumpRenderTree/AccessibilityUIElement.h:
355         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
356         (AccessibilityUIElement::replaceTextInRange):
357         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
358         (AccessibilityUIElement::replaceTextInRange):
359         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
360         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
361         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
362         (WTR::AccessibilityUIElement::replaceTextInRange):
363         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
364         (WTR::AccessibilityUIElement::replaceTextInRange):
365
366 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
367
368         [iOS] Do not allow starting selection drags when selection views are not visible
369         https://bugs.webkit.org/show_bug.cgi?id=196686
370         <rdar://problem/49399192>
371
372         Reviewed by Tim Horton.
373
374         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
375         also add some new API tests to cover scenarios where the web view is not first responder.
376
377         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
378         (TestWebKitAPI::TEST):
379         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
380
381         Add a switch to optionally make the web view first responder when starting the simulated drag.
382
383         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
384         (-[DragAndDropSimulator initWithWebView:]):
385         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
386
387 2019-04-08  Justin Fan  <justin_fan@apple.com>
388
389         [Web GPU] Fix Web GPU experimental feature on iOS
390         https://bugs.webkit.org/show_bug.cgi?id=196632
391
392         Reviewed by Myles C. Maxfield.
393
394         Properly make Web GPU available on iOS 11+.
395
396         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
397
398 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
399
400         [ews-build] Do not upload archive when Compile Fails
401         https://bugs.webkit.org/show_bug.cgi?id=196674
402
403         Reviewed by Alexey Proskuryakov.
404
405         * BuildSlaveSupport/ews-build/factories.py:
406         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
407         * BuildSlaveSupport/ews-build/steps.py:
408         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
409         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
410         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
411
412 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
413
414         Enable DFG on MIPS
415         https://bugs.webkit.org/show_bug.cgi?id=196689
416
417         Reviewed by Žan Doberšek.
418
419         Since the bytecode change, we enabled the baseline JIT on mips in
420         r240432, but DFG is still missing. With this change, all tests are
421         passing on a ci20 board.
422
423         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
424
425 2019-04-08  Philippe Normand  <pnormand@igalia.com>
426
427         [Flatpak] Second run update-webkitwpe-flatpak fails
428         https://bugs.webkit.org/show_bug.cgi?id=192702
429
430         Reviewed by Carlos Garcia Campos.
431
432         * flatpak/flatpakutils.py:
433         (FlatpakObject.flatpak): Fix typo.
434         (FlatpakPackage.install): When installing, also update to the configured remote commit.
435         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
436
437 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
438
439         [GTK][WPE] outlook.live.com displays old-fashioned UI
440         https://bugs.webkit.org/show_bug.cgi?id=196642
441
442         Reviewed by Carlos Garcia Campos.
443
444         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
445         (TestWebKitAPI::TEST): New Mac platform quirk test.
446
447 2019-04-07  Commit Queue  <commit-queue@webkit.org>
448
449         Unreviewed, rolling out r243956.
450         https://bugs.webkit.org/show_bug.cgi?id=196688
451
452         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
453         by aakashjain on #webkit).
454
455         Reverted changeset:
456
457         "Clicking "Go Back" from a safe browsing warning from an
458         iframe should navigate the WKWebView back to the previous
459         page"
460         https://bugs.webkit.org/show_bug.cgi?id=196665
461         https://trac.webkit.org/changeset/243956
462
463 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
464
465         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
466         https://bugs.webkit.org/show_bug.cgi?id=196669
467
468         Reviewed by Geoffrey Garen.
469
470         Added three new unit tests for WeakHashSet.
471
472         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
473         (WTF_WeakPtr.WeakHashSetConstObjects):
474         (WTF_WeakPtr.WeakHashSetComputesEmpty):
475         (WTF_WeakPtr.WeakHashSetComputeSize):
476
477 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
478
479         Hide next and previous form control buttons when WKWebView is editable
480         https://bugs.webkit.org/show_bug.cgi?id=196672
481         <rdar://problem/35625321>
482
483         Reviewed by Tim Horton.
484
485         Add a new API test.
486
487         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
488         (-[TestWKWebView lastTrailingBarButtonGroup]):
489         (TestWebKitAPI::TEST):
490         * TestWebKitAPI/ios/UIKitSPI.h:
491
492 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
493
494         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
495         https://bugs.webkit.org/show_bug.cgi?id=196077
496         <rdar://problem/49108202>
497
498         Reviewed by Chris Dumez.
499
500         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
501         on new web view.
502
503         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
504
505 2019-04-05  Saam Barati  <sbarati@apple.com>
506
507         Make compare-results understand MotionMark
508         https://bugs.webkit.org/show_bug.cgi?id=196666
509
510         Reviewed by Yusuke Suzuki.
511
512         * Scripts/compare-results:
513         (PLT5Results):
514         (detectMotionMark):
515         (detectMotionMark1_1):
516         (motionMarkResults):
517         (motionMark1_1Results):
518         (detectBenchmark):
519         (biggerIsBetter):
520         (main):
521
522 2019-04-05  Alex Christensen  <achristensen@webkit.org>
523
524         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
525         https://bugs.webkit.org/show_bug.cgi?id=196665
526         <rdar://45115669>
527
528         Reviewed by Geoff Garen.
529
530         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
531         (goBack):
532         (+[SimpleLookupContext sharedLookupContext]):
533         (-[SimpleLookupContext lookUpURL:completionHandler:]):
534         (TEST):
535         (+[Simple3LookupContext sharedLookupContext]): Deleted.
536         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
537
538 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
539
540         [ews-build] Add configuration and architecture for windows builders
541         https://bugs.webkit.org/show_bug.cgi?id=196660
542
543         Reviewed by Lucas Forschler.
544
545         * BuildSlaveSupport/ews-build/config.json:
546
547 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
548
549         webkitpy: Don't run subsequent rounds if interrupted
550         https://bugs.webkit.org/show_bug.cgi?id=196646
551
552         Reviewed by Aakash Jain.
553
554         * Scripts/webkitpy/layout_tests/controllers/manager.py:
555         (Manager.run): Bail out if interrupted.
556
557 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
558
559         Test sessionStorage in PSON private browsing mode
560         https://bugs.webkit.org/show_bug.cgi?id=196561
561
562         Reviewed by Alex Christensen.
563
564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
565
566 2019-04-05  Commit Queue  <commit-queue@webkit.org>
567
568         Unreviewed, rolling out r243833.
569         https://bugs.webkit.org/show_bug.cgi?id=196645
570
571         This change breaks build of WPE and GTK ports (Requested by
572         annulen on #webkit).
573
574         Reverted changeset:
575
576         "[CMake][WTF] Mirror XCode header directories"
577         https://bugs.webkit.org/show_bug.cgi?id=191662
578         https://trac.webkit.org/changeset/243833
579
580 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
581
582         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
583         https://bugs.webkit.org/show_bug.cgi?id=196635
584
585         Reviewed by Antti Koivisto.
586         
587         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
588         for a test to enable async frame scrolling via:
589             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
590         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
591         
592         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
593
594         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
595         (WTR::InjectedBundle::beginTesting):
596         * WebKitTestRunner/TestController.cpp:
597         (WTR::TestController::resetPreferencesToConsistentValues):
598
599 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
600
601         Use a correct LC_RPATH when building with ASan
602         https://bugs.webkit.org/show_bug.cgi?id=196576
603
604         Reviewed by David Kilzer.
605
606         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
607         so that ../Frameworks is checked. This is simpler and more reliable than updating
608         each SPC service xcconfig.
609
610 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
611
612         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
613         https://bugs.webkit.org/show_bug.cgi?id=196629
614
615         Reviewed by Lucas Forschler.
616
617         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
618
619 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
620
621         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
622         https://bugs.webkit.org/show_bug.cgi?id=196618
623
624         Reviewed by Lucas Forschler.
625
626         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
627         (StatusBubble): Added QUEUE_TRIGGERS.
628         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
629         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
630         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
631         its parent(builder).
632
633 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
634
635         [ews-app] Status-bubble steps are sometimes displayed in reverse order
636         https://bugs.webkit.org/show_bug.cgi?id=196625
637
638         Reviewed by Lucas Forschler.
639
640         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
641         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
642
643 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
644
645         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
646         https://bugs.webkit.org/show_bug.cgi?id=196630
647
648         Reviewed by Wenson Hsieh.
649
650         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
651
652 2019-04-04  Youenn Fablet  <youenn@apple.com>
653
654         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
655         https://bugs.webkit.org/show_bug.cgi?id=196543
656
657         Reviewed by Alex Christensen.
658
659         * WebKitTestRunner/TestController.cpp:
660         (WTR::TestController::generatePageConfiguration):
661
662 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
663
664         [ews-app] Status bubble should not display skipped buildbot steps
665         https://bugs.webkit.org/show_bug.cgi?id=196584
666
667         Reviewed by Lucas Forschler.
668
669         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
670
671 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
672
673         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
674         https://bugs.webkit.org/show_bug.cgi?id=196620
675
676         Reviewed by Lucas Forschler.
677
678         * BuildSlaveSupport/ews-app/ews/config.py:
679
680 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
681
682         [Win] DumpRenderTreeWatchDog.py is not checked into source
683         https://bugs.webkit.org/show_bug.cgi?id=196567
684         <rdar://problem/49525901>
685
686         Reviewed by Lucas Forschler.
687
688         This script is used on Win EWS bots to terminate hanging DRT processes.
689
690         * EWSTools/dumprendertreewatchdog.py: Added.
691
692 2019-04-04  Chris Dumez  <cdumez@apple.com>
693
694         Unreviewed, roll out r243858 which made tests time out.
695
696         Disable new API tests on Windows instead.
697
698         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
699         (TestWebKitAPI::TEST):
700
701 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
702
703         [ATK] Cleanup WebPageAccessibilityObjectAtk
704         https://bugs.webkit.org/show_bug.cgi?id=196537
705
706         Reviewed by Michael Catanzaro.
707
708         Also consider files under atk directories as exceptions for GObject conventions.
709
710         * Scripts/webkitpy/style/checkers/cpp.py:
711         (check_identifier_name_in_declaration):
712
713 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
714
715         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
716         https://bugs.webkit.org/show_bug.cgi?id=196588
717         <rdar://problem/49365787>
718
719         Unreviewed build fix for Windows port.
720
721         error C3861: 'kill': identifier not found
722
723         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
724         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
725
726 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
727
728         [ews-build] Cancel build and similar operations should have authentication
729         https://bugs.webkit.org/show_bug.cgi?id=196520
730
731         Reviewed by Dewei Zhu.
732
733         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
734         environment variables.
735
736 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
737
738         [ews-build] Do not trigger queues which are not in production yet
739         https://bugs.webkit.org/show_bug.cgi?id=196581
740
741         Reviewed by Dewei Zhu.
742
743         * BuildSlaveSupport/ews-build/config.json:
744
745 2019-04-03  Chris Dumez  <cdumez@apple.com>
746
747         Unreviewed, fix typo in the name of API test added in r243848.
748
749         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
750         (TestWebKitAPI::TEST):
751
752 2019-04-03  Chris Dumez  <cdumez@apple.com>
753
754         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
755         https://bugs.webkit.org/show_bug.cgi?id=196588
756         <rdar://problem/49365787>
757
758         Reviewed by Ryosuke Niwa.
759
760         Add API test coverage.
761
762         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
763         (TestWebKitAPI::nullJavaScriptCallback):
764         (TestWebKitAPI::didCrashCheckFrames):
765         (TestWebKitAPI::TEST):
766
767 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
768
769         run-webkit-tests: Upload test results (new results database)
770         https://bugs.webkit.org/show_bug.cgi?id=196577
771         <rdar://problem/34841155>
772
773         Reviewed by Lucas Forschler.
774
775         * Scripts/webkitpy/layout_tests/controllers/manager.py:
776         (Manager.run): Upload results after each device shard, since the configuration will be
777         different for each device.
778         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
779         uploaded to a results database.
780         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
781         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
782
783 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
784
785         -apple-trailing-word is needed for browser detection
786         https://bugs.webkit.org/show_bug.cgi?id=196575
787
788         Unreviewed.
789
790         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
791
792 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
793
794         [CMake][WTF] Mirror XCode header directories
795         https://bugs.webkit.org/show_bug.cgi?id=191662
796
797         Reviewed by Konstantin Tokarev.
798
799         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
800         builds.
801
802         * CMakeLists.txt:
803         * DumpRenderTree/CMakeLists.txt:
804         * DumpRenderTree/PlatformWin.cmake:
805         * MiniBrowser/win/CMakeLists.txt:
806         * TestWebKitAPI/CMakeLists.txt:
807         * TestWebKitAPI/PlatformWin.cmake:
808         * WebKitTestRunner/PlatformGTK.cmake:
809         * WebKitTestRunner/PlatformWin.cmake:
810
811 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
812
813         [ews-app] Status bubble should not display certain infrastructure status messages
814         https://bugs.webkit.org/show_bug.cgi?id=196550
815
816         Reviewed by Lucas Forschler.
817
818         Do not display the steps which are un-needed for end-user. This information is still avaiable
819         if the user click on the bubble and look at the Buildbot build.
820         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
821         (StatusBubble._steps_messages):
822         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
823
824 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
825
826         [ews-build] Use https for sending data to ews-app
827         https://bugs.webkit.org/show_bug.cgi?id=196492
828
829         Reviewed by Lucas Forschler.
830
831         * BuildSlaveSupport/ews-build/events.py:
832
833 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
834
835         Remove support for -apple-trailing-word
836         https://bugs.webkit.org/show_bug.cgi?id=196525
837
838         Reviewed by Zalan Bujtas.
839
840         This CSS property is nonstandard and not used.
841
842         * Scripts/webkitperl/FeatureList.pm:
843         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
844
845 2019-04-03  Youenn Fablet  <youenn@apple.com>
846
847         Add a test for DOMCache on multiple browsing in case of private browsing
848         https://bugs.webkit.org/show_bug.cgi?id=196524
849
850         Reviewed by Alex Christensen.
851
852         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
853         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
854
855 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
856
857         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
858         https://bugs.webkit.org/show_bug.cgi?id=196540
859
860         Reviewed by Aakash Jain.
861
862         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
863
864 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
865
866         Add plumbing for a compatibility mode preference in WebKit
867         https://bugs.webkit.org/show_bug.cgi?id=196005
868
869         Reviewed by Tim Horton.
870
871         Add new API tests.
872
873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
874         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
875
876 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
877
878         [WPE][GTK] Update libsrtp dependency package for Debian
879         https://bugs.webkit.org/show_bug.cgi?id=196528
880
881         Reviewed by Frédéric Wang.
882
883         * gtk/install-dependencies:
884         * wpe/install-dependencies:
885
886 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
887
888         [WK2] Add support for Window's beforeprint / afterprint events
889         https://bugs.webkit.org/show_bug.cgi?id=196478
890         <rdar://problem/49535124>
891
892         Unreviewed build fix for MSVC.
893
894         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
895
896         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
897
898         * WebKitTestRunner/TestController.cpp:
899         (WTR::printFrame): Use int and float literals.
900
901 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
902
903         [ews-build] Reassign bots to queues
904
905         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
906
907 2019-04-02  Chris Dumez  <cdumez@apple.com>
908
909         [WK2] Add support for Window's beforeprint / afterprint events
910         https://bugs.webkit.org/show_bug.cgi?id=196478
911
912         Reviewed by Alex Christensen.
913
914         Add minimal implementation for printFrame in WebKitTestRunner.
915
916         * WebKitTestRunner/TestController.cpp:
917         (WTR::printFrame):
918         (WTR::TestController::createOtherPage):
919         (WTR::TestController::createWebViewWithOptions):
920
921 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
922
923         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
924         https://bugs.webkit.org/show_bug.cgi?id=196491
925
926         Reviewed by Lucas Forschler.
927
928         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
929
930 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
931
932         [ews-build] Configure buildbot try credentials in environment variables
933         https://bugs.webkit.org/show_bug.cgi?id=196501
934
935         Reviewed by Lucas Forschler.
936
937         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
938         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
939         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
940
941 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
942
943         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
944         https://bugs.webkit.org/show_bug.cgi?id=196496
945         <rdar://problem/49521634>
946
947         Reviewed by Chris Dumez.
948
949         Add new API tests (see WebKit ChangeLog for more detail).
950
951         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
952         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
953         (TEST):
954
955 2019-04-02  David Kilzer  <ddkilzer@apple.com>
956
957         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
958         <https://webkit.org/b/196499>
959
960         Reviewed by Alexey Proskuryakov.
961
962         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
963         ENABLE_ADDRESS_SANITIZER.
964
965 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
966
967         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
968         https://bugs.webkit.org/show_bug.cgi?id=182757
969
970         Reviewed by Don Olmstead.
971
972         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
973         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
974
975 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
976
977         run-api-tests: Upload test results
978         https://bugs.webkit.org/show_bug.cgi?id=196323
979         <rdar://problem/49356714>
980
981         Reviewed by Lucas Forschler.
982
983         * Scripts/webkitpy/api_tests/manager.py:
984         (Manager):
985         (Manager.run): Upload results to a results database.
986         * Scripts/webkitpy/api_tests/run_api_tests.py:
987         (parse_args): Add upload arguments.
988         * Scripts/webkitpy/port/base.py:
989         (Port):
990         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
991         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
992         with commits from any other associated repositories.
993         * Scripts/webkitpy/port/device.py:
994         (Device):
995         (Device.build_version): Access build_versoin of underlying platform device.
996         * Scripts/webkitpy/port/ios_simulator_unittest.py:
997         (IOSSimulatorTest):
998         (IOSSimulatorTest.test_configuration_for_upload):
999         * Scripts/webkitpy/port/device_port.py:
1000         (DevicePort):
1001         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1002         the same as the machine uploading results.
1003         * Scripts/webkitpy/port/mac.py:
1004         (MacPort):
1005         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1006         * Scripts/webkitpy/port/mac_unittest.py:
1007         (MacTest):
1008         (MacTest.test_configuration_for_upload):
1009         * Scripts/webkitpy/xcode/simulated_device.py:
1010         (SimulatedDeviceManager._create_device_with_runtime):
1011         (SimulatedDevice.__init__): Create simulated device with a build_version.
1012         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1013         (test_existing_simulator):
1014
1015 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1016
1017         Remove extra newline characters (Follow-up fix to r243707)
1018
1019         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1020
1021 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1022
1023         [ews-app] Use API_KEY to accept results data
1024         https://bugs.webkit.org/show_bug.cgi?id=196461
1025
1026         Reviewed by Dewei Zhu.
1027
1028         * BuildSlaveSupport/ews-app/ews/views/results.py:
1029         (Results.post): Validate EWS_API_KEY before accepting any data.
1030         * BuildSlaveSupport/ews-build/events.py:
1031         (Events.sendData): Send EWS_API_KEY if available along with event data.
1032
1033 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1034
1035         Unable to copy and paste a PDF from Notes into Mail compose body
1036         https://bugs.webkit.org/show_bug.cgi?id=196442
1037         <rdar://problem/48573098>
1038
1039         Reviewed by Tim Horton.
1040
1041         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1042         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1043         to be specified on the item providers.
1044
1045         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1046         (TestWebKitAPI::mapItemForTesting):
1047         (TestWebKitAPI::contactItemForTesting):
1048
1049 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1050
1051         Make UIWKDocumentContext rects per-character instead of per-word
1052         https://bugs.webkit.org/show_bug.cgi?id=196459
1053
1054         Reviewed by Wenson Hsieh.
1055
1056         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1057         (TEST):
1058         Adjust test results due to switching to per-character rects.
1059
1060 2019-04-01  Chris Dumez  <cdumez@apple.com>
1061
1062         UIProcess crash when a prewarmed process is terminated
1063         https://bugs.webkit.org/show_bug.cgi?id=196451
1064         <rdar://problem/49245471>
1065
1066         Reviewed by Geoffrey Garen.
1067
1068         Add API test coverage.
1069
1070         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1071         (TEST):
1072
1073 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1074
1075         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1076         https://bugs.webkit.org/show_bug.cgi?id=196449
1077
1078         Reviewed by Lucas Forschler.
1079
1080         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1081         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1082         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1083         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1084
1085 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1086
1087         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1088         https://bugs.webkit.org/show_bug.cgi?id=196444
1089
1090         Reviewed by Lucas Forschler.
1091
1092         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1093
1094 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1095
1096         Add SPI to canonicalize NSURLs with WTF::URL
1097         https://bugs.webkit.org/show_bug.cgi?id=196415
1098         <rdar://problem/44980271>
1099
1100         Reviewed by Darin Adler.
1101
1102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1103         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1104         (TestWebKitAPI::TEST):
1105
1106 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1107
1108         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1109         https://bugs.webkit.org/show_bug.cgi?id=196441
1110
1111         Reviewed by Carlos Garcia Campos.
1112
1113         Don't cache the wpe_view_backend object that might not exist yet at the
1114         time of EventSenderProxy constructor invocation, but instead retrieve
1115         that object whenever it's required for event dispatching. This should
1116         avoid crashes in this constructor now that it's invoked before any
1117         PlatformWindow has been set up (as changed in r243496).
1118
1119         * WebKitTestRunner/EventSenderProxy.h:
1120         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1121         (WTR::viewBackend):
1122         (WTR::EventSenderProxy::EventSenderProxy):
1123         (WTR::EventSenderProxy::mouseDown):
1124         (WTR::EventSenderProxy::mouseUp):
1125         (WTR::EventSenderProxy::mouseMoveTo):
1126         (WTR::EventSenderProxy::mouseScrollBy):
1127         (WTR::EventSenderProxy::keyDown):
1128         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1129
1130 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1131
1132         [Win][WebKit] MiniBrowser should support high DPI display
1133         https://bugs.webkit.org/show_bug.cgi?id=196391
1134
1135         Reviewed by Alex Christensen.
1136
1137         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1138         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1139         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1140         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1141
1142 2019-03-31  Sam Weinig  <weinig@apple.com>
1143
1144         Remove more i386 specific configurations
1145         https://bugs.webkit.org/show_bug.cgi?id=196430
1146
1147         Reviewed by Alexey Proskuryakov.
1148
1149         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1150         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1151
1152 2019-03-31  Andy Estes  <aestes@apple.com>
1153
1154         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1155         https://bugs.webkit.org/show_bug.cgi?id=196433
1156         <rdar://problem/49293305>
1157
1158         Reviewed by Tim Horton.
1159
1160         Enhanced API test coverage to include all navigation response policy decisions in both
1161         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1162
1163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1164         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1165         (TestWebKitAPI::TEST):
1166         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1167         (readFile):
1168         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1169         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1170         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1171         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1172         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1173         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1174         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1175         (-[QuickLookDelegate _downloadDidStart:]):
1176         (-[QuickLookDelegate _download:didReceiveResponse:]):
1177         (-[QuickLookDelegate _download:didReceiveData:]):
1178         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1179         (-[QuickLookDelegate _downloadDidFinish:]):
1180         (-[QuickLookDelegate _download:didFailWithError:]):
1181         (-[QuickLookDelegate _downloadDidCancel:]):
1182         (-[QuickLookDelegate verifyDownload]):
1183         (runTest):
1184         (runTestDecideBeforeLoading):
1185         (runTestDecideAfterLoading):
1186         (TEST):
1187         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1188         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1189         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1190         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1191         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1192         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1193         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1194         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1195         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1196         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1197         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1198         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1199         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1200         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1201
1202 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1203
1204         [CMake] add testdfg as target with build-jsc
1205         https://bugs.webkit.org/show_bug.cgi?id=196393
1206
1207         Reviewed by Saam Barati.
1208
1209         Added testdfg as one of the targets to build when
1210         using CMake.
1211
1212         * Scripts/build-jsc:
1213
1214 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1215
1216         Delete WebMetal implementation in favor of WebGPU
1217         https://bugs.webkit.org/show_bug.cgi?id=195418
1218
1219         Reviewed by Dean Jackson.
1220
1221         * DumpRenderTree/mac/DumpRenderTree.mm:
1222         (enableExperimentalFeatures):
1223         (resetWebPreferencesToConsistentValues):
1224         * Scripts/webkitperl/FeatureList.pm:
1225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1227         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1228         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1229         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1230         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1231         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1232         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1233         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1234         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1235         (WTR::InjectedBundle::beginTesting):
1236         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1237         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1238         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1239
1240 2019-03-29  Chris Dumez  <cdumez@apple.com>
1241
1242         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1243         https://bugs.webkit.org/show_bug.cgi?id=196405
1244         <rdar://problem/49428130>
1245
1246         Reviewed by Wenson Hsieh.
1247
1248         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1249         the popover presentation methods to be no-ops. Use this in the new test added in
1250         r243523 so that we do not swizzle those methods for all tests. This is needed because
1251         those WatchOS tests rely on the popover getting presented and interactive.
1252
1253         * WebKitTestRunner/TestController.cpp:
1254         (WTR::updateTestOptionsFromTestHeader):
1255         * WebKitTestRunner/TestController.h:
1256         * WebKitTestRunner/TestOptions.h:
1257         (WTR::TestOptions::hasSameInitializationOptions const):
1258         * WebKitTestRunner/ios/TestControllerIOS.mm:
1259         (WTR::TestController::platformInitialize):
1260         (WTR::TestController::platformResetStateToConsistentValues):
1261
1262 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1263
1264         [Curl] Add Server Trust Evaluation Support.
1265         https://bugs.webkit.org/show_bug.cgi?id=191646
1266
1267         Reviewed by Fujii Hironori.
1268
1269         Implemented MiniBrowser UI for asking if user trusts the server.
1270
1271         * MiniBrowser/win/Common.cpp:
1272         (askServerTrustEvaluation):
1273         (replaceString):
1274         * MiniBrowser/win/Common.h:
1275         * MiniBrowser/win/MiniBrowserLib.rc:
1276         * MiniBrowser/win/MiniBrowserLibResource.h:
1277         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1278         (createPEMString):
1279         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1280         (WebKitBrowserWindow::canTrustServerCertificate):
1281         * MiniBrowser/win/WebKitBrowserWindow.h:
1282
1283 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1284
1285         Implement ResizeObserver.
1286         https://bugs.webkit.org/show_bug.cgi?id=157743
1287
1288         Reviewed by Simon Fraser.
1289
1290         Support resizeObserverEnabled webPreferences.
1291
1292         * DumpRenderTree/TestOptions.cpp:
1293         (TestOptions::TestOptions):
1294         * DumpRenderTree/TestOptions.h:
1295         * DumpRenderTree/mac/DumpRenderTree.mm:
1296         (setWebPreferencesForTestOptions):
1297         * DumpRenderTree/win/DumpRenderTree.cpp:
1298         (enableExperimentalFeatures):
1299         * Scripts/webkitperl/FeatureList.pm:
1300         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1301
1302 2019-03-28  John Wilander  <wilander@apple.com>
1303
1304         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1305         https://bugs.webkit.org/show_bug.cgi?id=196281
1306         <rdar://problem/48938748>
1307
1308         Reviewed by Alex Christensen.
1309
1310         This patch adds the function isStatisticsHasLocalStorage() to the
1311         TestRunner. With it, the page can query the WebsiteDataStore in the
1312         UI process to make sure that it sees LocalStorage.
1313
1314         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1315         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1316         (WTR::TestRunner::isStatisticsHasLocalStorage):
1317         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1318         * WebKitTestRunner/TestController.cpp:
1319         (WTR::TestController::isStatisticsHasLocalStorage):
1320         * WebKitTestRunner/TestController.h:
1321         * WebKitTestRunner/TestInvocation.cpp:
1322         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1323
1324 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1325
1326         API::Data::createWithoutCopying should do a null check before calling CFRelease
1327         https://bugs.webkit.org/show_bug.cgi?id=196276
1328         <rdar://problem/48059859>
1329
1330         Reviewed by Alex Christensen.
1331
1332         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1333
1334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1335         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1336         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1337         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1338         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1339         (TestWebKitAPI::TEST):
1340
1341 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1342
1343         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1344         https://bugs.webkit.org/show_bug.cgi?id=186276
1345
1346         Reviewed by Carlos Garcia Campos.
1347
1348         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1349         (webViewLoadChanged):
1350         (testWebResourceGetDataError):
1351         (testWebResourceGetDataEmpty):
1352         (beforeAll):
1353         (webViewloadChanged): Deleted.
1354
1355 2019-03-27  Andy Estes  <aestes@apple.com>
1356
1357         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1358         https://bugs.webkit.org/show_bug.cgi?id=196317
1359
1360         Reviewed by Dan Bernstein.
1361
1362         package-root copies built products into a staging directory using ditto(1), which does not
1363         follow symbolic links as it traverses a directory. Now that the files in
1364         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1365         itself, these become broken links when ditto'd into the staging directory.
1366
1367         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1368
1369         * Scripts/package-root:
1370
1371 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1372
1373         [ews-app] Update display text of Submit for ews analysis
1374         https://bugs.webkit.org/show_bug.cgi?id=196309
1375
1376         Reviewed by Dewei Zhu.
1377
1378         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1379
1380 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1381
1382         run-webkit-tests should check for leaks in WebKit processes
1383         <https://webkit.org/b/193772>
1384         <rdar://problem/46526680>
1385
1386         Reviewed by Ryosuke Niwa.
1387
1388         This works by doing the following:
1389         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1390           The list of child processes are returned one per line:
1391           process.name: pid
1392         - Run the "#LIST CHILD PROCESSES" command just before the
1393           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1394           processes on the ServerProcess object.
1395         - When the `--leaks` switch is handled, run check_for_leaks() on
1396           each child process after the main test harness.
1397
1398         * DumpRenderTree/mac/DumpRenderTree.mm:
1399         (handleControlCommand):
1400         - Use strncmp() instead of strcmp().
1401         - Add support for handling "#LIST CHILD PROCESSES" command.
1402
1403         * Scripts/webkitpy/port/base.py:
1404         (Port.check_for_leaks):
1405         * Scripts/webkitpy/port/darwin.py:
1406         (DarwinPort.check_for_leaks):
1407         - Rename redundant 'process_pid' argument to 'process_id'.
1408
1409         * Scripts/webkitpy/port/driver.py:
1410         (Driver.do_post_tests_work):
1411         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1412           longer the only command this sends to WebKitTestRunner.
1413         - If the `--leaks` switch is present, send the
1414           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1415           result using Port.set_webkit_processes().
1416         (Driver._parse_child_processes_output):
1417         - Add helper method to parse list of child process names and
1418           process IDs returned from WebKitTestRunner.
1419
1420         * Scripts/webkitpy/port/ios_device.py:
1421         (IOSDevicePort.check_for_leaks):
1422         - Rename redundant 'process_pid' argument to 'process_id'.
1423
1424         * Scripts/webkitpy/port/leakdetector.py:
1425         (LeakDetector._parse_leaks_output):
1426         - Return early if there is no leaks_output.
1427         (LeakDetector.check_for_leaks):
1428         - Rename redundant 'process_pid' argument to 'process_id'.
1429
1430         * Scripts/webkitpy/port/server_process.py:
1431         (ServerProcess.__init__):
1432         (ServerProcess.child_processes):
1433         (ServerProcess.set_child_processes):
1434         - Add instance variable to Port to store list of child process
1435           names and process IDs returned from WebKitTestRunner.
1436         (ServerProcess._start):
1437         - Clear self._child_processes.
1438         (ServerProcess.stop):
1439         - If self._child_processes is set, call
1440           self._port.check_for_leaks() for each child process.
1441
1442         * Scripts/webkitpy/port/server_process_unittest.py:
1443         (TrivialMockPort.check_for_leaks):
1444         - Rename redundant 'process_pid' argument to 'process_id'.
1445
1446         * Scripts/webkitpy/port/simulator_process.py:
1447         (SimulatorProcess.stop):
1448         - If self._child_processes is set, call
1449           self._port.check_for_leaks() for each child process.
1450
1451         * Scripts/webkitpy/port/watch_device.py:
1452         (WatchDevicePort.check_for_leaks):
1453         - Rename redundant 'process_pid' argument to 'process_id'.
1454
1455         * WebKitTestRunner/TestController.cpp:
1456         (WTR::TestController::dumpResponse):
1457         - Extract method from findAndDumpWorldLeaks() so that it may be
1458           reused by findAndDumpWebKitProcessIdentifiers().
1459         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1460         - Add method to output process name and process ID of both the
1461           WebContent and Networking processes.
1462         (WTR::TestController::findAndDumpWorldLeaks):
1463         - Fix missing newline in output when there were no abandoned
1464           documents.
1465         - Call dumpResponse() for extracted code.
1466         (WTR::TestController::handleControlCommand):
1467         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1468         - Use strncmp() instead of strcmp().
1469         - Call findAndDumpWebKitProcessIdentifiers() when
1470           "#LIST CHILD PROCESSES" command is sent.
1471         * WebKitTestRunner/TestController.h:
1472         (WTR::TestController::dumpResponse):
1473         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1474         - Declare methods.
1475
1476 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1477
1478         Unreviewed. Add GLib API test cases after r243434.
1479
1480         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1481         (testWebViewActiveURI):
1482         (serverCallback):
1483         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1484         (sendRequestCallback):
1485
1486 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1487
1488         Geolocation request not complete when watch request was started in a different web process
1489         https://bugs.webkit.org/show_bug.cgi?id=195996
1490
1491         Reviewed by Alex Christensen.
1492
1493         Add a test case.
1494
1495         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1496         (TestWebKitAPI::runJavaScriptAlert):
1497         (TestWebKitAPI::TEST):
1498
1499 2019-03-26  Keith Rollin  <krollin@apple.com>
1500
1501         Update the way generate-xcfilelists returns strings from functions
1502         https://bugs.webkit.org/show_bug.cgi?id=195975
1503         <rdar://problem/49040807>
1504
1505         Reviewed by Dean Jackson.
1506
1507         There are places where generate-xcfilelists executes assignments with
1508         statements like:
1509
1510             FOO=$(some_function)
1511
1512         where "some_function" return a string by echoing it. E.g.
1513
1514             some_function()
1515             {
1516                 echo "Hello, World"
1517             }
1518
1519         This is a common idiom, but it has a problem if "some_function" needs
1520         to call "exit" in an attempt to halt the entire script right then and
1521         there. Since "some_function" is called inside of $(), it's being
1522         executed in a sub-shell. Calling exit in that sub-shell simply exits
1523         that shell; it doesn't not exit the outer shell in which the main part
1524         of the script is still running. As such, the main script keeps
1525         executing when the intent was for the script to halt.
1526
1527         The solution to this is to use a different idiom for returning
1528         strings. The one we now is to pass in the name of the variable to
1529         receive the string result:
1530
1531             some_function()
1532             {
1533                 variable_name=$1
1534                 eval $variable_name ="Hello, World"
1535             }
1536
1537         The call site now looks like
1538
1539             some_function FOO
1540
1541         Because there's no invocation of a sub-shell, some_function can now
1542         call "exit" if it wants to, and the entire script will exit at that
1543         point.
1544
1545         * Scripts/generate-xcfilelists:
1546
1547 2019-03-26  Chris Dumez  <cdumez@apple.com>
1548
1549         Add basic layout test coverage for File Picker on iOS
1550         https://bugs.webkit.org/show_bug.cgi?id=196265
1551
1552         Reviewed by Wenson Hsieh.
1553
1554         Add layout test infrastructure to test the file picker on iOS.
1555
1556         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1557         (WTR::UIScriptController::dismissFilePicker):
1558         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1559         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1560         (WTR::UIScriptController::dismissFilePicker):
1561         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1562         * WebKitTestRunner/TestController.cpp:
1563         (WTR::TestController::createWebViewWithOptions):
1564         (WTR::updateTestOptionsFromTestHeader):
1565         * WebKitTestRunner/TestOptions.h:
1566         (WTR::TestOptions::hasSameInitializationOptions const):
1567         * WebKitTestRunner/ios/TestControllerIOS.mm:
1568         (overridePresentViewController):
1569         (WTR::TestController::platformInitialize):
1570         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1571         (WTR::UIScriptController::dismissFilePicker):
1572
1573 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1574
1575         Implement async paste method on UIWKInteractionViewProtocol
1576         https://bugs.webkit.org/show_bug.cgi?id=196267
1577         <rdar://problem/49236346>
1578
1579         Reviewed by Tim Horton.
1580
1581         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1582         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1583         are now a part of all iOS 12 internal SDKs.
1584
1585         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1586
1587         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1588         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1589
1590         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1591         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1592         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1593         * TestWebKitAPI/ios/UIKitSPI.h:
1594
1595 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1596
1597         [ews-build] Use PostgreSQL for ews.webkit.org database
1598         https://bugs.webkit.org/show_bug.cgi?id=196270
1599
1600         Reviewed by Lucas Forschler.
1601
1602         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1603
1604 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1605
1606         [ews] Reset simctl states on reboot
1607         https://bugs.webkit.org/show_bug.cgi?id=196260
1608
1609         Rubber-stamped by Aakash Jain.
1610
1611         * EWSTools/start-queue-mac.sh:
1612
1613 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1614
1615         [ews-build] Use PostgreSQL for ews-build database
1616         https://bugs.webkit.org/show_bug.cgi?id=196229
1617
1618         Reviewed by Lucas Forschler.
1619
1620         * BuildSlaveSupport/ews-build/master.cfg:
1621
1622 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1623
1624         [ews-build] Get master_hostname dynamically in master.cfg
1625         https://bugs.webkit.org/show_bug.cgi?id=196255
1626
1627         Reviewed by Lucas Forschler.
1628
1629         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1630         send events data in test mode.
1631
1632 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-app] Set db_constraint to False for Foreign Keys
1635         https://bugs.webkit.org/show_bug.cgi?id=196252
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-app/ews/models/build.py:
1640         * BuildSlaveSupport/ews-app/ews/models/step.py:
1641
1642 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1643
1644         [ews-build] is_test_mode_enabled should default to True
1645         https://bugs.webkit.org/show_bug.cgi?id=196248
1646
1647         Reviewed by Lucas Forschler.
1648
1649         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1650
1651 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1652
1653         [ews-app] Add webkitperl to ENABLED_QUEUES
1654         https://bugs.webkit.org/show_bug.cgi?id=196253
1655
1656         Reviewed by Lucas Forschler.
1657
1658         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1659
1660 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1661
1662         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1663         https://bugs.webkit.org/show_bug.cgi?id=196211
1664         rdar://problem/49110552
1665
1666         Reviewed by Tim Horton.
1667
1668         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1669         Make sure that EventSenderProxy always exists when running tests. We used to create
1670         it when resetting before the first test, which is a bit too late.
1671
1672         * WebKitTestRunner/TestController.h:
1673         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1674         (WTR::TestController::platformCreateWebView):
1675         (WTR::TestController::platformCreateOtherPage):
1676         (WTR::TestController::finishCreatingPlatformWebView):
1677         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1678         (WTR::PlatformWebView::PlatformWebView):
1679         Moved some code that made NSWindow use NSEvent during web view creation. We may
1680         need to move more if some other case us found, but this is enough for now.
1681
1682 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1683
1684         Unreviewed. Fix typo in GLib geolocation API after r243285.
1685
1686         gelocation -> geolocation.
1687
1688         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1689         (testGeolocationManagerWatchPosition):
1690
1691 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1692
1693         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1694         https://bugs.webkit.org/show_bug.cgi?id=196213
1695
1696         Reviewed by Geoff Garen.
1697
1698         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1699         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1700         (credentialWithIdentityAndKeychainPath):
1701         (-[ChallengeDelegate webView:didFinishNavigation:]):
1702         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1703         (TestWebKitAPI::TEST):
1704
1705 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1706
1707         Expected shouldn't assume its contained types are copyable
1708         https://bugs.webkit.org/show_bug.cgi?id=195986
1709
1710         Reviewed by JF Bastien.
1711
1712         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1713         (TestWebKitAPI::NonCopyable::operator== const):
1714         (TestWebKitAPI::NonCopyable::operator!= const):
1715         (TestWebKitAPI::TEST):
1716
1717 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1718
1719         Remove some now-unnecessary dynamic class lookup
1720         https://bugs.webkit.org/show_bug.cgi?id=196237
1721
1722         Reviewed by Simon Fraser.
1723
1724         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1725         (makeRequest):
1726         (TEST):
1727
1728 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1729
1730         Unreviewed, rolling out r243450.
1731
1732         AppleWin and WinCairo port builds get broken.
1733
1734         Reverted changeset:
1735
1736         "Add test for fix of #196095"
1737         https://bugs.webkit.org/show_bug.cgi?id=196097
1738         https://trac.webkit.org/changeset/243450
1739
1740 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1741
1742         Unreviewed, rolling out r243465.
1743         https://bugs.webkit.org/show_bug.cgi?id=196226
1744
1745         the test doesn't build (Requested by thorton on #webkit).
1746
1747         Reverted changeset:
1748
1749         "Do not terminate the NetworkProcess if a third party
1750         application sends a NSCredential with a SecIdentityRef"
1751         https://bugs.webkit.org/show_bug.cgi?id=196213
1752         https://trac.webkit.org/changeset/243465
1753
1754 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1755
1756         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1757         https://bugs.webkit.org/show_bug.cgi?id=196213
1758
1759         Reviewed by Geoff Garen.
1760
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1763         (credentialWithIdentityAndKeychainPath):
1764         (-[ChallengeDelegate webView:didFinishNavigation:]):
1765         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1766         (TestWebKitAPI::TEST):
1767
1768 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1769
1770         [ews-build] Gracefully handle missing patch_id in events
1771         https://bugs.webkit.org/show_bug.cgi?id=196216
1772
1773         Reviewed by Lucas Forschler.
1774
1775         * BuildSlaveSupport/ews-build/events.py:
1776
1777 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1778
1779         [ews-build] use lz4 compression for improving buildbot performance
1780         https://bugs.webkit.org/show_bug.cgi?id=196155
1781
1782         Reviewed by Lucas Forschler.
1783
1784         * BuildSlaveSupport/ews-build/master.cfg:
1785
1786 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1787
1788         Pull some API testing helper methods out of TestWKWebView
1789         https://bugs.webkit.org/show_bug.cgi?id=196212
1790
1791         Reviewed by Tim Horton.
1792
1793         Refactor some more API testing utility methods, so that they can be used in
1794         tests that do not use TestWKWebView.
1795
1796         * TestWebKitAPI/cocoa/TestWKWebView.h:
1797         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1798         (-[WKWebView loadTestPageNamed:]):
1799         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1800         (-[WKWebView synchronouslyLoadHTMLString:]):
1801         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1802         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1803         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1804         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1805         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1806
1807 2019-03-25  Jer Noble  <jer.noble@apple.com>
1808
1809         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1810         https://bugs.webkit.org/show_bug.cgi?id=196097
1811
1812         Reviewed by Eric Carlson.
1813
1814         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1815
1816         * DumpRenderTree/mac/DumpRenderTree.mm:
1817         (resetWebPreferencesToConsistentValues):
1818         * WebKitTestRunner/TestController.cpp:
1819         (WTR::TestController::resetPreferencesToConsistentValues):
1820
1821 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1822
1823         Pull IPadUserInterfaceSwizzler out into a separate header file
1824         https://bugs.webkit.org/show_bug.cgi?id=196193
1825
1826         Reviewed by Anders Carlsson.
1827
1828         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1829         be used in other API tests.
1830
1831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1832         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1833         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1834         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1835         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1836         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1837         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1838
1839 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1840
1841         Remove NavigatorContentUtils in WebCore/Modules
1842         https://bugs.webkit.org/show_bug.cgi?id=196070
1843
1844         Reviewed by Alex Christensen.
1845
1846         NavigatorContentUtils was to support the custom scheme spec [1].
1847         However, in WebKit side, no port has supported the feature in
1848         WebKit layer after EFL port was removed. So there has been the
1849         only IDL implementation of the NavigatorContentUtils in WebCore.
1850         So we don't need to keep the implementation in WebCore anymore.
1851
1852         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1853
1854         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1855
1856 2019-03-24  Andy Estes  <aestes@apple.com>
1857
1858         [watchOS] Remove unused Proximity Networking code
1859         https://bugs.webkit.org/show_bug.cgi?id=196188
1860
1861         Reviewed by Tim Horton.
1862
1863         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1864         (TEST):
1865
1866 2019-03-23  Keith Miller  <keith_miller@apple.com>
1867
1868         Refactor clz/ctz and fix getLSBSet.
1869         https://bugs.webkit.org/show_bug.cgi?id=196162
1870
1871         Reviewed by Saam Barati.
1872
1873         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1874
1875         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1876         (TestWebKitAPI::TEST):
1877
1878 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1879
1880         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1881         https://bugs.webkit.org/show_bug.cgi?id=196143
1882
1883         Reviewed by Michael Catanzaro.
1884
1885         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1886         directories.
1887
1888         * Scripts/webkitpy/style/checkers/cpp.py:
1889         (check_identifier_name_in_declaration):
1890         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1891         (WebKitStyleTest.test_names):
1892
1893 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1894
1895         [Flatpak] Manifest expanding fails for qt WPE extension
1896         https://bugs.webkit.org/show_bug.cgi?id=196148
1897
1898         Reviewed by Alex Christensen.
1899
1900         * flatpak/flatpakutils.py:
1901         (expand_submodules_recurse): The last recurse manifest expand
1902         iteration might lead to a single module so take it into account
1903         and don't try to recurse further.
1904
1905 2019-03-22  Chris Dumez  <cdumez@apple.com>
1906
1907         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1908         https://bugs.webkit.org/show_bug.cgi?id=195348
1909         <rdar://problem/48622090>
1910
1911         Reviewed by Alex Christensen.
1912
1913         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1914         to NO when test.options().shouldIgnoreMetaViewport is false.
1915
1916         * WebKitTestRunner/ios/TestControllerIOS.mm:
1917         (WTR::TestController::platformConfigureViewForTest):
1918
1919 2019-03-22  Chris Dumez  <cdumez@apple.com>
1920
1921         Prewarmed processes should be usable with any website data store
1922         https://bugs.webkit.org/show_bug.cgi?id=196104
1923
1924         Reviewed by Alex Christensen.
1925
1926         Add API test coverage.
1927
1928         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1929         (runInitialWarmedProcessUsedTest):
1930         (TEST):
1931
1932 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1933
1934         Back out local changes to Alex's Subversion working directory
1935
1936         They were accidentally committed.
1937
1938         * Scripts/webkitpy/common/system/abstractexecutive.py:
1939         (AbstractExecutive.wait_newest):
1940         * Scripts/webkitpy/common/system/executive.py:
1941         (Executive.running_pids):
1942         * Scripts/webkitpy/common/system/executive_mock.py:
1943         (MockExecutive.running_pids):
1944         * Scripts/webkitpy/common/system/executive_unittest.py:
1945         (ExecutiveTest.serial_test_running_pids):
1946         * Scripts/webkitpy/port/darwin.py:
1947         (DarwinPort.check_for_leaks):
1948         * Scripts/webkitpy/port/leakdetector.py:
1949         (LeakDetector.check_for_leaks):
1950         - This was the hack attached to Bug 193772.
1951
1952         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1953         (+[WebKitTestRunnerEvent mouseLocation]):
1954         - This works around a crash on an internal build.
1955
1956 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1957
1958         Fix the build after r243354
1959         https://bugs.webkit.org/show_bug.cgi?id=196138
1960         <rdar://problem/49145951>
1961
1962         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1963         (TEST):
1964         * TestWebKitAPI/ios/UIKitSPI.h:
1965
1966 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1967
1968         Adopt UIWKDocumentContext
1969         https://bugs.webkit.org/show_bug.cgi?id=196040
1970         <rdar://problem/48642440>
1971
1972         Reviewed by Ryosuke Niwa.
1973
1974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1975         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1976         (makeRequest):
1977         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1978         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1979         (applyStyle):
1980         (TEST):
1981         Add tests for UIWKDocumentContext.
1982
1983         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1984         (TEST):
1985         (recursiveFindWKContentView): Deleted.
1986         * TestWebKitAPI/cocoa/TestWKWebView.h:
1987         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1988         (recursiveFindWKContentView):
1989         (-[TestWKWebView wkContentView]):
1990         * TestWebKitAPI/ios/UIKitSPI.h:
1991         Share the WKContentView finding code between tests.
1992
1993 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1994
1995         [iOS WK2] Turn on async overflow scrolling by default
1996         https://bugs.webkit.org/show_bug.cgi?id=196011
1997         rdar://problem/48453859
1998
1999         Reviewed by Antti Koivisto.
2000         
2001         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2002         since so many basic layout tests have different results when compositing is triggered for
2003         overflow.
2004         
2005         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2006
2007         * WebKitTestRunner/TestController.cpp:
2008         (WTR::TestController::resetPreferencesToConsistentValues):
2009
2010 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2011
2012         [ews-build] Retry API test in case of failures
2013         https://bugs.webkit.org/show_bug.cgi?id=196004
2014
2015         Reviewed by Lucas Forschler.
2016
2017         * BuildSlaveSupport/ews-build/steps.py:
2018         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2019         (CompileWebKitToT.doStepIf): Ditto.
2020         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2021         (ReRunAPITests): Re-run API tests.
2022         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2023         (RunAPITestsWithoutPatch): Run API tests without patch.
2024         (RunAPITestsWithoutPatch.doStepIf):
2025         (RunAPITestsWithoutPatch.hideStepIf):
2026         (RunAPITestsWithoutPatch.evaluateCommand):
2027         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2028         (AnalyzeAPITestsResults.start):
2029         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2030         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2031         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2032         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2033
2034 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2035
2036         [ews-build] Update queues configurations
2037         https://bugs.webkit.org/show_bug.cgi?id=196074
2038
2039         Reviewed by Dewei Zhu.
2040
2041         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2042         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2043
2044 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2045
2046         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2047         https://bugs.webkit.org/show_bug.cgi?id=195680
2048         <rdar://problem/48903534>
2049
2050         Unreviewed infrastructure fix.
2051
2052         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2053         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2054
2055 2019-03-21  Andy Estes  <aestes@apple.com>
2056
2057         [iOS] Apple Pay should be available in documents with no user agent scripts
2058         https://bugs.webkit.org/show_bug.cgi?id=196061
2059         <rdar://problem/48649391>
2060
2061         Reviewed by Brady Eidson.
2062
2063         Added API tests and related infrastructure.
2064
2065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2066         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2067         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2068         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2069         (TestWebKitAPI::TEST):
2070         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2071         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2072         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2073         * TestWebKitAPI/cocoa/TestProtocol.mm:
2074         (-[TestProtocol startLoading]):
2075         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2076         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2077         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2078         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2079
2080 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2081
2082         REGRESSSION (r243297): webkitpy tests broken
2083         https://bugs.webkit.org/show_bug.cgi?id=196108
2084
2085         Reviewed by Aakash Jain.
2086
2087         r243297 updated contributors.json, which broke a few unit tests.
2088
2089         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2090         (IRCCommandTest.test_whois):
2091         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2092
2093 2019-03-21  Chris Dumez  <cdumez@apple.com>
2094
2095         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2096         https://bugs.webkit.org/show_bug.cgi?id=196041
2097         <rdar://problem/49083230>
2098
2099         Reviewed by Alex Christensen.
2100
2101         Add API test coverage.
2102
2103         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2104         (TEST):
2105
2106 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2107
2108         Add SPI to inform applications of WKContentRuleList actions
2109         https://bugs.webkit.org/show_bug.cgi?id=195965
2110         <rdar://problem/42664365>
2111
2112         Reviewed by Geoff Garen.
2113
2114         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2115         (TestWebKitAPI::allActionsForResourceLoad):
2116         (TestWebKitAPI::testRequest):
2117         (TestWebKitAPI::TEST_F):
2118         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2119         (Notification::description):
2120         (Notification::operator== const):
2121         (toVector):
2122         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2123         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2124         (makeContentRuleList):
2125         (TEST):
2126         (makeWarnContentRuleList): Deleted.
2127
2128 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2129
2130         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2131         https://bugs.webkit.org/show_bug.cgi?id=196088
2132
2133         Reviewed by Brian Burg.
2134
2135         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2136         Support checks when only one platform is specified. Also deprecate macosx() and
2137         force the use of macos() instead.
2138
2139         * Scripts/webkitpy/style/checkers/cpp.py:
2140         (check_min_versions_of_wk_api_available):
2141         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2142         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2143
2144 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2145
2146         Update status inactive committers' status to 'contributor'.
2147
2148         * Scripts/webkitpy/common/config/contributors.json:
2149
2150 2019-03-21  Xan Lopez  <xan@igalia.com>
2151
2152         [JSC][x86] Drop support for x87 floating point
2153         https://bugs.webkit.org/show_bug.cgi?id=194853
2154
2155         Reviewed by Don Olmstead.
2156
2157         Force SSE2 on x86/32bit builds.
2158
2159         * Scripts/webkitdirs.pm:
2160         (generateBuildSystemFromCMakeProject):
2161
2162 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2163
2164         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2165         https://bugs.webkit.org/show_bug.cgi?id=196073
2166
2167         Reviewed by Michael Catanzaro.
2168
2169         Add test cases to check functions and constructors with no arguments but receiving user data.
2170
2171         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2172         (checkUserData):
2173         (testJSCFunction):
2174         (fooCreateWithUserData):
2175         (testJSCClass):
2176
2177 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2178
2179         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2180
2181         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2182
2183         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2184
2185 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2186
2187         [GTK][WPE] Add API to provide geolocation information
2188         https://bugs.webkit.org/show_bug.cgi?id=195940
2189
2190         Reviewed by Michael Catanzaro.
2191
2192         Add a new test to check the new API.
2193
2194         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2195         (testGeolocationManagerCurrentPosition):
2196         (testGeolocationManagerWatchPosition):
2197         (beforeAll):
2198         (afterAll):
2199         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2200         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2201         (beforeAll): Ditto.
2202         * TestWebKitAPI/glib/CMakeLists.txt:
2203
2204 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2205
2206         [GLib] Returning G_TYPE_OBJECT from a method does not work
2207         https://bugs.webkit.org/show_bug.cgi?id=195574
2208
2209         Reviewed by Michael Catanzaro.
2210
2211         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2212
2213         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2214         (getGFile):
2215         (getParent):
2216         (createGString):
2217         (getGString):
2218         (getGStringCopyWillRaise):
2219         (getGStringCopy):
2220         (getGStringStr):
2221         (getGStringLen):
2222         (freeGString):
2223         (testJSCClass):
2224
2225 2019-03-20  Saam Barati  <sbarati@apple.com>
2226
2227         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2228         https://bugs.webkit.org/show_bug.cgi?id=195721
2229
2230         Reviewed by Filip Pizlo.
2231
2232         * Scripts/run-javascriptcore-tests:
2233
2234 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2235
2236         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2237         https://bugs.webkit.org/show_bug.cgi?id=196049
2238
2239         Reviewed by Tim Horton.
2240
2241         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2242         overflow scrolling in general, so rename it.
2243
2244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2245
2246 2019-03-20  Daniel Bates  <dabates@apple.com>
2247
2248         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2249         https://bugs.webkit.org/show_bug.cgi?id=196031
2250         <rdar://problem/49078172>
2251
2252         Reviewed by Tim Horton.
2253
2254         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2255         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2256         same code path used when the Done button is pressed to dismiss the <select> picker.
2257
2258         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2259         (TestWebKitAPI::TEST):
2260
2261 2019-03-20  Chris Dumez  <cdumez@apple.com>
2262
2263         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2264         https://bugs.webkit.org/show_bug.cgi?id=196029
2265         <rdar://problem/48954651>
2266
2267         Reviewed by Tim Horton.
2268
2269         Add API test coverage.
2270
2271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2272
2273 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2274
2275         [ews-build] Improve failure summary string for ApplyPatch step
2276         https://bugs.webkit.org/show_bug.cgi?id=195995
2277
2278         Reviewed by Alexey Proskuryakov.
2279
2280         * BuildSlaveSupport/ews-build/steps.py:
2281         (ApplyPatch.getResultSummary): Override getResultSummary.
2282
2283 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2284
2285         AX: Implement support for new meter ARIA role
2286         https://bugs.webkit.org/show_bug.cgi?id=195966
2287
2288         Reviewed by Chris Fleizach.
2289
2290         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2291         to AXLevelIndicator.
2292
2293         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2294
2295 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2296
2297         [WebAuthN] Implement FIDO AppID extension
2298         https://bugs.webkit.org/show_bug.cgi?id=143491
2299         <rdar://problem/48298273>
2300
2301         Reviewed by Brent Fulgham.
2302
2303         Add a test that covers the new flag of convertToU2fSignCommand.
2304
2305         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2306         (TestWebKitAPI::TEST):
2307         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2308         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2309         (TestWebKitAPI::TEST):
2310
2311 2019-03-19  Keith Rollin  <krollin@apple.com>
2312
2313         Add support for more platforms to generate-xcfilelists
2314         https://bugs.webkit.org/show_bug.cgi?id=195977
2315
2316         Reviewed by Alexey Proskuryakov.
2317
2318         generate-xcfilelists incorrectly complains when involved with building
2319         WebKit for iphonesimulator:
2320
2321             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2322             …
2323             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2324
2325         Address this by teaching generate-xcfilelists about more platforms.
2326
2327         * Scripts/generate-xcfilelists:
2328
2329 2019-03-19  John Wilander  <wilander@apple.com>
2330
2331         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2332         https://bugs.webkit.org/show_bug.cgi?id=195923
2333         <rdar://problem/49001272>
2334
2335         Reviewed by Alex Christensen.
2336
2337         This patch does the following to the TestRunner:
2338         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2339         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2340         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2341
2342         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2343         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2344         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2345         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2346         * WebKitTestRunner/TestController.cpp:
2347         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2348         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2349         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2350         * WebKitTestRunner/TestController.h:
2351         * WebKitTestRunner/TestInvocation.cpp:
2352         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2353
2354 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2355
2356         [CMake] Support more clang and gcc sanitizers
2357         https://bugs.webkit.org/show_bug.cgi?id=195956
2358
2359         Reviewed by Michael Catanzaro.
2360
2361         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2362
2363 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2364
2365         [ews-build] Improve summary for PrintConfiguration step
2366         https://bugs.webkit.org/show_bug.cgi?id=195945
2367
2368         Reviewed by Lucas Forschler.
2369
2370         * BuildSlaveSupport/ews-build/steps.py:
2371         (PrintConfiguration.getResultSummary): Override getResultSummary.
2372
2373 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2374
2375         [ews-build] Improve summary for CheckOutSource step
2376         https://bugs.webkit.org/show_bug.cgi?id=195963
2377
2378         Reviewed by Lucas Forschler.
2379
2380         * BuildSlaveSupport/ews-build/steps.py:
2381         (CheckOutSource.getResultSummary):
2382
2383 2019-03-19  Daniel Bates  <dabates@apple.com>
2384
2385         [iOS] Focus not preserved when switching between tabs
2386         https://bugs.webkit.org/show_bug.cgi?id=195820
2387         <rdar://problem/43614450>
2388
2389         Reviewed by Brent Fulgham.
2390
2391         Add tests to ensure that we restore focus when resigning and becoming first responder.
2392
2393         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2394         (TestWebKitAPI::TEST):
2395
2396 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2397
2398         Make WTFLogChannelState and WTFLogLevel enum classes
2399         https://bugs.webkit.org/show_bug.cgi?id=195904
2400
2401         Reviewed by Eric Carlson.
2402
2403         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2404         (TestWebKitAPI::TEST_F):
2405
2406 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2407
2408         [GStreamer][EME] Backported mssdemux protection data crash fix
2409         https://bugs.webkit.org/show_bug.cgi?id=195918
2410
2411         Reviewed by Philippe Normand.
2412
2413         * gstreamer/jhbuild.modules:
2414         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2415
2416 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2417
2418         Unreviewed, rolling out r243132.
2419
2420         Broke GTK build
2421
2422         Reverted changeset:
2423
2424         "Make WTFLogChannelState and WTFLogLevel enum classes"
2425         https://bugs.webkit.org/show_bug.cgi?id=195904
2426         https://trac.webkit.org/changeset/243132
2427
2428 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2429
2430         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2431
2432         * Scripts/webkitdirs.pm:
2433         (builtDylibPathForName): Adjust the shared library name that's changed
2434         with the API version bump in r243073.
2435
2436 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2437
2438         Make WTFLogChannelState and WTFLogLevel enum classes
2439         https://bugs.webkit.org/show_bug.cgi?id=195904
2440
2441         Reviewed by Eric Carlson.
2442
2443         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2444         (TestWebKitAPI::TEST_F):
2445
2446 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2447
2448         Disable flaky test added in r2431100
2449         https://webkit.org/b/195785
2450
2451         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2452         (TestWebKitAPI::TEST):
2453         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2454
2455 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2456
2457         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2458         https://bugs.webkit.org/show_bug.cgi?id=195916
2459
2460         Reviewed by Tim Horton.
2461
2462         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2463         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2464
2465 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2466
2467         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2468
2469         * Scripts/webkitpy/common/config/contributors.json:
2470
2471 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2472
2473         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2474         https://bugs.webkit.org/show_bug.cgi?id=195785
2475
2476         Reviewed by Geoffrey Garen.
2477
2478         * TestWebKitAPI/TCPServer.cpp: Added.
2479         (TestWebKitAPI::TCPServer::TCPServer):
2480         (TestWebKitAPI::TCPServer::~TCPServer):
2481         (TestWebKitAPI::TCPServer::socketBindListen):
2482         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2483         * TestWebKitAPI/TCPServer.h: Added.
2484         (TestWebKitAPI::TCPServer::port const):
2485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2486         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2487         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2488         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2489         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2490         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2491         (TestWebKitAPI::respondSlowly):
2492         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2493         (TestWebKitAPI::downloadAtRate):
2494         (TestWebKitAPI::TEST):
2495
2496 2019-03-18  Saam Barati  <sbarati@apple.com>
2497
2498         Add a plan file for JetStream 2
2499         https://bugs.webkit.org/show_bug.cgi?id=190734
2500
2501         Reviewed by Mark Lam.
2502
2503         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2504
2505 2019-03-18  Chris Dumez  <cdumez@apple.com>
2506
2507         Delay WebProcess launch until a load is triggered in a Web view
2508         https://bugs.webkit.org/show_bug.cgi?id=195758
2509         <rdar://problem/48126013>
2510
2511         Reviewed by Geoff Garen.
2512
2513         Add API test coverage. Also update some existing API tests to not expect
2514         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2515
2516         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2519         (TestWebKitAPI::TEST):
2520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2521         (TEST):
2522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2523         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2524         (TEST):
2525         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2526         (TEST):
2527         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2528
2529 2019-03-18  Xan Lopez  <xan@igalia.com>
2530
2531         [CMake] Prevent potential warning when determining $architecture
2532         https://bugs.webkit.org/show_bug.cgi?id=195891
2533
2534         Reviewed by Michael Catanzaro.
2535
2536         It's possible for generateBuildSystemForCMakeProject to be called
2537         before determineArchitecture() is ever called. This will make the
2538         first eq check with $architecture to be bogus (and print a
2539         warning). Change that to an eq check with architecture(), which
2540         implicitly calls determineArchitecture() if needed, and change all
2541         the other similar cases in the method in the same way to prevent
2542         future bugs like this one.
2543
2544         * Scripts/webkitdirs.pm:
2545         (generateBuildSystemFromCMakeProject):
2546
2547 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2548
2549         [WPE] Tarballs generated with “make dist” cannot build documentation
2550         https://bugs.webkit.org/show_bug.cgi?id=195885
2551
2552         Reviewed by Carlos Garcia Campos.
2553
2554         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2555
2556 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2557
2558         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2559         https://bugs.webkit.org/show_bug.cgi?id=195883
2560
2561         Reviewed by Carlos Garcia Campos.
2562
2563         * gtkdoc/gtkdoc.py:
2564         (GTKDoc._run_command): When commands fail to run, include the full command line for
2565         the program invocation and the output it has generated on the standard error stream.
2566
2567 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2568
2569         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2570         https://bugs.webkit.org/show_bug.cgi?id=195786
2571
2572         Reviewed by Philippe Normand.
2573
2574         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2575         * wpe/jhbuild.modules: Ditto.
2576
2577 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2578
2579         [ews-build] Don't run clean builds on EWS builders
2580         https://bugs.webkit.org/show_bug.cgi?id=195851
2581
2582         Reviewed by Geoffrey Garen.
2583
2584         * BuildSlaveSupport/ews-build/factories.py:
2585
2586 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2587
2588         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2589         https://bugs.webkit.org/show_bug.cgi?id=195849
2590
2591         Reviewed by Chris Dumez.
2592
2593         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2594
2595         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2596         (runWebsiteDataStoreCustomPaths):
2597
2598 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2599
2600         webkitpy: Upload test results
2601         https://bugs.webkit.org/show_bug.cgi?id=195755
2602         <rdar://problem/48896182>
2603
2604         Reviewed by Aakash Jain.
2605
2606         Establish a new format for uploading results that is not tied to layout tests, apply
2607         that format to webkitpy tests.
2608
2609         * Scripts/webkitpy/common/checkout/scm/git.py:
2610         (Git.native_branch): Return what branch the current checkout is on.
2611         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2612         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2613         * Scripts/webkitpy/common/checkout/scm/svn.py:
2614         (SVN.native_branch): Ditto.
2615         * Scripts/webkitpy/common/system/platforminfo.py:
2616         (PlatformInfo.build_version): Return a build version for Mac.
2617         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2618         (MockPlatformInfo.__init__):
2619         (MockPlatformInfo.build_version):
2620         * Scripts/webkitpy/results: Added.
2621         * Scripts/webkitpy/results/__init__.py: Added.
2622         * Scripts/webkitpy/results/options.py: Added.
2623         (upload_options): OptParse list for upload options.
2624         * Scripts/webkitpy/results/upload.py: Added.
2625         (Upload): Class which enforces the upload format expected by the results server.
2626         (Upload.Expectations):
2627         (Upload.create_configuration):
2628         (Upload.create_commit):
2629         (Upload.create_details):
2630         (Upload.create_run_stats):
2631         (Upload.create_test_result):
2632         (Upload.__init__):
2633         (Upload.Encoder): Encode Upload object as json.
2634         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2635         * Scripts/webkitpy/results/upload_unittest.py: Added.
2636         * Scripts/webkitpy/test/main.py:
2637         (Tester._parse_args): Add upload arguments.
2638         (Tester._run_tests): Allow results to be uploaded.
2639         * Scripts/webkitpy/test/runner.py:
2640         (Runner.__init__): Record which tests were run, rather than just counting them.
2641         (Runner.handle):
2642         * Scripts/webkitpy/test/runner_unittest.py:
2643         (RunnerTest.test_run):
2644         * Scripts/webkitpy/thirdparty/__init__.py:
2645         (AutoinstallImportHook.find_module): Add requests auto-install.
2646         (AutoinstallImportHook._install_requests):
2647         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2648         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2649
2650 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2651
2652         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2653         https://bugs.webkit.org/show_bug.cgi?id=195810
2654
2655         Reviewed by Tim Horton.
2656
2657         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2658         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2659         ending certain layout tests.
2660
2661         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2662         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2663         (-[TestRunnerWKWebView dealloc]):
2664         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2665
2666         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2667         helper method when destroying the web view, and when resetting state between tests.
2668
2669         * WebKitTestRunner/ios/TestControllerIOS.mm:
2670         (WTR::TestController::platformResetStateToConsistentValues):
2671
2672         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2673
2674 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2675
2676         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2677         https://bugs.webkit.org/show_bug.cgi?id=190350
2678         <rdar://problem/45089503>
2679
2680         Reviewed by Geoffrey Garen.
2681
2682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2683         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2684         (TEST):
2685         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2686         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2687         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2688         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2689         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2690         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2691         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2692         (runTest):
2693         (createDirectories):
2694         (TEST):
2695         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2696         (TEST):
2697         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2698         (TEST):
2699
2700 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2701
2702         Add support to WebPage for getting the contents as an attributed string.
2703         https://bugs.webkit.org/show_bug.cgi?id=195636
2704         rdar://problem/45055697
2705
2706         Reviewed by Tim Horton.
2707
2708         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2709         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2710
2711 2019-03-15  Chris Dumez  <cdumez@apple.com>
2712
2713         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2714         https://bugs.webkit.org/show_bug.cgi?id=195747
2715
2716         Reviewed by Geoff Garen.
2717
2718         Add API test coverage.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2721
2722 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2723
2724         Unreviewed, rolling out r242952.
2725
2726         Causing API failures on iOS Simulator
2727
2728         Reverted changeset:
2729
2730         "[PSON] Make sure the WebProcessCache is leverage when
2731         relaunching a process after termination"
2732         https://bugs.webkit.org/show_bug.cgi?id=195747
2733         https://trac.webkit.org/changeset/242952
2734
2735 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2736
2737         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2738         https://bugs.webkit.org/show_bug.cgi?id=195740
2739
2740         Reviewed by Ross Kirsling.
2741
2742         window.open doesn't work for WebKitBrowserWindow because it is not
2743         implemented yet.
2744
2745         1. Implemented createNewPage callback of WKPageUIClient.
2746         2. Changed MainWindow to take a BrowserWindow factory function
2747           instead of BrowserWindowType to be flexible to create
2748           BrowserWindow with extra settings.
2749         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2750           because it is not relevant with MainWindow anymore.
2751
2752         * MiniBrowser/win/Common.cpp:
2753         (parseCommandLine):
2754         * MiniBrowser/win/Common.h:
2755         (CommandLineOptions::CommandLineOptions):
2756         * MiniBrowser/win/MainWindow.cpp:
2757         (MainWindow::MainWindow):
2758         (MainWindow::create):
2759         (MainWindow::init):
2760         (MainWindow::WndProc):
2761         * MiniBrowser/win/MainWindow.h:
2762         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2763         (PrintWebUIDelegate::createWebViewWithRequest):
2764         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2765         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2766         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2767         (WebKitBrowserWindow::updateProxySettings):
2768         (WebKitBrowserWindow::createNewPage):
2769         * MiniBrowser/win/WebKitBrowserWindow.h:
2770         * MiniBrowser/win/WinMain.cpp:
2771         (wWinMain):
2772
2773 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2774
2775         Make it possible to test scrolling tree layer manipulation more easily
2776         https://bugs.webkit.org/show_bug.cgi?id=195780
2777
2778         Reviewed by Tim Horton.
2779         
2780         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2781         cuts off communication of scrolling tree scrolls back to the web process
2782         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2783         allows tests to trigger scrolls which run the scrolling tree layer positioning
2784         logic, but never get another commit from the web process that might mask
2785         scrolling tree bugs.
2786         
2787         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2788         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2789         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2790
2791         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2792         (WTR::UIScriptController::scrollUpdatesDisabled const):
2793         (WTR::UIScriptController::setScrollUpdatesDisabled):
2794         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2795         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2796         (WTR::UIScriptController::scrollUpdatesDisabled const):
2797         (WTR::UIScriptController::setScrollUpdatesDisabled):
2798         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2799         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2800         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2801         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2802         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2803         * WebKitTestRunner/ios/TestControllerIOS.mm:
2804         (WTR::TestController::platformResetStateToConsistentValues):
2805         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2806         (WTR::UIScriptController::scrollUpdatesDisabled const):
2807         (WTR::UIScriptController::setScrollUpdatesDisabled):
2808
2809 2019-03-14  Youenn Fablet  <youenn@apple.com>
2810
2811         Move IDB storage in private browsing mode to NetworkProcess
2812         https://bugs.webkit.org/show_bug.cgi?id=195602
2813
2814         Reviewed by Brady Eidson.
2815
2816         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2817         (TEST):
2818
2819 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-build] Make descriptionDone messages more readable
2822         https://bugs.webkit.org/show_bug.cgi?id=195760
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-build/steps.py:
2827         * BuildSlaveSupport/ews-build/steps_unittest.py:
2828
2829 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2830
2831         [ews-build] Generate status-bubble hover-over messages
2832         https://bugs.webkit.org/show_bug.cgi?id=195680
2833
2834         Reviewed by Lucas Forschler.
2835
2836         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2837         (StatusBubble):
2838         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2839         on hover-over.
2840         (StatusBubble._iso_time):
2841         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2842         hover-over message.
2843         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2844
2845 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2846
2847         [ews-app] Gracefully handle the case when state_string is None
2848         https://bugs.webkit.org/show_bug.cgi?id=195753
2849
2850         Reviewed by Lucas Forschler.
2851
2852         * BuildSlaveSupport/ews-app/ews/models/build.py:
2853         * BuildSlaveSupport/ews-app/ews/models/step.py:
2854
2855 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2856
2857         [ews-app] Status bubble display pending for currently running build step
2858         https://bugs.webkit.org/show_bug.cgi?id=195744
2859
2860         Reviewed by Lucas Forschler.
2861
2862         * BuildSlaveSupport/ews-build/events.py:
2863         (Events.stepStarted): If state_string is pending, replace it with step name.
2864
2865 2019-03-14  Chris Dumez  <cdumez@apple.com>
2866
2867         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2868         https://bugs.webkit.org/show_bug.cgi?id=195750
2869
2870         Reviewed by Geoffrey Garen.
2871
2872         Add API test coverage.
2873
2874         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2875         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2876         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2877         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2878
2879 2019-03-14  Chris Dumez  <cdumez@apple.com>
2880
2881         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2882         https://bugs.webkit.org/show_bug.cgi?id=195747
2883
2884         Reviewed by Geoff Garen.
2885
2886         Add API test coverage.
2887
2888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2889
2890 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2891
2892         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2893         https://bugs.webkit.org/show_bug.cgi?id=195725
2894         <rdar://problem/48545062>
2895
2896         Reviewed by Tim Horton.
2897
2898         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2899         handler is nil.
2900
2901         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2902         (TestWebKitAPI::TEST):
2903
2904 2019-03-13  Sam Weinig  <sam@webkit.org>
2905
2906         Add utility function to allow easy reverse range-based iteration of a container
2907         https://bugs.webkit.org/show_bug.cgi?id=195542
2908
2909         Reviewed by Antti Koivisto.
2910
2911         * TestWebKitAPI/CMakeLists.txt:
2912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2913         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2914         (TestWebKitAPI::TEST):
2915         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2916
2917 2019-03-13  Chris Dumez  <cdumez@apple.com>
2918
2919         Use a ServiceWorker process per registrable domain
2920         https://bugs.webkit.org/show_bug.cgi?id=195649
2921
2922         Reviewed by Youenn Fablet.
2923
2924         Update API test coverage.
2925
2926         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2927
2928 2019-03-13  Chris Dumez  <cdumez@apple.com>
2929
2930         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2931         https://bugs.webkit.org/show_bug.cgi?id=195684
2932         <rdar://problem/48294714>
2933
2934         Reviewed by Antti Koivisto.
2935
2936         Add API test coverage.
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2939
2940 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2941
2942         [ews-app] Remove unused patch view
2943         https://bugs.webkit.org/show_bug.cgi?id=195669
2944
2945         Reviewed by Lucas Forschler.
2946
2947         * BuildSlaveSupport/ews-app/ews/urls.py:
2948         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2949
2950 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2951
2952         [ews-app] Use Buildbot result code variables
2953         https://bugs.webkit.org/show_bug.cgi?id=195668
2954
2955         Reviewed by Alexey Proskuryakov.
2956
2957         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2958         (Buildbot): Added Buildbot result code variables.
2959         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2960         (StatusBubble._build_bubble): Used Buildbot result code variables.
2961
2962 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2963
2964         [Flatpak] Expand submodule recursively
2965         https://bugs.webkit.org/show_bug.cgi?id=195672
2966
2967         Building WPE with flatpak was impossible without that as it was raising an exception.
2968         Also update wpebackend-fdo to match what is built in jhbuild
2969
2970         Reviewed by Philippe Normand.
2971
2972         * flatpak/flatpakutils.py:
2973         (expand_submodules_recurse):
2974         (expand_manifest):
2975         * flatpak/org.webkit.WPEModules.yaml:
2976
2977 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2978
2979         [ews-app] status bubble should be hidden for certain builds
2980         https://bugs.webkit.org/show_bug.cgi?id=194597
2981
2982         Reviewed by Dewei Zhu.
2983
2984         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2985         (StatusBubble._build_bubble):
2986         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2987         because the patch didn't have relevant changes.
2988         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2989         in production yet.
2990
2991 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2992
2993         [Win] Fix a slew of simple clang-cl warnings.
2994         https://bugs.webkit.org/show_bug.cgi?id=195652
2995
2996         Reviewed by Don Olmstead.
2997
2998         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2999         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3000
3001 2019-03-12  Justin Fan  <justin_fan@apple.com>
3002
3003         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3004         https://bugs.webkit.org/show_bug.cgi?id=195518
3005         <rdar://problem/46322356>
3006
3007         Reviewed by Myles C. Maxfield.
3008
3009         * DumpRenderTree/DerivedSources-input.xcfilelist:
3010         * DumpRenderTree/DerivedSources-output.xcfilelist:
3011
3012 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3013
3014         Unreviewed, rolling out r242825.
3015         https://bugs.webkit.org/show_bug.cgi?id=195648
3016
3017         "Broke webkitpy tests with my change to
3018         lldb_dump_class_layout.py" (Requested by rmorisset on
3019         #webkit).
3020
3021         Reverted changeset:
3022
3023         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3024         classes with suspicious padding"
3025         https://bugs.webkit.org/show_bug.cgi?id=195573
3026         https://trac.webkit.org/changeset/242825
3027
3028 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-build] Show status bubbles while the patch is waiting in queue
3031         https://bugs.webkit.org/show_bug.cgi?id=195618
3032
3033         Reviewed by Lucas Forschler.
3034
3035         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3036         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3037         enabled in initial deployment.
3038         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3039         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3040         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3041         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3042         (StatusBubble._build_bubbles_for_patch):
3043
3044 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3045
3046         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3047         https://bugs.webkit.org/show_bug.cgi?id=195573
3048
3049         Reviewed by Simon Fraser.
3050
3051         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3052
3053         * Scripts/dump-class-layout:
3054         (main):
3055         * lldb/lldb_dump_class_layout.py:
3056         (ClassLayout.__init__):
3057         (ClassLayout._compute_padding_recursive):
3058         (LLDBDebuggerInstance.dump_layout_for_classname):
3059         (LLDBDebuggerInstance):
3060         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3061         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3062
3063 2019-03-12  Chris Dumez  <cdumez@apple.com>
3064
3065         Device Orientation access permission should be denied unless explicitly granted by the client
3066         https://bugs.webkit.org/show_bug.cgi?id=195625
3067
3068         Reviewed by Youenn Fablet.
3069
3070         add API test coverage.
3071
3072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3073         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3074         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3075         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3076         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3077         (runDeviceOrientationTest):
3078         (TEST):
3079         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3080         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3081
3082 2019-03-12  Jer Noble  <jer.noble@apple.com>
3083
3084         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3085         https://bugs.webkit.org/show_bug.cgi?id=195137
3086         <rdar://problem/48810307>
3087
3088         Reviewed by Eric Carlson.
3089
3090         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3091         (TestWebKitAPI::TEST):
3092
3093 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3094
3095         [ews-build] Change urls from uat to production
3096         https://bugs.webkit.org/show_bug.cgi?id=195566
3097
3098         Reviewed by Lucas Forschler.
3099
3100         * BuildSlaveSupport/ews-app/ews/config.py:
3101         * BuildSlaveSupport/ews-build/events.py:
3102         * BuildSlaveSupport/ews-build/steps.py:
3103
3104 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3105
3106         [ews-build] change max_builds for local-worker to 1
3107         https://bugs.webkit.org/show_bug.cgi?id=195568
3108
3109         Reviewed by Lucas Forschler.
3110
3111         * BuildSlaveSupport/ews-build/loadConfig.py:
3112
3113 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3114
3115         Fix the build
3116
3117         * TestRunnerShared/spi/PencilKitTestSPI.h:
3118         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3119
3120 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3121
3122         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3123         https://bugs.webkit.org/show_bug.cgi?id=194131
3124
3125         Reviewed by Michael Catanzaro.
3126
3127         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3128         (uriChanged):
3129         (testUnfinishedSubresourceLoad):
3130         (serverCallback):
3131         (beforeAll):
3132
3133 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3134
3135         WTF::Expected should use std::addressof instead of operator&
3136         https://bugs.webkit.org/show_bug.cgi?id=195604
3137
3138         Reviewed by Myles Maxfield.
3139
3140         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3141         (TestWebKitAPI::Unique::Unique):
3142         (TestWebKitAPI::Unique::operator&):
3143         (TestWebKitAPI::TEST):
3144
3145 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3146
3147         Add Optional to Forward.h.
3148         https://bugs.webkit.org/show_bug.cgi?id=195586
3149
3150         Reviewed by Darin Adler.
3151
3152         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3153         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3154         Remove unnecessary includes from headers.
3155
3156 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3157
3158         Add testing API to hit-test and scroll overflow scrollers
3159         https://bugs.webkit.org/show_bug.cgi?id=195278
3160
3161         Reviewed by Antti Koivisto.
3162         
3163         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3164         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3165         
3166         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3167
3168         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3169         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3170         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3171         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3172         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3173         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3174         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3175         (WTR::enclosingScrollViewIncludingSelf):
3176         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3177
3178 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3179
3180         API test WebKit.RequestTextInputContext fails on iOS
3181         https://bugs.webkit.org/show_bug.cgi?id=195585
3182
3183         Reviewed by Wenson Hsieh and Simon Fraser.
3184
3185         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3186         (applyStyle):
3187         (TEST):
3188         Add a viewport, so that the coordinates match up on iOS.
3189         Scroll by moving the UIScrollView's contentOffset.
3190
3191 2019-03-11  Chris Dumez  <cdumez@apple.com>
3192
3193         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3194         https://bugs.webkit.org/show_bug.cgi?id=195506
3195         <rdar://problem/48733477>
3196
3197         Reviewed by Alex Christensen.
3198
3199         Add API test coverage.
3200
3201         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3202
3203 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3204
3205         Adding myself to contributors.json
3206
3207         Unreviewed, addming myself to contributors.json .
3208
3209         * Scripts/webkitpy/common/config/contributors.json:
3210
3211 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3212
3213         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3214         https://bugs.webkit.org/show_bug.cgi?id=195511
3215         <rdar://problem/44873269>
3216
3217         Reviewed by Darin Adler.
3218
3219         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3220         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3221         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3222         (TEST_F):
3223
3224 2019-03-11  Chris Dumez  <cdumez@apple.com>
3225
3226         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3227         https://bugs.webkit.org/show_bug.cgi?id=195561
3228
3229         Reviewed by Youenn Fablet.
3230
3231         Make sure the JS in the test requests for permission to receive device orientation events.
3232
3233         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3234
3235 2019-03-11  Youenn Fablet  <youenn@apple.com>
3236
3237         Allow storage quota increase by default in WTR
3238         https://bugs.webkit.org/show_bug.cgi?id=195541
3239
3240         Reviewed by Geoffrey Garen.
3241
3242         Allow storage quota increase by default in WTR.
3243         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3244         Use this for tests that explicitly need cache increase.
3245
3246         Instead of increasing quota by 2, make sure the next request is
3247         granted by adding all given parameters.
3248
3249         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3250         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3251         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3252         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3254         * WebKitTestRunner/TestController.cpp:
3255         (WTR::TestController::setAllowStorageQuotaIncrease):
3256         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3257         * WebKitTestRunner/TestController.h:
3258         * WebKitTestRunner/TestInvocation.cpp:
3259         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3260         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3261         (WTR::TestController::cocoaResetStateToConsistentValues):
3262         (WTR::TestController::setAllowStorageQuotaIncrease):
3263         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3264         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3265         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3266
3267 2019-03-11  Xan Lopez  <xan@igalia.com>
3268
3269         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3270         https://bugs.webkit.org/show_bug.cgi?id=194147
3271
3272         Reviewed by Michael Saboff.
3273
3274         To make --32-bit work correctly on Linux/64bit we need to:
3275
3276         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3277         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3278         unfortunately CMake only allows us to do this during
3279         crosscompilation, which is overkill here.
3280         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3281         pkg-config detection module uses the x86 .pc files instead of the
3282         x86_64 ones.
3283         - Set the -m32 flags for the compiler.
3284
3285         * Scripts/webkitdirs.pm:
3286         (generateBuildSystemFromCMakeProject):
3287
3288 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3289
3290         Add MotionMark-1.1 plan file for run-benchmark script.
3291         https://bugs.webkit.org/show_bug.cgi?id=195481
3292
3293         Rubber-stamped by Darin Adler.
3294
3295         Run-benchmark script should support MontionMark-1.1.
3296
3297         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3298
3299 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3300
3301         [ews-app] Add support for submit-to-ews url
3302         https://bugs.webkit.org/show_bug.cgi?id=195477
3303
3304         Reviewed by Lucas Forschler.
3305
3306         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3307         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3308         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3309         * BuildSlaveSupport/ews-app/ews/urls.py:
3310         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3311
3312 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3313
3314         Unreviewed, rolling out r242688, r242643, r242624.
3315
3316         Caused multiple layout test failures and crashes on iOS and macOS.
3317
3318         Reverted changeset:
3319
3320         "requestAnimationFrame should execute before the next frame"
3321         https://bugs.webkit.org/show_bug.cgi?id=177484
3322         https://trac.webkit.org/changeset/242624/webkit
3323
3324         * Tracing/SystemTracePoints.plist:
3325
3326 2019-03-11  John Wilander  <wilander@apple.com>
3327
3328         Resource Load Statistics: Make it possible exclude localhost from classification
3329         https://bugs.webkit.org/show_bug.cgi?id=195474
3330         <rdar://problem/47520577>
3331
3332         Reviewed by Brent Fulgham.
3333
3334         This patch allows for localhost to be excluded from classification and
3335         treatment as a prevalent resource.
3336
3337         The WebKit Tools change adds a new function called
3338         testRunner.setStatisticsIsRunningTest() which can be used to control this
3339         behavior.
3340
3341         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3342         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3343         (WTR::TestRunner::setStatisticsIsRunningTest):
3344         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3345         * WebKitTestRunner/TestController.cpp:
3346         (WTR::TestController::setStatisticsIsRunningTest):
3347         * WebKitTestRunner/TestController.h:
3348         * WebKitTestRunner/TestInvocation.cpp:
3349         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3350
3351 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3352
3353         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3354         https://bugs.webkit.org/show_bug.cgi?id=195560
3355
3356         Reviewed by Lucas Forschler.
3357
3358         * BuildSlaveSupport/ews-build/master.cfg:
3359
3360 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3361
3362         Unreviewed, rolling out r242698.
3363
3364         API test crashes on bots.
3365
3366         Reverted changeset:
3367
3368         "Add a WKContentRuleList variant that uses copied memory
3369         instead of mmap'd shared memory for class A containerized
3370         apps"
3371         https://bugs.webkit.org/show_bug.cgi?id=195511
3372         https://trac.webkit.org/changeset/242698
3373
3374 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3375
3376         [WPE] Enable web process sandbox
3377         https://bugs.webkit.org/show_bug.cgi?id=195169
3378
3379         Reviewed by Daniel Bates.
3380
3381         * wpe/install-dependencies:
3382         * wpe/jhbuild.modules:
3383
3384 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3385
3386         [ews-app] Use port 17000 for worker communication
3387         https://bugs.webkit.org/show_bug.cgi?id=195558
3388
3389         Reviewed by Lucas Forschler.
3390
3391         * BuildSlaveSupport/ews-build/master.cfg:
3392
3393 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3394
3395         [ews-build] unit-tests fail when passwords.json is missing
3396         https://bugs.webkit.org/show_bug.cgi?id=195557
3397
3398         Reviewed by Lucas Forschler.
3399
3400         * BuildSlaveSupport/ews-build/loadConfig.py:
3401         (loadBuilderConfig):
3402         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3403         (ConfigDotJSONTest.test_configuration):
3404         * BuildSlaveSupport/ews-build/master.cfg:
3405
3406 2019-03-11  Truitt Savell  <tsavell@apple.com>
3407
3408         Unreviewed, rolling out r242702.
3409
3410         Broke High Sierra builders.
3411
3412         Reverted changeset:
3413
3414         "Add utility function to allow easy reverse range-based
3415         iteration of a container"
3416         https://bugs.webkit.org/show_bug.cgi?id=195542
3417         https://trac.webkit.org/changeset/242702
3418
3419 2019-03-11  Sam Weinig  <sam@webkit.org>
3420
3421         Add utility function to allow easy reverse range-based iteration of a container
3422         https://bugs.webkit.org/show_bug.cgi?id=195542
3423
3424         Reviewed by Antti Koivisto.
3425
3426         * TestWebKitAPI/CMakeLists.txt:
3427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3428         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3429         (TestWebKitAPI::TEST):
3430         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3431
3432 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3433
3434         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3435         https://bugs.webkit.org/show_bug.cgi?id=195511
3436         <rdar://problem/44873269>
3437
3438         Reviewed by Darin Adler.
3439
3440         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3441         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3442         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3443         (TEST_F):
3444
3445 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3446
3447         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3448         https://bugs.webkit.org/show_bug.cgi?id=195499
3449
3450         Reviewed by Darin Adler.
3451
3452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3453         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3454         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3455         (-[WKWebView synchronouslyFocusTextInputContext:]):
3456         (applyStyle):
3457         (applyIframe):
3458         (TEST):
3459         Add some tests for this SPI.
3460
3461 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3462
3463         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3464         https://bugs.webkit.org/show_bug.cgi?id=181151
3465
3466         Reviewed by Don Olmstead.
3467
3468         * TestWebKitAPI/CMakeLists.txt:
3469         * TestWebKitAPI/PlatformWin.cmake:
3470         Enable TestWTF RunLoop tests in all platforms.
3471
3472         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3473         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3474         (TestWebKitAPI::DerivedOneShotTimer::fired):
3475         (TestWebKitAPI::TEST):
3476         Only a few platforms support nested RunLoop.
3477
3478         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3479         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3480
3481 2019-03-10  David Quesada  <david_quesada@apple.com>
3482
3483         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3484         https://bugs.webkit.org/show_bug.cgi?id=152480
3485
3486         Reviewed by Chris Dumez.
3487
3488         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3489         there are no additional references to the process pool besides the one held by
3490         the download, waits for the download to finish (in the sense that the
3491         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3492         measure, also check that the process pool has been deallocated at the end of the
3493         test. The test wouldn't be meaningful if the process pool were still alive.
3494
3495         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3496         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3497         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3498             The download will be canceled because the delegate does not implement the
3499             method to decide the download's destination, so this is where we know the
3500             DownloadProxyMap is done with the DownloadProxy.
3501         (TEST):
3502
3503 2019-03-08  Chris Dumez  <cdumez@apple.com>
3504
3505         Add support for Device Orientation / Motion permission API
3506         https://bugs.webkit.org/show_bug.cgi?id=195329
3507         <rdar://problem/47645367>
3508
3509         Reviewed by Geoffrey Garen.
3510
3511         Add test infrastructure to help test the Device Orientation / Motion permission API.
3512
3513         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3514         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3515         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3516         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3517         * WebKitTestRunner/TestController.cpp:
3518         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3519         (WTR::TestController::createWebViewWithOptions):
3520         (WTR::TestController::resetStateToConsistentValues):
3521         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3522         * WebKitTestRunner/TestController.h:
3523         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3524         * WebKitTestRunner/TestInvocation.cpp:
3525         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3526
3527 2019-03-08  Saam barati  <sbarati@apple.com>
3528
3529         Add a compare-results script to compare benchmark results
3530         https://bugs.webkit.org/show_bug.cgi?id=195486
3531         <rdar://problem/48723397>
3532
3533         Reviewed by Geoffrey Garen.
3534
3535         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3536         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3537         to extend it to learn about our other benchmarks.
3538
3539         * Scripts/compare-results: Added.
3540         (readJSONFile):
3541         (detectJetStream2):
3542         (JetStream2Results):
3543         (detectSpeedometer2):
3544         (Speedometer2Results):
3545         (detectPLT5):
3546         (PLT5Results):
3547         (detectBenchmark):
3548         (biggerIsBetter):
3549         (ttest):
3550         (getOptions):
3551         (main):
3552
3553 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3554
3555         Ensure old tab state is cleared between iterations of run-benchmark
3556         https://bugs.webkit.org/show_bug.cgi?id=195393
3557         <rdar://problem/46885583>
3558
3559         Reviewed by Dewei Zhu.
3560
3561         a) ensure the default to restore state is not set
3562         b) terminate Safari correctly
3563         c) Set the system default to ignore Persistent State in Safari
3564
3565         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3566         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3567         (OSXBrowserDriver.prepare_env): 
3568         (OSXBrowserDriver.restore_env):
3569         (OSXBrowserDriver.close_browsers):
3570         (OSXBrowserDriver._terminate_processes):
3571         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3572         (OSXChromeDriver):
3573         (OSXChromeCanaryDriver):
3574         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3575         (OSXFirefoxDriver):
3576         (OSXFirefoxNightlyDriver):
3577         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3578         (OSXSafariDriver):
3579         (OSXSafariDriver.prepare_env):
3580
3581 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3582
3583         [GTK] Several InputMethodFilter tests are failing
3584         https://bugs.webkit.org/show_bug.cgi?id=195408
3585
3586         Reviewed by Carlos Garcia Campos.
3587
3588         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3589         Regressed in r241751.
3590         Hexadecimal values of keycodes are expressed now in upper letters.
3591         Composited characters should be cast to UTF8 strings.
3592
3593         (TestWebKitAPI::TEST):
3594
3595 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3596
3597         [GTK] Make Tools/gtkdoc python3 compatible
3598         https://bugs.webkit.org/show_bug.cgi?id=195359
3599
3600         Reviewed by Carlos Garcia Campos.
3601
3602         * gtkdoc/generate-gtkdoc:
3603         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3604         work with Python 2 and 3.
3605         (get_gtkdoc_module_paths):
3606         The iteritems() was removed in Python 3, so let's use items() that's
3607         available in Python 2 and 3.
3608         (get_generator_for_config):
3609         * gtkdoc/gtkdoc.py:
3610         (GTKDoc._run_command):
3611         The sys.stdout.write() is expecting str in Python 3 and not bytes
3612         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3613         for passing the bytes there.
3614
3615 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3616
3617         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3618         https://bugs.webkit.org/show_bug.cgi?id=195346
3619         <rdar://problem/48667048>
3620
3621         Unreviewed build fix for clang-cl.
3622
3623         * DumpRenderTree/win/DumpRenderTree.cpp:
3624         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3625
3626 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3627
3628         requestAnimationFrame should execute before the next frame
3629         https://bugs.webkit.org/show_bug.cgi?id=177484
3630
3631         Reviewed by Simon Fraser.
3632
3633         Add trace points for the page RenderingUpdate.
3634
3635         * Tracing/SystemTracePoints.plist:
3636
3637 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3638
3639         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3640         https://bugs.webkit.org/show_bug.cgi?id=195353
3641         <rdar://problem/48626394>
3642
3643         Reviewed by Simon Fraser.
3644
3645         * WebKitTestRunner/ios/TestControllerIOS.mm:
3646         (WTR::TestController::platformResetPreferencesToConsistentValues):
3647
3648 2019-03-07  John Wilander  <wilander@apple.com>
3649
3650         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3651         https://bugs.webkit.org/show_bug.cgi?id=195383
3652         <rdar://problem/48570136>
3653
3654         Reviewed by Brent Fulgham.
3655
3656         This patch adds test infrastructure to purge only script-accessible cookies,
3657         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3658
3659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3660         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3661         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3663         * WebKitTestRunner/TestController.cpp:
3664         (WTR::TestController::statisticsDeleteCookiesForHost):
3665         * WebKitTestRunner/TestController.h:
3666         * WebKitTestRunner/TestInvocation.cpp:
3667         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3668
3669 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3670
3671         Unreviewed, rolling out r242354.
3672         https://bugs.webkit.org/show_bug.cgi?id=195402
3673
3674         breaks layout tests in all configurations (Requested by
3675         zdobersek on #webkit).
3676
3677         Reverted changeset:
3678
3679         "[WPE] Enable web process sandbox"
3680         https://bugs.webkit.org/show_bug.cgi?id=195169
3681         https://trac.webkit.org/changeset/242354
3682
3683 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3684
3685         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3686         https://bugs.webkit.org/show_bug.cgi?id=195346
3687
3688         Reviewed by Fujii Hironori.
3689
3690         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3691         (TestWebKitAPI::TEST):
3692         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3693
3694         * DumpRenderTree/win/DumpRenderTree.cpp:
3695         (findFontFallback):
3696         (addFontFallbackIfPresent):
3697         (removeFontFallbackIfPresent):
3698         (main):
3699         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3700         (TestWebKitAPI::Util::moduleDirectory):
3701         (TestWebKitAPI::Util::createInjectedBundlePath):
3702         Use wchar helpers as needed.
3703
3704 2019-03-06  Rob Buis  <rbuis@igalia.com>
3705
3706         Consider supporting the `referrerpolicy` attribute.
3707         https://bugs.webkit.org/show_bug.cgi?id=179053
3708
3709         Reviewed by Darin Adler.
3710
3711         Add a runtime flag for referrerpolicy attribute.
3712
3713         * DumpRenderTree/mac/DumpRenderTree.mm:
3714         (enableExperimentalFeatures):
3715
3716 2019-03-05  Daniel Bates  <dabates@apple.com>
3717
3718         Update expected API test result following r242379
3719         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3720
3721         Update expected x-coordinate of selection rect now that the left padding of
3722         a textarea is sized in ems (so dependent on the font size) just like the left
3723         padding of a text field.
3724
3725         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3726         (TestWebKitAPI::TEST):
3727
3728 2019-03-05  David Quesada  <david_quesada@apple.com>
3729
3730         [WK2] It should be possible to follow links with 'download' attributes
3731         https://bugs.webkit.org/show_bug.cgi?id=195145
3732         rdar://problem/48462642
3733
3734         Reviewed by Alex Christensen.
3735
3736         Add a unit test to verify that activating links with 'download' attributes now
3737         navigates to the linked resource, rather than starts downloading it. Add another
3738         to verify that it is still possible to explicitly download the link via the
3739         'Download' navigation action policy.
3740
3741         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3742         (-[DownloadAttributeTestDelegate init]):
3743         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3744         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3745         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3746         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3747         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3748         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3749         (TEST):
3750         * WebKitTestRunner/TestController.cpp:
3751         (WTR::TestController::decidePolicyForNavigationAction):
3752         * WebKitTestRunner/TestController.h:
3753
3754 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3755
3756         [Curl] Implement Cookie Accept Policy.
3757         https://bugs.webkit.org/show_bug.cgi?id=191645
3758
3759         Reviewed by Fujii Hironori.
3760
3761         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3762         (TestWebKitAPI::Curl::TEST_F):
3763
3764 2019-03-05  Youenn Fablet  <youenn@apple.com>
3765
3766         Rename requestCacheStorageSpace to requestStorageSpace
3767         https://bugs.webkit.org/show_bug.cgi?id=195282
3768
3769         Reviewed by Chris Dumez.
3770
3771         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3772         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3773         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3774
3775 2019-03-05  Brady Eidson  <beidson@apple.com>
3776
3777         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3778         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3779
3780         Reviewed by Tim Horton.
3781
3782         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3783         different directory into that same WKWebView should work.
3784
3785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3786         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3787
3788 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3789
3790         Add WeakHashSet
3791         https://bugs.webkit.org/show_bug.cgi?id=195152
3792
3793         Reviewed by Antti Koivisto.
3794
3795         Added tests for WeakHashSet.
3796
3797         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3798         (TestWebKitAPI::Base::Base): Moved.
3799         (TestWebKitAPI::Derived::foo): Moved.
3800         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3801         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3802         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3803         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3804
3805 2019-03-04  Chris Dumez  <cdumez@apple.com>
3806
3807         Do not share WebProcesses between private and regular sessions
3808         https://bugs.webkit.org/show_bug.cgi?id=195189
3809         <rdar://problem/48421064>
3810
3811         Reviewed by Alex Christensen.
3812
3813         Add API test coverage.
3814
3815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3816         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3817
3818 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3819
3820         [WPE] Enable web process sandbox
3821         https://bugs.webkit.org/show_bug.cgi?id=195169
3822
3823         Reviewed by Daniel Bates.
3824
3825         * wpe/install-dependencies:
3826         * wpe/jhbuild.modules:
3827
3828 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3829
3830         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3831         https://bugs.webkit.org/show_bug.cgi?id=195206
3832
3833         Reviewed by Žan Doberšek.
3834
3835         Add a new test case.
3836
3837         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3838         (testJSCClass):
3839
3840 2019-03-04  Charlie Turner  <cturner@igalia.com>
3841
3842         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3843         https://bugs.webkit.org/show_bug.cgi?id=194898
3844
3845         Reviewed by Žan Doberšek.
3846
3847         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3848         a GCC extension that permits arithmetic on void* pointer. Inline
3849         the macro until this issue is fixed upstream.
3850
3851 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3852
3853         Rid the world of WK_API_ENABLED
3854         https://bugs.webkit.org/show_bug.cgi?id=195263
3855
3856         Reviewed by Dan Bernstein.
3857
3858         List of changed files elided because it's useless.
3859
3860 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3861
3862         Unreviewed follow-up to r242292.
3863
3864         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3865
3866         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3867         (TestWebKitAPI::testStrip): Renamed from strip.
3868         (TestWebKitAPI::TEST):
3869
3870 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3871
3872         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3873
3874         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3875         and bug #194272 for details.
3876
3877         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3878
3879 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3880
3881         Remove some more unused 32-bit code
3882         https://bugs.webkit.org/show_bug.cgi?id=195255
3883
3884         Reviewed by Darin Adler.
3885
3886         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3887         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3888         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3889         (NPP_New):
3890         (NPP_HandleEvent):
3891         (handleEventCarbon): Deleted.
3892
3893 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3894
3895         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3896
3897         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3898         (TestWebKitAPI::TEST):
3899
3900 2019-03-01  Darin Adler  <darin@apple.com>
3901
3902         Finish removing String::format
3903         https://bugs.webkit.org/show_bug.cgi?id=194893
3904
3905         Reviewed by Daniel Bates.
3906 '
3907         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3908
3909 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3910
3911         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3912         https://bugs.webkit.org/show_bug.cgi?id=195229
3913         <rdar://problem/48520362>
3914
3915         Reviewed by Chris Dumez.
3916
3917         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3918         (TEST):
3919
3920 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3921
3922         Add a system trace scope for event region building
3923         https://bugs.webkit.org/show_bug.cgi?id=195226
3924
3925         Reviewed by Jon Lee.
3926
3927         This trace scope measures the time spend converting element rects into Region objects,
3928         which can be large on some pages.
3929
3930         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3931
3932         * Tracing/SystemTracePoints.plist:
3933
3934 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3935
3936         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3937         https://bugs.webkit.org/show_bug.cgi?id=194612
3938
3939         Reviewed by Alex Christensen.
3940
3941         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3942         Just test the new string-processing function and don't touch the actual environment.
3943         (Test cases are all as before, but based on operator== instead of strcmp.)
3944
3945 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3946
3947         [ews-app] Update primary keys for handling multiple Buildbot instances
3948         https://bugs.webkit.org/show_bug.cgi?id=195120
3949
3950         Reviewed by Stephanie Lewis.
3951
3952         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3953         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3954         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3955
3956         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3957         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3958         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3959         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3960         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3961         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3962
3963 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3964
3965         [WinCairo] Enable service worker
3966         https://bugs.webkit.org/show_bug.cgi?id=188318
3967
3968         Reviewed by Youenn Fablet.
3969
3970         * DumpRenderTree/DumpRenderTreePrefix.h:
3971         * TestWebKitAPI/PlatformWin.cmake:
3972         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3973         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3974         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3975
3976 2019-03-01  Justin Fan  <justin_fan@apple.com>
3977
3978         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3979         https://bugs.webkit.org/show_bug.cgi?id=195191
3980
3981         Rubber-stamped by Dean Jackson.
3982
3983         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3984
3985         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3986
3987 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3988
3989         Unreviewed, fix lldb webkitpy tests
3990         https://bugs.webkit.org/show_bug.cgi?id=194375
3991
3992         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3993
3994         * lldb/lldb_webkit.py:
3995         (WTFStringImplProvider.is_8bit):
3996
3997 2019-02-28  David Quesada  <david_quesada@apple.com>
3998
3999         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4000         https://bugs.webkit.org/show_bug.cgi?id=195121
4001         rdar://problem/48450302
4002
4003         Reviewed by Alex Christensen.
4004
4005         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4006         configurations where the 'download' attribute is absent, blank, or populated
4007         with a filename, and where the anchor element is same-origin or cross-origin
4008         (meaning the 'download' attribute shouldn't be honored).
4009
4010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4011         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4012         (-[NavigationActionTestDelegate init]):
4013         (-[NavigationActionTestDelegate navigationAction]):
4014         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4015         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4016         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4017         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4018         (TEST):
4019
4020 2019-02-28  Antoine Quint  <graouts@apple.com>
4021
4022         Enable the Pointer Events runtime flag by default
4023         https://bugs.webkit.org/show_bug.cgi?id=195156
4024
4025         Reviewed by Dean Jackson.
4026
4027         * DumpRenderTree/mac/DumpRenderTree.mm:
4028         (enableExperimentalFeatures):
4029
4030 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4031
4032         Several PasteImage API tests are flaky
4033         https://bugs.webkit.org/show_bug.cgi?id=195160
4034
4035         Reviewed by Tim Horton.
4036
4037         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4038         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4039         listening for a "load" event after image load is already complete.
4040
4041         To address this, make these tests first register a "load" event handler, then run script to insert an image
4042         element into the document, and finally wait until the load event is observed before checking image size.
4043
4044         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4045
4046 2019-02-28  Chris Dumez  <cdumez@apple.com>
4047
4048         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4049         https://bugs.webkit.org/show_bug.cgi?id=195107
4050
4051         Reviewed by Alex Christensen.
4052
4053         Give some time for the zoom level to get restored.
4054
4055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4056
4057 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4058
4059         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4060         https://bugs.webkit.org/show_bug.cgi?id=194958
4061
4062         Reviewed by Geoffrey Garen.
4063
4064         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4065         (TEST):
4066
4067 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4068
4069         [ews-app] Update method to save build to handle builder_display_name
4070         https://bugs.webkit.org/show_bug.cgi?id=195047
4071
4072         Reviewed by Dewei Zhu.
4073
4074         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4075         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4076
4077 2019-02-28  Justin Fan  <justin_fan@apple.com>
4078
4079         [Web GPU] Enable Web GPU only on 64-bit
4080         https://bugs.webkit.org/show_bug.cgi?id=195139
4081
4082         Because Metal is only supported on 64 bit apps.
4083
4084         Unreviewed build fix.
4085
4086         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4087
4088 2019-02-27  Youenn Fablet  <youenn@apple.com>
4089
4090         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4091         https://bugs.webkit.org/show_bug.cgi?id=194959
4092
4093         Reviewed by Chris Dumez.
4094
4095         Spin loop until getting the condition to remove flakiness.
4096
4097         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4098
4099 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4100
4101         [ews-build] Buildbot should include builder_display_name in the build events
4102         https://bugs.webkit.org/show_bug.cgi?id=195045
4103
4104         Reviewed by Dewei Zhu.
4105
4106         * BuildSlaveSupport/ews-build/events.py:
4107         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4108         buildername to builder_name to be consistent in naming style.
4109         (Events.buildFinished): Ditto.
4110
4111 2019-02-27  Chris Dumez  <cdumez@apple.com>
4112
4113         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4114         https://bugs.webkit.org/show_bug.cgi?id=194480
4115
4116         Reviewed by Brady Eidson.
4117
4118         Update existing API test to make it more likely to reproduce the issue.
4119
4120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4121
4122 2019-02-27  Brady Eidson  <beidson@apple.com>
4123
4124         Universal links from Google search results pages don't open the app.
4125         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4126
4127         Reviewed by Geoffrey Garen.
4128
4129         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4130         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4131         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4132         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4133
4134 2019-02-27  Chris Dumez  <cdumez@apple.com>
4135
4136         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4137         https://bugs.webkit.org/show_bug.cgi?id=195102
4138
4139         Reviewed by Geoffrey Garen.
4140
4141         If the number of processes is not yet what we expect, wait a bit and check again to give
4142         processes some time to exit.
4143
4144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4145
4146 2019-02-27  Chris Dumez  <cdumez@apple.com>
4147
4148         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4149         https://bugs.webkit.org/show_bug.cgi?id=194545
4150
4151         Reviewed by Brady Eidson.
4152
4153         Make sure the test navigates forward and then back only once. Previously, navigating
4154         back would trigger a navigation again in a timer.
4155
4156         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4157
4158 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4159
4160         High Sierra Debug JSC test queue should use faster hardware
4161         https://bugs.webkit.org/show_bug.cgi?id=194603
4162
4163         Rubber-stamped by Alexey Proskuryakov.
4164
4165         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4166
4167         * BuildSlaveSupport/build.webkit.org-config/config.json:
4168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4169         (BubbleQueueServer):
4170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4171         (WebKitBuildbot):
4172         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4173         * QueueStatusServer/config/queues.py:
4174         * Scripts/webkitpy/common/config/ews.json:
4175         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4176         (test_ews_name):
4177
4178 2019-02-27  John Wilander  <wilander@apple.com>
4179
4180         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4181         https://bugs.webkit.org/show_bug.cgi?id=195071
4182         <rdar://problem/48417690>
4183
4184         Reviewed by Alex Christensen and Brent Fulgham.
4185
4186         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4187         (TestWebKitAPI::createURL):
4188             Convenience function.
4189         (TestWebKitAPI::TEST):
4190             WebCore::AdClickAttribution now takes a URL when creating Source and
4191             Destination.
4192         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4193         (TestWebKitAPI::TEST):
4194             WebCore::AdClickAttribution now takes a URL when creating Source and
4195             Destination.
4196
4197 2019-02-27  Antoine Quint  <graouts@apple.com>
4198
4199         Support Pointer Events on macOS
4200         https://bugs.webkit.org/show_bug.cgi?id=195008
4201         <rdar://problem/47454419>
4202
4203         Reviewed by Dean Jackson.
4204
4205         * DumpRenderTree/mac/DumpRenderTree.mm:
4206         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4208
4209 2019-02-26  Mark Lam  <mark.lam@apple.com>
4210
4211         Remove remaining poisoning code.
4212         https://bugs.webkit.org/show_bug.cgi?id=194138
4213
4214         Reviewed by Saam Barati.
4215
4216         * TestWebKitAPI/CMakeLists.txt:
4217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4218         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4219         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4220         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4221         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4222         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4223         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4224
4225 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4226
4227         Move ephemeral local storage from WebProcess to UIProcess
4228         https://bugs.webkit.org/show_bug.cgi?id=195074
4229         <rdar://problem/47937975>
4230
4231         Reviewed by Geoff Garen.
4232
4233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4234
4235 2019-02-20  Jer Noble  <jer.noble@apple.com>
4236
4237         [Cocoa] Media elements will restart network buffering just before suspending
4238         https://bugs.webkit.org/show_bug.cgi?id=193691
4239
4240         Reviewed by Eric Carlson.
4241
4242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4244         (TEST):
4245
4246 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4247
4248         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4249         https://bugs.webkit.org/show_bug.cgi?id=191652
4250
4251         Reviewed by Alex Christensen.
4252
4253         Fix WinCairo MiniBrowser behavior of authentication dialog.
4254
4255         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4256         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4257
4258 2019-02-26  Youenn Fablet  <youenn@apple.com>
4259
4260         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4261         https://bugs.webkit.org/show_bug.cgi?id=195028
4262         <rdar://problem/48243733>
4263
4264         Reviewed by Eric Carlson.
4265
4266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4267
4268 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4269
4270         [WPE] Add API for webview background color configuration
4271         https://bugs.webkit.org/show_bug.cgi?id=192305
4272
4273         Reviewed by Michael Catanzaro.
4274
4275         * MiniBrowser/wpe/main.cpp:
4276         (main): Add a new option to configure the webview background
4277         color. Example: --bg-color=transparent.
4278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4279         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4280         (beforeAll): Ditto.
4281
4282 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4283
4284         scalableNativeWebpageParameters() is not preserved on new page navigation.
4285         https://bugs.webkit.org/show_bug.cgi?id=194892
4286         <rdar://problem/47538280>
4287
4288         Reviewed by Wenson Hsieh.
4289         
4290         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4291
4292         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4293         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4294         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4295         (WTR::UIScriptController::allowsViewportShrinkToFit):
4296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4297         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4298         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4299         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4300         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4301         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4302
4303 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4304
4305         [ews-app] Add model for handling multiple Buildbot instances
4306         https://bugs.webkit.org/show_bug.cgi?id=194863
4307
4308         Reviewed by Stephanie Lewis.
4309
4310         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4311
4312 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4313
4314         [ews-app] Remove BuilderMapping table
4315         https://bugs.webkit.org/show_bug.cgi?id=194961
4316
4317         Reviewed by Stephanie Lewis.
4318
4319         Store builder name directly in build table, instead of having a separate
4320         table for it.
4321
4322         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4323         * BuildSlaveSupport/ews-app/ews/models/build.py:
4324         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4325         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4326
4327 2019-02-25  John Wilander  <wilander@apple.com>
4328
4329         Introduce and adopt new class RegistrableDomain for eTLD+1
4330         https://bugs.webkit.org/show_bug.cgi?id=194791
4331         <rdar://problem/48179240>
4332
4333         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4334
4335         This patch adds an API test and replaces two instances of
4336         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4337
4338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4339         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4340         (TestWebKitAPI::TEST):
4341             Changed two strings to make sure the registrable domains are still considered
4342             invalid and pass the test.
4343         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4344         (TestWebKitAPI::TEST):
4345         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4346         (WTR::InjectedBundle::didReceiveMessageToPage):
4347
4348 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4349
4350         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4351         https://bugs.webkit.org/show_bug.cgi?id=195001
4352
4353         Reviewed by Carlos Garcia Campos.
4354
4355         API version 1.0 always includes the functionality previously guarded with
4356         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4357         unconditionally.
4358
4359         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4360         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4361         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4362         (WebViewTest::showInWindow): Ditto.
4363         (WebViewTest::hideView): Ditto.
4364         * wpe/backends/HeadlessViewBackend.cpp:
4365         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4366         * wpe/backends/ViewBackend.cpp:
4367         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4368         * wpe/backends/WindowViewBackend.cpp:
4369         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4370         WPE_BACKEND_CHECK_VERSION().
4371         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4372
4373 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4374
4375         [Flatpak] Add support for flatpak > 1.1.2
4376         https://bugs.webkit.org/show_bug.cgi?id=194088
4377
4378         Flatpak 1.2 is now out so we need to support that
4379         version now.
4380
4381         Reviewed by Michael Catanzaro.
4382
4383         * flatpak/flatpakutils.py:
4384         (check_flatpak):
4385         (FlatpakPackages.__init__):
4386         (FlatpakPackages.__detect_packages):
4387         (FlatpakPackages.__detect_packages.in):
4388         (FlatpakRepos.update):
4389
4390 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4391
4392         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes