24796dcd7a6a44c7045f0d8628111e656499ce2d
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-07  Andy Estes  <aestes@apple.com>
2
3         Fix the Production build after r189455.
4
5         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
6         In-App Purchase template instead of the Aggregate template. Whoops.
7
8 2015-09-06  Andy Estes  <aestes@apple.com>
9
10         WebKit.xcworkspace should be be able to build iOS platforms
11         https://bugs.webkit.org/show_bug.cgi?id=148881
12
13         Reviewed by Daniel Bates.
14
15         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
16         for all supported platforms.
17
18         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
19         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
20         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
21         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
22
23 2015-09-06  Andy Estes  <aestes@apple.com>
24
25         WebKitTestRunner should build for iOS using the default target
26         https://bugs.webkit.org/show_bug.cgi?id=148918
27
28         Reviewed by Daniel Bates.
29
30         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
31         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
32         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
33
34         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
35         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
36         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
37         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
38         WebKitTestRunner is skipped when installing on iOS.
39
40         The target dependency graph now looks like this:
41
42             All
43                 WebKitTestRunnerApp
44                     WebKitTestRunner (Library)
45                         WebKitTestRunnerInjectedBundle
46                             Derived Sources
47                 WebKitTestRunner
48                     WebKitTestRunner (Library)
49                         WebKitTestRunnerInjectedBundle
50                             Derived Sources
51
52         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
53         * Scripts/build-webkittestrunner: Ditto.
54         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
55         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
56         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
57         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
58         excluded iOS-only files, and skipped installing on iOS.
59         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
60         excluded Mac-only files, and skipped installing on Mac.
61         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
62         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
63         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
64         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
65         new configuration files.
66
67 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
68
69         Web Inspector: Improve prepare-ChangeLog for multiple cases
70         https://bugs.webkit.org/show_bug.cgi?id=148875
71
72         Reviewed by Timothy Hatcher.
73
74         * Scripts/prepare-ChangeLog:
75         (get_function_line_ranges_for_javascript):
76         - We were ignoring everything inside of an anonymous function expression,
77           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
78           Better handle this by inserting a few tweaks.
79         - Allow method syntax outside of classes as long as they are at the global level.
80         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
81
82         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
83         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
84         (Foo.prototype.method1):
85         (Foo.prototype.method2):
86         (Foo.prototype.method3.innerFunction):
87         (Foo.prototype.method3):
88         (insideGlobalAnonymousFunctionExpression):
89         (foo.insideGlobalFunctionExpression):
90         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
91         (IssueWithMapGetAndSet.prototype.method1):
92         (IssueWithMapGetAndSet.prototype.method2):
93         (IssueWithMapGetAndSet.prototype.method3):
94         (IssueWithMapGetAndSet):
95
96 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
97
98         [ES6] Enable ES6 Module in JSC shell by default
99         https://bugs.webkit.org/show_bug.cgi?id=148689
100
101         Reviewed by Geoffrey Garen.
102
103         * Scripts/run-javascriptcore-tests:
104         (runJSCStressTests):
105         * Scripts/run-jsc-stress-tests:
106
107 2015-09-04  Basile Clement  <basile_clement@apple.com>
108
109         Unreviewed, change my email address.
110
111         * Scripts/webkitpy/common/config/contributors.json:
112
113 2015-09-04  Beth Dakin  <bdakin@apple.com>
114
115         Should have a test to make sure links don't navigate after a cancelled force 
116         click
117         https://bugs.webkit.org/show_bug.cgi?id=148846
118
119         Reviewed by Tim Horton.
120
121         New EventSender function for a started then cancelled force click.
122         * WebKitTestRunner/EventSenderProxy.h:
123         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
124         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
125         (WTR::EventSendingController::mouseForceClick):
126         (WTR::EventSendingController::startAndCancelMouseForceClick):
127         (WTR::EventSendingController::mouseForceDown):
128         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
129         * WebKitTestRunner/TestController.cpp:
130         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
131         * WebKitTestRunner/mac/EventSenderProxy.mm:
132         (WTR::EventSenderProxy::mouseForceClick):
133         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
134         (WTR::EventSenderProxy::mouseForceDown):
135         (WTR::EventSenderProxy::mouseMoveTo):
136
137 2015-09-04  Tim Horton  <timothy_horton@apple.com>
138
139         Add a test for r179736 (programmatic navigation during swipe causing a crash)
140         https://bugs.webkit.org/show_bug.cgi?id=148830
141
142         Reviewed by Beth Dakin.
143
144         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
145         (WTR::InjectedBundle::beginTesting):
146         Make sure that TestRunner callbacks don't leak between tests!
147
148 2015-09-04  Anders Carlsson  <andersca@apple.com>
149
150         It should be possible to pass relative HTTP test paths to DumpRenderTree
151         https://bugs.webkit.org/show_bug.cgi?id=148825
152         <rdar://problem/22583866>
153
154         Reviewed by Tim Horton.
155
156         Convert the path to an absolute path if needed.
157
158         * DumpRenderTree/mac/DumpRenderTree.mm:
159         (computeTestURL):
160
161 2015-09-04  Jason Marcell  <jmarcell@apple.com>
162
163         Fix Swift unit tests for prepare-ChangeLog.
164         https://bugs.webkit.org/show_bug.cgi?id=148817
165
166         Reviewed by Alexey Proskuryakov.
167
168         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
169         Swift unit tests for prepare-ChangeLog.
170
171 2015-09-04  Lucas Forschler  <lforschler@apple.com>
172
173         Modifications to the webkit-nightly logic.
174         
175         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
176         (updateAlertPanel):
177         * WebKitLauncher/main.m:
178         (displayErrorAndQuit):
179
180 2015-09-04  Beth Dakin  <bdakin@apple.com>
181
182         Speculative build fix.
183
184         * WebKitTestRunner/mac/EventSenderProxy.mm:
185
186 2015-09-04  Brian Burg  <bburg@apple.com>
187
188         Web Inspector: InspectorController should support multiple frontend channels
189         https://bugs.webkit.org/show_bug.cgi?id=148538
190
191         Reviewed by Joseph Pecoraro.
192
193         InspectorClients must explicitly disconnect their frontend channel(s) from the
194         inspected page's InspectorController.
195
196         To make this possible, DumpRenderTree should not destroy non-primary views until
197         it has tried to close any abandoned Web Inspector instances. Performing teardown
198         in the reverse order prevents disconnection of the frontend channel because that
199         prematurely destroys the inspector frontend client.
200
201         * DumpRenderTree/mac/DumpRenderTree.mm:
202         (runTest):
203         * DumpRenderTree/win/DumpRenderTree.cpp:
204         (runTest):
205
206 2015-09-04  Beth Dakin  <bdakin@apple.com>
207
208         Need to be able to test default behaviors on force click
209         https://bugs.webkit.org/show_bug.cgi?id=148758
210
211         Reviewed by Tim Horton.
212
213         This patch adds a new eventSender method to do a full, completed force click, 
214         and it re-works all of the existing force methods to dispatch their events in 
215         such a way that they will trigger the NSImmediateAction gesture recognizer. 
216         To do this, first we need to send the events to the app rather than straight 
217         to the view, and also needed to tweak some state and send the events in a 
218         delayed fashion.
219
220         New public function mouseForceClick() and private helper functions to make 
221         NSEvents.
222         * WebKitTestRunner/EventSenderProxy.h:
223
224         New public function mouseForceClick().
225         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
226         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
227         (WTR::EventSendingController::mouseMoveTo):
228         (WTR::EventSendingController::mouseForceClick):
229         (WTR::EventSendingController::mouseForceDown):
230         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
231         * WebKitTestRunner/TestController.cpp:
232         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
233
234         initPressureEventAtLocation needs to take a stageTransition and a window.
235         * WebKitTestRunner/mac/EventSenderProxy.mm:
236         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
237         (-[EventSenderSyntheticEvent stageTransition]):
238         (-[EventSenderSyntheticEvent timestamp]):
239         (-[EventSenderSyntheticEvent _cgsEventRecord]):
240         (-[EventSenderSyntheticEvent window]):
241
242         In order to enter the gesture recognizer, we need to start with a mouse down 
243         that has a NSEventMaskPressure modifier.
244         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
245
246         This ensures that the events queue properly for the force monitor in AppKit.
247         (WTR::spinRunLoopForForce):
248
249          We need to start the pressure change events with a began.
250         (WTR::EventSenderProxy::beginPressureEvent):
251
252         These functions can be used to create the NSEvent for a pressure change every 
253         time we need one.
254         (WTR::EventSenderProxy::pressureChangeEvent):
255
256         Send the right series of events to emulate a full, completed force click.
257         (WTR::EventSenderProxy::mouseForceClick):
258
259         Use all of the new things for these existing functions.
260         (WTR::EventSenderProxy::mouseForceDown):
261         (WTR::EventSenderProxy::mouseForceUp):
262         (WTR::EventSenderProxy::mouseForceChanged):
263
264         Set NSFakeForceTouchDevice to YES.
265         * WebKitTestRunner/mac/main.mm:
266         (setDefaultsToConsistentValuesForTesting):
267
268 2015-09-04  Jason Marcell  <jmarcell@apple.com>
269
270         prepare-ChangeLog needs to know how to parse Swift files.
271         https://bugs.webkit.org/show_bug.cgi?id=148784
272         <rdar://problem/22510062>
273
274         Reviewed by Darin Adler.
275
276         * Scripts/prepare-ChangeLog:
277         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
278         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
279         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
280         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
281         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
282         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
283         (freeFunction): Ditto.
284         (MyClass.function): Ditto.
285         (MyClass.functionWithArgument(_:)): Ditto.
286         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
287         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
288         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
289         (MyClass.classFunction): Ditto.
290         (MyClass.readWriteComputedVariable): Ditto.
291         (MyClass.readOnlyComputedVariable): Ditto.
292
293 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
294
295         Import css/css-color-3
296         https://bugs.webkit.org/show_bug.cgi?id=148803
297
298         Reviewed by Chris Dumez.
299
300         Fixed a bug that the imported reference files used the same extention as tests.
301         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
302
303         * Scripts/webkitpy/w3c/test_importer.py:
304         (TestImporter.find_importable_tests):
305
306 2015-09-03  Commit Queue  <commit-queue@webkit.org>
307
308         Unreviewed, rolling out r189338.
309         https://bugs.webkit.org/show_bug.cgi?id=148785
310
311         Caused tons of crashes (Requested by cdumez on #webkit).
312
313         Reverted changeset:
314
315         "Web Inspector: InspectorController should support multiple
316         frontend channels"
317         https://bugs.webkit.org/show_bug.cgi?id=148538
318         http://trac.webkit.org/changeset/189338
319
320 2015-09-03  Brian Burg  <bburg@apple.com>
321
322         Web Inspector: InspectorController should support multiple frontend channels
323         https://bugs.webkit.org/show_bug.cgi?id=148538
324
325         Reviewed by Joseph Pecoraro.
326
327         InspectorClients must explicitly disconnect their frontend channel(s) from the
328         inspected page's InspectorController.
329
330         To make this possible, DumpRenderTree should not destroy non-primary views until
331         it has tried to close any abandoned Web Inspector instances. Performing teardown
332         in the reverse order prevents disconnection of the frontend channel because that
333         prematurely destroys the inspector frontend client.
334
335         * DumpRenderTree/mac/DumpRenderTree.mm:
336         (runTest):
337         * DumpRenderTree/win/DumpRenderTree.cpp:
338         (runTest):
339
340 2015-09-03  Timothy Hatcher  <timothy@apple.com>
341
342         Update WebKit nightly icon to be more like Safari
343         https://bugs.webkit.org/show_bug.cgi?id=148768
344
345         Reviewed by Joseph Pecoraro.
346
347         * WebKitLauncher/webkit.icns:
348
349 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
350
351         JavaScriptCore should have some ES6 conformance tests
352         https://bugs.webkit.org/show_bug.cgi?id=148771
353
354         Reviewed by Chris Dumez.
355
356         * Scripts/run-javascriptcore-tests:
357         (runJSCStressTests): Added es6 as a test suite.
358
359         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
360
361         Some of these tests currently fail, so I also added a way to expect
362         failure for now. We'll migrate failing tests to expected passes as we
363         fix them.
364
365 2015-09-03  Tim Horton  <timothy_horton@apple.com>
366
367         Add a test for swipe-start hysteresis
368         https://bugs.webkit.org/show_bug.cgi?id=148756
369
370         Reviewed by Anders Carlsson.
371
372         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
373         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
374         (WTR::cacheTestRunnerCallback):
375         (WTR::TestRunner::clearTestRunnerCallbacks):
376         * WebKitTestRunner/InjectedBundle/TestRunner.h:
377         Make sure that we log if a client tries to install a callback twice
378         (since we use .add, the second call would not work).
379
380         Also, add clearTestRunnerCallbacks so tests can swap out installed
381         callbacks.
382
383 2015-09-03  Anders Carlsson  <andersca@apple.com>
384
385         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
386         https://bugs.webkit.org/show_bug.cgi?id=148746
387         rdar://problem/22568073
388
389         Reviewed by Tim Horton.
390
391         * DumpRenderTree/mac/DumpRenderTree.mm:
392         (computeTestURL):
393         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
394
395         (runTest):
396         Call computeTestURL.
397
398         (testPathFromURL):
399         Get rid of this; computeTestURL does this for us now.
400
401         * Scripts/webkitpy/port/driver.py:
402         (Driver._command_from_driver_input):
403         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
404
405 2015-09-03  Tim Horton  <timothy_horton@apple.com>
406
407         Swipe tests fail on Mavericks
408         https://bugs.webkit.org/show_bug.cgi?id=148752
409
410         Reviewed by Beth Dakin.
411
412         * WebKitTestRunner/mac/EventSenderProxy.mm:
413
414 2015-09-03  Tim Horton  <timothy_horton@apple.com>
415
416         Fix the 32-bit build
417
418         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
419         (WTR::PlatformWebView::setNavigationGesturesEnabled):
420
421 2015-09-03  Tim Horton  <timothy_horton@apple.com>
422
423         Remove some logging that wasn't meant to be in the tree
424
425         * WebKitTestRunner/mac/EventSenderProxy.mm:
426         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
427
428 2015-09-03  Tim Horton  <timothy_horton@apple.com>
429
430         [Mac] Add support for testing swipes
431         https://bugs.webkit.org/show_bug.cgi?id=148700
432
433         Reviewed by Beth Dakin.
434
435         * WebKitTestRunner/EventSenderProxy.h:
436         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
437         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
438         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
439         (WTR::cgEventPhaseFromString):
440         (WTR::cgEventMomentumPhaseFromString):
441         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
442         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
443         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
444         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
445         (WTR::InjectedBundle::didReceiveMessageToPage):
446         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
447         (WTR::TestRunner::installDidBeginSwipeCallback):
448         (WTR::TestRunner::installWillEndSwipeCallback):
449         (WTR::TestRunner::installDidEndSwipeCallback):
450         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
451         (WTR::TestRunner::callDidBeginSwipeCallback):
452         (WTR::TestRunner::callWillEndSwipeCallback):
453         (WTR::TestRunner::callDidEndSwipeCallback):
454         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
455         * WebKitTestRunner/InjectedBundle/TestRunner.h:
456         * WebKitTestRunner/TestController.cpp:
457         (WTR::TestController::createOtherPage):
458         (WTR::TestController::createWebViewWithOptions):
459         (WTR::TestController::didReceiveMessageFromInjectedBundle):
460         (WTR::TestController::didBeginNavigationGesture):
461         (WTR::TestController::willEndNavigationGesture):
462         (WTR::TestController::didEndNavigationGesture):
463         (WTR::TestController::didRemoveNavigationGestureSnapshot):
464         * WebKitTestRunner/TestController.h:
465         * WebKitTestRunner/TestInvocation.cpp:
466         (WTR::TestInvocation::didBeginSwipe):
467         (WTR::TestInvocation::willEndSwipe):
468         (WTR::TestInvocation::didEndSwipe):
469         (WTR::TestInvocation::didRemoveSwipeSnapshot):
470         * WebKitTestRunner/TestInvocation.h:
471         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
472         when the snapshot is removed.
473
474         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
475         mouseScrollBy function.
476
477         * WebKitTestRunner/mac/EventSenderProxy.mm:
478         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
479         (-[EventSenderSyntheticEvent type]):
480         (-[EventSenderSyntheticEvent subtype]):
481         (-[EventSenderSyntheticEvent locationInWindow]):
482         (-[EventSenderSyntheticEvent location]):
483         (-[EventSenderSyntheticEvent momentumPhase]):
484         (-[EventSenderSyntheticEvent _isTouchesEnded]):
485         (-[EventSenderSyntheticEvent _cgsEventRecord]):
486         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
487         more adjustable values.
488
489         (WTR::EventSenderProxy::mouseForceDown):
490         (WTR::EventSenderProxy::mouseForceUp):
491         (WTR::EventSenderProxy::mouseForceChanged):
492         Adopt EventSenderSyntheticEvent.
493
494         (WTR::nsEventPhaseFromCGEventPhase):
495         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
496         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
497
498         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
499         (WTR::PlatformWebView::PlatformWebView):
500         Enable swipe.
501
502 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
503
504         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
505         https://bugs.webkit.org/show_bug.cgi?id=148723
506
507         Reviewed by Anders Carlsson.
508
509         * WebKitTestRunner/TestController.cpp:
510         (WTR::testPath):
511         (WTR::updateViewOptionsFromTestHeader):
512         (WTR::TestController::viewOptionsForTest):
513
514 2015-09-03  Lucas Forschler  <lforschler@apple.com>
515
516         Test commit.
517
518 2015-09-02  Tim Horton  <timothy_horton@apple.com>
519
520         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
521         https://bugs.webkit.org/show_bug.cgi?id=148693
522
523         Reviewed by Anders Carlsson.
524
525         * WebKitTestRunner/TestController.cpp:
526         (WTR::TestController::createOtherPage):
527         (WTR::TestController::createWebViewWithOptions):
528
529 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
530
531         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
532         https://bugs.webkit.org/show_bug.cgi?id=148529
533
534         Reviewed by Darin Adler.
535
536         When there are pending EventSender messages after a test finishes,
537         they could be processed in the main loop started by the
538         resetStateToConsistentValues(), but the old EventSender has been
539         replaced by a new one at that point. The new Eventsender can crash
540         when processing messages that were sent to the old one. To avoid
541         this, we return early when receiving an EventSender message and
542         the TestController state is not RunningTest.
543
544         * WebKitTestRunner/TestController.cpp:
545         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
546         (WTR::TestController::didReceiveMessageFromInjectedBundle):
547
548 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
549
550         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
551         https://bugs.webkit.org/show_bug.cgi?id=148528
552
553         Reviewed by Darin Adler.
554
555         Before r188548 resetStateToConsistentValues() was called in
556         TestController::run(), before tests are run, but now it's called
557         for every test in TestInvocation::invoke(), after m_status has
558         changed to RunningTest.
559
560         * WebKitTestRunner/TestController.cpp:
561         (WTR::TestController::resetStateToConsistentValues): Use
562         TemporaryChange to reset m_state ot its previous value after reset
563         is done.
564
565 2015-08-31  Jason Marcell  <jmarcell@apple.com>
566
567         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
568         that are marked as requiring corresponding tests.
569         https://bugs.webkit.org/show_bug.cgi?id=148498
570         <rdar://problem/21555314>
571
572         Reviewed by Dan Bernstein and David Kilzer.
573
574         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
575         simulate Git's attribute behevaior.
576         (main): Added "requiresTests" array to contain files that require tests.
577         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
578         section in ChangeLog.
579         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
580         however, we check if the file or any containing folder has the given property set to "1" and
581         return 1 if so; return 0 otherwise.
582         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
583         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
584
585 2015-08-26  Andy Estes  <aestes@apple.com>
586
587         [Content Filtering] Determine navigation and content policy before continuing to filter a load
588         https://bugs.webkit.org/show_bug.cgi?id=148506
589
590         Reviewed by Brady Eidson.
591
592         Added download API tests covering every decision and decision point.
593         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
594
595         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
596         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
597         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
598         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
599         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
600         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
601         decision and decision point as a bundle parameter.
602         (+[MockContentFilterEnabler supportsSecureCoding]):
603         (-[MockContentFilterEnabler copyWithZone:]):
604         (-[MockContentFilterEnabler initWithCoder:]):
605         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
606         (-[MockContentFilterEnabler encodeWithCoder:]):
607         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
608         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
609         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
610         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
611         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
612         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
613         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
614         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
615         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
616         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
617         (+[MockContentFilterEnabler supportsSecureCoding]):
618         (-[MockContentFilterEnabler copyWithZone:]):
619         (-[MockContentFilterEnabler initWithCoder:]):
620         (-[MockContentFilterEnabler dealloc]):
621         (-[MockContentFilterEnabler encodeWithCoder:]):
622         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
623         (-[ContentFilteringPlugIn dealloc]): Stop observing.
624         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
625         (+[ServerRedirectPlugIn initialize]): Deleted.
626         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
627         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
628         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
629         (TEST): Deleted.
630
631 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
632
633         Skip slow lock tests on Windows/debug
634         https://bugs.webkit.org/show_bug.cgi?id=148643
635
636         Reviewed by Alexey Proskuryakov.
637
638         The lock tests simulate a critical section by doing some floating point math, and then either
639         make those critical sections very long or invoke them many times. This appears to be
640         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
641         that kind of computation slow.
642
643         These tests are almost as useful in release as they are in debug, so it's probably better to
644         just skip the in debug on platforms where this causes timeouts.
645
646         * TestWebKitAPI/Tests/WTF/Lock.cpp:
647         (TestWebKitAPI::runLockTest):
648         (TestWebKitAPI::skipSlow):
649         (TestWebKitAPI::TEST):
650
651 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
652
653         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
654         https://bugs.webkit.org/show_bug.cgi?id=125720
655
656         Reviewed by Daniel Bates.
657
658         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
659
660         * DumpRenderTree/AccessibilityUIElement.cpp:
661         (pressCallback):
662         (scrollToMakeVisibleWithSubFocusCallback):
663         (scrollToGlobalPointCallback):
664         (scrollToMakeVisibleCallback):
665         (AccessibilityUIElement::getJSClass):
666         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
667         (AccessibilityUIElement::scrollToMakeVisible):
668         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
669         (AccessibilityUIElement::scrollToGlobalPoint):
670         (AccessibilityUIElement::selectedTextRange):
671         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
672         (AccessibilityUIElement::AccessibilityUIElement):
673         (AccessibilityUIElement::mathPrescriptsDescription):
674         (AccessibilityUIElement::scrollToMakeVisible):
675         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
676         (AccessibilityUIElement::scrollToGlobalPoint):
677         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
678         (WTR::AccessibilityUIElement::isTextMarkerValid):
679         (WTR::AccessibilityUIElement::textMarkerForIndex):
680         (WTR::AccessibilityUIElement::scrollToMakeVisible):
681         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
682         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
683         (WTR::AccessibilityUIElement::supportedActions):
684         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
685         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
686         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
687         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
688         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
689         (WTR::AccessibilityUIElement::scrollToMakeVisible):
690         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
691         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
692         (WTR::AccessibilityUIElement::selectedTextRange):
693         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
694         (WTR::AccessibilityUIElement::scrollToMakeVisible):
695         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
696         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
697         (WTR::AccessibilityUIElement::selectedTextRange):
698
699 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
700
701         Add a mysteriously nonproblematic missing comma.
702
703         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
704         (TestExpectationParser._collect_matching_tests):
705         (TestExpectationParser):
706
707 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
708
709         Remove an old temporary script that has served its purpose
710
711         * Scripts/convert-test-expectations: Removed.
712
713 2015-08-28  Jer Noble  <jer.noble@apple.com>
714
715         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
716         https://bugs.webkit.org/show_bug.cgi?id=148579
717
718         Reviewed by Anders Carlsson.
719
720         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
721
722         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
723         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
724
725         * DumpRenderTree/mac/DumpRenderTree.mm:
726         (resetWebPreferencesToConsistentValues):
727         (resetWebViewToConsistentStateBeforeTesting): 
728         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
729         (WTR::initializeWebViewConfiguration):
730
731 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
732
733         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
734         https://bugs.webkit.org/show_bug.cgi?id=148592
735
736         Reviewed by Tim Horton.
737
738         * Scripts/webkitpy/port/base.py:
739         (Port.to.setup_environ_for_server):
740         (Port.to):
741         (Port.to._append_value_colon_separated):
742         (Port.to.show_results_html_file):
743         * Scripts/webkitpy/port/ios.py:
744         (IOSSimulatorPort.setup_environ_for_server):
745         * Scripts/webkitpy/port/mac.py:
746         (MacPort.setup_environ_for_server):
747
748 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
749
750         LICM should be sound even if the CFG has changed
751         https://bugs.webkit.org/show_bug.cgi?id=148259
752
753         Reviewed by Benjamin Poulain.
754
755         Add a utility for creating tests that set some uncommon option.
756
757         * Scripts/run-jsc-stress-tests:
758
759 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
760
761         [Win] Unreviewed EWS correction.
762
763         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
764
765 2015-08-28  Jer Noble  <jer.noble@apple.com>
766
767         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
768         https://bugs.webkit.org/show_bug.cgi?id=147512
769
770         Reviewed by Anders Carlsson.
771
772         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
773         to a consistent (true) value.
774
775         * DumpRenderTree/mac/DumpRenderTree.mm:
776         (setDefaultsToConsistentValuesForTesting):
777         * WebKitTestRunner/TestController.cpp:
778         (WTR::TestController::resetPreferencesToConsistentValues):
779
780 2015-08-28  Tim Horton  <timothy_horton@apple.com>
781
782         Add navigation gesture callbacks to WKPageNavigationClient
783         https://bugs.webkit.org/show_bug.cgi?id=148568
784         <rdar://problem/22371346>
785
786         Reviewed by Anders Carlsson.
787
788         * WebKitTestRunner/TestController.cpp:
789         (WTR::TestController::createOtherPage):
790         (WTR::TestController::createWebViewWithOptions):
791         Add some zeroes.
792
793 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
794
795         [Mac] kill-old-processes should kill more processes
796         https://bugs.webkit.org/show_bug.cgi?id=148577
797
798         Reviewed by Tim Horton.
799
800         * BuildSlaveSupport/kill-old-processes:
801
802 2015-08-28  Jason Marcell  <jmarcell@apple.com>
803
804         The status message for combined builder queues should say "all builds succeeded" if everything
805         built correctly.
806         https://bugs.webkit.org/show_bug.cgi?id=148535
807
808         Reviewed by David Kilzer and Alexey Proskuryakov.
809
810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
811         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
812         say "all builds succeeded" if everything built correctly.
813
814 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
815
816         [GTK] Simplify the internal API to create a WebView
817         https://bugs.webkit.org/show_bug.cgi?id=148570
818
819         Reviewed by Žan Doberšek.
820
821         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
822         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
823         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
824         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
825         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
826         passing the received PageConfiguration.
827         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
828         (WTR::PlatformWebView::PlatformWebView): Create the WebView
829         passing the received PageConfiguration.
830
831 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
832
833         iOS Simulator API tests fails as Simulator is not running
834         https://bugs.webkit.org/show_bug.cgi?id=148501
835         rdar://problem/22447525
836
837         Reviewed by Daniel Bates.
838
839         This change is a workaround for <rdar://problem/22388812>.
840
841          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
842          and quit it on program termination when running tests on the iOS port.
843          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
844          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
845
846 2015-08-27  Alex Christensen  <achristensen@webkit.org>
847
848         Make DLLLauncherMain executables dependent on dll
849         https://bugs.webkit.org/show_bug.cgi?id=148548
850
851         Reviewed by Brent Fulgham.
852
853         * DumpRenderTree/CMakeLists.txt:
854         * DumpRenderTree/PlatformWin.cmake:
855         * MiniBrowser/win/CMakeLists.txt:
856         * TestWebKitAPI/CMakeLists.txt:
857         * TestWebKitAPI/PlatformWin.cmake:
858
859 2015-08-27  Lucas Forschler  <lforschler@apple.com>
860
861         Remove Mac slaves 188/189 after being replaced with 400/401.
862         
863         Unreviewed.
864         
865         * BuildSlaveSupport/build.webkit.org-config/config.json:
866
867 2015-08-27  Lucas Forschler  <lforschler@apple.com>
868
869         Add two bots to the Mac Yosemite queue.
870         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
871         
872         Unreviewed.
873         
874         * BuildSlaveSupport/build.webkit.org-config/config.json:
875
876 2015-08-27  Alex Christensen  <achristensen@webkit.org>
877
878         [Win CMake] Fix incremental build after r188673
879         https://bugs.webkit.org/show_bug.cgi?id=148539
880
881         Reviewed by Brent Fulgham.
882
883         * TestWebKitAPI/PlatformWin.cmake:
884         Copy forwarding headers from WebCore before building in case that was not yet done.
885         It used to be done when running CMake, but now it's a build step.
886
887 2015-08-27  Nan Wang  <n_wang@apple.com>
888
889         AX: Fix accessibility/select-element-at-index.html test
890         https://bugs.webkit.org/show_bug.cgi?id=148516
891
892         Reviewed by Chris Fleizach.
893
894         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
895
896         * DumpRenderTree/AccessibilityUIElement.cpp:
897         (setSelectedChildCallback):
898         (setSelectedChildAtIndexCallback):
899         (removeSelectionAtIndexCallback):
900         (elementAtPointCallback):
901         (sentenceAtOffsetCallback):
902         (stringForSelectionCallback):
903         (AccessibilityUIElement::getJSClass):
904         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
905         (AccessibilityUIElement::setSelectedChild):
906         (AccessibilityUIElement::setSelectedChildAtIndex):
907         (AccessibilityUIElement::removeSelectionAtIndex):
908         (AccessibilityUIElement::accessibilityValue):
909         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
910         (WTR::AccessibilityUIElement::wordAtOffset):
911         (WTR::AccessibilityUIElement::lineAtOffset):
912         (WTR::AccessibilityUIElement::sentenceAtOffset):
913         (WTR::AccessibilityUIElement::isSelectable):
914         (WTR::AccessibilityUIElement::isMultiSelectable):
915         (WTR::AccessibilityUIElement::setSelectedChild):
916         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
917         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
918         (WTR::AccessibilityUIElement::selectedChildrenCount):
919         (WTR::AccessibilityUIElement::selectedChildAtIndex):
920         (WTR::AccessibilityUIElement::isExpanded):
921         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
922         (WTR::AccessibilityUIElement::setSelectedChild):
923         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
924         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
925         (WTR::AccessibilityUIElement::accessibilityValue):
926
927 2015-08-27  Alex Christensen  <achristensen@webkit.org>
928
929         Build fix after r188982
930
931         * MiniBrowser/win/CMakeLists.txt:
932         The directory structure changed in the move.
933
934 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
935
936         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
937
938         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
939
940         * gtk/install-dependencies:
941
942 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
943
944         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
945
946         * Scripts/run-gtk-tests:
947         (TestRunner):
948
949 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
950
951         Fix GTK+ WTR crashes in initializeMainRunLoop()
952
953         Rubber-stamped by Žan Doberšek.
954
955         Initialize threading and main thread before
956         RunLoop::initializeMainRunLoop(), since the GLib implementation of
957         the RunLoop uses isMainThread() to decide whether to create a new
958         GMainContext or use the default one. Also use RunLoop::run() and
959         ::stop() instead of gtk_main/quit.
960
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::initialize):
963         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
964         (WTR::TestController::notifyDone):
965         (WTR::TestController::platformRunUntil):
966
967 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
968
969         Unreviewed, further shorten a test that times out because it's very long
970         running.
971
972         I've locally run these tests on repeat for 24 hours and found no genuine
973         failures, like deadlocks. So, the timeouts are probably because the test
974         machine is slow and debug is slow. We should just run this test for fewer
975         iterations.
976
977         * TestWebKitAPI/Tests/WTF/Lock.cpp:
978         (TestWebKitAPI::TEST):
979
980 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
981
982         Unreviewed build fix attempt on EFL
983
984         * WebKitTestRunner/PlatformEfl.cmake:
985
986 2015-08-26  Alex Christensen  <achristensen@webkit.org>
987
988         Build fix after r188982
989
990         * MiniBrowser/win/CMakeLists.txt:
991         Find .rc files in correct directory.
992
993 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
994
995         [EFL] Bump cairo version to 1.14.2
996         https://bugs.webkit.org/show_bug.cgi?id=148474
997
998         Reviewed by Csaba Osztrogonác.
999
1000         * efl/jhbuild.modules:
1001
1002 2015-08-26  Andy Estes  <aestes@apple.com>
1003
1004         Crash when following a Google search link to Twitter with Limit Adult Content enabled
1005         https://bugs.webkit.org/show_bug.cgi?id=147651
1006
1007         Rubber-stamped by Brady Eidson.
1008
1009         Taught TestRunner how to decide the navigation policy after a delay.
1010
1011         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1013         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1014         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1015         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1016         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1017         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
1018         * WebKitTestRunner/TestController.cpp:
1019         (WTR::TestController::initialize):
1020         (WTR::TestController::resetStateToConsistentValues):
1021         (WTR::TestController::decidePolicyForNavigationAction):
1022         * WebKitTestRunner/TestController.h:
1023         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
1024         * WebKitTestRunner/TestInvocation.cpp:
1025         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1026
1027 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
1028
1029         [Win] Rename 'WinLauncher' to 'MiniBrowser'
1030         https://bugs.webkit.org/show_bug.cgi?id=148485
1031
1032         Reviewed by Alex Christensen
1033
1034         Move the WinLauncher project and source files to a subdirectory
1035         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
1036         source code and project files.
1037         
1038         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
1039         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
1040         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
1041         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
1042         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
1043         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
1044         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
1045         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
1046         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
1047         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
1048         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
1049         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
1050         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
1051         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
1052         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
1053         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
1054         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
1055         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
1056         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
1057         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
1058         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
1059         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
1060         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
1061         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
1062         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
1063         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
1064         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
1065         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
1066         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
1067         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
1068         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
1069         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
1070         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
1071         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
1072         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1073         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
1074         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
1075         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1076         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1077         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
1078         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
1079         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
1080         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
1081         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
1082         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
1083         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
1084         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
1085         * MiniBrowser/win: Copied from WinLauncher.
1086         * MiniBrowser/win/Common.cpp:
1087         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
1088         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
1089         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
1090         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
1091         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
1092         * MiniBrowser/win/PageLoadTestClient.cpp:
1093         * MiniBrowser/win/PageLoadTestClient.h:
1094         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1095         * MiniBrowser/win/ResourceLoadDelegate.h:
1096         * MiniBrowser/win/WinLauncher.cpp: Removed.
1097         * MiniBrowser/win/WinLauncher.h: Removed.
1098         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
1099         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1100         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1101         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1102         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1103         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1104         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1105         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1106         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1107         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1108         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1109         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1110         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1111         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1112         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1113         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1114         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1115         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1116         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1117         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1118         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1119         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1120         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1121         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1122         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
1123         * MiniBrowser/win/WinLauncherReplace.h: Removed.
1124         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
1125         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
1126         * MiniBrowser/win/WinMain.cpp:
1127         * WinLauncher: Removed.
1128         * WinLauncher/AccessibilityDelegate.cpp: Removed.
1129         * WinLauncher/AccessibilityDelegate.h: Removed.
1130         * WinLauncher/CMakeLists.txt: Removed.
1131         * WinLauncher/Common.cpp: Removed.
1132         * WinLauncher/DOMDefaultImpl.cpp: Removed.
1133         * WinLauncher/DOMDefaultImpl.h: Removed.
1134         * WinLauncher/PageLoadTestClient.cpp: Removed.
1135         * WinLauncher/PageLoadTestClient.h: Removed.
1136         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
1137         * WinLauncher/PrintWebUIDelegate.h: Removed.
1138         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
1139         * WinLauncher/ResourceLoadDelegate.h: Removed.
1140         * WinLauncher/WebDownloadDelegate.cpp: Removed.
1141         * WinLauncher/WebDownloadDelegate.h: Removed.
1142         * WinLauncher/WinLauncher.cpp: Removed.
1143         * WinLauncher/WinLauncher.h: Removed.
1144         * WinLauncher/WinLauncher.vcxproj: Removed.
1145         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1146         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1147         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1148         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1149         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1150         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1151         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1152         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1153         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1154         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1155         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1156         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1157         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1158         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1159         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1160         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1161         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1162         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1163         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1164         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1165         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1166         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1167         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1168         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
1169         * WinLauncher/WinLauncherReplace.h: Removed.
1170         * WinLauncher/WinLauncherWebHost.cpp: Removed.
1171         * WinLauncher/WinLauncherWebHost.h: Removed.
1172         * WinLauncher/WinMain.cpp: Removed.
1173         * WinLauncher/resource.h: Removed.
1174         * WinLauncher/stdafx.cpp: Removed.
1175         * WinLauncher/stdafx.h: Removed.
1176         * win/AssembleBuildLogs/AssembleLogs.cmd:
1177
1178 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
1179
1180         [Win] Simplify menu handling code in WinLauncher
1181         https://bugs.webkit.org/show_bug.cgi?id=148461
1182
1183         Reviewed by Zalan Bujtas.
1184
1185         Revise 'ToggleMenuItem' to return a boolean value indicating if
1186         it handled the message. Revise WndProc to use this to decide if it
1187         should pass the message on to the default handler, rather than
1188         duplicating the logic in both places.
1189         
1190         * WinLauncher/Common.cpp:
1191         (ToggleMenuItem): Return true if the menu item message was handled.
1192         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
1193         the message tothe default handler.
1194
1195 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1196
1197         Remove unused code after r188948
1198         https://bugs.webkit.org/show_bug.cgi?id=148467
1199
1200         Reviewed by Gyuyoung Kim.
1201
1202         * WebKitTestRunner/TestController.cpp:
1203         (WTR::TestController::platformPreferences): Deleted.
1204
1205 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1206
1207         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
1208         https://bugs.webkit.org/show_bug.cgi?id=148377
1209
1210         Reviewed by Carlos Garcia Campos.
1211
1212         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
1213         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
1214         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
1215         EFL and GTK at the moment.
1216
1217         * WebKitTestRunner/TestController.cpp:
1218         (WTR::TestController::platformWillRunTest):
1219         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1220         (WTR::TestController::platformPreferences):
1221         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1222         (WTR::TestController::platformPreferences):
1223
1224 2015-08-25  Nan Wang  <n_wang@apple.com>
1225
1226         AX: Enable accessibility/aria-controls.html test for mac
1227         https://bugs.webkit.org/show_bug.cgi?id=148458
1228
1229         Reviewed by Chris Fleizach.
1230
1231         Implemented ariaControlsElementAtIndex(unsigned index).
1232
1233         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1234         (AccessibilityUIElement::ariaControlsElementAtIndex):
1235         (AccessibilityUIElement::disclosedRowAtIndex):
1236         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1237         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1238
1239 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1240
1241         Remove python tests for PassRefPtr 
1242         https://bugs.webkit.org/show_bug.cgi?id=148463
1243
1244         Reviewed by Andy Estes.
1245
1246         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
1247
1248         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1249         (PassPtrTest): Deleted.
1250         (PassPtrTest.assert_pass_ptr_check): Deleted.
1251         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
1252         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
1253         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1254         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
1255         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
1256         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
1257
1258 2015-08-25  Andy Estes  <aestes@apple.com>
1259
1260         [iOS] run-webkit-tests fails if watchOS SDK is installed
1261         https://bugs.webkit.org/show_bug.cgi?id=148453
1262
1263         Reviewed by David Kilzer.
1264
1265         * Scripts/webkitpy/xcode/simulator.py:
1266         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
1267         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1268
1269 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
1270
1271         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
1272         https://bugs.webkit.org/show_bug.cgi?id=148197
1273         rdar://problem/22334382
1274
1275         Reviewed by Daniel Bates.
1276
1277         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
1278         * Scripts/webkitpy/port/ios.py:
1279         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
1280         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
1281         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
1282         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
1283         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
1284
1285 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1286
1287         Remove PassRefPtr style check rule
1288         https://bugs.webkit.org/show_bug.cgi?id=148432
1289
1290         Reviewed by Andreas Kling.
1291
1292         PassRefPtr is being removed. Thus style rule needs to be removed as well.
1293
1294         * Scripts/webkitpy/style/checkers/cpp.py:
1295         (_check_parameter_name_against_text): Deleted.
1296         (check_function_definition_and_pass_ptr): Deleted.
1297         (check_function_definition): Deleted.
1298         (check_pass_ptr_usage): Deleted.
1299         (process_line): Deleted.
1300         (CppChecker): Deleted.
1301
1302 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
1303
1304         [Win] Expose "Inverted Colors" option in WinLauncher
1305         https://bugs.webkit.org/show_bug.cgi?id=148451
1306
1307         Reviewed by Tim Horton.
1308
1309         Add the ability to toggle the "Inverted Colors" preference
1310         in WinLauncher.
1311         
1312         * WinLauncher/Common.cpp:
1313         (ToggleMenuItem): Toggle the feature when the menu item
1314         is selected.
1315         (WndProc): Recognize the new menu option.
1316         * WinLauncher/WinLauncher.cpp:
1317         (WinLauncher::setToDefaultPreferences): Launch with "Invert
1318         Colors" turned off.
1319         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
1320         entry for "Invert Colors".
1321         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1322
1323 2015-08-25  Nan Wang  <n_wang@apple.com>
1324
1325         [Mac] accessibility/document-attributes.html fails
1326         https://bugs.webkit.org/show_bug.cgi?id=116636
1327
1328         Reviewed by Chris Fleizach.
1329
1330         Implemented documentURI() and documentEncoding().
1331
1332         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1333         (AccessibilityUIElement::documentEncoding):
1334         (AccessibilityUIElement::documentURI):
1335         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1336         (WTR::AccessibilityUIElement::documentEncoding):
1337         (WTR::AccessibilityUIElement::documentURI):
1338
1339 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
1340
1341         [Win] Unreviewed test gardening.
1342
1343         Fix another case where the logging string is constructed using the variable 'frame',
1344         but the method argument is not given a name. This causes the global 'frame' value to
1345         be used, producing incorrect output.
1346
1347         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1348         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
1349         argument.
1350
1351 2015-08-24  Tim Horton  <timothy_horton@apple.com>
1352
1353         (Finally...) get rid of WKViewIOS
1354         https://bugs.webkit.org/show_bug.cgi?id=148404
1355
1356         Reviewed by Anders Carlsson.
1357
1358         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1359         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1360         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1361         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1362         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1363         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1364         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1365         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1366         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1367         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
1368         Mark tests that use WKBrowsingContextController as Mac-only.
1369
1370         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1371         (WTR::AccessibilityController::addNotificationListener):
1372         * WebKitTestRunner/ios/mainIOS.mm:
1373         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
1374         Import UIKit instead of depending on WKView.h to do so.
1375
1376 2015-08-24  Jason Marcell  <jmarcell@apple.com>
1377
1378         Add support to dashboard for displaying Git SHA's as revisions.
1379         https://bugs.webkit.org/show_bug.cgi?id=148387
1380
1381         Reviewed by Daniel Bates.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1384         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1386         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
1388         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
1389
1390 2015-08-24  Andy Estes  <aestes@apple.com>
1391
1392         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
1393
1394         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
1395
1396 2015-08-23  Andy Estes  <aestes@apple.com>
1397
1398         Addressed a missed piece of review feedback from r188851.
1399
1400         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1401
1402 2015-08-23  Andy Estes  <aestes@apple.com>
1403
1404         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
1405         https://bugs.webkit.org/show_bug.cgi?id=147872
1406         rdar://problem/22044000
1407
1408         Reviewed by Dan Bernstein.
1409         
1410         Added an API test.
1411
1412         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
1413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
1415         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
1416         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
1417         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
1418         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
1419         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
1420         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
1421         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
1422         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
1423
1424 2015-08-23  Andy Estes  <aestes@apple.com>
1425
1426         Fixed the 32-bit Mac build after r188844.
1427
1428         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1429         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1430
1431 2015-08-22  Andy Estes  <aestes@apple.com>
1432
1433         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
1434         https://bugs.webkit.org/show_bug.cgi?id=148317
1435
1436         Reviewed by Dan Bernstein.
1437
1438         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
1439         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
1440         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
1441         when creating WKWebViews.
1442
1443         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
1444         added a new API test for bundle parameters.
1445
1446         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
1447         named its executable TestWebKitAPI.bundle.
1448         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
1449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
1450         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
1451         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
1452         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
1453         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
1454         bundle parameter and asked for an initial notification.
1455         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
1456         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
1457         mirror its value in the main frame's JSContext.
1458         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
1459         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
1460         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
1461         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
1462         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
1463         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
1464         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
1465         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
1466         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
1467         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
1468
1469 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
1470
1471         URTBF after r188828.
1472
1473         * WebKitTestRunner/PlatformWebView.h:
1474
1475 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
1476
1477         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
1478         https://bugs.webkit.org/show_bug.cgi?id=148356
1479
1480         Reviewed by Darin Adler.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1483         (BuildbotCombinedQueueView.prototype.update):
1484
1485 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
1486
1487         build.webkit.org/dashboard: Respect step's hidden flag
1488         https://bugs.webkit.org/show_bug.cgi?id=148357
1489
1490         Reviewed by Darin Adler.
1491
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1493         (BuildbotIteration.prototype._parseData):
1494
1495 2015-08-23  Nan Wang  <n_wang@apple.com>
1496
1497         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
1498         https://bugs.webkit.org/show_bug.cgi?id=148328
1499
1500         Reviewed by Darin Adler.
1501
1502         We should only expose stringValue() when value attribute is set.
1503
1504         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1505         (AccessibilityUIElement::stringValue):
1506         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1507         (WTR::AccessibilityUIElement::stringValue):
1508
1509 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1510
1511         Remove style checking rule regarding OwnPtr and PassOwnPtr
1512         https://bugs.webkit.org/show_bug.cgi?id=148360
1513
1514         Reviewed by Darin Adler.
1515
1516         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
1517         Removed it.
1518
1519         * Scripts/do-webcore-rename:
1520         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1521         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
1522         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1523         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
1524         (WebKitStyleTest.test_names): Deleted.
1525
1526 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
1527
1528         WebKitTestRunner should use WKWebView on OS X and iOS
1529         https://bugs.webkit.org/show_bug.cgi?id=143743
1530         <rdar://problem/16947123>
1531
1532         Reviewed by Anders Carlsson.
1533         Patch by Enrica Casucci and myself.
1534
1535         * WebKitTestRunner/PlatformWebView.h:
1536         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1537         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1538         instead of WKContext and WKPageGroup.
1539
1540         Remove the unused, always-true windowSnapshotEnabled().
1541         While technically some platforms don't have window snapshotting,
1542         they just return null instead of implementing windowSnapshotEnabled().
1543
1544         * WebKitTestRunner/TestController.h:
1545         * WebKitTestRunner/TestController.cpp:
1546         (WTR::TestController::createOtherPage):
1547         (WTR::TestController::initialize):
1548         (WTR::TestController::createWebViewWithOptions):
1549         Delegate to the various platforms for creating PlatformWebView instances,
1550         for creating WKContexts, and for accessing WKPreferences,
1551         so that they can do special things (like, use WKWebView instead!).
1552
1553         (WTR::TestController::resetPreferencesToConsistentValues):
1554         Make explicit WebKitTestRunner's desired default for two preferences
1555         which have differing defaults between the antique and modern API,
1556         for consistency's sake.
1557
1558         (WTR::TestController::resetStateToConsistentValues):
1559         Add platformResetStateToConsistentValues.
1560
1561         * WebKitTestRunner/TestInvocation.cpp:
1562         (WTR::TestInvocation::dumpResults):
1563         Adjust to the aforementioned removal of windowSnapshotEnabled().
1564
1565         * WebKitTestRunner/ios/TestControllerCocoa.mm:
1566         (WTR::TestController::platformResetStateToConsistentValues):
1567         (WTR::TestController::platformPreferences):
1568         (WTR::TestController::platformCreateWebView):
1569         (WTR::TestController::platformCreateOtherPage):
1570         (WTR::TestController::platformInitializeConfiguration):
1571         Implement the new platform functions for the Modern WebKit2 API,
1572         in a new TestControllerCocoa file that is shared between iOS and Mac.
1573         
1574         For platformMaybeCreateContext, use the trick that we know we can cast
1575         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1576         WKWebView's configuration.
1577
1578         Ditto for WKPreferencesRef and WKPreferences.
1579
1580         Remove user content filters on the WKWebView's userContentController.
1581
1582         * WebKitTestRunner/mac/TestControllerMac.mm:
1583         * WebKitTestRunner/ios/TestControllerIOS.mm:
1584         Move code into TestControllerCocoa.
1585
1586         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1587         (WTR::InjectedBundle::beginTesting):
1588         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1589         (WTR::TestRunner::addUserScript):
1590         (WTR::TestRunner::addUserStyleSheet):
1591         Adopt WKBundlePage API for user scripts/sheets.
1592
1593         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1594         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1595         Make and keep a WKWebView instead of a WKView.
1596         
1597         * WebKitTestRunner/mac/EventSenderProxy.mm:
1598         (WTR::EventSenderProxy::mouseUp):
1599         (WTR::EventSenderProxy::mouseMoveTo):
1600         Reach inside the WKWebView to the WKView when dispatching events.
1601         This is fairly ugly and we should come up with a better solution.
1602         Also, fix some flipping and style errors.
1603
1604 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1605
1606         Unreviewed, attempt to fix GTK build after r188718
1607
1608         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1609         (WTR::PlatformWebView::PlatformWebView):
1610
1611 2015-08-21  Commit Queue  <commit-queue@webkit.org>
1612
1613         Unreviewed, rolling out r188807, r188813, and r188815.
1614         https://bugs.webkit.org/show_bug.cgi?id=148349
1615
1616         lots of 32-bit build problems, better to resolve separately
1617         and try again (Requested by thorton on #webkit).
1618
1619         Reverted changesets:
1620
1621         "WebKitTestRunner should use WKWebView on OS X and iOS"
1622         https://bugs.webkit.org/show_bug.cgi?id=143743
1623         http://trac.webkit.org/changeset/188807
1624
1625         "Stop building WebKitTestRunner for 32-bit platforms"
1626         https://bugs.webkit.org/show_bug.cgi?id=143743
1627         http://trac.webkit.org/changeset/188813
1628
1629         "Stop building WebKitTestRunner for 32-bit platforms"
1630         https://bugs.webkit.org/show_bug.cgi?id=143743
1631         http://trac.webkit.org/changeset/188815
1632
1633 2015-08-21  Tim Horton  <timothy_horton@apple.com>
1634
1635         Stop building WebKitTestRunner for 32-bit platforms
1636         https://bugs.webkit.org/show_bug.cgi?id=143743
1637         <rdar://problem/16947123>
1638
1639         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1640         This is a restriction on the valid set, not the desired set.
1641
1642 2015-08-21  Jason Marcell  <jmarcell@apple.com>
1643
1644         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
1645         to work with these new objects.
1646         https://bugs.webkit.org/show_bug.cgi?id=148188
1647
1648         Reviewed by Daniel Bates.
1649
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1651         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1653         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
1654         (repository, "branch name")-pair.
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1657         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1659         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
1660         objects which represent a (repository, "branch name")-pair.
1661         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1662         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1663         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
1664         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
1665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
1666         BuildbotQueue.branch to BuildbotQueue.branches.
1667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1668         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
1669
1670 2015-08-21  Tim Horton  <timothy_horton@apple.com>
1671
1672         Stop building WebKitTestRunner for 32-bit platforms
1673         https://bugs.webkit.org/show_bug.cgi?id=143743
1674         <rdar://problem/16947123>
1675
1676         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1677         WKWebView is not available on 32-bit OS X.
1678
1679 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
1680
1681         [Win] Unreviewed test correction after r188709.
1682
1683         I removed a function argument that happened to be mirrored by a global
1684         value with the same name. This prevented a compile error, but testing
1685         showed that the wrong value was being used in the function.
1686
1687         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1688         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
1689         back
1690
1691 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
1692
1693         WebKitTestRunner should use WKWebView on OS X and iOS
1694         https://bugs.webkit.org/show_bug.cgi?id=143743
1695         <rdar://problem/16947123>
1696
1697         Reviewed by Anders Carlsson.
1698         Patch by Enrica Casucci and myself.
1699
1700         * WebKitTestRunner/PlatformWebView.h:
1701         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1702         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1703         instead of WKContext and WKPageGroup.
1704
1705         Remove the unused, always-true windowSnapshotEnabled().
1706         While technically some platforms don't have window snapshotting,
1707         they just return null instead of implementing windowSnapshotEnabled().
1708
1709         * WebKitTestRunner/TestController.h:
1710         * WebKitTestRunner/TestController.cpp:
1711         (WTR::TestController::createOtherPage):
1712         (WTR::TestController::initialize):
1713         (WTR::TestController::createWebViewWithOptions):
1714         Delegate to the various platforms for creating PlatformWebView instances,
1715         for creating WKContexts, and for accessing WKPreferences,
1716         so that they can do special things (like, use WKWebView instead!).
1717
1718         (WTR::TestController::resetPreferencesToConsistentValues):
1719         Make explicit WebKitTestRunner's desired default for two preferences
1720         which have differing defaults between the antique and modern API,
1721         for consistency's sake.
1722
1723         (WTR::TestController::resetStateToConsistentValues):
1724         Add platformResetStateToConsistentValues.
1725
1726         * WebKitTestRunner/TestInvocation.cpp:
1727         (WTR::TestInvocation::dumpResults):
1728         Adjust to the aforementioned removal of windowSnapshotEnabled().
1729
1730         * WebKitTestRunner/ios/TestControllerCocoa.mm:
1731         (WTR::TestController::platformResetStateToConsistentValues):
1732         (WTR::TestController::platformPreferences):
1733         (WTR::TestController::platformCreateWebView):
1734         (WTR::TestController::platformCreateOtherPage):
1735         (WTR::TestController::platformInitializeConfiguration):
1736         Implement the new platform functions for the Modern WebKit2 API,
1737         in a new TestControllerCocoa file that is shared between iOS and Mac.
1738         
1739         For platformMaybeCreateContext, use the trick that we know we can cast
1740         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1741         WKWebView's configuration.
1742
1743         Ditto for WKPreferencesRef and WKPreferences.
1744
1745         Remove user content filters on the WKWebView's userContentController.
1746
1747         * WebKitTestRunner/mac/TestControllerMac.mm:
1748         * WebKitTestRunner/ios/TestControllerIOS.mm:
1749         Move code into TestControllerCocoa.
1750
1751         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1752         (WTR::InjectedBundle::beginTesting):
1753         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1754         (WTR::TestRunner::addUserScript):
1755         (WTR::TestRunner::addUserStyleSheet):
1756         Adopt WKBundlePage API for user scripts/sheets.
1757
1758         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1759         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1760         Make and keep a WKWebView instead of a WKView.
1761         
1762         * WebKitTestRunner/mac/EventSenderProxy.mm:
1763         (WTR::EventSenderProxy::mouseUp):
1764         (WTR::EventSenderProxy::mouseMoveTo):
1765         Reach inside the WKWebView to the WKView when dispatching events.
1766         This is fairly ugly and we should come up with a better solution.
1767         Also, fix some flipping and style errors.
1768
1769 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
1770
1771         Improve how UI events are dispatched by WebKitTestRunner
1772         https://bugs.webkit.org/show_bug.cgi?id=148326
1773
1774         Reviewed by Anders Carlsson.
1775
1776         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1777         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1778         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
1779         asynchronous (and really, it has always been for the most part).
1780
1781         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1782         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
1783         (WTR::EventSendingController::mouseUp): Ditto.
1784         (WTR::EventSendingController::mouseMoveTo): Ditto.
1785         (WTR::EventSendingController::mouseForceDown): Ditto.
1786         (WTR::EventSendingController::mouseForceUp): Ditto.
1787         (WTR::EventSendingController::mouseForceChanged): Ditto.
1788         (WTR::EventSendingController::leapForward): Ditto.
1789         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
1790         (WTR::EventSendingController::keyDown): Ditto.
1791         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
1792         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
1793         to be done in custom WebKit2 code for test wheel event handling.
1794         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
1795         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
1796         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
1797         (WTR::EventSendingController::addTouchPoint): Ditto.
1798         (WTR::EventSendingController::updateTouchPoint): Ditto.
1799         (WTR::EventSendingController::setTouchModifier): Ditto.
1800         (WTR::EventSendingController::setTouchPointRadius): Ditto.
1801         (WTR::EventSendingController::touchStart): Ditto.
1802         (WTR::EventSendingController::touchMove): Ditto.
1803         (WTR::EventSendingController::touchEnd): Ditto.
1804         (WTR::EventSendingController::touchCancel): Ditto.
1805         (WTR::EventSendingController::clearTouchPoints): Ditto.
1806         (WTR::EventSendingController::releaseTouchPoint): Ditto.
1807         (WTR::EventSendingController::cancelTouchPoint): Ditto.
1808
1809         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1810         (WTR::InjectedBundle::postSetWindowIsKey):
1811         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1812         (WTR::InjectedBundle::isGeolocationProviderActive):
1813         (WTR::InjectedBundle::shouldProcessWorkQueue):
1814         Updated for WKBundlePagePostSynchronousMessage renaming.
1815
1816         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1817         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
1818
1819         * WebKitTestRunner/TestController.cpp:
1820         (WTR::TestController::initialize): Allow handling the new test style messages.
1821         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
1822         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
1823         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1824         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
1825         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
1826
1827         * WebKitTestRunner/mac/EventSenderProxy.mm:
1828         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
1829         (WTR::EventSenderProxy::keyDown): Ditto.
1830         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
1831         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1832
1833 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1834
1835         Skip no-llint tests that fail due to running out of executable memory after r188969
1836         https://bugs.webkit.org/show_bug.cgi?id=148273
1837
1838         Reviewed by Michael Saboff.
1839
1840         * Scripts/run-jsc-stress-tests:
1841
1842 2015-08-21  Nan Wang  <n_wang@apple.com>
1843
1844         [Mac] accessibility/selection-states.html fails
1845         https://bugs.webkit.org/show_bug.cgi?id=116637
1846
1847         Reviewed by Chris Fleizach.
1848
1849         Implemented isSelectable() and isMultiSelectable().
1850
1851         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1852         (AccessibilityUIElement::isSelectable):
1853         (AccessibilityUIElement::isMultiSelectable):
1854         (AccessibilityUIElement::isSelectedOptionActive):
1855         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1856         (WTR::AccessibilityUIElement::isSelectable):
1857         (WTR::AccessibilityUIElement::isMultiSelectable):
1858         (WTR::AccessibilityUIElement::isVisible):
1859
1860 2015-08-21  Jason Marcell  <jmarcell@apple.com>
1861
1862         Fix iteration over repositories on bot watcher's dashboard.
1863
1864         Reviewed by Alexey Proskuryakov.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1867         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
1868
1869 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
1870
1871         [EFL] Revise PlatformWebView ctor according to r188718
1872         https://bugs.webkit.org/show_bug.cgi?id=148282
1873
1874         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
1875         instead of WKContextRef and WKPageGroupRef respectively.
1876
1877         Reviewed by Gyuyoung Kim.
1878
1879         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1880         (WTR::PlatformWebView::PlatformWebView):
1881
1882 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
1883
1884         Unreviewed, changed Devin Rousso's email.
1885
1886         * Scripts/webkitpy/common/config/contributors.json:
1887
1888 2015-08-20  Anders Carlsson  <andersca@apple.com>
1889
1890         Use WKPageConfigurationRef in WebKitTestRunner
1891         https://bugs.webkit.org/show_bug.cgi?id=147996
1892
1893         Reviewed by Tim Horton.
1894
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::TestController::createOtherPage):
1897         (WTR::TestController::initialize):
1898         (WTR::TestController::createWebViewWithOptions):
1899         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1900         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
1901         (WTR::PlatformWebView::PlatformWebView):
1902         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
1903
1904 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
1905
1906         [Win] Update Windows tools for revised MIDL interfaces
1907         https://bugs.webkit.org/show_bug.cgi?id=148249
1908
1909         Reviewed by Dean Jackson.
1910
1911         This is a follow-up to Bug 148001.
1912
1913         Revise the testing software to use compatible signatures and
1914         implementations to match the requirements of the IDL generated
1915         with the SAL annotations.
1916
1917         * DumpRenderTree/win/DRTDataObject.cpp:
1918         * DumpRenderTree/win/DRTDataObject.h:
1919         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1920         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1921         * DumpRenderTree/win/DRTDropSource.cpp:
1922         * DumpRenderTree/win/DRTDropSource.h:
1923         * DumpRenderTree/win/DumpRenderTree.cpp:
1924         * DumpRenderTree/win/EditingDelegate.cpp:
1925         * DumpRenderTree/win/EditingDelegate.h:
1926         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1927         * DumpRenderTree/win/FrameLoadDelegate.h:
1928         * DumpRenderTree/win/HistoryDelegate.cpp:
1929         * DumpRenderTree/win/HistoryDelegate.h:
1930         * DumpRenderTree/win/PolicyDelegate.cpp:
1931         * DumpRenderTree/win/PolicyDelegate.h:
1932         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1933         * DumpRenderTree/win/ResourceLoadDelegate.h:
1934         * DumpRenderTree/win/TestRunnerWin.cpp:
1935         * DumpRenderTree/win/UIDelegate.cpp:
1936         * DumpRenderTree/win/UIDelegate.h:
1937         * WinLauncher/AccessibilityDelegate.cpp:
1938         * WinLauncher/AccessibilityDelegate.h:
1939         * WinLauncher/Common.cpp:
1940         * WinLauncher/DOMDefaultImpl.cpp:
1941         * WinLauncher/DOMDefaultImpl.h:
1942         * WinLauncher/PageLoadTestClient.cpp:
1943         * WinLauncher/PageLoadTestClient.h:
1944         * WinLauncher/PrintWebUIDelegate.cpp:
1945         * WinLauncher/PrintWebUIDelegate.h:
1946         * WinLauncher/ResourceLoadDelegate.cpp:
1947         * WinLauncher/ResourceLoadDelegate.h:
1948         * WinLauncher/WebDownloadDelegate.cpp:
1949         * WinLauncher/WebDownloadDelegate.h:
1950         * WinLauncher/WinLauncherWebHost.cpp:
1951         * WinLauncher/WinLauncherWebHost.h:
1952         * WinLauncher/WinMain.cpp:
1953         * win/DLLLauncher/DLLLauncherMain.cpp:
1954
1955 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
1956
1957         Unreviewed, shorten a test that runs too long and times out.
1958
1959         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1960         (TestWebKitAPI::TEST):
1961
1962 2015-08-20  Alex Christensen  <achristensen@webkit.org>
1963
1964         Clean up CMake build after r188673
1965         https://bugs.webkit.org/show_bug.cgi?id=148234
1966
1967         Reviewed by Tim Horton.
1968
1969         * DumpRenderTree/PlatformWin.cmake:
1970         * TestWebKitAPI/CMakeLists.txt:
1971         * TestWebKitAPI/PlatformWin.cmake:
1972         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1973         gtest needs to be a static library on Windows to not crash.
1974
1975 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1976
1977         CMake Windows build should not include files directly from other Source directories
1978         https://bugs.webkit.org/show_bug.cgi?id=148198
1979
1980         Reviewed by Brent Fulgham.
1981
1982         * DumpRenderTree/DumpRenderTreePrefix.h:
1983         Include cmakeconfig.h to properly define all enabled features.
1984         * DumpRenderTree/PlatformWin.cmake:
1985         * TestWebKitAPI/PlatformWin.cmake:
1986
1987 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1988
1989         Build TestWTF on Mac with CMake.
1990         https://bugs.webkit.org/show_bug.cgi?id=147972
1991
1992         Reviewed by Tim Horton.
1993
1994         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1995         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1996
1997         * TestWebKitAPI/CMakeLists.txt:
1998         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1999         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
2000         * TestWebKitAPI/PlatformMac.cmake: Added.
2001         * TestWebKitAPI/config.h:
2002         Postpone some build fixes until WebKit builds completely on Mac with CMake.
2003
2004 2015-08-19  Brian Burg  <bburg@apple.com>
2005
2006         Unreviewed, add Aleksandr Skachkov to the list of contributors.
2007
2008         * Scripts/webkitpy/common/config/contributors.json:
2009
2010 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2011
2012         REGRESSION(r188548): [GTK] Build broken.
2013         https://bugs.webkit.org/show_bug.cgi?id=148154
2014
2015         Reviewed by Martin Robinson.
2016
2017         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2018         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2019         Even if we don't need to add/override any settings in ViewOptions,
2020         we need to define this as an empty function to make it build.
2021
2022 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2023
2024         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
2025         https://bugs.webkit.org/show_bug.cgi?id=148073
2026
2027         Reviewed by Alexey Proskuryakov.
2028
2029         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
2030         (TestWebKitAPI::TEST):
2031
2032 2015-08-18  Anders Carlsson  <andersca@apple.com>
2033
2034         Fix test failure fallout from r188602 by using a V5 page ui client struct.
2035
2036         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2037         (TestWebKitAPI::setUpClients):
2038
2039 2015-08-18  Brian Burg  <bburg@apple.com>
2040
2041         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2042         https://bugs.webkit.org/show_bug.cgi?id=147955
2043
2044         Reviewed by Timothy Hatcher.
2045
2046         To enable sharing of common test code between protocol and model tests,
2047         start loading the protocol TestStub.js through the WebInspectorUI bundle.
2048
2049         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2050         protocol-test.js uses to load the inspector frontend stub into its iframe
2051         from an arbitrary local file URL.
2052
2053         * DumpRenderTree/TestRunner.cpp:
2054         (getInspectorTestStubURLCallback):
2055         (TestRunner::staticValues):
2056         * DumpRenderTree/TestRunner.h:
2057         * DumpRenderTree/mac/TestRunnerMac.mm:
2058         (SOFT_LINK_STAGED_FRAMEWORK):
2059         (TestRunner::inspectorTestStubURL):
2060         * DumpRenderTree/win/TestRunnerWin.cpp:
2061         (TestRunner::inspectorTestStubURL):
2062         * WebKitTestRunner/Configurations/Base.xcconfig:
2063         Since WebKitTestRunner now includes WebCore private headers, also search
2064         for the WebCore framework inside the WebKit umbrella framework.
2065
2066         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2067         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2068         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2069         (WTR::TestRunner::inspectorTestStubURL):
2070         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2071         (WTR::TestRunner::inspectorTestStubURL):
2072         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2073         (WTR::TestRunner::inspectorTestStubURL):
2074
2075 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
2076
2077         Unreviewed, fix GTK build.
2078
2079         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2080         (TestWebKitAPI::TEST):
2081
2082 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
2083
2084         Replace all remaining uses of WTF::Mutex with WTF::Lock
2085         https://bugs.webkit.org/show_bug.cgi?id=148089
2086
2087         Reviewed by Geoffrey Garen.
2088
2089         * DumpRenderTree/JavaScriptThreading.cpp:
2090         (javaScriptThreadsMutex):
2091         (runJavaScriptThread):
2092         (startJavaScriptThreads):
2093         (stopJavaScriptThreads):
2094         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
2095         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2096         (TestWebKitAPI::TEST):
2097         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2098         (TestWebKitAPI::TEST):
2099
2100 2015-08-17  Commit Queue  <commit-queue@webkit.org>
2101
2102         Unreviewed, rolling out r188539, r188544, r188552, and
2103         r188564.
2104         https://bugs.webkit.org/show_bug.cgi?id=148122
2105
2106         Broke tests and some build styles (Requested by ap on
2107         #webkit).
2108
2109         Reverted changesets:
2110
2111         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
2112         bundle"
2113         https://bugs.webkit.org/show_bug.cgi?id=147955
2114         http://trac.webkit.org/changeset/188539
2115
2116         "Web Inspector: split TestStub.js into multiple files and
2117         modernize it"
2118         https://bugs.webkit.org/show_bug.cgi?id=148077
2119         http://trac.webkit.org/changeset/188544
2120
2121         "Web Inspector: InspectorTest should be a subclass of
2122         TestHarness"
2123         https://bugs.webkit.org/show_bug.cgi?id=148079
2124         http://trac.webkit.org/changeset/188552
2125
2126         "Unreviewed internal build fix attempt after r188539."
2127         http://trac.webkit.org/changeset/188564
2128
2129 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2130
2131         [OS X] Remove support for composite fonts
2132         https://bugs.webkit.org/show_bug.cgi?id=147920
2133
2134         Reviewed by Dan Bernstein.
2135
2136         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2137         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2138         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2139         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2140         * DumpRenderTree/mac/DumpRenderTree.mm:
2141         (allowedFontFamilySet): Deleted.
2142         (activateTestingFonts): Deleted.
2143         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2144         (WTR::allowedFontFamilySet): Deleted.
2145         (WTR::activateFonts): Deleted.
2146         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2147         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2148         * WebKitTestRunner/mac/TestControllerMac.mm:
2149         (WTR::allowedFontFamilySet): Deleted.
2150
2151 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
2152
2153         Unreviewed internal build fix attempt after r188539.
2154
2155         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2156
2157 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2158
2159         Fix the build
2160
2161         Unreviewed.
2162
2163         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2164
2165 2015-08-17  Alex Christensen  <achristensen@webkit.org>
2166
2167         Build Debug Suffix on Windows with CMake
2168         https://bugs.webkit.org/show_bug.cgi?id=148083
2169
2170         Reviewed by Brent Fulgham.
2171
2172         * TestWebKitAPI/CMakeLists.txt:
2173         * TestWebKitAPI/PlatformWin.cmake:
2174         Add DEBUG_SUFFIX
2175
2176 2015-08-17  Anders Carlsson  <andersca@apple.com>
2177
2178         Simplify how PlatformWebViews are created when view options change
2179         https://bugs.webkit.org/show_bug.cgi?id=148093
2180
2181         Reviewed by Sam Weinig.
2182
2183         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
2184
2185         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
2186         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
2187         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
2188
2189         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
2190
2191         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
2192         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
2193
2194         * WebKitTestRunner/TestController.cpp:
2195         (WTR::TestController::ensureViewSupportsOptionsForTest):
2196         (WTR::shouldUseFixedLayout):
2197         (WTR::TestController::viewOptionsForTest):
2198         (WTR::TestController::updateWebViewSizeForTest):
2199         (WTR::TestController::updateWindowScaleForTest):
2200         (WTR::TestController::configureViewForTest):
2201         (WTR::TestController::initialize): Deleted.
2202         (WTR::TestController::ensureViewSupportsOptions): Deleted.
2203         (WTR::TestController::updateLayoutTypeForTest): Deleted.
2204         (WTR::TestController::platformConfigureViewForTest): Deleted.
2205         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
2206         (WTR::TestController::run): Deleted.
2207         * WebKitTestRunner/TestController.h:
2208         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2209         (WTR::shouldUseFixedLayout):
2210         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2211         (WTR::TestController::platformConfigureViewForTest):
2212         (WTR::TestController::platformResetPreferencesToConsistentValues):
2213         * WebKitTestRunner/ios/TestControllerIOS.mm:
2214         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2215         * WebKitTestRunner/mac/TestControllerMac.mm:
2216         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2217         (WTR::TestController::platformConfigureViewForTest):
2218
2219 2015-08-17  Sam Weinig  <sam@webkit.org>
2220
2221         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
2222         https://bugs.webkit.org/show_bug.cgi?id=148097
2223
2224         Reviewed by Anders Carlsson.
2225
2226         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
2227         Add tests for WebsiteDataStores in the WKPageConfiguration.
2228
2229 2015-08-17  Brian Burg  <bburg@apple.com>
2230
2231         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2232         https://bugs.webkit.org/show_bug.cgi?id=147955
2233
2234         Reviewed by Timothy Hatcher.
2235
2236         To enable sharing of common test code between protocol and model tests,
2237         start loading the protocol TestStub.js through the WebInspectorUI bundle.
2238
2239         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2240         protocol-test.js uses to load the inspector frontend stub into its iframe
2241         from an arbitrary local file URL.
2242
2243         * DumpRenderTree/TestRunner.cpp:
2244         (getInspectorTestStubURLCallback):
2245         (TestRunner::staticValues):
2246         * DumpRenderTree/TestRunner.h:
2247         * DumpRenderTree/mac/TestRunnerMac.mm:
2248         (SOFT_LINK_STAGED_FRAMEWORK):
2249         (TestRunner::inspectorTestStubURL):
2250         * DumpRenderTree/win/TestRunnerWin.cpp:
2251         (TestRunner::inspectorTestStubURL):
2252         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2254         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2255         (WTR::TestRunner::inspectorTestStubURL):
2256         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2257         (WTR::TestRunner::inspectorTestStubURL):
2258         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2259         (WTR::TestRunner::inspectorTestStubURL):
2260
2261 2015-08-17  Saam barati  <sbarati@apple.com>
2262
2263         Change email address from saambarati1@gmail.com to sbarati@apple.com
2264
2265         * Scripts/webkitpy/common/config/contributors.json:
2266
2267 2015-08-17  Jason Marcell  <jmarcell@apple.com>
2268
2269         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
2270         repositories other than "openSource" and "internal".
2271         https://bugs.webkit.org/show_bug.cgi?id=147961
2272
2273         Reviewed by Daniel Bates.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2276         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
2277         generically with repositories other than "openSource" and "internal".
2278
2279 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
2280
2281         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
2282         https://bugs.webkit.org/show_bug.cgi?id=148081
2283
2284         Reviewed by Tim Horton.
2285
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2287         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2288
2289 2015-08-11  Andy Estes  <aestes@apple.com>
2290
2291         [Cocoa] Add redirect support to CustomProtocolManager
2292         https://bugs.webkit.org/show_bug.cgi?id=147871
2293
2294         Reviewed by Dan Bernstein.
2295
2296         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
2297
2298         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2299         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
2300         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
2301         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2302         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
2303         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
2304         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
2305         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
2306         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
2307         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2308         (TestWebKitAPI::TEST): Unregistered TestProtocol.
2309         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
2310         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
2311         (-[TestProtocol startLoading]): Taught to handle redirect responses.
2312
2313 2015-08-13  Andy Estes  <aestes@apple.com>
2314
2315         [Cocoa] Downloads do not start if policy decision is made asynchronously
2316         https://bugs.webkit.org/show_bug.cgi?id=147985
2317
2318         Reviewed by Brady Eidson.
2319
2320         Added a new API test.
2321
2322         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2323         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2324         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
2325         (TEST):
2326
2327 2015-08-14  Commit Queue  <commit-queue@webkit.org>
2328
2329         Unreviewed, rolling out r187357.
2330         https://bugs.webkit.org/show_bug.cgi?id=148032
2331
2332         webkit-patch generates incorrect patches that cannot be
2333         applied (Requested by dydz on #webkit).
2334
2335         Reverted changeset:
2336
2337         "Call fixChangeLogPatch when generating patches from webkit-
2338         patch"
2339         https://bugs.webkit.org/show_bug.cgi?id=147248
2340         http://trac.webkit.org/changeset/187357
2341
2342 2015-08-14  Jason Marcell  <jmarcell@apple.com>
2343
2344         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
2345         other than "openSource" and "internal".
2346         https://bugs.webkit.org/show_bug.cgi?id=147938
2347
2348         Reviewed by Daniel Bates.
2349
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2351         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
2352         repositories other than "openSource" and "internal".
2353
2354 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
2355
2356         Unreviewed, shorten another test that is timing out.
2357
2358         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2359         (TestWebKitAPI::TEST):
2360
2361 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
2362
2363         AppScale: Assertion hit when hovering a webkit-queue bubble
2364         https://bugs.webkit.org/show_bug.cgi?id=147997
2365
2366         Reviewed by Alexey Proskuryakov.
2367
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2369         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
2370
2371 2015-08-13  Lucas Forschler  <lforschler@apple.com>
2372
2373         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
2374         
2375         Unreviewed.
2376         
2377         * Scripts/copy-webkitlibraries-to-product-directory:
2378
2379 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
2380
2381         Run benchmark customized Dromaeo should not assume there is an internet connection.
2382         https://bugs.webkit.org/show_bug.cgi?id=147995
2383
2384         Reviewed by Ryosuke Niwa.
2385
2386         Add several dependency js libs to local.
2387
2388         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2389
2390 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
2391
2392         WTF should have a compact Condition object to use with Lock
2393         https://bugs.webkit.org/show_bug.cgi?id=147986
2394
2395         Reviewed by Geoffrey Garen.
2396
2397         Add a test for WTF::Condition.
2398
2399         * TestWebKitAPI/CMakeLists.txt:
2400         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2402         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
2403         (TestWebKitAPI::TEST):
2404         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2405         (TestWebKitAPI::runLockTest): Change the name of the thread.
2406
2407 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
2408
2409         Unreviewed, shorten another test. It's timing out in debug on some bot.
2410
2411         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2412         (TestWebKitAPI::TEST):
2413
2414 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
2415
2416         WTF::Lock should not suffer from the thundering herd
2417         https://bugs.webkit.org/show_bug.cgi?id=147947
2418
2419         Reviewed by Geoffrey Garen.
2420
2421         Add testing that checks that locks return to a pristine state after contention is over.
2422
2423         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2424         (TestWebKitAPI::LockInspector::isFullyReset):
2425         (TestWebKitAPI::runLockTest):
2426         (TestWebKitAPI::TEST):
2427
2428 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
2429
2430         Benchmarks supported by run_benchmark script should not assume we have internet access.
2431         https://bugs.webkit.org/show_bug.cgi?id=147959
2432
2433         Reviewed by Ryosuke Niwa.
2434
2435         For JSBench we should not request jquery.min.js from google through the internet.
2436
2437         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2438
2439 2015-08-12  Jason Marcell  <jmarcell@apple.com>
2440
2441         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
2442         other than "openSource" and "internal".
2443         https://bugs.webkit.org/show_bug.cgi?id=147796
2444
2445         Reviewed by Daniel Bates.
2446
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2448         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
2449         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
2450         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
2451         and another assertion that, if the previousIteration is non-null, the given repository is in
2452         previousIteration.revision.
2453         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
2454         with repositories other than "openSource" and "internal". Also added an assertion that the returned
2455         fragment has at least one child node.
2456
2457 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
2458
2459         Add a tool that dumps class and struct member layout, showing padding
2460         https://bugs.webkit.org/show_bug.cgi?id=147898
2461
2462         Reviewed by Zalan Bujtas.
2463         
2464         This 'dump-class-layout' script uses the lldb Python bindings to collect data
2465         about data member layout, and displays it.
2466         
2467         Sample output:
2468
2469               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
2470               +0 < 56>     WebCore::URL m_value;
2471               +0 <  8>         WTF::String m_string;
2472               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
2473               +0 <  8>                 WTF::StringImpl * m_ptr;
2474               +8 <  1>         bool:1 m_isValid;
2475               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
2476               +9 <  3>         <PADDING>
2477              +12 <  4>         int m_schemeEnd;
2478              +16 <  4>         int m_userStart;
2479              +20 <  4>         int m_userEnd;
2480              +24 <  4>         int m_passwordEnd;
2481              +28 <  4>         int m_hostEnd;
2482              +32 <  4>         int m_portEnd;
2483              +36 <  4>         int m_pathAfterLastSlash;
2484              +40 <  4>         int m_pathEnd;
2485              +44 <  4>         int m_queryEnd;
2486              +48 <  4>         int m_fragmentEnd;
2487              +52 <  4>         <PADDING>
2488              +52 <  4>     <PADDING>
2489              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
2490              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
2491             Total byte size: 72
2492             Total pad bytes: 11
2493             Padding percentage: 15.28 %
2494
2495         * Scripts/dump-class-layout: Added.
2496         (webkit_build_dir):
2497         (developer_dir):
2498         (import_lldb):
2499         (find_build_directory):
2500         (verify_type):
2501         (verify_type_recursive):
2502         (dump_class):
2503         (main):
2504         (main.or):
2505
2506 2015-08-12  Alex Christensen  <achristensen@webkit.org>
2507
2508         Fix Debug CMake builds on Windows
2509         https://bugs.webkit.org/show_bug.cgi?id=147940
2510
2511         Reviewed by Chris Dumez.
2512
2513         * DumpRenderTree/PlatformWin.cmake:
2514         * TestWebKitAPI/PlatformWin.cmake:
2515         The BitmapImage test is not enabled on the AppleWin port.
2516         * WinLauncher/CMakeLists.txt:
2517         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
2518
2519 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2520
2521         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
2522
2523         In r188125 I added a way to mark tests as slow to use a longer
2524         timeout. But it seems it was not enough for
2525         WTF_Lock.ContendedShortSection, so let's try again with a longer
2526         timeout now.
2527
2528         * Scripts/run-gtk-tests:
2529         (TestRunner._run_google_test):
2530
2531 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2532
2533         Allow --debug option in run-jsc
2534         https://bugs.webkit.org/show_bug.cgi?id=147923
2535
2536         Reviewed by Csaba Osztrogonác.
2537
2538         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
2539
2540         * Scripts/run-jsc:
2541
2542 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2543
2544         Fix test after build fix in r188286.
2545         https://bugs.webkit.org/show_bug.cgi?id=147907
2546
2547         Reviewed by Anders Carlsson.
2548
2549         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2550         sleep_for can now be used, but we need to include <thread>
2551
2552 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
2553
2554         Always use a byte-sized lock implementation
2555         https://bugs.webkit.org/show_bug.cgi?id=147908
2556
2557         Reviewed by Geoffrey Garen.
2558
2559         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
2560         now tests of Lock.
2561
2562         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2563         (TestWebKitAPI::runLockTest):
2564         (TestWebKitAPI::TEST):
2565
2566 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
2567
2568         Make ASan build not depend on asan.xcconfig
2569         https://bugs.webkit.org/show_bug.cgi?id=147840
2570         rdar://problem/21093702
2571
2572         Reviewed by Daniel Bates.
2573
2574         * asan/asan.xcconfig:
2575         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
2576         are now marked in source code.
2577
2578 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
2579
2580         Unreviewed, shorten another test since it timed out.
2581
2582         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2583         (TestWebKitAPI::TEST):
2584
2585 2015-08-11  Mark Lam  <mark.lam@apple.com>
2586
2587         Fix names of Lock tests: should be "Contended", not "Contented".
2588         https://bugs.webkit.org/show_bug.cgi?id=147905
2589
2590         Reviewed by Saam Barati.
2591
2592         We're testing the behavior of lock contention (i.e. when threads contend), not
2593         whether the locks are happy (contented).
2594
2595         * Scripts/run-gtk-tests:
2596         (TestRunner):
2597         (TestRunner.__init__): Deleted.
2598         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2599         (TestWebKitAPI::runLockTest):
2600         (TestWebKitAPI::TEST):
2601
2602 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2603
2604         Update WinCairoRequirements to VS2015.
2605
2606         * Scripts/update-webkit-wincairo-libs:
2607         Update WinCairoRequirements location.
2608
2609 2015-08-11  Jason Marcell  <jmarcell@apple.com>
2610
2611         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
2612         for internalTrac.
2613         https://bugs.webkit.org/show_bug.cgi?id=147805
2614
2615         Reviewed by Daniel Bates.
2616
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2618         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
2619         Dashboard.Repository.Internal.trac for internalTrac.
2620         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
2621         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
2622         respectively.
2623         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2624         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
2625         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
2626         internalTrac.
2627         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
2628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
2629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2630         (Analyzer): Ditto.
2631         (Analyzer.prototype.analyze): Ditto.
2632
2633 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
2634
2635         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
2636
2637         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2638         (TestWebKitAPI::TEST):
2639
2640 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
2641
2642         [Win] Switch Windows build to Visual Studio 2015
2643         https://bugs.webkit.org/show_bug.cgi?id=147887
2644         <rdar://problem/22235098>
2645
2646         Reviewed by Alex Christensen.
2647
2648         Update Visual Studio project file settings to use the current Visual
2649         Studio and compiler. Continue targeting binaries to run on our minimum
2650         supported configuration of Windows 7.
2651
2652         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2653         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2654         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2655         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2656         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2657         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
2658         prefer the newer MSBuild included in Visual Studio 2015.
2659         (visualStudioInstallDir):
2660         (msBuildInstallDir):
2661         (visualStudioVersion):
2662         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2663         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2664         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2665         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2666         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2667         * win/record-memory/record-memory.vcxproj:
2668
2669 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2670
2671         Another speculative build fix after r188280.
2672
2673         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2674         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
2675         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
2676
2677 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2678
2679         Unreviewed build fix after r188280.
2680
2681         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2682         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
2683
2684 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
2685
2686         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
2687         https://bugs.webkit.org/show_bug.cgi?id=147665
2688
2689         Reviewed by Mark Lam.
2690
2691         * TestWebKitAPI/CMakeLists.txt:
2692         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2694         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
2697         (TestWebKitAPI::TEST):
2698
2699 2015-08-11  Brian Burg  <bburg@apple.com>
2700
2701         webkit-patch should not explode when $EDITOR is set incorrectly
2702         https://bugs.webkit.org/show_bug.cgi?id=147884
2703
2704         Reviewed by Darin Adler.
2705
2706         If $EDITOR doesn't exist, log a warning and continue.
2707
2708         * Scripts/webkitpy/common/system/user.py: 
2709         (User.edit):
2710         (User.edit_changelog):
2711
2712 2015-08-11  Dan Bernstein  <mitz@apple.com>
2713
2714         Reverted r188255, because it turned out that delegates do nonot need this information.
2715
2716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2717         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
2718
2719 2015-08-11  Dan Bernstein  <mitz@apple.com>
2720
2721         [Cocoa] The UI delegate can't tell if printing was user-initiated
2722         https://bugs.webkit.org/show_bug.cgi?id=147869
2723
2724         Reviewed by Sam Weinig.
2725
2726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2727         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
2728         (-[PrintFrameController webView:didFinishNavigation:]):
2729         (-[PrintFrameController _webView:printFrame:userInitiated:]):
2730         (TEST):
2731
2732 2015-08-10  Alex Christensen  <achristensen@webkit.org>
2733
2734         Another build fix after r188239.
2735
2736         * TestWebKitAPI/PlatformWin.cmake:
2737         Link with more libraries.
2738         * WinLauncher/CMakeLists.txt:
2739         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
2740
2741 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2742
2743         Build fix after r188237.
2744
2745         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2746         (BenchmarkBuilder.__enter__):
2747
2748 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
2749
2750         Update ReadMe and correct the way to use abstract abstract class.
2751         https://bugs.webkit.org/show_bug.cgi?id=147860
2752
2753         Reviewed by Ryosuke Niwa.
2754
2755         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
2756         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
2757
2758         * Scripts/webkitpy/benchmark_runner/README.md:
2759         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2760         (BrowserDriver):
2761         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2762         (OSXBrowserDriver.restore_env):
2763         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2764         (HTTPServerDriver):
2765         (HTTPServerDriver.set_device_id):
2766         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2767         (SimpleHTTPServerDriver.get_return_code):
2768         (SimpleHTTPServerDriver):
2769         (SimpleHTTPServerDriver.set_device_id):
2770
2771 2015-08-10  Alex Christensen  <achristensen@webkit.org>
2772
2773         Build TestWebKitAPI with CMake on Windows
2774         https://bugs.webkit.org/show_bug.cgi?id=147851
2775
2776         Reviewed by Chris Dumez.
2777
2778         * CMakeLists.txt:
2779         * TestWebKitAPI/CMakeLists.txt:
2780         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
2781         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
2782         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
2783         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
2784         * TestWebKitAPI/PlatformEfl.cmake:
2785         * TestWebKitAPI/PlatformGTK.cmake:
2786         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
2787         I did this without changing the directory structure of the existing EFL and GTK builds.
2788         * TestWebKitAPI/PlatformWin.cmake: Added.
2789         * TestWebKitAPI/win/main.cpp:
2790         (main):
2791         (dllLauncherEntryPoint):
2792         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
2793         * WinLauncher/CMakeLists.txt:
2794         AppleWin port needs /NODEFAULTLIB:MSVCRT.
2795
2796 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
2797
2798         Make cleanup more robust and minor code cleaning in run benchmark script.
2799         https://bugs.webkit.org/show_bug.cgi?id=147800
2800
2801         Reviewed by Ryosuke Niwa.
2802
2803         Use 'finnaly' block to make sure cleanup code is always executed.
2804
2805         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2806         (built_benchmark):
2807         (built_benchmark.__init__):
2808         (built_benchmark.__enter__):
2809         (built_benchmark.__exit__):
2810         (test_environment):
2811         (test_environment.__init__):
2812         (test_environment.__enter__):
2813         (test_environment.__exit__):
2814         (BenchmarkRunner.__init__):
2815         (BenchmarkRunner.execute):
2816         (BenchmarkRunner._dump):
2817         (BenchmarkRunner._wrap):
2818         (BenchmarkRunner): Deleted.
2819         (BenchmarkRunner._cleanup): Deleted.
2820         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2821         (BrowserDriver.close_browsers):
2822         (BrowserDriver):
2823         (BrowserDriver.restore_env):
2824         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2825         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
2826
2827 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2828
2829         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
2830         https://bugs.webkit.org/show_bug.cgi?id=146414
2831
2832         Reviewed by Darin Adler.
2833
2834         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2835         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
2836
2837 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2838
2839         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
2840         https://bugs.webkit.org/show_bug.cgi?id=147727
2841
2842         Reviewed by Sergio Villar Senin.
2843
2844         I think it was not this test in particular, but
2845         /webkit2/WebKitWebView/custom-charset that is affecting the
2846         others. This is because changing the encoding reloads the page,
2847         but we don't wait for the page to be reloaded, so when the test
2848         finishes and other test starts the web process is still reloading
2849         the page.
2850
2851         * Scripts/run-gtk-tests:
2852         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
2853         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2854         (testWebViewCustomCharset): Wait until page is reloaded after
2855         changing the charset.
2856
2857 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2858
2859         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
2860
2861         It's timing out in the bots. My guess is that there's no installer
2862         installed in the bots and gst_install_plugins_supported() returns
2863         false, so we don't even get a permission request because no
2864         installer will be launched.
2865
2866         * Scripts/run-gtk-tests:
2867         (TestRunner):
2868
2869 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2870
2871         [GTK] Another build fix after r188157.
2872
2873         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2874         (WTR::PlatformWebView::viewSupportsOptions):
2875         Name all the things correctly!
2876
2877 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2878
2879         [EFL, GTK] Build fix after r188176.
2880
2881         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2882         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
2883
2884 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2885
2886         [GTK] Speculative build fix after r188157.
2887
2888         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2889         (WTR::PlatformWebView::PlatformWebView):
2890         Update parameter list.
2891
2892 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2893
2894         Build more testing binaries with CMake on Windows
2895         https://bugs.webkit.org/show_bug.cgi?id=147799
2896
2897         Reviewed by Brent Fulgham.
2898
2899         * DumpRenderTree/CMakeLists.txt:
2900         Build TestNetscapePlugin.
2901         * DumpRenderTree/PlatformWin.cmake:
2902         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
2903         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
2904         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
2905         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
2906         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
2907         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
2908         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
2909         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2910         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
2911
2912 2015-08-07  Jason Marcell  <jmarcell@apple.com>
2913
2914         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
2915         https://bugs.webkit.org/show_bug.cgi?id=147667
2916
2917         Reviewed by Daniel Bates.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2920         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
2921         other than "openSource" and "internal".
2922         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2924         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
2925         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2927         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2928         (sortedPlatforms): Deleted.
2929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2930         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2931         (sortedPlatforms): Deleted.
2932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2933         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2934         and sorts them by this property returning the new sorted array.
2935
2936 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
2937
2938         Lightweight locks should be adaptive
2939         https://bugs.webkit.org/show_bug.cgi?id=147545
2940
2941         Reviewed by Geoffrey Garen.
2942
2943         * TestWebKitAPI/CMakeLists.txt:
2944         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2946         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2947         (TestWebKitAPI::runLockTest):
2948         (TestWebKitAPI::TEST):
2949
2950 2015-08-07  Anders Carlsson  <andersca@apple.com>
2951
2952         Fix a tyop.
2953
2954         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2955         (WTR::PlatformWebView::viewSupportsOptions):
2956
2957 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2958
2959         Update AppEngine app version numbers to the latest commit.
2960
2961         * QueueStatusServer/app.yaml:
2962         * TestResultServer/app.yaml:
2963
2964 2015-08-07  Anders Carlsson  <andersca@apple.com>
2965
2966         Simplify WKTR's view options
2967         https://bugs.webkit.org/show_bug.cgi?id=147791
2968
2969         Reviewed by Sam Weinig.
2970
2971         Instead of using a WKDictionaryRef, just use a struct for the options.
2972
2973         * WebKitTestRunner/PlatformWebView.h:
2974         (WTR::PlatformWebView::options):
2975         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2976         * WebKitTestRunner/TestController.cpp:
2977         (WTR::TestController::initialize):
2978         (WTR::TestController::createWebViewWithOptions):
2979         (WTR::TestController::ensureViewSupportsOptions):
2980         (WTR::TestController::updateLayoutTypeForTest):
2981         * WebKitTestRunner/TestController.h:
2982         * WebKitTestRunner/ViewOptions.h: Added.
2983         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2984         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2985         (WTR::PlatformWebView::PlatformWebView):
2986         (WTR::PlatformWebView::viewSupportsOptions):
2987         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2988         (WTR::PlatformWebView::viewSupportsOptions):
2989         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2990         (WTR::PlatformWebView::viewSupportsOptions):
2991         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2992         (WTR::PlatformWebView::PlatformWebView):
2993         (WTR::PlatformWebView::viewSupportsOptions):
2994         * WebKitTestRunner/mac/TestControllerMac.mm:
2995         (WTR::TestController::platformConfigureViewForTest):
2996
2997 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2998
2999         Running tests for a long time results in some tests running very slowly (throttling)
3000         https://bugs.webkit.org/show_bug.cgi?id=147718
3001
3002         Reviewed by Chris Dumez.
3003
3004         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
3005         Although COCOA ports default this setting to be disabled in WebKit1,
3006         we should make both test harnesses disable the setting for consistency.
3007
3008         * DumpRenderTree/mac/DumpRenderTree.mm:
3009         (resetWebPreferencesToConsistentValues):
3010
3011 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
3012
3013         Use a specific version of Speedometer in run-benchmark
3014         https://bugs.webkit.org/show_bug.cgi?id=147769
3015
3016         Reviewed by Chris Dumez.
3017
3018         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
3019
3020         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
3021
3022 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
3023
3024         twisted_http_server.py should support --port
3025         https://bugs.webkit.org/show_bug.cgi?id=147771
3026
3027         Reviewed by Chris Dumez.
3028
3029         Added the option. This makes the script more useful on its own.
3030
3031         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3032
3033 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3034
3035         [GTK] WTF unit tests are timing out in the bots
3036         https://bugs.webkit.org/show_bug.cgi?id=147777
3037
3038         Reviewed by Filip Pizlo.
3039
3040         Add a way to mark google unit tests as slow and add
3041         WTF_Lock.ContentedShortSection to the list. In case of slow test
3042         we use the double of the given timeout for that particular test.
3043
3044         * Scripts/run-gtk-tests:
3045         (TestRunner):
3046         (TestRunner._run_google_test):
3047
3048 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3049
3050         [GTK] run-gtk-tests should not stop when a google test case fails
3051         https://bugs.webkit.org/show_bug.cgi?id=147778
3052
3053         Reviewed by Philippe Normand.
3054
3055         For glib based tests we run the test runner with the -k option,
3056         but for google tests we are aborting as soon as we find a failure.
3057
3058         * Scripts/run-gtk-tests:
3059         (TestRunner._run_google_test_suite): Use a global return code that
3060         is set to 1 when any test has failed.
3061
3062 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3063
3064         [GStreamer] Do not automatically show PackageKit codec installation notifications
3065         https://bugs.webkit.org/show_bug.cgi?id=135973
3066
3067         Reviewed by Philippe Normand.
3068
3069         Handle the missing media plugins installation permission request
3070         in MiniBrowser and add a test case for the new API.
3071
3072         * MiniBrowser/gtk/BrowserWindow.c:
3073         (webViewDecidePermissionRequest):
3074         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3075         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3076         (permissionRequestCallback):
3077         (testInstallMissingPluginsPermissionRequest):
3078         (beforeAll):
3079         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3080         (methodCallCallback):
3081
3082 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
3083
3084         Running tests for a long time results in some tests running very slowly (throttling)
3085         https://bugs.webkit.org/show_bug.cgi?id=147718
3086
3087         Reviewed by Alexey Proskuryakov.
3088
3089         * WebKitTestRunner/TestController.cpp:
3090         (WTR::TestController::resetPreferencesToConsistentValues):
3091         Ensure throttling settings are disabled for tests for all ports, as
3092         COCOA ports default to having these setting enabled. Note, there is
3093         still other timer throttling not covered by these setting.
3094
3095 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3096
3097         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
3098         https://bugs.webkit.org/show_bug.cgi?id=147752
3099
3100         Reviewed by Chris Dumez.
3101
3102         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
3103
3104         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
3105         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
3106
3107         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
3108         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
3109         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
3110         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
3111         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
3112         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3113         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
3114         HTTPServerDriverFactory taking the platform name as an argument.
3115         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
3116         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
3117         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
3118         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
3119         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
3120         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
3121         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
3122         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
3123         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
3124         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
3125         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
3126         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
3127         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3128         (HTTPServerDriver): Replaced name by platforms.
3129         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3130         (SimpleHTTPServerDriver): Ditto.
3131         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3132         (parse_args): Removed --http-server-driver option.
3133         (start): Ditto.
3134
3135 2015-08-06  Chris Dumez  <cdumez@apple.com>
3136
3137         Toggle GPS state based on page visibility to save battery
3138         https://bugs.webkit.org/show_bug.cgi?id=147685
3139
3140         Reviewed by Benjamin Poulain.
3141
3142         Add testRunner.isGeolocationProviderActive() test support function.
3143
3144         * DumpRenderTree/TestRunner.cpp:
3145         (isGeolocationProviderActiveCallback):
3146         (TestRunner::staticFunctions):
3147         * DumpRenderTree/TestRunner.h:
3148         * DumpRenderTree/mac/MockGeolocationProvider.h:
3149         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3150         (-[MockGeolocationProvider isActive]):
3151         * DumpRenderTree/mac/TestRunnerMac.mm:
3152         (TestRunner::isGeolocationProviderActive):
3153         * DumpRenderTree/win/TestRunnerWin.cpp:
3154         (TestRunner::isGeolocationProviderActive):
3155         * WebKitTestRunner/GeolocationProviderMock.h:
3156         (WTR::GeolocationProviderMock::isActive):
3157         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3158         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3159         (WTR::InjectedBundle::isGeolocationProviderActive):
3160         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3161         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3162         (WTR::TestRunner::isGeolocationProviderActive):
3163         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3164         * WebKitTestRunner/TestController.cpp:
3165         (WTR::TestController::isGeolocationProviderActive):
3166         * WebKitTestRunner/TestController.h:
3167         * WebKitTestRunner/TestInvocation.cpp:
3168         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3169
3170 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3171
3172         Automate JSBench with run-benchmark
3173         https://bugs.webkit.org/show_bug.cgi?id=147716
3174
3175         Reviewed by Chris Dumez.
3176
3177         Added JSBench plan to run-benchmark.
3178
3179         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3180         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
3181         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
3182         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
3183         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
3184         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
3185         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
3186         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
3187         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
3188         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
3189         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
3190         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
3191         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
3192         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
3193         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
3194         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
3195
3196 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3197
3198         Pass-through the undefined options in run-jsc
3199         https://bugs.webkit.org/show_bug.cgi?id=147717
3200
3201         Undefined options in run-jsc is just passed to the actual jsc shell.
3202         We can execute `Tools/Scripts/run-jsc -d`.
3203
3204         Reviewed by Csaba Osztrogonác.
3205
3206         * Scripts/run-jsc:
3207
3208 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3209
3210         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
3211
3212         It's flaky.
3213
3214         * Scripts/run-gtk-tests:
3215         (TestRunner):
3216
3217 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
3218
3219         [EFL] Bump EFL version to 1.15.0
3220         https://bugs.webkit.org/show_bug.cgi?id=147450
3221
3222         Reviewed by Gyuyoung Kim.
3223
3224         * efl/jhbuild.modules:
3225
3226 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3227
3228         Unreviewed. Unksip TestContextMenu GTK+ API test.
3229
3230         This has been skipped for a long time, and it's very
3231         unconvenient. It has never failed for me locally, so let's try
3232         again to see if it works in the bots. I'll skip it again if it
3233         keeps failing.
3234
3235         * Scripts/run-gtk-tests:
3236         (TestRunner):
3237
3238 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
3239
3240         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
3241
3242         * DumpRenderTree/JavaScriptThreading.cpp:
3243         (javaScriptThreadsMutex):
3244         (runJavaScriptThread):
3245         (startJavaScriptThreads):
3246         (stopJavaScriptThreads):
3247         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3248         (TestWebKitAPI::TEST):
3249         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3250         (TestWebKitAPI::TEST):
3251
3252 2015-08-05  Alex Christensen  <achristensen@webkit.org>
3253
3254         Build DumpRenderTree with CMake.
3255         https://bugs.webkit.org/show_bug.cgi?id=147519
3256
3257         Reviewed by Brent Fulgham.
3258
3259         * CMakeLists.txt:
3260         Build the DumpRenderTree directory now that it builds successfully.
3261         * DumpRenderTree/CMakeLists.txt:
3262         Added missing source file and don't link with WebCore.lib.
3263         * DumpRenderTree/PlatformWin.cmake:
3264         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
3265         * WinLauncher/CMakeLists.txt:
3266         We need libcmt now that we are not linking with WebCore.lib.
3267
3268 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
3269
3270         AppScale: Use https URLs for subresources and links
3271         https://bugs.webkit.org/show_bug.cgi?id=147686
3272
3273         Reviewed by Ryosuke Niwa.
3274
3275         * QueueStatusServer/filters/webkit_extras.py:
3276         * TestResultServer/static-dashboards/dashboard_base.js:
3277         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3278         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3279         * TestResultServer/static-dashboards/treemap.js:
3280         * TestResultServer/static-dashboards/ui.js:
3281
3282 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
3283
3284         Rename Mutex to DeprecatedMutex
3285         https://bugs.webkit.org/show_bug.cgi?id=147675
3286
3287         Reviewed by Geoffrey Garen.
3288
3289         * DumpRenderTree/JavaScriptThreading.cpp:
3290         (javaScriptThreadsMutex):
3291         (runJavaScriptThread):
3292         (startJavaScriptThreads):
3293         (stopJavaScriptThreads):
3294         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3295         (TestWebKitAPI::TEST):
3296         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3297         (TestWebKitAPI::TEST):
3298
3299 2015-08-05  Timothy Hatcher  <timothy@apple.com>
3300
3301         Update the WebKit nightly icon
3302         https://bugs.webkit.org/show_bug.cgi?id=147684
3303
3304         Reviewed by Sam Weinig.
3305
3306         * WebKitLauncher/webkit.icns: Replaced.
3307
3308 2015-08-05  Daniel Bates  <dabates@apple.com>
3309
3310         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
3311         https://bugs.webkit.org/show_bug.cgi?id=147678
3312         <rdar://problem/21827815>
3313
3314         Reviewed by Brady Eidson.
3315
3316         Add a test to ensure that we restore the "should open external URLs" policy on
3317         page reload after the web content process crashes.
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
3321         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3322         (TEST):
3323
3324 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
3325
3326         [EFL] Editing tests have been broken since r186694
3327         https://bugs.webkit.org/show_bug.cgi?id=146888
3328
3329         Reviewed by Brent Fulgham.
3330
3331         Restored some codes for the context click on GTK+ and EFL port.
3332
3333         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3334         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
3335
3336 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
3337
3338         Install twisted package for http server when necessary.
3339         https://bugs.webkit.org/show_bug.cgi?id=147082
3340
3341         Reviewed by Ryosuke Niwa.
3342
3343         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3344         * Scripts/webkitpy/thirdparty/__init__.py:
3345         (AutoinstallImportHook.find_module):
3346         (AutoinstallImportHook._install_twisted):
3347
3348 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
3349
3350         [Win] Update Apple Windows build for VS2015
3351         https://bugs.webkit.org/show_bug.cgi?id=147653
3352
3353         Reviewed by Dean Jackson.
3354
3355         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
3356         something older than VS2015, define snprintf as _snprintf.
3357         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3358         Remove unneeded macro definition for snprintf.
3359         * Scripts/webkitpy/common/system/platforminfo.py:
3360         (PlatformInfo._determine_win_version): Recognize Windows 10.
3361         * Scripts/webkitpy/port/win.py:
3362         (WinPort): Ditto.
3363         * Scripts/webkitpy/port/win_unittest.py:
3364         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
3365         (WinPortTest._assert_version): Ditto.
3366
3367 2015-08-04  Brian Burg  <bburg@apple.com>
3368
3369         Unreviewed, update email addresses in contributors.json and watchlist.
3370
3371         * Scripts/webkitpy/common/config/contributors.json:
3372         * Scripts/webkitpy/common/config/watchlist:
3373
3374 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
3375
3376         Implement NPAPI redirect handling
3377         https://bugs.webkit.org/show_bug.cgi?id=138675
3378         rdar://problem/15779101
3379
3380         Patch by Jeffrey Pfau, updated and tweaked by me.
3381
3382         Reviewed by Anders Carlsson.
3383
3384         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3385         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
3386         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3387         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3388         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3389         (PluginTest::NPP_URLNotify):
3390         (PluginTest::NPP_URLRedirectNotify):
3391         (PluginTest::NPP_GetValue):
3392         (PluginTest::NPN_GetURLNotify):
3393         (PluginTest::NPN_PostURLNotify):
3394         (PluginTest::NPN_GetValue):
3395         (PluginTest::NPN_ReleaseVariantValue):
3396         (PluginTest::NPN_URLRedirectResponse):
3397         (PluginTest::NPN_ConvertPoint):
3398         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3399         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
3400         (URLRedirect::URLRedirect):
3401         (URLRedirect::ScriptableObject::hasMethod):
3402         (URLRedirect::ScriptableObject::get):
3403         (URLRedirect::ScriptableObject::serviceAsync):
3404         (URLRedirect::ScriptableObject::invoke):
3405         (URLRedirect::NPP_GetValue):
3406         (URLRedirect::NPP_URLNotify):
3407         (URLRedirect::NPP_URLRedirectNotify):
3408         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3409         (NP_GetEntryPoints):
3410         (NPP_URLNotify):
3411         (NPP_URLRedirectNotify):
3412         (NPP_GetValue):
3413
3414 2015-08-04  Tim Horton  <timothy_horton@apple.com>
3415
3416         Move Matt Daiter to committers.
3417
3418         * Scripts/webkitpy/common/config/contributors.json:
3419
3420 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
3421
3422         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
3423         https://bugs.webkit.org/show_bug.cgi?id=147636
3424
3425         Reviewed by Alex Christensen.
3426         
3427         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
3428         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
3429         on EWS machines)
3430
3431         * Scripts/build-webkit:
3432
3433 2015-08-04  Jason Marcell  <jmarcell@apple.com>
3434
3435         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
3436         https://bugs.webkit.org/show_bug.cgi?id=147280
3437
3438         Reviewed by Daniel Bates.
3439
3440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3441         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
3442         Refactored _parseData to handle repositories more generically.
3443         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3445         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
3446         "opensourceRevision" and "internalRevision".
3447         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
3448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3449         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
3450         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3451         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
3452         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
3453         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
3454         and "internalRevision".
3455         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
3456         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
3457         "opensourceRevision" and "internalRevision".
3458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
3459         constants for internal and opensource repositories.
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3461         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
3462         instead of "opensourceRevision" and "internalRevision".
3463         (Analyzer.prototype._countPercentageOfGreen): Ditto.
3464         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
3465         (Analyzer.prototype._countTimes): Ditto.
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3467         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
3468
3469 2015-08-04  Mark Lam  <mark.lam@apple.com>
3470
3471         Removed a local debugging line I accidentally left in from a previous commit.
3472
3473         Not Reviewed.
3474
3475         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3476
3477 2015-08-04  Mark Lam  <mark.lam@apple.com>
3478
3479         Unreviewed. Make Saam Barati a WebKit reviewer.
3480
3481         * Scripts/webkitpy/common/config/contributors.json:
3482
3483 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3484
3485         Unreviewed, updated Streams API watchlist.
3486
3487         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
3488
3489 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
3490
3491         [CMake] Add an option to build AllInOne files
3492         https://bugs.webkit.org/show_bug.cgi?id=102647
3493
3494         Reviewed by Alex Christensen.
3495
3496         * Scripts/webkitperl/FeatureList.pm:
3497
3498 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
3499
3500         AppScale: Add required indices
3501         https://bugs.webkit.org/show_bug.cgi?id=147593
3502
3503         Reviewed by Tim Horton.
3504
3505         * QueueStatusServer/index.yaml:
3506
3507 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
3508
3509         Check in LLVM 3.6.2 binary drops for El Capitan
3510         https://bugs.webkit.org/show_bug.cgi?id=147582
3511
3512         Reviewed by Alexey Proskuryakov.
3513         
3514         Recognize 10.11 and use the right drops.
3515
3516         * Scripts/copy-webkitlibraries-to-product-directory:
3517
3518 2015-08-03  Alex Christensen  <achristensen@webkit.org>
3519
3520         [Win] Build fix after r187733.
3521
3522         * WinLauncher/PageLoadTestClient.cpp:
3523         (PageLoadTestClient::dumpRunStatistics):
3524         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
3525
3526 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
3527
3528         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
3529         https://bugs.webkit.org/show_bug.cgi?id=118455
3530
3531         Reviewed by Filip Pizlo.
3532
3533         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3534         (TestWebKitAPI::TEST):
3535
3536 2015-07-31  Alex Christensen  <achristensen@webkit.org>
3537
3538         Prepare for VS2015
3539         https://bugs.webkit.org/show_bug.cgi?id=146579
3540
3541         Reviewed by Jon Honeycutt.
3542
3543         * WinLauncher/stdafx.h:
3544         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
3545
3546 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
3547
3548         [EFL] Fix pixman build on ARM with GCC 4.9.3
3549         https://bugs.webkit.org/show_bug.cgi?id=147224
3550
3551         Reviewed by Gyuyoung Kim.
3552
3553         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
3554
3555 2015-07-30  Anders Carlsson  <andersca@apple.com>
3556
3557         Add support for window.open to WK1BrowserWindowController
3558         https://bugs.webkit.org/show_bug.cgi?id=147474
3559
3560         Reviewed by Dan Bernstein.
3561
3562         * MiniBrowser/mac/WK1BrowserWindowController.m:
3563         (-[WK1BrowserWindowController awakeFromNib]):
3564         Set javaScriptCanOpenWindowsAutomatically to YES. 
3565         If this becomes a nuisance, we can always add a menu item to toggle this.
3566
3567         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
3568         Implement this UI delegate method.
3569
3570 2015-07-30  Anders Carlsson  <andersca@apple.com>
3571
3572         Undo stray commit.
3573
3574         * MiniBrowser/mac/WK1BrowserWindowController.m:
3575         (-[WK1BrowserWindowController awakeFromNib]):
3576         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
3577
3578 2015-07-29  Dean Jackson  <dino@apple.com>
3579
3580         Don't use (Details) when exposing SPI
3581         https://bugs.webkit.org/show_bug.cgi?id=147426
3582         <rdar://problem/22062407>
3583
3584         Reviewed by Dan Bernstein.
3585
3586         If we are declaring the interface without any implementation,
3587         we should use class extensions.
3588
3589         * DumpRenderTree/mac/DumpRenderTree.mm:
3590         * DumpRenderTree/mac/EventSendingController.mm:
3591         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3592         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3593         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3594         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3595         * WebKitTestRunner/mac/TestControllerMac.mm:
3596
3597 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
3598
3599         Replace Google App Engine with AppScale
3600         https://bugs.webkit.org/show_bug.cgi?id=147178
3601
3602         Reviewed by Daniel Bates.
3603
3604         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3605         (RunWebKitTests):
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3611         (.):
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3613         (BubbleQueueServer):
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
3615         (TestHistory):
3616         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3617         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
3618         * TestResultServer/app.yaml: Ditto
3619         * Scripts/webkitpy/common/config/urls.py:
3620         * TestResultServer/main.py:
3621         * TestResultServer/static-dashboards/dashboard_base.js:
3622         * TestResultServer/static-dashboards/loader.js:
3623
3624 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
3625
3626         [EFL] Enable IndexedDB based on DatabaseProcess
3627         https://bugs.webkit.org/show_bug.cgi?id=147221
3628
3629         Reviewed by Csaba Osztrogonác.
3630
3631         * Scripts/webkitperl/FeatureList.pm:
3632
3633 2015-07-30  Alex Christensen  <achristensen@webkit.org>
3634
3635         Build AppleWin port with CMake
3636         https://bugs.webkit.org/show_bug.cgi?id=147385
3637
3638         Reviewed by Martin Robinson.
3639
3640         * WinLauncher/CMakeLists.txt:
3641         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
3642
3643 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
3644
3645         Implement basic types for ECMAScript Internationalization API
3646         https://bugs.webkit.org/show_bug.cgi?id=146926
3647
3648         Reviewed by Benjamin Poulain.
3649
3650         Enable flag now that the basic objects are in place.
3651
3652         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
3653
3654 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3655
3656         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
3657         https://bugs.webkit.org/show_bug.cgi?id=147108
3658
3659         Reviewed by Gustavo Noronha Silva.
3660
3661         Add test case to check the web process limit.
3662
3663         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3664         (testWebProcessLimit):
3665         (beforeAll):
3666
3667 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3668
3669         [GTK] Missing casts in BrowserWindow.c
3670         https://bugs.webkit.org/show_bug.cgi?id=147395
3671
3672         Reviewed by Carlos Garcia Campos.
3673
3674         * MiniBrowser/gtk/BrowserWindow.c:
3675         (browserWindowSetupEditorToolbar):
3676
3677 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3678
3679         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
3680         https://bugs.webkit.org/show_bug.cgi?id=147350
3681
3682         Reviewed by Sam Weinig.
3683
3684         * Scripts/webkitperl/FeatureList.pm:
3685
3686 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3687
3688         [Freetype] Always allow font matching for strong aliases
3689         https://bugs.webkit.org/show_bug.cgi?id=147057
3690
3691         Reviewed by Martin Robinson.
3692
3693         Create family aliases needed for the new layout tests.
3694
3695         * WebKitTestRunner/gtk/fonts/fonts.conf:
3696
3697 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
3698
3699         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
3700         https://bugs.webkit.org/show_bug.cgi?id=147359
3701
3702         Reviewed by Ryosuke Niwa.
3703
3704         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3705         (NewCommitBot.begin_work_queue):
3706         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3707         (SheriffBot.begin_work_queue):
3708
3709 2015-07-27  Alex Christensen  <achristensen@webkit.org>
3710
3711         Use Ninja on Windows.
3712         https://bugs.webkit.org/show_bug.cgi?id=147228
3713
3714         Reviewed by Martin Robinson.
3715
3716         * WinLauncher/CMakeLists.txt:
3717         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
3718         * Scripts/build-webkit:
3719         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
3720
3721 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
3722
3723         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
3724         highlight after being tapped to style a selection"
3725         https://bugs.webkit.org/show_bug.cgi?id=147278
3726
3727         Reviewed by Ryosuke Niwa.
3728
3729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3730
3731         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
3732         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
3733         (TestWebKitAPI::TEST):
3734         Load a page with the string "Hello, world!", then select "world" and
3735         underline it. Test that the typing attributes for the current selection
3736         include the underline attribute.
3737
3738 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3739
3740         Unreviewed, updated my nick name in contributors.json
3741
3742         * Scripts/webkitpy/common/config/contributors.json:
3743
3744 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
3745
3746         AX: scrollable elements do not allow 3-finger swipe
3747         https://bugs.webkit.org/show_bug.cgi?id=141893
3748
3749         Reviewed by Mario Sanchez Prada.
3750
3751         Support global notification listeners for iOS code.
3752         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
3753         Implement scrollUp/Down/Left/Right.
3754
3755         * DumpRenderTree/AccessibilityController.h:
3756         * DumpRenderTree/AccessibilityUIElement.cpp:
3757         (increaseTextSelectionCallback):
3758         (scrollPageUpCallback):
3759         (scrollPageDownCallback):
3760         (scrollPageLeftCallback):
3761         (scrollPageRightCallback):
3762         (decreaseTextSelectionCallback):
3763         (getElementTextLengthCallback):
3764         (AccessibilityUIElement::getJSClass):
3765         * DumpRenderTree/AccessibilityUIElement.h:
3766         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3767         (AccessibilityController::~AccessibilityController):
3768         (AccessibilityController::elementAtPoint):
3769         (AccessibilityController::addNotificationListener):
3770         (AccessibilityController::platformResetToConsistentState):
3771         (AccessibilityController::removeNotificationListener):
3772         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3773         (AccessibilityUIElement::AccessibilityUIElement):
3774         (AccessibilityUIElement::subrole):
3775         (AccessibilityUIElement::scrollPageUp):
3776         (AccessibilityUIElement::scrollPageDown):
3777         (AccessibilityUIElement::scrollPageLeft):
3778         (AccessibilityUIElement::scrollPageRight):
3779         (AccessibilityUIElement::roleDescription):
3780         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3781         (-[AccessibilityNotificationHandler _notificationReceived:]):
3782         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3783         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3784         (WTR::AccessibilityUIElement::linkedElement):
3785         (WTR::AccessibilityUIElement::headerElementAtIndex):
3786         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3787         (WTR::AccessibilityUIElement::scrollPageUp):
3788         (WTR::AccessibilityUIElement::scrollPageDown):
3789         (WTR::AccessibilityUIElement::scrollPageLeft):
3790         (WTR::AccessibilityUIElement::scrollPageRight):
3791         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3792         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3793         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3794         (WTR::AccessibilityController::addNotificationListener):
3795         (WTR::AccessibilityController::removeNotificationListener):
3796         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3797         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3798         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3799         (WTR::AccessibilityUIElement::scrollPageUp):
3800         (WTR::AccessibilityUIElement::scrollPageDown):
3801         (WTR::AccessibilityUIElement::scrollPageLeft):
3802         (WTR::AccessibilityUIElement::scrollPageRight):
3803         (WTR::AccessibilityUIElement::increaseTextSelection):
3804
3805 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
3806
3807         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
3808         https://bugs.webkit.org/show_bug.cgi?id=147279
3809         <rdar://problem/21990767>
3810
3811         Reviewed by Dean Jackson.
3812
3813         * DumpRenderTree/win/TestRunnerWin.cpp:
3814         (TestRunner::addUserScript):
3815         (TestRunner::addUserStyleSheet):
3816         (TestRunner::setDeveloperExtrasEnabled):
3817
3818 2015-07-24  Basile Clement  <basile_clement@apple.com>
3819
3820         Call fixChangeLogPatch when generating patches from webkit-patch
3821         https://bugs.webkit.org/show_bug.cgi?id=147248
3822
3823         Reviewed by Geoffrey Garen.
3824
3825         When two consecutive patches are from the same author, diff tools
3826         create wrong-looking diffs for ChangeLog files where the apparent added
3827         author is actually the previous patch's author line, making it awkward
3828         to read - and things only get worse when committing a patch and a
3829         followup fix for the same bug shortly after.
3830
3831         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
3832         this, which we use in perl scripts (svn-create-patch et al). But it is
3833         not used by webkit-patch, which is a python script, and thus creates
3834         "bad" diffs.
3835
3836         In the long term, we should probably port fixChangeLogPatch to python -
3837         but in the short term, let's make webkit-patch call perl to run
3838         fixChangeLogPatch. We are already making various external calls there
3839         anyway.
3840
3841         * Scripts/webkitpy/common/checkout/scm/git.py:
3842         (Git.create_patch):
3843         * Scripts/webkitpy/common/checkout/scm/scm.py:
3844         (SCM.fix_changelog_patch):
3845         * Scripts/webkitpy/common/checkout/scm/svn.py:
3846         (SVN.create_patch):
3847
3848 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
3849
3850         commit-queue flags in webkit-patch are confusing
3851         https://bugs.webkit.org/show_bug.cgi?id=88694
3852
3853         Reviewed by Csaba Osztrogonác.
3854
3855         * Scripts/webkitpy/tool/steps/options.py:
3856         (Options): Updated help string to be more descriptive.
3857
3858 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
3859
3860         [Win] Implement proper High DPI support features
3861         https://bugs.webkit.org/show_bug.cgi?id=146335
3862         <rdar://problem/21558269>
3863
3864         Reviewed by Alex Christensen.
3865
3866         Update WinLauncher to take device scaling factor into account.
3867
3868         * WinLauncher/Common.cpp:
3869         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
3870         a valid font.
3871         (computeFullDesktopFrame): Handle high DPI desktops.
3872         (WndProc): Make comments more precise.
3873         * WinLauncher/WinLauncher.cpp:
3874         (WinLauncher::init): Determine device scale factor at launch.
3875         (WinLauncher::updateDeviceScaleFactor): Added.
3876         * WinLauncher/WinLauncher.h:
3877         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
3878         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
3879         (wWinMain): Ditto.
3880         * win/DLLLauncher/DLLLauncherMain.cpp:
3881         (wWinMain): Tell Windows we understand high DPI.
3882
3883 2015-07-23  Alex Christensen  <achristensen@webkit.org>
3884
3885         [Win] Unreviewed build fix after r187169.
3886
3887         * Scripts/build-webkit:
3888         Correctly find WebKit.sln.
3889
3890 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3891
3892         [GTK] Add API to allow executing editing commands that require an argument
3893         https://bugs.webkit.org/show_bug.cgi?id=146781
3894
3895         Reviewed by Gustavo Noronha Silva.
3896
3897         Add buttons to insert image/link to the MiniBrowser edit toolbar,
3898         and test cases for insert image/link commands too.
3899
3900         * MiniBrowser/gtk/BrowserWindow.c:
3901         (insertImageCommandCallback):
3902         (insertLinkCommandCallback):
3903         (browserWindowSetupEditorToolbar):
3904         (browserWindowConstructed):
3905         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3906         (testWebViewEditorInsertImage):
3907         (testWebViewEditorCreateLink):
3908         (beforeAll):
3909
3910 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3911
3912         Unregistering and re-registering a user message handler does not work
3913         https://bugs.webkit.org/show_bug.cgi?id=138142
3914
3915         Reviewed by Martin Robinson.
3916
3917         This has probably been fixed in r184846, enable the test case
3918         blocked on it.
3919
3920         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3921         (testUserContentManagerScriptMessageReceived):
3922
3923 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
3924
3925         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
3926         https://bugs.webkit.org/show_bug.cgi?id=147212
3927
3928         Reviewed by Filip Pizlo.
3929
3930         * Scripts/webkitperl/FeatureList.pm:
3931
3932 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
3933
3934         Add --ios-simulator to run-api-tests --help.
3935
3936         Rubber-stamped by Dan Bates.
3937
3938         * Scripts/run-api-tests:
3939
3940 2015-07-22  Jason Marcell  <jmarcell@apple.com>
3941
3942         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
3943         https://bugs.webkit.org/show_bug.cgi?id=147043
3944
3945         Reviewed by Daniel Bates and Alexey Proskuryakov.
3946
3947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3948         (Buildbot.prototype._normalizeQueueInfo):
3949         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
3950         in cases where the queue.branch property is not set and the queue is not a combined queue.
3951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3952         (BuildbotCombinedQueueView):
3953         Ensuring uniformity of repository branches within a combined queue.
3954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3955         (WebKitBuildbot.prototype.get defaultBranches):
3956         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
3957         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
3958         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
3959         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
3960         implement defaultBranches so that a person can either update the definition of the sub-queue or
3961         implement defaultBranches in the derived Buildbot class they are using.
3962
3963 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3964
3965         Switch WinCairo build to use CMake.
3966         https://bugs.webkit.org/show_bug.cgi?id=147169
3967
3968         Reviewed by Brent Fulgham.
3969
3970         * Scripts/build-webkit:
3971         * Scripts/webkitdirs.pm:
3972         (determineConfiguration):
3973         (determineArchitecture):
3974         (determinePassedConfiguration):
3975         (passedConfiguration):
3976         (jhbuildWrapperPrefixIfNeeded):
3977         (generateBuildSystemFromCMakeProject):
3978         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
3979
3980 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3981
3982         Fix quirks in CMake build on Mac and Windows
3983         https://bugs.webkit.org/show_bug.cgi?id=147174
3984
3985         Reviewed by Gyuyoung Kim.
3986
3987         * CMakeLists.txt:
3988         Don't build DumpRenderTree with CMake for now (until we get that working).
3989         * WinLauncher/CMakeLists.txt:
3990         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3991
3992 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3993
3994         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3995         https://bugs.webkit.org/show_bug.cgi?id=147146
3996
3997         Reviewed by Darin Adler.
3998
3999         * Scripts/webkitpy/style/checkers/cpp.py:
4000         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
4001         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4002         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
4003
4004 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
4005
4006         Fixed VM pool allocation should have a reserve for allocations that cannot fail
4007         https://bugs.webkit.org/show_bug.cgi?id=147154
4008         rdar://problem/21847618
4009
4010         Reviewed by Geoffrey Garen.
4011         
4012         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
4013         mitigations work, these should all pass. Prior to this patch there were >20 failures.
4014
4015         * Scripts/run-jsc-stress-tests:
4016
4017 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4018
4019         [GTK] Add API to be notified about editor state changes
4020         https://bugs.webkit.org/show_bug.cgi?id=145875
4021
4022         Reviewed by Gustavo Noronha Silva.
4023
4024         Update the typing attributes toggle buttons state according to the
4025         editor state in MiniBrowser, and add a test case to the
4026         WebViewEditor unit tests.
4027
4028         * MiniBrowser/gtk/BrowserWindow.c:
4029         (browserWindowEditingCommandToggleButtonSetActive):
4030         (typingAttributesChanged):
4031         (browserWindowSetupEditorToolbar):
4032         (browserWindowConstructed):
4033         (browser_window_init):
4034         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
4035         (testWebViewEditorEditorStateTypingAttributes):
4036         (beforeAll):
4037
4038 2015-07-20  Tomas Popela  <tpopela@redhat.com>
4039
4040         [GTK] Add selection-changed signal to the WebKit2 API
4041         https://bugs.webkit.org/show_bug.cgi?id=137116
4042
4043         Reviewed by Carlos Garcia Campos.
4044
4045         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
4046         (namely the selection-changed signal).
4047
4048         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4049         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
4050         (WebKitWebEditorTest::create):
4051         (WebKitWebEditorTest::selectionChangedCallback):
4052         (WebKitWebEditorTest::testSelectionSelectAll):
4053         (WebKitWebEditorTest::testSelectionCollapse):
4054         (WebKitWebEditorTest::testSelectionModifyMove):
4055         (WebKitWebEditorTest::testSelectionModifyExtend):
4056         (WebKitWebEditorTest::testSelectionUnselect):
4057         (registerTests):
4058         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
4059         (testWebKitWebEditorSelectionChanged):
4060         (beforeAll):
4061         (afterAll):
4062
4063 2015-07-20  Alex Christensen  <achristensen@webkit.org>
4064
4065         Resurrect CMake build on Windows.
4066         https://bugs.webkit.org/show_bug.cgi?id=147083
4067
4068         Reviewed by Gyuyoung Kim.
4069
4070         * DumpRenderTree/CMakeLists.txt:
4071         * DumpRenderTree/PlatformWin.cmake: Added.
4072         * WinLauncher/CMakeLists.txt:
4073
4074 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4075
4076         [GTK] Enable seccomp filter API tests
4077         https://bugs.webkit.org/show_bug.cgi?id=140071
4078
4079         Reviewed by Žan Doberšek.
4080
4081         These tests will now be run by the run-gtk-tests script.
4082
4083         * TestWebKitAPI/PlatformGTK.cmake:
4084
4085 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4086
4087         [GTK] Add seccomp filters support
4088         https://bugs.webkit.org/show_bug.cgi?id=110014
4089
4090         Reviewed by Žan Doberšek.
4091
4092         Add libseccomp to jhbuild modulesets.
4093
4094         * gtk/jhbuild.modules:
4095
4096 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
4097
4098         MiniBrowser window title is just "Window" when page has no <title>
4099         https://bugs.webkit.org/show_bug.cgi?id=147076
4100
4101         Reviewed by Tim Horton.
4102         
4103         Make MiniBrowser windows show the filename from the URL if we never get a title changed
4104         notification.
4105
4106         * MiniBrowser/mac/WK1BrowserWindowController.m:
4107         (-[WK1BrowserWindowController updateTitle:]):
4108         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
4109         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
4110         * MiniBrowser/mac/WK2BrowserWindowController.m:
4111         (-[WK2BrowserWindowController updateTitle:]):
4112         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
4113         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
4114
4115 2015-07-17  Andy Estes  <aestes@apple.com>
4116
4117         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
4118         https://bugs.webkit.org/show_bug.cgi?id=147044
4119         rdar://problem/21567820
4120
4121         Reviewed by Brady Eidson.
4122
4123         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4124         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
4125         This matches the behavior of DumpRenderTree.
4126
4127 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
4128
4129         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
4130         https://bugs.webkit.org/show_bug.cgi?id=147032
4131
4132         Reviewed by Alex Christensen.
4133
4134         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4135         Test that the useless terms are eliminated by counting
4136         the number of NFA nodes generated.
4137
4138 2015-07-17  Dan Bernstein  <mitz@apple.com>
4139
4140         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
4141         https://bugs.webkit.org/show_bug.cgi?id=147040
4142
4143         Reviewed by Dean Jackson.
4144
4145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4146         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
4147         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
4148         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
4149         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4150         (TEST):
4151
4152 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
4153
4154         webkit-patch uses incorrect credentials from keychain to login until account lockout
4155         https://bugs.webkit.org/show_bug.cgi?id=146923
4156
4157         Reviewed by Daniel Bates.
4158
4159         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
4160         provide incorrect credentials then ask for them to be saved to the keychain
4161         webkit-patch will then use those incorrect credentials until 5 total attempts
4162         have been made to log in. This will lock the user out of Bugzilla for a
4163         half hour.
4164
4165         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4166         (Bugzilla.authenticate): Added argument to read_credentials() that
4167         passes in whether or not to use stored credentials.
4168         * Scripts/webkitpy/common/net/credentials.py:
4169         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
4170         that specifies whether or not to use credentials stored on the system. If it
4171         does, we do not auto-fill credentials since either the credentials caused
4172         the failure, or they weren't used in the first place so there is no reason
4173         to try and use them again if a failure happened.
4174         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
4175         use_stored_credentials argument.
4176         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
4177         retrieve username/password information from the local system (environment, Git, keychain,
4178         keyring) are never called. It also tests that we get back our mocked username and password.
4179         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
4180         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
4181         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
4182         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
4183         is never called.
4184         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
4185         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
4186         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
4187         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
4188         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
4189         against.
4190
4191 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4192
4193         Unreviewed, remove my redundant email information.
4194
4195         * Scripts/webkitpy/common/config/contributors.json:
4196
4197 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
4198
4199         Unreviewed. Add Hyungwook Lee as a committer.
4200
4201         * Scripts/webkitpy/common/config/contributors.json:
4202
4203 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4204
4205         Added myself to the list of contributors.
4206
4207         Reviewed by Brent Fulgham.
4208
4209         * Scripts/webkitpy/common/config/contributors.json:
4210
4211 2015-07-16  Alex Christensen  <achristensen@webkit.org>
4212
4213         [Content Extensions] Cache domain actions
4214         https://bugs.webkit.org/show_bug.cgi?id=146817
4215
4216         Reviewed by Benjamin Poulain.
4217
4218         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4219         (TestWebKitAPI::TEST_F):
4220         Test if-domain and unless-domain with multiple load types.
4221
4222 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
4223
4224         [Content extensions] Combine suffixes when generating NFAs
4225         https://bugs.webkit.org/show_bug.cgi?id=146961
4226
4227