Make ASan build not depend on asan.xcconfig
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
2
3         Make ASan build not depend on asan.xcconfig
4         https://bugs.webkit.org/show_bug.cgi?id=147840
5         rdar://problem/21093702
6
7         Reviewed by Daniel Bates.
8
9         * asan/asan.xcconfig:
10         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
11         are now marked in source code.
12
13 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
14
15         Unreviewed, shorten another test since it timed out.
16
17         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
18         (TestWebKitAPI::TEST):
19
20 2015-08-11  Mark Lam  <mark.lam@apple.com>
21
22         Fix names of Lock tests: should be "Contended", not "Contented".
23         https://bugs.webkit.org/show_bug.cgi?id=147905
24
25         Reviewed by Saam Barati.
26
27         We're testing the behavior of lock contention (i.e. when threads contend), not
28         whether the locks are happy (contented).
29
30         * Scripts/run-gtk-tests:
31         (TestRunner):
32         (TestRunner.__init__): Deleted.
33         * TestWebKitAPI/Tests/WTF/Lock.cpp:
34         (TestWebKitAPI::runLockTest):
35         (TestWebKitAPI::TEST):
36
37 2015-08-11  Alex Christensen  <achristensen@webkit.org>
38
39         Update WinCairoRequirements to VS2015.
40
41         * Scripts/update-webkit-wincairo-libs:
42         Update WinCairoRequirements location.
43
44 2015-08-11  Jason Marcell  <jmarcell@apple.com>
45
46         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
47         for internalTrac.
48         https://bugs.webkit.org/show_bug.cgi?id=147805
49
50         Reviewed by Daniel Bates.
51
52         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
53         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
54         Dashboard.Repository.Internal.trac for internalTrac.
55         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
56         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
57         respectively.
58         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
59         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
60         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
61         internalTrac.
62         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
63         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
64         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
65         (Analyzer): Ditto.
66         (Analyzer.prototype.analyze): Ditto.
67
68 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
69
70         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
71
72         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
73         (TestWebKitAPI::TEST):
74
75 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
76
77         [Win] Switch Windows build to Visual Studio 2015
78         https://bugs.webkit.org/show_bug.cgi?id=147887
79         <rdar://problem/22235098>
80
81         Reviewed by Alex Christensen.
82
83         Update Visual Studio project file settings to use the current Visual
84         Studio and compiler. Continue targeting binaries to run on our minimum
85         supported configuration of Windows 7.
86
87         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
88         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
89         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
90         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
91         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
92         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
93         prefer the newer MSBuild included in Visual Studio 2015.
94         (visualStudioInstallDir):
95         (msBuildInstallDir):
96         (visualStudioVersion):
97         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
98         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
99         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
100         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
101         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
102         * win/record-memory/record-memory.vcxproj:
103
104 2015-08-11  Alex Christensen  <achristensen@webkit.org>
105
106         Another speculative build fix after r188280.
107
108         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
109         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
110         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
111
112 2015-08-11  Alex Christensen  <achristensen@webkit.org>
113
114         Unreviewed build fix after r188280.
115
116         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
117         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
118
119 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
120
121         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
122         https://bugs.webkit.org/show_bug.cgi?id=147665
123
124         Reviewed by Mark Lam.
125
126         * TestWebKitAPI/CMakeLists.txt:
127         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
129         * TestWebKitAPI/Tests/WTF/Lock.cpp:
130         (TestWebKitAPI::TEST):
131         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
132         (TestWebKitAPI::TEST):
133
134 2015-08-11  Brian Burg  <bburg@apple.com>
135
136         webkit-patch should not explode when $EDITOR is set incorrectly
137         https://bugs.webkit.org/show_bug.cgi?id=147884
138
139         Reviewed by Darin Adler.
140
141         If $EDITOR doesn't exist, log a warning and continue.
142
143         * Scripts/webkitpy/common/system/user.py: 
144         (User.edit):
145         (User.edit_changelog):
146
147 2015-08-11  Dan Bernstein  <mitz@apple.com>
148
149         Reverted r188255, because it turned out that delegates do nonot need this information.
150
151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
152         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
153
154 2015-08-11  Dan Bernstein  <mitz@apple.com>
155
156         [Cocoa] The UI delegate can't tell if printing was user-initiated
157         https://bugs.webkit.org/show_bug.cgi?id=147869
158
159         Reviewed by Sam Weinig.
160
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
163         (-[PrintFrameController webView:didFinishNavigation:]):
164         (-[PrintFrameController _webView:printFrame:userInitiated:]):
165         (TEST):
166
167 2015-08-10  Alex Christensen  <achristensen@webkit.org>
168
169         Another build fix after r188239.
170
171         * TestWebKitAPI/PlatformWin.cmake:
172         Link with more libraries.
173         * WinLauncher/CMakeLists.txt:
174         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
175
176 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
177
178         Build fix after r188237.
179
180         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
181         (BenchmarkBuilder.__enter__):
182
183 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
184
185         Update ReadMe and correct the way to use abstract abstract class.
186         https://bugs.webkit.org/show_bug.cgi?id=147860
187
188         Reviewed by Ryosuke Niwa.
189
190         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
191         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
192
193         * Scripts/webkitpy/benchmark_runner/README.md:
194         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
195         (BrowserDriver):
196         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
197         (OSXBrowserDriver.restore_env):
198         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
199         (HTTPServerDriver):
200         (HTTPServerDriver.set_device_id):
201         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
202         (SimpleHTTPServerDriver.get_return_code):
203         (SimpleHTTPServerDriver):
204         (SimpleHTTPServerDriver.set_device_id):
205
206 2015-08-10  Alex Christensen  <achristensen@webkit.org>
207
208         Build TestWebKitAPI with CMake on Windows
209         https://bugs.webkit.org/show_bug.cgi?id=147851
210
211         Reviewed by Chris Dumez.
212
213         * CMakeLists.txt:
214         * TestWebKitAPI/CMakeLists.txt:
215         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
216         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
217         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
218         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
219         * TestWebKitAPI/PlatformEfl.cmake:
220         * TestWebKitAPI/PlatformGTK.cmake:
221         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
222         I did this without changing the directory structure of the existing EFL and GTK builds.
223         * TestWebKitAPI/PlatformWin.cmake: Added.
224         * TestWebKitAPI/win/main.cpp:
225         (main):
226         (dllLauncherEntryPoint):
227         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
228         * WinLauncher/CMakeLists.txt:
229         AppleWin port needs /NODEFAULTLIB:MSVCRT.
230
231 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
232
233         Make cleanup more robust and minor code cleaning in run benchmark script.
234         https://bugs.webkit.org/show_bug.cgi?id=147800
235
236         Reviewed by Ryosuke Niwa.
237
238         Use 'finnaly' block to make sure cleanup code is always executed.
239
240         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
241         (built_benchmark):
242         (built_benchmark.__init__):
243         (built_benchmark.__enter__):
244         (built_benchmark.__exit__):
245         (test_environment):
246         (test_environment.__init__):
247         (test_environment.__enter__):
248         (test_environment.__exit__):
249         (BenchmarkRunner.__init__):
250         (BenchmarkRunner.execute):
251         (BenchmarkRunner._dump):
252         (BenchmarkRunner._wrap):
253         (BenchmarkRunner): Deleted.
254         (BenchmarkRunner._cleanup): Deleted.
255         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
256         (BrowserDriver.close_browsers):
257         (BrowserDriver):
258         (BrowserDriver.restore_env):
259         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
260         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
261
262 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
263
264         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
265         https://bugs.webkit.org/show_bug.cgi?id=146414
266
267         Reviewed by Darin Adler.
268
269         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
270         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
271
272 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
273
274         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
275         https://bugs.webkit.org/show_bug.cgi?id=147727
276
277         Reviewed by Sergio Villar Senin.
278
279         I think it was not this test in particular, but
280         /webkit2/WebKitWebView/custom-charset that is affecting the
281         others. This is because changing the encoding reloads the page,
282         but we don't wait for the page to be reloaded, so when the test
283         finishes and other test starts the web process is still reloading
284         the page.
285
286         * Scripts/run-gtk-tests:
287         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
288         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
289         (testWebViewCustomCharset): Wait until page is reloaded after
290         changing the charset.
291
292 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
293
294         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
295
296         It's timing out in the bots. My guess is that there's no installer
297         installed in the bots and gst_install_plugins_supported() returns
298         false, so we don't even get a permission request because no
299         installer will be launched.
300
301         * Scripts/run-gtk-tests:
302         (TestRunner):
303
304 2015-08-07  Alex Christensen  <achristensen@webkit.org>
305
306         [GTK] Another build fix after r188157.
307
308         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
309         (WTR::PlatformWebView::viewSupportsOptions):
310         Name all the things correctly!
311
312 2015-08-07  Alex Christensen  <achristensen@webkit.org>
313
314         [EFL, GTK] Build fix after r188176.
315
316         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
317         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
318
319 2015-08-07  Alex Christensen  <achristensen@webkit.org>
320
321         [GTK] Speculative build fix after r188157.
322
323         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
324         (WTR::PlatformWebView::PlatformWebView):
325         Update parameter list.
326
327 2015-08-07  Alex Christensen  <achristensen@webkit.org>
328
329         Build more testing binaries with CMake on Windows
330         https://bugs.webkit.org/show_bug.cgi?id=147799
331
332         Reviewed by Brent Fulgham.
333
334         * DumpRenderTree/CMakeLists.txt:
335         Build TestNetscapePlugin.
336         * DumpRenderTree/PlatformWin.cmake:
337         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
338         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
339         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
340         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
341         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
342         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
343         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
344         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
345         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
346
347 2015-08-07  Jason Marcell  <jmarcell@apple.com>
348
349         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
350         https://bugs.webkit.org/show_bug.cgi?id=147667
351
352         Reviewed by Daniel Bates.
353
354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
355         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
356         other than "openSource" and "internal".
357         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
359         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
360         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
362         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
363         (sortedPlatforms): Deleted.
364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
365         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
366         (sortedPlatforms): Deleted.
367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
368         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
369         and sorts them by this property returning the new sorted array.
370
371 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
372
373         Lightweight locks should be adaptive
374         https://bugs.webkit.org/show_bug.cgi?id=147545
375
376         Reviewed by Geoffrey Garen.
377
378         * TestWebKitAPI/CMakeLists.txt:
379         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
381         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
382         (TestWebKitAPI::runLockTest):
383         (TestWebKitAPI::TEST):
384
385 2015-08-07  Anders Carlsson  <andersca@apple.com>
386
387         Fix a tyop.
388
389         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
390         (WTR::PlatformWebView::viewSupportsOptions):
391
392 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
393
394         Update AppEngine app version numbers to the latest commit.
395
396         * QueueStatusServer/app.yaml:
397         * TestResultServer/app.yaml:
398
399 2015-08-07  Anders Carlsson  <andersca@apple.com>
400
401         Simplify WKTR's view options
402         https://bugs.webkit.org/show_bug.cgi?id=147791
403
404         Reviewed by Sam Weinig.
405
406         Instead of using a WKDictionaryRef, just use a struct for the options.
407
408         * WebKitTestRunner/PlatformWebView.h:
409         (WTR::PlatformWebView::options):
410         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
411         * WebKitTestRunner/TestController.cpp:
412         (WTR::TestController::initialize):
413         (WTR::TestController::createWebViewWithOptions):
414         (WTR::TestController::ensureViewSupportsOptions):
415         (WTR::TestController::updateLayoutTypeForTest):
416         * WebKitTestRunner/TestController.h:
417         * WebKitTestRunner/ViewOptions.h: Added.
418         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
419         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
420         (WTR::PlatformWebView::PlatformWebView):
421         (WTR::PlatformWebView::viewSupportsOptions):
422         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
423         (WTR::PlatformWebView::viewSupportsOptions):
424         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
425         (WTR::PlatformWebView::viewSupportsOptions):
426         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
427         (WTR::PlatformWebView::PlatformWebView):
428         (WTR::PlatformWebView::viewSupportsOptions):
429         * WebKitTestRunner/mac/TestControllerMac.mm:
430         (WTR::TestController::platformConfigureViewForTest):
431
432 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
433
434         Running tests for a long time results in some tests running very slowly (throttling)
435         https://bugs.webkit.org/show_bug.cgi?id=147718
436
437         Reviewed by Chris Dumez.
438
439         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
440         Although COCOA ports default this setting to be disabled in WebKit1,
441         we should make both test harnesses disable the setting for consistency.
442
443         * DumpRenderTree/mac/DumpRenderTree.mm:
444         (resetWebPreferencesToConsistentValues):
445
446 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
447
448         Use a specific version of Speedometer in run-benchmark
449         https://bugs.webkit.org/show_bug.cgi?id=147769
450
451         Reviewed by Chris Dumez.
452
453         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
454
455         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
456
457 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
458
459         twisted_http_server.py should support --port
460         https://bugs.webkit.org/show_bug.cgi?id=147771
461
462         Reviewed by Chris Dumez.
463
464         Added the option. This makes the script more useful on its own.
465
466         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
467
468 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
469
470         [GTK] WTF unit tests are timing out in the bots
471         https://bugs.webkit.org/show_bug.cgi?id=147777
472
473         Reviewed by Filip Pizlo.
474
475         Add a way to mark google unit tests as slow and add
476         WTF_Lock.ContentedShortSection to the list. In case of slow test
477         we use the double of the given timeout for that particular test.
478
479         * Scripts/run-gtk-tests:
480         (TestRunner):
481         (TestRunner._run_google_test):
482
483 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
484
485         [GTK] run-gtk-tests should not stop when a google test case fails
486         https://bugs.webkit.org/show_bug.cgi?id=147778
487
488         Reviewed by Philippe Normand.
489
490         For glib based tests we run the test runner with the -k option,
491         but for google tests we are aborting as soon as we find a failure.
492
493         * Scripts/run-gtk-tests:
494         (TestRunner._run_google_test_suite): Use a global return code that
495         is set to 1 when any test has failed.
496
497 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
498
499         [GStreamer] Do not automatically show PackageKit codec installation notifications
500         https://bugs.webkit.org/show_bug.cgi?id=135973
501
502         Reviewed by Philippe Normand.
503
504         Handle the missing media plugins installation permission request
505         in MiniBrowser and add a test case for the new API.
506
507         * MiniBrowser/gtk/BrowserWindow.c:
508         (webViewDecidePermissionRequest):
509         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
510         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
511         (permissionRequestCallback):
512         (testInstallMissingPluginsPermissionRequest):
513         (beforeAll):
514         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
515         (methodCallCallback):
516
517 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
518
519         Running tests for a long time results in some tests running very slowly (throttling)
520         https://bugs.webkit.org/show_bug.cgi?id=147718
521
522         Reviewed by Alexey Proskuryakov.
523
524         * WebKitTestRunner/TestController.cpp:
525         (WTR::TestController::resetPreferencesToConsistentValues):
526         Ensure throttling settings are disabled for tests for all ports, as
527         COCOA ports default to having these setting enabled. Note, there is
528         still other timer throttling not covered by these setting.
529
530 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
531
532         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
533         https://bugs.webkit.org/show_bug.cgi?id=147752
534
535         Reviewed by Chris Dumez.
536
537         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
538
539         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
540         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
541
542         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
543         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
544         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
545         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
546         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
547         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
548         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
549         HTTPServerDriverFactory taking the platform name as an argument.
550         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
551         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
552         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
553         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
554         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
555         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
556         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
557         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
558         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
559         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
560         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
561         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
562         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
563         (HTTPServerDriver): Replaced name by platforms.
564         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
565         (SimpleHTTPServerDriver): Ditto.
566         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
567         (parse_args): Removed --http-server-driver option.
568         (start): Ditto.
569
570 2015-08-06  Chris Dumez  <cdumez@apple.com>
571
572         Toggle GPS state based on page visibility to save battery
573         https://bugs.webkit.org/show_bug.cgi?id=147685
574
575         Reviewed by Benjamin Poulain.
576
577         Add testRunner.isGeolocationProviderActive() test support function.
578
579         * DumpRenderTree/TestRunner.cpp:
580         (isGeolocationProviderActiveCallback):
581         (TestRunner::staticFunctions):
582         * DumpRenderTree/TestRunner.h:
583         * DumpRenderTree/mac/MockGeolocationProvider.h:
584         * DumpRenderTree/mac/MockGeolocationProvider.mm:
585         (-[MockGeolocationProvider isActive]):
586         * DumpRenderTree/mac/TestRunnerMac.mm:
587         (TestRunner::isGeolocationProviderActive):
588         * DumpRenderTree/win/TestRunnerWin.cpp:
589         (TestRunner::isGeolocationProviderActive):
590         * WebKitTestRunner/GeolocationProviderMock.h:
591         (WTR::GeolocationProviderMock::isActive):
592         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
593         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
594         (WTR::InjectedBundle::isGeolocationProviderActive):
595         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
597         (WTR::TestRunner::isGeolocationProviderActive):
598         * WebKitTestRunner/InjectedBundle/TestRunner.h:
599         * WebKitTestRunner/TestController.cpp:
600         (WTR::TestController::isGeolocationProviderActive):
601         * WebKitTestRunner/TestController.h:
602         * WebKitTestRunner/TestInvocation.cpp:
603         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
604
605 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
606
607         Automate JSBench with run-benchmark
608         https://bugs.webkit.org/show_bug.cgi?id=147716
609
610         Reviewed by Chris Dumez.
611
612         Added JSBench plan to run-benchmark.
613
614         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
615         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
616         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
617         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
618         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
619         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
620         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
621         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
622         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
623         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
624         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
625         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
626         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
627         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
628         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
629         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
630
631 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
632
633         Pass-through the undefined options in run-jsc
634         https://bugs.webkit.org/show_bug.cgi?id=147717
635
636         Undefined options in run-jsc is just passed to the actual jsc shell.
637         We can execute `Tools/Scripts/run-jsc -d`.
638
639         Reviewed by Csaba Osztrogonác.
640
641         * Scripts/run-jsc:
642
643 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
644
645         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
646
647         It's flaky.
648
649         * Scripts/run-gtk-tests:
650         (TestRunner):
651
652 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
653
654         [EFL] Bump EFL version to 1.15.0
655         https://bugs.webkit.org/show_bug.cgi?id=147450
656
657         Reviewed by Gyuyoung Kim.
658
659         * efl/jhbuild.modules:
660
661 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
662
663         Unreviewed. Unksip TestContextMenu GTK+ API test.
664
665         This has been skipped for a long time, and it's very
666         unconvenient. It has never failed for me locally, so let's try
667         again to see if it works in the bots. I'll skip it again if it
668         keeps failing.
669
670         * Scripts/run-gtk-tests:
671         (TestRunner):
672
673 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
674
675         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
676
677         * DumpRenderTree/JavaScriptThreading.cpp:
678         (javaScriptThreadsMutex):
679         (runJavaScriptThread):
680         (startJavaScriptThreads):
681         (stopJavaScriptThreads):
682         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
683         (TestWebKitAPI::TEST):
684         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
685         (TestWebKitAPI::TEST):
686
687 2015-08-05  Alex Christensen  <achristensen@webkit.org>
688
689         Build DumpRenderTree with CMake.
690         https://bugs.webkit.org/show_bug.cgi?id=147519
691
692         Reviewed by Brent Fulgham.
693
694         * CMakeLists.txt:
695         Build the DumpRenderTree directory now that it builds successfully.
696         * DumpRenderTree/CMakeLists.txt:
697         Added missing source file and don't link with WebCore.lib.
698         * DumpRenderTree/PlatformWin.cmake:
699         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
700         * WinLauncher/CMakeLists.txt:
701         We need libcmt now that we are not linking with WebCore.lib.
702
703 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
704
705         AppScale: Use https URLs for subresources and links
706         https://bugs.webkit.org/show_bug.cgi?id=147686
707
708         Reviewed by Ryosuke Niwa.
709
710         * QueueStatusServer/filters/webkit_extras.py:
711         * TestResultServer/static-dashboards/dashboard_base.js:
712         * TestResultServer/static-dashboards/flakiness_dashboard.js:
713         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
714         * TestResultServer/static-dashboards/treemap.js:
715         * TestResultServer/static-dashboards/ui.js:
716
717 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
718
719         Rename Mutex to DeprecatedMutex
720         https://bugs.webkit.org/show_bug.cgi?id=147675
721
722         Reviewed by Geoffrey Garen.
723
724         * DumpRenderTree/JavaScriptThreading.cpp:
725         (javaScriptThreadsMutex):
726         (runJavaScriptThread):
727         (startJavaScriptThreads):
728         (stopJavaScriptThreads):
729         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
730         (TestWebKitAPI::TEST):
731         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
732         (TestWebKitAPI::TEST):
733
734 2015-08-05  Timothy Hatcher  <timothy@apple.com>
735
736         Update the WebKit nightly icon
737         https://bugs.webkit.org/show_bug.cgi?id=147684
738
739         Reviewed by Sam Weinig.
740
741         * WebKitLauncher/webkit.icns: Replaced.
742
743 2015-08-05  Daniel Bates  <dabates@apple.com>
744
745         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
746         https://bugs.webkit.org/show_bug.cgi?id=147678
747         <rdar://problem/21827815>
748
749         Reviewed by Brady Eidson.
750
751         Add a test to ensure that we restore the "should open external URLs" policy on
752         page reload after the web content process crashes.
753
754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
755         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
756         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
757         (TEST):
758
759 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
760
761         [EFL] Editing tests have been broken since r186694
762         https://bugs.webkit.org/show_bug.cgi?id=146888
763
764         Reviewed by Brent Fulgham.
765
766         Restored some codes for the context click on GTK+ and EFL port.
767
768         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
769         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
770
771 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
772
773         Install twisted package for http server when necessary.
774         https://bugs.webkit.org/show_bug.cgi?id=147082
775
776         Reviewed by Ryosuke Niwa.
777
778         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
779         * Scripts/webkitpy/thirdparty/__init__.py:
780         (AutoinstallImportHook.find_module):
781         (AutoinstallImportHook._install_twisted):
782
783 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
784
785         [Win] Update Apple Windows build for VS2015
786         https://bugs.webkit.org/show_bug.cgi?id=147653
787
788         Reviewed by Dean Jackson.
789
790         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
791         something older than VS2015, define snprintf as _snprintf.
792         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
793         Remove unneeded macro definition for snprintf.
794         * Scripts/webkitpy/common/system/platforminfo.py:
795         (PlatformInfo._determine_win_version): Recognize Windows 10.
796         * Scripts/webkitpy/port/win.py:
797         (WinPort): Ditto.
798         * Scripts/webkitpy/port/win_unittest.py:
799         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
800         (WinPortTest._assert_version): Ditto.
801
802 2015-08-04  Brian Burg  <bburg@apple.com>
803
804         Unreviewed, update email addresses in contributors.json and watchlist.
805
806         * Scripts/webkitpy/common/config/contributors.json:
807         * Scripts/webkitpy/common/config/watchlist:
808
809 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
810
811         Implement NPAPI redirect handling
812         https://bugs.webkit.org/show_bug.cgi?id=138675
813         rdar://problem/15779101
814
815         Patch by Jeffrey Pfau, updated and tweaked by me.
816
817         Reviewed by Anders Carlsson.
818
819         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
820         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
821         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
822         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
823         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
824         (PluginTest::NPP_URLNotify):
825         (PluginTest::NPP_URLRedirectNotify):
826         (PluginTest::NPP_GetValue):
827         (PluginTest::NPN_GetURLNotify):
828         (PluginTest::NPN_PostURLNotify):
829         (PluginTest::NPN_GetValue):
830         (PluginTest::NPN_ReleaseVariantValue):
831         (PluginTest::NPN_URLRedirectResponse):
832         (PluginTest::NPN_ConvertPoint):
833         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
834         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
835         (URLRedirect::URLRedirect):
836         (URLRedirect::ScriptableObject::hasMethod):
837         (URLRedirect::ScriptableObject::get):
838         (URLRedirect::ScriptableObject::serviceAsync):
839         (URLRedirect::ScriptableObject::invoke):
840         (URLRedirect::NPP_GetValue):
841         (URLRedirect::NPP_URLNotify):
842         (URLRedirect::NPP_URLRedirectNotify):
843         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
844         (NP_GetEntryPoints):
845         (NPP_URLNotify):
846         (NPP_URLRedirectNotify):
847         (NPP_GetValue):
848
849 2015-08-04  Tim Horton  <timothy_horton@apple.com>
850
851         Move Matt Daiter to committers.
852
853         * Scripts/webkitpy/common/config/contributors.json:
854
855 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
856
857         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
858         https://bugs.webkit.org/show_bug.cgi?id=147636
859
860         Reviewed by Alex Christensen.
861         
862         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
863         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
864         on EWS machines)
865
866         * Scripts/build-webkit:
867
868 2015-08-04  Jason Marcell  <jmarcell@apple.com>
869
870         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
871         https://bugs.webkit.org/show_bug.cgi?id=147280
872
873         Reviewed by Daniel Bates.
874
875         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
876         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
877         Refactored _parseData to handle repositories more generically.
878         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
880         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
881         "opensourceRevision" and "internalRevision".
882         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
884         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
885         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
886         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
887         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
888         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
889         and "internalRevision".
890         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
891         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
892         "opensourceRevision" and "internalRevision".
893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
894         constants for internal and opensource repositories.
895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
896         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
897         instead of "opensourceRevision" and "internalRevision".
898         (Analyzer.prototype._countPercentageOfGreen): Ditto.
899         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
900         (Analyzer.prototype._countTimes): Ditto.
901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
902         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
903
904 2015-08-04  Mark Lam  <mark.lam@apple.com>
905
906         Removed a local debugging line I accidentally left in from a previous commit.
907
908         Not Reviewed.
909
910         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
911
912 2015-08-04  Mark Lam  <mark.lam@apple.com>
913
914         Unreviewed. Make Saam Barati a WebKit reviewer.
915
916         * Scripts/webkitpy/common/config/contributors.json:
917
918 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
919
920         Unreviewed, updated Streams API watchlist.
921
922         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
923
924 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
925
926         [CMake] Add an option to build AllInOne files
927         https://bugs.webkit.org/show_bug.cgi?id=102647
928
929         Reviewed by Alex Christensen.
930
931         * Scripts/webkitperl/FeatureList.pm:
932
933 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
934
935         AppScale: Add required indices
936         https://bugs.webkit.org/show_bug.cgi?id=147593
937
938         Reviewed by Tim Horton.
939
940         * QueueStatusServer/index.yaml:
941
942 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
943
944         Check in LLVM 3.6.2 binary drops for El Capitan
945         https://bugs.webkit.org/show_bug.cgi?id=147582
946
947         Reviewed by Alexey Proskuryakov.
948         
949         Recognize 10.11 and use the right drops.
950
951         * Scripts/copy-webkitlibraries-to-product-directory:
952
953 2015-08-03  Alex Christensen  <achristensen@webkit.org>
954
955         [Win] Build fix after r187733.
956
957         * WinLauncher/PageLoadTestClient.cpp:
958         (PageLoadTestClient::dumpRunStatistics):
959         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
960
961 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
962
963         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
964         https://bugs.webkit.org/show_bug.cgi?id=118455
965
966         Reviewed by Filip Pizlo.
967
968         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
969         (TestWebKitAPI::TEST):
970
971 2015-07-31  Alex Christensen  <achristensen@webkit.org>
972
973         Prepare for VS2015
974         https://bugs.webkit.org/show_bug.cgi?id=146579
975
976         Reviewed by Jon Honeycutt.
977
978         * WinLauncher/stdafx.h:
979         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
980
981 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
982
983         [EFL] Fix pixman build on ARM with GCC 4.9.3
984         https://bugs.webkit.org/show_bug.cgi?id=147224
985
986         Reviewed by Gyuyoung Kim.
987
988         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
989
990 2015-07-30  Anders Carlsson  <andersca@apple.com>
991
992         Add support for window.open to WK1BrowserWindowController
993         https://bugs.webkit.org/show_bug.cgi?id=147474
994
995         Reviewed by Dan Bernstein.
996
997         * MiniBrowser/mac/WK1BrowserWindowController.m:
998         (-[WK1BrowserWindowController awakeFromNib]):
999         Set javaScriptCanOpenWindowsAutomatically to YES. 
1000         If this becomes a nuisance, we can always add a menu item to toggle this.
1001
1002         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
1003         Implement this UI delegate method.
1004
1005 2015-07-30  Anders Carlsson  <andersca@apple.com>
1006
1007         Undo stray commit.
1008
1009         * MiniBrowser/mac/WK1BrowserWindowController.m:
1010         (-[WK1BrowserWindowController awakeFromNib]):
1011         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
1012
1013 2015-07-29  Dean Jackson  <dino@apple.com>
1014
1015         Don't use (Details) when exposing SPI
1016         https://bugs.webkit.org/show_bug.cgi?id=147426
1017         <rdar://problem/22062407>
1018
1019         Reviewed by Dan Bernstein.
1020
1021         If we are declaring the interface without any implementation,
1022         we should use class extensions.
1023
1024         * DumpRenderTree/mac/DumpRenderTree.mm:
1025         * DumpRenderTree/mac/EventSendingController.mm:
1026         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1027         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1028         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1029         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1030         * WebKitTestRunner/mac/TestControllerMac.mm:
1031
1032 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
1033
1034         Replace Google App Engine with AppScale
1035         https://bugs.webkit.org/show_bug.cgi?id=147178
1036
1037         Reviewed by Daniel Bates.
1038
1039         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1040         (RunWebKitTests):
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1046         (.):
1047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1048         (BubbleQueueServer):
1049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1050         (TestHistory):
1051         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1052         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
1053         * TestResultServer/app.yaml: Ditto
1054         * Scripts/webkitpy/common/config/urls.py:
1055         * TestResultServer/main.py:
1056         * TestResultServer/static-dashboards/dashboard_base.js:
1057         * TestResultServer/static-dashboards/loader.js:
1058
1059 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
1060
1061         [EFL] Enable IndexedDB based on DatabaseProcess
1062         https://bugs.webkit.org/show_bug.cgi?id=147221
1063
1064         Reviewed by Csaba Osztrogonác.
1065
1066         * Scripts/webkitperl/FeatureList.pm:
1067
1068 2015-07-30  Alex Christensen  <achristensen@webkit.org>
1069
1070         Build AppleWin port with CMake
1071         https://bugs.webkit.org/show_bug.cgi?id=147385
1072
1073         Reviewed by Martin Robinson.
1074
1075         * WinLauncher/CMakeLists.txt:
1076         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
1077
1078 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
1079
1080         Implement basic types for ECMAScript Internationalization API
1081         https://bugs.webkit.org/show_bug.cgi?id=146926
1082
1083         Reviewed by Benjamin Poulain.
1084
1085         Enable flag now that the basic objects are in place.
1086
1087         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
1088
1089 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1090
1091         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
1092         https://bugs.webkit.org/show_bug.cgi?id=147108
1093
1094         Reviewed by Gustavo Noronha Silva.
1095
1096         Add test case to check the web process limit.
1097
1098         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1099         (testWebProcessLimit):
1100         (beforeAll):
1101
1102 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1103
1104         [GTK] Missing casts in BrowserWindow.c
1105         https://bugs.webkit.org/show_bug.cgi?id=147395
1106
1107         Reviewed by Carlos Garcia Campos.
1108
1109         * MiniBrowser/gtk/BrowserWindow.c:
1110         (browserWindowSetupEditorToolbar):
1111
1112 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1113
1114         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
1115         https://bugs.webkit.org/show_bug.cgi?id=147350
1116
1117         Reviewed by Sam Weinig.
1118
1119         * Scripts/webkitperl/FeatureList.pm:
1120
1121 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1122
1123         [Freetype] Always allow font matching for strong aliases
1124         https://bugs.webkit.org/show_bug.cgi?id=147057
1125
1126         Reviewed by Martin Robinson.
1127
1128         Create family aliases needed for the new layout tests.
1129
1130         * WebKitTestRunner/gtk/fonts/fonts.conf:
1131
1132 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
1133
1134         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
1135         https://bugs.webkit.org/show_bug.cgi?id=147359
1136
1137         Reviewed by Ryosuke Niwa.
1138
1139         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1140         (NewCommitBot.begin_work_queue):
1141         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1142         (SheriffBot.begin_work_queue):
1143
1144 2015-07-27  Alex Christensen  <achristensen@webkit.org>
1145
1146         Use Ninja on Windows.
1147         https://bugs.webkit.org/show_bug.cgi?id=147228
1148
1149         Reviewed by Martin Robinson.
1150
1151         * WinLauncher/CMakeLists.txt:
1152         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
1153         * Scripts/build-webkit:
1154         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
1155
1156 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
1157
1158         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
1159         highlight after being tapped to style a selection"
1160         https://bugs.webkit.org/show_bug.cgi?id=147278
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1165
1166         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
1167         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
1168         (TestWebKitAPI::TEST):
1169         Load a page with the string "Hello, world!", then select "world" and
1170         underline it. Test that the typing attributes for the current selection
1171         include the underline attribute.
1172
1173 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1174
1175         Unreviewed, updated my nick name in contributors.json
1176
1177         * Scripts/webkitpy/common/config/contributors.json:
1178
1179 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
1180
1181         AX: scrollable elements do not allow 3-finger swipe
1182         https://bugs.webkit.org/show_bug.cgi?id=141893
1183
1184         Reviewed by Mario Sanchez Prada.
1185
1186         Support global notification listeners for iOS code.
1187         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
1188         Implement scrollUp/Down/Left/Right.
1189
1190         * DumpRenderTree/AccessibilityController.h:
1191         * DumpRenderTree/AccessibilityUIElement.cpp:
1192         (increaseTextSelectionCallback):
1193         (scrollPageUpCallback):
1194         (scrollPageDownCallback):
1195         (scrollPageLeftCallback):
1196         (scrollPageRightCallback):
1197         (decreaseTextSelectionCallback):
1198         (getElementTextLengthCallback):
1199         (AccessibilityUIElement::getJSClass):
1200         * DumpRenderTree/AccessibilityUIElement.h:
1201         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1202         (AccessibilityController::~AccessibilityController):
1203         (AccessibilityController::elementAtPoint):
1204         (AccessibilityController::addNotificationListener):
1205         (AccessibilityController::platformResetToConsistentState):
1206         (AccessibilityController::removeNotificationListener):
1207         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1208         (AccessibilityUIElement::AccessibilityUIElement):
1209         (AccessibilityUIElement::subrole):
1210         (AccessibilityUIElement::scrollPageUp):
1211         (AccessibilityUIElement::scrollPageDown):
1212         (AccessibilityUIElement::scrollPageLeft):
1213         (AccessibilityUIElement::scrollPageRight):
1214         (AccessibilityUIElement::roleDescription):
1215         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1216         (-[AccessibilityNotificationHandler _notificationReceived:]):
1217         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1218         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1219         (WTR::AccessibilityUIElement::linkedElement):
1220         (WTR::AccessibilityUIElement::headerElementAtIndex):
1221         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1222         (WTR::AccessibilityUIElement::scrollPageUp):
1223         (WTR::AccessibilityUIElement::scrollPageDown):
1224         (WTR::AccessibilityUIElement::scrollPageLeft):
1225         (WTR::AccessibilityUIElement::scrollPageRight):
1226         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1227         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1228         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1229         (WTR::AccessibilityController::addNotificationListener):
1230         (WTR::AccessibilityController::removeNotificationListener):
1231         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1232         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1233         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1234         (WTR::AccessibilityUIElement::scrollPageUp):
1235         (WTR::AccessibilityUIElement::scrollPageDown):
1236         (WTR::AccessibilityUIElement::scrollPageLeft):
1237         (WTR::AccessibilityUIElement::scrollPageRight):
1238         (WTR::AccessibilityUIElement::increaseTextSelection):
1239
1240 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
1241
1242         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
1243         https://bugs.webkit.org/show_bug.cgi?id=147279
1244         <rdar://problem/21990767>
1245
1246         Reviewed by Dean Jackson.
1247
1248         * DumpRenderTree/win/TestRunnerWin.cpp:
1249         (TestRunner::addUserScript):
1250         (TestRunner::addUserStyleSheet):
1251         (TestRunner::setDeveloperExtrasEnabled):
1252
1253 2015-07-24  Basile Clement  <basile_clement@apple.com>
1254
1255         Call fixChangeLogPatch when generating patches from webkit-patch
1256         https://bugs.webkit.org/show_bug.cgi?id=147248
1257
1258         Reviewed by Geoffrey Garen.
1259
1260         When two consecutive patches are from the same author, diff tools
1261         create wrong-looking diffs for ChangeLog files where the apparent added
1262         author is actually the previous patch's author line, making it awkward
1263         to read - and things only get worse when committing a patch and a
1264         followup fix for the same bug shortly after.
1265
1266         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
1267         this, which we use in perl scripts (svn-create-patch et al). But it is
1268         not used by webkit-patch, which is a python script, and thus creates
1269         "bad" diffs.
1270
1271         In the long term, we should probably port fixChangeLogPatch to python -
1272         but in the short term, let's make webkit-patch call perl to run
1273         fixChangeLogPatch. We are already making various external calls there
1274         anyway.
1275
1276         * Scripts/webkitpy/common/checkout/scm/git.py:
1277         (Git.create_patch):
1278         * Scripts/webkitpy/common/checkout/scm/scm.py:
1279         (SCM.fix_changelog_patch):
1280         * Scripts/webkitpy/common/checkout/scm/svn.py:
1281         (SVN.create_patch):
1282
1283 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
1284
1285         commit-queue flags in webkit-patch are confusing
1286         https://bugs.webkit.org/show_bug.cgi?id=88694
1287
1288         Reviewed by Csaba Osztrogonác.
1289
1290         * Scripts/webkitpy/tool/steps/options.py:
1291         (Options): Updated help string to be more descriptive.
1292
1293 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
1294
1295         [Win] Implement proper High DPI support features
1296         https://bugs.webkit.org/show_bug.cgi?id=146335
1297         <rdar://problem/21558269>
1298
1299         Reviewed by Alex Christensen.
1300
1301         Update WinLauncher to take device scaling factor into account.
1302
1303         * WinLauncher/Common.cpp:
1304         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
1305         a valid font.
1306         (computeFullDesktopFrame): Handle high DPI desktops.
1307         (WndProc): Make comments more precise.
1308         * WinLauncher/WinLauncher.cpp:
1309         (WinLauncher::init): Determine device scale factor at launch.
1310         (WinLauncher::updateDeviceScaleFactor): Added.
1311         * WinLauncher/WinLauncher.h:
1312         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
1313         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
1314         (wWinMain): Ditto.
1315         * win/DLLLauncher/DLLLauncherMain.cpp:
1316         (wWinMain): Tell Windows we understand high DPI.
1317
1318 2015-07-23  Alex Christensen  <achristensen@webkit.org>
1319
1320         [Win] Unreviewed build fix after r187169.
1321
1322         * Scripts/build-webkit:
1323         Correctly find WebKit.sln.
1324
1325 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1326
1327         [GTK] Add API to allow executing editing commands that require an argument
1328         https://bugs.webkit.org/show_bug.cgi?id=146781
1329
1330         Reviewed by Gustavo Noronha Silva.
1331
1332         Add buttons to insert image/link to the MiniBrowser edit toolbar,
1333         and test cases for insert image/link commands too.
1334
1335         * MiniBrowser/gtk/BrowserWindow.c:
1336         (insertImageCommandCallback):
1337         (insertLinkCommandCallback):
1338         (browserWindowSetupEditorToolbar):
1339         (browserWindowConstructed):
1340         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1341         (testWebViewEditorInsertImage):
1342         (testWebViewEditorCreateLink):
1343         (beforeAll):
1344
1345 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1346
1347         Unregistering and re-registering a user message handler does not work
1348         https://bugs.webkit.org/show_bug.cgi?id=138142
1349
1350         Reviewed by Martin Robinson.
1351
1352         This has probably been fixed in r184846, enable the test case
1353         blocked on it.
1354
1355         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1356         (testUserContentManagerScriptMessageReceived):
1357
1358 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
1359
1360         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
1361         https://bugs.webkit.org/show_bug.cgi?id=147212
1362
1363         Reviewed by Filip Pizlo.
1364
1365         * Scripts/webkitperl/FeatureList.pm:
1366
1367 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
1368
1369         Add --ios-simulator to run-api-tests --help.
1370
1371         Rubber-stamped by Dan Bates.
1372
1373         * Scripts/run-api-tests:
1374
1375 2015-07-22  Jason Marcell  <jmarcell@apple.com>
1376
1377         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
1378         https://bugs.webkit.org/show_bug.cgi?id=147043
1379
1380         Reviewed by Daniel Bates and Alexey Proskuryakov.
1381
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1383         (Buildbot.prototype._normalizeQueueInfo):
1384         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
1385         in cases where the queue.branch property is not set and the queue is not a combined queue.
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1387         (BuildbotCombinedQueueView):
1388         Ensuring uniformity of repository branches within a combined queue.
1389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1390         (WebKitBuildbot.prototype.get defaultBranches):
1391         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
1392         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
1393         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
1394         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
1395         implement defaultBranches so that a person can either update the definition of the sub-queue or
1396         implement defaultBranches in the derived Buildbot class they are using.
1397
1398 2015-07-22  Alex Christensen  <achristensen@webkit.org>
1399
1400         Switch WinCairo build to use CMake.
1401         https://bugs.webkit.org/show_bug.cgi?id=147169
1402
1403         Reviewed by Brent Fulgham.
1404
1405         * Scripts/build-webkit:
1406         * Scripts/webkitdirs.pm:
1407         (determineConfiguration):
1408         (determineArchitecture):
1409         (determinePassedConfiguration):
1410         (passedConfiguration):
1411         (jhbuildWrapperPrefixIfNeeded):
1412         (generateBuildSystemFromCMakeProject):
1413         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
1414
1415 2015-07-22  Alex Christensen  <achristensen@webkit.org>
1416
1417         Fix quirks in CMake build on Mac and Windows
1418         https://bugs.webkit.org/show_bug.cgi?id=147174
1419
1420         Reviewed by Gyuyoung Kim.
1421
1422         * CMakeLists.txt:
1423         Don't build DumpRenderTree with CMake for now (until we get that working).
1424         * WinLauncher/CMakeLists.txt:
1425         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
1426
1427 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1428
1429         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
1430         https://bugs.webkit.org/show_bug.cgi?id=147146
1431
1432         Reviewed by Darin Adler.
1433
1434         * Scripts/webkitpy/style/checkers/cpp.py:
1435         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
1436         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1437         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
1438
1439 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
1440
1441         Fixed VM pool allocation should have a reserve for allocations that cannot fail
1442         https://bugs.webkit.org/show_bug.cgi?id=147154
1443         rdar://problem/21847618
1444
1445         Reviewed by Geoffrey Garen.
1446         
1447         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
1448         mitigations work, these should all pass. Prior to this patch there were >20 failures.
1449
1450         * Scripts/run-jsc-stress-tests:
1451
1452 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1453
1454         [GTK] Add API to be notified about editor state changes
1455         https://bugs.webkit.org/show_bug.cgi?id=145875
1456
1457         Reviewed by Gustavo Noronha Silva.
1458
1459         Update the typing attributes toggle buttons state according to the
1460         editor state in MiniBrowser, and add a test case to the
1461         WebViewEditor unit tests.
1462
1463         * MiniBrowser/gtk/BrowserWindow.c:
1464         (browserWindowEditingCommandToggleButtonSetActive):
1465         (typingAttributesChanged):
1466         (browserWindowSetupEditorToolbar):
1467         (browserWindowConstructed):
1468         (browser_window_init):
1469         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1470         (testWebViewEditorEditorStateTypingAttributes):
1471         (beforeAll):
1472
1473 2015-07-20  Tomas Popela  <tpopela@redhat.com>
1474
1475         [GTK] Add selection-changed signal to the WebKit2 API
1476         https://bugs.webkit.org/show_bug.cgi?id=137116
1477
1478         Reviewed by Carlos Garcia Campos.
1479
1480         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
1481         (namely the selection-changed signal).
1482
1483         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1484         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
1485         (WebKitWebEditorTest::create):
1486         (WebKitWebEditorTest::selectionChangedCallback):
1487         (WebKitWebEditorTest::testSelectionSelectAll):
1488         (WebKitWebEditorTest::testSelectionCollapse):
1489         (WebKitWebEditorTest::testSelectionModifyMove):
1490         (WebKitWebEditorTest::testSelectionModifyExtend):
1491         (WebKitWebEditorTest::testSelectionUnselect):
1492         (registerTests):
1493         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
1494         (testWebKitWebEditorSelectionChanged):
1495         (beforeAll):
1496         (afterAll):
1497
1498 2015-07-20  Alex Christensen  <achristensen@webkit.org>
1499
1500         Resurrect CMake build on Windows.
1501         https://bugs.webkit.org/show_bug.cgi?id=147083
1502
1503         Reviewed by Gyuyoung Kim.
1504
1505         * DumpRenderTree/CMakeLists.txt:
1506         * DumpRenderTree/PlatformWin.cmake: Added.
1507         * WinLauncher/CMakeLists.txt:
1508
1509 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1510
1511         [GTK] Enable seccomp filter API tests
1512         https://bugs.webkit.org/show_bug.cgi?id=140071
1513
1514         Reviewed by Žan Doberšek.
1515
1516         These tests will now be run by the run-gtk-tests script.
1517
1518         * TestWebKitAPI/PlatformGTK.cmake:
1519
1520 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1521
1522         [GTK] Add seccomp filters support
1523         https://bugs.webkit.org/show_bug.cgi?id=110014
1524
1525         Reviewed by Žan Doberšek.
1526
1527         Add libseccomp to jhbuild modulesets.
1528
1529         * gtk/jhbuild.modules:
1530
1531 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
1532
1533         MiniBrowser window title is just "Window" when page has no <title>
1534         https://bugs.webkit.org/show_bug.cgi?id=147076
1535
1536         Reviewed by Tim Horton.
1537         
1538         Make MiniBrowser windows show the filename from the URL if we never get a title changed
1539         notification.
1540
1541         * MiniBrowser/mac/WK1BrowserWindowController.m:
1542         (-[WK1BrowserWindowController updateTitle:]):
1543         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
1544         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
1545         * MiniBrowser/mac/WK2BrowserWindowController.m:
1546         (-[WK2BrowserWindowController updateTitle:]):
1547         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1548         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1549
1550 2015-07-17  Andy Estes  <aestes@apple.com>
1551
1552         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
1553         https://bugs.webkit.org/show_bug.cgi?id=147044
1554         rdar://problem/21567820
1555
1556         Reviewed by Brady Eidson.
1557
1558         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1559         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
1560         This matches the behavior of DumpRenderTree.
1561
1562 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
1563
1564         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
1565         https://bugs.webkit.org/show_bug.cgi?id=147032
1566
1567         Reviewed by Alex Christensen.
1568
1569         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1570         Test that the useless terms are eliminated by counting
1571         the number of NFA nodes generated.
1572
1573 2015-07-17  Dan Bernstein  <mitz@apple.com>
1574
1575         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
1576         https://bugs.webkit.org/show_bug.cgi?id=147040
1577
1578         Reviewed by Dean Jackson.
1579
1580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1581         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
1582         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
1583         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
1584         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1585         (TEST):
1586
1587 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
1588
1589         webkit-patch uses incorrect credentials from keychain to login until account lockout
1590         https://bugs.webkit.org/show_bug.cgi?id=146923
1591
1592         Reviewed by Daniel Bates.
1593
1594         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
1595         provide incorrect credentials then ask for them to be saved to the keychain
1596         webkit-patch will then use those incorrect credentials until 5 total attempts
1597         have been made to log in. This will lock the user out of Bugzilla for a
1598         half hour.
1599
1600         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1601         (Bugzilla.authenticate): Added argument to read_credentials() that
1602         passes in whether or not to use stored credentials.
1603         * Scripts/webkitpy/common/net/credentials.py:
1604         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
1605         that specifies whether or not to use credentials stored on the system. If it
1606         does, we do not auto-fill credentials since either the credentials caused
1607         the failure, or they weren't used in the first place so there is no reason
1608         to try and use them again if a failure happened.
1609         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
1610         use_stored_credentials argument.
1611         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
1612         retrieve username/password information from the local system (environment, Git, keychain,
1613         keyring) are never called. It also tests that we get back our mocked username and password.
1614         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
1615         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
1616         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
1617         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
1618         is never called.
1619         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
1620         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
1621         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
1622         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
1623         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
1624         against.
1625
1626 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1627
1628         Unreviewed, remove my redundant email information.
1629
1630         * Scripts/webkitpy/common/config/contributors.json:
1631
1632 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1633
1634         Unreviewed. Add Hyungwook Lee as a committer.
1635
1636         * Scripts/webkitpy/common/config/contributors.json:
1637
1638 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1639
1640         Added myself to the list of contributors.
1641
1642         Reviewed by Brent Fulgham.
1643
1644         * Scripts/webkitpy/common/config/contributors.json:
1645
1646 2015-07-16  Alex Christensen  <achristensen@webkit.org>
1647
1648         [Content Extensions] Cache domain actions
1649         https://bugs.webkit.org/show_bug.cgi?id=146817
1650
1651         Reviewed by Benjamin Poulain.
1652
1653         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1654         (TestWebKitAPI::TEST_F):
1655         Test if-domain and unless-domain with multiple load types.
1656
1657 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
1658
1659         [Content extensions] Combine suffixes when generating NFAs
1660         https://bugs.webkit.org/show_bug.cgi?id=146961
1661
1662         Reviewed by Alex Christensen.
1663
1664         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1665         (TestWebKitAPI::compareContents):
1666         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1667
1668 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1669
1670         [GTK] Input method filter is always enabled when the view is focused
1671         https://bugs.webkit.org/show_bug.cgi?id=146965
1672
1673         Reviewed by Martin Robinson.
1674
1675         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
1676
1677         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1678         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1679
1680 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1681
1682         [EFL] Bump libseccomp version to 2.2.3
1683         https://bugs.webkit.org/show_bug.cgi?id=146980
1684
1685         Reviewed by Gyuyoung Kim.
1686
1687         * efl/jhbuild.modules:
1688
1689 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
1690
1691         [Win] Maintain consistent COM Interfaces
1692         https://bugs.webkit.org/show_bug.cgi?id=146983
1693         <rdar://problem/21822278>
1694
1695         Reviewed by Dean Jackson.
1696
1697         Update DumpRenderTree and WinLauncher to use the properly
1698         versioned COM interface objects.
1699
1700         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1701         (AccessibilityController::rootElement):
1702         * DumpRenderTree/win/DumpRenderTree.cpp:
1703         (resetWebPreferencesToConsistentValues):
1704         (resetWebViewToConsistentStateBeforeTesting):
1705         (runTest):
1706         (createWebViewAndOffscreenWindow):
1707         * DumpRenderTree/win/EditingDelegate.cpp:
1708         (EditingDelegate::QueryInterface):
1709         (EditingDelegate::shouldEndEditingInDOMRange):
1710         (EditingDelegate::shouldInsertNode):
1711         * DumpRenderTree/win/EditingDelegate.h:
1712         * DumpRenderTree/win/EventSender.cpp:
1713         (scalePageByCallback):
1714         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1715         (FrameLoadDelegate::didCommitLoadForFrame):
1716         * DumpRenderTree/win/TestRunnerWin.cpp:
1717         (TestRunner::callShouldCloseOnWebView):
1718         (TestRunner::applicationCacheDiskUsageForOrigin):
1719         (TestRunner::clearApplicationCacheForOrigin):
1720         (TestRunner::setDefersLoading):
1721         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1722         (TestRunner::setTabKeyCyclesThroughElements):
1723         (TestRunner::setValueForUser):
1724         (TestRunner::dispatchPendingLoadRequests):
1725         (TestRunner::setWindowIsKey):
1726         (TestRunner::execCommand):
1727         (TestRunner::addOriginAccessWhitelistEntry):
1728         (TestRunner::removeOriginAccessWhitelistEntry):
1729         (TestRunner::addUserScript):
1730         (TestRunner::addUserStyleSheet):
1731         (TestRunner::showWebInspector):
1732         (TestRunner::closeWebInspector):
1733         (TestRunner::evaluateInWebInspector):
1734         (TestRunner::setSerializeHTTPLoads):
1735         * DumpRenderTree/win/TextInputControllerWin.cpp:
1736         (TextInputController::setMarkedText):
1737         (TextInputController::hasMarkedText):
1738         (TextInputController::unmarkText):
1739         (TextInputController::markedRange):
1740         (TextInputController::insertText):
1741         (TextInputController::firstRectForCharacterRange):
1742         (TextInputController::selectedRange):
1743         * DumpRenderTree/win/UIDelegate.h:
1744         (UIDelegate::unused2):
1745         (UIDelegate::unused3):
1746         (UIDelegate::webViewScrolled):
1747         (UIDelegate::webViewShouldInterruptJavaScript):
1748         (UIDelegate::webViewReceivedFocus):
1749         (UIDelegate::unused4): Deleted.
1750         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1751         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1752         * WinLauncher/PageLoadTestClient.cpp:
1753         (PageLoadTestClient::didStartProvisionalLoad):
1754         * WinLauncher/WinLauncher.cpp:
1755         (WinLauncher::init):
1756         * WinLauncher/WinLauncher.h:
1757         * WinLauncher/WinLauncherWebHost.cpp:
1758         (WinLauncherWebHost::didFinishLoadForFrame):
1759         (WinLauncherWebHost::didFirstLayoutInFrame):
1760         * WinLauncher/WinLauncherWebHost.h:
1761
1762 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
1763
1764         Many test failures in scm_unittest.py
1765         https://bugs.webkit.org/show_bug.cgi?id=143967
1766
1767         Reviewed by Daniel Bates. 
1768
1769         * Scripts/webkitpy/common/checkout/scm/detection.py:
1770         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
1771         absolute canonical file paths. Two mutually exclusive issues cause this
1772         to be a problem.
1773             1) Python's os.path.relpath() function does not return correct relative
1774             paths between two filepaths that point to the same file, if symlinks are
1775             involved.
1776                 On Mac, /tmp points to /private/tmp
1777                 ex. os.path.relpath('/tmp', '/private/tmp')
1778                     returns '../../tmp'
1779             What we want is actually just '.'
1780             2) Git does not allow file paths to trace outside of
1781             the Git repository. This means that if you have a repository in
1782             /tmp and you refer to that repository when invoking a git command as
1783             ../tmp, Git will produce errors about working outside of the repository.
1784         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
1785         its default behavior and such, needed to be updated.
1786         (Git.changed_files): '--' was added into the command so that patch_directories
1787         were taken as positional arguments.
1788         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
1789         in the GitSVNTest class to more closely emulate the version of Git that the tests
1790         assumed a system had. Also fixed a small side-effect from the absolute canonical
1791         path fix in SCMDetector.detect_scm_system
1792         (SVNTestRepository.setup): A relative filepath was previously passed as the
1793         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
1794         an absolute canonical path before being passed in. The failing test
1795         was a "sanity check" that the svn.checkout_root and scm.checkout_root
1796         were the same.
1797         (GitSVNTest._setup_git_checkout):
1798             1) Added "--prefix ''" option to `git clone` since Git changed its default
1799             behavior in version 2.0.
1800             2) The branch master was renamed to trunk to more closely emulate what
1801             tests expected when they were written. 
1802         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
1803         original tests failed because the tests expected the trunk branch
1804         to produce its parent's commit, whereas Git merely provides the HEAD commit
1805         for a given branch (trunk in this case). Based on other tests written
1806         in the same commit, it appears these tests were failing from the point they
1807         were written.
1808
1809 2015-07-14  Anders Carlsson  <andersca@apple.com>
1810
1811         Assertions.h should include ExportMacros.h
1812         https://bugs.webkit.org/show_bug.cgi?id=146948
1813
1814         Reviewed by Tim Horton.
1815
1816         Remove now unneeded WTF_EXPORT_PRIVATE define.
1817
1818         * DumpRenderTree/cg/ImageDiffCG.cpp:
1819
1820 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1821
1822         [GTK] [Wayland] Build by default the X11 and Wayland targets.
1823         https://bugs.webkit.org/show_bug.cgi?id=146057
1824
1825         Reviewed by Carlos Garcia Campos.
1826
1827         * gtk/install-dependencies:
1828
1829 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
1830
1831         [Mac] Unable to dismiss context menu during test runs
1832         https://bugs.webkit.org/show_bug.cgi?id=146836
1833
1834         Reviewed by Tim Horton.
1835
1836         Since Context Menus are modal, the test system would block on the displayed context menu,
1837         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
1838         mouse click and generate the menu contents, but not ask AppKit to display it.
1839
1840         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
1841
1842         * DumpRenderTree/mac/EventSendingController.mm:
1843         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
1844         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1845         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
1846         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
1847         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
1848         work without actually calling on AppKit to display the menu.
1849         ask WebCore to do all the work EXCEPT displaying the menu.
1850         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1851         * WebKitTestRunner/mac/EventSenderProxy.mm:
1852         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
1853
1854 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
1855
1856         It should be possible to run the OSR exit fuzzer
1857         https://bugs.webkit.org/show_bug.cgi?id=146814
1858
1859         Reviewed by Mark Lam.
1860         
1861         This runs a test command to detect how many static OSR exit sites it had, and then for
1862         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
1863         middle opportunity), plus a mode where the check always exits. This is an exhaustive
1864         search, so in the future it'll be very appropriate for cases where we have a simple test
1865         and we want to see what happens when you eventually exit in this test.
1866         
1867         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
1868         and it seems to do the right thing.
1869
1870         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
1871         (fail):
1872
1873 2015-07-10  Alex Christensen  <achristensen@webkit.org>
1874
1875         Add tests for r186649
1876         https://bugs.webkit.org/show_bug.cgi?id=146821
1877
1878         Reviewed by Darin Adler.
1879
1880         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1881         (TestWebKitAPI::TEST_F):
1882         (TestWebKitAPI::compareContents):
1883         (TestWebKitAPI::expectedIndex):
1884         Add some larger tests to test large jumps.
1885
1886 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
1887
1888         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
1889         https://bugs.webkit.org/show_bug.cgi?id=146820
1890
1891         Reviewed by Ryosuke Niwa.
1892
1893         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1894         (OSXBrowserDriver):
1895         (OSXBrowserDriver.close_browsers):
1896         (OSXBrowserDriver._terminiate_processes):
1897         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1898         (OSXChromeDriver):
1899         (OSXChromeCanaryDriver):
1900         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1901         (OSXFirefoxDriver):
1902         (OSXFirefoxNightlyDriver):
1903         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1904         (OSXSafariDriver):
1905
1906 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1907
1908         [GTK] pango should be included in the default jhbuild moduleset
1909         https://bugs.webkit.org/show_bug.cgi?id=146683
1910
1911         Reviewed by Martin Robinson.
1912
1913         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
1914         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
1915         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
1916         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
1917         the same problem again the next time pango wants to use a new fontconfig feature), or remove
1918         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
1919         best.
1920
1921         * gtk/jhbuild-optional.modules: Remove pango
1922         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
1923
1924 2015-07-09  Devin Rousso  <drousso@apple.com>
1925
1926         Unreviewed.  Added myself as a committer.
1927
1928         * Scripts/webkitpy/common/config/contributors.json:
1929
1930 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
1931
1932         Add a way to set the default URL from Minibrowser UI
1933         https://bugs.webkit.org/show_bug.cgi?id=146780
1934
1935         Reviewed by Simon Fraser.
1936
1937         * MiniBrowser/mac/AppDelegate.m:
1938         (-[BrowserAppDelegate didChangeSettings]):
1939         * MiniBrowser/mac/BrowserWindowController.h:
1940         * MiniBrowser/mac/BrowserWindowController.m:
1941         (-[BrowserWindowController fetch:]):
1942         (-[BrowserWindowController reload:]):
1943         (-[BrowserWindowController forceRepaint:]):
1944         (-[BrowserWindowController goBack:]):
1945         (-[BrowserWindowController goForward:]):
1946         (-[BrowserWindowController showHideWebView:]):
1947         (-[BrowserWindowController removeReinsertWebView:]):
1948         (-[BrowserWindowController zoomIn:]):
1949         (-[BrowserWindowController zoomOut:]):
1950         (-[BrowserWindowController resetZoom:]):
1951         (-[BrowserWindowController canZoomIn]):
1952         (-[BrowserWindowController canZoomOut]):
1953         (-[BrowserWindowController canResetZoom]):
1954         (-[BrowserWindowController toggleZoomMode:]):
1955         (-[BrowserWindowController setScale:]):
1956         (-[BrowserWindowController toggleShrinkToFit:]):
1957         (-[BrowserWindowController dumpSourceToConsole:]):
1958         (-[BrowserWindowController find:]):
1959         (-[BrowserWindowController didChangeSettings]):
1960         (-[BrowserWindowController currentURL]):
1961         Get rid of the BrowserController protocol. It was a bad idea and confused
1962         Interface Builder more than I thought possible.
1963
1964         * MiniBrowser/mac/SettingsController.m:
1965         (-[SettingsController _populateMenu]):
1966         (-[SettingsController setDefaultURLToCurrentURL:]):
1967         If we have a BrowserWindowController, grab its URL and set the relevant default.
1968
1969         * MiniBrowser/mac/WK1BrowserWindowController.h:
1970         * MiniBrowser/mac/WK1BrowserWindowController.m:
1971         (-[WK1BrowserWindowController currentURL]):
1972         * MiniBrowser/mac/WK2BrowserWindowController.h:
1973         * MiniBrowser/mac/WK2BrowserWindowController.m:
1974         (-[WK2BrowserWindowController currentURL]):
1975         Retrieve the current URL from the WKView/WebView.
1976
1977 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
1978
1979         Increase MiniBrowser location bar maximum width
1980         https://bugs.webkit.org/show_bug.cgi?id=146779
1981
1982         Reviewed by Simon Fraser.
1983
1984         * MiniBrowser/mac/BrowserWindow.xib:
1985         Have an enormous maximum width on the location bar, so that it doesn't
1986         stop expanding with the window at 800px.
1987
1988 2015-07-08  Brady Eidson  <beidson@apple.com>
1989
1990         Crash calling [WebView close] in didFinishLoadForFrame callback.
1991         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
1992
1993         Reviewed by David Kilzer.
1994
1995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1996         
1997         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
1998         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
1999         (TestWebKitAPI::TEST):
2000
2001 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2002
2003         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
2004         https://bugs.webkit.org/show_bug.cgi?id=146546
2005
2006         Reviewed by Darin Adler.
2007
2008         We did't reset pendingNavigationID value when request url is empty.
2009         Hence we need to ignore ASSERT check in this case.
2010
2011         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2012         (TestWebKitAPI::TEST):
2013
2014 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
2015
2016         [Content Extensions] Fuse undistinguishable actions as much as possible
2017         https://bugs.webkit.org/show_bug.cgi?id=146762
2018
2019         Reviewed by Alex Christensen.
2020
2021         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2022         Test that combinations and flags still work as expected.
2023
2024 2015-07-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2025
2026         [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset.
2027         https://bugs.webkit.org/show_bug.cgi?id=146056
2028
2029         Reviewed by Martin Robinson.
2030
2031         * gtk/install-dependencies: libepoxy is now required for building GTK+.
2032         * gtk/jhbuild-wayland.modules: Removed. Not longer needed.
2033         * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building:
2034         Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1).
2035         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed.
2036         Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb.
2037         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed.
2038         GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98.
2039
2040 2015-07-06  Matt Rajca  <mrajca@apple.com>
2041
2042         Media Session: propagate metadata changes to UI clients
2043         https://bugs.webkit.org/show_bug.cgi?id=146660
2044
2045         Reviewed by Tim Horton.
2046
2047         * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient.
2048         (WTR::TestController::createOtherPage):
2049         (WTR::TestController::createWebViewWithOptions):
2050
2051 2015-07-07  Brady Eidson  <beidson@apple.com>
2052
2053         HTTP Auth cached after disabling private browsing/reset.
2054         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
2055
2056         Reviewed by Tim Horton.
2057
2058         * DumpRenderTree/mac/DumpRenderTree.mm:
2059         (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs.
2060
2061 2015-07-06  Alex Christensen  <achristensen@webkit.org>
2062
2063         [Content Extensions] Remove memory page reporting
2064         https://bugs.webkit.org/show_bug.cgi?id=146659
2065
2066         Reviewed by Benjamin Poulain.
2067
2068         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2069         (TestWebKitAPI::TEST_F):
2070
2071 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
2072
2073         [Content Extensions] Make the DFA transitions ranges instead of characters
2074         https://bugs.webkit.org/show_bug.cgi?id=146575
2075
2076         Reviewed by Alex Christensen.
2077
2078         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2079         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2080         Since the minimizer is perfect, we get the minimal solution now,
2081         which is really cool!
2082
2083 2015-07-06  Brady Eidson  <beidson@apple.com>
2084
2085         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
2086         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
2087
2088         Reviewed by Geoff Garen.
2089
2090         * WebKitTestRunner/TestInvocation.cpp:
2091         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
2092           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
2093
2094 2015-07-06  Daniel Bates  <dabates@apple.com>
2095
2096         Unreviewed, rolling out r170639.
2097
2098         Broke using webkit-patch apply-attachment to apply an
2099         attachment from a security bug. The patch incorrectly assumed
2100         that Bugzilla returns a non-HTTP 200 status code in its HTTP
2101         response when authentication is required.
2102
2103         Reverted changeset:
2104
2105         "webkit-patch apply-from-bug / apply-attachment should not ask
2106         for credentials if none are required"
2107         https://bugs.webkit.org/show_bug.cgi?id=40095
2108         http://trac.webkit.org/changeset/170639
2109
2110 2015-07-04  Chris Dumez  <cdumez@apple.com>
2111
2112         Drop RefPtr::clear() method
2113         https://bugs.webkit.org/show_bug.cgi?id=146556
2114
2115         Reviewed by Brady Eidson.
2116
2117         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
2118
2119 2015-07-03  Dan Bernstein  <mitz@apple.com>
2120
2121         Fixed the iOS build.
2122
2123         * DumpRenderTree/mac/EventSendingController.mm:
2124         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2125         (+[EventSendingController webScriptNameForSelector:]):
2126
2127 2015-07-03  Dan Bernstein  <mitz@apple.com>
2128
2129         [Xcode] Update some build settings as recommended by Xcode 7
2130         https://bugs.webkit.org/show_bug.cgi?id=146597
2131
2132         Reviewed by Sam Weinig.
2133
2134         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2135
2136         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
2137         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2138         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2139         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
2140         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
2141
2142         * DumpRenderTree/mac/EventSendingController.mm:
2143         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
2144         which was removed in r19101.
2145
2146         * DumpRenderTree/mac/TextInputController.m:
2147         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
2148         around used of a selector not that is not declared anywhere.
2149
2150         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
2151
2152         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2153
2154         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
2155         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2156         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2157         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
2158         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
2159
2160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2161
2162 2015-07-02  Daniel Bates  <dabates@apple.com>
2163
2164         [iOS] Add WebKitSystemInterface for iOS 8.4
2165         https://bugs.webkit.org/show_bug.cgi?id=146548
2166
2167         Rubber-stamped by Zalan Bujtas.
2168
2169         * Scripts/copy-webkitlibraries-to-product-directory:
2170
2171 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2172
2173         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
2174         https://bugs.webkit.org/show_bug.cgi?id=146234
2175
2176         Reviewed by Sergio Villar Senin.
2177
2178         Enable the WebSQL directory test that was disabled because of this bug.
2179
2180         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2181         (testWebContextConfiguration):
2182
2183 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
2184
2185         Enabled MEDIA_STREAM flag
2186         https://bugs.webkit.org/show_bug.cgi?id=145947
2187         <rdar://problem/21365829>
2188         
2189         Reviewed by Eric Carlson.
2190
2191         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2192
2193 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
2194
2195         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
2196         https://bugs.webkit.org/show_bug.cgi?id=144828
2197
2198         Reviewed by Carlos Garcia Campos.
2199
2200         * WebKitTestRunner/gtk/main.cpp:
2201         (main): Use the new WKTextChecker API to set the spell checking languages
2202         when the process is starting up.
2203
2204 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
2205
2206         Implement ECMAScript Internationalization API
2207         https://bugs.webkit.org/show_bug.cgi?id=90906
2208
2209         Reviewed by Benjamin Poulain.
2210
2211         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
2212
2213 2015-06-30  Jonathan Davis  <jond@apple.com>
2214
2215         Unreviewed. Added myself as a committer.
2216
2217         * Scripts/webkitpy/common/config/contributors.json:
2218
2219 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
2220
2221         Unreviewed build fix.
2222
2223         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
2224         to developer.apple.com to get update libraries.
2225
2226 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
2227
2228         Add timeout in run-webkit-tests for launching the simulator
2229         https://bugs.webkit.org/show_bug.cgi?id=146371
2230
2231         Reviewed by Darin Adler.
2232
2233         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
2234         for the otherwise infinitely patient wait_until_device_is_in_state method.
2235
2236         * Scripts/webkitpy/xcode/simulator.py:
2237         (Simulator.DeviceState):
2238         (Simulator):
2239         (Simulator.wait_until_device_is_in_state):
2240         (Simulator.device_state):
2241
2242 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
2243
2244         Make the NFA transitions range-based
2245         https://bugs.webkit.org/show_bug.cgi?id=146338
2246
2247         Reviewed by Alex Christensen.
2248
2249         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2250         Test some new interesting cases.
2251
2252 2015-06-28  Dan Bernstein  <mitz@apple.com>
2253
2254         [Xcode] Use the same environment for command-line and IDE builds
2255         https://bugs.webkit.org/show_bug.cgi?id=146401
2256
2257         Reviewed by Anders Carlsson.
2258
2259         * Scripts/webkitdirs.pm:
2260         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
2261         xcodebuild use the same environment Xcode uses.
2262
2263 2015-06-28  Dan Bernstein  <mitz@apple.com>
2264
2265         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
2266         https://bugs.webkit.org/show_bug.cgi?id=146396
2267
2268         Reviewed by Anders Carlsson.
2269
2270         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2271         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
2272         (TestWebKitAPI::TEST): Updated for renames.
2273         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2274         (runJavaScriptAlert): Removed suffix.
2275         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
2276         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2277         (runJavaScriptAlert): Removed suffix.
2278         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
2279
2280 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2281
2282         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
2283         https://bugs.webkit.org/show_bug.cgi?id=146318
2284
2285         Reviewed by Sergio Villar Senin.
2286
2287         Copy mac PublicSuffix test to the common directory and add it to
2288         the GTK+ build.
2289
2290         * TestWebKitAPI/PlatformGTK.cmake:
2291         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
2292         (TestWebKitAPI::TEST_F):
2293
2294 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
2295
2296         WinLauncher fails to download files.
2297         https://bugs.webkit.org/show_bug.cgi?id=146242
2298
2299         Reviewed by Alex Christensen.
2300
2301         Added WinLauncher download delegate.
2302
2303         * WinLauncher/Common.cpp:
2304         * WinLauncher/WebDownloadDelegate.cpp: Added.
2305         (WebDownloadDelegate::WebDownloadDelegate):
2306         (WebDownloadDelegate::~WebDownloadDelegate):
2307         (WebDownloadDelegate::QueryInterface):
2308         (WebDownloadDelegate::AddRef):
2309         (WebDownloadDelegate::Release):
2310         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
2311         (WebDownloadDelegate::didCancelAuthenticationChallenge):
2312         (WebDownloadDelegate::didCreateDestination):
2313         (WebDownloadDelegate::didFailWithError):
2314         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
2315         (WebDownloadDelegate::didReceiveDataOfLength):
2316         (WebDownloadDelegate::didReceiveResponse):
2317         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
2318         (WebDownloadDelegate::willResumeWithResponse):
2319         (WebDownloadDelegate::willSendRequest):
2320         (WebDownloadDelegate::didBegin):
2321         (WebDownloadDelegate::didFinish):
2322         * WinLauncher/WebDownloadDelegate.h: Added.
2323         * WinLauncher/WinLauncher.cpp:
2324         (WinLauncher::setAccessibilityDelegate):
2325         (WinLauncher::setResourceLoadDelegate):
2326         (WinLauncher::setDownloadDelegate):
2327         (WinLauncher::mainFrame):
2328         * WinLauncher/WinLauncher.h:
2329         (WinLauncher::standardPreferences):
2330         (WinLauncher::privatePreferences):
2331         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2332         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2333         * WinLauncher/WinMain.cpp:
2334         (wWinMain):
2335
2336 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
2337
2338         [EFL] Bump libseccomp version to 2.2.1
2339         https://bugs.webkit.org/show_bug.cgi?id=146341
2340
2341         Reviewed by Gyuyoung Kim.
2342
2343         * efl/jhbuild.modules:
2344         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
2345         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
2346
2347 2015-06-25  Alex Christensen  <achristensen@webkit.org>
2348
2349         [Content Extensions] Add a way to match a domain but not subdomains
2350         https://bugs.webkit.org/show_bug.cgi?id=146241
2351         rdar://problem/21557754
2352
2353         Reviewed by Darin Adler.
2354
2355         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2356         (TestWebKitAPI::TEST_F):
2357         Update subdomain test because of changed behavior and add test for new '*' functionality.
2358
2359 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
2360
2361         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
2362         https://bugs.webkit.org/show_bug.cgi?id=146308
2363
2364         Reviewed by Csaba Osztrogonác.
2365
2366         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
2367
2368         * Scripts/webkitperl/FeatureList.pm:
2369
2370 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2371
2372         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
2373         https://bugs.webkit.org/show_bug.cgi?id=146149
2374
2375         Reviewed by Sergio Villar Senin.
2376
2377         Update unit tests to use WebKitWebsiteDataManager.
2378
2379         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2380         (testWebContextConfiguration):
2381         (serverCallback):
2382         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2383         (Test::Test): Use WebKitWebsiteDataManager and set all possible
2384         values to ensure unit tests don't write outside the temporary directory.
2385         (Test::~Test): Explicitly reset the web context to ensure its
2386         objects are released before the leaks check.
2387         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2388         (WebViewTest::wait): Fix the GSource used, since we are receiving
2389         a double in seconds, but using g_timeout_add_seconds() that
2390         expects an unsigned in seconds. Use GMainLoopSource to correctly
2391         handle the value and simplify the code.
2392
2393 2015-06-24  Jason Marcell  <jmarcell@apple.com>
2394
2395         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
2396         https://bugs.webkit.org/show_bug.cgi?id=146126
2397         <rdar://problem/18226291>
2398
2399         Reviewed by Alexey Proskuryakov.
2400
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2402         (documentReady): Using combined queues to display iOS projects
2403
2404 2015-06-24  Doug Russell  <d_russell@apple.com>
2405
2406         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
2407         when posting a selection notification when on the border between two accessibilityObjects
2408         https://bugs.webkit.org/show_bug.cgi?id=146177
2409
2410         Reviewed by Darin Adler.
2411
2412         Add support for mapping WebCore Accessibility types into JSValueRef types
2413         so they can be used in tests.
2414
2415         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2416         (webAccessibilityObjectWrapperClass):
2417         (-[AccessibilityNotificationHandler startObserving]):
2418         (makeValueRefForValue):
2419         (makeArrayRefForArray):
2420         (makeObjectRefForDictionary):
2421         (-[AccessibilityNotificationHandler _notificationReceived:]):
2422         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2423         (webAccessibilityObjectWrapperClass):
2424         (-[AccessibilityNotificationHandler startObserving]):
2425         (makeValueRefForValue):
2426         (makeArrayRefForArray):
2427         (makeObjectRefForDictionary):
2428         (-[AccessibilityNotificationHandler _notificationReceived:]):
2429
2430 2015-06-24  Zalan Bujtas  <zalan@apple.com>
2431
2432         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
2433         https://bugs.webkit.org/show_bug.cgi?id=146273
2434         rdar://problem/18509840
2435
2436         Reviewed by Simon Fraser.
2437
2438         Due to the floating point approximate representation, we can't always produce
2439         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
2440         and by changing the rounding in roundToDevicePixel() from float to double.
2441
2442         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2443         (TestWebKitAPI::TEST):
2444
2445 2015-06-24  Brady Eidson  <beidson@apple.com>
2446
2447         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
2448         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
2449
2450         Reviewed by Alex Christensen.
2451
2452         - Update WKTR to the new client structure.
2453         - Update existing TestWebKitAPI tests to either use the new client structure or
2454           assign the old function signature to the updated variable name.
2455         - Include a new test.
2456
2457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2458
2459         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2460         (TestWebKitAPI::runJavaScriptAlert):
2461
2462         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2463         (TestWebKitAPI::TEST):
2464
2465         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2466         (TestWebKitAPI::analyzeDialogArguments):
2467         (TestWebKitAPI::runJavaScriptAlert):
2468         (TestWebKitAPI::runJavaScriptConfirm):
2469         (TestWebKitAPI::runJavaScriptPrompt):
2470         (TestWebKitAPI::createNewPage):
2471         (TestWebKitAPI::TEST):
2472
2473         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2474         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2475
2476         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2477         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2478
2479         * WebKitTestRunner/TestController.cpp:
2480         (WTR::TestController::createOtherPage):
2481         (WTR::TestController::createWebViewWithOptions):
2482
2483 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
2484
2485         Refactoring benchmark runner script to follow pep8 code style.
2486         https://bugs.webkit.org/show_bug.cgi?id=146264
2487
2488         Reviewed by Ryosuke Niwa.
2489
2490         Refactor benchmark runner script to follow pep8 code style.
2491
2492         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2493         (GenericBenchmarkBuilder.prepare):
2494         (GenericBenchmarkBuilder._run_create_script):
2495         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
2496         (GenericBenchmarkBuilder._fetch_remote_archive):
2497         (GenericBenchmarkBuilder):
2498         (GenericBenchmarkBuilder._checkout_with_subversion):
2499         (GenericBenchmarkBuilder._apply_patch):
2500         (GenericBenchmarkBuilder.clean):
2501         (GenericBenchmarkBuilder._runCreateScript): Deleted.
2502         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
2503         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
2504         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
2505         (GenericBenchmarkBuilder._applyPatch): Deleted.
2506         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2507         (BenchmarkRunner.__init__):
2508         (BenchmarkRunner._find_plan_file):
2509         (BenchmarkRunner.execute):
2510         (BenchmarkRunner._cleanup):
2511         (BenchmarkRunner._dump):
2512         (BenchmarkRunner._wrap):
2513         (BenchmarkRunner._merge):
2514         (BenchmarkRunner._show_results):
2515         (BenchmarkRunner._findPlanFile): Deleted.
2516         (BenchmarkRunner.cleanup): Deleted.
2517         (BenchmarkRunner.dump): Deleted.
2518         (BenchmarkRunner.wrap): Deleted.
2519         (BenchmarkRunner.merge): Deleted.
2520         (BenchmarkRunner.show_results): Deleted.
2521         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2522         (BrowserDriver.prepare_env):
2523         (BrowserDriver.launch_url):
2524         (BrowserDriver.close_browsers):
2525         (BrowserDriver.prepareEnv): Deleted.
2526         (BrowserDriver.launchUrl): Deleted.
2527         (BrowserDriver.closeBrowser): Deleted.
2528         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2529         (OSXBrowserDriver):
2530         (OSXBrowserDriver.prepare_env):
2531         (OSXBrowserDriver.close_browsers):
2532         (OSXBrowserDriver._launch_process):
2533         (OSXBrowserDriver._terminiate_processes):
2534         (OSXBrowserDriver._launch_process_with_caffinate):
2535         (OSXBrowserDriver._screen_size):
2536         (OSXBrowserDriver.prepareEnv): Deleted.
2537         (OSXBrowserDriver.closeBrowsers): Deleted.
2538         (OSXBrowserDriver.launchProcess): Deleted.
2539         (OSXBrowserDriver.terminateProcesses): Deleted.
2540         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
2541         (OSXBrowserDriver.screenSize): Deleted.
2542         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2543         (OSXChromeDriver):
2544         (OSXChromeDriver.launch_url):
2545         (OSXChromeCanaryDriver):
2546         (OSXChromeCanaryDriver.launch_url):
2547         (OSXChromeDriver.launchUrl): Deleted.
2548         (OSXChromeCanaryDriver.launchUrl): Deleted.
2549         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2550         (OSXFirefoxDriver):
2551         (OSXFirefoxDriver.launch_url):
2552         (OSXFirefoxNightlyDriver):
2553         (OSXFirefoxNightlyDriver.launch_url):
2554         (OSXFirefoxDriver.launchUrl): Deleted.
2555         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
2556         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2557         (OSXSafariDriver):
2558         (OSXSafariDriver.prepare_env):
2559         (OSXSafariDriver.launch_url):
2560         (OSXSafariDriver.close_browsers):
2561         (OSXSafariDriver._maximize_window):
2562         (OSXSafariDriver.prepareEnv): Deleted.
2563         (OSXSafariDriver.launchUrl): Deleted.
2564         (OSXSafariDriver.closeBrowsers): Deleted.
2565         (OSXSafariDriver.maximizeWindow): Deleted.
2566         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2567         (HTTPServerDriver.fetch_result):
2568         (HTTPServerDriver.kill_server):
2569         (HTTPServerDriver.get_return_code):
2570         (HTTPServerDriver.set_device_id):
2571         (HTTPServerDriver.fetchResult): Deleted.
2572         (HTTPServerDriver.killServer): Deleted.
2573         (HTTPServerDriver.getReturnCode): Deleted.
2574         (HTTPServerDriver.setDeviceID): Deleted.
2575         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2576         (SimpleHTTPServerDriver.serve):
2577         (SimpleHTTPServerDriver.base_url):
2578         (SimpleHTTPServerDriver.fetch_result):
2579         (SimpleHTTPServerDriver.kill_server):
2580         (SimpleHTTPServerDriver.get_return_code):
2581         (SimpleHTTPServerDriver): Deleted.
2582         (SimpleHTTPServerDriver.baseUrl): Deleted.
2583         (SimpleHTTPServerDriver.fetchResult): Deleted.
2584         (SimpleHTTPServerDriver.killServer): Deleted.
2585         (SimpleHTTPServerDriver.getReturnCode): Deleted.
2586         * Scripts/webkitpy/benchmark_runner/utils.py:
2587         (get_path_from_project_root):
2588         (force_remove):
2589         (getPathFromProjectRoot): Deleted.
2590         (forceRemove): Deleted.
2591
2592 2015-06-23  Anders Carlsson  <andersca@apple.com>
2593
2594         Add operator! and copy/move constructors to WeakObjCPtr
2595         https://bugs.webkit.org/show_bug.cgi?id=146255
2596
2597         Reviewed by Andreas Kling.
2598
2599         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
2600         (TEST):
2601
2602 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
2603
2604         Expose some more rendering progress events, and have MiniBrowser log for each of them
2605         https://bugs.webkit.org/show_bug.cgi?id=146227
2606
2607         Reviewed by Darin Adler.
2608
2609         Register for layout milestones/rendering progress events in the WK1 and WK2
2610         browser window controllers, and, if logging is turned on, log when they are
2611         reached.
2612
2613         * MiniBrowser/mac/WK1BrowserWindowController.m:
2614         (-[WK1BrowserWindowController awakeFromNib]):
2615         (-[WK1BrowserWindowController webView:didLayout:]):
2616         * MiniBrowser/mac/WK2BrowserWindowController.m:
2617         (-[WK2BrowserWindowController awakeFromNib]):
2618         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
2619
2620 2015-06-23  Brady Eidson  <beidson@apple.com>
2621
2622         WKFrameInfo should have an accessor for the Frame's current security origin.
2623         https://bugs.webkit.org/show_bug.cgi?id=146162
2624
2625         Reviewed by Dan Bernstein.
2626
2627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2628         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
2629         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
2630         (sawDialog):
2631         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2632         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2633         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2634         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2635         (TEST):
2636
2637 2015-06-23  Tanay C  <tanay.c@samsung.com>
2638
2639         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
2640         https://bugs.webkit.org/show_bug.cgi?id=146007
2641
2642         Reviewed by Darin Adler.
2643
2644         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2645         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
2646         (pluginLogWithWindowObject):
2647         (pluginLogWithArguments):
2648         (pluginLog):
2649         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
2650         (PluginTest::executeScript):
2651         (PluginTest::log):
2652
2653 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
2654
2655         [EFL] Add libhyphen-dev as dependency after r185862
2656         https://bugs.webkit.org/show_bug.cgi?id=146230
2657
2658         Reviewed by Gyuyoung Kim.
2659
2660         * efl/install-dependencies:
2661
2662 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
2663
2664         [EFL] Hyphenation is not supported
2665         https://bugs.webkit.org/show_bug.cgi?id=89830
2666
2667         Reviewed by Gyuyoung Kim.
2668
2669         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
2670
2671 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
2672
2673         Get rid of factory json files in benchmark_runner
2674         https://bugs.webkit.org/show_bug.cgi?id=146175
2675
2676         Reviewed by Ryosuke Niwa.
2677
2678         Get rid of factory json files in benchmark_runner and refactoring the code.
2679
2680         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
2681         (benchmark_builder_loader):
2682         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
2683         (BenchmarkBuilderFactory):
2684         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
2685         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2686         (GenericBenchmarkBuilder):
2687         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2688         (BenchmarkRunner.__init__):
2689         (BenchmarkRunner.execute):
2690         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
2691         (browser_driver_loader):
2692         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2693         (BrowserDriver):
2694         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2695         (BrowserDriverFactory):
2696         (BrowserDriverFactory.available_platforms):
2697         (BrowserDriverFactory.available_browsers):
2698         (BrowserDriverFactory.add_browser_driver):
2699         (BrowserDriverFactory.create):
2700         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
2701         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2702         (OSXBrowserDriver):
2703         (OSXBrowserDriver.prepareEnv):
2704         (OSXBrowserDriver.terminateProcesses):
2705         (OSXBrowserDriver.screenSize):
2706         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2707         (OSXChromeDriver):
2708         (OSXChromeCanaryDriver):
2709         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2710         (OSXFirefoxDriver):
2711         (OSXFirefoxNightlyDriver):
2712         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2713         (OSXSafariDriver):
2714         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
2715         (GenericFactory.create):
2716         (GenericFactory.add):
2717         (GenericFactory.iterateGetItem): Deleted.
2718         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2719         (http_server_driver_loader):
2720         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2721         (HTTPServerDriver):
2722         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
2723         (HTTPServerDriverFactory):
2724         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
2725         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2726         (SimpleHTTPServerDriver):
2727         * Scripts/webkitpy/benchmark_runner/utils.py:
2728         (is_subclass):
2729         (load_subclasses):
2730         (ModuleNotFoundError): Deleted.
2731         (loadModule): Deleted.
2732         (loadJSONFromFile): Deleted.
2733
2734 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
2735
2736         Make it possible to enable incremental rendering suppression in MiniBrowser
2737         https://bugs.webkit.org/show_bug.cgi?id=146223
2738         
2739         Reviewed by Tim Horton.
2740
2741         Add a menu item to enable incremental rendering suppression to MiniBrowser.
2742         
2743         For WK1, this just toggles a pref, and takes effect immediately.
2744         
2745         For WK2, this is a WKConfiguration property, so only affects new web views.
2746         
2747         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
2748         logging on launch.
2749
2750         * MiniBrowser/mac/AppDelegate.m:
2751         (defaultConfiguration):
2752         * MiniBrowser/mac/BrowserWindow.xib:
2753         * MiniBrowser/mac/SettingsController.h:
2754         * MiniBrowser/mac/SettingsController.m:
2755         (-[SettingsController _populateMenu]):
2756         (-[SettingsController validateMenuItem:]):
2757         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
2758         (-[SettingsController incrementalRenderingSuppressed]):
2759         * MiniBrowser/mac/WK1BrowserWindowController.m:
2760         (-[WK1BrowserWindowController didChangeSettings]):
2761
2762 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
2763
2764         Run CDjs as part of JSC stress testing
2765         https://bugs.webkit.org/show_bug.cgi?id=146174
2766
2767         Reviewed by Geoffrey Garen.
2768
2769         * Scripts/run-javascriptcore-tests:
2770         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
2771         * Scripts/run-jsc-stress-tests:
2772         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
2773         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
2774         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
2775
2776 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
2777
2778         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
2779         https://bugs.webkit.org/show_bug.cgi?id=146121
2780         rdar://problem/21395180
2781
2782         Reviewed by Darin Adler.
2783
2784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2785         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
2786         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
2787         (TestWebKitAPI::overrideAppleLanguages):
2788         (TestWebKitAPI::languageForSystemLanguage):
2789         (TestWebKitAPI::TEST):
2790
2791 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2792
2793         [CMake] Ignore warnings from system headers when compiling Tools
2794         https://bugs.webkit.org/show_bug.cgi?id=146185
2795
2796         Reviewed by Martin Robinson.
2797
2798         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
2799         from system headers that we don't control.
2800
2801         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2802         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
2803         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
2804         * ImageDiff/PlatformGTK.cmake:
2805         * MiniBrowser/efl/CMakeLists.txt:
2806         * MiniBrowser/gtk/CMakeLists.txt:
2807         * TestWebKitAPI/PlatformEfl.cmake:
2808         * TestWebKitAPI/PlatformGTK.cmake:
2809         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2810         * WebKitTestRunner/CMakeLists.txt:
2811         * WebKitTestRunner/PlatformEfl.cmake:
2812         * WebKitTestRunner/PlatformGTK.cmake:
2813
2814 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2815
2816         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
2817         https://bugs.webkit.org/show_bug.cgi?id=146186
2818
2819         Reviewed by Martin Robinson.
2820
2821         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
2822         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
2823
2824         * MiniBrowser/gtk/CMakeLists.txt:
2825
2826 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
2827
2828         Build fix after r146125.
2829
2830         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2831         (OSXSafariDriver):
2832         (OSXSafariDriver.prepareEnv):
2833
2834 2015-06-19  Brady Eidson  <beidson@apple.com>
2835
2836         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
2837         https://bugs.webkit.org/show_bug.cgi?id=146152
2838
2839         Reviewed by Dan Bernstein.
2840
2841         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2842         * WebKitTestRunner/WebNotificationProvider.cpp:
2843
2844 2015-06-19  Mark Lam  <mark.lam@apple.com>
2845
2846         CheckedArithmetic's operator bool() and operator==() is broken.
2847         https://bugs.webkit.org/show_bug.cgi?id=146129
2848
2849         Reviewed by Geoffrey Garen and Oliver Hunt.
2850
2851         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
2852         and overflow scenarios in usage of the Checked arithmetic class.
2853
2854         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2855         (TestWebKitAPI::OverflowCrashLogger::overflowed):
2856         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
2857         (TestWebKitAPI::OverflowCrashLogger::crash):
2858         (TestWebKitAPI::OverflowCrashLogger::reset):
2859         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
2860         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
2861         (TestWebKitAPI::OverflowCrashLogger::didCrash):
2862         - crash logger for verifying that a crash occurs when expected. 
2863
2864         (TestWebKitAPI::resetOverflow):
2865         - convenience function for resetting a test value to an initial overflowed state
2866           before a crash.  We will use this value in the overflow testing.
2867
2868         (TestWebKitAPI::CheckedArithmeticTester::run):
2869         - Added new tests for all the comparison operators.
2870
2871 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
2872
2873         Fix the Windows build after r185721
2874         https://bugs.webkit.org/show_bug.cgi?id=146146
2875
2876         Reviewed by Csaba Osztrogonác.
2877
2878         Speculative buildfix.
2879
2880         * DumpRenderTree/win/UIDelegate.h:
2881         (UIDelegate::unused4): Added.
2882         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
2883
2884 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
2885
2886         Unreviewed. Add myself as a committer.
2887
2888         * Scripts/webkitpy/common/config/contributors.json:
2889
2890 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         Remove unnecessary svn:executable flags
2893         https://bugs.webkit.org/show_bug.cgi?id=146107
2894
2895         Reviewed by Alexey Proskuryakov.
2896
2897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
2898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
2899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
2902         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
2903         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
2904         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
2905         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
2906         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
2907         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
2908         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
2909         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
2910         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
2911
2912 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
2913
2914         Disable tests on the WinCairo buildbot
2915         https://bugs.webkit.org/show_bug.cgi?id=146106
2916
2917         Reviewed by Alexey Proskuryakov.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/config.json:
2920         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2921
2922 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
2923
2924         [EFL] Fix the minibrowser after r185725
2925         https://bugs.webkit.org/show_bug.cgi?id=146135
2926
2927         Reviewed by Gyuyoung Kim.
2928
2929         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
2930         for the elm_config_accel_preference_set() to set the config of acceleration preference.
2931
2932         * MiniBrowser/efl/main.c:
2933         (elm_main): Deleted the HAVE_ECORE_X guard.
2934
2935 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
2936
2937         Extend capability of run-benchmark script to support mobile device
2938         https://bugs.webkit.org/show_bug.cgi?id=146125
2939
2940         Reviewed by Ryosuke Niwa.
2941
2942         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
2943         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
2944
2945         * Scripts/run-benchmark:
2946         (main): Deleted.
2947         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2948         (BenchmarkRunner.__init__):
2949         (BenchmarkRunner.execute):
2950         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2951         (BrowserDriver.prepareEnv):
2952         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2953         (OSXBrowserDriver.prepareEnv):
2954         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2955         (OSXSafariDriver.prepareEnv):
2956         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2957         (HTTPServerDriver.getReturnCode):
2958         (HTTPServerDriver):
2959         (HTTPServerDriver.setDeviceID):
2960         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
2961         (parse_args):
2962         (start):
2963         (main):
2964         * Scripts/webkitpy/benchmark_runner/utils.py:
2965         (getPathFromProjectRoot):
2966
2967 2015-06-18  Jon Lee  <jonlee@apple.com>
2968
2969         Unreviewed. Add Matt Daiter as a contributor.
2970
2971         * Scripts/webkitpy/common/config/contributors.json:
2972
2973 2015-06-18  Mark Lam  <mark.lam@apple.com>
2974
2975         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
2976         https://bugs.webkit.org/show_bug.cgi?id=146103
2977
2978         Not reviewed.
2979
2980         Follow up to fix some typos not caught before original patch was landed.
2981
2982         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2983         (TestWebKitAPI::CheckedArithmeticTester::run):
2984         (TestWebKitAPI::AllowMixedSignednessTest::run):
2985         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
2986
2987 2015-06-18  Daniel Bates  <dabates@apple.com>
2988
2989         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
2990         https://bugs.webkit.org/show_bug.cgi?id=146082
2991
2992         Reviewed by Darin Adler.
2993
2994         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
2995         working directory after being invoked in a different Git checkout. In particular,
2996         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
2997         a pure Git checkout g will fail to update g.
2998
2999         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
3000         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
3001         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
3002         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
3003         different than the current working directory). Instead runGitUpdate() should check
3004         whether the current working directory is a Git SVN checkout on each invocation.
3005
3006         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
3007         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
3008         SVN directory from isGitSVN().
3009         (isGitSVN): Implemented in terms of isGitSVNDirectory().
3010         * Scripts/webkitdirs.pm:
3011         (runGitUpdate): Modified to use isGitSVNDirectory().
3012
3013 2015-06-18  Mark Lam  <mark.lam@apple.com>
3014
3015         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
3016         https://bugs.webkit.org/show_bug.cgi?id=146103
3017
3018         Reviewed by Anders Carlsson.
3019
3020         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
3021         part of a large macro.  This makes them harder to:
3022
3023         1. write: no editor help with indentations, have to add trailing '\'s,
3024            inconvenient to add line breaks and comments.
3025
3026         2. read: no chroma coding / syntax highlighting.
3027
3028         3. debug: compile time errors are reported as being on the single line where
3029            the macro is used.
3030
3031         Refactoring the tests to use C++ templates solves all these issues.
3032
3033         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3034         (TestWebKitAPI::CheckedArithmeticTester::run):
3035         (TestWebKitAPI::AllowMixedSignednessTest::run):
3036         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
3037         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
3038         (TestWebKitAPI::CoerceLiteralNop::coerce):
3039
3040 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3041
3042         [EFL][WK2] Use Web Browser cache model in MiniBrowser
3043         https://bugs.webkit.org/show_bug.cgi?id=112273
3044
3045         Reviewed by Laszlo Gombos.
3046
3047         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
3048         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
3049         This way we have a decent cache capacity and the page cache actually works.
3050
3051         * MiniBrowser/efl/main.c:
3052         (elm_main):
3053
3054 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3055
3056         Remove redundant Chromium bug keyword
3057         https://bugs.webkit.org/show_bug.cgi?id=146097
3058
3059         Reviewed by Csaba Osztrogonác.
3060
3061         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3062         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
3063         (TestExpectationLine._format_line): Deleted.
3064
3065 2015-06-17  Daniel Bates  <dabates@apple.com>
3066
3067         Client may receive began editing callback for already focused text field
3068         https://bugs.webkit.org/show_bug.cgi?id=146074
3069         <rdar://problem/21293562>
3070
3071         Reviewed by Darin Adler.
3072
3073         Add a unit test to ensure that a client receives exactly one began editing
3074         callback when a text field is newly focused. In particular, dispatching
3075         a DOM focus event at an already focused text field does not dispatch a
3076         began editing callback to the client.
3077
3078         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3079         (TestWebKitAPI::TEST_F):
3080
3081 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3082
3083         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
3084         https://bugs.webkit.org/show_bug.cgi?id=26481
3085
3086         Reviewed by Darin Adler.
3087
3088         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
3089
3090         * DumpRenderTree/win/TestRunnerWin.cpp:
3091         (TestRunner::dispatchPendingLoadRequests):
3092         (TestRunner::overridePreference):
3093
3094 2015-06-17  Alex Christensen  <achristensen@webkit.org>
3095
3096         [Content Extensions] Fail to parse invalid arrays
3097         https://bugs.webkit.org/show_bug.cgi?id=146079
3098         rdar://problem/21422649
3099
3100         Reviewed by Benjamin Poulain.
3101
3102         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3103         (TestWebKitAPI::TEST_F):
3104         Correct and add parsing tests with invalid arrays.
3105
3106 2015-06-17  Matt Rajca  <mrajca@apple.com>
3107
3108         Unreviewed. Added myself as a committer.
3109
3110         * Scripts/webkitpy/common/config/contributors.json:
3111
3112 2015-06-17  Daniel Bates  <dabates@apple.com>
3113
3114         Export VCSUtils::gitTreeDirectory()
3115         <rdar://problem/21248901>
3116
3117         Rubber-stamped by Alexey Proskuryakov.
3118
3119         * Scripts/VCSUtils.pm:
3120
3121 2015-06-17  Tim Horton  <timothy_horton@apple.com>
3122
3123         Safari tabs still have shrunken content after coming out of fullscreen
3124         https://bugs.webkit.org/show_bug.cgi?id=146037
3125         <rdar://problem/21105960>
3126
3127         Reviewed by Simon Fraser and Darin Adler.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
3131         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
3132         (TEST):
3133         Add a test that ensures that disabling scale-to-fit mode correctly updates
3134         the page's layout.
3135
3136 2015-06-17  Dan Bernstein  <mitz@apple.com>
3137
3138         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
3139         https://bugs.webkit.org/show_bug.cgi?id=145957
3140
3141         Reviewed by Darin Adler.
3142
3143         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3144         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
3145
3146 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
3147
3148         AX:  iOS accessibility tests are not running because we need WKTR support
3149         https://bugs.webkit.org/show_bug.cgi?id=145991
3150
3151         Reviewed by Daniel Bates.
3152
3153         Add support for WKTR iOS accessibility.
3154         Utilize the notification handling mechanisms that Mac already uses.
3155         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
3156
3157         * DumpRenderTree/AccessibilityUIElement.cpp:
3158         (stringForSelectionCallback):
3159         (getIdentifierCallback):
3160         (getTraitsCallback):
3161         (getElementTextPositionCallback):
3162         (getElementTextLengthCallback):
3163         (AccessibilityUIElement::getJSClass):
3164         (getIPhoneLabelCallback): Deleted.
3165         (getIPhoneHintCallback): Deleted.
3166         (getIPhoneValueCallback): Deleted.
3167         (getIPhoneIdentifierCallback): Deleted.
3168         (getIPhoneTraitsCallback): Deleted.
3169         (getIPhoneIsElementCallback): Deleted.
3170         (getIPhoneElementTextPositionCallback): Deleted.
3171         (getIPhoneElementTextLengthCallback): Deleted.
3172         * DumpRenderTree/AccessibilityUIElement.h:
3173         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3174         (AccessibilityUIElement::identifier):
3175         (AccessibilityUIElement::traits):
3176         (AccessibilityUIElement::elementTextPosition):
3177         (AccessibilityUIElement::elementTextLength):
3178         (AccessibilityUIElement::description):
3179         (AccessibilityUIElement::orientation):
3180         (AccessibilityUIElement::stringValue):
3181         (AccessibilityUIElement::language):
3182         (AccessibilityUIElement::helpText):
3183         (AccessibilityUIElement::intValue):
3184         (AccessibilityUIElement::isSelected):
3185         (AccessibilityUIElement::isExpanded):
3186         (AccessibilityUIElement::documentURI):
3187         (AccessibilityUIElement::addNotificationListener):
3188         (AccessibilityUIElement::removeNotificationListener):
3189         (AccessibilityUIElement::isFocusable):
3190         (AccessibilityUIElement::isIgnored):
3191         (AccessibilityUIElement::hasPopup):
3192         (AccessibilityUIElement::iphoneLabel): Deleted.
3193         (AccessibilityUIElement::iphoneHint): Deleted.
3194         (AccessibilityUIElement::iphoneValue): Deleted.
3195         (AccessibilityUIElement::iphoneIdentifier): Deleted.
3196         (AccessibilityUIElement::iphoneTraits): Deleted.
3197         (AccessibilityUIElement::iphoneIsElement): Deleted.
3198         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
3199         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
3200         (_accessibilityNotificationCallback): Deleted.
3201         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3202         (WTR::AccessibilityUIElement::isValid):
3203         (WTR::AccessibilityUIElement::identifier):
3204         (WTR::AccessibilityUIElement::traits):
3205         (WTR::AccessibilityUIElement::elementTextPosition):
3206         (WTR::AccessibilityUIElement::elementTextLength):
3207         (WTR::AccessibilityUIElement::stringForSelection):
3208         (WTR::AccessibilityUIElement::elementsForRange):
3209         (WTR::AccessibilityUIElement::increaseTextSelection):
3210         (WTR::AccessibilityUIElement::decreaseTextSelection):
3211         (WTR::AccessibilityUIElement::linkedElement):
3212         (WTR::AccessibilityUIElement::headerElementAtIndex):
3213         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3214         (WTR::AccessibilityUIElement::characterAtOffset):
3215         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3216         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3217         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3218         (WTR::findAccessibleObjectById):
3219         (WTR::AccessibilityController::accessibleElementById):
3220         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3221         (+[NSString stringWithJSStringRef:]):
3222         (-[NSString createJSStringRef]):
3223         (WTR::convertNSArrayToVector):
3224         (WTR::concatenateAttributeAndValue):
3225         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3226         (WTR::AccessibilityUIElement::isEqual):
3227         (WTR::AccessibilityUIElement::headerElementAtIndex):
3228         (WTR::AccessibilityUIElement::linkedElement):
3229         (WTR::AccessibilityUIElement::getLinkedUIElements):
3230         (WTR::AccessibilityUIElement::elementAtPoint):
3231         (WTR::convertElementsToObjectArray):
3232         (WTR::AccessibilityUIElement::elementsForRange):
3233         (WTR::AccessibilityUIElement::indexOfChild):
3234         (WTR::AccessibilityUIElement::stringAttributeValue):
3235         (WTR::AccessibilityUIElement::description):
3236         (WTR::AccessibilityUIElement::orientation):
3237         (WTR::AccessibilityUIElement::stringValue):
3238         (WTR::AccessibilityUIElement::language):
3239         (WTR::AccessibilityUIElement::helpText):
3240         (WTR::AccessibilityUIElement::x):
3241         (WTR::AccessibilityUIElement::clickPointX):
3242         (WTR::AccessibilityUIElement::clickPointY):
3243         (WTR::AccessibilityUIElement::intValue):
3244         (WTR::AccessibilityUIElement::minValue):
3245         (WTR::AccessibilityUIElement::maxValue):
3246         (WTR::AccessibilityUIElement::valueDescription):
3247         (WTR::AccessibilityUIElement::isSelected):
3248         (WTR::AccessibilityUIElement::isSelectedOptionActive):
3249         (WTR::AccessibilityUIElement::stringForRange):
3250         (WTR::AccessibilityUIElement::attributedStringForRange):
3251         (WTR::AccessibilityUIElement::attributesOfHeader):
3252         (WTR::AccessibilityUIElement::traits):
3253         (WTR::AccessibilityUIElement::identifier):
3254         (WTR::AccessibilityUIElement::rowCount):
3255         (WTR::AccessibilityUIElement::rowIndexRange):
3256         (WTR::AccessibilityUIElement::columnIndexRange):
3257         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3258         (WTR::AccessibilityUIElement::horizontalScrollbar):
3259         (WTR::AccessibilityUIElement::documentURI):
3260         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3261         (WTR::AccessibilityUIElement::increaseTextSelection):
3262         (WTR::AccessibilityUIElement::decreaseTextSelection):
3263         (WTR::AccessibilityUIElement::stringForSelection):
3264         (WTR::AccessibilityUIElement::elementTextPosition):
3265         (WTR::AccessibilityUIElement::elementTextLength):
3266         (WTR::AccessibilityUIElement::url):
3267         (WTR::AccessibilityUIElement::addNotificationListener):
3268         (WTR::AccessibilityUIElement::removeNotificationListener):
3269         (WTR::AccessibilityUIElement::isFocusable):
3270         (WTR::AccessibilityUIElement::isIgnored):
3271         (WTR::AccessibilityUIElement::hasPopup):
3272         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3273         (WTR::_CGPathEnumerationIteration):
3274         (WTR::AccessibilityUIElement::pathDescription):
3275         (WTR::AccessibilityUIElement::supportedActions):
3276
3277 2015-06-16  Mark Lam  <mark.lam@apple.com>
3278
3279         Use NakedPtr<Exception>& to return exception results.
3280         https://bugs.webkit.org/show_bug.cgi?id=145870
3281
3282         Reviewed by Anders Carlsson and Filip Pizlo.
3283
3284         * TestWebKitAPI/CMakeLists.txt:
3285         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3286         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3288         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
3289         (TestWebKitAPI::TEST):
3290         (TestWebKitAPI::nakedPtrFoo):
3291
3292 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
3293
3294         Unreviewed. Adding myself as a committer.
3295
3296         * Scripts/webkitpy/common/config/contributors.json:
3297
3298 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
3299
3300         Add test expectations for El Capitan
3301         https://bugs.webkit.org/show_bug.cgi?id=146005
3302
3303         Rubber-stamped by Dan Bernstein.
3304
3305         Add appropriate tools code.
3306
3307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
3308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
3309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3311         Added dashboard support.
3312
3313         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3314         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3315         Trigger the right build queues on check-in.
3316
3317         * Scripts/webkitpy/common/system/platforminfo.py:
3318         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3319         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3320         * Scripts/webkitpy/port/mac.py:
3321         * Scripts/webkitpy/port/mac_unittest.py:
3322         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3323         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3324         Added cases for El Capitan, and updated tests for new baseline search paths.
3325
3326 2015-06-15  Alex Christensen  <achristensen@webkit.org>
3327
3328         [Content Extensions] Make max NFA size and max rule count user defaults.
3329         https://bugs.webkit.org/show_bug.cgi?id=145663
3330
3331         Reviewed by Benjamin Poulain.
3332
3333         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3334         (TestWebKitAPI::TEST_F):
3335
3336 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
3337
3338         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
3339         https://bugs.webkit.org/show_bug.cgi?id=145900
3340
3341         Reviewed by Sam Weinig.
3342
3343         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3344         (TEST): Added tests.
3345
3346 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3347
3348         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
3349         https://bugs.webkit.org/show_bug.cgi?id=145969
3350
3351         Reviewed by Sergio Villar Senin.
3352
3353         Add a test case to the custom URI schemes unit test.
3354
3355         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3356         (testWebContextURIScheme):
3357
3358 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
3359
3360         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
3361         https://bugs.webkit.org/show_bug.cgi?id=145922
3362
3363         Reviewed by Carlos Garcia Campos.
3364
3365         * gtk/jhbuild.modules:
3366         * gtk/patches/glib-warning-fix.patch: Added.
3367
3368 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
3369
3370         Update springLoadingHighlight type
3371         https://bugs.webkit.org/show_bug.cgi?id=145939
3372         rdar://problem/20880213
3373
3374         Reviewed by Darin Adler.
3375
3376         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3377         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3378         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3379         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3380
3381 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
3382
3383         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
3384         https://bugs.webkit.org/show_bug.cgi?id=145945
3385
3386         Reviewed by Stephanie Lewis.
3387
3388         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3389         (OSXBrowserDriver.prepareEnv):
3390         (OSXBrowserDriver.moveCursor): Deleted.
3391         (OSXBrowserDriver): Deleted.
3392         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3393         (OSXSafariDriver.prepareEnv):
3394
3395 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
3396
3397         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
3398         https://bugs.webkit.org/show_bug.cgi?id=145938
3399
3400         Reviewed by Alexey Proskuryakov.
3401
3402         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
3403         LWP::UserAgent to get access to more robust HTTPS support.
3404
3405 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3406
3407         [GTK] Fix return type warning in WebViewTest.cpp
3408         https://bugs.webkit.org/show_bug.cgi?id=145914
3409
3410         Reviewed by Darin Adler.
3411
3412         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3413         (WebViewTest::isEditable):
3414
3415 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
3416
3417         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
3418         https://bugs.webkit.org/show_bug.cgi?id=145799
3419
3420         Reviewed by Carlos Garcia Campos.
3421
3422         Update header inclusions for headers that have been moved
3423         to Source/WTF/wtf/glib/.
3424
3425         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
3426         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
3427
3428         * TestWebKitAPI/PlatformGTK.cmake:
3429         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
3430         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3431         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3432         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3433         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3434         (TestWebKitAPI::GMainLoopSourceTest::finish):
3435         (TestWebKitAPI::GMainLoopSourceTest::source):
3436         (TestWebKitAPI::basicRescheduling):
3437         (TestWebKitAPI::TEST):
3438         (TestWebKitAPI::reentrantRescheduling):
3439         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3440         (TestWebKitAPI::basicDestroyCallbacks):
3441         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3442         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3443         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
3444         (log):
3445         (takeLogStr):
3446         (TestWebKitAPI::TEST):
3447         (TestWebKitAPI::returnOutChar):
3448         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3449         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3450         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
3451         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
3452         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
3453         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
3454         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
3455         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
3456         (TestWebKitAPI::basicRescheduling): Deleted.
3457         (TestWebKitAPI::TEST): Deleted.
3458         (TestWebKitAPI::reentrantRescheduling): Deleted.
3459         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
3460         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
3461         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
3462         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
3463         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
3464         (log): Deleted.
3465         (takeLogStr): Deleted.
3466         (TestWebKitAPI::TEST): Deleted.
3467         (TestWebKitAPI::returnOutChar): Deleted.
3468         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3469         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3470         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3471         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3472         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3473         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3474         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3475         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
3476         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3477         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3478         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3479         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3480         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3481         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
3482         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3483         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
3484         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3485         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3486         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3487         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3488         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3489         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3490         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3491         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3492         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3493         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3494         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3495         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3496         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
3497         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
3498         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
3499         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
3500         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3501         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3502         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3503         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3504         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3506         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3507         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3508         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3509         * WebKitTestRunner/PlatformGTK.cmake:
3510         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3511         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3512
3513 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3514
3515         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
3516         https://bugs.webkit.org/show_bug.cgi?id=145913
3517
3518         Reviewed by Gyuyoung Kim.
3519
3520         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3521         (TestWebKitAPI::setupGeolocationProvider):
3522         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3523         (TestWebKitAPI::setPageLoaderClient):
3524         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
3525         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3526         * WebKitTestRunner/GeolocationProviderMock.cpp:
3527         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3528         * WebKitTestRunner/WebNotificationProvider.cpp:
3529         (WTR::WebNotificationProvider::provider):
3530
3531 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3532
3533         Fix the libusrsctp build with clang
3534         https://bugs.webkit.org/show_bug.cgi?id=145128
3535
3536         Reviewed by Gyuyoung Kim.
3537
3538         * efl/jhbuild.modules:
3539         * gtk/jhbuild.modules:
3540
3541 2015-06-11  Mark Lam  <mark.lam@apple.com>
3542
3543         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
3544         https://bugs.webkit.org/show_bug.cgi?id=145872
3545
3546         Reviewed by Michael Saboff.
3547
3548         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3549         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3550         - Exercises the JSC ObjC API to call a function which throws an exception.  That
3551           exception will be returned as a JSValue instead of an Exception object.  We
3552           will use this JSValue to test WebCore::reportException() to confirm that it is
3553           able to handle an exception value which is not an Exception object.
3554
3555 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
3556
3557         Move cursor to corner and fix safari window size before running benchmark
3558         https://bugs.webkit.org/show_bug.cgi?id=145858
3559
3560         Reviewed by Ryosuke Niwa
3561
3562         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3563         (OSXBrowserDriver.prepareEnv):
3564         (OSXBrowserDriver):
3565         (OSXBrowserDriver.moveCursor):
3566         (OSXBrowserDriver.getScreenSize):
3567         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3568         (OSXChromeDriver.launchUrl):
3569         (OSXChromeCanaryDriver.launchUrl):
3570         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3571         (OSXFirefoxDriver.launchUrl):
3572         (OSXFirefoxNightlyDriver.launchUrl):
3573         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3574         (OSXSafariDriver.prepareEnv):
3575         (OSXSafariDriver):
3576         (OSXSafariDriver.maximizeWindow):
3577
3578 2015-06-11  Daniel Bates  <dabates@apple.com>
3579
3580         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
3581         https://bugs.webkit.org/show_bug.cgi?id=145319
3582
3583         Reviewed by David Kilzer.
3584
3585         Add SPI wrapper header for CoreSimulator and update the source files to reference
3586         it instead of directly referencing the CoreSimulator header.
3587
3588         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
3589         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
3590         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3591         * LayoutTestRelay/LayoutTestRelay/main.m:
3592
3593 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3594
3595         [EFL] dimmed area for popup does not cover the fullscreen mode.
3596         https://bugs.webkit.org/show_bug.cgi?id=145133
3597
3598         Reviewed by Gyuyoung Kim.
3599
3600         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
3601         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
3602
3603         * MiniBrowser/efl/main.c:
3604         (on_fullscreen_accept):
3605         (on_fullscreen_deny):
3606         (on_fullscreen_enter):
3607
3608 2015-06-10  Commit Queue  <commit-queue@webkit.org>
3609
3610         Unreviewed, rolling out r185442.
3611         https://bugs.webkit.org/show_bug.cgi?id=145871
3612
3613         seems to have broken WTF.StringOperators test (Requested by
3614         alexchristensen on #webkit).
3615
3616         Reverted changeset:
3617
3618         "[Content Extensions] Limit number of rules."
3619         https://bugs.webkit.org/show_bug.cgi?id=145663
3620         http://trac.webkit.org/changeset/185442
3621