Unreviewed.
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Unreviewed.
4
5         [Qt][WK2] Buildfix.
6
7         * MiniBrowser/qt/MiniBrowser.pro:
8
9 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
10
11         Reviewed by Adam Roben.
12         
13         define NOMINMAX when building ImageDiff, as we do elsewhere.
14
15         Add various clampToInt() methods to MathExtras.h
16         https://bugs.webkit.org/show_bug.cgi?id=52910
17
18         * DumpRenderTree/win/ImageDiffCommon.vsprops:
19
20 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
21
22         Reviewed by Darin Adler.
23
24         WebKitTestRunner needs layoutTestController.setPOSIXLocale
25         https://bugs.webkit.org/show_bug.cgi?id=42682
26
27         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
28         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
29         (WTR::InjectedBundle::resetLocalSettings):
30         (WTR::InjectedBundle::didReceiveMessage):
31         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
32         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
33         (WTR::LayoutTestController::setPOSIXLocale):
34         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
35
36 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
37  
38          Reviewed by Mihai Parparita.
39  
40          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
41  
42          This patch re-enables this test and changes it to
43          handle all of the mac platform versions, not just the one
44          it is running on.
45  
46          https://bugs.webkit.org/show_bug.cgi?id=53356
47  
48          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
49  
50 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
51
52         Unreviewed, build fix.
53
54         Take two. The fix in 77023 didn't work, because we were
55         still calling path.abspath_to_uri, which calls _cygpath under
56         the covers, and it appears the cygpath on the bots does
57         something different than it does on my machine. This patch
58         removes the calls to path.abspath_to_uri, so it should be safe.
59         If it doesn't work, I'll roll it out along with r76982 and 77023.
60
61         https://bugs.webkit.org/show_bug.cgi?id=53126
62
63         * Scripts/webkitpy/layout_tests/port/test.py:
64
65 2011-01-28  David Kilzer  <ddkilzer@apple.com>
66
67         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
68         <http://webkit.org/b/53353>
69
70         Reviewed by Mark Rowe.
71
72         * Scripts/webkitdirs.pm:
73         (checkRequiredSystemConfig): Check the Xcode marketing version
74         in addition to the DevCoreTools build version before complaining
75         about an old version of Xcode.  Also make the Mac OS X version
76         check use Perl's built-in version string comparitor.
77
78 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
79
80         Unreviewed, build fix.
81
82         Work around breakage on Win 7 Release bot caused by r76982
83         and the fact that windows ports use "file:////" instead of
84         "file:///". Ideally the test code should be isolated from
85         this, but it isn't yet. Will fix properly in a bit.
86
87         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
88
89 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
90
91         Reviewed by Tony Chang.
92
93         new-run-webkit-tests: change worker model values to
94         "old-inline", "old-threads" in preparation for test_runner2 /
95         multiprocessing changes.
96
97         https://bugs.webkit.org/show_bug.cgi?id=53156
98
99         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
100         * Scripts/webkitpy/layout_tests/port/base.py:
101         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
102         * Scripts/webkitpy/layout_tests/port/mac.py:
103         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
104
105 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
106
107         Reviewed by Tony Chang.
108
109         committers.py - add an IRC nickname for dpranke
110         https://bugs.webkit.org/show_bug.cgi?id=53335
111
112         * Scripts/webkitpy/common/config/committers.py:
113
114 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
115
116         Reviewed by Tony Chang.
117
118         new-run-webkit-tests: add a "mock DRT" port implementation
119         and a separate class that emulates what we expect the
120         DumpRenderTree behavior to be.
121
122         This will eventually replace port/dryrun.py and allow us to get
123         better test coverage of the new-run-webkit-tests code as well as
124         a reference for what new-run-webkit-tests expects from DRT.
125
126         This is the first attempt at this, and it is pretty bare-boned. It
127         really only has been tested on the 'mac' port (and a little on
128         the 'chromium-mac' port.
129
130         https://bugs.webkit.org/show_bug.cgi?id=53126
131
132         * Scripts/webkitpy/common/system/filesystem_mock.py:
133         * Scripts/webkitpy/layout_tests/port/dryrun.py:
134         * Scripts/webkitpy/layout_tests/port/factory.py:
135         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
136         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
137         * Scripts/webkitpy/layout_tests/port/test.py:
138
139 2011-01-28  Pratik Solanki  <psolanki@apple.com>
140
141         Unreviewed. Removing .swp file checked in by mistake.
142
143         * Scripts/.webkitdirs.pm.swp: Removed.
144
145 2011-01-28  Pratik Solanki  <psolanki@apple.com>
146
147         Reviewed by David Kilzer.
148
149         Space not necessary for undefined feature
150         https://bugs.webkit.org/show_bug.cgi?id=53317
151
152         * Scripts/build-webkit:
153
154 2011-01-28  Chang Shu  <chang.shu@nokia.com>
155
156         Reviewed by Andreas Kling.
157
158         Reset NetworkAccessManager to clean up credentials from previous tests.
159         This change causes no performance overhead either.
160         https://bugs.webkit.org/show_bug.cgi?id=36688
161
162         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
163         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
164         (WebCore::DumpRenderTree::open):
165         * DumpRenderTree/qt/DumpRenderTreeQt.h:
166
167 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
168
169         Reviewed by Andreas Kling.
170
171         [Qt] Add Zoom Text Only action to MiniBrowser
172         https://bugs.webkit.org/show_bug.cgi?id=53297
173
174         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
175
176         * MiniBrowser/qt/BrowserWindow.cpp:
177         (BrowserWindow::BrowserWindow):
178         (BrowserWindow::zoomIn):
179         (BrowserWindow::zoomOut):
180         (BrowserWindow::resetZoom):
181         (BrowserWindow::toggleZoomTextOnly):
182         (BrowserWindow::applyZoom):
183         * MiniBrowser/qt/BrowserWindow.h:
184
185 2011-01-28  Adam Barth  <abarth@webkit.org>
186
187         Reviewed by Eric Seidel.
188
189         Add webkit-patch roll-chromium-deps
190         https://bugs.webkit.org/show_bug.cgi?id=53288
191
192         This command updates the Source/WebKit/chromium/DEPS file with the
193         last-known good revision of Chromium (or a revision specified on the
194         command line).  I'd eventually like to turn this into a SheriffBot
195         command, but this is the first step.
196
197         This patch somewhat sprawled because I needed to move a bunch of code
198         out of ChangeLog that should never have been there in the first place.
199         Also, I had to fix a bug in MockUser in order to test the new command.
200
201         * Scripts/webkitpy/common/checkout/api.py:
202         * Scripts/webkitpy/common/checkout/changelog.py:
203         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
204         * Scripts/webkitpy/common/checkout/deps.py: Added.
205         * Scripts/webkitpy/common/config/urls.py:
206         * Scripts/webkitpy/tool/commands/__init__.py:
207         * Scripts/webkitpy/tool/commands/download_unittest.py:
208         * Scripts/webkitpy/tool/commands/roll.py: Added.
209         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
210         * Scripts/webkitpy/tool/commands/upload_unittest.py:
211         * Scripts/webkitpy/tool/mocktool.py:
212         * Scripts/webkitpy/tool/steps/__init__.py:
213         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
214         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
215         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
216         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
217         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
218         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
219
220 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
221
222         Reviewed by Laszlo Gombos.
223
224         Get rid of prefix header dependency for WebKit2 build system
225         https://bugs.webkit.org/show_bug.cgi?id=50174
226
227         Change the style checker so that it enforces config.h include for
228         WebKit2.
229
230         * Scripts/webkitpy/style/checker.py:
231
232 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
233
234         Reviewed by Darin Adler.
235
236         execCommand("Paste") doesn't work in WebKitTestRunner
237         https://bugs.webkit.org/show_bug.cgi?id=52785
238
239         Enable both of the settings needed to allow paste.
240         
241         * WebKitTestRunner/TestController.cpp:
242         (WTR::TestController::resetStateToConsistentValues):
243
244 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
245
246         Reviewed by Andreas Kling.
247
248         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
249         https://bugs.webkit.org/show_bug.cgi?id=48440
250
251         Preserve user input when toggling use of QGraphicsView
252
253         * QtTestBrowser/launcherwindow.cpp:
254         (LauncherWindow::initializeView):
255         (LauncherWindow::loadFinished):
256         * QtTestBrowser/launcherwindow.h:
257         * QtTestBrowser/mainwindow.cpp:
258         (MainWindow::addressUrl):
259         * QtTestBrowser/mainwindow.h:
260
261 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
262
263         Reviewed by Mihai Parparita.
264
265         new-run-webkit-tests: turn off pixel tests correctly by default
266         for webkit-based ports. r70013 (bug 47510) used
267         port.set_option_default() to attempt to set default values, but
268         that didn't work correctly. I have removed set_option_default
269         for now since it was only being used in two places and in three
270         useless unit tests. There is a separate bug open to fix the
271         option parsing (48095), so this workaround is fine for now.
272
273         https://bugs.webkit.org/show_bug.cgi?id=53217
274
275         * Scripts/webkitpy/layout_tests/port/webkit.py:
276         * Scripts/webkitpy/layout_tests/port/base.py:
277         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
278
279 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
280
281         Rubber-stamped by Ariya Hidayat.
282
283         Trivial crash fix in WTR.
284
285         * WebKitTestRunner/TestController.cpp:
286         (WTR::TestController::initialize): Increase the size
287         of the vector by one to be able to store the null character.
288
289 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
290
291         Reviewed by Csaba Osztrogonác.
292
293         [Qt][WK2] WTR should be initialized in the same way as DRT
294         https://bugs.webkit.org/show_bug.cgi?id=53240
295
296         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
297         (WTR::activateFonts): Added missing initialization steps.
298
299 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
300
301         Unreviewed. 
302
303         Adding myself to committers.py.
304
305         * Scripts/webkitpy/common/config/committers.py:
306
307 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
308
309         Reviewed by Csaba Osztrogonác.
310
311         [Qt] [Symbian] Move project files into Source
312         https://bugs.webkit.org/show_bug.cgi?id=52891
313
314         Fix the Symbian build after the project files
315         are moved to Source directory. On Symbian qmake
316         needs to run in the same directory where the main
317         pro files (WebKit.pro, Tools.pro) are located.
318
319         * Scripts/webkitdirs.pm: Change to the directory where the pro file
320         is located before running qmake for Symbian. Qmake on Symbian
321         does not properly honor the "-o" option, work it around by setting
322         the name of the Makefile to bld.inf.
323
324 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
325
326         Reviewed by Andreas Kling.
327
328         [Qt] Add simple zooming features to MiniBrowser
329         https://bugs.webkit.org/show_bug.cgi?id=53231
330
331         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
332
333         * MiniBrowser/qt/BrowserWindow.cpp:
334         (BrowserWindow::BrowserWindow):
335         (BrowserWindow::zoomIn):
336         (BrowserWindow::zoomOut):
337         (BrowserWindow::resetZoom):
338         (BrowserWindow::updateUserAgentList):
339         (BrowserWindow::applyZoom):
340         * MiniBrowser/qt/BrowserWindow.h:
341
342 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
343
344         Reviewed by Dan Bernstein.
345
346         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
347         https://bugs.webkit.org/show_bug.cgi?id=42319
348         
349         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
350
351         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
352         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
353         (WTR::LayoutTestController::showWebInspector):
354         (WTR::LayoutTestController::closeWebInspector):
355         (WTR::LayoutTestController::evaluateInWebInspector):
356         (WTR::LayoutTestController::setTimelineProfilingEnabled):
357         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
358         * WebKitTestRunner/TestInvocation.cpp:
359         (WTR::shouldOpenWebInspector):
360         (WTR::TestInvocation::invoke):
361         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
362
363 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
364
365         Reviewed by Xan Lopez.
366
367         [GTK] Pixel dumps do not include scrollbars in output images
368         https://bugs.webkit.org/show_bug.cgi?id=53216
369
370         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
371         that have scrollbars.
372
373         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
374         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
375         instead of the web view itself.
376
377 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
378
379         Reviewed by Mihai Parparita.
380
381         Fix regression introduced in r76322 ... new-run-webkit-tests
382         was attempting to save the image diff output as a UTF-8-encoded
383         file.
384
385         https://bugs.webkit.org/show_bug.cgi?id=53210
386
387         * Scripts/webkitpy/layout_tests/port/webkit.py:
388
389 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
390
391         Unreviewed, rolling out r76709.
392         http://trac.webkit.org/changeset/76709
393         https://bugs.webkit.org/show_bug.cgi?id=53194
394
395         "broke python tests on non-snowleopard platforms" (Requested
396         by dpranke on #webkit).
397
398         * Scripts/webkitpy/layout_tests/port/factory.py:
399         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
400         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
401
402 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
403
404         Reviewed by Tony Chang.
405
406         new-run-webkit-tests: add a "mock DRT" port implementation
407         and a separate class that emulates what we expect the
408         DumpRenderTree behavior to be.
409
410         This will eventually replace port/dryrun.py and allow us to get
411         better test coverage of the new-run-webkit-tests code as well as
412         a reference for what new-run-webkit-tests expects from DRT.
413
414         This is the first attempt at this, and it is pretty bare-boned. It
415         really only has been tested on the 'mac' port (and a little on
416         the 'chromium-mac' port.
417
418         https://bugs.webkit.org/show_bug.cgi?id=53126
419
420         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
421         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
422         * Scripts/webkitpy/layout_tests/port/factory.py:
423
424 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
425
426         Reviewed by Tony Chang.
427
428         Add '--no-timeout' option to Chromium DRT to ease debugging.
429         https://bugs.webkit.org/show_bug.cgi?id=52873
430
431         * DumpRenderTree/chromium/DumpRenderTree.cpp:
432         (main):
433
434 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
435
436         Reviewed by Andreas Kling.
437
438         [Qt] Fix qt_minimal build
439         https://bugs.webkit.org/show_bug.cgi?id=53172
440
441         * QtTestBrowser/locationedit.h:
442
443 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
444
445         Reviewed by Antonio Gomes.
446
447         QtTestBrowser should have a UI Setting to disable plugins
448         https://bugs.webkit.org/show_bug.cgi?id=52408
449         
450         Added a new action item named "Disable Plugins"
451         under the "Settings" menu. 
452
453         * QtTestBrowser/launcherwindow.cpp:
454         (LauncherWindow::createChrome):
455         (LauncherWindow::togglePlugins):
456         * QtTestBrowser/launcherwindow.h:
457
458 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
459
460         Reviewed by Adam Barth.
461
462         Move main CMakeLists.txt into Source directory
463         https://bugs.webkit.org/show_bug.cgi?id=52888
464
465         * Scripts/webkitdirs.pm:
466
467 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
468
469         Reviewed by Eric Seidel.
470
471         Improve label text in submit-to-ews
472         https://bugs.webkit.org/show_bug.cgi?id=53130
473
474         * QueueStatusServer/templates/submittoews.html:
475
476 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
477
478         Reviewed by Antonio Gomes.
479
480         QtTestBrowser should have a UI Settings to prevent loading images
481         https://bugs.webkit.org/show_bug.cgi?id=52409
482         
483         Added a new action item named "DisableAutoLoadImages"
484         under the "Settings" menu 
485
486         * QtTestBrowser/launcherwindow.cpp:
487         (LauncherWindow::createChrome):
488         (LauncherWindow::toggleAutoLoadImages):
489         * QtTestBrowser/launcherwindow.h:
490
491 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
492
493         Reviewed by Tony Chang.
494
495         Minor bug fixes and cleanup for filesystem wrappers, port/* test
496         classes, test_expectations.py. This change adds "test-win" and
497         "test-mac" variants to the test port so that we can better test
498         rebaselining, and adds a MockUser() object for reuse in testing.
499
500         https://bugs.webkit.org/show_bug.cgi?id=53036
501
502         * Scripts/webkitpy/common/system/filesystem.py:
503         * Scripts/webkitpy/common/system/filesystem_mock.py:
504         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
505         * Scripts/webkitpy/layout_tests/port/factory.py:
506         * Scripts/webkitpy/layout_tests/port/base.py:
507         * Scripts/webkitpy/layout_tests/port/test.py:
508         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
509         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
510         * Scripts/webkitpy/tool/mocktool.py:
511
512 2011-01-25  Tony Chang  <tony@chromium.org>
513
514         Reviewed by Dimitri Glazkov.
515
516         [chromium] remove unused layoutTestController callback
517         https://bugs.webkit.org/show_bug.cgi?id=53103
518
519         This method is used by a test_shell_test, but not needed by DRT.
520
521         * DumpRenderTree/chromium/LayoutTestController.cpp:
522         (LayoutTestController::LayoutTestController):
523         * DumpRenderTree/chromium/LayoutTestController.h:
524
525 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
526
527         Reviewed by Andreas Kling.
528
529         [GTK] Remove 64 bits release bot from the buildbot master
530         https://bugs.webkit.org/show_bug.cgi?id=52899
531
532         Removes the 64 bits release slave from the buildbot configuration,
533         so that we can use it as an EWS.
534
535         * BuildSlaveSupport/build.webkit.org-config/config.json:
536
537 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
538
539         Reviewed by Dan Bernstein.
540
541         Implement database quota callback to fix storage tests on WebKit2 bot
542         https://bugs.webkit.org/show_bug.cgi?id=53064
543
544         * WebKitTestRunner/TestController.cpp:
545         (WTR::exceededDatabaseQuota):
546         (WTR::TestController::createOtherPage):
547         (WTR::TestController::initialize):
548
549 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
550
551         Reviewed by Anders Carlsson.
552
553         Use designated temp directory for the database for WebKit2
554         https://bugs.webkit.org/show_bug.cgi?id=53052
555         
556         Adopt the new WK2 API for this.
557
558         * WebKitTestRunner/TestController.cpp:
559         (WTR::TestController::libraryPathForTesting):
560         (WTR::TestController::initialize):
561         * WebKitTestRunner/TestController.h:
562         * WebKitTestRunner/mac/TestControllerMac.mm:
563         (WTR::TestController::platformLibraryPathForTesting):
564         * WebKitTestRunner/qt/TestControllerQt.cpp:
565         (WTR::TestController::platformLibraryPathForTesting):
566         * WebKitTestRunner/win/TestControllerWin.cpp:
567         (WTR::TestController::platformLibraryPathForTesting):
568
569 2011-01-24  Lucas Forschler  <lforschler@apple.com>
570
571         Reviewed by Stephanie Lewis.
572
573         Add a new Leopard test bot.
574
575         * BuildSlaveSupport/build.webkit.org-config/config.json:
576
577 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
578
579         Reviewed by Adam Barth.
580
581         Add EFL Builder to core waterfall
582         https://bugs.webkit.org/show_bug.cgi?id=52704
583
584         Add EFL Builder to the core waterfall again.
585
586         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
587         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
588
589 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
590
591         Reviewed by Tony Chang.
592
593         new-run-webkit-tests fails to start HTTP server if there are proxy settings
594         https://bugs.webkit.org/show_bug.cgi?id=52872
595
596         Force disabling proxy to resolve the problem.
597
598         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
599         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
600
601 2011-01-24  Andreas Kling  <kling@webkit.org>
602
603         Reviewed by Darin Adler.
604
605         check-webkit-style: Update exemptions following Source/ move.
606         https://bugs.webkit.org/show_bug.cgi?id=53017
607
608         * Scripts/webkitpy/style/checker.py:
609         * Scripts/webkitpy/style/checker_unittest.py:
610
611 2011-01-24  Andras Becsi  <abecsi@webkit.org>
612
613         Rubber-stamped by Csaba Osztrogonác.
614
615         [Qt] Move project files into Source
616         https://bugs.webkit.org/show_bug.cgi?id=52891
617
618         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
619
620 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
621
622         Reviewed by Yury Semikhatsky.
623
624         Web Inspector: Find duplicate strings in localizedStrings.js
625
626         https://bugs.webkit.org/show_bug.cgi?id=53005
627
628         * Scripts/check-inspector-strings:
629
630 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
631
632         Reviewed by Andreas Kling.
633
634         [Qt] Regroup MiniBrowser's menubar and add open file action
635         https://bugs.webkit.org/show_bug.cgi?id=53000
636
637         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
638
639         * MiniBrowser/qt/BrowserWindow.cpp:
640         (BrowserWindow::BrowserWindow):
641         (BrowserWindow::openFile):
642         (BrowserWindow::~BrowserWindow):
643         * MiniBrowser/qt/BrowserWindow.h:
644
645 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
646
647         Unreviewed fix after r76496
648
649         [Qt] Move project files into Source
650         https://bugs.webkit.org/show_bug.cgi?id=52891
651
652         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
653         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
654         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
655
656 2011-01-24  Andras Becsi  <abecsi@webkit.org>
657
658         Reviewed by Csaba Osztrogonác.
659
660         [Qt] Move project files into Source
661         https://bugs.webkit.org/show_bug.cgi?id=52891
662
663         * DerivedSources.pro: Renamed from DerivedSources.pro.
664         * DumpRenderTree/qt/DumpRenderTree.pro:
665         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
666         * MiniBrowser/DerivedSources.pro:
667         * MiniBrowser/qt/MiniBrowser.pro:
668         * QtTestBrowser/QtTestBrowser.pro:
669         * Scripts/webkitdirs.pm:
670         * Tools.pro: Added.
671         * WebKitTestRunner/DerivedSources.pro:
672         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
673         * WebKitTestRunner/qt/WebKitTestRunner.pro:
674
675 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
676
677         Reviewed by Dan Bernstein.
678
679         Beefed up --threaded mode to catch even more kinds of errors.
680         https://bugs.webkit.org/show_bug.cgi?id=52971
681
682         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
683         context group to force JSC to mark multiple threads. (This used to be
684         the default, but it changed in SnowLeopard.)
685         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
686         to give threading mistakes more chances to show themselves.
687         (startJavaScriptThreads):
688         (stopJavaScriptThreads):
689
690 2011-01-22  Robert Hogan  <robert@webkit.org>
691
692         Reviewed by Andreas Kling.
693
694         [Qt] Support layoutTestController.addURLToRedirect()
695         https://bugs.webkit.org/show_bug.cgi?id=52956
696
697         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
698         (LayoutTestController::addURLToRedirect):
699         * DumpRenderTree/qt/LayoutTestControllerQt.h:
700
701 2011-01-22  Robert Hogan  <robert@webkit.org>
702
703         Reviewed by Kenneth Rohde Christiansen.
704
705         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
706         https://bugs.webkit.org/show_bug.cgi?id=49802
707
708         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
709         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
710         (WebCore::DumpRenderTree::open):
711
712 2011-01-21  Adam Barth  <abarth@webkit.org>
713
714         Reviewed by Maciej Stachowiak.
715
716         Disable mac_unittest.py that fails on some of the Mac bots
717         https://bugs.webkit.org/show_bug.cgi?id=52947
718
719         As noted in the comment, this test does not appear to be correct
720         because the function this test is testing returns different results
721         depending on which flavor of Mac the test is run on.  This patch
722         disable the test.  Hopefully we can re-enable the test once we've
723         probably insulated the test from its environment.
724
725         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
726
727 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
728
729         Reviewed by Mihai Parparita.
730
731         Fix bug introduced in r76322 that caused NRWT to not actually
732         read the Skipped files properly.
733
734         https://bugs.webkit.org/show_bug.cgi?id=52771
735
736         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
737         * Scripts/webkitpy/layout_tests/port/webkit.py:
738         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
739
740 2011-01-21  Sam Weinig  <sam@webkit.org>
741
742         Reviewed by Geoffrey Sean Garen and Mark Rowe.
743
744         WebKitTestRunner needs the HOME environment variable to be set.
745         <rdar://problem/8896573>
746
747         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
748         it exists.
749
750 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
751
752         Reviewed by Eric Seidel.
753
754         Suppress a few remaining integration tests so that none of the
755         layout_test unit tests ever read from the filesystem or launch
756         subprocesses that aren't part of the unit tests.
757
758         Also fix a minor bug in the printing unit tests that was
759         incorrectly relying on sys.argv.
760
761         https://bugs.webkit.org/show_bug.cgi?id=52863
762
763         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
764         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
765         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
766
767 2011-01-21  Darin Adler  <darin@apple.com>
768
769        Fix Mac build.
770
771         * MiniBrowser/mac/BrowserWindowController.m:
772         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
773
774 2011-01-20  Darin Adler  <darin@apple.com>
775
776         Reviewed by Dan Bernstein.
777
778         WebKit2: Implement showModalDialog
779         https://bugs.webkit.org/show_bug.cgi?id=52855
780
781         This fixes WebKitTestRunner to compile, but more work is probably
782         needed to get it to pass the tests.
783
784         * WebKitTestRunner/TestController.cpp:
785         (WTR::TestController::runModal): Added. Calls through to the
786         platform-specific version of runModal.
787         (WTR::TestController::createOtherPage): Changed to be a private
788         static member function so it can refer to runModal, which is
789         a private static member function.
790         (WTR::TestController::initialize): Pass 0 for the runModal
791         function since we don't need to run the main window modal.
792         I suspect this is wrong and will need to change.
793         * WebKitTestRunner/TestController.h: Added declarations for
794         the functions added above.
795         * WebKitTestRunner/mac/TestControllerMac.mm:
796         (WTR::TestController::runModal): Added. Untested implementation.
797         * WebKitTestRunner/qt/TestControllerQt.cpp:
798         (WTR::TestController::runModal): Added.
799         * WebKitTestRunner/win/TestControllerWin.cpp:
800         (WTR::TestController::runModal): Added.
801
802 2011-01-21  Eric Seidel  <eric@webkit.org>
803
804         Reviewed by Adam Barth.
805
806         Split Host object off from WebKitPatch for easier re-use
807         https://bugs.webkit.org/show_bug.cgi?id=52284
808
809         new-run-webkit-tests and other tools are eventually going to want one of these.
810         Basically you need to inherit from this class if you want to pretend to be a
811         self.tool object for Steps/Commands.
812
813         * Scripts/webkitpy/common/host.py: Added.
814         * Scripts/webkitpy/tool/main.py:
815
816 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
817
818         Reviewed by Adam Barth.
819
820         Disable the tests that start and stop the http server and web
821         server, so that we don't have to worry about port collisions on
822         the bots.
823
824         https://bugs.webkit.org/show_bug.cgi?id=52861
825
826         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
827
828 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
829
830         Reviewed by Eric Seidel.
831
832         nrwt: rewrite google_chrome_unittest to use mock filesystem.
833         
834         https://bugs.webkit.org/show_bug.cgi?id=52772
835         
836         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
837
838 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
839
840         Reviewed by Eric Siedel.
841
842         nrwt: clean up almost all remaining port references, remove
843         unnecessary import clauses. The only remaining references are
844         in places where a mock filesystem makes no sense or can't be
845         used, and in one routine in port/google_chrome_unittest that
846         I'll rewrite in a separate patch.
847
848         https://bugs.webkit.org/show_bug.cgi?id=52771
849
850         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
851         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
852         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
853         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
854         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
855         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
856         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
857         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
858         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
859         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
860         * Scripts/webkitpy/layout_tests/port/gtk.py:
861         * Scripts/webkitpy/layout_tests/port/mac.py:
862         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
863         * Scripts/webkitpy/layout_tests/port/qt.py:
864         * Scripts/webkitpy/layout_tests/port/webkit.py:
865         * Scripts/webkitpy/layout_tests/port/win.py:
866         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
867
868 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
869
870         Reviewed by Mihai Parparita.
871
872         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
873
874         https://bugs.webkit.org/show_bug.cgi?id=52762
875
876         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
877         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
878
879 2011-01-20  Tony Chang  <tony@chromium.org>
880
881         Reviewed by Ojan Vafai.
882
883         [chromium] fix the paths used for the rebaseline tool
884         https://bugs.webkit.org/show_bug.cgi?id=52857
885
886         Some of the bots were renamed so the path to grab the results zip
887         file has changed.
888
889         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
890
891 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
892
893         Reviewed by Tony Chang.
894
895         Fix bug introduced in r72688 / bug 52768 that broke the
896         generation of the output filename links in the results.html
897         output. Apparently none of the unit tests actually checked to
898         make sure the generated links were correct :(
899
900         https://bugs.webkit.org/show_bug.cgi?id=52854
901
902         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
903         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
904
905 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
906
907         Reviewed by Darin Adler.
908
909         https://bugs.webkit.org/show_bug.cgi?id=52849
910         Make window.print work with WebKit2
911
912         * MiniBrowser/mac/BrowserWindowController.m:
913         (-[BrowserWindowController awakeFromNib]):
914         * WebKitTestRunner/TestController.cpp:
915         (WTR::createOtherPage):
916         (WTR::TestController::initialize):
917         Added zeroes to WKPageUIClient structures to avoid build failures.
918
919 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
920
921         Reviewed by Eric Seidel.
922
923         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
924
925         https://bugs.webkit.org/show_bug.cgi?id=52756
926
927         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
928         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
929         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
930         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
931         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
932         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
933
934 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
935
936         Reviewed by Antonio Gomes.
937
938         QtTestBrowser should have a seperate menu for Settings
939         https://bugs.webkit.org/show_bug.cgi?id=52817
940         
941         Added a new menu item named "Settings"
942         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
943
944         * QtTestBrowser/launcherwindow.cpp:
945         (LauncherWindow::createChrome):
946
947 2011-01-20  Sam Weinig  <sam@webkit.org>
948
949         Reviewed by John Sullivan.
950
951         Update update-webkit-localizable-strings with new path to WebKit.
952
953         * Scripts/update-webkit-localizable-strings:
954
955 2011-01-20  James Robinson  <jamesr@chromium.org>
956
957         Reviewed by Darin Fisher.
958
959         Implement mozilla's requestAnimationFrame API
960         https://bugs.webkit.org/show_bug.cgi?id=51218
961
962         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
963
964         * DumpRenderTree/chromium/WebViewHost.cpp:
965         (invokeScheduleComposite):
966         (WebViewHost::scheduleAnimation):
967         (WebViewHost::paintInvalidatedRegion):
968         * DumpRenderTree/chromium/WebViewHost.h:
969
970 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
971
972         Reviewed by Adam Roben.
973
974         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
975         https://bugs.webkit.org/show_bug.cgi?id=42327
976
977         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
978         for methods that take their normal arguments but also a JSContextRef.
979         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
980         for evaluateScriptInIsolatedWorld.
981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
982         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
983         this call is for an isolated world.
984         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
985         (WTR::worldMap): Helper to create a world map.
986         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
987         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
988         added LayoutTestController API.
989         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
990
991 2011-01-19  Adam Roben  <aroben@apple.com>
992
993         Convert paths in environment variables back to msys-style inside commit-log-editor
994
995         When this script gets run from inside git commit, msys-style paths in the environment will
996         have been turned into Windows-style paths with forward slashes. This screws up functions
997         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
998         the paths back to msys-style before doing anything else.
999
1000         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1001         using msysgit's Perl and multiple ChangeLogs have been edited
1002
1003         Reviewed by David Kilzer.
1004
1005         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1006         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1007         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1008
1009 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1010
1011         [Win] Unreviewed build fix after r76248.
1012
1013         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1014
1015 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1016
1017         Reviewed by Csaba Osztrogonác.
1018
1019         Refactoring of the custom allocation framework
1020         https://bugs.webkit.org/show_bug.cgi?id=49897
1021
1022         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1023         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1024         equivalent macro implementation at the necessary places.
1025 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1026
1027         Unreviewed. 
1028
1029         Adding myself to committers.py.
1030
1031         * Scripts/webkitpy/common/config/committers.py:
1032
1033 2011-01-20  Adam Barth  <abarth@webkit.org>
1034
1035         Reviewed by Tony Chang.
1036
1037         Chromium builders don't delete unversioned directories when DEPS change
1038         https://bugs.webkit.org/show_bug.cgi?id=52745
1039
1040         If we pass this option to gclient sync, gclient will delete directories
1041         that are no longer part of DEPS instead of leaving them around to
1042         confuse us later.  Apparently, the downstream buildbots use this option
1043         already.
1044
1045         * Scripts/update-webkit-chromium:
1046
1047 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1048
1049         Unreviewed, build fix - I pulled this patch in to fix an issue
1050         revealed by r76195 running on some new bots). Also fix a couple
1051         of other issues revealed in testing.
1052
1053         nrwt: remove fs refs from layout_package/json*
1054
1055         https://bugs.webkit.org/show_bug.cgi?id=52754
1056
1057         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1058         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1059         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1060         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1061         * Scripts/webkitpy/layout_tests/port/base.py:
1062
1063 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1064
1065         Unreviewed, build fix.
1066
1067         Fix a couple of minor bugs discovered while bringing up new bots
1068         for testing.
1069
1070         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1071         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1072
1073 2011-01-19  James Robinson  <jamesr@chromium.org>
1074
1075         Unreviewed, rolling out r76194.
1076         http://trac.webkit.org/changeset/76194
1077         https://bugs.webkit.org/show_bug.cgi?id=51218
1078
1079         Caused mysterious compile failure on the chromium win
1080         build.webkit.org bots
1081
1082         * DumpRenderTree/chromium/WebViewHost.cpp:
1083         (WebViewHost::paintInvalidatedRegion):
1084         * DumpRenderTree/chromium/WebViewHost.h:
1085
1086 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1087
1088         Reviewed by Mihai Parparita.
1089
1090         remove fs refs from test_runner, dump_render_tree_thread
1091
1092         https://bugs.webkit.org/show_bug.cgi?id=52753
1093
1094         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1095         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1096         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1097         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1098
1099 2011-01-19  James Robinson  <jamesr@chromium.org>
1100
1101         Reviewed by Darin Fisher.
1102
1103         Implement mozilla's requestAnimationFrame API
1104         https://bugs.webkit.org/show_bug.cgi?id=51218
1105
1106         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1107
1108         * DumpRenderTree/chromium/WebViewHost.cpp:
1109         (invokeScheduleComposite):
1110         (WebViewHost::scheduleAnimation):
1111         (WebViewHost::paintInvalidatedRegion):
1112         * DumpRenderTree/chromium/WebViewHost.h:
1113
1114 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1115
1116         Unreviewed, build fix.
1117
1118         Fix a few incorrect "self._filesystem" references introduced in
1119         r76184.
1120
1121         * Scripts/webkitpy/layout_tests/port/chromium.py:
1122         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1123
1124 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1125
1126         Reviewed by Mihai Parparita.
1127
1128         add a .sep property, abspath(), isabs(), mtime(), and
1129         open_text_file_for_writing() to filesystem modules. Some of
1130         these properties are not needed in this patch but will be needed
1131         in subsequent patches (I'm doing this to avoid having to track
1132         multiple versions of a single file).
1133
1134         Also, change most of the port/* modules to use the filesystem
1135         objects instead of referencing the filesystem directly.
1136
1137         https://bugs.webkit.org/show_bug.cgi?id=52748
1138
1139         * Scripts/webkitpy/common/system/filesystem.py:
1140         * Scripts/webkitpy/common/system/filesystem_mock.py:
1141         * Scripts/webkitpy/layout_tests/port/__init__.py:
1142         * Scripts/webkitpy/layout_tests/port/base.py:
1143         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1144         * Scripts/webkitpy/layout_tests/port/chromium.py:
1145         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1146         * Scripts/webkitpy/layout_tests/port/config.py:
1147         * Scripts/webkitpy/layout_tests/port/test.py:
1148         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1149
1150 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1151
1152         Reviewed by Anders Carlsson.
1153
1154         If resetting between tests times out, treat it as a WebProcess crash
1155         https://bugs.webkit.org/show_bug.cgi?id=52757
1156
1157         * WebKitTestRunner/TestController.cpp:
1158         (WTR::TestController::runTest):
1159
1160 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1161
1162         Reviewed by Darin Adler.
1163
1164         https://bugs.webkit.org/show_bug.cgi?id=52739
1165         Make it possible for a WebKit2 client to print headers and footers
1166
1167         Added dummy implementations for new printing UIClient calls.
1168
1169         * MiniBrowser/mac/BrowserWindowController.m:
1170         (-[BrowserWindowController awakeFromNib]):
1171         * WebKitTestRunner/TestController.cpp:
1172         (WTR::createOtherPage):
1173         (WTR::TestController::initialize):
1174
1175 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1176
1177         Reviewed by Ojan Vafai.
1178
1179         Change webkitpy/layout_tests/port/test.py to use the
1180         in-memory filesystem for cleaner unit testing. This
1181         change allows us to kill a lot of code that was
1182         specific to the test port, at the cost of being a
1183         little less clear about how things would work if
1184         you didn't have a filesystem.
1185
1186         https://bugs.webkit.org/show_bug.cgi?id=52605
1187
1188         * Scripts/webkitpy/layout_tests/port/test.py:
1189
1190 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1191
1192         Unreviewed, build fix.
1193
1194         Fix test failure caused by committing attachment 79368 instead
1195         of attachment 79461 on bug 52604.
1196
1197         * Scripts/webkitpy/common/system/filesystem_mock.py:
1198
1199 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1200
1201         Reviewed by Mihai Parparita.
1202
1203         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1204         unit testing. os.walk() is too much of a hassle to implement on
1205         top of the in-memory mock filesystem and adding the necessary
1206         interface to files_under() gives clients a cleaner API anyway
1207         (for this particular usage model).
1208
1209         https://bugs.webkit.org/show_bug.cgi?id=52691
1210
1211         * Scripts/webkitpy/common/system/filesystem.py:
1212         * Scripts/webkitpy/common/system/filesystem_mock.py:
1213         * Scripts/webkitpy/layout_tests/port/test_files.py:
1214         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1215
1216 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1217
1218         Reviewed by Tony Chang.
1219
1220         Change more modules in the layout-tests code to use the
1221         filesystem wrapper for cleaner unit testing.
1222
1223         This patch also adds the glob() wrapper to the filesystem
1224         abstraction.
1225         
1226         https://bugs.webkit.org/show_bug.cgi?id=52604
1227
1228         * Scripts/webkitpy/layout_tests/port/test_files.py:
1229         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1230         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1231         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1232         * Scripts/webkitpy/common/system/filesystem.py:
1233         * Scripts/webkitpy/common/system/filesystem_mock.py:
1234
1235 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1236
1237         Unreviewed.
1238
1239         Updating my email addresses and irc nick.
1240
1241         * Scripts/webkitpy/common/config/committers.py:
1242
1243 2011-01-19  Tony Chang  <tony@chromium.org>
1244
1245         Reviewed by Mihai Parparita.
1246
1247         [chromium] [linux] if check-sys-deps fails, output the failure reason
1248         https://bugs.webkit.org/show_bug.cgi?id=52671
1249
1250         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1251             error handler functions.
1252         * Scripts/webkitpy/layout_tests/port/chromium.py:
1253             output the error text from --check-sys-deps
1254         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1255
1256 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1257
1258         Reviewed by Andreas Kling.
1259
1260         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1261         https://bugs.webkit.org/show_bug.cgi?id=52554
1262         
1263         QtNetworkAccessManager is created in a thread and set as
1264         member variable in QWebPage. When the thread is destroyed
1265         the object is still used. So fix will set the object to
1266         NULL once the thread is destroyed.
1267
1268         * QtTestBrowser/launcherwindow.cpp:
1269         (LauncherWindow::~LauncherWindow):
1270
1271 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1272
1273         Rubber stamped by Csaba Osztrogonac
1274
1275         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1276
1277 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1278
1279         Reviewed by Tony Chang.
1280
1281         new-run-webkit-tests: add a --build-directory command line argument
1282
1283         Official Google Chrome builds use a non-standard build directory
1284         location. This patch adds a --build-directory argument that
1285         allows that location to be specified on the command line. Only
1286         Chromium-based builds will use this flag for now, but anyone can
1287         in the future.
1288
1289         There are no unit tests for this since it's difficult to test
1290         until mock filesystems are fully supported in the code. This was
1291         tested by hand for now.
1292
1293         https://bugs.webkit.org/show_bug.cgi?id=52694
1294
1295         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1296         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1297         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1298         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1299
1300 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1301
1302         Not reviewed. Bot fix.
1303
1304         Remove an inadvertently committed debugging print.
1305
1306         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1307         (LayoutTestController::notifyDone):
1308
1309 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1310
1311         Reviewed by Sam Weinig.
1312
1313         WebKitTestRunner should track loading more like DumpRenderTree
1314         https://bugs.webkit.org/show_bug.cgi?id=52692
1315
1316         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1317         This makes some tests that call notifyDone multiple times pass.
1318         
1319         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1320         (WTR::InjectedBundle::InjectedBundle):
1321         (WTR::InjectedBundle::done):
1322         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1323         (WTR::InjectedBundle::topLoadingFrame):
1324         (WTR::InjectedBundle::setTopLoadingFrame):
1325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1326         (WTR::InjectedBundlePage::InjectedBundlePage):
1327         (WTR::InjectedBundlePage::stopLoading):
1328         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1329         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1330         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1331         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1332         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1333         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1334         (WTR::LayoutTestController::notifyDone):
1335         * WebKitTestRunner/TestController.cpp:
1336         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1337
1338 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1339
1340         Reviewed by Kent Tamura.
1341
1342         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1343         https://bugs.webkit.org/show_bug.cgi?id=52678
1344         
1345         Update path now that WebKit is inside Source.
1346
1347         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1348
1349 2011-01-18  Robert Hogan  <robert@webkit.org>
1350
1351         Reviewed by Simon Hausmann.
1352
1353         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1354         https://bugs.webkit.org/show_bug.cgi?id=44282
1355
1356         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1357         (WebCore::DumpRenderTree::dump):
1358
1359 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1360
1361         Reviewed by Mihai Parparita.
1362
1363         Fix a small race condition that could cause the unit tests for
1364         new-run-webkit-tests to fail in a multithreaded environment.
1365         There was a small window in the code where one thread would
1366         check to see if a thread had raised an exception, do something,
1367         and then check to see if the thread was alive. If the other
1368         thread raised an exception and exited in between these two
1369         steps, the exception would be lost. Flipping the order of the
1370         two checks fixes the race, since we will now always check for an
1371         exception on the thread before exiting.
1372
1373         https://bugs.webkit.org/show_bug.cgi?id=51579
1374
1375         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1376
1377 2011-01-18  Eric Seidel  <eric@webkit.org>
1378
1379         Reviewed by Adam Barth.
1380
1381         commit-queue dies when test archiving fails
1382         https://bugs.webkit.org/show_bug.cgi?id=52617
1383
1384         I looked at the machine and it had 10 archives already
1385         thus find_unused_name was returning None.  I've upped
1386         the limit to 100 (per bug) and tested the case where
1387         find_unused_name returns None (making archive return None).
1388
1389         * Scripts/webkitpy/common/system/workspace.py:
1390         * Scripts/webkitpy/common/system/workspace_unittest.py:
1391         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1392         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1393         * Scripts/webkitpy/tool/commands/queues.py:
1394
1395 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1396
1397         Reviewed by Ojan Vafai.
1398
1399         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1400         filesystem. Also fix a couple of "with" statements missed by
1401         r76050.
1402
1403         https://bugs.webkit.org/show_bug.cgi?id=52487
1404
1405         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1406
1407 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1408
1409         Reviewed by Martin Robinson.
1410
1411         [Gtk] Build fixes for gtk3 build
1412         https://bugs.webkit.org/show_bug.cgi?id=52648
1413
1414         * DumpRenderTree/gtk/EventSender.cpp:
1415         (beginDragWithFilesCallback):
1416
1417 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1418
1419         Reviewed by Mihai Parparita.
1420
1421         Update rebaseline-chromium-webkit-tests to use filesystem objects
1422         instead of direct references to os.path, shutil, tempfile, etc.
1423
1424         This patch doesn't change anything, but will allow subsequent
1425         patches to change the unit tests to no longer use the real
1426         filesystem.
1427
1428         This patch adds a bunch more methods to the filesystem object as
1429         well.
1430
1431         https://bugs.webkit.org/show_bug.cgi?id=52482
1432
1433         * Scripts/webkitpy/common/system/filesystem.py:
1434         * Scripts/webkitpy/common/system/filesystem_mock.py:
1435         * Scripts/webkitpy/tool/commands/queues.py:
1436         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1437         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1438
1439 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1440
1441         Reviewed by Mihai Parparita.
1442
1443         new-run-webkit-tests shouldn't crash when you try to run a
1444         directory containing only skipped files.
1445
1446         https://bugs.webkit.org/show_bug.cgi?id=52478
1447         
1448         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1449         * Scripts/webkitpy/layout_tests/port/test.py:
1450         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1451
1452 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1453
1454         Reviewed by Gustavo Noronha Silva.
1455
1456         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1457         https://bugs.webkit.org/show_bug.cgi?id=40833
1458
1459         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1460         GTK+ event sender.
1461         (dragWithFilesDragDataGetCallback): Added.
1462         (dragWithFilesDragEndCallback): Added.
1463         (beginDragWithFilesCallback): Added.
1464
1465 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1466
1467         Reviewed by Adam Barth.
1468
1469         ews: Add additional watcher to efl ews
1470         https://bugs.webkit.org/show_bug.cgi?id=52613
1471
1472         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1473
1474         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1475
1476 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1477
1478         Reviewed by Alexey Proskuryakov.
1479
1480         Fix some headers with missing or misspelled #ifndef guards
1481         https://bugs.webkit.org/show_bug.cgi?id=52545
1482
1483         * DumpRenderTree/chromium/TestEventPrinter.h:
1484         * DumpRenderTree/chromium/WebPreferences.h:
1485
1486 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1487
1488         Reviewed by Anders Carlsson.
1489
1490         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1491         navigating back to an unreachable URL
1492         https://bugs.webkit.org/show_bug.cgi?id=52388
1493
1494         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1495
1496         * DumpRenderTree/LayoutTestController.cpp:
1497         (queueLoadHTMLStringCallback):
1498         (LayoutTestController::queueLoadHTMLString):
1499         (LayoutTestController::queueLoadAlternateHTMLString):
1500         * DumpRenderTree/LayoutTestController.h:
1501
1502         * DumpRenderTree/WorkQueueItem.h:
1503         (LoadHTMLStringItem::LoadHTMLStringItem):
1504
1505         * DumpRenderTree/chromium/LayoutTestController.cpp:
1506         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1507         (WorkItemLoadHTMLString::run):
1508         (LayoutTestController::queueLoadHTMLString):
1509
1510         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1511         (LoadHTMLStringItem::invoke):
1512         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1513         (LoadHTMLStringItem::invoke):
1514         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1515         (LoadHTMLStringItem::invoke):
1516
1517 2011-01-17  Dan Bernstein  <mitz@apple.com>
1518
1519         Rubber-stamped by Mark Rowe.
1520
1521         Update xcodeproj svn:ignore to include xcuserdata.
1522
1523         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1524         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1525         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1526         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1527         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1528
1529 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1530
1531         Unreviewed fix after r75908.
1532
1533         Move WebKit into Source
1534         https://bugs.webkit.org/show_bug.cgi?id=52530
1535
1536         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1537
1538 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1539
1540         Unreviewed.
1541
1542         Remove accidentally committed debug printing after r75908.
1543
1544         * Scripts/webkitdirs.pm:
1545
1546 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1547
1548         Unreviewed.
1549
1550         Add myself to committers list
1551         https://bugs.webkit.org/show_bug.cgi?id=52566
1552
1553         * Scripts/webkitpy/common/config/committers.py:
1554
1555 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1556
1557         Reviewed by Jeremy Orlow.
1558
1559         GeolocationController should call stopUpdating on destruction
1560         https://bugs.webkit.org/show_bug.cgi?id=52216
1561
1562         fast/dom/Geolocation/window-close-crash.html requires that a
1563         Geolocation watch be started in a secondary window. Consequently,
1564         we need to allow geolocation permission and provide a mock
1565         geolocation position for the secondary window's
1566         GeolocationClientMock.
1567
1568         * DumpRenderTree/chromium/LayoutTestController.cpp:
1569         (LayoutTestController::setGeolocationPermission):
1570         (LayoutTestController::setMockGeolocationPosition):
1571         (LayoutTestController::setMockGeolocationError):
1572         * DumpRenderTree/chromium/TestShell.h:
1573         (TestShell::windowList):
1574
1575 2011-01-16  Adam Barth  <abarth@webkit.org>
1576
1577         Update more include paths to reflect WebKit move.
1578
1579         * DumpRenderTree/chromium/EventSender.cpp:
1580         (EventSender::keyDown):
1581         (EventSender::needsShiftModifier):
1582         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1583         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1584
1585 2011-01-16  Kent Tamura  <tkent@chromium.org>
1586
1587         Unreviewed, Chromium build fix.
1588
1589         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1590
1591 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1592
1593         Build fix for GTK+ after source directory movement.
1594
1595         * GNUmakefile.am: Correct include paths.
1596
1597 2011-01-16  Adam Barth  <abarth@webkit.org>
1598
1599         Teach svn-apply about WebKit move.
1600
1601         * Scripts/VCSUtils.pm:
1602
1603 2011-01-16  Adam Barth  <abarth@webkit.org>
1604
1605         Rubber-stamped by Eric Seidel.
1606
1607         Move WebKit into Source
1608         https://bugs.webkit.org/show_bug.cgi?id=52530
1609
1610         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1611         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1612         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1613         * DumpRenderTree/qt/GCControllerQt.cpp:
1614         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1615         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1616         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1617         * DumpRenderTree/wscript:
1618         * QtTestBrowser/launcherwindow.h:
1619         * Scripts/build-webkit:
1620         * Scripts/webkitdirs.pm:
1621
1622 2011-01-15  Adam Barth  <abarth@webkit.org>
1623
1624         Teach svn-apply about WebKit2 move.
1625
1626         * Scripts/VCSUtils.pm:
1627
1628 2011-01-15  Adam Barth  <abarth@webkit.org>
1629
1630         Rubber-stamped by Eric Seidel.
1631
1632         Move WebKit2 into Source
1633         https://bugs.webkit.org/show_bug.cgi?id=52438
1634
1635         * MiniBrowser/qt/MiniBrowser.pro:
1636         * Scripts/build-webkit:
1637         * Scripts/do-file-rename:
1638         * Scripts/do-webcore-rename:
1639         * Scripts/test-webkitpy:
1640         * Scripts/webkitdirs.pm:
1641         * Scripts/webkitpy/style/checker.py:
1642         * WebKitTestRunner/DerivedSources.pro:
1643         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1644         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1645
1646 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1647
1648         Reviewed by David Levin.
1649
1650         [chromium] remove obsolete createView method
1651         https://bugs.webkit.org/show_bug.cgi?id=52437
1652
1653         * DumpRenderTree/chromium/WebViewHost.cpp:
1654         (WebViewHost::createView):
1655         * DumpRenderTree/chromium/WebViewHost.h:
1656
1657 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1658
1659         Reviewed by Geoff Garen.
1660
1661         ShouldLoadResourceForFrame should use strings, not URLs.
1662         https://bugs.webkit.org/show_bug.cgi?id=52476
1663
1664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1665         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1666         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1667
1668 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1669
1670         Reviewed by David Levin.
1671
1672         Add Tony Gentilcore as a reviewer
1673         https://bugs.webkit.org/show_bug.cgi?id=52480
1674
1675         * Scripts/webkitpy/common/config/committers.py:
1676
1677 2011-01-14  David Levin  <levin@chromium.org>
1678
1679         Reviewed by Eric Seidel.
1680
1681         check-webkit-style: _FunctionState should keep track of where the function name starts.
1682         https://bugs.webkit.org/show_bug.cgi?id=52454
1683
1684         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1685         _FunctionState and logic for setting it correctly.
1686         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1687
1688 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1689
1690         Reviewed by David Levin.
1691
1692         Add support to DumpRenderTree to use the GPU rather than software renderer
1693         https://bugs.webkit.org/show_bug.cgi?id=52333
1694
1695         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1696         (main):
1697         * Scripts/webkitpy/layout_tests/port/chromium.py:
1698         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1699
1700 2011-01-14  Tony Chang  <tony@chromium.org>
1701
1702         Reviewed by Kent Tamura.
1703
1704         [chromium] update fonts.conf to fix 6 linux tests in drt
1705         https://bugs.webkit.org/show_bug.cgi?id=52411
1706
1707         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1708             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1709
1710 2011-01-14  Eric Seidel  <eric@webkit.org>
1711
1712         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1713
1714         Reviewed by Adam Barth.
1715
1716         Fix when running Tools/Scripts/check-webkit-style without arguments.
1717         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1718
1719         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1720         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1721
1722 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1723
1724         Reviewed by David Levin.
1725
1726         Store the tempdir object in a variable so it doesn't get deleted too early.
1727         https://bugs.webkit.org/show_bug.cgi?id=51875
1728
1729         * Scripts/update-webkit-auxiliary-libs:
1730         * Scripts/update-webkit-support-libs:
1731
1732 2011-01-14  Eric Seidel  <eric@webkit.org>
1733
1734         Unreviewed.  Make it work in python 2.5.
1735
1736         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1737         https://bugs.webkit.org/show_bug.cgi?id=49158
1738
1739         * Scripts/webkitpy/common/checkout/api_unittest.py:
1740
1741 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1742
1743         Unreviewed, rolling out r75774.
1744         http://trac.webkit.org/changeset/75774
1745         https://bugs.webkit.org/show_bug.cgi?id=52431
1746
1747         gtk builds were broken (Requested by loislo2 on #webkit).
1748
1749         * Scripts/webkitpy/common/checkout/scm.py:
1750
1751 2011-01-14  David Levin  <levin@chromium.org>
1752
1753         Reviewed by Shinichiro Hamaji.
1754
1755         check-webkit-style: _FunctionState should detect pure functions.
1756         https://bugs.webkit.org/show_bug.cgi?id=52428
1757
1758         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1759         is a pure virtual function.
1760         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1761         virtual functions are correctly detected.
1762
1763 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1764
1765         Reviewed by Yury Semikhatsky.
1766
1767         Just small fix for problem with check-webkit-style.
1768         It just didn't work for this patch.
1769         Old code can't concatenate a list of strings with None.
1770
1771         * Scripts/webkitpy/common/checkout/scm.py:
1772
1773 2011-01-13  David Levin  <levin@chromium.org>
1774
1775         Reviewed by Shinichiro Hamaji.
1776
1777         check-webkit-style: _FunctionState should use Position to know where items are.
1778         https://bugs.webkit.org/show_bug.cgi?id=52424
1779
1780         * Scripts/webkitpy/style/checkers/cpp.py:
1781         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1782         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1783         did some minor clean-up.
1784         (*): Other changes are simply about converting to use the Position's in_FunctionState
1785         instead of line numbers.
1786         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1787         to verify the positions stored in _FunctionState.
1788
1789 2011-01-13  Eric Seidel  <eric@webkit.org>
1790
1791         Reviewed by David Levin.
1792
1793         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1794         https://bugs.webkit.org/show_bug.cgi?id=49158
1795
1796         This is not the most elegant, but it is a very safe fix to this bug.
1797         One advantage of catching ScriptError like this instead of adding a
1798         new added_or_modified_files or fixing all changed_files callers
1799         to use a more specific change_files variant, is that we catch
1800         all kinds of ScriptErrors which might cause our (non-essential)
1801         suggest-reviewers code to fail out.  This should make passing
1802         --suggest-reviewers to webkit-patch upload much more robust
1803         and may even make it possible for us to make it default.
1804
1805         The root of the problem here is that SCM.changed_files includes
1806         deleted ChangeLog paths (from moves, etc) which then when we ask
1807         SVN/Git for the contents of the file at that revision, the command
1808         errors out and Executive.run_command raises a ScriptError.
1809
1810         In the future we might fix this differently by making all current
1811         callers of chagned_files use a more specific method for requesting
1812         what types of changes they're interested in (adds, modifies, deletes, etc.)
1813
1814         * Scripts/webkitpy/common/checkout/api.py:
1815         * Scripts/webkitpy/common/checkout/api_unittest.py:
1816
1817 2011-01-13  Dan Bernstein  <mitz@apple.com>
1818
1819         Reviewed by Alexey Proskuryakov.
1820
1821         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1822         https://bugs.webkit.org/show_bug.cgi?id=52419
1823
1824         Allow to further control the behavior of the willSendRequest delegate callback by making it
1825         set a different URL in the new request.
1826
1827         * DumpRenderTree/LayoutTestController.cpp:
1828         (addURLToRedirectCallback): Added.
1829         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1830         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1831         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1832         * DumpRenderTree/LayoutTestController.h:
1833         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1834         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1835         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1836         change the URL in the new request to the redirect destination.
1837
1838 2011-01-13  Eric Seidel  <eric@webkit.org>
1839
1840         Reviewed by Mihai Parparita.
1841
1842         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1843         https://bugs.webkit.org/show_bug.cgi?id=52416
1844
1845         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1846         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1847
1848         I also added FIXMEs about the changed_files returning deleted files problem
1849         which is causing the other most common exception for suggest-reviewers
1850         (and is probably breaking sheriff-bots blame detection).
1851
1852         * Scripts/webkitpy/common/checkout/api.py:
1853         * Scripts/webkitpy/common/checkout/api_unittest.py:
1854         * Scripts/webkitpy/common/checkout/scm.py:
1855
1856 2011-01-13  Eric Seidel  <eric@webkit.org>
1857
1858         Reviewed by Adam Barth.
1859
1860         results archives from commit-queue are too large to upload
1861         https://bugs.webkit.org/show_bug.cgi?id=52405
1862
1863         * Scripts/webkitpy/common/system/filesystem.py:
1864         * Scripts/webkitpy/common/system/filesystem_mock.py:
1865         * Scripts/webkitpy/tool/commands/queues.py:
1866
1867 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1868
1869         Reviewed by Martin Robinson.
1870
1871         [gtk] Zero-sized font does not yet work
1872         https://bugs.webkit.org/show_bug.cgi?id=49793
1873
1874         Set minimum-font-size to 0 for the DRT.
1875
1876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1877         (resetDefaultsToConsistentValues):
1878
1879 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1880
1881         Reviewed by Darin Adler.
1882
1883         Make old-run-webkit-tests more robust on buildbots
1884         https://bugs.webkit.org/show_bug.cgi?id=52364
1885
1886         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1887
1888 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1889
1890         Reviewed by Darin Adler.
1891
1892         Make old-run-webkit-tests more robust on buildbots
1893         https://bugs.webkit.org/show_bug.cgi?id=52364
1894
1895         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1896
1897 2011-01-13  Tony Chang  <tony@chromium.org>
1898
1899         Reviewed by Kent Tamura.
1900
1901         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1902         https://bugs.webkit.org/show_bug.cgi?id=52332
1903
1904         Forked Info.plist is not longer needed.
1905
1906         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1907
1908 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1909
1910         Reviewed by Timothy Hatcher.
1911
1912         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1913         to be passed directly to WebInspector.UIString
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=52365
1916
1917         * Scripts/check-inspector-strings:
1918
1919 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1920
1921         Unreviewed, rolling out r74881.
1922         http://trac.webkit.org/changeset/74881
1923         https://bugs.webkit.org/show_bug.cgi?id=52357
1924
1925         The EFL builder has been red for days (Requested by abarth on
1926         #webkit).
1927
1928         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1929         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1930
1931 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1932
1933         Reviewed by David Levin.
1934
1935         Add beforeunload support to WebKitTestRunner
1936         https://bugs.webkit.org/show_bug.cgi?id=52353
1937         
1938         This makes a number of currently failing tests pass.
1939
1940         * WebKitTestRunner/TestController.cpp:
1941         (WTR::runBeforeUnloadConfirmPanel):
1942         (WTR::createOtherPage):
1943         (WTR::TestController::initialize):
1944
1945 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1946
1947         Reviewed by Sam Weinig.
1948
1949         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1950         https://bugs.webkit.org/show_bug.cgi?id=52330
1951
1952         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1953         a web process crash.
1954         * WebKitTestRunner/TestController.cpp:
1955         (WTR::TestController::initialize): Set up a processDidCrash
1956         callback.
1957         (WTR::TestController::processDidCrash): Report that the Web process
1958         crashed.
1959         * WebKitTestRunner/TestController.h:
1960
1961 2011-01-12  David Levin  <levin@chromium.org>
1962
1963         Reviewed by Shinichiro Hamaji.
1964
1965         check-webkit-style -- close_expression function doesn't work correctly.
1966         https://bugs.webkit.org/show_bug.cgi?id=52272
1967
1968         * Scripts/webkitpy/style/checkers/cpp.py:
1969         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1970         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1971         generally useful (for upcoming code changes).
1972         (close_expression): Changed to use Position for input and output.
1973         Also, fixed many bugs such as only working correctly for parenthesis,
1974         not working correctly if given an offset in a line and not finding
1975         the real closing element if there were multiple closing elements in
1976         the same line.
1977         (detect_functions): Adjusted due to the change in arguments for
1978         close_expression.
1979         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1980         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1981         two positions are the same.
1982         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1983         (CppStyleTest.test_close_expression): Added tests to catch the issues
1984         that were fixed.
1985
1986 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1987
1988         Unreviewed, rolling out r75576.
1989         http://trac.webkit.org/changeset/75576
1990         https://bugs.webkit.org/show_bug.cgi?id=52304
1991
1992         broke rebaseline-chromium-webkit-test (Requested by thakis on
1993         #webkit).
1994
1995         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1996         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1997         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1998         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1999         * Scripts/webkitpy/layout_tests/port/base.py:
2000         * Scripts/webkitpy/layout_tests/port/chromium.py:
2001         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2002         * Scripts/webkitpy/layout_tests/port/test.py:
2003         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2005         * Scripts/webkitpy/style/checkers/test_expectations.py:
2006         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2007
2008 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2009
2010         Reviewed by Darin Adler.
2011
2012         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2013         https://bugs.webkit.org/show_bug.cgi?id=52307
2014
2015         * Scripts/old-run-webkit-tests:
2016
2017 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2018
2019         Reviewed by Martin Robinson.
2020
2021         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2022         https://bugs.webkit.org/show_bug.cgi?id=50867
2023
2024         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2025         TestNetscapePlugin.cpp 
2026
2027         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2028         * Scripts/webkitdirs.pm:
2029
2030 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2031
2032         Reviewed by Pavel Feldman.
2033
2034         Add check-inspector-strings script.
2035
2036         https://bugs.webkit.org/show_bug.cgi?id=52295
2037
2038         * Scripts/check-inspector-strings: Added.
2039
2040 2011-01-12  Adam Roben  <aroben@apple.com>
2041
2042         Advertise the .testnetscape file extension on Windows
2043
2044         Fixes <http://webkit.org/b/52298>
2045         plugins/no-mime-with-valid-extension.html fails on Windows
2046
2047         Reviewed by Dan Bernstein.
2048
2049         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2050         FileExtents field to map the .testnetscape file extension to the
2051         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2052
2053 2011-01-12  Adam Barth  <abarth@webkit.org>
2054
2055         Reviewed by Eric Seidel.
2056
2057         Make webkit-patch support subdirectories for SVN checkouts
2058         https://bugs.webkit.org/show_bug.cgi?id=52261
2059
2060         os.relpath does not exist on Python 2.5, so we need to call our version
2061         of the API.
2062
2063         * Scripts/webkitpy/common/checkout/scm.py:
2064
2065 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2066
2067         Reviewed by Eric Seidel.
2068
2069         Close additional pages opened during a test once the test completes.
2070         https://bugs.webkit.org/show_bug.cgi?id=52276
2071
2072         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2073         (WTR::InjectedBundle::done):
2074
2075 2011-01-11  David Levin  <levin@chromium.org>
2076
2077         Reviewed by Eric Seidel.
2078
2079         Errors should be separated from the command line in bot messages.
2080         https://bugs.webkit.org/show_bug.cgi?id=52275
2081
2082         * Scripts/webkitpy/common/system/executive.py:
2083         (ScriptError.message_with_output): Added a newline to separate the command
2084         line from the errors.
2085         * Scripts/webkitpy/common/system/executive_unittest.py:
2086         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2087         paths in message_with_output.
2088
2089 2011-01-11  Eric Seidel  <eric@webkit.org>
2090
2091         Unreviewed.
2092
2093         commit-queue should know how to upload archived results (for test flakes or general failures)
2094         https://bugs.webkit.org/show_bug.cgi?id=52048
2095
2096         The zips are mostly empty due to forgetting -r.
2097         Expected diffs were not being pulled from the archive due
2098         to the archive having longer paths than I realized.
2099
2100         * Scripts/webkitpy/common/system/workspace.py:
2101         * Scripts/webkitpy/common/system/workspace_unittest.py:
2102         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2103         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2104
2105 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2106
2107         Reviewed by Ojan Vafai.
2108
2109         The current modifier parsing code in test_expectations is
2110         fragile and hard-coded, so it's not easy to understand the logic
2111         or easily add new types of modifiers (like GPU vs. CPU testing
2112         for graphics tests, or 32-bit vs. 64-bit differences).
2113
2114         This is the first of two patches that will add in more generic
2115         support and then eliminate the GPU-specific test expectations
2116         files for Chromium.
2117
2118         This patch adds two standalone objects for handling modifiers. The
2119         rules for interpreting modifiers, precedence, and conflicts are
2120         given in the docstring to the ModifierMatcher class, which
2121         returns ModifierMatchResult objects.
2122         
2123         This patch also adds routines to the Port interface and a
2124         default set of values in the base object, in order to obtain the
2125         values needed on a given test run. These values are then passed
2126         to the expectation parser. This also allows us to clean up the
2127         logic used to lint all of the different configurations in a
2128         single test_expectations.txt file.
2129
2130         The next patch will merge in the separate GPU expectations file.
2131
2132         https://bugs.webkit.org/show_bug.cgi?id=51222
2133
2134         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2135         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2136         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2137         * Scripts/webkitpy/layout_tests/port/base.py:
2138         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2139         * Scripts/webkitpy/layout_tests/port/chromium.py:
2140         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2141         * Scripts/webkitpy/layout_tests/port/test.py:
2142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2143         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2144
2145 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2146
2147         Reviewed by Adam Barth.
2148
2149         Make webkit-patch support subdirectories for SVN checkouts
2150         https://bugs.webkit.org/show_bug.cgi?id=52261
2151
2152         * Scripts/webkitpy/common/checkout/scm.py:
2153         * Scripts/webkitpy/style_references.py:
2154         * Scripts/webkitpy/tool/main.py:
2155         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2156
2157 2011-01-11  Eric Seidel  <eric@webkit.org>
2158
2159         Unreviewed.
2160
2161         commit-queue should know how to upload archived results (for test flakes or general failures)
2162         https://bugs.webkit.org/show_bug.cgi?id=52048
2163
2164         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2165         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2166
2167         * Scripts/webkitpy/common/system/workspace.py:
2168         * Scripts/webkitpy/common/system/workspace_unittest.py:
2169         * Scripts/webkitpy/tool/commands/queues.py:
2170
2171 2011-01-11  Sam Weinig  <sam@webkit.org>
2172
2173         Roll r75474 back in.
2174
2175 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2176
2177         Reviewed by Kenneth Rohde Christiansen.
2178
2179         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2180         https://bugs.webkit.org/show_bug.cgi?id=51204
2181
2182         * QtTestBrowser/webpage.h:
2183         (QtNAMThread::QtNAMThread):
2184         (QtNAMThread::networkAccessManager):
2185         (QtNAMThread::run):
2186
2187 2011-01-11  Peter Varga  <pvarga@webkit.org>
2188
2189         Unreviewed.
2190
2191         Add myself to committers' list.
2192
2193         * Scripts/webkitpy/common/config/committers.py:
2194
2195 2011-01-11  Eric Seidel  <eric@webkit.org>
2196
2197         Reviewed by Adam Barth.
2198
2199         commit-queue should know how to upload archived results (for test flakes or general failures)
2200         https://bugs.webkit.org/show_bug.cgi?id=52048
2201
2202         Now the queue will always upload results.  Either the entire zip, or just
2203         the diffs.txt in the case of text failures.
2204
2205         This should make understanding flakes much easier, and paves the way
2206         for having the EWS run layout tests (and upload failures).
2207
2208         In order to upload .zip files I had to teach bugzilla.py to autodetect
2209         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2210         for .patch files, I have it add one before calling guess_type.
2211
2212         We may find that always uploading the whole zip instead of just the -diffs.txt
2213         file is preferable, but for now I'm keeping the old behavior because it makes
2214         quickly understanding text failures easy.
2215
2216         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2217         * Scripts/webkitpy/common/system/workspace.py: Added.
2218         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2219         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2220         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2221         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2222         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2223         * Scripts/webkitpy/tool/commands/queues.py:
2224         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2225
2226 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2227
2228         Unreviewed, rolling out r75464.
2229         http://trac.webkit.org/changeset/75464
2230         https://bugs.webkit.org/show_bug.cgi?id=52193
2231
2232         Followup rollout for 75474 (Requested by Ossy on #webkit).
2233
2234         * MiniBrowser/mac/BrowserWindowController.m:
2235         (-[BrowserWindowController awakeFromNib]):
2236         * MiniBrowser/win/BrowserView.cpp:
2237         (BrowserView::create):
2238         * WebKitTestRunner/TestController.cpp:
2239         (WTR::createOtherPage):
2240         (WTR::TestController::initialize):
2241
2242 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2243
2244         Reviewed by Csaba Osztrogonác.
2245
2246         [Qt] Baseline qt_minimal configuration
2247         https://bugs.webkit.org/show_bug.cgi?id=51313
2248
2249         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2250         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2251         QT_NO_UNDOSTACK guard.
2252
2253         * QtTestBrowser/launcherwindow.cpp:
2254         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2255         guards.
2256         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2257         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2258         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2259         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2260
2261         * QtTestBrowser/launcherwindow.h:
2262         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2263         * QtTestBrowser/locationedit.h: Ditto.
2264
2265         * QtTestBrowser/mainwindow.cpp:
2266         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2267         QT_NO_UNDOSTACK guards.
2268         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2269         (MainWindow::changeLocation): Ditto.
2270         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2271         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2272
2273         * QtTestBrowser/webpage.cpp:
2274         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2275         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2276
2277         * QtTestBrowser/webview.cpp:
2278         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2279         (WebViewGraphicsBased::animatedYFlip): Ditto.
2280
2281 2011-01-10  Sam Weinig  <sam@webkit.org>
2282
2283         Fix build.
2284
2285         * MiniBrowser/mac/BrowserWindowController.m:
2286         (-[BrowserWindowController awakeFromNib]):
2287         * MiniBrowser/win/BrowserView.cpp:
2288         (BrowserView::create):
2289         * WebKitTestRunner/TestController.cpp:
2290         (WTR::createOtherPage):
2291         (WTR::TestController::initialize):
2292
2293 2011-01-10  Eric Seidel  <eric@webkit.org>
2294
2295         Reviewed by Ojan Vafai.
2296
2297         style-queue messages are way too long for big patches
2298         https://bugs.webkit.org/show_bug.cgi?id=52161
2299
2300         We definitely could build much fancier list-to-string-with-limit functions
2301         but this should be sufficient for our needs at the moment.
2302
2303         * Scripts/webkitpy/common/system/executive.py:
2304         * Scripts/webkitpy/common/system/executive_unittest.py:
2305
2306 2011-01-10  Tony Chang  <tony@chromium.org>
2307
2308         Unreviewed, rolling out r75398.
2309         http://trac.webkit.org/changeset/75398
2310         https://bugs.webkit.org/show_bug.cgi?id=52008
2311
2312         Some layout tests are crashing on Chromium Win.
2313
2314         * DumpRenderTree/chromium/WebViewHost.cpp:
2315         (WebViewHost::updatePaintRect):
2316         * DumpRenderTree/chromium/WebViewHost.h:
2317
2318 2011-01-10  Adam Roben  <aroben@apple.com>
2319
2320         Roll out r75392
2321
2322         It isn't needed now that r75289 has been rolled out.
2323
2324         * Scripts/run-javascriptcore-tests:
2325
2326 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2327
2328         Reviewed by Anders Carlsson.
2329
2330         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2331         https://bugs.webkit.org/show_bug.cgi?id=52160
2332
2333         * WebKitTestRunner/mac/TestControllerMac.mm:
2334         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2335         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2336         anyway.
2337
2338 2011-01-10  Tony Chang  <tony@chromium.org>
2339
2340         Reviewed by Mihai Parparita.
2341
2342         [chromium] fix for animated gif layout tests
2343         https://bugs.webkit.org/show_bug.cgi?id=52008
2344
2345         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2346             to trigger gif animations.
2347         (WebViewHostPaintTask::WebViewHostPaintTask):
2348         (WebViewHostPaintTask::runIfValid):
2349         (WebViewHost::updatePaintRect):
2350         * DumpRenderTree/chromium/WebViewHost.h:
2351         (WebViewHost::taskList):
2352
2353 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2354
2355         Reviewed by Xan Lopez.
2356
2357         [GTK] Fix gtk2 compilation for master
2358         https://bugs.webkit.org/show_bug.cgi?id=51885
2359
2360         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2361         (createBitmapContextFromWebView): Replaced the old
2362         gdk_drawable_get_size with gdk_pixmap_get_size.
2363
2364 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2365
2366         Reviewed by Laszlo Gombos.
2367
2368         [WINCE] Reenable NPAPI after r75203
2369         https://bugs.webkit.org/show_bug.cgi?id=52109
2370
2371         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2372         it with !isEfl(), because EFL port does not support NPAPI (yet).
2373
2374         * Scripts/build-webkit:
2375
2376 2011-01-10  Adam Roben  <aroben@apple.com>
2377
2378         Skip some asserting JS tests
2379
2380         See <http://webkit.org/b/52156>.
2381
2382         * Scripts/run-javascriptcore-tests:
2383
2384 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2385
2386         Reviewed by Xan Lopez.
2387
2388         [GTK] build-webkit disable Blob support via arguments passed to automake
2389         https://bugs.webkit.org/show_bug.cgi?id=52097
2390
2391         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2392         build-webkit.
2393
2394 2011-01-10  Adam Roben  <aroben@apple.com>
2395
2396         Use the same name and description for TestNetscapePlugin on Windows and
2397         Mac
2398
2399         Fixes <http://webkit.org/b/52151>
2400         fast/frames/iframe-reparenting-plugins.html fails on Windows
2401
2402         Reviewed by Steve Falkenburg.
2403
2404         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2405         the name and description from Mac's Info.plist.
2406
2407 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2408
2409         Reviewed by Laszlo Gombos.
2410
2411         [Qt][WK2] Guard gcc-specific syntax
2412
2413         Non-gcc based compliers choke on the "-include"
2414         syntax for preinclude, place guard around it.
2415
2416         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2417         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2418
2419 2011-01-10  Andreas Kling  <kling@webkit.org>
2420
2421         Reviewed by Simon Hausmann.
2422
2423         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2424         https://bugs.webkit.org/show_bug.cgi?id=52111
2425
2426         When getting a createNewPage() callback from QWKPage, create the
2427         new page with the same QWKContext as the page that is passed to
2428         the callback.
2429
2430         * MiniBrowser/qt/BrowserView.h:
2431         * MiniBrowser/qt/BrowserWindow.cpp:
2432         (newPageFunction):
2433         (BrowserWindow::BrowserWindow):
2434         * MiniBrowser/qt/BrowserWindow.h:
2435
2436 2011-01-10  Andreas Kling  <kling@webkit.org>
2437
2438         Reviewed by Kenneth Rohde Christiansen.
2439
2440         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2441
2442         BrowserView set its own useless createNewPage() callback on QWKPage.
2443         This was immediately overridden by BrowserWindow anyway, so remove
2444         the BrowserView one.
2445
2446         * MiniBrowser/qt/BrowserView.cpp:
2447         (BrowserView::BrowserView):
2448
2449 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2450
2451         Reviewed by Jeremy Orlow.
2452
2453         [Chromium] Remove non-client-based Geolocation code
2454         https://bugs.webkit.org/show_bug.cgi?id=50921
2455
2456         * DumpRenderTree/chromium/LayoutTestController.cpp:
2457         (LayoutTestController::setGeolocationPermission):
2458         (LayoutTestController::setMockGeolocationPosition):
2459         (LayoutTestController::setMockGeolocationError):
2460         * DumpRenderTree/chromium/WebViewHost.cpp:
2461         (WebViewHost::geolocationClientMock):
2462         (WebViewHost::reset):
2463         * DumpRenderTree/chromium/WebViewHost.h:
2464
2465 2011-01-10  Eric Seidel  <eric@webkit.org>
2466
2467         Reviewed by Adam Barth.
2468
2469         Commit bot tried to land r? cq+ patch
2470         https://bugs.webkit.org/show_bug.cgi?id=36638
2471
2472         It should now be possible to post a patch with r? and cq+ and the
2473         commit-queue will correctly wait for the r+ before attempting to land the patch.
2474         (This was a feature requested by several users.)
2475
2476         One caveat: We don't actually reject r-, cq+ patches from the queue
2477         (we just ignore them), but I think that's OK for now.
2478
2479         I also noticed that setting r- once a commit-queue node had grabbed
2480         a patch would not properly cancel the landing.  That's fixed and
2481         tested in this patch.
2482
2483         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2484         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2485         * Scripts/webkitpy/tool/bot/feeders.py:
2486         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2487
2488 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2489
2490         Reviewed by Kenneth Rohde Christiansen.
2491
2492         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2493         https://bugs.webkit.org/show_bug.cgi?id=51934
2494
2495         When accessing the network from the destructor of QWebPage, the network access manager
2496         was already deleted because the object WebPage was already destructed.
2497
2498         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2499         The object is now destructed in the destructor of QObject.
2500
2501         * QtTestBrowser/webpage.cpp:
2502         (WebPage::WebPage):
2503         (WebPage::setQnamThreaded):
2504         * QtTestBrowser/webpage.h:
2505         (QtNAMThread::QtNAMThread):
2506
2507 2011-01-08  Eric Seidel  <eric@webkit.org>
2508
2509         Reviewed by Ojan Vafai.
2510
2511         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2512         https://bugs.webkit.org/show_bug.cgi?id=52067
2513
2514         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2515         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2516
2517         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2518
2519 2011-01-08  Eric Seidel  <eric@webkit.org>
2520
2521         Reviewed by Mihai Parparita.
2522
2523         commit-queue hangs when the ChangeLog diff is bad
2524         https://bugs.webkit.org/show_bug.cgi?id=52072
2525
2526         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2527         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2528
2529 2011-01-08  Adam Barth  <abarth@webkit.org>
2530
2531         Teach svn-apply how to re-write WebCore to Source/WebCore.
2532
2533         * Scripts/VCSUtils.pm:
2534
2535 2011-01-07  Adam Barth  <abarth@webkit.org>
2536
2537         Rubber-stamped by Eric Seidel.
2538
2539         Move WebCore to Source
2540         https://bugs.webkit.org/show_bug.cgi?id=52050
2541
2542         Update the tools to understand WebCore's new location.
2543
2544         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2545         * DumpRenderTree/wscript:
2546         * GNUmakefile.am:
2547         * Scripts/build-webkit:
2548         * Scripts/do-file-rename:
2549         * Scripts/do-webcore-rename:
2550         * Scripts/generate-qt-inspector-resource:
2551         * Scripts/prepare-ChangeLog:
2552         * Scripts/run-bindings-tests:
2553         * Scripts/update-iexploder-cssproperties:
2554         * Scripts/update-sources-list.py:
2555         * Scripts/update-webkit-localizable-strings:
2556         * Scripts/webkitdirs.pm:
2557         * Scripts/webkitpy/common/config/build.py:
2558         * Scripts/webkitpy/common/config/build_unittest.py:
2559         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2560         * Scripts/webkitpy/style/checker.py:
2561         * Scripts/webkitpy/style/checker_unittest.py:
2562         * WebKitTestRunner/DerivedSources.pro:
2563         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2564         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2565         * wx/browser/wscript:
2566         * wx/build/settings.py:
2567
2568 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2569
2570         Reviewed by Sam Weinig.
2571
2572         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2573         https://bugs.webkit.org/show_bug.cgi?id=52086
2574
2575         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2576         (WTR::InjectedBundle::didReceiveMessage):
2577         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2578         (WTR::LayoutTestController::notifyDone):
2579         * WebKitTestRunner/TestController.cpp:
2580         (WTR::TestController::resetStateToConsistentValues):
2581         (WTR::TestController::run):
2582
2583 2011-01-07  James Robinson  <jamesr@chromium.org>
2584
2585         Revert "Implement mozilla's animationTime property"
2586         https://bugs.webkit.org/show_bug.cgi?id=51952
2587
2588         This approach isn't quite right.
2589
2590         * DumpRenderTree/chromium/WebViewHost.cpp:
2591         (WebViewHost::paintInvalidatedRegion):
2592
2593 2011-01-07  Adam Roben  <aroben@apple.com>
2594
2595         Build master fix
2596
2597         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2598         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2599
2600 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2601
2602         Reviewed by Csaba Osztrogonác.
2603
2604         run-qtwebkit-tests should be able to kill a testsuite.
2605
2606         Add new option in the script that can setup a timeout for a test.
2607         If the test execution takes more then specified time then the test
2608         would be terminated.
2609
2610         [Qt] run-qtwebkit-tests needs timeout
2611         https://bugs.webkit.org/show_bug.cgi?id=51894
2612
2613         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2614         * Scripts/run-qtwebkit-tests:
2615
2616 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2617
2618         Unreviewed fix after r75233.
2619
2620         Based on idea from Eric Seidel.
2621
2622         Add remote zip file handling to webkitpy.
2623         https://bugs.webkit.org/show_bug.cgi?id=50901
2624
2625         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2626
2627 2011-01-07  Shane Stephens  <shanestephens@google.com>
2628
2629         Reviewed by Eric Seidel.
2630
2631         svn-apply: should support git binary delta diffs
2632         https://bugs.webkit.org/show_bug.cgi?id=38864
2633
2634         * Scripts/VCSUtils.pm:
2635         * Scripts/svn-apply:
2636
2637 2011-01-06  Julie Parent  <jparent@chromium.org>
2638
2639         Reviewed by Eric Seidel.
2640
2641         Test Result Server not removing old results.
2642         https://bugs.webkit.org/show_bug.cgi?id=52012
2643
2644         * TestResultServer/model/jsonresults.py:
2645         Fix off-by-one: Truncate if >= num_runs, not just >.
2646         * TestResultServer/model/jsonresults_unittest.py:
2647         Add unit test to test that merging in a new result with the same value
2648         as the last result causes previous result to fall off.
2649
2650 2011-01-06  James Kozianski  <koz@chromium.org>
2651
2652         Reviewed by Mihai Parparita.
2653
2654         Add classes to provide a consistent interface to a set of files.
2655         https://bugs.webkit.org/show_bug.cgi?id=50901
2656
2657         These classes allow us to write code that is agnostic to whether a
2658         particular set of files resides in a local directory or in a zip file
2659         on a remote machine.
2660
2661         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2662         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2663         * Scripts/webkitpy/common/system/fileset.py: Added.
2664         * Scripts/webkitpy/common/system/filesystem.py:
2665         * Scripts/webkitpy/common/system/filesystem_mock.py:
2666         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2667         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2668
2669 2011-01-06  Eric Seidel  <eric@webkit.org>
2670
2671         Reviewed by Adam Barth.
2672
2673         NetworkTransaction should log the url it is retrying
2674         https://bugs.webkit.org/show_bug.cgi?id=52043
2675
2676         * Scripts/webkitpy/common/net/networktransaction.py:
2677         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2678
2679 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2680
2681         Windows build fix.
2682         Import os before using it.
2683
2684         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2685
2686 2011-01-06  Eric Seidel  <eric@webkit.org>
2687
2688         Reviewed by Adam Barth.
2689
2690         StyleQueue fails to report errors when patches have many files
2691         https://bugs.webkit.org/show_bug.cgi?id=52042
2692
2693         This is one of at least two errors preventing style error reporting at the moment.
2694         When we moved to passing the list of files to check explicitly,
2695         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2696         We could change the type of the QueueStatus.message type, or we could
2697         just teach statusserver.py how to clamp values (and warn when it does).
2698         I chose the latter path.
2699
2700         * Scripts/webkitpy/common/net/statusserver.py:
2701
2702 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2703
2704         Reviewed by Stephanie Lewis.
2705         
2706         Fix syntax error in script.
2707
2708         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2709         https://bugs.webkit.org/show_bug.cgi?id=51996
2710
2711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2712
2713 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2714
2715         Unreviewed, fixing WinCE build after r75196.
2716
2717         WinCE port does not (yet) support NPAPI.
2718
2719         * Scripts/build-webkit:
2720
2721 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2722
2723         Reviewed by Darin Adler.
2724
2725         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2726         https://bugs.webkit.org/show_bug.cgi?id=52015
2727
2728         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2729         after the platform has been detected, otherwise the script will
2730         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2731         detection.
2732
2733 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2734
2735         Reviewed by Eric Seidel.
2736
2737         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2738         https://bugs.webkit.org/show_bug.cgi?id=51346
2739
2740         * Scripts/build-webkit:
2741
2742 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2743
2744         Reviewed by Adam Roben.
2745
2746         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2747         https://bugs.webkit.org/show_bug.cgi?id=51996
2748         
2749         After the configuration directory change, we were archiving the incorrect directory for
2750         build product, so we were running tests on the wrong binaries.
2751         
2752         This change archives the correct directory, and also unarchives it into a configuration-
2753         specific directory.
2754
2755         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2756         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2757
2758 2011-01-06  Eric Seidel  <eric@webkit.org>
2759
2760         Reviewed by Mihai Parparita.
2761
2762         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2763         https://bugs.webkit.org/show_bug.cgi?id=52002
2764
2765         See an example of this here:
2766         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2767
2768         It's due to the fact that we pass around TestFailure() instance
2769         objects and yet expect them to all compare to be the same.
2770
2771         This is bad.  We should either have shared instances of these values
2772         or we should just pass around the class names.  There are already hacks
2773         in place to make TestFailure objects pass equality tests, I just added
2774         a __hash__ implementation so they can be used in sets as expected.
2775
2776         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2777         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2778
2779 2011-01-06  Evan Martin  <evan@chromium.org>
2780
2781         Reviewed by Tony Chang.
2782
2783         [gdb] handle inaccessible memory and UChar*
2784         https://bugs.webkit.org/show_bug.cgi?id=52003
2785
2786         To pretty-print a UChar*, we just grope around in the memory
2787         looking for a terminating NUL.  We need to handle the exception
2788         that can occur when we poke into an invalid location.
2789
2790         Additionally, the logic for choosing which pretty-printer would
2791         early return before hitting the point where we'd use the UChar*
2792         printer.  (Did this ever work?  How did it regress?)
2793
2794         * gdb/webkit.py:
2795
2796 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2797
2798         Reviewed by Ada Chan.
2799
2800         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2801         https://bugs.webkit.org/show_bug.cgi?id=51969
2802         
2803         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2804
2805         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2806         (WTR::InjectedBundlePage::InjectedBundlePage):
2807         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2808         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2809
2810 2011-01-06  James Robinson  <jamesr@chromium.org>
2811
2812         Reviewed by Simon Fraser.
2813
2814         Implement mozilla's animationTime property
2815         https://bugs.webkit.org/show_bug.cgi?id=51952
2816
2817         Chromium DRT support for webkitAnimationTime.
2818
2819         * DumpRenderTree/chromium/WebViewHost.cpp:
2820         (WebViewHost::paintInvalidatedRegion):
2821
2822 2011-01-06  Julie Parent  <jparent@chromium.org>
2823
2824         Reviewed by Tony Chang.
2825
2826         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2827         https://bugs.webkit.org/show_bug.cgi?id=51217
2828
2829         * TestResultServer/model/jsonresults.py:
2830         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2831         Adds missing documentation.
2832         * TestResultServer/model/jsonresults_unittest.py:
2833         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2834         Update test_merge to take a number of builds to truncate at.
2835
2836 2011-01-06  Adam Barth  <abarth@webkit.org>
2837
2838         Reviewed by Eric Seidel.
2839
2840         The EWS should log outside of the working directory
2841         https://bugs.webkit.org/show_bug.cgi?id=51986
2842
2843         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2844         script, which will actually clean the working copy back to a pristine
2845         state instead of leaving untracked directories and ignored files.
2846
2847         * Scripts/webkitpy/tool/commands/queues.py:
2848         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2849
2850 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2851
2852         Windows build fix.
2853         Back out attempted change to built-product-archive.
2854
2855         * BuildSlaveSupport/built-product-archive:
2856
2857 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2858
2859         Windows build fix.
2860         Include configuration name when unpacking a build archive.
2861
2862         Needed, since we split Windows build results into configuration-specific directories
2863         under WebKitOutputDir.
2864
2865         * BuildSlaveSupport/built-product-archive:
2866
2867 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2868
2869         Reviewed by Darin Adler.
2870
2871         Debug and Release builds on Windows clobber each other
2872         https://bugs.webkit.org/show_bug.cgi?id=49185
2873
2874         Changes the structure of WebKitBuild build products directory so we
2875         completely separate each build configuration into independent directories.
2876         
2877         Although we previously had per-configuration directories for obj, this change adds
2878         per-configuration directories for bin, lib, obj, and include. Each configuration's
2879         build products are stored within a directory inside of WebKitBuild.
2880         
2881         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2882         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2883
2884         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2885         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2886         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2887         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2888         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2889         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2890         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2891         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2892         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2893         * FindSafari/FindSafari.vcproj:
2894         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2895         * MiniBrowser/MiniBrowserPostBuild.cmd:
2896         * MiniBrowser/MiniBrowserPreBuild.cmd:
2897         * Scripts/webkitdirs.pm:
2898         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2899         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2900         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2901         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2902         * TestWebKitAPI/win/copy-resources.cmd:
2903         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2904         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2905         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2906         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2907         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2908         * WebKitTestRunner/win/InjectedBundle.vcproj:
2909         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2910         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2911         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2912         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2913         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2914         * WinLauncher/WinLauncherCommon.vsprops:
2915         * WinLauncher/WinLauncherPostBuild.cmd:
2916         * WinLauncher/WinLauncherPreBuild.cmd:
2917
2918 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2919
2920         Reviewed by Ariya Hidayat.
2921
2922         [Qt] TestNetscapePlugin doesn't link on OS X
2923         https://bugs.webkit.org/show_bug.cgi?id=51948
2924
2925         Only add a dependency on libX11 on X11 systems
2926
2927         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2928
2929 2011-01-05  Jeff Miller  <jeffm@apple.com>
2930
2931         Reviewed by Adam Roben.
2932
2933         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2934         https://bugs.webkit.org/show_bug.cgi?id=51970
2935
2936         * Scripts/webkitpy/style/checker.py:
2937         Add -readability/naming for WebKit2 C API directories.
2938
2939 2011-01-05  Eric Seidel  <eric@webkit.org>
2940
2941         Unreviewed, just fixing one more log error from my previous python patch.
2942
2943         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2944         https://bugs.webkit.org/show_bug.cgi?id=51802
2945
2946         webkit-patch failure-reason was logging about parsing errors
2947         due to my misunderstanding of how BeautifulSoup.findAll worked.
2948
2949         Fixed, and added a unit test.
2950
2951         * Scripts/webkitpy/common/net/layouttestresults.py:
2952         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2953
2954 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2955
2956         Reviewed by Kenneth Rohde Christiansen.
2957
2958         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2959         https://bugs.webkit.org/show_bug.cgi?id=51951
2960
2961         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2962         to create new window from WebKit.
2963
2964         * MiniBrowser/qt/BrowserWindow.cpp:
2965         (newPageFunction):
2966         (BrowserWindow::BrowserWindow):
2967         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2968         (BrowserWindow::newWindow):
2969         (BrowserWindow::updateUserAgentList):
2970         (BrowserWindow::showUserAgentDialog):
2971         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2972         define the type of the backing store used for new windows.
2973         * MiniBrowser/qt/main.cpp:
2974         (main):
2975
2976 2011-01-05  Eric Seidel  <eric@webkit.org>
2977
2978         Reviewed by Ojan Vafai.
2979
2980         commit-queue should report failure type when reporting flaky tests
2981         https://bugs.webkit.org/show_bug.cgi?id=51900
2982
2983         This patch was a ridiculous amount of plumbing.  In the end I like
2984         the NRWT-style TestResult class even less.  But now we're passing
2985         a list of TestResult objects from the queue to the FlakyTestReporter.
2986         Thus the FlakyTestReporter can more easily report what type of failure
2987         occurred.
2988
2989         In the process, I found that I was not alone in finding TestResult
2990         cumbersome to use.  A bunch of code was trying to create a TestResult
2991         object with default values.  However since the constructor didn't make
2992         this easy, some places were getting it wrong (including the TestResult unit test)!
2993         I've fixed the TestResult constructor to have default values for non-essential
2994         arguments.
2995
2996         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2997         * Scripts/webkitpy/common/net/layouttestresults.py:
2998         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2999         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3000         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3001         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3002         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3003         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3004         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3005         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3006         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3007         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3008         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3009         * Scripts/webkitpy/tool/commands/queues.py:
3010         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3011
3012 2011-01-05  Eric Seidel  <eric@webkit.org>
3013
3014         Unreviewed.
3015
3016         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3017         https://bugs.webkit.org/show_bug.cgi?id=51802
3018
3019         Add another unit test to cover a previously missing import.
3020
3021         * Scripts/webkitpy/common/net/layouttestresults.py:
3022         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3023
3024 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3025
3026         Reviewed by David Levin.
3027
3028         Add mihaip@chromium.org as a reviewer
3029         https://bugs.webkit.org/show_bug.cgi?id=51966
3030         
3031         Add myself as a reviewer.
3032
3033         * Scripts/webkitpy/common/config/committers.py:
3034
3035 2011-01-05  James Simonsen  <simonjam@chromium.org>
3036
3037         Unreviewed. Adding myself to the list of committers.
3038
3039         * Scripts/webkitpy/common/config/committers.py:
3040
3041 2011-01-05  Eric Seidel  <eric@webkit.org>
3042
3043         Unreviewed.
3044
3045         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3046         https://bugs.webkit.org/show_bug.cgi?id=51802
3047
3048         Fix two exceptions seen on the bots after my original commit.
3049
3050         * Scripts/webkitpy/common/net/layouttestresults.py:
3051         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3052
3053 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3054
3055         Reviewed by Andreas Kling.
3056
3057         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3058         https://bugs.webkit.org/show_bug.cgi?id=51750
3059
3060         * QtTestBrowser/main.cpp:
3061         (LauncherApplication::handleUserOptions):
3062          Local storage settings can be enable form command line arguments for
3063          QtTestBrowser.
3064
3065 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3066
3067         Reviewed by Martin Robinson.
3068
3069         GTK: AX: DRT needs to use correct root object method.
3070         https://bugs.webkit.org/show_bug.cgi?id=51911
3071
3072         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3073         (AccessibilityController::rootElement):
3074
3075 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3076
3077         Rubber-stamped by Csaba Osztrogonác.
3078
3079         Based on idea from Péter Gál.
3080
3081         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3082
3083 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3084
3085         Reviewed by Adam Barth.
3086
3087         sheriff-bot should be able to do multi-revision rollouts
3088         https://bugs.webkit.org/show_bug.cgi?id=51176
3089
3090         * Scripts/webkitpy/tool/bot/irc_command.py:
3091         * Scripts/webkitpy/tool/bot/sheriff.py:
3092         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3093
3094 2011-01-05  Eric Seidel  <eric@webkit.org>
3095
3096         Reviewed by Adam Barth.
3097
3098         queues.webkit.org should have per-bot status pages
3099         https://bugs.webkit.org/show_bug.cgi?id=51906
3100
3101         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3102         statuses from a single queue.  Now that we have many bots servicing
3103         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3104         you care about scroll off the end of the 15-message limit on the main page.
3105
3106         Eventually we should probably rename /queue-status to /queue or /queues,
3107         but that's fodder for another patch.
3108
3109         * QueueStatusServer/handlers/queuestatus.py:
3110         * QueueStatusServer/index.yaml:
3111         * QueueStatusServer/main.py:
3112         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3113          - This probably should use a custom filter instead of hard-coding
3114            the URL scheme here, but I couldn't figure out how to easily
3115            create such a filter.  Most filters work with "strings" so we can't
3116            pass the status object.  We could add a method to the status
3117            object and call that, but that seemed a bit strange too.
3118         * QueueStatusServer/templates/queuestatus.html:
3119
3120 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3121
3122         Unreviewed. Adding myself to the list of committers.
3123
3124         * Scripts/webkitpy/common/config/committers.py:
3125
3126 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3127
3128         Reviewed by David Levin.
3129
3130         check-webkit-style treated some macros with parentheses after #elif as function calls
3131         https://bugs.webkit.org/show_bug.cgi?id=51695
3132
3133         Ingore function call space checking in any preprocessor directives
3134         (things starting with #). Change search() to match() because 
3135         preprocessor directives are supposed to be in the beginning of lines.
3136
3137         * Scripts/webkitpy/style/checkers/cpp.py:
3138         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3139
3140 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3141
3142         Reviewed by Tony Chang.
3143
3144         Change the --multi-load test option to --stress-opt
3145         https://bugs.webkit.org/show_bug.cgi?id=50751
3146
3147         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3148         (runTest):
3149         (main):
3150         * DumpRenderTree/chromium/TestShell.cpp:
3151         (TestShell::TestShell):
3152         * DumpRenderTree/chromium/TestShell.h:
3153         (TestShell::stressOpt):
3154         (TestShell::setStressOpt):
3155         (TestShell::stressDeopt):
3156         (TestShell::setStressDeopt):
3157         (TestShell::javaScriptFlags):
3158         (TestShell::setJavaScriptFlags):
3159         * Scripts/webkitpy/layout_tests/port/chromium.py:
3160         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3161
3162 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3163
3164         Reviewed by Sam Weinig.
3165
3166         WK2: Support Accessibility
3167         https://bugs.webkit.org/show_bug.cgi?id=51859
3168
3169         Use rootObject() method to get top of accessibility tree.
3170
3171         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3172         (AccessibilityController::focusedElement):
3173         (AccessibilityController::rootElement):
3174
3175 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3176
3177         Reviewed by Darin Adler.
3178
3179         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3180         https://bugs.webkit.org/show_bug.cgi?id=51846
3181
3182         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3183         back to GRefPtr.
3184
3185 2011-01-04  Zhe Su  <suzhe@chromium.org>
3186
3187         Reviewed by Kenneth Russell.
3188
3189         Fix insertText, setMarkedText and unmarkText methods of
3190         TextInputController to call corresponding methods of WebKit::WebView
3191         rather than WebKit::WebFrame. This change matches the behavior of
3192         chromium browser.
3193         insertText corresponds to WebView::confirmComposition(text)
3194         setMarkedText corresponds to WebView::setComposition(...)
3195         unmarkText corresponds to WebView::confirmComposition()
3196         https://bugs.webkit.org/show_bug.cgi?id=51693
3197
3198         * DumpRenderTree/chromium/TextInputController.cpp:
3199         (TextInputController::insertText):
3200         (TextInputController::setMarkedText):
3201         (TextInputController::unmarkText):
3202
3203 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3204
3205         Reviewed by Laszlo Gombos.
3206
3207         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3208
3209         On Symbian productDir points to the source directory. Removing all the
3210         empty files from the productDir directory corrupts the svn repository.
3211
3212         * Scripts/build-webkit:
3213
3214 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3215
3216         Reviewed by Adam Barth.
3217
3218         [Qt] Add SelectAll option to the context menu for the editor
3219         https://bugs.webkit.org/show_bug.cgi?id=50049
3220
3221         Set shortcut for the SelectAll action.
3222
3223         * QtTestBrowser/mainwindow.cpp:
3224         (MainWindow::buildUI):
3225
3226 2011-01-03  David Levin  <levin@chromium.org>
3227
3228         Reviewed by Eric Seidel.
3229
3230         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3231         https://bugs.webkit.org/show_bug.cgi?id=51842
3232
3233         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3234         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3235
3236 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3237
3238         Reviewed by David Kilzer.
3239
3240         [WINCE] Adds a build slave.
3241         https://bugs.webkit.org/show_bug.cgi?id=50523
3242
3243         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3244         entry for a release build of the WinCE port.
3245         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3246         flag to build the WinCE port.
3247
3248 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3249
3250         Reviewed by David Kilzer.
3251
3252         Add WinCE support to build-webkit
3253         https://bugs.webkit.org/show_bug.cgi?id=51642
3254
3255         * Scripts/build-webkit:
3256         * Scripts/webkitdirs.pm:
3257
3258 2011-01-03  Eric Seidel  <eric@webkit.org>
3259
3260         Reviewed by Adam Barth.
3261
3262         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3263         https://bugs.webkit.org/show_bug.cgi?id=51802
3264
3265         I'm not the biggest fan of the test_failures or test_results classes,
3266         but it's better to have one shared set of classes, than separate ones
3267         for new vs. old run-webkit-test result handling.
3268
3269         This moves the ORWT results class "LayoutTestResults" over to using
3270         TestResult and TestFailure classes, making it easy for us to
3271         make all our sheriff-bot and other webkitpy code NRWT ready.
3272
3273         This also makes it a trivial patch to generate results.json information
3274         from ORWT results.html files (for flaky test analysis, etc.) as well
3275         as making it a one-liner to report test failure types when the
3276         commit-queue sees flaky tests.
3277
3278         This patch tried not to add new functionality, but only to replace
3279         the guts of LayoutTestResults, while adding unit tests and hoping
3280         not to break anything.
3281
3282         I also moved callers which assumed User.prompt* were static/class methods
3283         to using them as instance methods (since we'll eventually want to make them such).
3284
3285         In the process of re-writing things, I broke the rebaseline command, so I wrote
3286         a unit test to catch my breakage were I do do so again in the future.
3287
3288         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3289         * Scripts/webkitpy/common/net/layouttestresults.py:
3290         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3291         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3292         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3293         * Scripts/webkitpy/tool/commands/queries.py:
3294         * Scripts/webkitpy/tool/commands/rebaseline.py:
3295         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3296         * Scripts/webkitpy/tool/mocktool.py:
3297
3298 2011-01-03  Adam Barth  <abarth@webkit.org>
3299
3300         Reviewed by Simon Fraser.
3301
3302         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3303         https://bugs.webkit.org/show_bug.cgi?id=51840
3304
3305         * Scripts/webkitpy/common/checkout/scm.py:
3306
3307 2011-01-03  Adam Barth  <abarth@webkit.org>
3308
3309         Reviewed by Simon Fraser.
3310
3311         webkit-patch should only hide update output if --quiet
3312         https://bugs.webkit.org/show_bug.cgi?id=51838
3313
3314         As requested by smfr.
3315
3316         * Scripts/webkitpy/tool/steps/update.py:
3317
3318 2011-01-03  Adam Barth  <abarth@webkit.org>
3319
3320         Reviewed by David Levin.
3321
3322         commit-queue shouldn't reject patches twice if two bots process the same patch
3323         https://bugs.webkit.org/show_bug.cgi?id=51805
3324
3325         Before raising an error, we first check whether the patch is still in
3326         the commit-queue.  This check is still racy, of course, but the time
3327         window is much smaller.
3328
3329         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3330
3331 2011-01-03  Sam Weinig  <sam@webkit.org>
3332
3333         Reviewed by Anders Carlsson.
3334
3335         Make run-api-tests less chatty.
3336         https://bugs.webkit.org/show_bug.cgi?id=51831
3337
3338         - Make script quiet by default and add --verbose option (replacing --quiet).
3339         - When not verbose, pipe stdout and stderr to devnull.
3340
3341         * Scripts/run-api-tests:
3342
3343 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3344
3345         Unreviewed. Adding myself to committers.py.
3346
3347         * Scripts/webkitpy/common/config/committers.py:
3348
3349 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3350
3351         Reviewed by Xan Lopez.
3352
3353         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3354         https://bugs.webkit.org/show_bug.cgi?id=51806
3355
3356         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3357         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3358         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3359         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3360         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3361         so make it 'WebKitBuild/Release/.libs'
3362
3363         * Scripts/webkitdirs.pm: 
3364
3365 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3366
3367         Reviewed by Adam Barth.
3368
3369         Make EFL a core builder
3370         https://bugs.webkit.org/show_bug.cgi?id=51804
3371
3372         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3373         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3374
3375 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3376
3377         [Qt] Unreviewed fix after r74855 and r74875.
3378
3379         * BuildSlaveSupport/built-product-archive:
3380          - Create directories explicitly.
3381          - Pass shell=True to subprocess.call().
3382
3383 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3384
3385         [Qt] Unreviewed fix after r74855.
3386
3387         Move JavaScriptCore to Source
3388         https://bugs.webkit.org/show_bug.cgi?id=51604
3389
3390         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3391
3392 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3393
3394         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3395
3396         Move JavaScriptCore to Source
3397         https://bugs.webkit.org/show_bug.cgi?id=51604
3398
3399         * Scripts/webkitdirs.pm:
3400
3401 2011-01-02  Robert Hogan  <robert@webkit.org>
3402
3403         Unreviewed, build fix.
3404
3405         [Qt] Fix DRT build after 74855
3406
3407         * DumpRenderTree/qt/DumpRenderTree.pro:
3408
3409 2011-01-01  Adam Barth  <abarth@webkit.org>
3410
3411         Remove the assumption from the Qt and Gtk builds that every project is
3412         in the root directory.
3413
3414         * Scripts/build-webkit:
3415
3416 2011-01-01  Adam Barth  <abarth@webkit.org>
3417
3418         Reviewed by Eric Seidel.
3419
3420         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3421         https://bugs.webkit.org/show_bug.cgi?id=51796
3422
3423         After this change, svn-apply will magically apply patches to
3424         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3425
3426         * Scripts/VCSUtils.pm:
3427
3428 2011-01-01  Adam Barth  <abarth@webkit.org>
3429
3430         Reviewed by Eric Seidel.
3431
3432         Move JavaScriptCore to Source
3433         https://bugs.webkit.org/show_bug.cgi?id=51604
3434
3435         Update references to JavaScriptCore to point to the new location.
3436
3437         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3438         * DumpRenderTree/qt/DumpRenderTree.pro:
3439         * DumpRenderTree/qt/ImageDiff.pro:
3440         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3441         * DumpRenderTree/wscript:
3442         * Scripts/build-jsc:
3443         * Scripts/build-webkit:
3444         * Scripts/do-file-rename:
3445         * Scripts/do-webcore-rename:
3446         * Scripts/run-javascriptcore-tests:
3447         * Scripts/update-javascriptcore-test-results:
3448         * Scripts/webkitdirs.pm:
3449         * Scripts/webkitpy/common/config/build_unittest.py:
3450         * Scripts/webkitpy/style/checker.py:
3451         * Scripts/webkitpy/style/checker_unittest.py:
3452         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3453         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3454         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3455         * wx/build/settings.py:
3456
3457 2011-01-01  Adam Barth  <abarth@webkit.org>
3458
3459         Reviewed by Eric Seidel.
3460
3461         Move Sources to Source
3462         https://bugs.webkit.org/show_bug.cgi?id=51794
3463
3464         Update scripts to point to the new location.
3465
3466         * Scripts/build-webkit:
3467         * Scripts/do-file-rename:
3468         * Scripts/do-webcore-rename:
3469         * Scripts/webkitpy/common/config/build.py:
3470         * Scripts/webkitpy/common/config/build_unittest.py:
3471
3472 2010-12-31  Kent Tamura  <tkent@chromium.org>
3473
3474         Reviewed by Eric Seidel.
3475
3476         [DRT/Chromium] Enable mock spell checker on non-OSX
3477         https://bugs.webkit.org/show_bug.cgi?id=51401
3478
3479         * DumpRenderTree/chromium/WebViewHost.cpp:
3480         (WebViewHost::spellCheck):
3481
3482 2010-12-31  Adam Barth  <abarth@webkit.org>
3483
3484         Reviewed by Ariya Hidayat.
3485
3486         Remove Tools/Scripts/wkstyle
3487         https://bugs.webkit.org/show_bug.cgi?id=51774
3488
3489         This script appears to not have been touched in a while and seems to
3490         have been replaced by check-webkit-style.
3491
3492         * Scripts/wkstyle: Removed.
3493
3494 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3495
3496         Unreviewed. Coding style fix.
3497
3498         * DumpRenderTree/chromium/TestShell.h:
3499
3500 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3501
3502         Reviewed by Pavel Feldman.
3503
3504         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3505
3506         It was a problem with Chromium DRT. DevToolsAgent object instance was
3507         attached not only to the inspected page but to the DevTools window too.
3508         As result all the inspector files were interpreted as a content of inspected page
3509         and were transfered to the DevTools scripts panel for debugging etc.
3510
3511         https://bugs.webkit.org/show_bug.cgi?id=51735
3512
3513         * DumpRenderTree/chromium/TestShell.cpp:
3514         (TestShell::TestShell):
3515         (TestShell::bindJSObjectsToWindow):
3516         (TestShell::createNewWindow):
3517         * DumpRenderTree/chromium/TestShell.h:
3518
3519 2010-12-31  Adam Barth  <abarth@webkit.org>
3520
3521         Rubber-stamped by Eric Seidel.
3522
3523         Move PageLoadTests to PerformanceTests/PageLoad
3524         https://bugs.webkit.org/show_bug.cgi?id=51771
3525
3526         Update references to PageLoadTests to point to the new location.
3527
3528         * Scripts/run-pageloadtest:
3529         * Scripts/webkitpy/common/config/build.py:
3530
3531 2010-12-31  Adam Barth  <abarth@webkit.org>
3532
3533         Rubber-stamped by Eric Seidel.
3534
3535         Move SunSpider into PerformanceTests
3536         https://bugs.webkit.org/show_bug.cgi?id=51769
3537
3538         Update these scripts to point to the new location.
3539
3540         * Scripts/run-sunspider:
3541         * Scripts/sunspider-compare-results:
3542
3543 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3544
3545         Reviewed by Kent Tamura.
3546
3547         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3548         https://bugs.webkit.org/show_bug.cgi?id=51728
3549         
3550         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3551         to render top-level scrollbars. This makes them match the Mac port's
3552         use of an NSScrollView, which means that we'll be able to share more
3553         pixel baselines.
3554         
3555         The new rendering code will not be activated until the 
3556         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3557         ScrollbarThemeChromiumMac.
3558
3559         * DumpRenderTree/DumpRenderTree.gypi:
3560         * DumpRenderTree/chromium/TestShellMac.mm:
3561         (platformInit):
3562         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3563         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3564         (+[FakeActiveWindow alwaysActiveWindow]):
3565         (+[FakeActiveWindow alwaysInactiveWindow]):
3566         (-[FakeActiveWindow initWithActiveControls:]):
3567         (-[FakeActiveWindow _hasActiveControls]):
3568         (WebThemeEngineDRTMac::paintScrollbarThumb):
3569         (stateToHIEnableState):
3570         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3571         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3572
3573 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3574
3575         Reviewed by David Kilzer.
3576
3577         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3578         used
3579         https://bugs.webkit.org/show_bug.cgi?id=51672
3580
3581         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3582         with USE_SYSTEM_MALLOC=1
3583         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3584         with USE_SYSTEM_MALLOC=1
3585
3586 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3587
3588         Reviewed by David Kilzer.
3589
3590         [Qt] [Symbian] Fix build-webkit script for Symbian
3591         https://bugs.webkit.org/show_bug.cgi?id=51509
3592
3593         Set the OUTPUT_DIR for Symbian to be the same as the source
3594         directory.
3595
3596         * Scripts/webkitdirs.pm:
3597
3598 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3599
3600         Reviewed by Darin Adler.
3601
3602         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3603         https://bugs.webkit.org/show_bug.cgi?id=51758
3604
3605         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3606
3607         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3608         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3609
3610 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3611
3612         Unreviewed WinCE buildfix.
3613
3614         * WinCELauncher/main.cpp: Add missing include.
3615
3616 2010-12-29  Daniel Bates  <dbates@rim.com>
3617
3618         Reviewed by Darin Adler.
3619
3620         svn-apply updates date of wrong change log entry for a change log diff that
3621         contains two consecutive entries with the same author and date
3622         https://bugs.webkit.org/show_bug.cgi?id=46061
3623
3624         Fixes an issue where the date of the wrong change log entry may be modified.
3625         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3626         in a ChangeLog file to the top of the file.
3627
3628         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3629         diff when it detects that the diff inserts a change log entry earlier in a
3630         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3631         change. With the advent of the commit-queue this functionality of bailing out
3632         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3633         Instead, we should always move the change log entry to the top of the ChangeLog file.
3634
3635         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3636         the date line of the correct change log entry in a ChangeLog diff.
3637
3638         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3639
3640         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3641           Updated the following unit tests now that we move entries inserted earlier to the top:
3642           - "fixChangeLogPatch: New entry inserted in middle."
3643             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3644
3645           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3646             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3647
3648         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3649
3650 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3651
3652         Reviewed by Eric Seidel.
3653
3654         [Qt] Fixed compatibility with gold linker on X11 platforms
3655         https://bugs.webkit.org/show_bug.cgi?id=51700
3656
3657         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3658         Linked TestNetscapePlugin with libX11 on Unix platforms
3659
3660 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3661
3662         Reviewed by Darin Adler.
3663
3664         Circular dependency in webkitpy.common.checkout.changelog module
3665         https://bugs.webkit.org/show_bug.cgi?id=50475
3666
3667         Remove automatic import of api.Checkout module when any checkout/
3668         submodule is imported (e.g.: when checkout.scm.Git is imported).
3669
3670         * Scripts/webkitpy/common/checkout/__init__.py:
3671
3672 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3673
3674         Reviewed by Ojan Vafai.
3675
3676         prepare-ChangeLog should support the -g option for specifying the git-commit
3677         https://bugs.webkit.org/show_bug.cgi?id=51708
3678
3679         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3680         webkit-patch, though the exact meaning of the two options remain different.
3681
3682         * Scripts/prepare-ChangeLog: Add -g.
3683
3684 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3685
3686         Reviewed by Simon Hausmann.
3687
3688         [Qt] Fix compilation with Qt in namespace
3689         https://bugs.webkit.org/show_bug.cgi?id=51701
3690
3691         * QtTestBrowser/webview.h:
3692
3693 2010-12-28  Daniel Bates  <dbates@rim.com>
3694
3695         Reviewed by Sam Weinig.
3696
3697         Substitute // MARK: for compiler-specific #pragma mark
3698         https://bugs.webkit.org/show_bug.cgi?id=51657
3699
3700         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3701         substituting  "// MARK:" for "#pragma mark", which provides
3702         analogous code-bookmarking functionality under Xcode.
3703
3704         Also, for consistency, we should substitute "// MARK:" for compiler-
3705         specific "#pragma mark" in the source files for the Mac port.
3706
3707         * DumpRenderTree/AccessibilityTextMarker.cpp:
3708         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3709         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3710         * DumpRenderTree/mac/ObjCController.m:
3711         * MiniBrowser/mac/AppDelegate.m:
3712         * MiniBrowser/mac/BrowserWindowController.m:
3713
3714 2010-12-28  Xan Lopez  <xlopez@igalia.com>