Access expectations path through apple_additions
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
2
3         Access expectations path through apple_additions
4         https://bugs.webkit.org/show_bug.cgi?id=174800
5         <rdar://problem/33498899>
6
7         Reviewed by David Kilzer.
8
9         Follow-up fix. Mapping of operating system names was done incorrectly.
10
11         * Scripts/webkitpy/port/ios.py:
12         (IOSPort._apple_additions_path): Correctly find the operating system to be replaced.
13         * Scripts/webkitpy/port/ios_device_unittest.py:
14         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
15         system name replacement.
16         * Scripts/webkitpy/port/ios_simulator_unittest.py:
17         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
18         system name replacement.
19         * Scripts/webkitpy/port/mac.py: Correctly find the operating system to be replaced.
20         (MacPort._apple_additions_path):
21         * Scripts/webkitpy/port/mac_unittest.py:
22         (MacTest.test_layout_test_searchpath_with_apple_additions): Add test for operating system
23         name replacement.
24         * Scripts/webkitpy/port/port_testcase.py:
25         (bind_mock_apple_additions.MockAppleAdditions.ios_os_name): Change the passed name so that
26         operating system name replacement can be tested.
27         (bind_mock_apple_additions.MockAppleAdditions.mac_os_name): Ditto.
28
29 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
30
31         Access expectations path through apple_additions
32         https://bugs.webkit.org/show_bug.cgi?id=174800
33         <rdar://problem/33498899>
34
35         Reviewed by Alexey Proskuryakov.
36
37         When external test expectations are imported through additional-platform-directory, they will
38         over-write any WebKit expectations. Access some expectations from apple_additions to correct
39         these precedence issues.
40
41         * Scripts/webkitpy/port/ios.py:
42         (IOSPort._apple_additions_path): Convert test expectation directory to a path
43         coming from apple_additions.
44         (IOSPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
45         path for layout test expectations.
46         * Scripts/webkitpy/port/ios_device_unittest.py:
47         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
48         * Scripts/webkitpy/port/ios_simulator_unittest.py:
49         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
50         * Scripts/webkitpy/port/mac.py:
51         (MacPort._apple_additions_path): Convert test expectation directory to a path
52         coming from apple_additions.
53         (MacPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
54         path for layout test expectations.
55         * Scripts/webkitpy/port/mac_unittest.py:
56         (MacTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
57         * Scripts/webkitpy/port/port_testcase.py:
58         (bind_mock_apple_additions): Added to create mock apple_additions for a block.
59         (bind_mock_apple_additions.MockAppleAdditions): Contains apple_addition stubs for testing.
60         * Scripts/webkitpy/port/win.py:
61         (WinPort.default_baseline_search_path): Include apple_additions test expectation for Windows.
62
63 2017-08-22  Zan Dobersek  <zdobersek@igalia.com>
64
65         Unreviewed. The WPE port should build TestWebKitAPI with the same
66         compiler flags as the GTK+ port, disabling a few flags that are
67         sprouting a lot of warning output.
68
69         * TestWebKitAPI/PlatformWPE.cmake:
70
71 2017-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
72
73         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
74         https://bugs.webkit.org/show_bug.cgi?id=175116
75         <rdar://problem/28279301>
76
77         Reviewed by Darin Adler and Ryosuke Niwa.
78
79         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
80         EditorStateTests run on both iOS and Mac.
81
82         * TestWebKitAPI/EditingTestHarness.h: Added.
83         * TestWebKitAPI/EditingTestHarness.mm: Added.
84
85         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
86         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
87         the state of the latest observed EditorState.
88
89         (-[EditingTestHarness initWithWebView:]):
90         (-[EditingTestHarness dealloc]):
91         (-[EditingTestHarness webView]):
92         (-[EditingTestHarness latestEditorState]):
93         (-[EditingTestHarness editorStateHistory]):
94         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
95         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
96         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
97         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
98         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
99         (-[EditingTestHarness toggleBold]):
100         (-[EditingTestHarness toggleItalic]):
101         (-[EditingTestHarness toggleUnderline]):
102         (-[EditingTestHarness setForegroundColor:]):
103         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
104         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
105         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
106         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
107         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
108         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
109         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
110
111         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
112         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
113         keys and values.
114
115         (-[EditingTestHarness latestEditorStateContains:]):
116         (-[EditingTestHarness _webView:editorStateDidChange:]):
117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
118         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
119         (TestWebKitAPI::setUpEditorStateTestHarness):
120         (TestWebKitAPI::TEST):
121         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
122
123 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
124
125         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
126         https://bugs.webkit.org/show_bug.cgi?id=175370
127         <rdar://problem/33799806>
128
129         Reviewed by Ryosuke Niwa.
130
131         Tweaks API tests that involve editing to wait for a presentation update before checking against UI process-side
132         information sent via EditorState updates. This allows any EditorState update scheduled by the test to propagate
133         to the UI process.
134
135         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
136         (-[CandidateTestWebView typeString:inputMessage:]):
137         (+[CandidateTestWebView setUpWithFrame:testPage:]):
138         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
139         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
140         (TestWebKitAPI::AcceptsFirstMouse::runTest):
141         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
142         * TestWebKitAPI/cocoa/TestWKWebView.h:
143         * TestWebKitAPI/cocoa/TestWKWebView.mm:
144         (-[TestWKWebView waitForNextPresentationUpdate]):
145
146         Add a new helper method to spin until the next presentation update.
147
148         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
149         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
150         (TestWebKitAPI::WebKitAgnosticTest::waitForNextPresentationUpdate):
151
152 2017-08-22  Alex Christensen  <achristensen@webkit.org>
153
154         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
155         https://bugs.webkit.org/show_bug.cgi?id=175797
156         <rdar://problem/29270035>
157
158         Reviewed by Geoffrey Garen.
159
160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
161         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
162         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
163         (-[UITestDelegate _showPage:]):
164         (-[UITestDelegate webView:startURLSchemeTask:]):
165         (-[UITestDelegate webView:stopURLSchemeTask:]):
166         (TEST):
167
168 2017-08-22  Devin Rousso  <webkit@devinrousso.com>
169
170         Unreviewed, change my IRC nick.
171
172         * Scripts/webkitpy/common/config/contributors.json:
173
174 2017-08-22  Matt Lewis  <jlewis3@apple.com>
175
176         Unreviewed, rolling out r221026.
177
178         This caused a consistent API failure on iOS Simulator.
179
180         Reverted changeset:
181
182         "Add UIDelegatePrivate SPI corresponding to
183         WKPageUIClient.showPage"
184         https://bugs.webkit.org/show_bug.cgi?id=175797
185         http://trac.webkit.org/changeset/221026
186
187 2017-08-22  Alex Christensen  <achristensen@webkit.org>
188
189         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
190         https://bugs.webkit.org/show_bug.cgi?id=175797
191         <rdar://problem/29270035>
192
193         Reviewed by Geoffrey Garen.
194
195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
196         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
197         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
198         (-[UITestDelegate _showPage:]):
199         (-[UITestDelegate webView:startURLSchemeTask:]):
200         (-[UITestDelegate webView:stopURLSchemeTask:]):
201         (TEST):
202
203 2017-08-22  Jonathan Bedard  <jbedard@apple.com>
204
205         Fix leak-checking for iOS Simulators
206         https://bugs.webkit.org/show_bug.cgi?id=175735
207
208         Reviewed by David Kilzer.
209
210         Follow-up fix to r220942. _proc may be undefined.
211
212         * Scripts/webkitpy/port/server_process.py:
213         (ServerProcess._wait_for_stop): Handle case where _proc is undefined.
214
215 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
216
217         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
218         https://bugs.webkit.org/show_bug.cgi?id=175822
219
220         Reviewed by Xabier Rodriguez-Calvar.
221
222         * gtk/install-dependencies: Add the bad plugins to the list.
223         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
224
225 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
226
227         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
228         https://bugs.webkit.org/show_bug.cgi?id=175787
229         <rdar://problem/33996612>
230
231         Reviewed by Wenson Hsieh.
232
233         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
234         (TestWebKitAPI::TEST):
235
236 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
237
238         Typo in "webkit-patch land"
239         https://bugs.webkit.org/show_bug.cgi?id=175788
240
241         Reviewed by Tim Horton.
242
243         * Scripts/webkitpy/tool/steps/commit.py:
244         (Commit._commit_warning):
245
246 2017-08-20  Sam Weinig  <sam@webkit.org>
247
248         StringView could use a function to strip leading/trailing characters without allocation
249         https://bugs.webkit.org/show_bug.cgi?id=175757
250
251         Reviewed by Darin Adler.
252
253         * TestWebKitAPI/Tests/WTF/StringView.cpp:
254         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
255
256 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
257
258         [PAL] Move spi/mac directory into PAL
259         https://bugs.webkit.org/show_bug.cgi?id=175649
260
261         Reviewed by Myles C. Maxfield.
262
263         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
264
265 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
266
267         [Win] DRT should only allow any https certificate for localhost.
268         https://bugs.webkit.org/show_bug.cgi?id=175147
269
270         Reviewed by Brent Fulgham.
271
272         Add check to make sure only localhost requests allow any https certificate.
273
274         * DumpRenderTree/win/DumpRenderTree.cpp:
275         (runTest):
276
277 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
278
279         Add WTFLogChannel level to allow runtime log filtering
280         https://bugs.webkit.org/show_bug.cgi?id=175731
281         <rdar://problem/33967234>
282
283         Unreviewed build fix.
284
285         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
286         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
287         fails on some of the bots.
288
289 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
290
291         Add WTFLogChannel level to allow runtime log filtering
292         https://bugs.webkit.org/show_bug.cgi?id=175731
293         <rdar://problem/33967234>
294
295         Reviewed by Jer Noble.
296
297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
298         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
299         (TestWebKitAPI::LoggingTest::output):
300         (TestWebKitAPI::TEST_F):
301
302 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
303
304         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
305         https://bugs.webkit.org/show_bug.cgi?id=175509
306         <rdar://problem/33728169>
307
308         Reviewed by Ryosuke Niwa.
309
310         Removes ExternalSourceAttributedStringToContentEditable and adds
311         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
312         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
313         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
314         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
315         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
316         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
317
318         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
319
320         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
321         (TestWebKitAPI::TEST):
322
323 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
324
325         Unreviewed, rolling out r220938.
326
327         The API tests added with this change are failing.
328
329         Reverted changeset:
330
331         "Add WTFLogChannel level to allow runtime log filtering"
332         https://bugs.webkit.org/show_bug.cgi?id=175731
333         http://trac.webkit.org/changeset/220938
334
335 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
336
337         Unreviewed, change my email.
338
339         * Scripts/webkitpy/common/config/contributors.json:
340
341 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
342
343         Fix leak-checking for iOS Simulators
344         https://bugs.webkit.org/show_bug.cgi?id=175735
345
346         Reviewed by Darin Adler.
347
348         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
349         Simulator (or device) because the process will have already been killed by the time we
350         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
351
352         * Scripts/webkitpy/port/server_process.py:
353         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
354         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
355         and SimulatorProcess.
356         * Scripts/webkitpy/port/simulator_process.py:
357         (SimulatorProcess.stop): Before closing the process, check for leaks.
358
359 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
360
361         Add WTFLogChannel level to allow runtime log filtering
362         https://bugs.webkit.org/show_bug.cgi?id=175731
363         <rdar://problem/33967234>
364
365         Reviewed by Jer Noble.
366
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
369         (TestWebKitAPI::LoggingTest::output):
370         (TestWebKitAPI::TEST_F):
371
372 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
373
374         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
375
376         * Scripts/webkitpy/common/config/contributors.json:
377
378 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
379
380         [Tools] Add script to download a GitHub release
381         https://bugs.webkit.org/show_bug.cgi?id=175279
382
383         Reviewed by Brent Fulgham.
384
385         * Scripts/download-latest-github-release.py: Added.
386
387 2017-08-18  Commit Queue  <commit-queue@webkit.org>
388
389         Unreviewed, rolling out r220854.
390         https://bugs.webkit.org/show_bug.cgi?id=175716
391
392         I'm not sure we really need this (Requested by KaL on
393         #webkit).
394
395         Reverted changeset:
396
397         "[GTK][WPE] Add NTLM authentication enabled API"
398         https://bugs.webkit.org/show_bug.cgi?id=122952
399         http://trac.webkit.org/changeset/220854
400
401 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
402
403         [GTK] Make TestContextMenu work on Fedora
404         https://bugs.webkit.org/show_bug.cgi?id=175708
405
406         Reviewed by Carlos Garcia Campos.
407
408         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
409         and my student last summer who was trying to work on a context menu API. It's trying to load
410         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
411         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
412         don't care to investigate. Let's switch it to WebM so I can move on.
413
414         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
415         (prepareContextMenuTestView):
416         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
417         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
418
419 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
420
421         check-webkit-style shouldn't check spacing in #elif preprocessor lines
422         https://bugs.webkit.org/show_bug.cgi?id=175652
423
424         Reviewed by Alex Christensen.
425
426         * Scripts/webkitpy/style/checkers/cpp.py:
427         (check_spacing):
428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
429         (CppStyleTest.test_spacing_for_binary_ops):
430
431 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
432
433         Fix the build on other platforms after r220865
434         https://bugs.webkit.org/show_bug.cgi?id=175683
435
436         Reviewed by Tim Horton.
437
438         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
439         availability is determined by SDK version rather than deployment version.
440
441         * TestWebKitAPI/ios/UIKitSPI.h:
442
443 2017-08-17  Andreas Kling  <akling@apple.com>
444
445         Disable CSS regions at compile time
446         https://bugs.webkit.org/show_bug.cgi?id=175630
447
448         Reviewed by Antti Koivisto.
449
450         * Scripts/webkitperl/FeatureList.pm:
451         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
452
453 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
454
455         Unreviewed, try to fix the internal iOS 10 build after r220865.
456
457         * TestWebKitAPI/ios/UIKitSPI.h:
458
459         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
460         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
461         this compiler guard.
462
463 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
464
465         [iOS] Respect type fidelities when copying image elements to the pasteboard
466         https://bugs.webkit.org/show_bug.cgi?id=175638
467         <rdar://problem/26556043>
468
469         Reviewed by Ryosuke Niwa.
470
471         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
472         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
473         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
474
475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
476         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
477         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
478         (TestWebKitAPI::TEST):
479         (TestWebKitAPI::presentActionSheetAndChooseAction):
480         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
481         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
482         (checkEstimatedSize):
483         (checkSuggestedNameAndEstimatedSize):
484
485         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
486
487         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
488         (TestWebKitAPI::TEST):
489         * TestWebKitAPI/ios/DataInteractionSimulator.h:
490         * TestWebKitAPI/ios/UIKitSPI.h: Added.
491
492 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
493
494         Recursively create resource load statistics folder for testing
495         https://bugs.webkit.org/show_bug.cgi?id=175676
496
497         Reviewed by Brady Eidson.
498
499         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
500         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
501
502 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
503
504         [GTK][WPE] Add NTLM authentication enabled API
505         https://bugs.webkit.org/show_bug.cgi?id=122952
506
507         Reviewed by Michael Catanzaro.
508
509         Add a test case to check we can enable/disable NTLM.
510
511         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
512         (testWebViewAuthenticationNTLM):
513         (beforeAll):
514
515 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
516
517         [PAL] Move spi/ios and spi/win directories into PAL
518         https://bugs.webkit.org/show_bug.cgi?id=175171
519
520         Reviewed by Antti Koivisto.
521
522         * DumpRenderTree/mac/EventSendingController.mm:
523
524 2017-08-16  Andy Estes  <aestes@apple.com>
525
526         [Payment Request] Add an ENABLE flag and an experimental feature preference
527         https://bugs.webkit.org/show_bug.cgi?id=175622
528
529         Reviewed by Tim Horton.
530
531         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
532         * WebKitTestRunner/TestController.cpp:
533         (WTR::TestController::resetPreferencesToConsistentValues):
534
535 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
536
537         undefined URL in PopoverTracker for failed step
538         https://bugs.webkit.org/show_bug.cgi?id=175593
539         <rdar://problem/33898769>
540
541         Reviewed by Daniel Bates.
542
543         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
544         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
545
546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
547         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
548         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
550         (BuildbotTestResults): Accept URL in constructor.
551
552 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
553
554         Remove Proximity Events and related code
555         https://bugs.webkit.org/show_bug.cgi?id=175545
556
557         Reviewed by Daniel Bates.
558
559         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
560         and other related code.
561
562         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
563
564 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
565
566         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
567         https://bugs.webkit.org/show_bug.cgi?id=175504
568
569         Reviewed by Sam Weinig.
570
571         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
572
573 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
574
575         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
576         https://bugs.webkit.org/show_bug.cgi?id=175557
577
578         Reviewed by Jon Lee.
579         
580         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
581
582         * DumpRenderTree/TestRunner.cpp:
583         (TestRunner::staticFunctions):
584         (setViewModeMediaFeatureCallback): Deleted.
585         * DumpRenderTree/TestRunner.h:
586         * DumpRenderTree/mac/TestRunnerMac.mm:
587         (TestRunner::setViewModeMediaFeature): Deleted.
588         * DumpRenderTree/win/TestRunnerWin.cpp:
589         (TestRunner::setViewModeMediaFeature): Deleted.
590         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
591
592 2017-08-14  Andy Estes  <aestes@apple.com>
593
594         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
595         https://bugs.webkit.org/show_bug.cgi?id=175548
596         <rdar://problem/33866206>
597
598         Reviewed by Brady Eidson.
599
600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
601         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
602         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
603
604 2017-08-14  Youenn Fablet  <youenn@apple.com>
605
606         WPT server should be able to do logging even if its output folder is not created at launch time
607         https://bugs.webkit.org/show_bug.cgi?id=175543
608
609         Reviewed by Alexey Proskuryakov.
610
611         Removing no longer used stdout/stderr member variables.
612         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
613
614         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
615         (WebPlatformTestServer.__init__):
616         (WebPlatformTestServer._prepare_config):
617         (WebPlatformTestServer._spawn_process):
618         (WebPlatformTestServer._stop_running_server):
619
620 2017-08-14  Daniel Bates  <dabates@apple.com>
621
622         webkit-patch: Passing --no-review should submit patch to EWS by default
623         https://bugs.webkit.org/show_bug.cgi?id=148899
624
625         Reviewed by David Kilzer.
626
627         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
628         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
629         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
630
631         Frequently I want to post a draft of a patch without review to have the EWS bots process
632         it to catch build and test breakage before I clean it up and post it for formal review.
633         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
634         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
635         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
636
637         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
638         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
639         parse the attachment id from the response page after adding an attachment to the bug.
640         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
641         HTTP response after uploading the patch.
642         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
643         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
644         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
645         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
646         * Scripts/webkitpy/tool/commands/upload.py:
647         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
648         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
649         this command.
650         (PostCommits.execute): Submit the patch to EWS, if applicable.
651         * Scripts/webkitpy/tool/commands/upload_unittest.py:
652         (test_upload): Set options.ews to False as the upload command expects this option
653         to be specified.
654         (test_upload_with_no_review_and_ews): Added.
655         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
656         * Scripts/webkitpy/tool/steps/options.py:
657         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
658         * Scripts/webkitpy/tool/steps/postdiff.py:
659         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
660         this command.
661         (PostDiff.run): Submit the patch to EWS, if applicable.
662         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
663         (SubmitToEWS):
664         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
665         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
666
667 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
668
669         Disable two flaky VideoControlsManager API tests.
670
671         Unreviewed test gardening.
672
673         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
674         (TestWebKitAPI::TEST):
675
676 2017-08-14  Tim Horton  <timothy_horton@apple.com>
677
678         Only create directory and sandbox extension handle for storage directories if they are set
679         https://bugs.webkit.org/show_bug.cgi?id=175522
680
681         Reviewed by Brady Eidson.
682
683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
684         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
685         (TEST):
686         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
687         doesn't log anything to stderr.
688
689 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
690
691         sub-categorize Sandbox violation logs
692         https://bugs.webkit.org/show_bug.cgi?id=175536
693         <rdar://problem/33834416>
694
695         Reviewed by David Kilzer.
696
697         * Scripts/webkitpy/common/system/crashlogs.py:
698         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
699         a Sandbox violation.
700         (CrashLogs._find_all_logs_darwin): Update comment.
701         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
702         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
703         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
704         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
705         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
706         * Scripts/webkitpy/port/darwin.py:
707         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
708
709 2017-08-14  Daniel Bates  <dabates@apple.com>
710
711         Add Automator service to copy permalink to Clipboard
712         https://bugs.webkit.org/show_bug.cgi?id=170978
713
714         Reviewed by Joseph Pecoraro.
715
716         It is helpful to reference using a hyperlink a particular line of code when having
717         a discussion on IRC or in a bug. You can get such a link by navigating to the file
718         in the Trac Browse Source viewer and selecting the line your are interested in.
719         I found myself doing this often enough that I wrote an Automator service to do it
720         for me.
721
722         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
723
724         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
725         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
726         * CopyPermalink/README: Added.
727
728 2017-08-14  Chris Dumez  <cdumez@apple.com>
729
730         Address flakiness related to download tests
731         https://bugs.webkit.org/show_bug.cgi?id=175338
732         <rdar://problem/33865119>
733
734         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
735         between tests.
736
737         * WebKitTestRunner/TestController.cpp:
738         (WTR::TestController::resetStateToConsistentValues):
739
740 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
741
742         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
743         https://bugs.webkit.org/show_bug.cgi?id=175474
744         <rdar://problem/33844628>
745
746         Reviewed by Wenson Hsieh.
747
748         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
749
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (resetWebPreferencesToConsistentValues):
752         * WebKitTestRunner/TestController.cpp:
753         (WTR::TestController::resetPreferencesToConsistentValues):
754
755 2017-08-12  Chris Dumez  <cdumez@apple.com>
756
757         Address flakiness related to download tests
758         https://bugs.webkit.org/show_bug.cgi?id=175338
759
760         Reviewed by Ryosuke Niwa.
761
762         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
763           is actually queried when a download completes. Previously, this would be
764           identical to a call to testRunner.waitUntilDone() because any download
765           completion would call testRunner.notifyDone().
766         - Disable logging of download callbacks by default and add a
767           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
768           enable such logging.
769
770         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
771         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
772         (WTR::InjectedBundle::didReceiveMessageToPage):
773         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
774         (WTR::TestRunner::setShouldLogDownloadCallbacks):
775         * WebKitTestRunner/InjectedBundle/TestRunner.h:
776         * WebKitTestRunner/TestController.cpp:
777         (WTR::TestController::downloadDidStart):
778         (WTR::TestController::decideDestinationWithSuggestedFilename):
779         (WTR::TestController::downloadDidFinish):
780         (WTR::TestController::downloadDidFail):
781         (WTR::TestController::downloadDidCancel):
782         * WebKitTestRunner/TestController.h:
783         (WTR::TestController::setShouldLogDownloadCallbacks):
784         * WebKitTestRunner/TestInvocation.cpp:
785         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
786
787 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
788
789         Create mock ITP data in testing to prevent grandfathering
790         https://bugs.webkit.org/show_bug.cgi?id=174720
791
792         Unreviewed follow-up fix for r220604.
793
794         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
795         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
796
797 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
798
799         Create mock ITP data in testing to prevent grandfathering
800         https://bugs.webkit.org/show_bug.cgi?id=174720
801         <rdar://problem/33457779>
802
803         Reviewed by Brent Fulgham.
804
805         We don't need to be triggering grandfathering when each test runner starts. On Mac,
806         this may launch plugins which can cause layout tests to fail later if the test
807         runner does not shut-down before the plugins unload.
808
809         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
810         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
811         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
812         prevent grandfathering from being triggered.
813         * WebKitTestRunner/ios/TestControllerIOS.mm:
814         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
815         * WebKitTestRunner/mac/TestControllerMac.mm:
816         (WTR::TestController::platformInitialize): Ditto.
817
818 2017-08-11  Sam Weinig  <sam@webkit.org>
819
820         WTF::Function does not allow for reference / non-default constructible return types
821         https://bugs.webkit.org/show_bug.cgi?id=175244
822         <rdar://problem/33801582>
823
824         Reviewed by Chris Dumez.
825
826         * TestWebKitAPI/Tests/WTF/Function.cpp:
827         (TestWebKitAPI::TEST):
828
829 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
830
831         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
832         https://bugs.webkit.org/show_bug.cgi?id=175378
833
834         Reviewed by Sergio Villar Senin.
835
836         Add two test cases to check proxy authentication.
837
838         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
839         (Tunnel::Tunnel):
840         (Tunnel::~Tunnel):
841         (Tunnel::connect):
842         (Tunnel::connected):
843         (serverCallback):
844         (ProxyAuthenticationTest::ProxyAuthenticationTest):
845         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
846         (ProxyAuthenticationTest::proxyServerPortAsString):
847         (testWebViewAuthenticationProxy):
848         (testWebViewAuthenticationProxyHTTPS):
849         (beforeAll):
850
851 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
852
853         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
854         https://bugs.webkit.org/show_bug.cgi?id=175428
855
856         Both ports share the GStreamer code as multimedia backend and till
857         not so long they were using different versions. Now they do use
858         the same versions and it does not make any sense anymore (and
859         neither had sense before) to have differences in the modulesets.
860
861         In this patch I created a GStreamer moduleset and referenced it
862         from both GTK+'s and WPE's. GStreamer patches were also moved there.
863
864         Reviewed by Žan Doberšek.
865
866         * gstreamer/jhbuild.modules: Added.
867         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
868         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
869         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
870         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
871         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
872         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
873         * gtk/jhbuild.modules:
874         * wpe/jhbuild.modules:
875         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
876         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
877         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
878         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
879         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
880
881 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
882
883         Unreviewed, adding Ross Kirsling to contributors.json
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
888
889         Unreviewed, attempt to fix build failure with VC2017
890
891         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
892         (TEST):
893
894 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
895
896         Unreviewed, suppress warnings on GCC
897
898         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
899         (TestWebKitAPI::CheckedArithmeticTester::run):
900
901 2017-08-10  Dan Bernstein  <mitz@apple.com>
902
903         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
904         https://bugs.webkit.org/show_bug.cgi?id=173223
905
906         Reviewed by Tim Horton.
907
908         The rebuilds were happening due to a difference in the compiler options that the IDE and
909         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
910         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
911         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
912         Advanced when a Custom Absolute path is selected.
913
914         * Scripts/webkitdirs.pm:
915         (determineBaseProductDir):
916
917 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
918
919         Run more WTF tests
920         https://bugs.webkit.org/show_bug.cgi?id=174970
921
922         Reviewed by Michael Catanzaro.
923
924         Some of WTF tests are not executed in non Apple ports while they are generic ones.
925         This patch adds these tests to non-Apple port TestWebKitAPI.
926         Currently, we do not add Signals.cpp since it depends on signal functionality.
927
928         * TestWebKitAPI/CMakeLists.txt:
929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
930         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
931         (isHigherPriority):
932         (TEST):
933         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
934         (TEST):
935         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
936         (TEST):
937
938 2017-08-10  obinna obike  <oobike@apple.com>
939
940         Remove obsolete link from webkit-queues status page
941         https://bugs.webkit.org/show_bug.cgi?id=175337
942
943         Reviewed by Aakash Jain.
944
945         * QueueStatusServer/templates/recentstatus.html:
946         Removed the link to the ews-watcher server.
947
948 2017-08-10  Brian Burg  <bburg@apple.com>
949
950         WKPreferences should conform to NSCopying
951         https://bugs.webkit.org/show_bug.cgi?id=175303
952         <rdar://problem/33764939>
953
954         Reviewed by Dan Bernstein.
955
956         Add unit test to make sure a WKPreference and its copy are
957         not aliased to each other or affect each other's properties.
958
959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
960         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
961         (TEST):
962
963 2017-08-10  Tim Horton  <timothy_horton@apple.com>
964
965         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
966         https://bugs.webkit.org/show_bug.cgi?id=175436
967         <rdar://problem/33667497>
968
969         Reviewed by Simon Fraser.
970
971         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
972         (TestWebKitAPI::TEST_F):
973
974 2017-08-10  Lucas Forschler  <lforschler@apple.com>
975
976         Fix duplicated code in r220534.
977
978         Unreviewed cleanup.
979
980         * Scripts/bisect-builds:
981
982 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
983
984         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
985         https://bugs.webkit.org/show_bug.cgi?id=175344
986         <rdar://problem/28507240>
987
988         Reviewed by Alexey Proskuryakov.
989
990         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
991         Finally enable the existing tests for iOS.
992
993         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
994         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
996         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
997
998 2017-08-10  Lucas Forschler  <lforschler@apple.com>
999
1000         Write a tool to bisect WebKit builds
1001         https://bugs.webkit.org/show_bug.cgi?id=174596
1002
1003         Reviewed by Dean Johnson and Kocsen Chung.
1004
1005         * Scripts/bisect-builds: Added.
1006         (bisect_builds): main bisection algorithm
1007         (download_archive):download an archive from S3 using existing tools
1008         (extract_archive):extract an archive using existing tools
1009         (find_le):Find rightmost value less than or equal to x
1010         (find_ge):Find leftmost item greater than or equal to x
1011         (get_api_url):generate url for the rest api/database
1012         (get_indices_from_revisions):convert revisions to list indexes for bisection
1013         (get_sorted_revisions):retrieve sorted revision list
1014         (get_s3_location_for_revision):calculate the S3 archive storage location
1015         (parse_args):parse command line arguments
1016         (pick_next_build):compute the next build to bisect
1017         (prompt_did_reproduce):prompt user for direction for bisection
1018         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
1019         (test_archive):Platform specific logic to test downloaded archive
1020         (minified_platforms):return a list of minified platforms in the database
1021         (unminified_platforms):return a list of full platforms in the database
1022         (is_supported_platform):check if platform is supported
1023         (validate_options):validate command line options
1024         (main):
1025
1026 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1027
1028         Remove bisect-builds script.
1029         https://bugs.webkit.org/show_bug.cgi?id=175433
1030         
1031         Reviewed by Aakash Jain.
1032
1033         * Scripts/bisect-builds: Removed.
1034
1035 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1036
1037         Remove ENABLE_GAMEPAD_DEPRECATED
1038         https://bugs.webkit.org/show_bug.cgi?id=175361
1039
1040         Reviewed by Carlos Garcia Campos.
1041
1042         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1043
1044 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1045
1046         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
1047         https://bugs.webkit.org/show_bug.cgi?id=175426
1048
1049         Reviewed by Carlos Garcia Campos.
1050
1051         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
1052
1053 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
1054
1055         Add Ms2ger as contributor.
1056         https://bugs.webkit.org/show_bug.cgi?id=175325
1057
1058         Reviewed by Carlos Alberto Lopez Perez.
1059
1060         * Scripts/webkitpy/common/config/contributors.json:
1061
1062 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
1063
1064         Fix run-benchmark after r220483.
1065         https://bugs.webkit.org/show_bug.cgi?id=175415
1066         <rdar://problem/33803003>
1067
1068         Reviewed by Ryosuke Niwa.
1069
1070         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
1071
1072         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1073         (WebServerBenchmarkRunner._run_one_test):
1074
1075 2017-08-09  Chris Dumez  <cdumez@apple.com>
1076
1077         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
1078         https://bugs.webkit.org/show_bug.cgi?id=175401
1079
1080         Reviewed by Brady Eidson.
1081
1082         * DumpRenderTree/mac/DumpRenderTree.mm:
1083         (enableExperimentalFeatures):
1084
1085 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1086
1087         [PAL] Move spi/cocoa and spi/cg directories into PAL
1088         https://bugs.webkit.org/show_bug.cgi?id=175175
1089
1090         Reviewed by Myles C. Maxfield.
1091
1092         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1093         * DumpRenderTree/mac/DumpRenderTree.mm:
1094         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
1095         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1096
1097         * Scripts/webkitpy/style/checker.py:
1098         * Scripts/webkitpy/style/checker_unittest.py:
1099         (GlobalVariablesTest.test_path_rules_specifier):
1100
1101         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
1102
1103         * Scripts/webkitpy/style/checkers/cpp.py:
1104         (check_braces):
1105         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1106         (WebKitStyleTest.test_braces.CF_OPTIONS):
1107         (WebKitStyleTest.test_braces):
1108
1109         Prevent CF_OPTIONS() from being handled as funtion definition.
1110
1111 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
1112
1113         [WTF] Move TextStream into WTF
1114         https://bugs.webkit.org/show_bug.cgi?id=175211
1115
1116         Reviewed by Myles C. Maxfield.
1117
1118         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1119
1120 2017-08-09  Andy Estes  <aestes@apple.com>
1121
1122         Part 3 of: Rename DatabaseProcess to StorageProcess
1123         https://bugs.webkit.org/show_bug.cgi?id=175034
1124
1125         Reviewed by Brady Eidson.
1126
1127         * WebKitTestRunner/TestController.cpp:
1128         (WTR::TestController::databaseProcessName): Updated to return
1129         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
1130
1131 2017-08-09  Commit Queue  <commit-queue@webkit.org>
1132
1133         Unreviewed, rolling out r220466, r220477, and r220487.
1134         https://bugs.webkit.org/show_bug.cgi?id=175411
1135
1136         This change broke existing API tests and follow up fixes did
1137         not resolve all the issues. (Requested by ryanhaddad on
1138         #webkit).
1139
1140         Reverted changesets:
1141
1142         https://bugs.webkit.org/show_bug.cgi?id=175244
1143         http://trac.webkit.org/changeset/220466
1144
1145         "WTF::Function does not allow for reference / non-default
1146         constructible return types"
1147         https://bugs.webkit.org/show_bug.cgi?id=175244
1148         http://trac.webkit.org/changeset/220477
1149
1150         https://bugs.webkit.org/show_bug.cgi?id=175244
1151         http://trac.webkit.org/changeset/220487
1152
1153 2017-08-09  Sam Weinig  <sam@webkit.org>
1154
1155         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1156
1157         Remove one addition of null Function test.
1158
1159 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
1160
1161         Allow nested timeouts in webkitpy
1162         https://bugs.webkit.org/show_bug.cgi?id=175390
1163         <rdar://problem/33803003>
1164
1165         Reviewed by David Kilzer.
1166
1167         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
1168         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
1169         the executive to detect and recover from any issues connecting with devices.
1170
1171         * Scripts/webkitpy/benchmark_runner/utils.py:
1172         (TimeoutError): Deleted.
1173         (timeout): Deleted.
1174         * Scripts/webkitpy/common/timeout_context.py: Added.
1175         (Timeout): A timeout context designed to be nested.
1176         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
1177         (Timeout.TimeoutData.__init__):
1178         (Timeout.default_handler): Timeout handler used if none is specified.
1179         (Timeout.current): Access data about the most urgent timeout.
1180         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
1181         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
1182         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
1183         urgent timeout data.
1184         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
1185         most urgent timeout data, if such data exists.
1186         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
1187         (TimeoutContextTests):
1188         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
1189         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
1190         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
1191         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
1192         over a less urgent outer timeout.
1193         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
1194         over a less urgent inner timeout.
1195         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
1196         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
1197         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
1198         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
1199         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
1200         * Scripts/webkitpy/port/simulator_process.py:
1201         (SimulatorProcess._start): Use Timeout class.
1202         * Scripts/webkitpy/xcode/simulated_device.py:
1203         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
1204         (SimulatedDevice.launch_app): Ditto.
1205         (SimulatedDevice.launch_app._install_timeout): Deleted.
1206         * Scripts/webkitpy/xcode/simulator.py:
1207         (Simulator.wait_until_device_is_booted):Use Timeout class.
1208         (Simulator.wait_until_device_is_in_state): Ditto.
1209
1210 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1211
1212         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1213         https://bugs.webkit.org/show_bug.cgi?id=175392
1214         <rdar://problem/33783207>
1215
1216         Reviewed by Tim Horton and Megan Gardner.
1217
1218         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1219
1220         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1221
1222 2017-08-09  Sam Weinig  <sam@webkit.org>
1223
1224         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1225
1226         * TestWebKitAPI/Tests/WTF/Function.cpp:
1227         Remove tests of null Functions, as they are no longer supported.
1228
1229 2017-08-09  Daniel Bates  <dabates@apple.com>
1230
1231         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1232         https://bugs.webkit.org/show_bug.cgi?id=175247
1233         <rdar://problem/33679804>
1234
1235         Reviewed by Brady Eidson.
1236
1237         Add tests for redirects.
1238
1239         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1240         (TEST):
1241         * TestWebKitAPI/cocoa/TestProtocol.mm:
1242         (createRedirectURL):
1243         (-[TestProtocol startLoading]):
1244
1245 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1246
1247         Unreviewed, rolling out r220393.
1248
1249         This patch regresses the performance of WebPage::editorState.
1250
1251         Reverted changeset:
1252
1253         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1254         cmb+b,i,u inside a contenteditable div"
1255         https://bugs.webkit.org/show_bug.cgi?id=175116
1256         http://trac.webkit.org/changeset/220393
1257
1258 2017-08-08  obinna obike  <oobike@apple.com>
1259
1260         Created Individual EWS Pages
1261         https://bugs.webkit.org/show_bug.cgi?id=174477
1262
1263         Reviewed by Aakash Jain.
1264
1265         Created individual pages for each EWS. Changed the link within each status bubble
1266         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1267
1268         * QueueStatusServer/handlers/patch.py:
1269         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1270         * QueueStatusServer/handlers/statusbubble.py:
1271         (StatusBubble._build_bubble): Updated url for specific EWS.
1272         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1273         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1274         all ews queues.
1275         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1276         takes you directly to the individual ews page.
1277
1278 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1279
1280         Separate jsc stress test script writer from run-jsc-stress-tests
1281         https://bugs.webkit.org/show_bug.cgi?id=175216
1282
1283         Reviewed by Mark Lam.
1284
1285         * Scripts/run-jsc-stress-tests:
1286         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1287
1288 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1289
1290         Unreviewed, fix Ubuntu LTS build
1291         https://bugs.webkit.org/show_bug.cgi?id=174490
1292
1293         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1294
1295 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1296
1297         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1298         https://bugs.webkit.org/show_bug.cgi?id=175302
1299         <rdar://problem/33762116>
1300
1301         Reviewed by Tim Horton.
1302
1303         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1304         See WebKit ChangeLog for more details.
1305
1306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1307         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1308         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1309         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1310         (-[SlowTextInputContext handleEvent:completionHandler:]):
1311         (-[SlowInputWebView inputContext]):
1312         (-[SlowInputWebView _web_superInputContext]):
1313         (TEST):
1314
1315 2017-08-08  John Wilander  <wilander@apple.com>
1316
1317         Resource Load Statistics: Clear web processes' state on history removal
1318         https://bugs.webkit.org/show_bug.cgi?id=175271
1319         <rdar://problem/33756560>
1320
1321         Reviewed by Chris Dumez.
1322
1323         Test infrastructure for asynchronous tests of website data
1324         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1325
1326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1327         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1328         (WTR::InjectedBundle::didReceiveMessageToPage):
1329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1330         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1331         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1332         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1333         * WebKitTestRunner/TestController.cpp:
1334         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1335         * WebKitTestRunner/TestController.h:
1336         * WebKitTestRunner/TestInvocation.cpp:
1337         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1338         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1339         * WebKitTestRunner/TestInvocation.h:
1340         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1341         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1342
1343 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1344
1345         Add Alicia Boya García as contributor
1346         https://bugs.webkit.org/show_bug.cgi?id=175326
1347
1348         Reviewed by Michael Catanzaro.
1349
1350         * Scripts/webkitpy/common/config/contributors.json:
1351
1352 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1353
1354         [CMake] Properly test if compiler supports compiler flags
1355         https://bugs.webkit.org/show_bug.cgi?id=174490
1356
1357         Reviewed by Konstantin Tokarev.
1358
1359         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1360         * MiniBrowser/gtk/CMakeLists.txt:
1361         * TestRunnerShared/Bindings/JSWrapper.cpp:
1362         (WTR::JSWrapper::initialize):
1363         * TestWebKitAPI/CMakeLists.txt:
1364         * TestWebKitAPI/PlatformGTK.cmake:
1365         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1366         (TestWebKitAPI::CheckedArithmeticTester::run):
1367         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1368         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1369         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1370         (formControlsAssociatedCallback):
1371         * TestWebKitAPI/glib/CMakeLists.txt:
1372         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1373         (Test::getResourcesDir):
1374         * WebKitTestRunner/CMakeLists.txt:
1375         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1376         (WTR::menuItemClickCallback):
1377         (WTR::staticConvertMenuItemToType):
1378         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1379         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1380         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1381         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1382         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1383         (WTR::AccessibilityUIElement::helpText const):
1384         (WTR::AccessibilityUIElement::attributedStringForRange):
1385         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1386         (WTR::EventSenderProxy::updateTouchPoint):
1387         (WTR::EventSenderProxy::releaseTouchPoint):
1388
1389 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1390
1391         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1392         https://bugs.webkit.org/show_bug.cgi?id=175116
1393         <rdar://problem/28279301>
1394
1395         Reviewed by Darin Adler and Ryosuke Niwa.
1396
1397         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1398         EditorStateTests run on both iOS and Mac.
1399
1400         * TestWebKitAPI/EditingTestHarness.h: Added.
1401         * TestWebKitAPI/EditingTestHarness.mm: Added.
1402
1403         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1404         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1405         the state of the latest observed EditorState.
1406
1407         (-[EditingTestHarness initWithWebView:]):
1408         (-[EditingTestHarness dealloc]):
1409         (-[EditingTestHarness webView]):
1410         (-[EditingTestHarness latestEditorState]):
1411         (-[EditingTestHarness editorStateHistory]):
1412         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1413         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1414         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1415         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1416         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1417         (-[EditingTestHarness toggleBold]):
1418         (-[EditingTestHarness toggleItalic]):
1419         (-[EditingTestHarness toggleUnderline]):
1420         (-[EditingTestHarness setForegroundColor:]):
1421         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1422         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1423         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1424         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1425         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1426         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1427         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1428
1429         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1430         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1431         keys and values.
1432
1433         (-[EditingTestHarness latestEditorStateContains:]):
1434         (-[EditingTestHarness _webView:editorStateDidChange:]):
1435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1436         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1437         (TestWebKitAPI::setUpEditorStateTestHarness):
1438         (TestWebKitAPI::TEST):
1439         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1440
1441 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1442
1443         Prevent domain from being set to a TLD
1444         https://bugs.webkit.org/show_bug.cgi?id=175226
1445         <rdar://problem/11079948>
1446
1447         Reviewed by Chris Dumez.
1448
1449         Extend the public suffix tests to include cases used by the
1450         Public Domain 'Public Suffix List'.
1451
1452         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1453         (TestWebKitAPI::TEST):
1454
1455 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1456
1457         [XCode] webkit-patch should run sort-Xcode-project-file
1458         https://bugs.webkit.org/show_bug.cgi?id=174036
1459         <rdar://problem/33732709>
1460
1461         Reviewed by Simon Fraser.
1462
1463         * Scripts/webkitpy/common/config/ports.py:
1464         * Scripts/webkitpy/tool/commands/download.py:
1465         * Scripts/webkitpy/tool/commands/download_unittest.py:
1466         * Scripts/webkitpy/tool/commands/upload.py:
1467         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1468         * Scripts/webkitpy/tool/steps/__init__.py:
1469         * Scripts/webkitpy/tool/steps/options.py:
1470         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1471
1472 2017-08-07  Devin Rousso  <drousso@apple.com>
1473
1474         Web Inspector: Preview Canvas path when viewing a recording
1475         https://bugs.webkit.org/show_bug.cgi?id=174967
1476
1477         Reviewed by Brian Burg.
1478
1479         * DumpRenderTree/TestOptions.h:
1480         * DumpRenderTree/TestOptions.mm:
1481         (TestOptions::TestOptions):
1482         * DumpRenderTree/mac/DumpRenderTree.mm:
1483         (setWebPreferencesForTestOptions):
1484         * WebKitTestRunner/TestController.cpp:
1485         (WTR::TestController::resetPreferencesToConsistentValues):
1486         (WTR::updateTestOptionsFromTestHeader):
1487         * WebKitTestRunner/TestOptions.h:
1488         (WTR::TestOptions::hasSameInitializationOptions const):
1489         Add plumbing for new InspectorAdditions runtime flag.
1490
1491 2017-08-07  obinna obike  <oobike@apple.com>
1492
1493         Sorted EWS Queues on Patch page
1494         https://bugs.webkit.org/show_bug.cgi?id=173667
1495
1496         Reviewed by Aakash Jain.
1497
1498         * QueueStatusServer/handlers/patch.py:
1499         (Patch.get): Sorted queue_status.
1500         * QueueStatusServer/templates/patch.html:
1501         Changed queue_status.items to queue_status because it's a list.
1502
1503 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1504
1505         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1506         https://bugs.webkit.org/show_bug.cgi?id=175286
1507
1508         Reviewed by Myles C. Maxfield.
1509
1510         * Scripts/webkitpy/style/checkers/cpp.py:
1511         (check_braces):
1512         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1513         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1514         (WebKitStyleTest.test_braces):
1515         (WebKitStyleTest.test_braces.NS_OPTIONS):
1516
1517 2017-08-07  Brian Burg  <bburg@apple.com>
1518
1519         Remove CANVAS_PATH compilation guard
1520         https://bugs.webkit.org/show_bug.cgi?id=175207
1521
1522         Reviewed by Sam Weinig.
1523
1524         * Scripts/webkitperl/FeatureList.pm:
1525         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1526
1527 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1528
1529         [Win] Use Visual Studio 2017 if installed.
1530         https://bugs.webkit.org/show_bug.cgi?id=175188
1531
1532         Reviewed by Sam Weinig.
1533
1534         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1535
1536         * Scripts/webkitdirs.pm:
1537         (visualStudioInstallDir):
1538         (msBuildInstallDir):
1539
1540 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1541
1542         [GTK][WPE] Add API to provide browser information required by automation
1543         https://bugs.webkit.org/show_bug.cgi?id=175130
1544
1545         Reviewed by Michael Catanzaro.
1546
1547         * MiniBrowser/gtk/main.c:
1548         (automationStartedCallback): Set browser information when a new automation session is started.
1549         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1550         (testAutomationSessionApplicationInfo):
1551         (beforeAll):
1552
1553 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1554
1555         Unreviewed, rolling out r220295.
1556
1557         This change introduced 4 errors in webkitpy tests.
1558
1559         Reverted changeset:
1560
1561         "[XCode] webkit-patch should run sort-Xcode-project-file"
1562         https://bugs.webkit.org/show_bug.cgi?id=174036
1563         http://trac.webkit.org/changeset/220295
1564
1565 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1566
1567         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1568
1569         Unreviewed test gardening.
1570
1571         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1572         (TestWebKitAPI::TEST):
1573
1574 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1575
1576         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1577         https://bugs.webkit.org/show_bug.cgi?id=175083
1578
1579         Reviewed by Oliver Hunt.
1580         
1581         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1582         to wait for VM destructions to finish before running the next test. This makes it easier to 
1583         understand leaks results from workers tests, and leads to fewer reported leaks.
1584
1585         * DumpRenderTree/mac/DumpRenderTree.mm:
1586         (runTest):
1587
1588 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1589
1590         check-webkit-style: fix path-specific rules for WebKit2 rename
1591         https://bugs.webkit.org/show_bug.cgi?id=175182
1592
1593         Reviewed by David Kilzer.
1594
1595         * Scripts/webkitpy/style/checker.py:
1596
1597 2017-08-04  Youenn Fablet  <youenn@apple.com>
1598
1599         [Cache API] Add Cache and CacheStorage IDL definitions
1600         https://bugs.webkit.org/show_bug.cgi?id=175201
1601
1602         Reviewed by Brady Eidson.
1603
1604         * DumpRenderTree/mac/DumpRenderTree.mm:
1605         (enableExperimentalFeatures):
1606         (resetWebPreferencesToConsistentValues):
1607         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1608         (WTR::InjectedBundle::beginTesting):
1609         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1610         (WTR::TestRunner::setCacheAPIEnabled):
1611         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1612
1613 2017-08-04  John Wilander  <wilander@apple.com>
1614
1615         Resource Load Statistics: Report user interaction immediately, but only when needed
1616         https://bugs.webkit.org/show_bug.cgi?id=175090
1617         <rdar://problem/33685546>
1618
1619         Reviewed by Chris Dumez.
1620
1621         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1622         (WTR::InjectedBundle::beginTesting):
1623             Now calls WebCore::ResourceLoadObserver::clearState().
1624
1625 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1626
1627         Add an API test for r220286
1628         https://bugs.webkit.org/show_bug.cgi?id=175206
1629
1630         Reviewed by Simon Fraser.
1631
1632         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1633         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1634         (createAnimatedResizeWebView):
1635         (TEST):
1636         Add a test to ensure that we don't call
1637         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1638         animated resize.
1639
1640 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1641
1642         [XCode] webkit-patch should run sort-Xcode-project-file
1643         https://bugs.webkit.org/show_bug.cgi?id=174036
1644
1645         Reviewed by Simon Fraser.
1646
1647         * Scripts/webkitpy/common/config/ports.py:
1648         * Scripts/webkitpy/tool/commands/download.py:
1649         * Scripts/webkitpy/tool/commands/upload.py:
1650         * Scripts/webkitpy/tool/steps/__init__.py:
1651         * Scripts/webkitpy/tool/steps/options.py:
1652         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1653
1654 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1655
1656         REGRESSION(r219857): run-benchmark --allplans broken
1657         https://bugs.webkit.org/show_bug.cgi?id=175186
1658
1659         Reviewed by Saam Barati.
1660
1661         r219857 forgot to update also the calls to BenchmarkRunner() that
1662         is done when the script is run with --allplans.
1663
1664         To fix this (and avoid future issues like this), let's factorize
1665         the calls to the benchhmark runner in a run_benchmark_plan()
1666         function.
1667
1668         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1669         (run_benchmark_plan):
1670         (start):
1671
1672 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1673
1674         Dashboard bubbles sometimes show failure count instead of crash count
1675         https://bugs.webkit.org/show_bug.cgi?id=175157
1676         <rdar://problem/33709009>
1677
1678         Reviewed by Alexey Proskuryakov.
1679
1680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1681         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1682
1683 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1684
1685         Add tests for NeverDestroyed
1686         https://bugs.webkit.org/show_bug.cgi?id=175146
1687
1688         Reviewed by Darin Adler.
1689
1690         * CMakeLists.txt:
1691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1692         New files and sort.
1693
1694         * TestWebKitAPI/Tests/WTF/Logger.h:
1695         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1696         (TestWebKitAPI::log):
1697         (TestWebKitAPI::takeLogStr):
1698         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1699         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1700         (TestWebKitAPI::log): Deleted.
1701         (TestWebKitAPI::takeLogStr): Deleted.
1702         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1703
1704         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1705         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1706         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1707         (TestWebKitAPI::LifecycleLogger::operator=):
1708         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1709         (TestWebKitAPI::LifecycleLogger::setName):
1710         (TestWebKitAPI::TEST):
1711         Add a class that logs construction / assignment / modifications.
1712
1713         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1714         (TestWebKitAPI::TEST):
1715         (TestWebKitAPI::list):
1716         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1717
1718 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1719
1720         minification logic is not implemented for ios builds
1721         <rdar://problem/33726561>
1722
1723         Reviewed by Dean Johnson
1724
1725         * BuildSlaveSupport/built-product-archive:
1726         (minifyDirectory): refactor minifySource -> minifyDirectory
1727         (archiveBuiltProduct): add ios minification logic
1728         (minifySource): Deleted.
1729
1730 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1731
1732         Unreviewed, rolling out r220271.
1733
1734         Rolling out due to Layout Test failing on iOS Simulator.
1735
1736         Reverted changeset:
1737
1738         "Remove STREAMS_API compilation guard"
1739         https://bugs.webkit.org/show_bug.cgi?id=175165
1740         http://trac.webkit.org/changeset/220271
1741
1742 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1743
1744         Unreviewed, rolling out r220268.
1745
1746         This change caused assertion failures on macOS and iOS Debug
1747         WK2.
1748
1749         Reverted changeset:
1750
1751         "Resource Load Statistics: Report user interaction
1752         immediately, but only when needed"
1753         https://bugs.webkit.org/show_bug.cgi?id=175090
1754         http://trac.webkit.org/changeset/220268
1755
1756 2017-08-04  Youenn Fablet  <youenn@apple.com>
1757
1758         Remove STREAMS_API compilation guard
1759         https://bugs.webkit.org/show_bug.cgi?id=175165
1760
1761         Reviewed by Darin Adler.
1762
1763         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1764
1765 2017-08-04  John Wilander  <wilander@apple.com>
1766
1767         Resource Load Statistics: Report user interaction immediately, but only when needed
1768         https://bugs.webkit.org/show_bug.cgi?id=175090
1769         <rdar://problem/33685546>
1770
1771         Reviewed by Chris Dumez.
1772
1773         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1774         (WTR::InjectedBundle::beginTesting):
1775             Now calls WebCore::ResourceLoadObserver::clearState().
1776
1777 2017-08-03  Brian Burg  <bburg@apple.com>
1778
1779         Remove ENABLE(WEB_SOCKET) guards
1780         https://bugs.webkit.org/show_bug.cgi?id=167044
1781
1782         Reviewed by Joseph Pecoraro.
1783
1784         * Scripts/webkitperl/FeatureList.pm:
1785         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1786
1787 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1788
1789         REGRESSION(r219850): run-benchmark script broken on Linux
1790         https://bugs.webkit.org/show_bug.cgi?id=175126
1791
1792         Reviewed by Stephanie Lewis.
1793
1794         The run-benchmark script dynamically generates the list of supported
1795         browsers and platforms (currently Linux and OSX) by loading all
1796         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1797         and getting the browser_name and platform variables from the
1798         classes defined there.
1799
1800         This means that this classes should not raise an exception when
1801         loaded on other platforms or otherwise they will broke the whole
1802         script. Its fine if they raise an exception when executing any of
1803         the methods they implement, but not when just loading/importing
1804         the class.
1805
1806         Move the argument variable definitions that call on the platform
1807         specific OSXBrowserDriver._screen_size() function from beeing
1808         variables that are evaluated when loading the file, to be functions
1809         that are only evaluated when the actual functionality needs to be
1810         executed.
1811
1812         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1813         (OSXChromeDriver.launch_url):
1814         (OSXChromeCanaryDriver.launch_url):
1815         (create_args):
1816         (create_chrome_options):
1817         (create_window_size_arg):
1818         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1819         (OSXFirefoxDriver.launch_url):
1820         (OSXFirefoxNightlyDriver.launch_url):
1821         (OSXFirefoxNightlyDriver.launch_driver):
1822         (create_args):
1823
1824 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1825
1826         [PAL] Move spi/cf directory into PAL
1827         https://bugs.webkit.org/show_bug.cgi?id=175057
1828
1829         Reviewed by Antti Koivisto.
1830
1831         * Scripts/webkitpy/style/checker.py:
1832         * Scripts/webkitpy/style/checker_unittest.py:
1833         (GlobalVariablesTest.test_path_rules_specifier):
1834
1835         Ignore "readability/naming/underscores" style errors for sources
1836         under the WebCore/PAL/pal/spi directory.
1837
1838         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1839
1840 2017-08-03  Youenn Fablet  <youenn@apple.com>
1841
1842         Remove FETCH_API compilation guard
1843         https://bugs.webkit.org/show_bug.cgi?id=175154
1844
1845         Reviewed by Chris Dumez.
1846
1847         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1848
1849 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1850
1851         Enable archive minification on iOS builds
1852         https://bugs.webkit.org/show_bug.cgi?id=174718
1853         
1854         Reviewed by Aakash Jain.
1855
1856         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1857         (BuildFactory.__init__):
1858
1859 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1860
1861         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1862         https://bugs.webkit.org/show_bug.cgi?id=175140
1863
1864         Reviewed by Alexey Proskuryakov.
1865
1866         We are having lately issues with JSC tests causing problems on
1867         the GTK+ and WPE bots due to the high amount of memory some tests
1868         need to run.
1869
1870         The best thing we can do now is to workaround this by disabling
1871         all the tests marked as memoryLimited on the GTK and WPE bots.
1872         We may revise this on the future.
1873
1874         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1875         (RunJavaScriptCoreTests.start):
1876
1877 2017-08-03  Brady Eidson  <beidson@apple.com>
1878
1879         Add SW IDLs and stub out basic functionality.
1880         https://bugs.webkit.org/show_bug.cgi?id=175115
1881
1882         Reviewed by Chris Dumez.
1883
1884         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1885
1886         * Scripts/webkitpy/bindings/main.py:
1887
1888 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1889
1890         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1891         https://bugs.webkit.org/show_bug.cgi?id=159510
1892
1893         Reviewed by Daniel Bates.
1894
1895         Allow any https certificate when running tests.
1896
1897         * DumpRenderTree/win/DumpRenderTree.cpp:
1898         (runTest):
1899
1900 2017-08-02  Youenn Fablet  <youenn@apple.com>
1901
1902         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1903         https://bugs.webkit.org/show_bug.cgi?id=175089
1904
1905         Reviewed by Chris Dumez.
1906
1907         * DumpRenderTree/TestOptions.mm:
1908         (TestOptions::TestOptions): Using absolutePath if available.
1909         * DumpRenderTree/mac/DumpRenderTree.mm:
1910         (computeTestURL): Removing http/tests/ specific URL computation.
1911         * Scripts/webkitpy/port/driver.py:
1912         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1913
1914 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1915
1916         download-built-product should allow for a proxy option
1917         https://bugs.webkit.org/show_bug.cgi?id=174875
1918
1919         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1920
1921         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1922         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1923         
1924
1925 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1926
1927         check-webkit-style: deleting lines in a file runs the linter on the whole file
1928         https://bugs.webkit.org/show_bug.cgi?id=175078
1929
1930         Reviewed by David Kilzer.
1931
1932         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1933         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1934
1935         * Scripts/webkitpy/style/checkers/test_expectations.py:
1936         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1937         * Scripts/webkitpy/style/main_unittest.py:
1938         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1939         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1940         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1941
1942 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1943
1944         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1945         https://bugs.webkit.org/show_bug.cgi?id=175075
1946
1947         Reviewed by David Kilzer.
1948
1949         We have no way of handling text files with illegal unicode characters. Allow the callers of
1950         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1951         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1952
1953         * Scripts/webkitpy/common/system/filesystem.py:
1954         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1955         (FileSystem.write_text_file): Ditto.
1956         * Scripts/webkitpy/common/system/filesystem_mock.py:
1957         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1958         (MockFileSystem.write_text_file): Ditto.
1959         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1960         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1961         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1962
1963 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1964
1965         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1966         https://bugs.webkit.org/show_bug.cgi?id=175072
1967
1968         Reviewed by Alexey Proskuryakov.
1969
1970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1971         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1972
1973 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1974
1975         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1976         https://bugs.webkit.org/show_bug.cgi?id=175019
1977
1978         Reviewed by Darin Adler.
1979
1980         * TestWebKitAPI/CMakeLists.txt:
1981
1982 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1983
1984         Enabling uploading archives to S3
1985         https://bugs.webkit.org/show_bug.cgi?id=174198
1986
1987         Unreviewed unit test fix after r219235.
1988
1989         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1990
1991 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1992
1993         Fix JSCOnly ARM buildbots after r220047
1994         https://bugs.webkit.org/show_bug.cgi?id=174993
1995
1996         Unreviewed fix after r220087.
1997
1998         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1999         (BuildAndRemoteJSCTestsFactory.__init__):
2000
2001 2017-08-01  Chris Dumez  <cdumez@apple.com>
2002
2003         Add initial support for navigator.sendBeacon
2004         https://bugs.webkit.org/show_bug.cgi?id=175007
2005         <rdar://problem/33547728>
2006
2007         Reviewed by Sam Weinig.
2008
2009         Enable the Beacon API at runtime in the context of layout tests since the
2010         feature is currently disabled by default.
2011
2012         * DumpRenderTree/mac/DumpRenderTree.mm:
2013         (enableExperimentalFeatures):
2014         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2015         (WTR::InjectedBundle::beginTesting):
2016         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2017         (WTR::TestRunner::setModernMediaControlsEnabled):
2018         (WTR::TestRunner::setBeaconAPIEnabled):
2019         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2020
2021 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
2022
2023         Update Bot Watcher's Dashboard for Buildbot 0.9
2024         https://bugs.webkit.org/show_bug.cgi?id=174777
2025
2026         Reviewed by Daniel Bates.
2027
2028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2029         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
2030         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
2031         in a dictionary.
2032         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
2033         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
2034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2035         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
2036         (parseRevisionProperty): Ditto.
2037         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
2038         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
2039         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
2040         have changed in Buildbot 0.9.
2041         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
2042         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
2043         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
2044         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
2045         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
2046         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
2047         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
2048         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
2049         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
2050         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2052         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
2053         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
2054         (BuildbotQueue.prototype.get overviewURL): Ditto.
2055         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
2056         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
2057         Buildbot 0.8 or 0.9.
2058         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
2059         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
2060         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
2061         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
2062         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
2063         Therefore we are fetching information for fixed number of build. 
2064         Also iterating the loop incrementally since the build data is already reverse sorted.
2065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2066         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
2067         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
2068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2069         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
2070
2071 2017-08-01  Devin Rousso  <drousso@apple.com>
2072
2073         Web Inspector: simplify WebInspector with WI
2074         https://bugs.webkit.org/show_bug.cgi?id=175058
2075
2076         Reviewed by Joseph Pecoraro.
2077
2078         * Scripts/check-inspector-strings:
2079         (extract_ui_strings):
2080         * Scripts/extract-localizable-js-strings:
2081
2082 2017-08-01  Youenn Fablet  <youenn@apple.com>
2083
2084         Layout tests with 'https' suffix should be run over HTTPS
2085         https://bugs.webkit.org/show_bug.cgi?id=174992
2086
2087         Reviewed by Chris Dumez.
2088
2089         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
2090         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
2091         Covered by corresponding unit tests.
2092
2093         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2094         (run_server):
2095         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2096         (base_http_url):
2097         (base_https_url):
2098         (base_url): Deleted.
2099         * Scripts/webkitpy/port/base.py:
2100         (Port.to.web_platform_test_server_base_http_url):
2101         (Port.to):
2102         (Port.to.web_platform_test_server_base_https_url):
2103         (Port.to.web_platform_test_server_base_url): Deleted.
2104         * Scripts/webkitpy/port/driver.py:
2105         (Driver.__init__):
2106         (Driver.wpt_test_path_to_uri):
2107         (Driver):
2108         (Driver.http_test_path_to_uri):
2109         (Driver.test_to_uri):
2110         (Driver.uri_to_test):
2111         * Scripts/webkitpy/port/driver_unittest.py:
2112         (DriverTest.test_test_to_uri):
2113         (DriverTest.test_uri_to_test):
2114
2115 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
2116
2117         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
2118         https://bugs.webkit.org/show_bug.cgi?id=173998
2119
2120         Reviewed by Darin Adler.
2121
2122         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
2123         detect mistakes in backward compatibility in the future when we change it.
2124
2125         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
2126         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
2127         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
2128         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
2129         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
2130         internal key data slot.
2131
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
2134         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
2135         (getNextMessage):
2136         (TEST):
2137         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
2138         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
2139         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
2140         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
2141         These are the pre-baked databases.
2142         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
2143         This is the actual test that do all the reads and comparisons.
2144         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
2145         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
2146         IndexedDB new stuffs. Then it can be used to bake the database again.
2147
2148 2017-08-01  Brady Eidson  <beidson@apple.com>
2149
2150         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
2151         https://bugs.webkit.org/show_bug.cgi?id=175030
2152
2153         Reviewed by Andy Estes.
2154
2155         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2156         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
2157
2158 2017-08-01  Brady Eidson  <beidson@apple.com>
2159
2160         Part 2 of: Rename DatabaseProcess to StorageProcess.
2161         https://bugs.webkit.org/show_bug.cgi?id=174880
2162
2163         Reviewed by Andy Estes.
2164
2165         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2166         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2167         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2168         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2169         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2170         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2171         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2172         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2173
2174 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2175
2176         Fix JSCOnly ARM buildbots after r220047
2177         https://bugs.webkit.org/show_bug.cgi?id=174993
2178
2179         Reviewed by Saam Barati.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2182         (BuildAndRemoteJSCTestsFactory.__init__):
2183
2184 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2185
2186         [WTF] Introduce Private Symbols
2187         https://bugs.webkit.org/show_bug.cgi?id=174935
2188
2189         Reviewed by Darin Adler.
2190
2191         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2192         (TestWebKitAPI::TEST):
2193
2194 2017-07-30  Darin Adler  <darin@apple.com>
2195
2196         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
2197         https://bugs.webkit.org/show_bug.cgi?id=130653
2198
2199         Reviewed by Antti Koivisto.
2200
2201         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2202         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
2203         when calling frameDidChangeLocation.
2204         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
2205         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
2206         thus causing mysterious failures of a couple of tests. There are two remaining issues:
2207         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
2208         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
2209         same logic flaw that causes "top loading frame" to get set to one of the subframes in
2210         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
2211         loading, subframe starts loading. It would be good to clean that up some day, but for now
2212         this patch makes the two work identically rather than changing both.
2213         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
2214
2215 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2216
2217         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
2218         https://bugs.webkit.org/show_bug.cgi?id=174963
2219
2220         Reviewed by Darin Adler.
2221
2222         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
2223         RetainPtr<>. This patch changes them to all use auto.
2224
2225         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2226         (TestWebKitAPI::TEST):
2227
2228 2017-07-30  Brady Eidson  <beidson@apple.com>
2229
2230         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2231         https://bugs.webkit.org/show_bug.cgi?id=174958
2232
2233         Reviewed by Darin Adler.
2234
2235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2236         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2237         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2238         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2239         (runUntilTasksInFlight):
2240         (TEST):
2241
2242 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2243
2244         Unreviewed, rolling out r219990.
2245         https://bugs.webkit.org/show_bug.cgi?id=174961
2246
2247         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2248         estes on #webkit).
2249
2250         Reverted changeset:
2251
2252         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2253         https://bugs.webkit.org/show_bug.cgi?id=174880
2254         http://trac.webkit.org/changeset/219990
2255
2256 2017-07-28  Brady Eidson  <beidson@apple.com>
2257
2258         API tests that use URLSchemeHandler are failing.
2259         https://bugs.webkit.org/show_bug.cgi?id=174950
2260
2261         Reviewed by Alex Christensen.
2262
2263         Fix the NoMIMEType test to be correct.
2264
2265         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2266         (-[SchemeHandler initWithData:mimeType:]):
2267         (-[SchemeHandler webView:startURLSchemeTask:]):
2268         (TEST):
2269
2270 2017-07-28  Daniel Bates  <dabates@apple.com>
2271
2272         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2273         https://bugs.webkit.org/show_bug.cgi?id=174876
2274
2275         Reviewed by Alex Christensen.
2276
2277         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2278         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2279         they provide a more direct way to test the platform abstraction.
2280
2281         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2282
2283         * Scripts/prepare-ChangeLog:
2284         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2285         of the current working directory.
2286
2287 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2288
2289         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2290         https://bugs.webkit.org/show_bug.cgi?id=174930
2291
2292         Unreviewed test fix.
2293
2294         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2295
2296         * Scripts/prepare-ChangeLog:
2297         (get_function_line_ranges_for_cpp):
2298
2299 2017-07-28  JF Bastien  <jfbastien@apple.com>
2300
2301         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2302         https://bugs.webkit.org/show_bug.cgi?id=174930
2303
2304         Reviewed by Daniel Bates.
2305
2306         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2307         here also teach it about const and volatile overloads. I didn't do
2308         reference and rvalue reference overloads because we don't really
2309         use them, and the current parser throws away those characters and
2310         it doesn't seem worth making it more complex.
2311
2312         * Scripts/prepare-ChangeLog:
2313         (get_function_line_ranges_for_cpp):
2314         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2315         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2316         (Foo::Arrow::arrow):
2317         (Foo::Arrow::otherArrow):
2318         (Foo::Arrow::otherArrow const):
2319         (Foo::Arrow::otherArrow volatile):
2320         (Foo::Arrow::otherArrow const volatile):
2321
2322 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2323
2324         [GTK] Building with ENABLE_VIDEO=OFF fails
2325         https://bugs.webkit.org/show_bug.cgi?id=174940
2326
2327         Reviewed by Alex Christensen.
2328
2329         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2330         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2331
2332         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2333         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2334
2335 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2336
2337         [WPE] Implement EventSenderProxy in WTR
2338         https://bugs.webkit.org/show_bug.cgi?id=173419
2339
2340         Reviewed by Žan Doberšek.
2341
2342         Add the implementation of EventSenderProxy to the WTR. This
2343         allows us to extend the coverage of the test suite in WKWPE.
2344
2345         * WebKitTestRunner/EventSenderProxy.h:
2346         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2347         libxkbcommon needed to deal with key events.
2348         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2349         (WTR::EventSenderProxy::EventSenderProxy):
2350         (WTR::senderButtonToWPEButton):
2351         (WTR::EventSenderProxy::mouseDown):
2352         (WTR::EventSenderProxy::mouseUp):
2353         (WTR::EventSenderProxy::mouseMoveTo):
2354         (WTR::EventSenderProxy::mouseScrollBy):
2355         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2356         (WTR::EventSenderProxy::leapForward):
2357         (WTR::wkEventModifiersToWPE):
2358         (WTR::getXKBKeySymForKeyRef):
2359         (WTR::EventSenderProxy::keyDown):
2360         (WTR::EventSenderProxy::addTouchPoint):
2361         (WTR::EventSenderProxy::updateTouchPoint):
2362         (WTR::EventSenderProxy::setTouchModifier):
2363         (WTR::EventSenderProxy::setTouchPointRadius):
2364         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2365         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2366         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2367         (WTR::EventSenderProxy::touchStart):
2368         (WTR::EventSenderProxy::touchMove):
2369         (WTR::EventSenderProxy::touchEnd):
2370         (WTR::EventSenderProxy::touchCancel):
2371         (WTR::EventSenderProxy::clearTouchPoints):
2372         (WTR::EventSenderProxy::releaseTouchPoint):
2373         (WTR::EventSenderProxy::cancelTouchPoint):
2374
2375 2017-07-27  Brady Eidson  <beidson@apple.com>
2376
2377         Part 2 of: Rename DatabaseProcess to StorageProcess.
2378         https://bugs.webkit.org/show_bug.cgi?id=174880
2379
2380         Reviewed by Andy Estes.
2381
2382         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2383         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2384         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2385         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2386         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2387         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2388         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2389         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2390
2391 2017-07-26  Mark Lam  <mark.lam@apple.com>
2392
2393         Add ability to only run specific tests in run-javascriptcore-tests.
2394         https://bugs.webkit.org/show_bug.cgi?id=174884
2395
2396         Reviewed by Saam Barati.
2397
2398         For example, if we only want to run testapi, we can do so as follows:
2399             $ run-javascriptcore-tests --testapi
2400
2401         Previously, specifying --testapi effectively does nothing because we run all tests
2402         by default.  Only --no-testapi had the effect of disabling the test set.  This
2403         old behavior for --testapi is not very useful or meaningful.  We're now changing
2404         it to mean that we will only run that test.
2405
2406         With this change, we can also run more than one set of tests.  For example, if we
2407         only want to run testmasm and testair, we can do so as follows:
2408             $ run-javascriptcore-tests --testmasm --testair
2409
2410         By default, if no specific test option is specified, run-javascriptcore-tests will
2411         run all tests.
2412
2413         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2414         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2415         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2416         the other set will not run.  For example, the following only runs the mozilla tests:
2417             $ run-javascriptcore-tests --mozilla-tests
2418
2419         Note also that --jit-stress-tests is not for choosing a different set of tests.
2420         Instead, it is used for determining whether we run JIT'ed test configurations
2421         on the jsc stress tests and mozilla tests.  As a result, specifying
2422         --jit-stress-tests will not omit other tests.  For example, the following still
2423         runs all tests:
2424             $ run-javascriptcore-tests --jit-stress-tests
2425
2426         * Scripts/run-javascriptcore-tests:
2427         (defaultStringForTestState):
2428         (enableTestOrNot):
2429         (runJSCStressTests):
2430
2431 2017-07-26  Mark Lam  <mark.lam@apple.com>
2432
2433         Make run-javascriptcore-test run testair, testb3, and testmasm.
2434         https://bugs.webkit.org/show_bug.cgi?id=174837
2435         <rdar://problem/33522927>
2436
2437         Reviewed by Saam Barati and Filip Pizlo.
2438
2439         1. Refactors code for running testapi so that we can use it to run other tests.
2440         2. Added running of testmasm, testair, testb3.
2441
2442         Note: the existing testapi invocation code does not support remote invocation of
2443         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2444         and testb3 also do not support remote invocation.  If we wish to add remote
2445         invocation support, we should do that in a separate patch.
2446
2447         * Scripts/run-javascriptcore-tests:
2448         (testPath):
2449         (runTest):
2450         (testapiPath): Deleted.
2451
2452 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2453
2454         Remove duplicate code from Buildbot.js in dashboard
2455         https://bugs.webkit.org/show_bug.cgi?id=174870
2456
2457         Reviewed by Daniel Bates.
2458
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2460         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2461         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2463         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2464
2465 2017-07-26  Brady Eidson  <beidson@apple.com>
2466
2467         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2468         https://bugs.webkit.org/show_bug.cgi?id=174851
2469
2470         Reviewed by Chris Dumez.
2471
2472         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2473         (TEST):
2474
2475 2017-07-26  Brian Burg  <bburg@apple.com>
2476
2477         Remove WEB_TIMING feature flag
2478         https://bugs.webkit.org/show_bug.cgi?id=174795
2479
2480         Reviewed by Alex Christensen.
2481
2482         * Scripts/webkitperl/FeatureList.pm:
2483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2484
2485 2017-07-26  Chris Dumez  <cdumez@apple.com>
2486
2487         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2488         https://bugs.webkit.org/show_bug.cgi?id=174864
2489         <rdar://problem/33009088>
2490
2491         Reviewed by Geoffrey Garen.
2492
2493         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2494         WKTR.
2495
2496         * DumpRenderTree/mac/EventSendingController.mm:
2497         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2498
2499 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2500
2501         Unreviewed, added Romain Bellessort to contributors.json.
2502
2503         * Scripts/webkitpy/common/config/contributors.json:
2504
2505 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2506
2507         [WPE] WebGL2 support
2508         https://bugs.webkit.org/show_bug.cgi?id=174249
2509
2510         Reviewed by Alex Christensen.
2511
2512         * Scripts/webkitperl/FeatureList.pm:
2513         Enable WebGL2 for WPE when building through build-webkit.
2514
2515 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2516
2517         Unreviewed. Fix GTK distcheck.
2518
2519         * gtk/make-dist.py:
2520         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2521
2522 2017-07-25  Brady Eidson  <beidson@apple.com>
2523
2524         ResourceLoadStatistics grandfathering happens much too often.
2525         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2526
2527         Reviewed by Chris Dumez.
2528
2529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2530         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2531         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2532         (TEST):
2533
2534 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2535
2536         Fix autoinstaller failing on autoinstall_everything
2537         https://bugs.webkit.org/show_bug.cgi?id=174830
2538
2539         Reviewed by Joseph Pecoraro.
2540
2541         * Scripts/webkitpy/thirdparty/__init__.py:
2542         (AutoinstallImportHook.find_module):
2543         (AutoinstallImportHook.install_chromedriver):
2544         (AutoinstallImportHook.install_geckodriver):
2545         (AutoinstallImportHook._install_chromedriver): Deleted.
2546         (AutoinstallImportHook._install_geckodriver): Deleted.
2547
2548 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2549
2550         Replace --runtime with something for both ios-simulator and ios-device
2551         https://bugs.webkit.org/show_bug.cgi?id=173775
2552         <rdar://problem/32952164>
2553
2554         Reviewed by Aakash Jain.
2555
2556         Add --version flag for both iOS simulator and iOS device.
2557
2558         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2559         (parse_args): Add --version flag and move --no-install.
2560         * Scripts/webkitpy/port/factory.py:
2561         (platform_options): Move --no-intall to run_webkit_tests.py.
2562         * Scripts/webkitpy/port/ios.py:
2563         (IOSPort):
2564         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2565         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2566         * Scripts/webkitpy/port/ios_device.py:
2567         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2568         devices for iOS version.
2569         * Scripts/webkitpy/port/ios_device_unittest.py:
2570         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2571         expectation paths without devices connected.
2572         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2573         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2574         (IOSDeviceTest.test_expectations_ordering): Deleted.
2575         * Scripts/webkitpy/port/ios_simulator.py:
2576         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2577         flag to specify a runtime.
2578         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2579         flag and then use the default runtime.
2580
2581 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2582
2583         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2584         https://bugs.webkit.org/show_bug.cgi?id=174815
2585
2586         Reviewed by Carlos Alberto Lopez Perez.
2587
2588         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2589         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2590         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2591         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2592         think), probably because of a newer CMake version.
2593
2594         * CMakeLists.txt:
2595         * TestWebKitAPI/CMakeLists.txt:
2596         * TestWebKitAPI/PlatformGTK.cmake:
2597
2598 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2599
2600         Fix BenchmarkRunner to only import selenium when needed
2601         https://bugs.webkit.org/show_bug.cgi?id=174808
2602
2603         Reviewed by Stephanie Lewis.
2604
2605         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2606         (LinuxChromeDriver.launch_driver):
2607         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2608         (LinuxFirefoxDriver.launch_driver):
2609         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2610         (OSXChromeDriver.launch_driver):
2611         (OSXChromeCanaryDriver.launch_driver):
2612         (create_chrome_options):
2613         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2614         (OSXFirefoxDriver.launch_driver):
2615         (OSXFirefoxNightlyDriver.launch_driver):
2616         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2617         (OSXSafariDriver.launch_driver):
2618         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2619         (WebDriverBenchmarkRunner._run_one_test):
2620
2621 2017-07-23  Darin Adler  <darin@apple.com>
2622
2623         More NeverDestroyed and related cleanup
2624         https://bugs.webkit.org/show_bug.cgi?id=174745
2625
2626         Reviewed by Alex Christensen.
2627
2628         * DumpRenderTree/JavaScriptThreading.cpp:
2629         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2630         DEPRECATED_DEFINE_STATIC_LOCAL.
2631         (javaScriptThreads): Ditto.
2632
2633 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2634
2635         Subclass Benchmark Runner script for WebDriver support
2636         https://bugs.webkit.org/show_bug.cgi?id=174390
2637
2638         Reviewed by Dewei Zhu, Stephanie Lewis.
2639
2640         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2641
2642         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2643         (BenchmarkBuilder.__init__):
2644         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2645         (BenchmarkRunner.__init__):
2646         (BenchmarkRunner._find_plan_file):
2647         (BenchmarkRunner._run_one_test.and):
2648         (BenchmarkRunner.execute):
2649         (BenchmarkRunner._get_result): Deleted.
2650         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2651         (parse_args):
2652         (start):
2653         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2654         (WebDriverBenchmarkRunner):
2655         (WebDriverBenchmarkRunner._get_result):
2656         (WebDriverBenchmarkRunner._run_one_test):
2657         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2658         (WebServerBenchmarkRunner):
2659         (WebServerBenchmarkRunner.__init__):
2660         (WebServerBenchmarkRunner._get_result):
2661         (WebServerBenchmarkRunner._run_one_test):
2662
2663 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2664
2665         Add BenchmarkRunner patches with WebDriver support for each testing plan
2666         https://bugs.webkit.org/show_bug.cgi?id=174443
2667
2668         Reviewed by Dewei Zhu, Stephanie Lewis.
2669
2670         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2671         (BenchmarkBuilder.__enter__):
2672         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2673         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2674         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2675         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2676         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2677         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2678         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2679         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2680         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2681         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2682         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2683         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2684         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2685         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2686         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2687         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2688         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2689         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2690         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2691         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2692         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2693         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2694         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2695         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2696         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2697         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2698         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2699         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2700         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2701         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2702         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2703         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2704         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2705
2706 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2707
2708         Add functions to autoinstaller needed for Benchmark Runner script
2709         https://bugs.webkit.org/show_bug.cgi?id=174331
2710
2711         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2712
2713         Adds autoinstaller functions to install selenium and webdriver binaries
2714         which will be used by the browser driver part of Benchmark Runner.
2715
2716         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2717         (BrowserDriver.restore_env):
2718         (BrowserDriver):
2719         (BrowserDriver.get_webdriver_binary_path):
2720         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2721         (LinuxChromeDriver.launch_driver):
2722         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2723         (LinuxFirefoxDriver.launch_driver):
2724         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2725         (OSXChromeDriver.launch_driver):
2726         (OSXChromeCanaryDriver.launch_driver):
2727         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2728         (OSXFirefoxDriver.launch_driver):
2729         (OSXFirefoxNightlyDriver.launch_driver):
2730         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2731         * Scripts/webkitpy/benchmark_runner/utils.py:
2732         (get_driver_binary_path):
2733         * Scripts/webkitpy/common/system/autoinstall.py:
2734         (AutoInstaller._unzip):
2735         * Scripts/webkitpy/thirdparty/__init__.py:
2736         (AutoinstallImportHook.find_module):
2737         (AutoinstallImportHook._install_selenium):
2738         (AutoinstallImportHook):
2739         (AutoinstallImportHook._install_chromedriver):
2740         (AutoinstallImportHook._install_geckodriver):
2741         (AutoinstallImportHook.get_latest_pypi_url):
2742         (AutoinstallImportHook.install_binary):
2743         (autoinstall_everything):
2744         (get_driver_filename):
2745         (get_os_info):
2746
2747 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2748
2749         Add WebDriver support in browser driver part of BenchmarkRunner
2750         https://bugs.webkit.org/show_bug.cgi?id=174445
2751
2752         Reviewed by Stephanie Lewis.
2753
2754         Adds a launch_driver function to each BrowserDriver subclass. This
2755         function sets up the arguments for the webdriver and launches the
2756         webdriver specific to that browser.
2757
2758         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2759         (BrowserDriver.launch_webdriver):
2760         (BrowserDriver):
2761         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2762         (LinuxBrowserDriver.launch_webdriver):
2763         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2764         (LinuxChromeDriver.launch_url):
2765         (LinuxChromeDriver):
2766         (LinuxChromeDriver.launch_driver):
2767         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2768         (EpiphanyBrowserDriver.launch_url):
2769         (EpiphanyBrowserDriver):
2770         (EpiphanyBrowserDriver.launch_driver):
2771         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2772         (LinuxFirefoxDriver):
2773         (LinuxFirefoxDriver.launch_url):
2774         (LinuxFirefoxDriver.launch_driver):
2775         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2776         (GTKMiniBrowserDriver.launch_url):
2777         (GTKMiniBrowserDriver):
2778         (GTKMiniBrowserDriver.launch_driver):
2779         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2780         (OSXBrowserDriver._launch_webdriver):
2781         (OSXBrowserDriver):
2782         (OSXBrowserDriver._screen_size):
2783         (OSXBrowserDriver._insert_url):
2784         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2785         (OSXChromeDriver):
2786         (OSXChromeDriver.launch_url):
2787         (OSXChromeDriver.launch_driver):
2788         (OSXChromeCanaryDriver):
2789         (OSXChromeCanaryDriver.launch_url):
2790         (OSXChromeCanaryDriver.launch_driver):
2791         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2792         (OSXFirefoxDriver):
2793         (OSXFirefoxDriver.launch_url):
2794         (OSXFirefoxDriver.launch_driver):
2795         (OSXFirefoxNightlyDriver):
2796         (OSXFirefoxNightlyDriver.launch_url):
2797         (OSXFirefoxNightlyDriver.launch_driver):
2798         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2799         (OSXSafariDriver.launch_driver):
2800
2801 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2802
2803         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2804         https://bugs.webkit.org/show_bug.cgi?id=174793
2805
2806         Reviewed by Tim Horton.
2807
2808         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2809         down. Without r219765, this test will dereference null and crash.
2810
2811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2812         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2813         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2814         (TEST):
2815
2816 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2817
2818         [Win] Implement Authentication dialog in MiniBrowser
2819         https://bugs.webkit.org/show_bug.cgi?id=174662
2820
2821         Reviewed by Alex Christensen.
2822
2823         * MiniBrowser/win/Common.cpp:
2824         (CustomUserAgent):
2825         (DisplayAuthDialog):
2826         (AuthDialogProc):
2827         * MiniBrowser/win/MiniBrowserLib.rc:
2828         * MiniBrowser/win/MiniBrowserLibResource.h:
2829         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2830         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2831
2832 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2833
2834         Handle case where line_numbers is None instead of an array of line numbers
2835         https://bugs.webkit.org/show_bug.cgi?id=174775
2836
2837         Reviewed by Aakash Jain.
2838
2839         Added files set line_numbers to None in process_file.
2840
2841         * Scripts/webkitpy/style/filereader.py:
2842         (TextFileReader.process_file): Handle case where line_number is set to None.
2843         * Scripts/webkitpy/style/main_unittest.py:
2844         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2845
2846 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2847
2848         [WPE] Add libepoxy to the Jhbuild moduleset
2849         https://bugs.webkit.org/show_bug.cgi?id=174711
2850
2851         Reviewed by Carlos Alberto Lopez Perez.
2852
2853         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2854
2855 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2856
2857         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2858         https://bugs.webkit.org/show_bug.cgi?id=174780
2859
2860         Reviewed by Carlos Garcia Campos.
2861
2862         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2863         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2864         in case the eglplatform.h header doesn't provide that macro. This replicates
2865         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2866
2867 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2868
2869         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2870         https://bugs.webkit.org/show_bug.cgi?id=174758
2871
2872         Reviewed by Dan Bernstein.
2873
2874         Migrate position-information-related unit tests from the PositionInformationTests suite to
2875         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2876
2877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2878         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2879         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2880         (TestWebKitAPI::TEST):
2881         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2882         * TestWebKitAPI/cocoa/TestWKWebView.h:
2883         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2884         (-[TestWKWebView activatedElementAtPosition:]):
2885
2886 2017-07-22  Chris Dumez  <cdumez@apple.com>
2887
2888         REGRESSION(r204565): WKObject is broken
2889         https://bugs.webkit.org/show_bug.cgi?id=174736
2890         <rdar://problem/33246169>
2891
2892         Reviewed by Dan Bernstein.
2893
2894         Add API test that used to crash.
2895
2896         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2897         (TestWebKitAPI::TEST):
2898
2899 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2900
2901         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2902         https://bugs.webkit.org/show_bug.cgi?id=174705
2903
2904         Reviewed by Mark Lam.
2905
2906         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2907         (TestWebKitAPI::testThreadGroup):
2908         (TestWebKitAPI::TEST):
2909
2910 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2911
2912         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2913         https://bugs.webkit.org/show_bug.cgi?id=174724
2914
2915         Reviewed by Aakash Jain.
2916
2917         * Scripts/webkitpy/port/ios_simulator.py:
2918         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2919         simulator. Errors here should be treated the same as no simulators found.
2920
2921 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2922
2923         [CMake] Add an option to stop build after generating project files
2924         https://bugs.webkit.org/show_bug.cgi?id=174664
2925
2926         Reviewed by Konstantin Tokarev.
2927
2928         Add "--generate-project-only" to stop build after generating project files.
2929
2930         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2931         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2932         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2933         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2934         (isGenerateProjectOnly): ditto
2935
2936 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2937
2938         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2939         https://bugs.webkit.org/show_bug.cgi?id=174501
2940
2941         Reviewed by Darin Adler.
2942
2943         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2944         (TestWebKitAPI::TEST):
2945
2946 2017-07-20  David Quesada  <david_quesada@apple.com>
2947
2948         Add SPI to notify WKNavigationDelegate about client redirects
2949         https://bugs.webkit.org/show_bug.cgi?id=174680
2950         rdar://problem/33184886
2951
2952         Reviewed by Brady Eidson.
2953
2954         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2955         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2956         (TEST):
2957         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2958
2959 2017-07-20  Brady Eidson  <beidson@apple.com>
2960
2961         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2962         https://bugs.webkit.org/show_bug.cgi?id=174685
2963
2964         Reviewed by Andy Estes.
2965
2966         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2967         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2968
2969 2017-07-20  Brady Eidson  <beidson@apple.com>
2970
2971         Deprecate WebIconDatabase in WebKitLegacy/mac.
2972         https://bugs.webkit.org/show_bug.cgi?id=174607
2973
2974         Reviewed by Alex Christensen.
2975
2976         * DumpRenderTree/mac/TestRunnerMac.mm:
2977
2978 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2979
2980         lint-test-expectations should be run during style checking
2981         https://bugs.webkit.org/show_bug.cgi?id=173559
2982         <rdar://problem/32854941>
2983
2984         Reviewed by Aakash Jain.
2985
2986         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2987         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2988         prevents identifying errors on specific lines in a file.
2989         * Scripts/webkitpy/style/main_unittest.py:
2990         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2991         case where a linter error is in the file modified, but the line modified is not related to
2992         the linter error.
2993
2994 2017-07-20  Brady Eidson  <beidson@apple.com>
2995
2996         Remove WebIconDatabase from WebKitLegacy/win.
2997         https://bugs.webkit.org/show_bug.cgi?id=174608
2998
2999         Reviewed by Alex Christensen.
3000
3001         * DumpRenderTree/win/DumpRenderTree.cpp:
3002         (main):
3003         * DumpRenderTree/win/TestRunnerWin.cpp:
3004         (TestRunner::setIconDatabaseEnabled):
3005
3006 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
3007
3008         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
3009         https://bugs.webkit.org/show_bug.cgi?id=174671
3010
3011         Reviewed by Carlos Garcia Campos.
3012
3013         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
3014         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
3015         priority for this source in order to have it dispatched on the same
3016         priority as the other WebKit-controlled GSource objects.
3017
3018 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3019
3020         lint-test-expectations should be run during style checking
3021         https://bugs.webkit.org/show_bug.cgi?id=173559
3022         <rdar://problem/32854941>
3023
3024         Reviewed by Daniel Bates.
3025
3026         Follow up fix addressing style and a few minor bugs.
3027
3028         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3029         (TestExpectationParser.__init__): Use lambda x: x instead of str
3030         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
3031         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
3032         reduce the calls of _shorten_filename, fix minor bug in appending the current
3033         expectation's line number instead of the previous ones, clarify treatment of None
3034         in file-to-line-number mapping.
3035         (TestExpectations._report_warnings): Collapse call.
3036         * Scripts/webkitpy/style/checkers/test_expectations.py:
3037         (TestExpectationsChecker.lint_test_expectations):
3038         * Scripts/webkitpy/style/filereader.py: Re-write comment.
3039         (TextFileReader.process_file): Add comment explaining treatment of None in
3040         file-to-line-number mapping.
3041         (TextFileReader.delete_file): Collapse call.
3042
3043 2017-07-19  Chris Dumez  <cdumez@apple.com>
3044
3045         Unreviewed attempt to fix API test failure after r219663.
3046
3047         The test was hard-coding an exception string and the string has changed slightly
3048         in r219663.
3049
3050         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3051         (TEST):
3052
3053 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
3054
3055         Don't write file URLs to iOS Pasteboard
3056         https://bugs.webkit.org/show_bug.cgi?id=174647
3057         <rdar://problem/33199730>
3058
3059         Reviewed by Wenson Hsieh.
3060
3061         Updating tests to reflect the lack of file URLs for images.
3062
3063         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3064         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
3065         (checkEstimatedSize):
3066         (TestWebKitAPI::TEST):
3067
3068 2017-07-19  Brady Eidson  <beidson@apple.com>
3069
3070         iBooks sometimes crashes when closing a book.
3071         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
3072
3073         Reviewed by Oliver Hunt.
3074
3075         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3076         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
3077         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
3078         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
3079         (TestWebKitAPI::TEST):
3080
3081         Add a "spin the runloop X number of times" utility:
3082         * TestWebKitAPI/Utilities.h:
3083         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3084         (TestWebKitAPI::Util::spinRunLoop):
3085
3086 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3087
3088         lint-test-expectations should be run during style checking
3089         https://bugs.webkit.org/show_bug.cgi?id=173559
3090         <rdar://problem/32854941>
3091
3092         Reviewed by David Kilzer.
3093
3094         Running the test expectation linter requires reading both files and lines not in the
3095         patch because, for example, deletion of a test can cause a lint failure even though
3096         no test expectations where modified. This means that the linter will occasionally warn
3097         about lines which were not changed in a given patch but whose error is related to a
3098         change made in that patch.
3099
3100         * Scripts/webkitpy/common/system/filesystem_mock.py:
3101         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
3102         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3103         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
3104         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
3105         content, description of the error and the name of the associated test.
3106         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
3107         (TestExpectationParser.__init__): Pass shorten_filename function to
3108         TestExpectationsParser to add a deleted file to the related_files dictionary.
3109         (TestExpectationParser._check_test_exists): If the test does not exist, add the
3110         missing path to the related_files dictionary.
3111         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
3112         files and line numbers related to this test expectation line. This will allow
3113         tracking linter errors in the style checker occurring across multiple files.
3114         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
3115         lines to related_files dictionary.
3116         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
3117         (TestExpectations._report_warnings): Construct warning object instead of string
3118         when adding to warnings list.
3119         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
3120         clean-up log.
3121         * Scripts/webkitpy/style/checker.py:
3122         (ProcessorBase.do_association_check): Add required function for processor classes.
3123         (StyleProcessor):
3124         (StyleProcessor.do_association_check): Run the TestExpectations linter when
3125         checking for errors between associated files.
3126         * Scripts/webkitpy/style/checkers/test_expectations.py:
3127         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
3128         (TestExpectationsChecker):
3129         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
3130         of modified files, the current working directory and the host, determine if the linter
3131         warning is associated with the changes.
3132         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
3133         style checker.
3134         * Scripts/webkitpy/style/filereader.py:
3135         (TextFileReader):
3136         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
3137         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
3138         (TextFileReader.process_file): Track both the number of files changed and which lines
3139         in those files were changed.
3140         (TextFileReader.do_association_check): Run the processor's association check on all
3141         modified or deleted files processed by TextFileReader.
3142         (TextFileReader.delete_file): Track deleted files in _files dictionary.
3143         (TextFileReader.count_delete_only_file): Deleted.
3144         * Scripts/webkitpy/style/filereader_unittest.py:
3145         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
3146         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
3147         * Scripts/webkitpy/style/main.py:
3148         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
3149         explicitly run the association check on the file reader.
3150         * Scripts/webkitpy/style/main_unittest.py:
3151         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
3152         embedded in the style checker.
3153         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
3154         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
3155         construct the TextFileReader object with a StyleProcessor used to run style checks on
3156         specific files.
3157         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
3158         testing the test expectation linter inside the style checker. This host must contain a
3159         mock file system with the basic structure of test expectations.
3160         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
3161         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
3162         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
3163         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
3164         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
3165         * Scripts/webkitpy/style/patchreader.py:
3166         (PatchReader.check): Specify which file was deleted, run the association check.
3167         * Scripts/webkitpy/style/patchreader_unittest.py:
3168         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
3169         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
3170         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
3171
3172 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3173
3174         [WTF] Implement WTF::ThreadGroup
3175         https://bugs.webkit.org/show_bug.cgi?id=174081
3176
3177         Reviewed by Mark Lam.
3178
3179         Add WTF::ThreadGroup tests.
3180
3181         * TestWebKitAPI/CMakeLists.txt:
3182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3183         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
3184         (TestWebKitAPI::testThreadGroup):
3185         (TestWebKitAPI::TEST):
3186
3187 2017-07-18  Andy Estes  <aestes@apple.com>
3188
3189         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3190         https://bugs.webkit.org/show_bug.cgi?id=174631
3191
3192         Reviewed by Tim Horton.
3193
3194         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3195         * MiniBrowser/Configurations/Base.xcconfig:
3196         * MobileMiniBrowser/Configurations/Base.xcconfig:
3197         * TestWebKitAPI/Configurations/Base.xcconfig:
3198         * WebKitTestRunner/Configurations/Base.xcconfig:
3199
3200 2017-07-18  Andy Estes  <aestes@apple.com>
3201
3202         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3203         https://bugs.webkit.org/show_bug.cgi?id=174631
3204
3205         Reviewed by Sam Weinig.
3206
3207         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3208         * MiniBrowser/Configurations/Base.xcconfig:
3209         * MobileMiniBrowser/Configurations/Base.xcconfig:
3210         * TestWebKitAPI/Configurations/Base.xcconfig:
3211         * WebKitTestRunner/Configurations/Base.xcconfig:
3212
3213 2017-07-18  Daniel Bates  <dabates@apple.com>
3214
3215         lldb: Add type summary for StringView
3216         https://bugs.webkit.org/show_bug.cgi?id=174637
3217
3218         Reviewed by Sam Weinig.
3219
3220         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
3221         StringView object will print output that has the form:
3222
3223             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3224               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3225               m_length = 2
3226               m_is8Bit = true
3227               m_underlyingString = 0x0000614000000a90
3228             }
3229
3230         * lldb/lldb_webkit.py:
3231         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3232         (WTFStringView_SummaryProvider):
3233         (WTFStringViewProvider):
3234         (WTFStringViewProvider.__init__):
3235         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3236         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3237         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3238         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3239
3240 2017-07-18  Andy Estes  <aestes@apple.com>
3241
3242         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3243         https://bugs.webkit.org/show_bug.cgi?id=174631
3244
3245         Reviewed by Dan Bernstein.
3246
3247         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3248         * MiniBrowser/Configurations/Base.xcconfig:
3249         * MobileMiniBrowser/Configurations/Base.xcconfig:
3250         * TestWebKitAPI/Configurations/Base.xcconfig:
3251         * WebKitTestRunner/Configurations/Base.xcconfig:
3252
3253 2017-07-18  Devin Rousso  <drousso@apple.com>
3254
3255         Web Inspector: Add memoryCost to Inspector Protocol objects
3256         https://bugs.webkit.org/show_bug.cgi?id=174478
3257
3258         Reviewed by Joseph Pecoraro.
3259
3260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3261         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3262         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3263         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3264         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3265         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3266         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3267         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3268         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3269         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3270         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3271         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3272         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3273         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3274         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3275         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3276         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3277
3278 2017-07-18  Andy Estes  <aestes@apple.com>
3279
3280         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3281         https://bugs.webkit.org/show_bug.cgi?id=174631
3282
3283         Reviewed by Darin Adler.
3284
3285         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3286         * MiniBrowser/Configurations/Base.xcconfig:
3287         * MobileMiniBrowser/Configurations/Base.xcconfig:
3288         * TestWebKitAPI/Configurations/Base.xcconfig:
3289         * WebKitTestRunner/Configurations/Base.xcconfig:
3290
3291 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3292
3293         Unreviewed, fix the iOS build.
3294
3295         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3296
3297         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3298         (TestWebKitAPI::TEST):
3299
3300 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3301
3302         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3303         https://bugs.webkit.org/show_bug.cgi?id=174585
3304         <rdar://problem/33302541>
3305
3306         Reviewed by Tim Horton.
3307
3308         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3309         being dragged when initiating a drag.
3310
3311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3312         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3313         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3314         (TestWebKitAPI::TEST):
3315         * TestWebKitAPI/cocoa/TestWKWebView.h:
3316
3317         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3318
3319         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3320         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3321
3322 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3323
3324         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3325         https://bugs.webkit.org/show_bug.cgi?id=174547
3326
3327         Reviewed by Alex Christensen.
3328
3329         * DumpRenderTree/PlatformWin.cmake:
3330         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3331
3332 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3333
3334         Update style checker to deal with "final"
3335         https://bugs.webkit.org/show_bug.cgi?id=174528
3336
3337         Reviewed by Alex Christensen.
3338         
3339         check-webkit-style shouldn't complain about an open brace to start a
3340         line after a function definition with "final" or "const final".
3341
3342         * Scripts/webkitpy/style/checkers/cpp.py:
3343         (check_braces):
3344         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3345         (CppStyleTest.test_brace_at_begin_of_line):
3346
3347 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3348
3349         Modernize content extension code
3350         https://bugs.webkit.org/show_bug.cgi?id=174588
3351
3352         Reviewed by Sam Weinig.
3353
3354         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3355         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3356         (TestWebKitAPI::testRequest):
3357         (TestWebKitAPI::makeBackend):
3358         (TestWebKitAPI::TEST_F):
3359
3360 2017-07-17  Brady Eidson  <beidson@apple.com>
3361
3362         WKHTTPCookieStore observing only works on the default cookie store.
3363         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3364
3365         Reviewed by Sam Weinig.
3366
3367         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3368         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3369           called for the default store, a non-persistent store, and a custom store.
3370         (TEST):
3371
3372 2017-07-16  Sam Weinig  <sam@webkit.org>
3373
3374         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3375         https://bugs.webkit.org/show_bug.cgi?id=174575
3376
3377         Reviewed by Brady Eidson.
3378
3379         * Scripts/svn-create-patch:
3380         (findModificationType):
3381         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3382         default value of "unknown".
3383
3384         (generateFileList):
3385         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3386         for untracked, which matches our old behavior.
3387
3388 2017-07-17  Charlie Turner  <cturner@igalia.com>
3389
3390         Add some missing build dependencies on Fedora
3391         https://bugs.webkit.org/show_bug.cgi?id=174578
3392
3393         Unreviewed dependency update.
3394
3395         * gtk/install-dependencies:
3396
3397 2017-07-16  Brady Eidson  <beidson@apple.com>
3398
3399         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3400         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3401
3402         Reviewed by Tim Horton.
3403
3404         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3405         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3406         (TEST):
3407
3408 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3409
3410         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3411         https://bugs.webkit.org/show_bug.cgi?id=174540
3412
3413         Reviewed by Michael Catanzaro.
3414
3415         * gtk/generate-inspector-gresource-manifest.py:
3416         (get_filenames): sort list of input files
3417
3418 2017-07-15  Brady Eidson  <beidson@apple.com>
3419
3420         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3421         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3422
3423         Reviewed by Tim Horton.
3424
3425         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3426         (TEST): Make this test more reliable by clearing everything beforehand.
3427
3428 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3429
3430         Make it possible to extend check-webkit-style with Apple-internal checkers
3431         <https://webkit.org/b/174464>
3432         <rdar://problem/25564402>
3433
3434         Reviewed by Darin Adler.
3435
3436         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3437         (_all_categories): Add categories from apple_additions() if it
3438         exists.
3439         (CheckerDispatcher._create_checker): Create python checker
3440         from apple_additions() if it exists.
3441
3442 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3443
3444         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3445         https://bugs.webkit.org/show_bug.cgi?id=174539
3446         <rdar://problem/33307395>
3447
3448         Reviewed by Darin Adler.
3449
3450         Adds a new unit test suite to cover action sheet popover presentation.
3451
3452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3453         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3454         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3455         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3456
3457         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3458
3459         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3460         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3461
3462         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3463
3464         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3465         (TestWebKitAPI::TEST):
3466
3467 2017-07-15  Sam Weinig  <sam@webkit.org>
3468
3469         [Scripts] Make svn-create-patch work better when called in sub directories
3470         https://bugs.webkit.org/show_bug.cgi?id=174551
3471
3472         Reviewed by Darin Adler.
3473
3474         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3475           by ensuring that the prefix is applied as is done in generateDiff.
3476         - Silence output of explanatory lines from svn stat (" > move to ...")
3477           that show up in STDERR when running svn-create-patch.
3478         - Add verbose logging that I found useful while debugging this issue.
3479
3480         * Scripts/svn-create-patch:
3481         (findBaseUrl):
3482         (findMimeType):
3483         (findSourceFileAndRevision):
3484         (generateDiff):
3485         (generateFileList):
3486         (manufacturePatchForAdditionWithHistory):
3487
3488 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3489
3490         Unreviewed build fix after r219537.
3491
3492         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3493
3494 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3495
3496         Add iOS 11 SPI
3497         https://bugs.webkit.org/show_bug.cgi?id=174430
3498         <rdar://problem/33269288>
3499
3500         Reviewed by Tim Horton.
3501
3502         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3503         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3504         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3505
3506 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3507
3508         Failing to install on iPad simulators
3509         https://bugs.webkit.org/show_bug.cgi?id=174532
3510         <rdar://problem/33328347>
3511
3512         Reviewed by Stephanie Lewis.
3513
3514         * Scripts/webkitpy/xcode/simulated_device.py:
3515         (SimulatedDevice.install_app): Place install command in retry try-except block.
3516
3517 2017-07-14  Jeff Miller  <jeffm@apple.com>
3518
3519         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3520         https://bugs.webkit.org/show_bug.cgi?id=174524
3521
3522         Reviewed by Sam Weinig.
3523
3524         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3525         (TEST):
3526         Renamed TestParameter to TestParameter1.
3527         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3528
3529         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3530         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3531         Observe changes for two bundle parameters.
3532
3533         (-[BundleParametersPlugIn dealloc]):
3534         Remove observers for two bundle parameters.
3535
3536 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3537
3538         Unreviewed, rolling out r219510.
3539         https://bugs.webkit.org/show_bug.cgi?id=174525
3540
3541         Need to revert length() == 0 check for null string (Requested
3542         by yusukesuzuki on #webkit).
3543
3544         Reverted changeset:
3545
3546         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3547         static string if StringImpl is static"
3548         https://bugs.webkit.org/show_bug.cgi?id=174501
3549         http://trac.webkit.org/changeset/219510
3550
3551 2017-07-14  Jer Noble  <jer.noble@apple.com>
3552
3553         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3554         https://bugs.webkit.org/show_bug.cgi?id=174514
3555
3556         Reviewed by Sam Weinig.
3557
3558         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3559         (TestWebKitAPI::TEST_F):
3560
3561 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3562
3563         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3564         https://bugs.webkit.org/show_bug.cgi?id=174501
3565
3566         Reviewed by Darin Adler.
3567
3568         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3569         (TestWebKitAPI::TEST):
3570
3571 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3572
3573         Bring mac expectations in-line with other platforms
3574         https://bugs.webkit.org/show_bug.cgi?id=174472
3575         <rdar://problem/33297388>
3576
3577         Reviewed by David Kilzer.
3578
3579         The override order for Mac test expectations does not conform to the pattern used by iOS,
3580         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3581
3582             platform/mac-wk2
3583             platform/wk2
3584             platform/mac-elcapitan
3585             platform/mac-sierra
3586             generic
3587
3588         After this change, El Capitan's baseline search path looks like this:
3589
3590             platform/mac-sierra-wk2
3591             platform/mac-sierra
3592             platform/mac-wk2
3593             platform/wk2
3594             generic
3595
3596         * Scripts/webkitpy/port/mac.py:
3597         (MacPort.__init__): If a specific version is specified in the port name, use that
3598         as the os version.
3599         (MacPort.default_baseline_search_path): Expectation search paths should work the
3600         same way they do on other ports. Port + version overrides port, port overrides generic
3601         and wk1/wk2 should override expectations for the two combined.