22c3cc5e60f7a2998415dde23ada9e7b2e448481
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-08  Alex Christensen  <achristensen@webkit.org>
2
3         Fix possible null dereference in WebBackForwardList::restoreFromState
4         https://bugs.webkit.org/show_bug.cgi?id=188418
5         <rdar://problem/42531726>
6
7         Reviewed by Chris Dumez.
8
9         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
10         (TestWebKitAPI::TEST):
11
12 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
13
14         run-builtins-generator-tests does not correctly handle CRLFs from stderr
15         https://bugs.webkit.org/show_bug.cgi?id=188392
16
17         Reviewed by Fujii Hironori.
18
19         Background:
20         file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.
21
22         * Scripts/webkitpy/common/system/executive.py:
23         (Executive.run_command):
24         Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.
25
26 2018-08-08  Aditya Keerthi  <akeerthi@apple.com>
27
28         Unreviewed, add myself to committers list.
29
30         * Scripts/webkitpy/common/config/contributors.json:
31
32 2018-08-08  Commit Queue  <commit-queue@webkit.org>
33
34         Unreviewed, rolling out r234314, r234320, and r234321.
35         https://bugs.webkit.org/show_bug.cgi?id=188414
36
37         Caused email sign in issue (Requested by ryanhaddad on
38         #webkit).
39
40         Reverted changesets:
41
42         "Remove unused WKNavigationDelegatePrivate
43         decidePolicyForNavigationAction SPI"
44         https://bugs.webkit.org/show_bug.cgi?id=188077
45         https://trac.webkit.org/changeset/234314
46
47         "Fix API tests after r234314"
48         https://bugs.webkit.org/show_bug.cgi?id=188077
49         https://trac.webkit.org/changeset/234320
50
51         "Fix API tests after r234314"
52         https://bugs.webkit.org/show_bug.cgi?id=188077
53         https://trac.webkit.org/changeset/234321
54
55 2018-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
56
57         [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
58         https://bugs.webkit.org/show_bug.cgi?id=188401
59         <rdar://problem/32542300>
60
61         Reviewed by Ryosuke Niwa.
62
63         When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
64         run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
65         is because each of the three steps of this test ends when UIScriptController's `didHideKeyboardCallback` is
66         invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
67         keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
68         skip over one of the steps in the layout test, resulting in a text diff failure.
69
70         To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
71         as a part of resetting test controller state, before moving on to the next layout test.
72
73         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
74         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
75         (-[TestRunnerWKWebView didStartFormControlInteraction]):
76         (-[TestRunnerWKWebView didEndFormControlInteraction]):
77
78         Use these hooks to keep track of whether the previous test is presenting any form input UI.
79
80         (-[TestRunnerWKWebView isInteractingWithFormControl]):
81         * WebKitTestRunner/ios/TestControllerIOS.mm:
82         (WTR::handleKeyboardWillHideNotification):
83         (WTR::handleKeyboardDidHideNotification):
84         (WTR::TestController::platformInitialize):
85         (WTR::TestController::platformDestroy):
86
87         Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
88         of when the keyboard dismissal animation ends.
89
90         (WTR::TestController::platformResetStateToConsistentValues):
91
92         Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
93         which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
94         finish. This includes any keyboard dismissal animations triggered as a result of step (1).
95
96 2018-08-05  Darin Adler  <darin@apple.com>
97
98         [Cocoa] More tweaks and refactoring to prepare for ARC
99         https://bugs.webkit.org/show_bug.cgi?id=188245
100
101         Reviewed by Dan Bernstein.
102
103         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
104         CFTypeRef instead of void*.
105
106         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
107         (createCoreAnimationLayer): Use CFBridgingRetain.
108
109         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
110         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
111         (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
112         (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
113         (AccessibilityUIElement::textMarkerRangeLength): Ditto.
114         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
115         (AccessibilityUIElement::indexForTextMarker): Ditto.
116         (AccessibilityUIElement::textMarkerForIndex): Ditto.
117         (AccessibilityUIElement::isTextMarkerValid): Ditto.
118         (AccessibilityUIElement::previousTextMarker): Ditto.
119         (AccessibilityUIElement::nextTextMarker): Ditto.
120         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
121         (createJSStringRef): Ditto.
122         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
123         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
124         (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
125         (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
126         (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
127         (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
128         (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
129         (AccessibilityUIElement::textMarkerForPoint): Ditto.
130         (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
131         (AccessibilityUIElement::startTextMarker): Ditto.
132         (AccessibilityUIElement::endTextMarker): Ditto.
133         (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
134         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
135         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
136         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
137         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
138         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
139         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
140         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
141         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
142         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
143         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
144
145         * DumpRenderTree/mac/DumpRenderTree.mm:
146         (resetWebPreferencesToConsistentValues): Use bridging cast.
147         (dumpFramesAsText): Ditto.
148         (dumpBackForwardListForAllWindows): Use a modern for loop instead of
149         CFArray functions to iterate the array.
150         (dump): Use bridging cast.
151         (runTest): Ditto.
152
153         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
154         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
155         (toUTI): Return a RetainPtr<CFStringRef>.
156         (-[LocalPasteboard types]): Use the above and bridging casts.
157         (-[LocalPasteboard availableTypeFromArray:]): Ditto.
158         (-[LocalPasteboard setData:forType:]): Ditto.
159         (-[LocalPasteboard dataForType:]): Ditto.
160         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
161         instead of CFPropertyList.
162         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
163         CFStringCreateExternalRepresentation.
164
165         * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
166         instead of an Objective-C object pointer type.
167         * DumpRenderTree/mac/MockGeolocationProvider.mm:
168         (-[MockGeolocationProvider registerWebView:]): Update for above.
169         (-[MockGeolocationProvider unregisterWebView:]): Ditto.
170         (-[MockGeolocationProvider timerFired]): Ditto.
171
172         * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
173         HashMap and HashSet instead of an Objective-C object pointer type.
174         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
175         (-[MockWebNotificationProvider registerWebView:]): Update for above.
176         (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
177         (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
178         (-[MockWebNotificationProvider cancelNotification:]): Ditto.
179         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
180
181         * DumpRenderTree/mac/ObjCPlugin.m:
182         (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
183
184         * DumpRenderTree/mac/TestRunnerMac.mm:
185         (TestRunner::addDisallowedURL): Use bridging cast.
186         (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
187         (TestRunner::clearApplicationCacheForOrigin): Ditto.
188         (originsArrayToJS): Ditto.
189         (TestRunner::copyDecodedHostName): Ditto.
190         (TestRunner::copyEncodedHostName): Ditto.
191         (TestRunner::queueLoad): Ditto.
192         (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
193         (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
194         (TestRunner::setUserStyleSheetLocation): Ditto.
195         (TestRunner::setValueForUser): Ditto.
196         (TestRunner::overridePreference): Ditto.
197         (TestRunner::execCommand): Ditto.
198         (TestRunner::findString): Ditto.
199         (TestRunner::isCommandEnabled): Ditto.
200         (TestRunner::addOriginAccessWhitelistEntry): Ditto.
201         (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
202         (TestRunner::addUserScript): Ditto.
203         (TestRunner::addUserStyleSheet): Ditto.
204         (TestRunner::evaluateInWebInspector): Ditto.
205         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
206         (TestRunner::authenticateSession): Ditto.
207         (TestRunner::grantWebNotificationPermission): Ditto.
208         (TestRunner::denyWebNotificationPermission): Ditto.
209         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
210         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
211
212         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
213         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
214         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
215         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
216         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
217         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
218         (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
219         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
220         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
221         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
222         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
223         (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
224         (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
225         (WTR::AccessibilityUIElement::startTextMarker): Ditto.
226         (WTR::AccessibilityUIElement::endTextMarker): Ditto.
227         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
228         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
229         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
230         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
231         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
232         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
233         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
234         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
235         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
236         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
237
238         * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
239         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
240
241         * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
242         so we can use the type and know it inherits from NSWindow.
243
244         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
245         so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
246         class into a separate file.
247         (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
248         instead of have a second copy of the implementation.
249
250         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
251         so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
252         (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
253
254         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
255         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
256         (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
257         (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
258         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
259         instead of CFPropertyList.
260         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
261         CFStringCreateExternalRepresentation.
262
263         * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
264         WebKitTestRunnerWindow here so it can be included by files that need to know
265         what the type is and that it inherits from NSWindow.
266
267         * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
268         (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
269         messier implementation.
270
271 2018-08-07  Alex Christensen  <achristensen@webkit.org>
272
273         Add a test for using SafeBrowsing
274         https://bugs.webkit.org/show_bug.cgi?id=188290
275
276         Reviewed by Chris Dumez.
277
278         Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
279         We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
280
281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
282         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
283         (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
284         (TestWebKitAPI::TEST):
285
286 2018-08-07  Lucas Forschler  <lforschler@apple.com>
287
288         If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
289         https://bugs.webkit.org/show_bug.cgi?id=188235
290
291         Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
292
293         * Scripts/webkitpy/common/checkout/changelog.py: 
294         (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
295         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
296         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
297         (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
298         * Scripts/webkitpy/tool/commands/upload.py:
299         (Upload): Teach the upload step how to add radar information when creating a new bug.
300         * Scripts/webkitpy/tool/steps/__init__.py:
301         * Scripts/webkitpy/tool/steps/addradar.py: Added.
302         (AddRadar):
303         (AddRadar.run): Contains the logic to add the radar information to bugzilla.
304         * Scripts/webkitpy/tool/steps/createbug.py:
305         (CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
306
307 2018-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
308
309         Post-review feedback after r234614.
310         https://bugs.webkit.org/show_bug.cgi?id=188322
311         <rdar://problem/42455270>
312
313         Reviewed by Sam Weinig.
314
315         Use std::round instead of roundl — there's no reason to go from double to long double precision when rounding.
316
317         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
318         (rounded):
319
320 2018-08-07  Don Olmstead  <don.olmstead@sony.com>
321
322         [MiniBrowser][Win] Allow selection of recent user agents
323         https://bugs.webkit.org/show_bug.cgi?id=188371
324
325         Reviewed by Fujii Hironori.
326
327         Updates the user agent spoofing strings to the latest released
328         versions and adds Microsoft Edge's user agent.
329
330         Moves the menu item selection to the common base class, BrowserWindow
331         to support user agent spoofing in a WebKitLegacyBrowserWindow and
332         WebKitBrowserWindow.
333
334         * MiniBrowser/win/BrowserWindow.cpp: Added.
335         (BrowserWindow::setUserAgent):
336         * MiniBrowser/win/BrowserWindow.h:
337         * MiniBrowser/win/CMakeLists.txt:
338         * MiniBrowser/win/MainWindow.cpp:
339         (MainWindow::toggleMenuItem):
340         * MiniBrowser/win/MiniBrowserLib.rc:
341         * MiniBrowser/win/MiniBrowserLibResource.h:
342         * MiniBrowser/win/WebKitBrowserWindow.cpp:
343         * MiniBrowser/win/WebKitBrowserWindow.h:
344         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
345         (WebKitLegacyBrowserWindow::setUserAgent):
346         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
347
348 2018-08-07  Yusuke Suzuki  <utatane.tea@gmail.com>
349
350         Unreviewed, add a new address to my configuration
351
352         * Scripts/webkitpy/common/config/contributors.json:
353
354 2018-08-06  David Quesada  <david_quesada@apple.com>
355
356         webkitdirs.pm should default to iPhone SE for 64-bit testing
357         https://bugs.webkit.org/show_bug.cgi?id=188361
358
359         Reviewed by Daniel Bates.
360
361         Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
362
363         * Scripts/webkitdirs.pm:
364         (findOrCreateSimulatorForIOSDevice):
365         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
366         (parse_args):
367             Update the help text for --device-type to reflect the new default device.
368
369 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
370
371         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
372         https://bugs.webkit.org/show_bug.cgi?id=188322
373         <rdar://problem/42455270>
374
375         Reviewed by Tim Horton.
376
377         Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
378         was not in content view coordinates, unlike the x, y, and height.
379
380         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
381         (rounded):
382         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
383         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
384         (TestWebKitAPI::TEST):
385
386 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
387
388         Unreviewed, rolling out r234569.
389
390         Breaks internal builds.
391
392         Reverted changeset:
393
394         "We should cache the compiled sandbox profile in a data vault"
395         https://bugs.webkit.org/show_bug.cgi?id=184991
396         https://trac.webkit.org/changeset/234569
397
398 2018-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
399
400         [Win][DLLLauncher] Remove --highDPI switch
401         https://bugs.webkit.org/show_bug.cgi?id=188255
402
403         Reviewed by Yusuke Suzuki.
404
405         Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
406         aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
407         became useless since the change. Remove the switch.
408
409         This change fixes the issue all dump render tree tests are failing
410         in WinCairo port if high DPI display is connected.
411
412         * MiniBrowser/win/Common.cpp:
413         (parseCommandLine): Removed `--highDPI` switch.
414         * win/DLLLauncher/DLLLauncherMain.cpp:
415         (wWinMain): Do not call SetProcessDPIAware.
416         (shouldUseHighDPI): Deleted.
417
418 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
419
420         [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
421         https://bugs.webkit.org/show_bug.cgi?id=188335
422         <rdar://problem/32542437> and <rdar://problem/32542433>
423
424         Reviewed by Tim Horton.
425
426         Remove a UIScriptController helper method that attempted to wait for QuickType buttons to appear, and then send
427         touch events to the buttons. These were only used for the two tests which this patch refactors. See the
428         LayoutTests ChangeLog for more detail.
429
430         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
431         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
432         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
433         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
434         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
435         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
436         * TestRunnerShared/UIScriptContext/UIScriptController.h:
437         * TestRunnerShared/spi/UIKitTestSPI.h:
438
439         Remove an internal class declaration that is now unnecessary.
440
441         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
442         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
443         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
444
445 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
446
447         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
448         https://bugs.webkit.org/show_bug.cgi?id=188322
449         <rdar://problem/42455270>
450
451         Reviewed by Tim Horton.
452
453         Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
454         test. Also adds new API tests to verify that when a web view resigns first responder, both caret and range
455         selection views are hidden, and when first responder status is restored, both caret and range selection views
456         are made visible again.
457
458         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
459         (WTR::UIScriptController::selectionStartGrabberViewRect const):
460         (WTR::UIScriptController::selectionEndGrabberViewRect const):
461         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
462         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
463         (WTR::UIScriptController::selectionStartGrabberViewRect const):
464         (WTR::UIScriptController::selectionEndGrabberViewRect const):
465         * TestRunnerShared/UIScriptContext/UIScriptController.h:
466         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
467         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
468         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
469         (webViewWithAutofocusedInput):
470
471         Pull out some common logic for creating a web view that allows programmatic focus to present the keyboard, and
472         immediately loading a web page with an autofocusing text field.
473
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/cocoa/TestWKWebView.h:
476         * TestWebKitAPI/cocoa/TestWKWebView.mm:
477         (-[TestWKWebView caretViewRectInContentCoordinates]):
478         (-[TestWKWebView selectionViewRectsInContentCoordinates]):
479         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
480         (WTR::UIScriptController::selectionStartGrabberViewRect const):
481         (WTR::UIScriptController::selectionEndGrabberViewRect const):
482
483 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
484
485         [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
486         https://bugs.webkit.org/show_bug.cgi?id=188334
487         <rdar://problem/40630074>
488
489         Reviewed by Tim Horton.
490
491         To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
492         and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
493         vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
494         it to a completion block, and invoke the completion block to signal that the previous HID event has been
495         processed.
496
497         This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
498         shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
499         IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
500         callback ID because the buffer was clamped to 8 bytes.
501
502         However, on recent iOS SDKs that contain the fix for <rdar://problem/20082284>, IOKit no longer clamps the size
503         of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
504         read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
505         the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
506         callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
507         be thrown.
508
509         To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.
510
511         * WebKitTestRunner/ios/HIDEventGenerator.mm:
512         (+[HIDEventGenerator nextEventCallbackID]):
513         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
514
515         Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.
516
517 2018-08-03  Ben Richards  <benton_richards@apple.com>
518
519         We should cache the compiled sandbox profile in a data vault
520         https://bugs.webkit.org/show_bug.cgi?id=184991
521
522         Reviewed by Ryosuke Niwa.
523
524         Added trace points for sandbox initialization
525
526         * Tracing/SystemTracePoints.plist:
527
528 2018-08-03  David Fenton  <david_fenton@apple.com>
529
530         Unreviewed, rolling out r234517.
531
532         Caused API test failures on iOS
533
534         Reverted changeset:
535
536         "[Cocoa] setCookie API fails to set session cookies for
537         defaultDataStore if processPool created but not used"
538         https://bugs.webkit.org/show_bug.cgi?id=188209
539         https://trac.webkit.org/changeset/234517
540
541 2018-08-03  Ben Richards  <benton_richards@apple.com>
542
543         Add configuration for automatic process pre-warming
544         https://bugs.webkit.org/show_bug.cgi?id=187108
545
546         Reviewed by Ryosuke Niwa.
547
548         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
549
550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
551         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
552         (TEST):
553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
554         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
555         (TEST):
556
557 2018-08-03  Aakash Jain  <aakash_jain@apple.com>
558
559         [ews-build] Add build step to Check Patch Relevance
560         https://bugs.webkit.org/show_bug.cgi?id=188295
561
562         Reviewed by Lucas Forschler.
563
564         * BuildSlaveSupport/ews-build/steps.py:
565         (CheckPatchRelevance): Added step to check patch relevance.
566         (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevant.
567         (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
568         (CheckPatchRelevance._addToLog): Add the log message.
569         (CheckPatchRelevance.start):
570         * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance step appropriately.
571
572 2018-08-03  Jer Noble  <jer.noble@apple.com>
573
574         Unreviewed gardening; r234534 changed the policy for what audio session is set when a
575         media element is paused. Updating the test to reflect the new policy.
576
577         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
578         (TestWebKitAPI::TEST):
579
580 2018-08-03  Zalan Bujtas  <zalan@apple.com>
581
582         [LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust viewport stretching.
583         https://bugs.webkit.org/show_bug.cgi?id=188306
584
585         Reviewed by Antti Koivisto.
586
587         * LayoutReloaded/misc/LFC-passing-tests.txt:
588
589 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
590
591         [WPE] Use the new key mapper API from WPEBackend
592         https://bugs.webkit.org/show_bug.cgi?id=188216
593
594         Reviewed by Žan Doberšek.
595
596         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
597         (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_for_key_code() to get the hardware key
598         code.
599         * wpe/backends/WindowViewBackend.cpp:
600         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
601         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
602         (WPEToolingBackends::WindowViewBackend::modifiers const):
603         * wpe/backends/WindowViewBackend.h:
604
605 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
606
607         [WPE] Implement MouseEvent.buttons
608         https://bugs.webkit.org/show_bug.cgi?id=187998
609
610         Reviewed by Žan Doberšek.
611
612         Pass modifiers to mouse events.
613
614         * WebKitTestRunner/EventSenderProxy.h:
615         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
616         (WTR::senderButtonToWPEButton):
617         (WTR::modifierForButton):
618         (WTR::EventSenderProxy::mouseDown):
619         (WTR::EventSenderProxy::mouseUp):
620         (WTR::EventSenderProxy::mouseMoveTo):
621         (WTR::EventSenderProxy::mouseScrollBy):
622         (WTR::wkEventModifiersToWPE):
623         (WTR::wpeKeySymForKeyRef):
624         (WTR::EventSenderProxy::keyDown):
625         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
626         * wpe/backends/WindowViewBackend.cpp:
627         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
628         (WPEToolingBackends::WindowViewBackend::modifiers const):
629         * wpe/backends/WindowViewBackend.h:
630
631 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
632
633         [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
634         https://bugs.webkit.org/show_bug.cgi?id=188093
635
636         Reviewed by Žan Doberšek.
637
638         * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
639         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
640         (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_code().
641         (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event since it was removed.
642         * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versions.
643         * wpe/backends/WindowViewBackend.cpp:
644         (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unicode char to the event since it was removed.
645         * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
646
647 2018-08-02  Nan Wang  <n_wang@apple.com>
648
649         AX: [iOS] add support to return the attributed string under the element
650         https://bugs.webkit.org/show_bug.cgi?id=188276
651         <rdar://problem/42872357>
652
653         Reviewed by Chris Fleizach.
654
655         * DumpRenderTree/AccessibilityUIElement.cpp:
656         (attributedStringForElementCallback):
657         (AccessibilityUIElement::getJSClass):
658         * DumpRenderTree/AccessibilityUIElement.h:
659         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
660         (AccessibilityUIElement::attributedStringForElement):
661         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
662         (WTR::AccessibilityUIElement::attributedStringForElement):
663         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
664         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
665         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
666         (WTR::AccessibilityUIElement::attributedStringForElement):
667
668 2018-08-02  Ryan Haddad  <ryanhaddad@apple.com>
669
670         Skip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
671         https://bugs.webkit.org/show_bug.cgi?id=175204
672
673         Unreviewed test gardening.
674
675         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
676
677 2018-08-02  Sihui Liu  <sihui_liu@apple.com>
678
679         [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
680         https://bugs.webkit.org/show_bug.cgi?id=188209
681
682         Reviewed by Geoffrey Garen.
683
684         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
685         (TEST):
686
687 2018-08-02  Dan Bernstein  <mitz@apple.com>
688
689         Fixed WebKit.AttrStyle timing out on build.webkit.org.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
692           access to one that doesn’t.
693         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
694         (TEST): Updated expected value.
695
696 2018-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
697
698         [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
699         https://bugs.webkit.org/show_bug.cgi?id=188251
700         <rdar://problem/37842108>
701
702         Reviewed by Tim Horton.
703
704         Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
705         -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
706
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
709         (TestWebKitAPI::TEST):
710         * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
711
712         Pull some logic used to force an input session to start out from an existing API test file
713         (WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
714         new keyboard input test.
715
716         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
717         (-[AutofillTestView initWithFrame:]):
718         (TestWebKitAPI::TEST):
719         (-[TestInputDelegate init]): Deleted.
720         (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
721         * TestWebKitAPI/ios/UIKitSPI.h:
722
723         Add some UIKit SPI utilized by the new API test.
724
725 2018-08-01  Dan Bernstein  <mitz@apple.com>
726
727         Optionally expose Attr::style to JavaScript
728         https://bugs.webkit.org/show_bug.cgi?id=188226
729         <rdar://problem/42818113>
730
731         Reviewed by Darin Adler.
732
733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
734         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
735         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
736         (TEST):
737
738 2018-08-02  David Fenton  <david_fenton@apple.com>
739
740         Unreviewed, rolling out r234489.
741
742         Caused 50+ crashes and 60+ API failures on iOS
743
744         Reverted changeset:
745
746         "[WTF] Rename String::format to String::deprecatedFormat"
747         https://bugs.webkit.org/show_bug.cgi?id=188191
748         https://trac.webkit.org/changeset/234489
749
750 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
751
752         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
753         https://bugs.webkit.org/show_bug.cgi?id=188244
754
755         Reviewed by Daniel Bates.
756
757         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
758
759         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
760
761 2018-08-01  Tomas Popela  <tpopela@redhat.com>
762
763         [WTF] Rename String::format to String::deprecatedFormat
764         https://bugs.webkit.org/show_bug.cgi?id=188191
765
766         Reviewed by Darin Adler.
767
768         It should be replaced with string concatenation.
769
770         * DumpRenderTree/win/DumpRenderTree.cpp:
771         (applicationId):
772         (main):
773         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
774         (TestWebKitAPI::Util::createURLForResource):
775         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
776         (WTR::cacheTestRunnerCallback):
777         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
778         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
779         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
780         (WTR::AccessibilityUIElement::attributedStringForRange):
781         (WTR::AccessibilityUIElement::url):
782         (WTR::stringAtOffset):
783         * WebKitTestRunner/TestController.cpp:
784         (WTR::TestController::didReceiveAuthenticationChallenge):
785         (WTR::TestController::downloadDidFail):
786         (WTR::originUserVisibleName):
787         (WTR::userMediaOriginHash):
788         (WTR::TestController::didNavigateWithNavigationData):
789         (WTR::TestController::didPerformClientRedirect):
790         (WTR::TestController::didPerformServerRedirect):
791         (WTR::TestController::didUpdateHistoryTitle):
792
793 2018-08-01  Nan Wang  <n_wang@apple.com>
794
795         AX: AOM: Add ARIA IDL Attribute Reflection
796         https://bugs.webkit.org/show_bug.cgi?id=184676
797         <rdar://problem/39476882>
798
799         Reviewed by Chris Fleizach.
800
801         * DumpRenderTree/mac/DumpRenderTree.mm:
802         (enableExperimentalFeatures):
803         * WebKitTestRunner/TestController.cpp:
804         (WTR::TestController::resetPreferencesToConsistentValues):
805
806 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
807
808         Use iPhone SE as the default simulated device
809         https://bugs.webkit.org/show_bug.cgi?id=188227
810
811         Reviewed by Aakash Jain.
812
813         * Scripts/webkitpy/port/ios_simulator.py:
814         (IOSSimulatorPort):
815
816 2018-08-01  Commit Queue  <commit-queue@webkit.org>
817
818         Unreviewed, rolling out r234443 and r234445.
819         https://bugs.webkit.org/show_bug.cgi?id=188224
820
821         Revision caused 3 api failures across all platforms.
822         (Requested by Truitt on #webkit).
823
824         Reverted changesets:
825
826         "Add configuration for automatic process pre-warming"
827         https://bugs.webkit.org/show_bug.cgi?id=187108
828         https://trac.webkit.org/changeset/234443
829
830         "Add configuration for automatic process pre-warming"
831         https://bugs.webkit.org/show_bug.cgi?id=187108
832         https://trac.webkit.org/changeset/234445
833
834 2018-07-31  Ben Richards  <benton_richards@apple.com>
835
836         Add configuration for automatic process pre-warming
837         https://bugs.webkit.org/show_bug.cgi?id=187108
838
839         Reviewed by Ryosuke Niwa.
840
841         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
842
843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
844         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
845         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
846         (TEST):
847
848 2018-07-31  John Wilander  <wilander@apple.com>
849
850         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
851         https://bugs.webkit.org/show_bug.cgi?id=188109
852         <rdar://problem/42664391>
853
854         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
855
856         This patch removes cookie partitioning which reduces the model to just
857         blocked cookies (in third-party contexts) and first-party cookie access.
858
859         Several of the changes are renaming to reflect that there are no more
860         cookie partitions.
861
862         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
863            Removed or renamed functions to reflect that there are no more
864            partitioned cookies.
865         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
866         (WTR::InjectedBundle::didReceiveMessageToPage):
867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
868         (WTR::TestRunner::statisticsUpdateCookieBlocking):
869         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
870         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
871         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
872         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
873         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
874         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
875         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
876         * WebKitTestRunner/InjectedBundle/TestRunner.h:
877         * WebKitTestRunner/TestController.cpp:
878         (WTR::TestController::statisticsUpdateCookieBlocking):
879         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
880         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
881         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
882         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
883         * WebKitTestRunner/TestController.h:
884         * WebKitTestRunner/TestInvocation.cpp:
885         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
886         (WTR::TestInvocation::didSetBlockCookiesForHost):
887         (WTR::TestInvocation::didSetHasHadUserInteraction):
888         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
889         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
890         * WebKitTestRunner/TestInvocation.h:
891         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
892         (WTR::initializeWebViewConfiguration):
893
894 2018-07-31  Alex Christensen  <achristensen@webkit.org>
895
896         Build fix.  Remove unused variable.
897
898         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
899         (TestWebKitAPI::TEST):
900         transform was never used. It was introduced in r205871
901         Apparently I'm the first one to build in a certain configuration that found it.
902
903 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
904
905         server_process.py should print returncode in debug log if the process crashed
906         https://bugs.webkit.org/show_bug.cgi?id=188160
907
908         Reviewed by Konstantin Tokarev.
909
910         * Scripts/webkitpy/port/server_process.py:
911         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
912
913 2018-07-31  Tomas Popela  <tpopela@redhat.com>
914
915         [WTF] String::formatWithArguments() is unused
916         https://bugs.webkit.org/show_bug.cgi?id=187955
917
918         Reviewed by Darin Adler.
919
920         Remove tests for WTF::String::formatWithArguments() as it's unused and
921         we are removing it.
922
923         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
924
925 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
926
927         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
928
929         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
930         other builders.
931
932 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
933
934         [ews-build] Add support for API tests in OpenSource EWS
935         https://bugs.webkit.org/show_bug.cgi?id=188156
936
937         Reviewed by Lucas Forschler.
938
939         * BuildSlaveSupport/ews-build/config.json:
940         * BuildSlaveSupport/ews-build/factories.py:
941         (BuildFactory.__init__): Added triggers parameter.
942         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
943         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
944         (APITestsFactory): Factory for running API tests.
945         * BuildSlaveSupport/ews-build/steps.py:
946         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
947         source of the property.
948
949 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
950
951         [ews-build] loadConfig should ensure that the triggers are valid
952         https://bugs.webkit.org/show_bug.cgi?id=188134
953
954         Reviewed by Lucas Forschler.
955
956         * BuildSlaveSupport/ews-build/loadConfig.py:
957         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
958         (checkValidSchedulers): Ensures that the scheduler is not un-used.
959         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
960
961 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
962
963         Unreviewed, fix typo in test expectations and mark another test as timing out
964
965         * TestWebKitAPI/glib/TestExpectations.json:
966
967 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
968
969         More unreviewed GTK test gardening
970
971         * TestWebKitAPI/glib/TestExpectations.json:
972
973 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
974
975         Be more conservative with compositing layer creation when memory is low
976         https://bugs.webkit.org/show_bug.cgi?id=187866
977         rdar://problem/42366345
978
979         Reviewed by Zalan Bujtas.
980         
981         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
982         compositing layers. We avoid compositing for these situations:
983         1. Layers with 3D transforms which are affine (like translateZ(0)).
984         2. Layers with will-change
985         3. Layers for canvases (other than WebGL/WebGPU)
986         
987         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
988         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
989         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
990         
991         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
992         flakily falling into a different mode, and so that we can impose the conservative
993         mode for testing.
994
995         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
996         (WTR::InjectedBundlePage::prepare):
997
998 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
999
1000         Unreviewed GTK test gardening
1001
1002         * TestWebKitAPI/glib/TestExpectations.json:
1003
1004 2018-07-27  Alex Christensen  <achristensen@webkit.org>
1005
1006         Fix API tests after r234314
1007         https://bugs.webkit.org/show_bug.cgi?id=188077
1008
1009         Make API tests use new delegate method.
1010
1011         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1012         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1013         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1014
1015 2018-07-27  Alex Christensen  <achristensen@webkit.org>
1016
1017         Fix API tests after r234314
1018         https://bugs.webkit.org/show_bug.cgi?id=188077
1019
1020         Make API tests use new delegate method.
1021
1022         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1023         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1024         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1025         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1026         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1027         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1028         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1029         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1030         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1031         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1032         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1033
1034 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1035
1036         [INTL] Remove INTL sub-feature compile flags
1037         https://bugs.webkit.org/show_bug.cgi?id=188081
1038
1039         Reviewed by Michael Catanzaro.
1040
1041         * Scripts/webkitperl/FeatureList.pm:
1042         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1043
1044 2018-07-26  Chris Dumez  <cdumez@apple.com>
1045
1046         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
1047         https://bugs.webkit.org/show_bug.cgi?id=188078
1048         <rdar://problem/42562493>
1049
1050         Reviewed by Geoff Garen.
1051
1052         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
1053         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
1054
1055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1056         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
1057         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
1058         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
1059         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
1060         (TEST):
1061
1062 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
1063
1064         Add Aaron Chu as a committer to contributors.json
1065         https://bugs.webkit.org/show_bug.cgi?id=188066
1066
1067         Unreviwed. Added myself as committer.
1068
1069         * Scripts/webkitpy/common/config/contributors.json:
1070
1071 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
1072
1073         [ews-build] Add build step to run API Tests
1074         https://bugs.webkit.org/show_bug.cgi?id=188079
1075
1076         Reviewed by Lucas Forschler.
1077
1078         * BuildSlaveSupport/ews-build/steps.py:
1079         (TestWithFailureCount): Common class for various tests with failure count.
1080         (TestWithFailureCount.start): Configure Buildbot's logobserver.
1081         (TestWithFailureCount.commandComplete): Updates the failure count.
1082         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
1083         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
1084         (RunAPITests): Build step to run API tests.
1085         (RunAPITests.countFailures): Count the failures by parsing the output.
1086         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1087
1088 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1089
1090         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1091         https://bugs.webkit.org/show_bug.cgi?id=187963
1092
1093         Reviewed by Alex Christensen.
1094
1095         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1096         Add tests for String::split and String::splitAllowingEmptyEntries.
1097
1098         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1099         * WebKitTestRunner/TestController.cpp:
1100         (WTR::updateTestOptionsFromTestHeader):
1101         Update split/splitAllowingEmptyEntries usage.
1102
1103 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1104
1105         Unreviewed, rolling out r234181 and r234189.
1106         https://bugs.webkit.org/show_bug.cgi?id=188075
1107
1108         These are not needed right now (Requested by thorton on
1109         #webkit).
1110
1111         Reverted changesets:
1112
1113         "Enable Web Content Filtering on watchOS"
1114         https://bugs.webkit.org/show_bug.cgi?id=187979
1115         https://trac.webkit.org/changeset/234181
1116
1117         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1118         https://bugs.webkit.org/show_bug.cgi?id=187985
1119         https://trac.webkit.org/changeset/234189
1120
1121 2018-07-04  Darin Adler  <darin@apple.com>
1122
1123         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
1124         https://bugs.webkit.org/show_bug.cgi?id=187333
1125
1126         Reviewed by Sam Weinig.
1127
1128         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
1129         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
1130         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
1131         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
1132         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
1133
1134 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
1135
1136         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
1137         https://bugs.webkit.org/show_bug.cgi?id=188031
1138
1139         Reviewed by Lucas Forschler.
1140
1141         * BuildSlaveSupport/ews-build/steps.py:
1142         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
1143         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
1144         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1145
1146 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
1147
1148         [ews-build] Add build step UploadBuiltProduct
1149         https://bugs.webkit.org/show_bug.cgi?id=188016
1150
1151         Reviewed by Lucas Forschler.
1152
1153         * BuildSlaveSupport/ews-build/steps.py:
1154         (UploadBuiltProduct): Added build step UploadBuiltProduct.
1155         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1156
1157 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
1158
1159         [ews-build] Add build step ArchiveBuiltProduct
1160         https://bugs.webkit.org/show_bug.cgi?id=188014
1161
1162         Reviewed by Lucas Forschler.
1163
1164         * BuildSlaveSupport/ews-build/steps.py:
1165         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
1166         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1167
1168 2018-07-25  Chris Dumez  <cdumez@apple.com>
1169
1170         navigator.userAgent may return outdated value after webView.customUserAgent is set
1171         https://bugs.webkit.org/show_bug.cgi?id=188009
1172         <rdar://problem/42566456>
1173
1174         Reviewed by Alex Christensen.
1175
1176         Add API test coverage.
1177
1178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1179         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
1180         (TEST):
1181
1182 2018-07-25  Charlie Turner  <cturner@igalia.com>
1183
1184         [Flatpak] Pass more environment variables to sandbox
1185         https://bugs.webkit.org/show_bug.cgi?id=188002
1186
1187         Reviewed by Michael Catanzaro.
1188
1189         * flatpak/flatpakutils.py:
1190         (WebkitFlatpak.run_in_sandbox):
1191
1192 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
1193
1194         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
1195         https://bugs.webkit.org/show_bug.cgi?id=187997
1196
1197         Reviewed by Carlos Garcia Campos.
1198
1199         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
1200         the EGL-oriented API that simply serves EGLImageKHR objects instead of
1201         raw buffer resources. This allows us not to wrangle with creating and
1202         managing lifetime of the same EGLImageKHR by ourselves.
1203
1204         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
1205         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
1206         the exportable object. This means that for each frame we're served an
1207         EGLImageKHR object that is passed on to the displayBuffer()
1208         implementation.
1209
1210         HeadlessViewBackend now just manages the pending and committed image
1211         objects. Width and height values used during pixel data retrieval are
1212         gathered from the ViewBackend's size that was specified when
1213         constructed.
1214
1215         WindowViewBackend similarly only manages the committed image object,
1216         not having to create an equivalent EGLImageKHR object from the raw
1217         buffer resource anymore.
1218
1219         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
1220         classes are removed, and destructors for both classes are made virtual.
1221
1222         The WPEBackend-fdo version is bumped in order to have the EGL-specific
1223         export API available.
1224
1225         * flatpak/org.webkit.WPE.yaml:
1226         * wpe/backends/HeadlessViewBackend.cpp:
1227         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1228         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
1229         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1230         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1231         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1232         * wpe/backends/HeadlessViewBackend.h:
1233         * wpe/backends/ViewBackend.cpp:
1234         (WPEToolingBackends::ViewBackend::initialize):
1235         * wpe/backends/ViewBackend.h:
1236         * wpe/backends/WindowViewBackend.cpp:
1237         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1238         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
1239         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1240         * wpe/backends/WindowViewBackend.h:
1241         * wpe/jhbuild.modules:
1242
1243 2018-07-24  Thomas Denney  <tdenney@apple.com>
1244
1245         Remove support for the double type from WHLSL
1246         https://bugs.webkit.org/show_bug.cgi?id=187977
1247
1248         Reviewed by Myles C. Maxfield.
1249
1250         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1251         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
1252         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
1253         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
1254         * WebGPUShadingLanguageRI/Parse.js:
1255         (parseTerm): Removed parsing of double literals.
1256         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1257         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
1258         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
1259         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1260         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
1261         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1262
1263 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1264
1265         Enable Web Content Filtering on watchOS
1266         https://bugs.webkit.org/show_bug.cgi?id=187979
1267         <rdar://problem/42559346>
1268
1269         Reviewed by Wenson Hsieh.
1270
1271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1272
1273 2018-07-24  Daniel Bates  <dabates@apple.com>
1274
1275         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
1276         https://bugs.webkit.org/show_bug.cgi?id=187971
1277
1278         Reviewed by Saam Barati.
1279
1280         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
1281         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
1282         data type.
1283
1284         * TestWebKitAPI/CMakeLists.txt:
1285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1286         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
1287         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
1288         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
1289         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
1290         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
1291         (TestWebKitAPI::TEST):
1292         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
1293         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
1294         (TestWebKitAPI::TEST):
1295
1296 2018-07-24  Thomas Denney  <tdenney@apple.com>
1297         Minor changes to the WHLSL interpreter to support the new compiler
1298         https://bugs.webkit.org/show_bug.cgi?id=187728
1299
1300         Reviewed by Myles C. Maxfield.
1301
1302         This bug contains small changes that are make minor changes to the
1303         behaviour of the existing interpreter (the tests are unaffected and all
1304         still pass).
1305
1306         * WebGPUShadingLanguageRI/EnumType.js:
1307         (EnumType.prototype.get isEnum): Property added to EnumType and Type
1308         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
1309         * WebGPUShadingLanguageRI/Func.js:
1310         (Func.prototype.get isEntryPoint): Add boolean property
1311         * WebGPUShadingLanguageRI/FuncInstantiator.js:
1312         (FuncInstantiator.prototype.get instances): Public accessor for existing
1313         private field
1314         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
1315         that it directly wraps a Func instance (therefore the only interface
1316         change is to the constructor and the addition of the func accessor).
1317         This change allows the de-inlining of functions.
1318         (FunctionLikeBlock):
1319         (FunctionLikeBlock.prototype.get func):
1320         (FunctionLikeBlock.prototype.get returnType):
1321         (FunctionLikeBlock.prototype.get parameters):
1322         (FunctionLikeBlock.prototype.get body):
1323         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
1324         constructor
1325         (Inliner.prototype.visitCallExpression):
1326         (Inliner):
1327         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
1328         to native functions (with additional support in StandardLibrary.js).
1329         This reduces first-time compile-time from around 4s to around 0.1s.
1330         (Intrinsics):
1331         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
1332         comments completes correctly
1333         (Lexer.prototype.next):
1334         (Lexer):
1335         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
1336         property, which is based on the type of the lValue and the semantics of
1337         the language (the @ operator yields an array reference with the thread
1338         scope).
1339         (MakeArrayRefExpression):
1340         (MakeArrayRefExpression.prototype.get type):
1341         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
1342         implementationData to support swizzle operator change
1343         (NativeFunc.prototype.get implementationData):
1344         (NativeFunc.prototype.set implementationData):
1345         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
1346         constructor
1347         (Rewriter.prototype.visitFunctionLikeBlock):
1348         * WebGPUShadingLanguageRI/StandardLibrary.js:
1349         (_generateSwizzle): Deleted.
1350         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
1351         carrying metadata about swizzle operators so that they are implemented
1352         as native functions rather than generated at compile time.
1353         (SwizzleOp):
1354         (SwizzleOp.prototype.get outSize):
1355         (SwizzleOp.prototype.get components):
1356         (SwizzleOp.prototype.get inSize):
1357         (SwizzleOp.prototype.toString):
1358         (SwizzleOp.allSwizzleOperators.):
1359         (SwizzleOp.allSwizzleOperators):
1360         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
1361         (SwizzleOp.prototype.get outSize):
1362         (SwizzleOp.prototype.get components):
1363         (SwizzleOp.prototype.get inSize):
1364         (SwizzleOp.prototype.toString):
1365         (generateSwizzles):
1366         (_generateSwizzle): Deleted.
1367         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
1368         above.
1369         (Type.prototype.get isEnum):
1370
1371 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
1372
1373         Unreviewed, rolling out r234121.
1374
1375         Caused perf test failures.
1376
1377         Reverted changeset:
1378
1379         "We should cache the compiled sandbox profile in a data vault"
1380         https://bugs.webkit.org/show_bug.cgi?id=184991
1381         https://trac.webkit.org/changeset/234121
1382
1383 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
1384
1385         [Flatpak] Add openh264 as needed by WebRTC
1386         https://bugs.webkit.org/show_bug.cgi?id=187956
1387
1388         Reviewed by Philippe Normand.
1389
1390         * flatpak/org.webkit.WebKit.yaml:
1391
1392 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
1393
1394         WebCore::URL::hostIsIPAddress needs a Windows implementation
1395         https://bugs.webkit.org/show_bug.cgi?id=187859
1396
1397         Reviewed by Fujii Hironori.
1398
1399         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1400         Check for a few other ways an IP address could be invalid.
1401
1402 2018-07-24  Charlie Turner  <cturner@igalia.com>
1403
1404         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
1405         https://bugs.webkit.org/show_bug.cgi?id=187951
1406
1407         When running run-webkit-tests --wpe --debug, it was observed that
1408         both self.platform != 'wpe' and self.debug != True. This turned
1409         out to be because of the "args" argument consuming the remainder
1410         of future arguments that came after it. Since the first argument
1411         to load_from_args was the test script to run, it would end up
1412         never processing the other arguments supplied to the wrapper
1413         script.
1414
1415         Tested this by rebuilding GTK in debug mode, running the
1416         minibrowser with various extra options, and running some tests
1417         with various extra options.
1418
1419         Reviewed by Michael Catanzaro.
1420
1421         * flatpak/flatpakutils.py:
1422         (WebkitFlatpak.load_from_args):
1423
1424 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
1425
1426         [Flatpak] Remove now unnecessary 'hacks' for running tests
1427         https://bugs.webkit.org/show_bug.cgi?id=187608
1428
1429         Reviewed by Philippe Normand.
1430
1431         We used to need to not share X11 with the sandbox when running tests
1432         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
1433         sandbox (we mount it on `/run/host/tmp` now).
1434
1435         This has the advantage of making running the MiniBrowser to display test
1436         results working again.
1437
1438         * flatpak/flatpakutils.py:
1439         (WebkitFlatpak.clean_args):
1440         (WebkitFlatpak.run_in_sandbox):
1441         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
1442
1443 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1444
1445         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
1446         https://bugs.webkit.org/show_bug.cgi?id=187581
1447
1448         Reviewed by Daniel Bates.
1449
1450         There are two failures in this test case:
1451         1. proc.poll() doesn't return 0.
1452         2. stderr is not output.
1453
1454         For failure #1, this is expected. the process should not exit at
1455         the time. proc.poll() should return None because the process is
1456         still alive.
1457
1458         This change added a new test to check proc.poll() becomes 0 after
1459         the process successfully exits.
1460
1461         For failure #2, stderr is not flushed even though stdout is
1462         flushed. This change uses '-u' command switch to force stdin,
1463         stdout and stderr to be totally unbuffered.
1464
1465         * Scripts/webkitpy/port/server_process_unittest.py:
1466         (TestServerProcess.test_basic): Added -u command switch. Do not
1467         flush stdout. Removed the special condition for Windows. Add a new
1468         test to check proc.poll() returns 0.
1469         (TestServerProcess.test_process_crashing): Added -u command
1470         switch. Do not flush stdout.
1471
1472 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
1473
1474         WTF::StringView::split should have an allowEmptyEntries flag
1475         https://bugs.webkit.org/show_bug.cgi?id=187864
1476
1477         Reviewed by Konstantin Tokarev.
1478
1479         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
1480
1481 2018-07-23  Ben Richards  <benton_richards@apple.com>
1482
1483         We should cache the compiled sandbox profile in a data vault
1484         https://bugs.webkit.org/show_bug.cgi?id=184991
1485
1486         Reviewed by Ryosuke Niwa.
1487
1488         Added trace points for sandbox initialization
1489
1490         * Tracing/SystemTracePoints.plist:
1491
1492 2018-07-23  Zalan Bujtas  <zalan@apple.com>
1493
1494         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
1495         https://bugs.webkit.org/show_bug.cgi?id=187924
1496         <rdar://problem/41745884>
1497
1498         Reviewed by Simon Fraser.
1499
1500         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
1501
1502         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1503         (createBitmapContextFromWebView):
1504
1505 2018-07-23  Chris Dumez  <cdumez@apple.com>
1506
1507         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
1508         https://bugs.webkit.org/show_bug.cgi?id=187910
1509         <rdar://problem/42356526>
1510
1511         Reviewed by Brent Fulgham.
1512
1513         Add API test coverage.
1514
1515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1516         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1517         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
1518         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
1519         (TEST):
1520         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
1521
1522 2018-07-23  Daniel Bates  <dabates@apple.com>
1523
1524         test-webkitpy should take configuration command line options
1525         https://bugs.webkit.org/show_bug.cgi?id=187872
1526
1527         Reviewed by David Kilzer.
1528
1529         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
1530         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
1531         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
1532
1533         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1534         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
1535         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
1536         * Scripts/webkitpy/test/main.py:
1537         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
1538         the specified configuration is None then we fall back to using the default configuration (as set
1539         by script set-webkit-configuration).
1540         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
1541         with a Debug configuration and a Release configuration, respectively
1542         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
1543         the command line options. It may be None if neither --debug nor --release were passed.
1544
1545 2018-07-23  Commit Queue  <commit-queue@webkit.org>
1546
1547         Unreviewed, rolling out r233030.
1548         https://bugs.webkit.org/show_bug.cgi?id=187904
1549
1550         Broke tarball builds (Requested by mcatanzaro on #webkit).
1551
1552         Reverted changeset:
1553
1554         "run-gtk-tests (glib/common.py) cannot determine build
1555         directory when webKitBranchBuild=true"
1556         https://bugs.webkit.org/show_bug.cgi?id=185643
1557         https://trac.webkit.org/changeset/233030
1558
1559 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
1560
1561         Fix lldb summarizers for HashMaps and HashSets
1562         https://bugs.webkit.org/show_bug.cgi?id=187883
1563
1564         Reviewed by Dan Bates.
1565         
1566         HashMap and HashSet summarizers were broken in various ways.
1567         
1568         The 'type summary add -x' regexp needs to match at the start and end of the string
1569         to avoid finding types nested inside other templates.
1570         
1571         The HashTable synthetic child code incorrectly used the type of the key, rather than
1572         the value when synthesizing children.
1573         
1574         Add HashMap and HashSet summarizers.
1575
1576         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
1577
1578         * lldb/lldbWebKitTester/main.cpp:
1579         (testSummaryProviders):
1580         * lldb/lldb_webkit.py:
1581         (__lldb_init_module):
1582         (__lldb_init_module.lldb_webkit):
1583         (WTFHashMap_SummaryProvider):
1584         (WTFHashSet_SummaryProvider):
1585         (WebCoreColorProvider._to_string_extended):
1586         (WebCoreURLProvider.to_string):
1587         (WTFHashMapProvider):
1588         (WTFHashMapProvider.__init__):
1589         (WTFHashMapProvider.tableSize):
1590         (WTFHashMapProvider.keyCount):
1591         (WTFHashSetProvider):
1592         (WTFHashSetProvider.__init__):
1593         (WTFHashSetProvider.tableSize):
1594         (WTFHashSetProvider.keyCount):
1595         (WTFHashTableProvider.tableSize):
1596         (WTFHashTableProvider):
1597         (WTFHashTableProvider.keyCount):
1598         (WTFHashTableProvider.get_child_at_index):
1599         (WTFHashTableProvider.update):
1600         * lldb/lldb_webkit_unittest.py:
1601         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
1602         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1603         (TestSummaryProviders):
1604         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
1605         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
1606         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
1607
1608 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
1609
1610         Add lldb formatters for WebCore geometry types
1611         https://bugs.webkit.org/show_bug.cgi?id=187884
1612
1613         Reviewed by Daniel Bates.
1614         
1615         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
1616         and LayoutRect.
1617         
1618         Testing is blocked by webkit.org/b/187872.
1619
1620         * lldb/lldbWebKitTester/main.cpp:
1621         (testSummaryProviders):
1622         * lldb/lldb_webkit.py:
1623         (__lldb_init_module.lldb_webkit):
1624         (__lldb_init_module):
1625         (WebCoreLayoutRect_SummaryProvider):
1626         (WebCoreIntSize_SummaryProvider):
1627         (WebCoreIntPoint_SummaryProvider):
1628         (WebCoreFloatSize_SummaryProvider):
1629         (WebCoreFloatPoint_SummaryProvider):
1630         (WebCoreIntRect_SummaryProvider):
1631         (WebCoreFloatRect_SummaryProvider):
1632         (WebCoreLayoutRectProvider):
1633         (WebCoreLayoutRectProvider.__init__):
1634         (WebCoreLayoutRectProvider.get_x):
1635         (WebCoreLayoutRectProvider.get_y):
1636         (WebCoreLayoutRectProvider.get_width):
1637         (WebCoreLayoutRectProvider.get_height):
1638         (WebCoreIntPointProvider):
1639         (WebCoreIntPointProvider.__init__):
1640         (WebCoreIntPointProvider.get_x):
1641         (WebCoreIntPointProvider.get_y):
1642         (WebCoreIntSizeProvider):
1643         (WebCoreIntSizeProvider.__init__):
1644         (WebCoreIntSizeProvider.get_width):
1645         (WebCoreIntSizeProvider.get_height):
1646         (WebCoreIntRectProvider):
1647         (WebCoreIntRectProvider.__init__):
1648         (WebCoreIntRectProvider.get_x):
1649         (WebCoreIntRectProvider.get_y):
1650         (WebCoreIntRectProvider.get_width):
1651         (WebCoreIntRectProvider.get_height):
1652         (WebCoreFloatPointProvider):
1653         (WebCoreFloatPointProvider.__init__):
1654         (WebCoreFloatPointProvider.get_x):
1655         (WebCoreFloatPointProvider.get_y):
1656         (WebCoreFloatSizeProvider):
1657         (WebCoreFloatSizeProvider.__init__):
1658         (WebCoreFloatSizeProvider.get_width):
1659         (WebCoreFloatSizeProvider.get_height):
1660         (WebCoreFloatRectProvider):
1661         (WebCoreFloatRectProvider.__init__):
1662         (WebCoreFloatRectProvider.get_x):
1663         (WebCoreFloatRectProvider.get_y):
1664         (WebCoreFloatRectProvider.get_width):
1665         (WebCoreFloatRectProvider.get_height):
1666
1667 2018-07-20  John Wilander  <wilander@apple.com>
1668
1669         Resource Load Statistics: Enable basic functionality in experimental debug mode
1670         https://bugs.webkit.org/show_bug.cgi?id=187835
1671         <rdar://problem/42408590>
1672
1673         Reviewed by Chris Dumez.
1674
1675         This patch makes the experimental ITP Debug Mode feature work, at least
1676         to a basic level. All of the changes to TestRunner are to support the
1677         layout tests for the functionality.
1678
1679         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1680         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1681         (WTR::InjectedBundle::didReceiveMessageToPage):
1682         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1683         (WTR::TestRunner::setStatisticsDebugMode):
1684         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
1685         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1686         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
1687         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1688         * WebKitTestRunner/TestController.cpp:
1689         (WTR::TestController::setStatisticsDebugMode):
1690         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1691         * WebKitTestRunner/TestController.h:
1692         * WebKitTestRunner/TestInvocation.cpp:
1693         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1694         (WTR::TestInvocation::didSetStatisticsDebugMode):
1695         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
1696         * WebKitTestRunner/TestInvocation.h:
1697
1698 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1699
1700         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1701         https://bugs.webkit.org/show_bug.cgi?id=187846
1702
1703         Reviewed by Simon Fraser.
1704
1705         Fixed the bug that testRunner.execCommand was using the second argument as the value.
1706
1707         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
1708         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
1709
1710         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1712         (WTR::TestRunner::execCommand):
1713         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1714
1715 2018-07-20  Dean Jackson  <dino@apple.com>
1716
1717         Accidentally checked in the wrong version of these files.
1718
1719         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1720         * lldb/lldbWebKitTester/main.cpp:
1721         (testSummaryProviders):
1722         * lldb/lldb_webkit_unittest.py:
1723         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1724         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
1725         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
1726         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
1727         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
1728         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
1729
1730 2018-07-20  Dean Jackson  <dino@apple.com>
1731
1732         Provide an lldb type summary for WebCore::Color
1733         https://bugs.webkit.org/show_bug.cgi?id=187776
1734
1735         Reviewed by Dan Bates.
1736
1737         This time without the tests because we don't want to build
1738         all of WebKit just for python tests.
1739
1740         * lldb/lldb_webkit.py: Add a Color summary provider.
1741         (__lldb_init_module):
1742         (WebCoreColor_SummaryProvider):
1743         (WebCoreColorProvider):
1744         (WebCoreColorProvider.__init__):
1745         (WebCoreColorProvider._is_extended):
1746         (WebCoreColorProvider._is_valid):
1747         (WebCoreColorProvider._is_semantic):
1748         (WebCoreColorProvider._to_string_extended):
1749         (WebCoreColorProvider.to_string):
1750
1751 2018-07-20  Brady Eidson  <beidson@apple.com>
1752
1753         Add WKNavigation/WKNavigationAction related SPI.
1754         https://bugs.webkit.org/show_bug.cgi?id=187826
1755
1756         Reviewed by Chris Dumez.
1757
1758         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1759         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
1760         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1761         (TEST):
1762
1763 2018-07-20  Commit Queue  <commit-queue@webkit.org>
1764
1765         Unreviewed, rolling out r233943, r233988, r234004, and
1766         r234012.
1767         https://bugs.webkit.org/show_bug.cgi?id=187856
1768
1769         webkitpy tests are failing to build lldbWebKitTester
1770         (Requested by ryanhaddad on #webkit).
1771
1772         Reverted changesets:
1773
1774         "Provide an lldb type summary for WebCore::Color"
1775         https://bugs.webkit.org/show_bug.cgi?id=187776
1776         https://trac.webkit.org/changeset/233943
1777
1778         "Provide an lldb type summary for WebCore::Color"
1779         https://bugs.webkit.org/show_bug.cgi?id=187776
1780         https://trac.webkit.org/changeset/233988
1781
1782         "Provide an lldb type summary for WebCore::Color"
1783         https://bugs.webkit.org/show_bug.cgi?id=187776
1784         https://trac.webkit.org/changeset/234004
1785
1786         "Provide an lldb type summary for WebCore::Color"
1787         https://bugs.webkit.org/show_bug.cgi?id=187776
1788         https://trac.webkit.org/changeset/234012
1789
1790 2018-07-20  Philippe Normand  <pnormand@igalia.com>
1791
1792         [GTK][WPE] enable-media-capabilities websetting
1793         https://bugs.webkit.org/show_bug.cgi?id=187847
1794
1795         Reviewed by Carlos Garcia Campos.
1796
1797         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1798         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
1799
1800 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1801
1802         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
1803         https://bugs.webkit.org/show_bug.cgi?id=187798
1804
1805         Reviewed by Michael Catanzaro.
1806
1807         Update test cases to the new API and use a destroy function and vtable in the test case of calling
1808         jsc_context_evaluate_in_object() with a JSCClass.
1809
1810         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1811         (testJSCEvaluateInObject):
1812
1813 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
1814
1815         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
1816         https://bugs.webkit.org/show_bug.cgi?id=187712
1817
1818         Reviewed by Fujii Hironori.
1819
1820         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1821         Mark result of unsigned short test case as platform-specific,
1822         since Windows' behavior is actually *less* surprising here.
1823
1824 2018-07-19  Lucas Forschler  <lforschler@apple.com>
1825
1826         Teach the AWS Lambda to use the [minified]-platforms database
1827         https://bugs.webkit.org/show_bug.cgi?id=187817
1828         
1829         Reviewed by David Kilzer.
1830
1831         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
1832         (lambda_handler): Add support for the platforms.webkit.org database
1833         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
1834         (lambda_handler): Add support for the minified-platforms.webkit.org database
1835
1836 2018-07-19  Dean Jackson  <dino@apple.com>
1837
1838         Provide an lldb type summary for WebCore::Color
1839         https://bugs.webkit.org/show_bug.cgi?id=187776
1840
1841         Dan Bates helped me with this attempted fix. Fingers crossed!
1842
1843         * Scripts/build-lldbwebkittester:
1844
1845 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
1846
1847         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
1848         https://bugs.webkit.org/show_bug.cgi?id=187786
1849
1850         Reviewed by Fujii Hironori.
1851
1852         * Scripts/webkitdirs.pm:
1853         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
1854         for WinCairo builds.
1855
1856 2018-07-19  Dean Jackson  <dino@apple.com>
1857
1858         Provide an lldb type summary for WebCore::Color
1859         https://bugs.webkit.org/show_bug.cgi?id=187776
1860
1861         Another attempted build fix for Debug.
1862
1863         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1864         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1865
1866 2018-07-19  Thomas Denney  <tdenney@apple.com>
1867
1868         [WHLSL] The interpreter doesn't support boolean short-circuiting
1869         https://bugs.webkit.org/show_bug.cgi?id=187779
1870
1871         Reviewed by Alex Christensen.
1872
1873         * WebGPUShadingLanguageRI/Evaluator.js:
1874         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
1875         * WebGPUShadingLanguageRI/Test.js:
1876         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
1877
1878 2018-07-19  Dean Jackson  <dino@apple.com>
1879
1880         Provide an lldb type summary for WebCore::Color
1881         https://bugs.webkit.org/show_bug.cgi?id=187776
1882
1883         Attempted build fix.
1884
1885         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1886
1887 2018-07-19  Brady Eidson  <beidson@apple.com>
1888
1889         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
1890         https://bugs.webkit.org/show_bug.cgi?id=187789
1891
1892         Reviewed by Andy Estes.
1893
1894         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1895         (-[PSONNavigationDelegate init]):
1896         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1897
1898 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
1899
1900         [Flatpak] Let flatpak process handle SIGINT
1901         https://bugs.webkit.org/show_bug.cgi?id=187521
1902
1903         Reviewed by Philippe Normand.
1904
1905         Ensuring that flatpak process ends properly and that the sandbox is teard down.
1906         It also avoids showing usless backtrace to the end user and makes gdb
1907         much more usable.
1908
1909         Also make flatpakutils not verbose by default
1910
1911         * flatpak/flatpakutils.py:
1912         (disable_signals):
1913         (WebkitFlatpak.run_in_sandbox):
1914         (WebkitFlatpak.run_gdb):
1915
1916 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1917
1918         Unreviewed. Fix contributors entry.
1919
1920         * Scripts/webkitpy/common/config/contributors.json:
1921
1922 2018-07-18  Dean Jackson  <dino@apple.com>
1923
1924         Provide an lldb type summary for WebCore::Color
1925         https://bugs.webkit.org/show_bug.cgi?id=187776
1926
1927         Reviewed by Dan Bates.
1928
1929         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1930             to get to WebCore.
1931         * lldb/lldbWebKitTester/main.cpp:
1932         (testSummaryProviders): Create some Color objects for testing.
1933
1934         * lldb/lldb_webkit.py: Add a Color summary provider.
1935         (__lldb_init_module):
1936         (WebCoreColor_SummaryProvider):
1937         (WebCoreColorProvider):
1938         (WebCoreColorProvider.__init__):
1939         (WebCoreColorProvider._is_extended):
1940         (WebCoreColorProvider._is_valid):
1941         (WebCoreColorProvider._is_semantic):
1942         (WebCoreColorProvider._to_string_extended):
1943         (WebCoreColorProvider.to_string):
1944
1945         * lldb/lldb_webkit_unittest.py: Tests.
1946         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1947         (TestSummaryProviders):
1948         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1949         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1950         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1951         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1952
1953 2018-07-18  Truitt Savell  <tsavell@apple.com>
1954
1955         Unreviewed, rolling out r233934.
1956
1957         Revision caused 5 webkitpy failures on Mac and broke webkitpy
1958         testing on iOS simulator
1959
1960         Reverted changeset:
1961
1962         "Provide an lldb type summary for WebCore::Color"
1963         https://bugs.webkit.org/show_bug.cgi?id=187776
1964         https://trac.webkit.org/changeset/233934
1965
1966 2018-07-18  Chris Dumez  <cdumez@apple.com>
1967
1968         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
1969         https://bugs.webkit.org/show_bug.cgi?id=187784
1970         <rdar://problem/42329230>
1971
1972         Reviewed by Brady Eidson.
1973
1974         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
1975         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
1976         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
1977
1978         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
1979         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
1980         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
1981         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
1982         result.
1983
1984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1985         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1986
1987 2018-07-18  Dean Jackson  <dino@apple.com>
1988
1989         Provide an lldb type summary for WebCore::Color
1990         https://bugs.webkit.org/show_bug.cgi?id=187776
1991
1992         Reviewed by Dan Bates.
1993
1994         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1995             to get to WebCore.
1996         * lldb/lldbWebKitTester/main.cpp:
1997         (testSummaryProviders): Create some Color objects for testing.
1998
1999         * lldb/lldb_webkit.py: Add a Color summary provider.
2000         (__lldb_init_module):
2001         (WebCoreColor_SummaryProvider):
2002         (WebCoreColorProvider):
2003         (WebCoreColorProvider.__init__):
2004         (WebCoreColorProvider._is_extended):
2005         (WebCoreColorProvider._is_valid):
2006         (WebCoreColorProvider._is_semantic):
2007         (WebCoreColorProvider._to_string_extended):
2008         (WebCoreColorProvider.to_string):
2009
2010         * lldb/lldb_webkit_unittest.py: Tests.
2011         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
2012         (TestSummaryProviders):
2013         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
2014         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
2015         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
2016         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
2017
2018 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
2019
2020         Adding myself to contributors.json
2021
2022         Unreviewed contributors.json change.
2023
2024         * Scripts/webkitpy/common/config/contributors.json:
2025
2026 2018-07-18  Jer Noble  <jer.noble@apple.com>
2027
2028         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
2029         https://bugs.webkit.org/show_bug.cgi?id=187739
2030         <rdar://problem/42304518>
2031
2032         Reviewed by Tim Horton.
2033
2034         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2035         (TEST):
2036
2037 2018-07-18  Jer Noble  <jer.noble@apple.com>
2038
2039         PiP from Element Fullscreen should match AVKit's behavior
2040         https://bugs.webkit.org/show_bug.cgi?id=187623
2041         <rdar://problem/41212379>
2042
2043         Reviewed by Jon Lee.
2044
2045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2046         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
2047         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
2048         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
2049         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
2050         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
2051         (TestWebKitAPI::TEST):
2052
2053 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
2054
2055         [ews-build] Add build step to run layout-test
2056         https://bugs.webkit.org/show_bug.cgi?id=187674
2057
2058         Reviewed by Lucas Forschler.
2059
2060         * BuildSlaveSupport/ews-build/steps.py:
2061         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
2062         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2063         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
2064
2065 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2066
2067         Add SPI to defer running async script until after document load
2068         https://bugs.webkit.org/show_bug.cgi?id=187748
2069         <rdar://problem/42317378>
2070
2071         Reviewed by Ryosuke Niwa and Tim Horton.
2072
2073         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
2074         executed after the DOMContentLoaded event.
2075
2076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2077         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
2078         (TEST):
2079
2080 2018-07-18  Charlie Turner  <cturner@igalia.com>
2081
2082         [WPE] Update WPEBackend in flatpak
2083         https://bugs.webkit.org/show_bug.cgi?id=187753
2084
2085         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
2086         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
2087         in the version guard,
2088
2089         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
2090
2091         This doesn't work as intended, since the C preprocessor first expands
2092         all macro arguments in the #if expression before evaluating the
2093         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
2094         lead to a syntax error and some head scratching.
2095
2096         A future patch should address the buggy macro check, when it is
2097         decided whether the assume the macro is always defined and bump
2098         the API requirements on WPEBackend, or to move the check into two
2099         conditionals to avoid the expansion problem.
2100
2101         Unreviewed build fix.
2102         
2103         * flatpak/org.webkit.WPE.yaml:
2104
2105 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
2106
2107         Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes
2108         https://bugs.webkit.org/show_bug.cgi?id=187747
2109
2110         Reviewed by Ryosuke Niwa.
2111         
2112         Add textInputController.attributedStringForTyping(), which returns a one-character
2113         attributed string whose attributes are the typing attributes, making it possible to
2114         test -[WebView typingAttributes].
2115         
2116         Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NSDictionary,
2117         so we can't return -typingAttributes directly.
2118
2119         * DumpRenderTree/mac/TextInputControllerMac.m:
2120         (+[TextInputController isSelectorExcludedFromWebScript:]):
2121         (-[TextInputController attributedStringForTyping]):
2122
2123 2018-07-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2124
2125         [GLIB] Add jsc_context_check_syntax() to GLib API
2126         https://bugs.webkit.org/show_bug.cgi?id=187694
2127
2128         Reviewed by Yusuke Suzuki.
2129
2130         Add a new test case.
2131
2132         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2133         (testJSCCheckSyntax):
2134         (main):
2135
2136 2018-07-17  Sihui Liu  <sihui_liu@apple.com>
2137
2138         REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths is a flaky failure
2139         https://bugs.webkit.org/show_bug.cgi?id=187066
2140         <rdar://problem/41609065>
2141
2142         Reviewed by Chris Dumez.
2143
2144         In r232668 we started to do reload if web process crashes by default. As we killed the web 
2145         process explicitly in this test, if web page got reloaded, messages would be sent again, 
2146         and flag set in message handler could keep the test continue to evaluate the expectation 
2147         without waiting for removeDataOfTypes to finish.
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2150         (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDidTerminate:]):
2151         (TEST):
2152
2153 2018-07-17  Chris Dumez  <cdumez@apple.com>
2154
2155         Turn on PSON in WebKitTestRunner
2156         https://bugs.webkit.org/show_bug.cgi?id=186542
2157
2158         Reviewed by Brady Eidson.
2159
2160         Turn on PSON by default in WebKitTestRunner.
2161
2162         * WebKitTestRunner/TestOptions.h:
2163
2164 2018-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2165
2166         Add an SPI hook to allow clients to yield document parsing and script execution
2167         https://bugs.webkit.org/show_bug.cgi?id=187682
2168         <rdar://problem/42207453>
2169
2170         Reviewed by Ryosuke Niwa.
2171
2172         Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
2173         document load, and that doing so doesn't cause deferred `script` to execute in the wrong order (i.e. before
2174         synchronous script, or after "DOMContentLoaded").
2175
2176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2177         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
2178         (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
2179         (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
2180         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2181         (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2182         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2183         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
2184
2185         Add an injected bundle object that knows how to take and release multiple document parser yield tokens.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
2188         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
2189         (+[ParserYieldTokenTestWebView webView]):
2190         (-[ParserYieldTokenTestWebView bundle]):
2191         (-[ParserYieldTokenTestWebView schemeHandler]):
2192         (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
2193         (-[ParserYieldTokenTestWebView didFinishLoad]):
2194         (waitForDelay):
2195         (TEST):
2196         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
2197         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
2198         (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
2199         (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
2200         (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
2201         (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
2202         (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
2203         (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
2204
2205         Add a new test helper class to handle custom schemes via a block-based API.
2206
2207         * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
2208
2209         New test HTML page that contains a deferred script element, a synchronous script element, another deferred
2210         script element, and then some text, images, and links.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
2213
2214 2018-07-17  Truitt Savell  <tsavell@apple.com>
2215
2216         Adding myself to Contributors.json
2217
2218         Unreviewed
2219
2220         * Scripts/webkitpy/common/config/contributors.json:
2221
2222 2018-07-17  Aditya Keerthi  <akeerthi@apple.com>
2223
2224         [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
2225         https://bugs.webkit.org/show_bug.cgi?id=187730
2226
2227         Reviewed by Jer Noble.
2228
2229         This regression was introduced by r233865. PIP can now only be initiated from a
2230         window that is on screen.
2231
2232         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2233         (TestWebKitAPI::TEST):
2234
2235 2018-07-17  John Wilander  <wilander@apple.com>
2236
2237         Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
2238         https://bugs.webkit.org/show_bug.cgi?id=187710
2239         <rdar://problem/42252757>
2240
2241         Reviewed by Chris Dumez.
2242
2243         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2244         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2245         (WTR::InjectedBundle::didReceiveMessageToPage):
2246         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2247         (WTR::TestRunner::setStatisticsLastSeen):
2248         (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
2249         (WTR::TestRunner::setStatisticsPrevalentResource):
2250         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
2251         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2252         (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
2253         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2254         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
2255         (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
2256         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2257         * WebKitTestRunner/TestController.cpp:
2258         (WTR::TestController::setStatisticsLastSeen):
2259         (WTR::TestController::setStatisticsPrevalentResource):
2260         (WTR::TestController::setStatisticsVeryPrevalentResource):
2261         (WTR::TestController::setStatisticsHasHadUserInteraction):
2262         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
2263         * WebKitTestRunner/TestInvocation.cpp:
2264         (WTR::TestInvocation::didSetLastSeen):
2265         (WTR::TestInvocation::didSetPrevalentResource):
2266         (WTR::TestInvocation::didSetVeryPrevalentResource):
2267         (WTR::TestInvocation::didSetHasHadUserInteraction):
2268         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
2269         * WebKitTestRunner/TestInvocation.h:
2270
2271 2018-07-16  Jeremy Jones  <jeremyj@apple.com>
2272
2273         Fix API Test failures introduced by r233865
2274         https://bugs.webkit.org/show_bug.cgi?id=187720
2275
2276         Unreviewed APITest fix after r233865.
2277
2278         Fullscreen can now only be initiated from a window that is on screen.
2279
2280         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2281         (TestWebKitAPI::TEST):
2282         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
2283         (TestWebKitAPI::TEST):
2284
2285 2018-07-11  Dean Jackson  <dino@apple.com>
2286
2287         Allow removal of white backgrounds
2288         https://bugs.webkit.org/show_bug.cgi?id=187574
2289         <rdar://problem/41146792>
2290
2291         Reviewed by Simon Fraser.
2292
2293         Add a new menu item for punching out white backgrounds in MiniBrowser.
2294         In WebKitTestRunner, expose the new setting and hook that up to
2295         drawing a background in the WebView.
2296
2297         * MiniBrowser/mac/AppDelegate.m:
2298         (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
2299
2300         * MiniBrowser/mac/SettingsController.h: Ditto.
2301         * MiniBrowser/mac/SettingsController.m:
2302         (-[SettingsController _populateMenu]):
2303         (-[SettingsController validateMenuItem:]):
2304         (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
2305         (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
2306
2307         * MiniBrowser/mac/WK1BrowserWindowController.m:
2308         (-[WK1BrowserWindowController didChangeSettings]): Set the new preference.
2309
2310         * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
2311         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
2312         (WTR::PlatformWebView::drawsBackground const):
2313         (WTR::PlatformWebView::setDrawsBackground):
2314         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
2315         (WTR::PlatformWebView::drawsBackground const):
2316         (WTR::PlatformWebView::setDrawsBackground):
2317         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView and
2318         set its SPI.
2319         (WTR::PlatformWebView::drawsBackground const):
2320         (WTR::PlatformWebView::setDrawsBackground):
2321         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.
2322         (WTR::PlatformWebView::drawsBackground const):
2323         (WTR::PlatformWebView::setDrawsBackground):
2324
2325         * WebKitTestRunner/TestController.cpp: Reset and copy the new preference.
2326         (WTR::TestController::resetPreferencesToConsistentValues):
2327         (WTR::updateTestOptionsFromTestHeader):
2328         * WebKitTestRunner/TestOptions.h:
2329         (WTR::TestOptions::hasSameInitializationOptions const):
2330
2331         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2332         (WTR::TestController::platformCreateWebView): If the option for punching
2333         out the background was set, tell the WebView to not draw its background.
2334
2335 2018-07-16  Aditya Keerthi  <akeerthi@apple.com>
2336
2337         [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
2338         https://bugs.webkit.org/show_bug.cgi?id=186531
2339
2340         Reviewed by Tim Horton.
2341
2342         Added isShowingDatalistSuggestions testing hook in order to enable testing of the
2343         visibility of the suggestions view.
2344
2345         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2346         (WTR::UIScriptController::isShowingDataListSuggestions const):
2347         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2348         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2349         (WTR::UIScriptController::isShowingDataListSuggestions const):
2350         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2351         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2352         (WTR::UIScriptController::isShowingDataListSuggestions const):
2353
2354 2018-07-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2355
2356         Add --target-path option to dump-class-layout
2357         https://bugs.webkit.org/show_bug.cgi?id=187687
2358
2359         Reviewed by Simon Fraser.
2360
2361         We add an escape hatch to dump-class-layout for specifying target path directly.
2362         This `--target-path` allows us to use dump-class-layout in the other ports
2363         like JSCOnly.
2364
2365         We can dump class layout if we build the target with clang by using the following command.
2366
2367         Tools/Scripts/dump-class-layout \
2368             --architecture=x86_64 \
2369             --target-path=path/to/libJavaScriptCore.so \
2370             JavaScriptCore \
2371             ScopeNode
2372
2373         * Scripts/dump-class-layout:
2374         (main):
2375
2376 2018-07-16  Sihui Liu  <sihui_liu@apple.com>
2377
2378         IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
2379         https://bugs.webkit.org/show_bug.cgi?id=187631
2380         <rdar://problem/42164227>
2381
2382         Reviewed by Brady Eidson.
2383
2384         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2385         (TEST):
2386
2387 2018-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2388
2389         [GLIB] Add API to evaluate code using a given object to store global symbols
2390         https://bugs.webkit.org/show_bug.cgi?id=187639
2391
2392         Reviewed by Michael Catanzaro.
2393
2394         Add a new test case.
2395
2396         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2397         (testJSCEvaluateInObject):
2398         (testJSCExceptions):
2399         (main):
2400
2401 2018-07-15  Zan Dobersek  <zdobersek@igalia.com>
2402
2403         [webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories
2404         https://bugs.webkit.org/show_bug.cgi?id=187353
2405
2406         Reviewed by Youenn Fablet.
2407
2408         When using run-web-platform-tests, allow specifying custom WPT metadata
2409         directory. This will avoid generating such metadata-filled directory
2410         from the port-specific JSON expectations file, and instead will search
2411         for the metadata files and the include manifest inside the specified
2412         directory. The MANIFEST.json file will also be generated under there.
2413
2414         Rationale for this change is prototyping using custom metadata
2415         directories and avoiding generating all this content from a JSON file.
2416         Using this by default in the future would avoid sporradic changes in how
2417         WPT handles metadata .ini files and releases us from the obligation of
2418         adjusting the generator for every such change. This would also allow
2419         managing this metadata content in a separate repository, avoiding
2420         polluting the main webkit.org repository with thousands of .ini files.
2421
2422         If this turns out to be the preferable way of managing the metadata
2423         content, the JSON files under WebPlatformTests/ and the related code in
2424         wpt_runner.py would be removed.
2425
2426         * Scripts/webkitpy/w3c/wpt_runner.py:
2427         (parse_args):
2428         (WPTRunner._wpt_run_paths):
2429         (WPTRunner.run):
2430         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
2431         (WPTRunnerTest.test_run_with_specified_options):
2432
2433 2018-07-13  Ross Kirsling  <ross.kirsling@sony.com>
2434
2435         [WinCairo] run-api-tests is timing out for almost all test cases
2436         https://bugs.webkit.org/show_bug.cgi?id=187547
2437
2438         Reviewed by Fujii Hironori.
2439
2440         * Scripts/webkitpy/port/server_process.py:
2441         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2442         Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
2443
2444         * Scripts/webkitpy/port/server_process_unittest.py:
2445         (TestServerProcess.test_read_after_process_exits):
2446         Add test case.
2447
2448 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
2449
2450         Add TestExpectations and baselines for iOS 12
2451         https://bugs.webkit.org/show_bug.cgi?id=187628
2452
2453         Reviewed by Alexey Proskuryakov.
2454
2455         * Scripts/webkitpy/port/ios.py:
2456         (IOSPort): Bump current version to 12.
2457
2458 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
2459
2460         Add TestExpectations and baselines for Mojave.
2461         https://bugs.webkit.org/show_bug.cgi?id=187620
2462
2463         Reviewed by Alexey Proskuryakov.
2464
2465         * Scripts/webkitpy/port/mac.py:
2466         (MacPort): Bump current version to 10.14.
2467
2468 2018-07-13  Timothy Hatcher  <timothy@apple.com>
2469
2470         Add _drawsBackground to WKWebViewConfiguration.
2471         https://bugs.webkit.org/show_bug.cgi?id=187665
2472         rdar://problem/42182268
2473
2474         Reviewed by Tim Horton.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2477         (TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
2478
2479 2018-07-13  Chris Dumez  <cdumez@apple.com>
2480
2481         Add a FrameLoaderClient willInjectUserScriptForFrame callback
2482         https://bugs.webkit.org/show_bug.cgi?id=187565
2483         <rdar://problem/42095701>
2484
2485         Unreviewed WKTR fix after r233782.
2486
2487         * WebKitTestRunner/TestInvocation.cpp:
2488         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2489
2490 2018-07-13  Chris Dumez  <cdumez@apple.com>
2491
2492         Reduce size of WebCore::URL
2493         https://bugs.webkit.org/show_bug.cgi?id=186820
2494         <rdar://problem/42087508>
2495
2496         Unreviewed, re-generates Service worker registrations database used by API tests after r233789.
2497
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3: Removed.
2500         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-shm: Removed.
2501         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-wal.
2502         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2503         (TEST):
2504
2505 2018-07-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2506
2507         Make it easier to hit the significant rendered text layout milestone on pages with main article elements
2508         https://bugs.webkit.org/show_bug.cgi?id=187578
2509         <rdar://problem/42104637>
2510
2511         Reviewed by Ryosuke Niwa.
2512
2513         Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
2514         page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
2515         articles).
2516
2517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2518         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
2519         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
2520         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2521         (TEST):
2522
2523 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2524
2525         Change my status to be a WebKit reviewer.
2526
2527         Unreviewed status update.
2528
2529         * Scripts/webkitpy/common/config/contributors.json:
2530
2531 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2532
2533         Unreviewed contributors.json update
2534
2535         Just run "validate-committer-lists -c" to canonicalize the style.
2536
2537         * Scripts/webkitpy/common/config/contributors.json:
2538
2539 2018-07-12  Alex Christensen  <achristensen@webkit.org>
2540
2541         Reduce size of WebCore::URL
2542         https://bugs.webkit.org/show_bug.cgi?id=186820
2543
2544         Reviewed by Yusuke Suzuki and Youenn Fablet.
2545
2546         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2547         (TestWebKitAPI::TEST_F):
2548
2549 2018-07-12  Brady Eidson  <beidson@apple.com>
2550
2551         Make process-swap-on-navigation an experimental feature.
2552         <rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
2553
2554         Reviewed by Chris Dumez.
2555
2556         Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
2557
2558         * WebKitTestRunner/TestController.cpp:
2559         (WTR::TestController::createWebViewWithOptions):
2560         (WTR::TestController::resetPreferencesToConsistentValues):
2561
2562         * WebKitTestRunner/TestOptions.h:
2563         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
2564
2565 2018-07-12  Youenn Fablet  <youenn@apple.com>
2566
2567         Add a FrameLoaderClient willInjectUserScriptForFrame callback
2568         https://bugs.webkit.org/show_bug.cgi?id=187565
2569
2570         Reviewed by Alex Christensen.
2571
2572         Added new test runner API to check for willInjectUserScriptForFrame callback.
2573
2574         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2575         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2576         (WTR::InjectedBundle::resetUserScriptInjectedCount):
2577         (WTR::InjectedBundle::increaseUserScriptInjectedCount):
2578         (WTR::InjectedBundle::userScriptInjectedCount const):
2579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2580         (WTR::InjectedBundlePage::InjectedBundlePage):
2581         (WTR::InjectedBundlePage::resetAfterTest):
2582         (WTR::InjectedBundlePage::willInjectUserScriptForFrame):
2583         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2585         (WTR::TestRunner::userScriptInjectedCount const):
2586         (WTR::TestRunner::injectUserScript):
2587         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2588         * WebKitTestRunner/TestController.cpp:
2589         (WTR::TestController::injectUserScript):
2590         * WebKitTestRunner/TestController.h:
2591         * WebKitTestRunner/TestInvocation.cpp:
2592         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2593         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2594         (WTR::TestController::injectUserScript):
2595
2596 2018-07-12  Sihui Liu  <sihui_liu@apple.com>
2597
2598         IndexedDB: database file of subframe cannot be removed
2599         https://bugs.webkit.org/show_bug.cgi?id=187564
2600
2601         Reviewed by Youenn Fablet.
2602
2603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2604         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2605         (TEST):
2606
2607 2018-07-12  Timothy Hatcher  <timothy@apple.com>
2608
2609         Make WebKit.LinkColorWithSystemAppearance work across system versions.
2610         https://bugs.webkit.org/show_bug.cgi?id=187573
2611
2612         Reviewed by Wenson Hsieh.
2613
2614         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2615         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.
2616
2617 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2618
2619         [WPE] Pass the backend library name as command line parameter to the web process
2620         https://bugs.webkit.org/show_bug.cgi?id=186841
2621
2622         Reviewed by Žan Doberšek.
2623
2624         * MiniBrowser/wpe/main.cpp:
2625         (main): Stop using WPE_BACKEND_LIBRARY env var.
2626         * Scripts/run-wpe-tests:
2627         (WPETestRunner.__init__): Ditto.
2628         * Scripts/webkitpy/port/wpe.py:
2629         (WPEPort.setup_environ_for_server): Ditto.
2630         * wpe/backends/ViewBackend.cpp:
2631         (WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.
2632         * wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
2633
2634 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2635
2636         [GLIB] Add API to allow creating variadic functions
2637         https://bugs.webkit.org/show_bug.cgi?id=187517
2638
2639         Reviewed by Michael Catanzaro.
2640
2641         Add test cases.
2642
2643         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2644         (testJSCFunction):
2645         (fooCreateWithFooV):
2646         (multiplyFooV):
2647
2648 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2649
2650         [GLIB] Add jsc_context_get_global_object() to GLib API
2651         https://bugs.webkit.org/show_bug.cgi?id=187515
2652
2653         Reviewed by Michael Catanzaro.
2654
2655         Add test cases.
2656
2657         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2658         (testJSCGlobalObject):
2659         (main):
2660
2661 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2662
2663         [GLIB] Handle G_TYPE_STRV in glib API
2664         https://bugs.webkit.org/show_bug.cgi?id=187512
2665
2666         Reviewed by Michael Catanzaro.
2667
2668         Add test cases.
2669
2670         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2671         (testJSCTypes):
2672         (joinFunction):
2673         (testJSCFunction):
2674
2675 2018-07-11  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
2678         https://bugs.webkit.org/show_bug.cgi?id=187549
2679
2680         Reviewed by Alexey Proskuryakov.
2681
2682         * BuildSlaveSupport/ews-build/factories.py:
2683         (JSCTestsFactory.__init__):
2684         * BuildSlaveSupport/ews-build/steps.py:
2685         (CompileJSCOnlyToT): Build ToT without patch.
2686         (CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
2687         (RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
2688         (ReRunJavaScriptCoreTests): Re-runs JSC tests.
2689         (ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
2690         (ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
2691         (RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
2692         (RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
2693         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2694
2695 2018-07-11  Commit Queue  <commit-queue@webkit.org>
2696
2697         Unreviewed, rolling out r233742.
2698         https://bugs.webkit.org/show_bug.cgi?id=187577
2699
2700         Binary incompatible change with respect to Service Worker
2701         registration map (Requested by dydz on #webkit).
2702
2703         Reverted changeset:
2704
2705         "Reduce size of WebCore::URL"
2706         https://bugs.webkit.org/show_bug.cgi?id=186820
2707         https://trac.webkit.org/changeset/233742
2708
2709 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2710
2711         REGRESSION (231276): Attempting to copy an image fails
2712         https://bugs.webkit.org/show_bug.cgi?id=187212
2713
2714         Reviewed by Ryosuke Niwa.
2715         <rdar://problem/41540074>
2716
2717         Augmented test to include a URL where the lastPathComponent looks similar to a
2718         file URL.
2719
2720         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2721         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2722         (TestWebKitAPI::TEST):
2723
2724 2018-07-11  Alex Christensen  <achristensen@webkit.org>
2725
2726         Add SPI for immediate injection of user scripts
2727         https://bugs.webkit.org/show_bug.cgi?id=173342
2728         <rdar://problem/29202285>
2729
2730         Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
2731
2732         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2733         (waitForMessage):
2734         (TEST):
2735
2736 2018-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2737
2738         Move WHLSL spec work to the W3C GPUWeb GitHub repository
2739
2740         See https://github.com/gpuweb/WHLSL
2741
2742         * WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
2743         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
2744         * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
2745         * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
2746         * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
2747
2748 2018-07-11  Dean Jackson  <dino@apple.com>
2749
2750         Force WKTR to use the light appearance
2751         https://bugs.webkit.org/show_bug.cgi?id=187572
2752         <rdar://problem/42097805>
2753
2754         Reviewed by Simon Fraser.
2755
2756         Set the NSAppearance on the NSWindow to light mode.
2757
2758         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2759         (WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
2760
2761 2018-07-11  Alex Christensen  <achristensen@webkit.org>
2762
2763         Reduce size of WebCore::URL
2764         https://bugs.webkit.org/show_bug.cgi?id=186820
2765
2766         Reviewed by Yusuke Suzuki.
2767
2768         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2769         (TestWebKitAPI::TEST_F):
2770
2771 2018-07-11  Youenn Fablet  <youenn@apple.com>
2772
2773         Fix remaining Cross-Origin-Resource-Policy failures, if any
2774         https://bugs.webkit.org/show_bug.cgi?id=186761
2775         <rdar://problem/41209829>
2776
2777         Reviewed by Alex Christensen.
2778
2779         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
2780         (TestWebKitAPI::TEST):
2781
2782  2018-07-11  Aakash Jain  <aakash_jain@apple.com>
2783  
2784         [ews-build] EWS should unapply the patch and build ToT when patch fails to build
2785         https://bugs.webkit.org/show_bug.cgi?id=187358
2786  
2787         Reviewed by Alexey Proskuryakov.
2788  
2789         * BuildSlaveSupport/ews-build/factories.py:
2790         (BuildFactory.__init__):
2791         * BuildSlaveSupport/ews-build/steps.py:
2792         (CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
2793         (CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
2794         (CompileWebKitToT): Build ToT without patch.
2795         (CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
2796         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
2797
2798 2018-07-11  Robin Morisset  <rmorisset@apple.com>
2799
2800         [WSL] WIP, more of the spec
2801         https://bugs.webkit.org/show_bug.cgi?id=186310
2802
2803         Rubberstamped by Filip Pizlo.
2804
2805         Fixed a few issues with the formal rules (such as adding the restrictions on pointers for compilation to SpirV),
2806         and started writing some of the english in the spec.
2807
2808         * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
2809         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
2810
2811 2018-07-10  Aakash Jain  <aakash_jain@apple.com>
2812
2813         [ews-build] Add build step to UnApply patch
2814         https://bugs.webkit.org/show_bug.cgi?id=187357
2815
2816         Reviewed by Alexey Proskuryakov.
2817
2818         * BuildSlaveSupport/ews-build/steps.py:
2819         (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
2820         (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
2821         properties will be set by build-steps for build and test.
2822         (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
2823
2824 2018-07-10  Dewei Zhu  <dewei_zhu@apple.com>
2825
2826         Update ARES-6.patch file accordingly for r233631.
2827         https://bugs.webkit.org/show_bug.cgi?id=187534
2828
2829         Reviewed by Saam Barati.
2830
2831         Update ARES-6.patch file acoordingly after ARES-6 plan file change to
2832         avoid warning while applying the patch.
2833
2834         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2835
2836 2018-07-10  Tim Horton  <timothy_horton@apple.com>
2837
2838         doAfterNextPresentationUpdate should not be called while content is hidden due to animated resize
2839         https://bugs.webkit.org/show_bug.cgi?id=187500
2840         <rdar://problem/41294139>
2841
2842         Reviewed by Simon Fraser.
2843
2844         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2845         (-[AnimatedResizeWebView _endAnimatedResize]):
2846         Set didEndAnimatedResize before calling super, because it makes the
2847         new test easier and doesn't affect any of the existing ones.
2848
2849         (AnimatedResizeBlocksViewportFitChanges):
2850         This doAfterNextPresentationUpdate is always called during animated resize,
2851         and then synchronously waited for, so it /must/ use
2852         _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting.
2853         
2854         (AnimatedResizeBlocksDoAfterNextPresentationUpdate):
2855         Add a test ensuring that doAfterNextPresentationUpdate is deferred
2856         until endAnimatedResize is called.
2857
2858         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2859         (-[WKWebView _test_waitForDidFinishNavigation]):
2860         _test_waitForDidFinishNavigation is sometimes called during animated resize,
2861         and synchronously waits for a doAfterNextPresentationUpdate, so
2862         it cannot wait for the animated resize to complete.
2863
2864 2018-07-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2865
2866         [GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
2867         https://bugs.webkit.org/show_bug.cgi?id=184441
2868
2869         Reviewed by Michael Catanzaro.
2870
2871         All executables of TestWebKitAPI need the forwarding headers of
2872         WebCore and PAL because config.h includes
2873         <WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
2874
2875         The forwarding headers of WebCore are generated by
2876         generate-forwarding-headers.pl in GTK and WPE ports. The
2877         forwarding headers of PAL are generated by
2878         WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
2879
2880         * TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
2881         ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
2882         ${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
2883         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2884
2885 2018-07-10  Stephan Szabo  <stephan.szabo@sony.com>
2886
2887         [WinCairo] Support display of webinspector ui on non-legacy minibrowser
2888         https://bugs.webkit.org/show_bug.cgi?id=187415
2889
2890         Reviewed by Brian Burg.
2891
2892         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2893         (WebKitBrowserWindow::WebKitBrowserWindow):
2894
2895 2018-07-10  John Wilander  <wilander@apple.com>
2896
2897         Resource Load Statistics: Make testRunner.statisticsResetToConsistentState() take a completion handler
2898         https://bugs.webkit.org/show_bug.cgi?id=187499
2899         <rdar://problem/41999431>
2900
2901         Reviewed by Chris Dumez.
2902
2903         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2904         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2905         (WTR::InjectedBundle::didReceiveMessageToPage):
2906         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2907         (WTR::TestRunner::statisticsResetToConsistentState):
2908         (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
2909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2910         * WebKitTestRunner/TestController.cpp:
2911         (WTR::TestController::statisticsResetToConsistentState):
2912         * WebKitTestRunner/TestInvocation.cpp:
2913         (WTR::TestInvocation::didResetStatisticsToConsistentState):
2914         * WebKitTestRunner/TestInvocation.h:
2915
2916 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2917
2918         Disable cross-origin-window-policy by default
2919         https://bugs.webkit.org/show_bug.cgi?id=187509
2920
2921         Reviewed by Chris Dumez.
2922
2923         Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
2924
2925         * WebKitTestRunner/TestController.cpp:
2926         (WTR::TestController::resetPreferencesToConsistentValues):
2927
2928 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2929
2930         [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
2931         https://bugs.webkit.org/show_bug.cgi?id=187470
2932
2933         Reviewed by Philippe Normand.
2934
2935         Never force building, the user is responsible to make that decision and the workflow is
2936         now based on external scripts so it doesn't make sense anymore. Doing that leads
2937         to ignoring the options the user passed in.
2938
2939         * flatpak/flatpakutils.py:
2940         (WebkitFlatpak.setup_dev_env):
2941
2942 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2943
2944         [Flatpak] Fix running wpt tests inside flatpak
2945         https://bugs.webkit.org/show_bug.cgi?id=187490
2946
2947         Reviewed by Philippe Normand.
2948
2949         Still not *all* passing but a big majority do.
2950
2951         * Scripts/webkitpy/w3c/wpt_runner.py:
2952         (main): Generate the /etc/hosts and mount it in flatpak as required.
2953         (WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout WPT code before generating /etc/hosts.
2954         (WPTRunner._prepare_wpt_checkout): Deleted.
2955         * flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
2956         added a way to pass extra env to flatpak itself (so we can mount /etc/hosts).
2957         Stopped passing `--device=all` as it is not required since r233638 (Bug 187400).
2958         * flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as required by wpt.
2959
2960 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2961
2962         [Flatpak] Use logging to print debug information
2963         https://bugs.webkit.org/show_bug.cgi?id=187496
2964
2965         Reviewed by Philippe Normand.
2966
2967         * flatpak/flatpakutils.py:
2968         (WebkitFlatpak.load_from_args):
2969         (WebkitFlatpak.clean_args):
2970         (WebkitFlatpak.run_in_sandbox):
2971
2972 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2973
2974         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2975         https://bugs.webkit.org/show_bug.cgi?id=187425
2976         rdar://problem/39948240
2977         rdar://problem/41796865
2978
2979         Reviewed by Tim Horton.
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2982         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Use new color value.
2983
2984 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2985
2986         Fix dump-class-layout to show bit padding, and fix issues with padding offsets
2987         https://bugs.webkit.org/show_bug.cgi?id=187442
2988
2989         Reviewed by Daniel Bates.
2990         
2991         Synthetic padding members were shown with the wrong offset because they used the
2992         absolute offset rather than the class-relative offset. This didn't change the padding
2993         math, but made the output confusing.
2994         
2995         Also add support for showing empty bits in bitfields, and fix computation of padding
2996         after bitfields. Empty bits are computed by inserting a bit padding member after
2997         a bitfield that is not followed by another bitfield (making the assumption that bit
2998         padding will fill to the next byte boundary).
2999         
3000         The computation of padding after bitfields was also wrong, since lldb's member_type.GetByteSize()
3001         just reports the size of the type without the bitfield modifier (e.g. for "unsigned : 2" it returned 4).
3002         Fix by setting the byte size for bitfield fields to the number of bits rounded up to the next byte;
3003         this allows byte padding following the bitfield to be computed correctly.
3004         
3005         Add or modify test to cover these issues.
3006
3007         * lldb/dump_class_layout_unittest.py:
3008         (serial_test_ClassWithPaddedBitfields):
3009         (serial_test_MemberHasBitfieldPadding):
3010         (serial_test_InheritsFromClassWithPaddedBitfields):
3011         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
3012         (avoidClassDeadStripping):
3013         * lldb/lldb_dump_class_layout.py:
3014         (ClassLayoutBase):
3015         (ClassLayoutBase._to_string_recursive):
3016         (ClassLayout._parse):
3017         (ClassLayout._compute_padding_recursive):
3018
3019 2018-07-09  Youenn Fablet  <youenn@apple.com>
3020
3021         StringView operator==(char*) should check the length of the string
3022         https://bugs.webkit.org/show_bug.cgi?id=187422
3023
3024         Reviewed by Chris Dumez.
3025
3026         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3027         (TestWebKitAPI::equal2):
3028         (TestWebKitAPI::TEST):
3029
3030 2018-07-09  Ross Kirsling  <rkirsling@gmail.com>
3031
3032         [WinCairo] httpd service install needs to precede server start
3033         https://bugs.webkit.org/show_bug.cgi?id=187283
3034
3035         Reviewed by Daniel Bates.
3036
3037         * Scripts/webkitpy/port/base.py:
3038         (Port.check_build):
3039         Remove unused parameter `needs_http`.
3040         
3041         (Port.check_sys_deps):
3042         (Port.start_http_server):
3043         Move `check_httpd` call.
3044
3045         * Scripts/webkitpy/port/win.py:
3046         (WinPort.check_httpd): Added.
3047         (WinCairoPort.check_httpd): Deleted.
3048         Move `httpd -k install` logic to common Windows location.
3049
3050         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3051         (Manager._set_up_run):
3052         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3053         * Scripts/webkitpy/port/gtk.py:
3054         (GtkPort.check_sys_deps):
3055         * Scripts/webkitpy/port/ios_simulator.py:
3056         (IOSSimulatorPort.check_sys_deps):
3057         * Scripts/webkitpy/port/mock_drt.py:
3058         (MockDRTPort.check_build):
3059         (MockDRTPort.check_sys_deps):
3060         * Scripts/webkitpy/port/port_testcase.py:
3061         (PortTestCase.integration_test_check_sys_deps):
3062         (test_check_build):
3063         * Scripts/webkitpy/port/test.py:
3064         * Scripts/webkitpy/port/wpe.py:
3065         (WPEPort.check_sys_deps):
3066         * Scripts/webkitpy/tool/commands/perfalizer.py:
3067         (PerfalizerTask.run):
3068         Remove `needs_http` arguments.
3069
3070 2018-07-09  Philippe Normand  <pnormand@igalia.com>
3071
3072         [Flatpak] Unreviewed, switch to https for the gst-libav tarball.
3073         
3074         * flatpak/org.webkit.WebKit.yaml:
3075
3076 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
3077
3078         [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
3079         https://bugs.webkit.org/show_bug.cgi?id=187384
3080
3081         Reviewed by Philippe Normand.
3082
3083         And make it usable inside the sandbox even when
3084         perl is launched "tainted" (as the PERL5LIB won't
3085         work otherwise).
3086
3087         * flatpak/flatpakutils.py:
3088         (WebkitFlatpak.run_in_sandbox):
3089         * flatpak/org.webkit.WebKit.yaml:
3090
3091 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
3092
3093         [WPE][GTK] Mount /dev/shm on /run/shm in sandbox
3094         https://bugs.webkit.org/show_bug.cgi?id=187400
3095
3096         Reviewed by Philippe Normand.
3097
3098         This is where it is expected to be when it is a symlink,
3099         without mounting it the websocket python server can't work
3100         inside the sandbox.
3101
3102         * flatpak/flatpakutils.py:
3103         (WebkitFlatpak.run_in_sandbox):
3104
3105 2018-07-08  Filip Pizlo  <fpizlo@apple.com>
3106
3107         run-benchmark should run ARES-6 1.0.1
3108         https://bugs.webkit.org/show_bug.cgi?id=187452
3109
3110         Reviewed by Sam Weinig.
3111         
3112         We forgot to update this when we released 1.0.1!
3113
3114         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3115
3116 2018-07-07  Youenn Fablet  <youenn@apple.com>
3117
3118         WPT importer should create dummy HTML files for *.window.js script files
3119         https://bugs.webkit.org/show_bug.cgi?id=187426
3120
3121         Reviewed by Ryosuke Niwa.
3122
3123         Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
3124         Do the same strategy as done for worker.js/any.js files.
3125
3126         * Scripts/webkitpy/w3c/test_importer.py:
3127         (TestImporter.write_html_files_for_templated_js_tests):
3128
3129 2018-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3130
3131         Introduce a layout milestone to track when the document contains a large number of rendered characters
3132         https://bugs.webkit.org/show_bug.cgi?id=187412
3133         <rdar://problem/41744338>
3134
3135         Reviewed by Ryosuke Niwa.
3136
3137         Add a new API test to check that we observe the new rendering milestone in an article-like document.
3138
3139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3140         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html: Added.
3141         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
3142         (TEST):
3143
3144 2018-06-30  Simon Fraser  <simon.fraser@apple.com>
3145
3146         dump-class-layout reports wrong padding in many cases
3147         https://bugs.webkit.org/show_bug.cgi?id=185801
3148
3149         Reviewed by Dan Bates.
3150         
3151         Enhance dump-class-layout, fixing bugs and adding unit tests. This also includes
3152         the patch from bug 187141.
3153         
3154         Move the code that uses lldb to fetch the class layout to its own module,
3155         lldb_dump_class_layout.py, so it can be unit tested. Change this code
3156         to build up a data structure for the class. This is necessary since correct
3157         padding computation is easier with second traversal over the data structure.
3158         
3159         Try to deal with the empty base class optimization, which is necessary to report
3160         correct padding in classes using std::unique_ptr, and correctly handle virtual base classes.
3161         
3162         The ClassLayoutBase class knows how to test for equality and generate a string
3163         or string list representation of itself. The derived ClassLayout class knows
3164         how to build up the class layout using the lldb Python bindings.
3165         
3166         Finally we wrap the lldb debugger instance in LLDBDebuggerInstance so that we don't
3167         have to make a new one for each unit test. The tests have to run serially.
3168         
3169         Add to lldbWebKitTester a .cpp file that contains a set of C++ classes to unit-test
3170         dump-class-layout.
3171
3172         * Scripts/dump-class-layout:
3173         (main):
3174         * lldb/dump_class_layout_unittest.py:
3175         (destroy_cached_debug_session):
3176         (TestDumpClassLayout):
3177         (TestDumpClassLayout.setUpClass):
3178         (TestDumpClassLayout.setUp):
3179         (TestDumpClassLayout.serial_test_BasicClassLayout):
3180         (serial_test_PaddingBetweenClassMembers):
3181         (serial_test_BoolPaddingClass):
3182         (serial_test_ClassWithEmptyClassMembers):
3183         (serial_test_SimpleVirtualClass):
3184         (serial_test_SimpleVirtualClassWithNonVirtualBase):
3185         (serial_test_InterleavedVirtualNonVirtual):
3186         (serial_test_ClassWithTwoVirtualBaseClasses):
3187         (serial_test_ClassWithClassMembers):
3188         (serial_test_ClassWithBitfields):
3189         (serial_test_ClassWithUniquePtrs):
3190         (serial_test_ClassWithOptionals):
3191         (TestDumpClassLayout.test_BasicClassLayout): Deleted.
3192         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
3193         (EmptyClass::doStuff):
3194         (VirtualBaseClass::~VirtualBaseClass):
3195         (VirtualBaseClass2::~VirtualBaseClass2):
3196         (SimpleVirtualClass::~SimpleVirtualClass):
3197         (SimpleVirtualClass::doStuff):
3198         (SimpleVirtualClassWithNonVirtualBase::~SimpleVirtualClassWithNonVirtualBase):
3199         (SimpleVirtualClassWithNonVirtualBase::doStuff):
3200         (avoidClassDeadStripping):
3201         * lldb/lldb_dump_class_layout.py:
3202         (ansi_colors):
3203         (ClassLayoutBase):
3204         (ClassLayoutBase.__init__):
3205         (ClassLayoutBase.__ne__):
3206         (ClassLayoutBase.__eq__):
3207         (ClassLayoutBase._to_string_recursive):
3208         (ClassLayoutBase.as_string_list):
3209         (ClassLayoutBase.as_string):
3210         (ClassLayoutBase.dump):
3211         (ClassLayoutExpected):
3212         (ClassLayoutExpected.__init__):
3213         (ClassLayout):
3214         (ClassLayout.__init__):
3215         (ClassLayout._has_polymorphic_base_class):
3216         (ClassLayout._parse):
3217         (ClassLayout._probably_has_empty_base_class_optimization):
3218         (ClassLayout._compute_padding_recursive):
3219         (ClassLayout._compute_padding):
3220         (LLDBDebuggerInstance):
3221         (LLDBDebuggerInstance.__init__):
3222         (LLDBDebuggerInstance.__del__):
3223         (LLDBDebuggerInstance._get_first_file_architecture):
3224         (LLDBDebuggerInstance.layout_for_classname):
3225         (ClassLayoutDumper): Deleted.
3226         (ClassLayoutDumper.__init__): Deleted.
3227         (ClassLayoutDumper._get_first_file_architecture): Deleted.
3228         (ClassLayoutDumper.verify_type): Deleted.
3229         (ClassLayoutDumper.verify_type_recursive): Deleted.
3230         (ClassLayoutDumper._class_layout_as_string): Deleted.
3231         (ClassLayoutDumper.dump_to_string): Deleted.
3232         (ClassLayoutDumper.dump): Deleted.
3233
3234 2018-07-06  Christopher Reid  <chris.reid@sony.com>
3235
3236         [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs
3237         https://bugs.webkit.org/show_bug.cgi?id=187167
3238
3239         Reviewed by Alex Christensen.
3240
3241         A null byte was written past the end of the buffer causing the crash.
3242         Some of the heap allocated buffers were also not getting deleted.
3243
3244         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3245
3246 2018-07-06  Thibault Saunier  <tsaunier@igalia.com>
3247
3248         [WPE][GTK] Build php zlib plugin and enable sockets in flatpak
3249         https://bugs.webkit.org/show_bug.cgi?id=187401
3250
3251         Reviewed by Philippe Normand.
3252
3253         * flatpak/org.webkit.WebKit.yaml:
3254
3255 2018-07-06  Aakash Jain  <aakash_jain@apple.com>
3256
3257         [ews-build] EWS should run javascriptcore tests
3258         https://bugs.webkit.org/show_bug.cgi?id=187365
3259
3260         Reviewed by David Kilzer.
3261
3262         * BuildSlaveSupport/ews-build/steps.py: Added step to run JavaScriptCoreTests.
3263         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3264         * BuildSlaveSupport/ews-build/factories.py:
3265
3266 2018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3267
3268         [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails
3269         https://bugs.webkit.org/show_bug.cgi?id=187383
3270
3271         Reviewed by Žan Doberšek.
3272
3273         This is actually a problem in the test itself. The problem is that we run js, connect to message-received and
3274         quite the main loop when the message is received, which happens before the run js operation has been
3275         completed. The test finishes early and since r233111 an IPC message is still pending (I guess the run js
3276         callback) and the web page is still protected. Just adding a run loop operation before finishing the test would
3277         fix it. We should wait for the js run to complete, instead of the message.
3278
3279         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3280         (UserScriptMessageTest::scriptMessageReceived):
3281         (UserScriptMessageTest::waitUntilMessageReceived):
3282         (UserScriptMessageTest::runJavaScriptFinished):
3283         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
3284
3285 2018-07-05  Youenn Fablet  <youenn@apple.com>
3286
3287         REGRESSION (r230843): Flash doesn't work; Produces blue box on page
3288         https://bugs.webkit.org/show_bug.cgi?id=187346
3289         <rdar://problem/41773974>
3290
3291         Reviewed by Ryosuke Niwa.
3292
3293         * WebKitTestRunner/TestController.cpp:
3294         (WTR::TestController::resetStateToConsistentValues):
3295         (WTR::TestController::setBlockAllPlugins):
3296         When not blocked, set the load policy to allow once.
3297         * WebKitTestRunner/TestController.h:
3298
3299 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
3300
3301         [ews-build] Bindings-tests-EWS should output result in json
3302         https://bugs.webkit.org/show_bug.cgi?id=187330
3303
3304         Reviewed by David Kilzer.
3305
3306         * BuildSlaveSupport/ews-build/steps.py:
3307         (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
3308         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3309
3310 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
3311
3312         [ews-build] WebKitPy-Tests-EWS should output result in json
3313         https://bugs.webkit.org/show_bug.cgi?id=187331
3314
3315         Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.
3316
3317 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-build] WebKitPy-Tests-EWS should output result in json
3320         https://bugs.webkit.org/show_bug.cgi?id=187331
3321
3322         Reviewed by David Kilzer.
3323
3324         * BuildSlaveSupport/ews-build/steps.py:
3325         (RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.
3326         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3327
3328 2018-07-05  Philippe Normand  <pnormand@igalia.com>
3329
3330         [Flatpak] Add gst-libav to dependencies
3331         https://bugs.webkit.org/show_bug.cgi?id=187340
3332
3333         Reviewed by Žan Doberšek.
3334
3335         * flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git
3336         clones because the FFMPeg git server doesn't support shallow
3337         clones.
3338
3339 2018-07-05  Thibault Saunier  <tsaunier@igalia.com>
3340
3341         [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
3342         https://bugs.webkit.org/show_bug.cgi?id=187322
3343
3344         Reviewed by Žan Doberšek.
3345
3346         * flatpak/flatpakutils.py:
3347         (WebkitFlatpak.__init__):
3348
3349 2018-07-05  Zan Dobersek  <zdobersek@igalia.com>
3350
3351         Unreviewed, rolling out r233511.
3352
3353         Proper fix provided in bug #187322
3354
3355         Reverted changeset:
3356
3357         "Unreviewed. Fixing a call in flatpakutils.py to
3358         PortFactory.get(),"
3359         https://trac.webkit.org/changeset/233511
3360
3361 2018-07-04  Zan Dobersek  <zdobersek@igalia.com>
3362
3363         Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
3364         enforcing the passed platform argument to always be lowercase, as is
3365         expected from the PortFactory code.
3366
3367         * flatpak/flatpakutils.py:
3368         (WebkitFlatpak.clean_args):
3369
3370 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3371
3372         Introduce PLATFORM(IOSMAC)
3373         https://bugs.webkit.org/show_bug.cgi?id=187315
3374
3375         Reviewed by Dan Bernstein.
3376
3377         * TestWebKitAPI/Configurations/Base.xcconfig:
3378         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3379
3380 2018-07-03  Brady Eidson  <beidson@apple.com>
3381
3382         WebKit.ResponsivenessTimerCrash sometimes fails.
3383         https://bugs.webkit.org/show_bug.cgi?id=187314
3384
3385         Reviewed by Tim Horton.
3386
3387         Actually unregister observers from objects we're about to destroy before destroying them.
3388
3389         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
3390         (-[ResponsivenessTimerObserver observeValueForKeyPath:ofObject:change:context:]): 
3391
3392 2018-07-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3393
3394         update-webkitgtk-flatpak fails if running with python2
3395         https://bugs.webkit.org/show_bug.cgi?id=187240
3396
3397         Reviewed by Michael Catanzaro.
3398
3399         urllib.urlretrieve of Python2 sends invalid requests. Use
3400         urllib2.urlopen instead.
3401
3402         * flatpak/flatpakutils.py: Import urllib2.urlopen for Python2,
3403         urllib.request.urlopen for Python3.
3404         (FlatpakRepo.repo_file): Copy the content of urlopen result to the
3405         temporary file.
3406
3407 2018-07-03  Chris Dumez  <cdumez@apple.com>
3408
3409         Make CallbackMap::invalidate() safe to re-enter
3410         https://bugs.webkit.org/show_bug.cgi?id=187298
3411         <rdar://problem/41057167>
3412
3413         Reviewed by Geoffrey Garen.
3414
3415         Add API test coverage.
3416
3417         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
3418         (TEST):
3419
3420 2018-07-03  Chris Dumez  <cdumez@apple.com>
3421
3422         [Cocoa] Disable vnode guard related simulated crashes for WKTR / DRT and WebSQL
3423         https://bugs.webkit.org/show_bug.cgi?id=187270
3424         <rdar://problem/40674034>
3425
3426         Reviewed by Geoffrey Garen.
3427
3428         Disable vnode guard related simulated crashes for WKTR / DRT by setting the
3429         expected environment variable in the test driver.
3430
3431         * Scripts/webkitpy/port/driver.py:
3432         (Driver._setup_environ_for_driver):
3433
3434 2018-07-03  Eric Carlson  <eric.carlson@apple.com>
3435
3436         Video sometimes flickers when playing to AppleTV
3437         https://bugs.webkit.org/show_bug.cgi?id=187193
3438         <rdar://problem/40153865>
3439
3440         Unreviewed, fix test broken by r233435.
3441
3442         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3443         (TestWebKitAPI::waitUntilAudioSessionCategoryIsEqualTo): Poll for a change in audio session 
3444         category because it doesn't necessarily happen synchronously.
3445         (TestWebKitAPI::TEST):
3446
3447 2018-07-03  Thibault Saunier  <tsaunier@igalia.com>
3448
3449         Unreviewed, add myself as a WebKit committer.
3450
3451         And canonicalize the file as suggested by `check-webkit-style`
3452
3453         * Scripts/webkitpy/common/config/contributors.json:
3454
3455 2018-07-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3456
3457         check-webkit-style: Run the tool without SVN client.
3458         https://bugs.webkit.org/show_bug.cgi?id=187294
3459
3460         Reviewed by Daniel Bates.
3461
3462         When invoking check-webkit-style without SVN client, the exception was raised and terminated.
3463         Using Git repository is acceptable workflow according to the wording on:
3464         <https://webkit.org/getting-the-code/#checking-out-with-git>
3465         and using Subversion is considered optional by following link:
3466         <https://webkit.org/webkit-on-windows/#installing-developer-tools>.
3467         This patch makes it so that people with only a Git checkout of WebKit that commit using
3468         the commit-queue (or another machine with an SVN checkout) can run check-webkit-style.
3469
3470         * Scripts/webkitpy/common/checkout/scm/svn.py:
3471         (SVN.in_working_directory):
3472
3473 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
3474
3475         Remove old JSCTestsFactory
3476
3477         Follow-up fix to r233471.
3478
3479 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
3480
3481         [ews-build] Add support for JSC-Tests-EWS
3482         https://bugs.webkit.org/show_bug.cgi?id=187201
3483
3484         Reviewed by Lucas Forschler.
3485
3486         * BuildSlaveSupport/ews-build/factories.py:
3487         (JSCTestsFactory): Added JSCTestsFactory.
3488         * BuildSlaveSupport/ews-build/steps.py:
3489         (CompileJSCOnly): Command to compile JSC.
3490         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3491         * BuildSlaveSupport/ews-build/config.json: Changed platform to jsc-only. This matches with build.webkit.org configuration.
3492
3493 2018-07-03  Zalan Bujtas  <zalan@apple.com>
3494
3495         [LFC] Add test-list file for regression testing
3496         https://bugs.webkit.org/show_bug.cgi?id=187296
3497
3498         Reviewed by Antti Koivisto.
3499
3500         run-webkit-tests --test-list=./Tools/LayoutReloaded/misc/LFC-passing-tests.txt
3501
3502         * LayoutReloaded/misc/LFC-passing-tests.txt: Added.
3503
3504 2018-07-03  John Wilander  <wilander@apple.com>
3505
3506         Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
3507         https://bugs.webkit.org/show_bug.cgi?id=187277
3508         <rdar://problem/41745510>
3509
3510         Reviewed by Chris Dumez.
3511
3512         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3513         (WTR::TestController::getAllStorageAccessEntries):
3514
3515 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3516
3517         Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
3518         https://bugs.webkit.org/show_bug.cgi?id=187280
3519
3520         Reviewed by Tim Horton.
3521
3522         Add a missing `adoptNS()`.
3523
3524         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3525         (TestWebKitAPI::TEST):
3526
3527 2018-07-02  Myles C. Maxfield  <mmaxfield@apple.com>
3528
3529         [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
3530         https://bugs.webkit.org/show_bug.cgi?id=187228
3531         <rdar://problem/40967280>
3532
3533         Reviewed by Brent Fulgham.
3534
3535         The test only fails before the patch if the lookup for Helvetica2 is allowed to occur.
3536
3537         * WebKitTestRunner/mac/TestControllerMac.mm:
3538         (WTR::allowedFontFamilySet):
3539
3540 2018-07-02  Ryosuke Niwa  <rniwa@webkit.org>
3541
3542         run-benchmark should include the version number of MotionMark's results
3543         https://bugs.webkit.org/show_bug.cgi?id=187274
3544
3545         Reviewed by Jon Lee.
3546
3547         Append the version number as a part of the suite name.
3548
3549         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
3550
3551 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3552
3553         [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave
3554         https://bugs.webkit.org/show_bug.cgi?id=187253
3555
3556         Reviewed by Tim Horton.
3557
3558         Enhances and refactors LayoutTestSpellChecker, which was introduced in r233412.
3559
3560         * DumpRenderTree/TestRunner.cpp:
3561         (setSpellCheckerResultsCallback):
3562
3563         Rename setSpellCheckerTextReplacements to setSpellCheckerResults.
3564
3565         (TestRunner::staticFunctions):
3566         (setSpellCheckerTextReplacementsCallback): Deleted.
3567         * DumpRenderTree/TestRunner.h:
3568         * DumpRenderTree/mac/TestRunnerMac.mm:
3569         (TestRunner::setSpellCheckerResults):
3570         (TestRunner::setSpellCheckerTextReplacements): Deleted.
3571         * DumpRenderTree/win/TestRunnerWin.cpp:
3572         (TestRunner::setSpellCheckerResults):
3573         (TestRunner::setSpellCheckerTextReplacements): Deleted.
3574         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
3575         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3576         (-[LayoutTestTextCheckingResult initWithType:range:replacement:details:]):
3577         (-[LayoutTestTextCheckingResult grammarDetails]):
3578         (-[LayoutTestSpellChecker reset]):
3579         (-[LayoutTestSpellChecker results]):
3580         (-[LayoutTestSpellChecker setResults:]):
3581         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]):
3582
3583         Add support for passing in a list of grammar correction detail ranges. Necessary for simulating grammar errors.
3584
3585         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
3586
3587         Tweaked to always call the superclass method. This ensures that we set the `orthography` and `wordCount`
3588         outpointers if applicable.
3589
3590         (-[LayoutTestSpellChecker requestCheckingOfString:range:types:options:inSpellDocumentWithTag:completionHandler:]):
3591
3592         Added support for simulating asynchronous spell checking.
3593
3594         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]): Deleted.
3595         (-[LayoutTestSpellChecker replacements]): Deleted.
3596         (-[LayoutTestSpellChecker setReplacements:]): Deleted.
3597         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]): Deleted.
3598
3599 2018-07-02  Brady Eidson  <beidson@apple.com>
3600
3601         Another unreviewed followup to:
3602         Crash notifying observers of responsiveness state change
3603
3604         * TestWebKitAPI/cocoa/TestWKWebView.h:
3605         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3606         (-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this
3607           test on iOS for other reasons.
3608
3609 2018-07-02  Brady Eidson  <beidson@apple.com>
3610
3611         Unreviewed followup to:
3612         Crash notifying observers of responsiveness state change
3613
3614         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Need the C-SPI for this test.
3615
3616 2018-07-02  Brady Eidson  <beidson@apple.com>
3617
3618         Crash notifying observers of responsiveness state change
3619         <rdar://problem/41267796> and https://bugs.webkit.org/show_bug.cgi?id=187262
3620
3621         Reviewed by Tim Horton.
3622
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3624         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Added.
3625         (-[RTObserver observeValueForKeyPath:ofObject:change:context:]):
3626         (TestWebKitAPI::TEST):
3627         * TestWebKitAPI/cocoa/TestWKWebView.h:
3628         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3629         (-[TestWKWebView typeCharacter:]):
3630         (-[TestWKWebView hostWindow]):
3631
3632 2018-07-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3633
3634         [WPE][GTK] flatpakutils.py should respect set-webkit-configuration build type
3635         https://bugs.webkit.org/show_bug.cgi?id=187218
3636
3637         Reviewed by Philippe Normand.
3638
3639         Using the webkitpy Config module, if the build type is not passed on the command line, we
3640         read it from WebKitBuild/Configuration and respect it.
3641
3642         * flatpak/flatpakutils.py:
3643         (WebkitFlatpak.__init__):
3644         (WebkitFlatpak.clean_args):
3645
3646 2018-07-02  Zan Dobersek  <zdobersek@igalia.com>
3647
3648         [WPE] Add touch support to WindowViewBackend
3649         https://bugs.webkit.org/show_bug.cgi?id=187245
3650
3651         Reviewed by Carlos Garcia Campos.
3652
3653         Add touch input support to the WindowViewBackend implementation,
3654         plugging into the Wayland protocol in order to get properly notified
3655         about these events, and then dispatching them against the appropriate
3656         wpe_view_backend object so that WebKit can process them.
3657
3658         * wpe/backends/ViewBackend.cpp:
3659         (WPEToolingBackends::ViewBackend::dispatchInputTouchEvent):
3660         * wpe/backends/ViewBackend.h:
3661         * wpe/backends/WindowViewBackend.cpp:
3662         * wpe/backends/WindowViewBackend.h:
3663
3664 2018-07-02  Rob Buis  <rbuis@igalia.com>
3665
3666         [GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
3667         https://bugs.webkit.org/show_bug.cgi?id=186838
3668
3669         This URL constructor expects canonicalized input, so fix the passed URL. I missed
3670         this one some weeks ago since I had an older checkout.
3671
3672         Reviewed by Michael Catanzaro.
3673
3674         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3675         (TestWebKitAPI::TEST):
3676
3677 2018-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3678
3679         [macOS] Text replacements that end with symbols are expanded immediately
3680         https://bugs.webkit.org/show_bug.cgi?id=187225
3681         <rdar://problem/41112433>
3682
3683         Reviewed by Darin Adler.
3684
3685         Adds testing support for mocking NSSpellChecker's text checking results. See below for more details, and the new
3686         layout test for an example of its usage.
3687
3688         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3689         * DumpRenderTree/TestRunner.cpp:
3690         (setSpellCheckerTextReplacementsCallback):
3691
3692         Add bindings support in TestRunner to specify a set of text replacement mappings. Each entry in the dictionary
3693         maps a string representing an input to the NSSpellChecker to some information describing the spell checking
3694         result that LayoutTestSpellChecker will return.
3695
3696         (TestRunner::staticFunctions):
3697         * DumpRenderTree/TestRunner.h:
3698         * DumpRenderTree/mac/DumpRenderTree.mm:
3699         (resetWebViewToConsistentStateBeforeTesting):
3700
3701         Restore the original shared NSSpellchecker before transitioning to the next layout test, if needed.
3702
3703         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Removed.
3704         * DumpRenderTree/mac/TestRunnerMac.mm:
3705         (TestRunner::setSpellCheckerLoggingEnabled):
3706         (TestRunner::setSpellCheckerTextReplacements):
3707
3708         These testRunner methods ensure that `-[NSSpellChecker sharedSpellChecker]` is swizzled to return our mock
3709         LayoutTestSpellChecker instance before calling into it.
3710
3711         * DumpRenderTree/win/TestRunnerWin.cpp:
3712         (TestRunner::setSpellCheckerTextReplacements):
3713         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreeSpellChecker.h.
3714         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm: Added.
3715
3716         Moved DumpRenderTreeSpellChecker to LayoutTestSpellChecker, and made it compile for both WebKitTestRunner
3717         (modern WebKit) and DumpRenderTree (legacy WebKit) by putting it in TestRunnerShared.
3718
3719         (existingGlobalLayoutTestSpellChecker):
3720         (ensureGlobalLayoutTestSpellChecker):
3721         (stringForCorrectionResponse):
3722         (nsTextCheckingType):
3723         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]):
3724         (-[LayoutTestTextCheckingResult range]):
3725         (-[LayoutTestTextCheckingResult resultType]):
3726         (-[LayoutTestTextCheckingResult replacementString]):
3727         (-[LayoutTestTextCheckingResult description]):
3728
3729         LayoutTestTextCheckingResult represents a fake NSTextCheckingResult containing spell checking results supplied
3730         by the layout test.
3731
3732         (+[LayoutTestSpellChecker installIfNecessary]):
3733         (+[LayoutTestSpellChecker uninstallAndReset]):
3734
3735         Helper methods to begin and end swizzling the shared NSSpellChecker.
3736
3737         (-[LayoutTestSpellChecker reset]):
3738
3739         Resets the state of the LayoutTestSpellChecker (this entails clearing the fake replacements dictionary and
3740         turning off logging for recorded spellchecking responses).
3741
3742         (-[LayoutTestSpellChecker replacements]):
3743         (-[LayoutTestSpellChecker setReplacements:]):
3744         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]):
3745
3746         Helper method to take a `JSObjectRef` supplied by the test runner and transform it into a map of spell checking
3747         string inputs to LayoutTestTextCheckingResults.
3748
3749         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
3750
3751         Consult the text replacement map and bail early if a match is found, before calling into real NSSpellChecker
3752         logic to perform spellchecking.
3753
3754         (-[LayoutTestSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:]):
3755
3756         Reimplement the original functionality in DumpRenderTreeSpellChecker to make `-recordResponse:…` print to stdout
3757         by overriding the method and printing if the `-spellCheckerLoggingEnabled` property has been set to YES.
3758
3759         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3760
3761 2018-07-01  Thibault Saunier  <tsaunier@igalia.com>
3762
3763         [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
3764         https://bugs.webkit.org/show_bug.cgi?id=187232
3765
3766         Reviewed by Michael Catanzaro.
3767
3768         The place where host tmp folder is mounted changed to /run/host/ we
3769         need to take that into account.
3770
3771         Also explicitely close temporary files as relying on garbage collection to
3772         remove them is a bad idea.
3773
3774         Also minor optimization avoiding to compile regex for each backtrace
3775         retrieval.
3776
3777         * Scripts/webkitpy/port/linux_get_crash_log.py:
3778         (GDBCrashLogGenerator):
3779         (GDBCrashLogGenerator._get_tmp_file_name):
3780         (GDBCrashLogGenerator._get_trace_from_systemd):
3781
3782 2018-06-30  Daniel Bates  <dabates@apple.com>
3783
3784         test-webkitpy never rebuilds lldbWebKitTester
3785         https://bugs.webkit.org/show_bug.cgi?id=187229
3786
3787         Reviewed by David Kilzer.
3788
3789         Have test-webkitpy always call script build-lldbwebkittester to build lldbWebKitTester, if needed.
3790
3791         Currently test-webkitpy only calls script build-lldbwebkittester if lldbWebKitTester does not
3792         exist in the build products directory for the active configuration (e.g. Debug); => we do not
3793         build lldbWebKitTester again if its source changes (say, as a result of hacking on lldbWebKitTester).
3794         Instead we should have test-webkitpy unconditionally call build-lldbwebkittester to ensure
3795         that we have an up-to-date build of lldbWebKitTester.
3796
3797         * Scripts/webkitpy/test/main.py:
3798         (Tester._run_tests):
3799         (_find_lldb_webkit_tester): Deleted.
3800
3801 2018-06-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3802
3803         [CMake] build-webkit should be able to enable address sanitizer
3804         https://bugs.webkit.org/show_bug.cgi?id=187222
3805
3806         Reviewed by Daniel Bates.
3807
3808         If 'set-webkit-configuration --asan' has been run, then build-webkit should pass
3809         -DENABLE_ADDRESS_SANITIZER=ON to CMake, so that it actually does something.
3810
3811         This also works for build-jsc.
3812
3813         * Scripts/webkitdirs.pm:
3814         (generateBuildSystemFromCMakeProject):
3815
3816 2018-06-30  Thibault Saunier  <tsaunier@igalia.com>
3817
3818         Make check_flatpak() not verbose when only trying to run command inside flatpak
3819         https://bugs.webkit.org/show_bug.cgi?id=187187
3820
3821         Reviewed by Michael Catanzaro.
3822
3823         * flatpak/flatpakutils.py:
3824         (run_in_sandbox_if_available):
3825
3826 2018-06-29  Daniel Bates  <dabates@apple.com>
3827
3828         build-webkit: Perl "use of uninitialized value $previousContents"
3829         https://bugs.webkit.org/show_bug.cgi?id=185776
3830
3831         Reviewed by Michael Catanzaro.
3832
3833         Fixes an issue where reading an empty cached argument file would cause
3834         Perl "uninitialized value" warnings of the form:
3835             Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
3836             Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
3837
3838         * Scripts/webkitdirs.pm:
3839         (isCachedArgumentfileOutOfDate):
3840
3841 2018-06-29  Daniel Bates  <dabates@apple.com>
3842
3843         Perl uninitialized value $isEnabled when running build-jsc using a CMake build
3844         https://bugs.webkit.org/show_bug.cgi?id=187208
3845
3846         Reviewed by Tim Horton.
3847
3848         Share logic for computing the feature flags to enable in CMake with both script
3849         build-webkit and script build-jsc instead of duplicating it. This also fixes a
3850         bug in the version of this logic in build-jsc that was inadvertently not updated
3851         in r222394. In r222394 we removed the notion of a default value for a feature flag
3852         listed in webkitperl::FeatureList.
3853
3854         We keep the current behavior of build-jsc and leave it up to the build system
3855         to determine whether to enable or disable ENABLE_EXPERIMENTAL_FEATURES.
3856
3857         * Scripts/build-jsc:
3858         (buildMyProject):
3859         (cMakeArgsFromFeatures): Deleted.
3860         * Scripts/build-webkit:
3861         (cMakeArgsFromFeatures): Deleted; moved to webkitdirs.pm.
3862         * Scripts/webkitdirs.pm:
3863         (cmakeArgsFromFeatures): Moved code from script build-webkit so that it can be shared
3864         with build-jsc.
3865
3866 2018-06-29  Tim Horton  <timothy_horton@apple.com>
3867
3868         Add -apple-color-filter and system appearance toggles to MiniBrowser
3869         https://bugs.webkit.org/show_bug.cgi?id=187210
3870
3871         Reviewed by Simon Fraser.
3872
3873         * MiniBrowser/mac/AppDelegate.m:
3874         (defaultConfiguration):
3875         * MiniBrowser/mac/SettingsController.h:
3876         * MiniBrowser/mac/SettingsController.m:
3877         (-[SettingsController _populateMenu]):
3878         (-[SettingsController validateMenuItem:]):
3879         (-[SettingsController toggleAppleColorFilterEnabled:]):
3880         (-[SettingsController appleColorFilterEnabled]):
3881         (-[SettingsController toggleUseSystemAppearance:]):
3882         (-[SettingsController useSystemAppearance]):
3883         * MiniBrowser/mac/WK1BrowserWindowController.m:
3884         (-[WK1BrowserWindowController didChangeSettings]):
3885         * MiniBrowser/mac/WK2BrowserWindowController.m:
3886         (-[WK2BrowserWindowController didChangeSettings]):
3887
3888 2018-06-29  Aditya Keerthi  <akeerthi@apple.com>
3889
3890         [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard
3891         https://bugs.webkit.org/show_bug.cgi?id=187183
3892
3893         Reviewed by Wenson Hsieh.
3894
3895         Added a 'runSingly' option to the TestOptions struct. Setting this option to true
3896         will force a new PlatformWebView to be created before running a test. This ensures
3897         that any state set by previous tests are not preserved.
3898
3899         One example of the importance of having this ability is in the case where we want
3900         to test functionality that deals with read access to files. If a test were to
3901         load a valid file URL, universal read access will be granted in WebProcessProxy.
3902         This prevents us from testing cases that rely on us not have universal read
3903         access. Now, if we write the test using the 'runSingly' option, any state set
3904         by previous tests is cleared. Consequently, our test will behave as expected.
3905
3906         * WebKitTestRunner/PlatformWebView.h:
3907         (WTR::PlatformWebView::viewSupportsOptions const):
3908         * WebKitTestRunner/TestController.cpp:
3909         (WTR::updateTestOptionsFromTestHeader):
3910         * WebKitTestRunner/TestOptions.h:
3911         (WTR::TestOptions::hasSameInitializationOptions const):
3912
3913 2018-06-29  Daniel Bates  <dabates@apple.com>
3914
3915         [lldb-webkit] Non-empty strings may be pretty-printed as empty
3916         https://bugs.webkit.org/show_bug.cgi?id=187185
3917
3918         Reviewed by Simon Fraser.
3919
3920         For some reason lldb(1) sometimes has an issue accessing members of WTF::StringImplShape
3921         via a WTF::StringImpl pointer (why?). Explicitly casting a WTF::StringImpl* to a
3922         WTF::StringImplShape* before accessing such members makes LLDB happy.
3923
3924         I tried writing a test for this both for the LLVM project and to add to our lldb_webkit unit
3925         tests to no avail. I have only been able to reproduce this bug sporadically during my WebCore/WebKit
3926         debugging sessions so far.
3927
3928         * lldb/lldb_webkit.py:
3929         (WTFStringImplProvider.__init__): Explicitly cast the WTF::StringImpl* to WTF::StringImplShape*.
3930         (WTFStringImplProvider.get_data8): Update code now that we are directly accessing WTF::StringImplShape*.
3931         (WTFStringImplProvider.get_data16): Ditto.
3932
3933 2018-06-29  Chris Dumez  <cdumez@apple.com>
3934
3935         WebKitLegacy: Can trigger recursive loads triggering debug assertions
3936         https://bugs.webkit.org/show_bug.cgi?id=187121
3937         <rdar://problem/41259430>
3938
3939         Reviewed by Brent Fulgham.
3940
3941         Add API test coverage.
3942
3943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3944         * TestWebKitAPI/Tests/mac/StartLoadInDidFailProvisionalLoad.mm: Added.
3945         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3946         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFinishLoadForFrame:]):
3947         (TestWebKitAPI::TEST):
3948
3949 2018-06-29  Lucas Forschler  <lforschler@apple.com>
3950
3951         Teach bisect-builds to retrieve supported platforms from the rest api.
3952         https://bugs.webkit.org/show_bug.cgi?id=187195
3953         
3954         This patch updates bisect-builds to use v2_2 of the API. v2_2 adds two api endpoints: /platforms, and /minified-platforms.
3955         These endpoints scan a dynamoDB database, returning the identifier key for all available platforms.
3956         The identifier keys are in the format: platform-architecture-configuration.
3957
3958         Reviewed by Aakash Jain.
3959
3960         * Scripts/bisect-builds:
3961         (get_api_archive_url): refactored from get_api_url.
3962         (get_platforms): helper function to retrieve from the platforms api.
3963         (minified_platforms): returns a list of minified platforms currently in the database
3964         (unminified_platforms): returns a list of unminified platforms currently in the database
3965         (is_supported_platform): checks if the platform-architecture-configuration combo is supported
3966         (fetch_revision_list): refactored to use get_api_archive_url
3967         (get_api_url): Deleted/refactored to get_api_archive_url.
3968
3969 2018-06-29  Keith Miller  <keith_miller@apple.com>
3970
3971         run-jsc should print when jsc exits with non-zero status
3972         https://bugs.webkit.org/show_bug.cgi?id=187192
3973
3974         Reviewed by Saam Barati.
3975
3976         * Scripts/run-jsc:
3977
3978 2018-06-29  Aakash Jain  <aakash_jain@apple.com>
3979
3980         [ews-build] Add timeout to webkitpy and webkitperl tests
3981         https://bugs.webkit.org/show_bug.cgi?id=187191
3982
3983         Reviewed by Lucas Forschler.
3984
3985         * BuildSlaveSupport/ews-build/steps.py:
3986         (RunWebKitPerlTests.__init__): Set timeout of 2 minutes.
3987         (RunWebKitPyTests.__init__): Ditto.
3988         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3989
3990 2018-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3991
3992         [WPE]: Fix exception handling when flatpak is not installed
3993         https://bugs.webkit.org/show_bug.cgi?id=186771
3994
3995         Unreviewed followup-fix after r233362
3996
3997         This was causing failures when flatpak is not installed.
3998
3999         * flatpak/flatpakutils.py:
4000         (check_flatpak):
4001
4002 2018-06-29  Ross Kirsling  <ross.kirsling@sony.com>
4003
4004         [JSCOnly] Restore Windows build.
4005         https://bugs.webkit.org/show_bug.cgi?id=187127
4006
4007         Reviewed by Michael Catanzaro.
4008
4009         * Scripts/build-jsc:
4010         Fix condition for disabling FTL JIT on Windows.
4011
4012         * Scripts/webkitdirs.pm:
4013         (executableProductDir):
4014         JSCOnly should still use bin64 on Windows (for consistency with full WebKit build).
4015         (determineIsWin64):
4016         JSCOnly already defaults to 64-bit on Windows with Ninja -- ensure that this is true even with MSBuild.
4017
4018 2018-06-29  Thibault Saunier  <tsaunier@igalia.com>
4019
4020         [GTK][WPE]: Add a way to setup our development environment inside flatpak
4021         https://bugs.webkit.org/show_bug.cgi?id=186771
4022
4023         Reviewed by Carlos Alberto Lopez Perez.
4024
4025         This patch introduce a way to setup the development environment inside flatpak[0]
4026         removing the need for jhbuild when doing so. Anything needed to build/run minibrowser/ run
4027         layout tests is provided either but the org.gnome.Sdk runtime or built with flatpak-builder.
4028
4029         The workflow is very similar to the "jhbuild based" one except that you should use update-webkit$PORTNAME-flatpak instead
4030         of update-webkit$PORTNAME-libs and that script requires to specify a build configuration (--release is default).
4031
4032         Our scripts have been updated to be able to run inside that new build environment.
4033
4034         Since everything runs inside a flatpak sandbox, gdb needs to be run from within the sandbox, the script exposes a way to do it
4035         easily with the `--gdb` option:
4036
4037           $ webkit-flatpak --gdb [-m COREDUMPCTL MATCHES]
4038
4039         The Layout test `GDBCrashLogGenerator` has been taugth how to use that and is able to retrieve stacktrace as with the jhbuild based workflow.
4040
4041         [0] http://flatpak.org
4042
4043         * Scripts/build-webkit:
4044         * Scripts/generate-jsc-bundle:
4045         (main):
4046         * Scripts/run-gtk-tests:
4047         * Scripts/run-minibrowser:
4048         * Scripts/run-webdriver-tests:
4049         * Scripts/run-webkit-tests:
4050         * Scripts/run-wpe-tests:
4051         * Scripts/update-webkitgtk-libs:
4052         * Scripts/update-webkitwpe-libs:
4053         * Scripts/webkit-flatpak: Added.
4054         * Scripts/webkitdirs.pm:
4055         (getJhbuildPath):
4056         (getFlatpakPath):
4057         (inFlatpakSandbox):
4058         (runInFlatpak):
4059         (runInFlatpakIfAvalaible):
4060         (wrapperPrefixIfNeeded):
4061         (shouldUseFlatpak):
4062         * Scripts/webkitpy/port/base.py:
4063         (Port._path_to_apache):
4064         (Port._is_flatpak):
4065         (Port._apache_config_file_name_for_platform):
4066         (Port._should_use_flatpak):
4067         (Port):
4068         (Port._in_flatpak_sandbox):
4069         (Port._should_use_jhbuild):
4070         * Scripts/webkitpy/port/gtk.py:
4071         (GtkPort.setup_environ_for_server):
4072         * Scripts/webkitpy/port/linux_get_crash_log.py:
4073         (GDBCrashLogGenerator._get_trace_from_systemd):
4074         (GDBCrashLogGenerator.generate_crash_log):
4075         * Scripts/webkitpy/port/wpe.py:
4076         (WPEPort.setup_environ_for_server):
4077         * Scripts/webkitpy/w3c/wpt_runner.py:
4078         (main):
4079         * flatpak/files/default.xkm: Added.
4080         * flatpak/files/httpd-autogen.sh: Added.
4081         * flatpak/flatpakutils.py: Added.
4082         (Colors):
4083         (Console):
4084         (Console.message):
4085         (remove_extension_points):
4086         (remove_comments):
4087         (remove_comments._replacer):
4088         (load_manifest):
4089         (expand_manifest):
4090         (FlatpakObject):
4091         (FlatpakObject.__init__):
4092         (FlatpakObject.flatpak):
4093         (FlatpakPackages):
4094         (FlatpakPackages.__init__):
4095         (FlatpakPackages.__detect_packages):
4096         (FlatpakPackages.__detect_packages.in):
4097         (FlatpakPackages.__detect_runtimes):
4098         (FlatpakPackages.__detect_apps):
4099         (FlatpakPackages.__iter__):
4100         (FlatpakRepos):
4101         (FlatpakRepos.__init__):
4102         (FlatpakRepos.update):
4103         (FlatpakRepos.add):
4104         (FlatpakRepo):
4105         (FlatpakRepo.__init__):
4106         (FlatpakRepo.repo_file):
4107         (FlatpakPackage):
4108         (FlatpakPackage.__init__):
4109         (FlatpakPackage.__str__):
4110         (FlatpakPackage.is_installed):
4111         (FlatpakPackage.install):
4112         (FlatpakPackage.update):
4113         (WebkitFlatpak):
4114         (WebkitFlatpak.load_from_args):
4115         (WebkitFlatpak.__init__):
4116         (WebkitFlatpak.check_flatpak):
4117         (WebkitFlatpak.check_flatpak.comparable_version):
4118         (WebkitFlatpak.clean_args):
4119         (WebkitFlatpak.run_in_sandbox):
4120         (WebkitFlatpak.run):
4121         (WebkitFlatpak.has_environment):
4122         (WebkitFlatpak.setup_dev_env):
4123         (WebkitFlatpak.install_all):
4124         (WebkitFlatpak.run_gdb):
4125         (WebkitFlatpak.update_all):
4126         (is_sandboxed):
4127         (run_in_sandbox_if_available):
4128         * flatpak/org.webkit.GTK.yaml: Added.
4129         * flatpak/org.webkit.WPE.yaml: Added.
4130         * flatpak/org.webkit.WebKit.yaml: Added.
4131         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
4132         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Added.
4133
4134 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4135
4136         [iOS] DataTransfer.getData always returns the empty string when dropping text
4137         https://bugs.webkit.org/show_bug.cgi?id=187130
4138         <rdar://problem/41014117>
4139
4140         Reviewed by Ryosuke Niwa.
4141
4142         Add 2 new API tests to verify that:
4143         -   When dropping an item with text, markup, and URL representations, the page is allowed to get "text/html",
4144             "text/plain" and "text/uri-list" data.
4145         -   Adding a suggested name to a plain text item causes WebKit to treat it as a file, and suppress access to
4146             DataTransfer.getData().
4147
4148         Additionally tweaks a couple of existing API tests. Namely, in two API tests
4149         (ExternalSourceOverrideDropFileUpload and ExternalSourceHTMLToUploadArea) only a markup string is dropped, and
4150         we previously expected to handle the drop as a file. To allow this test to continue serving its purpose, tweak
4151         them such that the registered items appear to be file-backed (i.e. by adding a suggested filename in one of the
4152         tests, and specifying UIPreferredPresentationStyleAttachment in the other).
4153
4154         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4155         (TestWebKitAPI::TEST):
4156
4157 2018-06-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>
4158
4159         Unreviewed, rolling out r226652.
4160         https://bugs.webkit.org/show_bug.cgi?id=180827
4161
4162         "PlatformInfo should never be instantiated in isolation. So, PlatformInfo should
4163         not have default argument values. The preferred way to get a PlatformInfo object
4164         is to instantiate a Host object." (Requested by dbates).
4165
4166         Reverted changeset:
4167
4168         "[webkitpy] PlatformInfo should have default argument for casual use"
4169         https://bugs.webkit.org/show_bug.cgi?id=180827
4170
4171 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
4172
4173         Try to address test failures on the bots.
4174
4175         Allow the test to distinguish between a failure to find the variable, and an error
4176         reporting vector capacity.
4177
4178         * lldb/lldb_webkit_unittest.py:
4179         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
4180         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
4181
4182 2018-06-28  Lucas Forschler  <lforschler@apple.com>
4183
4184         Add Windows support for WEBKIT_API_KEY.
4185         https://bugs.webkit.org/show_bug.cgi?id=187155
4186
4187         Reviewed by Daniel Bates.
4188
4189         * EWSTools/start-queue-win.sh:
4190
4191 2018-06-28  Aakash Jain  <aakash_jain@apple.com>
4192
4193         [ews-build] Add support for WebKitPy-Tests-EWS
4194         https://bugs.webkit.org/show_bug.cgi?id=187148
4195
4196         Reviewed by Lucas Forschler.
4197
4198         * BuildSlaveSupport/ews-build/factories.py: Added WebKitPyFactory.
4199         * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPyTests.
4200         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4201         * BuildSlaveSupport/ews-build/config.json: Updated to use CamelCase. 
4202
4203 2018-06-28  Daniel Bates  <dabates@apple.com>
4204
4205         Fix the iOS build following r233299
4206         (https://bugs.webkit.org/show_bug.cgi?id=183744)
4207
4208         Only build lldbWebKitTester on Mac as that is the only supported platform at the time of writing.
4209
4210         * Makefile:
4211
4212 2018-06-28  Sihui Liu  <sihui_liu@apple.com>
4213
4214         Cookie API: cookie creation time is wrong
4215         https://bugs.webkit.org/show_bug.cgi?id=187101
4216
4217         Reviewed by Geoffrey Garen.
4218
4219         Add test coverage: make sure the cookie creation time returned is the same as set.
4220
4221         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
4222         (TEST):
4223
4224 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
4225
4226         The lldb vector summary provider always shows zero capacity
4227         https://bugs.webkit.org/show_bug.cgi?id=187132
4228
4229         Reviewed by Daniel Bates.
4230         
4231         WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
4232         on the buffer instead of the valobj.
4233
4234         * lldb/lldbWebKitTester/main.cpp:
4235         (testSummaryProviders):
4236         * lldb/lldb_webkit.py:
4237         (WTFVectorProvider.update):
4238         * lldb/lldb_webkit_unittest.py:
4239         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
4240         (TestSummaryProviders):
4241         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
4242         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
4243
4244 2018-06-28  Adam Barth  <abarth@webkit.org>
4245
4246         Switch OS(FUCHSIA) to using JSCOnly
4247         https://bugs.webkit.org/show_bug.cgi?id=187133
4248
4249         Reviewed by Yusuke Suzuki.
4250
4251         Switch Fuchsia from being a port to just being an OS. We now use a
4252         CMAKE_TOOLCHAIN_FILE to configure the toolchain and the target triple.
4253
4254         * Scripts/webkitdirs.pm: Remove isFuchsia() and clients. Turns out we
4255         can do everything we need using a CMAKE_TOOLCHAIN_FILE via the
4256         --cmakeargs flag.
4257
4258 2018-06-27  Ryosuke Niwa  <rniwa@webkit.org>
4259
4260         Make MotionMark's plan file more robust against code changes
4261         https://bugs.webkit.org/show_bug.cgi?id=187116
4262         <rdar://problem/41533956>
4263
4264         Reviewed by Saam Barati.
4265