Tools/ChangeLog

   1 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
   2
   3         [GTK] Fix concatenations of string literals that are not C++11-compliant
   4         https://bugs.webkit.org/show_bug.cgi?id=116449
   5
   6         Reviewed by Martin Robinson.
   7
   8         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
   9         is simply a matter of separating the string and the string literal that are being concatenated with a space.
  10
  11         * ImageDiff/gtk/ImageDiff.cpp:
  12         (printImage):
  13
  14 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
  15
  16         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
  17         https://bugs.webkit.org/show_bug.cgi?id=116450
  18
  19         Reviewed by Martin Robinson.
  20
  21         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
  22         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
  23         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
  24         TestWebKitAPI programs when compiling them.
  25
  26         * TestWebKitAPI/GNUmakefile.am:
  27
  28 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
  29
  30         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
  31         https://bugs.webkit.org/show_bug.cgi?id=116492
  32
  33         Reviewed by Dirk Pranke.
  34
  35         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
  36
  37         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
  38         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
  39         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
  40         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
  41         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
  42         to memory pressure on the machine.
  43
  44         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
  45         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
  46         for a subsequent patch just to make things easier to follow.
  47
  48         * Scripts/webkitpy/port/driver.py:
  49         (DriverProxy.__init__):
  50         (DriverProxy.run_test):
  51         (DriverProxy.has_crashed):
  52         (DriverProxy.stop):
  53
  54 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
  55
  56         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
  57         https://bugs.webkit.org/show_bug.cgi?id=116423
  58
  59         Reviewed by Ryosuke Niwa.
  60
  61         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
  62
  63         * BuildSlaveSupport/build.webkit.org-config/config.json:
  64
  65 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
  66
  67         Remove remaining link-prerender code
  68         https://bugs.webkit.org/show_bug.cgi?id=116429
  69
  70         Reviewed by Darin Adler.
  71
  72         Link prerendering code was removed in r150356.
  73
  74         * Scripts/webkitperl/FeatureList.pm:
  75         * qmake/mkspecs/features/features.pri:
  76
  77 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
  78
  79         commit-queue should check for oops in changelog entries
  80         https://bugs.webkit.org/show_bug.cgi?id=116395
  81
  82         Reviewed by Martin Robinson.
  83
  84         Make changelog validation fail when it contains oops!.
  85
  86         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  87         (CommitQueueTask._validate_changelog):
  88         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  89         (CommitQueueTaskTest._run_through_task):
  90         * Scripts/webkitpy/tool/commands/queues_unittest.py:
  91         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
  92         (ValidateChangeLogs.options):
  93         (ValidateChangeLogs._check_changelog_diff):
  94         (ValidateChangeLogs._changelog_contains_oops):
  95         (ValidateChangeLogs.run):
  96         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
  97         (ValidateChangeLogsTest._assert_start_line_produces_output):
  98         (ValidateChangeLogsTest.test_check_changelog_diff):
  99         (ValidateChangeLogsTest):
 100         (ValidateChangeLogsTest.test_changelog_contains_oops):
 101
 102 2013-05-20  Jessie Berlin  <jberlin@apple.com>
 103
 104         Expose a way to know when forms are added to a page or when form controls are added to a form
 105         in the injected bundle
 106         https://bugs.webkit.org/show_bug.cgi?id=116334
 107
 108         Reviewed by Alexey Proskuryakov.
 109
 110         Add tests for the new callbacks.
 111
 112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 113         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
 114
 115         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
 116         (TestWebKitAPI::nullJavaScriptCallback):
 117         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
 118         being passed in for the callback.
 119         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
 120         After receiving the message that didAssociateFormControls callback was invoked from adding
 121         the form in the onload handler, tell the page to add a password field to the form, which
 122         should also invoke didAssociateFormControls callback.
 123         (TestWebKitAPI::setInjectedBundleClient):
 124         Register to receive messages.
 125         (TestWebKitAPI::TEST):
 126         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
 127         been invoked for both adding the form and for adding a password field to the form.
 128
 129         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
 130         (TestWebKitAPI::shouldNotifyOnFormChanges):
 131         Return true so the didAssociateFormControls callback is invoked.
 132         (TestWebKitAPI::didAssociateFormControls):
 133         Tell the UI process.
 134         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
 135         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
 136         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
 137
 138         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
 139         Add a form in response to the onload event. Add a button that will add the password field
 140         for manual testing.
 141
 142 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 143
 144         [EFL][JHBUILD] Make sure eet is built before evas
 145         https://bugs.webkit.org/show_bug.cgi?id=116440
 146
 147         Reviewed by Gyuyoung Kim.
 148
 149         Mark eet as a dependency of evas since evas requires eet to enable some of its
 150         functionality.
 151
 152         * efl/jhbuild.modules:
 153
 154 2013-05-20  Alex Christensen  <achristensen@apple.com>
 155
 156         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
 157         https://bugs.webkit.org/show_bug.cgi?id=116125
 158
 159         Reviewed by Tim Horton.
 160
 161         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 162         (WTR::pathSuitableForTestResult):
 163         Changed string operations to match _drt_descriptionSuitableForTestResult.
 164         (WTR::dumpRequestDescriptionSuitableForTestResult):
 165         (WTR::dumpResponseDescriptionSuitableForTestResult):
 166         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
 167         (WTR::InjectedBundlePage::didInitiateLoadForResource):
 168         (WTR::InjectedBundlePage::willSendRequestForFrame):
 169         (WTR::InjectedBundlePage::didReceiveResponseForResource):
 170         Pass the main frame's URL to pathSuitableForTestResult.
 171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 172         Added WKBundlePageRef to willPerformClientRedirectForFrame.
 173
 174 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
 175
 176         fix w3c test importer unit tests after r150324
 177         https://bugs.webkit.org/show_bug.cgi?id=116459
 178
 179         Reviewed by Ryosuke Niwa.
 180
 181         This patch fixes the unit tests to not actually call out to
 182         'hg' (by using a mock executive) and also changes the real
 183         directory we crawl from Source/WebCore/css to
 184         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
 185         still change this to a mock filesystem, but that's a separate change.
 186
 187         * Scripts/webkitpy/w3c/test_importer.py:
 188         (main):
 189         (TestImporter.__init__):
 190         (TestImporter.load_changeset):
 191         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 192         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
 193         (TestImporterTest.test_import_dir_with_no_tests):
 194
 195 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 196
 197         Unreviewed EFL build fix.
 198
 199         Fix linking errors due to undefined symbols on Ubuntu 13.04.
 200
 201         * DumpRenderTree/efl/CMakeLists.txt:
 202         * EWebLauncher/CMakeLists.txt:
 203         * MiniBrowser/efl/CMakeLists.txt:
 204
 205 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 206
 207         [EFL] Reenabled INDEXED_DATABASE after r150344
 208         https://bugs.webkit.org/show_bug.cgi?id=116430
 209
 210         Reviewed by Gyuyoung Kim.
 211
 212         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
 213         build was fixed in r150344.
 214
 215         * Scripts/webkitperl/FeatureList.pm:
 216
 217 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
 218
 219         [EFL] init/shutdown should be paired in EWebLauncher
 220         https://bugs.webkit.org/show_bug.cgi?id=116427
 221
 222         Reviewed by Christophe Dumez.
 223
 224         Added ecore_file_shutdown() for cleanup of ecore_file.
 225         Removed edje_init and ecore_evas_init because it was in ewk_init().
 226
 227         * EWebLauncher/main.c:
 228         (main):
 229
 230 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
 231
 232         [EFL] Add command line option to MiniBrowser to set user agent
 233         https://bugs.webkit.org/show_bug.cgi?id=116387
 234
 235         Reviewed by Christophe Dumez.
 236
 237         We need this option to compare the rendering differences according to different user agents.
 238
 239         * MiniBrowser/efl/main.c:
 240         (window_create):
 241         (elm_main):
 242
 243 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
 244
 245         Unreviewed, addressing test-webkitpy failures after r150317.
 246
 247         * Scripts/webkitpy/w3c/test_converter.py:
 248         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
 249
 250 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
 251
 252         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
 253         https://bugs.webkit.org/show_bug.cgi?id=114554
 254
 255         Reviewed by Gyuyoung Kim.
 256
 257         Using variables as target names is very uncommon in CMake.
 258         The usual way to specify the name of the resulting binary
 259         is to set the OUTPUT_NAME target property.
 260
 261         * DumpRenderTree/efl/CMakeLists.txt:
 262         * EWebLauncher/CMakeLists.txt:
 263         * ImageDiff/CMakeLists.txt:
 264         * MiniBrowser/efl/CMakeLists.txt:
 265         * TestWebKitAPI/CMakeLists.txt:
 266         * WebKitTestRunner/CMakeLists.txt:
 267         * WebKitTestRunner/PlatformEfl.cmake:
 268         * WinCELauncher/CMakeLists.txt:
 269
 270 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 271
 272         Unreviewed EFL build fix.
 273
 274         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
 275         WK2 build after r150305.
 276
 277         * Scripts/webkitperl/FeatureList.pm:
 278
 279 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
 280
 281         [GTK] Parallel build fails if gtk-doc is enabled
 282         https://bugs.webkit.org/show_bug.cgi?id=116227
 283
 284         Reviewed by Martin Robinson.
 285
 286         * GNUmakefile.am:
 287         Don't use the 'all' target to generate the documentation.
 288         The prerequisites of this target must be files that need to be
 289         built _before_ the actual compilation of WebKit starts. Since the
 290         documentation depends on WebKit being built first, this means in
 291         practice that the code will be built in parallel with the
 292         generation of its dependencies, potentially making the build fail.
 293
 294 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 295
 296         Don't run hg.
 297
 298         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 299         (TestImporterTest):
 300
 301 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
 302
 303         Create a script to import W3C tests
 304         https://bugs.webkit.org/show_bug.cgi?id=111513
 305
 306         Reviewed by Ryosuke Niwa.
 307
 308         This patch attempts to re-land the 'import-w3c-tests'
 309         script and accompanying modules.  The tests and code have
 310         been cleaned up so that we do not log anything to stdout/stderr
 311         while running the tests (thanks to outputcapture) and do not
 312         write into the source tree while running the tests, and much
 313         but not all of the code has been converted over to using the webkitpy
 314
 315         * Scripts/import-w3c-tests: Added.
 316         * Scripts/webkitpy/w3c/__init__.py: Added.
 317         * Scripts/webkitpy/w3c/test_converter.py: Added.
 318         (W3CTestConverter):
 319         (W3CTestConverter.__init__):
 320         (W3CTestConverter.path_from_webkit_root):
 321         (W3CTestConverter.read_webkit_prefixed_css_property_list):
 322         (W3CTestConverter.convert_for_webkit):
 323         (W3CTestConverter.convert_css):
 324         (W3CTestConverter.convert_html):
 325         (W3CTestConverter.convert_testharness_paths):
 326         (W3CTestConverter.convert_prefixed_properties):
 327         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
 328         (W3CTestConverter.replace_tag):
 329         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
 330         (W3CTestConverterTest):
 331         (W3CTestConverterTest.fake_dir_path):
 332         (W3CTestConverterTest.test_read_prefixed_property_list):
 333         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
 334         (test_convert_for_webkit_harness_only):
 335         (test_convert_for_webkit_properties_only):
 336         (test_convert_for_webkit_harness_and_properties):
 337         (test_convert_test_harness_paths):
 338         (test_convert_prefixed_properties):
 339         (verify_conversion_happened):
 340         (verify_no_conversion_happened):
 341         (verify_test_harness_paths):
 342         (verify_prefixed_properties):
 343         (generate_test_content):
 344         * Scripts/webkitpy/w3c/test_importer.py: Added.
 345         (main):
 346         (parse_args):
 347         (validate_import_directory):
 348         (TestImporter):
 349         (TestImporter.__init__):
 350         (TestImporter.path_from_webkit_root):
 351         (TestImporter.do_import):
 352         (TestImporter.load_changeset):
 353         (TestImporter.find_importable_tests):
 354         (TestImporter.import_tests):
 355         (TestImporter.setup_destination_directory):
 356         (TestImporter.update_test_status):
 357         (TestImporter.remove_deleted_files):
 358         (TestImporter.write_import_log):
 359         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
 360         (TestImporterTest):
 361         (TestImporterTest.test_import_dir_with_no_tests):
 362         * Scripts/webkitpy/w3c/test_parser.py: Added.
 363         (TestParser):
 364         (TestParser.__init__):
 365         (TestParser.load_file):
 366         (TestParser.analyze_test):
 367         (TestParser.reference_links_of_type):
 368         (TestParser.is_jstest):
 369         (TestParser.support_files):
 370         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
 371         (TestParserTest):
 372         (TestParserTest.test_analyze_test_reftest_one_match):
 373         (test_analyze_test_reftest_multiple_matches):
 374         (test_analyze_test_reftest_match_and_mismatch):
 375         (test_analyze_test_reftest_with_ref_support_Files):
 376         (test_analyze_jstest):
 377         (test_analyze_pixel_test_all_true):
 378         (test_analyze_pixel_test_all_false):
 379         (test_analyze_non_html_file):
 380
 381 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 382
 383         Leaks builders exit early frequently
 384         https://bugs.webkit.org/show_bug.cgi?id=116355
 385
 386         Reviewed by Stephanie Lewis.
 387
 388         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
 389         we tolerate from 20 to 50.
 390
 391         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 392         (RunWebKitTests.start):
 393         * Scripts/webkitpy/port/mac.py:
 394         (MacPort.default_child_processes):
 395
 396 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
 397
 398         Remove chrome-channels command from the webkit-patch
 399         https://bugs.webkit.org/show_bug.cgi?id=116303
 400
 401         Reviewed by Ryosuke Niwa.
 402
 403         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
 404         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
 405         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
 406         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
 407         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
 408         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
 409
 410 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 411
 412         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
 413         Part 3 of 3: <http://webkit.org/b/116247>
 414
 415         Reviewed by Benjamin Poulain.
 416
 417         * Scripts/filter-build-webkit: Change while() loop to for() loop
 418         to track $previousLine, then pass $previousLine into
 419         shouldIgnoreLine().
 420         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
 421         line that begins with four spaces if the previous line is a
 422         linker error message.
 423         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
 424         - Add "Ignored: " to test descriptions to document expected
 425           behavior.
 426         - Add comment blocks for various groups of tests.
 427         - Expand "Build settings" tests since we're changing the code in
 428           shouldIgnoreLine() that ignores those lines.
 429         - Add tests for undefined symbols error message.
 430         (description): Add.  Extract from global code.
 431
 432 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 433
 434         Add tests for shouldIgnoreLine() in filter-build-webkit
 435         Part 2 of 3: <http://webkit.org/b/116247>
 436
 437         Reviewed by Benjamin Poulain.
 438
 439         * Scripts/filter-build-webkit:
 440         (shouldIgnoreLine): Add.  Extract code from global scope into
 441         subroutine to make it testable.
 442         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
 443         Tests shouldIgnoreLine() using output from a real build
 444         transcript.
 445
 446 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 447
 448         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
 449         https://bugs.webkit.org/show_bug.cgi?id=116341
 450
 451         Reviewed by Brady Eidson.
 452
 453         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
 454
 455 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
 456
 457         [Windows] Don't use pdevenv when building with VS2010.
 458         https://bugs.webkit.org/show_bug.cgi?id=116338.
 459
 460         Reviewed by Adam Roben.
 461
 462         * Scripts/webkitdirs.pm:
 463         (setupCygwinEnv): Check if we are using VS2005, and only use
 464         the 'pdevenv' hack if we are. Otherwise, just build with
 465         our standard project since it uses VS2010+'s native
 466         parallel building features.
 467
 468 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 469
 470         Unreviewed. Disable accelerated compositing until we figure out why it does not work
 471         properly in the 64 bits release bot.
 472
 473         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 474         (resetDefaultsToConsistentValues):
 475
 476 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 477
 478         Make filter-build-webkit testable using LoadAsModule
 479         Part 1 of 3: <http://webkit.org/b/116247>
 480
 481         Reviewed by Benjamin Poulain.
 482
 483         * Scripts/filter-build-webkit: Change global variables that are
 484         used in subroutines from 'my' to 'our' to make it possible to
 485         evaluate the script in a package context in LoadAsModule.pm.
 486
 487 2013-05-14  Sam Weinig  <sam@webkit.org>
 488
 489         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
 490         https://bugs.webkit.org/show_bug.cgi?id=116132
 491
 492         Reviewed by Anders Carlsson.
 493
 494         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
 495         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
 496
 497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 498         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
 499         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
 500         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 501
 502 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
 503
 504         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
 505         https://bugs.webkit.org/show_bug.cgi?id=114781
 506
 507         Reviewed by Christophe Dumez.
 508
 509         Add run_before_unload_confirm and
 510         Print the log message with "CONFIRM NAVIGATION: " in console.
 511
 512         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
 513         (onBeforeUnloadConfirm):
 514         (drtViewAdd):
 515
 516 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
 517
 518         Fix Analyze ChangeLog's entry processing
 519         https://bugs.webkit.org/show_bug.cgi?id=116219
 520
 521         Reviewed by Ryosuke Niwa.
 522
 523         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
 524         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
 525
 526 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
 527
 528         [Qt] UrlLoader::loadNext is broken in MiniBrowser
 529         https://bugs.webkit.org/show_bug.cgi?id=116099
 530
 531         Reviewed by Jocelyn Turcotte.
 532
 533         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
 534         are not available any more. So, UrlLoader::loadNext was broken
 535         because it failed to connect to those signals.
 536
 537         * MiniBrowser/qt/UrlLoader.cpp:
 538         (UrlLoader::UrlLoader):
 539         (UrlLoader::loadingChanged):
 540         * MiniBrowser/qt/UrlLoader.h:
 541         (UrlLoader):
 542
 543 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
 544
 545         [WebSocket] Update pywebsocket to r760
 546         https://bugs.webkit.org/show_bug.cgi?id=115863
 547
 548         Reviewed by Alexey Proskuryakov.
 549
 550         Version r760 supports a newer draft of message compression.
 551         We need this update to finish the permessage compression patch in
 552         bug 98840. This patch also fixes failing unit tests after the update.
 553
 554         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
 555         (StreamBase._read):
 556         (StreamBase._read.of):
 557         (StreamBase._write):
 558         (StreamBase.receive_bytes):
 559         (StreamBase._read_until):
 560         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
 561         (parse_frame):
 562         (StreamOptions.__init__):
 563         (Stream.__init__):
 564         (Stream._receive_frame_as_frame_object):
 565         (Stream._get_message_from_frame):
 566         (Stream._process_close_message):
 567         (Stream.close_connection):
 568         (Stream.get_last_received_opcode):
 569         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
 570         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
 571         (Dispatcher.do_extra_handshake):
 572         (Dispatcher.transfer_data):
 573         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
 574         (ExtensionProcessorInterface.__init__):
 575         (ExtensionProcessorInterface.request):
 576         (ExtensionProcessorInterface):
 577         (ExtensionProcessorInterface.name):
 578         (ExtensionProcessorInterface.check_consistency_with_other_processors):
 579         (ExtensionProcessorInterface.set_active):
 580         (ExtensionProcessorInterface.is_active):
 581         (ExtensionProcessorInterface._get_extension_response_internal):
 582         (ExtensionProcessorInterface.get_extension_response):
 583         (ExtensionProcessorInterface._setup_stream_options_internal):
 584         (ExtensionProcessorInterface.setup_stream_options):
 585         (_log_outgoing_compression_ratio):
 586         (_log_incoming_compression_ratio):
 587         (_parse_window_bits):
 588         (_AverageRatioCalculator):
 589         (_AverageRatioCalculator.__init__):
 590         (_AverageRatioCalculator.add_original_bytes):
 591         (_AverageRatioCalculator.add_result_bytes):
 592         (_AverageRatioCalculator.get_average_ratio):
 593         (DeflateFrameExtensionProcessor):
 594         (DeflateFrameExtensionProcessor.__init__):
 595         (DeflateFrameExtensionProcessor._get_extension_response_internal):
 596         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
 597         (DeflateFrameExtensionProcessor._outgoing_filter):
 598         (DeflateFrameExtensionProcessor._incoming_filter):
 599         (CompressionExtensionProcessorBase.for):
 600         (CompressionExtensionProcessorBase.__init__):
 601         (CompressionExtensionProcessorBase._get_extension_response_internal):
 602         (CompressionExtensionProcessorBase._setup_stream_options_internal):
 603         (PerFrameCompressExtensionProcessor):
 604         (PerMessageDeflateExtensionProcessor):
 605         (PerMessageDeflateExtensionProcessor.__init__):
 606         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
 607         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
 608         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
 609         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
 610         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
 611         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
 612         (PerMessageDeflateExtensionProcessor.set_bfinal):
 613         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
 614         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
 615         (_PerMessageDeflateFramer):
 616         (_PerMessageDeflateFramer.__init__):
 617         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
 618         (_PerMessageDeflateFramer._process_incoming_message):
 619         (_PerMessageDeflateFramer._process_outgoing_message):
 620         (_PerMessageDeflateFramer.setup_stream_options):
 621         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
 622         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
 623         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
 624         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
 625         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
 626         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
 627         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
 628         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
 629         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
 630         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
 631         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
 632         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
 633         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
 634         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
 635         (PerMessageCompressExtensionProcessor):
 636         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
 637         (MuxExtensionProcessor.__init__):
 638         (MuxExtensionProcessor.check_consistency_with_other_processors):
 639         (MuxExtensionProcessor):
 640         (MuxExtensionProcessor._get_extension_response_internal):
 641         (MuxExtensionProcessor._setup_stream_options_internal):
 642         (MuxExtensionProcessor.set_quota):
 643         (MuxExtensionProcessor.quota):
 644         (MuxExtensionProcessor.set_extensions):
 645         (MuxExtensionProcessor.extensions):
 646         (is_compression_extension):
 647         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
 648         (validate_subprotocol):
 649         (parse_host_header):
 650         (format_header):
 651         (check_request_line):
 652         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
 653         (Handshaker.do_handshake):
 654         (Handshaker._create_handshake_response):
 655         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
 656         (_validate_subprotocol):
 657         (_check_header_lines):
 658         (_build_location):
 659         (Handshaker.do_handshake):
 660         (Handshaker._set_subprotocol):
 661         (Handshaker._set_location):
 662         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
 663         (_create_dispatcher):
 664         (headerparserhandler):
 665         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
 666         (_create_add_channel_response):
 667         (_create_drop_channel):
 668         (_create_flow_control):
 669         (_create_new_channel_slot):
 670         (_create_fallback_new_channel_slot):
 671         (_MuxFramePayloadParser._read_number):
 672         (_MuxFramePayloadParser._read_size_and_contents):
 673         (_MuxFramePayloadParser._read_flow_control):
 674         (_MuxFramePayloadParser._read_new_channel_slot):
 675         (_LogicalConnection.__init__):
 676         (_LogicalConnection.write):
 677         (_LogicalConnection.on_write_data_done):
 678         (_LogicalConnection):
 679         (_LogicalConnection.on_writer_done):
 680         (_InnerMessage):
 681         (_InnerMessage.__init__):
 682         (_InnerMessageBuilder):
 683         (_InnerMessageBuilder.that):
 684         (_InnerMessageBuilder.__init__):
 685         (_InnerMessageBuilder._handle_first):
 686         (_InnerMessageBuilder._process_first_fragmented_control):
 687         (_InnerMessageBuilder._process_first_fragmented_message):
 688         (_InnerMessageBuilder._handle_fragmented_control):
 689         (_InnerMessageBuilder._reassemble_fragmented_control):
 690         (_InnerMessageBuilder._handle_fragmented_message):
 691         (_InnerMessageBuilder._reassemble_fragmented_message):
 692         (_InnerMessageBuilder.build):
 693         (_LogicalStream.__init__):
 694         (_LogicalStream._create_inner_frame):
 695         (_LogicalStream._write_inner_frame):
 696         (_LogicalStream.replenish_send_quota):
 697         (_LogicalStream.send_message):
 698         (_LogicalStream._receive_frame):
 699         (_LogicalStream._get_message_from_frame):
 700         (_LogicalStream.stop_sending):
 701         (_PhysicalConnectionWriter.__init__):
 702         (_PhysicalConnectionWriter._write_data):
 703         (_PhysicalConnectionWriter.run):
 704         (_PhysicalConnectionWriter.stop):
 705         (_Worker.run):
 706         (_MuxHandshaker.__init__):
 707         (_MuxHandshaker._create_stream):
 708         (_MuxHandshaker._create_handshake_response):
 709         (_HandshakeDeltaBase.create_headers):
 710         (_MuxHandler.start):
 711         (_MuxHandler.wait_until_done):
 712         (_MuxHandler.notify_write_data_done):
 713         (_MuxHandler._process_drop_channel):
 714         (_MuxHandler._process_logical_frame):
 715         (_MuxHandler.notify_reader_done):
 716         (_MuxHandler):
 717         (_MuxHandler.notify_writer_done):
 718         (_MuxHandler.fail_physical_connection):
 719         (_MuxHandler.fail_logical_channel):
 720         (use_mux):
 721         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
 722         (_StandaloneRequest.get_uri):
 723         (_StandaloneRequest.get_unparsed_uri):
 724         (_StandaloneRequest):
 725         (_StandaloneRequest.is_https):
 726         (_import_ssl):
 727         (_import_pyopenssl):
 728         (_StandaloneSSLConnection.for):
 729         (_StandaloneSSLConnection):
 730         (_StandaloneSSLConnection.__getattribute__):
 731         (_StandaloneSSLConnection.__setattr__):
 732         (_StandaloneSSLConnection.makefile):
 733         (_StandaloneSSLConnection.shutdown):
 734         (_StandaloneSSLConnection.recv):
 735         (WebSocketServer.__init__):
 736         (WebSocketServer._create_sockets):
 737         (WebSocketServer.handle_error):
 738         (WebSocketServer.get_request):
 739         (WebSocketServer.get_request.default_callback):
 740         (WebSocketRequestHandler.parse_request):
 741         (_build_option_parser):
 742         (_main):
 743         (_main.if):
 744         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
 745         (RepeatedXorMasker.__init__):
 746         (RepeatedXorMasker._mask_using_swig):
 747         (RepeatedXorMasker):
 748         (RepeatedXorMasker._mask_using_array):
 749         (_Deflater.compress_and_finish):
 750         (_RFC1979Deflater.filter):
 751         (DeflateSocket.send):
 752
 753 2013-05-16  Jonathan Liu  <net147@gmail.com>
 754
 755         Fix testing if program exists in PATH
 756         https://bugs.webkit.org/show_bug.cgi?id=116216
 757
 758         Reviewed by Jocelyn Turcotte.
 759
 760         functions.prf incorrectly uses win_cmd_shell to test whether to
 761         add .exe to the executable name when checking if it exists in
 762         the PATH environment variable. This works correctly when
 763         building using Windows Command Prompt but not under MSYS shell.
 764
 765         To resolve this, check the win32 platform scope instead of
 766         win_cmd_shell so that it correctly adds .exe to the executable
 767         name on Windows regardless of the shell used when testing if
 768         it exists in PATH.
 769
 770         * qmake/mkspecs/features/functions.prf:
 771
 772 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
 773
 774         Fix the hard-coded names of EWS bots that run tests.
 775
 776         * Scripts/webkitpy/tool/commands/queues.py:
 777         (CommitQueue.did_pass_testing_ews):
 778
 779 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 780
 781         [GTK] Build Xvfb with jhbuild
 782         https://bugs.webkit.org/show_bug.cgi?id=115907
 783
 784         Reviewed by Martin Robinson.
 785
 786         Build our own Xvfb so that we can avoid problems with the system Xvfb
 787         relying on symbols not present in our jhbuilt libraries such as pixman,
 788         and also to ensure we have the fix for a GLX module crasher.
 789
 790         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 791         (resetDefaultsToConsistentValues): enable accelerated compositing.
 792         * gtk/install-dependencies: list packages required for building Xvfb.
 793         * gtk/jhbuild.modules: add xserver as a jhbuild module.
 794         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
 795         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
 796         initializing the GLX module for Xvfb.
 797
 798 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 799
 800         [jhbuild] Should remove the sources directory as well when cleaning
 801         https://bugs.webkit.org/show_bug.cgi?id=116229
 802
 803         Reviewed by Martin Robinson.
 804
 805         * Scripts/update-webkit-libs-jhbuild:
 806         (cleanJhbuild): remove the Source directory as well when cleaning.
 807
 808 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
 809
 810         [EFL] Remove Intel Wk2 Buildbots from Master
 811         https://bugs.webkit.org/show_bug.cgi?id=116149
 812
 813         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
 814         since Gyuyoung Kim from Samsung plans to take over and maintain it.
 815
 816         Reviewed by Benjamin Poulain.
 817
 818         * BuildSlaveSupport/build.webkit.org-config/config.json:
 819
 820 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
 821
 822         [Windows] Update various build tools to understand VS2010 environment.
 823         https://bugs.webkit.org/show_bug.cgi?id=116169.
 824
 825         Reviewed by Anders Carlsson.
 826
 827         * Scripts/build-api-tests: Identify VS2010 environment.
 828         * Scripts/build-dumprendertree: Ditto.
 829         * Scripts/build-webkit: Ditto.
 830         * Scripts/webkitdirs.pm:
 831         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
 832         range of acceptable SDK's.
 833
 834 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
 835
 836         Allow http tests on Arch Linux
 837         https://bugs.webkit.org/show_bug.cgi?id=116155
 838
 839         Reviewed by Ryosuke Niwa.
 840
 841         * Scripts/webkitpy/port/base.py:
 842         (Port._is_arch_based): Added check for /etc/arch-release file.
 843         (Port._apache_config_file_name_for_platform): Call the check.
 844         * Scripts/webkitpy/port/port_testcase.py:
 845         (test_linux_distro_detection): Testcase added.
 846
 847 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
 848
 849         Remove a leftover v8 file from the watchlist
 850         https://bugs.webkit.org/show_bug.cgi?id=116158
 851
 852         Reviewed by Csaba Osztrogonác.
 853
 854         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
 855
 856 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
 857
 858         [GTK] Fails to build while generating gtkdoc
 859         https://bugs.webkit.org/show_bug.cgi?id=115612
 860
 861         Reviewed by Philippe Normand.
 862
 863         Fix typo in the prerequisites of docs-build.stamp.
 864
 865         * GNUmakefile.am:
 866
 867 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
 868
 869         Unreviewed, fixing the current test-webkitpy failure.
 870
 871         * Scripts/webkitpy/port/mac_unittest.py:
 872         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
 873         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
 874
 875 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
 876
 877         Fix build after r150090.
 878         https://bugs.webkit.org/show_bug.cgi?id=116129
 879
 880         Unreviewed build fix after r150090.
 881
 882         * WebKitTestRunner/TestInvocation.cpp:
 883         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
 884
 885 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
 886
 887         [Windows, others] Unreviewed build fix after r150090.
 888
 889         * DumpRenderTree/TestRunner.cpp:
 890         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
 891         doesn't exist on other platforms.
 892
 893 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
 894
 895         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
 896         https://bugs.webkit.org/show_bug.cgi?id=115889
 897
 898         Reviewed by Benjamin Poulain.
 899
 900         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
 901         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
 902
 903 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
 904
 905         [Windows] Identify proper run environment for scripts.
 906         https://bugs.webkit.org/show_bug.cgi?id=116114
 907
 908         Reviewed by David Kilzer.
 909
 910         Determine (based on Visual Studio version) which path to use for
 911         executables (bin versus bin32).
 912
 913         * Scripts/webkitdirs.pm:
 914         (determineVisualStudioInstallDir): Added.
 915         (determineVisualStudioVersion): Added.
 916         (determineConfigurationProductDir): Modified to choose proper bin
 917         or bin32 directory.
 918         (visualStudioVersion): Added
 919         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
 920
 921 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
 922
 923         [Mac] Add tests for secure event input
 924         https://bugs.webkit.org/show_bug.cgi?id=116121
 925
 926         Reviewed by Mark Rowe.
 927
 928         * DumpRenderTree/TestRunner.cpp:
 929         (getSecureEventInputIsEnabledCallback):
 930         (TestRunner::staticValues):
 931         Expose an accessor for current secure event input state.
 932
 933         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 934         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 935         (WTR::TestRunner::secureEventInputIsEnabled):
 936         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 937         * WebKitTestRunner/TestInvocation.cpp:
 938         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
 939         Expose an accessor for current secure event input state. This has to be done in
 940         UI process, as this is where it's changed by WebKit.
 941
 942 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
 943
 944         [Mac] Add a testing shim for secure event input functions
 945         https://bugs.webkit.org/show_bug.cgi?id=116122
 946
 947         Reviewed by Mark Rowe.
 948
 949         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
 950         Inject WebCore testing shim library to override system framework functions.
 951
 952 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
 953
 954         [Windows] Switch to embedded manifest commands for launcher executables.
 955         https://bugs.webkit.org/show_bug.cgi?id=116109
 956
 957         Reviewed by Darin Adler.
 958
 959         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
 960         now-unused WinLauncher.exe.manifest file.
 961         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
 962         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
 963         when building with VS2010 or newer.
 964
 965 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
 966
 967         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
 968         https://bugs.webkit.org/show_bug.cgi?id=116079
 969
 970         Reviewed by David Kilzer.
 971
 972         * Scripts/old-run-webkit-tests:
 973         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
 974
 975 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
 976
 977         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
 978         https://bugs.webkit.org/show_bug.cgi?id=115921
 979
 980         Reviewed by Gustavo Noronha Silva.
 981
 982         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
 983         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
 984
 985 2013-05-13  Alex Christensen  <achristensen@apple.com>
 986
 987         Added testRunner.setPrinting.
 988         https://bugs.webkit.org/show_bug.cgi?id=42693
 989         rdar://problem/8213845
 990
 991         Reviewed by Darin Adler.
 992
 993         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 994         Added setPrinting JavaScript function.
 995         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 996         (WTR::InjectedBundlePage::dump):
 997         Dump the external representation for printing if setPrinting has been called.
 998         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 999         (WTR::TestRunner::isPrinting): Added.
1000         (WTR::TestRunner::setPrinting): Added.
1001         Added and initialized m_isPrinting member boolean.
1002
1003 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1004
1005         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1006         https://bugs.webkit.org/show_bug.cgi?id=116016
1007
1008         Reviewed by Dirk Pranke.
1009
1010         Same fix as in the upstream style checker, but without hg support.
1011         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1012
1013         * Scripts/webkitpy/style/checkers/cpp.py:
1014         (FileInfo.repository_name):
1015
1016 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1017
1018         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1019         https://bugs.webkit.org/show_bug.cgi?id=115918
1020
1021         Reviewed by Gustavo Noronha Silva.
1022
1023         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1024         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1025         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1026         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1027         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1028         problems.
1029
1030         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1031         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1032         file paths are constructed and then used to dump the member files from these archives. The member files are
1033         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1034         successfully link.
1035
1036         * TestWebKitAPI/GNUmakefile.am:
1037
1038 2013-05-13  Anders Carlsson  <andersca@apple.com>
1039
1040         Remove UnusedParam.h
1041         https://bugs.webkit.org/show_bug.cgi?id=116029
1042
1043         Reviewed by Andreas Kling.
1044
1045         Stop including UnusedParam.h.
1046
1047         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1048         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1049
1050 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1051
1052         Unreviewed, rolling out r149955.
1053         http://trac.webkit.org/changeset/149955
1054         https://bugs.webkit.org/show_bug.cgi?id=115990
1055
1056         Broke lots of tests (Requested by smfr on #webkit).
1057
1058         * Scripts/webkitpy/port/mac.py:
1059
1060 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1061
1062         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1063         https://bugs.webkit.org/show_bug.cgi?id=115914
1064
1065         Reviewed by Martin Robinson.
1066
1067         * GtkLauncher/main.c:
1068         (createToolbar):
1069         * MiniBrowser/gtk/BrowserWindow.c:
1070         (_BrowserWindow):
1071         (browserWindowSetStatusText):
1072         (fullScreenMessageTimeoutCallback):
1073         (webViewEnterFullScreen):
1074         (webViewLeaveFullScreen):
1075         (browserWindowFinalize):
1076         (browserWindowConstructed):
1077         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1078         (WTR::EventSenderProxy::mouseScrollBy):
1079         (WTR::EventSenderProxy::continuousMouseScrollBy):
1080
1081 2013-05-11  Anders Carlsson  <andersca@apple.com>
1082
1083         Crash when terminating a process that has not been fully launched
1084         https://bugs.webkit.org/show_bug.cgi?id=115962
1085         <rdar://problem/13660916>
1086
1087         Reviewed by Andreas Kling.
1088
1089         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1090         before the process has had a chance to be fully launched.
1091
1092         * TestWebKitAPI/GNUmakefile.am:
1093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1094         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1095         (TestWebKitAPI):
1096         (TestWebKitAPI::didFinishLoadForFrame):
1097         (TestWebKitAPI::TEST):
1098         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1099
1100 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1101
1102         Remove Mac OS X Leopard (10.5) support
1103         https://bugs.webkit.org/show_bug.cgi?id=107964
1104
1105         Reviewed by Ryosuke Niwa.
1106
1107         Removed the code for 10.5 and removed if-def for 10.6.
1108
1109         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1110         (convertMIMEType):
1111         (createXMLStringFromWebArchiveData):
1112         * DumpRenderTree/mac/TestRunnerMac.mm:
1113         (TestRunner::authenticateSession):
1114         (TestRunner::setTextDirection):
1115         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1116         (convertMIMEType):
1117         (createXMLStringFromWebArchiveData):
1118
1119 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1120
1121         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1122         https://bugs.webkit.org/show_bug.cgi?id=115935
1123
1124         Reviewed by Jer Noble.
1125
1126         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1127         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1128         to the new manifest file.
1129         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1130
1131 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1132
1133         Fix some compiler warnings (miscellaneous)
1134         https://bugs.webkit.org/show_bug.cgi?id=80790
1135
1136         Reviewed by Rob Buis.
1137
1138         Fix the following warnings for BlackBerry:
1139         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1140         used as truth value [-Wparentheses].
1141
1142         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1143         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1144
1145 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1146
1147         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1148         https://bugs.webkit.org/show_bug.cgi?id=115928
1149
1150         Reviewed by Kenneth Rohde Christiansen.
1151
1152         WKViewSetThemePath was moved to WKViewEfl.h.
1153
1154         * TestWebKitAPI/efl/PlatformWebView.cpp:
1155
1156 2013-05-10  Andreas Kling  <akling@apple.com>
1157
1158         I accidentally the Java testing.
1159
1160         * Scripts/webkitpy/port/mac.py:
1161
1162 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1163
1164         [GTK] Module Cairo fails to build under jhbuild
1165         https://bugs.webkit.org/show_bug.cgi?id=115854
1166
1167         Reviewed by Martin Robinson.
1168
1169         Make cairo depend on glib in jhbuild.modules.
1170
1171         * gtk/jhbuild.modules:
1172
1173 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1174
1175         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1176         https://bugs.webkit.org/show_bug.cgi?id=115904
1177
1178         Reviewed by Martin Robinson.
1179
1180         * ImageDiff/gtk/ImageDiff.cpp:
1181         (main):
1182
1183 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1184
1185         Add my new address to contributors.json. (Unreviewed)
1186
1187         * Scripts/webkitpy/common/config/contributors.json:
1188
1189 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1190
1191         Unreviewed. Move myself to the reviewers list.
1192
1193         * Scripts/webkitpy/common/config/contributors.json:
1194
1195 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1196
1197         Unreviewed. Add my email to a few watchlists.
1198
1199         * Scripts/webkitpy/common/config/watchlist:
1200
1201 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1202
1203         Unicode support missing from string representation of Contributors in committers.py
1204         https://bugs.webkit.org/show_bug.cgi?id=115859
1205
1206         Reviewed by Darin Adler.
1207
1208         Contributors, in committers.py, provided a string representation in __str__ which
1209         didn't support unicode characters, so printing a contributor would fail in that case.
1210         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1211         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1212
1213         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1214         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1215         representation.
1216         (Contributor.__str__):
1217         (Contributor):
1218         (Contributor.__unicode__):
1219         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1220         a contributor with unicode characters can be represented as a string.
1221         (CommittersTest):
1222         (CommittersTest.test_contributor_encoding):
1223
1224 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1225
1226         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1227         https://bugs.webkit.org/show_bug.cgi?id=92371
1228
1229         Reviewed by Brent Fulgham.
1230
1231         Use JavaScriptThreading.cpp where the same functionality is
1232         implemented too. This reduces the dependency on the pthread
1233         library. Also replace assert() with WebKit ASSERT().
1234
1235         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1236         * DumpRenderTree/win/DumpRenderTree.cpp:
1237         (dumpHistoryItem):
1238         (dumpBackForwardList):
1239         * DumpRenderTree/win/DumpRenderTree.vcproj:
1240
1241 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1242
1243         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1244         https://bugs.webkit.org/show_bug.cgi?id=92505
1245
1246         Reviewed by Brent Fulgham.
1247
1248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1249         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1250         (javaScriptThreadsMutex):
1251         (javaScriptThreads):
1252         (runJavaScriptThread):
1253         (startJavaScriptThreads):
1254         (stopJavaScriptThreads):
1255         * DumpRenderTree/pthreads: Removed.
1256         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1257
1258 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1259
1260         Unreviewed. Update Simon Pena email on his behalf.
1261
1262         * Scripts/webkitpy/common/config/contributors.json:
1263
1264 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1265
1266         Add support for [NoInterfaceObject] Web IDL extended attribute
1267         https://bugs.webkit.org/show_bug.cgi?id=115714
1268
1269         Reviewed by Kentaro Hara.
1270
1271         Update BindingsTests.generate_supplemental_dependency() to pass an
1272         additional windowConstructorsFile argument to preprocess-idls.pl.
1273
1274         * Scripts/webkitpy/bindings/main.py:
1275         (BindingsTests.generate_supplemental_dependency):
1276         (BindingsTests.main):
1277
1278 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1279
1280         [GTK][AC] Buildfix after r149694
1281         https://bugs.webkit.org/show_bug.cgi?id=115797
1282
1283         Reviewed by Gustavo Noronha Silva.
1284
1285         Add CLUTTER_LIBS for linking TestWebCore.
1286
1287         * TestWebKitAPI/GNUmakefile.am:
1288
1289 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1290
1291         [EFL] Remove unnecessary pkgs in EFL jhbuild
1292         https://bugs.webkit.org/show_bug.cgi?id=114908
1293
1294         Reviewed by Laszlo Gombos.
1295
1296         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1297         handle them using jhbuild. We can reduce build time when using --update-efl.
1298
1299         * efl/jhbuild.modules:
1300
1301 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1302
1303         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1304         https://bugs.webkit.org/show_bug.cgi?id=115834
1305
1306         Reviewed by Gyuyoung Kim.
1307
1308         * Scripts/webkitperl/FeatureList.pm:
1309
1310 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1311
1312         Add Scheduler for Mac MtnLion 32bit Release builder.
1313
1314         Unreviewed.
1315
1316         * BuildSlaveSupport/build.webkit.org-config/config.json:
1317
1318 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1319
1320         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1321         https://bugs.webkit.org/show_bug.cgi?id=115808
1322
1323         Reviewed by Darin Adler.
1324
1325         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1326         was left outdated after r127191, when the m_string member was changed
1327         from UString to String. This patch calls the right pretty printer for it.
1328
1329         * gdb/webkit.py:
1330         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1331         WTFImplPrettyPrinter.
1332
1333 2013-05-08  Andy Estes  <aestes@apple.com>
1334
1335         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1336         https://bugs.webkit.org/show_bug.cgi?id=115790
1337
1338         Reviewed by Alexey Proskuryakov.
1339
1340         Added two API tests:
1341
1342         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1343         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1344
1345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1346         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1347         (TestWebKitAPI):
1348         (TestWebKitAPI::TEST):
1349         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1350         (TestWebKitAPI):
1351         (TestWebKitAPI::decidePolicyForNavigationAction):
1352         (CustomProtocolInvalidSchemeTest):
1353         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1354
1355 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1356
1357         Teach buildbot how to compile 32-bit on Mac.
1358
1359         Reviewed by Ryosuke Niwa.
1360
1361         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1362         (CompileWebKit.start):
1363         (ExtractTestResultsAndLeaks):
1364
1365 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1366
1367         [BlackBerry] Fix usage of BlackBerry::Platform::String
1368         https://bugs.webkit.org/show_bug.cgi?id=115781
1369
1370         Reviewed by Rob Buis.
1371
1372         BlackBerry PRs 304193 and 327181
1373         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1374
1375         We currently have a problem where we're passing UTF-8 encoded data into
1376         the char* constructors of BlackBerry::Platform::String. This means the string
1377         thinks its data is not UTF-8.
1378
1379         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1380         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1381         (BlackBerry::WebKit::dumpHistoryItem):
1382         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1383         (TestRunner::setUserStyleSheetLocation):
1384         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1385         (LoadHTMLStringItem::invoke):
1386
1387 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1388
1389         Tools: add new BlackBerry include dirs.
1390         https://bugs.webkit.org/show_bug.cgi?id=115514
1391
1392         Reviewed by Rob Buis.
1393
1394         iType include dirs are missing, and HarfBuzz needs to be fixed.
1395
1396         * Scripts/webkitdirs.pm:
1397         (blackberryCMakeArguments):
1398
1399 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1400
1401         [GTK] Plumb the Automake build system for the Battery Status API feature
1402         https://bugs.webkit.org/show_bug.cgi?id=115718
1403
1404         Reviewed by Martin Robinson.
1405
1406         * Scripts/webkitdirs.pm:
1407         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1408         through the --(enable|disable)-battery-status flag passed to configure.
1409
1410 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1411
1412         new-run-webkit-websocketserver doesn't work after Chromium removal
1413         https://bugs.webkit.org/show_bug.cgi?id=115816
1414
1415         Reviewed by Joseph Pecoraro.
1416
1417         Fix the bug by instantiating the correct port object.
1418
1419         * Scripts/new-run-webkit-websocketserver:
1420         (main):
1421
1422 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1423
1424         Configure buildbot for 32bit builder.
1425         https://bugs.webkit.org/show_bug.cgi?id=115769
1426
1427         Reviewed by Ryosuke Niwa.
1428
1429         * BuildSlaveSupport/build.webkit.org-config/config.json:
1430
1431 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1432
1433         Unreviewed. Update to show my apple.com address.
1434
1435         * Scripts/webkitpy/common/config/contributors.json: Added
1436         my apple.com e-mail address.
1437
1438 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1439
1440         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1441
1442         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1443         (concatenateAttributeAndValue): Switch to appendVector().
1444
1445 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1446
1447         [Qt][WTR] Fix the build on Mac after r149692
1448
1449         Unreviewed build fix.
1450
1451         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1452         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1453
1454 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1455
1456         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1457         to the watchlist for Accessibility.
1458
1459         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1460         * Scripts/webkitpy/common/config/watchlist: Added myself.
1461
1462 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1463
1464         [Qt] Build fails with clang
1465         https://bugs.webkit.org/show_bug.cgi?id=115741
1466
1467         Reviewed by Benjamin Poulain.
1468
1469         Since r149112 std::move is used in AtomicString for compilers that
1470         support rvalue references and this requires a standard library
1471         implementing c++11 move semantics.
1472         We only explicitely require c++11 for WebKit2, but since clang supports
1473         rvalue references the build of subtargets using AtomicString fails because
1474         of missing std::move.
1475         It is safe to add CONFIG += c++11 for the whole project when using clang
1476         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1477
1478         * qmake/mkspecs/features/unix/default_pre.prf:
1479
1480 2013-05-08  Darin Adler  <darin@apple.com>
1481
1482         Fix one more place that needed to use adoptCF/NS
1483         https://bugs.webkit.org/show_bug.cgi?id=115778
1484
1485         Reviewed by Benjamin Poulain.
1486
1487         Not sure why I missed this code last time, but found a bit more code that needs
1488         to switch to the newer style adoptCF/NS.
1489
1490         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1491         (convertWebResourceDataToString): Use adoptCF.
1492         (convertWebResourceResponseToDictionary): Ditto.
1493         (createXMLStringFromWebArchiveData): Ditto.
1494         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1495         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1496
1497 2013-05-08  Commit Queue  <commit-queue@webkit.org>
1498
1499         Unreviewed, rolling out r149271.
1500         http://trac.webkit.org/changeset/149271
1501         https://bugs.webkit.org/show_bug.cgi?id=115780
1502
1503         The mangled symbols are now enforced through LDFLAGS
1504         (Requested by zdobersek on #webkit).
1505
1506         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1507
1508 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
1509
1510         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
1511         https://bugs.webkit.org/show_bug.cgi?id=115636
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1516         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
1517         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
1518         while Chromium-specific, can't be removed just yet as there's more code that uses it.
1519
1520 2013-05-06  Darin Adler  <darin@apple.com>
1521
1522         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
1523         https://bugs.webkit.org/show_bug.cgi?id=115657
1524
1525         Reviewed by Sam Weinig.
1526
1527         This is similar to my last set of changes, but covers code that I missed with
1528         global replace using the Safari Xcode workspace.
1529
1530         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1531         (convertWebResourceDataToString):
1532         (convertWebResourceResponseToDictionary):
1533         (createXMLStringFromWebArchiveData):
1534         * DumpRenderTree/cg/ImageDiffCG.cpp:
1535         (createImageFromStdin):
1536         (createDifferenceImage):
1537         (main):
1538         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1539         (printPNG):
1540         (dumpBitmap):
1541         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1542         (BitmapContext::BitmapContext):
1543         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1544         (-[MockWebNotificationProvider init]):
1545         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1546         (createBitmapContext):
1547         * DumpRenderTree/mac/TestRunnerMac.mm:
1548         (TestRunner::addDisallowedURL):
1549         (TestRunner::applicationCacheDiskUsageForOrigin):
1550         (TestRunner::localStorageDiskUsageForOrigin):
1551         (TestRunner::clearApplicationCacheForOrigin):
1552         (TestRunner::deleteLocalStorageForOrigin):
1553         (TestRunner::copyDecodedHostName):
1554         (TestRunner::copyEncodedHostName):
1555         (TestRunner::queueLoad):
1556         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1557         (TestRunner::setMockGeolocationPositionUnavailableError):
1558         (TestRunner::setUserStyleSheetLocation):
1559         (TestRunner::setValueForUser):
1560         (TestRunner::overridePreference):
1561         (TestRunner::setPersistentUserStyleSheetLocation):
1562         (TestRunner::execCommand):
1563         (TestRunner::findString):
1564         (TestRunner::isCommandEnabled):
1565         (TestRunner::addOriginAccessWhitelistEntry):
1566         (TestRunner::removeOriginAccessWhitelistEntry):
1567         (TestRunner::addUserScript):
1568         (TestRunner::addUserStyleSheet):
1569         (TestRunner::evaluateInWebInspector):
1570         (TestRunner::evaluateScriptInIsolatedWorld):
1571         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1572         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1573         (TestRunner::authenticateSession):
1574         (TestRunner::grantWebNotificationPermission):
1575         (TestRunner::denyWebNotificationPermission):
1576         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1577         (createCFURLResponseFromResponseData):
1578         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1579         (LoadItem::invoke):
1580         (LoadHTMLStringItem::invoke):
1581         (ScriptItem::invoke):
1582         * DumpRenderTree/win/DumpRenderTree.cpp:
1583         (substringFromIndex):
1584         (urlSuitableForTestResult):
1585         (lastPathComponent):
1586         (sharedCFURLCache):
1587         * DumpRenderTree/win/ImageDiffCairo.cpp:
1588         (createImageFromStdin):
1589         (main):
1590         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1591         (createBitmapContextFromWebView):
1592         * DumpRenderTree/win/TestRunnerWin.cpp:
1593         (TestRunner::setUserStyleSheetLocation):
1594         (TestRunner::setPersistentUserStyleSheetLocation):
1595         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1596         (TestWebKitAPI::TEST):
1597         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1598         (TestWebKitAPI::TEST):
1599         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1600         (TestWebKitAPI::TEST):
1601         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1602         (TestWebKitAPI::TEST):
1603         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1604         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1605         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1606         (TestWebKitAPI::createWindow):
1607         (TestWebKitAPI::TEST):
1608         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1609         (TestWebKitAPI::TEST):
1610         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1611         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1612         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1613         (TestWebKitAPI::TEST):
1614         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
1615         (TestWebKitAPI::TEST):
1616         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
1617         (TestWebKitAPI::TEST):
1618         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1619         (TestWebKitAPI::TEST):
1620         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
1621         (TestWebKitAPI::TEST):
1622         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1623         (TestWebKitAPI::TEST):
1624         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
1625         (TestWebKitAPI::TEST):
1626         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1627         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1628         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1629         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
1630         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1633         (TestWebKitAPI::TEST):
1634         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1635         (TestWebKitAPI::TEST):
1636         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
1637         (TestWebKitAPI::TEST):
1638         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1639         (TestWebKitAPI::TEST):
1640         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1641         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1642         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
1643         (TestWebKitAPI::TEST):
1644         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1647         (TestWebKitAPI::TEST):
1648         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
1649         (TestWebKitAPI::TEST):
1650         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1651         (TestWebKitAPI::TEST):
1652         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1653         (TestWebKitAPI::TEST):
1654         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1657         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1658         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1659         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1660         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1661         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1662         (WTR::testPathFromURL):
1663         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1664         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1665         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1666         (WTR::createCGContextFromImage):
1667         (WTR::dumpBitmap):
1668         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1669         * WebKitTestRunner/mac/EventSenderProxy.mm:
1670         (WTR::EventSenderProxy::mouseScrollBy):
1671         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1672         (WTR::PlatformWebView::windowSnapshotImage):
1673         * WebKitTestRunner/win/TestControllerWin.cpp:
1674         (WTR::TestController::initializeTestPluginDirectory):
1675         Use adoptCF and adoptNS.
1676
1677 2013-05-07  Alex Christensen  <achristensen@apple.com>
1678
1679         Fix a memory leak introduced in r149692
1680         https://bugs.webkit.org/show_bug.cgi?id=115766
1681
1682         Reviewed by Mark Rowe.
1683
1684         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
1685         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
1686
1687         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1688         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1689         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
1690
1691 2013-05-07  Darin Adler  <darin@apple.com>
1692
1693         [Win] Fix storage leak in Windows DumpRenderTree
1694         https://bugs.webkit.org/show_bug.cgi?id=115651
1695
1696         Reviewed by Sam Weinig.
1697
1698         * DumpRenderTree/win/DumpRenderTree.cpp:
1699         (lastPathComponent): Added a missing call to adoptCF.
1700
1701 2013-05-07  Alex Christensen  <achristensen@apple.com>
1702
1703         fixed a memory leak introduced by bug 42324 by using a RetainPtr
1704         https://bugs.webkit.org/show_bug.cgi?id=115760
1705
1706         Reviewed by Tim Horton.
1707
1708         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1709         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1710         fixed memory leak, added UNUSED_PARAM macros
1711
1712 2013-05-07  Alex Christensen  <achristensen@apple.com>
1713
1714         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
1715         https://bugs.webkit.org/show_bug.cgi?id=42324
1716         <rdar://problem/8193633>
1717
1718         Reviewed by Tim Horton.
1719
1720         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1721         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
1722         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1723         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1724         Added dumpDOMAsWebArchive code that is called when dumping.
1725         (WTR::InjectedBundlePage::dump):
1726         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
1727         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1728         (InjectedBundlePage):
1729         Added dumpDOMAsWebArchive declaration.
1730         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
1731         (WTR::TestRunner::dumpDOMAsWebArchive):
1732         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
1733         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1734         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
1735         * Tools/WebKitTestRunner/cf: Added.
1736         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
1737         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
1738         (convertMIMEType):
1739         (convertWebResourceDataToString):
1740         (normalizeHTTPResponseHeaderFields):
1741         (normalizeWebResourceURL):
1742         (convertWebResourceResponseToDictionary):
1743         (compareResourceURLs):
1744         (createXMLStringFromWebArchiveData):
1745         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
1746         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
1747         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
1748         Copied from Tools/DumpRenderTree/mac for used functions.
1749         (createCFURLResponseFromResponseData):
1750         (supportedNonImageMIMETypes):
1751
1752 2013-05-07  Alex Christensen  <achristensen@apple.com>
1753
1754         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
1755         https://bugs.webkit.org/show_bug.cgi?id=115745
1756
1757         Reviewed by Tim Horton.
1758
1759         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1760         (compareResourceURLs):
1761         Updated style.
1762
1763 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
1764
1765         Add an 'isReadOnly' member to IDL parse tree structure
1766         https://bugs.webkit.org/show_bug.cgi?id=115704
1767
1768         Reviewed by Kentaro Hara.
1769
1770         Use newly added isReadOnly attribute.
1771
1772         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1773         (_generateHeaderFile):
1774         (_generateImplementationFile):
1775         (_staticValuesGetterImplementation):
1776
1777 2013-05-07  Anders Carlsson  <andersca@apple.com>
1778
1779         Remove AlwaysInline.h from WTF
1780         https://bugs.webkit.org/show_bug.cgi?id=115727
1781
1782         Reviewed by Brent Fulgham.
1783
1784         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
1785         to keep AlwaysInline.h around anymore.
1786
1787         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
1788         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1789
1790 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
1791
1792         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
1793         https://bugs.webkit.org/show_bug.cgi?id=114808
1794
1795         Reviewed by Jocelyn Turcotte.
1796
1797         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
1798         (https://codereview.qt-project.org/#change,54234)
1799
1800         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1801         (WTR::WrapperWindow::handleStatusChanged):
1802
1803 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1804
1805         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
1806
1807         * Scripts/webkitpy/common/config/watchlist:
1808
1809 2013-05-06  Kangil Han  <kangil.han@samsung.com>
1810
1811         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
1812         https://bugs.webkit.org/show_bug.cgi?id=115645
1813
1814         Reviewed by Gyuyoung Kim.
1815
1816         To run performance tests in wk1, we need --no-timeout option implementation.
1817         So adopt it from gtk+ port.
1818
1819         * DumpRenderTree/efl/DumpRenderTree.cpp:
1820         (shouldSetWaitToDumpWatchdog):
1821         (parseCommandLineOptions):
1822         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1823         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1824         (TestRunner::setWaitToDump):
1825
1826 2013-05-06  Commit Queue  <commit-queue@webkit.org>
1827
1828         Unreviewed, rolling out r149547.
1829         http://trac.webkit.org/changeset/149547
1830         https://bugs.webkit.org/show_bug.cgi?id=115682
1831
1832         Added unittests that fail on bots and spits out text into
1833         stdout (Requested by rniwa on #webkit).
1834
1835         * Scripts/import-w3c-tests: Removed.
1836         * Scripts/webkitpy/w3c/__init__.py: Removed.
1837         * Scripts/webkitpy/w3c/test_converter.py: Removed.
1838         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
1839         * Scripts/webkitpy/w3c/test_importer.py: Removed.
1840         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
1841         * Scripts/webkitpy/w3c/test_parser.py: Removed.
1842         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
1843
1844 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
1845
1846         [jhbuild] bump jhbuild version to take advantage of new improvements
1847         https://bugs.webkit.org/show_bug.cgi?id=115558
1848
1849         Reviewed by Martin Robinson.
1850
1851         One of the important improvements is jhbuild no longer fetches git
1852         repositories if they are already at the expected revision, which should
1853         make the EWS bots more robust to git servers unavailability.
1854
1855         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
1856
1857 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
1858
1859         [GTK] Add webkit_uri_scheme_request_finish_error
1860         https://bugs.webkit.org/show_bug.cgi?id=94316
1861
1862         Reviewed by Anders Carlsson.
1863
1864         * MiniBrowser/gtk/main.c:
1865         (miniBrowserErrorQuark): Add function to create a global quark for
1866         MiniBrowser.
1867         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
1868         function webkit_uri_scheme_request_finish_error().
1869
1870 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
1871
1872         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
1873         https://bugs.webkit.org/show_bug.cgi?id=113808
1874
1875         Reviewed by Rob Buis.
1876
1877         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
1878         to true for BlackBerry.
1879
1880         * Scripts/webkitperl/FeatureList.pm:
1881
1882 2013-05-06  Jessie Berlin  <jberlin@apple.com>
1883
1884         check-webkit-style should complain about a layering violation if platform-specific guards are
1885         used in WebCore outside of the platform directory
1886         https://bugs.webkit.org/show_bug.cgi?id=115567
1887
1888         Reviewed by Benjamin Poulain.
1889
1890         * Scripts/webkitpy/style/checkers/cpp.py:
1891         (check_for_webcore_platform_layering_violation):
1892         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
1893         (process_line):
1894         Add the check_for_webcore_platform_layering_violation.
1895         (CppChecker):
1896         List the new check.
1897
1898         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1899         (CppStyleTest.test_webcore_platform_layering_violation):
1900         Add tests.
1901
1902 2013-05-06  David Kilzer  <ddkilzer@apple.com>
1903
1904         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
1905         <http://webkit.org/b/115667>
1906
1907         Reviewed by Dirk Pranke.
1908
1909         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1910         (Bugzilla._check_create_bug_response): Update regex to work with
1911         Bugzilla 3.2.3 and 4.2.5.
1912         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1913         (test__check_create_bug_response): Add new test that covers both
1914         old and new <title> variations.
1915
1916 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
1917
1918         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
1919         https://bugs.webkit.org/show_bug.cgi?id=115661
1920
1921         Reviewed by Ryosuke Niwa.
1922
1923         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
1924         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
1925         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
1926
1927         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1928         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1929
1930 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
1931
1932         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
1933         https://bugs.webkit.org/show_bug.cgi?id=114603
1934
1935         Reviewed by Ryosuke Niwa.
1936
1937         * TestResultServer/generate_builders_json.py:
1938         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
1939         to represent these to be 'layout-test', for backwards compatibility.
1940         (main): Remove all the build.chromium.org masters.
1941         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
1942         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1943         (GenerateBuildersJsonTest):
1944         (GenerateBuildersJsonTest.test_generate_json_data):
1945         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
1946         test-running builders from the webkit.org master.
1947
1948 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
1949
1950         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
1951         https://bugs.webkit.org/show_bug.cgi?id=114988
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
1956         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
1957         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
1958         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
1959         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
1960
1961 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
1962
1963         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
1964         https://bugs.webkit.org/show_bug.cgi?id=114954
1965
1966         Reviewed by Ryosuke Niwa.
1967
1968         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1969         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
1970         modifier unions in the list of modifiers.
1971         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
1972         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
1973
1974 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
1975
1976         [Flakiness Dashboard] Simplify builder-name-based platform recognition
1977         https://bugs.webkit.org/show_bug.cgi?id=114957
1978
1979         Reviewed by Ryosuke Niwa.
1980
1981         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1982         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
1983         (chromiumPlatform): Removed, unnecessary.
1984         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
1985         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
1986         the builder operates with debug builds, no webkit.org builders are named this way.
1987         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1988         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
1989
1990 2013-05-06  Andy Estes  <aestes@apple.com>
1991
1992         Added two files I neglected to commit in r149589.
1993
1994         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
1995         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
1996
1997 2013-05-04  Andy Estes  <aestes@apple.com>
1998
1999         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2000         https://bugs.webkit.org/show_bug.cgi?id=115609
2001
2002         Reviewed by Oliver Hunt.
2003
2004         Added an API test.
2005
2006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2007         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2008         (+[TestDelegate shared]):
2009         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2010         (-[TestDelegate webView:createWebViewWithRequest:]):
2011         (TestWebKitAPI):
2012         (TestWebKitAPI::TEST):
2013         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2014
2015 2013-05-06  Antoine Quint  <graouts@apple.com>
2016
2017         Manage the presentation of the snapshotted plug-in using JavaScript
2018         https://bugs.webkit.org/show_bug.cgi?id=115548
2019
2020         Reviewed by Dean Jackson.
2021
2022         Take into account the new plugInExtraScript method added to support
2023         the injection of a JS file from the chrome client to customize the
2024         rendering of a snapshotted plug-in's shadow tree.
2025
2026         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2027         (WTR::InjectedBundlePage::InjectedBundlePage):
2028
2029 2013-05-05  Anders Carlsson  <andersca@apple.com>
2030
2031         Remove the Vector::append overload that takes a Vector
2032         https://bugs.webkit.org/show_bug.cgi?id=115535
2033
2034         Reviewed by Andreas Kling.
2035
2036         Use Vector::appendVector instead.
2037
2038         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2039         (concatenateAttributeAndValue):
2040         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2041         (WTR::concatenateAttributeAndValue):
2042
2043 2013-05-04  Sam Weinig  <sam@webkit.org>
2044
2045         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2046         <rdar://problem/13702008>
2047         https://bugs.webkit.org/show_bug.cgi?id=115607
2048
2049         Reviewed by Benjamin Poulain.
2050
2051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2052         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2053         (TestWebKitAPI::didFinishLoadForFrame):
2054         (TestWebKitAPI::TEST):
2055         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2056
2057 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2058
2059         Unreviewed.
2060
2061         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2062
2063 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2064
2065         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2066
2067         * Scripts/webkitpy/common/config/contributors.json:
2068
2069 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2070
2071         [GTK] Catch select.error exceptions in parse_output_lines
2072         https://bugs.webkit.org/show_bug.cgi?id=115253
2073
2074         Reviewed by Gustavo Noronha Silva.
2075
2076         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2077         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2078         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2079         error code and the error message) and the loop is re-entered.
2080
2081         * gtk/common.py:
2082         (parse_output_lines):
2083
2084 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2085
2086         [GTK] Set up the TestWebCore in TestWebKitAPI
2087         https://bugs.webkit.org/show_bug.cgi?id=115237
2088
2089         Reviewed by Gustavo Noronha Silva.
2090
2091         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2092         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2093         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2094         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2095         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2096
2097         * TestWebKitAPI/GNUmakefile.am:
2098
2099 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2100
2101         Create a script to import W3C tests
2102         https://bugs.webkit.org/show_bug.cgi?id=111513
2103
2104         Reviewed by Dirk Pranke.
2105
2106         Script to automate the import of W3C tests into WebKit.
2107         For the full description of how it works, see the comments
2108         at the top of test_importer.py.
2109
2110         * Scripts/import-w3c-tests: Added.
2111         * Scripts/webkitpy/w3c/__init__.py: Added.
2112         * Scripts/webkitpy/w3c/test_converter.py: Added.
2113         (TestConverter):
2114         (TestConverter.__init__):
2115         (TestConverter.load_prefixed_prop_list):
2116         (TestConverter.load_file):
2117         (TestConverter.convert_for_webkit):
2118         (TestConverter.convert_testharness_paths):
2119         (TestConverter.convert_prefixed_properties):
2120         (TestConverter.scrub_unprefixed_props):
2121         (TestConverter.replace_tag):
2122         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2123         (TestConverterTest):
2124         (TestConverterTest.testLoadPrefixedPropList):
2125         (TestConverterTest.test_convertForWebkitNothingToConvert):
2126         (test_convertForWebkitHarnessOnly):
2127         (test_convertForWebkitPropsOnly):
2128         (test_convertForWebkitHarnessAndProps):
2129         (test_convertTestHarnessPaths):
2130         (test_convertPrefixedProperties):
2131         (verifyTestHarnessPaths):
2132         (verifyPrefixedProperties):
2133         (generateTestContent):
2134         * Scripts/webkitpy/w3c/test_importer.py: Added.
2135         (main):
2136         (parse_args):
2137         (validate_import_directory):
2138         (TestImporter):
2139         (TestImporter.__init__):
2140         (TestImporter.do_import):
2141         (TestImporter.get_changeset):
2142         (TestImporter.scan_source_directory):
2143         (TestImporter.import_tests):
2144         (TestImporter.setup_destination_directory):
2145         (TestImporter.get_test_status):
2146         (TestImporter.remove_deleted_files):
2147         (TestImporter.write_import_log):
2148         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2149         (TestImporterTest):
2150         (TestImporterTest.test_ImportDirWithNoTests):
2151         * Scripts/webkitpy/w3c/test_parser.py: Added.
2152         (TestParser):
2153         (TestParser.__init__):
2154         (TestParser.load_file):
2155         (TestParser.analyze_test):
2156         (TestParser.get_reftests):
2157         (TestParser.is_jstest):
2158         (TestParser.get_support_files):
2159         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2160         (TestParserTest):
2161         (TestParserTest.test_analyzeTestReftestOneMatch):
2162         (test_analyzeTestReftestMultipleMatches):
2163         (test_analyzeTestReftestMatchAndMismatch):
2164         (test_analyzeTestReftestWithRefSupportFiles):
2165         (test_analyzeJSTest):
2166         (test_analyzePixelTestAllTrue):
2167         (test_analyzePixelTestAllFalse):
2168         (test_analyzeNonHTMLFile):
2169
2170 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2171
2172         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2173
2174         * Scripts/webkitpy/common/config/contributors.json:
2175
2176 2013-05-02  Nico Weber  <thakis@chromium.org>
2177
2178         Remove a stale script file.
2179         https://bugs.webkit.org/show_bug.cgi?id=115521
2180
2181         Reviewed by Anders Carlsson.
2182
2183         This script was added in
2184         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2185         Bakefile system that was removed in
2186         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2187         script just asserts when it's run and is useless.
2188
2189         * Scripts/update-sources-list.py: Removed.
2190
2191 2013-05-01  Glenn Adams  <glenn@skynav.com>
2192
2193         [webkitpy] Need abstract base class for commands that analyze commit logs
2194         https://bugs.webkit.org/show_bug.cgi?id=115391
2195
2196         Reviewed by Benjamin Poulain.
2197
2198         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2199         in preparation for adding two new commands that will reuse this functionality along with
2200         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2201         https://bugs.webkit.org/show_bug.cgi?id=115388.
2202
2203         No new tests as this patch does not change existing functionality or behavior.
2204
2205         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2206         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2207         (AbstractCommitLogCommand.__init__):
2208         (AbstractCommitLogCommand._init_options):
2209         (AbstractCommitLogCommand._parse_commit_message):
2210         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2211         (SuggestNominations.__init__):
2212         (SuggestNominations._init_options):
2213
2214 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2215
2216         Web Inspector: Fix check-inspector-strings script and fix localized strings
2217         https://bugs.webkit.org/show_bug.cgi?id=115495
2218
2219         Reviewed by Joseph Pecoraro.
2220
2221         * Scripts/check-inspector-strings:
2222
2223 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2224
2225         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2226         https://bugs.webkit.org/show_bug.cgi?id=115470
2227
2228         Reviewed by Martin Robinson.
2229
2230         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2231         not building either of the IOS, Windows or GTK-WK1 platforms.
2232
2233         Up until now the header was included for everything but the IOS and Windows platforms due to
2234         an incorrectly stated condition regarding the GTK platform.
2235
2236         * TestWebKitAPI/config.h:
2237
2238 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2239
2240         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2241         https://bugs.webkit.org/show_bug.cgi?id=115469
2242
2243         Reviewed by Martin Robinson.
2244
2245         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2246         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2247         for the WebKit2 tests and the injected bundle required by them.
2248
2249         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2250         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2251         under the WebKit2 code).
2252
2253         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2254         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2255         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2256
2257         * TestWebKitAPI/GNUmakefile.am:
2258
2259 2013-04-30  Glenn Adams  <glenn@skynav.com>
2260
2261         Unreviewed. Add myself to watchlist entries.
2262
2263         * Scripts/webkitpy/common/config/watchlist:
2264
2265 2013-04-30  Glenn Adams  <glenn@skynav.com>
2266
2267         [webkitpy] suggest-nominations doesn't count all qualified patches
2268         https://bugs.webkit.org/show_bug.cgi?id=115285
2269
2270         Reviewed by Benjamin Poulain.
2271
2272         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2273         nomination. Improve commit log parsing.
2274
2275         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2276         (CommitLogError):
2277         (CommitLogError.__init__):
2278         (CommitLogMissingReviewer):
2279         (CommitLogMissingReviewer.__init__):
2280         (SuggestNominations):
2281         (SuggestNominations.__init__):
2282         (SuggestNominations._recent_commit_messages):
2283         (SuggestNominations._author_name_from_email):
2284         (SuggestNominations._contributor_from_email):
2285         (SuggestNominations._parse_commit_message):
2286         (SuggestNominations._count_commit):
2287         (SuggestNominations._count_recent_patches):
2288         (SuggestNominations._collect_nominations):
2289         (SuggestNominations._print_nominations):
2290         (SuggestNominations.execute):
2291         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2292         (_make_options):
2293         (test_recent_commit_messages):
2294         (test_basic):
2295
2296 2013-04-30  Commit Queue  <rniwa@webkit.org>
2297
2298         Unreviewed, rolling out r149309.
2299         http://trac.webkit.org/changeset/149309
2300         https://bugs.webkit.org/show_bug.cgi?id=115430
2301
2302         The patch does not build on WK1-only builds of the GTK port
2303         (Requested by zdobersek on #webkit).
2304
2305         * TestWebKitAPI/GNUmakefile.am:
2306
2307 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2308
2309         Stop using "in" keyword in IDL files
2310         https://bugs.webkit.org/show_bug.cgi?id=115418
2311
2312         Reviewed by Kentaro Hara.
2313
2314         Remove "in" keyword from IDL files as this is no longer part of the Web
2315         IDL specification.
2316
2317         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2318         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2319         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2320         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2321         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2322         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2324         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2325
2326 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2327
2328         [EFL] Enable scaled cursors
2329         https://bugs.webkit.org/show_bug.cgi?id=106242
2330
2331         Reviewed by Gyuyoung Kim.
2332
2333         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2334
2335         * Scripts/webkitperl/FeatureList.pm:
2336
2337 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2338
2339         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2340         https://bugs.webkit.org/show_bug.cgi?id=115380
2341
2342         Reviewed by Kentaro Hara.
2343
2344         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2345         keyword.
2346
2347         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2348         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2349
2350 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2351
2352         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2353         https://bugs.webkit.org/show_bug.cgi?id=114684
2354
2355         Reviewed by Simon Hausmann.
2356
2357         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2358         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2359
2360         * qmake/mkspecs/features/features.prf:
2361
2362 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2363
2364         [GTK] Disable Shadow DOM feature
2365         https://bugs.webkit.org/show_bug.cgi?id=115374
2366
2367         Reviewed by Martin Robinson.
2368
2369         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2370
2371         * Scripts/webkitperl/FeatureList.pm:
2372
2373 2013-04-29  Glenn Adams  <glenn@skynav.com>
2374
2375         [webkitpy] Add missing contributor email addresses
2376         https://bugs.webkit.org/show_bug.cgi?id=115394
2377
2378         Reviewed by Ryosuke Niwa.
2379
2380         * Scripts/webkitpy/common/config/contributors.json:
2381
2382 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2383
2384         Remove all remaining Skia code
2385         https://bugs.webkit.org/show_bug.cgi?id=115263
2386
2387         Reviewed by Benjamin Poulain.
2388
2389         Remove all remaining references to Skia.
2390
2391         * Scripts/webkitdirs.pm:
2392         (blackberryCMakeArguments):
2393         * Scripts/webkitpy/common/config/contributionareas.py:
2394         * Scripts/webkitpy/common/config/watchlist:
2395
2396 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2397
2398         Get rid of unused options in Tools/Scripts/webkit-build-directory
2399         https://bugs.webkit.org/show_bug.cgi?id=115383
2400
2401         Reviewed by Darin Adler.
2402
2403         * Scripts/webkit-build-directory:
2404
2405 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2406
2407         [WK2][Mac] Test with NetworkProcess enabled.
2408
2409         Fix the build for non-Mac.
2410
2411         * WebKitTestRunner/TestController.cpp:
2412         (WTR::TestController::initialize):
2413
2414 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2415
2416         [WK2][Mac] Test with NetworkProcess enabled.
2417
2418         Reviewed by Sam Weinig.
2419
2420         * WebKitTestRunner/TestController.cpp:
2421         (WTR::TestController::initialize):
2422
2423 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2424
2425         [GTK] Set up the TestWebCore in TestWebKitAPI
2426         https://bugs.webkit.org/show_bug.cgi?id=115237
2427
2428         Reviewed by Gustavo Noronha Silva.
2429
2430         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2431         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2432         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2433         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2434         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2435
2436         * TestWebKitAPI/GNUmakefile.am:
2437
2438 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2439
2440         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2441         https://bugs.webkit.org/show_bug.cgi?id=115236
2442
2443         Reviewed by Gustavo Noronha Silva.
2444
2445         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2446         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2447
2448         * TestWebKitAPI/GNUmakefile.am:
2449
2450 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2451
2452         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2453         https://bugs.webkit.org/show_bug.cgi?id=115323
2454
2455         Reviewed by Philippe Normand.
2456
2457         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2458         Its presence enforces linkers to output mangled symbols when reporting linking failures
2459         due to unresolved references. People trying to fix the build can then simply copy
2460         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2461         or connecting to the builders to discover the mangled version of the missing symbol.
2462
2463         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2464
2465 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2466
2467         Remove Chromium code from Tools/BuildSlaveSupport
2468         https://bugs.webkit.org/show_bug.cgi?id=115325
2469
2470         Reviewed by Benjamin Poulain.
2471
2472         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2473         covering archiving test results and built products.
2474
2475         * BuildSlaveSupport/built-product-archive:
2476         (archiveBuiltProduct):
2477         (extractBuiltProduct):
2478         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2479         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2480         * BuildSlaveSupport/test-result-archive:
2481         (archiveTestResults):
2482
2483 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2484
2485         Remove support for Chromium from webkitdirs.pm
2486         https://bugs.webkit.org/show_bug.cgi?id=115338
2487
2488         Reviewed by Darin Adler.
2489
2490         * Scripts/webkitdirs.pm:
2491         (determineBaseProductDir):
2492         (argumentsForConfiguration):
2493         (builtDylibPathForName):
2494         (determineIsQt):
2495         (isAppleWebKit):
2496
2497 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2498
2499         Rename TestRunner's setAudioData to setAudioResult
2500         https://bugs.webkit.org/show_bug.cgi?id=115326
2501
2502         Reviewed by Darin Adler.
2503
2504         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
2505         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
2506         affected tests are adjusted accordingly.
2507
2508         * DumpRenderTree/qt/TestRunnerQt.cpp:
2509         (TestRunnerQt::setAudioResult):
2510         * DumpRenderTree/qt/TestRunnerQt.h:
2511         (TestRunnerQt):
2512         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2513         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2514         (WTR::TestRunner::setAudioResult):
2515         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2516         (TestRunner):
2517
2518 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2519
2520         [WKTR] Tests dumping audio data shouldn't dump pixels
2521         https://bugs.webkit.org/show_bug.cgi?id=115270
2522
2523         Reviewed by Benjamin Poulain.
2524
2525         Prevent dumping the pixel output when Web Audio tests are dumping output data
2526         as the testing output. Pixel output in these tests has no real meaning and is
2527         as such unnecessary.
2528
2529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2530         (WTR::TestRunner::setAudioData):
2531
2532 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2533
2534         [EFL] Unreviewed Intel bots fix after r149231.
2535
2536         * efl/jhbuild.modules: Disable the libxml Python bindings since the
2537         bots don't have Python's development files installed. libxml should
2538         detect this kind of thing better.
2539
2540 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
2541
2542         [EFL] Build break using jhbuild on ubuntu 13.04
2543         https://bugs.webkit.org/show_bug.cgi?id=115225
2544
2545         Reviewed by Gyuyoung Kim.
2546
2547         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
2548         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
2549         So this patch bumped libxml version to 2.9.1.
2550
2551         * efl/jhbuild.modules:
2552
2553 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
2554
2555         delete-stale-build-files does not clear .d files
2556         http://bugs.webkit.org/show_bug.cgi?id=115293
2557
2558         Reviewed by Ryosuke Niwa.
2559
2560         * BuildSlaveSupport/delete-stale-build-files:
2561         (main): Add .d to the file type list
2562
2563 2013-04-26  Roger Fong  <roger_fong@apple.com>
2564
2565         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
2566         Make the DebugSuffix configuration use _debug dependencies.
2567
2568         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2569         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
2570         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2571         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
2572         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2573         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2574         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
2575         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
2576         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
2577         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2578         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2579         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
2580         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2581         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2582         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2583         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
2584         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
2585         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
2586         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2587         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
2588         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
2589         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
2590         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2591         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
2592         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2593         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
2594         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
2595         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2596         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2597         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2598         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
2599         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
2600         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2601         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
2602         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2603         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2604         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2605         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
2606         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2607         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
2608         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2609         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2610         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2611         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
2612         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
2613         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2614         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
2615         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
2616         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
2617         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2618         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
2619         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2620         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2621         * win/AssembleBuildLogs/AssembleLogs.cmd:
2622         * win/record-memory/record-memory.vcxproj:
2623         * win/record-memory/record-memoryDebug.props:
2624         * win/record-memory/record-memoryDebugWinCairo.props:
2625         * win/record-memory/record-memoryProduction.props:
2626         * win/record-memory/record-memoryRelease.props:
2627         * win/record-memory/record-memoryReleaseWinCairo.props:
2628
2629 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2630
2631         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
2632         https://bugs.webkit.org/show_bug.cgi?id=115233
2633
2634         Reviewed by Martin Robinson.
2635
2636         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
2637         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
2638         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
2639         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
2640         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
2641
2642         * TestWebKitAPI/GNUmakefile.am:
2643
2644 2013-04-25  Andy Estes  <aestes@apple.com>
2645
2646         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
2647         https://bugs.webkit.org/show_bug.cgi?id=115223
2648
2649         Reviewed by Darin Adler.
2650
2651         Added an API test.
2652
2653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2654         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
2655         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
2656         when it loads a request with a custom protocol.
2657         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
2658         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
2659         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
2660         miscellaneous cleanup.
2661         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
2662         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
2663         (+[TestProtocol canInitWithRequest:]):
2664         (+[TestProtocol canonicalRequestForRequest:]):
2665         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
2666         (+[TestProtocol scheme]):
2667         (-[TestProtocol startLoading]):
2668         (-[TestProtocol stopLoading]):
2669
2670 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
2671
2672         Remove the remaining Skia #ifdefs
2673         https://bugs.webkit.org/show_bug.cgi?id=114886
2674
2675         Reviewed by Benjamin Poulain.
2676
2677         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2678         (createBitmapContextFromWebView): Remove Skia #ifdef references.
2679
2680 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
2681
2682         [BlackBerry] Clean up load interface in WebPage
2683         https://bugs.webkit.org/show_bug.cgi?id=113267
2684
2685         Reviewed by Rob Buis.
2686
2687         Update DumpRenderTree with change of load() interface in WebPage.
2688         RIM Bug# 315535, internally reviewed by Joe Mason.
2689
2690         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2691         (BlackBerry::WebKit::DumpRenderTree::runTest):
2692
2693 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2694
2695         Remove the HeapGraphSerializer unit test
2696         https://bugs.webkit.org/show_bug.cgi?id=115231
2697
2698         Reviewed by Andreas Kling.
2699
2700         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
2701         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
2702
2703         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
2704
2705 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2706
2707         Remove support for Chromium from build/update scripts
2708         https://bugs.webkit.org/show_bug.cgi?id=115218
2709
2710         Reviewed by Darin Adler.
2711
2712         * Scripts/build-webkit:
2713         (writeCongrats):
2714         * Scripts/update-webkit:
2715
2716 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2717
2718         Remove support for Chromium from api-test
2719         https://bugs.webkit.org/show_bug.cgi?id=115211
2720
2721         Reviewed by Dirk Pranke.
2722
2723         * Scripts/build-api-tests:
2724         * Scripts/run-api-tests:
2725         (isSupportedPlatform):
2726
2727 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2728
2729         Get rid of Chromium in build-dumprendertree
2730         https://bugs.webkit.org/show_bug.cgi?id=115212
2731
2732         Reviewed by Dirk Pranke.
2733
2734         * Scripts/build-dumprendertree:
2735
2736 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
2737
2738         Pass relatedPage when creating a page in WebKitTestRunner
2739         https://bugs.webkit.org/show_bug.cgi?id=115206
2740
2741         Reviewed by Geoffrey Garen.
2742
2743         To make sure that window.open() opens in the same process even when using multiple processes.
2744
2745         * WebKitTestRunner/PlatformWebView.h:
2746         * WebKitTestRunner/TestController.cpp:
2747         (WTR::TestController::createOtherPage):
2748         (WTR::TestController::createWebViewWithOptions):
2749         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2750         (WTR::PlatformWebView::PlatformWebView):
2751         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2752         (WTR::PlatformWebView::PlatformWebView):
2753         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2754         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
2755         (WTR::PlatformWebView::PlatformWebView):
2756         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2757         (WTR::PlatformWebView::PlatformWebView):
2758         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2759         (WTR::PlatformWebView::PlatformWebView):
2760
2761 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2762
2763         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
2764
2765         * Scripts/webkitpy/common/config/contributors.json:
2766
2767 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2768
2769         Build fix. Forgot to merge args.
2770
2771         * Scripts/webkitpy/tool/bot/irc_command.py:
2772         (Hi.execute):
2773
2774 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2775
2776         webkitbot should recognize its own nickname in greetings.
2777         https://bugs.webkit.org/show_bug.cgi?id=115196
2778
2779         Reviewed by Andreas Kling.
2780
2781         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
2782
2783         * Scripts/webkitpy/tool/bot/irc_command.py:
2784         (Hi.execute):
2785
2786 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
2787
2788         [GTK] Tools/gtk/install-dependencies added ragel dependency
2789         https://bugs.webkit.org/show_bug.cgi?id=115163
2790
2791         Reviewed by Xan Lopez.
2792
2793         The install-dependencies script was missing a dependency on ragel
2794         which is expected when building HarfBuzz.
2795
2796         * gtk/install-dependencies: Added a dependency on ragel for both
2797         apt and yum.
2798
2799 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
2800
2801         [GTK] Remove pango from optional jhbuild dependencies
2802         https://bugs.webkit.org/show_bug.cgi?id=115162
2803
2804         Reviewed by Martin Robinson.
2805
2806         Pango is not needed since revision r148293 that lowers the pango
2807         dependency to 1.30, which is available in most distributions.
2808
2809         * gtk/jhbuild-optional.modules: Removes description of pango module.
2810
2811 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2812
2813         Remove Chromium-specific cases from FeatureList.pm
2814         https://bugs.webkit.org/show_bug.cgi?id=115169
2815
2816         Reviewed by Andreas Kling.
2817
2818         * Scripts/webkitperl/FeatureList.pm:
2819
2820 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
2821
2822         Remove checking chromium from run-webkit-tests
2823         https://bugs.webkit.org/show_bug.cgi?id=115139
2824
2825         Reviewed by Benjamin Poulain.
2826
2827         * Scripts/run-webkit-tests:
2828         (useNewRunWebKitTests):
2829
2830 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
2831
2832         Pixel tests in SVG are all broken in WK2
2833         https://bugs.webkit.org/show_bug.cgi?id=114218
2834
2835         Reviewed by Darin Adler.
2836
2837         Window snapshots in WebKitTestRunner on Mac are window-sized
2838         (800x600), which is wrong for the W3C SVG tests that require a
2839         480x360 snapshot.
2840
2841         Fix by resizing the window, as well as the web view in
2842         PlatformWebView::resizeTo() so that window snapshots are correctly
2843         sized.
2844
2845         Also do some drive-by cleanup of the window size constants in both
2846         DRT and WTR to remove magic numbers, and make the code more similar.
2847
2848         * DumpRenderTree/TestRunner.cpp:
2849         (TestRunner::setShouldPaintBrokenImage):
2850         * DumpRenderTree/TestRunner.h:
2851         * DumpRenderTree/efl/DumpRenderTree.cpp:
2852         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2853         (webInspectorShowWindow):
2854         * DumpRenderTree/mac/DumpRenderTree.mm:
2855         (createWebViewAndOffscreenWindow):
2856         (sizeWebViewForCurrentTest):
2857         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2858         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2859         (createPagedBitmapContext):
2860         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2861         (DumpRenderTree::DumpRenderTree):
2862         (DumpRenderTree::open):
2863         * DumpRenderTree/qt/TestRunnerQt.cpp:
2864         * DumpRenderTree/qt/TestRunnerQt.h:
2865         * DumpRenderTree/win/DumpRenderTree.cpp:
2866         (sizeWebViewForCurrentTest):
2867         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2868         * WebKitTestRunner/TestController.cpp:
2869         (WTR::TestController::resetStateToConsistentValues):
2870         * WebKitTestRunner/TestController.h:
2871         * WebKitTestRunner/TestInvocation.cpp:
2872         (WTR::sizeWebViewForCurrentTest):
2873         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2874         (WTR::PlatformWebView::PlatformWebView):
2875         (WTR::PlatformWebView::resizeTo):
2876
2877 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
2878
2879         [EFL] Fix build error after r148963.
2880         https://bugs.webkit.org/show_bug.cgi?id=115126
2881
2882         Reviewed by Laszlo Gombos.
2883
2884         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
2885
2886         * TestWebKitAPI/PlatformEfl.cmake:
2887
2888 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2889
2890         [GTK] Use stamp files for generate-forwarding-headers makefile rules
2891         https://bugs.webkit.org/show_bug.cgi?id=115118
2892
2893         Reviewed by Martin Robinson.
2894
2895         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
2896         forwarding generator rules and don't call it for soup since there
2897         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
2898
2899         * TestWebKitAPI/GNUmakefile.am:
2900         * WebKitTestRunner/GNUmakefile.am:
2901
2902 2013-04-24  Simon Pena  <simon.pena@samsung.com>
2903
2904         [GTK] Update build dependencies
2905         https://bugs.webkit.org/show_bug.cgi?id=115111
2906
2907         Reviewed by Martin Robinson.
2908
2909         The install-dependencies script was missing a dependency on EGL,
2910         which is expected when building Cairo.
2911
2912         * gtk/install-dependencies: Added a dependency on libegl1-mesa
2913         for both apt and yum.
2914
2915 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
2916
2917         Remove the Chromium-specific helper from run_webkit_tests.py
2918         https://bugs.webkit.org/show_bug.cgi?id=114996
2919
2920         Reviewed by Dirk Pranke.
2921
2922         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2923         (parse_args):
2924
2925 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
2926
2927         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
2928         https://bugs.webkit.org/show_bug.cgi?id=114850
2929
2930         Reviewed by Andreas Kling.
2931
2932         Revision r148312 fixed WebPageProxy cleanup and also changed the process
2933         termination semantics when requested by the user so that a client is not
2934         notified of a crash anymore, since there was no crash anyway.
2935
2936         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
2937         relied on being notified of a crash after calling WKPageTerminate(). As
2938         a result of not being notified of such non-existent crash, the test would
2939         timeout right after making the terminate call.
2940
2941         This patch adds an InjectedBundle to be used for simulating a crash, by
2942         calling abort() upon receiving a "Crash" message, and thus we are able to
2943         keep testing the crash callback.
2944
2945         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
2946         had been disabled in revisions r148858 and r148855, since it was failing.
2947
2948         * TestWebKitAPI/PlatformEfl.cmake:
2949         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2950         (TestWebKitAPI::TEST):
2951         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
2952         (TestWebKitAPI):
2953         (WKViewClientWebProcessCallbacksTest):
2954         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
2955         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
2956
2957 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2958
2959         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
2960         https://bugs.webkit.org/show_bug.cgi?id=115095
2961
2962         Reviewed by Antonio Gomes.
2963
2964         Use different subfolders under DumpRenderTree Temp folder for every
2965         functionality (icon database, cache, localstorage, ...). This makes
2966         sure there is no conflict between the functionalities.
2967
2968         In EFL's case, libsoup cache was causing problems for the icon
2969         database if sharing the same folder.
2970
2971         * WebKitTestRunner/TestController.cpp:
2972         (WTR::TestController::initialize):
2973
2974 == Rolled over to ChangeLog-2013-04-24 ==