Tools/ChangeLog

   1 2015-09-15  Alex Christensen  <achristensen@webkit.org>
   2
   3         Fix Windows test bots after changing to non-cygwin build
   4         https://bugs.webkit.org/show_bug.cgi?id=149196
   5
   6         Reviewed by Daniel Bates.
   7
   8         * BuildSlaveSupport/built-product-archive:
   9         (unzipArchive):
  10         Using different versions of python makes what I think is https://bugs.python.org/issue15795
  11         prevent us from executing files from the archive on the test bots.
  12
  13 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
  14
  15         Add ShadowRoot interface and Element.prototype.attachShadow
  16         https://bugs.webkit.org/show_bug.cgi?id=149187
  17
  18         Reviewed by Antti Koivisto.
  19
  20         * Scripts/webkitperl/FeatureList.pm:
  21
  22 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
  23
  24         Appscale queue status json output lacks bots
  25         https://bugs.webkit.org/show_bug.cgi?id=149194
  26         <rdar://problem/22171089>
  27
  28         Reviewed by Alexey Proskuryakov.
  29
  30         * QueueStatusServer/handlers/queuestatusjson.py:
  31         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
  32         * QueueStatusServer/index.yaml: Index according to appscale requirements.
  33
  34 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
  35
  36         [Win] Provide a means for viewing the layer tree
  37         https://bugs.webkit.org/show_bug.cgi?id=149165
  38
  39         Reviewed by Simon Fraser.
  40
  41         Update MiniBrowser with a new Debug menu option that will
  42         dump the current layer tree to the debug console.
  43
  44         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
  45         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
  46         * MiniBrowser/win/Common.cpp:
  47         (WndProc): Add handler for 'Print Layer Tree' menu option.
  48         * MiniBrowser/win/MiniBrowser.cpp:
  49         (MiniBrowser::printLayerTree): Added Handler.
  50         * MiniBrowser/win/MiniBrowser.h:
  51
  52 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
  53
  54         WebKitTestRunner declarative language setting is broken for iOS
  55         https://bugs.webkit.org/show_bug.cgi?id=149119
  56
  57         Unreviewed.
  58
  59         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
  60         lost in the final version which got committed. This simply implements the existing
  61         OS X behavior on iOS.
  62
  63         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
  64         (WTR::InjectedBundle::platformInitialize):
  65
  66 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
  67
  68         Unreviewed, add myself to committers list.
  69
  70         * Scripts/webkitpy/common/config/contributors.json:
  71
  72 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
  73
  74         [Cocoa] Allow testing with the system language
  75         https://bugs.webkit.org/show_bug.cgi?id=148671
  76
  77         Reviewed by Anders Carlsson and Alexey Proskuryakov.
  78
  79         React to tests marked with language=lang1,lang2,etc in their header.
  80         Once this information is parsed, pass it to
  81         WKContextConfigurationSetOverrideLanguages().
  82
  83         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  84         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
  85         list.
  86         * WebKitTestRunner/TestController.cpp:
  87         (WTR::TestController::createWebViewWithOptions): Call
  88         WKContextConfigurationSetOverrideLanguages().
  89         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
  90         * WebKitTestRunner/TestOptions.h:
  91         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
  92         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
  93         option to restart the web process.
  94         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  95         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
  96
  97 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
  98
  99         [WKTR] Allow changing the WKContextConfiguration between successive tests
 100         https://bugs.webkit.org/show_bug.cgi?id=148833
 101
 102         Reviewed by Tim Horton.
 103
 104         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
 105         However, there are certain tests which require specifying options in this object. This patch makes
 106         our existing code for recreating the test runner web view also recreate the WKContext.
 107
 108         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
 109         class.
 110
 111         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
 112         * WebKitTestRunner/PlatformWebView.h:
 113         (WTR::PlatformWebView::options):
 114         * WebKitTestRunner/TestController.cpp:
 115         (WTR::TestController::initialize):
 116         (WTR::TestController::generateContextConfiguration):
 117         (WTR::TestController::generatePageConfiguration):
 118         (WTR::TestController::createWebViewWithOptions):
 119         (WTR::TestController::ensureViewSupportsOptionsForTest):
 120         (WTR::updateContextConfigurationOptionsFromTestHeader):
 121         (WTR::TestController::contextConfigurationOptionsForTest):
 122         (WTR::TestController::platformCreateWebView):
 123         (WTR::TestController::platformCreateOtherPage):
 124         (WTR::updateViewOptionsFromTestHeader): Deleted.
 125         (WTR::TestController::viewOptionsForTest): Deleted.
 126         * WebKitTestRunner/TestController.h:
 127         (WTR::TestController::injectedBundlePath):
 128         (WTR::TestController::testPluginDirectory):
 129         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 130         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 131         (WTR::TestController::platformCreateWebView):
 132         (WTR::TestController::platformCreateOtherPage):
 133         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
 134         (WTR::PlatformWebView::PlatformWebView):
 135         (WTR::PlatformWebView::viewSupportsOptions):
 136         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 137         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 138         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 139         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
 140         (WTR::PlatformWebView::PlatformWebView):
 141         (WTR::PlatformWebView::viewSupportsOptions):
 142         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
 143         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 144         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 145         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 146         (WTR::PlatformWebView::PlatformWebView):
 147         (WTR::PlatformWebView::viewSupportsOptions):
 148         * WebKitTestRunner/ios/TestControllerIOS.mm:
 149         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 150         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 151         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 152         (WTR::PlatformWebView::PlatformWebView):
 153         (WTR::PlatformWebView::viewSupportsOptions):
 154         * WebKitTestRunner/mac/TestControllerMac.mm:
 155         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 156         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 157
 158 2015-09-11  Michael Saboff  <msaboff@apple.com>
 159
 160         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
 161         https://bugs.webkit.org/show_bug.cgi?id=149083
 162
 163         Reviewed by Alexey Proskuryakov.
 164
 165         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
 166
 167         * DumpRenderTree/mac/LayoutTestHelper.m:
 168         (colorProfileURLForDisplay):
 169
 170 2015-09-11  Saam barati  <sbarati@apple.com>
 171
 172         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
 173         https://bugs.webkit.org/show_bug.cgi?id=149058
 174
 175         Reviewed by Geoffrey Garen.
 176
 177         * Scripts/run-jsc-stress-tests:
 178
 179 2015-09-10  Commit Queue  <commit-queue@webkit.org>
 180
 181         Unreviewed, rolling out r189595.
 182         https://bugs.webkit.org/show_bug.cgi?id=149052
 183
 184         The tests still fail (Requested by ap on #webkit).
 185
 186         Reverted changeset:
 187
 188         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
 189         error -1"
 190         https://bugs.webkit.org/show_bug.cgi?id=142929
 191         http://trac.webkit.org/changeset/189595
 192
 193 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
 194
 195         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
 196         https://bugs.webkit.org/show_bug.cgi?id=142929
 197
 198         Reviewed by Brent Fulgham.
 199
 200         Silence the logging. We'll track fixing the root cause in Radar.
 201
 202         * Scripts/webkitpy/port/mac.py:
 203         (MacPort.stderr_patterns_to_strip): Added a FIXME.
 204
 205         * Scripts/webkitpy/port/win.py:
 206         (WinPort.logging_patterns_to_strip): Added.
 207
 208 2015-09-09  Andy Estes  <aestes@apple.com>
 209
 210         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
 211         https://bugs.webkit.org/show_bug.cgi?id=149022
 212
 213         Reviewed by Daniel Bates.
 214
 215         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
 216         did not account for this.
 217
 218         * Scripts/webkitpy/xcode/simulator.py:
 219         (Simulator): Optionally matched a revision at the end of a runtime version number.
 220         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
 221
 222 2015-09-09  Andy Estes  <aestes@apple.com>
 223
 224         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
 225         https://bugs.webkit.org/show_bug.cgi?id=149029
 226         <rdar://problem/22432624>
 227
 228         Reviewed by Daniel Bates.
 229
 230         * Scripts/webkitpy/xcode/simulator.py:
 231         (Simulator): Taught to parse tvOS runtimes.
 232         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
 233
 234 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
 235
 236         Fix bit rot on bot watcher's dashboard page
 237         https://bugs.webkit.org/show_bug.cgi?id=149012
 238
 239         Reviewed by Tim Horton.
 240
 241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
 242         The code path used by the metrics page was trying to add properties to an undefined.
 243
 244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
 245         Silence an expection that would occur when the step has no logs. This should never
 246         happen, but it did (perhaps buildbot was misconfigured for a while).
 247
 248 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
 249
 250         Update LayoutTestRelay xcconfig file.
 251
 252         Rubber-stamped by Dan Bernstein.
 253
 254         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
 255
 256 2015-09-09  Saam barati  <sbarati@apple.com>
 257
 258         DFG should have a debugging option that runs a phase that flushes all locals
 259         https://bugs.webkit.org/show_bug.cgi?id=148916
 260
 261         Reviewed by Filip Pizlo.
 262
 263         * Scripts/run-jsc-stress-tests:
 264
 265 2015-09-09  Commit Queue  <commit-queue@webkit.org>
 266
 267         Unreviewed, rolling out r189530 and r189534.
 268         https://bugs.webkit.org/show_bug.cgi?id=148996
 269
 270         Caused assertion failures on Yosemite (Requested by litherum
 271         on #webkit).
 272
 273         Reverted changesets:
 274
 275         "[WKTR] Allow changing the WKContextConfiguration between
 276         successive tests"
 277         https://bugs.webkit.org/show_bug.cgi?id=148833
 278         http://trac.webkit.org/changeset/189530
 279
 280         "[Cocoa] Fix the tests after r189530"
 281         http://trac.webkit.org/changeset/189534
 282
 283 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
 284
 285         [Cocoa] Fix the tests after r189530
 286
 287         Unreviewed.
 288
 289         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 290         (WTR::initializeWebViewConfiguration):
 291
 292 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
 293
 294         [WKTR] Allow changing the WKContextConfiguration between successive tests
 295         https://bugs.webkit.org/show_bug.cgi?id=148833
 296
 297         Reviewed by Tim Horton.
 298
 299         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
 300         However, there are certain tests which require specifying options in this object. This patch makes
 301         our existing code for recreating the test runner web view also recreate the WKContext.
 302
 303         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
 304         class.
 305
 306         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
 307         * WebKitTestRunner/PlatformWebView.h:
 308         (WTR::PlatformWebView::options):
 309         * WebKitTestRunner/TestController.cpp:
 310         (WTR::TestController::initialize):
 311         (WTR::TestController::generateContextConfiguration):
 312         (WTR::TestController::generatePageConfiguration):
 313         (WTR::TestController::createWebViewWithOptions):
 314         (WTR::TestController::ensureViewSupportsOptionsForTest):
 315         (WTR::updateContextConfigurationOptionsFromTestHeader):
 316         (WTR::TestController::contextConfigurationOptionsForTest):
 317         (WTR::TestController::platformCreateWebView):
 318         (WTR::TestController::platformCreateOtherPage):
 319         (WTR::updateViewOptionsFromTestHeader): Deleted.
 320         (WTR::TestController::viewOptionsForTest): Deleted.
 321         * WebKitTestRunner/TestController.h:
 322         (WTR::TestController::injectedBundlePath):
 323         (WTR::TestController::testPluginDirectory):
 324         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 325         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 326         (WTR::TestController::platformCreateWebView):
 327         (WTR::TestController::platformCreateOtherPage):
 328         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
 329         (WTR::PlatformWebView::PlatformWebView):
 330         (WTR::PlatformWebView::viewSupportsOptions):
 331         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 332         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 333         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 334         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
 335         (WTR::PlatformWebView::PlatformWebView):
 336         (WTR::PlatformWebView::viewSupportsOptions):
 337         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
 338         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 339         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 340         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 341         (WTR::PlatformWebView::PlatformWebView):
 342         (WTR::PlatformWebView::viewSupportsOptions):
 343         * WebKitTestRunner/ios/TestControllerIOS.mm:
 344         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 345         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 346         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 347         (WTR::PlatformWebView::PlatformWebView):
 348         (WTR::PlatformWebView::viewSupportsOptions):
 349         * WebKitTestRunner/mac/TestControllerMac.mm:
 350         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
 351         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
 352
 353 2015-09-08  Daniel Bates  <dabates@apple.com>
 354
 355         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
 356         https://bugs.webkit.org/show_bug.cgi?id=148980
 357
 358         Reviewed by Alexey Proskuryakov.
 359
 360         Add setting to enable/disable accelerated drawing so as to support testing
 361         this feature in MiniBrowser on Mac.
 362
 363         * MiniBrowser/mac/SettingsController.h:
 364         * MiniBrowser/mac/SettingsController.m:
 365         (-[SettingsController _populateMenu]): Add menu item.
 366         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
 367         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
 368         (-[SettingsController acceleratedDrawingEnabled]): Added.
 369         * MiniBrowser/mac/WK1BrowserWindowController.m:
 370         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
 371         * MiniBrowser/mac/WK2BrowserWindowController.m:
 372         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
 373
 374 2015-09-08  Jason Marcell  <jmarcell@apple.com>
 375
 376         Unreviewed. Added myself as a commiter in contributors.json.
 377
 378         * Scripts/webkitpy/common/config/contributors.json:
 379
 380 2015-09-08  Keith Miller  <keith_miller@apple.com>
 381
 382         Unreviewed, added myself to the list of contributors.
 383
 384         * Scripts/webkitpy/common/config/contributors.json:
 385
 386 2015-09-08  Daniel Bates  <dabates@apple.com>
 387
 388         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
 389         https://bugs.webkit.org/show_bug.cgi?id=148921
 390
 391         Reviewed by Alexey Proskuryakov.
 392
 393         The ring image is positioned above the platform icon in markup and we specify the CSS
 394         property z-index for the ring image so that it is painted on top of the platform icon
 395         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
 396         of the ring image, switch the order of these DOM elements and remove the use of the CSS
 397         property z-index to achieve a similar effect.
 398
 399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
 400         (documentReady): Create the platform icon image element before the ring image such that
 401         the ring image is painted on top of the platform icon.
 402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 403         (table.queue-grid td.logo img.ring): Removed property z-index.
 404
 405 2015-09-08  Daniel Bates  <dabates@apple.com>
 406
 407         Dashboard: Remove duplicate gear icon data URLs
 408         https://bugs.webkit.org/show_bug.cgi?id=148920
 409
 410         Reviewed by Alexey Proskuryakov.
 411
 412         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
 413         background-image associated with each of the three gear icon states: collapsed (.settings), hover
 414         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
 415         as a mask and make use of the CSS background-color to define the fill color for each of these three
 416         states.
 417
 418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 419         (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
 420         (.settings:hover): Override CSS background-color for hover state.
 421         (.settings-visible .settings): Override CSS background-color for expanded state.
 422
 423 2015-09-07  Andy Estes  <aestes@apple.com>
 424
 425         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
 426         https://bugs.webkit.org/show_bug.cgi?id=148946
 427         <rdar://problem/22603981>
 428
 429         Reviewed by Dan Bernstein.
 430
 431         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 432         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 433
 434 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
 435
 436         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
 437         https://bugs.webkit.org/show_bug.cgi?id=148927
 438
 439         Reviewed by Csaba Osztrogonác.
 440
 441         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
 442         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
 443
 444         * WebKitTestRunner/TestController.cpp:
 445         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
 446         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 447         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
 448
 449 2015-09-07  Andy Estes  <aestes@apple.com>
 450
 451         Fix the Production build after r189455.
 452
 453         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
 454         In-App Purchase template instead of the Aggregate template. Whoops.
 455
 456 2015-09-06  Andy Estes  <aestes@apple.com>
 457
 458         WebKit.xcworkspace should be be able to build iOS platforms
 459         https://bugs.webkit.org/show_bug.cgi?id=148881
 460
 461         Reviewed by Daniel Bates.
 462
 463         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
 464         for all supported platforms.
 465
 466         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
 467         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
 468         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
 469         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
 470
 471 2015-09-06  Andy Estes  <aestes@apple.com>
 472
 473         WebKitTestRunner should build for iOS using the default target
 474         https://bugs.webkit.org/show_bug.cgi?id=148918
 475
 476         Reviewed by Daniel Bates.
 477
 478         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
 479         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
 480         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
 481
 482         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
 483         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
 484         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
 485         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
 486         WebKitTestRunner is skipped when installing on iOS.
 487
 488         The target dependency graph now looks like this:
 489
 490             All
 491                 WebKitTestRunnerApp
 492                     WebKitTestRunner (Library)
 493                         WebKitTestRunnerInjectedBundle
 494                             Derived Sources
 495                 WebKitTestRunner
 496                     WebKitTestRunner (Library)
 497                         WebKitTestRunnerInjectedBundle
 498                             Derived Sources
 499
 500         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
 501         * Scripts/build-webkittestrunner: Ditto.
 502         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
 503         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
 504         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
 505         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
 506         excluded iOS-only files, and skipped installing on iOS.
 507         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
 508         excluded Mac-only files, and skipped installing on Mac.
 509         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
 510         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
 511         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
 512         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
 513         new configuration files.
 514
 515 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
 516
 517         Web Inspector: Improve prepare-ChangeLog for multiple cases
 518         https://bugs.webkit.org/show_bug.cgi?id=148875
 519
 520         Reviewed by Timothy Hatcher.
 521
 522         * Scripts/prepare-ChangeLog:
 523         (get_function_line_ranges_for_javascript):
 524         - We were ignoring everything inside of an anonymous function expression,
 525           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
 526           Better handle this by inserting a few tweaks.
 527         - Allow method syntax outside of classes as long as they are at the global level.
 528         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
 529
 530         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
 531         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
 532         (Foo.prototype.method1):
 533         (Foo.prototype.method2):
 534         (Foo.prototype.method3.innerFunction):
 535         (Foo.prototype.method3):
 536         (insideGlobalAnonymousFunctionExpression):
 537         (foo.insideGlobalFunctionExpression):
 538         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
 539         (IssueWithMapGetAndSet.prototype.method1):
 540         (IssueWithMapGetAndSet.prototype.method2):
 541         (IssueWithMapGetAndSet.prototype.method3):
 542         (IssueWithMapGetAndSet):
 543
 544 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
 545
 546         [ES6] Enable ES6 Module in JSC shell by default
 547         https://bugs.webkit.org/show_bug.cgi?id=148689
 548
 549         Reviewed by Geoffrey Garen.
 550
 551         * Scripts/run-javascriptcore-tests:
 552         (runJSCStressTests):
 553         * Scripts/run-jsc-stress-tests:
 554
 555 2015-09-04  Basile Clement  <basile_clement@apple.com>
 556
 557         Unreviewed, change my email address.
 558
 559         * Scripts/webkitpy/common/config/contributors.json:
 560
 561 2015-09-04  Beth Dakin  <bdakin@apple.com>
 562
 563         Should have a test to make sure links don't navigate after a cancelled force
 564         click
 565         https://bugs.webkit.org/show_bug.cgi?id=148846
 566
 567         Reviewed by Tim Horton.
 568
 569         New EventSender function for a started then cancelled force click.
 570         * WebKitTestRunner/EventSenderProxy.h:
 571         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
 572         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 573         (WTR::EventSendingController::mouseForceClick):
 574         (WTR::EventSendingController::startAndCancelMouseForceClick):
 575         (WTR::EventSendingController::mouseForceDown):
 576         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
 577         * WebKitTestRunner/TestController.cpp:
 578         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
 579         * WebKitTestRunner/mac/EventSenderProxy.mm:
 580         (WTR::EventSenderProxy::mouseForceClick):
 581         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
 582         (WTR::EventSenderProxy::mouseForceDown):
 583         (WTR::EventSenderProxy::mouseMoveTo):
 584
 585 2015-09-04  Tim Horton  <timothy_horton@apple.com>
 586
 587         Add a test for r179736 (programmatic navigation during swipe causing a crash)
 588         https://bugs.webkit.org/show_bug.cgi?id=148830
 589
 590         Reviewed by Beth Dakin.
 591
 592         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 593         (WTR::InjectedBundle::beginTesting):
 594         Make sure that TestRunner callbacks don't leak between tests!
 595
 596 2015-09-04  Anders Carlsson  <andersca@apple.com>
 597
 598         It should be possible to pass relative HTTP test paths to DumpRenderTree
 599         https://bugs.webkit.org/show_bug.cgi?id=148825
 600         <rdar://problem/22583866>
 601
 602         Reviewed by Tim Horton.
 603
 604         Convert the path to an absolute path if needed.
 605
 606         * DumpRenderTree/mac/DumpRenderTree.mm:
 607         (computeTestURL):
 608
 609 2015-09-04  Jason Marcell  <jmarcell@apple.com>
 610
 611         Fix Swift unit tests for prepare-ChangeLog.
 612         https://bugs.webkit.org/show_bug.cgi?id=148817
 613
 614         Reviewed by Alexey Proskuryakov.
 615
 616         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
 617         Swift unit tests for prepare-ChangeLog.
 618
 619 2015-09-04  Lucas Forschler  <lforschler@apple.com>
 620
 621         Modifications to the webkit-nightly logic.
 622
 623         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
 624         (updateAlertPanel):
 625         * WebKitLauncher/main.m:
 626         (displayErrorAndQuit):
 627
 628 2015-09-04  Beth Dakin  <bdakin@apple.com>
 629
 630         Speculative build fix.
 631
 632         * WebKitTestRunner/mac/EventSenderProxy.mm:
 633
 634 2015-09-04  Brian Burg  <bburg@apple.com>
 635
 636         Web Inspector: InspectorController should support multiple frontend channels
 637         https://bugs.webkit.org/show_bug.cgi?id=148538
 638
 639         Reviewed by Joseph Pecoraro.
 640
 641         InspectorClients must explicitly disconnect their frontend channel(s) from the
 642         inspected page's InspectorController.
 643
 644         To make this possible, DumpRenderTree should not destroy non-primary views until
 645         it has tried to close any abandoned Web Inspector instances. Performing teardown
 646         in the reverse order prevents disconnection of the frontend channel because that
 647         prematurely destroys the inspector frontend client.
 648
 649         * DumpRenderTree/mac/DumpRenderTree.mm:
 650         (runTest):
 651         * DumpRenderTree/win/DumpRenderTree.cpp:
 652         (runTest):
 653
 654 2015-09-04  Beth Dakin  <bdakin@apple.com>
 655
 656         Need to be able to test default behaviors on force click
 657         https://bugs.webkit.org/show_bug.cgi?id=148758
 658
 659         Reviewed by Tim Horton.
 660
 661         This patch adds a new eventSender method to do a full, completed force click,
 662         and it re-works all of the existing force methods to dispatch their events in
 663         such a way that they will trigger the NSImmediateAction gesture recognizer.
 664         To do this, first we need to send the events to the app rather than straight
 665         to the view, and also needed to tweak some state and send the events in a
 666         delayed fashion.
 667
 668         New public function mouseForceClick() and private helper functions to make
 669         NSEvents.
 670         * WebKitTestRunner/EventSenderProxy.h:
 671
 672         New public function mouseForceClick().
 673         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
 674         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 675         (WTR::EventSendingController::mouseMoveTo):
 676         (WTR::EventSendingController::mouseForceClick):
 677         (WTR::EventSendingController::mouseForceDown):
 678         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
 679         * WebKitTestRunner/TestController.cpp:
 680         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
 681
 682         initPressureEventAtLocation needs to take a stageTransition and a window.
 683         * WebKitTestRunner/mac/EventSenderProxy.mm:
 684         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
 685         (-[EventSenderSyntheticEvent stageTransition]):
 686         (-[EventSenderSyntheticEvent timestamp]):
 687         (-[EventSenderSyntheticEvent _cgsEventRecord]):
 688         (-[EventSenderSyntheticEvent window]):
 689
 690         In order to enter the gesture recognizer, we need to start with a mouse down
 691         that has a NSEventMaskPressure modifier.
 692         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
 693
 694         This ensures that the events queue properly for the force monitor in AppKit.
 695         (WTR::spinRunLoopForForce):
 696
 697          We need to start the pressure change events with a began.
 698         (WTR::EventSenderProxy::beginPressureEvent):
 699
 700         These functions can be used to create the NSEvent for a pressure change every
 701         time we need one.
 702         (WTR::EventSenderProxy::pressureChangeEvent):
 703
 704         Send the right series of events to emulate a full, completed force click.
 705         (WTR::EventSenderProxy::mouseForceClick):
 706
 707         Use all of the new things for these existing functions.
 708         (WTR::EventSenderProxy::mouseForceDown):
 709         (WTR::EventSenderProxy::mouseForceUp):
 710         (WTR::EventSenderProxy::mouseForceChanged):
 711
 712         Set NSFakeForceTouchDevice to YES.
 713         * WebKitTestRunner/mac/main.mm:
 714         (setDefaultsToConsistentValuesForTesting):
 715
 716 2015-09-04  Jason Marcell  <jmarcell@apple.com>
 717
 718         prepare-ChangeLog needs to know how to parse Swift files.
 719         https://bugs.webkit.org/show_bug.cgi?id=148784
 720         <rdar://problem/22510062>
 721
 722         Reviewed by Darin Adler.
 723
 724         * Scripts/prepare-ChangeLog:
 725         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
 726         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
 727         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
 728         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
 729         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
 730         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
 731         (freeFunction): Ditto.
 732         (MyClass.function): Ditto.
 733         (MyClass.functionWithArgument(_:)): Ditto.
 734         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
 735         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
 736         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
 737         (MyClass.classFunction): Ditto.
 738         (MyClass.readWriteComputedVariable): Ditto.
 739         (MyClass.readOnlyComputedVariable): Ditto.
 740
 741 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
 742
 743         Import css/css-color-3
 744         https://bugs.webkit.org/show_bug.cgi?id=148803
 745
 746         Reviewed by Chris Dumez.
 747
 748         Fixed a bug that the imported reference files used the same extention as tests.
 749         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
 750
 751         * Scripts/webkitpy/w3c/test_importer.py:
 752         (TestImporter.find_importable_tests):
 753
 754 2015-09-03  Commit Queue  <commit-queue@webkit.org>
 755
 756         Unreviewed, rolling out r189338.
 757         https://bugs.webkit.org/show_bug.cgi?id=148785
 758
 759         Caused tons of crashes (Requested by cdumez on #webkit).
 760
 761         Reverted changeset:
 762
 763         "Web Inspector: InspectorController should support multiple
 764         frontend channels"
 765         https://bugs.webkit.org/show_bug.cgi?id=148538
 766         http://trac.webkit.org/changeset/189338
 767
 768 2015-09-03  Brian Burg  <bburg@apple.com>
 769
 770         Web Inspector: InspectorController should support multiple frontend channels
 771         https://bugs.webkit.org/show_bug.cgi?id=148538
 772
 773         Reviewed by Joseph Pecoraro.
 774
 775         InspectorClients must explicitly disconnect their frontend channel(s) from the
 776         inspected page's InspectorController.
 777
 778         To make this possible, DumpRenderTree should not destroy non-primary views until
 779         it has tried to close any abandoned Web Inspector instances. Performing teardown
 780         in the reverse order prevents disconnection of the frontend channel because that
 781         prematurely destroys the inspector frontend client.
 782
 783         * DumpRenderTree/mac/DumpRenderTree.mm:
 784         (runTest):
 785         * DumpRenderTree/win/DumpRenderTree.cpp:
 786         (runTest):
 787
 788 2015-09-03  Timothy Hatcher  <timothy@apple.com>
 789
 790         Update WebKit nightly icon to be more like Safari
 791         https://bugs.webkit.org/show_bug.cgi?id=148768
 792
 793         Reviewed by Joseph Pecoraro.
 794
 795         * WebKitLauncher/webkit.icns:
 796
 797 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
 798
 799         JavaScriptCore should have some ES6 conformance tests
 800         https://bugs.webkit.org/show_bug.cgi?id=148771
 801
 802         Reviewed by Chris Dumez.
 803
 804         * Scripts/run-javascriptcore-tests:
 805         (runJSCStressTests): Added es6 as a test suite.
 806
 807         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
 808
 809         Some of these tests currently fail, so I also added a way to expect
 810         failure for now. We'll migrate failing tests to expected passes as we
 811         fix them.
 812
 813 2015-09-03  Tim Horton  <timothy_horton@apple.com>
 814
 815         Add a test for swipe-start hysteresis
 816         https://bugs.webkit.org/show_bug.cgi?id=148756
 817
 818         Reviewed by Anders Carlsson.
 819
 820         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 821         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 822         (WTR::cacheTestRunnerCallback):
 823         (WTR::TestRunner::clearTestRunnerCallbacks):
 824         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 825         Make sure that we log if a client tries to install a callback twice
 826         (since we use .add, the second call would not work).
 827
 828         Also, add clearTestRunnerCallbacks so tests can swap out installed
 829         callbacks.
 830
 831 2015-09-03  Anders Carlsson  <andersca@apple.com>
 832
 833         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
 834         https://bugs.webkit.org/show_bug.cgi?id=148746
 835         rdar://problem/22568073
 836
 837         Reviewed by Tim Horton.
 838
 839         * DumpRenderTree/mac/DumpRenderTree.mm:
 840         (computeTestURL):
 841         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
 842
 843         (runTest):
 844         Call computeTestURL.
 845
 846         (testPathFromURL):
 847         Get rid of this; computeTestURL does this for us now.
 848
 849         * Scripts/webkitpy/port/driver.py:
 850         (Driver._command_from_driver_input):
 851         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
 852
 853 2015-09-03  Tim Horton  <timothy_horton@apple.com>
 854
 855         Swipe tests fail on Mavericks
 856         https://bugs.webkit.org/show_bug.cgi?id=148752
 857
 858         Reviewed by Beth Dakin.
 859
 860         * WebKitTestRunner/mac/EventSenderProxy.mm:
 861
 862 2015-09-03  Tim Horton  <timothy_horton@apple.com>
 863
 864         Fix the 32-bit build
 865
 866         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 867         (WTR::PlatformWebView::setNavigationGesturesEnabled):
 868
 869 2015-09-03  Tim Horton  <timothy_horton@apple.com>
 870
 871         Remove some logging that wasn't meant to be in the tree
 872
 873         * WebKitTestRunner/mac/EventSenderProxy.mm:
 874         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
 875
 876 2015-09-03  Tim Horton  <timothy_horton@apple.com>
 877
 878         [Mac] Add support for testing swipes
 879         https://bugs.webkit.org/show_bug.cgi?id=148700
 880
 881         Reviewed by Beth Dakin.
 882
 883         * WebKitTestRunner/EventSenderProxy.h:
 884         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
 885         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 886         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 887         (WTR::cgEventPhaseFromString):
 888         (WTR::cgEventMomentumPhaseFromString):
 889         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
 890         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
 891         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
 892         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 893         (WTR::InjectedBundle::didReceiveMessageToPage):
 894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 895         (WTR::TestRunner::installDidBeginSwipeCallback):
 896         (WTR::TestRunner::installWillEndSwipeCallback):
 897         (WTR::TestRunner::installDidEndSwipeCallback):
 898         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
 899         (WTR::TestRunner::callDidBeginSwipeCallback):
 900         (WTR::TestRunner::callWillEndSwipeCallback):
 901         (WTR::TestRunner::callDidEndSwipeCallback):
 902         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
 903         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 904         * WebKitTestRunner/TestController.cpp:
 905         (WTR::TestController::createOtherPage):
 906         (WTR::TestController::createWebViewWithOptions):
 907         (WTR::TestController::didReceiveMessageFromInjectedBundle):
 908         (WTR::TestController::didBeginNavigationGesture):
 909         (WTR::TestController::willEndNavigationGesture):
 910         (WTR::TestController::didEndNavigationGesture):
 911         (WTR::TestController::didRemoveNavigationGestureSnapshot):
 912         * WebKitTestRunner/TestController.h:
 913         * WebKitTestRunner/TestInvocation.cpp:
 914         (WTR::TestInvocation::didBeginSwipe):
 915         (WTR::TestInvocation::willEndSwipe):
 916         (WTR::TestInvocation::didEndSwipe):
 917         (WTR::TestInvocation::didRemoveSwipeSnapshot):
 918         * WebKitTestRunner/TestInvocation.h:
 919         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
 920         when the snapshot is removed.
 921
 922         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
 923         mouseScrollBy function.
 924
 925         * WebKitTestRunner/mac/EventSenderProxy.mm:
 926         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
 927         (-[EventSenderSyntheticEvent type]):
 928         (-[EventSenderSyntheticEvent subtype]):
 929         (-[EventSenderSyntheticEvent locationInWindow]):
 930         (-[EventSenderSyntheticEvent location]):
 931         (-[EventSenderSyntheticEvent momentumPhase]):
 932         (-[EventSenderSyntheticEvent _isTouchesEnded]):
 933         (-[EventSenderSyntheticEvent _cgsEventRecord]):
 934         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
 935         more adjustable values.
 936
 937         (WTR::EventSenderProxy::mouseForceDown):
 938         (WTR::EventSenderProxy::mouseForceUp):
 939         (WTR::EventSenderProxy::mouseForceChanged):
 940         Adopt EventSenderSyntheticEvent.
 941
 942         (WTR::nsEventPhaseFromCGEventPhase):
 943         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
 944         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
 945
 946         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 947         (WTR::PlatformWebView::PlatformWebView):
 948         Enable swipe.
 949
 950 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
 951
 952         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
 953         https://bugs.webkit.org/show_bug.cgi?id=148723
 954
 955         Reviewed by Anders Carlsson.
 956
 957         * WebKitTestRunner/TestController.cpp:
 958         (WTR::testPath):
 959         (WTR::updateViewOptionsFromTestHeader):
 960         (WTR::TestController::viewOptionsForTest):
 961
 962 2015-09-03  Lucas Forschler  <lforschler@apple.com>
 963
 964         Test commit.
 965
 966 2015-09-02  Tim Horton  <timothy_horton@apple.com>
 967
 968         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
 969         https://bugs.webkit.org/show_bug.cgi?id=148693
 970
 971         Reviewed by Anders Carlsson.
 972
 973         * WebKitTestRunner/TestController.cpp:
 974         (WTR::TestController::createOtherPage):
 975         (WTR::TestController::createWebViewWithOptions):
 976
 977 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
 978
 979         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
 980         https://bugs.webkit.org/show_bug.cgi?id=148529
 981
 982         Reviewed by Darin Adler.
 983
 984         When there are pending EventSender messages after a test finishes,
 985         they could be processed in the main loop started by the
 986         resetStateToConsistentValues(), but the old EventSender has been
 987         replaced by a new one at that point. The new Eventsender can crash
 988         when processing messages that were sent to the old one. To avoid
 989         this, we return early when receiving an EventSender message and
 990         the TestController state is not RunningTest.
 991
 992         * WebKitTestRunner/TestController.cpp:
 993         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
 994         (WTR::TestController::didReceiveMessageFromInjectedBundle):
 995
 996 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
 997
 998         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
 999         https://bugs.webkit.org/show_bug.cgi?id=148528
1000
1001         Reviewed by Darin Adler.
1002
1003         Before r188548 resetStateToConsistentValues() was called in
1004         TestController::run(), before tests are run, but now it's called
1005         for every test in TestInvocation::invoke(), after m_status has
1006         changed to RunningTest.
1007
1008         * WebKitTestRunner/TestController.cpp:
1009         (WTR::TestController::resetStateToConsistentValues): Use
1010         TemporaryChange to reset m_state ot its previous value after reset
1011         is done.
1012
1013 2015-08-31  Jason Marcell  <jmarcell@apple.com>
1014
1015         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
1016         that are marked as requiring corresponding tests.
1017         https://bugs.webkit.org/show_bug.cgi?id=148498
1018         <rdar://problem/21555314>
1019
1020         Reviewed by Dan Bernstein and David Kilzer.
1021
1022         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
1023         simulate Git's attribute behevaior.
1024         (main): Added "requiresTests" array to contain files that require tests.
1025         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
1026         section in ChangeLog.
1027         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
1028         however, we check if the file or any containing folder has the given property set to "1" and
1029         return 1 if so; return 0 otherwise.
1030         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
1031         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
1032
1033 2015-08-26  Andy Estes  <aestes@apple.com>
1034
1035         [Content Filtering] Determine navigation and content policy before continuing to filter a load
1036         https://bugs.webkit.org/show_bug.cgi?id=148506
1037
1038         Reviewed by Brady Eidson.
1039
1040         Added download API tests covering every decision and decision point.
1041         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
1042
1043         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
1044         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
1045         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1046         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
1047         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
1048         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
1049         decision and decision point as a bundle parameter.
1050         (+[MockContentFilterEnabler supportsSecureCoding]):
1051         (-[MockContentFilterEnabler copyWithZone:]):
1052         (-[MockContentFilterEnabler initWithCoder:]):
1053         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
1054         (-[MockContentFilterEnabler encodeWithCoder:]):
1055         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
1056         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
1057         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
1058         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
1059         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
1060         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
1061         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
1062         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
1063         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
1064         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
1065         (+[MockContentFilterEnabler supportsSecureCoding]):
1066         (-[MockContentFilterEnabler copyWithZone:]):
1067         (-[MockContentFilterEnabler initWithCoder:]):
1068         (-[MockContentFilterEnabler dealloc]):
1069         (-[MockContentFilterEnabler encodeWithCoder:]):
1070         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
1071         (-[ContentFilteringPlugIn dealloc]): Stop observing.
1072         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
1073         (+[ServerRedirectPlugIn initialize]): Deleted.
1074         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1075         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1076         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
1077         (TEST): Deleted.
1078
1079 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
1080
1081         Skip slow lock tests on Windows/debug
1082         https://bugs.webkit.org/show_bug.cgi?id=148643
1083
1084         Reviewed by Alexey Proskuryakov.
1085
1086         The lock tests simulate a critical section by doing some floating point math, and then either
1087         make those critical sections very long or invoke them many times. This appears to be
1088         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
1089         that kind of computation slow.
1090
1091         These tests are almost as useful in release as they are in debug, so it's probably better to
1092         just skip the in debug on platforms where this causes timeouts.
1093
1094         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1095         (TestWebKitAPI::runLockTest):
1096         (TestWebKitAPI::skipSlow):
1097         (TestWebKitAPI::TEST):
1098
1099 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
1100
1101         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
1102         https://bugs.webkit.org/show_bug.cgi?id=125720
1103
1104         Reviewed by Daniel Bates.
1105
1106         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
1107
1108         * DumpRenderTree/AccessibilityUIElement.cpp:
1109         (pressCallback):
1110         (scrollToMakeVisibleWithSubFocusCallback):
1111         (scrollToGlobalPointCallback):
1112         (scrollToMakeVisibleCallback):
1113         (AccessibilityUIElement::getJSClass):
1114         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1115         (AccessibilityUIElement::scrollToMakeVisible):
1116         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1117         (AccessibilityUIElement::scrollToGlobalPoint):
1118         (AccessibilityUIElement::selectedTextRange):
1119         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1120         (AccessibilityUIElement::AccessibilityUIElement):
1121         (AccessibilityUIElement::mathPrescriptsDescription):
1122         (AccessibilityUIElement::scrollToMakeVisible):
1123         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1124         (AccessibilityUIElement::scrollToGlobalPoint):
1125         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1126         (WTR::AccessibilityUIElement::isTextMarkerValid):
1127         (WTR::AccessibilityUIElement::textMarkerForIndex):
1128         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1129         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1130         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1131         (WTR::AccessibilityUIElement::supportedActions):
1132         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1133         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1135         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1136         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1137         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1138         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1139         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1140         (WTR::AccessibilityUIElement::selectedTextRange):
1141         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1142         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1143         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1144         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1145         (WTR::AccessibilityUIElement::selectedTextRange):
1146
1147 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1148
1149         Add a mysteriously nonproblematic missing comma.
1150
1151         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1152         (TestExpectationParser._collect_matching_tests):
1153         (TestExpectationParser):
1154
1155 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1156
1157         Remove an old temporary script that has served its purpose
1158
1159         * Scripts/convert-test-expectations: Removed.
1160
1161 2015-08-28  Jer Noble  <jer.noble@apple.com>
1162
1163         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
1164         https://bugs.webkit.org/show_bug.cgi?id=148579
1165
1166         Reviewed by Anders Carlsson.
1167
1168         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
1169
1170         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
1171         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
1172
1173         * DumpRenderTree/mac/DumpRenderTree.mm:
1174         (resetWebPreferencesToConsistentValues):
1175         (resetWebViewToConsistentStateBeforeTesting):
1176         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1177         (WTR::initializeWebViewConfiguration):
1178
1179 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1180
1181         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
1182         https://bugs.webkit.org/show_bug.cgi?id=148592
1183
1184         Reviewed by Tim Horton.
1185
1186         * Scripts/webkitpy/port/base.py:
1187         (Port.to.setup_environ_for_server):
1188         (Port.to):
1189         (Port.to._append_value_colon_separated):
1190         (Port.to.show_results_html_file):
1191         * Scripts/webkitpy/port/ios.py:
1192         (IOSSimulatorPort.setup_environ_for_server):
1193         * Scripts/webkitpy/port/mac.py:
1194         (MacPort.setup_environ_for_server):
1195
1196 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
1197
1198         LICM should be sound even if the CFG has changed
1199         https://bugs.webkit.org/show_bug.cgi?id=148259
1200
1201         Reviewed by Benjamin Poulain.
1202
1203         Add a utility for creating tests that set some uncommon option.
1204
1205         * Scripts/run-jsc-stress-tests:
1206
1207 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
1208
1209         [Win] Unreviewed EWS correction.
1210
1211         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
1212
1213 2015-08-28  Jer Noble  <jer.noble@apple.com>
1214
1215         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
1216         https://bugs.webkit.org/show_bug.cgi?id=147512
1217
1218         Reviewed by Anders Carlsson.
1219
1220         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
1221         to a consistent (true) value.
1222
1223         * DumpRenderTree/mac/DumpRenderTree.mm:
1224         (setDefaultsToConsistentValuesForTesting):
1225         * WebKitTestRunner/TestController.cpp:
1226         (WTR::TestController::resetPreferencesToConsistentValues):
1227
1228 2015-08-28  Tim Horton  <timothy_horton@apple.com>
1229
1230         Add navigation gesture callbacks to WKPageNavigationClient
1231         https://bugs.webkit.org/show_bug.cgi?id=148568
1232         <rdar://problem/22371346>
1233
1234         Reviewed by Anders Carlsson.
1235
1236         * WebKitTestRunner/TestController.cpp:
1237         (WTR::TestController::createOtherPage):
1238         (WTR::TestController::createWebViewWithOptions):
1239         Add some zeroes.
1240
1241 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1242
1243         [Mac] kill-old-processes should kill more processes
1244         https://bugs.webkit.org/show_bug.cgi?id=148577
1245
1246         Reviewed by Tim Horton.
1247
1248         * BuildSlaveSupport/kill-old-processes:
1249
1250 2015-08-28  Jason Marcell  <jmarcell@apple.com>
1251
1252         The status message for combined builder queues should say "all builds succeeded" if everything
1253         built correctly.
1254         https://bugs.webkit.org/show_bug.cgi?id=148535
1255
1256         Reviewed by David Kilzer and Alexey Proskuryakov.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1259         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
1260         say "all builds succeeded" if everything built correctly.
1261
1262 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1263
1264         [GTK] Simplify the internal API to create a WebView
1265         https://bugs.webkit.org/show_bug.cgi?id=148570
1266
1267         Reviewed by Žan Doberšek.
1268
1269         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
1270         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1271         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
1272         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
1273         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
1274         passing the received PageConfiguration.
1275         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1276         (WTR::PlatformWebView::PlatformWebView): Create the WebView
1277         passing the received PageConfiguration.
1278
1279 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
1280
1281         iOS Simulator API tests fails as Simulator is not running
1282         https://bugs.webkit.org/show_bug.cgi?id=148501
1283         rdar://problem/22447525
1284
1285         Reviewed by Daniel Bates.
1286
1287         This change is a workaround for <rdar://problem/22388812>.
1288
1289          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
1290          and quit it on program termination when running tests on the iOS port.
1291          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
1292          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
1293
1294 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1295
1296         Make DLLLauncherMain executables dependent on dll
1297         https://bugs.webkit.org/show_bug.cgi?id=148548
1298
1299         Reviewed by Brent Fulgham.
1300
1301         * DumpRenderTree/CMakeLists.txt:
1302         * DumpRenderTree/PlatformWin.cmake:
1303         * MiniBrowser/win/CMakeLists.txt:
1304         * TestWebKitAPI/CMakeLists.txt:
1305         * TestWebKitAPI/PlatformWin.cmake:
1306
1307 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1308
1309         Remove Mac slaves 188/189 after being replaced with 400/401.
1310
1311         Unreviewed.
1312
1313         * BuildSlaveSupport/build.webkit.org-config/config.json:
1314
1315 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1316
1317         Add two bots to the Mac Yosemite queue.
1318         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
1319
1320         Unreviewed.
1321
1322         * BuildSlaveSupport/build.webkit.org-config/config.json:
1323
1324 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1325
1326         [Win CMake] Fix incremental build after r188673
1327         https://bugs.webkit.org/show_bug.cgi?id=148539
1328
1329         Reviewed by Brent Fulgham.
1330
1331         * TestWebKitAPI/PlatformWin.cmake:
1332         Copy forwarding headers from WebCore before building in case that was not yet done.
1333         It used to be done when running CMake, but now it's a build step.
1334
1335 2015-08-27  Nan Wang  <n_wang@apple.com>
1336
1337         AX: Fix accessibility/select-element-at-index.html test
1338         https://bugs.webkit.org/show_bug.cgi?id=148516
1339
1340         Reviewed by Chris Fleizach.
1341
1342         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
1343
1344         * DumpRenderTree/AccessibilityUIElement.cpp:
1345         (setSelectedChildCallback):
1346         (setSelectedChildAtIndexCallback):
1347         (removeSelectionAtIndexCallback):
1348         (elementAtPointCallback):
1349         (sentenceAtOffsetCallback):
1350         (stringForSelectionCallback):
1351         (AccessibilityUIElement::getJSClass):
1352         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1353         (AccessibilityUIElement::setSelectedChild):
1354         (AccessibilityUIElement::setSelectedChildAtIndex):
1355         (AccessibilityUIElement::removeSelectionAtIndex):
1356         (AccessibilityUIElement::accessibilityValue):
1357         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1358         (WTR::AccessibilityUIElement::wordAtOffset):
1359         (WTR::AccessibilityUIElement::lineAtOffset):
1360         (WTR::AccessibilityUIElement::sentenceAtOffset):
1361         (WTR::AccessibilityUIElement::isSelectable):
1362         (WTR::AccessibilityUIElement::isMultiSelectable):
1363         (WTR::AccessibilityUIElement::setSelectedChild):
1364         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1365         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1366         (WTR::AccessibilityUIElement::selectedChildrenCount):
1367         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1368         (WTR::AccessibilityUIElement::isExpanded):
1369         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1370         (WTR::AccessibilityUIElement::setSelectedChild):
1371         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1372         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1373         (WTR::AccessibilityUIElement::accessibilityValue):
1374
1375 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1376
1377         Build fix after r188982
1378
1379         * MiniBrowser/win/CMakeLists.txt:
1380         The directory structure changed in the move.
1381
1382 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1383
1384         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
1385
1386         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
1387
1388         * gtk/install-dependencies:
1389
1390 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1391
1392         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
1393
1394         * Scripts/run-gtk-tests:
1395         (TestRunner):
1396
1397 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1398
1399         Fix GTK+ WTR crashes in initializeMainRunLoop()
1400
1401         Rubber-stamped by Žan Doberšek.
1402
1403         Initialize threading and main thread before
1404         RunLoop::initializeMainRunLoop(), since the GLib implementation of
1405         the RunLoop uses isMainThread() to decide whether to create a new
1406         GMainContext or use the default one. Also use RunLoop::run() and
1407         ::stop() instead of gtk_main/quit.
1408
1409         * WebKitTestRunner/TestController.cpp:
1410         (WTR::TestController::initialize):
1411         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1412         (WTR::TestController::notifyDone):
1413         (WTR::TestController::platformRunUntil):
1414
1415 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
1416
1417         Unreviewed, further shorten a test that times out because it's very long
1418         running.
1419
1420         I've locally run these tests on repeat for 24 hours and found no genuine
1421         failures, like deadlocks. So, the timeouts are probably because the test
1422         machine is slow and debug is slow. We should just run this test for fewer
1423         iterations.
1424
1425         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1426         (TestWebKitAPI::TEST):
1427
1428 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
1429
1430         Unreviewed build fix attempt on EFL
1431
1432         * WebKitTestRunner/PlatformEfl.cmake:
1433
1434 2015-08-26  Alex Christensen  <achristensen@webkit.org>
1435
1436         Build fix after r188982
1437
1438         * MiniBrowser/win/CMakeLists.txt:
1439         Find .rc files in correct directory.
1440
1441 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
1442
1443         [EFL] Bump cairo version to 1.14.2
1444         https://bugs.webkit.org/show_bug.cgi?id=148474
1445
1446         Reviewed by Csaba Osztrogonác.
1447
1448         * efl/jhbuild.modules:
1449
1450 2015-08-26  Andy Estes  <aestes@apple.com>
1451
1452         Crash when following a Google search link to Twitter with Limit Adult Content enabled
1453         https://bugs.webkit.org/show_bug.cgi?id=147651
1454
1455         Rubber-stamped by Brady Eidson.
1456
1457         Taught TestRunner how to decide the navigation policy after a delay.
1458
1459         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1460         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1461         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1462         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1463         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1464         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1465         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
1466         * WebKitTestRunner/TestController.cpp:
1467         (WTR::TestController::initialize):
1468         (WTR::TestController::resetStateToConsistentValues):
1469         (WTR::TestController::decidePolicyForNavigationAction):
1470         * WebKitTestRunner/TestController.h:
1471         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
1472         * WebKitTestRunner/TestInvocation.cpp:
1473         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1474
1475 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
1476
1477         [Win] Rename 'WinLauncher' to 'MiniBrowser'
1478         https://bugs.webkit.org/show_bug.cgi?id=148485
1479
1480         Reviewed by Alex Christensen
1481
1482         Move the WinLauncher project and source files to a subdirectory
1483         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
1484         source code and project files.
1485
1486         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
1487         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
1488         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
1489         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
1490         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
1491         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
1492         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
1493         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
1494         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
1495         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
1496         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
1497         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
1498         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
1499         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
1500         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
1501         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
1502         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
1503         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
1504         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
1505         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
1506         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
1507         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
1508         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
1509         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
1510         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
1511         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
1512         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
1513         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
1514         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
1515         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
1516         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
1517         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
1518         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
1519         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
1520         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1521         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
1522         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
1523         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1524         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1525         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
1526         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
1527         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
1528         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
1529         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
1530         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
1531         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
1532         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
1533         * MiniBrowser/win: Copied from WinLauncher.
1534         * MiniBrowser/win/Common.cpp:
1535         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
1536         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
1537         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
1538         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
1539         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
1540         * MiniBrowser/win/PageLoadTestClient.cpp:
1541         * MiniBrowser/win/PageLoadTestClient.h:
1542         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1543         * MiniBrowser/win/ResourceLoadDelegate.h:
1544         * MiniBrowser/win/WinLauncher.cpp: Removed.
1545         * MiniBrowser/win/WinLauncher.h: Removed.
1546         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
1547         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1548         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1549         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1550         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1551         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1552         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1553         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1554         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1555         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1556         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1557         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1558         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1559         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1560         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1561         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1562         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1563         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1564         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1565         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1566         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1567         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1568         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1569         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1570         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
1571         * MiniBrowser/win/WinLauncherReplace.h: Removed.
1572         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
1573         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
1574         * MiniBrowser/win/WinMain.cpp:
1575         * WinLauncher: Removed.
1576         * WinLauncher/AccessibilityDelegate.cpp: Removed.
1577         * WinLauncher/AccessibilityDelegate.h: Removed.
1578         * WinLauncher/CMakeLists.txt: Removed.
1579         * WinLauncher/Common.cpp: Removed.
1580         * WinLauncher/DOMDefaultImpl.cpp: Removed.
1581         * WinLauncher/DOMDefaultImpl.h: Removed.
1582         * WinLauncher/PageLoadTestClient.cpp: Removed.
1583         * WinLauncher/PageLoadTestClient.h: Removed.
1584         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
1585         * WinLauncher/PrintWebUIDelegate.h: Removed.
1586         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
1587         * WinLauncher/ResourceLoadDelegate.h: Removed.
1588         * WinLauncher/WebDownloadDelegate.cpp: Removed.
1589         * WinLauncher/WebDownloadDelegate.h: Removed.
1590         * WinLauncher/WinLauncher.cpp: Removed.
1591         * WinLauncher/WinLauncher.h: Removed.
1592         * WinLauncher/WinLauncher.vcxproj: Removed.
1593         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1594         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1595         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1596         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1597         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1598         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1599         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1600         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1601         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1602         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1603         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1604         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1605         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1606         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1607         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1608         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1609         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1610         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1611         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1612         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1613         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1614         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1615         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1616         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
1617         * WinLauncher/WinLauncherReplace.h: Removed.
1618         * WinLauncher/WinLauncherWebHost.cpp: Removed.
1619         * WinLauncher/WinLauncherWebHost.h: Removed.
1620         * WinLauncher/WinMain.cpp: Removed.
1621         * WinLauncher/resource.h: Removed.
1622         * WinLauncher/stdafx.cpp: Removed.
1623         * WinLauncher/stdafx.h: Removed.
1624         * win/AssembleBuildLogs/AssembleLogs.cmd:
1625
1626 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
1627
1628         [Win] Simplify menu handling code in WinLauncher
1629         https://bugs.webkit.org/show_bug.cgi?id=148461
1630
1631         Reviewed by Zalan Bujtas.
1632
1633         Revise 'ToggleMenuItem' to return a boolean value indicating if
1634         it handled the message. Revise WndProc to use this to decide if it
1635         should pass the message on to the default handler, rather than
1636         duplicating the logic in both places.
1637
1638         * WinLauncher/Common.cpp:
1639         (ToggleMenuItem): Return true if the menu item message was handled.
1640         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
1641         the message tothe default handler.
1642
1643 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1644
1645         Remove unused code after r188948
1646         https://bugs.webkit.org/show_bug.cgi?id=148467
1647
1648         Reviewed by Gyuyoung Kim.
1649
1650         * WebKitTestRunner/TestController.cpp:
1651         (WTR::TestController::platformPreferences): Deleted.
1652
1653 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1654
1655         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
1656         https://bugs.webkit.org/show_bug.cgi?id=148377
1657
1658         Reviewed by Carlos Garcia Campos.
1659
1660         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
1661         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
1662         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
1663         EFL and GTK at the moment.
1664
1665         * WebKitTestRunner/TestController.cpp:
1666         (WTR::TestController::platformWillRunTest):
1667         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1668         (WTR::TestController::platformPreferences):
1669         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1670         (WTR::TestController::platformPreferences):
1671
1672 2015-08-25  Nan Wang  <n_wang@apple.com>
1673
1674         AX: Enable accessibility/aria-controls.html test for mac
1675         https://bugs.webkit.org/show_bug.cgi?id=148458
1676
1677         Reviewed by Chris Fleizach.
1678
1679         Implemented ariaControlsElementAtIndex(unsigned index).
1680
1681         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1682         (AccessibilityUIElement::ariaControlsElementAtIndex):
1683         (AccessibilityUIElement::disclosedRowAtIndex):
1684         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1685         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1686
1687 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1688
1689         Remove python tests for PassRefPtr
1690         https://bugs.webkit.org/show_bug.cgi?id=148463
1691
1692         Reviewed by Andy Estes.
1693
1694         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
1695
1696         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1697         (PassPtrTest): Deleted.
1698         (PassPtrTest.assert_pass_ptr_check): Deleted.
1699         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
1700         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
1701         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1702         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
1703         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
1704         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
1705
1706 2015-08-25  Andy Estes  <aestes@apple.com>
1707
1708         [iOS] run-webkit-tests fails if watchOS SDK is installed
1709         https://bugs.webkit.org/show_bug.cgi?id=148453
1710
1711         Reviewed by David Kilzer.
1712
1713         * Scripts/webkitpy/xcode/simulator.py:
1714         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
1715         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1716
1717 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
1718
1719         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
1720         https://bugs.webkit.org/show_bug.cgi?id=148197
1721         rdar://problem/22334382
1722
1723         Reviewed by Daniel Bates.
1724
1725         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
1726         * Scripts/webkitpy/port/ios.py:
1727         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
1728         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
1729         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
1730         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
1731         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
1732
1733 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1734
1735         Remove PassRefPtr style check rule
1736         https://bugs.webkit.org/show_bug.cgi?id=148432
1737
1738         Reviewed by Andreas Kling.
1739
1740         PassRefPtr is being removed. Thus style rule needs to be removed as well.
1741
1742         * Scripts/webkitpy/style/checkers/cpp.py:
1743         (_check_parameter_name_against_text): Deleted.
1744         (check_function_definition_and_pass_ptr): Deleted.
1745         (check_function_definition): Deleted.
1746         (check_pass_ptr_usage): Deleted.
1747         (process_line): Deleted.
1748         (CppChecker): Deleted.
1749
1750 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
1751
1752         [Win] Expose "Inverted Colors" option in WinLauncher
1753         https://bugs.webkit.org/show_bug.cgi?id=148451
1754
1755         Reviewed by Tim Horton.
1756
1757         Add the ability to toggle the "Inverted Colors" preference
1758         in WinLauncher.
1759
1760         * WinLauncher/Common.cpp:
1761         (ToggleMenuItem): Toggle the feature when the menu item
1762         is selected.
1763         (WndProc): Recognize the new menu option.
1764         * WinLauncher/WinLauncher.cpp:
1765         (WinLauncher::setToDefaultPreferences): Launch with "Invert
1766         Colors" turned off.
1767         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
1768         entry for "Invert Colors".
1769         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1770
1771 2015-08-25  Nan Wang  <n_wang@apple.com>
1772
1773         [Mac] accessibility/document-attributes.html fails
1774         https://bugs.webkit.org/show_bug.cgi?id=116636
1775
1776         Reviewed by Chris Fleizach.
1777
1778         Implemented documentURI() and documentEncoding().
1779
1780         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1781         (AccessibilityUIElement::documentEncoding):
1782         (AccessibilityUIElement::documentURI):
1783         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1784         (WTR::AccessibilityUIElement::documentEncoding):
1785         (WTR::AccessibilityUIElement::documentURI):
1786
1787 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
1788
1789         [Win] Unreviewed test gardening.
1790
1791         Fix another case where the logging string is constructed using the variable 'frame',
1792         but the method argument is not given a name. This causes the global 'frame' value to
1793         be used, producing incorrect output.
1794
1795         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1796         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
1797         argument.
1798
1799 2015-08-24  Tim Horton  <timothy_horton@apple.com>
1800
1801         (Finally...) get rid of WKViewIOS
1802         https://bugs.webkit.org/show_bug.cgi?id=148404
1803
1804         Reviewed by Anders Carlsson.
1805
1806         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1807         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1808         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1809         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1810         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1811         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1812         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1813         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1814         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1815         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
1816         Mark tests that use WKBrowsingContextController as Mac-only.
1817
1818         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1819         (WTR::AccessibilityController::addNotificationListener):
1820         * WebKitTestRunner/ios/mainIOS.mm:
1821         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
1822         Import UIKit instead of depending on WKView.h to do so.
1823
1824 2015-08-24  Jason Marcell  <jmarcell@apple.com>
1825
1826         Add support to dashboard for displaying Git SHA's as revisions.
1827         https://bugs.webkit.org/show_bug.cgi?id=148387
1828
1829         Reviewed by Daniel Bates.
1830
1831         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1832         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
1833         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1834         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
1836         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
1837
1838 2015-08-24  Andy Estes  <aestes@apple.com>
1839
1840         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
1841
1842         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
1843
1844 2015-08-23  Andy Estes  <aestes@apple.com>
1845
1846         Addressed a missed piece of review feedback from r188851.
1847
1848         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1849
1850 2015-08-23  Andy Estes  <aestes@apple.com>
1851
1852         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
1853         https://bugs.webkit.org/show_bug.cgi?id=147872
1854         rdar://problem/22044000
1855
1856         Reviewed by Dan Bernstein.
1857
1858         Added an API test.
1859
1860         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
1861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1862         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
1863         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
1864         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
1865         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
1866         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
1867         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
1868         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
1869         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
1870         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
1871
1872 2015-08-23  Andy Estes  <aestes@apple.com>
1873
1874         Fixed the 32-bit Mac build after r188844.
1875
1876         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1877         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1878
1879 2015-08-22  Andy Estes  <aestes@apple.com>
1880
1881         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
1882         https://bugs.webkit.org/show_bug.cgi?id=148317
1883
1884         Reviewed by Dan Bernstein.
1885
1886         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
1887         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
1888         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
1889         when creating WKWebViews.
1890
1891         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
1892         added a new API test for bundle parameters.
1893
1894         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
1895         named its executable TestWebKitAPI.bundle.
1896         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
1897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
1898         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
1899         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
1900         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
1901         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
1902         bundle parameter and asked for an initial notification.
1903         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
1904         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
1905         mirror its value in the main frame's JSContext.
1906         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
1907         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
1908         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
1909         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
1910         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
1911         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
1912         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
1913         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
1914         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
1915         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
1916
1917 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
1918
1919         URTBF after r188828.
1920
1921         * WebKitTestRunner/PlatformWebView.h:
1922
1923 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
1924
1925         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
1926         https://bugs.webkit.org/show_bug.cgi?id=148356
1927
1928         Reviewed by Darin Adler.
1929
1930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1931         (BuildbotCombinedQueueView.prototype.update):
1932
1933 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
1934
1935         build.webkit.org/dashboard: Respect step's hidden flag
1936         https://bugs.webkit.org/show_bug.cgi?id=148357
1937
1938         Reviewed by Darin Adler.
1939
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1941         (BuildbotIteration.prototype._parseData):
1942
1943 2015-08-23  Nan Wang  <n_wang@apple.com>
1944
1945         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
1946         https://bugs.webkit.org/show_bug.cgi?id=148328
1947
1948         Reviewed by Darin Adler.
1949
1950         We should only expose stringValue() when value attribute is set.
1951
1952         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1953         (AccessibilityUIElement::stringValue):
1954         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1955         (WTR::AccessibilityUIElement::stringValue):
1956
1957 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1958
1959         Remove style checking rule regarding OwnPtr and PassOwnPtr
1960         https://bugs.webkit.org/show_bug.cgi?id=148360
1961
1962         Reviewed by Darin Adler.
1963
1964         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
1965         Removed it.
1966
1967         * Scripts/do-webcore-rename:
1968         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1969         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
1970         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1971         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
1972         (WebKitStyleTest.test_names): Deleted.
1973
1974 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
1975
1976         WebKitTestRunner should use WKWebView on OS X and iOS
1977         https://bugs.webkit.org/show_bug.cgi?id=143743
1978         <rdar://problem/16947123>
1979
1980         Reviewed by Anders Carlsson.
1981         Patch by Enrica Casucci and myself.
1982
1983         * WebKitTestRunner/PlatformWebView.h:
1984         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1985         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1986         instead of WKContext and WKPageGroup.
1987
1988         Remove the unused, always-true windowSnapshotEnabled().
1989         While technically some platforms don't have window snapshotting,
1990         they just return null instead of implementing windowSnapshotEnabled().
1991
1992         * WebKitTestRunner/TestController.h:
1993         * WebKitTestRunner/TestController.cpp:
1994         (WTR::TestController::createOtherPage):
1995         (WTR::TestController::initialize):
1996         (WTR::TestController::createWebViewWithOptions):
1997         Delegate to the various platforms for creating PlatformWebView instances,
1998         for creating WKContexts, and for accessing WKPreferences,
1999         so that they can do special things (like, use WKWebView instead!).
2000
2001         (WTR::TestController::resetPreferencesToConsistentValues):
2002         Make explicit WebKitTestRunner's desired default for two preferences
2003         which have differing defaults between the antique and modern API,
2004         for consistency's sake.
2005
2006         (WTR::TestController::resetStateToConsistentValues):
2007         Add platformResetStateToConsistentValues.
2008
2009         * WebKitTestRunner/TestInvocation.cpp:
2010         (WTR::TestInvocation::dumpResults):
2011         Adjust to the aforementioned removal of windowSnapshotEnabled().
2012
2013         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2014         (WTR::TestController::platformResetStateToConsistentValues):
2015         (WTR::TestController::platformPreferences):
2016         (WTR::TestController::platformCreateWebView):
2017         (WTR::TestController::platformCreateOtherPage):
2018         (WTR::TestController::platformInitializeConfiguration):
2019         Implement the new platform functions for the Modern WebKit2 API,
2020         in a new TestControllerCocoa file that is shared between iOS and Mac.
2021
2022         For platformMaybeCreateContext, use the trick that we know we can cast
2023         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2024         WKWebView's configuration.
2025
2026         Ditto for WKPreferencesRef and WKPreferences.
2027
2028         Remove user content filters on the WKWebView's userContentController.
2029
2030         * WebKitTestRunner/mac/TestControllerMac.mm:
2031         * WebKitTestRunner/ios/TestControllerIOS.mm:
2032         Move code into TestControllerCocoa.
2033
2034         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2035         (WTR::InjectedBundle::beginTesting):
2036         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2037         (WTR::TestRunner::addUserScript):
2038         (WTR::TestRunner::addUserStyleSheet):
2039         Adopt WKBundlePage API for user scripts/sheets.
2040
2041         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2042         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2043         Make and keep a WKWebView instead of a WKView.
2044
2045         * WebKitTestRunner/mac/EventSenderProxy.mm:
2046         (WTR::EventSenderProxy::mouseUp):
2047         (WTR::EventSenderProxy::mouseMoveTo):
2048         Reach inside the WKWebView to the WKView when dispatching events.
2049         This is fairly ugly and we should come up with a better solution.
2050         Also, fix some flipping and style errors.
2051
2052 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2053
2054         Unreviewed, attempt to fix GTK build after r188718
2055
2056         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2057         (WTR::PlatformWebView::PlatformWebView):
2058
2059 2015-08-21  Commit Queue  <commit-queue@webkit.org>
2060
2061         Unreviewed, rolling out r188807, r188813, and r188815.
2062         https://bugs.webkit.org/show_bug.cgi?id=148349
2063
2064         lots of 32-bit build problems, better to resolve separately
2065         and try again (Requested by thorton on #webkit).
2066
2067         Reverted changesets:
2068
2069         "WebKitTestRunner should use WKWebView on OS X and iOS"
2070         https://bugs.webkit.org/show_bug.cgi?id=143743
2071         http://trac.webkit.org/changeset/188807
2072
2073         "Stop building WebKitTestRunner for 32-bit platforms"
2074         https://bugs.webkit.org/show_bug.cgi?id=143743
2075         http://trac.webkit.org/changeset/188813
2076
2077         "Stop building WebKitTestRunner for 32-bit platforms"
2078         https://bugs.webkit.org/show_bug.cgi?id=143743
2079         http://trac.webkit.org/changeset/188815
2080
2081 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2082
2083         Stop building WebKitTestRunner for 32-bit platforms
2084         https://bugs.webkit.org/show_bug.cgi?id=143743
2085         <rdar://problem/16947123>
2086
2087         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2088         This is a restriction on the valid set, not the desired set.
2089
2090 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2091
2092         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
2093         to work with these new objects.
2094         https://bugs.webkit.org/show_bug.cgi?id=148188
2095
2096         Reviewed by Daniel Bates.
2097
2098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2099         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2101         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
2102         (repository, "branch name")-pair.
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2105         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2107         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
2108         objects which represent a (repository, "branch name")-pair.
2109         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2110         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2111         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
2112         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
2113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
2114         BuildbotQueue.branch to BuildbotQueue.branches.
2115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2116         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
2117
2118 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2119
2120         Stop building WebKitTestRunner for 32-bit platforms
2121         https://bugs.webkit.org/show_bug.cgi?id=143743
2122         <rdar://problem/16947123>
2123
2124         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2125         WKWebView is not available on 32-bit OS X.
2126
2127 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
2128
2129         [Win] Unreviewed test correction after r188709.
2130
2131         I removed a function argument that happened to be mirrored by a global
2132         value with the same name. This prevented a compile error, but testing
2133         showed that the wrong value was being used in the function.
2134
2135         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2136         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
2137         back
2138
2139 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
2140
2141         WebKitTestRunner should use WKWebView on OS X and iOS
2142         https://bugs.webkit.org/show_bug.cgi?id=143743
2143         <rdar://problem/16947123>
2144
2145         Reviewed by Anders Carlsson.
2146         Patch by Enrica Casucci and myself.
2147
2148         * WebKitTestRunner/PlatformWebView.h:
2149         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2150         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2151         instead of WKContext and WKPageGroup.
2152
2153         Remove the unused, always-true windowSnapshotEnabled().
2154         While technically some platforms don't have window snapshotting,
2155         they just return null instead of implementing windowSnapshotEnabled().
2156
2157         * WebKitTestRunner/TestController.h:
2158         * WebKitTestRunner/TestController.cpp:
2159         (WTR::TestController::createOtherPage):
2160         (WTR::TestController::initialize):
2161         (WTR::TestController::createWebViewWithOptions):
2162         Delegate to the various platforms for creating PlatformWebView instances,
2163         for creating WKContexts, and for accessing WKPreferences,
2164         so that they can do special things (like, use WKWebView instead!).
2165
2166         (WTR::TestController::resetPreferencesToConsistentValues):
2167         Make explicit WebKitTestRunner's desired default for two preferences
2168         which have differing defaults between the antique and modern API,
2169         for consistency's sake.
2170
2171         (WTR::TestController::resetStateToConsistentValues):
2172         Add platformResetStateToConsistentValues.
2173
2174         * WebKitTestRunner/TestInvocation.cpp:
2175         (WTR::TestInvocation::dumpResults):
2176         Adjust to the aforementioned removal of windowSnapshotEnabled().
2177
2178         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2179         (WTR::TestController::platformResetStateToConsistentValues):
2180         (WTR::TestController::platformPreferences):
2181         (WTR::TestController::platformCreateWebView):
2182         (WTR::TestController::platformCreateOtherPage):
2183         (WTR::TestController::platformInitializeConfiguration):
2184         Implement the new platform functions for the Modern WebKit2 API,
2185         in a new TestControllerCocoa file that is shared between iOS and Mac.
2186
2187         For platformMaybeCreateContext, use the trick that we know we can cast
2188         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2189         WKWebView's configuration.
2190
2191         Ditto for WKPreferencesRef and WKPreferences.
2192
2193         Remove user content filters on the WKWebView's userContentController.
2194
2195         * WebKitTestRunner/mac/TestControllerMac.mm:
2196         * WebKitTestRunner/ios/TestControllerIOS.mm:
2197         Move code into TestControllerCocoa.
2198
2199         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2200         (WTR::InjectedBundle::beginTesting):
2201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2202         (WTR::TestRunner::addUserScript):
2203         (WTR::TestRunner::addUserStyleSheet):
2204         Adopt WKBundlePage API for user scripts/sheets.
2205
2206         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2207         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2208         Make and keep a WKWebView instead of a WKView.
2209
2210         * WebKitTestRunner/mac/EventSenderProxy.mm:
2211         (WTR::EventSenderProxy::mouseUp):
2212         (WTR::EventSenderProxy::mouseMoveTo):
2213         Reach inside the WKWebView to the WKView when dispatching events.
2214         This is fairly ugly and we should come up with a better solution.
2215         Also, fix some flipping and style errors.
2216
2217 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
2218
2219         Improve how UI events are dispatched by WebKitTestRunner
2220         https://bugs.webkit.org/show_bug.cgi?id=148326
2221
2222         Reviewed by Anders Carlsson.
2223
2224         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2225         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2226         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
2227         asynchronous (and really, it has always been for the most part).
2228
2229         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2230         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
2231         (WTR::EventSendingController::mouseUp): Ditto.
2232         (WTR::EventSendingController::mouseMoveTo): Ditto.
2233         (WTR::EventSendingController::mouseForceDown): Ditto.
2234         (WTR::EventSendingController::mouseForceUp): Ditto.
2235         (WTR::EventSendingController::mouseForceChanged): Ditto.
2236         (WTR::EventSendingController::leapForward): Ditto.
2237         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
2238         (WTR::EventSendingController::keyDown): Ditto.
2239         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
2240         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
2241         to be done in custom WebKit2 code for test wheel event handling.
2242         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
2243         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
2244         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
2245         (WTR::EventSendingController::addTouchPoint): Ditto.
2246         (WTR::EventSendingController::updateTouchPoint): Ditto.
2247         (WTR::EventSendingController::setTouchModifier): Ditto.
2248         (WTR::EventSendingController::setTouchPointRadius): Ditto.
2249         (WTR::EventSendingController::touchStart): Ditto.
2250         (WTR::EventSendingController::touchMove): Ditto.
2251         (WTR::EventSendingController::touchEnd): Ditto.
2252         (WTR::EventSendingController::touchCancel): Ditto.
2253         (WTR::EventSendingController::clearTouchPoints): Ditto.
2254         (WTR::EventSendingController::releaseTouchPoint): Ditto.
2255         (WTR::EventSendingController::cancelTouchPoint): Ditto.
2256
2257         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2258         (WTR::InjectedBundle::postSetWindowIsKey):
2259         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2260         (WTR::InjectedBundle::isGeolocationProviderActive):
2261         (WTR::InjectedBundle::shouldProcessWorkQueue):
2262         Updated for WKBundlePagePostSynchronousMessage renaming.
2263
2264         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2265         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
2266
2267         * WebKitTestRunner/TestController.cpp:
2268         (WTR::TestController::initialize): Allow handling the new test style messages.
2269         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
2270         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
2271         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2272         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
2273         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
2274
2275         * WebKitTestRunner/mac/EventSenderProxy.mm:
2276         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
2277         (WTR::EventSenderProxy::keyDown): Ditto.
2278         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
2279         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2280
2281 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2282
2283         Skip no-llint tests that fail due to running out of executable memory after r188969
2284         https://bugs.webkit.org/show_bug.cgi?id=148273
2285
2286         Reviewed by Michael Saboff.
2287
2288         * Scripts/run-jsc-stress-tests:
2289
2290 2015-08-21  Nan Wang  <n_wang@apple.com>
2291
2292         [Mac] accessibility/selection-states.html fails
2293         https://bugs.webkit.org/show_bug.cgi?id=116637
2294
2295         Reviewed by Chris Fleizach.
2296
2297         Implemented isSelectable() and isMultiSelectable().
2298
2299         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2300         (AccessibilityUIElement::isSelectable):
2301         (AccessibilityUIElement::isMultiSelectable):
2302         (AccessibilityUIElement::isSelectedOptionActive):
2303         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2304         (WTR::AccessibilityUIElement::isSelectable):
2305         (WTR::AccessibilityUIElement::isMultiSelectable):
2306         (WTR::AccessibilityUIElement::isVisible):
2307
2308 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2309
2310         Fix iteration over repositories on bot watcher's dashboard.
2311
2312         Reviewed by Alexey Proskuryakov.
2313
2314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2315         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
2316
2317 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
2318
2319         [EFL] Revise PlatformWebView ctor according to r188718
2320         https://bugs.webkit.org/show_bug.cgi?id=148282
2321
2322         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
2323         instead of WKContextRef and WKPageGroupRef respectively.
2324
2325         Reviewed by Gyuyoung Kim.
2326
2327         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2328         (WTR::PlatformWebView::PlatformWebView):
2329
2330 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
2331
2332         Unreviewed, changed Devin Rousso's email.
2333
2334         * Scripts/webkitpy/common/config/contributors.json:
2335
2336 2015-08-20  Anders Carlsson  <andersca@apple.com>
2337
2338         Use WKPageConfigurationRef in WebKitTestRunner
2339         https://bugs.webkit.org/show_bug.cgi?id=147996
2340
2341         Reviewed by Tim Horton.
2342
2343         * WebKitTestRunner/TestController.cpp:
2344         (WTR::TestController::createOtherPage):
2345         (WTR::TestController::initialize):
2346         (WTR::TestController::createWebViewWithOptions):
2347         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2348         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
2349         (WTR::PlatformWebView::PlatformWebView):
2350         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
2351
2352 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
2353
2354         [Win] Update Windows tools for revised MIDL interfaces
2355         https://bugs.webkit.org/show_bug.cgi?id=148249
2356
2357         Reviewed by Dean Jackson.
2358
2359         This is a follow-up to Bug 148001.
2360
2361         Revise the testing software to use compatible signatures and
2362         implementations to match the requirements of the IDL generated
2363         with the SAL annotations.
2364
2365         * DumpRenderTree/win/DRTDataObject.cpp:
2366         * DumpRenderTree/win/DRTDataObject.h:
2367         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2368         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2369         * DumpRenderTree/win/DRTDropSource.cpp:
2370         * DumpRenderTree/win/DRTDropSource.h:
2371         * DumpRenderTree/win/DumpRenderTree.cpp:
2372         * DumpRenderTree/win/EditingDelegate.cpp:
2373         * DumpRenderTree/win/EditingDelegate.h:
2374         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2375         * DumpRenderTree/win/FrameLoadDelegate.h:
2376         * DumpRenderTree/win/HistoryDelegate.cpp:
2377         * DumpRenderTree/win/HistoryDelegate.h:
2378         * DumpRenderTree/win/PolicyDelegate.cpp:
2379         * DumpRenderTree/win/PolicyDelegate.h:
2380         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2381         * DumpRenderTree/win/ResourceLoadDelegate.h:
2382         * DumpRenderTree/win/TestRunnerWin.cpp:
2383         * DumpRenderTree/win/UIDelegate.cpp:
2384         * DumpRenderTree/win/UIDelegate.h:
2385         * WinLauncher/AccessibilityDelegate.cpp:
2386         * WinLauncher/AccessibilityDelegate.h:
2387         * WinLauncher/Common.cpp:
2388         * WinLauncher/DOMDefaultImpl.cpp:
2389         * WinLauncher/DOMDefaultImpl.h:
2390         * WinLauncher/PageLoadTestClient.cpp:
2391         * WinLauncher/PageLoadTestClient.h:
2392         * WinLauncher/PrintWebUIDelegate.cpp:
2393         * WinLauncher/PrintWebUIDelegate.h:
2394         * WinLauncher/ResourceLoadDelegate.cpp:
2395         * WinLauncher/ResourceLoadDelegate.h:
2396         * WinLauncher/WebDownloadDelegate.cpp:
2397         * WinLauncher/WebDownloadDelegate.h:
2398         * WinLauncher/WinLauncherWebHost.cpp:
2399         * WinLauncher/WinLauncherWebHost.h:
2400         * WinLauncher/WinMain.cpp:
2401         * win/DLLLauncher/DLLLauncherMain.cpp:
2402
2403 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
2404
2405         Unreviewed, shorten a test that runs too long and times out.
2406
2407         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2408         (TestWebKitAPI::TEST):
2409
2410 2015-08-20  Alex Christensen  <achristensen@webkit.org>
2411
2412         Clean up CMake build after r188673
2413         https://bugs.webkit.org/show_bug.cgi?id=148234
2414
2415         Reviewed by Tim Horton.
2416
2417         * DumpRenderTree/PlatformWin.cmake:
2418         * TestWebKitAPI/CMakeLists.txt:
2419         * TestWebKitAPI/PlatformWin.cmake:
2420         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
2421         gtest needs to be a static library on Windows to not crash.
2422
2423 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2424
2425         CMake Windows build should not include files directly from other Source directories
2426         https://bugs.webkit.org/show_bug.cgi?id=148198
2427
2428         Reviewed by Brent Fulgham.
2429
2430         * DumpRenderTree/DumpRenderTreePrefix.h:
2431         Include cmakeconfig.h to properly define all enabled features.
2432         * DumpRenderTree/PlatformWin.cmake:
2433         * TestWebKitAPI/PlatformWin.cmake:
2434
2435 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2436
2437         Build TestWTF on Mac with CMake.
2438         https://bugs.webkit.org/show_bug.cgi?id=147972
2439
2440         Reviewed by Tim Horton.
2441
2442         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
2443         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
2444
2445         * TestWebKitAPI/CMakeLists.txt:
2446         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
2447         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
2448         * TestWebKitAPI/PlatformMac.cmake: Added.
2449         * TestWebKitAPI/config.h:
2450         Postpone some build fixes until WebKit builds completely on Mac with CMake.
2451
2452 2015-08-19  Brian Burg  <bburg@apple.com>
2453
2454         Unreviewed, add Aleksandr Skachkov to the list of contributors.
2455
2456         * Scripts/webkitpy/common/config/contributors.json:
2457
2458 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2459
2460         REGRESSION(r188548): [GTK] Build broken.
2461         https://bugs.webkit.org/show_bug.cgi?id=148154
2462
2463         Reviewed by Martin Robinson.
2464
2465         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2466         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2467         Even if we don't need to add/override any settings in ViewOptions,
2468         we need to define this as an empty function to make it build.
2469
2470 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2471
2472         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
2473         https://bugs.webkit.org/show_bug.cgi?id=148073
2474
2475         Reviewed by Alexey Proskuryakov.
2476
2477         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
2478         (TestWebKitAPI::TEST):
2479
2480 2015-08-18  Anders Carlsson  <andersca@apple.com>
2481
2482         Fix test failure fallout from r188602 by using a V5 page ui client struct.
2483
2484         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2485         (TestWebKitAPI::setUpClients):
2486
2487 2015-08-18  Brian Burg  <bburg@apple.com>
2488
2489         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2490         https://bugs.webkit.org/show_bug.cgi?id=147955
2491
2492         Reviewed by Timothy Hatcher.
2493
2494         To enable sharing of common test code between protocol and model tests,
2495         start loading the protocol TestStub.js through the WebInspectorUI bundle.
2496
2497         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2498         protocol-test.js uses to load the inspector frontend stub into its iframe
2499         from an arbitrary local file URL.
2500
2501         * DumpRenderTree/TestRunner.cpp:
2502         (getInspectorTestStubURLCallback):
2503         (TestRunner::staticValues):
2504         * DumpRenderTree/TestRunner.h:
2505         * DumpRenderTree/mac/TestRunnerMac.mm:
2506         (SOFT_LINK_STAGED_FRAMEWORK):
2507         (TestRunner::inspectorTestStubURL):
2508         * DumpRenderTree/win/TestRunnerWin.cpp:
2509         (TestRunner::inspectorTestStubURL):
2510         * WebKitTestRunner/Configurations/Base.xcconfig:
2511         Since WebKitTestRunner now includes WebCore private headers, also search
2512         for the WebCore framework inside the WebKit umbrella framework.
2513
2514         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2515         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2516         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2517         (WTR::TestRunner::inspectorTestStubURL):
2518         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2519         (WTR::TestRunner::inspectorTestStubURL):
2520         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2521         (WTR::TestRunner::inspectorTestStubURL):
2522
2523 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
2524
2525         Unreviewed, fix GTK build.
2526
2527         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2528         (TestWebKitAPI::TEST):
2529
2530 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
2531
2532         Replace all remaining uses of WTF::Mutex with WTF::Lock
2533         https://bugs.webkit.org/show_bug.cgi?id=148089
2534
2535         Reviewed by Geoffrey Garen.
2536
2537         * DumpRenderTree/JavaScriptThreading.cpp:
2538         (javaScriptThreadsMutex):
2539         (runJavaScriptThread):
2540         (startJavaScriptThreads):
2541         (stopJavaScriptThreads):
2542         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
2543         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2544         (TestWebKitAPI::TEST):
2545         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2546         (TestWebKitAPI::TEST):
2547
2548 2015-08-17  Commit Queue  <commit-queue@webkit.org>
2549
2550         Unreviewed, rolling out r188539, r188544, r188552, and
2551         r188564.
2552         https://bugs.webkit.org/show_bug.cgi?id=148122
2553
2554         Broke tests and some build styles (Requested by ap on
2555         #webkit).
2556
2557         Reverted changesets:
2558
2559         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
2560         bundle"
2561         https://bugs.webkit.org/show_bug.cgi?id=147955
2562         http://trac.webkit.org/changeset/188539
2563
2564         "Web Inspector: split TestStub.js into multiple files and
2565         modernize it"
2566         https://bugs.webkit.org/show_bug.cgi?id=148077
2567         http://trac.webkit.org/changeset/188544
2568
2569         "Web Inspector: InspectorTest should be a subclass of
2570         TestHarness"
2571         https://bugs.webkit.org/show_bug.cgi?id=148079
2572         http://trac.webkit.org/changeset/188552
2573
2574         "Unreviewed internal build fix attempt after r188539."
2575         http://trac.webkit.org/changeset/188564
2576
2577 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2578
2579         [OS X] Remove support for composite fonts
2580         https://bugs.webkit.org/show_bug.cgi?id=147920
2581
2582         Reviewed by Dan Bernstein.
2583
2584         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2585         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2586         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2587         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2588         * DumpRenderTree/mac/DumpRenderTree.mm:
2589         (allowedFontFamilySet): Deleted.
2590         (activateTestingFonts): Deleted.
2591         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2592         (WTR::allowedFontFamilySet): Deleted.
2593         (WTR::activateFonts): Deleted.
2594         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2595         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2596         * WebKitTestRunner/mac/TestControllerMac.mm:
2597         (WTR::allowedFontFamilySet): Deleted.
2598
2599 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
2600
2601         Unreviewed internal build fix attempt after r188539.
2602
2603         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2604
2605 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2606
2607         Fix the build
2608
2609         Unreviewed.
2610
2611         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2612
2613 2015-08-17  Alex Christensen  <achristensen@webkit.org>
2614
2615         Build Debug Suffix on Windows with CMake
2616         https://bugs.webkit.org/show_bug.cgi?id=148083
2617
2618         Reviewed by Brent Fulgham.
2619
2620         * TestWebKitAPI/CMakeLists.txt:
2621         * TestWebKitAPI/PlatformWin.cmake:
2622         Add DEBUG_SUFFIX
2623
2624 2015-08-17  Anders Carlsson  <andersca@apple.com>
2625
2626         Simplify how PlatformWebViews are created when view options change
2627         https://bugs.webkit.org/show_bug.cgi?id=148093
2628
2629         Reviewed by Sam Weinig.
2630
2631         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
2632
2633         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
2634         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
2635         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
2636
2637         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
2638
2639         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
2640         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
2641
2642         * WebKitTestRunner/TestController.cpp:
2643         (WTR::TestController::ensureViewSupportsOptionsForTest):
2644         (WTR::shouldUseFixedLayout):
2645         (WTR::TestController::viewOptionsForTest):
2646         (WTR::TestController::updateWebViewSizeForTest):
2647         (WTR::TestController::updateWindowScaleForTest):
2648         (WTR::TestController::configureViewForTest):
2649         (WTR::TestController::initialize): Deleted.
2650         (WTR::TestController::ensureViewSupportsOptions): Deleted.
2651         (WTR::TestController::updateLayoutTypeForTest): Deleted.
2652         (WTR::TestController::platformConfigureViewForTest): Deleted.
2653         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
2654         (WTR::TestController::run): Deleted.
2655         * WebKitTestRunner/TestController.h:
2656         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2657         (WTR::shouldUseFixedLayout):
2658         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2659         (WTR::TestController::platformConfigureViewForTest):
2660         (WTR::TestController::platformResetPreferencesToConsistentValues):
2661         * WebKitTestRunner/ios/TestControllerIOS.mm:
2662         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2663         * WebKitTestRunner/mac/TestControllerMac.mm:
2664         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2665         (WTR::TestController::platformConfigureViewForTest):
2666
2667 2015-08-17  Sam Weinig  <sam@webkit.org>
2668
2669         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
2670         https://bugs.webkit.org/show_bug.cgi?id=148097
2671
2672         Reviewed by Anders Carlsson.
2673
2674         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
2675         Add tests for WebsiteDataStores in the WKPageConfiguration.
2676
2677 2015-08-17  Brian Burg  <bburg@apple.com>
2678
2679         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2680         https://bugs.webkit.org/show_bug.cgi?id=147955
2681
2682         Reviewed by Timothy Hatcher.
2683
2684         To enable sharing of common test code between protocol and model tests,
2685         start loading the protocol TestStub.js through the WebInspectorUI bundle.
2686
2687         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2688         protocol-test.js uses to load the inspector frontend stub into its iframe
2689         from an arbitrary local file URL.
2690
2691         * DumpRenderTree/TestRunner.cpp:
2692         (getInspectorTestStubURLCallback):
2693         (TestRunner::staticValues):
2694         * DumpRenderTree/TestRunner.h:
2695         * DumpRenderTree/mac/TestRunnerMac.mm:
2696         (SOFT_LINK_STAGED_FRAMEWORK):
2697         (TestRunner::inspectorTestStubURL):
2698         * DumpRenderTree/win/TestRunnerWin.cpp:
2699         (TestRunner::inspectorTestStubURL):
2700         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2701         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2702         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2703         (WTR::TestRunner::inspectorTestStubURL):
2704         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2705         (WTR::TestRunner::inspectorTestStubURL):
2706         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2707         (WTR::TestRunner::inspectorTestStubURL):
2708
2709 2015-08-17  Saam barati  <sbarati@apple.com>
2710
2711         Change email address from saambarati1@gmail.com to sbarati@apple.com
2712
2713         * Scripts/webkitpy/common/config/contributors.json:
2714
2715 2015-08-17  Jason Marcell  <jmarcell@apple.com>
2716
2717         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
2718         repositories other than "openSource" and "internal".
2719         https://bugs.webkit.org/show_bug.cgi?id=147961
2720
2721         Reviewed by Daniel Bates.
2722
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2724         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
2725         generically with repositories other than "openSource" and "internal".
2726
2727 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
2728
2729         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
2730         https://bugs.webkit.org/show_bug.cgi?id=148081
2731
2732         Reviewed by Tim Horton.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2735         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2736
2737 2015-08-11  Andy Estes  <aestes@apple.com>
2738
2739         [Cocoa] Add redirect support to CustomProtocolManager
2740         https://bugs.webkit.org/show_bug.cgi?id=147871
2741
2742         Reviewed by Dan Bernstein.
2743
2744         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
2745
2746         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2747         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
2748         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
2749         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2750         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
2751         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
2752         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
2753         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
2754         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
2755         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2756         (TestWebKitAPI::TEST): Unregistered TestProtocol.
2757         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
2758         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
2759         (-[TestProtocol startLoading]): Taught to handle redirect responses.
2760
2761 2015-08-13  Andy Estes  <aestes@apple.com>
2762
2763         [Cocoa] Downloads do not start if policy decision is made asynchronously
2764         https://bugs.webkit.org/show_bug.cgi?id=147985
2765
2766         Reviewed by Brady Eidson.
2767
2768         Added a new API test.
2769
2770         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2771         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2772         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
2773         (TEST):
2774
2775 2015-08-14  Commit Queue  <commit-queue@webkit.org>
2776
2777         Unreviewed, rolling out r187357.
2778         https://bugs.webkit.org/show_bug.cgi?id=148032
2779
2780         webkit-patch generates incorrect patches that cannot be
2781         applied (Requested by dydz on #webkit).
2782
2783         Reverted changeset:
2784
2785         "Call fixChangeLogPatch when generating patches from webkit-
2786         patch"
2787         https://bugs.webkit.org/show_bug.cgi?id=147248
2788         http://trac.webkit.org/changeset/187357
2789
2790 2015-08-14  Jason Marcell  <jmarcell@apple.com>
2791
2792         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
2793         other than "openSource" and "internal".
2794         https://bugs.webkit.org/show_bug.cgi?id=147938
2795
2796         Reviewed by Daniel Bates.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2799         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
2800         repositories other than "openSource" and "internal".
2801
2802 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
2803
2804         Unreviewed, shorten another test that is timing out.
2805
2806         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2807         (TestWebKitAPI::TEST):
2808
2809 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
2810
2811         AppScale: Assertion hit when hovering a webkit-queue bubble
2812         https://bugs.webkit.org/show_bug.cgi?id=147997
2813
2814         Reviewed by Alexey Proskuryakov.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2817         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
2818
2819 2015-08-13  Lucas Forschler  <lforschler@apple.com>
2820
2821         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
2822
2823         Unreviewed.
2824
2825         * Scripts/copy-webkitlibraries-to-product-directory:
2826
2827 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
2828
2829         Run benchmark customized Dromaeo should not assume there is an internet connection.
2830         https://bugs.webkit.org/show_bug.cgi?id=147995
2831
2832         Reviewed by Ryosuke Niwa.
2833
2834         Add several dependency js libs to local.
2835
2836         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2837
2838 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
2839
2840         WTF should have a compact Condition object to use with Lock
2841         https://bugs.webkit.org/show_bug.cgi?id=147986
2842
2843         Reviewed by Geoffrey Garen.
2844
2845         Add a test for WTF::Condition.
2846
2847         * TestWebKitAPI/CMakeLists.txt:
2848         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2850         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
2851         (TestWebKitAPI::TEST):
2852         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2853         (TestWebKitAPI::runLockTest): Change the name of the thread.
2854
2855 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
2856
2857         Unreviewed, shorten another test. It's timing out in debug on some bot.
2858
2859         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2860         (TestWebKitAPI::TEST):
2861
2862 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
2863
2864         WTF::Lock should not suffer from the thundering herd
2865         https://bugs.webkit.org/show_bug.cgi?id=147947
2866
2867         Reviewed by Geoffrey Garen.
2868
2869         Add testing that checks that locks return to a pristine state after contention is over.
2870
2871         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2872         (TestWebKitAPI::LockInspector::isFullyReset):
2873         (TestWebKitAPI::runLockTest):
2874         (TestWebKitAPI::TEST):
2875
2876 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
2877
2878         Benchmarks supported by run_benchmark script should not assume we have internet access.
2879         https://bugs.webkit.org/show_bug.cgi?id=147959
2880
2881         Reviewed by Ryosuke Niwa.
2882
2883         For JSBench we should not request jquery.min.js from google through the internet.
2884
2885         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2886
2887 2015-08-12  Jason Marcell  <jmarcell@apple.com>
2888
2889         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
2890         other than "openSource" and "internal".
2891         https://bugs.webkit.org/show_bug.cgi?id=147796
2892
2893         Reviewed by Daniel Bates.
2894
2895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2896         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
2897         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
2898         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
2899         and another assertion that, if the previousIteration is non-null, the given repository is in
2900         previousIteration.revision.
2901         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
2902         with repositories other than "openSource" and "internal". Also added an assertion that the returned
2903         fragment has at least one child node.
2904
2905 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
2906
2907         Add a tool that dumps class and struct member layout, showing padding
2908         https://bugs.webkit.org/show_bug.cgi?id=147898
2909
2910         Reviewed by Zalan Bujtas.
2911
2912         This 'dump-class-layout' script uses the lldb Python bindings to collect data
2913         about data member layout, and displays it.
2914
2915         Sample output:
2916
2917               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
2918               +0 < 56>     WebCore::URL m_value;
2919               +0 <  8>         WTF::String m_string;
2920               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
2921               +0 <  8>                 WTF::StringImpl * m_ptr;
2922               +8 <  1>         bool:1 m_isValid;
2923               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
2924               +9 <  3>         <PADDING>
2925              +12 <  4>         int m_schemeEnd;
2926              +16 <  4>         int m_userStart;
2927              +20 <  4>         int m_userEnd;
2928              +24 <  4>         int m_passwordEnd;
2929              +28 <  4>         int m_hostEnd;
2930              +32 <  4>         int m_portEnd;
2931              +36 <  4>         int m_pathAfterLastSlash;
2932              +40 <  4>         int m_pathEnd;
2933              +44 <  4>         int m_queryEnd;
2934              +48 <  4>         int m_fragmentEnd;
2935              +52 <  4>         <PADDING>
2936              +52 <  4>     <PADDING>
2937              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
2938              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
2939             Total byte size: 72
2940             Total pad bytes: 11
2941             Padding percentage: 15.28 %
2942
2943         * Scripts/dump-class-layout: Added.
2944         (webkit_build_dir):
2945         (developer_dir):
2946         (import_lldb):
2947         (find_build_directory):
2948         (verify_type):
2949         (verify_type_recursive):
2950         (dump_class):
2951         (main):
2952         (main.or):
2953
2954 2015-08-12  Alex Christensen  <achristensen@webkit.org>
2955
2956         Fix Debug CMake builds on Windows
2957         https://bugs.webkit.org/show_bug.cgi?id=147940
2958
2959         Reviewed by Chris Dumez.
2960
2961         * DumpRenderTree/PlatformWin.cmake:
2962         * TestWebKitAPI/PlatformWin.cmake:
2963         The BitmapImage test is not enabled on the AppleWin port.
2964         * WinLauncher/CMakeLists.txt:
2965         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
2966
2967 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2968
2969         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
2970
2971         In r188125 I added a way to mark tests as slow to use a longer
2972         timeout. But it seems it was not enough for
2973         WTF_Lock.ContendedShortSection, so let's try again with a longer
2974         timeout now.
2975
2976         * Scripts/run-gtk-tests:
2977         (TestRunner._run_google_test):
2978
2979 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2980
2981         Allow --debug option in run-jsc
2982         https://bugs.webkit.org/show_bug.cgi?id=147923
2983
2984         Reviewed by Csaba Osztrogonác.
2985
2986         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
2987
2988         * Scripts/run-jsc:
2989
2990 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2991
2992         Fix test after build fix in r188286.
2993         https://bugs.webkit.org/show_bug.cgi?id=147907
2994
2995         Reviewed by Anders Carlsson.
2996
2997         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2998         sleep_for can now be used, but we need to include <thread>
2999
3000 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3001
3002         Always use a byte-sized lock implementation
3003         https://bugs.webkit.org/show_bug.cgi?id=147908
3004
3005         Reviewed by Geoffrey Garen.
3006
3007         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
3008         now tests of Lock.
3009
3010         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3011         (TestWebKitAPI::runLockTest):
3012         (TestWebKitAPI::TEST):
3013
3014 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
3015
3016         Make ASan build not depend on asan.xcconfig
3017         https://bugs.webkit.org/show_bug.cgi?id=147840
3018         rdar://problem/21093702
3019
3020         Reviewed by Daniel Bates.
3021
3022         * asan/asan.xcconfig:
3023         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
3024         are now marked in source code.
3025
3026 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3027
3028         Unreviewed, shorten another test since it timed out.
3029
3030         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3031         (TestWebKitAPI::TEST):
3032
3033 2015-08-11  Mark Lam  <mark.lam@apple.com>
3034
3035         Fix names of Lock tests: should be "Contended", not "Contented".
3036         https://bugs.webkit.org/show_bug.cgi?id=147905
3037
3038         Reviewed by Saam Barati.
3039
3040         We're testing the behavior of lock contention (i.e. when threads contend), not
3041         whether the locks are happy (contented).
3042
3043         * Scripts/run-gtk-tests:
3044         (TestRunner):
3045         (TestRunner.__init__): Deleted.
3046         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3047         (TestWebKitAPI::runLockTest):
3048         (TestWebKitAPI::TEST):
3049
3050 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3051
3052         Update WinCairoRequirements to VS2015.
3053
3054         * Scripts/update-webkit-wincairo-libs:
3055         Update WinCairoRequirements location.
3056
3057 2015-08-11  Jason Marcell  <jmarcell@apple.com>
3058
3059         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
3060         for internalTrac.
3061         https://bugs.webkit.org/show_bug.cgi?id=147805
3062
3063         Reviewed by Daniel Bates.
3064
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3066         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
3067         Dashboard.Repository.Internal.trac for internalTrac.
3068         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
3069         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
3070         respectively.
3071         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3072         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
3073         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
3074         internalTrac.
3075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3078         (Analyzer): Ditto.
3079         (Analyzer.prototype.analyze): Ditto.
3080
3081 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3082
3083         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
3084
3085         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3086         (TestWebKitAPI::TEST):
3087
3088 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
3089
3090         [Win] Switch Windows build to Visual Studio 2015
3091         https://bugs.webkit.org/show_bug.cgi?id=147887
3092         <rdar://problem/22235098>
3093
3094         Reviewed by Alex Christensen.
3095
3096         Update Visual Studio project file settings to use the current Visual
3097         Studio and compiler. Continue targeting binaries to run on our minimum
3098         supported configuration of Windows 7.
3099
3100         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3101         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3102         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3103         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3104         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3105         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
3106         prefer the newer MSBuild included in Visual Studio 2015.
3107         (visualStudioInstallDir):
3108         (msBuildInstallDir):
3109         (visualStudioVersion):
3110         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3111         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3112         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3113         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3114         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3115         * win/record-memory/record-memory.vcxproj:
3116
3117 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3118
3119         Another speculative build fix after r188280.
3120
3121         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3122         std::this_thread is too modern c++ for VS2013 and supported GCC versions,
3123         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
3124
3125 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3126
3127         Unreviewed build fix after r188280.
3128
3129         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3130         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
3131
3132 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
3133
3134         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
3135         https://bugs.webkit.org/show_bug.cgi?id=147665
3136
3137         Reviewed by Mark Lam.
3138
3139         * TestWebKitAPI/CMakeLists.txt:
3140         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3142         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3143         (TestWebKitAPI::TEST):
3144         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
3145         (TestWebKitAPI::TEST):
3146
3147 2015-08-11  Brian Burg  <bburg@apple.com>
3148
3149         webkit-patch should not explode when $EDITOR is set incorrectly
3150         https://bugs.webkit.org/show_bug.cgi?id=147884
3151
3152         Reviewed by Darin Adler.
3153
3154         If $EDITOR doesn't exist, log a warning and continue.
3155
3156         * Scripts/webkitpy/common/system/user.py:
3157         (User.edit):
3158         (User.edit_changelog):
3159
3160 2015-08-11  Dan Bernstein  <mitz@apple.com>
3161
3162         Reverted r188255, because it turned out that delegates do nonot need this information.
3163
3164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3165         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
3166
3167 2015-08-11  Dan Bernstein  <mitz@apple.com>
3168
3169         [Cocoa] The UI delegate can't tell if printing was user-initiated
3170         https://bugs.webkit.org/show_bug.cgi?id=147869
3171
3172         Reviewed by Sam Weinig.
3173
3174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3175         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
3176         (-[PrintFrameController webView:didFinishNavigation:]):
3177         (-[PrintFrameController _webView:printFrame:userInitiated:]):
3178         (TEST):
3179
3180 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3181
3182         Another build fix after r188239.
3183
3184         * TestWebKitAPI/PlatformWin.cmake:
3185         Link with more libraries.
3186         * WinLauncher/CMakeLists.txt:
3187         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
3188
3189 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3190
3191         Build fix after r188237.
3192
3193         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3194         (BenchmarkBuilder.__enter__):
3195
3196 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3197
3198         Update ReadMe and correct the way to use abstract abstract class.
3199         https://bugs.webkit.org/show_bug.cgi?id=147860
3200
3201         Reviewed by Ryosuke Niwa.
3202
3203         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
3204         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
3205
3206         * Scripts/webkitpy/benchmark_runner/README.md:
3207         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3208         (BrowserDriver):
3209         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3210         (OSXBrowserDriver.restore_env):
3211         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3212         (HTTPServerDriver):
3213         (HTTPServerDriver.set_device_id):
3214         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3215         (SimpleHTTPServerDriver.get_return_code):
3216         (SimpleHTTPServerDriver):
3217         (SimpleHTTPServerDriver.set_device_id):
3218
3219 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3220
3221         Build TestWebKitAPI with CMake on Windows
3222         https://bugs.webkit.org/show_bug.cgi?id=147851
3223
3224         Reviewed by Chris Dumez.
3225
3226         * CMakeLists.txt:
3227         * TestWebKitAPI/CMakeLists.txt:
3228         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
3229         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
3230         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win
3231         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
3232         * TestWebKitAPI/PlatformEfl.cmake:
3233         * TestWebKitAPI/PlatformGTK.cmake:
3234         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
3235         I did this without changing the directory structure of the existing EFL and GTK builds.
3236         * TestWebKitAPI/PlatformWin.cmake: Added.
3237         * TestWebKitAPI/win/main.cpp:
3238         (main):
3239         (dllLauncherEntryPoint):
3240         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
3241         * WinLauncher/CMakeLists.txt:
3242         AppleWin port needs /NODEFAULTLIB:MSVCRT.
3243
3244 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3245
3246         Make cleanup more robust and minor code cleaning in run benchmark script.
3247         https://bugs.webkit.org/show_bug.cgi?id=147800
3248
3249         Reviewed by Ryosuke Niwa.
3250
3251         Use 'finnaly' block to make sure cleanup code is always executed.
3252
3253         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3254         (built_benchmark):
3255         (built_benchmark.__init__):
3256         (built_benchmark.__enter__):
3257         (built_benchmark.__exit__):
3258         (test_environment):
3259         (test_environment.__init__):
3260         (test_environment.__enter__):
3261         (test_environment.__exit__):
3262         (BenchmarkRunner.__init__):
3263         (BenchmarkRunner.execute):
3264         (BenchmarkRunner._dump):
3265         (BenchmarkRunner._wrap):
3266         (BenchmarkRunner): Deleted.
3267         (BenchmarkRunner._cleanup): Deleted.
3268         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3269         (BrowserDriver.close_browsers):
3270         (BrowserDriver):
3271         (BrowserDriver.restore_env):
3272         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3273         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
3274
3275 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3276
3277         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
3278         https://bugs.webkit.org/show_bug.cgi?id=146414
3279
3280         Reviewed by Darin Adler.
3281
3282         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3283         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
3284
3285 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3286
3287         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
3288         https://bugs.webkit.org/show_bug.cgi?id=147727
3289
3290         Reviewed by Sergio Villar Senin.
3291
3292         I think it was not this test in particular, but
3293         /webkit2/WebKitWebView/custom-charset that is affecting the
3294         others. This is because changing the encoding reloads the page,
3295         but we don't wait for the page to be reloaded, so when the test
3296         finishes and other test starts the web process is still reloading
3297         the page.
3298
3299         * Scripts/run-gtk-tests:
3300         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
3301         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3302         (testWebViewCustomCharset): Wait until page is reloaded after
3303         changing the charset.
3304
3305 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3306
3307         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
3308
3309         It's timing out in the bots. My guess is that there's no installer
3310         installed in the bots and gst_install_plugins_supported() returns
3311         false, so we don't even get a permission request because no
3312         installer will be launched.
3313
3314         * Scripts/run-gtk-tests:
3315         (TestRunner):
3316
3317 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3318
3319         [GTK] Another build fix after r188157.
3320
3321         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3322         (WTR::PlatformWebView::viewSupportsOptions):
3323         Name all the things correctly!
3324
3325 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3326
3327         [EFL, GTK] Build fix after r188176.
3328
3329         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3330         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
3331
3332 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3333
3334         [GTK] Speculative build fix after r188157.
3335
3336         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3337         (WTR::PlatformWebView::PlatformWebView):
3338         Update parameter list.
3339
3340 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3341
3342         Build more testing binaries with CMake on Windows
3343         https://bugs.webkit.org/show_bug.cgi?id=147799
3344
3345         Reviewed by Brent Fulgham.
3346
3347         * DumpRenderTree/CMakeLists.txt:
3348         Build TestNetscapePlugin.
3349         * DumpRenderTree/PlatformWin.cmake:
3350         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
3351         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
3352         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
3353         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
3354         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
3355         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
3356         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
3357         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
3358         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
3359
3360 2015-08-07  Jason Marcell  <jmarcell@apple.com>
3361
3362         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
3363         https://bugs.webkit.org/show_bug.cgi?id=147667
3364
3365         Reviewed by Daniel Bates.
3366
3367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3368         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
3369         other than "openSource" and "internal".
3370         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
3371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3372         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
3373         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
3374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3375         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3376         (sortedPlatforms): Deleted.
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3378         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3379         (sortedPlatforms): Deleted.
3380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3381         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
3382         and sorts them by this property returning the new sorted array.
3383
3384 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
3385
3386         Lightweight locks should be adaptive
3387         https://bugs.webkit.org/show_bug.cgi?id=147545
3388
3389         Reviewed by Geoffrey Garen.
3390
3391         * TestWebKitAPI/CMakeLists.txt:
3392         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3394         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
3395         (TestWebKitAPI::runLockTest):
3396         (TestWebKitAPI::TEST):
3397
3398 2015-08-07  Anders Carlsson  <andersca@apple.com>
3399
3400         Fix a tyop.
3401
3402         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3403         (WTR::PlatformWebView::viewSupportsOptions):
3404
3405 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
3406
3407         Update AppEngine app version numbers to the latest commit.
3408
3409         * QueueStatusServer/app.yaml:
3410         * TestResultServer/app.yaml:
3411
3412 2015-08-07  Anders Carlsson  <andersca@apple.com>
3413
3414         Simplify WKTR's view options
3415         https://bugs.webkit.org/show_bug.cgi?id=147791
3416
3417         Reviewed by Sam Weinig.
3418
3419         Instead of using a WKDictionaryRef, just use a struct for the options.
3420
3421         * WebKitTestRunner/PlatformWebView.h:
3422         (WTR::PlatformWebView::options):
3423         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3424         * WebKitTestRunner/TestController.cpp:
3425         (WTR::TestController::initialize):
3426         (WTR::TestController::createWebViewWithOptions):
3427         (WTR::TestController::ensureViewSupportsOptions):
3428         (WTR::TestController::updateLayoutTypeForTest):
3429         * WebKitTestRunner/TestController.h:
3430         * WebKitTestRunner/ViewOptions.h: Added.
3431         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3432         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3433         (WTR::PlatformWebView::PlatformWebView):
3434         (WTR::PlatformWebView::viewSupportsOptions):
3435         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3436         (WTR::PlatformWebView::viewSupportsOptions):
3437         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3438         (WTR::PlatformWebView::viewSupportsOptions):
3439         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3440         (WTR::PlatformWebView::PlatformWebView):
3441         (WTR::PlatformWebView::viewSupportsOptions):
3442         * WebKitTestRunner/mac/TestControllerMac.mm:
3443         (WTR::TestController::platformConfigureViewForTest):
3444
3445 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3446
3447         Running tests for a long time results in some tests running very slowly (throttling)
3448         https://bugs.webkit.org/show_bug.cgi?id=147718
3449
3450         Reviewed by Chris Dumez.
3451
3452         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
3453         Although COCOA ports default this setting to be disabled in WebKit1,
3454         we should make both test harnesses disable the setting for consistency.
3455
3456         * DumpRenderTree/mac/DumpRenderTree.mm:
3457         (resetWebPreferencesToConsistentValues):
3458
3459 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
3460
3461         Use a specific version of Speedometer in run-benchmark
3462         https://bugs.webkit.org/show_bug.cgi?id=147769
3463
3464         Reviewed by Chris Dumez.
3465
3466         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
3467
3468         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
3469
3470 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
3471
3472         twisted_http_server.py should support --port
3473         https://bugs.webkit.org/show_bug.cgi?id=147771
3474
3475         Reviewed by Chris Dumez.
3476
3477         Added the option. This makes the script more useful on its own.
3478
3479         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3480
3481 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3482
3483         [GTK] WTF unit tests are timing out in the bots
3484         https://bugs.webkit.org/show_bug.cgi?id=147777
3485
3486         Reviewed by Filip Pizlo.
3487
3488         Add a way to mark google unit tests as slow and add
3489         WTF_Lock.ContentedShortSection to the list. In case of slow test
3490         we use the double of the given timeout for that particular test.
3491
3492         * Scripts/run-gtk-tests:
3493         (TestRunner):
3494         (TestRunner._run_google_test):
3495
3496 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3497
3498         [GTK] run-gtk-tests should not stop when a google test case fails
3499         https://bugs.webkit.org/show_bug.cgi?id=147778
3500
3501         Reviewed by Philippe Normand.
3502
3503         For glib based tests we run the test runner with the -k option,
3504         but for google tests we are aborting as soon as we find a failure.
3505
3506         * Scripts/run-gtk-tests:
3507         (TestRunner._run_google_test_suite): Use a global return code that
3508         is set to 1 when any test has failed.
3509
3510 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3511
3512         [GStreamer] Do not automatically show PackageKit codec installation notifications
3513         https://bugs.webkit.org/show_bug.cgi?id=135973
3514
3515         Reviewed by Philippe Normand.
3516
3517         Handle the missing media plugins installation permission request
3518         in MiniBrowser and add a test case for the new API.
3519
3520         * MiniBrowser/gtk/BrowserWindow.c:
3521         (webViewDecidePermissionRequest):
3522         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3523         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3524         (permissionRequestCallback):
3525         (testInstallMissingPluginsPermissionRequest):
3526         (beforeAll):
3527         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3528         (methodCallCallback):
3529
3530 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
3531
3532         Running tests for a long time results in some tests running very slowly (throttling)
3533         https://bugs.webkit.org/show_bug.cgi?id=147718
3534
3535         Reviewed by Alexey Proskuryakov.
3536
3537         * WebKitTestRunner/TestController.cpp:
3538         (WTR::TestController::resetPreferencesToConsistentValues):
3539         Ensure throttling settings are disabled for tests for all ports, as
3540         COCOA ports default to having these setting enabled. Note, there is
3541         still other timer throttling not covered by these setting.
3542
3543 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3544
3545         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
3546         https://bugs.webkit.org/show_bug.cgi?id=147752
3547
3548         Reviewed by Chris Dumez.
3549
3550         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
3551
3552         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
3553         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
3554
3555         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
3556         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
3557         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
3558         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
3559         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
3560         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3561         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
3562         HTTPServerDriverFactory taking the platform name as an argument.
3563         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
3564         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
3565         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
3566         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
3567         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
3568         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
3569         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.