21cf86b1b4401e743ab6012cb786daa7cad62499
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-28  Tony Chang  <tony@chromium.org>
2
3         ews bots should pass --force to update-webkit-chromium
4         https://bugs.webkit.org/show_bug.cgi?id=73230
5
6         Reviewed by Adam Barth.
7
8         This makes it less likely for gclient changes to break the bots (e.g.,
9         if a DEPS repository moves or is switched to a branch).
10
11         Also pass --force when using |build-webkit --update-chromium| since this
12         appears to only be used by the bots.
13
14         * Scripts/update-webkit:
15         * Scripts/webkitdirs.pm:
16         (determineIsChromium): Add --force-update to update-webkit --chromium.
17         (forceChromiumUpdate):
18         (buildChromium): Pass --force to update-webkit-chromium.
19         * Scripts/webkitpy/tool/steps/update.py:
20         (Update.run): Add --force-update if non-interactive (i.e., bots).
21         * Scripts/webkitpy/tool/steps/update_unittest.py:
22
23 2011-11-28  Michael Saboff  <msaboff@apple.com>
24
25         Fixed help message for --exclude-kraken to say that
26         it excludes Kraken and not SunSpider.
27
28         Rubber-stamped by Filip Pizlo.
29
30         * Scripts/bencher:
31
32 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
33
34         Unreviewed, rolling out r101273.
35         http://trac.webkit.org/changeset/101273
36         https://bugs.webkit.org/show_bug.cgi?id=73244
37
38         multiple test failures and timeouts (Requested by tony^work on
39         #webkit).
40
41         * DumpRenderTree/DumpRenderTree.gypi:
42         * DumpRenderTree/chromium/EventSender.cpp:
43         (EventSender::keyDown):
44         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
45         (AlarmHandler):
46         (TestShell::waitTestFinished):
47         (platformInit):
48         (openStartupDialog):
49         (checkLayoutTestSystemDependencies):
50         * DumpRenderTree/chromium/TestShellGtk.cpp:
51         (AlarmHandler):
52         (setupFontconfig):
53         (TestShell::waitTestFinished):
54         (platformInit):
55         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
56         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
57
58 2011-11-28  John Yani  <vanuan@gmail.com>
59
60         new-run-webkit-tests is locale dependent
61         https://bugs.webkit.org/show_bug.cgi?id=68691
62
63         Reviewed and modified by Eric Seidel.
64
65         This is a simpler version of John's patch which I'm landing.
66         This just engages the hacks from the Host constructor on a global
67         basis.
68
69         * Scripts/webkitpy/common/host.py:
70         (Host.__init__):
71         (Host._engage_awesome_locale_hacks):
72
73 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
74
75         [Chromium] Fix broken DRT build for Aura Linux
76         https://bugs.webkit.org/show_bug.cgi?id=72667
77
78         Reviewed by Tony Chang.
79
80         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
81
82         The following changes have been made:
83
84           1. Renamed TestShellAndroid to TestShellLinux.
85           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
86           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
87
88         * DumpRenderTree/DumpRenderTree.gypi:
89         * DumpRenderTree/chromium/EventSender.cpp:
90         (EventSender::keyDown):
91         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
92         * DumpRenderTree/chromium/TestShellGtk.cpp:
93         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
94         (AlarmHandler):
95         (TestShell::waitTestFinished):
96         (setupFontconfig):
97         (platformInit):
98         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
99         (checkLayoutTestSystemDependencies):
100         (openStartupDialog):
101
102 2011-11-28  Eric Seidel  <eric@webkit.org>
103
104         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
105         https://bugs.webkit.org/show_bug.cgi?id=71983
106
107         Reviewed by Adam Barth.
108
109         We'll add more code to Environment overtime,
110         allowing us to mock out more of our direct interactions with os.environ.
111
112         This patch also makes run_command print the passed in environment.
113
114         * Scripts/webkitpy/common/host_mock.py:
115         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
116         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
117         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
118         * Scripts/webkitpy/common/system/executive.py:
119         * Scripts/webkitpy/common/system/executive_mock.py:
120         * Scripts/webkitpy/layout_tests/port/webkit.py:
121         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
122         * Scripts/webkitpy/tool/commands/download_unittest.py:
123         * Scripts/webkitpy/tool/steps/build.py:
124
125 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
126
127         [Qt] Build system fixes against V8.
128
129         Reviewed by Tor Arne Vestbø.
130
131         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
132         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
133         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
134
135 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
136
137         Make sure the useFixedLayout feature is consistently handled
138         https://bugs.webkit.org/show_bug.cgi?id=73212
139
140         Reviewed by Simon Hausmann.
141
142         The web page parameters are set to our Qt defaults and are now altered
143         in the WebKitTestRunner.
144
145         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
146         (WTR::WrapperWindow::WrapperWindow):
147
148 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
149
150         [Qt] WTF should be built as separate static library
151         https://bugs.webkit.org/show_bug.cgi?id=73201
152
153         Reviewed by Tor Arne Vestbø.
154
155         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
156         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
157         thus wtf dependency.
158         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
159         * WebKitTestRunner/Target.pri: Ditto.
160         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
161         consider wtf, too.
162         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
163         moved into wtf.prf.
164         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
165         link in libwtf.
166         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
167
168 2011-11-28  Kentaro Hara  <haraken@chromium.org>
169
170         run-bindings-tests shows diff error for a newly added binding test
171         https://bugs.webkit.org/show_bug.cgi?id=73179
172
173         Reviewed by Adam Barth.
174
175         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
176         run-bindings-tests just shows diff error because reference files
177         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
178
179             FAIL: (V8) V8TestSupplemental.h
180             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
181
182         Instead, this patch treats a non-existent reference file as an empty file and
183         shows the result of the newly added binding test, like this:
184
185             FAIL: (V8) V8TestSupplemental.h
186             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
187             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
188             @@ -0,0 +1,84 @@
189             +/*
190             +    This file is part of the WebKit open source project.
191             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
192             +
193             (omitted)
194
195         * Scripts/run-bindings-tests:
196         (detect_changes): Just added an -N option to the diff command.
197
198 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
199
200         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
201         https://bugs.webkit.org/show_bug.cgi?id=73165
202
203         Reviewed by Philippe Normand.
204
205         Fix some syntax errors in this script and remove an unused variable.
206
207         * gtk/generate-gtkdoc:
208         (get_webkit2_options.src_path): 
209         (get_webkit2_options):
210         (get_webkit1_options.src_path):
211
212 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
213
214         [wx] Unreviewed build fix. Enable the inspector.
215         
216         * waf/build/settings.py:
217
218 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
219
220         Try to fix the build after r101174.
221
222         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
223
224 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
225
226         [GTK] Integrate build-gtkdoc into build-webkit and make
227         https://bugs.webkit.org/show_bug.cgi?id=72626
228
229         Reviewed by Philippe Normand.
230
231         * GNUmakefile.am: Added support for new scripts and "make docs".
232         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
233         (buildAutotoolsProject):
234         * gtk/generate-gtkdoc: Added.
235         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
236
237 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
238
239         [Qt] Add support for using OWRT with Qt5
240         https://bugs.webkit.org/show_bug.cgi?id=72947
241
242         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
243
244         Reviewed by Csaba Osztrogonác.
245
246         * Scripts/old-run-webkit-tests:
247
248 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
249
250         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
251         https://bugs.webkit.org/show_bug.cgi?id=73126
252
253         No need to have a separate client call for this. The front-end can store messages
254         which arrive before front-end loaded and dispatch them later. This happens in layout
255         tests only by the way as all other messages should be initiated by the front-end code.
256
257         Reviewed by Pavel Feldman.
258
259         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
260         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
261         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
262         * DumpRenderTree/chromium/DRTDevToolsClient.h:
263
264 2011-11-24  Kentaro Hara  <haraken@chromium.org>
265
266         Replace subprocess.call() with subprocess.Popen()
267         https://bugs.webkit.org/show_bug.cgi?id=73105
268
269         Reviewed by Adam Barth.
270
271         Currently, the stdout and stderr of the child processes of run-bindings-tests
272         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
273         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
274         between a parent process and a child process. This patch replaces subprocess.call() with
275         subprocess.Popen() and synchronizes the stdout and stderr between them.
276         This patch also makes output messages of run-bindings-tests more readable.
277
278         With this patch, the output messages of run-bindings-tests look like as follows:
279
280             PASS: (CPP) WebDOMTestObj.h
281             PASS: (CPP) WebDOMTestObj.cpp
282             FAIL: (CPP) WebDOMTestInterface.h
283             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
284             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
285             @@ -23,7 +23,7 @@
286              #ifndef WebDOMTestInterface_h
287              #define WebDOMTestInterface_h
288
289             -#if ENABLE(Condition1) || ENABLE(Condition2)
290             +#if ENABLE(Condition1) || ENABLE(Condition3)
291
292              #include <WebDOMObject.h>
293              #include <WebDOMString.h>
294              @@ -53,5 +53,5 @@
295              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
296
297              #endif
298             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
299             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
300             PASS: (CPP) WebDOMFloat64Array.cpp
301             PASS: (CPP) WebDOMFloat64Array.h
302
303             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
304
305         * Scripts/run-bindings-tests:
306         (generate_from_idl):
307         (detect_changes):
308         (run_tests):
309         (main):
310
311 2011-11-24  Kentaro Hara  <haraken@chromium.org>
312
313         Fix the current working directory of run-bindings-tests
314         https://bugs.webkit.org/show_bug.cgi?id=73106
315
316         Reviewed by Adam Barth.
317
318         Currently, run-bindings-tests outputs the following error
319         (although it outputs "all tests passed!" in the end):
320
321             Testing the ObjC generator on TestObj.idl
322             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
323             gcc: warning: '-x objective-c' after last input file has no effect
324             gcc: no input files
325
326         This is because CodeGeneratorObjC.pm assumes that the current working directory
327         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
328         Thus, this patch changes it to WebKit/Source/.
329
330         * Scripts/run-bindings-tests:
331         (generate_from_idl):
332         (main):
333
334 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
335
336         [Qt] Get rid of the buildDirForSource() function in the build system
337
338         At some point the plan was to allow for running qmake on sub-trees
339         of the sources, into the top level build directory, but this is no
340         longer possible, so no reason to keep the convenience function around.
341
342         Reviewed by Simon Hausmann.
343
344         * WebKitTestRunner/DerivedSources.pri:
345         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
346         * qmake/mkspecs/features/default_post.prf:
347         * qmake/mkspecs/features/default_pre.prf:
348         * qmake/mkspecs/features/functions.prf:
349         * qmake/mkspecs/features/javascriptcore.prf:
350         * qmake/mkspecs/features/webcore.prf:
351         * qmake/mkspecs/features/webkit2.prf:
352
353 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
354
355         Unreviewed, rolling out r101107.
356         http://trac.webkit.org/changeset/101107
357         https://bugs.webkit.org/show_bug.cgi?id=73062
358
359         Breaks the commit-queue (Requested by abarth on #webkit).
360
361         * Scripts/webkitpy/common/host.py:
362         (Host._engage_awesome_windows_hacks):
363         * Scripts/webkitpy/common/host_mock.py:
364         (MockHost.__init__):
365         * Scripts/webkitpy/common/system/environment.py: Removed.
366         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
367         * Scripts/webkitpy/common/system/executive.py:
368         (Executive._run_command_with_teed_output):
369         (Executive.run_and_throw_if_fail):
370         * Scripts/webkitpy/common/system/executive_mock.py:
371         (MockExecutive.run_and_throw_if_fail):
372         (MockExecutive.run_command):
373         * Scripts/webkitpy/layout_tests/port/webkit.py:
374         (WebKitPort._driver_build_script_name):
375         (WebKitPort._run_script):
376         (WebKitPort._build_driver):
377         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
378         (test_build_driver):
379         * Scripts/webkitpy/tool/commands/download_unittest.py:
380         * Scripts/webkitpy/tool/steps/build.py:
381         (Build.build):
382
383 2011-11-23  Ojan Vafai  <ojan@chromium.org>
384
385         Unreviewed, rolling out r101110.
386         http://trac.webkit.org/changeset/101110
387         https://bugs.webkit.org/show_bug.cgi?id=73057
388
389         The bots have now cycled and this patch is no longer needed.
390
391         * Scripts/webkitpy/layout_tests/controllers/manager.py:
392         (Manager._upload_json_files):
393
394 2011-11-23  Ojan Vafai  <ojan@chromium.org>
395
396         Temporarily save the incremental results json in order to identify bug
397         https://bugs.webkit.org/show_bug.cgi?id=73057
398
399         Reviewed by Dean Jackson.
400
401         The test results server needed to be rolled back from tip of tree
402         due to a JSON merging bug. It's hard to identify what the bug is without
403         the raw data.
404
405         * Scripts/webkitpy/layout_tests/controllers/manager.py:
406         (Manager._upload_json_files):
407
408 2011-11-23  Ojan Vafai  <ojan@chromium.org>
409
410         Merging two version 4 results hits an error in the test results server
411         https://bugs.webkit.org/show_bug.cgi?id=73042
412
413         Reviewed by Adam Barth.
414
415         The old code assumed that if the aggregate results value was not a leaf
416         value that the incremental results would exist, which is just totally
417         wrong. Added a test for that case as well.
418
419         * TestResultServer/model/jsonresults.py:
420         (JsonResults._merge_tests):
421         * TestResultServer/model/jsonresults_unittest.py:
422         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
423         (JsonResultsTest.test_merge_build_directory_hierarchy):
424
425 2011-11-23  Eric Seidel  <eric@webkit.org>
426
427         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
428         https://bugs.webkit.org/show_bug.cgi?id=71983
429
430         Reviewed by Adam Barth.
431
432         We'll add more code to Environment overtime,
433         allowing us to mock out more of our direct interactions with os.environ.
434
435         This patch also makes run_command print the passed in environment.
436
437         * Scripts/webkitpy/common/host_mock.py:
438         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
439         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
440         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
441         * Scripts/webkitpy/common/system/executive.py:
442         * Scripts/webkitpy/common/system/executive_mock.py:
443         * Scripts/webkitpy/layout_tests/port/webkit.py:
444         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
445         * Scripts/webkitpy/tool/commands/download_unittest.py:
446         * Scripts/webkitpy/tool/steps/build.py:
447
448 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
449
450         [Qt] Re-generate QtWebKit API forwarding headers when API changes
451
452         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
453         so we need sync.profile to live in the same directory as the project file
454         that will be touched when adding/removing API (api.pri in our case).
455
456         Since the WebKit2 APIs live in a separate static library, we have to
457         add the project file for WebKit2 as a dependency of the api.pri file
458         as well, so that any changes to the WebKit2 API will still trigger a
459         run of qmake (and then syncqt).
460
461         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
462         that the forwarding headers are still generated in the root build dir,
463         not in the Source dir along with the internal forwarding headers.
464
465         Reviewed by Andreas Kling.
466
467         * qmake/mkspecs/features/default_pre.prf:
468         * qmake/mkspecs/features/functions.prf:
469
470 2011-11-23  Johnny Ding  <jnd@chromium.org>
471
472         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
473         https://bugs.webkit.org/show_bug.cgi?id=72950
474
475         Reviewed by Tony Chang.
476
477         * DumpRenderTree/chromium/LayoutTestController.cpp:
478         (LayoutTestController::queueLoadHTMLString):
479
480 2011-11-23  Adam Barth  <abarth@webkit.org>
481
482         garden-o-matic should display a message if it can't find results to display
483         https://bugs.webkit.org/show_bug.cgi?id=72991
484
485         Reviewed by Dimitri Glazkov.
486
487         Not all failures (e.g., TIMEOUT) have results that we can display.
488         This patch adds a short message so that the user can see that we're
489         done trying to load the results.
490
491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
494
495 2011-11-23  Adam Barth  <abarth@webkit.org>
496
497         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
498         https://bugs.webkit.org/show_bug.cgi?id=72992
499
500         Reviewed by Dimitri Glazkov.
501
502         This patch also prepares us to list other sorts of failures, like
503         performance and unit test.
504
505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
509
510 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
511
512         Add new Chromium tests to the flakiness dashboard
513         https://bugs.webkit.org/show_bug.cgi?id=72997
514
515         Reviewed by Ojan Vafai.
516
517         * TestResultServer/static-dashboards/dashboard_base.js:
518         ():
519
520 2011-11-23  Adam Barth  <abarth@webkit.org>
521
522         garden-o-matic should support AUDIO failures
523         https://bugs.webkit.org/show_bug.cgi?id=69477
524
525         Reviewed by Dimitri Glazkov.
526
527         This is a first iteration at supporting AUDIO failures in
528         garden-o-matic.  We'll probably need to iterate a bit when we have a
529         real audio failure in the tree to play with.  For example, we'll
530         probably want to add and <audio> element to the "Examine" view to hear
531         the differences, but that all can be done in a subsequent patch.
532
533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
534
535 2011-11-23  Scott Graham  <scottmg@chromium.org>
536
537         Adding gamepad support
538         https://bugs.webkit.org/show_bug.cgi?id=69451
539
540         Reviewed by Darin Fisher.
541
542         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
543         gamepad data that will be retrieved when JS code pulls via API access.
544
545         * DumpRenderTree/DumpRenderTree.gypi:
546         * DumpRenderTree/chromium/GamepadController.cpp: Added.
547         (GamepadController::GamepadController):
548         (GamepadController::bindToJavascript):
549         (GamepadController::reset):
550         (GamepadController::connect):
551         (GamepadController::disconnect):
552         (GamepadController::setId):
553         (GamepadController::setButtonCount):
554         (GamepadController::setButtonData):
555         (GamepadController::setAxisCount):
556         (GamepadController::setAxisData):
557         (GamepadController::fallbackCallback):
558         * DumpRenderTree/chromium/GamepadController.h: Added.
559         * DumpRenderTree/chromium/TestShell.cpp:
560         (TestShell::TestShell):
561         (TestShell::resetTestController):
562         (TestShell::bindJSObjectsToWindow):
563         * DumpRenderTree/chromium/TestShell.h:
564         (TestShell::gamepadController):
565
566 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
567
568         [CMake] Move the top-level logic to the top-level directory.
569         https://bugs.webkit.org/show_bug.cgi?id=72685
570
571         Reviewed by Brent Fulgham.
572
573         * CMakeLists.txt: Added.
574         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
575         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
576         * Scripts/webkitdirs.pm:
577         (generateBuildSystemFromCMakeProject):
578         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
579
580 2011-11-17  Vincent Scheib  <scheib@chromium.org>
581
582         Pointer Lock: Initial Tests for navigator.webkitPonter
583         https://bugs.webkit.org/show_bug.cgi?id=72659
584
585         Reviewed by Darin Fisher.
586
587         * DumpRenderTree/chromium/TestShell.cpp:
588         (TestShell::TestShell):
589             Enabling PointerLock in TestShell
590
591 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
592
593         Update flakiness dashboard for new Chromium builders and tests
594         https://bugs.webkit.org/show_bug.cgi?id=72931
595
596         Reviewed by Ojan Vafai.
597
598         * TestResultServer/static-dashboards/builders.js:
599         * TestResultServer/static-dashboards/dashboard_base.js:
600
601 2011-11-22  Adam Roben  <aroben@apple.com>
602
603         Remove some debugging code I accidentally left in r101005
604
605         * Scripts/prepare-ChangeLog:
606         (get_function_line_ranges_for_python):
607
608 2011-11-22  Adam Roben  <aroben@apple.com>
609
610         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
611
612         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
613         classes/methods in Python source files
614
615         Reviewed by Dan Bates.
616
617         * Scripts/prepare-ChangeLog:
618         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
619         or that use python as their interpreter. Modified the code that extracts the interpreter to
620         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
621         scripts.
622         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
623         for class/def lines and generate ranges based on them.
624
625 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
626
627         [GTK] Enable WebSocket hybi tests
628         https://bugs.webkit.org/show_bug.cgi?id=72870
629
630         Reviewed by Xan Lopez.
631
632         * DumpRenderTree/gtk/DumpRenderTree.cpp:
633         (resetDefaultsToConsistentValues):
634         Reset the setting value to the default value (true).
635         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
636         (LayoutTestController::overridePreference):
637         Change the setting value through a function in DumpRenderTreeSupportGtk.
638
639 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
640
641         ChangeLogEntry should be able to parse entries with multiple authors
642         https://bugs.webkit.org/show_bug.cgi?id=72690
643
644         Reviewed by Eric Seidel.
645
646         Support multi-author change log entries in ChangeLogEntry. Split author names using
647         the same logic as splitting reviewer names. _authors now stores list of dictionaries
648         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
649         accounts because some contributors are never listed in committers.py. 
650
651         * Scripts/webkitpy/common/checkout/changelog.py:
652         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
653         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
654         throws an exception when the argument is None.
655
656 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
657
658         [Qt] Speed up debug builds.
659         https://bugs.webkit.org/show_bug.cgi?id=72882
660
661         Reviewed by Tor Arne Vestbø.
662
663         Introduce a special type of build that replaces the static jsc/wc/wk2
664         static libraries with shared libraries, that individually are much faster
665         to link and don't require relinking into the big library when changing just
666         one file in one module. It can be enabled with
667         --qmakearg="CONFIG+=force_static_libs_as_shared"
668
669         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
670         disable symbol visibility, static linkage and enable rpath.
671         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
672         we need to link the convenience libraries together or not and renamed linkStaticLibrary
673         to just linkLibrary (because linkage is not necessarily static).
674         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
675         link against jsc/wc/wk2 when linking app code against QtWebKit.
676         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
677         function.
678         * qmake/mkspecs/features/webcore.prf: Ditto.
679         * qmake/mkspecs/features/webkit2.prf: Ditto.
680
681 2011-11-21  Adam Klein  <adamk@chromium.org>
682
683         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
684         https://bugs.webkit.org/show_bug.cgi?id=72898
685
686         Reviewed by Ojan Vafai.
687
688         Also removed a comment that was going to be more trouble to keep up to
689         date than seemed worthwhile (the code is now the documentation).
690
691         * TestResultServer/static-dashboards/flakiness_dashboard.html:
692
693 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
694
695         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
696         https://bugs.webkit.org/show_bug.cgi?id=72895
697
698         Reviewed by Chris Fleizach.
699
700         * DumpRenderTree/chromium/WebViewHost.cpp:
701         (WebViewHost::postAccessibilityNotification):
702
703 2011-11-21  Philippe Normand  <pnormand@igalia.com>
704
705         Unreviewed, run-gtk-tests temporary workaround after r98500.
706
707         * Scripts/run-gtk-tests: Try to find the build directory like in
708         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
709
710 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
711
712         [GTK] Add a way to skip unit tests in the bots
713         https://bugs.webkit.org/show_bug.cgi?id=72879
714
715         Reviewed by Philippe Normand.
716
717         Rewrite the script in python to make it easier for everybody to
718         change it and add support for skipping tests.
719
720         * Scripts/run-gtk-tests:
721
722 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
723
724         [EFL] Add more appcache functions to ewk_settings.
725         https://bugs.webkit.org/show_bug.cgi?id=72143
726
727         Reviewed by Kenneth Rohde Christiansen.
728
729         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
730         (LayoutTestController::clearAllApplicationCaches):
731         (LayoutTestController::setAppCacheMaximumSize): Use the right
732         function, this is not related to the memory cache, but rather to the
733         appcache.
734
735 2011-11-18  Adam Roben  <aroben@apple.com>
736
737         Make NRWT consider all lines of output from parse-malloc-history, not just the first
738
739         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
740         found" even when there are more than 1 unique leaks
741
742         Reviewed by Darin Adler.
743
744         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
745         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
746         "^" will be considered to match the beginning of any line, not only the beginning of the
747         string.
748
749         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
750         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
751         fake output and updated expectations to match.
752
753 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
754
755         [Qt] Clean up MiniBrowser project file after recent changes
756         https://bugs.webkit.org/show_bug.cgi?id=72869
757
758         Reviewed by Simon Hausmann.
759
760         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
761
762         * MiniBrowser/qt/MiniBrowser.pro:
763
764 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
765
766         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
767         https://bugs.webkit.org/show_bug.cgi?id=72479
768
769         Reviewed by Chris Fleizach.
770
771         * DumpRenderTree/AccessibilityUIElement.cpp:
772         (getIsSelectedOptionActiveCallback):
773         (AccessibilityUIElement::getJSClass):
774         * DumpRenderTree/AccessibilityUIElement.h:
775         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
776         (AccessibilityUIElement::AccessibilityUIElement):
777         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
778         * DumpRenderTree/chromium/AccessibilityUIElement.h:
779         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
780         (AccessibilityUIElement::isSelectedOptionActive):
781         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
782         (AccessibilityUIElement::isSelectedOptionActive):
783         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
784         (AccessibilityUIElement::isSelectedOptionActive):
785
786 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
787
788         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
789         https://bugs.webkit.org/show_bug.cgi?id=72859
790
791         Reviewed by Eric Seidel.
792         
793         * Scripts/new-run-webkit-websocketserver:
794
795 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
796
797         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
798         https://bugs.webkit.org/show_bug.cgi?id=72655
799
800         Reviewed by Hajime Morita.
801
802         Fixed the calculation of offset.
803
804         * DumpRenderTree/chromium/WebViewHost.cpp:
805         (WebViewHost::finishLastTextCheck):
806
807 2011-11-20  Ojan Vafai  <ojan@chromium.org>
808
809         Change the final place where we use version 3 of the results json output
810         https://bugs.webkit.org/show_bug.cgi?id=72838
811
812         Reviewed by Adam Barth.
813
814         This converts the json from being a flat map of test name --> results
815         to being hierarchical by directory. This will make the json files 
816         considerably smaller.
817
818         Also cleaned up some functions that were returning/checking boolean values
819         that were always True.
820
821         * TestResultServer/model/jsonresults.py:
822         * TestResultServer/model/jsonresults_unittest.py:
823
824 2011-11-20  Ojan Vafai  <ojan@chromium.org>
825
826         Include the master name when querying the test results server.
827         This will soon be required since leaving the master name out mean
828         that multiple files could match the query.
829
830         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
831
832 2011-11-19  Ojan Vafai  <ojan@chromium.org>
833
834         Fix jsonp callback code to add the callback if json content
835         is not jsonp.
836         * TestResultServer/handlers/testfilehandler.py:
837
838 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
839
840         Modify dashboard_base.js to optionally accept version 4 results json.
841
842         Reviewed by Ojan Vafai.
843
844         * TestResultServer/static-dashboards/dashboard_base.js:
845         (ADD_RESULTS):
846         (flattenTrie):
847         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
848         (testFlattenTrie):
849
850 2011-11-19  Ojan Vafai  <ojan@chromium.org>
851
852         Stop storing results files as jsonp in the test results server
853         https://bugs.webkit.org/show_bug.cgi?id=72814
854
855         Reviewed by Adam Barth.
856
857         * TestResultServer/model/jsonresults.py:
858         * TestResultServer/model/jsonresults_unittest.py:
859
860 2011-11-19  Ojan Vafai  <ojan@chromium.org>
861
862         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
863         https://bugs.webkit.org/show_bug.cgi?id=72813
864
865         Reviewed by Adam Barth.
866
867         Once this lands, we can start storing pure json in the test results server and then
868         we can delete the code with all the FIXMEs added here.
869
870         * Scripts/webkitpy/layout_tests/controllers/manager.py:
871         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
872         Only add jsonp for full_results.json.
873         * TestResultServer/model/jsonresults.py:
874         * TestResultServer/model/jsonresults_unittest.py:
875         Accept pure json uploads.
876         * TestResultServer/static-dashboards/dashboard_base.js:
877         (appendJSONScriptElementFor):
878         Use the callback parameter so that the server can start returning pure json if it's left out.
879
880 2011-11-19  Ojan Vafai  <ojan@chromium.org>
881
882         Allow json NRWT downloads to be pure json and not jsonp
883         https://bugs.webkit.org/show_bug.cgi?id=72809
884
885         Reviewed by Adam Barth.
886
887         I'm moving the server to storing and serving up raw json instead of jsonp.
888         You can still get the jsonp by passing a "callback" parameter, but there's no
889         need for run-webkit-tests to get jsonp when all it wants is the raw json.
890
891         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
892         Make the wrapper stripping only happen if the json is actually wrapped.
893         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
894
895 2011-11-18  Daniel Bates  <dbates@rim.com>
896
897         Add CMake build infrastructure for the BlackBerry port
898         https://bugs.webkit.org/show_bug.cgi?id=72768
899
900         Reviewed by Antonio Gomes.
901
902         Add optional --blackberry command line argument to build-webkit to build the
903         BlackBerry port.
904
905         * Scripts/build-webkit:
906         * Scripts/webkitdirs.pm:
907         (determineBaseProductDir):
908         (argumentsForConfiguration):
909         (builtDylibPathForName):
910         (determineIsQt):
911         (isBlackBerry): Added.
912         (determineIsBlackBerry): Added.
913         (blackberryTargetArchitecture): Added.
914         (isAppleWebKit):
915
916 2011-11-18  James Robinson  <jamesr@chromium.org>
917
918         Unreviewed, rolling out r100835.
919         http://trac.webkit.org/changeset/100835
920         https://bugs.webkit.org/show_bug.cgi?id=72778
921
922         Broke some page scale tests
923
924         * DumpRenderTree/chromium/EventSender.cpp:
925         (EventSender::scalePageBy):
926
927 2011-11-18  Adam Barth  <abarth@webkit.org>
928
929         Prepare to move manual-tests out of WebCore
930         https://bugs.webkit.org/show_bug.cgi?id=72782
931
932         Reviewed by Eric Seidel.
933
934         Update this file to refer to the new location of ManualTests.
935
936         * Scripts/webkitpy/common/config/build.py:
937
938 2011-11-18  James Robinson  <jamesr@chromium.org>
939
940         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
941         https://bugs.webkit.org/show_bug.cgi?id=72778
942
943         Reviewed by Kenneth Russell.
944
945         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
946
947         * DumpRenderTree/chromium/EventSender.cpp:
948         (EventSender::scalePageBy):
949
950 2011-11-18  Scott Graham  <scottmg@chromium.org>
951
952         IDL changes for gamepad support
953         https://bugs.webkit.org/show_bug.cgi?id=71753
954
955         Reviewed by Adam Barth.
956
957         Runtime enable gamepad in chromium test shell.
958
959         * DumpRenderTree/chromium/TestShell.cpp:
960         (TestShell::TestShell):
961
962 2011-10-27  Darin Fisher  <darin@chromium.org>
963
964         [chromium] Improve fullscreen API
965         https://bugs.webkit.org/show_bug.cgi?id=70477
966
967         Reviewed by Adam Barth.
968
969         Implement enter/exitFullScreen.  The implementation is asynchronous,
970         via postDelayedTask, to simulate how the browser actually behaves.
971
972         * DumpRenderTree/chromium/WebViewHost.cpp:
973         (WebViewHost::enterFullScreen):
974         (WebViewHost::exitFullScreen):
975         (WebViewHost::setAddressBarURL):
976         (WebViewHost::enterFullScreenNow):
977         (WebViewHost::exitFullScreenNow):
978         * DumpRenderTree/chromium/WebViewHost.h:
979
980 2011-11-18  Adam Roben  <aroben@apple.com>
981
982         Ignore an ANGLE leak that is not WebKit's fault
983
984         * Scripts/old-run-webkit-tests:
985         (countAndPrintLeaks):
986         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
987         (LeakDetector._callstacks_to_exclude_from_leaks):
988         Added ScanFromString to the call stacks to exclude on all OS versions.
989
990 2011-11-18  Adam Roben  <aroben@apple.com>
991
992         Ignore another Lion-specific leak that is not WebKit's fault
993
994         * Scripts/old-run-webkit-tests:
995         (countAndPrintLeaks):
996         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
997         (LeakDetector._callstacks_to_exclude_from_leaks):
998         Added SecTransformExecute to the call stacks to exclude.
999
1000 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
1001
1002         [Qt] Enable WebSocket hybi tests
1003         https://bugs.webkit.org/show_bug.cgi?id=72687
1004
1005         Reviewed by Simon Hausmann.
1006
1007         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
1008
1009         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1010         (WebCore::WebPage::resetSettings):
1011         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1012         (LayoutTestController::overridePreference):
1013
1014 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
1015
1016         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
1017         https://bugs.webkit.org/show_bug.cgi?id=72707
1018
1019         Reviewed by Philippe Normand.
1020
1021         Make new-run-webkit-tests use the right path to locate the test
1022         plugin used by WebKitTestRunner.
1023
1024         * Scripts/webkitpy/layout_tests/port/gtk.py:
1025
1026 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
1027
1028         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
1029         https://bugs.webkit.org/show_bug.cgi?id=72697
1030
1031         Reviewed by Kenneth Rohde Christiansen.
1032
1033         * Tools.pro: Make WTR linux only for the moment.
1034         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
1035         * WebKitTestRunner/Target.pri: Ditto.
1036         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
1037         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
1038
1039 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1040
1041         [Qt] Change default size of the MiniBrowser
1042
1043         Reviewed by Simon Hausmann.
1044
1045         As we lay out desktop pages using the width of 980, change our default
1046         size to 980x735 so that we are not scaling down by default.
1047
1048         * MiniBrowser/qt/MiniBrowserApplication.h:
1049         (WindowOptions::WindowOptions):
1050
1051 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1052
1053         [EFL] Clean up the use of DATA_DIR in the buildsystem
1054         https://bugs.webkit.org/show_bug.cgi?id=72681
1055
1056         Reviewed by Daniel Bates.
1057
1058         Instead of adding -DDATA_DIR in all scopes, only define it in
1059         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
1060         it.
1061
1062         We can then define DATA_DIR to the generated theme directory for
1063         EWebLauncher, since it's what we want here.
1064
1065         * CMakeListsEfl.txt:
1066
1067 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1068
1069         [EFL] Move platform includes last in DRT's include directories.
1070         https://bugs.webkit.org/show_bug.cgi?id=72684
1071
1072         Reviewed by Daniel Bates.
1073
1074         This is the first step in fixing the build when a platform include (in
1075         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
1076         is included instead of WebKit's.
1077
1078         * DumpRenderTree/efl/CMakeLists.txt:
1079
1080 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
1081
1082         fuzzy_match doesn't recognize "Dan B" or "hyatt"
1083         https://bugs.webkit.org/show_bug.cgi?id=72636
1084
1085         Reviewed by Eric Seidel.
1086
1087         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
1088         and user names of email addreses such as rniwa in rniwa@webkit.org.
1089
1090         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
1091
1092         * Scripts/webkitpy/common/config/committers.py:
1093         * Scripts/webkitpy/common/config/committers_unittest.py:
1094
1095 2011-11-17  Eric Seidel  <eric@webkit.org>
1096
1097         Remove support for running check-webkit-style w/o a webkit checkout
1098         https://bugs.webkit.org/show_bug.cgi?id=72678
1099
1100         Reviewed by Adam Barth.
1101
1102         After talking to Dave Levin we've decided to remove this
1103         code.  I know of no users of check-webkit-style w/o a webkit checkout
1104         and this needlessly adds complexity.
1105
1106         * Scripts/webkitpy/style/main.py:
1107
1108 2011-11-17  Eric Seidel  <eric@webkit.org>
1109
1110         Remove more direct uses of os.path
1111         https://bugs.webkit.org/show_bug.cgi?id=72677
1112
1113         Reviewed by Adam Barth.
1114
1115         Remove more uses of os.path, including refactoring
1116         CommitterValidator to use a Host object instead of
1117         manual hacks to emulate what SCM and FileSystem provide.
1118
1119         * Scripts/webkitpy/common/checkout/changelog.py:
1120         * Scripts/webkitpy/common/config/committervalidator.py:
1121         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1122         * Scripts/webkitpy/common/system/filesystem_mock.py:
1123          - Turns out none of our unittests actually looked at this path.
1124            now I've made it be a valid path.
1125         * Scripts/webkitpy/tool/bot/feeders.py:
1126         * Scripts/webkitpy/tool/commands/queues.py:
1127
1128 2011-11-17  Eric Seidel  <eric@webkit.org>
1129
1130         Teach TextFileReader about FileSystem
1131         https://bugs.webkit.org/show_bug.cgi?id=72673
1132
1133         Reviewed by Adam Barth.
1134
1135         Unfortunately TextFileReader doesn't use FileSystem
1136         everywhere yet, so we can't move the unittests to
1137         using MockFileSystem, but we're close.
1138
1139         * Scripts/webkitpy/style/filereader.py:
1140         * Scripts/webkitpy/style/filereader_unittest.py:
1141         * Scripts/webkitpy/style/main.py:
1142
1143 2011-11-17  Eric Seidel  <eric@webkit.org>
1144
1145         Give check-webkit-style a Host
1146         https://bugs.webkit.org/show_bug.cgi?id=72670
1147
1148         Reviewed by Adam Barth.
1149
1150         * Scripts/webkitpy/common/checkout/scm/detection.py:
1151         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1152          - We don't run these unittests, but this one was looking for the wrong exception.
1153         * Scripts/webkitpy/style/main.py:
1154         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1155          - This was create a new scm object even though it already had one?
1156
1157 2011-11-17  Eric Seidel  <eric@webkit.org>
1158
1159         Move check-webkit-style change_directory code to more modern mocks
1160         https://bugs.webkit.org/show_bug.cgi?id=72664
1161
1162         Reviewed by Adam Barth.
1163
1164         * Scripts/check-webkit-style:
1165         * Scripts/webkitpy/style/main.py:
1166         * Scripts/webkitpy/style/main_unittest.py:
1167
1168 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
1169
1170         [GTK] enable ref tests
1171         https://bugs.webkit.org/show_bug.cgi?id=72601
1172
1173         Re-enable ref tests. Run the driver under evenly numbered display if performing
1174         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
1175         being run in an already used Xvfb instance if pixel tests are disabled.
1176
1177         Reviewed by Tony Chang.
1178
1179         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
1180         after the process is killed
1181
1182 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1183
1184         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
1185         https://bugs.webkit.org/show_bug.cgi?id=72620
1186
1187         Reviewed by David Levin.
1188
1189         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
1190         adding the suffix the cpp file. One example of false positive
1191         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
1192
1193         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
1194         basename contains the cpp's basename.
1195         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1196
1197 2011-11-17  Eric Seidel  <eric@webkit.org>
1198
1199         Move check-webkit-style's guts into webkitpy/style/main.py
1200         https://bugs.webkit.org/show_bug.cgi?id=72657
1201
1202         Reviewed by Adam Barth.
1203
1204         * Scripts/check-webkit-style:
1205         * Scripts/webkitpy/style/main.py:
1206
1207 2011-11-17  Eric Seidel  <eric@webkit.org>
1208
1209         new-run-webkit-tests is locale dependent
1210         https://bugs.webkit.org/show_bug.cgi?id=68691
1211
1212         Reviewed by Adam Barth.
1213
1214         Make NRWT use a clean environment, just like ORWT did.
1215
1216         * Scripts/webkitpy/layout_tests/port/base.py:
1217         * Scripts/webkitpy/layout_tests/port/chromium.py:
1218         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1219         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1220         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1221         * Scripts/webkitpy/layout_tests/port/efl.py:
1222         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1223         * Scripts/webkitpy/layout_tests/port/mac.py:
1224         * Scripts/webkitpy/layout_tests/port/qt.py:
1225         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1226         * Scripts/webkitpy/layout_tests/port/webkit.py:
1227         * Scripts/webkitpy/layout_tests/port/win.py:
1228
1229 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
1230
1231         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
1232         https://bugs.webkit.org/show_bug.cgi?id=72615
1233
1234         Reviewed by James Robinson.
1235
1236         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1237
1238 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
1239
1240         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
1241         https://bugs.webkit.org/show_bug.cgi?id=72595
1242
1243         Reviewed by Noam Rosenthal.
1244
1245         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1246         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
1247         ensure the registration of the DRTNode JS bindings.
1248         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1249         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
1250         registration of QWebElement (now done implicitly through QWebPage ->
1251         QtWebElementRunTime::initialize code path)
1252
1253 2011-11-17  Adam Roben  <aroben@apple.com>
1254
1255         Fix a crash-inducing typo I introduced in r100648
1256
1257         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
1258         handling a crashing test
1259
1260         Reviewed by Adam Barth.
1261
1262         * Scripts/webkitpy/layout_tests/port/chromium.py:
1263         (ChromiumDriver.run_test): Get the driver name from the port.
1264
1265         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1266         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
1267         right crashed process name.
1268
1269 2011-11-17  Adam Roben  <aroben@apple.com>
1270
1271         Fix NRWT's parsing of the number of excluded leaks
1272
1273         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
1274         leaks were excluded
1275
1276         Reviewed by Adam Barth.
1277
1278         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1279         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
1280         regular expression match, not the entire matched string.
1281
1282         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1283         (LeakDetectorTest): Added some example output that shows how things look when leaks are
1284         excluded.
1285         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
1286         correctly.
1287
1288 2011-11-17  Adam Roben  <aroben@apple.com>
1289
1290         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
1291
1292         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
1293         when web process crashes, but WebProcess crash log should get saved instead
1294
1295         Reviewed by Eric Seidel.
1296
1297         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1298         (write_test_result): Simplified a little to share more code between the case where we
1299         crashed when running the test and where we crashed when checking the expected rendering for
1300         a reftest. Changed to pass the crashed process name down to write_crash_report.
1301         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
1302         along to CrashLogs.find_newest_log rather than always using the driver name.
1303
1304         * Scripts/webkitpy/layout_tests/port/chromium.py:
1305         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
1306         crashed.
1307
1308         * Scripts/webkitpy/layout_tests/port/test.py:
1309         (TestInstance.__init__): Initialize new web_process_crash attribute.
1310         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
1311         test this patch adds.
1312         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
1313         specifies that the driver crashed or the web process crashed.
1314
1315         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1316         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
1317         which we pretend the web process crashed rather than the driver process.
1318
1319         (MainTest.test_run_singly_actually_runs_tests):
1320         (MainTest.test_unexpected_failures):
1321         (EndToEndTest.test_end_to_end):
1322         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
1323
1324 2011-11-17  Tony Chang  <tony@chromium.org>
1325
1326         [chromium] stop spamming features warning on every build
1327         https://bugs.webkit.org/show_bug.cgi?id=72629
1328
1329         Reviewed by Ojan Vafai.
1330
1331         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
1332         $mediaStreamSupport is on by default for chromium, make the default
1333         for $blobSupport also on.
1334
1335         * Scripts/build-webkit:
1336
1337 2011-11-17  Adam Roben  <aroben@apple.com>
1338
1339         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
1340
1341         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
1342         that are supposed to be ignored
1343
1344         Reviewed by Adam Barth.
1345
1346         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1347         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
1348         required when passing arguments via the shell (which we aren't doing here). It is not
1349         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
1350
1351         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1352         (LeakDetectorTest.test_leaks_args): Updated expectations.
1353
1354 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1355
1356         Unreviewed, run-bindings-tests fix after r91028.
1357
1358         * Scripts/run-bindings-tests: Use scm.detection module.
1359
1360 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
1361
1362         Silence a warning about control reaching the end of a non-void function
1363         https://bugs.webkit.org/show_bug.cgi?id=72616
1364
1365         Reviewed by Tony Gentilcore.
1366
1367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1368         (AccessibilityUIElement::verticalScrollbar):
1369
1370 2011-11-17  Adam Roben  <aroben@apple.com>
1371
1372         Ignore some leaks in frameworks we link against on Lion
1373
1374         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
1375         aren't WebKit's fault
1376
1377         Reviewed by Antti Koivisto.
1378
1379         * Scripts/old-run-webkit-tests:
1380         (countAndPrintLeaks):
1381         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1382         (LeakDetector._callstacks_to_exclude_from_leaks):
1383         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
1384
1385         * Scripts/webkitpy/layout_tests/port/mac.py:
1386         (MacPort.is_lion): Added.
1387
1388         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1389         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
1390         methods.
1391
1392 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1393
1394         [GTK] Disable ref tests
1395         https://bugs.webkit.org/show_bug.cgi?id=72599
1396
1397         Reviewed by Xan Lopez.
1398
1399         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
1400         tests to avoid massive flakiness.
1401
1402 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1403
1404         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
1405
1406         A new extension object has been added to QQuickWebView (the same approach should be used
1407         for other API classes that need experimental APIs). The QML extension mechanism is then
1408         built on top of the experimental object.
1409
1410         https://bugs.webkit.org/show_bug.cgi?id=72522
1411
1412         Reviewed by Simon Hausmann.
1413
1414         * MiniBrowser/qt/BrowserWindow.cpp:
1415         (BrowserWindow::BrowserWindow):
1416         (BrowserWindow::webView):
1417         * MiniBrowser/qt/BrowserWindow.h:
1418         * MiniBrowser/qt/UrlLoader.cpp:
1419         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1420         * qmake/mkspecs/features/default_post.prf:
1421         * qmake/mkspecs/features/default_pre.prf:
1422         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
1423         * qmake/mkspecs/features/qtwebkit.prf:
1424
1425 2011-11-17  Adam Barth  <abarth@webkit.org>
1426
1427         Move test_results_uploader.py out of layout_package
1428         https://bugs.webkit.org/show_bug.cgi?id=72590
1429
1430         Reviewed by Eric Seidel.
1431
1432         Most of the lines of code in this file are wrong, but I've restrained
1433         myself and only changed a few of them to generalized this class to the
1434         common package.
1435
1436         This is part of a series of patches to remove layout_package.
1437
1438         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
1439         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1440         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
1441
1442 2011-11-17  Adam Barth  <abarth@webkit.org>
1443
1444         Unreviewed. Fix style nits in printing.py.
1445
1446         * Scripts/webkitpy/layout_tests/views/printing.py:
1447
1448 2011-11-17  Adam Barth  <abarth@webkit.org>
1449
1450         Minor style nits in run_webkit_tests.py
1451         https://bugs.webkit.org/show_bug.cgi?id=72583
1452
1453         Reviewed by Eric Seidel.
1454
1455         This patch just fixes some minor style issues as I work my way back
1456         into this code.
1457
1458         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1459
1460 2011-11-17  Adam Barth  <abarth@webkit.org>
1461
1462         Move test_result_writer out of layout_package
1463         https://bugs.webkit.org/show_bug.cgi?id=72586
1464
1465         Rubber-stamped by Eric Seidel.
1466
1467         This is part of a series of patches to remove layout_package.
1468
1469         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1470         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
1471         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
1472         * Scripts/webkitpy/tool/commands/rebaseline.py:
1473
1474 2011-11-17  Adam Barth  <abarth@webkit.org>
1475
1476         svn-apply shouldn't magically move files into Source anymore
1477         https://bugs.webkit.org/show_bug.cgi?id=72579
1478
1479         Reviewed by Eric Seidel.
1480
1481         The Source directory has existed for long enough that we don't need
1482         svn-apply to magically re-write old-style patches anymore.
1483
1484         * Scripts/VCSUtils.pm:
1485         (parseGitDiffHeader):
1486         (parseSvnDiffHeader):
1487
1488 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1489
1490         Add a list of contribution areas
1491         https://bugs.webkit.org/show_bug.cgi?id=72566
1492
1493         Reviewed by Eric Seidel.
1494
1495         Added ContributionAreas class.
1496
1497         * Scripts/webkitpy/common/config/contributionareas.py: Added.
1498         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
1499
1500 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1501
1502         Refactor ChangeLogTest.test_parse_reviewer_text
1503         https://bugs.webkit.org/show_bug.cgi?id=72572
1504
1505         Reviewed by Eric Seidel.
1506
1507         Refactored the test code by introduing two helper functions.
1508
1509         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1510
1511 2011-11-16  Eric Seidel  <eric@webkit.org>
1512
1513         Add SCMDetector object to make scm detection mockable
1514         https://bugs.webkit.org/show_bug.cgi?id=72247
1515
1516         Reviewed by Adam Barth.
1517
1518         I think SCM detection may eventually be rolled into Checkout,
1519         but this patch at least makes it possible to mock code-paths
1520         which rely on scm detection.
1521         In the process of replacing callers of these free-functions
1522         I found that one of the functions was no longer used,
1523         and that one of the callers could instead just use the SCM
1524         object it already had access to through port.host.scm().
1525         I also discovered that I was not calling Host._initialize_scm()
1526         and thus host.scm() was always returning None!
1527
1528         * Scripts/check-webkit-style:
1529         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1530         * Scripts/webkitpy/common/checkout/deps.py:
1531         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1532         * Scripts/webkitpy/common/checkout/scm/detection.py:
1533         * Scripts/webkitpy/common/checkout/scm/git.py:
1534         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1535         * Scripts/webkitpy/common/checkout/scm/svn.py:
1536         * Scripts/webkitpy/common/host.py:
1537         * Scripts/webkitpy/common/host_mock.py:
1538         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1539         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1540         * Scripts/webkitpy/layout_tests/port/base.py:
1541         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1542         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1543         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1544         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1545
1546 2011-11-16  Mark Rowe  <mrowe@apple.com>
1547
1548         Fix the build.
1549
1550         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
1551         Apply the workaround that we use in other projects to WebKitTestRunner.
1552
1553         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
1554         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1555         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
1556
1557 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1558
1559         [Qt] Fix build after WTR AX support
1560         https://bugs.webkit.org/show_bug.cgi?id=72560
1561
1562         Reviewed by Geoffrey Garen.
1563
1564         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1565         * WebKitTestRunner/InjectedBundle/Target.pri:
1566
1567 2011-11-16  Tony Chang  <tony@chromium.org>
1568
1569         repurpose the flexbox bot for grid layout
1570         https://bugs.webkit.org/show_bug.cgi?id=72557
1571
1572         Reviewed by Ryosuke Niwa.
1573
1574         Since new flexbox is enabled everywhere, we don't need this bot
1575         anymore.  However, work on grid layout has begun, so we can use this
1576         bot to compile with ENABLE_CSS_GRID_LAYOUT.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
1579         the bot on the waterfall, I will change the slave config to enable
1580         the compile flag and tests.
1581
1582 2011-11-11  Adrienne Walker  <enne@google.com>
1583
1584         [chromium] Expose mock scrollbars to window.internals
1585         https://bugs.webkit.org/show_bug.cgi?id=72195
1586
1587         Reviewed by James Robinson.
1588
1589         Because mock scrollbars are a global setting, reset between runs.
1590
1591         * DumpRenderTree/chromium/WebPreferences.cpp:
1592         (WebPreferences::applyTo):
1593
1594 2011-11-16  James Robinson  <jamesr@chromium.org>
1595
1596         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
1597         https://bugs.webkit.org/show_bug.cgi?id=72562
1598
1599         Reviewed by Dirk Pranke.
1600
1601         * DumpRenderTree/chromium/TestShell.cpp:
1602         (TestShell::runFileTest):
1603
1604 2011-11-16  Tony Chang  <tony@chromium.org>
1605
1606         [NRWT] speculative fix for multiple subprocess test on cygwin
1607         https://bugs.webkit.org/show_bug.cgi?id=72518
1608
1609         Reviewed by Adam Barth.
1610
1611         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
1612             tries to emulate posix fd behavior.
1613         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1614
1615 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1616
1617         Revert r100509; change was committed twice (first time as r100491).
1618         Unreviewed, build fix.
1619
1620         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1621
1622 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1623
1624         Run a dummy test in the gpu configurations if there's nothing to do.
1625         https://bugs.webkit.org/show_bug.cgi?id=72498
1626
1627         Reviewed by James Robinson.
1628
1629         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1630
1631 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1632
1633         contributors_by_fuzzy_match is super slow
1634         https://bugs.webkit.org/show_bug.cgi?id=72540
1635
1636         Reviewed by Eric Seidel.
1637
1638         Make contributors_by_name do case insensitive search using a dictionary.
1639
1640         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
1641         because that's the most common case.
1642
1643         * Scripts/webkitpy/common/config/committers.py:
1644         * Scripts/webkitpy/common/config/committers_unittest.py:
1645
1646 2011-11-16  David Levin  <levin@chromium.org>
1647
1648         check-webkit-style should recognize functions even if they have OVERRIDE after them.
1649         https://bugs.webkit.org/show_bug.cgi?id=72515
1650
1651         Reviewed by Adam Barth.
1652
1653         * Scripts/webkitpy/style/checkers/cpp.py:
1654         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1655
1656 2011-11-16  Tony Chang  <tony@chromium.org>
1657
1658         [NRWT] refactor drivers to require pixel_tests param
1659         https://bugs.webkit.org/show_bug.cgi?id=72517
1660
1661         Reviewed by Ojan Vafai.
1662
1663         No tests, just a refactoring.
1664
1665         * Scripts/webkitpy/layout_tests/port/chromium.py:
1666         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1667         * Scripts/webkitpy/layout_tests/port/webkit.py:
1668         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1669
1670 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1671
1672         Run a dummy test in the gpu configurations if there's nothing to do.
1673         https://bugs.webkit.org/show_bug.cgi?id=72498
1674
1675         Reviewed by James Robinson.
1676
1677         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1678
1679 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
1680
1681         WebKitTestRunner needs to support accessibility-related DRT APIs
1682         https://bugs.webkit.org/show_bug.cgi?id=42131
1683
1684         Reviewed by Beth Dakin.
1685
1686         Port the AX code in DRT to WKTestRunner by using IDL.
1687
1688         * DumpRenderTree/AccessibilityUIElement.cpp:
1689         (horizontalScrollbarCallback):
1690         (verticalScrollbarCallback):
1691         (AccessibilityUIElement::horizontalScrollbar):
1692         (AccessibilityUIElement::verticalScrollbar):
1693         (AccessibilityUIElement::getJSClass):
1694         * DumpRenderTree/AccessibilityUIElement.h:
1695         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1696         (AccessibilityUIElement::horizontalScrollbar):
1697         (AccessibilityUIElement::verticalScrollbar):
1698         * WebKitTestRunner/DerivedSources.make:
1699         * WebKitTestRunner/GNUmakefile.am:
1700         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
1701         (WTR::AccessibilityController::create):
1702         (WTR::AccessibilityController::AccessibilityController):
1703         (WTR::AccessibilityController::~AccessibilityController):
1704         (WTR::AccessibilityController::makeWindowObject):
1705         (WTR::AccessibilityController::wrapperClass):
1706         (WTR::AccessibilityController::rootElement):
1707         (WTR::AccessibilityController::focusedElement):
1708         (WTR::AccessibilityController::elementAtPoint):
1709         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
1710         (WTR::AccessibilityController::logFocusEvents):
1711         (WTR::AccessibilityController::logValueChangeEvents):
1712         (WTR::AccessibilityController::logScrollingStartEvents):
1713         (WTR::AccessibilityController::logAccessibilityEvents):
1714         (WTR::AccessibilityController::addNotificationListener):
1715         (WTR::AccessibilityController::notificationReceived):
1716         (WTR::AccessibilityController::resetToConsistentState):
1717         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
1718         (WTR::AccessibilityTextMarker::create):
1719         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1720         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
1721         (WTR::AccessibilityTextMarker::platformTextMarker):
1722         (WTR::AccessibilityTextMarker::wrapperClass):
1723         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
1724         (WTR::AccessibilityTextMarker::isEqual):
1725         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
1726         (WTR::AccessibilityTextMarkerRange::create):
1727         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1728         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1729         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
1730         (WTR::AccessibilityTextMarkerRange::wrapperClass):
1731         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
1732         (WTR::AccessibilityTextMarkerRange::isEqual):
1733         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
1734         (WTR::AccessibilityUIElement::create):
1735         (WTR::AccessibilityUIElement::wrapperClass):
1736         (WTR::AccessibilityUIElement::isValid):
1737         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1738         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1739         (WTR::AccessibilityUIElement::isEqual):
1740         (WTR::AccessibilityUIElement::elementAtPoint):
1741         (WTR::AccessibilityUIElement::childAtIndex):
1742         (WTR::AccessibilityUIElement::indexOfChild):
1743         (WTR::AccessibilityUIElement::childrenCount):
1744         (WTR::AccessibilityUIElement::titleUIElement):
1745         (WTR::AccessibilityUIElement::parentElement):
1746         (WTR::AccessibilityUIElement::takeFocus):
1747         (WTR::AccessibilityUIElement::takeSelection):
1748         (WTR::AccessibilityUIElement::addSelection):
1749         (WTR::AccessibilityUIElement::removeSelection):
1750         (WTR::AccessibilityUIElement::allAttributes):
1751         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1752         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1753         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1754         (WTR::AccessibilityUIElement::attributesOfChildren):
1755         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1756         (WTR::AccessibilityUIElement::increment):
1757         (WTR::AccessibilityUIElement::decrement):
1758         (WTR::AccessibilityUIElement::showMenu):
1759         (WTR::AccessibilityUIElement::press):
1760         (WTR::AccessibilityUIElement::stringAttributeValue):
1761         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1762         (WTR::AccessibilityUIElement::numberAttributeValue):
1763         (WTR::AccessibilityUIElement::boolAttributeValue):
1764         (WTR::AccessibilityUIElement::isAttributeSupported):
1765         (WTR::AccessibilityUIElement::isAttributeSettable):
1766         (WTR::AccessibilityUIElement::isActionSupported):
1767         (WTR::AccessibilityUIElement::role):
1768         (WTR::AccessibilityUIElement::subrole):
1769         (WTR::AccessibilityUIElement::roleDescription):
1770         (WTR::AccessibilityUIElement::title):
1771         (WTR::AccessibilityUIElement::description):
1772         (WTR::AccessibilityUIElement::language):
1773         (WTR::AccessibilityUIElement::stringValue):
1774         (WTR::AccessibilityUIElement::accessibilityValue):
1775         (WTR::AccessibilityUIElement::helpText):
1776         (WTR::AccessibilityUIElement::orientation):
1777         (WTR::AccessibilityUIElement::x):
1778         (WTR::AccessibilityUIElement::y):
1779         (WTR::AccessibilityUIElement::width):
1780         (WTR::AccessibilityUIElement::height):
1781         (WTR::AccessibilityUIElement::intValue):
1782         (WTR::AccessibilityUIElement::minValue):
1783         (WTR::AccessibilityUIElement::maxValue):
1784         (WTR::AccessibilityUIElement::valueDescription):
1785         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1786         (WTR::AccessibilityUIElement::selectedTextRange):
1787         (WTR::AccessibilityUIElement::isEnabled):
1788         (WTR::AccessibilityUIElement::isRequired):
1789         (WTR::AccessibilityUIElement::isFocused):
1790         (WTR::AccessibilityUIElement::isFocusable):
1791         (WTR::AccessibilityUIElement::isSelected):
1792         (WTR::AccessibilityUIElement::isSelectable):
1793         (WTR::AccessibilityUIElement::isMultiSelectable):
1794         (WTR::AccessibilityUIElement::setSelectedChild):
1795         (WTR::AccessibilityUIElement::selectedChildrenCount):
1796         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1797         (WTR::AccessibilityUIElement::isExpanded):
1798         (WTR::AccessibilityUIElement::isChecked):
1799         (WTR::AccessibilityUIElement::isVisible):
1800         (WTR::AccessibilityUIElement::isOffScreen):
1801         (WTR::AccessibilityUIElement::isCollapsed):
1802         (WTR::AccessibilityUIElement::isIgnored):
1803         (WTR::AccessibilityUIElement::hasPopup):
1804         (WTR::AccessibilityUIElement::hierarchicalLevel):
1805         (WTR::AccessibilityUIElement::clickPointX):
1806         (WTR::AccessibilityUIElement::clickPointY):
1807         (WTR::AccessibilityUIElement::documentEncoding):
1808         (WTR::AccessibilityUIElement::documentURI):
1809         (WTR::AccessibilityUIElement::url):
1810         (WTR::AccessibilityUIElement::speak):
1811         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1812         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1813         (WTR::AccessibilityUIElement::attributesOfColumns):
1814         (WTR::AccessibilityUIElement::attributesOfRows):
1815         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1816         (WTR::AccessibilityUIElement::attributesOfHeader):
1817         (WTR::AccessibilityUIElement::indexInTable):
1818         (WTR::AccessibilityUIElement::rowIndexRange):
1819         (WTR::AccessibilityUIElement::columnIndexRange):
1820         (WTR::AccessibilityUIElement::rowCount):
1821         (WTR::AccessibilityUIElement::columnCount):
1822         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1823         (WTR::AccessibilityUIElement::disclosedByRow):
1824         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1825         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1826         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1827         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1828         (WTR::AccessibilityUIElement::ariaDropEffects):
1829         (WTR::AccessibilityUIElement::lineForIndex):
1830         (WTR::AccessibilityUIElement::rangeForLine):
1831         (WTR::AccessibilityUIElement::boundsForRange):
1832         (WTR::AccessibilityUIElement::setSelectedTextRange):
1833         (WTR::AccessibilityUIElement::stringForRange):
1834         (WTR::AccessibilityUIElement::attributedStringForRange):
1835         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1836         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1837         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1838         (WTR::AccessibilityUIElement::horizontalScrollbar):
1839         (WTR::AccessibilityUIElement::verticalScrollbar):
1840         (WTR::AccessibilityUIElement::addNotificationListener):
1841         (WTR::AccessibilityUIElement::removeNotificationListener):
1842         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1843         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1844         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1845         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1846         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1847         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1848         (WTR::AccessibilityUIElement::textMarkerForPoint):
1849         (WTR::AccessibilityUIElement::previousTextMarker):
1850         (WTR::AccessibilityUIElement::nextTextMarker):
1851         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1852         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
1853         (WTR::AccessibilityUIElement::platformUIElement):
1854         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
1855         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
1856         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
1857         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
1858         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1859         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1860         (WTR::InjectedBundle::beginTesting):
1861         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1862         (WTR::InjectedBundle::accessibilityController):
1863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1864         (WTR::InjectedBundlePage::didClearWindowForFrame):
1865         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1866         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
1867         (WTR::LayoutTestController::platformName):
1868         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
1869         (WTR::AccessibilityTextMarker::isEqual):
1870         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
1871         (WTR::AccessibilityTextMarkerRange::isEqual):
1872         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
1873         (+[NSString stringWithJSStringRef:]):
1874         (-[NSString createJSStringRef]):
1875         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1876         (-[AccessibilityNotificationHandler dealloc]):
1877         (-[AccessibilityNotificationHandler _notificationReceived:]):
1878         (-[AccessibilityNotificationHandler setCallback:]):
1879         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1880         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1881         (WTR::AccessibilityUIElement::isEqual):
1882         (WTR::descriptionOfValue):
1883         (WTR::attributesOfElement):
1884         (WTR::concatenateAttributeAndValue):
1885         (WTR::convertNSArrayToVector):
1886         (WTR::descriptionOfElements):
1887         (WTR::AccessibilityUIElement::getLinkedUIElements):
1888         (WTR::AccessibilityUIElement::getDocumentLinks):
1889         (WTR::AccessibilityUIElement::getChildren):
1890         (WTR::AccessibilityUIElement::getChildrenWithRange):
1891         (WTR::AccessibilityUIElement::childrenCount):
1892         (WTR::AccessibilityUIElement::elementAtPoint):
1893         (WTR::AccessibilityUIElement::indexOfChild):
1894         (WTR::AccessibilityUIElement::childAtIndex):
1895         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1896         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1897         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1898         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1899         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1900         (WTR::AccessibilityUIElement::selectedChildrenCount):
1901         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1902         (WTR::AccessibilityUIElement::titleUIElement):
1903         (WTR::AccessibilityUIElement::parentElement):
1904         (WTR::AccessibilityUIElement::disclosedByRow):
1905         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1906         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1907         (WTR::AccessibilityUIElement::attributesOfChildren):
1908         (WTR::AccessibilityUIElement::allAttributes):
1909         (WTR::AccessibilityUIElement::stringAttributeValue):
1910         (WTR::AccessibilityUIElement::numberAttributeValue):
1911         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1912         (WTR::AccessibilityUIElement::boolAttributeValue):
1913         (WTR::AccessibilityUIElement::isAttributeSettable):
1914         (WTR::AccessibilityUIElement::isAttributeSupported):
1915         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1916         (WTR::AccessibilityUIElement::role):
1917         (WTR::AccessibilityUIElement::subrole):
1918         (WTR::AccessibilityUIElement::roleDescription):
1919         (WTR::AccessibilityUIElement::title):
1920         (WTR::AccessibilityUIElement::description):
1921         (WTR::AccessibilityUIElement::orientation):
1922         (WTR::AccessibilityUIElement::stringValue):
1923         (WTR::AccessibilityUIElement::language):
1924         (WTR::AccessibilityUIElement::helpText):
1925         (WTR::AccessibilityUIElement::x):
1926         (WTR::AccessibilityUIElement::y):
1927         (WTR::AccessibilityUIElement::width):
1928         (WTR::AccessibilityUIElement::height):
1929         (WTR::AccessibilityUIElement::clickPointX):
1930         (WTR::AccessibilityUIElement::clickPointY):
1931         (WTR::AccessibilityUIElement::intValue):
1932         (WTR::AccessibilityUIElement::minValue):
1933         (WTR::AccessibilityUIElement::maxValue):
1934         (WTR::AccessibilityUIElement::valueDescription):
1935         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1936         (WTR::AccessibilityUIElement::isActionSupported):
1937         (WTR::AccessibilityUIElement::isEnabled):
1938         (WTR::AccessibilityUIElement::isRequired):
1939         (WTR::AccessibilityUIElement::isFocused):
1940         (WTR::AccessibilityUIElement::isSelected):
1941         (WTR::AccessibilityUIElement::isExpanded):
1942         (WTR::AccessibilityUIElement::isChecked):
1943         (WTR::AccessibilityUIElement::hierarchicalLevel):
1944         (WTR::AccessibilityUIElement::speak):
1945         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1946         (WTR::AccessibilityUIElement::ariaDropEffects):
1947         (WTR::AccessibilityUIElement::lineForIndex):
1948         (WTR::AccessibilityUIElement::rangeForLine):
1949         (WTR::AccessibilityUIElement::boundsForRange):
1950         (WTR::AccessibilityUIElement::stringForRange):
1951         (WTR::AccessibilityUIElement::attributedStringForRange):
1952         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1953         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1954         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1955         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1956         (WTR::AccessibilityUIElement::attributesOfColumns):
1957         (WTR::AccessibilityUIElement::attributesOfRows):
1958         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1959         (WTR::AccessibilityUIElement::attributesOfHeader):
1960         (WTR::AccessibilityUIElement::rowCount):
1961         (WTR::AccessibilityUIElement::columnCount):
1962         (WTR::AccessibilityUIElement::indexInTable):
1963         (WTR::AccessibilityUIElement::rowIndexRange):
1964         (WTR::AccessibilityUIElement::columnIndexRange):
1965         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1966         (WTR::AccessibilityUIElement::horizontalScrollbar):
1967         (WTR::AccessibilityUIElement::verticalScrollbar):
1968         (WTR::AccessibilityUIElement::selectedTextRange):
1969         (WTR::AccessibilityUIElement::setSelectedTextRange):
1970         (WTR::AccessibilityUIElement::increment):
1971         (WTR::AccessibilityUIElement::decrement):
1972         (WTR::AccessibilityUIElement::showMenu):
1973         (WTR::AccessibilityUIElement::press):
1974         (WTR::AccessibilityUIElement::setSelectedChild):
1975         (WTR::AccessibilityUIElement::accessibilityValue):
1976         (WTR::AccessibilityUIElement::documentEncoding):
1977         (WTR::AccessibilityUIElement::documentURI):
1978         (WTR::AccessibilityUIElement::url):
1979         (WTR::AccessibilityUIElement::addNotificationListener):
1980         (WTR::AccessibilityUIElement::removeNotificationListener):
1981         (WTR::AccessibilityUIElement::isFocusable):
1982         (WTR::AccessibilityUIElement::isSelectable):
1983         (WTR::AccessibilityUIElement::isMultiSelectable):
1984         (WTR::AccessibilityUIElement::isVisible):
1985         (WTR::AccessibilityUIElement::isOffScreen):
1986         (WTR::AccessibilityUIElement::isCollapsed):
1987         (WTR::AccessibilityUIElement::isIgnored):
1988         (WTR::AccessibilityUIElement::hasPopup):
1989         (WTR::AccessibilityUIElement::takeFocus):
1990         (WTR::AccessibilityUIElement::takeSelection):
1991         (WTR::AccessibilityUIElement::addSelection):
1992         (WTR::AccessibilityUIElement::removeSelection):
1993         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1994         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1995         (WTR::AccessibilityUIElement::previousTextMarker):
1996         (WTR::AccessibilityUIElement::nextTextMarker):
1997         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1998         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1999         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2000         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2001         (WTR::AccessibilityUIElement::textMarkerForPoint):
2002         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2003         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2004         (WTR::LayoutTestController::platformName):
2005         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2006         (WTR::LayoutTestController::platformName):
2007         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2008         (WTR::LayoutTestController::platformName):
2009         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010         * WebKitTestRunner/win/InjectedBundle.vcproj:
2011
2012 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2013
2014         [Qt] Fix use of config.tests
2015
2016         We were checking @buildArgs to determine if the optional argument was
2017         passed or not, but this is not the right way to do that in Perl. The
2018         right way is to not use a prototype for the function, and to pass
2019         the list as a reference (to avoid list expansion). That way we can
2020         check the number of arguments, and choose the right code path based
2021         on that.
2022
2023         We were also missing a default-value of 0 for any feature that's not
2024         set in features.prf.
2025
2026         Reviewed by Kenneth Rohde Christiansen.
2027
2028         * Scripts/build-webkit:
2029         * Scripts/webkitdirs.pm:
2030         (qtFeatureDefaults):
2031         (buildQMakeProject):
2032
2033 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2034
2035         [Qt] Prospective fix for broken plugin tests
2036
2037         Don't hide symbols for the NPAPI test plugin
2038
2039         Rubber-stamped by Andreas Kling.
2040
2041         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2042
2043 2011-11-16  Adam Roben  <aroben@apple.com>
2044
2045         Move filenames/line numbers off to the right edge in Leaks Viewer
2046
2047         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
2048         because filenames/line numbers are right next to function names
2049
2050         Reviewed by Andreas Kling.
2051
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
2053         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
2054         function name. Use the filename as the profile node's URL (we don't have enough info to
2055         compute a real URL currently) and the line number as the profile node's line number so the
2056         Inspector code will put them on the right side of the callstack graph.
2057
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2059         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
2060         passed here, just filenames.
2061
2062         (WebInspector.linkifyURLAsNode):
2063         (WebInspector.linkifyResourceAsNode):
2064         Copied and slightly modified from inspector.js.
2065
2066 2011-11-16  Adam Roben  <aroben@apple.com>
2067
2068         Make Leaks Viewer load builds from the new Lion Leaks bot
2069
2070         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
2071
2072         Reviewed by Andreas Kling.
2073
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2075         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
2076         SnowLeopard one.
2077
2078 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
2079
2080         [EFL] Clean up the offline apps-related functions in ewk_settings.
2081         https://bugs.webkit.org/show_bug.cgi?id=72132
2082
2083         Reviewed by Kenneth Rohde Christiansen.
2084
2085         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
2086         prefixes for code that is related only to the HTML5 app cache
2087         features.
2088
2089         Use `ewk_settings_application_cache' and
2090         `ewk_view_setting_application_cache' instead.
2091
2092         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2093         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2094
2095 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2096
2097         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2098
2099         Reviewed by Tor Arne Vestbø.
2100
2101         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2102         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
2103         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
2104         removes the .so.0.0.0 and just produces .so.
2105
2106 2011-11-16  Peter Beverloo  <peter@chromium.org>
2107
2108         Explicitly include unistd.h in TestNetscapePlugIn
2109         https://bugs.webkit.org/show_bug.cgi?id=72385
2110
2111         This is needed for the sleep() call in the indicateTestFailure method,
2112         which seems to be implicitly available for other platforms. This is not
2113         the case on Android.
2114
2115         Reviewed by Steve Block.
2116
2117         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2118
2119 2011-11-16  Peter Beverloo  <peter@chromium.org>
2120
2121         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
2122         https://bugs.webkit.org/show_bug.cgi?id=72384
2123
2124         Update to Android NDK r7, which was released last Friday. This adds
2125         support for RTTI and the -mimplicit-it gcc flag, which are required to
2126         respectively build ICU and Skia.
2127
2128         Reviewed by Steve Block.
2129
2130         * Scripts/update-webkit-chromium:
2131         * Scripts/webkitdirs.pm:
2132         (buildChromiumMakefile):
2133
2134 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2135
2136         Unreviewed, rolling out r100266.
2137         http://trac.webkit.org/changeset/100266
2138
2139         Broke WTR.
2140
2141         * qmake/mkspecs/features/default_post.prf:
2142
2143 2011-11-16  Eric Seidel  <eric@webkit.org>
2144
2145         check-webkit-style broken by r99773: "Could not determine the port"
2146         https://bugs.webkit.org/show_bug.cgi?id=72275
2147
2148         Reviewed by Adam Barth.
2149
2150         I will continue engaging hacks, until windows improves.
2151
2152         * Scripts/webkitpy/common/host.py:
2153          - Host uses self.executive instead of self._executive like Port does.
2154          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
2155
2156 2011-11-16  Eric Seidel  <eric@webkit.org>
2157
2158         check-webkit-style broken by r99773: "Could not determine the port"
2159         https://bugs.webkit.org/show_bug.cgi?id=72275
2160
2161         Reviewed by Adam Barth.
2162
2163         Engage windows hacks harder.
2164
2165         This is a speculative fix for ChromiumWin.  We're now
2166         creating an SCM object much earlier, so we need to
2167         engage our "awesome" windows hacks earlier.
2168
2169         * Scripts/webkitpy/common/host.py:
2170         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2171
2172 2011-11-15  Darin Adler  <darin@apple.com>
2173
2174         DRT's uiElementAttributeValueCallback function is leaky
2175         https://bugs.webkit.org/show_bug.cgi?id=72453
2176
2177         Reviewed by Dan Bernstein.
2178
2179         * DumpRenderTree/AccessibilityUIElement.cpp:
2180         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
2181
2182 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2183
2184         Implement edit-distance based reviewer recognition algorithm
2185         https://bugs.webkit.org/show_bug.cgi?id=72351
2186
2187         Reviewed by Eric Seidel.
2188
2189         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
2190         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
2191         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
2192         "build fix" to a reviewer's name (e.g. with with edit distance 9).
2193
2194         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
2195         the edit distance is implemented in edit_distance.py.
2196
2197         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
2198         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
2199
2200         * Scripts/webkitpy/common/checkout/changelog.py:
2201         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2202         * Scripts/webkitpy/common/config/committers.py:
2203         * Scripts/webkitpy/common/config/committers_unittest.py:
2204         * Scripts/webkitpy/common/editdistance.py: Added.
2205         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
2206         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2207         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
2208
2209 2011-11-15  Tony Chang  <tony@chromium.org>
2210
2211         Skip a failing webkitpy test on cygwin.
2212
2213         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2214
2215 2011-11-15  Sam Weinig  <sam@webkit.org>
2216
2217         TestWebKitAPI should not put its resources in the root products directory
2218         https://bugs.webkit.org/show_bug.cgi?id=72446
2219
2220         Reviewed by Anders Carlsson.
2221
2222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2223         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
2224         directory.
2225
2226         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2227         (TEST_F):
2228         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2229         (TestWebKitAPI::TEST):
2230         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2231         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2232         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2233         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
2234         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2235         (TestWebKitAPI::Util::createURLForResource):
2236         Update calls to retrieve files from the bundle to look in the newly
2237         created subdirectory.
2238
2239 2011-11-15  Tony Chang  <tony@chromium.org>
2240
2241         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
2242
2243         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2244
2245 2011-11-15  Tony Chang  <tony@chromium.org>
2246
2247         Unreviewed, fix test-webkitpy tests.  Move the check for image results
2248         earlier.
2249
2250         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2251         * Scripts/webkitpy/layout_tests/port/webkit.py:
2252
2253 2011-11-15  James Robinson  <jamesr@chromium.org>
2254
2255         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
2256         https://bugs.webkit.org/show_bug.cgi?id=72444
2257
2258         Reviewed by Adam Barth.
2259
2260         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2261
2262 2011-11-15  Tony Chang  <tony@chromium.org>
2263
2264         Unreviewed, better fix for ref tests failures on SL Intel bot.
2265         Revert the previous change and return None if pixel results from
2266         either the test page or the expected page is missing.
2267
2268         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2269         * Scripts/webkitpy/layout_tests/port/webkit.py:
2270
2271 2011-11-15  James Robinson  <jamesr@chromium.org>
2272
2273         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
2274         https://bugs.webkit.org/show_bug.cgi?id=72402
2275
2276         Reviewed by Dirk Pranke.
2277
2278         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
2279         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
2280         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
2281         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
2282         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
2283         compositing enabled.
2284
2285         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
2286         patch should not impact any tests.
2287
2288         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2289         (main):
2290         * DumpRenderTree/chromium/TestShell.cpp:
2291         (TestShell::TestShell):
2292         (TestShell::resetWebSettings):
2293         * DumpRenderTree/chromium/TestShell.h:
2294         (TestShell::setAcceleratedCompositingForVideoEnabled):
2295         * DumpRenderTree/chromium/WebPreferences.cpp:
2296         (WebPreferences::reset):
2297         (WebPreferences::applyTo):
2298         * DumpRenderTree/chromium/WebPreferences.h:
2299         * Scripts/webkitpy/layout_tests/port/chromium.py:
2300         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2301         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2302
2303 2011-11-15  Tony Chang  <tony@chromium.org>
2304
2305         Unreviewed, try to fix ref tests failures on SL Intel bot.
2306         It looks like ImageDiff isn't returning an image diff.
2307
2308         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2309
2310 2011-11-15  Tony Chang  <tony@chromium.org>
2311
2312         Unreviewed fix of ref-tests on GTK+.
2313         If a driver is never started, _xvfb_process is never set.
2314
2315         * Scripts/webkitpy/layout_tests/port/gtk.py:
2316
2317 2011-11-14  Tony Chang  <tony@chromium.org>
2318
2319         [NRWT] Reftests should run even when pixel tests are disabled.
2320         https://bugs.webkit.org/show_bug.cgi?id=60605
2321
2322         Reviewed by Dirk Pranke.
2323
2324         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
2325             Also add an assert to make sure we get image hashes back when running ref tests.
2326         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
2327         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2328         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
2329         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
2330             of starting a pixel driver if needed.  It handles the logic of sending the test
2331             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
2332         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2333         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
2334         * Scripts/webkitpy/layout_tests/port/webkit.py:
2335         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
2336         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
2337
2338 2011-11-15  David Kilzer  <ddkilzer@apple.com>
2339
2340         Don't use File::Slurp for run-leaks unit tests
2341         <http://webkit.org/b/72356>
2342
2343         Reviewed by Daniel Bates.
2344
2345         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
2346         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2347         Extracted common package logic into RunLeaks.pm.  Fixed call to
2348         RunLeaks::parseLeaksOutput().
2349         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
2350         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
2351
2352 2011-11-15  Peter Kasting  <pkasting@google.com>
2353
2354         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
2355         https://bugs.webkit.org/show_bug.cgi?id=72349
2356
2357         Reviewed by Adam Roben.
2358
2359         * Scripts/VCSUtils.pm:
2360         (isSVNDirectory):
2361
2362 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2363
2364         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2365
2366         Reviewed by Tor Arne Vestbø.
2367
2368         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2369         magic here where we handle all TEMPLATE = lib .pro files.
2370
2371 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2372
2373         [Qt] Unreviewed prospective --minimal build fix.
2374
2375         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
2376         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
2377
2378 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2379
2380         [Qt] Unreviewed --minimal build fix.
2381
2382         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
2383         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
2384         to make moc's preprocessor abort.
2385
2386 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2387
2388         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
2389         https://bugs.webkit.org/show_bug.cgi?id=72156
2390
2391         Reviewed by Daniel Bates.
2392
2393         Similar to --makearg and --qmakearg, --cmakearg lets one pass
2394         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
2395
2396         * Scripts/build-webkit:
2397         * Scripts/webkitdirs.pm:
2398         (generateBuildSystemFromCMakeProject):
2399
2400 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2401
2402         Improve ChangeLogEntry's reviewer parsing algorithm part 2
2403         https://bugs.webkit.org/show_bug.cgi?id=72340
2404
2405         Reviewed by Eric Seidel.
2406
2407         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
2408         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
2409
2410         * Scripts/webkitpy/common/checkout/changelog.py:
2411         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2412
2413 2011-11-14  Eric Seidel  <eric@webkit.org>
2414
2415         check-webkit-style broken by r99773: "Could not determine the port"
2416         https://bugs.webkit.org/show_bug.cgi?id=72275
2417
2418         Reviewed by Adam Barth.
2419
2420         The TestExpectationsChecker was using a generic try/except block
2421         which caught all exceptions, so we didn't notice that failing
2422         to pass a Host to PortFactory was causing an exception in port instantiation.
2423         I've factored out the "lookup the port" logic into a separate function
2424         which I've now unittested.  This should fix the bug and prevent
2425         others like it from occuring the the future.
2426
2427         * Scripts/webkitpy/style/checkers/test_expectations.py:
2428         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2429
2430 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2431
2432         Add --css-grid-layout to build-webkit and the build systems
2433         https://bugs.webkit.org/show_bug.cgi?id=72320
2434
2435         Reviewed by Ojan Vafai.
2436
2437         * Scripts/build-webkit:
2438         Added the option.
2439
2440 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2441
2442         Unreviewed, rolling out r100192.
2443         http://trac.webkit.org/changeset/100192
2444         https://bugs.webkit.org/show_bug.cgi?id=72328
2445
2446         Caused infinite tests to fail (Requested by abarth on
2447         #webkit).
2448
2449         * Scripts/webkitpy/layout_tests/port/base.py:
2450         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2451
2452 2011-11-14  Tony Chang  <tony@chromium.org>
2453
2454         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
2455         https://bugs.webkit.org/show_bug.cgi?id=72196
2456
2457         Reviewed by Ojan Vafai.
2458
2459         * Scripts/build-webkit:
2460
2461 2011-11-14  John Yani  <vanuan@gmail.com>
2462
2463         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
2464         Override LOCALE to en_US.
2465
2466         Reviewed by Eric Seidel.
2467
2468         * Scripts/webkitpy/layout_tests/port/base.py:
2469
2470 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2471
2472         [Chromium] build-webkit silently drops the features flags
2473         https://bugs.webkit.org/show_bug.cgi?id=72293
2474
2475         Reviewed by Tony Chang.
2476
2477         Chromium still ignores @features but now we give a warning!
2478
2479         * Scripts/build-webkit: Check if one of the features is different
2480         from the default and print a warning in this case.
2481
2482 2011-11-14  David Kilzer  <ddkilzer@apple.com>
2483
2484         run-leaks does not work on Lion?
2485         <http://webkit.org/b/71059>
2486         <rdar://problem/10428527>
2487
2488         Reviewed by Adam Roben.
2489
2490         The output of leaks(1) changed again in Lion to move the
2491         "leaks Report Version: 2.0" line from the first line of the
2492         output to just above the "Process " lines that run-leaks is
2493         interested in parsing.  This required using a more generic
2494         algorithm to find the start of the "Process " lines.
2495
2496         * Scripts/run-leaks:
2497         (parseLeaksOutput): Make the code to skip headers more generic.
2498         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
2499         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
2500         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
2501
2502 2011-11-14  Lei Zhang  <thestig@chromium.org>
2503
2504         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
2505         https://bugs.webkit.org/show_bug.cgi?id=72088
2506
2507         Reviewed by Tony Chang.
2508
2509         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2510
2511 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
2512
2513         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
2514         https://bugs.webkit.org/show_bug.cgi?id=72147
2515
2516         Reviewed by Adam Barth.
2517
2518         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2519
2520 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2521
2522         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
2523
2524         Reviewed by Simon Hausmann.
2525
2526         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
2527
2528 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2529
2530         [Qt] Disable plugins on X11 for WK2
2531
2532         Reviewed by Kenneth Rohde Christiansen.
2533
2534         Currently plugins are in-process and they crash in the likely case of
2535         a plugin installation that uses Qt 4, which beautifully clashes with the
2536         Qt 5 based QtWebProcess.
2537
2538         * qmake/mkspecs/features/features.prf:
2539
2540 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2541
2542         [Qt] Add support for config tests for Qt 5
2543
2544         This allows us to build and run configure-tests at build
2545         time to determine if a given platform feature is available.
2546
2547         Reviewed by Simon Hausmann.
2548
2549         * Scripts/build-webkit:
2550         * Scripts/webkitdirs.pm:
2551         (qtFeatureDefaults):
2552         * qmake/configure.pro: Added.
2553         * qmake/mkspecs/features/features.prf:
2554         * qmake/sync.profile: Added.
2555
2556 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2557
2558         [Qt] Remove the QStyle dependency in Qt's mobile theme
2559         https://bugs.webkit.org/show_bug.cgi?id=67773
2560
2561         This refactoring splits up RenderThemeQt with two
2562         subclasses, a QStyle-backed one, and a Mobile version
2563         that uses the old mobile theme for now.
2564
2565         QStyle availability is detected at compile time, and
2566         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2567         environment variable.
2568
2569         Reviewed by Simon Hausmann.
2570
2571         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2572         (WTR::activateFonts):
2573         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2574         based on availability of QtWidgets.
2575         * qmake/mkspecs/features/webcore.prf: cleanup.
2576
2577 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2578
2579         Unreviewed, rolling out r100116.
2580         http://trac.webkit.org/changeset/100116
2581
2582         r100104 was rolled out, so no longer needed
2583
2584         * Scripts/run-bindings-tests:
2585
2586 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2587
2588         Unreviewed, rolling out r100104.
2589         http://trac.webkit.org/changeset/100104
2590         https://bugs.webkit.org/show_bug.cgi?id=72247
2591
2592         broke windows builds
2593
2594         * Scripts/check-webkit-style:
2595         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2596         * Scripts/webkitpy/common/checkout/deps.py:
2597         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2598         * Scripts/webkitpy/common/checkout/scm/detection.py:
2599         * Scripts/webkitpy/common/checkout/scm/git.py:
2600         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2601         * Scripts/webkitpy/common/checkout/scm/svn.py:
2602         * Scripts/webkitpy/common/host.py:
2603         * Scripts/webkitpy/common/host_mock.py:
2604         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2605         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2606         * Scripts/webkitpy/layout_tests/port/base.py:
2607         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2609         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2610         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2611
2612 2011-11-14  Philippe Normand  <pnormand@igalia.com>
2613
2614         Unreviewed, build fix after r100104. run-binding-tests broke.
2615
2616         * Scripts/run-bindings-tests: Explicitely use scm.detection.
2617
2618 2011-11-13  Eric Seidel  <eric@webkit.org>
2619
2620         Add SCMDetector object to make scm detection mockable
2621         https://bugs.webkit.org/show_bug.cgi?id=72247
2622
2623         Reviewed by Adam Barth.
2624
2625         I think SCM detection may eventually be rolled into Checkout,
2626         but this patch at least makes it possible to mock code-paths
2627         which rely on scm detection.
2628         In the process of replacing callers of these free-functions
2629         I found that one of the functions was no longer used,
2630         and that one of the callers could instead just use the SCM
2631         object it already had access to through port.host.scm().
2632         I also discovered that I was not calling Host._initialize_scm()
2633         and thus host.scm() was always returning None!
2634
2635         * Scripts/check-webkit-style:
2636         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2637         * Scripts/webkitpy/common/checkout/deps.py:
2638         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2639         * Scripts/webkitpy/common/checkout/scm/detection.py:
2640         * Scripts/webkitpy/common/checkout/scm/git.py:
2641         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2642         * Scripts/webkitpy/common/checkout/scm/svn.py:
2643         * Scripts/webkitpy/common/host.py:
2644         * Scripts/webkitpy/common/host_mock.py:
2645         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2646         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2647         * Scripts/webkitpy/layout_tests/port/base.py:
2648         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2649         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2650         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2651         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2652
2653 2011-11-13  Gavin Peters  <gavinp@chromium.org>
2654
2655         command line control of webcore log channels in chromium DumpRenderTree
2656         https://bugs.webkit.org/show_bug.cgi?id=72126
2657         
2658         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
2659         what chromium takes.
2660
2661         Reviewed by Kent Tamura.
2662
2663         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2664         (main):
2665
2666 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
2667
2668         [Qt] Fix minor config typo in the build tool documentation
2669         https://bugs.webkit.org/show_bug.cgi?id=72194
2670
2671         Reviewed by Andreas Kling.
2672
2673         * qmake/README:
2674
2675 2011-11-11  Stephen Chenney  <schenney@chromium.org>
2676
2677         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
2678         https://bugs.webkit.org/show_bug.cgi?id=49257
2679
2680         Adds the remaining missing layout test functionality for printing.
2681
2682         Reviewed by Darin Fisher.
2683
2684         * DumpRenderTree/chromium/LayoutTestController.cpp:
2685         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
2686         (parsePageNumber): Method to parse JS arguments for a page number
2687         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
2688         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
2689         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
2690         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
2691         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
2692
2693 2011-11-11  Darin Adler  <darin@apple.com>
2694
2695         Remove all releaseRef implementations except for RetainPtr
2696         https://bugs.webkit.org/show_bug.cgi?id=71423
2697
2698         Reviewed by Julien Chaffraix.
2699
2700         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2701         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
2702
2703 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2704
2705         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
2706         https://bugs.webkit.org/show_bug.cgi?id=72090
2707
2708         Reviewed by Eric Seidel.
2709
2710         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
2711         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
2712
2713         yay! r100002.
2714
2715         * Scripts/webkitpy/common/checkout/changelog.py:
2716         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2717
2718 2011-11-11  Tony Chang  <tony@chromium.org>
2719
2720         Remove --force from gclient sync.  The bots seem to have made it past
2721         the update step.
2722
2723         * Scripts/update-webkit:
2724
2725 2011-11-11  Tony Chang  <tony@chromium.org>
2726
2727         Add --force to gclient sync. Once the cq bots cycle, we can remove
2728         this since it slows down the normal sync.
2729
2730         * Scripts/update-webkit:
2731
2732 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
2733
2734         When --force is used, also use --reset
2735         https://bugs.webkit.org/show_bug.cgi?id=72129
2736
2737         Reviewed by Dimitri Glazkov.
2738
2739         * Scripts/update-webkit-chromium:
2740
2741 2011-11-11  Tony Chang  <tony@chromium.org>
2742
2743         allow two chromium drivers to run at the same time in NRWT
2744         https://bugs.webkit.org/show_bug.cgi?id=72067
2745
2746         Reviewed by Dirk Pranke.
2747
2748         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
2749             posix prevents the subprocesses from sharing the same fd for stdin.
2750             Sharing the same fd prevents us from closing the files unless all references
2751             to the fd are closed.
2752         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
2753             to adding a test for this, speed up a test (from 3sec to 0) by fixing
2754             the timeout override. It looks like it regressed in r95875.
2755
2756 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2757
2758         Unreviewed, rolling out r99964.
2759         http://trac.webkit.org/changeset/99964
2760         https://bugs.webkit.org/show_bug.cgi?id=72124
2761
2762         Broke too many Qt tests (Requested by tronical_ on #webkit).
2763
2764         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2765         (WTR::activateFonts):
2766         * qmake/mkspecs/features/features.prf:
2767         * qmake/mkspecs/features/webcore.prf:
2768
2769 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2770
2771         [Qt] Remove the QStyle dependency in Qt's mobile theme
2772         https://bugs.webkit.org/show_bug.cgi?id=67773
2773
2774         This refactoring splits up RenderThemeQt with two
2775         subclasses, a QStyle-backed one, and a Mobile version
2776         that uses the old mobile theme for now.
2777
2778         QStyle availability is detected at compile time, and
2779         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2780         environment variable.
2781
2782         Reviewed by Simon Hausmann.
2783
2784         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2785         (WTR::activateFonts):
2786         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2787         based on availability of QtWidgets.
2788         * qmake/mkspecs/features/webcore.prf: cleanup.
2789
2790 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2791
2792         [Qt] Add missing include to PlatformWebViewQt
2793
2794         Reviewed by Simon Hausmann.
2795
2796         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2797
2798 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2799
2800         [Qt] Fix incremental builds on Windows after buildsystem refactor
2801
2802         The qmake rules to ensure that we run make on the derived sources
2803         before running qmake on the target were inside a unix-scope, which
2804         resulted in flakey builds on Windows.
2805
2806         We now generate a rule on all platforms that ensures that "make qmake"
2807         will always run make on the derived sources. In addition, on platforms
2808         that have GNU make (where "make incremental" does not run "make qmake",
2809         but only "make"), we add a similar rule that ensures that any time the
2810         target makefile is regenerated we first run qmake and make on the derived
2811         sources. This rule relies on GNU make's order-only-prerequisites to
2812         not trigger a qmake-run of the target every time we run make.
2813
2814         https://bugs.webkit.org/show_bug.cgi?id=71778
2815
2816         Reviewed by Simon Hausmann.
2817
2818         * qmake/mkspecs/features/functions.prf:
2819
2820 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2821
2822         [Qt][WK2] Remove QWebNavigationController
2823         https://bugs.webkit.org/show_bug.cgi?id=72113
2824
2825         Reviewed by Andreas Kling.
2826
2827         Adapt to the move of the QWebNavigationController functions/properties to
2828         QQuickWebView.
2829
2830         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2831         * MiniBrowser/qt/qml/BrowserWindow.qml:
2832
2833 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2834
2835         [Qt] Build system tweak
2836
2837         Reviewed by Tor Arne Vestbø.
2838
2839         Be a good qmake citizen, return true from our linkStaticLibrary
2840         "test" function.
2841
2842         * qmake/mkspecs/features/functions.prf:
2843
2844 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2845
2846         [Qt] Add support for QT += webkit-private
2847
2848         Reviewed by Tor Arne Vestbø.
2849
2850         * qmake/qt_webkit.pri: Declare private headers.
2851
2852 2011-11-11  Philippe Normand  <pnormand@igalia.com>
2853
2854         Unreviewed, build fix attempt after r99907. Since that revision
2855         GTK layout tests were not running at all...
2856
2857         * Scripts/webkitpy/layout_tests/port/gtk.py:
2858
2859 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
2860
2861         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
2862         https://bugs.webkit.org/show_bug.cgi?id=72001
2863
2864         Reviewed by Dirk Pranke.
2865
2866         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2867
2868 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
2869
2870         bencher script should support remote benchmarking
2871         https://bugs.webkit.org/show_bug.cgi?id=71618
2872
2873         Rubber-stamped by Geoff Garen.
2874         
2875         Added the following features:
2876         
2877         - Benchmark report tells you the hostname and machine model (according to
2878           'sysctl hw.model') of the machine you did the run on, and svn revision number
2879           (according to 'svn info') of the VMs you're testing.
2880         
2881         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2882           acceptable, in addition to just host, in which case your username is used)
2883           and it automatically packages the build directories of the VMs you're testing,
2884           sends them to the remote machine along with your copy of the bencher script
2885           and all of the options you passed.  This pretty much seamlessly allows you
2886           to run a set of benchmarks on any machine that is sufficiently compatible with
2887           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2888           must now include a tempPath setting that tells bencher where to put files
2889           when that machine is used as a slave in a remote benchmarking run.
2890           
2891         - Added yet another way of specifying which benchmarks to run. This was sort of
2892           necessary for --remote to work as expected. Previously, you either said what
2893           suites to exclude (for example --exclude-sunspider) or that you only wanted
2894           to run one suite to the exclusion of others (--sunspider-only). But it's
2895           often better to just be able to specify the list of suites you want. This is
2896           now supported. You can say, for example, --v8 --sunspider, which means, just
2897           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2898           still supported.
2899
2900         * Scripts/bencher:
2901
2902 2011-11-10  Tony Chang  <tony@chromium.org>
2903
2904         Lazily start DRT instances in NRWT
2905         https://bugs.webkit.org/show_bug.cgi?id=72038
2906
2907         Reviewed by Eric Seidel.
2908
2909         Just a refactoring, no new tests.
2910
2911         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2912         * Scripts/webkitpy/layout_tests/port/chromium.py:
2913         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2914         * Scripts/webkitpy/layout_tests/port/test.py:
2915         * Scripts/webkitpy/layout_tests/port/webkit.py:
2916
2917 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2918
2919         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2920         https://bugs.webkit.org/show_bug.cgi?id=72057
2921
2922         Reviewed by Eric Seidel.
2923
2924         Make the regular expression more explicit.
2925
2926         * Scripts/webkitpy/common/checkout/changelog.py:
2927         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2928
2929 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2930
2931         [Qt] X11 plugins need to be reworked for Qt5
2932         https://bugs.webkit.org/show_bug.cgi?id=70023
2933
2934         Reviewed by Simon Hausmann.
2935
2936         Rework our basic plugin support in a way that does
2937         not need a bridge between Qt and X. The solution is
2938         based on getting the content drawed by the plugin
2939         from the server as an image and creating a QImage
2940         from it.
2941
2942         * qmake/mkspecs/features/features.prf: Enable X11
2943         plugins if Qt is built with the xcb-xlib backend.
2944
2945 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2946
2947         [Qt] Fix keyboard related layout tests after API refactoring
2948
2949         Reviewed by Tor Arne Vestbø.
2950
2951         Send key events to the handling page item, not the view.
2952
2953         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2954         (WTR::PlatformWebView::sendEvent):
2955         (WTR::PlatformWebView::postEvent):
2956
2957 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2958
2959         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2960         https://bugs.webkit.org/show_bug.cgi?id=71940
2961
2962         Reviewed by Philippe Normand.
2963
2964         * GNUmakefile.am:
2965         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2966         ENABLE_* variables are part of the environment.
2967
2968 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2969
2970         [Qt] Fix focus related layout tests after API refactoring
2971
2972         Reviewed by Tor Arne Vestbø.
2973
2974         Make sure the focus is set on the page now, not on the view
2975         (which doesn't actually handle the focus).
2976
2977         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2978         (WTR::WrapperWindow::WrapperWindow):
2979         (WTR::WrapperWindow::handleStatusChanged):
2980
2981 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2982
2983         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2984         https://bugs.webkit.org/show_bug.cgi?id=71355
2985
2986         Reviewed by Kenneth Rohde Christiansen.
2987
2988         Make MiniBrowser and WebKitTestRunner work again after the
2989         merge.
2990
2991         * MiniBrowser/qt/BrowserWindow.cpp:
2992         (BrowserWindow::BrowserWindow):
2993         (BrowserWindow::webView):
2994         * MiniBrowser/qt/MiniBrowser.pro:
2995         * MiniBrowser/qt/MiniBrowser.qrc:
2996         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2997         * MiniBrowser/qt/main.cpp:
2998         * MiniBrowser/qt/qml/BrowserWindow.qml:
2999         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
3000         * MiniBrowser/qt/qml/TouchView.qml: Removed.
3001         * WebKitTestRunner/PlatformWebView.h:
3002         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3003         (WTR::PlatformWebView::PlatformWebView):
3004
3005 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3006
3007         [Qt] Change semantics of the haveQt() function to match API promises
3008
3009         Having Qt 5 does not imply that we have Qt 4, from an API point of
3010         view, as a major version can in theory break BC/SC. Our minimum
3011         version of Qt 4 will always be the latest released version of Qt 4,
3012         so the only place we should use haveQt(4, x) is when checking for
3013         the minimum requirements.
3014
3015         Reviewed by Simon Hausmann.
3016
3017         * qmake/mkspecs/features/default_pre.prf:
3018         * qmake/mkspecs/features/features.prf:
3019         * qmake/mkspecs/features/functions.prf:
3020
3021 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
3022
3023         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
3024         https://bugs.webkit.org/show_bug.cgi?id=69411
3025
3026         Reviewed by Martin Robinson.
3027
3028         * WebKitTestRunner/EventSenderProxy.h:
3029         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3030         * WebKitTestRunner/TestController.cpp:
3031         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3032         use the EventSender instead of WebProcess Event Simulation.
3033         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3034         (WTR::WTREventQueueItem::WTREventQueueItem):
3035         (WTR::EventSenderProxy::EventSenderProxy):
3036         (WTR::getMouseButtonModifiers):
3037         (WTR::eventSenderButtonToGDKButton):
3038         (WTR::EventSenderProxy::createMouseButtonEvent):
3039         (WTR::EventSenderProxy::updateClickCountForButton):
3040         (WTR::EventSenderProxy::replaySavedEvents):
3041         (WTR::EventSenderProxy::sendOrQueueEvent):
3042         (WTR::webkitModifiersToGDKModifiers):
3043         (WTR::getGDKKeySymForKeyRef):
3044         (WTR::EventSenderProxy::keyDown):
3045         (WTR::EventSenderProxy::mouseDown):
3046         (WTR::EventSenderProxy::mouseUp):
3047         (WTR::EventSenderProxy::mouseMoveTo):
3048         (WTR::EventSenderProxy::mouseScrollBy):
3049         (WTR::EventSenderProxy::leapForward):
3050
3051 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3052
3053         [Qt] Enable exports and constructor functions in static libs
3054
3055         Reviewed by Tor Arne Vestbø.
3056
3057         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3058         mac/win32-msvc equivalents when linking static libraries into a shared
3059         library or executable.
3060
3061 2011-11-09  Hayato Ito  <hayato@chromium.org>
3062
3063         [NRWT] Make results.html aware of reference filename in reftests.
3064         https://bugs.webkit.org/show_bug.cgi?id=71574
3065
3066         Reviewed by Ryosuke Niwa.
3067
3068         If a reference filename is different from the default one, include that in result summary
3069         so results.html can link to the correct reference file.
3070
3071         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3072         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3073
3074 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3075
3076         [wx] Unreviewed build fix. Update project files and
3077         add LTC stubs for new methods.
3078
3079         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3080         (LayoutTestController::addChromeInputField):
3081         (LayoutTestController::removeChromeInputField):
3082         (LayoutTestController::focusWebView):
3083         (LayoutTestController::setBackingScaleFactor):
3084         * waf/build/settings.py:
3085
3086 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3087
3088         [wx] Unreviewed build fix. Support XCode 4 when building deps.
3089
3090         * wx/install-unix-extras:
3091
3092 2011-11-09  Eric Seidel  <eric@webkit.org>
3093
3094         Remove the concept of platform-dependent unittests
3095         https://bugs.webkit.org/show_bug.cgi?id=71963
3096
3097         Unreviewed.  Fix test-webkitpy on cygwin.
3098
3099         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3100
3101 2011-11-09  Dana Jansens  <danakj@chromium.org>
3102
3103         Add cc-bugs group to watch changes in chromium graphics
3104         https://bugs.webkit.org/show_bug.cgi?id=71690
3105
3106         Reviewed by David Levin.
3107
3108         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
3109         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
3110         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
3111         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
3112
3113 2011-11-09  Eric Seidel  <eric@webkit.org>
3114
3115         Remove more platform-dependent unittests
3116         https://bugs.webkit.org/show_bug.cgi?id=71971
3117
3118         Reviewed by Adam Barth.
3119
3120         Tests which only run on a couple platforms will break.
3121         All tests should run on all platforms where possible.
3122
3123         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3124         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3125         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3126         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3127
3128 2011-11-09  Ojan Vafai  <ojan@chromium.org>
3129
3130         Merge in results to the test results server even if build numbers conflict
3131         https://bugs.webkit.org/show_bug.cgi?id=71967
3132
3133         Reviewed by Tony Chang.
3134
3135         This was initially meant to be a sanity check that we don't
3136         enter duplicate runs, but it turns out that we can reasonably get
3137         in these situations when a builder is clobbered (e.g. the build
3138         numbers start over again from 0).
3139
3140         * TestResultServer/model/jsonresults.py:
3141         * TestResultServer/model/jsonresults_unittest.py:
3142
3143 2011-11-09  Eric Seidel  <eric@webkit.org>
3144
3145         Remove the concept of platform-dependent unittests
3146         https://bugs.webkit.org/show_bug.cgi?id=71963
3147
3148         Reviewed by Adam Barth.
3149
3150         These have been the source of never-ending sadness.
3151         We'd change behavior and forget to update results in
3152         some unittests because they were only run on certain platforms.
3153         This change removes a large source of these platform-dependent
3154         unittests, which was caused by the port_maker stuff.
3155
3156         It's possible that this change will break test-webkitpy
3157         on some platforms, but that will be a one-time cost.
3158         I will fix the breakage by removing the platform-dependantness
3159         of any such broken tests.
3160
3161         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3162         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3163         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3164         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3165         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3166         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3167         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3168         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3169         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3170         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3171         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3172         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3173         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3174
3175 2011-11-09  Eric Seidel  <eric@webkit.org>
3176
3177         Make the Port object have a Host
3178         https://bugs.webkit.org/show_bug.cgi?id=71961
3179
3180         Reviewed by Adam Barth.
3181
3182         This has been a long time coming.
3183         Now that Port has a Host object, it's very easy
3184         to write unittests which use a properly mocked Port.
3185         Soon we will remove the executive, filesystem and user
3186         members of Port and get everything through the Host.
3187
3188         Note how in many callsites we're actually removing
3189         explicit mocks, since we're now always going to get the
3190         correct Executive/User/FileSystem from the
3191         Host and callsites don't need to be careful to pass each one.
3192
3193         This is prep-work for adding a new Environment member to
3194         Host and needing to be able to access the Environment
3195         member from Port functions w/o needing to pass an Environment
3196         object (or appropriate Mock) every place we create a Port object.
3197         Now that we have a single Host object to reach out through, its
3198         simple to add additional functionality (like Environment) while
3199         keeping our unittests properly mocked.
3200
3201         * Scripts/webkitpy/common/host.py:
3202         * Scripts/webkitpy/common/net/credentials_unittest.py:
3203         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3204         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3205         * Scripts/webkitpy/layout_tests/port/apple.py:
3206         * Scripts/webkitpy/layout_tests/port/base.py:
3207         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3208         * Scripts/webkitpy/layout_tests/port/chromium.py:
3209         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3210         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3211         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3212         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3213         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3214         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3215         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3216         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3217         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3218         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3219         * Scripts/webkitpy/layout_tests/port/efl.py:
3220         * Scripts/webkitpy/layout_tests/port/factory.py:
3221         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3222         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3223         * Scripts/webkitpy/layout_tests/port/gtk.py:
3224         * Scripts/webkitpy/layout_tests/port/mac.py:
3225         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3226         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3227         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3228         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3229         * Scripts/webkitpy/layout_tests/port/qt.py:
3230         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3231         * Scripts/webkitpy/layout_tests/port/test.py:
3232         * Scripts/webkitpy/layout_tests/port/webkit.py:
3233         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3234         * Scripts/webkitpy/layout_tests/port/win.py:
3235         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3236         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3237         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3238         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3239         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3240
3241 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
3242
3243         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
3244         https://bugs.webkit.org/show_bug.cgi?id=71561
3245
3246         Reviewed by Dimitri Glazkov.
3247
3248         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3249         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3250
3251 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
3252
3253         Implement dumpProgressFinishedCallback() for Mac layoutTestController
3254         https://bugs.webkit.org/show_bug.cgi?id=66772
3255
3256         Reviewed by Simon Fraser.
3257
3258         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
3259         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
3260
3261         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
3262         in the FrameLoadDelegate and print the output in response to the notification.
3263
3264         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3265         (-[FrameLoadDelegate init]):
3266         (-[FrameLoadDelegate dealloc]):
3267         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
3268
3269 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3270
3271         [GTK][DRT] window internals object is not reset after each test
3272         https://bugs.webkit.org/show_bug.cgi?id=71890
3273
3274         Reviewed by Martin Robinson.
3275
3276         Call WebCoreTestSupport::resetInternalsObject without going
3277         through DumpRenderTreeSupport.
3278
3279         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3280         (runTest):
3281
3282 2011-11-09  Beth Dakin  <bdakin@apple.com>
3283
3284         Build fix.
3285
3286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3287         (AccessibilityUIElement::uiElementAttributeValue):
3288
3289 2011-11-09  Beth Dakin  <bdakin@apple.com>
3290
3291         Speculative build fix.
3292
3293         * DumpRenderTree/AccessibilityUIElement.h:
3294
3295 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
3296
3297         Unreviewed build fix.
3298
3299         * DumpRenderTree/AccessibilityUIElement.cpp:
3300         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3301         A bad merge added this check that is making the bots sad.
3302
3303 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
3304
3305         AX: crash when accessing selectedTab in a tab list
3306         https://bugs.webkit.org/show_bug.cgi?id=70938
3307
3308         Reviewed by Beth Dakin.
3309
3310         Add the ability to retrieve an element through an arbitrary attribute.
3311
3312         * DumpRenderTree/AccessibilityUIElement.cpp:
3313         (uiElementAttributeValueCallback):
3314         (AccessibilityUIElement::uiElementAttributeValue):
3315         (AccessibilityUIElement::getJSClass):
3316         * DumpRenderTree/AccessibilityUIElement.h:
3317         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3318         (AccessibilityUIElement::uiElementAttributeValue):
3319
3320 2011-11-09  Andy Wingo  <wingo@igalia.com>
3321
3322         Add webkitdirs.pm:getArchitecture implementation for GTK
3323         https://bugs.webkit.org/show_bug.cgi?id=71370
3324
3325         Reviewed by Xan Lopez.
3326
3327         * Scripts/webkitdirs.pm (determineArchitecture): Add an
3328         implementation for ports using autotools, so that a vanilla
3329         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
3330         to build-jsc on x86-64 machines.
3331
3332 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3333
3334         Unreviewed, rolling out r99707.
3335         http://trac.webkit.org/changeset/99707
3336
3337         Re-enable until we can disable it together with tests in one
3338         shot.
3339
3340         * qmake/mkspecs/features/features.prf:
3341
3342 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3343
3344         [Qt] Disable use of QtUiTools if the library/module is not found
3345
3346         We rely on the lookup order of prf files to inject our own uitools.prf
3347         that will verify that QtUiTools is in fact present before allowing the
3348         CONFIG += uitools to have any effect.
3349
3350         Reviewed by Simon Hausmann.
3351
3352         * DumpRenderTree/qt/DumpRenderTree.pro:
3353         * QtTestBrowser/QtTestBrowser.pro:
3354         * qmake/mkspecs/features/uitools.prf: Added.
3355
3356 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3357
3358         Unreviewed, rolling out r99701.
3359         http://trac.webkit.org/changeset/99701
3360
3361         Breaks Qt mac build
3362
3363         * qmake/mkspecs/features/functions.prf:
3364
3365 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3366
3367         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
3368
3369         Reviewed by Tor Arne Vestbø.
3370
3371         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
3372         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
3373         is not up to the task of full XSLT support, so we should disable it.
3374
3375 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3376
3377         [Qt] Enable exports and constructor functions in static libs
3378
3379         Reviewed by Tor Arne Vestbø.
3380
3381         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3382         mac/win32-msvc equivalents when linking static libraries into a shared
3383         library or executable.
3384
3385 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3386
3387         [GTK][DRT] window internals object is not reset after each test
3388         https://bugs.webkit.org/show_bug.cgi?id=71890
3389
3390         Reviewed by Xan Lopez.
3391
3392         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3393         (runTest): reset the Internals object after each test.
3394
3395 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3396
3397         [Qt] Detect presence of QtUiTools and enable it only when available
3398
3399         The disable_uitools option was a workaround for missing detection.
3400
3401         Reviewed by Simon Hausmann.
3402
3403         * QtTestBrowser/QtTestBrowser.pro:
3404         * qmake/mkspecs/features/default_post.prf:
3405         * qmake/mkspecs/features/default_pre.prf:
3406
3407 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3408
3409         [Qt] Don't override config for the build_pass of debug_and_release
3410
3411         Qmake will parse the profile once for each configuration (debug and
3412         release), with the build_pass option set. In that situation we don't
3413         want to override what qmake is setting explicitly, otherwise the
3414         debug-step will end up hitting all the release-scopes.
3415
3416         Reviewed by Simon Hausmann.
3417
3418         * qmake/mkspecs/features/default_pre.prf:
3419
3420 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3421
3422         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
3423
3424         * qmake/mkspecs/features/functions.prf:
3425
3426 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3427
3428         [Qt] Centralize duplicated code for linking the static libs
3429
3430         Reviewed by Tor Arne Vestbø.
3431
3432         * qmake/mkspecs/features/functions.prf:
3433         * qmake/mkspecs/features/javascriptcore.prf:
3434         * qmake/mkspecs/features/webcore.prf:
3435         * qmake/mkspecs/features/webkit2.prf:
3436
3437 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3438
3439         [Qt] Build system cleanup
3440         https://bugs.webkit.org/show_bug.cgi?id=71815
3441
3442         Reviewed by Kenneth Rohde Christiansen.
3443
3444         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
3445         static library.
3446         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
3447         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
3448
3449 2011-11-08  Hayato Ito  <hayato@chromium.org>
3450
3451         [NRWT] Make single_test_runner aware of reference filename of test_input.
3452         https://bugs.webkit.org/show_bug.cgi?id=71567
3453
3454         Reviewed by Ryosuke Niwa.
3455
3456         Make single_test_runner honor a reference filename of given test_input so that
3457         we can use any file as reference html, instead of depending on implicit naming convention.
3458         The typical use case is to support w3c reftests.
3459
3460         No tests since no functional changes until there is a client.
3461         Test should be easily written with future clients.
3462
3463         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3464         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3465         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3466         * Scripts/webkitpy/layout_tests/models/test_input.py:
3467
3468 2011-11-08  Lucas Forschler  <lforschler@apple.com>
3469
3470         https://bugs.webkit.org/show_bug.cgi?id=71839
3471         Update the leaks bot OS to Lion.
3472         Update the config.json to reflect the update.
3473
3474         Reviewed by Stephanie Lewis.
3475
3476         * BuildSlaveSupport/build.webkit.org-config/config.json:
3477
3478 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3479
3480         Unreviewed, rolling out r99626.
3481         http://trac.webkit.org/changeset/99626
3482         https://bugs.webkit.org/show_bug.cgi?id=71866
3483
3484         "C++ exceptions cannot be disabled without influencing the
3485         Objective-C exceptions" (Requested by benjaminp on #webkit).
3486
3487         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3488
3489 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
3490
3491         [Mac] Disable C++ exceptions from DumpRenderTree
3492         https://bugs.webkit.org/show_bug.cgi?id=71834
3493
3494         Reviewed by Darin Adler.
3495
3496         DumpRenderTree Mac does not handle C++ exceptions. When such exception
3497         happens, it tends to cause the AutoReleasePool stack to be corrupted,
3498         which leads to crashes long after the exception was raised.
3499
3500         This patch disabled C++ exceptions in order to catch the problems where
3501         they happen when a C++ exception is raised.
3502
3503         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3504
3505 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
3506
3507         Moved myself to the reviewer list (yay!).
3508
3509         * Scripts/webkitpy/common/config/committers.py:
3510
3511 2011-11-08  Zeno Albisser  <zeno@webkit.org>
3512
3513         Added myself as a committer.
3514
3515         * Scripts/webkitpy/common/config/committers.py:
3516
3517 2011-11-08  Andy Wingo  <wingo@igalia.com>
3518
3519         Skip some ECMAScript tests that fail on Linux in some time zones.
3520         https://bugs.webkit.org/show_bug.cgi?id=71371
3521
3522         Reviewed by Martin Robinson.
3523
3524         * Scripts/run-javascriptcore-tests: Skip some more tests.
3525
3526 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
3527
3528         [Qt] Unreviewed trivial fix after build system refactoring.
3529
3530         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
3531
3532 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3533
3534         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
3535
3536         If a pro file needs to access the OBJECTS_DIR it should use the
3537         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
3538         after defaults_post has been processed.
3539
3540         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
3541         the command line will override whatever we set in defaults_pre.
3542
3543         Reviewed by Simon Hausmann.
3544
3545         * qmake/mkspecs/features/default_post.prf:
3546         * qmake/mkspecs/features/default_pre.prf:
3547
3548 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3549
3550         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
3551
3552         Reviewed by Simon Hausmann.
3553
3554         * qmake/mkspecs/features/default_post.prf:
3555
3556 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
3557
3558         [Qt][WK2] MiniBrowser should use urlFromUserInput()
3559         https://bugs.webkit.org/show_bug.cgi?id=71680
3560
3561         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
3562         complete urls in MiniBrowser.
3563
3564         Reviewed by Tor Arne Vestbø.
3565
3566         * MiniBrowser/qt/BrowserWindow.cpp:
3567         (BrowserWindow::BrowserWindow):
3568         (BrowserWindow::load):
3569         * MiniBrowser/qt/qml/BrowserWindow.qml:
3570         * MiniBrowser/qt/utils.cpp:
3571         (Utils::urlFromUserInput):
3572         * MiniBrowser/qt/utils.h:
3573         (Utils::Utils):
3574
3575 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
3576
3577         Added myself as a committer.
3578
3579         * Scripts/webkitpy/common/config/committers.py:
3580
3581 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3582
3583         Unreviewed webkitpy test fix after r99512.
3584
3585         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3586         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
3587
3588 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3589
3590         Added myself as a committer.
3591
3592         * Scripts/webkitpy/common/config/committers.py:
3593
3594 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3595
3596         Unreviewed, rolling out r99470.
3597         http://trac.webkit.org/changeset/99470
3598         https://bugs.webkit.org/show_bug.cgi?id=71740
3599
3600         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
3601
3602         * Scripts/webkitpy/common/config/watchlist:
3603
3604 2011-11-07  Tony Chang  <tony@chromium.org>
3605
3606         [chromium] update flakiness dashboard to reflect current bots
3607
3608         Reviewed by Ojan Vafai.
3609
3610         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
3611             bots and merged linux debug bots into a single bot.
3612         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3613         (setupExpectationsTest):
3614
3615 2011-11-07  Dana Jansens  <danakj@chromium.org>
3616
3617         Add cc-bugs group to watch changes in chromium graphics
3618         https://bugs.webkit.org/show_bug.cgi?id=71690
3619
3620         Reviewed by James Robinson.
3621
3622         * Scripts/webkitpy/common/config/watchlist:
3623
3624 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3625
3626         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
3627         https://bugs.webkit.org/show_bug.cgi?id=70912
3628
3629         Reviewed by Ojan Vafai.
3630
3631         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
3632         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
3633
3634 2011-11-07  Eric Seidel  <eric@webkit.org>
3635
3636         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
3637         https://bugs.webkit.org/show_bug.cgi?id=62199
3638
3639         Reviewed by Dirk Pranke.
3640
3641         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3643         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3644
3645 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
3646
3647         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
3648         https://bugs.webkit.org/show_bug.cgi?id=71485
3649
3650         Reviewed by Darin Fisher.
3651
3652         * DumpRenderTree/chromium/EventSender.cpp:
3653         (EventSender::scalePageBy):
3654         * DumpRenderTree/chromium/TestShell.cpp:
3655         (TestShell::resetTestController):
3656
3657 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3658
3659         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
3660
3661         Allows us to not package up the whole Source/JavaScriptCore directory for the
3662         buildbots.
3663
3664         Reviewed-by Simon Hausmann.
3665
3666         * BuildSlaveSupport/built-product-archive:
3667         * Scripts/webkitdirs.pm:
3668         (jscProductDir):
3669
3670 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3671
3672         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
3673
3674         Reviewed-by Simon Hausmann.
3675
3676         * qmake/mkspecs/features/default_post.prf:
3677
3678 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3679
3680         [Qt] Sanitize qmake paths correctly before comparing
3681
3682         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
3683         which caused us to always generate derived webcore sources, but never build
3684         them. The bug has been fixed, and we now also sanitize paths for the injected
3685         bundle derived sources.
3686
3687         Reviewed by Simon Hausmann.
3688
3689         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3690         * qmake/mkspecs/features/functions.prf:
3691
3692 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3693
3694         [Qt] Print right order for changing feature defines
3695
3696         Reviewed by Simon Hausmann.
3697
3698         * Scripts/webkitdirs.pm:
3699         (buildQMakeProject):
3700
3701 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
3702
3703         [Qt] Unreviewed trivial fix after build system refactoring.
3704
3705         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
3706
3707 2011-11-06  Eric Seidel  <eric@webkit.org>
3708
3709         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3710         https://bugs.webkit.org/show_bug.cgi?id=66078
3711
3712         Unreviewed.  Add an assert about the type of "args"
3713         to our Executive Mocks and fix a piece of code
3714         from this patch which was hitting that assert
3715         when executing for real.
3716
3717         * Scripts/webkitpy/common/system/executive_mock.py:
3718         * Scripts/webkitpy/layout_tests/port/webkit.py:
3719
3720 2011-11-06  Eric Seidel  <eric@webkit.org>
3721
3722         Split chunk handling out of prepare_lists_and_print_output to make it more readable
3723         https://bugs.webkit.org/show_bug.cgi?id=71629
3724
3725         Reviewed by Adam Barth.
3726
3727         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3728
3729 2011-11-06  Eric Seidel  <eric@webkit.org>
3730
3731         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3732         https://bugs.webkit.org/show_bug.cgi?id=66078
3733
3734         Reviewed by Adam Barth.
3735
3736         The runtime feature detection was fixed to work in bug 64472.
3737         In this bug I moved the symbol-based feature detection from
3738         popen() to Executive.run_command and cleaned up the callers
3739         and unittests to make sure that we're correctly parsing the
3740         nm output correctly.  The old code happened to work even though
3741         the runtime-features path was using "str in list" and the
3742         symbol features path was using "str in str" and it just happened
3743         to do what we wanted to.  Now runtime features and symbol feature
3744         blacklists are computed separately (and with better documentation).
3745
3746         This system remains confusing, partially because these are black-lists
3747         which are amended to whatever static blacklist may exist for the
3748         port as part of a Skipped list file.
3749
3750         For example, notice how the runtime feature list only has directory
3751         blacklists for a couple features.  If all features are off,
3752         how do we skip enough tests with only 2 entries in the blacklist map?
3753         The answer is that Windows is the only port to use runtime feature
3754         detection, and the win/Skipped file turns off all the other features
3755         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
3756         which use symbol-based feature detection turn of mathml, wcss, etc
3757         using the blacklists found in _missing_symbol_to_skipped_tests.
3758
3759         I also noticed a couple places where we still referenced xhtmlmp
3760         even though support for such has been removed from WebKit.  Removed those.
3761
3762         This should result in no functional change.
3763
3764         * Scripts/webkitpy/layout_tests/port/gtk.py:
3765          - Use self._filesystem instead of os.path
3766         * Scripts/webkitpy/layout_tests/port/webkit.py:
3767         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3768
3769 2011-11-06  Dan Bernstein  <mitz@apple.com>
3770
3771         Made show-pretty-diff work when the input path contains spaces.
3772
3773         Reviewed by Anders Carlsson.
3774
3775         * Scripts/show-pretty-diff:
3776
3777 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
3778
3779         [chromium] Use the security origin instead of the URL when checking notification permissions
3780         https://bugs.webkit.org/show_bug.cgi?id=71590
3781
3782         Reviewed by Adam Barth.
3783
3784         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3785         (NotificationPresenter::checkPermission):
3786         * DumpRenderTree/chromium/NotificationPresenter.h:
3787
3788 2011-11-05  Darin Adler  <darin@apple.com>
3789
3790         Fix a small leak in Mac version of LayoutTestController
3791         https://bugs.webkit.org/show_bug.cgi?id=71615
3792
3793         Reviewed by Mark Rowe.
3794
3795         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3796         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
3797         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
3798
3799 2011-11-04  Eric Seidel  <eric@webkit.org>
3800
3801         Upgrade to the latest Mechanize
3802         https://bugs.webkit.org/show_bug.cgi?id=71594
3803
3804         Reviewed by Adam Barth.
3805
3806         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
3807         Mechanize is no longer two separate libraries, so importing it is much simpler.
3808
3809         * Scripts/webkitpy/thirdparty/__init__.py:
3810
3811 2011-11-04  Stephen Chenney  <schenney@chromium.org>
3812
3813         Crash in ScrollAnimator.cpp
3814         https://bugs.webkit.org/show_bug.cgi?id=69865
3815
3816         The code in ScrollAnimator assumes that horizontal per-page mouse
3817         wheel events cannot happen, which is not true. This patch adds layout
3818         tests for all paging wheel event situations and fixes the broken
3819         horizontal case.
3820
3821         Reviewed by Anders Carlsson
3822
3823         * DumpRenderTree/chromium/EventSender.cpp:
3824         (EventSender::handleMouseWheel): Added the ability to specify that a
3825         mouse wheel event should be paging.
3826
3827 2011-11-04  Eric Seidel  <eric@webkit.org>
3828
3829         Remove deprecated free functions in port.factory
3830         https://bugs.webkit.org/show_bug.cgi?id=71494
3831
3832         Unreviewed.  Fix exception when running new-run-webkit-httpd.
3833
3834         * Scripts/new-run-webkit-httpd:
3835
3836 2011-11-04  Adam Roben  <aroben@apple.com>
3837
3838         Remove Leopard-specific code from build.webkit.org
3839
3840         We don't have any Leopard bots anymore.
3841
3842         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
3843
3844         Reviewed by Mark Rowe.
3845
3846         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
3847         and StopATSServer steps.
3848         (unitTestsSupported): Removed check for mac-leopard.
3849         (TestFactory.__init__): Removed Leopard-specific steps.
3850
3851 2011-11-04  Eric Seidel  <eric@webkit.org>
3852
3853         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
3854         https://bugs.webkit.org/show_bug.cgi?id=71549
3855
3856         Reviewed by Adam Barth.
3857
3858         Several members of Host didn't really belong there
3859         and were instead specific to WebKitPatch, so I've moved
3860         them up onto that class.
3861
3862         * Scripts/webkitpy/common/host.py:
3863         * Scripts/webkitpy/common/host_mock.py:
3864         * Scripts/webkitpy/tool/main.py:
3865         * Scripts/webkitpy/tool/mocktool.py:
3866         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3867
3868 2011-11-04  Tony Chang  <tony@chromium.org>
3869
3870         garden-o-matic: bring back party time!
3871         https://bugs.webkit.org/show_bug.cgi?id=71582
3872
3873         Reviewed by Adam Barth.
3874
3875         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
3876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
3877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
3878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
3879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
3880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
3881
3882 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3883
3884         [EFL] DRT: Fix the order of the items in the dumped history list.
3885         https://bugs.webkit.org/show_bug.cgi?id=71562
3886
3887         It did not make much sense to hold the history list in a map, as we do not need
3888         the keys. And the printed items must be sorted by target, which is more easily
3889         done with a vector.
3890
3891         Should make tests such as http/tests/navigation/error404-frames.html pass.
3892
3893         Reviewed by Antonio Gomes.
3894
3895         * DumpRenderTree/efl/DumpHistoryItem.cpp:
3896         (compareHistoryItemsByTarget):
3897         (dumpHistoryItem):
3898
3899 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
3900
3901         [Qt] Remove ENABLE_SQLITE from qmake files
3902         https://bugs.webkit.org/show_bug.cgi?id=71546
3903
3904         Reviewed by Simon Hausmann.
3905
3906         * qmake/mkspecs/features/features.prf:
3907         * qmake/mkspecs/features/webcore.prf:
3908
3909 2011-11-04  Adam Barth  <abarth@webkit.org>
3910
3911         watchlist for WebIDL shouldn't trigger on Internals.idl
3912         https://bugs.webkit.org/show_bug.cgi?id=70657
3913
3914         Reviewed by David Levin.
3915
3916         Internals.idl isn't part of the Web-facing IDL in the project.
3917
3918         * Scripts/webkitpy/common/config/watchlist:
3919
3920 2011-11-04  Anders Carlsson  <andersca@apple.com>
3921
3922         Fix WKTR crash when running NPN_ConvertPoint test.
3923
3924         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
3925
3926         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3927         (ConvertPoint::NPP_SetWindow):
3928
3929 2011-11-04  Anders Carlsson  <andersca@apple.com>
3930
3931         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3932         https://bugs.webkit.org/show_bug.cgi?id=71570
3933
3934         Reviewed by Simon Fraser.
3935
3936         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3937         (PluginTest::NPP_SetWindow):
3938         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3939         Remove the NPP parameter from NPP_SetWindow.
3940
3941         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3942         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3943         Remove the NPP parameter from NPP_SetWindow.
3944
3945         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3946         (PassDifferentNPPStruct::NPP_SetWindow):
3947         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3948
3949         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3950         (ConvertPoint::NPP_SetWindow):
3951         Run the test from NPP_SetWindow and call notifyDone() when done.
3952
3953         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3954         (NPP_SetWindow):
3955         Remove unnecessary parameter.
3956
3957 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3958
3959         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3960
3961         Rubber-stamped by Tor Arne Vestbø.
3962
3963         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3964         changed slightly after the refactoring.
3965
3966 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3967
3968         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3969
3970         Reviewed by Simon Hausmann.
3971
3972         * qmake/mkspecs/features/default_pre.prf:
3973
3974 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3975
3976         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3977
3978         Reviewed by Simmon Hausmann.
3979
3980         * qmake/mkspecs/features/default_pre.prf:
3981
3982 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3983
3984         [Qt] Disable STDIN check before cleaning build dir
3985
3986         It didn't work on the bots.
3987
3988         Reviewed by Ossy.
3989
3990         * Scripts/webkitdirs.pm:
3991
3992 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3993
3994         [Qt] Don't build all of webkit when running build-jsc
3995
3996         In case the whole webkit project was built, but we then subsequently
3997         want to build only JSC, we need to run make in the proper subdirectory.
3998
3999         This also means the incremental target needs to be added to all
4000         makefiles.
4001
4002         Reviewed by Simmon Hausmann.
4003
4004         * Scripts/webkitdirs.pm:
4005         (buildQMakeProject):
4006         * qmake/mkspecs/features/default_post.prf:
4007
4008 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4009
4010         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
4011
4012         Reviewed by Tor Arne Vestbø.
4013
4014         * Scripts/webkitdirs.pm:
4015         (jscProductDir): jsc path changed.
4016
4017 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4018
4019         [Qt] Error out early if trying to build against Qt < 4.8
4020
4021         Reviewed by Simon Hausmann.
4022
4023         * qmake/mkspecs/features/default_pre.prf:
4024
4025 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4026
4027         Fix run-launcher for Qt and Gtk.
4028
4029         Rubber-stamped by Tor Arne Vestbø.
4030
4031         * Scripts/webkitdirs.pm:
4032         (isWK2): Re-add isWK2(), as it's used in run-launcher.
4033
4034 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4035
4036         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
4037
4038         Reviewed by Simon Hausmann.
4039
4040         * Scripts/build-webkit:
4041
4042 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4043
4044         [GTK] Use web view title as window title in MiniBrowser
4045         https://bugs.webkit.org/show_bug.cgi?id=71544
4046
4047         Reviewed by Philippe Normand.
4048
4049         * MiniBrowser/gtk/BrowserWindow.c:
4050         (webViewURIChanged): Removed extra space.
4051         (webViewTitleChanged): Set window title using
4052         webkit_web_view_get_title().
4053         (browser_window_init): Set initial default window title.
4054         (browserWindowConstructed): Connect to WebView notify::title
4055         signal.
4056
4057 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4058
4059         [Qt] Refactor and clean up the qmake build system
4060
4061         The qmake build system has accumulated a bit of cruft and redundancy
4062         over time. There's also a fairly tight coupling between how to build
4063         the various targets, and _what_ to build, making it harder to add new
4064         rules or sources. This patch aims to elevate these issues somewhat.
4065
4066         This is a short-list of the changes:
4067
4068           * The rules for how to build targets are now mostly contained as
4069             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
4070             allows us to do pre- and post-processing of each project file,
4071             which helps to clean up the actual project files.
4072
4073           * Derived sources are no longer generated as a separate make-step
4074             but is part of each target's project file as a subdir. Makefile
4075             rules are used to ensure that we run make on the derived sources
4076             before running qmake on the actual target makefile. This makes
4077             it easier to keep a proper dependency between derived sources
4078             and the target.
4079
4080           * We use GNU make and the compiler to generate dependencies on
4081             UNIX-based systems running Qt 5. This allows us to lessen the
4082             need to run qmake, which should reduce compile time.
4083
4084           * WebKit2 is now build by default if building with Qt 5. It can
4085             be disabled by passing --no-webkit2 to build-webkit.
4086
4087         The result of these changes are hopefully a cleaner and easier
4088         build system to modify, and faster build times due to no longer
4089         running qmake on every single build. It's also a first step
4090         towards possibly generating the list of sources using another
4091         build system.
4092
4093         https://bugs.webkit.org/show_bug.cgi?id=71222
4094
4095         Reviewed by Simon Hausmann.
4096
4097         * DerivedSources.pro: Removed.
4098         * DumpRenderTree/qt/DumpRenderTree.pro:
4099         * DumpRenderTree/qt/ImageDiff.pro:
4100         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4101         * MiniBrowser/qt/MiniBrowser.pro:
4102         * QtTestBrowser/QtTestBrowser.pro:
4103         * QtTestBrowser/launcherwindow.cpp:
4104         (LauncherWindow::initializeView):
4105         (LauncherWindow::createChrome):
4106         (LauncherWindow::screenshot):
4107         * QtTestBrowser/launcherwindow.h:
4108         (WindowOptions::WindowOptions):
4109         * Scripts/build-webkit:
4110         (unlinkZeroFiles):
4111         * Scripts/webkitdirs.pm:
4112         (qtFeatureDefaults):
4113         (promptUser):
4114         (buildQMakeProject):
4115         * Tools.pro:
4116         * WebKitTestRunner/DerivedSources.pri: Added.
4117         * WebKitTestRunner/DerivedSources.pro: Removed.
4118         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
4119         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
4120         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
4121         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
4122         * WebKitTestRunner/Target.pri: Added.
4123         * WebKitTestRunner/WebKitTestRunner.pro:
4124         * WebKitTestRunner/qt/TestInvocationQt.cpp:
4125         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
4126         * qmake/README: Added.
4127         * qmake/mkspecs/features/default_post.prf: Added.
4128         * qmake/mkspecs/features/default_pre.prf: Added.
4129         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
4130         * qmake/mkspecs/features/functions.prf: Added.
4131         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
4132         * qmake/mkspecs/features/mac/default_post.prf: Added.
4133         * qmake/mkspecs/features/mac/default_pre.prf: Added.
4134         * qmake/mkspecs/features/minimal_qt.prf: Added.
4135         * qmake/mkspecs/features/qtwebkit.prf: Added.
4136         * qmake/mkspecs/features/rpath.prf: Added.
4137         * qmake/mkspecs/features/unix/default_post.prf: Added.
4138         * qmake/mkspecs/features/unix/default_pre.prf: Added.
4139         * qmake/mkspecs/features/valgrind.prf: Added.
4140         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
4141         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
4142         * qmake/mkspecs/features/win32/default_post.prf: Added.
4143         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
4144         * qmake/syncqt-4.8: Added.
4145         (showUsage):
4146         ():
4147         (copyFile):
4148         (symlinkFile):
4149
4150 2011-11-04  Eric Seidel  <eric@webkit.org>
4151
4152         Remove deprecated free functions in port.factory
4153         https://bugs.webkit.org/show_bug.cgi?id=71494
4154
4155         Unreviewed.  Fixing exception seen when running test-webkitpy.
4156
4157         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
4158         unittest, since that script is nearly ready to be deleted.  But I added
4159         it back at the last second and failed to run the tests. :(
4160         This fixes the exception the bots were seeing.
4161
4162         * Scripts/webkitpy/style/checkers/test_expectations.py:
4163         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
4164         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
4165
4166 2011-11-02  Xiaomei Ji  <xji@chromium.org>
4167
4168         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
4169         https://bugs.webkit.org/show_bug.cgi?id=71163
4170
4171         Reviewed by Ryosuke Niwa.
4172
4173         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
4174         (WebPreferences::applyTo):
4175
4176 2011-11-03  Eric Seidel  <eric@webkit.org>
4177
4178         Remove deprecated free functions in port.factory
4179         https://bugs.webkit.org/show_bug.cgi?id=71494
4180
4181         Reviewed by Adam Barth.
4182
4183         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
4184         free functions in factory.py.  To remove these required fixing all callsites
4185         to use MockHost, Host, or PortFactory where appropriate.  After this change
4186         we're only left with a handfull of places where we inappropraitely use a
4187         real Executive, FileSystem or User object during unittesting.
4188
4189         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4190          - These PortFactory overrides were from an earlier edition of my previous patch
4191            in the end, I removed MockPortFactory so all tests ended up with this same
4192            real PortFactory() with a MockHost.  This was simply redundent code.
4193         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4194          - Use MockHost to get a mocked-out PortFactory.
4195         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
4196          - This code has no access to a Host object, so we just use a default PortFactory
4197            for now.  This will still incorrectly create real Executive/FileSystem objects
4198            durring unittesting, which is wrong. :(
4199         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
4200          - Use a MockHost to get a mocked PortFactory.
4201         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
4202          - Use a MockHost to get a mocked PortFactory.
4203         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
4204          - ditto.
4205         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4206          - ditto.
4207         * Scripts/webkitpy/layout_tests/port/__init__.py:
4208          - factory.get no longer exists.  Yay!
4209         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4210          - Use a MockHost to get a mocked PortFactory.
4211            To do this efficiently, I created a helper function
4212            and combined all these (mostly redundant) tests into one test
4213            with several calls to the helper function.
4214         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4215          - Pass MockUser and MockExecutive in these port testing subclasses.
4216          - I also removed a bunch of unecessary uses of mocktool. namespacing.
4217         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4218          - Awesome windows hacks should only happen on win32.  Once we started
4219            using MockExecutives these 'svn help' commands started printing in
4220            other tests, which is how I found this bug.
4221         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4222          - DryRunPort has no Host, so just use a PortFactory() directly.
4223            This will do the wrong thing if we're unittesting the DryRun port
4224            but it's no worse than the existing code.
4225         * Scripts/webkitpy/layout_tests/port/factory.py:
4226          - Remove the free functions.
4227          - Fix argument overriding to be able to override None.
4228         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4229          - Use a mocked-out PortFactory during testing.
4230         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4231          - Pass MockExecutive and MockUser to these manual Port instantiations.
4232         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
4233          - No access to a Host object here, so just using PortFactory directly.
4234            This is wrong, but no more wrong than the existing code was.
4235         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4236          - Use a MockHost to get a mocked out PortFactory.
4237         * Scripts/webkitpy/layout_tests/port/test.py:
4238          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
4239         * Scripts/webkitpy/layout_tests/port/win.py:
4240          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
4241            now that we're actually passing MockExecutive to most Port instantiations during testing.
4242         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4243          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
4244         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4245          - Host is the future.
4246         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4247          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
4248            we don't need to pass MockUser explicitly, it does that automatically for us.
4249         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4250          - Use a MockHost to get a mocked out PortFactory.
4251         * Scripts/webkitpy/style/checkers/test_expectations.py:
4252          - We don't have access to a Host object, so using PortFactory() directly.
4253         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4254          - Remove unused variable.
4255         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
4256          - Host isn't accessible here, so using PortFactory() directly, which
4257            although unfortunate is no worse than before.
4258         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
4259          - Testing is much easier when you don't need to hack global state...
4260         * Scripts/webkitpy/tool/commands/expectations.py:
4261          - Use the port_factory on the tool.
4262         * Scripts/webkitpy/tool/commands/rebaseline.py:
4263          - ditto.
4264         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4265          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
4266            the arguments in the right order.  Fixing that made it use a MockFileSystem
4267            (like it had been trying to), which then required us to actually populate
4268            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
4269         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4270          - Get the port_factory from the tool.
4271         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4272          - Ditto.
4273         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4274          - Use a MockHost to get a mocked out Port object.
4275
4276 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
4277
4278         [EFL] DRT: Allow choosing which backing store to use.
4279         https://bugs.webkit.org/show_bug.cgi?id=70532
4280
4281         Reviewed by Antonio Gomes.
4282
4283         This change makes it possible to change the backing store used by DRT
4284