2176b41dd40f9a6119565a4fe1fb3028e726b7e6
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
2
3         Update safariVersion to safariVersionString
4         https://bugs.webkit.org/show_bug.cgi?id=138193
5
6         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
7         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
8
9         Rubber-stamped by David Kilzer.
10
11         * Scripts/bisect-builds:
12         (makeNightlyList):
13         Compare safariVersionString to a string literal, instead of safariVersion.
14
15 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
16
17         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
18         https://bugs.webkit.org/show_bug.cgi?id=137775
19
20         Reviewed by Carlos Garcia Campos.
21
22         * MiniBrowser/gtk/BrowserWindow.c:
23         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
24         (browser_window_init):
25
26 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
27
28         CommitQueue and EWS should reject any patches that result in consistent test
29         failures that aren't present on the tree.
30         https://bugs.webkit.org/show_bug.cgi?id=138184
31
32         Reviewed by Alexey Proskuryakov.
33
34         * Scripts/webkitpy/layout_tests/models/test_results.py:
35         Adds a simple hashing function to allow for set operations to handle
36         TestResult objects properly.
37         (TestResult.__hash__):
38         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
39         Adds one unit test, and modifies others to agree with the notion that
40         patches that introduce new test failures (but also have flakyness)
41         should be rejected rather than spin.
42         (MockCommitQueue.report_flaky_tests):
43         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
44         (test_double_flaky_test_failure):
45         (test_two_flaky_tests):
46         (test_very_flaky_patch):
47         (test_very_flaky_patch_with_some_tree_redness):
48         (test_different_test_failures):
49         (test_different_test_failures_with_some_tree_redness):
50         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
51         (test_mildly_flaky_patch):
52         (test_mildly_flaky_patch_with_some_tree_redness):
53         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
54         Makes PatchAnalysisTask reject said patches.
55         (PatchAnalysisTask._test_patch):
56
57 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
58
59         WinCairoRequirements.zip cannot be downloaded from dropbox
60         https://bugs.webkit.org/show_bug.cgi?id=138113
61
62         Reviewed by Alexey Proskuryakov.
63
64         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
65
66 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
67
68         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
69         https://bugs.webkit.org/show_bug.cgi?id=138193
70
71         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
72         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
73
74         It also does a bit of refactoring, including distinguishing between versions and version strings and
75         saving versions to local variables instead of using eval in each conditional.
76
77         Reviewed by David Kilzer.
78
79         * Scripts/bisect-builds:
80         (makeNightlyList):
81         Restrict the set of nightlies to r174650 and above when running Yosemite.
82         Restrict the set of nightlies to r157846 and above when running Mavericks.
83         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
84
85 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
86
87         [EFL] build-webkit should try harder to avoid re-running cmake
88         https://bugs.webkit.org/show_bug.cgi?id=137949
89
90         Reviewed by Martin Robinson.
91
92         * Scripts/webkitdirs.pm:
93         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
94         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
95
96 2014-10-28  Daniel Bates  <dabates@apple.com>
97
98         Unify logic in RunTests.run() to run the Python unit tests
99         https://bugs.webkit.org/show_bug.cgi?id=138160
100
101         Reviewed by Martin Robinson.
102
103         Unify the interactive and non-interactive code path for running the Python unit tests
104         in step RunTests so as to remove duplicate code to compute the the path to the script
105         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
106
107         No new tests since no functionality was changed.
108
109         * Scripts/webkitpy/port/base.py:
110         (Port.python_unittest_results_directory):
111         * Scripts/webkitpy/tool/steps/runtests.py:
112         (RunTests.run):
113
114 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
115
116         Make runtest.py call test-webkitpy with the --json flag when in
117         non-interactive mode.
118         https://bugs.webkit.org/show_bug.cgi?id=137667
119
120         Reviewed by Daniel Bates.
121
122         * Scripts/webkitpy/port/base.py:
123         Adds the python_unittest_results_directory method.
124         (Port.python_unittest_results_directory):
125         * Scripts/webkitpy/tool/steps/runtests.py:
126         Changes RunTests to call test-webkitpy with the --json flag if the
127         --non-interactive flag is set.
128         (RunTests):
129         (RunTests.run):
130
131 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
132
133         import-w3c-tests should use re.escape() wherever it's handling file paths
134         https://bugs.webkit.org/show_bug.cgi?id=137934
135
136         This patch adds re.escape() to a few places where we're doing string
137         conversions. This prevents errors when attribute values coincidentally
138         have character sequences that can be interpreted as regular expressions.
139
140         Reviewed by Bem Jones-Bey.
141
142         * Scripts/webkitpy/w3c/test_converter.py:
143         (_W3CTestConverter.convert_attributes_if_needed):
144
145 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
146
147         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
148         https://bugs.webkit.org/show_bug.cgi?id=138130
149
150         Reviewed by Csaba Osztrogonác.
151
152         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
153
154 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
155
156         Fix link to Arch Linux Wiki
157         https://bugs.webkit.org/show_bug.cgi?id=138010
158
159         Reviewed by Benjamin Poulain.
160
161         * gtk/install-dependencies:
162
163 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
164
165         Test regressions are not detected when image result is missing
166         https://bugs.webkit.org/show_bug.cgi?id=138070
167
168         Reviewed by Simon Fraser.
169
170         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
171         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
172         Count these as regressions, not as flaky tests.
173
174         * Scripts/webkitpy/port/test.py:
175         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
176         Test it.
177
178 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
179
180         Add Conrad Shultz to the contributors list.
181
182         * Scripts/webkitpy/common/config/contributors.json:
183
184 2014-10-24  Dan Bernstein  <mitz@apple.com>
185
186         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
187         https://bugs.webkit.org/show_bug.cgi?id=138046
188
189         Reviewed by Alexey Proskuryakov.
190
191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
192         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
193         401. Otherwise, we’ll retry normally in 45 seconds.
194
195 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
196
197         [GTK] Implement is_selected method on WebKitHitTestResult
198         https://bugs.webkit.org/show_bug.cgi?id=137110
199
200         Reviewed by Tim Horton.
201
202         Add tests for new context SELECTION on WebKitHitTestResult.
203
204         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
205         (testContextMenuDefaultMenu):
206         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
207         (testWebViewMouseTarget):
208
209 2014-10-23  Roger Fong  <roger_fong@apple.com>
210
211         [Win] Skip failing JSC tests following r175078
212         https://bugs.webkit.org/show_bug.cgi?id=130967.
213
214         * Scripts/run-javascriptcore-tests:
215
216 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
217
218         commitqueuetask_unittest.py should be made more concise.
219         https://bugs.webkit.org/show_bug.cgi?id=137985
220
221         Reviewed by Alexey Proskuryakov.
222
223         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
224         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
225         (MockCommitQueue.__init__):
226         (MockCommitQueue.report_flaky_tests):
227         (MockCommitQueue):
228         (MockCommitQueue.get_reported_flaky_tests):
229         (MockSimpleTestPlanCommitQueue.__init__):
230         (MockSimpleTestPlanCommitQueue.run_command):
231         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
232         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
233         (test_land_failure):
234         (test_failed_archive):
235         (test_double_flaky_test_failure):
236         (test_test_failure):
237         (test_red_test_failure):
238         (test_very_red_tree_retry):
239         (test_red_tree_patch_rejection):
240         (test_one_flaky_test):
241         (test_tree_more_red_than_patch):
242         (MockCommitQueue.test_results): Deleted.
243         (test_simple_flaky_test_failure): Deleted.
244         (_expect_validate): Deleted.
245         (_expect_validate.MockDelegate): Deleted.
246         (_expect_validate.MockDelegate.refetch_patch): Deleted.
247         (_expect_validate.MockDelegate.expected_failures): Deleted.
248         (_mock_patch): Deleted.
249         (test_validate): Deleted.
250         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
251         Fixes a bug that slipped through the cracks prior to this change.
252         (PatchAnalysisTask._test_patch):
253
254 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
255
256         Flakiness dashboard should support OS X Yosemite
257         https://bugs.webkit.org/show_bug.cgi?id=137986
258
259         Reviewed by Ryosuke Niwa.
260
261         * TestResultServer/app.yaml:
262         * TestResultServer/static-dashboards/builders.jsonp:
263         * TestResultServer/static-dashboards/flakiness_dashboard.js:
264
265 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
266
267         commitqueuetask should include more tests to ensure that the behavior
268         of PatchAnalysisTask._test_patch() is well defined
269         https://bugs.webkit.org/show_bug.cgi?id=137977
270
271         Reviewed by Alexey Proskuryakov.
272
273         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
274         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
275         and more readable to define tests that are meant to test the behaviour
276         of PatchAnalysisTask._test_patch(), and adds several unit tests.
277         (FailingTestCommitQueue.test_results):
278         (PatchAnalysisResult):
279         (MockSimpleTestPlanCommitQueue):
280         (MockSimpleTestPlanCommitQueue.__init__):
281         (MockSimpleTestPlanCommitQueue.run_command):
282         (MockSimpleTestPlanCommitQueue._mock_test_result):
283         (MockSimpleTestPlanCommitQueue.test_results):
284         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
285         (test_flaky_test_failure):
286         (test_failed_archive):
287         (test_two_flaky_tests):
288         (test_one_flaky_test):
289         (test_very_flaky_patch):
290         (test_very_flaky_patch_with_some_tree_redness):
291         (test_different_test_failures):
292         (test_different_test_failures_with_some_tree_redness):
293         (test_mildly_flaky_patch):
294         (test_mildly_flaky_patch_with_some_tree_redness):
295         (test_tree_more_red_than_patch):
296
297 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
298
299         PatchAnalysisTask._test_patch() needs refactoring
300         https://bugs.webkit.org/show_bug.cgi?id=137904
301
302         Reviewed by Alexey Proskuryakov.
303
304         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
305         Fixes several small bugs, and makes minor changes to accomodate the
306         changes in PatchAnalysisTask.
307         (MockCommitQueue.refetch_patch):
308         (MockCommitQueue.test_results):
309         (test_flaky_test_failure):
310         (test_failed_archive):
311         (test_very_red_tree_retry):
312         (_expect_validate.MockDelegate.refetch_patch):
313         (MockCommitQueue.expected_failures): Deleted.
314         (_expect_validate.MockDelegate.expected_failures): Deleted.
315         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
316         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
317         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
318         Removes the unexpected_failures member, adds the _clean_tree_results
319         member, adds a helper function for _test_patch, and refactors
320         _test_patch to be more readable.
321         (PatchAnalysisTask.__init__):
322         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
323         (PatchAnalysisTask._test_patch):
324         (PatchAnalysisTask.results_from_test_run_without_patch):
325         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
326         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
327         (AbstractEarlyWarningSystem.begin_work_queue):
328         (AbstractEarlyWarningSystem._failing_tests_message):
329         (AbstractEarlyWarningSystem.command_failed):
330         (AbstractEarlyWarningSystem.expected_failures): Deleted.
331         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
332         Makes changes to accomodate the changes made to PatchAnalysisTask.
333         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
334         * Scripts/webkitpy/tool/commands/perfalizer.py:
335         Removes Perfalizer's dependancy on ExpectedFailures. 
336         (PerfalizerTask.refetch_patch):
337         (PerfalizerTask.expected_failures): Deleted.
338         * Scripts/webkitpy/tool/commands/queues.py:
339         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
340         initializer to allow for mock injection.
341         (CommitQueue.__init__):
342         (CommitQueue.begin_work_queue):
343         (CommitQueue.process_work_item):
344         (CommitQueue._failing_tests_message):
345         * Scripts/webkitpy/tool/commands/queues_unittest.py:
346         Removes dependancy on ExpectedFailures, and instead uses mock
347         injection.
348         (MockCommitQueueTask):
349         (MockCommitQueueTask.results_from_patch_test_run):
350         (MockCommitQueueTask.results_from_test_run_without_patch):
351         (mock_run_webkit_patch):
352
353 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
354
355         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
356         https://bugs.webkit.org/show_bug.cgi?id=136736
357
358         Reviewed by Gyuyoung Kim.
359
360         * MiniBrowser/efl/main.c:
361         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
362         (window_create):
363
364 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
365
366         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
367         https://bugs.webkit.org/show_bug.cgi?id=137884
368
369         Reviewed by Gustavo Noronha Silva.
370
371         Move InputMethodFilter test from WebCore tests to WebKit2 tests
372         and adapt it to use the new InputMethodFilter WebKit class. Instead
373         of having virtual methods just for testing, it has a testing mode
374         that logs the events.
375
376         * TestWebKitAPI/PlatformGTK.cmake:
377         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
378         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
379         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
380         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
381         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
382         (TestWebKitAPI::TEST):
383         (TestWebKitAPI::temporaryGetPreeditStringOverride):
384         (TestWebKitAPI::temporaryResetOverride):
385         (TestWebKitAPI::verifyCanceledComposition):
386
387 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
388
389         build.webkit.org/dashboard: Cannot click on green tester bubbles
390         https://bugs.webkit.org/show_bug.cgi?id=137909
391
392         Reviewed by Darin Adler.
393
394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
395         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
396
397 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
398
399         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
400         https://bugs.webkit.org/show_bug.cgi?id=137932
401
402         Reviewed by Simon Fraser.
403
404         This is the first step in moving over to native Windows rendering for our layout tests.
405         Once this change lands, approximately 300 tests will start failing on Windows. I will
406         rebaseline these changes against our test hardware and update this bug with the
407         commits related to that work.
408
409         * DumpRenderTree/win/DumpRenderTree.cpp:
410         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
411         we use native Windows drawing style.
412
413 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
414
415         Fix FTL Native Inlining for EFL
416         https://bugs.webkit.org/show_bug.cgi?id=137774
417
418         Reviewed by Michael Saboff.
419
420         Added Clang as an optional module to jhbuild.
421
422         * efl/jhbuild.modules:
423
424 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
425
426         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
427         https://bugs.webkit.org/show_bug.cgi?id=137832
428
429         Reviewed by Carlos Garcia Campos.
430
431         Ensure each test sets the TLS errors policy that it really needs.
432         Have each test except testTLSErrorsPolicy stash and restore the original
433         TLS errors policy. Update testTLSErrorsPolicy to account for the new
434         default policy.
435
436         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
437         (testSSL):
438         (testInsecureContent):
439         (testTLSErrorsPolicy):
440         (testTLSErrorsRedirect):
441         (testTLSErrorsHTTPAuth):
442         (testLoadFailedWithTLSErrors):
443         (beforeAll):
444
445 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
446
447         Unreviewed. Unskip inspector server unit tests.
448
449         They should pass now.
450
451         * Scripts/run-gtk-tests:
452         (TestRunner):
453
454 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
455
456         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
457         https://bugs.webkit.org/show_bug.cgi?id=132044
458
459         Reviewed by Brian Burg.
460
461         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
462         (openRemoteDebuggingSession): Remove trailing slash when
463         concatenating base inspector URL with the page, because the
464         inspector returns the relative paths with a leading slash.
465
466 2014-10-20  Tanay C  <tanay.c@samsung.com>
467
468         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
469         https://bugs.webkit.org/show_bug.cgi?id=137023
470
471         Reviewed by Gyuyoung Kim.
472
473         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
474         (search_box_show): Modified.
475         (search_box_hide): Modified.
476         (on_search_field_activated): Modified.
477         (on_search_backward_button_clicked): Modified.
478         (on_search_forward_button_clicked): Modified.
479         (on_search_case_option_changed): Added.
480         (on_search_word_start_option_changed): Added.
481         (window_create): Modified.
482
483 2014-10-20  Tanay C  <tanay.c@samsung.com>
484
485         [GTK][Minibrowser] Escape key does not hide the search box
486         https://bugs.webkit.org/show_bug.cgi?id=137734
487
488         Reviewed by Philippe Normand.
489
490         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
491         (stopPageLoad): Modified.
492
493 2014-10-18  Antti Koivisto  <antti@apple.com>
494
495         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
496         https://bugs.webkit.org/show_bug.cgi?id=137855
497
498         Reviewed by Dan Bernstein.
499
500         Test and warn if the dumped response mime type differs from the platform response mime type.
501
502         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
503         (WTR::InjectedBundlePage::didReceiveResponseForResource):
504         (WTR::InjectedBundlePage::platformResponseMimeType):
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
506         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
507         (WTR::InjectedBundlePage::platformResponseMimeType):
508
509 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
510
511         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
512         https://bugs.webkit.org/show_bug.cgi?id=137835
513
514         Reviewed by Andreas Kling.
515
516         * Scripts/run-inspector-perf-tests.py: Removed.
517         This script is stale, as PerformanceTests/inspector no longer exists.
518
519 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
520
521         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
522
523         * Scripts/webkitpy/port/ios.py:
524         (IOSSimulatorPort.default_baseline_search_path):
525
526 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
527
528         [iOS] Simplify test fallback paths for iOS Simulator testing
529         https://bugs.webkit.org/show_bug.cgi?id=137830
530
531         Reviewed by Zalan Bujtas.
532         
533         Make the fallback paths be:
534             ios-simulator -> generic
535             ios-simulator-wk2->ios-simulator -> generic
536         
537         so don't include mac in the fallback path. Also remove the
538         version handling for simplicity.
539
540         * Scripts/webkitpy/port/ios.py:
541         (IOSSimulatorPort):
542         (IOSSimulatorPort.default_baseline_search_path):
543
544 2014-10-17  Dana Burkart  <dburkart@apple.com>
545
546         Fix typos in the dashboard config file.
547
548         Unreviewed.
549
550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
551         (WebKitBuildbot):
552
553 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
554
555         [Win] Allow WinLauncher to specify Custom User Agent strings
556         https://bugs.webkit.org/show_bug.cgi?id=137828
557
558         Reviewed by Dean Jackson.
559
560         * WinLauncher/Common.cpp: Add support for custom user agent strings.
561         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
562         and set the user agent strings.
563         * WinLauncher/WinLauncher.h:
564         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
565         resources and dialog for setting custom User Agent strings.
566         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
567
568 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
569
570         [iOS] Turn off font autosizing for iOS WebKitTestRunner
571         https://bugs.webkit.org/show_bug.cgi?id=137806
572
573         Reviewed by Sam Weinig.
574
575         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
576         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
577         to disable font autosizing.
578         
579         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
580         test controller to set platform-specific prefs.
581
582         * WebKitTestRunner/TestController.cpp:
583         (WTR::TestController::resetPreferencesToConsistentValues):
584         (WTR::TestController::platformResetPreferencesToConsistentValues):
585         * WebKitTestRunner/TestController.h:
586         * WebKitTestRunner/ios/TestControllerIOS.mm:
587         (WTR::TestController::platformResetPreferencesToConsistentValues):
588         * WebKitTestRunner/mac/TestControllerMac.mm:
589         (WTR::TestController::platformResetPreferencesToConsistentValues):
590
591 2014-10-16  Dan Bernstein  <mitz@apple.com>
592
593         OSObjectPtr is missing leakRef()
594         https://bugs.webkit.org/show_bug.cgi?id=137798
595
596         Reviewed by Sam Weinig.
597
598         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
599         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
600
601 2014-10-16  Lucas Forschler  <lforschler@apple.com>
602
603         Update target platform to remove Leopard, Snow Leopard, Lion.
604         Add Yosemite. 
605         
606         Unreviewed.
607
608         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
609         (_should_file_trigger_build):
610
611 2014-10-16  David Kilzer  <ddkilzer@apple.com>
612
613         commit-queue: fails to replace OO-PS! with reviewer name
614         <http://webkit.org/b/137795>
615
616         Reviewed by Alexey Proskuryakov.
617
618         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
619         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
620         email addresses to unauthenticated page loads, so we must always
621         authenticate before getting bug data so we get full email
622         addresses.
623
624 2014-10-16  David Kilzer  <ddkilzer@apple.com>
625
626         commit-queue: fails to close bugs after successfully landing patches
627         <http://webkit.org/b/137794>
628
629         Reviewed by Alexey Proskuryakov.
630
631         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
632         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
633         tell Mechanize to use the second <textarea> on the page with
634         name="comment".
635
636 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
637
638         [Win] Update DRT to match Mac Logic
639         https://bugs.webkit.org/show_bug.cgi?id=137787
640
641         Reviewed by Dean Jackson.
642
643         * DumpRenderTree/win/DumpRenderTree.cpp:
644         (initialize): 0 -> nullptr
645         (runTest): Initialize MSG structure before using.
646         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
647         Also, cleanly shut down COM when exiting.
648         * DumpRenderTree/win/FrameLoadDelegate.cpp:
649         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
650         header and add printf to match Mac.
651         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
652         * DumpRenderTree/win/FrameLoadDelegate.h:
653         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
654         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
655         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
656         (isLocalhost): Added.
657         (hostIsUsedBySomeTestsToGenerateError): Added.
658         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
659         of certain error and redirect host names.
660         * DumpRenderTree/win/UIDelegate.cpp:
661         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
662         anything should be output to the console. This modifies behavior to match the Mac.
663         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
664         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
665         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
666         (UIDelegate::webViewAddMessageToConsole): Ditto.
667         * WinLauncher/PageLoadTestClient.cpp:
668         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
669         added last week.
670
671 2014-10-16  Commit Queue  <commit-queue@webkit.org>
672
673         Unreviewed, rolling out r174754.
674         https://bugs.webkit.org/show_bug.cgi?id=137789
675
676         Speculative fix for Windows test was ineffective. (Requested
677         by rfong on #webkit).
678
679         Reverted changeset:
680
681         "[Windows] Add some more logging to debug Windows test
682         issues."
683         http://trac.webkit.org/changeset/174754
684
685 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
686
687         Unreviewed, add myself to CoordinatedGraphics watchers.
688
689         * Scripts/webkitpy/common/config/watchlist:
690
691 2014-10-15  Roger Fong  <roger_fong@apple.com>
692
693         [Windows] Speculative Windows test fix.
694
695         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
696
697 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
698
699         import-w3c-test rewrites relative src paths in ref files incorrectly
700         https://bugs.webkit.org/show_bug.cgi?id=137586
701
702         This patch fixes a bug in test_converter.py where src paths were getting 
703         rewritten as ../../some-path instead of <script src="../../some-path>". 
704         It also adds support for rewriting src paths in style  elements, which was 
705         missing before and it adds tests for this case.
706
707         Reviewed by Bem Jones-Bey.
708
709         * Scripts/webkitpy/w3c/test_converter.py:
710         (_W3CTestConverter.convert_attributes_if_needed):
711         * Scripts/webkitpy/w3c/test_converter_unittest.py:
712         (test_convert_attributes_if_needed):
713         (verify_reference_relative_paths):
714
715 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
716
717         Add --json flag to test-webkitpy to emit JSON formatted test results
718         to stdout
719         https://bugs.webkit.org/show_bug.cgi?id=137353
720
721         Reviewed by Daniel Bates.
722
723         * Scripts/webkitpy/port/server_process_unittest.py:
724         Adds the read method to MockFile to allow the stdout of test_webkitpy
725         to be redirected without causing erroneous test failures.
726         In particular,
727         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
728         and
729         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
730         because when redirecting to a file, the
731         _wait_for_data_and_update_buffers_using_select method in 
732         server_process.py will find that there is a read file descriptor in
733         its call to select.select, which eventually leads to it calling read()
734         on the MockFile object.
735         (MockFile.read):
736         * Scripts/webkitpy/test/main.py:
737         Adds the _print_results_as_json method and the --json flag which
738         determines whether _print_results_as_json will get called.
739         (Tester._parse_args):
740         (Tester._print_results_as_json):
741         (Tester._print_results_as_json.result_dict_from_tuple):
742         (Tester._run_tests):
743
744 2014-10-13  David Farler  <dfarler@apple.com>
745
746         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
747         https://bugs.webkit.org/show_bug.cgi?id=137662
748
749         Reviewed by Darin Adler.
750
751         The layout test harness can close LayoutTestRelay's subprocess
752         stdout and stderr in the case of a timeout or if a run is
753         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
754         finds that no one is listening to its stdout/stderr (broken
755         pipe), then just exit(1), there is nothing to report.
756
757         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
758         (-[LTRelayController didReceiveStdoutData:]):
759         Add @try/@catch for NSFileHandleOperationException.
760         (-[LTRelayController didReceiveStderrData:]):
761         Add @try/@catch for NSFileHandleOperationException.
762
763 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
764
765         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
766         https://bugs.webkit.org/show_bug.cgi?id=137060
767
768         Reviewed by Philippe Normand.
769
770         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
771
772         * MiniBrowser/gtk/BrowserWindow.c:
773         (zoomInCallback):
774         (zoomOutCallback):
775         (defaultZoomCallback): Callback for default zoom keyboard support.
776         (browser_window_init):
777
778 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
779
780         [Mac] DRT stderr logging after the test completes gets attributed to the next test
781
782         Reviewed by Alexey Proskuryakov.
783         
784         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
785         logging to stderr to get associated with the next test.
786         
787         Fix by logging #EOF to stderr later, after we've completely finished with this test.
788
789         * DumpRenderTree/mac/DumpRenderTree.mm:
790         (dumpTestResults):
791         (runTest):
792
793 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
796
797         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
798
799 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
800
801         [cmake] Fix the make build after r174683
802         https://bugs.webkit.org/show_bug.cgi?id=137703
803
804         Reviewed by Martin Robinson.
805
806         * Scripts/webkitdirs.pm:
807         (buildCMakeGeneratedProject):
808
809 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
810
811         Adding myself to the watchlist to CachedFont
812
813         Unreviewed.
814
815         * Scripts/webkitpy/common/config/watchlist:
816
817 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
818
819         [EFL][GTK] Make it possible to get verbose output with ninja
820         https://bugs.webkit.org/show_bug.cgi?id=137606
821
822         Reviewed by Csaba Osztrogonác.
823
824         * Scripts/webkitdirs.pm:
825         (buildCMakeGeneratedProject):
826
827 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
828
829         [EFL] Make it possible to use ninja for EFL build too
830         https://bugs.webkit.org/show_bug.cgi?id=137605
831
832         Reviewed by Csaba Osztrogonác.
833
834         * Scripts/webkitdirs.pm:
835         (generateBuildSystemFromCMakeProject):
836         * efl/install-dependencies:
837
838 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
839
840         [GTK] Minibrowser : Add home buton and keyboard support for home page load
841         https://bugs.webkit.org/show_bug.cgi?id=137486
842
843         Reviewed by Philippe Normand.
844
845         * MiniBrowser/gtk/BrowserWindow.c:
846         (loadHomePage): Callback for home page load.
847         (browser_window_init):
848         * MiniBrowser/gtk/BrowserWindow.h:
849         * MiniBrowser/gtk/main.c:
850         (main):
851
852 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
853
854         import-w3c-tests doesn't prefix property values
855         https://bugs.webkit.org/show_bug.cgi?id=137600
856
857         Reviewed by Bem Jones-Bey.
858
859         Some property values are prefixed in WebKit. Modified the W3C import
860         script in order to prefix property values and not only properties.
861         The patch re-uses most of the already existent logic to prefix
862         properties.
863
864         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
865         from CSSValueKeywords.in and adapt converter to modify both properties
866         and property values.
867         (convert_for_webkit):
868         (_W3CTestConverter.__init__):
869         (_W3CTestConverter.output):
870         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
871         (_W3CTestConverter):
872         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
873         (_W3CTestConverter.add_webkit_prefix_following_regex):
874         (_W3CTestConverter.convert_reference_relpaths):
875         (_W3CTestConverter.convert_style_data):
876         (_W3CTestConverter.convert_attributes_if_needed):
877         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
878         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
879         include checks for property values too.
880         (W3CTestConverterTest.test_read_prefixed_property_list):
881         (verify_no_conversion_happened):
882         (verify_prefixed_properties):
883         (verify_prefixed_property_values):
884         (generate_test_content_properties_and_values):
885         (generate_test_content):
886         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
887         prefixed property values and inform about them.
888         (TestImporter.import_tests):
889         (TestImporter.write_import_log):
890
891 2014-10-13  Jer Noble  <jer.noble@apple.com>
892
893         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
894         https://bugs.webkit.org/show_bug.cgi?id=137533
895
896         Reviewed by Andy Estes.
897
898         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
899
900         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
901         (TestWebKitAPI::isMSEEnabledCallback):
902         (TestWebKitAPI::TEST):
903
904 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
905
906         [Win] Implement a page load profiling tool
907         https://bugs.webkit.org/show_bug.cgi?id=137673
908
909         Reviewed by Dean Jackson.
910
911         Add a tool to capture and summarize page load statistics.
912
913         * WinLauncher/Common.cpp:
914         (parseCommandLine): Move from WinMain.cpp so that it can
915         be shared with internal tools.
916         * WinLauncher/PageLoadTestClient.cpp: Added.
917         (PageLoadTestClient::PageLoadTestClient):
918         (PageLoadTestClient::pageLoadStartedAtTime):
919         (PageLoadTestClient::didStartProvisionalLoad):
920         (PageLoadTestClient::didCommitLoad):
921         (PageLoadTestClient::didFirstLayoutForMainFrame):
922         (PageLoadTestClient::didHandleOnLoadEvents):
923         (PageLoadTestClient::didFinishLoad):
924         (PageLoadTestClient::didFailLoad):
925         (PageLoadTestClient::didInitiateResourceLoad):
926         (PageLoadTestClient::didEndResourceLoad):
927         (PageLoadTestClient::pageLoadEndedAtTime):
928         (PageLoadTestClient::endPageLoad):
929         (PageLoadTestClient::clearPageLoadState):
930         (PageLoadTestClient::shouldConsiderPageLoadEnded):
931         (PageLoadTestClient::maybeEndPageLoadSoon):
932         (PageLoadTestClient::setPageURL):
933         (PageLoadTestClient::dumpRunStatistics):
934         * WinLauncher/PrintWebUIDelegate.cpp:
935         (PrintWebUIDelegate::createWebViewWithRequest): Handle
936         nullptr URL properly.
937         * WinLauncher/ResourceLoadDelegate.cpp: Added.
938         (ResourceLoadDelegate::QueryInterface):
939         (ResourceLoadDelegate::AddRef):
940         (ResourceLoadDelegate::Release):
941         (ResourceLoadDelegate::identifierForInitialRequest):
942         (ResourceLoadDelegate::willSendRequest):
943         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
944         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
945         (ResourceLoadDelegate::didReceiveResponse):
946         (ResourceLoadDelegate::didReceiveContentLength):
947         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
948         (ResourceLoadDelegate::didFailLoadingWithError):
949         (ResourceLoadDelegate::plugInFailedWithError):
950         * WinLauncher/ResourceLoadDelegate.h: Added.
951         (ResourceLoadDelegate::ResourceLoadDelegate):
952         * WinLauncher/WinLauncher.cpp:
953         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
954         page loading statistics.
955         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
956         and set private load delegate state.
957         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
958         that sets the view's resource load delegate.
959         (WinLauncher::loadURL): If no URL is passed, load the test document.
960         * WinLauncher/WinLauncher.h:
961         (WinLauncher::pageLoadTestClient):
962         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
963         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
964         * WinLauncher/WinLauncherWebHost.cpp:
965         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
966         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
967         it could be used from other source files.
968         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
969         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
970         (WinLauncherWebHost::didFailLoadWithError): Ditto.
971         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
972         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
973         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
974         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
975         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
976         * WinLauncher/WinLauncherWebHost.h:
977         * WinLauncher/WinMain.cpp:
978         (wWinMain): Create and use new delegates for gathering page load data.
979         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
980
981 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
982
983         Improve the test image diffs page
984         https://bugs.webkit.org/show_bug.cgi?id=137674
985
986         Reviewed by Alexey Proskuryakov.
987         
988         Don't treat the input file as a format string, otherwise we have to escape special
989         characters. Just do a couple of replaces.
990
991         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
992         (TestResultWriter.write_image_diff_files):
993
994 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
995
996         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
997         https://bugs.webkit.org/show_bug.cgi?id=137659
998
999         Reviewed by Martin Robinson.
1000
1001         * Scripts/webkitpy/port/xvfbdriver.py:
1002         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
1003
1004 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
1005
1006         Add more detailed wait time information to EWS metrics
1007         https://bugs.webkit.org/show_bug.cgi?id=137649
1008
1009         Reviewed by Daniel Bates.
1010
1011         Added average and worst time (we used to only have median), and also a percentage
1012         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
1013
1014         There is always some wait due to the polling nature of the queues, which is well understood
1015         and doesn't need to be measured. What needs to be measured is whether there is enough
1016         bot machines to process patches as soon as they are submitted.
1017
1018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1019         (Analyzer.prototype._analyzeBubblePerformance):
1020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1021         (MetricsBubbleView.prototype._update):
1022
1023 2014-10-11  Jer Noble  <jer.noble@apple.com>
1024
1025         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1026         https://bugs.webkit.org/show_bug.cgi?id=137533
1027
1028         Reviewed by Darin Adler.
1029
1030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1031         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1032         (TestWebKitAPI::TEST):
1033         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
1034         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
1035
1036 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1037
1038         iOS DRT snapshots are limited to the page visible area
1039         https://bugs.webkit.org/show_bug.cgi?id=137650
1040
1041         Reviewed by Daniel Bates.
1042         
1043         LegacyTileCache drawing was limited to the window's visible area, found by
1044         crawling up the layer hierarchy to the root layer. This caused test snapshots to
1045         be missing non-composited content outside the iPhone visible area, which hinders
1046         testing.
1047         
1048         Fix by adding a test-only mode where the window visible area is the entire window.
1049         
1050         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1051         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
1052         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1053         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
1054         for the DRT window.
1055         
1056
1057 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
1058
1059         Page not fully rendered in iOS DRT snapshots
1060         https://bugs.webkit.org/show_bug.cgi?id=137638
1061
1062         Reviewed by Tim Horton.
1063         
1064         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
1065         to ensure that the page has laid out and is rendered by the time we take
1066         the snapshot.
1067
1068         * DumpRenderTree/mac/DumpRenderTree.mm:
1069         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
1070         (-[DumpRenderTree _webThreadInvoked]): Moved.
1071         (-[DumpRenderTree _waitForWebThreadThenDump]):
1072         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
1073         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
1074         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
1075         relies on dispatch_async too, and the inner block won't complete until the outer block
1076         has completed.
1077         (dumpTestResults): Move the guts of dump() here.
1078         (runTest): Whitespace.
1079
1080 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
1081
1082         Adding svn:ignore so that .pyc files don't show up as new.
1083
1084         * Scripts/webkitpy/xcode: Added property svn:ignore.
1085
1086 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
1087
1088         [EFL] Introduce EWebKit_Extension
1089         https://bugs.webkit.org/show_bug.cgi?id=134921
1090
1091         Reviewed by Gyuyoung Kim.
1092
1093         * MiniBrowser/efl/main.c: Added x option to test extension path.
1094         (window_create):
1095         (elm_main):
1096         * Scripts/webkitpy/common/config/watchlist:
1097         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1098         * Scripts/webkitpy/style/checker.py:
1099         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1100
1101 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
1102
1103         After r174628 we send the test process a SIGTERM before the SIGKILL.
1104
1105         * Scripts/webkitpy/common/system/executive_unittest.py:
1106         (ExecutiveTest.serial_test_kill_process):
1107
1108 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
1109
1110         [EFL] Enable WebP support.
1111         https://bugs.webkit.org/show_bug.cgi?id=136156
1112
1113         Reviewed by Gyuyoung Kim.
1114
1115         Include libwebp-dev package to support WebP for WK2 Efl.
1116
1117         * efl/install-dependencies:
1118
1119 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1120
1121         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
1122         https://bugs.webkit.org/show_bug.cgi?id=137485
1123
1124         Reviewed by Sergio Villar Senin.
1125
1126         Update GMainLoopSource tests. Most of the tests are now run twice,
1127         first with a GMainLoopSource and then with a
1128         GThreadSafeMainLoopSource, since both should have the same
1129         behaviour. The threading test uses GThreadSafeMainLoopSource and
1130         the delete on destroy test uses GMainLoopSource. The tests
1131         themselves haven't changed, since there's no change in behaviour.
1132
1133         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1134         (TestWebKitAPI::GMainLoopSourceTest::source):
1135         (TestWebKitAPI::basicRescheduling):
1136         (TestWebKitAPI::TEST):
1137         (TestWebKitAPI::reentrantRescheduling):
1138         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1139         (TestWebKitAPI::basicDestroyCallbacks):
1140         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1141         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1142
1143 2014-10-10  Dana Burkart  <dburkart@apple.com>
1144
1145         Fix fat-fingered function name in git-add-reviewer.
1146
1147         Unreviewed.
1148
1149         * Scripts/git-add-reviewer:
1150         (getConfigValue):
1151
1152 2014-10-10  David Farler  <dfarler@apple.com>
1153
1154         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
1155         https://bugs.webkit.org/show_bug.cgi?id=137528
1156
1157         Reviewed by Simon Fraser.
1158
1159         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
1160         and SIGKILL the paired simulator app before exiting cleanly.
1161
1162         webkitpy only uses SIGKILL to kill processes which you cannot
1163         catch. Send SIGTERM to the process and give it chance to do
1164         its thing before sending SIGKILL. Sending a SIGKILL to an already
1165         dead PID is safe.
1166
1167         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
1168         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1169         (-[LTRelayController finish]):
1170         * LayoutTestRelay/LayoutTestRelay/main.m:
1171         (receivedSignal):
1172         (main):
1173
1174 2014-10-10  David Farler  <dfarler@apple.com>
1175
1176         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
1177         https://bugs.webkit.org/show_bug.cgi?id=137527
1178
1179         Reviewed by Simon Fraser.
1180
1181         NSFileHandle doesn't notify of EOF in its readability handler.
1182         Use a dispatch_source_t and an event handler that is called when reading is possible.
1183         In the handler block, do a run-of-the-mill read(2) from standard input and
1184         detect EOF in the usual way by checking that zero bytes were read.
1185
1186         Once an EOF is received, the FIFOs are disconnected, the simulator app
1187         is killed, and the relay exits with status 0.
1188
1189         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1190         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1191         (-[LTRelayController didDisconnect]):
1192         (-[LTRelayController didConnect]):
1193         (-[LTRelayController launchApp]):
1194         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
1195         confusion with this new dispatch source, called "standardInputDispatchSource".
1196         (-[LTRelayController finish]): Added.
1197         (-[LTRelayController readFileHandle:]): Deleted.
1198
1199 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1200
1201         [EFL] Crash on facebook.com
1202         https://bugs.webkit.org/show_bug.cgi?id=137562
1203
1204         Reviewed by Chris Dumez.
1205
1206         Crash occurs on the facebook.com when the webview is resized
1207         after the <select> item is clicked but no item is chosen.
1208         This crash is just caused by the reference of invalidated variable.
1209         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
1210         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
1211         on MiniBrowser is called.
1212         As a result, just set ewk_menu to NULL in order to prevent crash condition.
1213
1214         * MiniBrowser/efl/main.c:
1215         (on_popup_menu_hide):
1216
1217 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1218
1219         A small wording change for clarity.
1220
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1222         (MetricsBubbleView.prototype._update):
1223
1224 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1225
1226         Dashboard metrics page should have EWS statistics
1227         https://bugs.webkit.org/show_bug.cgi?id=137626
1228
1229         Reviewed by Ryosuke Niwa.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1232         (BubbleQueue): Put shortName in the object, so that it's actually useful.
1233
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1235         (BubbleQueueServer): Re-ordered queues to match bubble order.
1236         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
1237         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
1238
1239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1240         Added analysis for bubble queues.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
1243
1244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1245         (buildBubbleQueuesTable): Build the UI.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1248         Added JS sources to load.
1249
1250         * QueueStatusServer/app.yaml: To update app version.
1251
1252         * QueueStatusServer/handlers/processingtimesjson.py: Added.
1253
1254         * QueueStatusServer/main.py: Added a handler for processing-times-json.
1255
1256 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1257
1258         REGRESSION: Commit queue doesn't process rollouts
1259         https://bugs.webkit.org/show_bug.cgi?id=137623
1260
1261         Reviewed by Tim Horton.
1262
1263         * QueueStatusServer/app.yaml:
1264         * QueueStatusServer/handlers/updateworkitems.py:
1265         (UpdateWorkItems._work_items_from_request):
1266
1267 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
1268
1269         Fix syntax error after r174601.
1270
1271         * Scripts/run-javascriptcore-tests:
1272
1273 2014-10-10  Michael Saboff  <msaboff@apple.com>
1274
1275         Add ability to select tarfile name in run-jsc-stress-tests
1276         https://bugs.webkit.org/show_bug.cgi?id=137614
1277
1278         Reviewed by Mark Hahnenberg.
1279
1280         Added optional file name argument to the --tarball option.  
1281
1282         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
1283         extra test given after the options wont be used for the optional tarball file name.
1284         * Scripts/run-jsc-stress-tests:
1285
1286 2014-10-10  Chris Dumez  <cdumez@apple.com>
1287
1288         Unreviewed, update my information in contributors.json
1289
1290         Use my preferred first name and update my expertise areas.
1291
1292         * Scripts/webkitpy/common/config/contributors.json:
1293
1294 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
1295
1296         Fix perl scripts to run with env on Linux
1297         https://bugs.webkit.org/show_bug.cgi?id=137601
1298
1299         Reviewed by Csaba Osztrogonác.
1300
1301         Use of arguments in #! is nonstandard and does not behave the same on
1302         different systems. Linux would look for an executable named "perl -w" 
1303         "use warnings;" does the same things in a more portable way.
1304
1305         * Scripts/commit-log-editor:
1306         * Scripts/num-cpus:
1307         * Scripts/prepare-ChangeLog:
1308         * Scripts/run-launcher:
1309         * Scripts/svn-create-patch:
1310
1311 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1312
1313         [jhbuild] We should be able to disable wiping on configuration change
1314         https://bugs.webkit.org/show_bug.cgi?id=137446
1315
1316         Reviewed by Csaba Osztrogonác.
1317
1318         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
1319         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
1320         or passing --no-wipe-on-change command line option.
1321
1322         * Scripts/update-webkit-libs-jhbuild:
1323
1324 2014-10-09  Andy Estes  <aestes@apple.com>
1325
1326         Teach webkitpy about OS X Yosemite
1327         https://bugs.webkit.org/show_bug.cgi?id=137585
1328
1329         Reviewed by Simon Fraser.
1330
1331         * Scripts/webkitpy/common/system/platforminfo.py:
1332         (PlatformInfo._determine_mac_version):
1333         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1334         (TestPlatformInfo.test_os_version):
1335         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1336         (TestExpectationParser):
1337         * Scripts/webkitpy/port/builders.py:
1338         * Scripts/webkitpy/port/mac.py:
1339         (MacPort):
1340         * Scripts/webkitpy/port/mac_unittest.py:
1341         (test_versions):
1342         (test_baseline_search_path):
1343         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1344         (TestRebaselineTest.test_baseline_directory):
1345         (TestRebaselineExpectations.test_rebaseline_expectations):
1346
1347 2014-10-09  Dana Burkart  <dburkart@apple.com>
1348
1349         Add Mac OS Yosemite dashboard support.
1350
1351         Rubber-stamped by Lucas Forschler.
1352
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
1354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
1355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1358
1359 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
1360
1361         Add Babak to contributors.json and add historical email addresses for some contributors
1362         https://bugs.webkit.org/show_bug.cgi?id=137546
1363
1364         Reviewed by Christophe Dumez.
1365
1366         contributors.json is used to analyze historical commit data and change logs.
1367
1368         Add back historical email addresses for some contributors and also add Babak (Shafiei).
1369
1370         * Scripts/webkitpy/common/config/contributors.json:
1371
1372 2014-10-09  Lucas Forschler  <lforschler@apple.com>
1373
1374         Add Mac OS Yosemite webkit build infrastructure.
1375         
1376         This patch adds 15 bots to our build.webkit.org configuration.
1377         We are matching the current Mavericks machines 1:1.
1378         
1379         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
1380         
1381         Reviewed by Matt Hanson.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/config.json:
1384
1385 2014-10-09  Dana Burkart  <dburkart@apple.com>
1386
1387         Don't use backticks when running commands, as we run into sh-related
1388         interpolation issues. Also, fix our usage of system() to properly
1389         retrieve the status code.
1390         https://bugs.webkit.org/show_bug.cgi?id=137541
1391
1392         Reviewed by Darin Adler.
1393
1394         * Scripts/git-add-reviewer:
1395         (interactive):
1396         (nonInteractive):
1397         (requireCleanWorkTree):
1398         (cherryPick):
1399         (commit):
1400         (addReviewerToFile):
1401         (head):
1402         (isAncestor):
1403         (toCommit):
1404         (changeLogsForCommit):
1405         (resetToCommit):
1406         (getConfigValue):
1407         (runCommandWithOutput):
1408
1409 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1410
1411         Add a WebKit1 preference for selection services
1412         https://bugs.webkit.org/show_bug.cgi?id=137498
1413         <rdar://problem/18572699>
1414
1415         Reviewed by Simon Fraser.
1416
1417         * MiniBrowser/mac/WK1BrowserWindowController.m:
1418         (-[WK1BrowserWindowController awakeFromNib]):
1419         Turn on image and selection services in the Legacy WebKit MiniBrowser.
1420
1421 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
1422
1423         Get the patch scripts running on Haiku
1424         https://bugs.webkit.org/show_bug.cgi?id=137559
1425
1426         Reviewed by Benjamin Poulain.
1427
1428         Use /usr/bin/env instead of hardcoding path to perl.
1429         Declare haiku platform in platforminfo.py to avoid check-webkit-style
1430         failure.
1431
1432         * Scripts/commit-log-editor:
1433         * Scripts/num-cpus:
1434         * Scripts/prepare-ChangeLog:
1435         * Scripts/run-launcher:
1436         * Scripts/svn-create-patch:
1437         * Scripts/webkitpy/common/system/platforminfo.py:
1438         (PlatformInfo._determine_os_name):
1439
1440 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
1441
1442         StyleQueue should throw a PatchIsNotValid exception to achieve
1443         consistency with CommitQueue and EWS
1444         https://bugs.webkit.org/show_bug.cgi?id=137500
1445
1446         Reviewed by Alexey Proskuryakov.
1447
1448         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1449         Adds a call to validate() in run().
1450         (StyleQueueTask.run):
1451         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1452         Adds a return False in the patch is not valid exception statement.
1453         (AbstractEarlyWarningSystem.review_patch):
1454         * Scripts/webkitpy/tool/commands/queues.py:
1455         Adds a return False in the patch is not valid exception statement in
1456         commit queue, and adds an except statement to catch PatchIsNotValid
1457         exceptions in style queue.
1458         (CommitQueue.process_work_item):
1459         (StyleQueue.review_patch):
1460
1461 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1462
1463         Race condition with WebKitWebView:is-loading after starting page load
1464         https://bugs.webkit.org/show_bug.cgi?id=136692
1465
1466         Reviewed by Gustavo Noronha Silva.
1467
1468         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1469         (loadChangedCallback): Only check is-loading is false when load
1470         has finished if the load didn't fail due to a cancellation.
1471         (loadFailedCallback): Only check is-loading is false if the load
1472         didn't fail due to a cancellation.
1473         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1474         (WebViewTest::loadURI): Check is-loading is true and active URI is
1475         the requested one rigth after requesting the load.
1476         (WebViewTest::loadHtml): Ditto.
1477         (WebViewTest::loadPlainText): Ditto.
1478         (WebViewTest::loadBytes): Ditto.
1479         (WebViewTest::loadRequest): Ditto.
1480         (WebViewTest::loadAlternateHTML): Ditto.
1481         (WebViewTest::goBack): Ditto.
1482         (WebViewTest::goForward): Ditto.
1483         (WebViewTest::goToBackForwardListItem): Ditto.
1484
1485 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
1486
1487         [Win] Resolve various static analyzer warnings in Tools.
1488         https://bugs.webkit.org/show_bug.cgi?id=137534
1489
1490         Reviewed by Dean Jackson.
1491
1492         * DumpRenderTree/cg/ImageDiffCG.cpp:
1493         (main): User proper printf specifiers.
1494         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1495         (AccessibilityUIElement::childrenCount): Handle possibility that
1496         gcc_accChildCount returns with an error.
1497         (accessibilityState): Ditto for gcc_accState.
1498         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1499         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
1500         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
1501         be treated as such.
1502         * DumpRenderTree/win/DumpRenderTree.cpp:
1503         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
1504         by comparing an unsigned value as being greater-than zero.
1505         * DumpRenderTree/win/EditingDelegate.cpp:
1506         (dump): Pass proper character pointer type to printf.
1507         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
1508         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1509         (EditingDelegate::shouldInsertNode): Ditto.
1510         (EditingDelegate::shouldInsertText): Ditto.
1511         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1512         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1513         (EditingDelegate::shouldApplyStyle): Ditto.
1514         * DumpRenderTree/win/EventSender.cpp:
1515         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
1516         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
1517         system headers.
1518         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
1519         from CreateDIBSection.
1520         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
1521         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
1522         older versions of MSVC we no longer support.
1523         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
1524         for 64-bit builds.
1525         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
1526         * TestWebKitAPI/TestsController.h: Ditto.
1527         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
1528         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
1529         performing bitwise | before the comparison is done.
1530
1531 2014-10-08  Ada Chan  <adachan@apple.com>
1532
1533         Add a test for WKPageIsPlayingAudio().
1534         https://bugs.webkit.org/show_bug.cgi?id=137048
1535
1536         Reviewed by Darin Adler.
1537
1538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1539         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
1540         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
1541         (TestWebKitAPI::nullJavaScriptCallback):
1542         (TestWebKitAPI::didFinishLoadForFrame):
1543         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
1544         (TestWebKitAPI::setUpClients):
1545         (TestWebKitAPI::TEST):
1546         This test loads a page with a video in it. When the page is loaded, we first check that
1547         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
1548         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
1549         now returns true for the page.
1550         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
1551         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
1552         This is a video copied from LayoutTests/media/content.
1553
1554 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
1555
1556         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
1557         https://bugs.webkit.org/show_bug.cgi?id=137516
1558
1559         Reviewed by Alexey Proskuryakov.
1560
1561         * Scripts/webkitpy/thirdparty/__init__.py:
1562         (AutoinstallImportHook._install_irc):
1563
1564 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1565
1566         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
1567         https://bugs.webkit.org/show_bug.cgi?id=137520
1568
1569         Reviewed by Philippe Normand.
1570
1571         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
1572         For other distributions, we are already installing libjpeg-turbo.
1573         So, do the same for Debian and derivatives.
1574
1575         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
1576
1577 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1578
1579         [webkitpy] Add back the workaround to replace ZipFile.extractall()
1580         https://bugs.webkit.org/show_bug.cgi?id=137519
1581
1582         Reviewed by Csaba Osztrogonác.
1583
1584         It was removed by <http://trac.webkit.org/changeset/174266>,
1585         because the comment stated it is a workaround for buggy python
1586         2.6.1 which shipped on Snow Leopard. But it turned out the bug
1587         is still valid with python 2.7 shipped on the latest Ubuntu
1588         (12.04 and 14.04) and OS X 10.9.
1589
1590         * Scripts/webkitpy/common/system/autoinstall.py:
1591         (AutoInstaller):
1592         (AutoInstaller._extract_all):
1593         (AutoInstaller._unzip):
1594
1595 2014-10-08  Commit Queue  <commit-queue@webkit.org>
1596
1597         Unreviewed, rolling out r174335.
1598         https://bugs.webkit.org/show_bug.cgi?id=137515
1599
1600         It broke EFL layout test totally (Requested by gyuyoung on
1601         #webkit).
1602
1603         Reverted changeset:
1604
1605         "[EFL] Introduce EWebKit_Extension"
1606         https://bugs.webkit.org/show_bug.cgi?id=134921
1607         http://trac.webkit.org/changeset/174335
1608
1609 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1610
1611         [GTK] Make forwarding headers generation depend on source code
1612         https://bugs.webkit.org/show_bug.cgi?id=137394
1613
1614         Reviewed by Philippe Normand.
1615
1616         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
1617         * TestWebKitAPI/PlatformGTK.cmake: Only run
1618         generate-forwarding-headers.pl when source code changes.
1619         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1620
1621 2014-10-07  Tanay C  <tanay.c@samsung.com>
1622
1623         Remove build warnings in Hashmap API tests
1624         https://bugs.webkit.org/show_bug.cgi?id=137484
1625
1626         Reviewed by Darin Adler.
1627
1628         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1629         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
1630
1631 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
1632
1633         Commit queue doesn't drop obsolete patches sometimes
1634         https://bugs.webkit.org/show_bug.cgi?id=137460
1635
1636         Reviewed by Alexey Proskuryakov.
1637
1638         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1639         Adds another test patch for use in queues_unittest.py.
1640         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1641         (MockBugzilla):
1642         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1643         Raises a PatchIsNotValid exception in the case of validate() returning
1644         false.
1645         (CommitQueueTask.run):
1646         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1647         Raises a PatchIsNotValid exception in the case of validate() returning
1648         false.
1649         (EarlyWarningSystemTask.run):
1650         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1651         Defines PatchIsNotValid exception. 
1652         (PatchIsNotValid):
1653         (PatchIsNotValid.__init__):
1654         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1655         Remove call to validate() and instead catches the PatchIsNotValid
1656         exception.
1657         (AbstractEarlyWarningSystem.review_patch):
1658         * Scripts/webkitpy/tool/commands/queues.py:
1659         Adds logic to catch the PatchIsNotValid exception.
1660         (CommitQueue.process_work_item):
1661         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1662         Adds the test_non_valid_patch test to ensure that invalid patches are
1663         handled properly, and don't just result in indefinite spinning.
1664         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1665         (test_non_valid_patch):
1666
1667 2014-10-07  Daniel Bates  <dabates@apple.com>
1668
1669         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
1670         https://bugs.webkit.org/show_bug.cgi?id=137499
1671
1672         Reviewed by Simon Fraser.
1673
1674         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
1675         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
1676         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
1677         bit simulator builds of iOS WebKit.
1678
1679         * Scripts/webkitpy/port/ios.py:
1680         (IOSSimulatorPort._generate_all_test_configurations):
1681
1682 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1683
1684         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
1685         https://bugs.webkit.org/show_bug.cgi?id=137482
1686
1687         Reviewed by Martin Robinson.
1688
1689         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
1690
1691 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1692
1693         [SOUP] TLS errors should take precedence over HTTP authentication
1694         https://bugs.webkit.org/show_bug.cgi?id=137300
1695
1696         Reviewed by Sergio Villar Senin.
1697
1698         Add a test case to check that authenticate signal is not emitted
1699         in case of TLS errors, and the load fails instead.
1700
1701         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1702         (webViewAuthenticationCallback):
1703         (testTLSErrorsHTTPAuth):
1704         (httpsServerCallback):
1705         (beforeAll):
1706
1707 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
1708
1709         Make webkit-patch find-users useful
1710         https://bugs.webkit.org/show_bug.cgi?id=137475
1711
1712         Reviewed by Alexey Proskuryakov.
1713
1714         Make find-users use the CommitterList instead of accessing Bugzilla.
1715
1716         This essentially exposes the same functionality as webkitbot's whois command.
1717
1718         * Scripts/webkitpy/tool/commands/findusers.py:
1719         (FindUsers.execute):
1720
1721 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
1722
1723         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
1724         https://bugs.webkit.org/show_bug.cgi?id=137289
1725
1726         Unreviewed build fix.
1727
1728         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1729         (AccessibilityUIElement::getChildrenWithRange):
1730
1731 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1732
1733         build.webkit.org/dashboard: Add commit queue
1734         https://bugs.webkit.org/show_bug.cgi?id=137462
1735
1736         Reviewed by Tim Horton.
1737
1738         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
1739         Style queue is still invisible, as it doesn't have an associated platform, and also
1740         we never have problems with it anyway, so it's not worth watching.
1741
1742         The UI now allows for adding more bots to the Other column (such as leaks bot).
1743         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
1744         sources of data in a cell.
1745
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
1747         (BubbleQueue):
1748         (BubbleQueue.prototype.get statusPageURL):
1749         (BubbleQueue.prototype.update):
1750         (BubbleQueue.prototype.loadDetailedStatus):
1751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
1752         (BubbleQueueServer):
1753         (BubbleQueueServer.prototype.jsonQueueLengthURL):
1754         (BubbleQueueServer.prototype.jsonQueueStatusURL):
1755         (BubbleQueueServer.prototype.queueStatusURL):
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
1757         (BubbleQueueView):
1758         (BubbleQueueView.prototype.update.appendQueue):
1759         (BubbleQueueView.prototype.update):
1760         (BubbleQueueView.prototype._addQueueHeadingToPopover):
1761         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1762         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
1764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
1765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1769         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
1770         (.bubble-server-popover .latest-status-no-link):
1771         (.bubble-server-popover .bot-status-description):
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1773
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1775         (buildAggregateTable):
1776         (buildQueuesTable):
1777         Removed dysfunctional support for EWS for now. It will be different.
1778
1779 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1780
1781         One more case of incorrect comparison in recordpatchevent.py
1782         https://bugs.webkit.org/show_bug.cgi?id=137459
1783
1784         Reviewed by Tim Horton.
1785
1786         * QueueStatusServer/app.yaml:
1787         * QueueStatusServer/loggers/recordpatchevent.py:
1788         (RecordPatchEvent.started):
1789
1790 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1791
1792         webkit-queues PatchLog is incorrect for patches that took less than a second
1793         https://bugs.webkit.org/show_bug.cgi?id=137453
1794
1795         Reviewed by Tim Horton.
1796
1797         * QueueStatusServer/app.yaml: Updated app version.
1798
1799         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
1800         Don't bail out for patches that took 0 seconds to process (as frequently happens
1801         when a patch is obsolete).
1802
1803 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
1804
1805         EWS bubble hover shows wrong timestamps
1806         https://bugs.webkit.org/show_bug.cgi?id=137252
1807
1808         Reviewed by Alexey Proskuryakov.
1809
1810         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
1811
1812         * QueueStatusServer/handlers/queuestatusjson.py:
1813         (QueueStatusJSON.get):
1814         * QueueStatusServer/handlers/statusbubble.py:
1815         (StatusBubble._iso_time):
1816
1817 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
1818
1819         Unreviewed, updated list of email addresses in contributors.json
1820
1821         * Scripts/webkitpy/common/config/contributors.json: Added my former
1822         email address in Igalia, for the sake of completeness.
1823
1824 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1825
1826         Unreviewed, moved myself to the list of committers.
1827
1828         * Scripts/webkitpy/common/config/contributors.json:
1829
1830 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
1831
1832         [EFL] Introduce EWebKit_Extension
1833         https://bugs.webkit.org/show_bug.cgi?id=134921
1834
1835         Reviewed by Gyuyoung Kim.
1836
1837         * MiniBrowser/efl/main.c: Added x option to test extension path.
1838         (window_create):
1839         (elm_main):
1840         * Scripts/webkitpy/common/config/watchlist:
1841         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1842         * Scripts/webkitpy/style/checker.py:
1843         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1844
1845 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
1846
1847         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
1848         https://bugs.webkit.org/show_bug.cgi?id=137390
1849
1850         Reviewed by Carlos Garcia Campos.
1851
1852         * Scripts/update-webkit-libs-jhbuild:
1853
1854 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1855
1856         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
1857         https://bugs.webkit.org/show_bug.cgi?id=137391
1858
1859         Reviewed by Martin Robinson.
1860
1861         Add a custom command to only re-generate
1862         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
1863
1864         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1865
1866 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1867
1868         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
1869         https://bugs.webkit.org/show_bug.cgi?id=135502
1870
1871         Reviewed by Martin Robinson.
1872
1873         When writing to stdout/stderr fails due to a UnicodeDecodeError
1874         exception, try again without encoding the output.
1875
1876         * gtk/gtkdoc.py:
1877         (GTKDoc._run_command):
1878
1879 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1880
1881         Bugzilla status bubble displays an exception showing attachment 175738
1882         https://bugs.webkit.org/show_bug.cgi?id=137410
1883
1884         Reviewed by Tim Horton.
1885
1886         * QueueStatusServer/app.yaml: Update version.
1887
1888         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
1889         Don't fail even if expected status message is missing.
1890
1891         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
1892         the field in the same way it's defined in QueueStatus table.
1893
1894 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1895
1896         Record latest message in PatchLog for quick access
1897         https://bugs.webkit.org/show_bug.cgi?id=137405
1898
1899         Fixing a typo.
1900
1901         * QueueStatusServer/app.yaml:
1902         * QueueStatusServer/handlers/releasepatch.py:
1903
1904 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1905
1906         Record latest message in PatchLog for quick access
1907         https://bugs.webkit.org/show_bug.cgi?id=137405
1908
1909         Reviewed by Ryosuke Niwa.
1910
1911         It's no SQL...
1912
1913         * QueueStatusServer/handlers/releasepatch.py:
1914         * QueueStatusServer/handlers/updatestatus.py:
1915         * QueueStatusServer/loggers/recordpatchevent.py:
1916         * QueueStatusServer/model/patchlog.py:
1917
1918 2014-10-02  David Farler  <dfarler@apple.com>
1919
1920         -asan-blacklist option also renamed to generic -fsanitize-blacklist
1921         https://bugs.webkit.org/show_bug.cgi?id=137377
1922
1923         Reviewed by Daniel Bates.
1924
1925         * asan/asan.xcconfig:
1926         -asan-blacklist -> -fsanitize-blacklist
1927
1928         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1929
1930 2014-10-03  Roger Fong  <roger_fong@apple.com>
1931
1932         [Windows] Include batch size argument to layout tests on Windows.
1933
1934         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1935         (RunWebKitTests.start): 
1936         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
1937         These crashes seem to happen on random tests though generally in a spread out fashion.
1938         It seems possible that the DRT instance is being clobbered somehow after running too many
1939         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
1940
1941 2014-10-03  Roger Fong  <roger_fong@apple.com>
1942
1943         [Windows] Settle for 2 chid processes running NRWT on Windows.
1944
1945         * Scripts/webkitpy/port/win.py:
1946         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
1947
1948 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
1949
1950         [GTK] Bump up and patch dependencies to allow building for aarch64
1951         https://bugs.webkit.org/show_bug.cgi?id=137147
1952
1953         Reviewed by Martin Robinson.
1954
1955         The currently used versions of pixman, libffi, librsvg, glib,
1956         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
1957         and/or build for aarch64, so they are bumped up and patched where
1958         necessary. Wherever possible, the same versions and patches were used as
1959         for the EFL port bump-up
1960         (https://bugs.webkit.org/show_bug.cgi?id=135885).
1961
1962         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
1963         regression by crashing http/tests/media/video-redirect.html . A patch
1964         already in upstream fixes that bug.
1965
1966         This change does not touch xserver, which also needs bumping up, but 
1967         will be dealt with later.
1968
1969         * gtk/jhbuild.modules:
1970         Specified versions and patches necessary to correctly build for aarch64.
1971         * gtk/patches/gst-events-arent-gstobjects.patch:
1972         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
1973         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
1974         Added. Patches gst-plugins-base to configure correctly for aarch64.
1975         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
1976         Added. Bumps up config.guess and config.sub in librsvg to recognize
1977         aarch64.
1978         * gtk/patches/libxml2-2.9.0-dtd.patch:
1979         Removed. Not necessary for libxml2 v2.9.1 anymore.
1980
1981 2014-09-28  Sam Weinig  <sam@webkit.org>
1982
1983         Remove RefPtrHashMap
1984         https://bugs.webkit.org/show_bug.cgi?id=137200
1985
1986         Reviewed by Darin Adler.
1987
1988         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1989         (TestWebKitAPI::TEST):
1990         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
1991         a minimum of refcount churn occurs.
1992
1993 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1994
1995         Remove workarounds for versions of Python before 2.7
1996         https://bugs.webkit.org/show_bug.cgi?id=137338
1997
1998         Reviewed by Csaba Osztrogonác.
1999
2000         * Scripts/webkitpy/common/system/autoinstall.py:
2001         (AutoInstaller._extract_targz):
2002         (AutoInstaller._unzip):
2003         (AutoInstaller): Deleted.
2004         (AutoInstaller._extract_all): Deleted.
2005         * Scripts/webkitpy/common/webkitunittest.py:
2006         (TestCase.setUp): Deleted.
2007         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2008         (TestConfigurationConverter.collapse_macros):
2009         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2010         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2011         (TestConfigurationConverter):
2012         (TestConfigurationConverter.combinations): Deleted.
2013         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2014         * Scripts/webkitpy/port/base.py:
2015
2016 2014-10-03  Commit Queue  <commit-queue@webkit.org>
2017
2018         Unreviewed, rolling out r174264.
2019         https://bugs.webkit.org/show_bug.cgi?id=137392
2020
2021         It broke run-webkit-tests (Requested by ebalazsfalvi on
2022         #webkit).
2023
2024         Reverted changeset:
2025
2026         "Remove workarounds for versions of Python before 2.7"
2027         https://bugs.webkit.org/show_bug.cgi?id=137338
2028         http://trac.webkit.org/changeset/174264
2029
2030 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2031
2032         Remove workarounds for versions of Python before 2.7
2033         https://bugs.webkit.org/show_bug.cgi?id=137338
2034
2035         Reviewed by Csaba Osztrogonác.
2036
2037         * Scripts/webkitpy/common/system/autoinstall.py:
2038         (AutoInstaller._extract_targz):
2039         (AutoInstaller._unzip):
2040         (AutoInstaller): Deleted.
2041         (AutoInstaller._extract_all): Deleted.
2042         * Scripts/webkitpy/common/webkitunittest.py:
2043         (TestCase.setUp): Deleted.
2044         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2045         (TestConfigurationConverter.collapse_macros):
2046         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2047         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2048         (TestConfigurationConverter):
2049         (TestConfigurationConverter.combinations): Deleted.
2050         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2051         * Scripts/webkitpy/port/base.py:
2052         * Scripts/webkitpy/port/driver.py:
2053         (ContentBlock.__init__):
2054         * Scripts/webkitpy/port/server_process.py:
2055         (ServerProcess._reset):
2056
2057 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2058
2059         Remove autoinstaller workaround for python 2.6
2060         https://bugs.webkit.org/show_bug.cgi?id=137343
2061
2062         Reviewed by Daniel Bates.
2063
2064         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
2065         2.6, nor Snow Leopard is supported anymore, so the workaround is not
2066         needed anymore.
2067
2068         * Scripts/webkitpy/common/system/autoinstall.py:
2069         (AutoInstaller.install):
2070         * Scripts/webkitpy/test/main.py:
2071         (Tester._run_tests):
2072         * Scripts/webkitpy/thirdparty/__init__.py:
2073         (AutoinstallImportHook._install_mechanize):
2074         (AutoinstallImportHook._install_pep8):
2075         (AutoinstallImportHook._install_pylint):
2076         (AutoinstallImportHook._install_buildbot):
2077         (AutoinstallImportHook._install_coverage):
2078         (AutoinstallImportHook._install_eliza):
2079         (AutoinstallImportHook._install_irc):
2080         (AutoinstallImportHook._install):
2081         (autoinstall_everything):
2082
2083 2014-10-02  Daniel Bates  <dabates@apple.com>
2084
2085         Use version number 101000 instead of 10100 for OS X Yosemite
2086         https://bugs.webkit.org/show_bug.cgi?id=137372
2087
2088         Reviewed by Mark Rowe.
2089
2090         The version number for OS X Yosemite is 101000.
2091
2092         * DumpRenderTree/mac/TextInputController.m:
2093
2094 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
2095
2096         update-work-items should never delete items
2097         https://bugs.webkit.org/show_bug.cgi?id=137366
2098
2099         Reviewed by Ryosuke Niwa.
2100
2101         As we don't just replace the whole list any more, indicate which items are high
2102         priority, and which are not. Hight priority ones will be prepended to the queue,
2103         others will be appended.
2104
2105         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
2106         But hopefully we will never have many rollouts competing like that.
2107
2108         * QueueStatusServer/app.yaml: Update version.
2109
2110         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
2111         priority and regular items separately. Removed some error handling that used to
2112         end up in returning status 500 - an uncaught exception does that automatically.
2113
2114         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
2115
2116         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
2117
2118         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
2119         priority items.
2120
2121         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2122         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
2123         line that complicated testing.
2124
2125         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
2126
2127         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
2128         priority items into separate lists.
2129
2130         * Scripts/webkitpy/common/net/statusserver_mock.py:
2131         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2132         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2133         Updated tests.
2134
2135 2014-10-02  Brendan Long  <b.long@cablelabs.com>
2136
2137         Annoying build warnings in WTFString API tests
2138         https://bugs.webkit.org/show_bug.cgi?id=137360
2139
2140         Reviewed by Darin Adler.
2141
2142         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2143         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
2144
2145 2014-10-02  Roger Fong  <roger_fong@apple.com>
2146
2147         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
2148
2149         * Scripts/webkitpy/port/win.py:
2150         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
2151
2152 2014-10-02  David Farler  <dfarler@apple.com>
2153
2154         Move ASan arguments from LLVM (-mllvm) to the frontend
2155         https://bugs.webkit.org/show_bug.cgi?id=137365
2156
2157         Reviewed by David Kilzer.
2158
2159         * asan/asan.xcconfig:
2160         Remove the -mllvm prefix to the asan-blacklist argument, moving it
2161         to the clang frontend.
2162
2163         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2164
2165 2014-10-02  Commit Queue  <commit-queue@webkit.org>
2166
2167         Unreviewed, rolling out r174120.
2168         https://bugs.webkit.org/show_bug.cgi?id=137350
2169
2170         While number of failures is reasonable with 2 processes, test
2171         results seem to be inconsistent between runs (Requested by
2172         rfong on #webkit).
2173
2174         Reverted changeset:
2175
2176         "[Windows] Back to 2 child processes for NRWT on Windows."
2177         http://trac.webkit.org/changeset/174120
2178
2179 2014-10-02  Jeff Miller  <jeffm@apple.com>
2180
2181         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
2182         https://bugs.webkit.org/show_bug.cgi?id=137347
2183
2184         Reviewed by Dan Bernstein.
2185
2186         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2187         Use WebKitSystemInterfaceYosemite on OS X 10.10.
2188
2189         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2190         Ditto.
2191
2192 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2193
2194         [GTK] [JHBuild] Switch sourceware.org mirror to http.
2195
2196         Unreviewed.
2197
2198         The ftp access is recently failing to work as expected, and the
2199         bots fail to download the file.
2200         The same mirror is available via http and seems to work better.
2201
2202         * gtk/jhbuild.modules:
2203
2204 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2205
2206         Unreviewed, rolling out r174185.
2207         https://bugs.webkit.org/show_bug.cgi?id=137334
2208
2209         Patch that adds logging causes webkitpy failures (Requested by
2210         rfong on #webkit).
2211
2212         Reverted changeset:
2213
2214         "commitqueuetasks_unittest references a non-existent member
2215         variable"
2216         https://bugs.webkit.org/show_bug.cgi?id=137303
2217         http://trac.webkit.org/changeset/174185
2218
2219 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2220
2221         EWS and Commit Queue should know better than to spew 500 failed
2222         results in the case of extremely red patches.
2223         https://bugs.webkit.org/show_bug.cgi?id=137324
2224
2225         Reviewed by Alexey Proskuryakov.
2226
2227         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2228         Adds a check for did_exceed_test_failure_limit.
2229         (AbstractEarlyWarningSystem._failing_tests_message):
2230         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2231         Alters the task mock to respond properly to
2232         results_from_patch_test_run(patch)
2233         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2234         * Scripts/webkitpy/tool/commands/queues.py:
2235         Adds a check for did_exceed_test_failure_limit.
2236         (CommitQueue._failing_tests_message):
2237
2238 2014-10-01  Daniel Bates  <dabates@apple.com>
2239
2240         Unreviewed, rolling out r174192.
2241
2242         Revert the unit test fix in r174192 since we reverted r174187
2243         in r174194 due to correctness issues. See
2244         <http://webkit.org/b/137329> for more details.
2245
2246         Reverted changeset:
2247
2248         "Test fix after r174187"
2249         http://trac.webkit.org/changeset/174192
2250
2251 2014-10-01  Mark Rowe  <mrowe@apple.com>
2252
2253         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2254
2255         Reviewed by Dan Bernstein.
2256
2257         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
2258         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
2259         for the LLVM components when on Yosemite.
2260
2261 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2262
2263         Unreviewed, rolling out r174187.
2264         https://bugs.webkit.org/show_bug.cgi?id=137329
2265
2266         webkitpy failures, and thorton says the patch is wrong
2267         (Requested by dethbakin on #webkit).
2268
2269         Reverted changeset:
2270
2271         "[Windows] Increase layout test timeout for Windows following
2272         r174162."
2273         http://trac.webkit.org/changeset/174187
2274
2275 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
2276
2277         Test fix after r174187
2278
2279         * Scripts/webkitpy/port/win_unittest.py:
2280         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
2281
2282 2014-10-01  Roger Fong  <roger_fong@apple.com>
2283
2284         [Windows] Increase layout test timeout for Windows following r174162.
2285
2286         * Scripts/webkitpy/port/win.py:
2287         (WinPort.default_timeout_ms):
2288
2289 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2290
2291         commitqueuetasks_unittest references a non-existent member variable
2292         when mock-reporting flaky tests.
2293         https://bugs.webkit.org/show_bug.cgi?id=137303
2294
2295         Reviewed by Daniel Bates.
2296
2297         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2298         (MockCommitQueue.report_flaky_tests):
2299         Makes the appropriate name change.
2300         (test_simple_flaky_test_failure):
2301         Adds a unit test to make sure that the code is excercised.
2302
2303 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2304
2305         EWS is inconclusively spinning forever on a patch that breaks 500+
2306         tests
2307         https://bugs.webkit.org/show_bug.cgi?id=137223
2308
2309         Reviewed by Tim Horton.
2310
2311         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2312         Checks to see whether the tests have exceeded the failure limit, and
2313         only spins off another test if they have not exceeded the limit.
2314         (PatchAnalysisTask._test_patch):
2315
2316 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
2317
2318         Unreviewed, add Katie Madonna as a contributor.
2319
2320         * Scripts/webkitpy/common/config/contributors.json:
2321
2322 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2323
2324         commitqueuetasks_unittest does not construct FailingTestCommitQueue
2325         objects properly in its test cases.
2326         https://bugs.webkit.org/show_bug.cgi?id=137281
2327
2328         Reviewed by Daniel Bates.
2329
2330         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2331         (FailingTestCommitQueue.test_results):
2332         Adds an assert to make FailingTestCommitQueue harder to mis-use.
2333         (test_double_flaky_test_failure):
2334         Nests the intended test failure strings into one-length lists.
2335         (test_red_test_failure):
2336         Nests the intended test failure strings into one-length lists.
2337
2338 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2339
2340         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
2341         https://bugs.webkit.org/show_bug.cgi?id=136987
2342
2343         Reviewed by Daniel Bates.
2344
2345         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2346         Specify the default encoding for all WebKit developers to get consistent results.
2347
2348 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2349
2350         EWS is too eager to say that a patch does not apply to trunk of repository
2351         https://bugs.webkit.org/show_bug.cgi?id=137290
2352
2353         Reviewed by Ryosuke Niwa.
2354
2355         * QueueStatusServer/app.yaml: Updated app version.
2356
2357         * QueueStatusServer/handlers/statusbubble.py:
2358         (StatusBubble._build_bubble):
2359         (StatusBubble._build_bubbles_for_attachment):
2360         Rewrote to make more sense.
2361
2362 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2363
2364         Remove thirdparty/unittest2 from webkitpy
2365         https://bugs.webkit.org/show_bug.cgi?id=137251
2366
2367         Reviewed by Brent Fulgham.
2368
2369         Additionally ordered imports in related webkitpy files and
2370         removed unnecessary shebangs from unittest files.
2371
2372         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
2373         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2374         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2375         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2376         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2377         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2378         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2379         * Scripts/webkitpy/common/config/committers_unittest.py:
2380         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2381         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
2382         * Scripts/webkitpy/common/config/ports_unittest.py:
2383         * Scripts/webkitpy/common/config/urls_unittest.py:
2384         * Scripts/webkitpy/common/editdistance_unittest.py:
2385         * Scripts/webkitpy/common/find_files_unittest.py:
2386         * Scripts/webkitpy/common/lru_cache_unittest.py:
2387         * Scripts/webkitpy/common/memoized_unittest.py:
2388         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
2389         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2390         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2391         * Scripts/webkitpy/common/net/credentials_unittest.py:
2392         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2393         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2394         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2395         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2396         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2397         * Scripts/webkitpy/common/net/statusserver_unittest.py:
2398         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2399         * Scripts/webkitpy/common/newstringio_unittest.py:
2400         * Scripts/webkitpy/common/prettypatch_unittest.py:
2401         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2402         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2403         * Scripts/webkitpy/common/system/environment_unittest.py:
2404         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
2405         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
2406         * Scripts/webkitpy/common/system/executive_unittest.py:
2407         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2408         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2409         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2410         * Scripts/webkitpy/common/system/logtesting.py:
2411         * Scripts/webkitpy/common/system/logutils_unittest.py:
2412         * Scripts/webkitpy/common/system/outputcapture.py:
2413         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2414         * Scripts/webkitpy/common/system/outputtee_unittest.py:
2415         * Scripts/webkitpy/common/system/path_unittest.py:
2416         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2417         * Scripts/webkitpy/common/system/profiler_unittest.py:
2418         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
2419         * Scripts/webkitpy/common/system/user_unittest.py:
2420         * Scripts/webkitpy/common/system/workspace_unittest.py:
2421         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2422         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
2423         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
2424         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
2425         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
2426         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
2427         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2428         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
2429         * Scripts/webkitpy/common/webkitunittest.py:
2430         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2431         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2432         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2433         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2434         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2435         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2436         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2437         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2438         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
2439         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2440         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2441         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2442         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
2443         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2444         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2445         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
2446         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2447         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2448         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2449         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2450         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2451         * Scripts/webkitpy/port/base_unittest.py:
2452         * Scripts/webkitpy/port/builders_unittest.py:
2453         * Scripts/webkitpy/port/config_unittest.py:
2454         * Scripts/webkitpy/port/driver_unittest.py:
2455         * Scripts/webkitpy/port/efl_unittest.py:
2456         * Scripts/webkitpy/port/factory_unittest.py:
2457         * Scripts/webkitpy/port/gtk_unittest.py:
2458         * Scripts/webkitpy/port/http_lock_unittest.py:
2459         * Scripts/webkitpy/port/image_diff_unittest.py:
2460         * Scripts/webkitpy/port/leakdetector_unittest.py:
2461         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
2462         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2463         * Scripts/webkitpy/port/mock_drt_unittest.py:
2464         * Scripts/webkitpy/port/port_testcase.py:
2465         * Scripts/webkitpy/port/server_process_unittest.py:
2466         * Scripts/webkitpy/port/westondriver_unittest.py:
2467         * Scripts/webkitpy/port/win_unittest.py:
2468         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2469         * Scripts/webkitpy/style/checker_unittest.py:
2470         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2471         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2472         * Scripts/webkitpy/style/checkers/common_unittest.py:
2473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2474         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
2475         * Scripts/webkitpy/style/checkers/js_unittest.py:
2476         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2477         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
2478         * Scripts/webkitpy/style/checkers/png_unittest.py:
2479         * Scripts/webkitpy/style/checkers/python_unittest.py:
2480         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2481         * Scripts/webkitpy/style/checkers/text_unittest.py:
2482         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2483         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2484         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2485         * Scripts/webkitpy/style/error_handlers_unittest.py:
2486         * Scripts/webkitpy/style/filereader_unittest.py:
2487         * Scripts/webkitpy/style/filter_unittest.py:
2488         * Scripts/webkitpy/style/main_unittest.py:
2489         * Scripts/webkitpy/style/optparser_unittest.py:
2490         * Scripts/webkitpy/style/patchreader_unittest.py:
2491         * Scripts/webkitpy/test/finder_unittest.py:
2492         * Scripts/webkitpy/test/main.py: Ordered imports.
2493         * Scripts/webkitpy/test/main_unittest.py:
2494         * Scripts/webkitpy/test/printer.py: Ordered imports.
2495         (Printer.configure):
2496         * Scripts/webkitpy/test/runner_unittest.py:
2497         * Scripts/webkitpy/test/skip_unittest.py:
2498         * Scripts/webkitpy/thirdparty/__init__.py:
2499         (AutoinstallImportHook._install_irc):
2500         (AutoinstallImportHook._install_unittest2): Deleted.
2501         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2502         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
2503         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2504         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2505         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2506         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2507         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2508         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2509         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2510         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2511         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2512         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2513         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2514         * Scripts/webkitpy/tool/commands/download_unittest.py:
2515         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2516         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2517         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2518         * Scripts/webkitpy/tool/commands/queuestest.py:
2519         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2520         * Scripts/webkitpy/tool/grammar_unittest.py:
2521         * Scripts/webkitpy/tool/mocktool_unittest.py:
2522         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2523         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2524         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2525         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
2526         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
2527         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2528         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2529         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2530         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2531         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
2532         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2533         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2534         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2535         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2536         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2537         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2538         * Scripts/webkitpy/tool/steps/update_unittest.py:
2539         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2540         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2541         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2542         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2543         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2544
2545 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
2546
2547         LayoutTestResults and ExpectedFailures should know about the
2548         interrupted flag from the json results file
2549         https://bugs.webkit.org/show_bug.cgi?id=137229
2550
2551         Reviewed by Daniel Bates.
2552
2553         Changes LayoutTestResults to use the interrupted flag instead of
2554         counting failures.
2555
2556         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2557         (BuilderTest._install_fetch_build._mock_fetch_build):
2558         (BuilderTest.test_latest_layout_test_results):
2559         * Scripts/webkitpy/common/net/layouttestresults.py:
2560         Removes notion of failure_limit_count, and adds
2561         did_exceed_test_failure_limit.
2562
2563         (LayoutTestResults.results_from_string):
2564         (LayoutTestResults.__init__):
2565         (LayoutTestResults.did_exceed_test_failure_limit):
2566         (LayoutTestResults): Deleted.
2567         (LayoutTestResults.set_failure_limit_count): Deleted.
2568         (LayoutTestResults.failure_limit_count): Deleted.
2569         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2570         Removes unit test for failure_limit_count logic.
2571
2572         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
2573         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2574         Instead of providing a class method that returns a list of
2575         TestResults objects, resultsjsonparser now provides a class
2576         ParsedJSONResults that serves as an interface between the results.json
2577         file and the rest of webkitpy.
2578
2579         (ParsedJSONResults):
2580         (ParsedJSONResults.__init__):
2581         (ParsedJSONResults.did_exceed_test_failure_limit):
2582         (ParsedJSONResults.test_results):
2583         (ResultsJSONParser): Deleted.
2584         (ResultsJSONParser.parse_results_json): Deleted.
2585         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2586         Updates the unit test so that it can test the new ResultsJSONParser
2587         class.
2588
2589         (ParsedJSONResultsTest):
2590         (test_basic):
2591         (ResultsJSONParserTest): Deleted.
2592         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2593         Updates the unit test to instantiate ResultsJSONParser objects rather
2594         than simple lists of TestResult objects.
2595
2596         (MockCommitQueue.test_results):
2597         (FailingTestCommitQueue.test_results):
2598         (test_flaky_test_failure):
2599         (test_failed_archive):
2600         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2601         Updates ExpectedFailures to use the did_exceed_test_failure_limit
2602         method rather than counting the number of failed tests.
2603
2604         (ExpectedFailures._should_trust):
2605         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2606         Updates MockResults to more closely resemble the updated
2607         LayoutTestResults class.
2608
2609         (MockResults.__init__):
2610         (MockResults.did_exceed_test_failure_limit):
2611         (ExpectedFailuresTest.test_can_trust_results):
2612         (ExpectedFailuresTest.test_unexpected_failures_observed):
2613         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
2614         (MockResults.failure_limit_count): Deleted.
2615         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2616         Removes a FIXME regarding the use of the
2617         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
2618
2619         (LayoutTestResultsReader.results):
2620         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2621         Updates test to not check the now-nonexistant failure_count_limit
2622         method.
2623
2624         (test_missing_unit_test_results_path):
2625         (test_layout_test_results):
2626         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2627         Accounts for name change: ResultsJSONParserTest ->
2628         ParsedJSONParserTest.
2629
2630         (RebaselineTestTest.test_gather_baselines):
2631
2632 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2633
2634         [EFL] Rename TEST_THEME_DIR macro
2635         https://bugs.webkit.org/show_bug.cgi?id=137244
2636
2637         Reviewed by Csaba Osztrogonác.
2638
2639         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
2640         DEFAULT_THEME_DIR is better than it.
2641
2642         * MiniBrowser/efl/main.c:
2643         (window_create):
2644         * TestWebKitAPI/efl/PlatformWebView.cpp:
2645         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2646         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2647         (WTR::PlatformWebView::PlatformWebView):
2648
2649 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2650
2651         Windows EWS went purple when it failed to build
2652         https://bugs.webkit.org/show_bug.cgi?id=137267
2653
2654         Reviewed by Ryosuke Niwa.
2655
2656         * QueueStatusServer/app.yaml: Update the version.
2657
2658         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
2659         Make it work for style and win-ews queues.
2660
2661 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
2662
2663         It should be fun and easy to run every possible JavaScript benchmark from the command line
2664         https://bugs.webkit.org/show_bug.cgi?id=137245
2665
2666         Reviewed by Oliver Hunt.
2667         
2668         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
2669         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
2670         having their own private scripts for doing benchmark runs, and didn't share them in the open
2671         source community, because of fears about the shady licensing of the benchmarks suites that
2672         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
2673         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
2674         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
2675         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
2676         but some of them are. The non-public tests are exclusively those that were not made by any
2677         WebKit contributor, but which JSC/WebKit devs found useful for testing.
2678
2679         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
2680         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
2681         checked into WebKit svn at all) can be run by passing the path to them via a configuration
2682         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
2683         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
2684         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
2685         probably never be checked in because there is no license text anywhere in that benchmark.
2686         A valid ~/.run-jsc-benchmarks file will just be something like:
2687         
2688             {
2689                 "OctanePath": "/path/to/Octane2",
2690                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
2691             }
2692         
2693         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
2694         run-jsc-benchmarks will just gracefully avoid running that test suite.
2695         
2696         Finally, a word about policy: it is understood that different organizations that do
2697         development on JSC may find themselves having internal benchmarks that they cannot share
2698         because of weird licensing. It happens - usually because the organization doing JSC
2699         development found some test in the wild that is owned by someone else and therefore cannot
2700         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
2701         that add support for some new kind of benchmark suite even if the suite is not made public
2702         as part of the same patch - so long as the patch isn't too invasive. An example of
2703         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
2704         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
2705         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
2706         completely open-sourced and committed to the WebKit repo - but the reality is that this
2707         can't always be done safely.
2708
2709         * Scripts/bencher: Removed.
2710         * Scripts/run-jsc-benchmarks: Added.
2711
2712 2014-09-30  Roger Fong  <roger_fong@apple.com>
2713
2714         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
2715
2716         * Scripts/webkitpy/port/drdiver.py:
2717         (Driver.stop):
2718         * Scripts/webkitpy/port/server_process.py:
2719         (ServerProcess.stop):
2720
2721 2014-09-30  Roger Fong  <roger_fong@apple.com>
2722
2723         [Windows] Back to 2 child processes for NRWT on Windows.
2724
2725         * Scripts/webkitpy/port/win.py:
2726         (WinPort.default_child_processes):
2727         Changing the number of processes to 1 did not have an effect on the layout test results. 
2728         It does introduce an issue with one of the workers hanging indefinitely and causing the 
2729         layout tests to timeout as a whole occasionally, but we should just fix that.
2730
2731 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2732
2733         Remove an accidentally committed line..
2734
2735         * QueueStatusServer/handlers/statusbubble.py:
2736         (StatusBubble._build_bubble):
2737
2738 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2739
2740         build.webkit.org/dashboard: Switch EWS view to using actual retry count
2741         https://bugs.webkit.org/show_bug.cgi?id=137240
2742
2743         Reviewed by Ryosuke Niwa.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2746         (EWSQueue.prototype.loadDetailedStatus):
2747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2748         (EWSQueueView.prototype._popoverContentForEWSQueue):
2749         Use the new retry_count data member from JSON.
2750
2751         * QueueStatusServer/app.yaml: Updating the version.
2752
2753         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
2754         Instead of message_count, produce retry_count.
2755
2756 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2757
2758         EWS doesn't need to show all the bubbles when a patch fails to apply
2759         https://bugs.webkit.org/show_bug.cgi?id=137256
2760
2761         Reviewed by Ryosuke Niwa.
2762
2763         * QueueStatusServer/app.yaml: Updated app version.
2764
2765         * QueueStatusServer/handlers/statusbubble.py:
2766         (StatusBubble._build_bubble):
2767         (StatusBubble._build_bubbles_for_attachment):
2768         (StatusBubble.get):
2769         * QueueStatusServer/templates/statusbubble.html:
2770         When some queues fail to apply, and no queues had meaningful output (meaning that
2771         they will almost certainly fail to apply later), we can show a single bubble
2772         telling the user just that.
2773
2774 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2775
2776         [EFL] Bump EFL version to 1.11.2
2777         https://bugs.webkit.org/show_bug.cgi?id=137118
2778
2779         Reviewed by Gyuyoung Kim.
2780
2781         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
2782         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
2783
2784         * efl/jhbuild.modules:
2785         * efl/patches/ecore.patch: Removed.
2786
2787 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2788
2789         REGRESSION(r173929): [GTK] TestInspector fails after r173929
2790         https://bugs.webkit.org/show_bug.cgi?id=137247
2791
2792         Reviewed by Philippe Normand.
2793
2794         Wait until can-attach property changes before trying to attach the
2795         inspector after resizing the view.
2796
2797         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2798         (testInspectorDefault):
2799
2800 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2801
2802         Require Python 2.7 version
2803         https://bugs.webkit.org/show_bug.cgi?id=137112
2804
2805         Reviewed by Csaba Osztrogonác.
2806
2807         * Scripts/ensure-valid-python:
2808         (checkPythonVersion):
2809         * Scripts/webkitpy/common/version_check.py:
2810
2811 2014-09-30  Martin Hock  <mhock@apple.com>
2812
2813         Skip a JSC test after r174036.
2814         https://bugs.webkit.org/show_bug.cgi?id=137236
2815
2816         Reviewed by Csaba Osztrogonác.
2817
2818         * Scripts/run-javascriptcore-tests:
2819
2820 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2821
2822         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
2823         https://bugs.webkit.org/show_bug.cgi?id=137212
2824
2825         This moves TestNetscapePlugin to a new folder (lib/plugins).
2826         We should not use the same directory for TestNetscapePlugin and
2827         the other libraries, because we end up scanning all the .so in the
2828         lib dir for every test.
2829
2830         Reviewed by Carlos Garcia Campos.
2831
2832         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
2833         * Scripts/webkitpy/port/efl.py:
2834         (EflPort.setup_environ_for_server): Update plugin path.
2835         * Scripts/webkitpy/port/gtk.py:
2836         (GtkPort.setup_environ_for_server): Update plugin path.
2837         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
2838
2839 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2840
2841         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
2842
2843         Rubber-stamped by Tim Horton.
2844
2845         * QueueStatusServer/app.yaml:
2846         * QueueStatusServer/handlers/statusbubble.py:
2847         (StatusBubble._build_bubble):
2848
2849 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2850
2851         Typo fix, suggested by Tim Horton.
2852
2853         * QueueStatusServer/handlers/statusbubble.py:
2854         (StatusBubble._build_message_for_provisional_failure):
2855
2856 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2857
2858         Improve Bugzilla status bubbles
2859         https://bugs.webkit.org/show_bug.cgi?id=137232
2860
2861         Reviewed by Ryosuke Niwa.
2862
2863         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
2864
2865         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
2866         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
2867         that are stuck, as it was only confusing that they disappeared after 99.
2868
2869         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
2870         by old bubbles. We need a lot more information to determine color, so the implementation
2871         can not be here.
2872
2873         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
2874         always have a link for consistency. Added code to convert timestamps in tooltips
2875         to local time zone.
2876
2877 2014-09-29  Commit Queue  <commit-queue@webkit.org>
2878
2879         Unreviewed, rolling out r174045.
2880         https://bugs.webkit.org/show_bug.cgi?id=137231
2881
2882         Introduced a crash during page loading tests on Mac (Requested
2883         by rniwa on #webkit).
2884
2885         Reverted changeset:
2886
2887         "Replace OSObjectPtr with RetainPtr/adoptOS"
2888         https://bugs.webkit.org/show_bug.cgi?id=137158
2889         http://trac.webkit.org/changeset/174045
2890
2891 2014-09-29  Tim Horton  <timothy_horton@apple.com>
2892
2893         Add Jake as a contributor.
2894
2895         * Scripts/webkitpy/common/config/contributors.json:
2896
2897 2014-09-29  Roger Fong  <roger_fong@apple.com>
2898
2899         [Windows] Skip a javascriptcore test following r174036.
2900
2901         * Scripts/run-javascriptcore-tests:
2902
2903 2014-09-29  Roger Fong  <roger_fong@apple.com>
2904
2905         [Windows] Reduce number of processes used by NRWT on Windows to 1.
2906
2907         * Scripts/webkitpy/port/win.py:
2908         (WinPort.default_child_processes):
2909         Reduce number of processes to 1 so we can get a good baseline for what failures
2910         we should be expecting to see from the Windows bots.
2911
2912 2014-09-29  Darin Adler  <darin@apple.com>
2913
2914         Tweak and tighten SVG font converter
2915         https://bugs.webkit.org/show_bug.cgi?id=136956
2916
2917         Reviewed by Myles Maxfield.
2918
2919         I was investigating behavior of String::toInt, String::toDouble, and
2920         String::toFloat for various failure cases, and decided to start some
2921         unit tests for those functions here.
2922
2923         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2924         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
2925         StringToDouble testing.
2926
2927 2014-09-29  Philippe Normand  <pnormand@igalia.com>
2928
2929         [GTK][CMake] TestWebCore target build sometimes fail
2930         https://bugs.webkit.org/show_bug.cgi?id=137207
2931
2932         Reviewed by Csaba Osztrogon.
2933
2934         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
2935         headers are generated before the TestWebCore target is built.
2936
2937 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2938
2939         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
2940         https://bugs.webkit.org/show_bug.cgi?id=137209
2941
2942         Reviewed by Philippe Normand.
2943
2944         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
2945         from the WebCore test sources.
2946
2947 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
2948
2949         Allow webkit-patch upload to respect the --directory argument with git checkouts
2950         https://bugs.webkit.org/show_bug.cgi?id=137166
2951
2952         Reviewed by Darin Adler.
2953
2954         We simply hadn't plumbed it through.
2955
2956         * Scripts/webkitpy/common/checkout/scm/detection.py:
2957         (SCMDetector.detect_scm_system):
2958         * Scripts/webkitpy/common/checkout/scm/git.py:
2959         (Git.__init__):
2960         (Git.changed_files):
2961
2962 2014-09-26  Sam Weinig  <sam@webkit.org>
2963
2964         Replace OSObjectPtr with RetainPtr/adoptOS
2965         https://bugs.webkit.org/show_bug.cgi?id=137158
2966
2967         Reviewed by Dan Bernstein.
2968
2969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2970         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
2971         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
2972         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
2973
2974 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
2975
2976         Disable function.arguments
2977         https://bugs.webkit.org/show_bug.cgi?id=137167
2978
2979         Rubber stamped by Geoffrey Garen
2980         
2981         Enable the feature by default during tests.
2982
2983         * Scripts/run-jsc-stress-tests:
2984
2985 2014-09-26  Beth Dakin  <bdakin@apple.com>
2986
2987         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
2988         https://bugs.webkit.org/show_bug.cgi?id=137089
2989
2990         Reviewed by Tim Horton.
2991
2992         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
2993         tests run at 1x, but that code does not seem to execute at the right time for 
2994         these tests, so if we just ensure we start out at 1x, that appears to fix these 
2995         tests and does not break the HiDPI tests either.
2996         * WebKitTestRunner/TestController.cpp:
2997         (WTR::TestController::createWebViewWithOptions):
2998
2999 2014-09-26  Roger Fong  <roger_fong@apple.com>
3000
3001         [Windows] Decrease default number of child processes used by Windows.
3002
3003         * Scripts/webkitpy/port/win.py:
3004         (WinPort.default_child_processes):
3005         Having too many seems to cause many tests to crash or timeout. 
3006         We may even need to make it have only 1 child process if we’re still seeing problems after this.
3007
3008 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3009
3010         Mac EWS bots do not keep logs as promised
3011         https://bugs.webkit.org/show_bug.cgi?id=137151
3012
3013         Reviewed by Ryosuke Niwa.
3014
3015         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
3016
3017 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3018
3019         Get rid of webkit-queues dashboard
3020         https://bugs.webkit.org/show_bug.cgi?id=137141
3021
3022         Reviewed by Ryosuke Niwa.
3023
3024         * QueueStatusServer/app.yaml: Updated version.
3025
3026         * QueueStatusServer/templates/dashboard.html: Removed.
3027         * QueueStatusServer/handlers/dashboard.py: Removed.
3028         * QueueStatusServer/main.py:
3029         Kill it!
3030
3031         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
3032         (.status-cell): Deleted.
3033         (.status-cell:hover): Deleted.
3034         (.status-cell.pass): Deleted.
3035         (.status-cell.fail): Deleted.
3036         (.status-cell.pending): Deleted.
3037         (.status-cell.error): Deleted.
3038         * QueueStatusServer/stylesheets/dashboard.css: Removed.
3039         * QueueStatusServer/templates/activebots.html:
3040         * QueueStatusServer/templates/patch.html:
3041         * QueueStatusServer/templates/queuestatus.html:
3042         * QueueStatusServer/templates/recentstatus.html:
3043         Renamed dashboard.css to common.css, and removed dashboard-only rules.
3044
3045 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
3046
3047         Get rid of Retry status in webkit-queues
3048         https://bugs.webkit.org/show_bug.cgi?id=137135
3049
3050         Reviewed by Ryosuke Niwa.
3051
3052         * QueueStatusServer/config/messages.py: Removed Retry.
3053
3054         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
3055         no longer needs to check the latest status. It just always both unlocks the patch
3056         and removes it from WorkItems.
3057
3058         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
3059         I don't understand why we even needed to check for retries here, but now that there
3060         are no retries, that code can go to /dev/null.
3061
3062         * QueueStatusServer/loggers/recordpatchevent.py:
3063         (RecordPatchEvent.started):
3064         (RecordPatchEvent.retrying): Deleted.
3065         Fixed retry counting, it should work for all queues now.
3066
3067         * QueueStatusServer/model/queuestatus.py:
3068         (QueueStatus.is_retry_request): Deleted. These are no more.
3069
3070         * Scripts/webkitpy/common/net/statusserver_mock.py:
3071         (MockStatusServer.release_lock):
3072         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3073         Did whatever it took to keep passing the tests. The particular test doesn't seem
3074         quite right, but whatever.
3075
3076         * Scripts/webkitpy/tool/commands/queues.py:
3077         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
3078         and let others pick up. Also, added explicit returns for clarity.
3079         (AbstractPatchQueue._did_retry): Deleted.
3080
3081 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3082
3083         [EFL] Fix the gst-libav build on ARM Thumb2
3084         https://bugs.webkit.org/show_bug.cgi?id=137022
3085
3086         Reviewed by Zoltan Herczeg.
3087
3088         * efl/jhbuild.modules:
3089         * efl/patches/gst-libav.patch: Added.
3090
3091 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
3092
3093         [EFL] Bump up dependencies not to conflict with the GTK port.
3094         https://bugs.webkit.org/show_bug.cgi?id=137143
3095
3096         Reviewed by Gyuyoung Kim.
3097
3098         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
3099         installing and removing different versions of libgnutls-dev, thus
3100         hindering the development for both ports on the same machine. GTK is
3101         using the newer version of the package, now bumping up EFL to use the 
3102         same.
3103
3104         * efl/install-dependencies:
3105
3106 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
3107
3108         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
3109         https://bugs.webkit.org/show_bug.cgi?id=136854
3110
3111         Reviewed by Gyuyoung Kim.
3112
3113         'Escape' key should exit fullscreen first and then should be used to stop page load.
3114
3115         * MiniBrowser/efl/main.c:
3116         (on_key_down):
3117
3118 2014-09-25  Dean Jackson  <dino@apple.com>
3119
3120         Add Said to the contributors list so his name completes in bugzilla.
3121
3122         * Scripts/webkitpy/common/config/contributors.json:
3123
3124 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
3125
3126         EWS only repeats its cycle every two hours
3127         https://bugs.webkit.org/show_bug.cgi?id=137129
3128
3129         Reviewed by Ryosuke Niwa.
3130
3131         * QueueStatusServer/app.yaml: Updated version.
3132
3133         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
3134
3135         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
3136         the patch from work items.
3137
3138         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
3139
3140         * QueueStatusServer/main.py: Added release-lock.
3141
3142         * QueueStatusServer/model/activeworkitems.py:
3143         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
3144
3145         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
3146         we don't want it to be immediately picked up again, it's better to give other patches
3147         a chance.
3148
3149         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
3150         these interactive versions, but OK.
3151
3152         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
3153         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
3154         or svn is down).
3155
3156         * Scripts/webkitpy/tool/commands/queues.py:
3157         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
3158         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
3159         meaning that these handlers could never do the right thing. We'd either get a duplicate
3160         _did_fail, or try to unlock an already unlocked patch.
3161         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
3162         making it eligible for retry immediately.
3163
3164         * Scripts/webkitpy/common/net/statusserver.py:
3165         (StatusServer._post_release_lock):
3166         (StatusServer.release_lock):
3167         Added a call to release-lock.
3168
3169 2014-09-25  Roger Fong  <roger_fong@apple.com>
3170
3171         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
3172
3173         * Scripts/webkitpy/common/system/path.py:
3174         (_CygPath.convert):
3175
3176 2014-09-25  Roger Fong  <roger_fong@apple.com>
3177
3178         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
3179
3180         * Scripts/webkitpy/common/system/path.py:
3181         (_CygPath.convert):
3182
3183 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3184
3185         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
3186         https://bugs.webkit.org/show_bug.cgi?id=136377
3187
3188         Reviewed by Philippe Normand.
3189
3190         * Scripts/webkitdirs.pm:
3191         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
3192
3193 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
3194
3195         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
3196         https://bugs.webkit.org/show_bug.cgi?id=137117
3197
3198         Tools/efl/install-dependencies relies on apt-get to install packages.
3199         Unfortunately, if a package does not exist (e.g., for a given
3200         architecture) then apt-get install is not able to ignore the missing
3201         package and install the rest but fails to run entirely (and there
3202         seems to be no intent to change this behaviour).
3203
3204         On ARM64, the luajit package is missing and currently it needs manual
3205         editing of install-dependencies to get the script install as much as it
3206         can.
3207
3208         This patch separates the installation of the universally available
3209         packages from those which might not be available for all architectures.
3210
3211         Reviewed by Gyuyoung Kim.
3212
3213         * efl/install-dependencies:
3214
3215 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
3216
3217         Remove WinCE port from trunk
3218         https://bugs.webkit.org/show_bug.cgi?id=136951
3219
3220         Reviewed by Alex Christensen.
3221
3222         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3223         (_should_file_trigger_build):
3224         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3225         (ShouldBuildTest):
3226         * CMakeLists.txt:
3227         * DumpRenderTree/win/DRTDataObject.cpp:
3228         (DRTDataObject::CopyMedium):
3229         * Scripts/build-webkit:
3230         * Scripts/webkit-build-directory:
3231         * Scripts/webkitdirs.pm:
3232         (argumentsForConfiguration):
3233         (builtDylibPathForName):
3234         (isAppleWinWebKit):
3235         (launcherPath):
3236         (launcherName):
3237         (shouldRemoveCMakeCache):
3238         (cmakeBasedPortArguments):
3239         (cmakeBasedPortName):
3240         (isCMakeBuild):
3241         (isWinCE): Deleted.
3242         (determineIsWinCE): Deleted.
3243         * Scripts/webkitperl/FeatureList.pm:
3244         * Scripts/webkitpy/port/port_testcase.py:
3245         (test_apache_config_file_name_for_platform):
3246         * TestWebKitAPI/config.h:
3247         * WinCELauncher/CMakeLists.txt: Removed.
3248         * WinCELauncher/main.cpp: Removed.
3249         * gtk/manifest.txt:
3250
3251 2014-09-23  David Farler  <dfarler@apple.com>
3252
3253         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
3254         https://bugs.webkit.org/show_bug.cgi?id=136895
3255
3256         Reviewed by David Kilzer.
3257
3258         Create Device, DeviceType, and Runtime data classes.
3259         Create Simulator class represent simctl output.
3260
3261         Wherever possible, use structured data classes anywhere a raw
3262         identifier or UDID string was used for a cleaner implementation
3263         and to encapsulate the inherent fragility of scraping simctl output.
3264
3265         Create a suitably named testing device if one doesn't exist.
3266
3267         Finally, accurately handle having multiple simulator runtimes (SDKs)
3268         installed in the active Xcode.app bundle.
3269
3270         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3271         (_set_up_derived_options):
3272         * Scripts/webkitpy/port/driver.py:
3273         (IOSSimulatorDriver.cmd_line):
3274         Construct DeviceType and Runtime objects from identifiers passed at the
3275         command line, still providing sensible defaults for 32- and 64-bit testing.
3276         * Scripts/webkitpy/port/ios.py:
3277         (IOSSimulatorPort.__init__):
3278         (IOSSimulatorPort.setup_test_run):
3279         (IOSSimulatorPort):
3280         (IOSSimulatorPort.testing_device):
3281         Cache the testing device once it is created or found.
3282         (IOSSimulatorPort.reset_preferences):
3283         Get the device path from the Device object instead of consructing it
3284         in the port class.
3285         (IOSSimulatorPort.simulator_udid): Deleted.
3286         Get the UDID from the testing_device :: Device object itself.
3287         * Scripts/webkitpy/xcode/simulator.py:
3288         Created Device, DeviceType, Runtime, and Simulator classes.
3289         (get_runtimes): Deleted.
3290         (get_devices): Deleted.
3291         (get_device_types): Deleted.
3292         (get_latest_runtime): Deleted.
3293
3294 2014-09-24  Roger Fong  <roger_fong@apple.com>
3295
3296         [Windows] Tentative fix for Windows test bots.
3297
3298         * Scripts/webkitpy/common/system/path.py:
3299         (_CygPath.convert):
3300
3301 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
3302
3303         Change more build.webkit.org links to https
3304         https://bugs.webkit.org/show_bug.cgi?id=137049
3305
3306         Reviewed by Csaba Osztrogonác.
3307
3308         Fix appspot, svn.webkit.org and Trac links.
3309
3310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3311         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
3314         (ViewController.prototype._domForBuildName):
3315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3319         (.):
3320         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3321         (EWS):
3322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
3324         (TestHistory):
3325         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3326
3327 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
3328
3329         Update the list of u-szeged contributors.
3330
3331         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
3332
3333         * Scripts/webkitpy/common/config/contributors.json:
3334
3335 2014-09-23  Roger Fong  <roger_fong@apple.com>
3336
3337         [Windows] More debugging for the Windows bots.
3338
3339         * Scripts/webkitpy/common/system/path.py:
3340         (_CygPath):
3341
3342 2014-09-23  Roger Fong  <roger_fong@apple.com>
3343
3344         Unreviewed. Fix for r173899, those tabs should be spaces.
3345
3346         * Scripts/webkitpy/port/driver.py:
3347         (Driver._command_from_driver_input):
3348         (Driver): Deleted.
3349
3350 2014-09-23  Roger Fong  <roger_fong@apple.com>
3351
3352         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
3353
3354         * Scripts/webkitpy/port/driver.py:
3355         (Driver):
3356
3357 2014-09-23  Jer Noble  <jer.noble@apple.com>
3358
3359         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
3360         https://bugs.webkit.org/show_bug.cgi?id=137031
3361
3362         Reviewed by Joseph Pecoraro.
3363
3364         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
3365         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
3366         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
3367         ChangeLog locations before passing them to createCommitMessage().
3368
3369         * Scripts/commit-log-editor:
3370
3371 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3372
3373         W3C test importer should detect manual and reference tests according their filenames
3374         https://bugs.webkit.org/show_bug.cgi?id=133852
3375
3376         Reviewed by Bem Jones-Bey.
3377
3378         * Scripts/webkitpy/w3c/test_parser.py:
3379         (TestParser.analyze_test): Adding checks based on WPT filename rules.
3380         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
3381         (TestParser):
3382         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
3383         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
3384         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3385         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
3386
3387 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3388
3389         Unreviewed, add Rebecca Hauck as a contributor.
3390
3391         * Scripts/webkitpy/common/config/contributors.json:
3392
3393 2014-09-23  David Kilzer  <ddkilzer@apple.com>
3394
3395         Switch build.webkit.org URLs to https
3396
3397         Reviewed by Lucas Forschler and Alexey Proskuryakov.
3398
3399         * TestResultServer/app.yaml: Update version to this commit
3400         revision.
3401
3402         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3403         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
3406         (WebKitBuildbot):
3407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3410         (.):
3411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3412         (WebKitBuildbot):
3413         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3414         * Scripts/webkitpy/common/config/urls.py:
3415         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3416         (test_builder_with_name):
3417         * Scripts/webkitpy/tool/commands/queries.py:
3418         (TreeStatus):
3419         * TestResultServer/generate_builders_json.py:
3420         (main):
3421         * TestResultServer/generate_builders_json_unittest.py:
3422         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3423         (GenerateBuildersJsonTest):
3424         (GenerateBuildersJsonTest.test_generate_json_data):
3425         * TestResultServer/static-dashboards/builders.jsonp:
3426         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3427         (loadExpectationsLayoutTests):
3428         * TestResultServer/static-dashboards/timeline_explorer.js:
3429
3430 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3431
3432         W3C test importer should copy .htaccess files
3433         https://bugs.webkit.org/show_bug.cgi?id=136850
3434
3435         Reviewed by Bem Jones-Bey.
3436
3437         * Scripts/webkitpy/w3c/test_importer.py:
3438         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
3439         (TestImporter):
3440         (TestImporter.find_importable_tests): Making use of new helper function.
3441
3442 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
3443
3444         Trying to revive bot watcher's dashboard after HSTS.
3445
3446         Unreviewed.
3447
3448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3449         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
3450
3451 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3452
3453         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
3454         https://bugs.webkit.org/show_bug.cgi?id=137026
3455
3456         Reviewed by Csaba Osztrogonác.
3457
3458         * BuildSlaveSupport/wait-for-SVN-server.py:
3459         (getLatestSVNRevision):
3460         (waitForSVNRevision):
3461
3462 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3463
3464         Remove unlinkZeroFiles from build-webkit
3465         https://bugs.webkit.org/show_bug.cgi?id=137018
3466
3467         Reviewed by Csaba Osztrogonác.
3468
3469         * Scripts/build-webkit:
3470         (unlinkZeroFiles): Deleted.
3471
3472 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
3473
3474         [GTK] Minibrowser : Add keyboard support for stop page load
3475         https://bugs.webkit.org/show_bug.cgi?id=136857
3476
3477         Reviewed by Philippe Normand.
3478
3479         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
3480
3481         * MiniBrowser/gtk/BrowserWindow.c:
3482         (stopPageLoad): Callback to stop page load.
3483         (browser_window_init):
3484
3485 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
3486
3487         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
3488         https://bugs.webkit.org/show_bug.cgi?id=136813
3489
3490         Reviewed by Gyuyoung Kim.
3491
3492         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
3493
3494         * MiniBrowser/efl/main.c:
3495         (on_key_down):
3496
3497 2014-09-22  Daniel Bates  <dabates@apple.com>
3498
3499         [Cocoa] Add UI delegate callback when window.close() is called
3500         https://bugs.webkit.org/show_bug.cgi?id=137008
3501         <rdar://problem/17801001>
3502
3503         Reviewed by Anders Carlsson.
3504
3505         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
3506         for window opened via JavaScript (i.e. window.open()).
3507
3508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3509         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
3510         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
3511
3512 2014-09-22  Youenn Fablet  <youennf@gmail.com>
3513
3514         W3C importer should import html files within resources folders
3515         https://bugs.webkit.org/show_bug.cgi?id=127548
3516
3517         Reviewed by Ryosuke Niwa.
3518         
3519         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
3520
3521         * Scripts/webkitpy/w3c/test_importer.py:
3522         (TestImporter.find_importable_tests):
3523
3524 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3525
3526         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
3527         https://bugs.webkit.org/show_bug.cgi?id=136998
3528
3529         Reviewed by Philippe Normand.
3530
3531         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3532         (testWebViewCanShowMIMEType): Remove the check of PDF as
3533         unsupported MIME type.
3534
3535 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3536
3537         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
3538
3539         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
3540         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
3541
3542         * Scripts/webkitpy/common/config/watchlist: Use
3543         Source/WebCore/platform/gtk/po/ as directory to watch for
3544         WebKitGTKTranslations rule and add berto and myself to the list of
3545         watchers.
3546
3547 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
3548
3549         Fix syntaxError in watchlist since r173594
3550         https://bugs.webkit.org/show_bug.cgi?id=136996
3551
3552         Reviewed by Philippe Normand.
3553
3554         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
3555
3556 2014-09-20  Sam Weinig  <sam@webkit.org>
3557
3558         Make possible HashSet<std::unique_ptr<>>
3559         https://bugs.webkit.org/show_bug.cgi?id=136166
3560
3561         Reviewed by Darin Adler.
3562
3563         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
3564         * TestWebKitAPI/Counters.cpp: Added.
3565         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
3566         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
3567         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
3568         translation unit.
3569     
3570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3571         Add new files.
3572
3573         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3574         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
3575
3576         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3577         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
3578
3579 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3580
3581         run-webkit-tests should count tests submitted as absolute paths once
3582         https://bugs.webkit.org/show_bug.cgi?id=136848
3583
3584         Reviewed by Darin Adler.
3585
3586         * Scripts/webkitpy/port/base.py:
3587         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
3588
3589 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3590
3591         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
3592         https://bugs.webkit.org/show_bug.cgi?id=136974
3593
3594         Reviewed by Chris Fleizach.
3595
3596         * DumpRenderTree/AccessibilityUIElement.cpp:
3597         (selectTextWithCriteriaCallback):
3598         Be sure to release the string if it was allocated.
3599
3600 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
3601
3602         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
3603         https://bugs.webkit.org/show_bug.cgi?id=136966
3604
3605         Reviewed by Daniel Bates.
3606
3607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3608         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
3609
3610 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3611
3612         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
3613         https://bugs.webkit.org/show_bug.cgi?id=136917
3614
3615         Reviewed by Darin Adler.
3616
3617         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
3618
3619         * TestWebKitAPI/PlatformEfl.cmake:
3620         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
3621         (TestWebKitAPI::didFinishLoadForFrame):
3622         (TestWebKitAPI::TEST):
3623         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
3624
3625 2014-09-19  Daniel Bates  <dabates@apple.com>
3626
3627         Always assume internal SDK when building configuration Production
3628         https://bugs.webkit.org/show_bug.cgi?id=136925
3629         <rdar://problem/18362399>
3630
3631         Reviewed by Dan Bernstein.
3632
3633         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3634         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3635         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3636         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3637
3638 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3639
3640         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
3641         https://bugs.webkit.org/show_bug.cgi?id=136847
3642
3643         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
3644
3645         Reviewed by Alexey Proskuryakov.
3646
3647         * WebKitTestRunner/TestController.cpp:
3648         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
3649
3650 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3651
3652         [GTK] Missing inspector files in the tarball
3653         https://bugs.webkit.org/show_bug.cgi?id=136952
3654
3655         Reviewed by Gustavo Noronha Silva.
3656
3657         * gtk/manifest.txt: Add
3658         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
3659         to the tarball.
3660
3661 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3662
3663         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
3664         https://bugs.webkit.org/show_bug.cgi?id=136632
3665
3666         Reviewed by Gustavo Noronha Silva.
3667
3668         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
3669         the gtk icons.
3670         * gtk/manifest.txt: Only include the free icons in the tarball.
3671
3672 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3673
3674         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
3675         https://bugs.webkit.org/show_bug.cgi?id=136943
3676
3677         Reviewed by Philippe Normand.
3678
3679         Update the script to receive the list of files from the command
3680         line instead of scanning the given directories.
3681
3682         * gtk/generate-inspector-gresource-manifest.py:
3683         (get_filenames): Convert filenames to use relative paths.
3684         (find_all_files_in_directory): Deleted.
3685         (find_all_files_in_directory.select_file): Deleted.
3686
3687 2014-09-18  Tanay C  <tanay.c@samsung.com>
3688
3689         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
3690         https://bugs.webkit.org/show_bug.cgi?id=136739
3691
3692         Reviewed by Gyuyoung Kim.
3693
3694         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
3695         (on_mouse_wheel): Modified.
3696
3697 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3698
3699         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
3700         https://bugs.webkit.org/show_bug.cgi?id=136923
3701
3702         Reviewed by Gustavo Noronha Silva.
3703
3704         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3705         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
3706         the source.
3707
3708 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
3709
3710         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
3711         https://bugs.webkit.org/show_bug.cgi?id=136856
3712
3713         Reviewed by Darin Adler.
3714
3715         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3716         (RunLLINTCLoopTests.countFailures):
3717         (Run32bitJSCTests.countFailures):
3718         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3719         (RunLLINTCLoopTestsTest.test_failures):
3720         (RunLLINTCLoopTestsTest.test_failure):
3721         (RunLLINTCLoopTestsTest.test_no_failure):
3722         (Run32bitJSCTestsTest.test_failures):
3723         (Run32bitJSCTestsTest.test_failure):
3724         (Run32bitJSCTestsTest.test_no_failure):
3725
3726 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
3727
3728         GMainLoopSource is exposed to race conditions
3729         https://bugs.webkit.org/show_bug.cgi?id=135800
3730
3731         Reviewed by Carlos Garcia Campos.
3732
3733         Add unit tests for GMainLoopSource.
3734
3735         The tests check correct behavior of GMainLoopSource in various conditions --
3736         from the most simple rescheduling to rescheduling during dispatch, cancelling
3737         or destroying the GMainLoopSource during dispatch, proper destroy callback
3738         dispatching etc.
3739
3740         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
3741         State of the GMainLoopSource object (either ready, sheduled or active) is
3742         thoroughly tested throughout the lifetime of that object.
3743
3744         Still missing are tests for socket callbacks, which are a bit trickier because
3745         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
3746         are also not tested thoroughly, simply because it is at the moment impossible
3747         to test that the objects are actually destroyed when the corresponding source
3748         is finally deleted.
3749
3750         * TestWebKitAPI/PlatformGTK.cmake:
3751         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3752         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3753         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3754         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3755         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3756         (TestWebKitAPI::GMainLoopSourceTest::finish):
3757         (TestWebKitAPI::GMainLoopSourceTest::source):
3758         (TestWebKitAPI::TEST):
3759
3760 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
3761
3762         Unreviewed, Update my email in contributors.json
3763
3764         * Scripts/webkitpy/common/config/contributors.json:
3765
3766 2014-09-17  Daniel Bates  <dabates@apple.com>
3767
3768         Unreviewed, rolling out r173695.
3769
3770         Broke building third-party Legacy WebKit apps; will
3771         investigate offline
3772
3773         Reverted changeset:
3774
3775         "[iOS] Make WebCore build with public iOS SDK"
3776         https://bugs.webkit.org/show_bug.cgi?id=136487
3777         http://trac.webkit.org/changeset/173695
3778
3779 2014-09-17  Daniel Bates  <dabates@apple.com>
3780
3781         [iOS] Make WebCore build with public iOS SDK
3782         https://bugs.webkit.org/show_bug.cgi?id=136487
3783
3784         Reviewed by David Kilzer.
3785
3786         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
3787
3788         * DumpRenderTree/mac/CheckedMalloc.cpp:
3789
3790 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3791
3792         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
3793         https://bugs.webkit.org/show_bug.cgi?id=136889
3794
3795         Reviewed by Gustavo Noronha Silva.
3796
3797         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3798         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
3799         event was added to the events vector.
3800         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3801         (loadFailedCallback): Do not assume the web view URI is the
3802         failing URI when the load fails before the committed state.
3803         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
3804         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
3805         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
3806         (LoadTrackingTest::loadFailedWithTLSErrors): Add
3807         LoadFailedWithTLSErrors event to the events vector.
3808         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3809
3810 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
3811
3812         [EFL][GTK] Remove WebKit1 related codes
3813         https://bugs.webkit.org/show_bug.cgi?id=136853
3814
3815         Reviewed by Csaba Osztrogonác.
3816
3817         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
3818         from scripts.
3819
3820         * BuildSlaveSupport/build.webkit.org-config/config.json:
3821         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3822         (Compile32bitJSC):
3823         (BuildAndTestWebKit2Factory):
3824         (CompileWebKit1Only): Deleted.
3825         (CompileWebKit2Only): Deleted.
3826         (BuildAndTestWebKit1OnlyFactory): Deleted.
3827         (BuildAndTestWebKit2OnlyFactory): Deleted.
3828         * Scripts/build-webkit:
3829         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3830         * Scripts/webkitpy/common/config/ports.py:
3831         (GtkWK2Port.build_webkit_command):
3832         (EflWK2Port.build_webkit_command):
3833         * Scripts/webkitpy/common/config/ports_unittest.py:
3834         (DeprecatedPortTest.test_gtk_wk2_port):
3835         * Scripts/webkitpy/port/efl.py:
3836         (EflPort.build_webkit_command):
3837         * Scripts/webkitpy/port/gtk.py:
3838         (GtkPort._built_libraries_path):
3839         (GtkPort._search_paths):
3840         (GtkPort.test_expectations_file_position):
3841         (GtkPort.build_webkit_command):
3842         (GtkPort.run_webkit_tests_command):
3843         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
3844
3845 2014-09-16  Daniel Bates  <dabates@apple.com>
3846
3847         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3848         https://bugs.webkit.org/show_bug.cgi?id=136862
3849
3850         Reviewed by David Kilzer.
3851
3852         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3853         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3854         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
3855         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
3856
3857 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3858
3859         Mac queue slaves should reboot every so often
3860         https://bugs.webkit.org/show_bug.cgi?id=136791
3861
3862         Reviewed by Alexey Proskuryakov.
3863
3864         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
3865
3866         * EWSTools/start-queue-mac.sh:
3867
3868 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3869
3870         Unreviewed gardening, skip one more tests on Windows.
3871
3872         * Scripts/run-javascriptcore-tests:
3873
3874 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3875
3876         JSC test gardening
3877         https://bugs.webkit.org/show_bug.cgi?id=136823
3878
3879         Reviewed by Geoffrey Garen.
3880
3881         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
3882
3883 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3884
3885         Remove shouldAbortEarly cruft from master.cfg
3886         https://bugs.webkit.org/show_bug.cgi?id=136779
3887
3888         Reviewed by Csaba Osztrogonác.
3889
3890         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3891         (ConfigureBuild.start):
3892         (RunWebKitTests.start):
3893         (RunWebKit2Tests.start): Deleted.
3894
3895 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3896
3897         Remove ORWT related crufts from webkitdirs.pm
3898         https://bugs.webkit.org/show_bug.cgi?id=136821
3899
3900         Reviewed by Alexey Proskuryakov.
3901
3902         * Scripts/webkitdirs.pm:
3903         (isPerianInstalled): Deleted.
3904         (determineIPhoneSimulatorVersion): Deleted.
3905         (iPhoneSimulatorVersion): Deleted.
3906         (isSnowLeopard): Deleted.
3907         (isLion): Deleted.
3908         (quitIOSSimulator): Deleted.
3909
3910 2014-09-15  Roger Fong  <roger_fong@apple.com>
3911
3912         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
3913         https://bugs.webkit.org/show_bug.cgi?id=25160
3914
3915         * Scripts/run-javascriptcore-tests:
3916
3917 2014-09-15  Lucas Forschler  <lforschler@apple.com>
3918
3919         Add another Apple build slave to the Mountain Lion Debug WK1 queue
3920         
3921         Rubber stamped by Matt Hanson.
3922         
3923         * BuildSlaveSupport/build.webkit.org-config/config.json:
3924
3925 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3926
3927         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
3928         https://bugs.webkit.org/show_bug.cgi?id=136822
3929
3930         Reviewed by Gyuyoung Kim.
3931
3932         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
3933         initialized as we already does it in PlatformWebView::PlatformWebView
3934         calling ewk_init(). The reason for that was to ensure testing for example,
3935         WTF where creating the view is not mandatory.
3936
3937         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
3938         in order to properly initalize and release EWebKit.
3939
3940         * TestWebKitAPI/PlatformEfl.cmake:
3941         * TestWebKitAPI/efl/PlatformWebView.cpp:
3942         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3943         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3944         * TestWebKitAPI/efl/main.cpp:
3945         (main):
3946
3947 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
3948
3949         [WinCairo] Make it easier to enable/disable GStreamer.
3950         https://bugs.webkit.org/show_bug.cgi?id=135766
3951
3952         Reviewed by Brent Fulgham.
3953
3954         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
3955
3956         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
3957
3958 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
3959
3960         Web Inspector: remind about rebaselining generator test results
3961         https://bugs.webkit.org/show_bug.cgi?id=136759
3962
3963         Reviewed by Joseph Pecoraro.
3964
3965         For now, we can implement this as a watchlist message. Add watchlist
3966         groups and messages for the inspector and web replay generators.
3967
3968         * Scripts/webkitpy/common/config/watchlist:
3969
3970 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3971
3972         build.webkit.org/dashboard: Overlapping text when status is long
3973         https://bugs.webkit.org/show_bug.cgi?id=136794
3974
3975         Reviewed by Timothy Hatcher.
3976
3977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3978         (.status-line): Replaces height with min-height.
3979
3980 2014-09-12  Timothy Hatcher  <timothy@apple.com>
3981
3982         Make Brian Burg a WebKit reviewer.
3983
3984         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
3985
3986 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3987
3988         Multiple EWS or commit bots can pick up processing of the same patch
3989         https://bugs.webkit.org/show_bug.cgi?id=136793
3990
3991         Reviewed by Ryosuke Niwa.
3992
3993         Change timeout from one hour to two hours. This will let bots finish, and in the
3994         unlikely event of a bot being frozen, will only delay patch processing restart by
3995         one hour.
3996
3997         * QueueStatusServer/app.yaml:
3998         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
3999
4000 2014-09-11  Andy Estes  <aestes@apple.com>
4001
4002         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
4003         https://bugs.webkit.org/show_bug.cgi?id=136768
4004
4005         Reviewed by Tim Horton.
4006
4007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4008         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
4009         (TestWebKitAPI::TEST):
4010
4011 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4012
4013         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
4014         https://bugs.webkit.org/show_bug.cgi?id=136669
4015
4016         Reviewed by Antti Koivisto.
4017
4018         * Scripts/run-gtk-tests:
4019         (TestRunner): Unskip SSL test.
4020
4021 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
4022
4023         Strip extraneous AVFoundation and CoreMedia logging
4024         https://bugs.webkit.org/show_bug.cgi?id=136747
4025
4026         Reviewed by Jer Noble.
4027
4028         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4029         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
4030
4031         * Scripts/webkitpy/port/base.py:
4032         (Port.stderr_patterns_to_strip): Base class, empty list
4033
4034         * Scripts/webkitpy/port/driver.py:
4035         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
4036
4037         * Scripts/webkitpy/port/ios.py:
4038         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
4039
4040         * Scripts/webkitpy/port/mac.py:
4041         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
4042
4043
4044 2014-09-11  Michael Saboff  <msaboff@apple.com>
4045
4046         lldb_webkit.py:btjs doesn't work with release builds
4047         https://bugs.webkit.org/show_bug.cgi?id=136760
4048
4049         Reviewed by Jer Noble.
4050
4051         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
4052         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
4053         we can't get a valid result from trying either call.  In that case, we fallback to
4054         just showing the PC.  Also added check for both entry points.  If neither is found,
4055         we issue a warning and output the stack trace without JavaScript annotations.
4056
4057         * lldb/lldb_webkit.py:
4058         (btjs):
4059
4060 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
4061
4062         webkitpy test failures from import-w3c-tests
4063         https://bugs.webkit.org/show_bug.cgi?id=136752
4064
4065         Reviewed by Bem Jones-Bey.
4066
4067         This patch fixes a bug in import-w3c-tests where we were appending
4068         the wrong set of files to the copy_list. This also updates the tests
4069         to clear the failures introduced in the patch for bug 135929.
4070
4071         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4072         (W3CTestConverterTest.test_read_prefixed_property_list):
4073         * Scripts/webkitpy/w3c/test_parser.py:
4074         (TestParser.analyze_test):
4075         (TestParser.support_files):
4076         * Scripts/webkitpy/w3c/test_parser_unittest.py:
4077
4078 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
4079
4080         Blink merge: Speculative fix for windows run-webkit-tests hangs
4081         https://bugs.webkit.org/show_bug.cgi?id=136727
4082
4083         Reviewed by Csaba Osztrogonác.
4084
4085         Merged from Blink (patch by Dirk Pranke):
4086         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
4087
4088         * Scripts/webkitpy/common/system/executive.py:
4089         (Executive.kill_process):
4090
4091 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4092
4093         Added myself as a committer.
4094
4095         Unreviewed.
4096
4097         * Scripts/webkitpy/common/config/contributors.json:
4098
4099 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
4100
4101         [JavaScriptCore] Fix FTL on platform EFL.
4102         https://bugs.webkit.org/show_bug.cgi?id=133571
4103
4104         Reviewed by Filip Pizlo.
4105
4106         * efl/install-dependencies: Revert r169181.
4107         * efl/jhbuild.modules: Clone and build a custom branch.
4108         This branch contains some fix for FTL of platform EFL.
4109         The branch is a fork of llvm r206311.
4110
4111 2014-09-10  Tanay C  <tanay.c@samsung.com>
4112
4113         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
4114         https://bugs.webkit.org/show_bug.cgi?id=136698
4115
4116         Reviewed by Gyuyoung Kim.
4117
4118         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
4119         (on_mouse_wheel): Added.
4120         (window_free):
4121         (window_create):
4122
4123 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
4124
4125         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
4126         https://bugs.webkit.org/show_bug.cgi?id=136284
4127
4128         Reviewed by Gyuyoung Kim.
4129
4130         * MiniBrowser/efl/main.c:
4131         (window_create):
4132
4133 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
4134
4135         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
4136         https://bugs.webkit.org/show_bug.cgi?id=135929
4137
4138         Reviewed by Bem Jones-Bey.
4139
4140         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
4141         were made when this script was originally written with respect to relative paths
4142         in ref files. This patch updates import-w3c-tests to update paths in ref files if
4143         they move relative to the test file.
4144
4145
4146         * Scripts/webkitpy/w3c/test_converter.py:
4147         (convert_for_webkit):
4148         (_W3CTestConverter.__init__):
4149         (_W3CTestConverter.convert_reference_relpaths):
4150         (_W3CTestConverter.convert_style_data):
4151         (_W3CTestConverter.convert_attributes_if_needed):
4152         * Scripts/webkitpy/w3c/test_importer.py:
4153         (TestImporter.find_importable_tests):
4154         (TestImporter.import_tests):
4155         * Scripts/webkitpy/w3c/test_parser.py:
4156         (TestParser.load_file):
4157         (TestParser.analyze_test):
4158         (TestParser.support_files):
4159
4160 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4161
4162         [GTK] allow overwriting destination of download
4163         https://bugs.webkit.org/show_bug.cgi?id=136372
4164
4165         Reviewed by Carlos Garcia Campos.
4166
4167         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
4168         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
4169         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
4170         (createFileAtDestination): Added
4171         (testDownloadOverwriteDestinationAllowed): Added
4172         (testDownloadOverwriteDestinationDisallowed): Added
4173         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
4174         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
4175         (beforeAll): New tests
4176
4177 2014-08-05  David Farler  <dfarler@apple.com>
4178
4179         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
4180         https://bugs.webkit.org/show_bug.cgi?id=135551
4181
4182         Reviewed by Daniel Bates.
4183
4184         Prevent printing invalid Unicode strings going to stderr.
4185         Also, make filesystem.py more tolerant about receiving
4186         Unicode (encoded as UTF-8) when writing to files, in the
4187         rare case that an NSError description will make it to
4188         stderr, such as -[LTRelayController createUniqueApp].
4189
4190         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
4191         (-[LTRelayController launchSimulator]): Removed.
4192         (-[LTRelayController createUniqueApp]):
4193         Don't explicitly try to uninstall the app. It is automatically handled
4194         when installing an app with the same bundle identifier.
4195         (-[LTRelayController start]):
4196         (-[LTRelayController bootDevice]): Removed.
4197         The device already boots as a part of starting the simulator. Attempting
4198         to boot a second time may cause spurious stderr output.
4199         * Scripts/webkitpy/port/driver.py:
4200         (IOSSimulatorDriver._setup_environ_for_driver):
4201         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
4202         Open the iOS Simulator once instead of the LayoutTestRelay trying
4203         to do it.
4204         * Scripts/webkitpy/port/ios.py:
4205         (IOSSimulatorPort._get_crash_log):
4206         Make sure stderr is at least an empty string.
4207         (IOSSimulatorPort):
4208         (IOSSimulatorPort.developer_dir):
4209         New property for setting up DEVELOPER_DIR in the driver environment.
4210
4211 2014-09-09  Dan Bernstein  <mitz@apple.com>
4212
4213         Clean up the MiniBrowser Xcode project
4214         https://bugs.webkit.org/show_bug.cgi?id=136684
4215
4216         Reviewed by Tim Horton.
4217
4218         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
4219         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
4220         WebKit2.framework. Upgraded project file version.
4221
4222 2014-09-09  Daniel Bates  <dbates@webkit.org>
4223
4224         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
4225         https://bugs.webkit.org/show_bug.cgi?id=136379
4226
4227         Reviewed by David Kilzer.
4228
4229         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
4230         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
4231         and sets a property on F (say, the executable bit).
4232
4233         * Scripts/svn-apply:
4234         (patch): Only add file if the diff has text chunks.
4235         * Scripts/svn-unapply:
4236         (patch): Only delete added file if the diff has text chunks.
4237
4238 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4239
4240         [GTK] Unreviewed GTK gardening.
4241
4242         * Scripts/run-gtk-tests:
4243         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
4244
4245 2014-09-09  Christophe Dumez  <cdumez@apple.com>
4246
4247         Update my email in contributors.json
4248         https://bugs.webkit.org/show_bug.cgi?id=136671
4249
4250         Reviewed by Andreas Kling.
4251
4252         * Scripts/webkitpy/common/config/contributors.json:
4253
4254 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4255
4256         [EFL] Enable fixed layout by default
4257         https://bugs.webkit.org/show_bug.cgi?id=136607
4258
4259         Reviewed by Csaba Osztrogonác.
4260
4261         Fixed layout is being used by Tizen platform by default. However, the feature
4262         has still many defects now. So, we need to enable it by default, then should fix
4263         those bugs. 
4264
4265         * MiniBrowser/efl/main.c:
4266
4267 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4268
4269         Remove FILTERS flag
4270         https://bugs.webkit.org/show_bug.cgi?id=136571
4271
4272         Reviewed by Darin Adler.
4273
4274         * Scripts/webkitperl/FeatureList.pm:
4275
4276 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
4277
4278         Dashboard metrics should ignore commits that didn't trigger builds
4279         https://bugs.webkit.org/show_bug.cgi?id=136618
4280
4281         Reviewed by Darin Adler.
4282
4283         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
4284         other platforms etc. It does not make sense to count wait time for these, as it
4285         can be arbitrarily long.
4286
4287         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
4288
4289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4290         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
4291
4292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
4293         We used to walk the timeline to see which revisions are fully tested, but that's not
4294