209239d3bb71ee447075f602d019be55a003b09f
[WebKit-https.git] / Tools / ChangeLog
1 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         Unreviewed, rolling out r235500.
4
5         Time to switch back to master runtime
6
7         Reverted changeset:
8
9         "Unreviewed, rolling out r235114."
10         https://bugs.webkit.org/show_bug.cgi?id=188731
11         https://trac.webkit.org/changeset/235500
12
13 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
14
15         Unreviewed. Add Pablo Saavedra to the list of contributors.
16
17         * Scripts/webkitpy/common/config/contributors.json:
18
19 2018-09-19  Philippe Normand  <pnormand@igalia.com>
20
21         [GStreamer] Add support for AV1 decoding
22         https://bugs.webkit.org/show_bug.cgi?id=189647
23
24         Reviewed by Žan Doberšek.
25
26         Add patches required for AV1 decoding support. They're all
27         upstream already and will be shipped in GStreamer 1.16. The aom
28         GStreamer plugin depends on the aom library for which there's no
29         official release yet.
30
31         * gstreamer/jhbuild.modules:
32         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
33         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
34         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
35         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
36         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
37         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
38
39 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
40
41         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
42         https://bugs.webkit.org/show_bug.cgi?id=189702
43         <rdar://problem/44541704>
44
45         Reviewed by Aakash Jain.
46
47         * Scripts/webkitpy/layout_tests/controllers/manager.py:
48         (Manager._set_up_run): Move build check and clobbering to run, since set up is
49         run multiple times for iOS simulator.
50         (Manager.run):
51
52 2018-09-18  Chris Dumez  <cdumez@apple.com>
53
54         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
55         https://bugs.webkit.org/show_bug.cgi?id=189681
56         <rdar://problem/44526171>
57
58         Reviewed by Alex Christensen and Zalan Bujtas.
59
60         Add API test coverage.
61
62         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
63         (TestWebKitAPI::didFinishNavigation):
64         (TestWebKitAPI::TEST):
65
66 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
67
68         [WPE] Implement mouse event modifiers
69         https://bugs.webkit.org/show_bug.cgi?id=189697
70
71         Reviewed by Carlos Garcia Campos.
72
73         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
74         (WTR::wkEventModifiersToWPE):
75         (WTR::EventSenderProxy::mouseDown):
76         (WTR::EventSenderProxy::mouseUp):
77
78 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
79
80         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
81         https://bugs.webkit.org/show_bug.cgi?id=185339
82
83         Reviewed by Mark Lam.
84
85         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
86         (TestWebKitAPI::ToUpperConverter::stopProducing):
87         (TestWebKitAPI::ToUpperConverter::stopConsuming):
88
89 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
90
91         Many modern media control tests leak documents in testing
92         https://bugs.webkit.org/show_bug.cgi?id=189437
93
94         Reviewed by Darin Adler.
95         
96         In order to accurately detect leaks in media controls tests which use lots of
97         SVGImages, we have to:
98         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
99           to clear references to elements.
100         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
101           to drop the last handle to the CachedResource for an SVGImage.
102         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
103           to run again after that timer has fired.
104         
105         This should fix most of the spurious leak reports involving SVGImage documents.
106
107         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
108         (WTR::InjectedBundle::reportLiveDocuments):
109         (WTR::InjectedBundle::didReceiveMessageToPage):
110
111 2018-09-17  Chris Dumez  <cdumez@apple.com>
112
113         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
114         https://bugs.webkit.org/show_bug.cgi?id=189602
115         <rdar://problem/44430549>
116
117         Reviewed by Geoff Garen.
118
119         Add API test coverage.
120
121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
122
123 2018-09-17  Philippe Normand  <pnormand@igalia.com>
124
125         [JHBuild] Update to GStreamer 1.14.3
126         https://bugs.webkit.org/show_bug.cgi?id=189450
127
128         Reviewed by Xabier Rodriguez-Calvar.
129
130         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
131
132 2018-09-17  Philippe Normand  <pnormand@igalia.com>
133
134         [JHBuild] Doesn't check sha256 sums
135         https://bugs.webkit.org/show_bug.cgi?id=189646
136
137         Reviewed by Michael Catanzaro.
138
139         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
140
141 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
142
143         Move IndexedDB to Network Process
144         https://bugs.webkit.org/show_bug.cgi?id=189415
145         <rdar://problem/44396973>
146
147         Reviewed by Chris Dumez.
148
149         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
150         (TEST):
151         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
152         (TEST):
153         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
154         (TEST):
155         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
156         (TEST):
157         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
158         (TEST):
159
160 2018-09-08  Darin Adler  <darin@apple.com>
161
162         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
163         https://bugs.webkit.org/show_bug.cgi?id=189455
164
165         Reviewed by Keith Miller.
166
167         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
168         testing and even for macOS vs. iOS vs. Windows platform-specific code.
169         For now, this patch just makes corresponding changes to the copied code.
170         Later we might get better results by merging more code instead of having
171         all these separate copies.
172
173         * DumpRenderTree/AccessibilityController.cpp:
174         (AccessibilityController::makeWindowObject): Use the adopt function
175         instead of the special Adopt constructor of JSRetainPtr.
176
177         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
178
179         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
180         (allAttributesCallback): Don't adopt at this level; changed the
181         underlying function to return a JSRetainPtr so the adopt is right next
182         to the call to the create or copy function.
183         (attributesOfLinkedUIElementsCallback): Ditto.
184         (attributesOfDocumentLinksCallback): Ditto.
185         (attributesOfChildrenCallback): Ditto.
186         (parameterizedAttributeNamesCallback): Ditto.
187         (attributesOfColumnHeadersCallback): Ditto.
188         (attributesOfRowHeadersCallback): Ditto.
189         (attributesOfColumnsCallback): Ditto.
190         (attributesOfRowsCallback): Ditto.
191         (attributesOfVisibleCellsCallback): Ditto.
192         (attributesOfHeaderCallback): Ditto.
193         (rowIndexRangeCallback): Ditto.
194         (columnIndexRangeCallback): Ditto.
195         (rangeForLineCallback): Ditto.
196         (boundsForRangeCallback): Ditto.
197         (rangeForPositionCallback): Ditto.
198         (stringForRangeCallback): Ditto.
199         (attributedStringForRangeCallback): Ditto.
200         (uiElementCountForSearchPredicateCallback): Use the free adopt
201         function instead of the adopt member function.
202         (uiElementForSearchPredicateCallback): Ditto.
203         (selectTextWithCriteriaCallback): Don't adopt at this level.
204         (attributedStringForElementCallback): Ditto.
205         (setValueCallback): Use free adopt.
206         (stringAttributeValueCallback): Don't adopt at this level.
207         (uiElementArrayAttributeValueCallback): Ditto.
208         (uiElementAttributeValueCallback): Ditto.
209         (stringForTextMarkerRangeCallback): Ditto.
210         (attributedStringForTextMarkerRangeCallback): Ditto.
211         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
212         (getARIADropEffectsCallback): Ditto.
213         (getClassListCallback): Ditto.
214         (getRoleCallback): Ditto.
215         (getSubroleCallback): Ditto.
216         (getRoleDescriptionCallback): Ditto.
217         (getComputedRoleStringCallback): Ditto.
218         (getTitleCallback): Ditto.
219         (getDescriptionCallback): Ditto.
220         (getStringValueCallback): Ditto.
221         (getLanguageCallback): Ditto.
222         (getHelpTextCallback): Ditto.
223         (getOrientationCallback): Ditto.
224         (getPathDescriptionCallback): Ditto.
225         (getSelectedTextRangeCallback): Ditto.
226         (speakAsCallback): Ditto.
227         (getValueDescriptionCallback): Ditto.
228         (getAccessibilityValueCallback): Ditto.
229         (getDocumentEncodingCallback): Ditto.
230         (getDocumentURICallback): Ditto.
231         (getURLCallback): Ditto.
232         (characterAtOffsetCallback): Ditto.
233         (wordAtOffsetCallback): Ditto.
234         (lineAtOffsetCallback): Ditto.
235         (sentenceAtOffsetCallback): Ditto.
236         (stringForSelectionCallback): Ditto.
237         (getIdentifierCallback): Ditto.
238         (getTraitsCallback): Ditto.
239         (supportedActionsCallback): Ditto.
240         (mathPostscriptsDescriptionCallback): Ditto.
241         (mathPrescriptsDescriptionCallback): Ditto.
242         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
243         (AccessibilityUIElement::rangeForPosition): Ditto.
244         (AccessibilityUIElement::speakAs): Ditto.
245         (AccessibilityUIElement::pathDescription const): Ditto.
246         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
247         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
248         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
249
250         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
251         raw pointers for the results of the functions that create strings.
252         The old way was difficult to get right; the functions didn't even follow
253         the create/copy naming rule.
254
255         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
256         (_platformTypeConstructor): Use the adopt function instead of the
257         JSRetainPtr adopt constructor. Also nullptr instead of 0.
258
259         * DumpRenderTree/GCController.cpp:
260         (GCController::makeWindowObject): Use adopt function instead of constructor.
261
262         * DumpRenderTree/TestRunner.cpp:
263         (pathToLocalResourceCallback): Use adopt function instead of constructor.
264         (addDisallowedURLCallback): Ditto.
265         (addURLToRedirectCallback): Ditto.
266         (clearApplicationCacheForOriginCallback): Ditto.
267         (applicationCacheDiskUsageForOriginCallback): Ditto.
268         (decodeHostNameCallback): Don't adopt at this level.
269         (encodeHostNameCallback): Ditto.
270         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
271         (findStringCallback): Use adopt function instead of constructor.
272         (isCommandEnabledCallback): Ditto.
273         (overridePreferenceCallback): Ditto.
274         (queueLoadCallback): Ditto.
275         (queueLoadHTMLStringCallback): Ditto.
276         (queueLoadingScriptCallback): Ditto.
277         (queueNonLoadingScriptCallback): Ditto.
278         (setAuthenticationPasswordCallback): Ditto.
279         (setAuthenticationUsernameCallback): Ditto.
280         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
281         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
282         (setPOSIXLocaleCallback): Ditto.
283         (setPersistentUserStyleSheetLocationCallback): Ditto.
284         (setUserStyleSheetLocationCallback): Ditto.
285         (setValueForUserCallback): Ditto.
286         (setWillSendRequestClearHeaderCallback): Ditto.
287         (setPageVisibilityCallback): Ditto.
288         (evaluateInWebInspectorCallback): Ditto.
289         (evaluateScriptInIsolatedWorldCallback): Ditto.
290         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
291         (addOriginAccessWhitelistEntryCallback): Ditto.
292         (removeOriginAccessWhitelistEntryCallback): Ditto.
293         (setScrollbarPolicyCallback): Ditto.
294         (addUserScriptCallback): Ditto.
295         (addUserStyleSheetCallback): Ditto.
296         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
297         (authenticateSessionCallback): Ditto.
298         (getTitleTextDirectionCallback): Ditto.
299         (getInspectorTestStubURLCallback): Ditto.
300         (simulateLegacyWebNotificationClickCallback): Ditto.
301         (setTextDirectionCallback): Ditto.
302         (grantWebNotificationPermissionCallback): Ditto.
303         (denyWebNotificationPermissionCallback): Ditto.
304         (accummulateLogsForChannel): Ditto.
305         (runUIScriptCallback): Ditto.
306         (TestRunner::makeWindowObject): Ditto.
307         (TestRunner::uiScriptDidComplete): Ditto.
308         (TestRunner::setOpenPanelFiles): Ditto.
309
310         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
311         raw pointers for the results of the functions that create strings.
312
313         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
314         (AccessibilityController::platformName const): Use the adopt
315         function instead of the adopt constructor.
316
317         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
318         (createEmptyJSString): Added. This helper function makes reduces the
319         repetitive code to create empty strings.
320         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
321         (AccessibilityUIElement::identifier): Ditto.
322         (AccessibilityUIElement::traits): Ditto.
323         (AccessibilityUIElement::url): Ditto.
324         (AccessibilityUIElement::speakAs): Ditto.
325         (AccessibilityUIElement::stringForSelection): Ditto.
326         (AccessibilityUIElement::stringForRange): Ditto.
327         (AccessibilityUIElement::attributedStringForRange): Ditto.
328         (AccessibilityUIElement::attributedStringForElement): Ditto.
329         (AccessibilityUIElement::pathDescription const): Ditto.
330         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
331         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
332         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
333         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
334         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
335         (AccessibilityUIElement::attributesOfChildren): Ditto.
336         (AccessibilityUIElement::allAttributes): Ditto.
337         (AccessibilityUIElement::stringAttributeValue): Ditto.
338         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
339         (AccessibilityUIElement::role): Ditto.
340         (AccessibilityUIElement::subrole): Ditto.
341         (AccessibilityUIElement::roleDescription): Ditto.
342         (AccessibilityUIElement::computedRoleString): Ditto.
343         (AccessibilityUIElement::title): Ditto.
344         (AccessibilityUIElement::description): Ditto.
345         (AccessibilityUIElement::orientation const): Ditto.
346         (AccessibilityUIElement::stringValue): Ditto.
347         (AccessibilityUIElement::language): Ditto.
348         (AccessibilityUIElement::helpText const): Ditto.
349         (AccessibilityUIElement::valueDescription): Ditto.
350         (AccessibilityUIElement::ariaDropEffects const): Ditto.
351         (AccessibilityUIElement::boundsForRange): Ditto.
352         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
353         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
354         (AccessibilityUIElement::attributesOfColumns): Ditto.
355         (AccessibilityUIElement::attributesOfRows): Ditto.
356         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
357         (AccessibilityUIElement::attributesOfHeader): Ditto.
358         (AccessibilityUIElement::rowIndexRange): Ditto.
359         (AccessibilityUIElement::columnIndexRange): Ditto.
360         (AccessibilityUIElement::selectedTextRange): Ditto.
361         (AccessibilityUIElement::accessibilityValue const): Ditto.
362         (AccessibilityUIElement::documentEncoding): Ditto.
363         (AccessibilityUIElement::documentURI): Ditto.
364         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
365         (AccessibilityUIElement::classList const): Ditto.
366
367         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
368         createJSStringRef method to return a JSRetainPtr.
369         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
370         (-[NSString createJSStringRef]): Ditto.
371         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
372         adopt function instead of the adopt constructor.
373         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
374         (AccessibilityController::platformName const): Ditto.
375
376         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
377         (-[NSString createJSStringRef]): Return a JSRetainPtr.
378         (makeValueRefForValue): Updated for the above, no adopt needed here now.
379         (makeObjectRefForDictionary): Ditto.
380         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
381
382         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
383         (createEmptyJSString): Added. This helper function makes reduces the
384         repetitive code to create empty strings.
385         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
386         (descriptionOfElements): Ditto.
387         (selectTextParameterizedAttributeForCriteria): Ditto.
388         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
389         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
390         (AccessibilityUIElement::attributesOfChildren): Ditto.
391         (AccessibilityUIElement::allAttributes): Ditto.
392         (AccessibilityUIElement::stringAttributeValue): Ditto.
393         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
394         (AccessibilityUIElement::role): Ditto.
395         (AccessibilityUIElement::subrole): Ditto.
396         (AccessibilityUIElement::roleDescription): Ditto.
397         (AccessibilityUIElement::computedRoleString): Ditto.
398         (AccessibilityUIElement::title): Ditto.
399         (AccessibilityUIElement::description): Ditto.
400         (AccessibilityUIElement::orientation const): Ditto.
401         (AccessibilityUIElement::stringValue): Ditto.
402         (AccessibilityUIElement::language): Ditto.
403         (AccessibilityUIElement::helpText const): Ditto.
404         (AccessibilityUIElement::valueDescription): Ditto.
405         (AccessibilityUIElement::speakAs): Ditto.
406         (AccessibilityUIElement::classList const): Ditto.
407         (AccessibilityUIElement::ariaDropEffects const): Ditto.
408         (AccessibilityUIElement::rangeForLine): Ditto.
409         (AccessibilityUIElement::rangeForPosition): Ditto.
410         (AccessibilityUIElement::boundsForRange): Ditto.
411         (AccessibilityUIElement::stringForRange): Ditto.
412         (AccessibilityUIElement::attributedStringForRange): Ditto.
413         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
414         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
415         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
416         (AccessibilityUIElement::attributesOfColumns): Ditto.
417         (AccessibilityUIElement::attributesOfRows): Ditto.
418         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
419         (AccessibilityUIElement::attributesOfHeader): Ditto.
420         (AccessibilityUIElement::rowIndexRange): Ditto.
421         (AccessibilityUIElement::columnIndexRange): Ditto.
422         (AccessibilityUIElement::pathDescription const): Ditto.
423         (AccessibilityUIElement::selectedTextRange): Ditto.
424         (AccessibilityUIElement::accessibilityValue const): Ditto.
425         (AccessibilityUIElement::documentEncoding): Ditto.
426         (AccessibilityUIElement::documentURI): Ditto.
427         (AccessibilityUIElement::url): Ditto.
428         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
429         (createJSStringRef): Ditto.
430         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
431         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
432         (AccessibilityUIElement::supportedActions): Ditto.
433         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
434         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
435
436         * DumpRenderTree/mac/FrameLoadDelegate.mm:
437         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
438         Use the adopt function instead of the adopt constructor.
439         * DumpRenderTree/mac/TestRunnerMac.mm:
440         (originsArrayToJS): Ditto.
441         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
442         (TestRunner::copyEncodedHostName): Ditto.
443         (TestRunner::pathToLocalResource): Ditto.
444         (TestRunner::queueLoad): Use adopt function instead of constructor.
445         (TestRunner::findString): Ditto.
446         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
447
448         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
449         (AccessibilityController::winNotificationReceived): Use adopt function
450         instead of adopt constructor.
451         (AccessibilityController::platformName const): Ditto.
452
453         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
454         (createEmptyJSString): Added. This helper function makes reduces the
455         repetitive code to create empty strings.
456         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
457         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
458         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
459         (AccessibilityUIElement::attributesOfChildren): Ditto.
460         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
461         (AccessibilityUIElement::role): Ditto.
462         (AccessibilityUIElement::subrole): Ditto.
463         (AccessibilityUIElement::roleDescription): Ditto.
464         (AccessibilityUIElement::computedRoleString): Ditto.
465         (AccessibilityUIElement::title): Ditto.
466         (AccessibilityUIElement::description): Ditto.
467         (AccessibilityUIElement::stringValue): Ditto.
468         (AccessibilityUIElement::language): Ditto.
469         (AccessibilityUIElement::helpText const): Ditto.
470         (AccessibilityUIElement::valueDescription): Ditto.
471         (AccessibilityUIElement::ariaDropEffects const): Ditto.
472         (AccessibilityUIElement::orientation const): Ditto.
473         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
474         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
475         (AccessibilityUIElement::attributesOfColumns): Ditto.
476         (AccessibilityUIElement::attributesOfRows): Ditto.
477         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
478         (AccessibilityUIElement::attributesOfHeader): Ditto.
479         (AccessibilityUIElement::rowIndexRange): Ditto.
480         (AccessibilityUIElement::columnIndexRange): Ditto.
481         (AccessibilityUIElement::boundsForRange): Ditto.
482         (AccessibilityUIElement::stringForRange): Ditto.
483         (AccessibilityUIElement::attributedStringForRange): Ditto.
484         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
485         (AccessibilityUIElement::selectedTextRange): Ditto.
486         (AccessibilityUIElement::stringAttributeValue): Ditto.
487         (AccessibilityUIElement::accessibilityValue const): Ditto.
488         (AccessibilityUIElement::documentEncoding): Ditto.
489         (AccessibilityUIElement::documentURI): Ditto.
490         (AccessibilityUIElement::url): Ditto.
491         (AccessibilityUIElement::classList const): Ditto.
492
493         * DumpRenderTree/win/TestRunnerWin.cpp:
494         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
495         (TestRunner::copyEncodedHostName): Ditto.
496         (TestRunner::pathToLocalResource): Ditto.
497         (TestRunner::queueLoad): Ditto.
498         (TestRunner::findString): Ditto.
499         (TestRunner::inspectorTestStubURL): Ditto.
500
501         * TestRunnerShared/Bindings/JSWrapper.h:
502         (WTR::setProperty): Use adopt function instead of constructor.
503         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
504         (UIScriptContext::UIScriptContext): Ditto.
505         (UIScriptContext::runUIScript): Ditto.
506         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
507         (WTR::toDeviceOrientation): Ditto.
508
509         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
510         (nsTextCheckingType): Changed this function to not take an rvalue
511         reference to a JSRetainPtr since it doesn't take ownership.
512         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
513         for the above change.
514
515         * TestWebKitAPI/JavaScriptTest.cpp:
516         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
517         adopt member function.
518
519         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
520         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
521         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
522         adopt constructor.
523         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
524
525         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
526         Removed unneeded includes.
527         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
528         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
529         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
530
531         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
532         (_platformTypeConstructor): Use the adopt function instead of the
533         JSRetainPtr adopt constructor. Also nullptr instead of 0.
534
535         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
536         (WTR::arrayLength): Use adopt function instead of constructor.
537         (WTR::parseModifierArray): Ditto.
538         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
539         (WTR::propertyValue): Ditto.
540         (WTR::dumpPath): Ditto.
541         (WTR::toJS): Ditto.
542         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
543         (WTR::TestRunner::findString): Ditto.
544         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
545         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
546         (WTR::TestRunner::setOpenPanelFiles): Ditto.
547         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
548         (WTR::AccessibilityController::platformName): Ditto.
549
550         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
551         (-[NSString createJSStringRef]): Return a JSRetainPtr.
552         This fixes storage leaks in many functions below, which were using
553         the create function and putting the value right into a JSRetainPtr
554         without adoption.
555         (WTR::createEmptyJSString): Added. This helper function reduces the
556         repetitive code to create empty strings.
557         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
558         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
559         Use createEmptyJSString, fixing a storage leak due to missing adoption.
560         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
561         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
562         (WTR::AccessibilityUIElement::allAttributes): Ditto.
563         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
564         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
565         (WTR::AccessibilityUIElement::role): Ditto.
566         (WTR::AccessibilityUIElement::subrole): Ditto.
567         (WTR::AccessibilityUIElement::roleDescription): Ditto.
568         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
569         (WTR::AccessibilityUIElement::title): Ditto.
570         (WTR::AccessibilityUIElement::orientation const): Ditto.
571         (WTR::AccessibilityUIElement::language): Ditto.
572         (WTR::AccessibilityUIElement::valueDescription): Ditto.
573         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
574         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
575         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
576         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
577         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
578         Use createEmptyJSString, fixing a storage leak due to missing adoption.
579         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
580         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
581         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
582         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
583         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
584         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
585         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
586         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
587         (WTR::AccessibilityUIElement::documentURI): Ditto.
588         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
589         null check.
590         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
591         Use createEmptyJSString, fixing a storage leak due to missing adoption.
592
593         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
594         Use JSRetainPtr for the return value of createJSStringRef.
595         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
596         (-[NSString createJSStringRef]): Ditto.
597         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
598         adopt function instead of the adopt constructor.
599         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
600         (WTR::AccessibilityController::platformName): Ditto
601
602         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
603         (-[NSString createJSStringRef]): Return a JSRetainPtr.
604         (makeValueRefForValue): Updated for above by removing adopt.
605         (makeObjectRefForDictionary): Ditto.
606         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
607
608         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
609         (WTR::createEmptyJSString): Added. This helper function makes reduces the
610         repetitive code to create empty strings.
611         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
612         (WTR::descriptionOfElements): Ditto.
613         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
614         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
615         fixing a storage leak due to missing adoption.
616         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
617         (WTR::AccessibilityUIElement::documentURI): Ditto.
618         (WTR::createJSStringRef): Return a JSRetainPtr.
619
620         * WebKitTestRunner/StringFunctions.h:
621         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
622         (WTR::toJS): Use the adopt function instead of the constructor.
623
624 2018-09-14  Dean Jackson  <dino@grorg.org>
625
626         Add Justin Michaud.
627
628         * Scripts/webkitpy/common/config/contributors.json:
629
630 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
631
632         bots should pass --clobber-old-results to run-webkit-tests
633         https://bugs.webkit.org/show_bug.cgi?id=189623
634
635         Reviewed by Aakash Jain.
636
637         In order to ensure that bots to not produce confusing results due to transient execptions,
638         or run out of space if they continually hit an exception, old layout test results should be clobbered.
639
640         * BuildSlaveSupport/build.webkit.org-config/steps.py:
641         (RunWebKitTests):
642
643 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
644
645         Unreviewed, rolling out r235954.
646
647         Breaks the watchOS build.
648
649         Reverted changeset:
650
651         "Move IndexedDB to Network Process"
652         https://bugs.webkit.org/show_bug.cgi?id=189415
653         https://trac.webkit.org/changeset/235954
654
655 2018-09-13  Daniel Bates  <dabates@apple.com>
656
657         Add Copy WebKit Permalink plugin for Sublime Text
658         https://bugs.webkit.org/show_bug.cgi?id=189589
659
660         Rubber-stamped by Joseph Pecoraro.
661
662         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
663         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
664         active document with or without blame annotations.
665
666         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
667         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
668         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
669         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
670         and Command + Shift + Control + Option + C, respectively.
671
672         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
673         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
674         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
675         * CopyPermalink/Sublime Text/INSTALL: Added.
676         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
677         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
678         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
679
680 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
681
682         Unreviewed. Fix WebDriver tests after r235225.
683
684         Use wpt serve command to run the http server.
685
686         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
687         (WebDriverW3CWebServer.__init__):
688         (WebDriverW3CWebServer.start):
689         (WebDriverW3CWebServer.stop):
690
691 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
692
693         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
694         https://bugs.webkit.org/show_bug.cgi?id=189544
695
696         Reviewed by Michael Catanzaro.
697
698         Add test cases for the new API.
699
700         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
701         (testWebViewJavaScriptDialogs):
702
703 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
704
705         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
706         https://bugs.webkit.org/show_bug.cgi?id=189496
707         <rdar://problem/44370981>
708
709         Unreviewed warning fix.
710
711         r235929 has introduced a new compilation warning:
712         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
713
714         * ImageDiff/cairo/PlatformImageCairo.cpp:
715         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
716
717 2018-09-12  Dan Bernstein  <mitz@apple.com>
718
719         [Cocoa] Complete support for Paste as Quotation
720         https://bugs.webkit.org/show_bug.cgi?id=189504
721
722         Reviewed by Wenson Hsieh.
723
724         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
725
726 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
727
728         Move IndexedDB to Network Process
729         https://bugs.webkit.org/show_bug.cgi?id=189415
730
731         Reviewed by Geoffrey Garen.
732
733         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
734         (TEST):
735         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
736         (TEST):
737         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
738         (TEST):
739         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
740         (TEST):
741         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
742         (TEST):
743
744 2018-09-12  Chris Dumez  <cdumez@apple.com>
745
746         PSON: No process swap on back navigation after URL bar navigation
747         https://bugs.webkit.org/show_bug.cgi?id=189557
748         <rdar://problem/44353108>
749
750         Reviewed by Alex Christensen.
751
752         Add API test coverage.
753
754         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
755
756 2018-09-11  Dean Jackson  <dino@apple.com>
757
758         Header parsing for experimental and internal debug features
759         https://bugs.webkit.org/show_bug.cgi?id=189486
760         <rdar://problem/44320618>
761
762         Reviewed by Tim Horton.
763
764         Keep track of experimental and internal debug features in TestOptions, and
765         allow webkit-test-runner headers to toggle them by name.
766
767         * DumpRenderTree/TestOptions.cpp:
768         (TestOptions::TestOptions):
769         * WebKitTestRunner/TestController.cpp:
770         (WTR::TestController::resetPreferencesToConsistentValues):
771         (WTR::updateTestOptionsFromTestHeader):
772         * WebKitTestRunner/TestOptions.h:
773         (WTR::TestOptions::hasSameInitializationOptions const):
774
775 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
776
777         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
778         https://bugs.webkit.org/show_bug.cgi?id=189492
779
780         Reviewed by Alex Christensen.
781
782         0 and nullptr can't be implicitly converted to
783         AccessibilityUIElement because only Windows port typedefs
784         PlatformUIElement as COMPtr<IAccessible> not a pointer.
785
786         Replaced "return 0" and "return nullptr" with "return { nullptr }".
787
788         * DumpRenderTree/AccessibilityUIElement.cpp:
789         (AccessibilityUIElement::horizontalScrollbar const):
790         (AccessibilityUIElement::verticalScrollbar const):
791         (AccessibilityUIElement::uiElementAttributeValue const):
792         (AccessibilityUIElement::accessibilityElementForTextMarker):
793         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
794         (AccessibilityController::elementAtPoint):
795         (AccessibilityController::accessibleElementById):
796         (AccessibilityController::focusedElement):
797         (AccessibilityController::rootElement):
798         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
799         (AccessibilityUIElement::elementAtPoint):
800         (AccessibilityUIElement::linkedUIElementAtIndex):
801         (AccessibilityUIElement::getChildAtIndex):
802         (AccessibilityUIElement::titleUIElement):
803         (AccessibilityUIElement::parentElement):
804         (AccessibilityUIElement::uiElementForSearchPredicate):
805         (AccessibilityUIElement::cellForColumnAndRow):
806         (AccessibilityUIElement::disclosedRowAtIndex):
807         (AccessibilityUIElement::ariaOwnsElementAtIndex):
808         (AccessibilityUIElement::ariaFlowToElementAtIndex):
809         (AccessibilityUIElement::ariaControlsElementAtIndex):
810         (AccessibilityUIElement::selectedRowAtIndex):
811         (AccessibilityUIElement::rowAtIndex):
812         (AccessibilityUIElement::disclosedByRow):
813         (AccessibilityUIElement::selectedChildAtIndex const):
814
815 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
816
817         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
818         https://bugs.webkit.org/show_bug.cgi?id=189382
819
820         Reviewed by Ryosuke Niwa.
821
822         Fix the test by specifying colors in RGB colorspace.
823
824         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
825         (TestWebKitAPI::TEST):
826
827 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
828
829         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
830         https://bugs.webkit.org/show_bug.cgi?id=189496
831
832         Reviewed by Alex Christensen.
833
834         * ImageDiff/cairo/PlatformImageCairo.cpp:
835         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
836         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
837
838 2018-09-07  Dean Jackson  <dino@apple.com>
839
840         Add and expose Internal features from WebKit
841         https://bugs.webkit.org/show_bug.cgi?id=189442
842         <rdar://problem/44243404>
843
844         Reviewed by Simon Fraser.
845
846         Update MiniBrowser to expose an Internal feature menu.
847
848         * MiniBrowser/mac/AppDelegate.m:
849         (defaultConfiguration):
850         * MiniBrowser/mac/SettingsController.m:
851         (-[SettingsController _populateMenu]):
852         (-[SettingsController validateMenuItem:]):
853         (-[SettingsController toggleExperimentalFeature:]):
854         (-[SettingsController toggleInternalDebugFeature:]):
855
856 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
857
858         [macOS] [WK2] Support changing foreground colors via color panel
859         https://bugs.webkit.org/show_bug.cgi?id=189382
860         <rdar://problem/44227311>
861
862         Reviewed by Ryosuke Niwa.
863
864         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
865         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
866         colors, as well as making different parts of a word different colors.
867
868         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
869         (-[TestWKWebView collapseToEnd]):
870         (webViewForFontManagerTesting):
871         (TestWebKitAPI::TEST):
872         * TestWebKitAPI/cocoa/TestWKWebView.h:
873
874 == Rolled over to ChangeLog-2018-09-11 ==