perf-o-matic should store test results' units
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
2
3         perf-o-matic should store test results' units
4         https://bugs.webkit.org/show_bug.cgi?id=82852
5
6         Reviewed by Kentaro Hara.
7
8         Include units in the results JSON.
9
10         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
11         (PerfTestsRunner._process_chromium_style_test_result):
12         (PerfTestsRunner._process_parser_test_result):
13
14 2012-04-01  Tony Tseung  <tseung@apple.com>
15
16         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
17         composite fonts from existing physical fonts.
18         <rdar://problem/10717370>
19         https://bugs.webkit.org/show_bug.cgi?id=82810
20             
21         A new test font of this kind as been added to the test tools for running the webkit-tests
22
23         Reviewed by Dan Bernstein.
24
25         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
26         Added new dependency SampleFont.sfont
27         
28         * DumpRenderTree/fonts/SampleFont.sfont: Added.
29         
30         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
31         * DumpRenderTree/mac/DumpRenderTree.mm:
32         (allowedFontFamilySet):
33         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
34         
35         (activateTestingFonts):
36         Added the registration of the Composite Font Referene sample font
37         
38         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
39         (WTR::allowedFontFamilySet):
40         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
41
42         (WTR::activateFonts):
43         Added the registration of the Composite Font Referene sample font
44
45         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
46         Added new dependency SampleFont.sfont
47
48         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
49
50 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
51
52         Support the Network Information API
53         https://bugs.webkit.org/show_bug.cgi?id=73528
54
55         Reviewed by Adam Barth.
56
57         Add network information API feature to build script.
58
59         * Scripts/build-webkit:
60
61 2012-03-31  Ojan Vafai  <ojan@chromium.org>
62
63         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
64         https://bugs.webkit.org/show_bug.cgi?id=82839
65
66         Reviewed by Adam Barth.
67
68         Also, update various hard-coded lists for WIN7 and Lion ports.
69         This is necessary since the new list of builders grabbed off the
70         buildbot includes Lion.
71
72         * TestResultServer/static-dashboards/builders.js:
73         (generateWebkitBuildersFromBuilderList):
74         (xhr.onreadystatechange):
75         Don't use dashboard_base's request method to avoid layering violation.
76
77         * TestResultServer/static-dashboards/dashboard_base.js:
78         (parseParameters):
79         (initBuilders):
80         (haveJsonFilesLoaded):
81         (g_handleBuildersListLoaded):
82         Block loading the JSON files for each builder until we actually have a list of builders.
83
84         * TestResultServer/static-dashboards/flakiness_dashboard.html:
85         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
86         (testPlatformAndBuildType):
87         (testGenerateWebkitBuildersFromBuilderList):
88         * TestResultServer/static-dashboards/timeline_explorer.html:
89         * TestResultServer/static-dashboards/treemap.html:
90         Delay generating the page until the builder list has loaded.
91
92 2012-03-31  Ojan Vafai  <ojan@chromium.org>
93
94         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
95         https://bugs.webkit.org/show_bug.cgi?id=82799
96
97         Reviewed by Eric Seidel.
98
99         If we don't run a test, mark it as skipped.
100
101         * Scripts/webkitpy/layout_tests/controllers/manager.py:
102         (Manager._mark_interrupted_tests_as_skipped):
103         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
104         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
105         (ManagerTest.test_interrupt_if_at_failure_limits):
106
107 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
108
109         One more build fix after r112781 for Chromium Windows.
110         Don't copy zip .idb files.
111
112         * BuildSlaveSupport/built-product-archive:
113         (copyBuildFiles):
114
115 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
116
117         Yet another build fix after r112781 for Chromium Windows.
118         Run webkit-build-directory by perl explicitly.
119
120         * BuildSlaveSupport/built-product-archive:
121         (determineWebKitBuildDirectory):
122
123 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
124
125         Fix the syntax error in master.cfg after r112734.
126
127         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
128         (unitTestsSupported):
129
130 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
131
132         Another build fix after r112781.
133
134         * BuildSlaveSupport/built-product-archive:
135         (createZip):
136
137 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
138
139         Build fix after r112781.
140
141         * BuildSlaveSupport/built-product-archive:
142         (createZipManually):
143         (createZip):
144
145 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
146
147         Chromium bots should upload archived built files
148         https://bugs.webkit.org/show_bug.cgi?id=82666
149
150         Reviewed by Tony Chang.
151
152         * BuildSlaveSupport/build.webkit.org-config/config.json:
153         * BuildSlaveSupport/built-product-archive:
154         (main):
155         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
156         call out to webkit-build-directory.
157         (removeDirectoryIfExists): Extracted.
158         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
159         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
160         (createZipManually.addToArchive):
161         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
162         (archiveBuiltProduct): Add support for Chromium port.
163         * Scripts/webkit-build-directory: Add support for --platform options.
164
165 2012-03-30  Dan Bernstein  <mitz@apple.com>
166
167         Reverted r112767, because it caused many vertical text tests to fail.
168
169         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
170         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
171         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
172         * DumpRenderTree/mac/DumpRenderTree.mm:
173         (allowedFontFamilySet):
174         (activateTestingFonts):
175         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
176         (WTR::allowedFontFamilySet):
177         (WTR::activateFonts):
178         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
179         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
180
181 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
182
183         [wx] Move wxWebKit API into WebKit namespace.
184         https://bugs.webkit.org/show_bug.cgi?id=82740
185
186         Reviewed by Kevin Ollivier.
187
188         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
189         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
190         (LayoutWebViewEventHandler::bindEvents):
191         (LayoutWebViewEventHandler::OnLoadEvent):
192         (LayoutWebViewEventHandler::OnAlertEvent):
193         (LayoutWebViewEventHandler::OnConfirmEvent):
194         (LayoutWebViewEventHandler::OnPromptEvent):
195         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
196         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
197         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
198         (LayoutWebViewEventHandler):
199         (dumpFramesAsText):
200         (dump):
201         (MyApp::OnInit):
202         * wx/browser/browser.cpp:
203         (MyApp::OnInit):
204
205 2012-03-30  Eli Fidler  <efidler@rim.com>
206
207         Enable OpenType Sanitizer for BlackBerry port.
208         https://bugs.webkit.org/show_bug.cgi?id=82782
209
210         Reviewed by Eric Seidel.
211
212         * Scripts/webkitdirs.pm:
213         (blackberryCMakeArguments): add OTS to include path
214
215 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
216
217         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
218         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
219         is found.
220
221         <rdar://problem/11158581>
222         
223         Reviewed by Mark Rowe.
224
225         * Scripts/webkitpy/layout_tests/port/webkit.py:
226         (WebKitDriver._start):
227
228 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
229
230         Disable run-api-tests on release mac builds
231         https://bugs.webkit.org/show_bug.cgi?id=82788
232
233         Reviewed by Ryosuke Niwa.
234         
235         TestWebKitAPI crashes every time in release builds currently
236         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
237         run-api-tests on mac release builders.
238
239         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
240         (unitTestsSupported):
241
242 2012-03-30  Chang Shu  <cshu@webkit.org>
243
244         Unreviewed. Update my email.
245
246         * Scripts/webkitpy/common/config/committers.py:
247
248 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
249
250         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
251         https://bugs.webkit.org/show_bug.cgi?id=82745
252
253         Reviewed by Simon Fraser.
254
255         * DumpRenderTree/AccessibilityUIElement.cpp:
256         (rangeForPositionCallback):
257         (AccessibilityUIElement::rangeForPosition):
258         (AccessibilityUIElement::getJSClass):
259         * DumpRenderTree/AccessibilityUIElement.h:
260         (AccessibilityUIElement):
261         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
262         (AccessibilityUIElement::rangeForPosition):
263         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
264         (WTR::AccessibilityUIElement::rangeForPosition):
265         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
266         (AccessibilityUIElement):
267         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
268         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
269         (WTR::AccessibilityUIElement::rangeForPosition):
270         (WTR):
271
272 2012-03-30  David Barr  <davidbarr@chromium.org>
273
274         Split up top-level .gitignore and .gitattributes
275         https://bugs.webkit.org/show_bug.cgi?id=82687
276
277         Reviewed by Tor Arne Vestbø.
278
279         * .gitattributes: Added.
280         * .gitignore: Added.
281         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
282         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
283
284 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
285
286         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
287
288         * TestResultServer/static-dashboards/builders.js:
289
290 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
291
292         Update ChromiumOS bot names in builders.js to reflect changes made by
293         http://crrev.com/129835
294         
295         Also removes the ChromiumOS GTK builder, which was removed by
296         http://crrev.com/129835
297
298         * TestResultServer/static-dashboards/builders.js:
299
300 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
301
302         [GTK] Disable introspection build in the at-spi2-core module.
303         https://bugs.webkit.org/show_bug.cgi?id=82729
304
305         Reviewed by Philippe Normand.
306
307         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
308
309         * gtk/jhbuild.modules: Disable introspection.
310
311 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
312
313         Add a "preview" state to Page Visibility API implementation
314         https://bugs.webkit.org/show_bug.cgi?id=81355
315
316         Reviewed by Adam Barth.
317
318         Updating the Page Visibility API implementation to the current spec version.
319
320         * DumpRenderTree/chromium/LayoutTestController.cpp:
321         (LayoutTestController::setPageVisibility):
322
323 2012-03-30  Keishi Hattori  <keishi@webkit.org>
324
325         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
326         https://bugs.webkit.org/show_bug.cgi?id=80972
327
328         Reviewed by Kent Tamura.
329
330         * Scripts/build-webkit:
331         * qmake/mkspecs/features/features.prf:
332
333 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
334
335         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
336         https://bugs.webkit.org/show_bug.cgi?id=82195
337
338         Reviewed by Simon Hausmann.
339
340         * MiniBrowser/qt/BrowserWindow.cpp:
341         (BrowserWindow::updateVisualMockTouchPoints):
342         * MiniBrowser/qt/main.cpp:
343         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
344         (WTR::WrapperWindow::handleStatusChanged):
345         * qmake/mkspecs/features/unix/default_post.prf:
346
347 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
348
349         [EFL] Implement LayoutTestController::setMinimumTimerInterval
350         https://bugs.webkit.org/show_bug.cgi?id=81220
351
352         Add missing implementation setMinimumTimerInterval to EFL's
353         LayoutTestController so that we can unskip related tests from the skip list.
354
355         Reviewed by Philippe Normand.
356
357         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
358         (LayoutTestController::setMinimumTimerInterval):
359
360 2012-03-29  Dan Bernstein  <mitz@apple.com>
361
362         Removed “Intel” from the Lion builders’ names.
363
364         Rubber-stamped by Mark Rowe.
365
366         * BuildSlaveSupport/build.webkit.org-config/config.json:
367         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
368         (LeaksViewer._displayURLPrompt):
369
370 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
371
372         [Chromium] Add sharded ChromiumOS debug bots to builders.js
373         https://bugs.webkit.org/show_bug.cgi?id=82639
374
375         Reviewed by Eric Seidel.
376
377         The bots were sharded by http://crrev.com/129613, update builders.js
378         to reflect this.
379
380         * TestResultServer/static-dashboards/builders.js:
381
382 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
383
384         remove support for junit-style xml output from test-webkitpy
385         https://bugs.webkit.org/show_bug.cgi?id=82279
386
387         Reviewed by Eric Seidel.
388
389         This was added when we were looking into integrating w/ Jenkins
390         rather than buildbot, but I believe that project got shelved, so
391         this is unused. We can always add it back in later as necessary.
392
393         * Scripts/webkitpy/test/main.py:
394         (Tester._parse_args):
395         (Tester._run_tests):
396         * Scritps/webkitpy/thirdparty/__init__.py:
397
398 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
399
400         new-run-webkit-tests: crashes when it fails to decode a stack trace
401         https://bugs.webkit.org/show_bug.cgi?id=82673
402
403         Unreviewed, build fix.
404
405         We are assuming the stdout/stderr output from the driver is utf-8
406         encoded when we get stack traces; this may not be a valid
407         assumption generally, but if we do get strings that aren't valid
408         utf-8, we would crash. Now we will ignore any decoding errors.
409
410         * Scripts/webkitpy/layout_tests/port/base.py:
411         (Port._get_crash_log):
412         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
413         (PortTestCase.test_get_crash_log):
414
415 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
416
417         Scripts fail to detect when a tool crashes
418         https://bugs.webkit.org/show_bug.cgi?id=82659
419
420         Reviewed by Mark Rowe.
421         
422         Have exitStatus() detect when the process fail to exit cleanly
423         (possibly because of a crash), and return a non-zero exit code
424         in that case.
425
426         * Scripts/VCSUtils.pm:
427         (exitStatus):
428
429 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
430
431         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
432         https://bugs.webkit.org/show_bug.cgi?id=82581
433
434         Reviewed by Martin Robinson.
435
436         Running Javascriptcore tests through jhbuild
437         for consistency with run-webkit-tests and in order to
438         avoid confusing libraries when facing regressions.
439
440         * Scripts/run-javascriptcore-tests:
441
442 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
443
444         test-webkitpy: add --timing
445         https://bugs.webkit.org/show_bug.cgi?id=82550
446
447         Reviewed by Eric Seidel.
448
449         This patch adds a --timing option that will display the time
450         each test takes. It also removes the --silent option, since
451         probably no one ever used it, and cleans up the logging
452         option parsing code to be easier to follow.
453
454         * Scripts/webkitpy/test/main.py:
455         (Tester._parse_args):
456         (Tester._configure):
457         * Scripts/webkitpy/test/runner.py:
458         (TestRunner.write_result):
459         * Scripts/webkitpy/test/runner_unittest.py:
460         (RunnerTest.test_regular):
461         (RunnerTest.test_verbose):
462         (RunnerTest):
463         (RunnerTest.test_timing):
464
465 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
466
467         HashMap<>::add should return a more descriptive object
468         https://bugs.webkit.org/show_bug.cgi?id=71063
469
470         Reviewed by Ryosuke Niwa.
471
472         Update code to use AddResult instead of a pair.
473
474         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
475         (LayoutTestController::evaluateScriptInIsolatedWorld):
476         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
477         (LayoutTestController::evaluateScriptInIsolatedWorld):
478         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
479         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
480
481 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
482
483         Web Inspector: chromium: DRT --no-timeout option doesn't work.
484         https://bugs.webkit.org/show_bug.cgi?id=82608
485
486         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
487         This was broken by r112354 and the sequence became opposite.
488
489         Reviewed by Yury Semikhatsky.
490
491         * DumpRenderTree/chromium/TestShell.cpp:
492         (TestShell::TestShell):
493         (TestShell::initialize):
494
495 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
496
497         Remove custom bindings form Internals.idl of attribute type Array.
498         https://bugs.webkit.org/show_bug.cgi?id=82319
499
500         Reviewed by Kentaro Hara.
501
502         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
503
504         * GNUmakefile.am:
505
506 2012-03-28  Mark Rowe  <mrowe@apple.com>
507
508         Fix --no-saved-state.
509
510         Ignore the flag before Lion, rather than making it specific to Lion.
511
512         Rubber-stamped by Dan Bernstein.
513
514         * Scripts/webkitdirs.pm:
515         (argumentsForRunAndDebugMacWebKitApp):
516
517 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
518
519         Add dtharp to contributors list
520         https://bugs.webkit.org/show_bug.cgi?id=82545
521
522         Reviewed by Adam Barth.
523
524         Adding dtharp as Contributor.
525
526         * Scripts/webkitpy/common/config/committers.py:
527
528 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
529
530         build-webkit : the word "pass" is spelled incorrectly as "passs"
531         https://bugs.webkit.org/show_bug.cgi?id=82532
532
533         Reviewed by Julien Chaffraix.
534
535         Corrected spelling of the word "pass" in build-webkit.
536
537         * Scripts/build-webkit:
538
539 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
540
541         new-run-webkit-tests doesn't log correctly after retrying failures
542         https://bugs.webkit.org/show_bug.cgi?id=82541
543
544         Unreviewed, build fix.
545
546         r112189 introduced a regression where we would accidentally
547         delete the log handler after we retried any failing tests - that
548         meant that any log messages around uploading the results got
549         dropped.
550
551         * Scripts/webkitpy/layout_tests/controllers/manager.py:
552         (Manager._run_tests):
553
554 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
555
556         [wx] Unreviewed. Build fix, move WTF back into JSCore target
557         until issues with JSCore not linking in all WTF symbols are resolved.
558
559         * waf/build/settings.py:
560
561 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
562
563         download-built-product build step should detect 404 errors
564         https://bugs.webkit.org/show_bug.cgi?id=82491
565
566         Reviewed by Ryosuke Niwa.
567         
568         Pass --fail to curl so that it reports 404 errors.
569
570         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
571         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
572         * BuildSlaveSupport/built-product-archive:
573         (extractBuiltProduct): Remove trailing whitespace.
574
575 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
576
577         flakiness dashboard should only keep the last 500 runs
578         https://bugs.webkit.org/show_bug.cgi?id=82530
579
580         Reviewed by Ojan Vafai.
581
582         If a bot has an overly large amount of failing tests, then
583         storing 750 runs' worth takes a lot of memory and CPU time to
584         process and we end up getting killed by AppEngine; this cases
585         data corruption and confusion down the road when we have to
586         retry the upload of the data and the tests show up as multiple
587         runs.
588
589         * TestResultServer/model/jsonresults.py:
590         (JsonResults.update_file):
591
592 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
593
594         extract-built-product build step should fail if unzipping fails
595         https://bugs.webkit.org/show_bug.cgi?id=82493
596
597         Reviewed by Simon Fraser.
598
599         Forward non-zero exit code from subprocesses so that the master can detect any failures
600         and bail out early.
601
602         * BuildSlaveSupport/built-product-archive:
603         (main):
604
605 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
606
607         test-webkitpy should support files, directories, and packages as command line args
608         https://bugs.webkit.org/show_bug.cgi?id=76765
609
610         Reviewed by Adam Barth.
611
612         This patch adds support for specifying files, directories, and
613         packages to test-webkitpy along with the already existing
614         support for modules, test classes, and individual test names.
615
616         Also, fix a bug in filesystem_mock where we wouldn't normalize a
617         path containing a reference to the current directory properly,
618         for example, '/foo/./bar.py'.
619
620         * Scripts/webkitpy/common/system/filesystem_mock.py:
621         (MockFileSystem.normpath):
622         * Scripts/webkitpy/test/main.py:
623         (Tester._configure_logging):
624         (Tester._run_tests):
625         * Scripts/webkitpy/test/test_finder.py:
626         (TestDirectoryTree.find_modules):
627         (TestDirectoryTree.subpath):
628         (TestFinder.is_dotted_name):
629         (TestFinder.find_names):
630         (TestFinder):
631         (TestFinder._find_names_for_arg):
632         (TestFinder._find_in_trees):
633         (TestFinder._default_names):
634         * Scripts/webkitpy/test/test_finder_unittest.py:
635         (TestFinderTest.setUp):
636         (TestFinderTest.tearDown):
637         (TestFinderTest.check_names):
638         (TestFinderTest.test_default_names):
639         (TestFinderTest):
640         (TestFinderTest.test_paths):
641
642 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
643
644         Fix inspector tests when running in internal builds.
645
646         <rdar://problem/11050694>
647
648         Reviewed by Tim Hatcher.
649
650         * DumpRenderTree/mac/DumpRenderTree.mm:
651         (resetDefaultsToConsistentValues):
652         * WebKitTestRunner/TestController.cpp:
653         (WTR::TestController::resetStateToConsistentValues):
654
655 2012-03-28  David Kilzer  <ddkilzer@apple.com>
656
657         Use xcrun to find nm and ranlib on OS X builds
658         <http://webkit.org/b/82466>
659
660         Reviewed by Dan Bernstein.
661
662         * Scripts/build-webkit: Use xcrun to find ranlib.
663         * Scripts/webkitdirs.pm:
664         (determineNmPath): Added.  Use xcrun to find nm on OS X.
665         (nmPath): Added.
666         * Scripts/webkitperl/features.pm:
667         (libraryContainsSymbol): Use nmPath().
668
669 2012-03-28  Ojan Vafai  <ojan@chromium.org>
670
671         Add history navigation to garden-o-matic
672         https://bugs.webkit.org/show_bug.cgi?id=82495
673
674         Reviewed by Dimitri Glazkov.
675
676         Also, maintain scroll offsets when returning to a tab. This makes addressing
677         expected failures considerably easier when dealing with below-the-fold tests.
678
679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
680         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
681         switching.
682         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
683         from a file URL and Chrome puts each different file URL in it's own origin.
684
685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
686         Remove the href so that clicking on the accordion item does not modify window.location.hash.
687
688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
690
691 2012-03-28  Philippe Normand  <pnormand@igalia.com>
692
693         [GTK] generate-gtk-doc doesn't cope with custom build directory
694         https://bugs.webkit.org/show_bug.cgi?id=82448
695
696         Reviewed by Martin Robinson.
697
698         Pass the product directory in generate-gtkdoc arguments from
699         build-webkit.
700
701         * Scripts/webkitdirs.pm:
702         (buildAutotoolsProject):
703         * gtk/common.py:
704         (get_build_path):
705
706 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
707
708         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
709         https://bugs.webkit.org/show_bug.cgi?id=82341
710
711         Reviewed by Martin Robinson.
712
713         Add --skipped=skip|ignore|only command line option.
714
715         * Scripts/run-gtk-tests:
716         (TestRunner._test_cases_to_skip): Return the list of test cases
717         to skip for the given test depending on the skipped action.
718         (TestRunner._should_run_test): Decide whether to run the test or
719         not depending on the skipped action.
720         (TestRunner.run_tests): Only show the list of skipped tests when
721         skipped action is 'skip'.
722
723 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
724
725         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
726         https://bugs.webkit.org/show_bug.cgi?id=82333
727
728         Reviewed by Martin Robinson.
729
730         * Scripts/run-gtk-tests:
731         (TestRunner.SkippedTest): Add SkippedTest class to store more
732         information about skipped tests.
733         (TestRunner._setup_testing_environment): Use SkippedTest to add
734         TestWebKitAccessibility to the skipped list.
735         (TestRunner._find_skipped_test): Return the SkippedTest object for
736         a given test path.
737         (TestRunner._test_cases_to_skip): Returns the list of test cases
738         that should be skipped for a given test path.
739         (TestRunner._should_run_test): Helper funtion to decide whether
740         the given test path should be run or not. Tests in the skipped
741         list that don't have a list of failing test cases are not run at
742         all. Tests in the skipped list that contain a list of test cases
743         are run with gtester -s to skip the individual test cases.
744         (TestRunner._run_test): Helper funtion to run a given test.
745         (TestRunner.run_tests): Build the list of tests to run based on
746         _should_run_test() and use helper function _run_test() to run
747         every test.
748
749 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
750
751         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
752         https://bugs.webkit.org/show_bug.cgi?id=52810
753
754         Reviewed by Simon Hausmann.
755
756         Use SSE2 floating point math on 32 bit instead of the default
757         387 to make layout test result same on 32 and on 64 bit builds.
758
759         * qmake/mkspecs/features/unix/default_post.prf:
760
761 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
762
763         [Soup] DNS prefetching spams resolver, shoots self in the foot
764         https://bugs.webkit.org/show_bug.cgi?id=41630
765
766         Reviewed by Martin Robinson.
767
768         Bump libsoup and glib dependencies.
769
770         * efl/jhbuild.modules:
771         * gtk/jhbuild.modules:
772
773 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
774
775         [GTK] Disable introspection for jhbuild modules
776         https://bugs.webkit.org/show_bug.cgi?id=82395
777
778         Reviewed by Philippe Normand.
779
780         * efl/jhbuild.modules: add --disable-introspection to all modules
781         that support it
782         * gtk/jhbuild.modules: ditto.
783
784 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
785
786         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
787
788         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
789         (BuildAndTestFactory.__init__):
790
791 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
792
793         [Qt] Unreviewed typo fix after r112383.
794
795         * Scripts/run-qtwebkit-tests:
796         (Main.check_crash_occurences):
797
798 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
799
800         [Qt] run-qtwebkit-tests should report crashes
801         https://bugs.webkit.org/show_bug.cgi?id=76905
802
803         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
804         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
805
806         Reviewed by Csaba Osztrogonác.
807
808         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
809         (RunQtAPITests.commandComplete):
810         (RunQtAPITests.evaluateCommand):
811         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
812         (RunQtAPITestsTest):
813         (test_failure):
814         (test_crash):
815         * Scripts/run-qtwebkit-tests:
816         (Main.announce_results_html):
817         (Main):
818         (Main.check_crash_occurences):
819         (Main.convert_to_stdout):
820         (Main.convert_to_html):
821
822 2012-03-28  Kwonjin Jeong  <gram@company100.net>
823
824         Add support for Intel compiler on Linux QT port.
825         https://bugs.webkit.org/show_bug.cgi?id=81077
826
827         Reviewed by Tor Arne Vestbø.
828
829         * qmake/mkspecs/features/default_post.prf:
830         Don't hide symbols when building with Intel compiler.
831         The symbols are needed when building QtWebKit tests.
832
833         * qmake/mkspecs/features/unix/icc.prf:
834         Added to ignore icc-specific warnings.
835         This feature is used with command-line arguments for build-webkit script.
836
837 2012-03-28  Philippe Normand  <pnormand@igalia.com>
838
839         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
840
841         * Scripts/update-webkitgtk-libs: This script is written in
842         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
843
844 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
845
846         kill-old-processes doesn't do anything on linux
847         https://bugs.webkit.org/show_bug.cgi?id=82388
848
849         Reviewed by Tony Chang.
850
851         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
852         This should help stabilizing Chromium linux bots.
853
854         * BuildSlaveSupport/kill-old-processes:
855
856 2012-03-28  Philippe Normand  <pnormand@igalia.com>
857
858         [GTK] jhbuild wrongly tricked into clean-up
859         https://bugs.webkit.org/show_bug.cgi?id=82216
860
861         Reviewed by Gustavo Noronha Silva.
862
863         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
864         build tree. Also when checking if the jhbuild configuration
865         changed use absolute md5sum paths.
866
867         * Scripts/webkitdirs.pm:
868         (runAutogenForAutotoolsProjectIfNecessary):
869         (jhbuildConfigurationChanged):
870         (buildAutotoolsProject):
871
872 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
873
874         kill-old-processes doesn't do anything on linux
875         https://bugs.webkit.org/show_bug.cgi?id=82388
876
877         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
878
879         The platform in Factory comes from config.json, accordingly platform is fullplatform,
880         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
881
882         Reviewed by Ryosuke Niwa.
883
884         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
885         (Factory.__init__):
886
887 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
888
889         Make Chromium port for Android use hardware gpu path default.
890         https://bugs.webkit.org/show_bug.cgi?id=82033
891
892         Reviewed by Dirk Pranke.
893
894         Skip canvas tests, which are run in virtual gpu test suites.
895
896         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
897         (ChromiumAndroidPort.__init__):
898         (ChromiumAndroidPort.skipped_tests):
899
900 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
901
902         kill-old-processes doesn't do anything on linux
903         https://bugs.webkit.org/show_bug.cgi?id=82388
904
905         Disable kill-old-processes on the Qt bots not to kill each others.
906
907         Reviewed by Ryosuke Niwa.
908
909         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
910         (Factory.__init__):
911
912 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
913
914         Handle DRT crash caused by Android OOM.
915         https://bugs.webkit.org/show_bug.cgi?id=82310
916
917         Reviewed by Tony Chang.
918
919         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
920         is stopped silently and regarded as crashed. Re-run the test for
921         such crash.
922
923         Add some debug log to NRWT.
924
925         * Scripts/webkitpy/layout_tests/port/chromium.py:
926         (ChromiumDriver.run_test):
927         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
928         (ChromiumAndroidPort.__init__):
929         (ChromiumAndroidPort.get_last_stacktrace):
930         (ChromiumAndroidDriver.__init__):
931         (ChromiumAndroidDriver._start):
932         (ChromiumAndroidDriver.run_test):
933         (ChromiumAndroidDriver._get_drt_return_value):
934
935 2012-03-27  Ojan Vafai  <ojan@chromium.org>
936
937         Fix expected results for some unittest failures.
938
939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
940
941 2012-03-27  Adrienne Walker  <enne@google.com>
942
943         [chromium] Fix --enabled-threaded-compositing flag in DRT
944         https://bugs.webkit.org/show_bug.cgi?id=82405
945
946         Reviewed by James Robinson.
947
948         --enable-threaded-compositing wasn't working because there was no way
949         to set the value before it was used in the TestShell constructor.
950
951         To avoid adding yet another boolean parameter to TestShell's
952         constructor, add an explicit initialize function that can operate on
953         any boolean settings that are set post-constructor.
954
955         * DumpRenderTree/chromium/DumpRenderTree.cpp:
956         (main):
957         * DumpRenderTree/chromium/TestShell.cpp:
958         (TestShell::TestShell):
959         (TestShell::initialize):
960         * DumpRenderTree/chromium/TestShell.h:
961         (TestShell):
962         (TestShell::setTestShellMode):
963
964 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
965
966         new-run-webkit-tests: suppress debug output from run-safari on results file
967         https://bugs.webkit.org/show_bug.cgi?id=82400
968
969         Reviewed by Ryosuke Niwa.
970
971         Send the run-safari output to /dev/null rather than the console.
972
973         * Scripts/webkitpy/layout_tests/port/mac.py:
974         (MacPort.show_results_html_file):
975
976 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
977
978         Improve error reporting in run-javascriptcore-tests
979         https://bugs.webkit.org/show_bug.cgi?id=82379
980
981         Reviewed by Jessie Berlin.
982         
983         When the script dies, have it print out the reason for dying.
984
985         * Scripts/run-javascriptcore-tests:
986
987 2012-03-27  Eric Seidel  <eric@webkit.org>
988
989         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
990         https://bugs.webkit.org/show_bug.cgi?id=82373
991
992         Reviewed by Ryosuke Niwa.
993
994         Dave's committer-status in in-progress, so until then
995         list him as a Contributor so at least I can more easily CC him on bugs.
996
997         * Scripts/webkitpy/common/config/committers.py:
998
999 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1000
1001         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
1002         https://bugs.webkit.org/show_bug.cgi?id=82252
1003
1004         Reviewed by Gustavo Noronha Silva.
1005
1006         Appending the directory containing common.py may be problematic if
1007         another path in sys.path also contains either a common.py or a
1008         common/ module, so prepend to select our version instead. This is
1009         the case with fail2ban, which has a common/ directory which may
1010         end up being in Python's default path.
1011
1012         * efl/jhbuildrc:
1013         * gtk/jhbuildrc:
1014
1015 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
1016
1017         test-webkitpy: prepare for better test run output
1018         https://bugs.webkit.org/show_bug.cgi?id=82290
1019
1020         Reviewed by Adam Barth.
1021
1022         This code basically re-implements the output of the TextTestRunner default
1023         runner code from unittest, although the implementation is quite
1024         different, in preparation for changing the test output to be
1025         metered and possibly running in parallel.
1026
1027         The output is almost identical to before, except that instead of
1028         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
1029         "webkitpy.main.RunnerTest.test_regular passed". It has always
1030         annoyed me that they invert the names to be harder to read and
1031         so that you can't copy & paste back to the input for
1032         test-webkitpy.
1033
1034         This patch is provided to add a skeleton for unit tests and for
1035         comparison to an upcoming patch that will actually add new
1036         functionality.
1037
1038         * Scripts/webkitpy/test/main.py:
1039         (Tester.__init__):
1040         (Tester._configure_logging):
1041         (Tester._run_tests):
1042         * Scripts/webkitpy/test/runner.py: Added.
1043         (TestRunner):
1044         (TestRunner.__init__):
1045         (TestRunner.test_name):
1046         (TestRunner.all_test_names):
1047         (TestRunner.run):
1048         (TestRunner.write_result):
1049         (TestRunner.write_summary):
1050         * Scripts/webkitpy/test/runner_unittest.py: Added.
1051         (FakeModuleSuite):
1052         (FakeModuleSuite.__init__):
1053         (FakeModuleSuite.__str__):
1054         (FakeModuleSuite.run):
1055         (FakeTopSuite):
1056         (FakeTopSuite.__init__):
1057         (FakeLoader):
1058         (FakeLoader.__init__):
1059         (FakeLoader.top_suite):
1060         (FakeLoader.loadTestsFromName):
1061         (RunnerTest):
1062         (RunnerTest.test_regular):
1063         (RunnerTest.test_verbose):
1064
1065 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1066
1067         [GTK] Build gnutls without p11-kit support
1068         https://bugs.webkit.org/show_bug.cgi?id=82212
1069
1070         Reviewed by Martin Robinson.
1071
1072         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
1073         configure, to avoid requiring that dependency, which is not used
1074         by libsoup and WebKit anyway
1075
1076 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1077
1078         [Qt] Make debug build work on 32 bit
1079         https://bugs.webkit.org/show_bug.cgi?id=82331
1080
1081         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
1082         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
1083
1084         Reviewed by Tor Arne Vestbø.
1085
1086         * qmake/mkspecs/features/unix/default_post.prf:
1087         * qmake/mkspecs/features/unix/default_pre.prf:
1088
1089 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
1090
1091         Add png checking to check-webkit-style
1092         https://bugs.webkit.org/show_bug.cgi?id=75824
1093
1094         Reviewed by NOBODY Tony Chang.
1095
1096         * Scripts/webkitpy/style/checker.py:
1097         (_all_categories):
1098         (FileType):
1099         (CheckerDispatcher._should_skip_file_path):
1100         (CheckerDispatcher._file_type):
1101         (CheckerDispatcher._create_checker):
1102         * Scripts/webkitpy/style/checker_unittest.py:
1103         (CheckerDispatcherDispatchTest.test_none_paths):
1104         * Scripts/webkitpy/style/checkers/png.py: Added.
1105         (PNGChecker):
1106         (PNGChecker.__init__):
1107         (PNGChecker.check):
1108         (PNGChecker._config_file_path):
1109         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
1110         (MockSCMDetector):
1111         (MockSCMDetector.__init__):
1112         (MockSCMDetector.display_name):
1113         (MockSCMDetector.propget):
1114         (PNGCheckerTest):
1115         (PNGCheckerTest.test_init):
1116         (PNGCheckerTest.test_init.mock_handle_style_error):
1117         (PNGCheckerTest.test_check):
1118         (PNGCheckerTest.test_check.mock_handle_style_error):
1119         * Scripts/webkitpy/style/patchreader.py:
1120         (PatchReader.check):
1121
1122 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1123
1124         Unreviewed. Skip GTK+ unit tests that fail in the bots
1125
1126         * Scripts/run-gtk-tests:
1127         (TestRunner): Add failing tests to the skipped list.
1128
1129 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1130
1131         Unreviewed. Unskip all GTK+ unit test.
1132
1133         Currently, skipped tests contains the list of unit tests that have
1134         failed in one or more bots. In this moment it's not possible to
1135         skip just the test cases that fail, so the complete unit test is
1136         skipped when a single test case fails. For that reason, we don't
1137         know which test cases are actually failing for every skipped
1138         test. We are planning to land a patch to allow skipping individual
1139         test cases, but first we need to know which test cases are
1140         currently failing in the bots to skip them. So, this patch simply
1141         unskips all unit tests in order to watch the bots and get the list
1142         of test cases failing. Failing tests will be skipped again as soon
1143         as we have the new list of failing test cases.
1144
1145         * Scripts/run-gtk-tests:
1146         (TestRunner): Reset the list of skipped tests.
1147
1148 2012-03-26  Scott Byer  <scottbyer@chromium.org>
1149
1150         Enable layout testing of the scroll animator.
1151         https://bugs.webkit.org/show_bug.cgi?id=81858
1152         Add a call to the InternalSettings that layout tests can use to
1153         turn on scroll animation. Enable animation updates for the
1154         Chromium platform DRT when scroll animation has been turned on in
1155         a test. This should be a no-op for all current layout tests.
1156
1157         Reviewed by James Robinson.
1158
1159         * DumpRenderTree/chromium/WebViewHost.cpp:
1160         (WebViewHost::serviceAnimation):
1161         (WebViewHost::scheduleAnimation):
1162         * DumpRenderTree/chromium/WebViewHost.h:
1163         (WebViewHost):
1164
1165 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
1166
1167         [Qt][WK2] Support multi-file upload
1168         https://bugs.webkit.org/show_bug.cgi?id=81589
1169
1170         Reviewed by Simon Hausmann.
1171
1172         Modified filePicker to support multi-file upload.
1173
1174         * MiniBrowser/qt/MiniBrowser.qrc:
1175         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
1176         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
1177         * MiniBrowser/qt/js/MultiSelect.js: Added.
1178         (values):
1179         (isSelected):
1180         (removeValue):
1181         * MiniBrowser/qt/qml/CheckBox.qml: Added.
1182         * MiniBrowser/qt/qml/FilePicker.qml:
1183
1184 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1185
1186         Retry crashing tests serially at the end of NRWT on Apple Mac
1187         https://bugs.webkit.org/show_bug.cgi?id=82233
1188
1189         Reviewed by Dirk Pranke.
1190
1191         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1192         (Manager.run):
1193         * Scripts/webkitpy/layout_tests/port/base.py:
1194         (Port.should_retry_crashes):
1195         * Scripts/webkitpy/layout_tests/port/mac.py:
1196         (MacPort.should_retry_crashes):
1197
1198 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1199
1200         NRWT should retry failures serially
1201         https://bugs.webkit.org/show_bug.cgi?id=82241
1202
1203         Reviewed by Dirk Pranke.
1204
1205         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1206         (Manager._run_tests): Add another parameter to specify the number of workers to use.
1207         (Manager.run): Run the failures serially.
1208
1209 2012-03-26  Adrienne Walker  <enne@google.com>
1210
1211         Allow expectations on directories in virtual test suites
1212         https://bugs.webkit.org/show_bug.cgi?id=82250
1213
1214         Reviewed by Dirk Pranke.
1215
1216         lookup_virtual_test_base was only returning valid results for files
1217         and not directories. Fix by falling back to the virtual test suite
1218         mapping if possible.
1219
1220         * Scripts/webkitpy/layout_tests/port/base.py:
1221         (Port.lookup_virtual_test_base):
1222         * Scripts/webkitpy/layout_tests/port/test.py:
1223         (TestPort.skipped_tests):
1224         (TestPort.virtual_test_suites):
1225
1226 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1227
1228         Fix duplicated ChangeLog entry from r112171.
1229
1230         Unreviewed, build fix.
1231
1232 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1233
1234         nrwt: remove --worker-model flag
1235         https://bugs.webkit.org/show_bug.cgi?id=82112
1236
1237         Reviewed by Adam Barth.
1238
1239         The --worker-model=inline flag is basically redundant with the
1240         --child-processes=1 flag (technically, you could one run child
1241         process, but this is only useful for testing); this patch
1242         removes this flag, which simplifies things and enables more
1243         cleanup down the road.
1244
1245         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1246         (Manager._run_tests):
1247         (Manager.print_config):
1248         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1249         (get):
1250         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1251         (make_broker):
1252         (FunctionTests.test_get__inline):
1253         (FunctionTests.test_get__processes):
1254         (_TestsMixin.setUp):
1255         (_TestsMixin.make_broker):
1256         (InlineBrokerTests.setUp):
1257         (MultiProcessBrokerTests.setUp):
1258         * Scripts/webkitpy/layout_tests/port/base.py:
1259         (Port.default_child_processes):
1260         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1261         (ChromiumAndroidPort.check_sys_deps):
1262         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1263         (ChromiumAndroidPortTest):
1264         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1265         (MockDRTPortTest.make_port):
1266         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1267         (PortTestCase):
1268         (PortTestCase.make_port):
1269         * Scripts/webkitpy/layout_tests/port/test.py:
1270         (TestPort.default_child_processes):
1271         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1272         (_set_up_derived_options):
1273         (parse_args):
1274         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1275         (parse_args):
1276         (MainTest.test_batch_size):
1277         (MainTest.test_child_processes_2):
1278         (MainTest.test_child_processes_min):
1279         (MainTest.test_exception_raised):
1280         (MainTest.test_keyboard_interrupt):
1281         (MainTest.test_exit_after_n_crashes):
1282         (MainTest.assert_run_order):
1283         (MainTest.test_run_order__inline):
1284         (MainTest.test_virtual):
1285
1286 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1287
1288         test-webkitpy: split test-finding code into a different module
1289         https://bugs.webkit.org/show_bug.cgi?id=82253
1290
1291         Reviewed by Adam Barth.
1292
1293         Per suggestion from abarth, this change splits all the
1294         filesystem-crawling, test-finding code in test-webkitpy out into
1295         a separate module and switches to using a FileSystem object.
1296         This makes things much more testable, so we also add tests :).
1297
1298         We also add a realpath() method to the Filesystem object, since
1299         test-webkitpy needs that in order to be able to resolve symlinks
1300         properly to determine whether a file is under a particular tree
1301         or not.
1302
1303         * Scripts/webkitpy/common/system/filesystem.py:
1304         (FileSystem.realpath):
1305         * Scripts/webkitpy/common/system/filesystem_mock.py:
1306         (MockFileSystem.realpath):
1307         * Scripts/webkitpy/test/main.py:
1308         (Tester.__init__):
1309         (Tester.add_tree):
1310         (Tester.run):
1311         (Tester._run_tests):
1312         (Tester._log_exception):
1313         * Scripts/webkitpy/test/test_finder.py: Added.
1314         (TestDirectoryTree):
1315         (TestDirectoryTree.__init__):
1316         (TestDirectoryTree.find_modules):
1317         (TestDirectoryTree.find_modules.file_filter):
1318         (TestDirectoryTree.to_module):
1319         (TestDirectoryTree.clean):
1320         (TestFinder):
1321         (TestFinder.__init__):
1322         (TestFinder.add_tree):
1323         (TestFinder.additional_paths):
1324         (TestFinder.clean_trees):
1325         (TestFinder.is_module):
1326         (TestFinder.to_module):
1327         (TestFinder.find_names):
1328         (TestFinder._exclude):
1329         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
1330         (TestFinderTest):
1331         (TestFinderTest.setUp):
1332         (TestFinderTest.tearDown):
1333         (TestFinderTest.test_additional_system_paths):
1334         (TestFinderTest.test_is_module):
1335         (TestFinderTest.test_to_module):
1336         (TestFinderTest.test_clean):
1337         (TestFinderTest.test_find_names):
1338
1339 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1340
1341         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
1342         https://bugs.webkit.org/show_bug.cgi?id=82209
1343
1344         Reviewed by Martin Robinson.
1345
1346         Respecting the $MAKE environment variable when it is defined makes
1347         building jhbuild more portable, as some platforms may have GNU
1348         make as gmake, for example.
1349
1350         * jhbuild/jhbuild-wrapper:
1351         (install_jhbuild):
1352
1353 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1354
1355         add a Tree abstraction to test-webkitpy to better encapsulate things
1356         https://bugs.webkit.org/show_bug.cgi?id=82158
1357
1358         Reviewed by Adam Barth.
1359
1360         There are no functional changes in this patch, but adding a
1361         basic abstraction for the trees we are looking in for python
1362         tests will allow me to add some features later on more easily
1363         (like ignoring certain directories like webkitpy/thirdparty),
1364         and it makes things slightly less hard-coded.
1365
1366         * Scripts/test-webkitpy:
1367         * Scripts/webkitpy/test/main.py:
1368         (Tester.__init__):
1369         (Tester):
1370         (Tester.add_tree):
1371         (Tester._parse_args):
1372         (Tester._configure):
1373         (Tester.run):
1374         (Tester._find_modules):
1375         (Tester._run_tests):
1376         (Tester._is_module):
1377         (Tester._log_exception):
1378         (TestDirectoryTree):
1379         (TestDirectoryTree.__init__):
1380         (TestDirectoryTree.find_modules):
1381         (TestDirectoryTree.clean):
1382
1383 2012-03-26  Ojan Vafai  <ojan@chromium.org>
1384
1385         garden-o-matic should special case reftests
1386         https://bugs.webkit.org/show_bug.cgi?id=81812
1387
1388         Reviewed by Adam Barth.
1389
1390         On the examine page, don't show a rebaseline button for reftests.
1391         We still show it on the failure summary page because tests are grouped
1392         together. Long-term, we should make sure webkit-patch rebaseline-test
1393         never tries to rebaseline reftests.
1394
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1398
1399 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1400
1401         clean up NRWT logging/metering, be less verbose
1402         https://bugs.webkit.org/show_bug.cgi?id=73846
1403
1404         Reviewed by Ojan Vafai.
1405
1406         Re-land r112014 with a build fix for Python 2.6 compatibility.
1407
1408         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1409         (ManagerTest.test_http_locking):
1410         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1411         (AbstractWorker.run):
1412         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1413         (Worker.__init__):
1414         (Worker._set_up_logging):
1415         (Worker):
1416         (Worker._set_up_host_and_port):
1417         (Worker.run):
1418         (Worker.cleanup):
1419         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1420         (WorkerTest.test_default_platform_in_worker):
1421         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1422         (run):
1423         (main):
1424         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1425         (MeteredStream):
1426         (MeteredStream.implements):
1427         (MeteredStream._erasure):
1428         (MeteredStream._ensure_newline):
1429         (MeteredStream.__init__):
1430         (MeteredStream.__del__):
1431         (MeteredStream.cleanup):
1432         (MeteredStream.write_throttled_update):
1433         (MeteredStream.write_update):
1434         (MeteredStream.write):
1435         (MeteredStream.writeln):
1436         (MeteredStream._erase_last_partial_line):
1437         (_LogHandler):
1438         (_LogHandler.__init__):
1439         (_LogHandler.emit):
1440         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1441         (RegularTest):
1442         (RegularTest.setUp):
1443         (RegularTest.tearDown):
1444         (RegularTest.time_fn):
1445         (RegularTest.test_logging_not_included):
1446         (RegularTest._basic):
1447         (RegularTest.test_basic):
1448         (RegularTest._log_after_update):
1449         (RegularTest.test_log_after_update):
1450         (TtyTest):
1451         (TtyTest.test_basic):
1452         (TtyTest.test_log_after_update):
1453         (VerboseTest):
1454         (VerboseTest.test_basic):
1455         (VerboseTest.test_log_after_update):
1456         * Scripts/webkitpy/layout_tests/views/printing.py:
1457         (parse_print_options):
1458         (Printer.__init__):
1459         (Printer.cleanup):
1460         (Printer.print_progress):
1461         (Printer.print_update):
1462         (Printer._write):
1463         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1464         (Testprinter.get_printer):
1465         (Testprinter.test_print_progress):
1466         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1467         (PerfTestsRunner.__init__):
1468         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1469         (test_run_test_pause_before_testing):
1470
1471 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1472
1473         [jhbuild] Revert $MAKE environment hack introduced in r101929.
1474         https://bugs.webkit.org/show_bug.cgi?id=82234
1475
1476         Reviewed by Martin Robinson.
1477
1478         The problem it was supposedly fixing was fixed in jhbuild itself
1479         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
1480         can remove the workaround added to the script.
1481
1482         * jhbuild/jhbuild-wrapper:
1483         (install_jhbuild):
1484
1485 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
1486
1487         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
1488         https://bugs.webkit.org/show_bug.cgi?id=82157
1489
1490         Reviewed by Rob Buis.
1491
1492         * Scripts/build-webkit:
1493         Make ENABLE_FILE_SYSTEM default on for blackberry.
1494
1495 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1496
1497         [jhbuild] Explicitly disable DTrace when building glib.
1498         https://bugs.webkit.org/show_bug.cgi?id=82145
1499
1500         Reviewed by Gustavo Noronha Silva.
1501
1502         DTrace support is not really needed by WebKit, so disabling it
1503         helps avoid some build errors on more exotic platforms (such as
1504         FreeBSD).
1505
1506         * efl/jhbuild.modules:
1507         * gtk/jhbuild.modules:
1508
1509 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1510
1511         Unreviewed, rolling out r111993.
1512         http://trac.webkit.org/changeset/111993
1513         https://bugs.webkit.org/show_bug.cgi?id=82184
1514
1515         It broke layout and API tests and made WTR crash (Requested by
1516         Ossy on #webkit).
1517
1518         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1519         (WTR::PlatformWebView::PlatformWebView):
1520
1521 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
1522
1523         [wx] Unreviewed build fix. Move WTF to its own static lib build.
1524
1525         * waf/build/settings.py:
1526         (common_configure):
1527
1528 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
1529
1530         AX: Support solution to handle invalid ax text marker
1531         https://bugs.webkit.org/show_bug.cgi?id=82023
1532
1533         Reviewed by Oliver Hunt.
1534
1535         * DumpRenderTree/AccessibilityUIElement.cpp:
1536         (indexForTextMarkerCallback):
1537         (isTextMarkerValidCallback):
1538         (textMarkerForIndexCallback):
1539         (AccessibilityUIElement::indexForTextMarker):
1540         (AccessibilityUIElement::isTextMarkerValid):
1541         (AccessibilityUIElement::textMarkerForIndex):
1542         (AccessibilityUIElement::getJSClass):
1543         * DumpRenderTree/AccessibilityUIElement.h:
1544         (AccessibilityUIElement):
1545         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1546         (AccessibilityUIElement::indexForTextMarker):
1547         (AccessibilityUIElement::textMarkerForIndex):
1548         (AccessibilityUIElement::isTextMarkerValid):
1549         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1550         (WTR::AccessibilityUIElement::indexForTextMarker):
1551         (WTR::AccessibilityUIElement::isTextMarkerValid):
1552         (WTR::AccessibilityUIElement::textMarkerForIndex):
1553         (WTR):
1554         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1555         (AccessibilityUIElement):
1556         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1557         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1558         (WTR):
1559         (WTR::AccessibilityUIElement::indexForTextMarker):
1560         (WTR::AccessibilityUIElement::isTextMarkerValid):
1561         (WTR::AccessibilityUIElement::textMarkerForIndex):
1562
1563 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1564
1565         Unreviewed, rolling out r112014.
1566         http://trac.webkit.org/changeset/112014
1567         https://bugs.webkit.org/show_bug.cgi?id=82138
1568
1569         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
1570         #webkit).
1571
1572         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1573         (ManagerTest.test_http_locking):
1574         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1575         (AbstractWorker.run):
1576         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1577         (Worker.__init__):
1578         (Worker.safe_init):
1579         (Worker.run):
1580         (Worker.cleanup):
1581         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1582         (WorkerTest.test_default_platform_in_worker):
1583         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1584         (run):
1585         (main):
1586         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1587         (MeteredStream):
1588         (MeteredStream.is):
1589         (MeteredStream.__init__):
1590         (MeteredStream.write):
1591         (MeteredStream.update):
1592         (MeteredStream._overwrite):
1593         (MeteredStream._reset):
1594         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1595         (TestMeteredStream):
1596         (TestMeteredStream.test_regular):
1597         * Scripts/webkitpy/layout_tests/views/printing.py:
1598         (_configure_logging):
1599         (_restore_logging):
1600         (Printer.__init__):
1601         (Printer.cleanup):
1602         (Printer.print_progress):
1603         (Printer.print_update):
1604         (Printer._write):
1605         (Printer):
1606         (Printer._update):
1607         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1608         (TestUtilityFunctions.assertEmpty):
1609         (TestUtilityFunctions):
1610         (TestUtilityFunctions.assertNotEmpty):
1611         (TestUtilityFunctions.assertWritten):
1612         (TestUtilityFunctions.test_configure_logging):
1613         (Testprinter.get_printer):
1614         (Testprinter.test_print_progress):
1615         (Testprinter.test_print_progress.mock_time):
1616         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1617         (PerfTestsRunner.__init__):
1618         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1619         (test_run_test_pause_before_testing):
1620
1621 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1622
1623         [wx] Unreviewed. Fix the build after WTF move.
1624
1625         * waf/build/build_utils.py:
1626         (get_excludes):
1627         (get_excludes_in_dirs):
1628         * waf/build/settings.py:
1629         (get_port_excludes):
1630         (common_configure):
1631
1632 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
1633
1634         clean up NRWT logging/metering, be less verbose
1635         https://bugs.webkit.org/show_bug.cgi?id=73846
1636
1637         Reviewed by Ojan Vafai.
1638
1639         This patch totally rewrites the metered_stream module and
1640         changes the way it and the printing module now interact with the
1641         logging subsystem.
1642
1643         The printing module becomes a dumb layout_tests-specific wrapper around
1644         the metered stream. All of the intelligence of how and when to
1645         actually write (or erase) lines and how things interact with
1646         logging moves into the metered stream.
1647
1648         As of now, anything written to the metered stream *bypasses the
1649         logging system*. If a logger is passed to the meter constructor,
1650         the metered stream will also attach a log handler so that all
1651         messages fed to the logger will also be written to the metered
1652         stream. This detangles the logic that used to exist where
1653         sometimes the meter would write to the logger and sometimes the
1654         logger would write to the meter.
1655
1656         All of this makes the logic generic and reusable for
1657         test-webkitpy (coming in another patch). It also helps clarify
1658         what the mysterious "configure_logging" parameter to the printer
1659         constructor used to do (that parameter itself is gone now, and
1660         by default the printer and metered_stream will not ever touch
1661         the logging system; this makes a bunch of tests less fragile).
1662
1663         All of the above should produce no user-visible changes.
1664
1665         However, to also fix the bug in question, we change the message
1666         format in --verbose mode to %H:%M:%S.%frac %pid %message,
1667         eliminating the date, file:lineno, and level parameters. I am
1668         making this change at the same time because it would be
1669         difficult to write things consistently between the logs and the
1670         metered stream if we were still logging the file:lineno.
1671
1672         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1673           Remove the configure_logging parameter
1674         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1675           Use metered stream to configure the logging (we don't need a printer)
1676           and be careful about when and how we manipulate the log level
1677           and handlers on the root logger.
1678         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1679           Pass in the root logger so that log messages are formatted
1680           properly, and set the log level outside of any routines called
1681           by unit tests so as to not interfere.
1682         * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
1683           remove a duplicate log message.
1684         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1685           complete rewrite :).
1686         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1687           complete rewrite :).
1688         * Scripts/webkitpy/layout_tests/views/printing.py:
1689           move the logging configuration into metered_stream, and also
1690           move the "when should I log progress messages" into metered stream.
1691         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1692           remove tests that are no longer necessary.
1693         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1694           remove the configure_logging parameter.
1695         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1696           update the test; since the printer no longer writes to the log,
1697           we need to check what is written to the regular_output instead.
1698           (test_run_test_pause_before_testing):
1699
1700 2012-03-24  Gustavo Noronha Silva  <gns@gnome.org>
1701
1702         Add myself and Martin Robinson to:
1703           * GStreamerGraphics
1704           * GtkWebKit2PublicAPI
1705           * SoupNetwork
1706         and to the newly created WebKitGTKTranslations.
1707
1708         Rubber-stamped by Martin Robinson.
1709
1710         * Scripts/webkitpy/common/config/watchlist:
1711
1712 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1713
1714         [Qt][WK2] Implement PageClient::isViewWindowActive()
1715         https://bugs.webkit.org/show_bug.cgi?id=81143
1716
1717         Reviewed by Kenneth Rohde Christiansen.
1718
1719         Fix the WrapperWindow from our PlatformWebView
1720         so it correctly creates the platform related
1721         stuff for QWindow, which is not created unless
1722         QWindow::setVisible() or QWindow::show() are called.
1723
1724         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1725         (WTR::PlatformWebView::PlatformWebView):
1726
1727 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
1728
1729         nrwt: don't wait for safari to exit before exiting after showing the results file
1730         https://bugs.webkit.org/show_bug.cgi?id=81845
1731
1732         Reviewed by Ryosuke Niwa.
1733
1734         Prior to this change, if you ran new-run-webkit-tests and
1735         displayed the HTML results file at the end, we would block
1736         waiting for the user to quit the browser. There doesn't seem to
1737         be a need for that, and the Chromium ports don't do this.
1738
1739         Also, update the mac tests to capture the output and be quiet :).
1740
1741         * Scripts/webkitpy/common/system/executive_mock.py:
1742           Make popen() testable, implement should_log for it.
1743         * Scripts/webkitpy/layout_tests/port/mac.py:
1744         (MacPort.show_results_html_file):
1745         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1746           Silence some of the tests via outputcapture.
1747
1748 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
1749
1750         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
1751         https://bugs.webkit.org/show_bug.cgi?id=82073
1752
1753         Reviewed by Martin Robinson.
1754
1755         * Scripts/webkitdirs.pm:
1756         (jhbuildConfigurationChanged): new function that isolates the
1757         jhbuild configuration change checking from the autogen logic.
1758         (mustReRunAutogen): code for the new function lived here.
1759         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
1760         itself, and cleans up the jhbuild root if configuration has
1761         changed; it also forces autogen to be run in that case, to
1762         make sure the new libraries are used.
1763         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
1764         * jhbuild/jhbuild-wrapper:
1765         (ensure_jhbuild): this might be run inside a jhbuild environment,
1766         in which case aclocal fails when trying to use the now deleted
1767         aclocal directory in the jhbuild prefix, so work around that.
1768
1769 2012-03-23  Ojan Vafai  <ojan@chromium.org>
1770
1771         garden-o-matic scrolls to the top of the page when you click an accordion item
1772         https://bugs.webkit.org/show_bug.cgi?id=82088
1773
1774         Reviewed by Adam Barth.
1775
1776         Check the scroll position and make sure that the clicked accordion item is visible.
1777
1778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1779
1780 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
1781
1782         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
1783         https://bugs.webkit.org/show_bug.cgi?id=80567
1784
1785         Reviewed by Ryosuke Niwa.
1786
1787         Move clean_up_run to occur right after we finish testing and
1788         before we start processing the results. Also makes set_up_run()
1789         and clean_up_run() private since there's no real need for
1790         callers to be aware of them.
1791
1792         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1793         (Manager._set_up_run):
1794         (Manager.run):
1795         (Manager._clean_up_run):
1796         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1797         (ManagerTest.test_http_locking):
1798         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1799         (run):
1800
1801 2012-03-23  Dean Jackson  <dino@apple.com>
1802
1803         Disable CSS_SHADERS in Apple builds
1804         https://bugs.webkit.org/show_bug.cgi?id=81996
1805
1806         Reviewed by Simon Fraser.
1807
1808         Default enableCSSShaders to be 0 on all builds that use
1809         this script. Use the flag to turn it back on.
1810
1811         * Scripts/build-webkit:
1812
1813 2012-03-23  Tony Chang  <tony@chromium.org>
1814
1815         [chromium] rename newwtf target back to wtf
1816         https://bugs.webkit.org/show_bug.cgi?id=82064
1817
1818         Reviewed by Adam Barth.
1819
1820         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1821
1822 2012-03-23  Jessie Berlin  <jberlin@apple.com>
1823
1824         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
1825         the Lion Intel WebKit2 Debug bots.
1826         https://bugs.webkit.org/show_bug.cgi?id=81012.
1827
1828         Rubber-stamped by Dan Bernstein.
1829
1830         Add a step to kill the pasteboard server while we investigate what is causing these
1831         assertion failures (to get the bots green).
1832
1833         * BuildSlaveSupport/kill-old-processes:
1834
1835 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
1836
1837         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
1838         https://bugs.webkit.org/show_bug.cgi?id=81986
1839
1840         Reviewed by David Levin.
1841
1842         Track whether or not errors are filtered in error handlers. If an
1843         alphabetical sorting error is reported for a header and filtered, try
1844         reporting it for the other potential source of the error. This ensures
1845         that the style bot can still find new sorting errors in both potential
1846         situations:
1847
1848             #include <foo.h> <-- 1. edited line
1849             #include <baz.h> <-- 2. edited line
1850
1851         * Scripts/webkitpy/style/checkers/cpp.py:
1852         (check_include_line): Potentially report the error for both lines,
1853         if the first error is filtered.
1854         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
1855         test that allows only reporting errors for certain lines. This verifies that
1856         when one line of an ordering error is filtered, the error is reported on the
1857         other line.
1858         (ErrorCollector.__init__):
1859         (ErrorCollector.__call__):
1860         (CppStyleTestBase.perform_lint):
1861         (CppStyleTestBase.perform_language_rules_check):
1862         (CppStyleTestBase.assert_language_rules_check):
1863         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
1864         Added a new test that verifies that when one line of the two lines of an ordering
1865         error occur, the error is reported on the other line.
1866         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1867         (MockErrorHandler.__call__): Report True because the error is handled.
1868         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1869         (ErrorCollector.__call__): Ditto.
1870         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1871         (MockErrorHandler.__call__): Ditto.
1872         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1873         (TestErrorHandler.__call__): Ditto.
1874         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1875         (MockErrorHandler.__call__): Ditto.
1876         * Scripts/webkitpy/style/error_handlers.py:
1877         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
1878         and False if it is filtered.
1879
1880 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
1881
1882         Build fix for WinCE after r111778.
1883
1884         * WinCELauncher/CMakeLists.txt:
1885
1886 2012-03-23  Peter Beverloo  <peter@chromium.org>
1887
1888         Unreviewed buildfix for the Chromium Android builder.
1889
1890         Disable the ImageDiff target for now. Android needs to build this for
1891         host rather than for target (as other configurations do), but since the
1892         WTF move the dependency chain got significantly more complicated.
1893
1894         I'll work out a proper fix in the following bug, but since several
1895         things are broken due to this, this buildfix should be landed first.
1896         https://bugs.webkit.org/show_bug.cgi?id=82039
1897
1898         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1899
1900 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1901
1902         [EFL][DRT] Implement LayoutTestController's methods related with editing.
1903         https://bugs.webkit.org/show_bug.cgi?id=80136
1904
1905         Reviewed by Ryosuke Niwa.
1906
1907         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
1908         setSelectTrailingWhitespaceEnabled.
1909
1910         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1911         (LayoutTestController::setSmartInsertDeleteEnabled):
1912         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1913
1914 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1915
1916         Convert hasGrammarMarker to use Internals interface
1917         https://bugs.webkit.org/show_bug.cgi?id=82004
1918
1919         Reviewed by Ryosuke Niwa.
1920
1921         Remove hasGrammarMarker functions, because it is able to work in the
1922         cross-port way through the Internals interface.
1923
1924         * DumpRenderTree/LayoutTestController.cpp:
1925         (LayoutTestController::staticFunctions):
1926         * DumpRenderTree/LayoutTestController.h:
1927         (LayoutTestController):
1928         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1929         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1930         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1931         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1932         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1933         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1934
1935 2012-03-22  Adam Barth  <abarth@webkit.org>
1936
1937         sync-master-with-upstream creates non-linear git history
1938         https://bugs.webkit.org/show_bug.cgi?id=82006
1939
1940         Reviewed by Julien Chaffraix.
1941
1942         Previously this script would create a merge commit at the HEAD of
1943         origin/master, causing your fork of WebKit to diverge from upstream.
1944         The new version of this script pushes directly from upstream to origin
1945         (without round-tripping through any local branches), avoiding this
1946         problem.
1947
1948         * Scripts/sync-master-with-upstream:
1949
1950 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
1951
1952         Unreviewed build fix. Add knowledge of the WTF project to
1953         the autotools build system scripts so that build-jsc works
1954         correctly for GTK+.
1955
1956         * Scripts/webkitdirs.pm:
1957         (buildAutotoolsProject): handle the WTF project, build the
1958         libWTF.la target.
1959         (buildGtkProject): add WTF to the list of supported projects.
1960
1961 2012-03-22  Eric Seidel  <eric@webkit.org>
1962
1963         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
1964         https://bugs.webkit.org/show_bug.cgi?id=81984
1965
1966         Reviewed by Adam Barth.
1967
1968         * Scripts/VCSUtils.pm:
1969         (adjustPathForRecentRenamings):
1970
1971 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1972
1973         [CMake] Fix build-jsc after r111778 and r111797.
1974         https://bugs.webkit.org/show_bug.cgi?id=82001
1975
1976         Reviewed by Filip Pizlo.
1977
1978         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
1979         does return if no error occurred, and build-jsc failed with
1980         "building not defined for this platform".
1981
1982         * Scripts/build-jsc: Always exit after caling
1983         buildCMakeProjectOrExit().
1984         * Scripts/webkitdirs.pm:
1985         (buildCMakeProjectOrExit): Return 0 if no error occurred.
1986
1987 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1988
1989         [CMake] Unreviewed build fix after r111778.
1990
1991         * DumpRenderTree/efl/CMakeLists.txt: Replace
1992         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
1993         paths.
1994         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
1995         wtf include.
1996         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
1997         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
1998         with ${WTF_DIR}/wtf in the include paths.
1999
2000 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
2001
2002         Tools/Scripts/build-jsc doesn't work after WTF move
2003         https://bugs.webkit.org/show_bug.cgi?id=81999
2004
2005         Reviewed by Eric Seidel.
2006         
2007         For ports that require WTF and JSC to be built as two projects and where
2008         the machinery to build both does not already exist, teach the tool to do
2009         so for us.
2010
2011         * Scripts/build-jsc:
2012         (buildMyProject):
2013
2014 2012-03-22  Ojan Vafai  <ojan@chromium.org>
2015
2016         Fix accidental missing line in r111793.
2017
2018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2020         Remove base.values. It was unused and duplicates the builtin Object.values.
2021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2022         Accidentally deleted this line before committing r111793.
2023
2024 2012-03-22  Ojan Vafai  <ojan@chromium.org>
2025
2026         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
2027         https://bugs.webkit.org/show_bug.cgi?id=81983
2028
2029         Reviewed by Adam Barth.
2030
2031         The dialogs get in the way if you are doing multiple rebaselines. Also,
2032         a number of people didn't realize that you could do multiple rebaselines
2033         in parallel. A non-modal dialog is just confusing.
2034
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2037         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
2038         show the number of tests being rebaselined.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2041         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
2042         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
2043         into a single area.
2044
2045         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
2046         also serves to clear all teh content in the StatusArea. 
2047
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2049         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2050
2051 2012-03-22  Tony Chang  <tony@chromium.org>
2052
2053         Unreviewed, fix chromium build after wtf move.
2054
2055         Only use newwtf, remove references to wtf.
2056
2057         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2058
2059 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2060
2061         Actually move WTF files to their new home
2062         https://bugs.webkit.org/show_bug.cgi?id=81844
2063
2064         [Qt] Unreviewed buildfix after r111778.
2065
2066         * DumpRenderTree/qt/DumpRenderTree.pro:
2067
2068 2012-03-22  Dan Bernstein  <mitz@apple.com>
2069
2070         Font fallback in WebKitTestRunner depends on user settings
2071         https://bugs.webkit.org/show_bug.cgi?id=81978
2072
2073         Reviewed by Jessie Berlin.
2074
2075         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2076         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
2077         with a value consisting of the array ("en") to the override defaults
2078         dictionary. This is the same value used in DumpRenderTree, and it
2079         ensures that font fallback follows a consistent path that is not
2080         affected by the language preferences of the user running the test.
2081
2082 2012-03-22  Andy Estes  <aestes@apple.com>
2083
2084         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
2085         https://bugs.webkit.org/show_bug.cgi?id=81971
2086
2087         Reviewed by Dan Bernstein.
2088
2089         Xcode will automatically link ObjC binaries against libarclite in some
2090         cases, which defines a class called __ARCLite__.
2091         check-for-inappropriate-objc-class-names shouldn't complain about this
2092         class name.
2093
2094         * Scripts/check-for-inappropriate-objc-class-names:
2095
2096 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2097
2098         new-run-webkit-tests blames the wrong test for crashing
2099         https://bugs.webkit.org/show_bug.cgi?id=81951
2100
2101         Reviewed by Adam Barth.
2102
2103         NRWT wasn't extracting the WebProcess pid correct; should've
2104         used re.search instead of re.match :(. Add more tests!
2105
2106         * Scripts/webkitpy/layout_tests/port/mac.py:
2107         (MacPort._get_crash_log):
2108         * Scripts/webkitpy/layout_tests/port/webkit.py:
2109         (WebKitDriver.has_crashed):
2110         (WebKitDriver._check_for_driver_crash):
2111         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2112         (WebKitDriverTest.test_no_timeout):
2113         (WebKitDriverTest):
2114         (WebKitDriverTest.test_check_for_driver_crash):
2115         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
2116         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
2117         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
2118         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
2119         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
2120         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2121
2122 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2123
2124         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
2125         https://bugs.webkit.org/show_bug.cgi?id=81512
2126
2127         Adding missing implementation markerTextForListItem to EFL's
2128         LayoutTestController so that we can unskip related tests from
2129         the skip list.
2130
2131         Reviewed by Antonio Gomes.
2132
2133         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2134         (LayoutTestController::markerTextForListItem): Implemented.
2135
2136 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2137
2138         [EFL] Enable view mode media feature layout tests
2139         https://bugs.webkit.org/show_bug.cgi?id=81205
2140
2141         Adding missing implementation setViewModeMediaFeature to EFL's 
2142         LayoutTestController so that we can unskip view mode 
2143         media feature layout tests.
2144
2145         Reviewed by Antonio Gomes.
2146
2147         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2148         (LayoutTestController::setViewModeMediaFeature): Implemented.
2149
2150 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2151
2152         nrwt: crash while stopping layout test helper on apple mac lion
2153         https://bugs.webkit.org/show_bug.cgi?id=81949
2154
2155         Reviewed by Eric Seidel.
2156
2157         stop_helper() didn't work right if the helper process wasn't
2158         still running or didn't respond properly to being shut down. Fix
2159         this and add some tests. Also add code to MockExecutive() to be
2160         able to mock executive.popen() properly.
2161
2162         * Scripts/webkitpy/common/system/executive_mock.py:
2163         (MockProcess.__init__):
2164         (MockProcess.wait):
2165         (MockExecutive.__init__):
2166         (MockExecutive.popen):
2167         * Scripts/webkitpy/common/system/systemhost_mock.py:
2168         (MockSystemHost.__init__):
2169         * Scripts/webkitpy/layout_tests/port/mac.py:
2170         (MacPort.start_helper):
2171         (MacPort.stop_helper):
2172         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2173         (test_get_crash_log):
2174         (test_helper_starts):
2175         (test_helper_fails_to_start):
2176         (test_helper_fails_to_stop):
2177         (test_helper_fails_to_stop.bad_waiter):
2178
2179 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
2180
2181         [GTK] Add make to the jhbuild moduleset
2182         https://bugs.webkit.org/show_bug.cgi?id=81769
2183
2184         Reviewed by Martin Robinson.
2185
2186         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
2187         Add GNU make with custom patches to fix several issues:
2188
2189         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
2190           fix the argument list limit of GNU make when running make
2191           distcheck.
2192         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
2193           and Jeremy Devenport to fix parallel build issues present in
2194           GNU make 3.82
2195
2196         * gtk/jhbuild.modules: Added make with patches.
2197         * gtk/patches/make-3.82-arg-list-length.patch: Added.
2198         * gtk/patches/make-3.82-parallel-build.patch: Added.
2199
2200 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
2201
2202         [wx] Unreviewed. Adding Source/WTF to the build and updating
2203         waf port list.
2204
2205         * DumpRenderTree/wscript:
2206         * waf/build/settings.py:
2207
2208 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2209
2210         Re-land fix for r81603 yet again (!) with latest build fix.
2211         https://bugs.webkit.org/show_bug.cgi?id=81603
2212
2213         Unreviewed, build fix.
2214
2215         The latest problem was a bad sprintf() in
2216         BasePort._get_crash_log(). I've reworked that routine and added
2217         unit tests for coverage.
2218
2219         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2220         (SingleTestRunner._handle_error):
2221         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2222         (write_test_result):
2223         (TestResultWriter.write_crash_log):
2224         * Scripts/webkitpy/layout_tests/port/base.py:
2225         (Port.diff_text):
2226         (Port._get_crash_log):
2227         * Scripts/webkitpy/layout_tests/port/chromium.py:
2228         (ChromiumDriver.run_test):
2229         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2230         (ChromiumDriverTest.test_crash_log):
2231         * Scripts/webkitpy/layout_tests/port/driver.py:
2232         (DriverOutput.__init__):
2233         * Scripts/webkitpy/layout_tests/port/mac.py:
2234         (MacPort.is_lion):
2235         (MacPort._get_crash_log):
2236         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2237         (test_default_child_processes):
2238         (test_get_crash_log):
2239         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2240         (MockDRTPortTest.test_get_crash_log):
2241         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2242         (PortTestCase.test_get_crash_log):
2243         * Scripts/webkitpy/layout_tests/port/test.py:
2244         (TestDriver.run_test):
2245         * Scripts/webkitpy/layout_tests/port/webkit.py:
2246         (WebKitDriver.__init__):
2247         (WebKitDriver._start):
2248         (WebKitDriver.has_crashed):
2249         (WebKitDriver._check_for_driver_crash):
2250         (WebKitDriver.run_test):
2251
2252 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
2253
2254         [Qt] Enable support for handling database quota's in the MiniBrowser
2255         https://bugs.webkit.org/show_bug.cgi?id=81928
2256
2257         Reviewed by Simon Hausmann.
2258
2259         * MiniBrowser/qt/qml/BrowserWindow.qml:
2260
2261 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2262
2263         [EFL] Implement LayoutTestController::setEditingBehavior
2264         https://bugs.webkit.org/show_bug.cgi?id=81124
2265
2266         Adding missing implementation setEditingBehavior to EFL's
2267         LayoutTestController. This implementation allows us to
2268         unskip some tests from the skip list.
2269
2270         Reviewed by Martin Robinson.
2271
2272         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2273         (LayoutTestController::setEditingBehavior): Implemented.
2274
2275 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
2276
2277         [GTK] Use the angle-bracket form to include wtf headers
2278         https://bugs.webkit.org/show_bug.cgi?id=81884
2279
2280         Reviewed by Eric Seidel.
2281
2282         Use #include <wtf/foo> instead of #include "foo".
2283
2284         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2285         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2286         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2287         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2288         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2289         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2290
2291 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
2292
2293         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
2294
2295         * Scripts/webkitpy/common/config/committers.py:
2296
2297 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2298
2299         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
2300         https://bugs.webkit.org/show_bug.cgi?id=81889
2301
2302         Reviewed by Kenneth Rohde Christiansen.
2303
2304         Enable FAST_MOBILE_SCROLLING feature.
2305
2306         * qmake/mkspecs/features/features.prf:
2307
2308 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2309
2310         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
2311         https://bugs.webkit.org/show_bug.cgi?id=81900
2312
2313         Reviewed by Gustavo Noronha Silva.
2314
2315         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
2316         path which assumed a certain directory structure for the build
2317         directory which may noy be true.
2318
2319         Instead, hardcode the path to the downloaded fonts starting from the
2320         top-level source directory. While this solution is also far from
2321         perfect, it makes it more consistent and reliable, and easier to
2322         tackle at once with the rest of bug 81475.
2323
2324         * DumpRenderTree/efl/CMakeLists.txt:
2325
2326 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2327
2328         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
2329         https://bugs.webkit.org/show_bug.cgi?id=81888
2330
2331         Reviewed by Philippe Normand.
2332
2333         * Scripts/update-webkit-libs-jhbuild:
2334         (runJhbuild): Helper function to run jhbuild with a given command.
2335         Instead of running jhbuild directly, use the jhbuild-wrapper, so
2336         that we don't need to run it first to check whether jhbuild is
2337         installed or not.
2338         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
2339         * gtk/run-with-jhbuild: Ditto.
2340         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
2341         not only run.
2342
2343 2012-03-22  Philippe Normand  <pnormand@igalia.com>
2344
2345         Unreviewed, test-webkitpy fix after r111661.
2346
2347         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2348         (MainTest.test_crash_log):
2349         (MainTest.test_web_process_crash_log):
2350
2351 2012-03-22  Philippe Normand  <pnormand@igalia.com>
2352
2353         Unreviewed, test-webkitpy fix after r111642.
2354
2355         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2356         (ChromiumDriverTest.setUp):
2357         (ChromiumDriverTest.test_two_drivers):
2358
2359 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2360
2361         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
2362         https://bugs.webkit.org/show_bug.cgi?id=81603
2363
2364         Unreviewed rolling out r111609 and part of r111615,
2365         because it broke NRWT on Qt-WK2 platform.
2366
2367         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2368         (SingleTestRunner._handle_error):
2369         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2370         (write_test_result):
2371         (TestResultWriter.write_crash_report):
2372         * Scripts/webkitpy/layout_tests/port/base.py:
2373         (Port.is_crash_reporter):
2374         (Port._driver_class):
2375         * Scripts/webkitpy/layout_tests/port/chromium.py:
2376         (ChromiumDriver.run_test):
2377         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2378         (ChromiumDriverTest.test_crashed_process_name):
2379         * Scripts/webkitpy/layout_tests/port/driver.py:
2380         (DriverOutput.__init__):
2381         * Scripts/webkitpy/layout_tests/port/mac.py:
2382         (MacPort):
2383         (MacPort.is_crash_reporter):
2384         (MacPort.release_http_lock):
2385         * Scripts/webkitpy/layout_tests/port/test.py:
2386         (TestDriver.run_test):
2387         * Scripts/webkitpy/layout_tests/port/webkit.py:
2388         (WebKitDriver.__init__):
2389         (WebKitDriver._start):
2390         (WebKitDriver.has_crashed):
2391         (WebKitDriver._check_for_driver_crash):
2392         (WebKitDriver.run_test):
2393
2394 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2395
2396         [Qt] Add full platforms to Qt buildslaves
2397         https://bugs.webkit.org/show_bug.cgi?id=81877
2398
2399         Reviewed by Ryosuke Niwa.
2400
2401         * BuildSlaveSupport/build.webkit.org-config/config.json:
2402
2403 2012-03-21  Johnny Ding  <jnd@chromium.org>
2404
2405         Customize layout test timeout value for different ports.
2406         https://bugs.webkit.org/show_bug.cgi?id=79859
2407
2408         Reviewed by Ojan Vafai.
2409
2410         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2411         (Manager):
2412         * Scripts/webkitpy/layout_tests/port/base.py:
2413         (Port.default_test_timeout_ms):
2414         * Scripts/webkitpy/layout_tests/port/chromium.py:
2415         (ChromiumDriver.stop):
2416         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2417         (ChromiumAndroidPort.default_test_timeout_ms):
2418         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2419         (_set_up_derived_options):
2420
2421 2012-03-21  Mark Rowe  <mrowe@apple.com>
2422
2423         Fix the build.
2424
2425         Ensure that our test tools don't try and use RTTI unnecessarily.
2426
2427         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2428         * TestWebKitAPI/Configurations/Base.xcconfig:
2429         * WebKitTestRunner/Configurations/Base.xcconfig:
2430
2431 2012-03-21  Adam Barth  <abarth@webkit.org>
2432
2433         WebKit should have some scripts to smooth interactions with GitHub
2434         https://bugs.webkit.org/show_bug.cgi?id=81842
2435
2436         Reviewed by Eric Seidel.
2437
2438         These scripts support the workflow in
2439         https://trac.webkit.org/wiki/UsingGitHub by automating the
2440         configuration and syncing operations needed for a GitHub fork of WebKit
2441         to track the main WebKit repository.
2442
2443         * Scripts/configure-github-as-upstream: Added.
2444         * Scripts/sync-master-with-upstream: Added.
2445
2446 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2447
2448         WTR - log the pid of a crashing WebProcess
2449         https://bugs.webkit.org/show_bug.cgi?id=81575
2450
2451         Reviewed by Alexey Proskuryakov.
2452
2453         This allows run-webkit-tests to find the right crash log for a
2454         given crashed WebProcess in WebKit2.
2455
2456         * WebKitTestRunner/TestController.cpp:
2457         (WTR::exceededDatabaseQuota):
2458         (WTR::TestController::createOtherPage):
2459         (WTR::TestController::initialize):
2460         (WTR::TestController::resetStateToConsistentValues):
2461         (WTR::TestController::runTest):
2462         (WTR::TestController::processDidCrash):
2463
2464 2012-03-21  Enrica Casucci  <enrica@apple.com>
2465
2466         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
2467         https://bugs.webkit.org/show_bug.cgi?id=81835
2468         <rdar://problem/11082749>
2469
2470         Reviewed by Brady Eidson.
2471
2472         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2473         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2474         (TestWebKitAPI::contextMenuCopyLink):
2475
2476 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
2477
2478         [CSS Shaders] Make CSS Shaders compile on Chromium
2479         https://bugs.webkit.org/show_bug.cgi?id=81435
2480
2481         Reviewed by Stephen White.
2482         
2483         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
2484
2485         * DumpRenderTree/chromium/LayoutTestController.cpp:
2486         (LayoutTestController::overridePreference):
2487         * DumpRenderTree/chromium/WebPreferences.cpp:
2488         (WebPreferences::reset):
2489         (WebPreferences::applyTo):
2490         * DumpRenderTree/chromium/WebPreferences.h:
2491         (WebPreferences):
2492
2493 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2494
2495         fix regression on gtk port introduced by r111609
2496         https://bugs.webkit.org/show_bug.cgi?id=81839
2497
2498         Reviewed by Philippe Normand.
2499
2500         r111609 should've initialized a couple of missing fields in
2501         WebKitDriver, and also should've checked for method overrides
2502         in the other ports :(.
2503
2504         * Scripts/webkitpy/layout_tests/port/gtk.py:
2505         (GtkDriver._start):
2506         * Scripts/webkitpy/layout_tests/port/webkit.py:
2507         (WebKitDriver.__init__):
2508         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2509         (MainTest.test_crash_log):
2510         (MainTest.test_web_process_crash_log):
2511
2512 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2513
2514         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
2515         https://bugs.webkit.org/show_bug.cgi?id=81603
2516
2517         Reviewed by Adam Barth.
2518
2519         Add a new _get_crash_log() overridable method on the Port
2520         object to customize how we fetch crash logs per port.
2521         Mac will now slow-spin with a timeout waiting for the crash log, rather
2522         than waiting for the ReportCrash process to exit (it appears
2523         that the mac will manage multiple crashes with a single
2524         ReportCrash process, the process waits around longer than
2525         necessary, presumably to avoid thrashing if processes are
2526         repeatedly crashing).
2527
2528         Also, add the DriverOutput should contain the crash log and other info,
2529         which is created in a port-specific manner but can then be
2530         treated generically. Previously single_test_runner would get
2531         told that something crashed and attempt to do something to get
2532         the crash log, but it didn't have the information it needed to
2533         od the right thing; better to make the driver hand back the
2534         right info.
2535
2536         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2537         (SingleTestRunner._handle_error):
2538         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2539         (write_test_result):
2540         (TestResultWriter.write_crash_log):
2541         * Scripts/webkitpy/layout_tests/port/base.py:
2542         (Port.diff_text):
2543         (Port._get_crash_log):
2544         * Scripts/webkitpy/layout_tests/port/chromium.py:
2545         (ChromiumDriver.run_test):
2546         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2547         (ChromiumDriverTest.test_crash_log):
2548         * Scripts/webkitpy/layout_tests/port/driver.py:
2549         (DriverOutput.__init__):
2550         * Scripts/webkitpy/layout_tests/port/mac.py:
2551         (MacPort.is_lion):
2552         (MacPort._get_crash_log):
2553         * Scripts/webkitpy/layout_tests/port/test.py:
2554         (TestDriver.run_test):
2555         * Scripts/webkitpy/layout_tests/port/webkit.py:
2556         (WebKitDriver.__init__):
2557         (WebKitDriver._start):
2558         (WebKitDriver.has_crashed):
2559         (WebKitDriver._check_for_driver_crash):
2560         (WebKitDriver.run_test):
2561
2562 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2563
2564         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
2565         https://bugs.webkit.org/show_bug.cgi?id=81507
2566
2567         Now that we're only loading from one directory, no need to
2568         iterate over a list of directories anymore.
2569
2570         Reviewed by Martin Robinson.
2571
2572         * DumpRenderTree/efl/CMakeLists.txt:
2573         * DumpRenderTree/efl/FontManagement.cpp:
2574         (addFontDirectory):
2575         (addFontsToEnvironment):
2576
2577 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2578
2579         webkitpy: get ServerProcess out of the reportcrash business
2580         https://bugs.webkit.org/show_bug.cgi?id=81600
2581
2582         Unreviewed, build fix.
2583
2584         Re-land r111307 and r111293 with another fix for a crash in NRWT;
2585         we need to check if the driver has crashed before attempting to
2586         read from it.
2587
2588
2589         * Scripts/webkitpy/layout_tests/port/server_process.py:
2590         (ServerProcess._reset):
2591         (ServerProcess._handle_possible_interrupt):
2592         (ServerProcess.write):
2593         (ServerProcess.read_stdout):
2594         (ServerProcess.has_crashed):
2595         (ServerProcess._read):
2596         (ServerProcess.stop):
2597         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2598         (TrivialMockPort.check_for_leaks):
2599         (TestServerProcess.test_broken_pipe):
2600         * Scripts/webkitpy/layout_tests/port/webkit.py:
2601         (WebKitPort._read_image_diff):
2602         (WebKitDriver.has_crashed):
2603         (WebKitDriver._check_for_driver_crash):
2604         (WebKitDriver.run_test):
2605         (WebKitDriver._read_block):
2606         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2607         (MockServerProcess.__init__):
2608         (MockServerProcess):
2609         (MockServerProcess.has_crashed):
2610
2611 2012-03-21  Zeno Albisser  <zeno@webkit.org>
2612
2613         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
2614         https://bugs.webkit.org/show_bug.cgi?id=81750
2615
2616         Building WebCore on mac currently creates an archive that is bigger than
2617         4GB. But ranlib fails to create a symbol table for such a big archive,
2618         even on 64bit machines.
2619         Therefore we start using SVGAllInOne.cpp when building debug
2620         on mac. This reduces the size of the archive by about 300MB.
2621
2622         Reviewed by Tor Arne Vestbø.
2623
2624         * qmake/mkspecs/features/mac/default_pre.prf:
2625
2626 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
2627
2628         Updated the address list of committers.py.
2629
2630         Reviewed by Csaba Osztrogonác.
2631
2632         * Scripts/webkitpy/common/config/committers.py:
2633
2634 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
2635
2636         Updating my nick in committers file.
2637
2638         Unreviewed.
2639
2640         * Scripts/webkitpy/common/config/committers.py:
2641
2642 2012-03-21  Peter Beverloo  <peter@chromium.org>
2643
2644         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
2645         https://bugs.webkit.org/show_bug.cgi?id=80861
2646
2647         Reviewed by Tony Chang.
2648
2649         Remove most Android-specific logic from webkitdirs.pm in favor of
2650         handling this during project generation time.
2651
2652         * Scripts/webkitdirs.pm:
2653         (buildChromiumMakefile):
2654
2655 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2656
2657         [GTK] Allow running javascript from location bar in MiniBrowser
2658         https://bugs.webkit.org/show_bug.cgi?id=81331
2659
2660         Reviewed by Martin Robinson.
2661
2662         * MiniBrowser/gtk/BrowserWindow.c:
2663         (activateUriEntryCallback): Use browser_window_load_uri().
2664         (browser_window_load_uri): Check whether uri starts with
2665         javascript: and run the given script, or just call
2666         webkit_web_view_load_uri() to load the given uri.
2667         * MiniBrowser/gtk/BrowserWindow.h:
2668         * MiniBrowser/gtk/main.c:
2669         (createBrowserWindow): Use browser_window_load_uri().
2670
2671 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2672
2673         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
2674         https://bugs.webkit.org/show_bug.cgi?id=75543
2675
2676         Reviewed by Martin Robinson.
2677
2678         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
2679         MiniBrowser CPP flags.
2680
2681 2012-03-20  Eric Seidel  <eric@webkit.org>
2682
2683         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
2684         https://bugs.webkit.org/show_bug.cgi?id=80911
2685
2686         Reviewed by Adam Barth.
2687
2688         Update include paths for Source/WTF.
2689
2690         * DumpRenderTree/efl/CMakeLists.txt:
2691         * DumpRenderTree/qt/DumpRenderTree.pro:
2692         * QtTestBrowser/QtTestBrowser.pro:
2693         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
2694
2695 2012-03-20  Adam Barth  <abarth@webkit.org>
2696
2697         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
2698         https://bugs.webkit.org/show_bug.cgi?id=81567
2699
2700         Reviewed by Eric Seidel.
2701
2702         This temporary measure should help us avoid disrupting the folks
2703         working on WebAudio when we move the webaudio directory to Modules.
2704
2705         * Scripts/VCSUtils.pm:
2706         (adjustPathForRecentRenamings):
2707         (parseGitDiffHeader):
2708         (parseSvnDiffHeader):
2709
2710 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
2711
2712         Unreviewed, rolling out r111453.
2713         http://trac.webkit.org/changeset/111453
2714         https://bugs.webkit.org/show_bug.cgi?id=81600
2715
2716         still broken
2717
2718         * Scripts/webkitpy/layout_tests/port/server_process.py:
2719         (ServerProcess._reset):
2720         (ServerProcess.handle_interrupt):
2721         (ServerProcess.write):
2722         (ServerProcess._check_for_crash):
2723         (ServerProcess._handle_timeout):
2724         (ServerProcess._check_for_abort):
2725         (ServerProcess._read):
2726         (ServerProcess.stop):
2727         (ServerProcess):
2728         (ServerProcess.set_crashed):
2729         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2730         (TrivialMockPort.is_crash_reporter):
2731         (TestServerProcess.test_broken_pipe):
2732         * Scripts/webkitpy/layout_tests/port/webkit.py:
2733         (WebKitPort._read_image_diff):
2734         (WebKitDriver.has_crashed):
2735         (WebKitDriver._check_for_driver_crash):
2736         (WebKitDriver):
2737         (WebKitDriver._detected_crash):
2738         (WebKitDriver._subprocess_crashed):
2739         (WebKitDriver._crashed_process_name):
2740         (WebKitDriver.run_test):
2741         (WebKitDriver._read_block):
2742         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2743         (MockServerProcess.__init__):
2744
2745 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
2746
2747         webkitpy: get ServerProcess out of the reportcrash business
2748         https://bugs.webkit.org/show_bug.cgi?id=81600
2749
2750         Unreviewed, build fix.
2751
2752         Re-land r111307 and r111293 with fix for crash in NRWT; I
2753         was failing to set the crashing process name.
2754
2755         * Scripts/webkitpy/layout_tests/port/server_process.py:
2756         (ServerProcess._reset):
2757         (ServerProcess._handle_possible_interrupt):
2758         (ServerProcess.write):
2759         (ServerProcess.read_stdout):
2760         (ServerProcess.has_crashed):
2761         (ServerProcess._read):
2762         (ServerProcess.stop):
2763         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2764         (TrivialMockPort.check_for_leaks):
2765         (TestServerProcess.test_broken_pipe):
2766         * Scripts/webkitpy/layout_tests/port/webkit.py:
2767         (WebKitPort._read_image_diff):
2768         (WebKitDriver.has_crashed):
2769         (WebKitDriver._check_for_driver_crash):
2770         (WebKitDriver.run_test):
2771         (WebKitDriver._read_block):
2772         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2773         (MockServerProcess.__init__):
2774         (MockServerProcess):
2775         (MockServerProcess.has_crashed):
2776
2777 2012-03-20  Tim Horton  <timothy_horton@apple.com>
2778
2779         [mac] Restore color space switching code to run-webkit-tests
2780         https://bugs.webkit.org/show_bug.cgi?id=80571
2781         <rdar://problem/11008529>
2782
2783         Reviewed by Simon Fraser.
2784
2785         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
2786         
2787         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
2788         didn't exist until Lion.
2789
2790         * DumpRenderTree/mac/LayoutTestHelper.m:
2791         (installLayoutTestColorProfile):
2792         (restoreUserColorProfile):
2793
2794 2012-03-20  Adele Peterson  <adele@apple.com>
2795
2796         Update the last test to use EXPECT_WK_STREQ.
2797
2798         Reviewed by Dan Bernstein.
2799
2800         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
2801
2802 2012-03-20  Adele Peterson  <adele@apple.com>
2803
2804         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
2805         https://bugs.webkit.org/show_bug.cgi?id=81630
2806         <rdar://problem/10650660>
2807
2808         Reviewed by Alexey Proskuryakov.
2809
2810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
2812         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
2813         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
2814         (TestWebKitAPI):
2815         (TestWebKitAPI::didFinishLoadForFrame):
2816         (TestWebKitAPI::TEST):
2817         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
2818
2819 2012-03-20  Eric Seidel  <eric@webkit.org>
2820
2821         Add link on queues.webkit.org to kov's fancy queue-depth graph
2822         https://bugs.webkit.org/show_bug.cgi?id=81690
2823
2824         Reviewed by Adam Barth.
2825
2826         * QueueStatusServer/templates/recentstatus.html:
2827
2828 2012-03-20  Tim Horton  <timothy_horton@apple.com>
2829
2830         [mac] Restore color space switching code to run-webkit-tests
2831         https://bugs.webkit.org/show_bug.cgi?id=80571
2832         <rdar://problem/11008529>
2833
2834         Reviewed by Simon Fraser.
2835
2836         Make use of the layout test helper hooks to restore the Mac system-wide
2837         color profile switching code. This makes WkTR and DRT results match, and
2838         causes the main display's color profile to not affect results on Lion.
2839
2840         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2841         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
2842         (installLayoutTestColorProfile):
2843         (restoreUserColorProfile):
2844         (simpleSignalHandler):
2845         (main):
2846         * Scripts/webkitpy/layout_tests/port/mac.py:
2847         (MacPort.release_http_lock):
2848         (MacPort):
2849         (MacPort._path_to_helper):
2850         (MacPort.start_helper):
2851         (MacPort.stop_helper):
2852         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2853         (WTR::PlatformWebView::PlatformWebView):
2854         (WTR::PlatformWebView::windowSnapshotImage):
2855
2856 2012-02-24  Darin Fisher  <darin@chromium.org>
2857
2858         Add more Chromium WebKit API reviewers
2859         https://bugs.webkit.org/show_bug.cgi?id=81576
2860
2861         Reviewed by Adam Barth and David Levin.
2862
2863         Simplify watchlist to lump all WebKit API into one.
2864
2865         * Scripts/webkitpy/common/config/watchlist:
2866
2867 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2868
2869         Convert hasSpellingMarker to use Internals interface.
2870         https://bugs.webkit.org/show_bug.cgi?id=81300
2871
2872         Reviewed by Ryosuke Niwa.
2873
2874         Remove hasSpellingMarker functions, because it is able to work in the
2875         cross-port way through the Internals interface.
2876
2877         * DumpRenderTree/LayoutTestController.cpp:
2878         (LayoutTestController::staticFunctions):
2879         * DumpRenderTree/LayoutTestController.h:
2880         (LayoutTestController):
2881         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2882         * DumpRenderTree/chromium/LayoutTestController.cpp:
2883         (LayoutTestController::LayoutTestController):
2884         * DumpRenderTree/chromium/LayoutTestController.h:
2885         (LayoutTestController):
2886         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2887         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2888         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2889         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2890         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2891         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2892         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2893
2894 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
2895
2896         Add new Qt-WK2 performance tester bot to build.webkit.org
2897         https://bugs.webkit.org/show_bug.cgi?id=80842
2898
2899         Reviewed by Ryosuke Niwa.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/config.json:
2902         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2903         (RunAndUploadPerfTestsWebKit2):
2904         (RunAndUploadPerfTestsWebKit2.start):
2905         (BuildAndPerfTestWebKit2Factory):
2906         (BuildAndPerfTestWebKit2Factory.__init__):
2907         (DownloadAndPerfTestWebKit2Factory):
2908         (DownloadAndPerfTestWebKit2Factory.__init__):
2909
2910 2012-03-20  Peter Beverloo  <peter@chromium.org>
2911
2912         [Chromium] Update to Android NDK r7b
2913         https://bugs.webkit.org/show_bug.cgi?id=81005
2914
2915         Reviewed by Adam Barth.
2916
2917         Update to version r7b of the Android NDK, release notes of which are
2918         available on the following page:
2919         http://developer.android.com/sdk/ndk/index.html
2920
2921         * Scripts/update-webkit-chromium:
2922
2923 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
2924
2925         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
2926         https://bugs.webkit.org/show_bug.cgi?id=81502
2927
2928         Unreviewed.
2929
2930         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
2931
2932 2012-03-19  Jessie Berlin  <jberlin@apple.com>
2933
2934         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
2935         because they broke running the layout tests on mac.
2936
2937         * Scripts/webkitpy/layout_tests/port/webkit.py:
2938         (WebKitDriver._check_for_driver_crash):
2939
2940 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
2941
2942         [GTK] Allow running run-gtk-tests during 'make distcheck'
2943         https://bugs.webkit.org/show_bug.cgi?id=81415
2944
2945         Reviewed by Philippe Normand.
2946
2947         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
2948
2949         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
2950         main command run during 'make check.'
2951         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
2952         a requirement to run it. If jhbuild isn't around it will simply not start the
2953         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
2954         main loop and simply use the main loop in a synchronous method to start SPI
2955         daemons. Did a bunch of general cleanup around these tasks.
2956
2957 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2958
2959         jhbuild: Use the multiprocessing module to get the number of CPUs.
2960         https://bugs.webkit.org/show_bug.cgi?id=81585
2961
2962         Reviewed by Martin Robinson.
2963
2964         Now that support for Python 2.5 has been dropped, we can safely
2965         use multiprocessing.cpu_count() to obtain the current number of
2966         CPUs in the system instead of running a webkitperl script for
2967         that.
2968
2969         * efl/common.py:
2970         (top_level_path):
2971         * efl/jhbuildrc:
2972         * gtk/common.py:
2973         (build_path):
2974         * gtk/jhbuildrc:
2975
2976 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2977
2978         We should only add a live event listener once, not once per TestSelector.
2979         Adding one per TestSelector would cause accordion('option', 'active') to
2980         incorrectly be "false" if you examine multiple sets of tests.
2981
2982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2983
2984 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2985
2986         Fix typo introduced in r111293.
2987
2988         Unreviewed, build fix.
2989
2990         * Scripts/webkitpy/layout_tests/port/webkit.py:
2991         (WebKitDriver._check_for_driver_crash):
2992
2993 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2994
2995         webkitpy: get ServerProcess out of the reportcrash business
2996         https://bugs.webkit.org/show_bug.cgi?id=81600
2997
2998         Reviewed by Adam Barth.
2999
3000         ServerProcess was half-aware that ReportCrash might run
3001         sometimes, and that the process ServerProcess was talking to
3002         might have its own crashing subprocesses; neither of these
3003         things really worked right and it made the logic convoluted, so
3004         this change makes handling crashes completely separate from the
3005         server_process code, so that it can focus on just I/O to the
3006         subprocess.
3007
3008         There should be no functional changes resulting from this patch.
3009
3010         * Scripts/webkitpy/layout_tests/port/server_process.py:
3011         (ServerProcess._reset):
3012         (ServerProcess._handle_possible_interrupt):
3013         (ServerProcess.write):
3014         (ServerProcess.read_stdout):
3015         (ServerProcess.has_crashed):
3016         (ServerProcess._read):
3017         (ServerProcess.stop):
3018         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3019         (TrivialMockPort.check_for_leaks):
3020         (TestServerProcess.test_broken_pipe):
3021         * Scripts/webkitpy/layout_tests/port/webkit.py:
3022         (WebKitPort._read_image_diff):
3023         (WebKitDriver.has_crashed):
3024         (WebKitDriver._check_for_driver_crash):
3025         (WebKitDriver.run_test):
3026         (WebKitDriver._read_block):
3027         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3028         (MockServerProcess.__init__):
3029         (MockServerProcess):
3030         (MockServerProcess.has_crashed):
3031
3032 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3033
3034         webkitpy: crashlog parsing is broken
3035         https://bugs.webkit.org/show_bug.cgi?id=81586
3036
3037         Reviewed by Adam Barth.
3038
3039         Seeking on a file opened through codecs() appears to not work
3040         correctly (at least on SL).
3041         
3042         The code was more complicated than it needed to be, so I have
3043         revamped it to just read a full crashlog at once and then look
3044         for matches. 
3045         
3046         I have also added the ability to optionally propagate
3047         errors back (which can be helpful to debug races when ReportCrash is
3048         still running and you need to see that you couldn't open some
3049         files, rather than just ignoring them).
3050
3051         * Scripts/webkitpy/common/system/crashlogs.py:
3052         (CrashLogs.find_newest_log):
3053         (CrashLogs._find_newest_log_darwin):
3054         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3055         (CrashLogsTest.test_find_log_darwin):
3056
3057 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3058
3059         webkitpy: clean up some port._filesystem references to not reference private members
3060         https://bugs.webkit.org/show_bug.cgi?id=81595
3061
3062         Reviewed by Eric Seidel.
3063
3064         There should be no functional changes in this patch, just some
3065         refactoring. Also, fixes a minor nit in write_image_diff_files(()
3066
3067         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3068         (SingleTestRunner.__init__):
3069         (SingleTestRunner._run_compare_test):
3070         (SingleTestRunner._run_rebaseline):
3071         (SingleTestRunner._save_baseline_data):
3072         (SingleTestRunner._handle_error):
3073         (SingleTestRunner._run_reftest):
3074         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3075         (write_test_result):
3076         (TestResultWriter.__init__):
3077         (TestResultWriter._make_output_directory):
3078         (TestResultWriter.output_filename):
3079         (TestResultWriter._output_testname):
3080         (TestResultWriter.write_output_files):
3081         (TestResultWriter.write_stderr):
3082         (TestResultWriter.write_crash_report):
3083         (TestResultWriter.create_text_diff_and_write_result):
3084         (TestResultWriter.write_image_diff_files):
3085         (copy_file):
3086         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3087         (TestResultWriterTest.test_reftest_diff_image):
3088
3089 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3090
3091         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
3092         https://bugs.webkit.org/show_bug.cgi?id=81598
3093
3094         Reviewed by Eric Seidel.
3095
3096         "DumpRenderTree" shouldn't be hard-coded here, since some other
3097         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
3098         
3099         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3100         (TestExpectations):
3101
3102 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3103
3104         webkitpy: allow instance data in TestFailure objects
3105         https://bugs.webkit.org/show_bug.cgi?id=81580
3106
3107         Reviewed by Tony Chang.
3108
3109         Current TestFailures are basically enums, but it would be nice,
3110         especially for crashes, if they contained the name and pid of
3111         the process that crashed.
3112
3113         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3114         (TestFailure.message):
3115         (FailureTimeout.message):
3116         (FailureCrash):
3117         (FailureCrash.__init__):
3118         (FailureCrash.message):
3119         (FailureMissingResult.message):
3120         (FailureTextMismatch.message):
3121         (FailureMissingImageHash.message):
3122         (FailureMissingImage.message):
3123         (FailureImageHashMismatch.message):
3124         (FailureImageHashIncorrect.message):
3125         (FailureReftestMismatch.message):
3126         (FailureReftestMismatchDidNotOccur.message):
3127         (FailureReftestNoImagesGenerated.message):
3128         (FailureMissingAudio.message):
3129         (FailureAudioMismatch.message):
3130         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3131         (TestFailuresTest.test_equals):
3132         (TestFailuresTest):
3133         (TestFailuresTest.test_crashes):
3134
3135 2012-03-19  Brady Eidson  <beidson@apple.com>
3136
3137         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
3138         Crash in 3rd party WebKit apps under XHR/Cache code
3139
3140         Reviewed by Antti Koivisto.
3141
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3143         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
3144         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
3145         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3146         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3147         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3148         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3149         (TestWebKitAPI):
3150         (TestWebKitAPI::TEST):
3151
3152 2012-03-19  Brady Eidson  <beidson@apple.com>
3153
3154         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
3155         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
3156
3157         Reviewed by Enrica Casucci.
3158
3159         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
3160         are in the correct format.
3161
3162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3163         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
3164         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
3165         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
3166         (TestWebKitAPI::contextMenuCopyLink):
3167         (TestWebKitAPI::TEST):
3168
3169 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3170
3171         Make the selected item in the accordion a link to the flakiness dashboard
3172         https://bugs.webkit.org/show_bug.cgi?id=81571
3173
3174         Reviewed by Dimitri Glazkov.
3175
3176         Also, make it so that you can select the text of the link, instead of the current behavior
3177         of acting as if you had clicked on the accordion header.
3178
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3181
3182 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3183
3184         NRWT runs some tests that are skipped with -i command line option
3185         https://bugs.webkit.org/show_bug.cgi?id=81535
3186
3187         Reviewed by Ojan Vafai.
3188
3189         This change modifies the interaction of Skipped files and
3190         test_expectations files so that entries in Skipped files (and
3191         the -i command line) override *everything* in the expectations
3192         file.
3193
3194         Specifically, a directory in a Skipped file will cause all of
3195         the tests in the dir to be skipped even if individual tests in
3196         the dir are listed in the test_expectations.txt.
3197
3198         Skipped files also override anything in an overrides files.
3199
3200         This seems to make more intuitive sense, since if you list
3201         something in the Skips file (and even more specify it on the
3202         command line) you probably want it to be universally applied.
3203
3204         Theoretically we could add more precedence levels and have full
3205         paths in an expectations file override dirs in a Skipped file
3206         (but not the command line), but I don't know yet that that level
3207         of complexity is justified.
3208         
3209         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3210         (TestExpectations.__init__):
3211         (TestExpectations._add_skipped_tests):
3212         (TestExpectations._add_test):
3213         (TestExpectations._add_expectations):
3214         (TestExpectations._add_expectation_line):
3215         (TestExpectations._already_seen_better_match):
3216         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3217         (test_more_specific_override_resets_skip):
3218         (SkippedTests):
3219         (SkippedTests.get_exp):
3220         (SkippedTests.assert_exp):
3221         (SkippedTests.test_skipped_tests_work):
3222         (SkippedTests.test_duplicate_skipped_test_fails_lint):
3223         (SkippedTests.test_skipped_file_overrides_expectations):
3224         (SkippedTests.test_skipped_dir_overrides_expectations):
3225         (SkippedTests.test_skipped_file_overrides_overrides):
3226         (SkippedTests.test_skipped_dir_overrides_overrides):
3227
3228 2012-03-19  Eric Seidel  <eric@webkit.org>
3229
3230         Fix WTF header include discipline in Chromium WebKit
3231         https://bugs.webkit.org/show_bug.cgi?id=81281
3232
3233         Reviewed by James Robinson.
3234
3235         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3236         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
3237
3238 2012-03-19  Andy Chen  <andchen@rim.com>
3239
3240         [BlackBerry] Add new layout test for text match marker
3241         https://bugs.webkit.org/show_bug.cgi?id=81531
3242
3243         Make the LayoutTestControllerBlackBerry::findString to test the
3244         BlackBerry port implementation.
3245
3246         Reviewed by Rob Buis.
3247
3248         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3249         (LayoutTestController::findString):
3250
3251 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3252
3253         Don't show WONTFIX tests in garden-o-matic
3254         https://bugs.webkit.org/show_bug.cgi?id=81554
3255
3256         Reviewed by Dimitri Glazkov.
3257
3258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3260
3261 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
3262
3263         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
3264         https://bugs.webkit.org/show_bug.cgi?id=81530
3265
3266         Reviewed by Jessie Berlin.
3267
3268         Add rowAtIndex to WebKitTestRunner.
3269
3270         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3271         (WTR::AccessibilityUIElement::rowAtIndex):
3272         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3273         (AccessibilityUIElement):
3274         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3275         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3276         (WTR):
3277         (WTR::AccessibilityUIElement::rowAtIndex):
3278
3279 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3280
3281         Change garden-o-matic All Failures tab to Expected Failures
3282         https://bugs.webkit.org/show_bug.cgi?id=81540
3283
3284         Reviewed by Dimitri Glazkov.
3285
3286         Also, fix some broken unittests that had just gotten stale.
3287
3288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3290         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3298
3299 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
3300
3301         [chromium] DRT crashes at shutdown.
3302         https://bugs.webkit.org/show_bug.cgi?id=81504
3303
3304         Reviewed by James Robinson.
3305
3306         WebCompositor must be destroyed after WebView is properly destroyed,
3307         or some compositor objects like CCLayerTreeHost may not be destroyed.
3308         However, it is really hard to make the destruction order correct
3309         explicitly in ~TestShell. So move it out to DumpRenderTree.
3310
3311         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3312         (main):
3313         * DumpRenderTree/chromium/TestShell.cpp:
3314         (TestShell::~TestShell):
3315
3316 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3317
3318         add dpranke to webkitpy watchlist
3319         https://bugs.webkit.org/show_bug.cgi?id=81433
3320
3321         Reviewed by Benjamin Poulain.
3322
3323         * Scripts/webkitpy/common/config/watchlist:
3324
3325 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3326
3327         test-webkitpy is failing on SL/Python 2.6.1
3328         https://bugs.webkit.org/show_bug.cgi?id=81533
3329
3330         Reviewed by Ojan Vafai.
3331
3332         It appears that itertools.combinations() is buggy in 2.6.1; this
3333         backports the implementation from 2.7.
3334
3335         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3336         (TestConfigurationConverter.collapse_macros):
3337         (TestConfigurationConverter):
3338         (TestConfigurationConverter.combinations):
3339
3340 2012-03-19  David Michael Barr  <davidbarr@google.com>
3341
3342         Optimize the cleanup sequence in the start-queue.sh script
3343         https://github.com/abarth/webkit/pull/1
3344
3345         Reviewed by Adam Barth.
3346
3347         Updating the working copy is an expensive operation
3348         for a repository the size of WebKit.
3349         Attempt to reset only to the target revision.
3350
3351         * EWSTools/start-queue.sh:
3352
3353 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
3354
3355         Adjust architecture type of the EFL build bot.
3356         https://bugs.webkit.org/show_bug.cgi?id=81452
3357
3358         Reviewed by Tony Chang.
3359
3360         * BuildSlaveSupport/build.webkit.org-config/config.json: The
3361         buildslave is a 64-bit machine, therefore describe it as being
3362         x86_64, not i386.
3363
3364 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
3365
3366         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
3367         https://bugs.webkit.org/show_bug.cgi?id=81514
3368
3369         Reviewed by Simon Hausmann.
3370
3371         * MiniBrowser/qt/qml/BrowserWindow.qml:
3372
3373 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3374
3375         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
3376         https://bugs.webkit.org/show_bug.cgi?id=81491
3377
3378         Reviewed by Philippe Normand.
3379
3380         For the find_path(), find_library() etc CMake calls to find the
3381         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
3382         set, otherwise CMake cannot know the dependencies exist and will only
3383         look in the standard directories.
3384
3385         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
3386         the jhbuild Root directory.
3387
3388 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3389
3390         [EFL] Add XDG env vars to jhbuildrc
3391         https://bugs.webkit.org/show_bug.cgi?id=81510
3392
3393         Needed to ensure correct glib behaviour in jhbuild environment.
3394
3395         Reviewed by Philippe Normand.
3396
3397         * efl/jhbuildrc:
3398
3399 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3400
3401         Select best target for tap gesture.
3402         https://bugs.webkit.org/show_bug.cgi?id=78801
3403
3404         Reviewed by Kenneth Rohde Christiansen.
3405
3406         Add TOUCH_ADJUSTMENT to enabled features.
3407
3408         * qmake/mkspecs/features/features.prf:
3409
3410 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
3411
3412         [chromium] synthesize wheel events for fling on main thread
3413         https://bugs.webkit.org/show_bug.cgi?id=81458
3414
3415         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
3416
3417         Reviewed by James Robinson.
3418
3419         * DumpRenderTree/chromium/EventSender.cpp:
3420         (EventSender::EventSender):
3421         (EventSender::gestureFlingCancel):
3422         (EventSender::gestureFlingStart):
3423         * DumpRenderTree/chromium/EventSender.h:
3424         (EventSender):
3425
3426 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
3427
3428         [Qt] Add command line option to set the user agent in the MiniBrowser
3429         https://bugs.webkit.org/show_bug.cgi?id=81508
3430
3431         Reviewed by Simon Hausmann.
3432
3433         * MiniBrowser/qt/BrowserWindow.cpp:
3434         (BrowserWindow::BrowserWindow):
3435         (BrowserWindow::webViewExperimental):
3436         * MiniBrowser/qt/BrowserWindow.h:
3437         (BrowserWindow):
3438         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3439         (printHelp):
3440         (MiniBrowserApplication::handleUserOptions):
3441         * MiniBrowser/qt/MiniBrowserApplication.h:
3442         (WindowOptions::WindowOptions):
3443         (WindowOptions::setUserAgent):
3444         (WindowOptions::userAgent):
3445         (WindowOptions):
3446
3447 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
3448
3449         [Qt] Remove dead user agent code from the MiniBrowser.
3450
3451         Reviewed by Simon Hausmann.
3452
3453         * MiniBrowser/qt/BrowserWindow.cpp:
3454         * MiniBrowser/qt/BrowserWindow.h:
3455         (BrowserWindow):
3456         * MiniBrowser/qt/MiniBrowser.qrc:
3457         * MiniBrowser/qt/useragentlist.txt: Removed.
3458
3459 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3460
3461         jhbuild: Call jhbuild's autogen.sh via bash.
3462         https://bugs.webkit.org/show_bug.cgi?id=81485
3463
3464         Reviewed by Philippe Normand.
3465
3466         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
3467         this is usually true only on Linux systems, and even then bash for
3468         some reason might not be available in that location. It is safer to
3469         call bash directly and pass autogen.sh to it instead.
3470
3471         * jhbuild/jhbuild-wrapper:
3472         (install_jhbuild):
3473
3474 2012-03-19  Philippe Normand  <pnormand@igalia.com>
3475
3476         [GTK] Prefix run-launcher with run-with-jhbuild
3477         https://bugs.webkit.org/show_bug.cgi?id=81503
3478
3479         Reviewed by Hajime Morita.
3480
3481         * Scripts/run-launcher:
3482
3483 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3484
3485         [EFL] Prefix run-launcher with run-with-jhbuild
3486         https://bugs.webkit.org/show_bug.cgi?id=80026
3487
3488         Reviewed by Hajime Morita.
3489
3490         * Scripts/run-launcher:
3491
3492 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3493
3494         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
3495         https://bugs.webkit.org/show_bug.cgi?id=81498
3496
3497         * qmake/mkspecs/features/unix/default_post.prf:
3498
3499 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3500
3501         Unreviewed; switch to using my FreeBSD.org email address, the
3502         other one is going to disappear soon.
3503
3504         * Scripts/webkitpy/common/config/committers.py:
3505         * Scripts/webkitpy/common/config/watchlist:
3506
3507 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
3508
3509         Unreviewed; fix webkitpy unit test failures after r111116.
3510
3511         It turns out that cmd_line in the patch in bug 80025 had the right
3512         signature when it was submitted, but r109242 added a few more
3513         required parameters, and since the method (and EflDriver) did not
3514         exist at the time we ended up committing a broken method.
3515
3516         * Scripts/webkitpy/layout_tests/port/efl.py:
3517         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
3518         arguments.
3519
3520 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
3521
3522         [BlackBerry] Enable Web Timing for performance profiling and improvement.
3523         https://bugs.webkit.org/show_bug.cgi?id=81085
3524
3525         Reviewed by Rob Buis.
3526
3527         * Scripts/build-webkit:
3528
3529 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3530
3531         Add a dependencies installation step for EFL to buildbot master.cfg
3532         https://bugs.webkit.org/show_bug.cgi?id=81337
3533
3534         Reviewed by Gustavo Noronha Silva.
3535
3536         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3537         (InstallEflDependencies):
3538         (Factory.__init__):
3539
3540 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3541
3542         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
3543         https://bugs.webkit.org/show_bug.cgi?id=80025
3544
3545         Reviewed by Gustavo Noronha Silva.
3546
3547         * Scripts/webkitpy/layout_tests/port/efl.py:
3548         (EflDriver):
3549         (EflDriver.cmd_line):
3550         (EflPort._driver_class):
3551
3552 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3553
3554         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
3555         https://bugs.webkit.org/show_bug.cgi?id=79904
3556
3557         build-webkit --efl will use jhbuild for fetching and building dependencies.
3558
3559         Reviewed by Gustavo Noronha Silva.
3560
3561         * Scripts/update-webkitefl-libs: Added.
3562         * Scripts/webkitdirs.pm:
3563         (jhbuildWrapperPrefixIfNeeded):
3564         (generateBuildSystemFromCMakeProject):
3565         (buildCMakeGeneratedProject):
3566         * efl/common.py: Added.
3567         (script_path):
3568         (top_level_path):
3569         (number_of_cpus):
3570         * efl/jhbuild.modules: Added.
3571         * efl/jhbuildrc: Added.
3572         * efl/run-with-jhbuild: Added.
3573
3574 2012-03-16  Stephanie Lewis  <slewis@apple.com>
3575
3576         https://bugs.webkit.org/show_bug.cgi?id=81065
3577         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
3578         Fix crash preventing WebKitTestRunner from working in Release.  
3579         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
3580         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
3581         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
3582
3583         I removed ostringstream in favor of StringBuilder.  
3584
3585         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
3586
3587         Reviewed by Geoff Garen.
3588
3589         Add DEBUG_DEFINES to set NDEBUG on release builds.
3590         * WebKitTestRunner/Configurations/Base.xcconfig:
3591         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3592
3593         Remove ostringstream member in favor of StringBuilder.
3594         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3595         (WTR::InjectedBundle::initialize):
3596         (WTR::InjectedBundle::beginTesting):
3597         (WTR::InjectedBundle::done):
3598         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3599         (WTF):
3600         (WTR::InjectedBundle::stringBuilder):
3601         (InjectedBundle):
3602
3603         Append output to StringBuilder.
3604         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3605         (WTR::hasPrefix):
3606         (WTR::dumpPath):
3607         (WTR::rangeToStr):
3608         (WTR::styleDecToStr):
3609         (WTR::frameToStr):
3610         (WTR::dumpFrameScrollPosition):
3611         (WTR::dumpFrameText):
3612         (WTR::dumpDescendantFramesText):
3613         (WTR::InjectedBundlePage::dump):
3614         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3615         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3616         (WTR::InjectedBundlePage::willSendRequestForFrame):
3617         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3618         (WTR::lastFileURLPathComponent):
3619         (WTR::InjectedBundlePage::willAddMessageToConsole):
3620         (WTR::InjectedBundlePage::willSetStatusbarText):
3621         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3622         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3623         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3624         (WTR::InjectedBundlePage::shouldBeginEditing):
3625         (WTR::InjectedBundlePage::shouldEndEditing):
3626         (WTR::InjectedBundlePage::shouldInsertNode):
3627         (WTR::InjectedBundlePage::shouldInsertText):
3628         (WTR::InjectedBundlePage::shouldDeleteRange):
3629         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3630         (WTR::InjectedBundlePage::shouldApplyStyle):
3631         (WTR::InjectedBundlePage::didBeginEditing):
3632         (WTR::InjectedBundlePage::didEndEditing):
3633         (WTR::InjectedBundlePage::didChange):
3634         (WTR::InjectedBundlePage::didChangeSelection):
3635         (WTR::InjectedBundlePage::supportsFullScreen):
3636         (WTR::InjectedBundlePage::enterFullScreenForElement):
3637         (WTR::InjectedBundlePage::exitFullScreenForElement):
3638         (WTR::InjectedBundlePage::beganEnterFullScreen):
3639         (WTR::InjectedBundlePage::beganExitFullScreen):
3640         (WTR::dumpBackForwardListItem):
3641         (WTR::InjectedBundlePage::dumpBackForwardList):
3642         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3643         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
3644         (WTR::LayoutTestController::dumpConfigurationForViewport):
3645         
3646         Convert between WTF::String and WKStringRef.
3647         * WebKitTestRunner/StringFunctions.h:
3648         (WTR::toWTFString):
3649         (WTR):
3650         * WebKitTestRunner/TestInvocation.cpp:
3651         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3652
3653 2012-03-16  Eric Seidel  <eric@webkit.org>
3654
3655         Add a land-from-url command
3656         https://bugs.webkit.org/show_bug.cgi?id=81411
3657
3658         Reviewed by Adam Barth.
3659
3660         Very basic so far.  The goal is to make it landing smarter
3661         so that users don't have to bother to parse out the ids out of the urls.
3662
3663         * Scripts/webkitpy/common/config/urls.py:
3664         (parse_bug_id):
3665         (parse_attachment_id):
3666         * Scripts/webkitpy/common/config/urls_unittest.py:
3667         (URLsTest.test_parse_bug_id):
3668         (URLsTest):
3669         (URLsTest.test_parse_attachment_id):
3670         * Scripts/webkitpy/tool/commands/download.py:
3671         (ProcessURLsMixin):
3672         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3673         (LandFromURL):
3674         * Scripts/webkitpy/tool/commands/download_unittest.py:
3675         (test_land_from_bug):
3676         (test_land_from_url):
3677
3678 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
3679
3680         build-webkit launcher instructions use wrong relative path for Qt
3681