1 2016-01-21 Filip Pizlo <fpizlo@apple.com>
3 display-profiler-output should be able to display code blocks sorted by machine counts
4 https://bugs.webkit.org/show_bug.cgi?id=153298
6 Reviewed by Oliver Hunt.
8 * Scripts/display-profiler-output:
10 2016-01-21 Julien Isorce <j.isorce@samsung.com>
12 Ensure to use compatible liborc version with wanted gstreamer version
13 https://bugs.webkit.org/show_bug.cgi?id=153276
15 For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
16 The user may have a very recent liborc installed on his system.
18 Reviewed by Philippe Normand.
20 * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
21 * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
23 2016-01-21 Nan Wang <n_wang@apple.com>
25 AX: [IOS] Implement next/previous text marker functions using TextIterator
26 https://bugs.webkit.org/show_bug.cgi?id=153292
27 <rdar://problem/24268243>
29 Reviewed by Chris Fleizach.
31 Made text marker tests available on iOS.
33 * DumpRenderTree/AccessibilityTextMarker.h:
34 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
35 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
36 (AccessibilityTextMarker::AccessibilityTextMarker):
37 (AccessibilityTextMarker::~AccessibilityTextMarker):
38 (AccessibilityTextMarker::isEqual):
39 (AccessibilityTextMarker::platformTextMarker):
40 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
41 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
42 (AccessibilityTextMarkerRange::isEqual):
43 (AccessibilityTextMarkerRange::platformTextMarkerRange):
44 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
45 (AccessibilityUIElement::pathDescription):
46 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
47 (AccessibilityUIElement::textMarkerRangeForElement):
48 (AccessibilityUIElement::selectedTextMarkerRange):
49 (AccessibilityUIElement::resetSelectedTextMarkerRange):
50 (AccessibilityUIElement::textMarkerRangeLength):
51 (AccessibilityUIElement::textMarkerRangeForMarkers):
52 (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
53 (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
54 (AccessibilityUIElement::accessibilityElementForTextMarker):
55 (AccessibilityUIElement::endTextMarkerForBounds):
56 (AccessibilityUIElement::startTextMarkerForBounds):
57 (AccessibilityUIElement::textMarkerForPoint):
58 (AccessibilityUIElement::previousTextMarker):
59 (AccessibilityUIElement::nextTextMarker):
60 (AccessibilityUIElement::stringForTextMarkerRange):
61 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
62 (AccessibilityUIElement::indexForTextMarker):
63 (AccessibilityUIElement::isTextMarkerValid):
64 (AccessibilityUIElement::textMarkerForIndex):
65 (AccessibilityUIElement::startTextMarker):
66 (AccessibilityUIElement::endTextMarker):
67 (AccessibilityUIElement::setSelectedVisibleTextRange):
68 (AccessibilityUIElement::getLinkedUIElements):
69 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
70 (AccessibilityTextMarkerRange::platformTextMarkerRange):
71 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
72 (AccessibilityUIElement::removeSelection):
73 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
74 (AccessibilityUIElement::setSelectedVisibleTextRange):
75 (AccessibilityUIElement::supportedActions):
76 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
77 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
78 (WTR::AccessibilityUIElement::textMarkerRangeLength):
79 (WTR::AccessibilityUIElement::previousTextMarker):
80 (WTR::AccessibilityUIElement::nextTextMarker):
81 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
82 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
83 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
84 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
85 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
86 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
87 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
89 2016-01-20 Filip Pizlo <fpizlo@apple.com>
91 Unreviewed, revert accidental unreviewed commit.
93 * Scripts/display-profiler-output:
95 2016-01-20 Jason Marcell <jmarcell@apple.com>
97 Refactor compareIterations to remove duplicate code.
98 https://bugs.webkit.org/show_bug.cgi?id=152913
100 Reviewed by Daniel Bates.
102 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
103 (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
104 (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
105 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
106 the same behavior before and after refactor.
108 2016-01-20 Dana Burkart <dburkart@apple.com>
110 Botwatcher's dashboard should show an 'X' when the build is broken
111 https://bugs.webkit.org/show_bug.cgi?id=152507
113 Reviewed by David Kilzer.
115 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
116 (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
117 (BuildbotStaticAnalyzerQueueView.prototype.update):
119 2016-01-19 Jason Marcell <jmarcell@apple.com>
121 Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
122 https://bugs.webkit.org/show_bug.cgi?id=153262
124 Reviewed by Alexey Proskuryakov.
126 Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
127 such cases this revisionContentForIteration method does not have any content to return, thus the
130 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
131 (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
133 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
135 [GTK] Runtime critical warnings when loading a URL after a session restore
136 https://bugs.webkit.org/show_bug.cgi?id=153233
138 Reviewed by Michael Catanzaro.
142 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
144 (testWebKitWebViewNavigationAfterSessionRestore):
147 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
149 [GTK] Remove jhbuild-optional.modules
150 https://bugs.webkit.org/show_bug.cgi?id=152964
152 Reviewed by Alex Christensen.
154 * gtk/jhbuild-optional.modules: Removed.
155 * gtk/jhbuild.modules:
157 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
159 [GTK] Add support to load/save session in MiniBrowser
160 https://bugs.webkit.org/show_bug.cgi?id=153201
162 Reviewed by Michael Catanzaro.
164 It makes it easier to test the new WebView session API.
166 * MiniBrowser/gtk/BrowserWindow.c:
167 (browserWindowFinalize): Free the session file path.
168 (browserWindowSaveSession): Save the current WebView session if
169 there's a session file path.
170 (browserWindowDeleteEvent): Call browserWindowSaveSession().
171 (browser_window_load_session): Try to load the session from the
172 given file path, otherwise fall back to homepage and keep the
173 session file to save the session on window close.
174 * MiniBrowser/gtk/BrowserWindow.h:
175 * MiniBrowser/gtk/main.c:
176 (createBrowserWindow): Pass the given session file path when
177 shouldLoadSession is TRUE.
178 (main): Only allow to restore/save session when MiniBrowser is
179 launched without URL arguments.
181 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
183 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
185 Geolocation is no longer allowed for unique origins after r195075.
187 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
188 (testWebViewGeolocationPermissionRequests):
190 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
192 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
193 https://bugs.webkit.org/show_bug.cgi?id=153216
195 Reviewed by Michael Catanzaro.
197 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
198 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
200 2016-01-18 Nan Wang <n_wang@apple.com>
202 AX: [Mac] Implement next/previous text marker functions using TextIterator
203 https://bugs.webkit.org/show_bug.cgi?id=152728
205 Reviewed by Chris Fleizach.
207 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
208 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
210 2016-01-18 Csaba Osztrogonác <ossy@webkit.org>
212 [cmake] Add testair to the build system
213 https://bugs.webkit.org/show_bug.cgi?id=153126
215 Reviewed by Michael Catanzaro.
219 2016-01-16 Myles C. Maxfield <mmaxfield@apple.com>
221 Remove TextRun::allowsRoundingHacks()
222 https://bugs.webkit.org/show_bug.cgi?id=153185
224 Reviewed by Simon Fraser.
226 * DumpRenderTree/mac/DumpRenderTree.mm:
227 (resetWebViewToConsistentStateBeforeTesting): Deleted.
229 2016-01-15 Konstantin Tokarev <annulen@yandex.ru>
231 [webkitdirs] Avoid list form of open because it broke WinCairo
232 https://bugs.webkit.org/show_bug.cgi?id=153106
234 Reviewed by Alex Christensen.
236 * Scripts/webkitdirs.pm:
237 (determineArchitecture):
239 2016-01-15 Simon Fraser <simon.fraser@apple.com>
241 Add kdebug_trace signposts for a few WebCore operations
242 https://bugs.webkit.org/show_bug.cgi?id=153136
243 rdar://problem/24208487
245 Reviewed by Sam Weinig.
247 Plist used by kdebug_trace() viewing tools.
249 * Tracing/SystemTracePoints.plist: Added.
251 2016-01-14 Konstantin Tokarev <annulen@yandex.ru>
253 [webkitdirs] Replaced grep invocation with perl code
254 https://bugs.webkit.org/show_bug.cgi?id=153106
256 Reviewed by Alex Christensen.
258 * Scripts/webkitdirs.pm:
259 (determineArchitecture):
261 2016-01-14 Brian Burg <bburg@apple.com>
263 prepare-changelog does not read paths containing spaces properly
264 https://bugs.webkit.org/show_bug.cgi?id=137982
266 Reviewed by Joseph Pecoraro.
268 Escape whitespace in filenames before passing the file path to other functions.
270 * Scripts/prepare-ChangeLog:
271 (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
273 2016-01-14 Jason Marcell <jmarcell@apple.com>
275 Standardize the usage of "branch" vs. "branchName".
276 https://bugs.webkit.org/show_bug.cgi?id=152982
278 Reviewed by Daniel Bates.
280 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
281 "branchName" implies that the variable or property in question is simply a string.
283 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
284 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
285 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
286 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
287 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
288 (Trac.prototype.commitsOnBranch): Change branch to branchName.
289 (Trac.prototype._convertCommitInfoElementToObject): Ditto.
290 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
293 2016-01-14 Jason Marcell <jmarcell@apple.com>
295 Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
296 https://bugs.webkit.org/show_bug.cgi?id=152910
298 Reviewed by Daniel Bates.
300 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
301 (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
302 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
303 (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
304 the need to talk to a real Buildbot server.
305 (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
306 without the need to talk to a real Buildbot server.
307 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
308 (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
310 (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
311 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
312 (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
313 trying to talk to Trac.
314 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
316 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
318 2016-01-14 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
320 [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
321 https://bugs.webkit.org/show_bug.cgi?id=132599
323 Reviewed by Michael Catanzaro.
325 Check if cmake Ninja generators are installed.
327 * Scripts/webkitdirs.pm:
328 (canUseNinjaGenerator):
329 (canUseEclipseNinjaGenerator):
330 (generateBuildSystemFromCMakeProject):
331 (canUseEclipse): Deleted.
333 2016-01-13 Myles C. Maxfield <mmaxfield@apple.com>
335 [Cocoa] Testing with font family name "System Font" is unused
336 https://bugs.webkit.org/show_bug.cgi?id=153073
337 <rdar://problem/24091683>
339 Reviewed by Brent Fulgham.
341 * DumpRenderTree/mac/DumpRenderTree.mm:
342 (allowedFontFamilySet): Deleted.
343 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
344 (WTR::allowedFontFamilySet): Deleted.
345 * WebKitTestRunner/mac/TestControllerMac.mm:
346 (WTR::allowedFontFamilySet): Deleted.
348 2016-01-13 Daniel Bates <dabates@apple.com>
350 [XSS Auditor] Add test when XSS payload is in the path portion of the URL
351 https://bugs.webkit.org/show_bug.cgi?id=152871
353 Reviewed by Brent Fulgham.
355 Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
356 <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
358 * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
360 2016-01-08 Andy Estes <aestes@apple.com>
362 [Content Filtering] Lazily load platform frameworks
363 https://bugs.webkit.org/show_bug.cgi?id=152881
364 rdar://problem/23270886
366 Reviewed by Brady Eidson.
368 Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
369 expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
370 loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
371 and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
372 is loaded after an HTTPS request.
374 To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
375 Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
376 WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
377 also re-enabled on iOS after mistakenly being disabled by r188892.
379 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
381 (TestWebKitAPI::TEST):
382 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
383 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
384 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
387 (-[LazilyLoadPlatformFrameworksController init]):
388 (-[LazilyLoadPlatformFrameworksController webView]):
389 (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
390 (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
391 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
392 (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
393 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
394 (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
395 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
396 (TestWebKitAPI::TEST):
397 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
398 (TestWebKitAPI::TEST): Deleted.
399 * TestWebKitAPI/cocoa/TestProtocol.h:
400 * TestWebKitAPI/cocoa/TestProtocol.mm:
401 (+[TestProtocol registerWithScheme:]):
402 (+[TestProtocol unregister]):
404 2016-01-12 Dewei Zhu <dewei_zhu@apple.com>
406 Fix the Sunpider converage in slow device.
407 https://bugs.webkit.org/show_bug.cgi?id=152938
408 <rdar://problem/22511411>
410 Reviewed by Ryosuke Niwa.
412 Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
414 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
416 2016-01-12 Ryosuke Niwa <rniwa@webkit.org>
418 Add a build flag for custom element
419 https://bugs.webkit.org/show_bug.cgi?id=153005
421 Reviewed by Alex Christensen.
423 Added --custom-elements option to enable custom elements support.
425 * Scripts/webkitperl/FeatureList.pm:
427 2016-01-12 Benjamin Poulain <bpoulain@apple.com>
429 [JSC] Add a help message when run-jsc-stress-tests fails
430 https://bugs.webkit.org/show_bug.cgi?id=153014
432 Reviewed by Csaba Osztrogonác.
434 * Scripts/run-jsc-stress-tests:
436 2016-01-11 Saam barati <sbarati@apple.com>
438 run-jsc-stress-tests should try to figure out a JSC path
439 https://bugs.webkit.org/show_bug.cgi?id=152971
441 Reviewed by Yusuke Suzuki.
443 This patch now allows run-jsc-stress-tests to be run
444 without a "--jsc <jsc-path>" argument. It tries
445 to take its best guess at a <jsc-path> automagically.
447 This makes it much easier to just run run-jsc-stress-tests
448 with a directory or a yaml file as an argument.
449 You now just do this:
450 `run-jsc-stress-tests <path-to-yaml>`
452 `run-jsc-stress-tests <path-to-directory-of-js-files>`
454 I wrote this patch because I'd often find myself hacking the
455 run-javascriptcore-tests file just to run a particular subset of tests.
456 Because I always forget the arguments to run-jsc-stress-tests (which means
457 I always forgot to provide a --jsc argument), I always found it easier to
458 just hack on that file instead of calling run-jsc-stress-tests directly.
459 No longer is this true!
461 * Scripts/run-jsc-stress-tests:
463 2016-01-09 Andy Estes <aestes@apple.com>
465 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
466 https://bugs.webkit.org/show_bug.cgi?id=152950
467 rdar://problem/24066652
469 Reviewed by Tim Horton.
473 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
474 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
475 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
476 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
477 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
478 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
479 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
480 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
483 2016-01-11 Commit Queue <commit-queue@webkit.org>
485 Unreviewed, rolling out r194866.
486 https://bugs.webkit.org/show_bug.cgi?id=152986
488 This change broke the mac build (Requested by ryanhaddad on
493 "[Cocoa] Add SPI to opt out a URL scheme from the memory
495 https://bugs.webkit.org/show_bug.cgi?id=152950
496 http://trac.webkit.org/changeset/194866
498 2016-01-11 Andy Estes <aestes@apple.com>
500 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
501 https://bugs.webkit.org/show_bug.cgi?id=152950
502 rdar://problem/24066652
504 Reviewed by Tim Horton.
508 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
509 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
510 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
511 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
512 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
513 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
514 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
515 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
518 2016-01-11 Konstantin Tokarev <annulen@yandex.ru>
520 [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
521 https://bugs.webkit.org/show_bug.cgi?id=152959
523 Reviewed by Brent Fulgham.
525 * Scripts/webkitdirs.pm:
526 (determineArchitecture):
528 2016-01-11 Michael Catanzaro <mcatanzaro@igalia.com>
530 [GTK] W3C CSS2.1 anonymous table tests are failing
531 https://bugs.webkit.org/show_bug.cgi?id=152455
533 Reviewed by Mario Sanchez Prada.
535 Add shared-mime-info to the jhbuild environment, since it affects the results of layout
536 tests. Add upstream patches to fix detection of XHTML files.
538 * gtk/jhbuild.modules:
539 * gtk/patches/shared-mime-info-xht-glob.patch: Added.
540 * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
542 2016-01-10 Saam barati <sbarati@apple.com>
544 Implement a sampling profiler
545 https://bugs.webkit.org/show_bug.cgi?id=151713
547 Reviewed by Filip Pizlo.
549 * Scripts/run-jsc-stress-tests:
551 2016-01-10 Konstantin Tokarev <annulen@yandex.ru>
553 [webkitdirs] Try arch and uname commands on non-windows OS
554 https://bugs.webkit.org/show_bug.cgi?id=152958
556 Reviewed by Michael Catanzaro.
558 Right now, determineArchitecture() uses `arch` and `uname -m`
559 commands to determine architecture in case of condition (isGtk() ||
560 isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
561 instead, because this code is applicable to any non-windows OS WebKit
562 supports (even Haiku which once was supported is moderately
563 POSIX-compliant and has uname command).
565 * Scripts/webkitdirs.pm:
566 (determineArchitecture):
568 2016-01-08 Aakash Jain <aakash_jain@apple.com>
570 run-webkit-tests mis-counts totals when there are other crashes
571 https://bugs.webkit.org/show_bug.cgi?id=152894
572 <rdar://problem/24098697>
574 Reviewed by Alexey Proskuryakov.
576 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
577 (TestRunResults.add): Do not update result counters for other crashes.
579 2016-01-08 Youenn Fablet <youenn.fablet@crf.canon.fr>
581 webkit-patch build-and-test should have an option to iterate over new tests
582 https://bugs.webkit.org/show_bug.cgi?id=143093
584 Reviewed by Michael Catanzaro.
586 This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
587 It allows running run-webkit-tests on modified or new paths in LayoutTests.
588 Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
589 It implements the translation of -expected.* paths to their related tests.
590 It also implements the removal of skipped tests.
592 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
593 (LayoutTestFinder.find_touched_tests):
594 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
598 (LayoutTestFinderTests):
599 (LayoutTestFinderTests.touched_files):
600 (LayoutTestFinderTests.test_touched_test):
601 (LayoutTestFinderTests.test_expected_touched_test):
602 (LayoutTestFinderTests.test_platform_expected_touched_test):
603 (LayoutTestFinderTests.test_platform_duplicate_touched_test):
604 (LayoutTestFinderTests.test_touched_but_skipped_test):
605 * Scripts/webkitpy/port/base.py:
606 (Port.potential_test_names_from_expected_file):
607 * Scripts/webkitpy/tool/commands/download_unittest.py:
608 (DownloadCommandsTest._default_options):
609 * Scripts/webkitpy/tool/steps/options.py:
611 * Scripts/webkitpy/tool/steps/runtests.py:
615 (RunTests._new_or_modified_tests):
616 (RunTests._run_webkit_tests):
617 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
618 (RunTestsTest.test_webkit_run_unit_tests):
619 * Scripts/webkitpy/tool/steps/steps_unittest.py:
620 (StepsTest._step_options):
622 2016-01-07 Joseph Pecoraro <pecoraro@apple.com>
624 prepare-ChangeLog should include radar number
625 https://bugs.webkit.org/show_bug.cgi?id=152839
626 <rdar://problem/24093563>
628 Reviewed by Daniel Bates.
630 When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
631 starts with a "<rdar://problem/####>" URL. If found, include that radar URL
632 in the ChangeLog description after the bug URL.
634 * Scripts/prepare-ChangeLog:
635 (main): Update signatures.
636 (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
637 (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
638 (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
639 (generateNewChangeLogs): Include radar URL if we found one.
641 * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
642 Tests for the radar URL extraction.
644 2016-01-07 Alexey Proskuryakov <ap@apple.com>
646 testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
647 https://bugs.webkit.org/show_bug.cgi?id=152390
648 <rdar://problem/23948321>
650 Reviewed by Simon Fraser.
652 Fix two use-after-frees.
654 1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
655 but we may have already progressed to another test by the time the callback fires,
656 having destroyed the TestInvocation.
657 2. UIScriptController is a RefCounted object, but it has a raw pointer to
658 UIScriptContext which has the same lifetime as a TestInvocation.
659 As a result, completion blocks of UIScriptController actions would use a destroyed
662 * WebKitTestRunner/TestInvocation.cpp:
663 (WTR::TestInvocation::~TestInvocation):
664 (WTR::TestInvocation::url):
665 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
666 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
667 (WTR::TestInvocation::runUISideScript):
668 * WebKitTestRunner/TestInvocation.h:
669 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
670 (UIScriptContext::UIScriptContext):
671 (UIScriptContext::~UIScriptContext):
672 (UIScriptContext::runUIScript):
673 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
674 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
675 (WTR::UIScriptController::UIScriptController):
676 (WTR::UIScriptController::contextDestroyed):
677 (WTR::UIScriptController::makeWindowObject):
678 (WTR::UIScriptController::setWillBeginZoomingCallback):
679 (WTR::UIScriptController::willBeginZoomingCallback):
680 (WTR::UIScriptController::setDidEndZoomingCallback):
681 (WTR::UIScriptController::didEndZoomingCallback):
682 (WTR::UIScriptController::setDidEndScrollingCallback):
683 (WTR::UIScriptController::didEndScrollingCallback):
684 (WTR::UIScriptController::setDidShowKeyboardCallback):
685 (WTR::UIScriptController::didShowKeyboardCallback):
686 (WTR::UIScriptController::setDidHideKeyboardCallback):
687 (WTR::UIScriptController::didHideKeyboardCallback):
688 (WTR::UIScriptController::uiScriptComplete):
689 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
690 (WTR::UIScriptController::create):
691 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
692 (WTR::UIScriptController::doAsyncTask):
693 (WTR::UIScriptController::zoomToScale):
694 (WTR::UIScriptController::singleTapAtPoint):
695 (WTR::UIScriptController::doubleTapAtPoint):
696 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
697 (WTR::UIScriptController::contentVisibleRect):
698 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
699 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
700 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
701 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
702 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
703 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
704 (WTR::UIScriptController::doAsyncTask):
706 2016-01-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
708 [buildbot] clean-build script should remove untracked files and revert local changes too
709 https://bugs.webkit.org/show_bug.cgi?id=142400
711 Reviewed by Ryosuke Niwa.
713 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
714 A helper routine SCM.discard_untracked_files is added for that purpose.
716 * BuildSlaveSupport/clean-build:
717 (main): Making call to Scripts/clean-webkit
718 * Scripts/clean-webkit: Added.
719 (main): Revert changes and delete untracked files.
720 * Scripts/webkitpy/common/checkout/scm/scm.py:
721 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
722 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
723 (SCMTest._shared_test_discard_untracked_files):
724 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
726 2016-01-06 Simon Fraser <simon.fraser@apple.com>
728 Add a setting and preferences to enable display-list drawing. Does nothing yet.
729 https://bugs.webkit.org/show_bug.cgi?id=152807
731 Reviewed by Zalan Bujtas.
733 Add an item to the Settings menu to toggle display-list drawing.
735 * MiniBrowser/mac/SettingsController.h:
736 * MiniBrowser/mac/SettingsController.m:
737 (-[SettingsController _populateMenu]):
738 (-[SettingsController validateMenuItem:]):
739 (-[SettingsController toggleDisplayListDrawingEnabled:]):
740 (-[SettingsController displayListDrawingEnabled]):
741 * MiniBrowser/mac/WK2BrowserWindowController.m:
742 (-[WK2BrowserWindowController didChangeSettings]):
744 2016-01-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
746 Python SCM should be able to retrieve untracked files - Add GIT support
747 https://bugs.webkit.org/show_bug.cgi?id=143135
749 Reviewed by Michael Catanzaro.
751 * Scripts/webkitpy/common/checkout/scm/git.py:
752 (Git.untracked_files): Adding support for git.
753 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
755 (GitTest.test_untracked_files): Adding test.
757 2016-01-05 Mark Lam <mark.lam@apple.com>
759 Rename badly named JSC_timeout env var to JSCTEST_timeout.
760 https://bugs.webkit.org/show_bug.cgi?id=152748
762 Reviewed by Geoffrey Garen.
764 Now that we validate JSC options, the badly named JSC_timeout env var causes the
765 bots to have a bad time.
767 * Scripts/run-javascriptcore-tests:
768 * Scripts/run-jsc-stress-tests:
770 2016-01-04 Carlos Garcia Campos <cgarcia@igalia.com>
772 [GTK] Allow to save and restore session
773 https://bugs.webkit.org/show_bug.cgi?id=115600
775 Reviewed by Michael Catanzaro.
777 Add test case to check the new session API.
779 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
780 (testWebKitWebViewSessionState):
781 (testWebKitWebViewSessionStateWithFormData):
784 2016-01-04 Csaba Osztrogonác <ossy@webkit.org>
786 [EFL] Bump EFL version to 1.16.1
787 https://bugs.webkit.org/show_bug.cgi?id=152688
789 Reviewed by Gyuyoung Kim.
791 * efl/jhbuild.modules:
793 2016-01-04 Aakash Jain <aakash_jain@apple.com>
795 error running layout tests on iOS simulator on latest build
796 https://bugs.webkit.org/show_bug.cgi?id=152719
797 <rdar://problem/24009549>
799 Reviewed by Alexey Proskuryakov.
801 * Scripts/webkitpy/xcode/simulator.py:
802 (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
803 before running simctl spawn command.
805 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
807 Unreviewed, move Frédéric Wang to committers list
809 He seems to be on the contributors list by accident. He has been landing his own commits for
812 * Scripts/webkitpy/common/config/contributors.json:
814 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
816 Unreviewed, move Sebastian Dröge to committers list harder
818 He accidentally added himself to the reviewers list because the file is confusing. Then I
819 accidentially moved him to the contributors list because the file is confusing, even though
820 I knew the contributors list existed in this file and was attempting to add him to the
821 committers list. Really move him to the committers list now.
823 * Scripts/webkitpy/common/config/contributors.json:
825 2016-01-02 Youenn Fablet <youenn.fablet@crf.canon.fr>
827 Python SCM should be able to retrieve untracked files - Add SVN support
828 https://bugs.webkit.org/show_bug.cgi?id=152546
830 Reviewed by Michael Catanzaro.
832 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
833 (test_untracked_files): Activating test for SVN.
834 * Scripts/webkitpy/common/checkout/scm/svn.py:
835 (SVN.untracked_files): Implementing untracked files retrieval for SVN.
837 2015-12-31 Andy Estes <aestes@apple.com>
839 Replace WTF::move with WTFMove
840 https://bugs.webkit.org/show_bug.cgi?id=152601
842 Reviewed by Brady Eidson.
844 * DumpRenderTree/TestRunner.h:
845 (TestRunner::setAllowedHosts):
846 * DumpRenderTree/win/DRTDataObject.cpp:
847 (DRTDataObject::SetData):
848 * TestWebKitAPI/Tests/WTF/Deque.cpp:
849 (TestWebKitAPI::TEST):
850 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
851 (TestWebKitAPI::TEST):
852 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
853 (TestWebKitAPI::TEST):
854 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
855 (TestWebKitAPI::TEST):
856 * TestWebKitAPI/Tests/WTF/Ref.cpp:
857 (TestWebKitAPI::passWithRef):
858 (TestWebKitAPI::TEST):
859 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
860 (TestWebKitAPI::TEST):
861 * TestWebKitAPI/Tests/WTF/Vector.cpp:
862 (TestWebKitAPI::TEST):
863 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
864 (TestWebKitAPI::TEST):
865 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
866 (TestWebKitAPI::TEST):
867 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
868 (TestWebKitAPI::createTestValue):
869 (TestWebKitAPI::TEST):
870 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
871 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
872 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
873 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
874 (TestWebKitAPI::createNFAs):
875 (TestWebKitAPI::TEST_F):
876 * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
877 (TestWebKitAPI::combine):
878 * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
879 (TestWebKitAPI::createNFAs):
880 * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
882 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
883 (WebProcessTest::add):
885 2016-01-01 Michael Catanzaro <mcatanzaro@igalia.com>
887 [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
888 https://bugs.webkit.org/show_bug.cgi?id=152634
890 Reviewed by Carlos Garcia Campos.
892 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
893 (testLoadFromGResource): Added test.
895 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
896 (registerGResource): Added.
897 (webkit_web_extension_initialize_with_user_data): Load the test gresource.
898 * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
899 * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
901 2015-12-31 David Kilzer <ddkilzer@apple.com>
903 REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
904 <https://bugs.webkit.org/show_bug.cgi?id=152601>
906 Ignore unknown pragmas on older clangs. Fixes the following
909 Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
910 #pragma clang diagnostic ignored "-Wself-move"
914 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
915 (TestWebKitAPI::TEST):
916 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
917 (TestWebKitAPI::TEST):
919 2015-12-31 Andy Estes <aestes@apple.com>
921 Update the style checker to advise using WTFMove() instead of WTF::move()
922 https://bugs.webkit.org/show_bug.cgi?id=152601
924 Reviewed by Daniel Bates.
926 * Scripts/webkitpy/style/checkers/cpp.py:
928 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
929 (WebKitStyleTest.test_wtf_move):
931 2015-12-31 Andy Estes <aestes@apple.com>
933 Fix warnings uncovered by migrating to WTF_MOVE
934 https://bugs.webkit.org/show_bug.cgi?id=152601
936 Reviewed by Daniel Bates.
938 Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
939 self-move, even if doing so would trigger a warning.
941 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
942 (TestWebKitAPI::TEST):
943 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
944 (TestWebKitAPI::TEST):
946 2015-12-31 Martin Robinson <mrobinson@igalia.com>
948 [GTK] The install-dependencies script has a syntax error
949 https://bugs.webkit.org/show_bug.cgi?id=152613
951 Reviewed by Michael Catanzaro.
953 * gtk/install-dependencies: Add the missing 'then.'
955 2015-12-30 Philippe Normand <pnormand@igalia.com>
957 [Mac][GTK] Jhbuild support for OSX
958 https://bugs.webkit.org/show_bug.cgi?id=150799
960 Reviewed by Michael Catanzaro.
962 * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
963 * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
964 * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
965 * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
967 2015-12-28 Michael Catanzaro <mcatanzaro@igalia.com>
969 Unreviewed, move Sebastian Dröge to committers list
971 He accidentally added himself to the reviewers list because the file is confusing.
973 * Scripts/webkitpy/common/config/contributors.json:
975 2015-12-24 Simon Fraser <simon.fraser@apple.com>
977 Remove the unused #define _USE_MATH_DEFINES
978 https://bugs.webkit.org/show_bug.cgi?id=152034
980 Reviewed by Tim Horton.
982 Update this test to use piDouble from MathExtras.h, and
983 std::numeric_limits<>.
985 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
987 2015-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
989 Python SCM should be able to retrieve untracked files - Generic changes
990 https://bugs.webkit.org/show_bug.cgi?id=152536
992 Reviewed by Brent Fulgham.
994 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
995 No support is yet added to GIT and SVN specific implementations.
997 * Scripts/webkitpy/common/checkout/scm/scm.py:
998 (SCM.untracked_files):
999 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1000 (SCMTest._shared_test_untracked_files):
1002 2015-12-23 Dewei Zhu <dewei_zhu@apple.com>
1004 SVN checkout used by RunBenchmark should be non-interactive
1005 https://bugs.webkit.org/show_bug.cgi?id=152542
1007 Reviewed by Ryosuke Niwa.
1009 RunBenchmark should not require user interaction while running.
1011 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1012 (BenchmarkBuilder._checkout_with_subversion):
1014 2015-12-23 Brent Fulgham <bfulgham@apple.com>
1016 Web Inspector: add support for running protocol-test.js tests on Windows
1017 https://bugs.webkit.org/show_bug.cgi?id=148037
1018 <rdar://problem/22292237>
1020 Reviewed by Simon Fraser.
1022 * DumpRenderTree/win/TestRunnerWin.cpp:
1023 (TestRunner::inspectorTestStubURL): Provide implementation.
1025 2015-12-23 Eric Carlson <eric.carlson@apple.com>
1027 [MediaStream] MediaDeviceInfo.label must be empty in some situations
1028 https://bugs.webkit.org/show_bug.cgi?id=152000
1030 Reviewed by Brent Fulgham.
1032 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1033 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1034 (WTR::InjectedBundle::setUserMediaPermission):
1035 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1036 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1038 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1039 (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1040 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1042 * WebKitTestRunner/TestController.cpp:
1043 (WTR::TestController::setUserMediaPermissionForOrigin):
1044 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1045 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
1046 persistent permission for origin, that can be done from script now.
1047 * WebKitTestRunner/TestController.h:
1049 * WebKitTestRunner/TestInvocation.cpp:
1050 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1051 SetUserMediaPermissionForOrigin.
1053 2015-12-23 Brent Fulgham <bfulgham@apple.com>
1055 [Win] Unreviewed build fix: Recognize Windows 10 variants.
1057 * Scripts/webkitpy/common/system/platforminfo.py:
1058 (PlatformInfo._determine_win_version):
1060 2015-12-23 Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1062 Content blockers should be able to promote http to https
1063 https://bugs.webkit.org/show_bug.cgi?id=148966
1065 Reviewed by Benjamin Poulain.
1067 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1068 (WebCore::ContentExtensions::operator<<):
1069 (TestWebKitAPI::TEST_F):
1071 2015-12-22 Hunseop Jeong <hs85.jeong@samsung.com>
1073 [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1074 https://bugs.webkit.org/show_bug.cgi?id=152516
1076 Reviewed by Gyuyoung Kim.
1078 * MiniBrowser/efl/main.c:
1080 2015-12-22 Brent Fulgham <bfulgham@apple.com>
1082 Unreviewed: Add John Wilander as a contributor.
1084 * Scripts/webkitpy/common/config/contributors.json:
1086 2015-12-22 Chris Fleizach <cfleizach@apple.com>
1088 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1089 https://bugs.webkit.org/show_bug.cgi?id=152482
1091 Reviewed by Brent Fulgham.
1093 vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1094 for the same property. On WK2, the element returned will not be valid, but is still present and
1095 that can lead to looping.
1097 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1098 (AccessibilityUIElement::horizontalScrollbar):
1099 (AccessibilityUIElement::verticalScrollbar):
1100 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1101 (WTR::AccessibilityUIElement::horizontalScrollbar):
1102 (WTR::AccessibilityUIElement::verticalScrollbar):
1104 2015-12-22 Xabier Rodriguez Calvar <calvaris@igalia.com>
1108 * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1110 2015-12-21 Hunseop Jeong <hs85.jeong@samsung.com>
1112 [EFL] test_ewk2_context failed after r192808
1113 https://bugs.webkit.org/show_bug.cgi?id=151846
1115 Reviewed by Gyuyoung Kim.
1117 Used the added ewk_context_web_process_count_limit_set api
1118 instead of the deprecated ewk_context_process_model_set.
1120 * MiniBrowser/efl/main.c:
1123 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
1125 Unreviewed, move myself to reviewer list.
1127 * Scripts/webkitpy/common/config/contributors.json:
1129 2015-12-21 Aakash Jain <aakash_jain@apple.com>
1131 Unreviewed, add myself to the committers list.
1133 * Scripts/webkitpy/common/config/contributors.json:
1135 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
1137 [GTK] jquery.min.js violates DFSG
1138 https://bugs.webkit.org/show_bug.cgi?id=152428
1140 Reviewed by Joseph Pecoraro.
1142 Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1143 into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1145 * gtk/manifest.txt.in:
1147 2015-12-19 Dan Bernstein <mitz@apple.com>
1149 [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1150 https://bugs.webkit.org/show_bug.cgi?id=152462
1152 Reviewed by Alexey Proskuryakov.
1154 - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1157 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1158 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1159 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1160 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1161 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1163 - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1164 never getting compiled:
1166 * DumpRenderTree/mac/TextInputController.m:
1167 * MiniBrowser/mac/BrowserWindowController.m:
1168 * TestWebKitAPI/Tests/mac/AttributedString.mm:
1169 * WebKitTestRunner/mac/EventSenderProxy.mm:
1171 2015-12-18 Michael Catanzaro <mcatanzaro@igalia.com>
1173 Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1175 This is to make it easy to CC it on Bugzilla.
1177 * Scripts/webkitpy/common/config/contributors.json:
1179 2015-12-18 Aakash Jain <aakash_jain@apple.com>
1181 Pasteboard get messed up after running kill-old-processes
1182 https://bugs.webkit.org/show_bug.cgi?id=152426
1184 Reviewed by Alexey Proskuryakov.
1186 * BuildSlaveSupport/kill-old-processes:
1187 (main): Do not kill pasteboard anymore.
1189 2015-12-17 Aakash Jain <aakash_jain@apple.com>
1191 run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1192 https://bugs.webkit.org/show_bug.cgi?id=152157
1193 <rdar://problem/23851817>
1195 Reviewed by Alexey Proskuryakov.
1197 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1198 (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1199 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1200 (Manager._get_test_inputs): Common method to calculate test_inputs.
1201 (Manager._update_worker_count): Calculate and update required number of workers.
1203 2015-12-16 Aakash Jain <aakash_jain@apple.com>
1205 run-webkit-tests fails to delete Simulator device during cleanup
1206 https://bugs.webkit.org/show_bug.cgi?id=152363
1208 Reviewed by Alexey Proskuryakov.
1210 * Scripts/webkitpy/xcode/simulator.py:
1211 (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1213 2015-12-16 Tim Horton <timothy_horton@apple.com>
1215 [mac-wk2] fast/events force click tests crashing
1216 https://bugs.webkit.org/show_bug.cgi?id=152339
1218 Reviewed by Beth Dakin.
1220 * WebKitTestRunner/mac/EventSenderProxy.mm:
1221 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1222 Set the NSEvent's _type member in addition to overriding -type,
1223 because there are assertions in touch event handling code that depend on it.
1225 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1227 Enforce temporarily bots to sync WebKit and WPT testharness.js
1228 https://bugs.webkit.org/show_bug.cgi?id=152334
1230 Reviewed by Darin Adler.
1232 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1233 (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1235 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1237 [Fetch API] Add fetch API compile time flag
1238 https://bugs.webkit.org/show_bug.cgi?id=152254
1240 Reviewed by Darin Adler.
1242 * Scripts/webkitperl/FeatureList.pm:
1244 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1248 Added files that have impact in building Streams API to the watchlist.
1250 * Scripts/webkitpy/common/config/watchlist:
1252 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1256 Added imported tests to Streams API watchlist.
1258 * Scripts/webkitpy/common/config/watchlist:
1260 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1262 Remove default copy of wpt testharness.js when launching wpt server
1263 https://bugs.webkit.org/show_bug.cgi?id=152298
1265 Reviewed by Darin Adler.
1267 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1268 (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1270 2015-12-15 David Kilzer <ddkilzer@apple.com>
1272 REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1273 <http://webkit.org/b/152314>
1275 Reviewed by Daniel Bates.
1277 The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1278 code path to exit immediately when calling main().
1279 Unfortunately, DumpRenderTreeMain.mm was used for both
1280 DumpRenderTree command-line binary and DumpRenderTree.app, which
1281 meant that the app would exit immediately with no error code
1284 The workaround is to introduce a separate source file called
1285 DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1288 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1289 DumpRenderTreeAppMain.mm to the project. Make it the only
1290 compiled source for the DumpRenderTree.app target.
1291 * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1292 (main): Call DumpRenderTreeMain() on iOS. Assert on OS X in
1293 case someone tries mistakenly to use the app.
1294 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1295 Link to JavaScriptCore.framework on iOS for the assert.
1296 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1297 Link to JavaScriptCore.framework on OS X for the assert. Remove
1298 unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1299 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1300 (main): Add assert for iOS so that a crash occurs if someone
1301 tries to run the wrong command.
1303 2015-12-14 Tim Horton <timothy_horton@apple.com>
1305 Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1306 https://bugs.webkit.org/show_bug.cgi?id=152266
1307 <rdar://problem/22092676>
1309 Reviewed by Simon Fraser.
1311 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1312 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1313 Add a test that crashed before this change, and doesn't crash after.
1315 2015-12-14 Chris Fleizach <cfleizach@apple.com>
1317 AX: iOS: Text field variations do not have the correct traits
1318 https://bugs.webkit.org/show_bug.cgi?id=152237
1320 Reviewed by Mario Sanchez Prada.
1322 Add iOS calls for determing if an object is a search field or a text area.
1324 * DumpRenderTree/AccessibilityUIElement.cpp:
1325 (getIsSearchFieldCallback):
1326 (getIsTextAreaCallback):
1327 (stringForSelectionCallback):
1328 (AccessibilityUIElement::getJSClass):
1329 * DumpRenderTree/AccessibilityUIElement.h:
1330 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1331 (AccessibilityUIElement::identifier):
1332 (AccessibilityUIElement::isTextArea):
1333 (AccessibilityUIElement::isSearchField):
1334 (AccessibilityUIElement::traits):
1335 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1336 (WTR::AccessibilityUIElement::scrollPageRight):
1337 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1338 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1339 (WTR::AccessibilityUIElement::isSearchField):
1340 (WTR::AccessibilityUIElement::isTextArea):
1341 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1342 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1343 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1344 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1345 (WTR::AccessibilityUIElement::isTextArea):
1346 (WTR::AccessibilityUIElement::isSearchField):
1347 (WTR::AccessibilityUIElement::rowCount):
1349 2015-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
1351 [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1352 https://bugs.webkit.org/show_bug.cgi?id=152252
1354 Reviewed by Sergio Villar Senin.
1356 * gtk/install-dependencies: Add libtool-bin to the list of packages required
1357 for building the JHBuild on Debian systems.
1359 2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
1361 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1362 https://bugs.webkit.org/show_bug.cgi?id=152156
1364 Reviewed by Dan Bernstein.
1366 Our frameworks should appropriately prefix all ObjC classes,
1367 not just external symbols.
1369 * Scripts/check-for-inappropriate-objc-class-names:
1370 Remove the -g switch to check all ObjC class names.
1372 2015-12-10 Eric Carlson <eric.carlson@apple.com>
1374 [MediaStream] Expose media capture devices persistent permissions to WebCore
1375 https://bugs.webkit.org/show_bug.cgi?id=152087
1377 Add support for the new user media permission checker page UI client method.
1379 Reviewed by Chris Dumez.
1381 * WebKitTestRunner/TestController.cpp:
1382 (WTR::decidePolicyForUserMediaPermissionRequest):
1383 (WTR::checkUserMediaPermissionForOrigin):
1384 (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1385 (WTR::TestController::createWebViewWithOptions): Ditto.
1386 (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1387 (WTR::originUserVisibleName): New, create a string for the origin.
1388 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1389 according to the state of the origin permission map.
1390 (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1391 request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1392 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1393 origin permission map.
1394 * WebKitTestRunner/TestController.h:
1396 2015-12-10 Alex Christensen <achristensen@webkit.org>
1398 REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1399 https://bugs.webkit.org/show_bug.cgi?id=152022
1400 rdar://problem/23763584
1402 Reviewed by Darin Adler.
1404 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1405 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1406 (WTR::InjectedBundlePage::willSendRequestForFrame):
1407 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1408 (WTR::TestRunner::setWillSendRequestReturnsNull):
1409 (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1410 (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1411 (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1412 (WTR::TestRunner::willSendRequestHTTPBody):
1413 Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1415 2015-12-10 Aakash Jain <aakash_jain@apple.com>
1417 Remove additional simulator checks before running layout-tests
1418 https://bugs.webkit.org/show_bug.cgi?id=152146
1420 Reviewed by Darin Adler.
1422 * Scripts/webkitpy/port/ios.py:
1423 (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1424 * Scripts/webkitpy/xcode/simulator.py:
1425 (Simulator._boot_and_shutdown_simulator_device): Deleted.
1426 (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1428 2015-12-09 Aakash Jain <aakash_jain@apple.com>
1430 Run atleast one simulator even if max process limit is low
1431 https://bugs.webkit.org/show_bug.cgi?id=152081
1432 <rdar://problem/23819694>
1434 Reviewed by Alexey Proskuryakov.
1436 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
1438 [GTK] Crash in WebProcess when loading large content with custom URI schemes
1439 https://bugs.webkit.org/show_bug.cgi?id=144262
1441 Reviewed by Carlos Garcia Campos.
1443 Added new unit test to check the additional scenarios we now
1444 handle for custom URI schemes.
1446 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1447 (generateHTMLContent): New helper function to generate big enough content.
1448 (testWebContextURIScheme): New unit test.
1450 2015-12-09 Ryuan Choi <ryuan.choi@navercorp.com>
1452 [EFL] Fix unhandled web process message when launching MiniBrowser
1453 https://bugs.webkit.org/show_bug.cgi?id=152048
1455 Reviewed by Gyuyoung Kim.
1457 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1458 (TestWebKitAPI::TEST):
1460 2015-12-09 Carlos Garcia Campos <cgarcia@igalia.com>
1462 [GTK] Add API to handle beforeunload events
1463 https://bugs.webkit.org/show_bug.cgi?id=139090
1465 Reviewed by Gustavo Noronha Silva.
1467 * MiniBrowser/gtk/BrowserWindow.c:
1468 (browserWindowConstructed):
1469 (browserWindowDeleteEvent):
1470 (browser_window_class_init):
1471 Handle delete-event to prevent the window from being closed when
1472 the page has beforeunload handlers. Use
1473 webkit_web_view_try_close() when the window is requested to be
1475 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1476 (testWebViewJavaScriptDialogs):
1477 Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1480 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
1482 Refactored initialization code in LoadTrackingTest.
1484 Rubber-stamped by Carlos Garcia Campos.
1486 Small refactoring to make sure that the state of a LoadTrackingTest
1487 gets properly reset before loading new web content.
1489 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1490 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1491 (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1492 functions and reset the remaining local variables.
1493 (LoadTrackingTest::loadURI): Call reset();
1494 (LoadTrackingTest::loadHtml): Ditto.
1495 (LoadTrackingTest::loadPlainText): Ditto.
1496 (LoadTrackingTest::loadBytes): Ditto.
1497 (LoadTrackingTest::loadRequest): Ditto.
1498 (LoadTrackingTest::reload): Ditto.
1499 (LoadTrackingTest::goBack): Ditto.
1500 (LoadTrackingTest::goForward): Ditto.
1502 2015-12-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1504 [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1505 https://bugs.webkit.org/show_bug.cgi?id=151942
1507 Reviewed by Darin Adler.
1509 * MiniBrowser/efl/main.c:
1510 (window_create): Enable offline web application cache feature on MiniBrowser.
1513 2015-12-08 Aakash Jain <aakash_jain@apple.com>
1515 https://bugs.webkit.org/show_bug.cgi?id=151243
1516 <rdar://problem/22955197>
1518 Reviewed by Alexey Proskuryakov.
1520 * LayoutTestRelay/LayoutTestRelay/main.m:
1521 (getTestingSimDevice): Use separate testing device for each worker.
1522 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1523 (Manager.run): Perform cleanup even if setup fails.
1524 * Scripts/webkitpy/port/ios.py:
1525 (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1526 (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1527 (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1528 (IOSSimulatorPort._quit_ios_simulator): Same
1529 (IOSSimulatorPort.clean_up_test_run): Same
1530 (IOSSimulatorPort.check_sys_deps): Same
1531 (IOSSimulatorPort.testing_device): Same
1532 (IOSSimulatorPort.reset_preferences): Same
1533 (IOSSimulatorPort.get_simulator_path): Return simulator path.
1534 (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1535 * Scripts/webkitpy/xcode/simulator.py:
1536 (Device.delete): Delete the simulator device.
1537 (Simulator.delete_device): Same
1538 (Simulator.wait_until_device_is_booted): Wait for device booting.
1540 2015-12-08 Ryuan Choi <ryuan.choi@navercorp.com>
1542 [EFL] Add API to provide preferences before creating ewk_view
1543 https://bugs.webkit.org/show_bug.cgi?id=151587
1545 Reviewed by Gyuyoung Kim.
1547 * MiniBrowser/efl/main.c:
1551 Moved settings related code to configuration() not to update settings
1552 whenever ewk_view is created.
1556 2015-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
1558 Unreviewed. Fix GTK+ API tests after r193639.
1560 The new jhbuild version needs some more variables ot be present in
1561 the builtin dict, even if they are set to None.
1563 * jhbuild/jhbuildutils.py:
1564 (enter_jhbuild_environment_if_available):
1566 2015-12-07 Gustavo Noronha Silva <gns@gnome.org>
1568 [GTK] Notify WebCore when notification is clicked
1569 https://bugs.webkit.org/show_bug.cgi?id=151951
1571 Reviewed by Carlos Garcia Campos.
1573 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1574 (testWebViewNotification): test the new API.
1576 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
1578 'jhbuild build' should fail immediately when building any module fails
1579 https://bugs.webkit.org/show_bug.cgi?id=145697
1581 Reviewed by Carlos Garcia Campos.
1583 * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1584 * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1585 Everything is placed under lib instead of lib64 now.
1586 * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1587 --exit-on-error when running 'jhbuild build'.
1588 * jhbuild/jhbuildrc_common.py:
1589 (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1590 jhbuild should be able to handle these for us without breaking things....
1592 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
1594 Add support to import w3c tests from a repository with a different root that the main repo dir
1595 https://bugs.webkit.org/show_bug.cgi?id=151751
1597 Reviewed by Ryosuke Niwa and Youenn Fablet.
1599 We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1600 in a different directory than the repository root.
1602 This patch introduces a new parameter tests_directory that we will use as root directory to search for
1603 tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1604 requires having the copy_path lists including tuples of origin and destination directories.
1606 * Scripts/webkitpy/w3c/test_downloader.py:
1607 (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1608 (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1609 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1610 (TestImporterTest.test_tests_directory): Test.
1612 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
1614 Mock TestRepositories in W3C importer tests
1615 https://bugs.webkit.org/show_bug.cgi?id=151938
1617 Reviewed by Youenn Fablet.
1619 The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1620 is because the test repository method reading the file was using the filesystem directly instead of taking the
1621 host one. This patch changes that.
1623 * Scripts/webkitpy/w3c/test_downloader.py:
1624 (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1626 (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1627 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1628 (TestImporterTest.test_harnesslinks_conversion):
1629 (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1631 2015-12-07 David Kilzer <ddkilzer@apple.com>
1633 TestNetscapePlugIn: Address review comment on 193607
1634 <http://webkit.org/b/151881>
1636 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1637 (testSetStatus): Initializing std::unique_ptr<char[]> with
1638 nullptr is redundant.
1640 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
1642 [GTK] Add webkit_uri_request_get_http_method
1643 https://bugs.webkit.org/show_bug.cgi?id=151601
1645 Reviewed by Martin Robinson.
1647 Add test case to check HTTP method of WebKitURIRequest.
1649 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1650 (testURIRequestHTTPMethod):
1653 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1654 (sendRequestCallback):
1656 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
1658 [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1659 https://bugs.webkit.org/show_bug.cgi?id=79918
1661 Reviewed by Gustavo Noronha Silva.
1663 Add unit tests to check the different console messages.
1665 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1666 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1667 (ConsoleMessageTest::ConsoleMessage::operator==):
1668 (ConsoleMessageTest::consoleMessageReceivedCallback):
1669 (ConsoleMessageTest::ConsoleMessageTest):
1670 (ConsoleMessageTest::~ConsoleMessageTest):
1671 (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1672 (testWebKitConsoleMessageConsoleAPI):
1673 (testWebKitConsoleMessageJavaScriptException):
1674 (testWebKitConsoleMessageNetworkError):
1675 (testWebKitConsoleMessageSecurityError):
1678 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1679 (consoleMessageSentCallback):
1680 (pageCreatedCallback):
1682 2015-12-07 Ryuan Choi <ryuan.choi@navercorp.com>
1684 [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1685 https://bugs.webkit.org/show_bug.cgi?id=151934
1687 Reviewed by Csaba Osztrogonác.
1689 * MiniBrowser/efl/main.c:
1690 (on_window_deletion): Revert the changes of r192767.
1692 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
1694 [GTK] update-webkitgtk-libs cannot build mesa
1695 https://bugs.webkit.org/show_bug.cgi?id=151535
1697 Reviewed by Martin Robinson.
1699 Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1700 dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1701 on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1702 does not have a stable API and we cannot expect mesa to be buildable unless we control the
1703 LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1704 --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1706 * gtk/jhbuild.modules:
1708 2015-12-07 Philippe Normand <pnormand@igalia.com>
1710 [GTK][Mac] libWebExtensionTest link error
1711 https://bugs.webkit.org/show_bug.cgi?id=150802
1713 Reviewed by Carlos Garcia Campos.
1715 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1717 2015-12-06 David Kilzer <ddkilzer@apple.com>
1719 TestNetscapePlugIn: Fix leaks found by static analyzer
1720 <http://webkit.org/b/151881>
1722 Reviewed by Darin Adler.
1724 Fixes the following leaks found by the static analyzer:
1725 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1728 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1731 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1735 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1736 (toCString): Switch to returning std::unique_ptr<char[]>. Add
1737 early return if allocation fails.
1738 (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1739 Make sure to call fclose() on filehandle, even for an early
1741 (testSetStatus): Switch to using std::unique_ptr<char[]>.
1743 2015-12-05 David Kilzer <ddkilzer@apple.com>
1745 prepare-ChangeLog: Fix some warning messages when using svn
1746 <http://webkit.org/b/151914>
1748 Reviewed by Daniel Bates.
1750 * Scripts/prepare-ChangeLog:
1751 (generateFunctionLists): Simplify logic so that we never call
1752 normalizePath() with an undefined value.
1753 (attributeCommand): Quote $subPath for the shell so that we
1754 don't try to run "svn propget" on invalid paths.
1756 2015-12-04 David Kilzer <ddkilzer@apple.com>
1758 TestNetscapePlugIn: Fix remaining static analyzer warnings
1759 <http://webkit.org/b/151888>
1761 Reviewed by Alexey Proskuryakov.
1763 Fixes the following static analyzer warnings:
1764 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1767 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1768 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1770 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1771 return obj->pluginTest->NPP_SetWindow(window);
1773 2 warnings generated.
1775 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1776 (CRASH): Use __builtin_trap() for gcc/clang.
1777 (NPP_SetWindow): Add early return if obj is nullptr.
1779 2015-12-03 Carlos Garcia Campos <cgarcia@igalia.com>
1781 [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1782 https://bugs.webkit.org/show_bug.cgi?id=151797
1784 Reviewed by Martin Robinson.
1786 Since we switched to use the network process to run the unit tests
1787 the test /webkit2/WebKitWebResource/get-data sometimes fails and
1788 sometimes passes. We are now also getting the notification for the
1789 css image. Since we wait for 3 resources, sometimes the css image
1790 is loaded before and then checkResourceData is called for it, but
1791 not handled. When the css image is the last one loaded the test
1792 passes. So, we just need to wait for the 4 resources.
1794 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1795 (testWebResourceGetData):
1797 2015-12-03 David Kilzer <ddkilzer@apple.com>
1799 DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1800 <http://webkit.org/b/151845>
1802 Reviewed by Simon Fraser.
1804 Fixes the following static analyzer warning:
1805 DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1806 WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1807 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1809 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1810 (createBitmapContext): Free 'buffer' after using it in logging
1811 to fix the use-after-free. Assign a value of nullptr to buffer
1812 so we don't return with it set to a freed address.
1814 2015-12-03 Jer Noble <jer.noble@apple.com>
1816 Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1817 https://bugs.webkit.org/show_bug.cgi?id=151830
1819 Reviewed by Anders Carlsson.
1821 Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1823 * DumpRenderTree/mac/DumpRenderTree.mm:
1824 (resetWebPreferencesToConsistentValues):
1825 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1826 (WTR::initializeWebViewConfiguration):
1828 2015-12-03 Anders Carlsson <andersca@apple.com>
1830 Remove Objective-C GC support
1831 https://bugs.webkit.org/show_bug.cgi?id=151819
1832 rdar://problem/23746991
1834 Reviewed by Dan Bernstein.
1836 * asan/asan.xcconfig:
1838 2015-12-02 Yusuke Suzuki <utatane.tea@gmail.com>
1840 Allow nil for unspecified benchmark pathes
1841 https://bugs.webkit.org/show_bug.cgi?id=151784
1843 Reviewed by Filip Pizlo.
1845 `Pathname.new(nil)` will raise an error.
1846 Only generate Pathname if the benchmark path is specified.
1848 * Scripts/run-jsc-benchmarks:
1850 2015-12-02 Brent Fulgham <bfulgham@apple.com>
1852 [Win] Run non-http tests without Cygwin
1853 https://bugs.webkit.org/show_bug.cgi?id=151721
1855 Reviewed by Andy Estes.
1857 Support native 32-bit and 64-bit Python (and Perl) builds
1860 1. Use "startswith('win')", rather than "== 'win32'" to support
1861 various Windows build types.
1862 2. Supply full path for some native Windows utilities, since the
1863 path environment does not always have the specified, and they are
1864 guaranteed to exist in those specific locations.
1865 3. Make sure native Windows Python test runs pass proper environment
1866 variables to run programs.
1867 4. Append 'exe' suffix when running Windows executables.
1868 5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1869 command doesn't exist.
1871 * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1872 the current Perl executable, rather than requiring a new path search.
1873 * Scripts/webkitpy/common/find_files_unittest.py:
1874 (TestWinNormalize.test_win): Use startswith('win').
1875 * Scripts/webkitpy/common/prettypatch_unittest.py:
1876 (test_pretty_diff_encodings): Ditto.
1877 * Scripts/webkitpy/common/system/executive.py:
1878 (Executive._should_close_fds): Ditto.
1879 (Executive.shell_command_for_script): Use startswith('win').
1880 (Executive.kill_process): Use full path to killall executable.
1881 (Executive.check_running_pid): Use startswith('win').
1882 (Executive.running_pids): Ditto.
1883 (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1884 running under native Windows Python.
1885 (Executive._child_process_encoding): Use startswith('win').
1886 (Executive._should_encode_child_process_arguments): Ditto.
1887 (Executive.popen): Recognize proper script engine on Windows, since it
1888 does not support the shebang syntax.
1889 (Executive.run_in_parallel): Use startswith('win').
1890 * Scripts/webkitpy/common/system/executive_unittest.py:
1891 (never_ending_command): Ditto.
1892 (ExecutiveTest.test_run_command_with_unicode): Ditto.
1893 (ExecutiveTest.serial_test_kill_process): Ditto.
1894 (ExecutiveTest.serial_test_kill_all): Ditto.
1895 (ExecutiveTest.serial_test_check_running_pid): Ditto.
1896 (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1898 * Scripts/webkitpy/common/system/file_lock.py:
1899 (FileLock._create_lock): Ditto.
1900 (FileLock._remove_lock): Ditto.
1901 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1902 (RealFileSystemTest.test_chdir): Ditto.
1903 (RealFileSystemTest.test_chdir__notexists): Ditto.
1904 (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1905 * Scripts/webkitpy/common/system/path_unittest.py:
1906 (AbspathTest.test_abspath_to_uri_win): Ditto.
1907 * Scripts/webkitpy/common/system/platforminfo.py:
1908 (PlatformInfo._determine_os_name): Ditto.
1909 * Scripts/webkitpy/common/system/user.py: Ditto.
1910 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1911 (ManagerTest.integration_test_needs_servers): Ditto.
1912 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1913 (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1915 (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1916 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1917 (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1918 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1919 (HttpServerBase._check_that_all_ports_are_available): Ditto.
1920 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1921 (TestHttpServer.test_start_cmd): Ditto.
1922 * Scripts/webkitpy/port/base.py:
1923 (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1924 and 'SYSTEMROOT' in environment passed to test runners.
1925 (Port._apache_config_file_name_for_platform): Use startswith('win').
1926 (Port._build_path): Ditto.
1927 (Port._path_to_driver): Include 'exe' suffix when running under native
1929 * Scripts/webkitpy/port/driver.py:
1930 (Driver._setup_environ_for_driver): Explicitly make some environment
1932 * Scripts/webkitpy/port/server_process.py:
1933 (ServerProcess.__init__): Use startswith('win').
1934 * Scripts/webkitpy/port/win.py:
1935 (WinPort): Use the win32 registry utilities on Windows, and appropriate
1936 registry key formats.
1937 (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1938 (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1939 and regtool on Cygwin.
1940 (WinPort.write_registry_value): Ditto.
1941 (WinPort.setup_crash_log_saving): Ditto.
1942 (WinPort.restore_crash_log_saving): Ditto.
1943 (WinPort.prevent_error_dialogs): Ditto.
1944 (WinPort.allow_error_dialogs): Ditto.
1945 (WinPort.find_system_pid): Revise to use Windows management
1946 infrastructure on native Windows, continue using 'ps' on Cygwin.
1947 (WinPort.read_registry_string): Deleted.
1948 (WinPort.write_registry_string): Deleted.
1949 * Scripts/webkitpy/test/main.py:
1950 (main): Use startswith('win').
1951 (Tester._parse_args): Ditto.
1953 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
1955 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1956 https://bugs.webkit.org/show_bug.cgi?id=150792
1958 Reviewed by Saam Barati.
1960 * Scripts/webkitperl/FeatureList.pm:
1962 2015-12-01 Commit Queue <commit-queue@webkit.org>
1964 Unreviewed, rolling out r192914.
1965 https://bugs.webkit.org/show_bug.cgi?id=151734
1967 JSC tests for this change are failing on 32 and 64-bit bots
1968 (Requested by ryanhaddad on #webkit).
1972 "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1973 enable this feature"
1974 https://bugs.webkit.org/show_bug.cgi?id=150792
1975 http://trac.webkit.org/changeset/192914
1977 2015-12-01 David Kilzer <ddkilzer@apple.com>
1979 EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1980 <http://webkit.org/b/151726>
1982 Reviewed by Simon Fraser.
1984 * WebKitTestRunner/mac/EventSenderProxy.mm:
1985 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1986 Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1988 2015-12-01 Myles C. Maxfield <mmaxfield@apple.com>
1990 Give String and AtomicString an existingHash() function
1991 https://bugs.webkit.org/show_bug.cgi?id=151717
1993 Reviewed by Andreas Kling.
1995 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1996 (TestWebKitAPI::TEST):
1997 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1998 (TestWebKitAPI::TEST):
2000 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
2002 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2003 https://bugs.webkit.org/show_bug.cgi?id=150792
2005 Reviewed by Saam Barati.
2007 * Scripts/webkitperl/FeatureList.pm:
2009 2015-12-01 Sam Weinig <sam@webkit.org>
2011 Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2012 <rdar://problem/23320863>
2013 https://bugs.webkit.org/show_bug.cgi?id=151708
2015 Reviewed by Anders Carlsson.
2017 * WebKitTestRunner/TestController.cpp:
2018 (WTR::TestController::createOtherPage):
2019 (WTR::TestController::createWebViewWithOptions):
2020 Update for new WKPageUIClient.
2022 2015-12-01 Anders Carlsson <andersca@apple.com>
2024 Remove WebKit2.framework
2025 https://bugs.webkit.org/show_bug.cgi?id=151715
2027 Reviewed by Dan Bernstein.
2029 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2030 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2031 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2032 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2033 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2034 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2035 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2037 2015-12-01 Joseph Pecoraro <pecoraro@apple.com>
2039 Unreviewed common typo fix "occurance" => "occurrence".
2041 * Scripts/webkitpy/tool/commands/queries.py:
2042 (FindFlakyTests._print_statistics):
2044 2015-11-30 Alex Christensen <achristensen@webkit.org>
2046 Make ProcessModel always MultipleSecondaryProcesses
2047 https://bugs.webkit.org/show_bug.cgi?id=151662
2049 Reviewed by Antti Koivisto.
2051 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2052 (TestWebKitAPI::TEST):
2053 * WebKitTestRunner/TestController.cpp:
2054 (WTR::TestController::generatePageConfiguration):
2056 2015-11-30 Alex Christensen <achristensen@webkit.org>
2058 Make usesNetworkProcess always true
2059 https://bugs.webkit.org/show_bug.cgi?id=151580
2061 Reviewed by Darin Adler.
2063 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2064 (TestWebKitAPI::TEST):
2065 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2066 (TestWebKitAPI::TEST):
2067 * WebKitTestRunner/TestController.cpp:
2068 (WTR::TestController::generatePageConfiguration):
2070 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2072 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2074 Add a way to skip unit tests only for Debug or Release builds and
2075 skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2077 * Scripts/run-gtk-tests:
2079 (SkippedTest.__init__):
2080 (SkippedTest.__str__):
2081 (SkippedTest.skip_entire_suite):
2082 (SkippedTest.skip_for_build_type):
2084 (TestRunner.__init__):
2086 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2088 Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2090 It's an assert hit because we are reloading a view loaded with
2091 HTML data which is not supported. Use loadURI instead.
2093 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2094 (testWebViewCustomCharset):
2096 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2098 [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2099 https://bugs.webkit.org/show_bug.cgi?id=151633
2101 Reviewed by Csaba Osztrogonác.
2103 * TestWebKitAPI/PlatformGTK.cmake:
2104 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2106 2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com>
2108 [GTK] Remove the remaining uses of GMainLoopSource
2109 https://bugs.webkit.org/show_bug.cgi?id=151632
2111 Reviewed by Žan Doberšek.
2113 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2114 (testWebViewSyncRequestOnMaxConns):
2115 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2116 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2117 (WTR::TestRunner::TestRunner):
2118 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2119 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2120 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2121 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2122 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2123 (WTR::timeoutSource):
2124 (WTR::TestController::notifyDone):
2125 (WTR::TestController::platformRunUntil):
2127 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
2129 [cmake] Add testb3 to the build system
2130 https://bugs.webkit.org/show_bug.cgi?id=151619
2132 Reviewed by Gyuyoung Kim.
2134 * Scripts/build-jsc:
2136 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
2138 [jhbuild] Fix pixman build with clang
2139 https://bugs.webkit.org/show_bug.cgi?id=151441
2141 Reviewed by Carlos Garcia Campos.
2143 * efl/jhbuild.modules:
2144 * gtk/jhbuild.modules:
2146 2015-11-26 David Kilzer <ddkilzer@apple.com>
2148 Extract prependToEnvironmentVariableList
2149 <http://webkit.org/b/151536>
2151 Reviewed by Daniel Bates.
2153 Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2154 webkitdirs_unittest/prependToEnvironmentVariableList.pl
2156 * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2157 and prependToEnvironmentVariableList.
2158 (appendToEnvironmentVariableList): Simplify variable name.
2159 Switch to use $Config{path_sep}.
2160 (prependToEnvironmentVariableList): Add new method.
2161 (setupMacWebKitEnvironment): Switch to use
2162 prependToEnvironmentVariableList().
2163 (setupIOSWebKitEnvironment): Ditto.
2165 * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2166 * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2168 2015-11-24 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2170 REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2171 https://bugs.webkit.org/show_bug.cgi?id=151567
2173 Reviewed by Darin Adler.
2175 * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2176 (on_window_deletion):
2178 2015-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
2180 [GTK] Use the network process unconditionally
2181 https://bugs.webkit.org/show_bug.cgi?id=151541
2183 Reviewed by Alex Christensen.
2185 Fix TestInspectorServer test. Do not assume we already have the
2186 title we want when the page has been loaded, since the title is
2187 changed afterwards. So, check if the title has already been set,
2188 and if not wait for it.
2190 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2191 (openRemoteDebuggingSession):
2193 2015-11-23 Alex Christensen <achristensen@webkit.org>
2195 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2196 https://bugs.webkit.org/show_bug.cgi?id=151532
2198 Reviewed by Benjamin Poulain.
2200 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2201 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2202 (TestWebKitAPI::TEST):
2203 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2204 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2205 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2206 Properly load about:blank in all WebViews to clean up. Without this change, we had a
2207 Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2208 so it was calling a function on a test object that had gone out of scope.
2209 Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2210 but that will become the default soon and that call will be removed.
2212 2015-11-22 David Kilzer <ddkilzer@apple.com>
2214 run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2215 <http://webkit.org/b/151542>
2217 Reviewed by Daniel Bates.
2219 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2220 (base_url): Use the Port object (already passed in) to give us
2221 the path to the LayoutTests directory, which already checks for a
2222 --layout-tests-directory command-line switch.
2223 (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2224 argument since we can get this from the Port object already
2225 passed in via Port.results_directory(). Also switch to use
2226 Port.layout_tests_dir() to get the LayoutTests directory.
2228 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2229 (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2230 Add test case for custom LayoutTests directory.
2231 (TestWebPlatformTestServer.test_previously_spawned_instance):
2232 Update Port object to set mock results directory as if it was
2233 set on the command-line. Remove unneeded argument from
2234 WebPlatformTestServer constructor.
2235 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2237 * Scripts/webkitpy/port/base.py:
2238 (Port.to.start_web_platform_test_server): Remove unneeded
2239 argument from WebPlatformTestServer constuctor.
2241 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2243 [GTK] Some unit tests fail when using the network process
2244 https://bugs.webkit.org/show_bug.cgi?id=151490
2246 Reviewed by Martin Robinson.
2248 Run the soup server in a separate thread in TestResources test to
2251 This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2252 /webkit2/WebKitWebResource/get-data when using the network process.
2254 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2255 (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2256 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2257 (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2258 present, create a WorkQueue to run the server.
2259 (WebKitTestServer::run): Run the server in the work queue if it
2261 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2262 type into server options as flags.
2264 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2266 [GTK] ImageDiff should normalize the diff image
2267 https://bugs.webkit.org/show_bug.cgi?id=151261
2269 Reviewed by Sergio Villar Senin.
2271 * ImageDiff/gtk/ImageDiff.cpp:
2272 (readPixbufFromStdin): Fix memory leak.
2273 (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2274 (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2276 == Rolled over to ChangeLog-2015-11-21 ==