[GTK] Add accelerated 2D canvas support using cairo-gl
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
2
3         [GTK] Add accelerated 2D canvas support using cairo-gl
4         https://bugs.webkit.org/show_bug.cgi?id=104672
5
6         Reviewed by Alejandro G. Castro.
7
8         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
9         dependencies, don't override value of the setting determined by configure.
10         This will make it easier for people using build-webkit, but not the
11         WebKit JHBuild.
12
13         * Scripts/webkitdirs.pm:
14         (buildAutotoolsProject): Add a blacklist for settings to never override.
15         * gtk/jhbuild.modules: Build CairoGL.
16
17 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
18
19         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
20         https://bugs.webkit.org/show_bug.cgi?id=114477
21
22         Reviewed by Benjamin Poulain.
23
24         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
25
26 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
27
28         Leaks builder should not be triggered upon new commits
29         https://bugs.webkit.org/show_bug.cgi?id=114475
30
31         Reviewed by Jessie Berlin.
32
33         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
34         the leak builder when builds are done.
35
36         * BuildSlaveSupport/build.webkit.org-config/config.json:
37
38 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
39
40         [GTK] Windows build failure after r136056
41         https://bugs.webkit.org/show_bug.cgi?id=114121
42
43         Reviewed by Martin Robinson.
44
45         * TestWebKitAPI/config.h: Make sure defines are correct for other
46         Windows ports than apple-win.
47
48 2013-04-11  Ojan Vafai  <ojan@chromium.org>
49
50         Remove myself from watchlists.
51         * Scripts/webkitpy/common/config/watchlist:
52
53 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
54
55         Build fix. Don't hard-code queues.webkit.org at least during the transition.
56
57         * QueueStatusServer/templates/statusbubble.html:
58
59 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
60
61         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
62         https://bugs.webkit.org/show_bug.cgi?id=114397
63
64         Reviewed by Benjamin Poulain.
65
66         Reland the patch since Alan appears to have finished the migration.
67
68         * Scripts/webkitpy/common/net/statusserver.py:
69         (StatusServer):
70
71 2013-04-11  Brian Holt  <brian.holt@samsung.com>
72
73         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
74         https://bugs.webkit.org/show_bug.cgi?id=76796
75
76         Reviewed by Chris Fleizach.
77
78         Make the Gtk window for the DRT a toplevel so that it gets the
79         focus from the window manager when the test starts.
80
81         * DumpRenderTree/gtk/DumpRenderTree.cpp:
82         (main):
83
84 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
85
86         Use CSS4 image-rendering to determing image scaling quality
87         https://bugs.webkit.org/show_bug.cgi?id=113405
88
89         Reviewed by Simon Fraser.
90
91         Introduce new flag to enable experimental support for CSS4 Images.
92
93         * Scripts/webkitperl/FeatureList.pm:
94
95 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
96
97         Remove code for Chromium from wkbuild.py
98         https://bugs.webkit.org/show_bug.cgi?id=114423
99
100         Reviewed by Benjamin Poulain.
101
102         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
103         (_should_file_trigger_build):
104         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
105         (ShouldBuildTest):
106
107 2013-04-11  Philippe Normand  <pnormand@igalia.com>
108
109         Unreviewed, update my IRC nickname.
110
111         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
112
113 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
114
115         Remove the rest of Chromium code from webkitpy
116         https://bugs.webkit.org/show_bug.cgi?id=114420
117
118         Reviewed by Benjamin Poulain.
119
120         * Scripts/webkitpy/common/config/urls.py:
121         (view_revision_url):
122         * Scripts/webkitpy/common/host.py:
123         (Host._engage_awesome_locale_hacks):
124         (Host.initialize_scm):
125         (Host):
126         * Scripts/webkitpy/common/host_mock.py:
127         (MockHost.__init__):
128         (MockHost.checkout):
129         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
130         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
131         (JSONResultsGeneratorBase._insert_generic_metadata):
132         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
133         (TestExpectationParser._tokenize_line):
134         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
135         (ExpectationSyntaxTests.test_bare_name_and_bugs):
136         (ExpectationSyntaxTests.test_warnings):
137         * Scripts/webkitpy/layout_tests/port/base.py:
138         (Port.skips_perf_test):
139         (Port.path_to_test_expectations_file):
140         (Port._port_flag_for_scripts):
141         * Scripts/webkitpy/style/checkers/cpp.py:
142         (check_function_definition):
143         (check_include_line):
144         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
145         (OrderOfIncludesTest.test_check_wtf_includes):
146         (WebKitStyleTest.test_webkit_export_check):
147         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
148         (TestExpectationsTestCase.test_valid_expectations):
149         * Scripts/webkitpy/tool/bot/irc_command.py:
150         (Rollout.execute):
151         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
152         (IRCCommandTest.test_whois):
153         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
154         (IRCBotTest.test_help):
155         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
156         (SheriffBotTest.test_command_aliases):
157
158 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
159
160         roll-chromium-deps doesn't roll DEPS
161         https://bugs.webkit.org/show_bug.cgi?id=114421
162
163         Reviewed by Antti Koivisto.
164
165         Roll DEPS. Rolling DEPS. Rolled DEPS.
166
167         * Scripts/webkitpy/tool/bot/irc_command.py:
168         (RollChromiumDEPS.execute):
169
170 2013-04-11  Glenn Adams  <glenn@skynav.com>
171
172         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
173         https://bugs.webkit.org/show_bug.cgi?id=114418
174
175         Reviewed by Ryosuke Niwa.
176
177         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
178         (MockSCM.add): Remove optional remove_exit_code argument.
179         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
180         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
181         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
182         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
183
184 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
185
186         Fix roll-chromium-deps and hi.
187
188         * Scripts/webkitpy/tool/bot/irc_command.py:
189         (Hi.execute):
190         (RollChromiumDEPS.execute):
191
192 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
193
194         Remove webkitpy code to roll Chromium DEPS
195         https://bugs.webkit.org/show_bug.cgi?id=114415
196
197         Reviewed by Benjamin Poulain.
198
199         Removed the code to roll Chromium DEPS in WebKit.
200
201         * Scripts/webkitpy/common/checkout/checkout.py:
202         (Checkout.bug_id_for_this_commit):
203         * Scripts/webkitpy/common/checkout/checkout_mock.py:
204         (MockCheckout.commit_message_for_this_commit):
205         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
206         (CheckoutTest.test_suggested_reviewers):
207         * Scripts/webkitpy/common/checkout/deps.py: Removed.
208         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
209         * Scripts/webkitpy/tool/bot/irc_command.py:
210         (RollChromiumDEPS): Teach webkitbot a sense of humor.
211         (RollChromiumDEPS.execute):
212         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
213         (IRCCommandTest.test_create_bug):
214         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
215         (IRCBotTest.test_revert):
216         * Scripts/webkitpy/tool/bot/sheriff.py:
217         (Sheriff.post_rollout_patch):
218         * Scripts/webkitpy/tool/commands/__init__.py:
219         * Scripts/webkitpy/tool/commands/roll.py: Removed.
220         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
221         * Scripts/webkitpy/tool/steps/__init__.py:
222         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
223         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
224         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
225
226 2013-04-11  Glenn Adams  <glenn@skynav.com>
227
228         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
229         https://bugs.webkit.org/show_bug.cgi?id=114386
230
231         Reviewed by Benjamin Poulain.
232
233         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
234         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
235         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
236         by default and to return exit code 1 if a file/dir had already been added.
237
238         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
239         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
240         * Scripts/webkitpy/common/checkout/scm/svn.py:
241         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
242
243 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
244
245         Unreviewed.
246
247         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
248
249 2013-04-10  Glenn Adams  <glenn@skynav.com>
250
251         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
252         https://bugs.webkit.org/show_bug.cgi?id=114410
253
254         Reviewed by Ryosuke Niwa.
255
256         * Scripts/webkitpy/common/checkout/scm/git.py:
257         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
258         * Scripts/webkitpy/common/checkout/scm/scm.py:
259         (SCM.add): Remove optional return_exit_code argument.
260         (SCM.add_list): Remove optional return_exit_code argument.
261         * Scripts/webkitpy/common/checkout/scm/svn.py:
262         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
263
264 2013-04-10  Eric Seidel  <eric@webkit.org>
265
266         Remove myself from the watchlists, I'm getting too much bug mail. :)
267
268         * Scripts/webkitpy/common/config/watchlist:
269
270 2013-04-10  Commit Queue  <rniwa@webkit.org>
271
272         Unreviewed, rolling out r148158.
273         http://trac.webkit.org/changeset/148158
274         https://bugs.webkit.org/show_bug.cgi?id=114405
275
276         We need to migrate status data (Requested by rniwa on
277         #webkit).
278
279         * Scripts/webkitpy/common/net/statusserver.py:
280         (StatusServer):
281
282 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
283
284         Mass remove all the empty directories
285
286         Rubberstamped by Ryosuke Niwa.
287
288         * BuildSlaveSupport/gtk/crashmon/log: Removed.
289         * BuildSlaveSupport/gtk/xvfb/log: Removed.
290         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
291         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
292         * MiniBrowser/gtk/WebBundle: Removed.
293         * MiniBrowser/win: Removed.
294         * QtTestPlatformPlugin/mac: Removed.
295         * Scripts/webkitpy/tool/bot/testdata: Removed.
296         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
297         * efl/ImageDiff: Removed.
298         * iExploder/htdocs: Removed.
299         * iExploder/iexploder-1.7.2/output: Removed.
300         * iExploder/tools: Removed.
301         * qmake/config.tests/libexecdir: Removed.
302         * qmake/config.tests/libjpeg: Removed.
303         * qmake/config.tests/libpng: Removed.
304
305 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
306
307         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
308         https://bugs.webkit.org/show_bug.cgi?id=114397
309
310         Reviewed by Benjamin Poulain.
311
312         * Scripts/webkitpy/common/net/statusserver.py:
313         (StatusServer):
314
315 2013-04-10  Adam Barth  <abarth@webkit.org>
316
317         Remove abarth from watchlists
318         https://bugs.webkit.org/show_bug.cgi?id=114390
319
320         Reviewed by Ryosuke Niwa.
321
322         I'm trying to cut down on the amount of bugmail I get so that I'll have
323         more of a chance to notice a piece of bugmail directed at me.
324
325         * Scripts/webkitpy/common/config/watchlist:
326
327 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
328
329         webkit-test-results.appspot.com loads the dashboard for Chromium by default
330         https://bugs.webkit.org/show_bug.cgi?id=114381
331
332         Reviewed by Benjamin Poulain.
333
334         Changed the defaults.
335
336         * TestResultServer/static-dashboards/builders.js:
337         * TestResultServer/static-dashboards/dashboard_base.js:
338         (currentBuilderGroupCategory):
339
340 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
341
342         Remove Chromium EWS bots from the queue status server
343         https://bugs.webkit.org/show_bug.cgi?id=113988
344
345         Reviewed by Benjamin Poulain.
346
347         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
348
349         * QueueStatusServer/app.yaml:
350         * QueueStatusServer/config/queues.py:
351         * QueueStatusServer/model/queues.py:
352         (Queue.short_name):
353         (Queue.display_name):
354         * QueueStatusServer/model/queues_unittest.py:
355         (QueueTest.test_short_name):
356         (QueueTest.test_display_name):
357         (QueueTest.test_name_with_underscores):
358         * QueueStatusServer/templates/activebots.html:
359
360 2013-04-10  Ojan Vafai  <ojan@chromium.org>
361
362         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
363         https://bugs.webkit.org/show_bug.cgi?id=114370
364
365         Reviewed by Ryosuke Niwa.
366
367         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
368         Unfortunately, there's no way to test this until this is committed and there is
369         a master restart.
370
371         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
377         * TestResultServer/generate_builders_json.py:
378         * TestResultServer/static-dashboards/dashboard_base.js:
379         * TestResultServer/static-dashboards/loader.js:
380
381 2013-04-10  Glenn Adams  <glenn@skynav.com>
382
383         [Qt] Fix regression to test-webkitpy.
384         https://bugs.webkit.org/show_bug.cgi?id=114368
385
386         Reviewed by Ryosuke Niwa.
387
388         * Scripts/webkitpy/layout_tests/port/factory.py:
389         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
390         (PortFactory.get): Remove obsolete chromium port related code.
391         * Scripts/webkitpy/layout_tests/port/mac.py:
392         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
393
394 2013-04-10  Anders Carlsson  <andersca@apple.com>
395
396         Remove unneeded headers from FrameLoader.h
397         https://bugs.webkit.org/show_bug.cgi?id=114223
398
399         Reviewed by Geoffrey Garen.
400
401         Add back headers implicitly included by other headers.
402
403         * WebKitTestRunner/WorkQueueManager.cpp:
404
405 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
406
407         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
408         https://bugs.webkit.org/show_bug.cgi?id=114365
409
410         Reviewed by Martin Robinson.
411
412         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
413         The patch addresses crashes in the tally_event_reply method. It is already committed into the
414         at-spi2-atk source tree and will be available with the next stable release, after which the
415         patch should be removed and the dependency version bumped.
416
417         * gtk/jhbuild.modules:
418         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
419
420 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
421
422         [WinCairo] Unreviewed build fix. Correct DropBox download link.
423
424         * Scripts/update-webkit-wincairo-libs: Revise download URL to
425         match change in DropBox server behavior.
426
427 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
428
429         Removed an annoying message from svn-create-patch
430         https://bugs.webkit.org/show_bug.cgi?id=114332
431
432         Reviewed by Alexey Proskuryakov.
433
434         I see this message basically every time I write a patch, so it must not
435         be true.
436
437         * Scripts/svn-create-patch:
438         (generateDiff):
439
440 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
441
442         [GTK] Add support for Page Visibility
443         https://bugs.webkit.org/show_bug.cgi?id=97324
444
445         Reviewed by Sam Weinig.
446
447         Implemented test runner API for page visibility layout tests.
448
449         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
450         (TestRunner::resetPageVisibility):
451         (TestRunner::setPageVisibility):
452         * Scripts/webkitperl/FeatureList.pm:
453
454 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
455
456         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
457         https://bugs.webkit.org/show_bug.cgi?id=114342
458
459         Reviewed by Gyuyoung Kim.
460
461         Commit 148033 only added an implementation for the Mac port, which made
462         other ports fail most tests since loading the injected bundle failed
463         with a missing symbol.
464
465         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
466         (WTR::AccessibilityUIElement::pathDescription):
467
468 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
469
470         [EFL] Add spell checking option to MiniBrowser
471         https://bugs.webkit.org/show_bug.cgi?id=114282
472
473         Reviewed by Ryosuke Niwa.
474
475         Spell checking is enabled by adding a flag (t/text-checking)
476         with launching MiniBrowser.
477
478         * MiniBrowser/efl/main.c:
479         (window_create):
480         (elm_main):
481
482 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
483
484         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
485         https://bugs.webkit.org/show_bug.cgi?id=113281
486
487         Reviewed by Darin Adler.
488
489         * Scripts/run-gtk-tests:
490         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
491
492 2013-04-09  Glenn Adams  <glenn@skynav.com>
493
494         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
495
496         Unreviewed.
497
498         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
499         (RunTest.test_build_check):
500
501 2013-04-09  Glenn Adams  <glenn@skynav.com>
502
503         [webkitpy] Remove chromium ports.
504         https://bugs.webkit.org/show_bug.cgi?id=114326
505
506         Reviewed by Dirk Pranke.
507
508         As a side effect, also:
509
510         - remove chromium builders from webkitpy.layout_tests.port.builders
511         - remove chromium builders from rebaseline
512         - rewrite chromium dependent tests in rebaseline_unittest
513         - remove chromium platform from garden-o-matic
514         - select apple platform as default platform in garden-o-matic
515         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
516
517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
519         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
520         (BaselineOptimizerTest.test_move_baselines):
521         (BaselineOptimizerTest.test_efl):
522         (BaselineOptimizerTest.test_no_add_mac_future):
523         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
524         (BaselineOptimizerTest.test_common_directory_includes_root):
525         (BaselineOptimizerTest.test_complex_shadowing):
526         (BaselineOptimizerTest.test_virtual_ports_filtered):
527         * Scripts/webkitpy/layout_tests/port/builders.py:
528         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
529         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
530         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
531         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
532         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
533         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
534         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
535         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
536         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
537         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
538         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
539         * Scripts/webkitpy/layout_tests/port/factory.py:
540         (platform_options):
541         (PortFactory):
542         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
543         (FactoryTest.test_qt):
544         (FactoryTest.test_get_from_builder_name):
545         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
546         (RunTest.test_build_check):
547         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
548         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
549         * Scripts/webkitpy/tool/commands/rebaseline.py:
550         (Rebaseline._builders_to_pull_from):
551         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
552         (_BaseTestCase):
553         (_BaseTestCase.setUp):
554         (TestRebaselineTest.setUp):
555         (TestRebaselineTest.test_baseline_directory):
556         (test_rebaseline_updates_expectations_file):
557         (test_rebaseline_does_not_include_overrides):
558         (test_rebaseline_test):
559         (test_rebaseline_test_and_print_scm_changes):
560         (test_rebaseline_and_copy_test):
561         (test_rebaseline_and_copy_test_no_existing_result):
562         (test_rebaseline_and_copy_test_with_lion_result):
563         (test_rebaseline_and_copy_no_overwrite_test):
564         (TestRebaselineExpectations.test_rebaseline_expectations):
565
566 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
567
568         newcommitbot (WKR) requires a subversion checkout
569         https://bugs.webkit.org/show_bug.cgi?id=114309
570
571         Reviewed by Benjamin Poulain.
572
573         Directly talk to the subversion server instead of relying on a local checkout.
574         This allows us to run WKR off of a git clone.
575
576         * Scripts/webkitpy/tool/commands/newcommitbot.py:
577         (NewCommitBot.next_work_item):
578         (NewCommitBot.process_work_item):
579
580 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
581
582         webkitbot refers to sheriffbot in help
583         https://bugs.webkit.org/show_bug.cgi?id=114307
584
585         Reviewed by Benjamin Poulain.
586
587         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
588
589         * Scripts/webkitpy/tool/bot/irc_command.py:
590         (Help):
591         (Help.execute):
592         (RollChromiumDEPS.execute):
593         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
594         (IRCBotTest.test_help):
595         * Scripts/webkitpy/tool/bot/sheriff.py:
596         (Sheriff.name):
597
598 2013-04-06  Roger Fong  <roger_fong@apple.com>
599
600         Kill old processes between runs on WinEWS bots.
601         Temporarily disable tests to let bots catch up again.
602
603         * EWSTools/start-queue-win.sh:
604         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
605         (WinEWS):
606
607 2013-04-09  Glenn Adams  <glenn@skynav.com>
608
609         [webkitpy] Remove chromium deprecated port support.
610         https://bugs.webkit.org/show_bug.cgi?id=114228
611
612         Reviewed by Ryosuke Niwa.
613
614         * Scripts/webkitpy/common/config/ports.py:
615         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
616         (ChromiumPort): Removed.
617         (ChromiumAndroidPort): Removed.
618         (ChromiumXVFBPort): Removed.
619         * Scripts/webkitpy/common/config/ports_unittest.py:
620         (DeprecatedPortTest.test_chromium_port): Removed.
621         (DeprecatedPortTest.test_chromium_android_port): Removed.
622         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
623         * Scripts/webkitpy/tool/steps/update_unittest.py:
624         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
625         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
626
627 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
628
629         AX: The bounding paths should be made available through accessibility
630         https://bugs.webkit.org/show_bug.cgi?id=113817
631
632         Reviewed by David Kilzer.
633
634         Add a pathDescription property for testing so that it's possible
635         to verify that a path is being returned correctly.
636
637         * DumpRenderTree/AccessibilityUIElement.cpp:
638         (getPathDescriptionCallback):
639         (AccessibilityUIElement::pathDescription):
640         (AccessibilityUIElement::getJSClass):
641         * DumpRenderTree/AccessibilityUIElement.h:
642         (AccessibilityUIElement):
643         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
644         (_CGPathEnumerationIteration):
645         (AccessibilityUIElement::pathDescription):
646         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
647         (AccessibilityUIElement::pathDescription):
648         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
649         (WTR::AccessibilityUIElement::pathDescription):
650         (WTR):
651         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
652         (AccessibilityUIElement):
653         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
654         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
655         (WTR::AccessibilityUIElement::pathDescription):
656         (WTR):
657
658 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
659
660         [EFL] Declare TEST_THEME_DIR in a single place.
661         https://bugs.webkit.org/show_bug.cgi?id=114285
662
663         Reviewed by Anders Carlsson.
664
665         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
666
667         * DumpRenderTree/efl/CMakeLists.txt:
668         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
669         (DumpRenderTreeChrome::createView):
670         (DumpRenderTreeChrome::createInspectorView):
671         (DumpRenderTreeChrome::initialize):
672         (DumpRenderTreeChrome::onDownloadRequest):
673         * EWebLauncher/CMakeLists.txt:
674         * EWebLauncher/main.c:
675         (findThemePath):
676         * EWebLauncher/url_bar.c:
677         (url_bar_add):
678         * MiniBrowser/efl/CMakeLists.txt:
679         * MiniBrowser/efl/main.c:
680         (window_create):
681         * TestWebKitAPI/PlatformEfl.cmake:
682         * TestWebKitAPI/efl/PlatformWebView.cpp:
683         (TestWebKitAPI::PlatformWebView::PlatformWebView):
684         * WebKitTestRunner/PlatformEfl.cmake:
685         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
686         (WTR::PlatformWebView::PlatformWebView):
687
688 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
689
690         [GTK][AC] upversion of clutter and its dependecy
691         https://bugs.webkit.org/show_bug.cgi?id=114016
692
693         Reviewed by Gustavo Noronha Silva.
694
695         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
696
697         * gtk/jhbuild-optional.modules:
698
699 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
700
701         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
702         https://bugs.webkit.org/show_bug.cgi?id=89875
703
704         Reviewed by Maciej Stachowiak.
705
706         Add unit tests to verify if the handling of the open, openat, creat syscall
707         is being done right. We check if the Read/Write/ReadAndWrite permissions
708         are respected, if the canonical path is being resolved and if
709         the permissions are falling back to the topmost parent directory with a
710         policy set when the directory being opened has no policy.
711
712         We also test if any attempt of blocking SIGSYS is silently ignored.
713         SIGSYS cannot be blocked because in it's handler is where we hook
714         syscalls to the broker process.
715
716         Also added libseccomp to EFL's jhbuild to make the life of developers
717         willing to help easier.
718
719         * Scripts/webkitperl/FeatureList.pm:
720         * TestWebKitAPI/PlatformEfl.cmake:
721         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
722         (TestWebKitAPI):
723         (SeccompEnvironment):
724         (TestWebKitAPI::SeccompEnvironment::SetUp):
725         (TestWebKitAPI::SeccompEnvironment::TearDown):
726         (TestWebKitAPI::dummyHandler):
727         (TestWebKitAPI::TEST):
728         (TestWebKitAPI::stressTest):
729         * efl/jhbuild.modules:
730         * qmake/mkspecs/features/features.pri:
731
732 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
733
734         REGRESSION: Autocorrection doesn't work in DumpRenderTree
735         https://bugs.webkit.org/show_bug.cgi?id=113846
736
737         Reviewed by Alexey Proskuryakov.
738
739         The problem was that we were replacing NSSpellCheck's dictionary with our own
740         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
741
742         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
743         and "would" respectively in DumpRenderTree.
744
745         * DumpRenderTree/mac/DumpRenderTree.mm:
746         (resetDefaultsToConsistentValues):
747
748 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
749
750         Remove the gyp files for Tools
751         https://bugs.webkit.org/show_bug.cgi?id=114248
752
753         Reviewed by Ryosuke Niwa.
754
755         * DumpRenderTree/DumpRenderTree.gyp: Removed.
756         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
757         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
758         * DumpRenderTree/DumpRenderTree.gypi: Removed.
759         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
760         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
761         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
762         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
763
764 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
765
766         WKR (new-commit-bot) is too slow
767         https://bugs.webkit.org/show_bug.cgi?id=110087
768
769         Reviewed by Geoffrey Garen.
770
771         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
772         Just run "svn log -r <revision>" instead to cut down the delay.
773
774         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
775
776         * Scripts/webkitpy/tool/commands/newcommitbot.py:
777         (NewCommitBot):
778         (NewCommitBot.next_work_item):
779         (NewCommitBot._is_empty_log):
780         (NewCommitBot._update_checkout):
781
782 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
783
784         Build fix. Can't remove appendCustomBuildFlags.
785
786         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
787         (appendCustomBuildFlags):
788
789 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
790
791         Remove Chromium builders from build.webkit.org
792         https://bugs.webkit.org/show_bug.cgi?id=113990
793
794         Reviewed by Benjamin Poulain.
795
796         Removed.
797
798         * BuildSlaveSupport/build.webkit.org-config/config.json:
799         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
800         (InstallGtkDependencies):
801         (RunUnitTests.start):
802         (RunWebKit2Tests.start):
803         (Factory.__init__):
804         (unitTestsSupported):
805         (TestFactory.__init__):
806         (BuildAndTestFactory.__init__):
807         (BuildAndPerfTestFactory.__init__):
808         (BuildAndPerfTestWebKit2Factory.__init__):
809         (DownloadAndPerfTestFactory.__init__):
810         (loadBuilderConfig):
811         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
812
813 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
814
815         Remove HTML Notification
816         https://bugs.webkit.org/show_bug.cgi?id=114231
817
818         Reviewed by Ryosuke Niwa.
819
820         * qmake/mkspecs/features/features.pri:
821
822 2013-04-08  Glenn Adams  <glenn@skynav.com>
823
824         Remove chromium EWS support, and fix broken test.
825         https://bugs.webkit.org/show_bug.cgi?id=114221
826
827         Reviewed by Ryosuke Niwa.
828
829         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
830         (AbstractChromiumEWS): Removed.
831         (ChromiumLinuxEWS): Removed.
832         (ChromiumLinuxDebugEWS): Removed.
833         (ChromiumWindowsEWS): Removed.
834         (ChromiumAndroidEWS): Removed.
835         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
836         (EarlyWarningSystemTest): Fix misspelled class name.
837         (test_ewses): Fix entry point name to ensure test is run.
838
839 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
840
841         [WIN] Remove WebKit2 source code
842         https://bugs.webkit.org/show_bug.cgi?id=114096
843
844         Reviewed by Anders Carlsson.
845
846         Remove the windows specific parts of the MiniBrowser.
847
848         * MiniBrowser/MiniBrowser.vcproj: Removed.
849         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
850         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
851         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
852         * MiniBrowser/win/BrowserView.cpp: Removed.
853         * MiniBrowser/win/BrowserView.h: Removed.
854         * MiniBrowser/win/BrowserWindow.cpp: Removed.
855         * MiniBrowser/win/BrowserWindow.h: Removed.
856         * MiniBrowser/win/MiniBrowser.cpp: Removed.
857         * MiniBrowser/win/MiniBrowser.h: Removed.
858         * MiniBrowser/win/MiniBrowser.rc: Removed.
859         * MiniBrowser/win/main.cpp: Removed.
860         * MiniBrowser/win/resource.h: Removed.
861         * MiniBrowser/win/stdafx.cpp: Removed.
862         * MiniBrowser/win/stdafx.h: Removed.
863
864 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
865
866         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
867
868         * Scripts/webkitpy/common/config/irc.py:
869
870 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
871
872         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
873         https://bugs.webkit.org/show_bug.cgi?id=113139
874
875         Reviewed by Anders Carlsson.
876
877         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
878         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
879         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
880         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
881         (ToStringAndValueOfObject):
882         (ToStringAndValueOfObject::ToStringAndValueOfObject):
883         (ScriptableObject):
884         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
885         (ToStringAndValueOfObject::ScriptableObject::invoke):
886         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
887         (ToStringAndValueOfObject::NPP_GetValue):
888         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
889         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
890         * GNUmakefile.am:
891
892 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
893
894         [GTK] Bump gnome-themes-standard to 3.6.0
895         https://bugs.webkit.org/show_bug.cgi?id=114155
896
897         Reviewed by Martin Robinson.
898
899         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
900         dependency of gnome-themes-standard accordingly.
901
902 2013-04-08  David Levin  <levin@chromium.org>
903
904         Remove my watchlist entries.
905         https://bugs.webkit.org/show_bug.cgi?id=114180
906
907         Reviewed by Adam Barth.
908
909         * Scripts/webkitpy/common/config/committers.py:
910         * Scripts/webkitpy/common/config/watchlist:
911
912 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
913
914         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
915         https://bugs.webkit.org/show_bug.cgi?id=114161
916
917         Reviewed by Gyuyoung Kim.
918
919         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
920         as it is crashing due to Bug 111074.
921
922         * TestWebKitAPI/PlatformEfl.cmake:
923
924 2013-04-07  David Kilzer  <ddkilzer@apple.com>
925
926         Remove the rest of SVG_DOM_OBJC_BINDINGS
927         <http://webkit.org/b/114112>
928
929         Reviewed by Geoffrey Garen.
930
931         * Scripts/webkitperl/FeatureList.pm:
932         - Remove --svg-dom-objc-bindings switch.
933         * qmake/mkspecs/features/features.pri:
934         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
935
936 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
937
938         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
939         https://bugs.webkit.org/show_bug.cgi?id=114089
940
941         Reviewed by Chris Fleizach.
942
943         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
944         * DumpRenderTree/AccessibilityController.cpp:
945         * DumpRenderTree/AccessibilityUIElement.cpp:
946         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
947         (DumpRenderTreeChrome::DumpRenderTreeChrome):
948         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
949         (DumpRenderTreeChrome):
950
951 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
952
953         Build fix after r147857, remove remaining USE(JSC) guards.
954
955         Unreviewed.
956
957         * DumpRenderTree/config.h:
958         * TestWebKitAPI/config.h:
959         * WebKitTestRunner/config.h:
960
961 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
962
963         Rename sheriffbot to webkitbot
964         https://bugs.webkit.org/show_bug.cgi?id=114109
965
966         Reviewed by Benjamin Poulain.
967
968         Renamed since sheriffbot will be used in Blink.
969
970         * Scripts/webkitpy/tool/commands/sheriffbot.py:
971         (SheriffBot):
972         (SheriffBot.begin_work_queue):
973
974 2013-04-06  Oliver Hunt  <oliver@apple.com>
975
976         Unify the many and varied stack trace mechanisms, and make the result sane.
977         https://bugs.webkit.org/show_bug.cgi?id=114072
978
979         Reviewed by Filip Pizlo.
980
981         The commandline jsc executable no longer requires arguments, so
982         I've made run-jsc work without them.
983
984         * Scripts/run-jsc:
985
986 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
987
988         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
989         https://bugs.webkit.org/show_bug.cgi?id=114086
990
991         Reviewed by Tim Horton.
992
993         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
994
995 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
996
997         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
998         https://bugs.webkit.org/show_bug.cgi?id=114083
999
1000         Reviewed by Ryosuke Niwa.
1001
1002         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
1003         in TestWebKitAPI and WebKitTestRunner.
1004
1005         * TestWebKitAPI/config.h:
1006         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1007         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1008         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1009         (WTR::InjectedBundle::platformInitialize):
1010
1011 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
1012
1013         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
1014         https://bugs.webkit.org/show_bug.cgi?id=114094
1015
1016         Reviewed by Anders Carlsson.
1017
1018         * Scripts/run-jsc:
1019
1020 2013-04-05  Ojan Vafai  <ojan@chromium.org>
1021
1022         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
1023         https://bugs.webkit.org/show_bug.cgi?id=114080
1024
1025         Reviewed by Ryosuke Niwa.
1026
1027         This way, the WebKit and Blink dashboard code can change as appropriate without
1028         needing to consider the other project's needs. This still doesn't update the
1029         buildbots to upload to the new location, or the dashboard code to pull the
1030         results.json files from the new location, but it at least allows for changing the
1031         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1032
1033         * TestResultServer/app.yaml:
1034
1035 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1036
1037         Re-enable testing on the commit queue
1038         https://bugs.webkit.org/show_bug.cgi?id=114078
1039
1040         Reviewed by Darin Adler.
1041
1042         Re-enabled the feature and the associated tests.
1043
1044         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1045         (CommitQueueTask.run):
1046         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1047         (CommitQueueTaskTest._run_through_task):
1048         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1049         (CommitQueueTest._mock_test_result):
1050
1051 2013-04-05  Oliver Hunt  <oliver@apple.com>
1052
1053         Unify the many and varied stack trace mechanisms, and make the result sane.
1054         https://bugs.webkit.org/show_bug.cgi?id=114072
1055
1056         Reviewed by Filip Pizlo.
1057
1058         The commandline jsc executable no longer requires arguments, so
1059         I've made run-jsc work without them.
1060
1061         * Scripts/run-jsc:
1062
1063 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1064
1065         AX: Make SVG Group containers accessible elements
1066         https://bugs.webkit.org/show_bug.cgi?id=113939
1067
1068         Reviewed by Simon Fraser.
1069
1070         Implement axController.elementAtPoint for iOS.
1071         Implement a correct version of clickPoint for iOS.
1072
1073         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1074         (AccessibilityController::elementAtPoint):
1075         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1076         (AccessibilityUIElement::clickPointX):
1077         (AccessibilityUIElement::clickPointY):
1078
1079 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1080
1081         Unreviewed, rolling out r147773 and r147774.
1082         http://trac.webkit.org/changeset/147773
1083         http://trac.webkit.org/changeset/147774
1084         https://bugs.webkit.org/show_bug.cgi?id=114056
1085
1086         Causing some exceptions on AppEngine I don't understand
1087         (Requested by rniwa on #webkit).
1088
1089         * QueueStatusServer/config/queues.py:
1090         * QueueStatusServer/model/queues.py:
1091         (Queue.short_name):
1092         (Queue.display_name):
1093         * QueueStatusServer/model/queues_unittest.py:
1094         (QueueTest.test_short_name):
1095         (QueueTest.test_display_name):
1096         (QueueTest.test_name_with_underscores):
1097
1098 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1099
1100         Fixed run-bindings-tests by removing V8
1101         https://bugs.webkit.org/show_bug.cgi?id=114053
1102
1103         Reviewed by Benjamin Poulain.
1104
1105         * Scripts/run-bindings-tests:
1106         (main):
1107
1108 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1109
1110         Build fix.
1111
1112         * QueueStatusServer/model/queues.py:
1113         (Queue.short_name):
1114         (Queue.display_name):
1115
1116 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1117
1118         Remove Chromium EWS bots from the queue status server
1119         https://bugs.webkit.org/show_bug.cgi?id=113988
1120
1121         Reviewed by Benjamin Poulain.
1122
1123         Removed Chromium EWS bots.
1124
1125         * QueueStatusServer/config/queues.py:
1126         * QueueStatusServer/model/queues.py:
1127         (Queue.short_name):
1128         (Queue.display_name):
1129         * QueueStatusServer/model/queues_unittest.py:
1130         (QueueTest.test_short_name):
1131         (QueueTest.test_display_name):
1132         (QueueTest.test_name_with_underscores):
1133
1134 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1135
1136         [EFL] Enable indexed database
1137         https://bugs.webkit.org/show_bug.cgi?id=107248
1138
1139         Reviewed by Alexis Menard.
1140
1141         * Scripts/webkitperl/FeatureList.pm:
1142
1143 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1144
1145         Remove vestiges of Chromium bits from watchlists.
1146         https://bugs.webkit.org/show_bug.cgi?id=114047
1147
1148         Reviewed by Ryosuke Niwa.
1149
1150         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1151
1152 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1153
1154         Add James Craig to the contributors list.
1155
1156         * Scripts/webkitpy/common/config/committers.py:
1157
1158 2013-04-04  Kent Tamura  <tkent@chromium.org>
1159
1160         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1161
1162         * Scripts/webkitpy/common/config/watchlist:
1163
1164 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1165
1166         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1167         https://bugs.webkit.org/show_bug.cgi?id=113997
1168
1169         Reviewed by Ryosuke Niwa.
1170
1171         Disable the tests until Ryosuke gets the time and hardware to have
1172         a testing commit-queue.
1173
1174         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1175         (CommitQueueTaskTest):
1176         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1177         (CommitQueueTest):
1178
1179 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1180
1181         Remove Chromium builders from build.webkit.org
1182         https://bugs.webkit.org/show_bug.cgi?id=113990
1183
1184         Reviewed by Benjamin Poulain.
1185
1186         Land the part to disable triggering of Chromium builders first so that we may start
1187         deleting more Chromium code that breaks the update step.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/config.json:
1190
1191 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1192
1193         Remove Chromium's DumpRenderTree
1194         https://bugs.webkit.org/show_bug.cgi?id=113989
1195
1196         Reviewed by Kent Tamura.
1197
1198         On second thought, let's not go to Camelot. It is a silly place.
1199
1200         * DumpRenderTree/mac/DumpRenderTree.mm:
1201         (resetDefaultsToConsistentValues):
1202
1203 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1204
1205         Nixed the defunct chromium folder from DumpRenderTree
1206         https://bugs.webkit.org/show_bug.cgi?id=113993
1207
1208         Reviewed by Ryosuke Niwa.
1209
1210         * DumpRenderTree/chromium: Removed.
1211         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1212         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1213         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1214         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1215         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1216         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1217         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1218         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1219         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1220         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1221         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1222         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1223         * DumpRenderTree/chromium/Task.cpp: Removed.
1224         * DumpRenderTree/chromium/Task.h: Removed.
1225         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1226         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1227         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1228         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1229         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1230         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1231         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1232         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1233         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1234         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1235         * DumpRenderTree/chromium/TestRunner: Removed.
1236         * DumpRenderTree/chromium/TestRunner/public: Removed.
1237         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1238         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1239         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1240         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1241         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1242         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1243         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1244         * DumpRenderTree/chromium/TestRunner/src: Removed.
1245         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1246         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1247         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1248         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1249         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1250         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1251         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1252         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1253         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1254         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1255         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1256         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1257         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1258         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1259         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1260         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1261         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1262         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1263         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1264         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1265         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1266         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1267         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1268         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1269         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1270         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1271         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1272         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1273         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1274         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1275         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1276         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1277         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1278         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1279         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1280         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1281         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1282         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1283         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1284         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1285         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1286         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1287         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1288         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1289         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1290         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1291         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1292         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1293         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1294         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1295         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1296         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1297         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1298         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1299         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1300         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1301         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1302         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1303         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1304         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1305         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1306         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1307         * DumpRenderTree/chromium/TestShell.h: Removed.
1308         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1309         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1310         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1311         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1312         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1313         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1314         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1315         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1316         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1317         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1318         * DumpRenderTree/chromium/config.h: Removed.
1319         * DumpRenderTree/chromium/fonts.conf: Removed.
1320
1321 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1322
1323         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1324
1325         Rubber stamped by Benjamin Poulain.
1326
1327         * RebaselineQueueServer: Removed.
1328         * RebaselineQueueServer/app.yaml: Removed.
1329         * RebaselineQueueServer/handlers: Removed.
1330         * RebaselineQueueServer/handlers/__init__.py: Removed.
1331         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1332         * RebaselineQueueServer/handlers/pages.py: Removed.
1333         * RebaselineQueueServer/index.yaml: Removed.
1334         * RebaselineQueueServer/main.py: Removed.
1335         * RebaselineQueueServer/model: Removed.
1336         * RebaselineQueueServer/model/__init__.py: Removed.
1337         * RebaselineQueueServer/model/queueentry.py: Removed.
1338         * RebaselineQueueServer/static: Removed.
1339         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1340         * RebaselineQueueServer/static/styles.css: Removed.
1341         * RebaselineQueueServer/templates: Removed.
1342         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1343         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1344         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1345         * RebaselineQueueServer/templates/home.html: Removed.
1346
1347 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1348
1349         Fix setup-commit-queue and temporarily disable testing on commit-queue
1350         https://bugs.webkit.org/show_bug.cgi?id=113979
1351
1352         Reviewed by Benjamin Poulain.
1353
1354         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1355         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1356
1357         * EWSTools/setup-commit-queue.sh:
1358         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1359         (CommitQueueTask.run):
1360
1361 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1362
1363         temporarily make flakiness dashboard work again webkit.org bots
1364         https://bugs.webkit.org/show_bug.cgi?id=113972
1365
1366         Reviewed by Ojan Vafai.
1367
1368         This patch disables the chromium.org layout test bots TestExpectations
1369         parsing temporarily until we can work out the right way to split into
1370         two instances for webkit.org and chromium.org and figure out which
1371         code to delete where :).
1372
1373         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1374
1375 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1376
1377         Fix webkitpy tests after r147678.
1378
1379         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1380         (CommitQueueTest.test_commit_queue):
1381         (test_manual_reject_during_processing):
1382
1383 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1384
1385         The commit queue should use Mac MountainLion port
1386         https://bugs.webkit.org/show_bug.cgi?id=113971
1387
1388         Reviewed by Lucas Forschler.
1389
1390         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1391         * Scripts/webkitpy/tool/commands/queues.py:
1392         (CommitQueue):
1393
1394 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1395
1396         turn off running tests on chromium linux EWS bots
1397         https://bugs.webkit.org/show_bug.cgi?id=113959
1398
1399         Reviewed by Geoffrey Garen.
1400
1401         Now that the Chromium port is no longer being maintained
1402         there's little point in running the tests. Soon we should
1403         just shut this bot off altogether.
1404
1405         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1406         (ChromiumLinuxEWS):
1407
1408 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1409
1410         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1411
1412         * Scripts/webkitpy/common/config/watchlist:
1413
1414 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1415
1416         Indentation fix to get webkit-patch working again after r147625
1417
1418         Unreviewed.
1419
1420         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1421         (MacEWS):
1422         (MacWK2EWS):
1423
1424 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1425
1426         Turn tests back on for Mac WK1/WK2 EWS.
1427         
1428         Unreviewed.
1429         
1430         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1431         (MacEWS):
1432         (MacWK2EWS):
1433
1434 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1435
1436         [GTK][WK2] MiniBrowser custom URI scheme support
1437         https://bugs.webkit.org/show_bug.cgi?id=112419
1438
1439         Reviewed by Carlos Garcia Campos.
1440
1441         Add support for about URIs in MiniBrowser. An example about page is show
1442         with URI "about:minibrowser", the rest of the cases it will show a
1443         proper message explaining that the about page didn't exist.
1444
1445         Internally it uses "minibrowser-about" prefix instead of "about", but
1446         from the user point of view it works with "about" prefix.
1447
1448         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1449         (getInternalURI): Method to convert URIs from "about" prefix to
1450         "minibrowser-about".
1451         (getExternalURI): Opposite method.
1452         (webViewURIChanged): Use "about" prefix to show the URI to users.
1453         (webViewEnterFullScreen): Ditto.
1454         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1455         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1456         (aboutURISchemeRequestCallback): Callback to manage about calls.
1457         (main): Register the URI scheme to manage about URIs.
1458
1459 2013-04-03  Roger Fong  <roger_fong@apple.com>
1460
1461         Re-enable WinEWS tests.
1462
1463         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1464         (WinEWS):
1465
1466 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1467
1468         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1469         https://bugs.webkit.org/show_bug.cgi?id=113883
1470
1471         Reviewed by Martin Robinson.
1472
1473         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1474         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1475         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1476
1477 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1478
1479         [GTK] Include Pango in jhbuild-optional.modules
1480         https://bugs.webkit.org/show_bug.cgi?id=113878
1481
1482         Reviewed by Martin Robinson.
1483
1484         Since r147547 Pango 1.32.0 is required. Including the module in the
1485         JHBuild optional moduleset.
1486
1487         * gtk/jhbuild-optional.modules: Add Pango module.
1488
1489 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1490
1491         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1492         https://bugs.webkit.org/show_bug.cgi?id=113864
1493
1494         Moving setDefersLoading from TestRunnerQt to TestRunner
1495         requires access to the non-Qt TestRunner.
1496         As long as we instantiate both TestRunner and TestRunnerQt,
1497         we need a separate getter for the non-Qt TestRunner instance.
1498
1499         Reviewed by Simon Hausmann.
1500
1501         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1502         (WebPage::resetSettings):
1503         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1504         (DumpRenderTree::jscTestRunner):
1505         * DumpRenderTree/qt/TestRunnerQt.cpp:
1506         (TestRunner::setDefersLoading):
1507             Moving setDefersLoading from TestRunnerQt
1508             to TestRunner.
1509         * DumpRenderTree/qt/TestRunnerQt.h:
1510         (TestRunnerQt):
1511
1512 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1513
1514         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1515         https://bugs.webkit.org/show_bug.cgi?id=104779
1516
1517         Reviewed by Carlos Garcia Campos.
1518
1519         * Scripts/run-gtk-tests:
1520         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1521         passing in current trunk.
1522
1523 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1524
1525         Fix HAVE(QTTESTSUPPORT) logic
1526
1527         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1528         resulting in HAVE(QTTESTSUPPORT) never being true.
1529         Move that logic down in sanitizeFeatures.
1530
1531         Rubber-stamped by Tor Arne Vestbø.
1532
1533         * qmake/mkspecs/features/features.prf:
1534
1535 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1536
1537         [GTK] Bump required versions of some dependencies
1538         https://bugs.webkit.org/show_bug.cgi?id=113282
1539
1540         Reviewed by Martin Robinson.
1541
1542         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1543
1544 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1545
1546         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1547         https://bugs.webkit.org/show_bug.cgi?id=113809
1548
1549         Reviewed by Philippe Normand.
1550
1551         Newer Linux kernels have removed some deprecated macros from v4l2
1552         headers, causing gst-plugins-good's build to break. We don't need it
1553         right now, so just disable it.
1554
1555         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1556
1557 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1558
1559         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1560         https://bugs.webkit.org/show_bug.cgi?id=113535
1561
1562         Reviewed by Simon Hausmann.
1563
1564         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1565
1566         * qmake/mkspecs/features/features.prf:
1567
1568 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1569
1570         [Qt] Move logic of simple forwarding functions to TestRunner.
1571         https://bugs.webkit.org/show_bug.cgi?id=113863
1572
1573         Reviewed by Simon Hausmann.
1574
1575         * DumpRenderTree/qt/TestRunnerQt.cpp:
1576         (TestRunner::setTextDirection):
1577         (TestRunner::goBack):
1578         (TestRunner::evaluateScriptInIsolatedWorld):
1579         (TestRunner::addUserStyleSheet):
1580         * DumpRenderTree/qt/TestRunnerQt.h:
1581         (TestRunnerQt):
1582
1583 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1584
1585         [Qt] Disable media support using QuickTime if deployment target != SDK
1586
1587         We link to a single libWebKitSystemInterface static lib, so unless the
1588         deployment target matches the SDK let's not pretend like we'll be able
1589         to run on anything lower than the SDK version.
1590
1591         Reviewed by Simon Hausmann.
1592
1593         * qmake/mkspecs/features/features.prf:
1594
1595 2013-04-02  James Craig  <james@cookiecrook.com>
1596
1597         AXRoleDescripton for DL is "list"; should be "description list"
1598         https://bugs.webkit.org/show_bug.cgi?id=111665
1599
1600         Reviewed by Chris Fleizach.
1601
1602         Defining the role and description strings.
1603
1604         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1605
1606 2013-04-02  Roger Fong  <roger_fong@apple.com>
1607
1608         Unreviewed. Disable running tests on Win EWS queue.
1609
1610         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1611         (WinEWS):
1612
1613 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1614
1615         Disable running tests on the MAC WK2 EWS queue.
1616         
1617         Unreviewed.
1618         
1619         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1620         (MacWK2EWS):
1621
1622 2013-04-02  Julie Parent  <jparent@chromium.org>
1623
1624         Dashboard refactor: Move dashboard specific history related features to History.
1625         https://bugs.webkit.org/show_bug.cgi?id=113717
1626
1627         Reviewed by Ojan Vafai.
1628         
1629         Each dashboard now creates its own History object, with a custom
1630         configuration. This changes from just overriding global functions
1631         to passing in callbacks for generatePage, handleValidHashParameter,
1632         and handleQueryParameterChange. Same with passing in defaultStateValues
1633         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1634         variables.
1635         
1636         All functions related to these features are now (mostly) private
1637         function on History. 
1638         
1639         Loader no longer needs a loadingComplete callback, since it can just
1640         initialize the history object itself.
1641
1642         * TestResultServer/static-dashboards/aggregate_results.js:
1643         (handleValidHashParameter):
1644         * TestResultServer/static-dashboards/dashboard_base.js:
1645         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1646         (generatePage):
1647         (.switch.return):
1648         (handleQueryParameterChange):
1649         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1650         (resetGlobals):
1651         * TestResultServer/static-dashboards/history.js:
1652         (.):
1653         * TestResultServer/static-dashboards/loader.js:
1654         (.):
1655         * TestResultServer/static-dashboards/loader_unittests.js:
1656         * TestResultServer/static-dashboards/timeline_explorer.js:
1657         (generatePage):
1658         (initCurrentBuilderTestResults):
1659         * TestResultServer/static-dashboards/treemap.js:
1660         (generatePage):
1661         (.switch.return):
1662         (handleQueryParameterChange):
1663
1664 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1665
1666         Unreviewed, rolling out r147401.
1667         http://trac.webkit.org/changeset/147401
1668         https://bugs.webkit.org/show_bug.cgi?id=113767
1669
1670         The patch makes it extremely hard to set up the dependencies
1671         properly on the GTK builders (Requested by zdobersek on
1672         #webkit).
1673
1674         * gtk/jhbuild.modules:
1675
1676 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1677
1678         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1679         https://bugs.webkit.org/show_bug.cgi?id=113382
1680
1681         Reviewed by Gyuyoung Kim.
1682
1683         Do not show the empty tooltip box if the text is null.
1684
1685         * MiniBrowser/efl/main.c:
1686         (popup_menu_populate):
1687
1688 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1689
1690         [GTK] Bump required versions of some dependencies
1691         https://bugs.webkit.org/show_bug.cgi?id=113282
1692
1693         Reviewed by Martin Robinson.
1694
1695         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1696
1697 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1698
1699         Unreviewed, rolling out r147319.
1700         http://trac.webkit.org/changeset/147319
1701         https://bugs.webkit.org/show_bug.cgi?id=113707
1702
1703         The unit test is still failing on the buildbot (Requested by
1704         zdobersek on #webkit).
1705
1706         * Scripts/run-gtk-tests:
1707         (TestRunner):
1708
1709 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1710
1711         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1712         https://bugs.webkit.org/show_bug.cgi?id=104779
1713
1714         Reviewed by Carlos Garcia Campos.
1715
1716         * Scripts/run-gtk-tests:
1717         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1718         passing in current trunk.
1719
1720 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1721
1722         Unreviewed, rolling out r147289.
1723         http://trac.webkit.org/changeset/147289
1724         https://bugs.webkit.org/show_bug.cgi?id=113678
1725
1726         broke Win7 (dbg) build (Requested by shinyak|gardener on
1727         #webkit).
1728
1729         * DumpRenderTree/DumpRenderTree.gypi:
1730         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1731         (WebTestRunner):
1732         (WebUserMediaClientMock):
1733         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1734         (WebTestRunner::WebUserMediaClientMock::taskList):
1735         * Scripts/webkitpy/style/checkers/cpp.py:
1736         (check_function_definition):
1737
1738 2013-03-31  Adam Barth  <abarth@webkit.org>
1739
1740         configure-svn-config.sh fails
1741         https://codereview.chromium.org/13392007/
1742
1743         Reviewed by Eric Seidel.
1744
1745         This script was trying to use "svn checkout" to dowload a file from
1746         svn.webkit.org, but "svn checkout" only works with directories.
1747         Instead, we should use "svn export".
1748
1749         * EWSTools/configure-svn-config.sh:
1750
1751 2013-03-31  Wei Jia  <wjia@chromium.org>
1752
1753         Allow WebUserMediaClientMock to be used by client
1754         https://bugs.webkit.org/show_bug.cgi?id=113633
1755
1756         Reviewed by Adam Barth.
1757
1758         Export WebUserMediaClientMock.
1759         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1760
1761         * DumpRenderTree/DumpRenderTree.gypi:
1762         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1763         (WebUserMediaClientMock):
1764         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1765         * Scripts/webkitpy/style/checkers/cpp.py:
1766         (check_function_definition):
1767
1768 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1769
1770         Expose FeatureObserver data to WebKit clients
1771         https://bugs.webkit.org/show_bug.cgi?id=113613
1772
1773         Reviewed by Sam Weinig.
1774
1775         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1776         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1777
1778 2013-03-29  Greg Hughes  <ghughes@apple.com>
1779
1780         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1781         https://bugs.webkit.org/show_bug.cgi?id=112276
1782
1783         Reviewed by Chris Fleizach.
1784
1785         Added support to test accessibility search predicates with multiple keys.  
1786
1787         * DumpRenderTree/AccessibilityUIElement.cpp:
1788         (uiElementForSearchPredicateCallback):
1789         * DumpRenderTree/AccessibilityUIElement.h:
1790         (AccessibilityUIElement):
1791         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1792         (AccessibilityUIElement::uiElementForSearchPredicate):
1793         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1794         (AccessibilityUIElement::uiElementForSearchPredicate):
1795         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1796         (AccessibilityUIElement::uiElementForSearchPredicate):
1797         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1798         (AccessibilityUIElement::uiElementForSearchPredicate):
1799         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1800         (AccessibilityUIElement::uiElementForSearchPredicate):
1801         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1802         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1803         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1804         (AccessibilityUIElement):
1805         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1806         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1807         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1808         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1809         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1810
1811 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1812
1813         Fix a typo in r147147 to fix Mac EWS.
1814
1815         * Scripts/webkitpy/tool/commands/queues.py:
1816         (PatchProcessingQueue._new_port_name_from_old):
1817
1818 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1819
1820         [EFL] Build break with latest EFL libraries after r146265
1821         https://bugs.webkit.org/show_bug.cgi?id=113558
1822
1823         Unreviewed build fix.
1824
1825         * TestWebKitAPI/PlatformWebView.h:
1826         * WebKitTestRunner/PlatformWebView.h:
1827
1828 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1829
1830         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1831
1832         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1833         in libgcrypt build.
1834
1835 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1836
1837         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1838
1839         Unreviewed.
1840
1841         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1842         (MacEWS):
1843
1844 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1845
1846         Use the right OS name on Mac EWS instead of mac-future.
1847
1848         Rubber-stamped by Dirk Pranke.
1849
1850         * Scripts/webkitpy/tool/commands/queues.py:
1851         (PatchProcessingQueue._new_port_name_from_old):
1852         (PatchProcessingQueue.begin_work_queue):
1853         (PatchProcessingQueue._upload_results_archive_for_patch):
1854
1855 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1856
1857         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1858         https://bugs.webkit.org/show_bug.cgi?id=112546
1859
1860         Reviewed by Martin Robinson.
1861
1862         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1863         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1864
1865 2013-03-28  Ming Xie  <mxie@blackberry.com>
1866
1867         [BlackBerry] Committer Email Updates
1868         https://bugs.webkit.org/show_bug.cgi?id=113435
1869
1870         Reviewed by Rob Buis.
1871
1872         Add the @blackberry.com email address for all our BlackBerry
1873         WebKit committers. This is the first step for our email address
1874         migration.
1875
1876         * Scripts/webkitpy/common/config/committers.py:
1877
1878 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1879
1880         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1881         https://bugs.webkit.org/show_bug.cgi?id=113508
1882
1883         Reviewed by Martin Robinson.
1884
1885         Prevent the GStreamer plugin scanner to load system-wide
1886         plugins. Only the ones built in JHBuild should be loaded and used
1887         at runtime.
1888
1889         * efl/jhbuildrc:
1890         * gtk/jhbuildrc:
1891
1892 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1893
1894         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1895         https://bugs.webkit.org/show_bug.cgi?id=113386
1896
1897         Reviewed by Carlos Garcia Campos.
1898
1899         * Scripts/webkitdirs.pm:
1900         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1901         version to 3.0. Reflect this change so the builtDylibPathForName
1902         function doesn't fail to report the library as found.
1903
1904 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1905
1906         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1907         https://bugs.webkit.org/show_bug.cgi?id=113484
1908
1909         Unreviewed build fix.
1910
1911         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1912
1913         * TestWebKitAPI/CMakeLists.txt:
1914         * WebKitTestRunner/CMakeLists.txt:
1915
1916 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1917
1918         Revision for the internal jhbuild is too old
1919         https://bugs.webkit.org/show_bug.cgi?id=113324
1920
1921         Reviewed by Martin Robinson.
1922
1923         Update the minimum required version to a point where jhbuild won't
1924         fail installing packages when trying to remove a symlink to a directory.
1925
1926         * jhbuild/jhbuild-wrapper: Updated revision.
1927
1928 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1929
1930         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1931         https://bugs.webkit.org/show_bug.cgi?id=113203
1932
1933         Reviewed by Philippe Normand.
1934
1935         We build our libsoup without GNOME support. gst-plugins-good does separate
1936         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1937         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1938         build failures as the headers of those diverge. We do not use souphttpsrc, so
1939         disable it when building gst-plugins-good.
1940
1941         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1942
1943 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1944
1945         Build fix after r146852. Please another reference to the Lion leaks builder.
1946
1947         * BuildSlaveSupport/build.webkit.org-config/config.json:
1948
1949 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1950
1951         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1952         https://bugs.webkit.org/show_bug.cgi?id=113421
1953
1954         Reviewed by Dirk Pranke.
1955
1956         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1957         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1958         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1959         in the GTK-specific TestExpectations files.
1960
1961         To avoid this only enable the warnings only when not using WKTR.
1962
1963         * Scripts/webkitpy/layout_tests/port/gtk.py:
1964         (GtkPort.warn_if_bug_missing_in_test_expectations):
1965
1966 2013-03-27  Antti Koivisto  <antti@apple.com>
1967
1968         Fix Zalan's email.
1969
1970         * Scripts/webkitpy/common/config/committers.py:
1971
1972 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1973
1974         master.cfg cleanup
1975         https://bugs.webkit.org/show_bug.cgi?id=113195
1976
1977         Reviewed by Ryosuke Niwa.
1978
1979         * BuildSlaveSupport/build.webkit.org-config/config.json:
1980         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1981
1982 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1983
1984         master.cfg fine-tuning for Qt Mountain Lion Release bot
1985         https://bugs.webkit.org/show_bug.cgi?id=113191
1986
1987         Reviewed by Ryosuke Niwa.
1988
1989         * BuildSlaveSupport/build.webkit.org-config/config.json:
1990           - Rename the slave due to its location change.
1991           - Update the platform of the slave.
1992         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1993         (RunQtAPITests): Enable running WK2 API tests on Qt.
1994         (RunQtAPITests.start):
1995         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1996         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1997
1998 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1999
2000         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
2001         https://bugs.webkit.org/show_bug.cgi?id=113403
2002
2003         Reviewed by Kenneth Rohde Christiansen.
2004
2005         As of Evas 1.7.5, when Wayland is detected on the system, support for
2006         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
2007         The code, however, seems to depend on a few other flags which must be
2008         explicitly enabled.
2009
2010         If those additional GL-related options are passed, we end up
2011         having issues on the WebKit side, so disable Wayland support for
2012         now.
2013
2014         * efl/jhbuild.modules:
2015
2016 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2017
2018         Unreviewed, rolling out r146864.
2019         http://trac.webkit.org/changeset/146864
2020         https://bugs.webkit.org/show_bug.cgi?id=113391
2021
2022         causes crashes on Wk2 EFL release bot (Requested by drott on
2023         #webkit).
2024
2025         * Scripts/webkitperl/FeatureList.pm:
2026
2027 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2028
2029         [jhbuild] Correctly specify an alternate number of make jobs.
2030         https://bugs.webkit.org/show_bug.cgi?id=113396
2031
2032         Reviewed by Philippe Normand.
2033
2034         So far, we were using the `MAKEFLAGS' environment variable to pass the
2035         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2036         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2037
2038         We now behave more closely to the rest of the WebKit tools by first
2039         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2040         not set, just letting jhbuild itself figure out how many jobs to use.
2041
2042         * efl/jhbuildrc:
2043         * gtk/jhbuildrc:
2044
2045 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2046
2047         [Qt] Remove Qt specific WorkQueueItem definitions.
2048         https://bugs.webkit.org/show_bug.cgi?id=112891
2049
2050         This patch is preparation work for removing
2051         WorkQueue related code from TestRunnerQt and
2052         replacing it with generic TestRunner code.
2053
2054         Reviewed by Benjamin Poulain.
2055
2056         * DumpRenderTree/qt/TestRunnerQt.cpp:
2057         (TestRunnerQt::queueBackNavigation):
2058         (TestRunnerQt::queueForwardNavigation):
2059         (TestRunnerQt::queueLoadHTMLString):
2060         (TestRunnerQt::queueReload):
2061         (TestRunnerQt::queueLoadingScript):
2062         (TestRunnerQt::queueNonLoadingScript):
2063         (TestRunner::queueLoad):
2064         * DumpRenderTree/qt/TestRunnerQt.h:
2065         (TestRunnerQt):
2066         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2067         (LoadItem::invoke):
2068         (LoadHTMLStringItem::invoke):
2069         (LoadAlternateHTMLStringItem::invoke):
2070         (ReloadItem::invoke):
2071         (ScriptItem::invoke):
2072         (BackForwardItem::invoke):
2073         * DumpRenderTree/qt/WorkQueueItemQt.h:
2074         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2075         (LoadAlternateHTMLStringItem):
2076
2077 2013-03-26  Julie Parent  <jparent@chromium.org>
2078
2079         Flakiness dashboard: simplify logic around which tests to show.
2080         https://bugs.webkit.org/show_bug.cgi?id=113250
2081
2082         Reviewed by Ojan Vafai.
2083         
2084         The different filters for showing results are only used for layout
2085         tests, otherwise, we show everything.
2086         
2087         Change the defaults to false (what layout tests used), and only
2088         look at the values when viewing layout tests.
2089
2090         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2091         (htmlForTestsWithExpectationsButNoFailures):
2092         (shouldHideTest):
2093
2094 2013-03-26  Isaac Levy  <ilevy@google.com>
2095
2096         Update bots on test-results.appspot
2097         https://bugs.webkit.org/show_bug.cgi?id=113333
2098
2099         Reviewed by Ojan Vafai.
2100
2101         * TestResultServer/static-dashboards/builders.jsonp:
2102
2103 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2104
2105         Unreviewed GTK gardening.
2106
2107         * Scripts/run-gtk-tests:
2108         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2109
2110 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2111
2112         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2113         https://bugs.webkit.org/show_bug.cgi?id=113287
2114
2115         Reviewed by Jocelyn Turcotte.
2116
2117         * Scripts/run-qtwebkit-tests:
2118         (Options.__init__):
2119
2120 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2121
2122         [EFL] Enable IndexedDB by default
2123         https://bugs.webkit.org/show_bug.cgi?id=107248
2124
2125         Reviewed by Laszlo Gombos.
2126
2127         * Scripts/webkitperl/FeatureList.pm:
2128         Enable IndexedDB by default on EFL.
2129
2130 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2131
2132         Sheriffbot should explain rollout failures in a human readable form.
2133         https://bugs.webkit.org/show_bug.cgi?id=107092
2134
2135         Reviewed by Ryosuke Niwa.
2136
2137         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2138
2139         * Scripts/webkitpy/tool/bot/irc_command.py:
2140         (Rollout._check_diff_failure):
2141         (Rollout.execute):
2142         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2143         (IRCCommandTest.test_rollout):
2144
2145 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2146
2147         Unreviewed GTK gardening.
2148
2149         * Scripts/run-gtk-tests:
2150         (TestRunner): Skipping a failing unit test after r146518.
2151
2152 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2153
2154         Remove Lion leaks builder
2155         https://bugs.webkit.org/show_bug.cgi?id=113252
2156
2157         Reviewed by Andreas Kling.
2158
2159         Removed.
2160
2161         * BuildSlaveSupport/build.webkit.org-config/config.json:
2162
2163 2013-03-25  Kent Tamura  <tkent@chromium.org>
2164
2165         Rename ENABLE_INPUT_TYPE_DATETIME
2166         https://bugs.webkit.org/show_bug.cgi?id=113254
2167
2168         Reviewed by Kentaro Hara.
2169
2170         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2171         Actually I'd like to remove the code, but we shouldn't remove it yet
2172         because we shipped products with it on some platforms.
2173
2174         * Scripts/webkitperl/FeatureList.pm:
2175         * qmake/mkspecs/features/features.pri:
2176
2177 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2178
2179         Remove one more line that was intended to be removed in r146657.
2180
2181         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2182         (summarize_results):
2183
2184 2013-03-25  Roger Fong  <roger_fong@apple.com>
2185
2186         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2187         Re-enable WinEWS tests.
2188
2189         * Scripts/webkitpy/common/config/ports.py:
2190         (WinPort.run_bindings_tests_command):
2191         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2192         (WinEWS):
2193
2194 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2195
2196         Unreviewed, rolling out r146793.
2197         http://trac.webkit.org/changeset/146793
2198         https://bugs.webkit.org/show_bug.cgi?id=113248
2199
2200         Fix did not work (Requested by rfong on #webkit).
2201
2202         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2203         (WinEWS):
2204
2205 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2206
2207         REGRESSION(r146657): Test failures reported incorrectly
2208         https://bugs.webkit.org/show_bug.cgi?id=113223
2209
2210         Reviewed by Dirk Pranke.
2211
2212         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2213
2214         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2215         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2216
2217         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2218         (Manager.run):
2219
2220         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2221         (RunDetails.__init__):
2222         (summarize_results): Remove the line I intended to remove in r146657.
2223
2224         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2225         (logging_run): Return details instead of the exit code.
2226         (run_and_capture): Ditto.
2227
2228         (RunTest.test_full_results_html):
2229         (RunTest.test_hung_thread):
2230         (RunTest.test_no_tests_found):
2231         (RunTest.test_no_tests_found_2):
2232         (RunTest.test_repeat_each_iterations_num_tests):
2233         (RunTest.test_run_singly_actually_runs_tests):
2234         (RunTest.test_test_list):
2235         (RunTest.test_missing_and_unexpected_results):
2236         (RunTest.test_pixel_test_directories):
2237         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2238         (RunTest.test_crash_with_stderr):
2239         (RunTest.test_no_image_failure_with_image_diff):
2240         (RunTest.test_crash_log):
2241         (RunTest.test_exit_after_n_failures_upload):
2242         (RunTest.test_results_directory_absolute):
2243         (RunTest.test_results_directory_relative):
2244         (RunTest.test_retrying_and_flaky_tests):
2245         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2246         (RunTest.test_retrying_uses_retries_directory):
2247         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2248         (RunTest.test_output_diffs):
2249         (EndToEndTest.test_reftest_with_two_notrefs):
2250         (RebaselineTest.test_reset_results):
2251         (RebaselineTest.test_missing_results):
2252         (RebaselineTest.test_new_baseline):
2253
2254         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2255         (BuildBotPrinter.print_results):
2256         (BuildBotPrinter.print_unexpected_results):
2257         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2258         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2259
2260 2013-03-25  Julie Parent  <jparent@chromium.org>
2261
2262         Dashboard refactor: Move cross dashboard history related code into history.js.
2263         https://bugs.webkit.org/show_bug.cgi?id=113104
2264
2265         Reviewed by Ojan Vafai.
2266
2267         All functions relating to cross dashboard behavior move from being
2268         globals to methods on the history.History object. Names stay the same,
2269         except many are made private, ones that should have been constants now
2270         are, and the long standing TODO to change "currentState" to 
2271         dashboardSpecificState is done.
2272         
2273         We now create a global history object in dashboard_base, as an 
2274         intermediate measure.  Once the dashboard specific code is
2275         added to history, each DB will need to create its own, and this
2276         global will be eliminated.
2277         
2278         * TestResultServer/static-dashboards/aggregate_results.js:
2279         (handleValidHashParameter):
2280         (htmlForBuilder):
2281         (rawValuesHTML):
2282         * TestResultServer/static-dashboards/dashboard_base.js:
2283         (parseDashboardSpecificParameters):
2284         (defaultValue):
2285         (currentBuilderGroupCategory):
2286         (currentBuilderGroupName):
2287         (handleLocationChange):
2288         (expectationsMap):
2289         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2290         (generatePage):
2291         (.switch.return):
2292         (platformAndBuildType):
2293         (individualTests):
2294         (substringList):
2295         (processMissingAndExtraExpectations):
2296         (pathToFailureLog):
2297         (showPopupForBuild):
2298         (htmlForTestsWithExpectationsButNoFailures):
2299         (shouldHideTest):
2300         (isCrossBuilderView):
2301         (tableHeaders):
2302         (htmlForSingleTestRow):
2303         (htmlForTableColumnHeader):
2304         (generatePageForExpectationsUpdate):
2305         (handleUpdate):
2306         (nextUpdate):
2307         (setUpdateIndex):
2308         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2309         (.appendExpectationsItem):
2310         (loadExpectations):
2311         (.dummyNode.onload):
2312         (loadExpectationsLayoutTests):
2313         (appendExpectations):
2314         (htmlForNavBar):
2315         (checkBoxToToggleState):
2316         (linkHTMLToToggleState):
2317         (generatePageForBuilder):
2318         (isInvalidKeyForCrossBuilderView):
2319         (handleQueryParameterChange):
2320         (showLegend):
2321         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2322         (resetGlobals):
2323         (test):
2324         * TestResultServer/static-dashboards/history.js:
2325         (.):
2326         * TestResultServer/static-dashboards/history_unittests.js:
2327         * TestResultServer/static-dashboards/loader.js:
2328         (.):
2329         * TestResultServer/static-dashboards/loader_unittests.js:
2330         * TestResultServer/static-dashboards/timeline_explorer.js:
2331         (generatePage):
2332         (initCurrentBuilderTestResults):
2333         (selectBuild):
2334         (showResultsDelta):
2335         * TestResultServer/static-dashboards/treemap.js:
2336         (generatePage):
2337         (.switch.return):
2338         (handleFocus):
2339         * TestResultServer/static-dashboards/ui.js:
2340
2341 2013-03-25  Roger Fong  <roger_fong@apple.com>
2342
2343         Unreviewed. Enable WinEWS tests again.
2344
2345         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2346         (WinEWS):
2347
2348 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2349
2350         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2351         https://bugs.webkit.org/show_bug.cgi?id=112166
2352
2353         HarfBuzz 0.9.14 merged my patch for icu detection without
2354         pkg-config files, as needed by for example Ubuntu 12.04.
2355         This obsoletes our local workaround. Removed it for GTK and EFL.
2356
2357         Reviewed by Martin Robinson.
2358
2359         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2360         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2361         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2362         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2363
2364 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2365
2366         Unreviewed.  Move self from contributor to committer list.
2367
2368         * Scripts/webkitpy/common/config/committers.py:
2369
2370 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2371
2372         EWS should use a human readable port name when uploading layout test archives
2373         https://bugs.webkit.org/show_bug.cgi?id=113099
2374
2375         Reviewed by Dirk Pranke.
2376
2377         Use new port's object's name() method to report human readable port names.
2378         This will also help us resolving the bug to apply layout test results posted by EWS.
2379
2380         * Scripts/webkitpy/tool/bot/botinfo.py:
2381         (BotInfo.__init__): Take port's name.
2382         (BotInfo.summary_text):
2383
2384         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2385         (BotInfoTest.test_summary_text):
2386
2387         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2388         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2389
2390         * Scripts/webkitpy/tool/commands/queues.py:
2391         (PatchProcessingQueue.__init__): Initialize self._port.
2392         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2393         and use that for the attachment filename and the comment posted.
2394
2395         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2396         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2397         "mac-snowleopard" as expected for TestPort.
2398
2399 2013-03-22  Roger Fong  <roger_fong@apple.com>
2400
2401         Unreviewed. Turn off EWS test on Win again.
2402         The battle continues.
2403
2404         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2405         (WinEWS):
2406
2407 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2408
2409         NRWT: Enable pixel tests when retrying tests
2410         https://bugs.webkit.org/show_bug.cgi?id=112898
2411
2412         Reviewed by Dirk Pranke.
2413
2414         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2415         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2416         if we've forced pixel tests in the retry.
2417         (Manager._run_tests):
2418         (Manager._clean_up_run): Fixed the capitalizations.
2419         (Manager._force_pixel_tests_if_needed): Added.
2420
2421         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2422         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2423         'image_diff_percent' if it doesn't already exist.
2424
2425         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2426         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2427         treat this as a regular regression instead of a flakiness.
2428
2429         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2430         run had image diffs.
2431
2432         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2433         (summarized_results):
2434
2435         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2436         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2437         Also removed some dead code.
2438
2439         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2440         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2441         is set and pixel_tests_enabled is set to false.
2442         (EndToEndTest.test_reftest_with_two_notrefs):
2443
2444 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2445
2446         Make it possible to run layout tests on Retina MBP
2447         https://bugs.webkit.org/show_bug.cgi?id=93673
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2452         windows on 2x machines still run at 1x.
2453
2454         * DumpRenderTree/mac/DumpRenderTree.mm:
2455         (createWebViewAndOffscreenWindow):
2456         Reset the window resolution to 1x on creation.
2457         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2458         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2459         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2460         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2461         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2462         (WTR::PlatformWebView::PlatformWebView):
2463         Add NSWindow details, reset the window resolution to 1x on creation.
2464
2465 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2466
2467         Leak bots shouldn't build
2468         https://bugs.webkit.org/show_bug.cgi?id=112774
2469
2470         Reviewed by Simon Fraser.
2471
2472         Since leak bots use regular debug builds, there is no need to build on these bots.
2473         Simply downloading builds will dramatically improve the cycle time of these bots.
2474
2475         * BuildSlaveSupport/build.webkit.org-config/config.json:
2476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2477         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2478         TestFactory instead of BuildAndTestFactory.
2479
2480 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2481
2482         [Qt] Fix the TestWebKitAPI build
2483         https://bugs.webkit.org/show_bug.cgi?id=113044
2484
2485         Reviewed by Tor Arne Vestbø.
2486
2487         The generate-forwarding-headers script would only be run
2488         after the targets in InjectedBundle.pri since the second
2489         addStrictSubdirOrderBetween call in
2490         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2491         the derived_sources -> injected_bundle order in SUBDIRS.
2492
2493         Fix it by only moving the dependent target at the end of
2494         SUBDIRS, don't touch its dependency.
2495
2496         * qmake/mkspecs/features/functions.prf:
2497
2498 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2499
2500         [EFL][WK2] View is not focused when fullscreen mode toggled
2501         https://bugs.webkit.org/show_bug.cgi?id=113009
2502
2503         Reviewed by Laszlo Gombos.
2504
2505         Set focus on view when fullscreen mode enabled/disabled
2506         by FullScreen API.
2507
2508         * MiniBrowser/efl/main.c:
2509         (on_fullscreen_accept):
2510         (on_fullscreen_deny):
2511
2512 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2513
2514         nrwt is no longer saving retry results in the retries/ subdirectory
2515         https://bugs.webkit.org/show_bug.cgi?id=112995
2516
2517         Reviewed by Ojan Vafai.
2518
2519         I think this has been broken a long time, unfortunately. This
2520         patch should fix that.
2521
2522         In order to do so, I had to pass the directory to use from
2523         the Worker object through the SingleTestWriter to the
2524         TestResultWriter. While I was plumbing that through, I rationalized
2525         the order of the parameter arguments a bit ...
2526
2527         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2528         (Worker._run_single_test):
2529         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2530         (run_single_test):
2531         (SingleTestRunner.__init__):
2532         (SingleTestRunner._run_compare_test):
2533         (SingleTestRunner._run_rebaseline):
2534         (SingleTestRunner._run_reftest):
2535         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2536         (write_test_result):
2537         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2538         (TestResultWriterTest.test_reftest_diff_image):
2539         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2540         (RunTest.test_retrying_uses_retries_directory):
2541
2542 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2543
2544         JSC profiler should have an at-a-glance report of the success of DFG optimization
2545         https://bugs.webkit.org/show_bug.cgi?id=112988
2546
2547         Reviewed by Geoffrey Garen.
2548
2549         * Scripts/display-profiler-output:
2550
2551 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2552
2553         [chromium] Linux ASAN WebKit canary is running out of memory
2554         https://bugs.webkit.org/show_bug.cgi?id=112978
2555
2556         Reviewed by Tony Chang.
2557
2558         Running the AddressSanitizer on a crash takes a lot of
2559         memory, so we should serialize access to it to avoid running
2560         out of memory on a machine.
2561
2562         * Scripts/webkitpy/layout_tests/port/chromium.py:
2563         (ChromiumPort._get_crash_log):
2564         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2565         (HttpLock.__init__):
2566         (HttpLock.wait_for_httpd_lock):
2567
2568 2013-03-21  Min Qin  <qinmin@chromium.org>
2569
2570         Cleanup android media layout test code
2571         https://bugs.webkit.org/show_bug.cgi?id=112944
2572
2573         Reviewed by Adam Barth.
2574
2575         Chromium change: https://codereview.chromium.org/12892010/
2576         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2577         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2578         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2579         Instead, we should switch to use content shell for layout tests.
2580
2581         * DumpRenderTree/chromium/TestShell.cpp:
2582         (TestShell::resetTestController):
2583
2584 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2585
2586         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2587         https://bugs.webkit.org/show_bug.cgi?id=112953
2588
2589         Reviewed by Tony Chang.
2590
2591         When I created the DumpRenderTree_resources target in r144863 I
2592         forgot to declare the needed dependencies on the other resource
2593         targets. Due to a quirk of ordering, this appears to have been fine
2594         w/ ninja but not w/ Xcode (which is still being used on the chromium
2595         mac valgrind bots). Declaring the dependencies fixes the build
2596         failures.
2597
2598         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2599
2600 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2601
2602         [WinCairo] Correct assert in Empty BitmapImage Test.
2603         https://bugs.webkit.org/show_bug.cgi?id=112934
2604
2605         Reviewed by Tim Horton.
2606
2607         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2608         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2609         to avoid ref counting assertion when leaving test scope.
2610
2611 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2612
2613         [GTK] generate-feature-defines-files is incompatible with Python3
2614         https://bugs.webkit.org/show_bug.cgi?id=112956
2615
2616         Reviewed by Martin Robinson.
2617
2618         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2619         method on the dictionary objects when iterating through said dictionaries.
2620
2621         * gtk/generate-feature-defines-files:
2622         (write_feature_defines_header):
2623         (write_flattened_feature_defines_file):
2624
2625 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2626
2627         kill-old-processes spits out error messages on Mac
2628         https://bugs.webkit.org/show_bug.cgi?id=112878
2629
2630         Reviewed by Jessie Berlin.
2631
2632         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2633         included in the list of options grep --help shows.
2634
2635         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2636
2637         * BuildSlaveSupport/kill-old-processes:
2638         (main):
2639
2640 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2641
2642         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2643         https://bugs.webkit.org/show_bug.cgi?id=112597
2644
2645         Reviewed by Xan Lopez.
2646
2647         These were introduced for the Chromium port in r105295. We need
2648         dummy implementations in order to compile the BlackBerry port.
2649
2650         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2651         (AccessibilityUIElement::scrollToMakeVisible):
2652         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2653         (AccessibilityUIElement::scrollToGlobalPoint):
2654
2655 2013-03-21  Roger Fong  <roger_fong@apple.com>
2656
2657         Re-enable WinEWS tests following r146376.
2658
2659         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2660         (WinEWS):
2661
2662 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2663
2664         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2665
2666         * Scripts/webkitpy/common/config/committers.py:
2667
2668 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2669
2670         [GTK] Missing atk in install-dependencies script
2671         https://bugs.webkit.org/show_bug.cgi?id=112272
2672
2673         Reviewed by Gustavo Noronha Silva.
2674
2675         * gtk/install-dependencies: Add missing atk dependency.
2676
2677 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2678
2679         [GTK] Missing backslash in install-dependencies script
2680         https://bugs.webkit.org/show_bug.cgi?id=112907
2681
2682         Reviewed by Philippe Normand.
2683
2684         * gtk/install-dependencies: Add missing backslash to dependencies
2685         list.
2686
2687 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2688
2689         EWS bots have stopped uploading results to bugzilla
2690         https://bugs.webkit.org/show_bug.cgi?id=101091
2691
2692         Reviewed by Adam Barth.
2693
2694         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2695         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2696         this relative file path resoled to a file inside a non-existent directory for "zip".
2697
2698         Fixed the bug by resolving both test results directory and zip archive paths in
2699         LayoutTestResultsReader.archive.
2700
2701         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2702         in the future.
2703
2704         * Scripts/webkitpy/common/system/filesystem_mock.py:
2705         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2706
2707         * Scripts/webkitpy/common/system/workspace.py:
2708         (Workspace.create_zip): Log the source path when "zip" failed.
2709
2710         * Scripts/webkitpy/common/system/workspace_mock.py:
2711         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2712
2713         * Scripts/webkitpy/common/system/workspace_unittest.py:
2714         (WorkspaceTest.test_create_zip_exception): Test that.
2715
2716         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2717         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2718         This is the actual bug fix.
2719
2720         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2721         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2722
2723 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2724
2725         [chromium] move WebThemeEngine implementations to TestRunner library
2726         https://bugs.webkit.org/show_bug.cgi?id=112751
2727
2728         Reviewed by Adam Barth.
2729
2730         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2731         * DumpRenderTree/DumpRenderTree.gypi:
2732         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2733         (WebKit):
2734         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2735         (WebTestRunner::TestInterfaces::themeEngine):
2736         (WebTestRunner):
2737         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2738         (WebKit):
2739         (TestInterfaces):
2740         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2741         (WebTestRunner::WebTestInterfaces::themeEngine):
2742         (WebTestRunner):
2743         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2744         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2745         (WebTestRunner):
2746         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2747         (WebTestRunner::WebTestThemeControlWin::box):
2748         (WebTestRunner::WebTestThemeControlWin::line):
2749         (WebTestRunner::WebTestThemeControlWin::triangle):
2750         (WebTestRunner::WebTestThemeControlWin::roundRect):
2751         (WebTestRunner::WebTestThemeControlWin::oval):
2752         (WebTestRunner::WebTestThemeControlWin::circle):
2753         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2754         (WebTestRunner::WebTestThemeControlWin::markState):
2755         (WebTestRunner::WebTestThemeControlWin::draw):
2756         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2757         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2758         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2759         (WebTestRunner):
2760         (WebTestThemeControlWin):
2761         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2762         (WebTestRunner):
2763         (WebTestThemeEngineMac):
2764         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2765         (+[FakeActiveWindow alwaysActiveWindow]):
2766         (+[FakeActiveWindow alwaysInactiveWindow]):
2767         (-[FakeActiveWindow initWithActiveControls:]):
2768         (-[FakeActiveWindow _hasActiveControls]):
2769         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2770         (WebTestRunner):
2771         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2772         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2773         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2774         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2775         (WebTestRunner):
2776         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2777         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2778         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2779         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2780         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2781         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2782         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2783         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2784         (WebTestRunner::WebTestThemeEngineWin::getSize):
2785         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2786         (WebTestRunner):
2787         (WebTestThemeEngineWin):
2788         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2789         * DumpRenderTree/chromium/TestShell.cpp:
2790         (TestShell::initialize):
2791         * DumpRenderTree/chromium/TestShell.h:
2792         (WebKit):
2793         * DumpRenderTree/chromium/TestShellMac.mm:
2794         (platformInit):
2795         * DumpRenderTree/chromium/TestShellWin.cpp:
2796         (platformInit):
2797         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2798
2799 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2800
2801         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2802
2803         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2804         New property sheet that does not link against CoreFoundation and
2805         CFNetwork.
2806         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2807         Use new TestWebKitAPICommonWinCairo property sheet.
2808         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2809         Ditto.
2810
2811 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2812
2813         [WinCairo] Unreviewed build fix for VS2010.
2814
2815         Had to add WinCairo-specific property sheets to deal with some
2816         library and path differences with the main Apple port.
2817
2818         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2819         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2820         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2821         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2822         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2823         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2824
2825 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2826
2827         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2828         https://bugs.webkit.org/show_bug.cgi?id=112849
2829
2830         Reviewed by Sam Weinig.
2831
2832         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2833         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2834         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2835
2836 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2837
2838         [WinCairo] Build WebKit Tools under VS2010
2839         https://bugs.webkit.org/show_bug.cgi?id=112821
2840
2841         Reviewed by Tim Horton.
2842
2843         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2844         Add WinCairo-specific build target.
2845         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2846         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2847         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2848         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2849         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2850         Add WinCairo-specific build target.
2851         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2852         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2853         Add WinCairo-specific build target.
2854         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2855         WinCairo-specific build target.
2856         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2857         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2858         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2859         specific build target.
2860         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2861         WinCairo-specific build target.
2862         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2863         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2864         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2865
2866 2013-03-20  Roger Fong  <roger_fong@apple.com>
2867
2868         API test gardening AppleWin port.
2869
2870         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2871
2872         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2873         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2874
2875 2013-03-20  Roger Fong  <roger_fong@apple.com>
2876
2877         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2878
2879         * EWSTools/start-queue-win.sh:
2880
2881 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2882
2883         Unreviewed, add myself to committers.py.
2884
2885 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2886
2887         Unreviewed. Adding another email for me.
2888
2889         * Scripts/webkitpy/common/config/committers.py:
2890
2891 2013-03-20  Justin Novosad  <junov@google.com>
2892
2893         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2894         https://bugs.webkit.org/show_bug.cgi?id=112605
2895
2896         Reviewed by James Robinson.
2897
2898         Deleting all the code that was used for propagating and supporting
2899         the Chromium setting for disabling deferred 2d canvas rendering.
2900
2901         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2902         (main):
2903         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2904         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2905         (WebTestRunner::WebPreferences::reset):
2906         (WebTestRunner::WebPreferences::applyTo):
2907         * DumpRenderTree/chromium/TestShell.cpp:
2908         (TestShell::TestShell):
2909         (TestShell::resetWebSettings):
2910         (TestShell::runFileTest):
2911         * DumpRenderTree/chromium/TestShell.h:
2912         (TestShell):
2913
2914 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2915
2916         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2917         https://bugs.webkit.org/show_bug.cgi?id=112699.
2918
2919         Reviewed by Adam Barth.
2920
2921         * Scripts/webkitpy/layout_tests/port/qt.py:
2922         (QtPort._search_paths):
2923         (QtPort._port_specific_expectations_files):
2924         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2925         (QtPortTest):
2926         (QtPortTest._assert_search_path):
2927         (QtPortTest._assert_expectations_files):
2928
2929 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2930
2931         [Qt] Enable kerning by default
2932         https://bugs.webkit.org/show_bug.cgi?id=112704
2933
2934         Reviewed by Jocelyn Turcotte.
2935
2936         Disable kerning by default, since some reference test expectations
2937         expect kerning to be default off.
2938
2939         * DumpRenderTree/qt/TestRunnerQt.cpp:
2940         (TestRunnerQt::reset):
2941         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2942         (WTR::activateFonts):
2943
2944 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2945
2946         [Qt] Remove empty function stubs from TestRunnerQt.
2947         https://bugs.webkit.org/show_bug.cgi?id=112799
2948
2949         We are reducing the code in TestRunnerQt step by step,
2950         in order to finally replace all of it with the generic
2951         TestRunner implementation.
2952         This patch removes several simple function stubs that
2953         currently do not implement any actual functionality.
2954
2955         Reviewed by Kenneth Rohde Christiansen.
2956
2957         * DumpRenderTree/qt/TestRunnerQt.cpp:
2958         * DumpRenderTree/qt/TestRunnerQt.h:
2959         (TestRunnerQt):
2960
2961 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2962
2963         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2964         https://bugs.webkit.org/show_bug.cgi?id=112687
2965
2966         Reviewed by Kenneth Rohde Christiansen.
2967
2968         Hide the SearchBar by default on window creation.
2969
2970         * MiniBrowser/efl/main.c:
2971         (window_create):
2972
2973 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2974
2975         Unreviewed, rolling out r146304.
2976         http://trac.webkit.org/changeset/146304
2977         https://bugs.webkit.org/show_bug.cgi?id=112788
2978
2979         to many expectations to update (Requested by antonm on
2980         #webkit).
2981
2982         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2983         * DumpRenderTree/DumpRenderTree.gypi:
2984         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2985         (WebKit):
2986         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2987         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2988         (TestInterfaces):
2989         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2990         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2991         * DumpRenderTree/chromium/TestShell.cpp:
2992         (TestShell::initialize):
2993         * DumpRenderTree/chromium/TestShell.h:
2994         (WebKit):
2995         * DumpRenderTree/chromium/TestShellMac.mm:
2996         (platformInit):
2997         * DumpRenderTree/chromium/TestShellWin.cpp:
2998         (platformInit):
2999         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3000         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3001         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3002         (WebThemeControlDRTWin::box):
3003         (WebThemeControlDRTWin::line):
3004         (WebThemeControlDRTWin::triangle):
3005         (WebThemeControlDRTWin::roundRect):
3006         (WebThemeControlDRTWin::oval):
3007         (WebThemeControlDRTWin::circle):
3008         (WebThemeControlDRTWin::nestedBoxes):
3009         (WebThemeControlDRTWin::markState):
3010         (WebThemeControlDRTWin::draw):
3011         (WebThemeControlDRTWin::drawTextField):
3012         (WebThemeControlDRTWin::drawProgressBar):
3013         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3014         (WebThemeControlDRTWin):
3015         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3016         (WebThemeEngineDRTMac):
3017         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3018         (+[FakeActiveWindow alwaysActiveWindow]):
3019         (+[FakeActiveWindow alwaysInactiveWindow]):
3020         (-[FakeActiveWindow initWithActiveControls:]):
3021         (-[FakeActiveWindow _hasActiveControls]):
3022         (WebThemeEngineDRTMac::paintScrollbarThumb):
3023         (stateToHIEnableState):
3024         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3025         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3026         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3027         (webRectToSkIRect):
3028         (drawControl):
3029         (drawTextField):
3030         (drawProgressBar):
3031         (WebThemeEngineDRTWin::paintButton):
3032         (WebThemeEngineDRTWin::paintMenuList):
3033         (WebThemeEngineDRTWin::paintScrollbarArrow):
3034         (WebThemeEngineDRTWin::paintScrollbarThumb):
3035         (WebThemeEngineDRTWin::paintScrollbarTrack):
3036         (WebThemeEngineDRTWin::paintSpinButton):
3037         (WebThemeEngineDRTWin::paintTextField):
3038         (WebThemeEngineDRTWin::paintTrackbar):
3039         (WebThemeEngineDRTWin::paintProgressBar):
3040         (WebThemeEngineDRTWin::getSize):
3041         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3042         (WebThemeEngineDRTWin):
3043         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3044
3045 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3046
3047         [Qt] Support -webkit-font-smoothing
3048         https://bugs.webkit.org/show_bug.cgi?id=106009
3049
3050         Reviewed by Jocelyn Turcotte.
3051
3052         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
3053
3054         * DumpRenderTree/qt/TestRunnerQt.cpp:
3055         (TestRunnerQt::reset):
3056
3057 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3058
3059         [GTK] accessibility/aria-scrollbar-role.html is failing
3060         https://bugs.webkit.org/show_bug.cgi?id=98358
3061
3062         Reviewed by Martin Robinson.
3063
3064         Adds support for checking accessibility object's orientation.
3065         Orientation is checked by retrieving proper state of accessibility object.
3066
3067         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3068         (checkElementState):
3069         (AccessibilityUIElement::orientation):
3070         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3071         (WTR::AccessibilityUIElement::orientation):
3072
3073 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3074
3075         [chromium] move WebThemeEngine implementations to TestRunner library
3076         https://bugs.webkit.org/show_bug.cgi?id=112751
3077
3078         Reviewed by Adam Barth.
3079
3080         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3081         * DumpRenderTree/DumpRenderTree.gypi:
3082         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3083         (WebKit):
3084         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3085         (WebTestRunner::TestInterfaces::themeEngine):
3086         (WebTestRunner):
3087         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3088         (WebKit):
3089         (TestInterfaces):
3090         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3091         (WebTestRunner::WebTestInterfaces::themeEngine):
3092         (WebTestRunner):
3093         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3094         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3095         (WebTestRunner):
3096         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3097         (WebTestRunner::WebTestThemeControlWin::box):
3098         (WebTestRunner::WebTestThemeControlWin::line):
3099         (WebTestRunner::WebTestThemeControlWin::triangle):
3100         (WebTestRunner::WebTestThemeControlWin::roundRect):
3101         (WebTestRunner::WebTestThemeControlWin::oval):
3102         (WebTestRunner::WebTestThemeControlWin::circle):
3103         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3104         (WebTestRunner::WebTestThemeControlWin::markState):
3105         (WebTestRunner::WebTestThemeControlWin::draw):
3106         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3107         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3108         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3109         (WebTestRunner):
3110         (WebTestThemeControlWin):
3111         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3112         (WebTestRunner):
3113         (WebTestThemeEngineMac):
3114         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3115         (+[FakeActiveWindow alwaysActiveWindow]):
3116         (+[FakeActiveWindow alwaysInactiveWindow]):
3117         (-[FakeActiveWindow initWithActiveControls:]):
3118         (-[FakeActiveWindow _hasActiveControls]):
3119         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3120         (WebTestRunner):
3121         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3122         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3123         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3124         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3125         (WebTestRunner):
3126         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3127         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3128         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3129         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3130         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3131         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3132         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3133         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3134         (WebTestRunner::WebTestThemeEngineWin::getSize):
3135         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3136         (WebTestRunner):
3137         (WebTestThemeEngineWin):
3138         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3139         * DumpRenderTree/chromium/TestShell.cpp:
3140         (TestShell::initialize):
3141         * DumpRenderTree/chromium/TestShell.h:
3142         (WebKit):
3143         * DumpRenderTree/chromium/TestShellMac.mm:
3144         (platformInit):
3145         * DumpRenderTree/chromium/TestShellWin.cpp:
3146         (platformInit):
3147         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3148
3149 2013-03-19  Tony Chang  <tony@chromium.org>
3150
3151         Move testRunner.setTouchDragDropEnabled to internals.settings
3152         https://bugs.webkit.org/show_bug.cgi?id=112739
3153
3154         Reviewed by Adam Barth.
3155
3156         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3157         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3158         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3159         (TestRunner): Remove unnecessary code.
3160         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3161         (WebTestRunner::WebPreferences::reset):
3162         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3163
3164 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3165
3166         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3167         https://bugs.webkit.org/show_bug.cgi?id=112754
3168
3169         Reviewed by Darin Fisher.
3170
3171         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3172         now that it's always defined.
3173
3174         * DumpRenderTree/chromium/WebViewHost.cpp:
3175         * DumpRenderTree/chromium/WebViewHost.h:
3176         (WebViewHost):
3177
3178 2013-03-19  Kenneth Russell  <kbr@google.com>
3179
3180         Unreviewed, rolling out r146290.
3181         http://trac.webkit.org/changeset/146290
3182         https://bugs.webkit.org/show_bug.cgi?id=112751
3183
3184         Broke Chromium Mac build.
3185
3186         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3187         * DumpRenderTree/DumpRenderTree.gypi:
3188         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3189         (WebKit):
3190         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3191         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3192         (TestInterfaces):
3193         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3194         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3195         * DumpRenderTree/chromium/TestShell.cpp:
3196         (TestShell::initialize):
3197         * DumpRenderTree/chromium/TestShell.h:
3198         (WebKit):
3199         * DumpRenderTree/chromium/TestShellMac.mm:
3200         (platformInit):
3201         * DumpRenderTree/chromium/TestShellWin.cpp:
3202         (platformInit):
3203         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3204         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3205         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3206         (WebThemeControlDRTWin::box):
3207         (WebThemeControlDRTWin::line):
3208         (WebThemeControlDRTWin::triangle):
3209         (WebThemeControlDRTWin::roundRect):
3210         (WebThemeControlDRTWin::oval):
3211         (WebThemeControlDRTWin::circle):
3212         (WebThemeControlDRTWin::nestedBoxes):
3213         (WebThemeControlDRTWin::markState):
3214         (WebThemeControlDRTWin::draw):
3215         (WebThemeControlDRTWin::drawTextField):
3216         (WebThemeControlDRTWin::drawProgressBar):
3217         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3218         (WebThemeControlDRTWin):
3219         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3220         (WebThemeEngineDRTMac):
3221         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3222         (+[FakeActiveWindow alwaysActiveWindow]):
3223         (+[FakeActiveWindow alwaysInactiveWindow]):
3224         (-[FakeActiveWindow initWithActiveControls:]):
3225         (-[FakeActiveWindow _hasActiveControls]):
3226         (WebThemeEngineDRTMac::paintScrollbarThumb):
3227         (stateToHIEnableState):
3228         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3229         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3230         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3231         (webRectToSkIRect):
3232         (drawControl):
3233         (drawTextField):
3234         (drawProgressBar):
3235         (WebThemeEngineDRTWin::paintButton):
3236         (WebThemeEngineDRTWin::paintMenuList):
3237         (WebThemeEngineDRTWin::paintScrollbarArrow):
3238         (WebThemeEngineDRTWin::paintScrollbarThumb):
3239         (WebThemeEngineDRTWin::paintScrollbarTrack):
3240         (WebThemeEngineDRTWin::paintSpinButton):
3241         (WebThemeEngineDRTWin::paintTextField):
3242         (WebThemeEngineDRTWin::paintTrackbar):
3243         (WebThemeEngineDRTWin::paintProgressBar):
3244         (WebThemeEngineDRTWin::getSize):
3245         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3246         (WebThemeEngineDRTWin):
3247         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3248
3249 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3250
3251         [EFL] canvas-fallback-content.html is failing
3252         https://bugs.webkit.org/show_bug.cgi?id=111998
3253
3254         Reviewed by Chris Fleizach.
3255
3256         Adds support for getting platform name.
3257
3258         * DumpRenderTree/TestRunner.cpp:
3259         (TestRunner::staticValues):
3260         * DumpRenderTree/TestRunner.h:
3261         (TestRunner):
3262         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3263         (TestRunner::platformName):
3264
3265 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3266
3267         [chromium] move WebThemeEngine implementations to TestRunner library
3268         https://bugs.webkit.org/show_bug.cgi?id=112751
3269
3270         Reviewed by Adam Barth.
3271
3272         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3273         * DumpRenderTree/DumpRenderTree.gypi:
3274         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3275         (WebKit):
3276         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3277         (WebTestRunner::TestInterfaces::themeEngine):
3278         (WebTestRunner):
3279         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3280         (WebKit):
3281         (TestInterfaces):
3282         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3283         (WebTestRunner::WebTestInterfaces::themeEngine):
3284         (WebTestRunner):
3285         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3286         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3287         (WebTestRunner):
3288         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3289         (WebTestRunner::WebTestThemeControlWin::box):
3290         (WebTestRunner::WebTestThemeControlWin::line):
3291         (WebTestRunner::WebTestThemeControlWin::triangle):
3292         (WebTestRunner::WebTestThemeControlWin::roundRect):
3293         (WebTestRunner::WebTestThemeControlWin::oval):
3294         (WebTestRunner::WebTestThemeControlWin::circle):
3295         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3296         (WebTestRunner::WebTestThemeControlWin::markState):
3297         (WebTestRunner::WebTestThemeControlWin::draw):
3298         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3299         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3300         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3301         (WebTestRunner):
3302         (WebTestThemeControlWin):
3303         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3304         (WebTestRunner):
3305         (WebTestThemeEngineMac):
3306         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3307         (+[FakeActiveWindow alwaysActiveWindow]):
3308         (+[FakeActiveWindow alwaysInactiveWindow]):
3309         (-[FakeActiveWindow initWithActiveControls:]):
3310         (-[FakeActiveWindow _hasActiveControls]):
3311         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3312         (WebTestRunner):
3313         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3314         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3315         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3316         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3317         (WebTestRunner):
3318         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3319         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3320         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3321         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3322         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3323         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3324         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3325         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3326         (WebTestRunner::WebTestThemeEngineWin::getSize):
3327         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3328         (WebTestRunner):
3329         (WebTestThemeEngineWin):
3330         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3331         * DumpRenderTree/chromium/TestShell.cpp:
3332         (TestShell::initialize):
3333         * DumpRenderTree/chromium/TestShell.h:
3334         (WebKit):
3335         * DumpRenderTree/chromium/TestShellMac.mm:
3336         (platformInit):
3337         * DumpRenderTree/chromium/TestShellWin.cpp:
3338         (platformInit):
3339         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3340
3341 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3342
3343         [EFL][WK2] Separate WebView further from EwkView
3344         https://bugs.webkit.org/show_bug.cgi?id=111591
3345
3346         Reviewed by Caio Marcelo de Oliveira Filho.
3347
3348         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3349         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3350         since we can afford it having EWKViewGetWKView() private API to access WKView.
3351
3352         * TestWebKitAPI/PlatformWebView.h:
3353         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3354         (TestWebKitAPI::TEST):
3355         * TestWebKitAPI/efl/PlatformWebView.cpp:
3356         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3357         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3358         (TestWebKitAPI::PlatformWebView::resizeTo):
3359         (TestWebKitAPI::PlatformWebView::page):
3360         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3361         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3362         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3363         * WebKitTestRunner/PlatformWebView.h:
3364         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3365         (WTR::EventSenderProxy::dispatchEvent):
3366         (WTR::EventSenderProxy::keyDown):
3367         (WTR::EventSenderProxy::sendTouchEvent):
3368         (WTR::EventSenderProxy::setTouchModifier):
3369         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3370         (WTR::PlatformWebView::PlatformWebView):
3371         (WTR::PlatformWebView::~PlatformWebView):
3372         (WTR::PlatformWebView::resizeTo):
3373         (WTR::PlatformWebView::page):
3374         (WTR::PlatformWebView::focus):
3375         (WTR::PlatformWebView::windowSnapshotImage):
3376
3377 2013-03-19  Roger Fong  <roger_fong@apple.com>
3378
3379         Changes to VS2010 project files should only trigger builds on Windows bots.
3380         https://bugs.webkit.org/show_bug.cgi?id=112731
3381
3382         Reviewed by Timothy Horton.
3383
3384         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3385         (_should_file_trigger_build):
3386
3387 2013-03-19  Roger Fong  <roger_fong@apple.com>
3388
3389         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3390
3391         * Scripts/webkitpy/tool/steps/runtests.py:
3392         (RunTests.run):
3393         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3394         (RunTestsTest.test_webkit_run_unit_tests):
3395
3396 2013-03-19  Julie Parent  <jparent@chromium.org>
3397
3398         Dashboards: Introduce history namespace and unit tests.
3399         https://bugs.webkit.org/show_bug.cgi?id=112645
3400
3401         Reviewed by Ojan Vafai.
3402         
3403         Laying the framework for introducing the new history object and
3404         namespace.  This moves only static functions into the history
3405         namespace, and moves corresponding unit tests into seperate
3406         unit test file.
3407
3408         * TestResultServer/static-dashboards/aggregate_results.html:
3409         * TestResultServer/static-dashboards/dashboard_base.js:
3410         (parseCrossDashboardParameters):
3411         (parseDashboardSpecificParameters):
3412         (parseParameters):
3413         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3414         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3415         (.switch.return):
3416         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3417         * TestResultServer/static-dashboards/history.js: Added.
3418         * TestResultServer/static-dashboards/history_unittests.js: Added.
3419         * TestResultServer/static-dashboards/loader.js:
3420         (.):
3421         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3422         * TestResultServer/static-dashboards/run-unittests.html:
3423         * TestResultServer/static-dashboards/timeline_explorer.html:
3424         * TestResultServer/static-dashboards/timeline_explorer.js:
3425         * TestResultServer/static-dashboards/treemap.html:
3426         * TestResultServer/static-dashboards/treemap.js:
3427         (.switch.return):
3428         * TestResultServer/static-dashboards/ui.js:
3429
3430 2013-03-19  Daniel Bates  <dbates@webkit.org>
3431
3432         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3433         https://bugs.webkit.org/show_bug.cgi?id=112732
3434
3435         Reviewed by Eric Seidel.
3436
3437         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3438         of an existing file cannot be applied.
3439
3440         In particular, svn-{apply, unapply} compensate for differences in line endings
3441         by converting the line endings in a diff to match the line endings in the target
3442         file. The diff(1) command precedes the last line of a diff that adds a newline
3443         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3444         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3445         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3446         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3447         the newline characters in this special character sequence to match the line endings
3448         in the target file.
3449
3450         * Scripts/VCSUtils.pm:
3451         (parseDiff):
3452         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3453         Added tests:
3454             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3455             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3456             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3457             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3458         (escapeNewLineCharacters): Added.
3459         (toMacLineEndings): Added.
3460
3461 2013-03-19  James Robinson  <jamesr@chromium.org>
3462
3463         [chromium] Remove compositor settings that don't go through WebKit
3464         https://bugs.webkit.org/show_bug.cgi?id=112718
3465
3466         Reviewed by Adam Barth.
3467
3468         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3469         (main):
3470         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3471         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3472         (WebTestRunner::WebPreferences::reset):
3473         (WebTestRunner::WebPreferences::applyTo):
3474         * DumpRenderTree/chromium/TestShell.cpp:
3475         (TestShell::TestShell):
3476         (TestShell::resetWebSettings):
3477         * DumpRenderTree/chromium/TestShell.h:
3478         (TestShell):
3479
3480 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3481
3482         Unreviewed, rolling out r146101.
3483         https://bugs.webkit.org/show_bug.cgi?id=111884
3484
3485         re-enable custom freetype on asan; this needs to be on
3486         now that the bot is running lucid.
3487
3488         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3489
3490 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3491
3492         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3493         https://bugs.webkit.org/show_bug.cgi?id=112365
3494
3495         Reviewed by Benjamin Poulain.
3496
3497         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3498         harcoding it in wtf/Platform.h
3499
3500         * Scripts/webkitperl/FeatureList.pm:
3501
3502 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3503
3504         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3505         https://bugs.webkit.org/show_bug.cgi?id=94782
3506
3507         Based on patch by Csaba Osztrogonác.
3508         Reviewed by Jocelyn Turcotte.
3509
3510         The diff image is generated with bright red indicating errors, but letting the base image
3511         shine through so the context of the error-pixel can be identified.
3512
3513         * DumpRenderTree/qt/ImageDiff.cpp:
3514         (main):
3515
3516 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3517
3518         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3519
3520         Rubber-stamped by Csaba Osztrogonác.
3521
3522         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3523         since the latter might not cover the former.
3524
3525         * QtTestBrowser/launcherwindow.cpp:
3526         (LauncherWindow::print):
3527
3528 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3529
3530         Style tweeks to default.css.
3531         
3532         Rubber-stamped by David Kilzer.
3533         
3534         Give visited links a different color to other links, so you can
3535         see which builds you've viewed.
3536         
3537         Make the <small> text less tiny.
3538
3539         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3540         (small):
3541         (a:link,a:visited,a:active):
3542         (a:visited):
3543
3544 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3545
3546         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3547         https://bugs.webkit.org/show_bug.cgi?id=112494
3548
3549         Reviewed by Dirk Pranke.
3550
3551         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3552         Also merged two pairs of methods to cleanup the code.
3553
3554         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3555         (PerfTestsRunner.run): Merged _upload_and_show_results.
3556         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3557
3558 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3559
3560         [chromium] build xdisplaycheck when building DRT
3561         https://bugs.webkit.org/show_bug.cgi?id=112636
3562
3563         Reviewed by Tony Chang.
3564
3565         It appears that we need xdisplaycheck to be built in order for
3566         Xvfb to be started correctly on the bots, and DRT was missing
3567         a dependency on it. This may be the cause of the ASAN bot not
3568         starting up properly (it only builds DRT).
3569
3570         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3571
3572 2013-03-18  David Levin  <levin@chromium.org>
3573
3574         Implement icon change notification dump for Chromium's test shell.
3575         https://bugs.webkit.org/show_bug.cgi?id=112614
3576
3577         This was previously implemented for some other platforms in r58111
3578         and r116547.
3579
3580         In r122806, fast/dom/icon-url-property.html stopped using it, but
3581         it is useful for tests, so I plan to re-add it to that test again.
3582
3583         Reviewed by Jochen Eisinger.
3584
3585         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3586         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3587          icon change notifications from WebKit may be logged in test output.
3588         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3589         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3590         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3591         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3592         (WebTestRunner):
3593         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3594         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3595         (TestRunner):
3596         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3597         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3598         (WebTestRunner):
3599         * DumpRenderTree/chromium/WebViewHost.cpp:
3600         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3601         * DumpRenderTree/chromium/WebViewHost.h:
3602         (WebViewHost):
3603
3604 2013-03-18  Julie Parent  <jparent@chromium.org>
3605
3606         Cleanup: Move js for treemap and aggregate_results into own js files.
3607         https://bugs.webkit.org/show_bug.cgi?id=112618
3608
3609         Reviewed by Dirk Pranke.
3610         
3611         No functional changes, just moving the code into separate js file
3612         rather than inlined in the html, so we can test it, make it more
3613         modular, etc.  Other dashboard types are already done this way.
3614
3615         * TestResultServer/static-dashboards/aggregate_results.html:
3616         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3617         (generatePage):
3618         (handleValidHashParameter):
3619         (htmlForBuilder):
3620         (rawValuesHTML):
3621         (chartHTML):
3622         (filteredValues):
3623         (chart):
3624         (htmlForRevisionRows):
3625         (wrapHTMLInTable):
3626         (htmlForSummaryTable):
3627         (valuesPerExpectation):
3628         (htmlForTestType):
3629         (htmlForTableRow):
3630         (extendedEncode):
3631         * TestResultServer/static-dashboards/treemap.html:
3632         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3633         (humanReadableTime):
3634         (convertToWebTreemapFormat):
3635         (reverseSortByAverage):
3636         (generatePage):
3637         (focusPath):
3638         (.switch.return):
3639         (handleQueryParameterChange):
3640         (extractName):
3641         (fullName):
3642         (handleFocus.):
3643         (handleFocus):
3644
3645 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3646
3647         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3648         https://bugs.webkit.org/show_bug.cgi?id=112622
3649
3650         Reviewed by Dirk Pranke.
3651
3652         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3653         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3654
3655 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>