DRT/WTR python interface handles about:blank incorrectly
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
2
3         DRT/WTR python interface handles about:blank incorrectly
4         https://bugs.webkit.org/show_bug.cgi?id=89563
5
6         Reviewed by Dirk Pranke.
7
8         Currently DRT/WTR python interface's _command_from_driver_input function
9         puts the test directory path before about:blank. Remove this incorrect behavior.
10
11         * Scripts/webkitpy/layout_tests/port/webkit.py:
12         (WebKitDriver._command_from_driver_input):
13
14 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
15
16         reenable perf tests on win
17         https://bugs.webkit.org/show_bug.cgi?id=89690
18
19         Reviewed by Ryosuke Niwa.
20
21         Only the replay tests don't work, and those are disabled by
22         default. This change also fixes the undefined _log reference
23         that was causing a crash.
24
25         * Scripts/run-perf-tests:
26
27 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
28
29         Unreviewed, rolling out r120937.
30         http://trac.webkit.org/changeset/120937
31         https://bugs.webkit.org/show_bug.cgi?id=89679
32
33         This patch brought buildbot master down (Requested by svillar
34         on #webkit).
35
36         * BuildSlaveSupport/build.webkit.org-config/config.json:
37
38 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
39
40         [GTK] Combine WebKit API tests into fewer binaries
41         https://bugs.webkit.org/show_bug.cgi?id=88458
42
43         Reviewed by Carlos Garcia Campos.
44
45         Instead of creating one binary per-test file, create binaries for each
46         category of tests. Right now this includes WTF and the WebKit2 C API,
47         but later tests can be added for the GTK+ platform layer and the WebKit1
48         and WebKit2 API layers.
49
50         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
51           C API and one for WTF. Refresh the source list to ensure that new test are active.
52         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
53         concept of skipping a test and skipping a suite (program) of tests. Test cases are
54         skipped because of legitimate failures, but entire programs are skipped because of
55         problems in the harness. As of right now a test program is only skipped if the
56         accessibility bus cannot be started.
57         (SkippedTest.__init__): Make the test case a required argument and have one skipped
58         test case per SkippedTest instance.
59         (SkippedTest.__str__): Ditto.
60         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
61         in one directory. Reformat the test list to make it slightly easier to read.
62         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
63         test programs that are skipped.
64         (TestRunner._setup_testing_environment): Use the new member.
65         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
66         the first SkippedTest that matches.
67         (TestRunner._should_run_test_program): Take a look at the new member to make this
68         decision.
69         (TestRunner._run_test_command): Use the name test_program instead of test
70         to disambiguate between test cases and test suites.
71         (TestRunner._run_test_glib): ditto.
72         (TestRunner._run_test_google): Ditto.
73         (TestRunner._run_test): Ditto.
74         (TestRunner.run_tests): Ditto.
75
76 2012-06-21  Yong Li  <yoli@rim.com>
77
78         Unreviewed. Moving myself from committer to reviewer.
79
80         * Scripts/webkitpy/common/config/committers.py:
81
82 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
83
84         [GTK] Add a new webkit2 tests slave bot
85         https://bugs.webkit.org/show_bug.cgi?id=89336
86
87         Reviewed by Philippe Normand.
88
89         Slave configuration for a new GTK bot that will run WebKit2 tests.
90
91         * BuildSlaveSupport/build.webkit.org-config/config.json:
92
93 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
94
95         [Qt] Add a custom Color Chooser widget to MiniBrowser
96         https://bugs.webkit.org/show_bug.cgi?id=87988
97
98         Reviewed by Alexis Menard.
99
100         Added custom color chooser example for the MiniBrowser.
101
102         * MiniBrowser/qt/MiniBrowser.qrc:
103         * MiniBrowser/qt/qml/BrowserWindow.qml:
104         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
105
106 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
107
108         Remove the warning "File not found" in MiniBrowser post-build event
109         https://bugs.webkit.org/show_bug.cgi?id=89601
110
111         Reviewed by Adam Roben.
112
113         * MiniBrowser/MiniBrowserPostBuild.cmd:
114
115 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
116
117         [Qt] DRT in standalone mode hangs after the first test
118         https://bugs.webkit.org/show_bug.cgi?id=89613
119
120         Reviewed by Csaba Osztrogonác.
121
122         Break an inline signal slot chain that ends up in setting
123         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
124         we emit done() which starts the chain that finishes in DumpRenderTree::open().
125         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
126         these two lines but it seems to be wrong in general to start the next load
127         from this call chain. The server mode (when DRT is runned by the test harness)
128         also uses a queued connection to read the next test from stdin.
129
130         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
131         (WebCore::DumpRenderTree::processArgsLine):
132
133 2012-06-20  Hans Wennborg  <hans@chromium.org>
134
135         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
136         https://bugs.webkit.org/show_bug.cgi?id=89217
137
138         Reviewed by Adam Barth.
139
140         Add a method for checking whether the mock speech
141         recognition was aborted.
142
143         Also redo the way the mock posts tasks. Instead of posting them all at once,
144         maintain an internal queue of task objects, and call postTask() for them
145         once at the time. This means that for example when the page is navigated
146         away and abort() is called, that call doesn't end up after a bunch
147         of previously posted events on the event loop.
148
149         * DumpRenderTree/chromium/LayoutTestController.cpp:
150         (LayoutTestController::LayoutTestController):
151         (LayoutTestController::wasMockSpeechRecognitionAborted):
152         * DumpRenderTree/chromium/LayoutTestController.h:
153         (LayoutTestController):
154         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
155         (WebKit::ClientCallTask::ClientCallTask):
156         (WebKit::ResultTask::ResultTask):
157         (WebKit::NoMatchTask::NoMatchTask):
158         (WebKit::ErrorTask::ErrorTask):
159         (MockWebSpeechRecognizer::start):
160         (MockWebSpeechRecognizer::abort):
161         (MockWebSpeechRecognizer::setError):
162         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
163         (MockWebSpeechRecognizer::startTaskQueue):
164         (MockWebSpeechRecognizer::StepTask::runIfValid):
165         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
166         (MockWebSpeechRecognizer::hasBeenAborted):
167         (MockWebSpeechRecognizer):
168         (MockWebSpeechRecognizer::taskList):
169         (Task):
170         (MockWebSpeechRecognizer::Task::Task):
171         (MockWebSpeechRecognizer::Task::~Task):
172         (StepTask):
173         (MockWebSpeechRecognizer::StepTask::StepTask):
174
175 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
176
177         [GTK] Add support for window.showModalDialog in WebKit2GTK+
178         https://bugs.webkit.org/show_bug.cgi?id=79500
179
180         Reviewed by Carlos Garcia Campos.
181
182         Add support for modal dialogs in GTK's MiniBrowser.
183
184         * MiniBrowser/gtk/BrowserWindow.c:
185         (webViewRunAsModal):
186         (webViewCreate):
187         (webViewDecidePolicy):
188         (browser_window_new):
189         * MiniBrowser/gtk/BrowserWindow.h:
190         * MiniBrowser/gtk/main.c:
191         (createBrowserWindow):
192
193 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
194
195         [WinCairo] Unreviewed build fix.
196         The wrapper script that launched new- and old-run-webkit-tests
197         was discarding the --wincairo argument needed to get the proper
198         test infrastructure to build under WinCairo.
199
200         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
201         behavior to chain the --wincairo flag through to the new build
202         and test scripts.
203
204 2012-06-20  Mark Rowe  <mrowe@apple.com>
205
206         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
207
208         Reviewed by Dan Bernstein.
209
210         * Scripts/webkitdirs.pm:
211         (executableHasEntitlements):
212         (safariPathFromSafariBundle):
213
214 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
215
216         Unreviewed, rolling out r120821.
217         http://trac.webkit.org/changeset/120821
218         https://bugs.webkit.org/show_bug.cgi?id=89605
219
220         It made duplicated reviewer entries (Requested by Ossy on
221         #webkit).
222
223         * Scripts/webkitpy/common/checkout/changelog.py:
224         (ChangeLog.set_reviewer):
225         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
226         (test_set_reviewer):
227         (test_set_short_description_and_bug_url):
228
229 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
230
231         nrwt outputs empty files for wdiff output if wdiff is not installed
232         https://bugs.webkit.org/show_bug.cgi?id=88709
233
234         Reviewed by Tony Chang.
235
236         Reviewed by Tony Chang.
237
238         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
239         aren't available, and clean up the handling for them in the port
240         code.
241
242         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
243         (MainTest.test_output_diffs):
244         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
245         (TestResultWriter.create_text_diff_and_write_result):
246         * Scripts/webkitpy/layout_tests/port/base.py:
247         (Port.check_pretty_patch):
248         (Port.check_wdiff):
249         (Port._wdiff_missing_message):
250         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
251         (ChromiumLinuxPort.check_build):
252         (ChromiumLinuxPort._wdiff_missing_message):
253         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
254         (ChromiumMacPort.check_build):
255         (ChromiumMacPort):
256         (ChromiumMacPort._wdiff_missing_message):
257         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
258         (ChromiumMacPortTest):
259
260 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
261
262         nrwt: fix unit tests for ensuring svn revision is correct
263         https://bugs.webkit.org/show_bug.cgi?id=89498
264
265         Reviewed by Eric Seidel.
266
267         Reviewed by Eric Seidel.
268
269         Fix the unit tests for testing that we are embedding the SVN
270         revision in the results json for NRWT properly; this was broken
271         in r120646 but because the MockHost worked differently than the
272         real one (by always initializing the MockSCM object) we didn't
273         notice. Unfortunately, just changing the default breaks all
274         sorts of unit tests ...
275
276         * Scripts/webkitpy/common/host_mock.py:
277         (MockHost.__init__):
278         (MockHost._initialize_scm):
279         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
280         (ResultSummaryTest.test_no_svn_revision):
281         (ResultSummaryTest.test_svn_revision):
282
283 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
284
285         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
286         https://bugs.webkit.org/show_bug.cgi?id=69360
287
288         Reviewed by Eric Seidel.
289
290         Reviewed by Eric Seidel.
291
292         Propagate the 'port_implementation' part of the platform (i.e.,
293         gtk,qt,chromium) to webkit-build-directory so that we can pick
294         up the gtk-specific handling of WEBKITOUTPUTDIR ...
295
296         I didn't write any additional tests for this; testing it
297         properly is an integration test between the python code and the
298         perl code, which I verified by hand.
299
300         * Scripts/webkitpy/layout_tests/port/base.py:
301         (Port.__init__):
302         * Scripts/webkitpy/layout_tests/port/config.py:
303         (Config.__init__):
304         (Config.build_directory):
305         * Scripts/webkitpy/layout_tests/port/config_mock.py:
306         (MockConfig.__init__):
307         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
308         (ConfigTest.test_build_directory_passes_port_implementation):
309
310 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
311
312         Fix import sorting missed in r120846
313
314         Reviewed by Tony Chang.
315
316         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
317
318 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
319
320         Fix chromium win http servers after breakage introduced in r120846.
321
322         Unreviewed, build fix.
323
324         * Scripts/webkitpy/layout_tests/port/base.py:
325         (Port.to.start_http_server):
326         * Scripts/webkitpy/layout_tests/servers/http_server.py:
327         (Lighttpd.__init__):
328
329 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
330
331         tweak output of webkit-patch print-{baselines,expectations}
332         https://bugs.webkit.org/show_bug.cgi?id=89588
333
334         Reviewed by Tony Chang.
335
336         Minor tweaks to the output to make it more readable, including
337         turning off csv by default for print-baselines with multiple ports.
338
339         * Scripts/webkitpy/layout_tests/port/test.py:
340         (TestPort):
341         * Scripts/webkitpy/tool/commands/queries.py:
342         (PrintExpectations.execute):
343         (PrintBaselines.execute):
344         * Scripts/webkitpy/tool/commands/queries_unittest.py:
345         (PrintExpectationsTest.run_test):
346         (PrintExpectationsTest.test_multiple):
347         (PrintBaselinesTest.setUp):
348         (PrintBaselinesTest.test_multiple):
349
350 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
351
352         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
353         https://bugs.webkit.org/show_bug.cgi?id=88134
354
355         Reviewed by Tony Chang.
356
357         Change NRWT to spin up 2*min(child_processes, locked_shards)
358         http servers by default so that we are less likely to get a
359         bunch of http timeouts at the beginning of a test run.
360
361         Note that I had to tweak executive_mock to support mocked stderr
362         because the apache_http_server code reads stderr when starting a
363         process to ensure it started okay.
364
365         * Scripts/webkitpy/common/system/executive_mock.py:
366         (MockProcess.__init__):
367         * Scripts/webkitpy/common/system/outputcapture.py:
368         * Scripts/webkitpy/layout_tests/controllers/manager.py:
369         (Manager._run_tests):
370         (Manager.start_servers_with_lock):
371         * Scripts/webkitpy/layout_tests/port/base.py:
372         (Port.to.start_http_server):
373         * Scripts/webkitpy/layout_tests/port/test.py:
374         (TestPort.start_http_server):
375         (TestPort._path_to_apache):
376         (TestPort):
377         (TestPort._path_to_apache_config_file):
378         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
379         (LayoutTestApacheHttpd.__init__):
380         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
381         (LayoutTestApacheHttpd.__init__):
382         * Scripts/webkitpy/layout_tests/servers/http_server.py:
383         (Lighttpd.__init__):
384         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
385         (HttpServerBase.__init__):
386
387 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
388
389         Unreviewed: Back out accidentally checked in debug print which broke a test
390
391         * Scripts/webkitpy/performance_tests/perftest.py:
392         (PerfTest.parse_output):
393
394 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
395
396         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
397         https://bugs.webkit.org/show_bug.cgi?id=78789
398
399         Reviewed by Ryosuke Niwa.
400
401         Updated parser to include fps as a valid unit.
402
403         * Scripts/webkitpy/performance_tests/perftest.py:
404         (PerfTest):
405         (PerfTest.parse_output):
406
407 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
408
409         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
410         https://bugs.webkit.org/show_bug.cgi?id=67935
411
412         Reviewed by Ryosuke Niwa.
413
414         * Scripts/webkitpy/common/checkout/changelog.py:
415         (ChangeLog.set_reviewer):
416         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
417         (test_set_reviewer):
418         (test_set_short_description_and_bug_url):
419
420 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
421
422         Unreviewed trivial permissions fix.
423
424         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
425
426 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
427
428         [EFL][Regression] Build break after r120786
429         https://bugs.webkit.org/show_bug.cgi?id=89549
430
431         Unreviewed build fix for Efl port.
432
433         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
434
435 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
436
437         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
438         https://bugs.webkit.org/show_bug.cgi?id=64489
439
440         Reviewed by Tony Chang.
441
442         This change changes NRWT so that we don't start the websocket
443         server if we aren't running websocket tests and don't start the
444         HTTP server if we aren't running http tests.
445         
446         * Scripts/webkitpy/layout_tests/controllers/manager.py:
447         (Manager._websocket_tests):
448         (Manager.start_servers_with_lock):
449         (Manager.stop_servers_with_lock):
450         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
451         (ManagerTest.test_servers_started):
452
453 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
454
455         test-webkitpy: add a -p flag to pass through captured output to enable debugging
456         https://bugs.webkit.org/show_bug.cgi?id=89158
457
458         Reviewed by Eric Seidel.
459
460         Normally when outputcapture runs it intercepts stdout/stderr,
461         which makes running under the debugger difficult and mostly
462         pointless (since you can't see any output). This change adds a
463         flag to test-webkitpy (-p) that will cause outputcapture to pass
464         through the output as well as capture it.
465
466         * Scripts/webkitpy/common/system/outputcapture.py:
467         (OutputCapture.stream_wrapper):
468         (OutputCapture._capture_output_with_name):
469         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
470         (OutputCaptureTest.setUp):
471         * Scripts/webkitpy/test/main.py:
472         (Tester._parse_args):
473         (Tester._run_tests):
474         (Tester._log_exception):
475         (_CaptureAndPassThroughStream):
476         (_CaptureAndPassThroughStream.__init__):
477         (_CaptureAndPassThroughStream.write):
478         (_CaptureAndPassThroughStream._message_is_from_pdb):
479         (_CaptureAndPassThroughStream.flush):
480         (_CaptureAndPassThroughStream.getvalue):
481
482 2012-06-19  Adam Barth  <abarth@webkit.org>
483
484         garden-o-matic fails to rebaseline tests with MISSING results
485         https://bugs.webkit.org/show_bug.cgi?id=89521
486
487         Reviewed by Kenneth Russell.
488
489         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
490
491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
492
493 2012-06-19  Adam Barth  <abarth@webkit.org>
494
495         svn.delete_list fails to delete empty parent directories
496         https://bugs.webkit.org/show_bug.cgi?id=89520
497
498         Reviewed by Dirk Pranke.
499
500         These functions were calling scm.delete and scm.add, which already
501         delete the parent directory. We'd get an exception when we tried to
502         delete the parent directory again.
503
504         * Scripts/webkitpy/common/checkout/scm/svn.py:
505         (SVN._add_parent_directories):
506         (SVN._delete_parent_directories):
507
508 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
509
510         webkitpy: Simplify fetch_bugs_matching_search()
511         https://bugs.webkit.org/show_bug.cgi?id=89497
512
513         Reviewed by Adam Barth.
514
515         Removed parameter with default value. It's not being used
516         and the handling of the parameter was wrong. Saves a check.
517
518         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
519         (BugzillaQueries.fetch_bugs_matching_search):
520         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
521         (MockBugzillaQueries.fetch_bugs_matching_search):
522
523 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
524
525         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
526         https://bugs.webkit.org/show_bug.cgi?id=89522
527
528         Reviewed by Eric Seidel.
529
530         They were no longer being used. No tests necessary.
531
532         * Scripts/webkitpy/layout_tests/port/chromium.py:
533
534 2012-06-19  Adam Barth  <abarth@webkit.org>
535
536         Missing results aren't shown in garden-o-matic
537
538         Reviewed by Kenneth Russell.
539
540         Previously we didn't know to look for text and image results when the
541         bot told us that results were missing.
542
543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
544
545 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
546
547         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
548
549         Unreviewed, build fix.
550
551         It turns out that we store the svn revision two different ways
552         in the JSON, and I only caught one of them :(. This should fix
553         the other.
554
555         Also, this part of the code is poorly tested. I will investigate
556         adding at least a basic test for this in a separate fix.
557
558         * Scripts/webkitpy/layout_tests/controllers/manager.py:
559         (summarize_results):
560
561 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
562
563         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
564         https://bugs.webkit.org/show_bug.cgi?id=78127
565
566         Reviewed by Ryosuke Niwa.
567
568         Add the --add-platform-exceptions flag from ORWT, and ensure
569         that --new-baseline is equivalent to --reset-results
570         --add-platform-exceptions. Also fix the default logic for where to
571         put PNGs and render tree dumps if --new-test-results is true:
572         if --add-platform-exceptions is False, baselines should go in
573         the least-specific platform directory (e.g., platform/mac)
574         rather than the most-specific (platform/mac-snowleopard).
575
576         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
577         (SingleTestRunner):
578         (SingleTestRunner.run):
579         (SingleTestRunner._run_rebaseline):
580         (SingleTestRunner._add_missing_baselines):
581         (SingleTestRunner._location_for_new_baseline):
582         (SingleTestRunner._overwrite_baselines):
583         (SingleTestRunner._save_baseline_data):
584         * Scripts/webkitpy/layout_tests/port/base.py:
585         (Port.baseline_path):
586         (Port):
587         (Port.baseline_platform_dir):
588         (Port.baseline_version_dir):
589         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
590         (_set_up_derived_options):
591         (parse_args):
592         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
593         (RebaselineTest.assertBaselines):
594         (RebaselineTest.test_reset_results):
595         (RebaselineTest.test_missing_results):
596         (RebaselineTest.test_new_baseline):
597
598 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
599
600         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
601         https://bugs.webkit.org/show_bug.cgi?id=81379
602
603         Reviewed by Eric Seidel.
604
605         The 'free memory' calculation we were running on the mac seemed
606         to underestimate how many children we can run in parallel, and
607         it was complex. This patch replaces that calculation with a
608         simpler one that reserves 2GB for overhead and assumes 256MB per
609         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
610
611         Also, there was a bug where we were truncating the memory
612         installed on the machine to 4GB by casting to an int instead of
613         a long; this was probably the source of some of the earlier
614         problems when using total memory.
615
616         This patch also removes the no-longer-needed restrictions on the
617         number of workers on beefy Lion boxes for both Apple Mac and Chromium
618         Mac; we should now use all of the cores by default.
619
620         The memory calculations have only been implemented on the mac;
621         having the calculation in base.default_child_processes() was IMO
622         misleading, and so this patch also moves the computation into
623         the MacPort. I have not heard of the # of workers being an issue
624         on any other ports, so this should be fine.
625
626         * Scripts/webkitpy/common/system/platforminfo.py:
627         (PlatformInfo.total_bytes_memory):
628         * Scripts/webkitpy/common/system/platforminfo_mock.py:
629         (PlatformInfo.total_bytes_memory):
630         (PlatformInfo.total_bytes_memory):
631         (PlatformInfo._win_version_tuple_from_cmd):
632         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
633         (TestPlatformInfo.test_total_bytes_memory):
634         * Scripts/webkitpy/layout_tests/port/base.py:
635         (Port.default_child_processes):
636         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
637         (PortTest.test_default_child_processes):
638         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
639         (ChromiumMacPort.operating_system):
640         * Scripts/webkitpy/layout_tests/port/mac.py:
641         (MacPort.default_child_processes):
642         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
643         (TestMacPort.test_default_child_processes):
644
645 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
646
647         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
648         https://bugs.webkit.org/show_bug.cgi?id=85446
649
650         Reviewed by Simon Fraser.
651
652         Embed whether pixel testing was enabled into the results.json.
653
654         * Scripts/webkitpy/layout_tests/controllers/manager.py:
655         (summarize_results):
656
657 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
658
659         [Qt] Modify HTTPS port to 8443 for performance tests
660         https://bugs.webkit.org/show_bug.cgi?id=89442
661
662         Reviewed by Ryosuke Niwa.
663
664         We should be consistent with the default HTTPS port and with the changelog of r119188.
665
666         * Scripts/webkitpy/performance_tests/perftest.py:
667         (ReplayServer.__init__):
668
669 2012-06-19  Mike West  <mkwst@chromium.org>
670
671         Introduce ENABLE_CSP_NEXT configuration flag.
672         https://bugs.webkit.org/show_bug.cgi?id=89300
673
674         Reviewed by Adam Barth.
675
676         The 1.0 draft of the Content Security Policy spec is just about to
677         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
678         this ENABLE flag, disabled by default.
679
680         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
681
682         * Scripts/webkitperl/FeatureList.pm:
683         * qmake/mkspecs/features/features.pri:
684
685 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
686
687         [EFL] EFL's LayoutTestController does not support setTextDirection
688         https://bugs.webkit.org/show_bug.cgi?id=87481
689
690         Reviewed by Hajime Morita.
691
692         Implement setTextDirection in EFL's LayoutTestController and
693         properly reset its value between test cases to avoid flakiness.
694
695         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
696         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
697         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
698         (LayoutTestController::setTextDirection):
699
700 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
701
702         [Qt] Temporarily disable xvfb driver in nrwt
703         https://bugs.webkit.org/show_bug.cgi?id=88414
704
705         Reviewed by Csaba Osztrogonác.
706
707         * Scripts/webkitpy/layout_tests/port/qt.py:
708         (QtPort._build_driver):
709
710 2012-06-18  Joone Hur  <joone.hur@intel.com>
711
712         [EFL] Fontconfig can't be linked properly
713         https://bugs.webkit.org/show_bug.cgi?id=89418
714
715         Unreviewed build fix.
716
717         Make Fontconfig be linked correctly.
718
719         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
720
721 2012-06-18  Joone Hur  <joone.hur@intel.com>
722
723         Unreviewed. Updating email for committers.py script.
724
725         * Scripts/webkitpy/common/config/committers.py:
726
727 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
728
729         Fix a typo that caused TestFailures to have a syntax error.
730         
731         Sadly TestFailures is broken for another reason now too:
732         https://bugs.webkit.org/show_bug.cgi?id=89419
733
734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
735         (ViewController.prototype._domForBuildName):
736
737 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
738
739         Provide bug links for suspicious commits
740         https://bugs.webkit.org/show_bug.cgi?id=89408
741         
742         Reviewed by Adam Barth.
743
744         Add links to bugs for the suspicious commits if we have bug data.
745
746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
749         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
750         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
751
752 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
753
754         [Chromium] DeviceOrientation Cleanup
755         https://bugs.webkit.org/show_bug.cgi?id=89354
756
757         Reviewed by Kent Tamura.
758
759         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
760         (WebViewHost):
761
762 2012-06-18  James Robinson  <jamesr@chromium.org>
763
764         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
765         https://bugs.webkit.org/show_bug.cgi?id=89254
766
767         Reviewed by Adrienne Walker.
768
769         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
770         upstream.
771
772         * DumpRenderTree/chromium/WebViewHost.cpp:
773         (WebViewHost::createGraphicsContext3D):
774
775 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
776
777         Minor fix suggested by Adam Barth.
778
779         Use $(this._what).empty(); rather than removing children one at a time.
780         For some reason removeAllChildren() is undefined on this node.
781         
782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
783
784 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
785
786         Show TOT revision in garden-o-matic, and make the revisions into links
787         https://bugs.webkit.org/show_bug.cgi?id=89396
788
789         Reviewed by Adam Barth.
790
791         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
792         where the revisions are links to trac.
793         
794         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
795         the knock-on effect of flipping the target and href attributes for anchors in some test output.
796
797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
798         (ViewController.prototype._displayTesters.updateList.list):
799         (ViewController.prototype._displayTesters.updateList):
800         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
801         (ViewController.prototype._domForRegressionRange):
802         (ViewController.prototype._domForAuxiliaryUIElements):
803         (ViewController.prototype._domForBuildName):
804         (ViewController.prototype):
805         (ViewController.prototype.):
806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
807         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
808         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
811
812 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
813
814         REGRESSION(r100558): NRWT should work without SVN or GIT
815         https://bugs.webkit.org/show_bug.cgi?id=76630
816
817         Reviewed by Dirk Pranke.
818
819         NRWT is not supposed to have a requirement that we have an
820         actual SVN or Git checkout, and we were unnecessarily
821         initializing the checkout. This patch removes that line :).
822
823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
824         (main):
825
826 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
827
828         [garden-o-matic] Add support for the GTK builders
829         https://bugs.webkit.org/show_bug.cgi?id=89360
830
831         Reviewed by Adam Barth.
832
833         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
834         both get their data from build.webkit.org.
835
836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
837         (.):
838
839 2012-06-18  Nico Weber  <thakis@chromium.org>
840
841         [chromium/mac] Unbreak smooth scrolling.
842         https://bugs.webkit.org/show_bug.cgi?id=89327
843
844         Reviewed by Dimitri Glazkov.
845
846         Broken by Sam in r115589 / r115591.
847
848         * DumpRenderTree/mac/DumpRenderTree.mm:
849         (resetDefaultsToConsistentValues):
850         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
851         (TestWebKitAPI::InjectedBundleController::platformInitialize):
852         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
853         (WTR::InjectedBundle::platformInitialize):
854
855 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
856
857         Unreviewed, rolling out r120541, r120547, and r120548.
858         http://trac.webkit.org/changeset/120541
859         http://trac.webkit.org/changeset/120547
860         http://trac.webkit.org/changeset/120548
861         https://bugs.webkit.org/show_bug.cgi?id=89383
862
863         This approach doesn't work for WebKit2 (Requested by abarth on
864         #webkit).
865
866         * DumpRenderTree/LayoutTestController.cpp:
867         (setBackingScaleFactorCallback):
868         (LayoutTestController::staticFunctions):
869         * DumpRenderTree/LayoutTestController.h:
870         (LayoutTestController):
871         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
872         (LayoutTestController::setBackingScaleFactor):
873         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
874         (LayoutTestController::setBackingScaleFactor):
875         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
876         (LayoutTestController::setBackingScaleFactor):
877         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
878         (LayoutTestController::setBackingScaleFactor):
879         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
880         (LayoutTestController::setBackingScaleFactor):
881         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
882         (LayoutTestController::setBackingScaleFactor):
883         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
884         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
885         (WTR::InjectedBundle::didReceiveMessage):
886         (WTR::InjectedBundle::postSetBackingScaleFactor):
887         (WTR):
888         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
889         (InjectedBundle):
890         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
891         (WTR::LayoutTestController::setBackingScaleFactor):
892         (WTR):
893         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
894         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
895         (LayoutTestController):
896         * WebKitTestRunner/TestInvocation.cpp:
897         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
898
899 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
900
901         REGRESSION(r120546): It made 3 webkitpy tests fail
902         https://bugs.webkit.org/show_bug.cgi?id=89332
903
904         Reviewed by Adam Barth.
905
906         Update the BaselineOptimizer unittest after r120546.
907
908         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
909         (BaselineOptimizerTest.test_no_add_mac_future):
910         (BaselineOptimizerTest.test_mac_future):
911         (BaselineOptimizerTest.test_complex_shadowing):
912
913 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
914
915         new-run-webkit-tests output gets confused when logging
916         https://bugs.webkit.org/show_bug.cgi?id=63793
917
918         Reviewed by Adam Barth.
919
920         Ship all of the log messages generated in the worker back
921         to the manager; this allows the messages to be properly
922         serialized to stderr and for the meter to flush its output correctly.
923
924         Note however that this will likely result in messages to be
925         logged out of order between workers; I'm not sure that there's
926         an easy way to fix this short of buffering a potentially
927         unbounded amount of data. It might be better to just log through
928         stderr unless we're in 'metering' mode, but it's also worth
929         noting that we already get messages out of order through stderr
930         on Windows.
931
932         * Scripts/webkitpy/layout_tests/controllers/manager.py:
933         (Manager.handle_done):
934         (Manager.handle_finished_test):
935         (Manager._log_messages):
936         * Scripts/webkitpy/layout_tests/controllers/worker.py:
937         (Worker.__init__):
938         (Worker._set_up_logging):
939         (Worker.run):
940         (Worker._run_test):
941         (Worker.cleanup):
942         (Worker.run_single_test):
943         (_WorkerLogHandler):
944         (_WorkerLogHandler.__init__):
945         (_WorkerLogHandler.emit):
946         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
947         (MeteredStream.write):
948         (MeteredStream.writeln):
949         * Scripts/webkitpy/layout_tests/views/printing.py:
950         (Printer.writeln):
951
952 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
953
954         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
955         https://bugs.webkit.org/show_bug.cgi?id=89362
956
957         Reviewed by Simon Fraser.
958
959         Replace white spaces, braces and dots in the builder name with underscores. This
960         way the JQuery tabs will be properly matched with the according container.
961
962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
963
964 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
965
966         nrwt: metered output doesn't handle ^C cleanly
967         https://bugs.webkit.org/show_bug.cgi?id=89249
968
969         Reviewed by Tony Chang.
970
971         If you ctrl-c a running nrwt (w/o --verbose), then all but
972         two characters of the last update are erased, and then we print
973         "interrupted, exiting" as an update, which itself then gets
974         erased. Fix this so that we flush the meter (making the last
975         update persistent, so that we print the ^C for a visual clue),
976         print the interrupt message, and move on ...
977
978         * Scripts/webkitpy/layout_tests/controllers/manager.py:
979         (Manager._run_tests):
980         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
981         (MeteredStream.flush):
982         * Scripts/webkitpy/layout_tests/views/printing.py:
983         (Printer._write):
984         (Printer):
985         (Printer.flush):
986
987 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
988
989         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
990         https://bugs.webkit.org/show_bug.cgi?id=89228
991
992         Reviewed by Tony Chang.
993
994         * DumpRenderTree/chromium/LayoutTestController.cpp:
995         * DumpRenderTree/chromium/TestShellAndroid.cpp:
996
997 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
998
999         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
1000         https://bugs.webkit.org/show_bug.cgi?id=89226
1001
1002         Reviewed by Martin Robinson.
1003
1004         Implement increment() and decrement() functions in term of the AtkValue interface,
1005         instead of using DumpRenderTreeSupportGtk helper class.
1006
1007         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1008         (AccessibilityUIElement::intValue):
1009         (AccessibilityUIElement::minValue):
1010         (AccessibilityUIElement::maxValue):
1011         (alterCurrentValue):
1012         (AccessibilityUIElement::increment):
1013         (AccessibilityUIElement::decrement):
1014
1015 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
1016
1017         garden-o-matic 'Results' panel is broken for the Apple platform
1018         https://bugs.webkit.org/show_bug.cgi?id=89310
1019
1020         Reviewed by Adam Barth.
1021         
1022         For platforms that don't use accumulated build directories on the server,
1023         carry along buildLocation data with buildInfo, so that we know where to
1024         look for the test results files for a given test.
1025         
1026         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
1027         it now returns an array of objects with buildNumber, revision and url info.
1028         
1029         Fixed results.fetchResultsURLs() to use this data to find results.
1030         
1031         Fixed the results display to not scroll when you click on a test to see the results.
1032         Made the h3s look less ugly
1033         
1034         Don't try to show the flakiness dashboard for the Apple platform.
1035
1036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1042         (.results-view .top-panel):
1043         (.results-view h3):
1044
1045 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
1046
1047         Make garden-o-matic work for the Apple Mac port
1048         https://bugs.webkit.org/show_bug.cgi?id=84642
1049
1050         Reviewed by Adam Barth.
1051         
1052         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
1053         educating the scripts in various ways:
1054         * Wrap up platform-related differences in config.kPlatforms[]
1055         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
1056         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
1057           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
1058           recent build with valid results.
1059         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
1060           try to test a build that has already been deleted). Make walkHistory() more robust here.
1061         * webkit.org uses differently named test result directories, that include the SVN revision as
1062           well as the build number. That forces us to fetch more build info before we can get the
1063           result directory URL.
1064         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
1065           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
1066           dirs.
1067         * Various URLs differ between webkit.org and chromium.org
1068         * Better UI for the failures info, so that some info is visible even when not hovered.
1069
1070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
1072         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
1073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1075         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1077         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1086         (ol.notifications>li table.failures):
1087         (ol.notifications>li:hover table.failures):
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1089         (#onebar #platform-picker):
1090         * Scripts/webkitpy/layout_tests/port/builders.py:
1091
1092 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1093
1094         Unreviewed, rolling out r120536.
1095         http://trac.webkit.org/changeset/120536
1096         https://bugs.webkit.org/show_bug.cgi?id=89296
1097
1098         Does not compile on chromium-linux (Requested by abarth on
1099         #webkit).
1100
1101         * DumpRenderTree/chromium/LayoutTestController.cpp:
1102         (LayoutTestController::reset):
1103         (LayoutTestController::setTextSubpixelPositioning):
1104         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1105
1106 2012-06-16  Adam Barth  <abarth@webkit.org>
1107
1108         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
1109         https://bugs.webkit.org/show_bug.cgi?id=89274
1110
1111         Reviewed by Levi Weintraub.
1112
1113         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
1114         Note: The WebKit2 API that setBackingScaleFactor exercises is still
1115         tested by API-level tests.
1116
1117         * DumpRenderTree/LayoutTestController.cpp:
1118         (LayoutTestController::staticFunctions):
1119         * DumpRenderTree/LayoutTestController.h:
1120         (LayoutTestController):
1121         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1122         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1123         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1125         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1126         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1127         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1128         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1129         (WTR::InjectedBundle::didReceiveMessage):
1130         (WTR):
1131         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1132         (InjectedBundle):
1133         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1134         (WTR):
1135         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1136         (LayoutTestController):
1137         * WebKitTestRunner/TestInvocation.cpp:
1138         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1139
1140 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
1141
1142         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1143         https://bugs.webkit.org/show_bug.cgi?id=89228
1144
1145         Reviewed by Tony Chang.
1146
1147         * DumpRenderTree/chromium/LayoutTestController.cpp:
1148         (LayoutTestController::reset):
1149         (LayoutTestController::setTextSubpixelPositioning):
1150         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1151
1152 2012-06-15  Adam Barth  <abarth@webkit.org>
1153
1154         garden-o-matic's results.js should use RequestTracker
1155         https://bugs.webkit.org/show_bug.cgi?id=89257
1156
1157         Reviewed by Dimitri Glazkov.
1158
1159         We wrote results.js before we recognized the RequestTracker pattern.
1160         This patch replaces the manual implementations of RequestTracker with
1161         the real deal.
1162
1163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1164
1165 2012-06-15  Darin Adler  <darin@apple.com>
1166
1167         * Scripts/webkitpy/bindings: Added property svn:ignore.
1168
1169 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1170
1171         Unreviewed, rolling out r120511.
1172         http://trac.webkit.org/changeset/120511
1173         https://bugs.webkit.org/show_bug.cgi?id=89255
1174
1175         Breaks at least Android builder (Requested by wangxianzhu on
1176         #webkit).
1177
1178         * DumpRenderTree/chromium/LayoutTestController.cpp:
1179         (LayoutTestController::reset):
1180         (LayoutTestController::setTextSubpixelPositioning):
1181
1182 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1183
1184         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1185         https://bugs.webkit.org/show_bug.cgi?id=89228
1186
1187         Reviewed by Tony Chang.
1188
1189         * DumpRenderTree/chromium/LayoutTestController.cpp:
1190         (LayoutTestController::reset):
1191         (LayoutTestController::setTextSubpixelPositioning):
1192
1193 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1194
1195         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1196         https://bugs.webkit.org/show_bug.cgi?id=89135
1197
1198         Re-land change in r120370 with fix in
1199         PortFactory.get_from_builder_name() that changes BuilderOptions
1200         to an actual optparse.Values object.
1201
1202         * Scripts/webkitpy/layout_tests/port/base.py:
1203         (Port.__init__):
1204         (Port.get_option):
1205         (Port.set_option_default):
1206         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1207         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1208         * Scripts/webkitpy/layout_tests/port/factory.py:
1209         (_builder_options):
1210         (PortFactory.get_from_builder_name):
1211         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1212         (FactoryTest.test_get_from_builder_name):
1213         * Scripts/webkitpy/style/checkers/test_expectations.py:
1214         (TestExpectationsChecker._determine_port_from_expectations_path):
1215         * Scripts/webkitpy/tool/mocktool.py:
1216         (MockOptions.ensure_value):
1217
1218 2012-06-15  Bill Budge  <bbudge@chromium.org>
1219
1220         Add bbudge@chromium.org to committers.py
1221
1222         Unreviewed.
1223
1224         * Scripts/webkitpy/common/config/committers.py:
1225
1226 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1227
1228         Unreviewed style fix after r120351.
1229
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1231         (body.interface):
1232
1233 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1234
1235         master.cfg cleanup, remove unnecessary workaround
1236         https://bugs.webkit.org/show_bug.cgi?id=88994
1237
1238         Reviewed by Lucas Forschler.
1239
1240         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1241         (loadBuilderConfig):
1242
1243 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1244
1245         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1246         https://bugs.webkit.org/show_bug.cgi?id=88581
1247
1248         Reviewed by Adam Barth.
1249
1250         Make sure we only optimize the suffixes we rebaselined during
1251         rebaseline-expectations, and not all suffixes for a test.
1252         While optimizing is somewhere between harmless and good, it's also confusing :)
1253
1254         * Scripts/webkitpy/tool/commands/rebaseline.py:
1255         (RebaselineExpectations._rebaseline_port):
1256         (RebaselineExpectations.execute):
1257         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1258
1259 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1260
1261         Update builder.html template for newer buildmaster
1262         https://bugs.webkit.org/show_bug.cgi?id=89207
1263
1264         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
1265
1266         Reviewed by Zoltan Herczeg.
1267
1268         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
1269
1270 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1271
1272         Add ForceScheduler to build.webkit.org
1273         https://bugs.webkit.org/show_bug.cgi?id=88982
1274
1275         Reviewed by Ryosuke Niwa.
1276
1277         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1278         (loadBuilderConfig):
1279
1280 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1281
1282         [EFL][WK2] Add title support to Ewk_View
1283         https://bugs.webkit.org/show_bug.cgi?id=89095
1284
1285         Reviewed by Kenneth Rohde Christiansen.
1286
1287         Update the MiniBrowser so it listens for the "title,change"
1288         signal on the view and keeps the browser window title
1289         up-to-date.
1290
1291         * MiniBrowser/efl/main.c:
1292         (on_title_changed):
1293         (browserCreate):
1294
1295 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1296
1297         [WK2][EFL] Implement navigation back/forward in Ewk_View
1298         https://bugs.webkit.org/show_bug.cgi?id=89173
1299
1300         Reviewed by Kenneth Rohde Christiansen.
1301
1302         Implement navigation back / forward in MiniBrowser. Use
1303         'F1' to navigate back and 'F2' to navigate forward.
1304
1305         * MiniBrowser/efl/main.c:
1306         (on_key_down):
1307
1308 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1309
1310         [EFL] EFL's LayoutTestController does not support titleTextDirection
1311         https://bugs.webkit.org/show_bug.cgi?id=86475
1312
1313         Reviewed by Hajime Morita.
1314
1315         Add titleTextDirection getter and setter to LayoutTestController and
1316         expose its value to JavaScript.
1317         Update the titleTextDirection value from EFL's "title,changed"
1318         callback in DumpRenderTree.
1319
1320         * DumpRenderTree/LayoutTestController.cpp:
1321         (LayoutTestController::LayoutTestController):
1322         (getTitleTextDirectionCallback):
1323         (LayoutTestController::staticValues):
1324         * DumpRenderTree/LayoutTestController.h:
1325         (LayoutTestController::titleTextDirection):
1326         (LayoutTestController::setTitleTextDirection):
1327         (LayoutTestController):
1328         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1329         (DumpRenderTreeChrome::onFrameTitleChanged):
1330
1331 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1332
1333         [EFL][WK2] Implement reload / stop in Ewk_View
1334         https://bugs.webkit.org/show_bug.cgi?id=89168
1335
1336         Reviewed by Kenneth Rohde Christiansen.
1337
1338         Implement view reload / stop loading in MiniBrowser.
1339         Use 'F5' for reload and 'F6' for stopping the load.
1340
1341         * MiniBrowser/efl/main.c:
1342         (on_key_down):
1343         (browserCreate):
1344
1345 2012-06-15  Hironori Bono  <hbono@chromium.org>
1346
1347         Allow platforms to choose whether to remove markers on editing
1348         https://bugs.webkit.org/show_bug.cgi?id=88838
1349
1350         Reviewed by Hajime Morita.
1351
1352         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
1353         run grammar tests.
1354
1355         * DumpRenderTree/chromium/WebViewHost.cpp:
1356         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
1357         * DumpRenderTree/chromium/WebViewHost.h:
1358         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
1359
1360 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1361
1362         Unreviewed, rolling out r120370.
1363         http://trac.webkit.org/changeset/120370
1364         https://bugs.webkit.org/show_bug.cgi?id=89183
1365
1366         Broke webkit-patch rebaseline (Requested by zdobersek on
1367         #webkit).
1368
1369         * Scripts/webkitpy/layout_tests/port/base.py:
1370         (DummyOptions):
1371         (DummyOptions.__init__):
1372         (DummyOptions.__init__.this):
1373         (Port.__init__):
1374         (Port.get_option):
1375         (Port.set_option_default):
1376         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1377         (ChromiumWinTest.RegisterCygwinOption):
1378         (ChromiumWinTest.RegisterCygwinOption.__init__):
1379         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1380         * Scripts/webkitpy/style/checkers/test_expectations.py:
1381         (TestExpectationsChecker._determine_port_from_expectations_path):
1382         * Scripts/webkitpy/tool/mocktool.py:
1383         (MockOptions.update):
1384
1385 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1386
1387         [Chromium-Android] Initialize font rendering in DumpRenderTree
1388         https://bugs.webkit.org/show_bug.cgi?id=89133
1389
1390         Reviewed by Adam Barth.
1391
1392         * DumpRenderTree/chromium/LayoutTestController.cpp:
1393         (LayoutTestController::reset):
1394         (LayoutTestController::setTextSubpixelPositioning):
1395         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1396         (platformInit):
1397
1398 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
1399
1400         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
1401         https://bugs.webkit.org/show_bug.cgi?id=88622
1402
1403         Reviewed by Philippe Normand.
1404
1405         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
1406         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1407
1408 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1409
1410         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
1411         https://bugs.webkit.org/show_bug.cgi?id=89124
1412
1413         Reviewed by Dirk Pranke.
1414
1415         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1416         (ChromiumAndroidDriver._start):
1417         (ChromiumAndroidDriver):
1418         (ChromiumAndroidDriver._start_once):
1419
1420 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
1421
1422         Update webpagereplay to 1.1.2
1423         https://bugs.webkit.org/show_bug.cgi?id=89118
1424
1425         This includes the following patch which avoids pkg_resources import errors:
1426         http://code.google.com/p/web-page-replay/source/detail?r=476
1427
1428         Reviewed by Dirk Pranke.
1429
1430         * Scripts/webkitpy/thirdparty/__init__.py:
1431         (AutoinstallImportHook._install_webpagereplay):
1432
1433 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
1434
1435         Get rid of FAIL test expectation
1436         https://bugs.webkit.org/show_bug.cgi?id=89137
1437
1438         Reviewed by Dirk Pranke.
1439
1440         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1441         (ResultSummaryTest.test_summarized_results_wontfix):
1442         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1443         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1444         (JSONLayoutResultsGenerator):
1445         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1446         (result_was_expected):
1447         (suffixes_for_expectations):
1448         (TestExpectationsModel._add_test):
1449         (TestExpectations):
1450         (TestExpectations.get_rebaselining_failures):
1451         (TestExpectations.remove_configuration_from_test):
1452         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1453         (FunctionsTest.test_result_was_expected):
1454         (FunctionsTest.test_suffixes_for_expectations):
1455         (TestExpectationSerializerTests.test_parsed_expectations_string):
1456         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1457         (test_test_expectations):
1458         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1459         (TestExpectationsTestCase.test_valid_expectations):
1460
1461 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1462
1463         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1464         https://bugs.webkit.org/show_bug.cgi?id=89135
1465
1466         Reviewed by Ryosuke Niwa.
1467
1468         This patch is just some minor cleanup and simplification. There
1469         should be no functional changes here.
1470
1471         * Scripts/webkitpy/layout_tests/port/base.py:
1472         (Port.__init__):
1473         (Port.get_option):
1474         (Port.set_option_default):
1475         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1476         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1477         * Scripts/webkitpy/style/checkers/test_expectations.py:
1478         (TestExpectationsChecker._determine_port_from_expectations_path):
1479         * Scripts/webkitpy/tool/mocktool.py:
1480         (MockOptions.ensure_value):
1481
1482 2012-06-14  Ian Vollick  <vollick@chromium.org>
1483
1484         [chromium] Certain settings in CCSettings could be global
1485         https://bugs.webkit.org/show_bug.cgi?id=88384
1486
1487         Reviewed by James Robinson.
1488
1489         * DumpRenderTree/chromium/TestShell.cpp:
1490         (TestShell::TestShell):
1491         (TestShell::resetWebSettings):
1492         (TestShell::setPerTilePaintingEnabled):
1493         * DumpRenderTree/chromium/TestShell.h:
1494         (TestShell):
1495         * DumpRenderTree/chromium/WebPreferences.cpp:
1496         (WebPreferences::reset):
1497         (WebPreferences::applyTo):
1498         * DumpRenderTree/chromium/WebPreferences.h:
1499         (WebPreferences):
1500
1501 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1502
1503         Unreviewed, rolling out r120352.
1504         http://trac.webkit.org/changeset/120352
1505         https://bugs.webkit.org/show_bug.cgi?id=89120
1506
1507         It seems something is still wrong with it :/ (Requested by
1508         Ossy on #webkit).
1509
1510         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1511         (Factory.__init__):
1512         (BuildFactory.__init__):
1513         (TestFactory.__init__):
1514         (BuildAndTestFactory.__init__):
1515         (BuildAndPerfTestFactory.__init__):
1516         (BuildAndPerfTestWebKit2Factory.__init__):
1517         (DownloadAndPerfTestFactory.__init__):
1518         (DownloadAndPerfTestWebKit2Factory.__init__):
1519
1520 2012-06-14  Jia Pu  <jpu@apple.com>
1521
1522         Mark text with text alternative with blue underline.
1523         https://bugs.webkit.org/show_bug.cgi?id=83047
1524
1525         Reviewed by NOBODY Enrica Casucci.
1526
1527         * DumpRenderTree/mac/TextInputController.m:
1528         (+[TextInputController isSelectorExcludedFromWebScript:]):
1529         (+[TextInputController webScriptNameForSelector:]):
1530         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
1531
1532 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1533
1534         Unreviewed, rolling out r120353.
1535         http://trac.webkit.org/changeset/120353
1536         https://bugs.webkit.org/show_bug.cgi?id=89119
1537
1538         It seems we still need this workaround (Requested by Ossy on
1539         #webkit).
1540
1541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1542         (loadBuilderConfig):
1543
1544 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1545
1546         master.cfg cleanup, remove unnecessary workaround
1547         https://bugs.webkit.org/show_bug.cgi?id=88994
1548
1549         Reviewed by Lucas Forschler.
1550
1551         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1552         (loadBuilderConfig):
1553
1554 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1555
1556         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
1557         https://bugs.webkit.org/show_bug.cgi?id=89001
1558
1559         Reviewed by Lucas Forschler.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1562         (Factory.__init__):
1563         (BuildFactory.__init__):
1564         (TestFactory.__init__):
1565         (BuildAndTestFactory.__init__):
1566         (BuildAndPerfTestFactory.__init__):
1567         (BuildAndPerfTestWebKit2Factory.__init__):
1568         (DownloadAndPerfTestFactory.__init__):
1569         (DownloadAndPerfTestWebKit2Factory.__init__):
1570
1571 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1572
1573         Unhide login form on the build.webkit.org
1574         https://bugs.webkit.org/show_bug.cgi?id=88981
1575
1576         Reviewed by Lucas Forschler.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1579
1580 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
1581
1582         [Gtk] Add support in DumpRenderTree for tracking repaints
1583         https://bugs.webkit.org/show_bug.cgi?id=87658
1584
1585         Reviewed by Martin Robinson.
1586
1587         Reimplement the displayWebView method in DumpRenderTree - force a
1588         repaint before starting tracking repaints and resetting them.
1589
1590         When gathering pixel output from a web view, if tracking repaints,
1591         paint an overlay over the output with the overlay being clear in the
1592         areas where the repaints occurred.
1593
1594         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1595         (displayWebView):
1596         (resetDefaultsToConsistentValues):
1597         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1598         (paintOverlay):
1599         (fillRepaintOverlayIntoContext):
1600         (createBitmapContextFromWebView):
1601
1602 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1603
1604         new-run-webkit-tests doesn't find similar platform tests for a keyword
1605         https://bugs.webkit.org/show_bug.cgi?id=37956
1606
1607         Reviewed by Ryosuke Niwa.
1608
1609         This patches adds support for NRWT so that if you type
1610         "new-run-webkit-tests foo" it will run all the tests in foo as
1611         well as platform/foo for all of the platforms that are normally
1612         searched (this only applies to directories, not to individual tests).
1613
1614         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1615         (Manager.collect_tests):
1616         * Scripts/webkitpy/layout_tests/port/base.py:
1617         (Port.tests):
1618         (Port):
1619         (Port._expanded_paths):
1620         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1621         (MainTest.test_no_http_tests):
1622         (MainTest):
1623         (MainTest.test_platform_tests_are_found):
1624
1625 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1626
1627         NRWT should honor --skipped=[default|ignore|only], like ORWT does
1628         https://bugs.webkit.org/show_bug.cgi?id=66308
1629
1630         Reviewed by Ryosuke Niwa.
1631
1632         This patch adds support for ORWT's --skipped=(default|ignore|only)
1633         flag and cleans up the interaction between that and --ignore.
1634
1635         Individual tests (but not directories) explicitly listed on the
1636         command line will always be run regardless of what is passed
1637         for --skipped and --ignore.
1638
1639         This patch also changes the "found" and "running" log messages
1640         since it wasn't clear how the skipped tests were included in those numbers.
1641
1642         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1643         (Manager.__init__):
1644         (Manager.collect_tests):
1645         (Manager.prepare_lists_and_print_output):
1646         * Scripts/webkitpy/layout_tests/port/test.py:
1647         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1648         (_set_up_derived_options):
1649         (parse_args):
1650         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1651         (MainTest.test_ignore_flag):
1652         (MainTest):
1653         (MainTest.test_skipped_flag):
1654
1655 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1656
1657         new-run-webkit-websocketserver must handle TLS related arguments
1658         https://bugs.webkit.org/show_bug.cgi?id=89079
1659
1660         Reviewed by Dirk Pranke.
1661
1662         PyWebSocket class must accept private_key, certificate, and
1663         ca_certificate arguments and pass them to launching pywebsocket.
1664         Also add ca_certificate handling to new-run-webkit-websocketserver.
1665
1666         * Scripts/new-run-webkit-websocketserver:
1667         (main):
1668         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1669         (PyWebSocket.__init__):
1670         (PyWebSocket._prepare_config):
1671
1672 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1673
1674         Unreviewed. Update my email.
1675
1676         * Scripts/webkitpy/common/config/committers.py:
1677
1678 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1679
1680         Update pywebsocket to 0.7.6 from 0.7.4
1681         https://bugs.webkit.org/show_bug.cgi?id=88975
1682
1683         Reviewed by Kent Tamura.
1684
1685         This new version of pywebsocket introduce following features.
1686          - Allow handlers to send a close frame with empty body in response of
1687              a client initiated closing handshake
1688          - Implement perframe compression extension
1689          - Support client certificate authentication
1690
1691         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
1692         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1693         (_create_control_frame):
1694         (Stream._receive_frame):
1695         (Stream.send_message):
1696         (Stream.receive_message):
1697         (Stream._send_closing_handshake):
1698         (Stream.close_connection):
1699         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1700         (ExtensionParsingException):
1701         (ExtensionParsingException.__init__):
1702         (_parse_extension_param):
1703         (_parse_extension):
1704         (parse_extensions):
1705         (format_extension):
1706         (format_extensions):
1707         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1708         (_parse_compression_method):
1709         (_create_accepted_method_desc):
1710         (PerFrameCompressionExtensionProcessor):
1711         (PerFrameCompressionExtensionProcessor.__init__):
1712         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
1713         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
1714         (PerFrameCompressionExtensionProcessor.get_extension_response):
1715         (PerFrameCompressionExtensionProcessor.setup_stream_options):
1716         (PerFrameCompressionExtensionProcessor.get_compression_processor):
1717         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1718         (parse_token_list):
1719         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1720         (Handshaker._parse_extensions):
1721         (Handshaker._send_handshake):
1722         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1723         (WebSocketServer._create_sockets):
1724         (_get_logger_from_class):
1725         (_configure_logging):
1726         (_build_option_parser):
1727         (_main.if):
1728         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1729         (RepeatedXorMasker.mask):
1730
1731 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
1732
1733         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
1734
1735         Reviewed by Noam Rosenthal.
1736
1737         * qmake/mkspecs/features/features.prf:
1738
1739 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
1740
1741         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
1742         https://bugs.webkit.org/show_bug.cgi?id=88399
1743
1744         Reviewed by Kenneth Rohde Christiansen.
1745
1746         Update initialization of WKPageLoaderClient.
1747
1748         * MiniBrowser/mac/BrowserWindowController.m:
1749         (-[BrowserWindowController awakeFromNib]):
1750         * WebKitTestRunner/TestController.cpp:
1751         (WTR::TestController::initialize):
1752
1753 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1754
1755         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
1756         https://bugs.webkit.org/show_bug.cgi?id=84577
1757
1758         Reviewed by Ryosuke Niwa.
1759
1760         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
1761         LayoutTestController.
1762
1763         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1764         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1765
1766 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
1767
1768         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
1769         https://bugs.webkit.org/show_bug.cgi?id=88340
1770
1771         Reviewed by Kenneth Rohde Christiansen.
1772
1773         Update initialization of WKPageLoaderClient.
1774
1775         * MiniBrowser/mac/BrowserWindowController.m:
1776         (-[BrowserWindowController awakeFromNib]):
1777         * WebKitTestRunner/TestController.cpp:
1778         (WTR::TestController::initialize):
1779
1780 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1781
1782         Unreviewed, rolling out r120268.
1783         http://trac.webkit.org/changeset/120268
1784         https://bugs.webkit.org/show_bug.cgi?id=89060
1785
1786         WebCompositor::setPerTilePaintingEnabled hits an assertion in
1787         DEBUG (Requested by dominicc|work on #webkit).
1788
1789         * DumpRenderTree/chromium/WebPreferences.cpp:
1790         (WebPreferences::applyTo):
1791
1792 2012-06-13  Tim Horton  <timothy_horton@apple.com>
1793
1794         REGRESSION (r120252): run-webkit-tests on Mac fails
1795         https://bugs.webkit.org/show_bug.cgi?id=89057
1796
1797         Reviewed by Dan Bernstein.
1798
1799         get_option will happily return None (the default only kicks in if
1800         the option is actually *not set*). We should instead check get_option's
1801         return value and default to "x86_64" architecture ourselves.
1802
1803         * Scripts/webkitpy/layout_tests/port/mac.py:
1804         (MacPort.__init__):
1805
1806 2012-06-13  Ian Vollick  <vollick@chromium.org>
1807
1808         [chromium] Certain settings in CCSettings could be global
1809         https://bugs.webkit.org/show_bug.cgi?id=88384
1810
1811         Reviewed by James Robinson.
1812
1813         * DumpRenderTree/chromium/WebPreferences.cpp:
1814         (WebPreferences::applyTo):
1815
1816 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1817
1818         new-run-webkit-tests does not support --32-bit like ORWT did
1819         https://bugs.webkit.org/show_bug.cgi?id=71634
1820
1821         Reviewed by Ojan Vafai.
1822
1823         This patch adds support for 32-bit apple mac builds, adding the
1824         --32-bit flag for compatibility with ORWT and fixing the port
1825         architecture() definition to actually return the correct values.
1826
1827         * Scripts/webkitpy/layout_tests/port/apple.py:
1828         (ApplePort._generate_all_test_configurations):
1829         * Scripts/webkitpy/layout_tests/port/factory.py:
1830         (port_options):
1831         * Scripts/webkitpy/layout_tests/port/mac.py:
1832         (MacPort):
1833         (MacPort.__init__):
1834         (MacPort._build_driver_flags):
1835         (MacPort.setup_environ_for_server):
1836         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1837         (test_sample_process_throws_exception):
1838         (test_32bit):
1839         (test_32bit.run_script):
1840         (test_64bit):
1841         (test_64bit.run_script):
1842         * Scripts/webkitpy/layout_tests/port/webkit.py:
1843         (WebKitPort._build_driver):
1844         (WebKitPort._build_driver_flags):
1845         * Scripts/webkitpy/layout_tests/port/win.py:
1846         (WinPort):
1847
1848 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
1849
1850         Remove webkitpy code to support legacy test_expectations.txt files
1851         https://bugs.webkit.org/show_bug.cgi?id=89038
1852
1853         Reviewed by Dirk Pranke.
1854
1855         * Scripts/webkitpy/layout_tests/port/base.py:
1856         (Port.path_to_test_expectations_file):
1857         (Port.expectations_dict):
1858         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1859         (PortTest.test_uses_test_expectations_file):
1860         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1861         (WebKitPortTest.test_path_to_test_expectations_file):
1862         (test_test_expectations):
1863         * Scripts/webkitpy/style/checker.py:
1864         (CheckerDispatcher.should_skip_without_warning):
1865         (CheckerDispatcher._create_checker):
1866         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1867         (TestExpectationsTestCase._expect_port_for_expectations_path):
1868         * Scripts/webkitpy/tool/steps/commit.py:
1869         (Commit._check_test_expectations):
1870         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1871         (CommitTest.test_check_test_expectations):
1872
1873 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1874
1875         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
1876         https://bugs.webkit.org/show_bug.cgi?id=88948
1877
1878         Reviewed by Ojan Vafai.
1879
1880         In the final patch of this run, we remove the
1881         test_expectations() and test_expectation_overrides() methods
1882         from the Port class - callers must now use just
1883         expectations_dict().
1884
1885         Note that support for the cascade in new-run-webkit-tests is
1886         complete but only Chromium uses it; webkit-patch
1887         rebaseline-expectations still does not support updating entries
1888         in any file other than the first expectations file, however.
1889
1890         * Scripts/webkitpy/layout_tests/port/base.py:
1891         (Port.path_to_test_expectations_file):
1892         (Port.uses_test_expectations_file):
1893         (Port.expectations_files):
1894         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1895         (PortTest.test_additional_expectations):
1896         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1897         (ChromiumPortTest.test_expectations_files):
1898         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1899         (TestGoogleChromePort.test_get_google_chrome_port):
1900         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1901         (test_test_expectations):
1902         (test_legacy_test_expectations):
1903
1904 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1905
1906         nrwt: implement the actual cascade of TestExpectations
1907         https://bugs.webkit.org/show_bug.cgi?id=88947
1908
1909         Reviewed by Ojan Vafai.
1910
1911         This change implements the actual cascade by removing the
1912         concept of 'overrides' from the TestExpectations object and
1913         parsing each file separately.
1914
1915         There is an actual semantic change in this patch, in that
1916         setting an expectation on a directory in one file will override
1917         the expectations on any individual tests set in prior files. The
1918         test_overrides__directory() unit test verifies this.
1919
1920         Otherwise, this patch mostly consists of deleting code :).
1921
1922         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1923         (TestExpectationsModel.__init__):
1924         (TestExpectationsModel.add_expectation_line):
1925         (TestExpectationsModel._add_test):
1926         (TestExpectationsModel._already_seen_better_match):
1927         (TestExpectations.__init__):
1928         (TestExpectations._add_expectations):
1929         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1930         (test_overrides__directory):
1931
1932 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1933
1934         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
1935         https://bugs.webkit.org/show_bug.cgi?id=88946
1936
1937         Reviewed by Ojan Vafai.
1938
1939         In preparation for fully supporting cascading expectations files
1940         and removing the 'overrides' concept.
1941
1942         There should be no functional changes in this patch.
1943
1944         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1945         (ManagerTest.test_update_summary_with_result):
1946         (ResultSummaryTest.get_result_summary):
1947         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1948         (TestExpectations.__init__):
1949         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1950         (parse_exp):
1951         (SkippedTests.check):
1952         (RemoveConfigurationsTest.test_remove):
1953         (test_remove_line):
1954         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1955         (LintTest.test_all_configurations.FakePort.__init__):
1956         (LintTest.test_all_configurations.FakePort.expectations_dict):
1957         (LintTest.test_lint_test_files__errors):
1958         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1959         (test_overrides_are_included_correctly):
1960
1961 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1962
1963         webkitpy: rework the TestExpectations style checker in preparation for the cascade
1964         https://bugs.webkit.org/show_bug.cgi?id=88945
1965
1966         Reviewed by Ojan Vafai.
1967
1968         This patch changes the style checker to call the
1969         TestExpectations parser directly and be oblivious as to what the
1970         port's actual expectations are.
1971
1972         * Scripts/webkitpy/style/checkers/test_expectations.py:
1973         (TestExpectationsChecker.__init__):
1974         (TestExpectationsChecker.check_test_expectations):
1975
1976 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
1977
1978         nrwt: restructure the port classes to handle multiple expectations files
1979         https://bugs.webkit.org/show_bug.cgi?id=88944
1980
1981         Reviewed by Ojan Vafai.
1982
1983         This patch restructures the Port classes so that each port
1984         returns a list of TestExpectations files to be used (in a new, public,
1985         expectations_files() method), and the base implementation rolls them
1986         up into the ordered expectations_dict(), which becomes a public
1987         method.
1988
1989         port.path_to_test_expectations_file(), port.test_expectations(),
1990         and port.test_expectations_overrides() are then reimplemented as
1991         wrappers around port.expectations_dict().
1992         port.test_expectations() and port.test_expectations_overrides()
1993         will eventually be removed when the cascade is fully completed,
1994         and port.path_to_test_expectations_file() will be removed when
1995         the rebaselining tool supports the cascade
1996         (expectations_files() may also become private at that point).
1997
1998         There should be no functional changes in this patch, but a bunch
1999         of custom logic gets deleted!
2000
2001         * Scripts/webkitpy/layout_tests/port/base.py:
2002         (Port.expectations_dict):
2003         (Port):
2004         (Port.expectations_files):
2005         (Port.test_expectations):
2006         (Port.test_expectations_overrides):
2007         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2008         (PortTest.test_additional_expectations):
2009         (PortTest.test_uses_test_expectations_file):
2010         * Scripts/webkitpy/layout_tests/port/chromium.py:
2011         (ChromiumPort.all_baseline_variants):
2012         (ChromiumPort.expectations_files):
2013         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2014         (ChromiumPortTest.test_overrides_and_builder_names):
2015         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2016         (_expectations_files):
2017         (GoogleChromeLinux32Port.expectations_files):
2018         (GoogleChromeLinux64Port.expectations_files):
2019         (GoogleChromeMacPort.expectations_files):
2020         (GoogleChromeWinPort.expectations_files):
2021         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2022         (TestGoogleChromePort._verify_expectations_overrides):
2023         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2024         (PortTestCase.test_expectations_ordering):
2025         * Scripts/webkitpy/layout_tests/port/webkit.py:
2026         (WebKitPort._skipped_file_search_paths):
2027         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2028         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2029         (test_rebaseline_updates_expectations_file):
2030         (test_rebaseline_does_not_include_overrides):
2031         (test_rebaseline_expectations):
2032         (test_overrides_are_included_correctly):
2033
2034 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
2035
2036         [WinCairo] Update URL of WinCairoRequirements.zip download.
2037         https://bugs.webkit.org/show_bug.cgi?id=89009
2038
2039         Reviewed by Martin Robinson.
2040
2041         * Tools/Scripts/update-webkit-dependency: Put fallback code
2042         to download a "last update" time from servers that don't properly
2043         report Last-Modified in their HTTP header.
2044         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
2045         for the WinCairo build requirements bundle.
2046
2047 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2048
2049         nrwt: preliminary cleanup before supporting cascading expectations files
2050         https://bugs.webkit.org/show_bug.cgi?id=88942
2051
2052         Reviewed by Ojan Vafai.
2053
2054         This change just prepares the TestExpectations parser to get filenames
2055         along with the expectations, and improves the warning messages so that
2056         they contain the filenames along with the line numbers.
2057
2058         There should be no functional changes in this patch.
2059
2060         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2061         (TestExpectationEditorTests.make_parsed_expectation_lines):
2062         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2063         (TestExpectationParser.parse):
2064         (TestExpectationParser.expectation_for_skipped_test):
2065         (TestExpectationParser._tokenize):
2066         (TestExpectationParser._tokenize_list):
2067         (TestExpectationLine):
2068         (TestExpectationsModel.__init__):
2069         (TestExpectationsModel._already_seen_better_match):
2070         (TestExpectations.__init__):
2071         (TestExpectations._shorten_filename):
2072         (TestExpectations._report_warnings):
2073         (TestExpectations._add_skipped_tests):
2074         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2075         (TestExpectationParserTests._tokenize):
2076         (TestExpectationParserTests.test_tokenize_blank):
2077         (TestExpectationParserTests.test_tokenize_missing_colon):
2078         (TestExpectationParserTests.test_tokenize_extra_colon):
2079         (TestExpectationParserTests.test_tokenize_empty_comment):
2080         (TestExpectationParserTests.test_tokenize_comment):
2081         (TestExpectationParserTests.test_tokenize_missing_equal):
2082         (TestExpectationParserTests.test_tokenize_extra_equal):
2083         (TestExpectationParserTests.test_tokenize_valid):
2084         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2085         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2086         (TestExpectationParserTests.test_parse_empty_string):
2087         (TestExpectationSerializerTests._tokenize):
2088         (TestExpectationSerializerTests.assert_round_trip):
2089         (TestExpectationSerializerTests.assert_list_round_trip):
2090         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2091         (GardeningExpectationsUpdater.update_expectations):
2092
2093 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
2094
2095         [Gtk] Enable link prefetch support in the developer builds
2096         https://bugs.webkit.org/show_bug.cgi?id=89011
2097
2098         Reviewed by Martin Robinson.
2099
2100         Enable the link prefetch support for Gtk by default in developer
2101         builds.
2102
2103         * Scripts/webkitperl/FeatureList.pm:
2104
2105 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
2106
2107         Update buildbot master in autoinstaller to match build.webkit.org
2108         https://bugs.webkit.org/show_bug.cgi?id=88992
2109
2110         Reviewed by Adam Barth.
2111
2112         * Scripts/webkitpy/thirdparty/__init__.py:
2113         (AutoinstallImportHook._install_buildbot):
2114
2115 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2116
2117         Unreviewed, rolling out r120209.
2118         http://trac.webkit.org/changeset/120209
2119         https://bugs.webkit.org/show_bug.cgi?id=89007
2120
2121         Broke the WebKit2 mac build. (Requested by andersca on
2122         #webkit).
2123
2124         * MiniBrowser/mac/BrowserWindowController.m:
2125         (-[BrowserWindowController awakeFromNib]):
2126         * WebKitTestRunner/TestController.cpp:
2127         (WTR::TestController::initialize):
2128
2129 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
2130
2131         check-webkit-style needs to respect Qt API coding style
2132         https://bugs.webkit.org/show_bug.cgi?id=88995
2133
2134         Reviewed by Csaba Osztrogonác.
2135
2136         Add -whitespace/declaration exception to Qt API files.
2137
2138         * Scripts/webkitpy/style/checker.py:
2139
2140 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2141
2142         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2143         https://bugs.webkit.org/show_bug.cgi?id=88340
2144
2145         Reviewed by Kenneth Rohde Christiansen.
2146
2147         Update initialization of WKPageLoaderClient.
2148
2149         * MiniBrowser/mac/BrowserWindowController.m:
2150         (-[BrowserWindowController awakeFromNib]):
2151         * WebKitTestRunner/TestController.cpp:
2152         (WTR::TestController::initialize):
2153
2154 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2155
2156         [Qt] Handle multiple held buttons in touch mocking.
2157         https://bugs.webkit.org/show_bug.cgi?id=88865
2158
2159         Reviewed by Kenneth Rohde Christiansen.
2160
2161         Add handling for multiple held mouse-buttons in the appropiate places.
2162         To do this last-pos and start-pos are now also read from the last recorded
2163         touch-point instead from object-global variables.
2164
2165         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2166         (MiniBrowserApplication::notify):
2167         (MiniBrowserApplication::updateTouchPoint):
2168         * MiniBrowser/qt/MiniBrowserApplication.h:
2169         (MiniBrowserApplication):
2170
2171 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
2172
2173         [Qt] Make it possible to disable -Werror in production builds
2174
2175         Reviewed by Tor Arne Vestbø.
2176
2177         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
2178         something qt5.git's qtwebkit.pri will soon do.
2179
2180         * qmake/mkspecs/features/unix/default_post.prf:
2181
2182 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
2183
2184         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
2185         https://bugs.webkit.org/show_bug.cgi?id=85790
2186
2187         Reviewed by Gustavo Noronha Silva.
2188
2189         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
2190         code in webkitdirs.pm.
2191
2192         * Scripts/webkitdirs.pm:
2193         (jhbuildConfigurationChanged):
2194         (saveJhbuildMd5):
2195         (cleanJhbuild):
2196         (buildAutotoolsProject):
2197         (generateBuildSystemFromCMakeProject):
2198
2199 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
2200
2201         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
2202         https://bugs.webkit.org/show_bug.cgi?id=88763
2203
2204         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
2205         extension.
2206
2207         Reviewed by Simon Hausmann.
2208
2209         * qmake/config.tests/libzlib: Added.
2210         * qmake/config.tests/libzlib/libzlib.cpp: Added.
2211         (main):
2212         * qmake/config.tests/libzlib/libzlib.pro: Added.
2213         * qmake/mkspecs/features/features.prf:
2214         * qmake/sync.profile:
2215
2216 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
2217
2218         [BlackBerry] Enable MEDIA_STREAM by default
2219         https://bugs.webkit.org/show_bug.cgi?id=88849
2220
2221         Reviewed by Antonio Gomes.
2222
2223         * Scripts/webkitperl/FeatureList.pm:
2224
2225 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2226
2227         Prevent stderr output from messing up detection of build path
2228
2229         https://bugs.webkit.org/show_bug.cgi?id=88075
2230
2231         Warnings such as 'perl: warning: Setting locale failed' will otherwise
2232         end up as the build path when calling out to webkit-build-directory.
2233
2234         Reviewed by Ojan Vafai.
2235
2236         * Scripts/webkitpy/layout_tests/port/config.py:
2237         (Config.build_directory):
2238
2239 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2240
2241         Update the builder name for Apple Lion builders.
2242
2243         * Scripts/webkitpy/layout_tests/port/builders.py:
2244
2245 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
2246
2247         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
2248         https://bugs.webkit.org/show_bug.cgi?id=88874
2249
2250         Reviewed by Simon Hausmann.
2251
2252         Rename main.cpp in QtTestBrowser because on Windows
2253         it conflicts with main.cpp from DumpRenderTree.
2254
2255         * QtTestBrowser/QtTestBrowser.pro:
2256         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
2257         (launcherMain):
2258         (LauncherApplication):
2259         (LauncherApplication::urls):
2260         (LauncherApplication::isRobotized):
2261         (LauncherApplication::robotTimeout):
2262         (LauncherApplication::robotExtraTime):
2263         (LauncherApplication::applyDefaultSettings):
2264         (LauncherApplication::LauncherApplication):
2265         (requiresGraphicsView):
2266         (LauncherApplication::handleUserOptions):
2267         (main):
2268
2269 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2270
2271         Wrap bot types inside ().
2272         https://bugs.webkit.org/show_bug.cgi?id=88893
2273         
2274         Reviewed by Stephanie Lewis.
2275
2276         * BuildSlaveSupport/build.webkit.org-config/config.json:
2277
2278 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2279
2280         [soup] Prevent setting or editing httpOnly cookies from JavaScript
2281         https://bugs.webkit.org/show_bug.cgi?id=88760
2282
2283         Reviewed by Gustavo Noronha Silva.
2284
2285         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
2286         to v2.33.2 for both GTK and EFL ports.
2287
2288         * efl/jhbuild.modules:
2289         * gtk/jhbuild.modules:
2290
2291 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2292
2293         [EFL] Enable SHADOW_DOM flag
2294         https://bugs.webkit.org/show_bug.cgi?id=87732
2295
2296         Reviewed by Kentaro Hara.
2297
2298         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2299         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
2300         SHADOW_DOM by default in DRT.
2301         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2302         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
2303         Chromium and Mac ports.
2304         (drtViewAdd):
2305         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
2306         at compile time for EFL port.
2307
2308 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2309
2310         WinLauncher should show loading errors
2311         https://bugs.webkit.org/show_bug.cgi?id=80760
2312
2313         Reviewed by Brent Fulgham.
2314
2315         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
2316         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2317         * WinLauncher/WinLauncher.h:
2318         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2319         (WinLauncherWebHost):
2320
2321 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
2322
2323         [EFL][WK2] Add MiniBrowserEfl.
2324         https://bugs.webkit.org/show_bug.cgi?id=61850
2325
2326         Reviewed by Chang Shu.
2327
2328         Implement MiniBrowser for EFL.
2329
2330         * CMakeLists.txt:
2331         * MiniBrowser/efl/CMakeLists.txt: Added.
2332         * MiniBrowser/efl/main.c: Added.
2333         (_MiniBrowser):
2334         (main_signal_exit):
2335         (on_ecore_evas_resize):
2336         (browserCreate):
2337         (main):
2338
2339 2012-06-12  Helder Correia  <helder.correia@nokia.com>
2340
2341         Unreviewed. Update my email address in committers.py.
2342
2343         * Scripts/webkitpy/common/config/committers.py:
2344
2345 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
2346
2347         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2348         https://bugs.webkit.org/show_bug.cgi?id=84707
2349
2350         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
2351         use_lib64 variable is preconfigured to True by jhbuild.
2352
2353         Reviewed by Dirk Pranke.
2354
2355         * efl/jhbuildrc:
2356
2357 2012-06-12  Dana Jansens  <danakj@chromium.org>
2358
2359         Add zlieber@chromium.org to contributors list
2360         https://bugs.webkit.org/show_bug.cgi?id=88904
2361
2362         Unreviewed.
2363
2364         * Scripts/webkitpy/common/config/committers.py:
2365
2366 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2367
2368         Rename Apple bots to a standard convention.
2369         https://bugs.webkit.org/show_bug.cgi?id=88893
2370         
2371         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
2372
2373         Reviewed by Simon Fraser.
2374
2375         * BuildSlaveSupport/build.webkit.org-config/config.json:
2376
2377 2012-06-12  Mike West  <mkwst@chromium.org>
2378
2379         Make document.documentURI readonly from JavaScript
2380         https://bugs.webkit.org/show_bug.cgi?id=65187
2381
2382         Reviewed by Alexey Proskuryakov.
2383
2384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2385         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
2386         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
2387         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
2388         (TestWebKitAPI):
2389         (TestWebKitAPI::TEST):
2390
2391 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2392
2393         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
2394         https://bugs.webkit.org/show_bug.cgi?id=88715
2395
2396         Reviewed by Noam Rosenthal.
2397
2398         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
2399
2400         * Scripts/webkitperl/FeatureList.pm:
2401
2402 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2403
2404         [Qt] Fix -Werror for the buildbots
2405         https://bugs.webkit.org/show_bug.cgi?id=88223
2406
2407         Rubber-stamped by Tor Arne Vestbø.
2408
2409         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
2410
2411         * qmake/mkspecs/features/unix/default_post.prf:
2412
2413 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
2414
2415         [REGRESSION][WTR] Build fail with werror after r120054
2416         https://bugs.webkit.org/show_bug.cgi?id=88862
2417
2418         Reviewed by Csaba Osztrogonác.
2419
2420         Some static helpers become unused after counterValueForElementById
2421         has moved to Internals. Let's remove them.
2422
2423         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2424         (WTR):
2425
2426 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2427
2428         [Qt] Slave losts cause build break on bots
2429         https://bugs.webkit.org/show_bug.cgi?id=38980
2430
2431         Minor fix after r59261.
2432
2433         Reviewed by Tor Arne Vestbø.
2434
2435         * Scripts/build-webkit:
2436         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
2437
2438 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2439
2440         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
2441         https://bugs.webkit.org/show_bug.cgi?id=84406
2442
2443         Reviewed by Hajime Morita.
2444
2445         Move the counterValueForElementById from LayoutTestCotroller to Internals and
2446         remove the old platform specific implementations as it exclusively tests WebCore functionality.
2447
2448         * DumpRenderTree/LayoutTestController.cpp:
2449         (LayoutTestController::staticFunctions):
2450         * DumpRenderTree/LayoutTestController.h:
2451         (LayoutTestController):
2452         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2453         * DumpRenderTree/chromium/LayoutTestController.cpp:
2454         (LayoutTestController::LayoutTestController):
2455         (LayoutTestController::setPOSIXLocale):
2456         * DumpRenderTree/chromium/LayoutTestController.h:
2457         (LayoutTestController):
2458         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2459         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2460         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2461         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2462         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2463         (LayoutTestController):
2464         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2465         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2466         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2467         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2468         (WTR):
2469         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2470         (LayoutTestController):
2471
2472 2012-06-11  Hans Wennborg  <hans@chromium.org>
2473
2474         Speech JavaScript API: Make SpeechRecognitionError an Event
2475         https://bugs.webkit.org/show_bug.cgi?id=88784
2476
2477         Reviewed by Adam Barth.
2478
2479         Make it possible to have MockWebSpeechRecognizer fire error events.
2480
2481         * DumpRenderTree/chromium/LayoutTestController.cpp:
2482         (LayoutTestController::LayoutTestController):
2483         (LayoutTestController::setMockSpeechRecognitionError):
2484         * DumpRenderTree/chromium/LayoutTestController.h:
2485         (LayoutTestController):
2486         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2487         (WebKit):
2488         (ErrorTask):
2489         (WebKit::ErrorTask::ErrorTask):
2490         (MockWebSpeechRecognizer::addMockResult):
2491         (MockWebSpeechRecognizer::setError):
2492         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2493         (MockWebSpeechRecognizer):
2494
2495 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2496
2497         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
2498         https://bugs.webkit.org/show_bug.cgi?id=88836
2499
2500         Reviewed by Dirk Pranke.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2504
2505 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
2506
2507         [EFL] Remove CMakeCache.txt before building
2508         https://bugs.webkit.org/show_bug.cgi?id=88717
2509
2510         Reviewed by Antonio Gomes.
2511
2512         Remove CMake cache file before every build to avoid using outdated
2513         build flags when new features get enabled. This will avoid unexpected
2514         failures on the bots due to outdated build flags.
2515
2516         * Scripts/webkitdirs.pm:
2517         (generateBuildSystemFromCMakeProject):
2518
2519 2012-06-11  Vincent Scheib  <scheib@chromium.org>
2520
2521         Add new Pointer Lock spec attribute webkitPointerLockElement.
2522         https://bugs.webkit.org/show_bug.cgi?id=88799
2523
2524         Reviewed by Dimitri Glazkov.
2525
2526         Part of a series of refactoring changes to update pointer lock API to
2527         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
2528
2529         New attribute webkitPointerLockElement added. Follow up patches
2530         will remove the previous isLocked attribute. Tests updated to use
2531         the new attribute.
2532
2533         WebViewHost logic required modification to correctly repond to
2534         a lock, unlock, pointerLockElement call series. Specifically,
2535         unlocking must be queued after a lock command is issued always
2536         as the lock state may not be set yet with a lock request in flight.
2537
2538         * DumpRenderTree/chromium/WebViewHost.cpp:
2539         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
2540         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
2541
2542 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
2543
2544         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
2545         https://bugs.webkit.org/show_bug.cgi?id=88804
2546
2547         Reviewed by Tony Chang.
2548
2549         Protect box-decoration-break behind a feature flag enabled by default.
2550
2551         * Scripts/webkitperl/FeatureList.pm:
2552         * qmake/mkspecs/features/features.pri:
2553
2554 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2555
2556         [CMAKE][EFL] Remove duplicated executable output path
2557         https://bugs.webkit.org/show_bug.cgi?id=88765
2558
2559         Reviewed by Daniel Bates.
2560
2561         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
2562         need to define again because it is already defined in top-level CMake file.
2563
2564         * DumpRenderTree/efl/CMakeLists.txt:
2565         * EWebLauncher/CMakeLists.txt:
2566
2567 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2568
2569         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
2570         https://bugs.webkit.org/show_bug.cgi?id=88816
2571
2572         Reviewed by Dirk Pranke.
2573
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2575         Expose a way to clear AsynchronousCaches.
2576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2578         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
2579
2580 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
2581
2582         nrwt exits early too frequently
2583         https://bugs.webkit.org/show_bug.cgi?id=73843
2584
2585         Reviewed by Ryosuke Niwa.
2586
2587         Change the defaults for new-run-webkit-tests for both
2588         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
2589         to zero (i.e., we will never exit early by default).
2590
2591         If people want their buildbots to exit early it is their
2592         responsibility to update their buildbot configs appropriately.
2593
2594         Note that we have tests that ensure that these flags work for
2595         non-zero numbers, but we don't have tests that either test the
2596         default or ensure that zero means "run all of the tests". I
2597         think that's okay but can add tests if others disagree.
2598
2599         Also note that it looks like no changes on the build.webkit.org
2600         master.cfg are necessary; all of the bots seem to be using the
2601         RunWebKitTests wrapper which is already setting the flags. There
2602         is a NewRunWebKitTests wrapper, but that looks to be unused; I
2603         will delete that in a separate patch.
2604
2605         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2606         (parse_args):
2607
2608 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2609
2610         [EFL] [DRT] Reset CacheModel before running each test
2611         https://bugs.webkit.org/show_bug.cgi?id=87534
2612
2613         Reviewed by Gustavo Noronha Silva.
2614
2615         Reset cache model to default before running each test to fix some
2616         flaky tests on EFL build bots. Also fix case value in setCacheModel.
2617
2618         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2619         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2620         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2621         (LayoutTestController::setCacheModel):
2622
2623 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2624
2625         [GTK] Memory leaks in DRT EventSender.cpp
2626         https://bugs.webkit.org/show_bug.cgi?id=88774
2627
2628         Reviewed by Martin Robinson.
2629
2630         Fix a few possible memory leaks in EventSender code.
2631
2632         * DumpRenderTree/gtk/EventSender.cpp:
2633         (contextClickCallback): Free the event returned by gdk_event_new().
2634         (mouseDownCallback): Ditto.
2635         (mouseUpCallback): Ditto.
2636
2637 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2638
2639         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
2640         https://bugs.webkit.org/show_bug.cgi?id=88661
2641
2642         Reviewed by Dirk Pranke.
2643
2644         Pass string length explicitly when creating String object from
2645         non-null-terminated UChar* returned by characters().
2646
2647         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2648         (LayoutTestController::pathToLocalResource):
2649
2650 2012-06-11  David Dorwin  <ddorwin@chromium.org>
2651
2652         [chromium] Provide access to the WebPlugin created by the helper plugin widget
2653         https://bugs.webkit.org/show_bug.cgi?id=88028
2654
2655         Reviewed by Adam Barth.
2656
2657         Added isPlaceholder() to WebPlugin.
2658
2659         * DumpRenderTree/chromium/TestWebPlugin.h:
2660         (TestWebPlugin::isPlaceholder):
2661
2662 2012-06-11  Tony Chang  <tony@chromium.org>
2663
2664         rebaseline from garden-o-matic leaves N processes each time it is run
2665         https://bugs.webkit.org/show_bug.cgi?id=88586
2666
2667         Reviewed by Dirk Pranke.
2668
2669         This appears to only be a problem on python 2.7. Maybe a bug causing
2670         pools to not be garbage collected?
2671
2672         * Scripts/webkitpy/common/system/executive.py:
2673         (Executive.run_in_parallel): close() and join() the process pool.
2674         * Scripts/webkitpy/common/system/executive_unittest.py:
2675         (ExecutiveTest.test_run_in_parallel):
2676
2677 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
2678
2679         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
2680         https://bugs.webkit.org/show_bug.cgi?id=87841
2681
2682         Reviewed by Simon Hausmann.
2683
2684         * qmake/config.tests/libwebp/libwebp.cpp: Added.
2685         (main):
2686         * qmake/config.tests/libwebp/libwebp.pro: Added.
2687         * qmake/sync.profile:
2688
2689 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
2690
2691         Expose layoutTestController as testRunner
2692         https://bugs.webkit.org/show_bug.cgi?id=88210
2693
2694         Reviewed by Darin Adler.
2695
2696         * DumpRenderTree/LayoutTestController.cpp:
2697         (LayoutTestController::makeWindowObject):
2698         * DumpRenderTree/chromium/TestShell.cpp:
2699         (TestShell::bindJSObjectsToWindow):
2700         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2701         (WebCore::DumpRenderTree::initJSObjects):
2702         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2703         (WTR::LayoutTestController::makeWindowObject):
2704
2705 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
2706
2707         [Chromium] Remove JavaScriptCore dependencies from gyp
2708         https://bugs.webkit.org/show_bug.cgi?id=88510
2709
2710         Reviewed by Adam Barth.
2711
2712         Chromium doesn't support JSC any more and there doesn't seem to be
2713         a strong interest in using GYP as the common build system in other
2714         ports.
2715
2716         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2717         * Scripts/generate-project-files: Removed.
2718
2719 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
2720
2721         Add UNDO_MANAGER flag
2722         https://bugs.webkit.org/show_bug.cgi?id=87908
2723
2724         Reviewed by Tony Chang.
2725
2726         * Scripts/webkitperl/FeatureList.pm:
2727         * qmake/mkspecs/features/features.pri:
2728
2729 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2730
2731         webkit-patch land-safely should set cq? if the patch author is not in committers.py
2732         https://bugs.webkit.org/show_bug.cgi?id=88689
2733
2734         Reviewed by Dirk Pranke.
2735
2736         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
2737         in committers.py or the contributor cannot commit. If anything, the contributor can still
2738         set cq+ on thier patches manually so I don't think this will be an issue for people who
2739         don't list their Bugzille email on committers.py.
2740
2741         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2742         (Bugzilla._commit_queue_flag):
2743         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2744         (test_commit_queue_flag):
2745         (test_commit_queue_flag.assert_commit_queue_flag):
2746
2747 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
2748
2749         remove obsolete NewRunWebKitTests buildbot master factory classes
2750         https://bugs.webkit.org/show_bug.cgi?id=88693
2751
2752         Reviewed by Ryosuke Niwa.
2753
2754         I believe these aren't used any more ...
2755
2756         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2757         (RunWebKitTests.getText2):
2758         (BuildAndTestLeaksFactory):
2759
2760 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2761
2762         [Chromium-Android] Build DumpRenderTree with Android SDK
2763         https://bugs.webkit.org/show_bug.cgi?id=88598
2764
2765         Change WebKit side of DRT related code according to some recent changes at chromium side.
2766
2767         Reviewed by Adam Barth.
2768
2769         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2770         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2771         (ChromiumAndroidPort.__init__):
2772         (ChromiumAndroidPort._path_to_driver):
2773
2774 2012-06-08  Wei James  <james.wei@intel.com>
2775
2776         Add app_abi option for DumpRenderTree_apk
2777         https://bugs.webkit.org/show_bug.cgi?id=88626
2778
2779         Reviewed by Adam Barth.
2780
2781         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2782
2783 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2784
2785         [GTK] Add API to get the library version to WebKit2 GTK+
2786         https://bugs.webkit.org/show_bug.cgi?id=88426
2787
2788         Reviewed by Martin Robinson.
2789
2790         * gtk/generate-gtkdoc:
2791         (get_webkit2_options): Add built sources to the list of files, but
2792         ignore enum types and marshallers.
2793
2794 2012-06-07  Vincent Scheib  <scheib@chromium.org>
2795
2796         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
2797         https://bugs.webkit.org/show_bug.cgi?id=88604
2798
2799         Reviewed by Kent Tamura.
2800
2801         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
2802         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
2803
2804         * DumpRenderTree/chromium/WebViewHost.cpp:
2805         (WebViewHost::requestPointerUnlock):
2806
2807 2012-06-08  Hans Wennborg  <hans@chromium.org>
2808
2809         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
2810         https://bugs.webkit.org/show_bug.cgi?id=87976
2811
2812         Reviewed by Kent Tamura.
2813
2814         Provide a mock implementation of WebSpeechRecognizer for
2815         DumpRenderTree. This will allow better testing of the API via layout
2816         tests.
2817
2818         * DumpRenderTree/DumpRenderTree.gypi:
2819         * DumpRenderTree/chromium/LayoutTestController.cpp:
2820         (LayoutTestController::LayoutTestController):
2821         (LayoutTestController::addMockSpeechRecognitionResult):
2822         * DumpRenderTree/chromium/LayoutTestController.h:
2823         (LayoutTestController):
2824         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
2825         (MockWebSpeechRecognizer::create):
2826         (MockWebSpeechRecognizer::start):
2827         (MockWebSpeechRecognizer::stop):
2828         (MockWebSpeechRecognizer::abort):
2829         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2830         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
2831         (MockWebSpeechRecognizer::ResultTask::runIfValid):
2832         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
2833         (WebKit):
2834         (MockWebSpeechRecognizer):
2835         (MockWebSpeechRecognizer::addMockResult):
2836         (MockWebSpeechRecognizer::taskList):
2837         (ClientCallTask):
2838         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
2839         (ResultTask):
2840         (MockWebSpeechRecognizer::ResultTask::ResultTask):
2841         (NoMatchTask):
2842         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
2843         * DumpRenderTree/chromium/WebViewHost.cpp:
2844         (WebViewHost::speechRecognizer):
2845         * DumpRenderTree/chromium/WebViewHost.h:
2846         (WebViewHost):
2847         (WebViewHost::mockSpeechRecognizer):
2848
2849 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
2850
2851         check-webkit-style needs to be taught about <public/Foo.h>
2852         https://bugs.webkit.org/show_bug.cgi?id=88524
2853
2854         Reviewed by David Levin.
2855
2856         * Scripts/webkitpy/style/checkers/cpp.py:
2857         (_classify_include):
2858         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2859         (OrderOfIncludesTest.test_public_primary_header):
2860         (OrderOfIncludesTest.test_classify_include):
2861
2862 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
2863
2864         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2865         https://bugs.webkit.org/show_bug.cgi?id=67255
2866
2867         Reviewed by Dirk Pranke.
2868
2869         Implement pathToLocalResource to redirect file:///tmp URL's to
2870         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
2871         LayoutTests sub-directory of the WebKit source tree.
2872
2873         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2874         (LayoutTestController::pathToLocalResource):
2875
2876 2012-06-07  Tony Payne  <tpayne@chromium.org>
2877
2878         [chromium] Allow LayoutTests under new git workflow
2879         https://bugs.webkit.org/show_bug.cgi?id=88575
2880
2881         On Windows, chromium indirects through git.bat. Adds the same hack that
2882         is currently used for discovering svn.bat to support the new git
2883         workflow.
2884
2885         Reviewed by Dirk Pranke.
2886
2887         * Scripts/webkitpy/common/checkout/scm/git.py:
2888         (Git): Replaces all hard-coded references to 'git' with the class
2889         variable executable_name.
2890         (Git._check_git_architecture):
2891         (Git.in_working_directory):
2892         (Git.find_checkout_root):
2893         (Git.read_git_config):
2894         (Git.discard_local_commits):
2895         (Git.local_commits):
2896         (Git.working_directory_is_clean):
2897         (Git.clean_working_directory):
2898         (Git.status_command):
2899         (Git.add_list):
2900         (Git.delete_list):
2901         (Git.exists):
2902         (Git._current_branch):
2903         (Git.changed_files):
2904         (Git._changes_files_for_commit):
2905         (Git.revisions_changing_file):
2906         (Git.conflicted_files):
2907         (Git.svn_revision):
2908         (Git.create_patch):
2909         (Git._run_git_svn_find_rev):
2910         (Git.contents_at_revision):
2911         (Git.diff_for_file):
2912         (Git.show_head):
2913         (Git.committer_email_for_revision):
2914         (Git.apply_reverse_diff):
2915         (Git.revert_files):
2916         (Git.commit_with_message):
2917         (Git._commit_on_branch):
2918         (Git.svn_commit_log):
2919         (Git.last_svn_commit_log):
2920         (Git.svn_blame):
2921         (Git._branch_ref_exists):
2922         (Git.delete_branch):
2923         (Git.remote_merge_base):
2924         (Git.commit_locally_with_message):
2925         (Git.push_local_commits_to_server):
2926         (Git.commit_ids_from_commitish_arguments):
2927         (Git.commit_message_for_local_commit):
2928         (Git.files_changed_summary_for_commit):
2929         * Scripts/webkitpy/common/host.py:
2930         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
2931         that duplicates the logic in the existing 'svn.bat' hack.
2932
2933 2012-06-07  Ojan Vafai  <ojan@chromium.org>
2934
2935         Style build architectures like build versions for non-layout test failures
2936         https://bugs.webkit.org/show_bug.cgi?id=88590
2937
2938         Reviewed by Tony Chang.
2939
2940         Since we show the list of failing tests after the architecture, we want the
2941         buildtype and architecture to be grouped together visually.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2944         (.effects a.failing-builder>span.architecture):
2945
2946 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2947
2948         [Chromium] Remove header dependency of ImageDiff to WTF
2949         https://bugs.webkit.org/show_bug.cgi?id=88422
2950
2951         Reviewed by Ryosuke Niwa.
2952
2953         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2954         * DumpRenderTree/chromium/ImageDiff.cpp:
2955         (untestedCompareImages):
2956
2957 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
2958
2959         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
2960         https://bugs.webkit.org/show_bug.cgi?id=88491
2961
2962         Reviewed by Dirk Pranke.
2963
2964         DRT should enable WebAudio when WebAudio feature is enabled,
2965         so that the WebAudio feature could be tested by the Layouttest.
2966
2967         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
2968         (LayoutTestController::overridePreference):
2969
2970 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
2971
2972         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
2973         https://bugs.webkit.org/show_bug.cgi?id=88581
2974
2975         Reviewed by Ojan Vafai.
2976
2977         webkit-paptch rebaseline-expectations was ignoring what the
2978         expected results for a test were and pulling down all the result
2979         files from a bot. This could lead to us pulling down old,
2980         incorrect .txt or .png files. With this patch we will now only
2981         pull down expectations of the appropriate file types (so an
2982         IMAGE failure will only pull the png and not the txt file).
2983
2984         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2985         (has_pixel_failures):
2986         (suffixes_for_expectations):
2987         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2988         (FunctionsTest.test_suffixes_for_expectations):
2989         * Scripts/webkitpy/tool/commands/rebaseline.py:
2990         (AbstractRebaseliningCommand.__init__):
2991         (RebaselineExpectations._is_supported_port):
2992         (RebaselineExpectations._update_expectations_file):
2993         (RebaselineExpectations._tests_to_rebaseline):
2994         (RebaselineExpectations._rebaseline_port):
2995         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2996         (test_overrides_are_included_correctly):
2997
2998 2012-06-07  Ojan Vafai  <ojan@chromium.org>
2999
3000         Fix recent null pointer error regression in the flakiness dashboard
3001         https://bugs.webkit.org/show_bug.cgi?id=88573
3002
3003         Reviewed by Dirk Pranke.
3004
3005         * TestResultServer/static-dashboards/builders.js:
3006         (requestBuilderList):
3007         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3008
3009 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
3010
3011         Add Konrad Piascik to committers.py
3012         https://bugs.webkit.org/show_bug.cgi?id=88560
3013
3014         Unreviewed.
3015
3016         * Scripts/webkitpy/common/config/committers.py:
3017
3018 2012-06-07  Tony Chang  <tony@chromium.org>
3019
3020         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
3021         https://bugs.webkit.org/show_bug.cgi?id=77368
3022
3023         Reviewed by Ojan Vafai.
3024
3025         It doesn't look like we ever get a rect with width or height of 0.
3026         I ran css1, css2.1, fast/forms, and tables without any crashes.
3027
3028         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3029         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
3030
3031 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3032
3033         run-webkit-tests --lint-test-files gives an error when run on linux
3034         https://bugs.webkit.org/show_bug.cgi?id=88551
3035
3036         Reviewed by Ojan Vafai.
3037
3038         We weren't mapping the expectations properly for the
3039         google-chrome ports.
3040
3041         * Scripts/webkitpy/layout_tests/port/base.py:
3042         (Port.path_to_test_expectations_file):
3043         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3044         (TestGoogleChromePort.test_path_to_expectations):
3045
3046 2012-06-07  Daniel Erat  <derat@chromium.org>
3047
3048         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
3049         https://bugs.webkit.org/show_bug.cgi?id=88263
3050
3051         Reviewed by Tony Chang.
3052
3053         * DumpRenderTree/chromium/LayoutTestController.cpp:
3054         (LayoutTestController::LayoutTestController):
3055         (LayoutTestController::reset):
3056         (LayoutTestController::setTextSubpixelPositioning):
3057         * DumpRenderTree/chromium/LayoutTestController.h:
3058         (LayoutTestController):
3059         * DumpRenderTree/chromium/fonts.conf:
3060
3061 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
3062
3063         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
3064         https://bugs.webkit.org/show_bug.cgi?id=88060
3065
3066         Reviewed by Martin Robinson.
3067
3068         Spin the main loop before acquiring the pixel content. This ensures things
3069         like late size allocations are finished before calling gtk_widget_draw,
3070         avoiding assertions and subsequent empty pixel results.
3071
3072         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3073         (createBitmapContextFromWebView):
3074
3075 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3076
3077         [Qt] Improve the visual of the viewport info box
3078         https://bugs.webkit.org/show_bug.cgi?id=88410
3079
3080         Reviewed by Tor Arne Vestbø.
3081
3082         Improve the visual and make it possible to see the content more easy.
3083
3084         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3085
3086 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
3087
3088         [EFL][WK2] Compile webkit1 and webkit2 by default.
3089         https://bugs.webkit.org/show_bug.cgi?id=85041
3090
3091         Reviewed by Chang Shu.
3092
3093         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
3094         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
3095
3096         * Scripts/build-webkit:
3097
3098 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3099
3100         Unreviewed, rolling out r119662.
3101         http://trac.webkit.org/changeset/119662
3102         https://bugs.webkit.org/show_bug.cgi?id=88487
3103
3104         Broke builds (Requested by rniwa on #webkit).
3105
3106         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3107         * DumpRenderTree/chromium/ImageDiff.cpp:
3108         (untestedCompareImages):
3109
3110 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3111
3112         [Chromium] Remove header dependency of ImageDiff to WTF
3113         https://bugs.webkit.org/show_bug.cgi?id=88422
3114
3115         Reviewed by Adam Barth.
3116
3117         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3118         * DumpRenderTree/chromium/ImageDiff.cpp:
3119         (untestedCompareImages):
3120
3121 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
3122
3123         [WebKit] DeviceOrientation cleanup
3124         https://bugs.webkit.org/show_bug.cgi?id=88406
3125
3126         Reviewed by Kent Tamura.
3127
3128         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
3129
3130         * DumpRenderTree/chromium/LayoutTestController.cpp:
3131         (LayoutTestController::setMockDeviceOrientation):
3132
3133 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
3134
3135         webkitpy: add support for an ordered dict of test expectations
3136         https://bugs.webkit.org/show_bug.cgi?id=87802
3137
3138         Reviewed by Ojan Vafai.
3139
3140         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
3141         support a cascaded list of test expectations files. An easy way
3142         to think of this is as an ordered dictionary of name -> contents
3143         for files, where the name is usually a path on disk (I say
3144         usually because we want to support other kinds of expectations
3145         like the compile-time skips for unsupported features in
3146         webkit.py, and we want to continue to support "in-memory" test
3147         expectations that don't require a filesystem).
3148
3149         Conveniently there is an OrderedDict implementation in Python
3150         2.7+ and it is available as a backport, so the first step in
3151         adding this support is to use that implementation. Subsequent
3152         patches will update the test_expectations.py module (and other
3153         callers) to access the dict directly.
3154
3155         This patch just changes the base internal implementation and
3156         provides wrappers for compatibility. The derived ports
3157         (WebKitPort, TestPort, etc.) still need to be updated.
3158
3159         * Scripts/webkitpy/layout_tests/port/base.py:
3160         (Port._expectations_dict):
3161         (Port.test_expectations):
3162         (Port):
3163         (Port._expectations_overrides_dict):
3164         (Port.test_expectations_overrides):
3165         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3166         (PortTestCase.test_expectations_ordering):
3167         (PortTestCase):
3168         (PortTestCase.test_expectations_overrides_ordering):
3169         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
3170         (OrderedDict):
3171         (OrderedDict.__init__):
3172         (OrderedDict.clear):
3173         (OrderedDict.__setitem__):
3174         (OrderedDict.__delitem__):
3175         (OrderedDict.__iter__):
3176         (OrderedDict.__reversed__):
3177         (OrderedDict.popitem):
3178         (OrderedDict.__reduce__):
3179         (OrderedDict.__repr__):
3180         (OrderedDict.copy):
3181         (OrderedDict.fromkeys):
3182
3183 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
3184
3185         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
3186
3187         * gtk/run-api-tests:
3188         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
3189
3190 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3191
3192         nrwt should look in 'out' for binaries on chromium win to support ninja
3193         https://bugs.webkit.org/show_bug.cgi?id=88273
3194
3195         Reviewed by Tony Chang.
3196
3197         This patch standardizes the search algorithm the chromium ports
3198         use to figure out which driver to run. We will look in a
3199         chromium location before a webkit location (e.g., in
3200         Source/WebKit/chromium/out before out/) and we will look in the
3201         "legacy" directory (xcodebuild) before the directory ninja uses
3202         (out).
3203
3204         Unfortunately due to the way the test code is set up testing the
3205         properly requires some duplication of test code. I will fix that
3206         in a followup patch.
3207
3208         * Scripts/webkitpy/layout_tests/port/chromium.py:
3209         (ChromiumPort):
3210         (ChromiumPort._static_build_path):
3211         (ChromiumPort._build_path):
3212         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3213         (ChromiumLinuxPort):
3214         (ChromiumLinuxPort._determine_driver_path_statically):
3215         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3216         (ChromiumLinuxPortTest.test_build_path):
3217         (ChromiumLinuxPortTest):
3218         (ChromiumLinuxPortTest.test_driver_name_option):
3219         (ChromiumLinuxPortTest.path_to_image_diff):
3220         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3221         (ChromiumMacPort):
3222         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3223         (ChromiumMacPortTest.test_build_path):
3224         (ChromiumMacPortTest):
3225         (ChromiumMacPortTest.test_driver_name_option):
3226         (ChromiumMacPortTest.path_to_image_diff):
3227         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3228         (ChromiumPortTest.test_overrides_and_builder_names):
3229         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3230         (ChromiumWinPort):
3231         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3232         (ChromiumWinTest.test_build_path):
3233         (ChromiumWinTest.test_operating_system):
3234         (ChromiumWinTest):
3235         (ChromiumWinTest.test_driver_name_option):
3236         (ChromiumWinPortTest.path_to_image_diff):
3237         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3238         (PortTestCase.assert_build_path):
3239
3240 2012-06-06  Jessie Berlin  <jberlin@apple.com>
3241
3242         Remove very red Windows WebKit2 testers
3243         https://bugs.webkit.org/show_bug.cgi?id=88452
3244
3245         Reviewed by Steve Falkenburg.
3246
3247         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
3248         need to focus on getting the WK1 testers green.
3249
3250         * BuildSlaveSupport/build.webkit.org-config/config.json:
3251
3252 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3253
3254         get rebaselining tools to kinda work with the skia overrides file
3255         https://bugs.webkit.org/show_bug.cgi?id=88456
3256
3257         Reviewed by Ryosuke Niwa.
3258
3259         Update rebaseline-expectations so that we read in the overrides
3260         when looking for tests to rebaseline, but don't read in the
3261         overrides when we are writing the expectations file back out.
3262         This prevents the overrides from getting written into the main
3263         file. This is kind of a hack but will have to do until we
3264         support multiple expectations files properly.
3265
3266         * Scripts/webkitpy/tool/commands/rebaseline.py:
3267         (RebaselineExpectations._expectations):
3268         (RebaselineExpectations._update_expectations_file):
3269         (RebaselineExpectations._tests_to_rebaseline):
3270         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3271         (test_overrides_are_included_correctly):
3272
3273 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3274
3275         webkitpy: two manager_worker_broker_unittest tests are broken
3276         https://bugs.webkit.org/show_bug.cgi?id=88445
3277
3278         Reviewed by Ojan Vafai.
3279
3280         These tests were never updated when we removed the
3281         --worker-model argument, and we were passing 'inline' instead of
3282         1 (for the number of workers) :(. As a result we were creating
3283         multiprocessing queues unnecessarily and that was failing on cygwin.
3284
3285         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3286         (InterfaceTest.test_managerconnection_is_abstract):
3287         (InterfaceTest.test_workerconnection_is_abstract):
3288
3289 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3290
3291         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
3292         https://bugs.webkit.org/show_bug.cgi?id=87406
3293
3294         Reviewed by Dirk Pranke.
3295
3296         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3297         (TestExpectations.__init__):
3298         * Scripts/webkitpy/tool/commands/rebaseline.py:
3299         (RebaselineTest._update_expectations_file):
3300         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3301         (test_rebaseline_does_not_include_overrides):
3302
3303 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3304
3305         webkitpy: perf tests unit tests fail on chromium win
3306         https://bugs.webkit.org/show_bug.cgi?id=88279
3307
3308         Reviewed by Ryosuke Niwa.
3309
3310         I'm seeing weird failures running the unit tests in my win32
3311         checkout, and we don't really expect webpagereplay to work on
3312         win32 anyway, so I'm skipping the import of that module for now
3313         and adding a warning.
3314
3315         * Scripts/run-perf-tests:
3316         * Scripts/webkitpy/performance_tests/perftest.py:
3317
3318 2012-06-06  Yong Li <yoli@rim.com>
3319
3320         Unreviewed. Update my email address in committers.py.
3321
3322         * Scripts/webkitpy/common/config/committers.py:
3323
3324 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
3325
3326         Add Robert Kroeger  to commiters.py
3327         https://bugs.webkit.org/show_bug.cgi?id=88415
3328
3329         Unreviewed.
3330
3331         * Scripts/webkitpy/common/config/committers.py:
3332
3333 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3334
3335         [EFL][DRT] http/tests/globalhistory testcases do not pass
3336         https://bugs.webkit.org/show_bug.cgi?id=82579
3337
3338         Reviewed by Csaba Osztrogonác.
3339
3340         DRT has provided callbacks for ewk_view "global history delegate" signals.
3341
3342         * DumpRenderTree/efl/DumpRenderTree.cpp:
3343         (isGlobalHistoryTest): Aux function to ident global history testcase.
3344         (createLayoutTestController):
3345         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3346         (DumpRenderTreeChrome::createView):
3347         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
3348         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
3349         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
3350         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
3351         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
3352         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3353         (DumpRenderTreeChrome):
3354
3355 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
3356
3357         [Qt] run-qtwebkit-tests hangs with -j1
3358         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
3359         This could happen due to an uncancelled timer after results were returned. This timer was
3360         started only if --timeout was set.
3361         https://bugs.webkit.org/show_bug.cgi?id=85475
3362
3363         Reviewed by Csaba Osztrogonác.
3364
3365         * Scripts/run-qtwebkit-tests:
3366         (run_test):
3367
3368 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
3369
3370         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
3371         https://bugs.webkit.org/show_bug.cgi?id=88327
3372
3373         Reviewed by Kenneth Rohde Christiansen.
3374
3375         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
3376         * MiniBrowser/qt/icons/contents_width.png: Added.
3377         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
3378         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
3379
3380 2012-06-05  Jon Lee  <jonlee@apple.com>
3381
3382         Buildbot fix.
3383
3384         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
3385         in the function. Store in a local variable.
3386         (loadBuilderConfig):
3387
3388 2012-06-05  Jon Lee  <jonlee@apple.com>
3389
3390         Buildbot fix.
3391
3392         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3393         (loadBuilderConfig):
3394
3395 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3396
3397         webkitpy: clean up win-specific path handling and tests
3398         https://bugs.webkit.org/show_bug.cgi?id=88281
3399
3400         Reviewed by Adam Barth.
3401
3402         There was a bunch of inconsistent logic for handling path
3403         conversions for win32 and cygwin paths due to us sometimes
3404         looking at sys.platform and sometimes using mock hosts. This
3405         patch cleans everything up so that we are required to pass
3406         PlatformInfo objects to the path module and stop trying to do
3407         different things when running on cygwin or win32 hosts (except
3408         in the path_unittest module itself).
3409
3410         This may slightly reduce test coverage for the win32 code paths
3411         but will be a lot easier to follow and maintain.
3412
3413         * Scripts/webkitpy/common/system/path.py:
3414         (abspath_to_uri):
3415         (_convert_path):
3416         * Scripts/webkitpy/common/system/path_unittest.py:
3417         (AbspathTest.platforminfo):
3418         (AbspathTest.test_abspath_to_uri_cygwin):
3419         (AbspathTest.test_abspath_to_uri_unixy):
3420         (AbspathTest.test_abspath_to_uri_win):
3421         (AbspathTest.test_abspath_to_uri_escaping_unixy):
3422         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
3423         (AbspathTest.test_stop_cygpath_subprocess):
3424         * Scripts/webkitpy/common/system/platforminfo.py:
3425         (PlatformInfo.__init__):
3426         (PlatformInfo.is_cygwin):
3427         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3428         (MockPlatformInfo.is_cygwin):
3429         * Scripts/webkitpy/layout_tests/port/base.py:
3430         (Port.to.show_results_html_file):
3431         * Scripts/webkitpy/layout_tests/port/driver.py:
3432         (Driver.test_to_uri):
3433         (Driver.uri_to_test):
3434         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3435         (DriverTest.test_test_to_uri):
3436         (DriverTest.test_uri_to_test):
3437         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3438         (MockDRTPortTest.make_port):
3439         (MockDRTTest.input_line):
3440         (MockChromiumDRTTest.test_pixeltest__fails):
3441         * Scripts/webkitpy/layout_tests/port/test.py:
3442         * Scripts/webkitpy/layout_tests/port/win.py:
3443         (WinPort.show_results_html_file):
3444         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3445         (MainTest.test_unexpected_failures):
3446         (MainTest.test_results_directory_absolute):
3447         (MainTest.test_results_directory_default):
3448         (MainTest.test_results_directory_relative):
3449
3450 2012-06-05  Jon Lee  <jonlee@apple.com>
3451
3452         Workaround buildbot bug when merging build requests.
3453         https://bugs.webkit.org/show_bug.cgi?id=88158
3454
3455         Reviewed by Mark Rowe.
3456
3457         For expediency, we still want testers to pick the latest build to test, but to ensure
3458         that the builders are reporting the correct revision number, we should let the building bots
3459         run as they normally would. That is, the builder picks the oldest revision, and merges
3460         subsequent requests. Because merged requests get appended to the list of changes for a given
3461         build, the last change in that list is also the latest change. When we used pickLatestBuild
3462         for the builders, this was not the case (it would always report the penultimate change).
3463
3464         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
3467         for all Apple builders.
3468         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
3469         the latest build to run.
3470         (loadBuilderConfig):
3471
3472 2012-06-05  Jessie Berlin  <jberlin@apple.com>
3473
3474         [Win] DumpRenderTree should call resetInternalsObject
3475         https://bugs.webkit.org/show_bug.cgi?id=88346
3476
3477         Reviewed by Simon Fraser.
3478
3479         Invoke it on Windows in the same place it is invoked on Mac.
3480
3481         * DumpRenderTree/win/DumpRenderTree.cpp:
3482         (resetWebViewToConsistentStateBeforeTesting):
3483
3484 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3485
3486         [GTK] Fix two more memory leaks in DRT
3487         https://bugs.webkit.org/show_bug.cgi?id=88255
3488
3489         Reviewed by Martin Robinson.
3490
3491         Fixed memory leaks in GTK's DRT code.
3492
3493         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3494         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
3495         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
3496         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3497         (createBitmapContextFromWebView): Free the cairo surface.
3498
3499 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3500
3501         [Qt] Building when a top directory is named Source
3502         https://bugs.webkit.org/show_bug.cgi?id=77727
3503
3504         Reviewed by Tor Arne Vestbø.
3505
3506         Change regex to only replace the last instance of OUT_PWD.
3507
3508         * qmake/mkspecs/features/default_pre.prf:
3509
3510 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
3511
3512         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
3513         https://bugs.webkit.org/show_bug.cgi?id=73176
3514
3515         Reviewed by Adam Barth.
3516
3517         Two more APIs are added in Custom Scheme Handler specification.
3518         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
3519         One is 'isProtocolHandlerRegistered' to query whether the specific URL
3520         is registered or not.
3521         The other is 'unregisterProtocolHandler' to remove the registered URL.
3522
3523         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
3524
3525 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
3526
3527         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
3528         https://bugs.webkit.org/show_bug.cgi?id=83879
3529
3530         Reviewed by Carlos Garcia Campos.
3531
3532         Make minibrowser connect to the new 'permission requests' signal
3533         to allow users handle the Geolocation permission requests.
3534
3535         * MiniBrowser/gtk/BrowserWindow.c:
3536         (geolocationRequestDialogCallback): Callback for the dialog asking
3537         the user for allowing or not geolocation permission requests.
3538         (webViewDecidePermissionRequest): Launch a dialog to ask the user
3539         whether to allow or deny geolocation permission requests.
3540         (browserWindowConstructed): Connect to 'permission-request' signal.
3541
3542 2012-06-04  Chase Phillips  <cmp@google.com>
3543
3544         Make a builder group support+expect multiple loads.
3545         https://bugs.webkit.org/show_bug.cgi?id=88260
3546
3547         Change BuilderGroup to allow expecting multiple
3548         loads.  This allows merging results for a given set
3549         of builders into one group.
3550
3551         Add a test that verifies that the group count
3552         increments correctly based on successful and failed
3553         list loads.
3554
3555         Reviewed by Ojan Vafai.
3556
3557         * TestResultServer/static-dashboards/builders.js:
3558         (BuilderGroup):
3559         (BuilderGroup.prototype.setbuilder):
3560         (BuilderGroup.prototype.append):
3561         (BuilderGroup.prototype.loaded):
3562         (requestBuilderList.xhr.onload):
3563         (requestBuilderList.xhr.onerror):
3564         (onErrorLoadingBuilderList):
3565         (loadBuildersList):
3566         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3567         (test):
3568         * TestResultServer/static-dashboards/run-unittests.html:
3569
3570 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
3571
3572         Python test fix attempt for Chromium Windows.
3573
3574         * Scripts/webkitpy/layout_tests/port/driver.py:
3575         (Driver.uri_to_test):
3576
3577 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
3578
3579         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
3580         https://bugs.webkit.org/show_bug.cgi?id=88243
3581
3582         Reviewed by Adam Barth.
3583
3584         * qmake/mkspecs/features/features.prf:
3585
3586 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3587
3588         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
3589         https://bugs.webkit.org/show_bug.cgi?id=88280
3590
3591         Unreviewed, build fix.
3592
3593         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3594         (TestServerProcess.test_basic):
3595
3596 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3597
3598         test-webkitpy is hanging under cygwin
3599         https://bugs.webkit.org/show_bug.cgi?id=88269
3600
3601         Reviewed by Ryosuke Niwa.
3602
3603         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
3604         so we need to skip any tests that use it.
3605
3606         * Scripts/webkitpy/common/system/executive.py:
3607         (Executive.run_in_parallel):
3608         * Scripts/webkitpy/common/system/executive_unittest.py:
3609         (ExecutiveTest.test_run_in_parallel):
3610
3611 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
3612
3613         test-webkitpy is failing on win32 after r115054
3614         https://bugs.webkit.org/show_bug.cgi?id=88264
3615
3616         Reviewed by Ryosuke Niwa.
3617
3618         The failing http_server test was improperly suppressed (the
3619         tuple was missing a comma, and so wasn't a tuple at all, just a
3620         string) and so we were skipping *all* tests on win32. The right
3621         way to skip a single test is to disable it inside the test
3622         itself.
3623
3624         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3625         (TestHttpServer.test_start_cmd):
3626         * Scripts/webkitpy/test/test_finder.py:
3627         (TestFinder._default_names):
3628         * Scripts/webkitpy/test/main.py:
3629         (Tester.run): Add error message if we don't find any tests to run.
3630         * Scripts/webkitpy/test/main_unittest.py:
3631             
3632
3633 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3634
3635         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
3636         https://bugs.webkit.org/show_bug.cgi?id=88215
3637
3638         Reviewed by Martin Robinson.
3639
3640         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
3641         for newly allocated strings.
3642
3643         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3644         (attributeSetToString):
3645         (AccessibilityUIElement::allAttributes):
3646
3647 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3648
3649         [GTK] Memory leaks in DumpRenderTree.cpp
3650         https://bugs.webkit.org/show_bug.cgi?id=88213
3651
3652         Reviewed by Martin Robinson.
3653
3654         Fixed memory leaks in DumpRenderTree.
3655
3656         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3657         (appendString): Accepts const gchar* as the second argument.
3658         (dumpFramesAsText): Free the string returned by g_strdup_printf().
3659         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
3660
3661 2012-06-04  David Dorwin  <ddorwin@chromium.org>
3662
3663         Enable Chromium media player to instantiate a plugin
3664         https://bugs.webkit.org/show_bug.cgi?id=87399
3665
3666         Reviewed by Kent Tamura.
3667
3668         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
3669
3670         * DumpRenderTree/chromium/WebViewHost.cpp:
3671         (WebViewHost::createPopupMenu):
3672
3673 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
3674
3675         [GTK][WK2] Implement geolocation provider for the GTK port
3676         https://bugs.webkit.org/show_bug.cgi