Implement DownloadMonitor to prevent long-running slow downloads from background...
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2
3         Implement DownloadMonitor to prevent long-running slow downloads from background apps
4         https://bugs.webkit.org/show_bug.cgi?id=195785
5
6         Reviewed by Geoffrey Garen.
7
8         * TestWebKitAPI/TCPServer.cpp: Added.
9         (TestWebKitAPI::TCPServer::TCPServer):
10         (TestWebKitAPI::TCPServer::~TCPServer):
11         (TestWebKitAPI::TCPServer::socketBindListen):
12         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
13         * TestWebKitAPI/TCPServer.h: Added.
14         (TestWebKitAPI::TCPServer::port const):
15         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
17         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
18         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
19         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
20         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
21         (TestWebKitAPI::respondSlowly):
22         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
23         (TestWebKitAPI::downloadAtRate):
24         (TestWebKitAPI::TEST):
25
26 2019-03-18  Saam Barati  <sbarati@apple.com>
27
28         Add a plan file for JetStream 2
29         https://bugs.webkit.org/show_bug.cgi?id=190734
30
31         Reviewed by Mark Lam.
32
33         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
34
35 2019-03-18  Chris Dumez  <cdumez@apple.com>
36
37         Delay WebProcess launch until a load is triggered in a Web view
38         https://bugs.webkit.org/show_bug.cgi?id=195758
39         <rdar://problem/48126013>
40
41         Reviewed by Geoff Garen.
42
43         Add API test coverage. Also update some existing API tests to not expect
44         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
45
46         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
47         (TestWebKitAPI::TEST):
48         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
49         (TestWebKitAPI::TEST):
50         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
51         (TEST):
52         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
53         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
54         (TEST):
55         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
56         (TEST):
57         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
58
59 2019-03-18  Xan Lopez  <xan@igalia.com>
60
61         [CMake] Prevent potential warning when determining $architecture
62         https://bugs.webkit.org/show_bug.cgi?id=195891
63
64         Reviewed by Michael Catanzaro.
65
66         It's possible for generateBuildSystemForCMakeProject to be called
67         before determineArchitecture() is ever called. This will make the
68         first eq check with $architecture to be bogus (and print a
69         warning). Change that to an eq check with architecture(), which
70         implicitly calls determineArchitecture() if needed, and change all
71         the other similar cases in the method in the same way to prevent
72         future bugs like this one.
73
74         * Scripts/webkitdirs.pm:
75         (generateBuildSystemFromCMakeProject):
76
77 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
78
79         [WPE] Tarballs generated with “make dist” cannot build documentation
80         https://bugs.webkit.org/show_bug.cgi?id=195885
81
82         Reviewed by Carlos Garcia Campos.
83
84         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
85
86 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
87
88         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
89         https://bugs.webkit.org/show_bug.cgi?id=195883
90
91         Reviewed by Carlos Garcia Campos.
92
93         * gtkdoc/gtkdoc.py:
94         (GTKDoc._run_command): When commands fail to run, include the full command line for
95         the program invocation and the output it has generated on the standard error stream.
96
97 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
98
99         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
100         https://bugs.webkit.org/show_bug.cgi?id=195786
101
102         Reviewed by Philippe Normand.
103
104         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
105         * wpe/jhbuild.modules: Ditto.
106
107 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
108
109         [ews-build] Don't run clean builds on EWS builders
110         https://bugs.webkit.org/show_bug.cgi?id=195851
111
112         Reviewed by Geoffrey Garen.
113
114         * BuildSlaveSupport/ews-build/factories.py:
115
116 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
117
118         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
119         https://bugs.webkit.org/show_bug.cgi?id=195849
120
121         Reviewed by Chris Dumez.
122
123         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
124
125         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
126         (runWebsiteDataStoreCustomPaths):
127
128 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
129
130         webkitpy: Upload test results
131         https://bugs.webkit.org/show_bug.cgi?id=195755
132         <rdar://problem/48896182>
133
134         Reviewed by Aakash Jain.
135
136         Establish a new format for uploading results that is not tied to layout tests, apply
137         that format to webkitpy tests.
138
139         * Scripts/webkitpy/common/checkout/scm/git.py:
140         (Git.native_branch): Return what branch the current checkout is on.
141         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
142         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
143         * Scripts/webkitpy/common/checkout/scm/svn.py:
144         (SVN.native_branch): Ditto.
145         * Scripts/webkitpy/common/system/platforminfo.py:
146         (PlatformInfo.build_version): Return a build version for Mac.
147         * Scripts/webkitpy/common/system/platforminfo_mock.py:
148         (MockPlatformInfo.__init__):
149         (MockPlatformInfo.build_version):
150         * Scripts/webkitpy/results: Added.
151         * Scripts/webkitpy/results/__init__.py: Added.
152         * Scripts/webkitpy/results/options.py: Added.
153         (upload_options): OptParse list for upload options.
154         * Scripts/webkitpy/results/upload.py: Added.
155         (Upload): Class which enforces the upload format expected by the results server.
156         (Upload.Expectations):
157         (Upload.create_configuration):
158         (Upload.create_commit):
159         (Upload.create_details):
160         (Upload.create_run_stats):
161         (Upload.create_test_result):
162         (Upload.__init__):
163         (Upload.Encoder): Encode Upload object as json.
164         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
165         * Scripts/webkitpy/results/upload_unittest.py: Added.
166         * Scripts/webkitpy/test/main.py:
167         (Tester._parse_args): Add upload arguments.
168         (Tester._run_tests): Allow results to be uploaded.
169         * Scripts/webkitpy/test/runner.py:
170         (Runner.__init__): Record which tests were run, rather than just counting them.
171         (Runner.handle):
172         * Scripts/webkitpy/test/runner_unittest.py:
173         (RunnerTest.test_run):
174         * Scripts/webkitpy/thirdparty/__init__.py:
175         (AutoinstallImportHook.find_module): Add requests auto-install.
176         (AutoinstallImportHook._install_requests):
177         * Scripts/webkitpy/tool/commands/queues_unittest.py:
178         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
179
180 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
181
182         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
183         https://bugs.webkit.org/show_bug.cgi?id=195810
184
185         Reviewed by Tim Horton.
186
187         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
188         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
189         ending certain layout tests.
190
191         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
192         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
193         (-[TestRunnerWKWebView dealloc]):
194         (-[TestRunnerWKWebView resetInteractionCallbacks]):
195
196         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
197         helper method when destroying the web view, and when resetting state between tests.
198
199         * WebKitTestRunner/ios/TestControllerIOS.mm:
200         (WTR::TestController::platformResetStateToConsistentValues):
201
202         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
203
204 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
205
206         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
207         https://bugs.webkit.org/show_bug.cgi?id=190350
208         <rdar://problem/45089503>
209
210         Reviewed by Geoffrey Garen.
211
212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
213         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
214         (TEST):
215         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
216         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
217         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
218         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
219         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
220         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
221         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
222         (runTest):
223         (createDirectories):
224         (TEST):
225         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
226         (TEST):
227         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
228         (TEST):
229
230 2019-03-15  Timothy Hatcher  <timothy@apple.com>
231
232         Add support to WebPage for getting the contents as an attributed string.
233         https://bugs.webkit.org/show_bug.cgi?id=195636
234         rdar://problem/45055697
235
236         Reviewed by Tim Horton.
237
238         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
239         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
240
241 2019-03-15  Chris Dumez  <cdumez@apple.com>
242
243         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
244         https://bugs.webkit.org/show_bug.cgi?id=195747
245
246         Reviewed by Geoff Garen.
247
248         Add API test coverage.
249
250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
251
252 2019-03-15  Shawn Roberts  <sroberts@apple.com>
253
254         Unreviewed, rolling out r242952.
255
256         Causing API failures on iOS Simulator
257
258         Reverted changeset:
259
260         "[PSON] Make sure the WebProcessCache is leverage when
261         relaunching a process after termination"
262         https://bugs.webkit.org/show_bug.cgi?id=195747
263         https://trac.webkit.org/changeset/242952
264
265 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
266
267         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
268         https://bugs.webkit.org/show_bug.cgi?id=195740
269
270         Reviewed by Ross Kirsling.
271
272         window.open doesn't work for WebKitBrowserWindow because it is not
273         implemented yet.
274
275         1. Implemented createNewPage callback of WKPageUIClient.
276         2. Changed MainWindow to take a BrowserWindow factory function
277           instead of BrowserWindowType to be flexible to create
278           BrowserWindow with extra settings.
279         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
280           because it is not relevant with MainWindow anymore.
281
282         * MiniBrowser/win/Common.cpp:
283         (parseCommandLine):
284         * MiniBrowser/win/Common.h:
285         (CommandLineOptions::CommandLineOptions):
286         * MiniBrowser/win/MainWindow.cpp:
287         (MainWindow::MainWindow):
288         (MainWindow::create):
289         (MainWindow::init):
290         (MainWindow::WndProc):
291         * MiniBrowser/win/MainWindow.h:
292         * MiniBrowser/win/PrintWebUIDelegate.cpp:
293         (PrintWebUIDelegate::createWebViewWithRequest):
294         * MiniBrowser/win/WebKitBrowserWindow.cpp:
295         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
296         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
297         (WebKitBrowserWindow::updateProxySettings):
298         (WebKitBrowserWindow::createNewPage):
299         * MiniBrowser/win/WebKitBrowserWindow.h:
300         * MiniBrowser/win/WinMain.cpp:
301         (wWinMain):
302
303 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
304
305         Make it possible to test scrolling tree layer manipulation more easily
306         https://bugs.webkit.org/show_bug.cgi?id=195780
307
308         Reviewed by Tim Horton.
309         
310         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
311         cuts off communication of scrolling tree scrolls back to the web process
312         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
313         allows tests to trigger scrolls which run the scrolling tree layer positioning
314         logic, but never get another commit from the web process that might mask
315         scrolling tree bugs.
316         
317         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
318         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
319         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
320
321         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
322         (WTR::UIScriptController::scrollUpdatesDisabled const):
323         (WTR::UIScriptController::setScrollUpdatesDisabled):
324         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
325         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
326         (WTR::UIScriptController::scrollUpdatesDisabled const):
327         (WTR::UIScriptController::setScrollUpdatesDisabled):
328         * TestRunnerShared/UIScriptContext/UIScriptController.h:
329         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
330         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
331         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
332         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
333         * WebKitTestRunner/ios/TestControllerIOS.mm:
334         (WTR::TestController::platformResetStateToConsistentValues):
335         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
336         (WTR::UIScriptController::scrollUpdatesDisabled const):
337         (WTR::UIScriptController::setScrollUpdatesDisabled):
338
339 2019-03-14  Youenn Fablet  <youenn@apple.com>
340
341         Move IDB storage in private browsing mode to NetworkProcess
342         https://bugs.webkit.org/show_bug.cgi?id=195602
343
344         Reviewed by Brady Eidson.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
347         (TEST):
348
349 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
350
351         [ews-build] Make descriptionDone messages more readable
352         https://bugs.webkit.org/show_bug.cgi?id=195760
353
354         Reviewed by Lucas Forschler.
355
356         * BuildSlaveSupport/ews-build/steps.py:
357         * BuildSlaveSupport/ews-build/steps_unittest.py:
358
359 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
360
361         [ews-build] Generate status-bubble hover-over messages
362         https://bugs.webkit.org/show_bug.cgi?id=195680
363
364         Reviewed by Lucas Forschler.
365
366         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
367         (StatusBubble):
368         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
369         on hover-over.
370         (StatusBubble._iso_time):
371         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
372         hover-over message.
373         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
374
375 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
376
377         [ews-app] Gracefully handle the case when state_string is None
378         https://bugs.webkit.org/show_bug.cgi?id=195753
379
380         Reviewed by Lucas Forschler.
381
382         * BuildSlaveSupport/ews-app/ews/models/build.py:
383         * BuildSlaveSupport/ews-app/ews/models/step.py:
384
385 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
386
387         [ews-app] Status bubble display pending for currently running build step
388         https://bugs.webkit.org/show_bug.cgi?id=195744
389
390         Reviewed by Lucas Forschler.
391
392         * BuildSlaveSupport/ews-build/events.py:
393         (Events.stepStarted): If state_string is pending, replace it with step name.
394
395 2019-03-14  Chris Dumez  <cdumez@apple.com>
396
397         Add WebsitePolicy for the client to specify the device orientation & motion access policy
398         https://bugs.webkit.org/show_bug.cgi?id=195750
399
400         Reviewed by Geoffrey Garen.
401
402         Add API test coverage.
403
404         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
405         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
406         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
407         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
408
409 2019-03-14  Chris Dumez  <cdumez@apple.com>
410
411         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
412         https://bugs.webkit.org/show_bug.cgi?id=195747
413
414         Reviewed by Geoff Garen.
415
416         Add API test coverage.
417
418         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
419
420 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
421
422         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
423         https://bugs.webkit.org/show_bug.cgi?id=195725
424         <rdar://problem/48545062>
425
426         Reviewed by Tim Horton.
427
428         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
429         handler is nil.
430
431         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
432         (TestWebKitAPI::TEST):
433
434 2019-03-13  Sam Weinig  <sam@webkit.org>
435
436         Add utility function to allow easy reverse range-based iteration of a container
437         https://bugs.webkit.org/show_bug.cgi?id=195542
438
439         Reviewed by Antti Koivisto.
440
441         * TestWebKitAPI/CMakeLists.txt:
442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
443         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
444         (TestWebKitAPI::TEST):
445         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
446
447 2019-03-13  Chris Dumez  <cdumez@apple.com>
448
449         Use a ServiceWorker process per registrable domain
450         https://bugs.webkit.org/show_bug.cgi?id=195649
451
452         Reviewed by Youenn Fablet.
453
454         Update API test coverage.
455
456         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
457
458 2019-03-13  Chris Dumez  <cdumez@apple.com>
459
460         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
461         https://bugs.webkit.org/show_bug.cgi?id=195684
462         <rdar://problem/48294714>
463
464         Reviewed by Antti Koivisto.
465
466         Add API test coverage.
467
468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
469
470 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
471
472         [ews-app] Remove unused patch view
473         https://bugs.webkit.org/show_bug.cgi?id=195669
474
475         Reviewed by Lucas Forschler.
476
477         * BuildSlaveSupport/ews-app/ews/urls.py:
478         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
479
480 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
481
482         [ews-app] Use Buildbot result code variables
483         https://bugs.webkit.org/show_bug.cgi?id=195668
484
485         Reviewed by Alexey Proskuryakov.
486
487         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
488         (Buildbot): Added Buildbot result code variables.
489         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
490         (StatusBubble._build_bubble): Used Buildbot result code variables.
491
492 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
493
494         [Flatpak] Expand submodule recursively
495         https://bugs.webkit.org/show_bug.cgi?id=195672
496
497         Building WPE with flatpak was impossible without that as it was raising an exception.
498         Also update wpebackend-fdo to match what is built in jhbuild
499
500         Reviewed by Philippe Normand.
501
502         * flatpak/flatpakutils.py:
503         (expand_submodules_recurse):
504         (expand_manifest):
505         * flatpak/org.webkit.WPEModules.yaml:
506
507 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
508
509         [ews-app] status bubble should be hidden for certain builds
510         https://bugs.webkit.org/show_bug.cgi?id=194597
511
512         Reviewed by Dewei Zhu.
513
514         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
515         (StatusBubble._build_bubble):
516         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
517         because the patch didn't have relevant changes.
518         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
519         in production yet.
520
521 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
522
523         [Win] Fix a slew of simple clang-cl warnings.
524         https://bugs.webkit.org/show_bug.cgi?id=195652
525
526         Reviewed by Don Olmstead.
527
528         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
529         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
530
531 2019-03-12  Justin Fan  <justin_fan@apple.com>
532
533         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
534         https://bugs.webkit.org/show_bug.cgi?id=195518
535         <rdar://problem/46322356>
536
537         Reviewed by Myles C. Maxfield.
538
539         * DumpRenderTree/DerivedSources-input.xcfilelist:
540         * DumpRenderTree/DerivedSources-output.xcfilelist:
541
542 2019-03-12  Commit Queue  <commit-queue@webkit.org>
543
544         Unreviewed, rolling out r242825.
545         https://bugs.webkit.org/show_bug.cgi?id=195648
546
547         "Broke webkitpy tests with my change to
548         lldb_dump_class_layout.py" (Requested by rmorisset on
549         #webkit).
550
551         Reverted changeset:
552
553         "Alter Tools/Scripts/dump-class-layout to be able to dump all
554         classes with suspicious padding"
555         https://bugs.webkit.org/show_bug.cgi?id=195573
556         https://trac.webkit.org/changeset/242825
557
558 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
559
560         [ews-build] Show status bubbles while the patch is waiting in queue
561         https://bugs.webkit.org/show_bug.cgi?id=195618
562
563         Reviewed by Lucas Forschler.
564
565         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
566         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
567         enabled in initial deployment.
568         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
569         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
570         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
571         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
572         (StatusBubble._build_bubbles_for_patch):
573
574 2019-03-12  Robin Morisset  <rmorisset@apple.com>
575
576         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
577         https://bugs.webkit.org/show_bug.cgi?id=195573
578
579         Reviewed by Simon Fraser.
580
581         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
582
583         * Scripts/dump-class-layout:
584         (main):
585         * lldb/lldb_dump_class_layout.py:
586         (ClassLayout.__init__):
587         (ClassLayout._compute_padding_recursive):
588         (LLDBDebuggerInstance.dump_layout_for_classname):
589         (LLDBDebuggerInstance):
590         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
591         (LLDBDebuggerInstance.layout_for_classname): Deleted.
592
593 2019-03-12  Chris Dumez  <cdumez@apple.com>
594
595         Device Orientation access permission should be denied unless explicitly granted by the client
596         https://bugs.webkit.org/show_bug.cgi?id=195625
597
598         Reviewed by Youenn Fablet.
599
600         add API test coverage.
601
602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
603         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
604         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
605         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
606         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
607         (runDeviceOrientationTest):
608         (TEST):
609         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
610         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
611
612 2019-03-12  Jer Noble  <jer.noble@apple.com>
613
614         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
615         https://bugs.webkit.org/show_bug.cgi?id=195137
616         <rdar://problem/48810307>
617
618         Reviewed by Eric Carlson.
619
620         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
621         (TestWebKitAPI::TEST):
622
623 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
624
625         [ews-build] Change urls from uat to production
626         https://bugs.webkit.org/show_bug.cgi?id=195566
627
628         Reviewed by Lucas Forschler.
629
630         * BuildSlaveSupport/ews-app/ews/config.py:
631         * BuildSlaveSupport/ews-build/events.py:
632         * BuildSlaveSupport/ews-build/steps.py:
633
634 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
635
636         [ews-build] change max_builds for local-worker to 1
637         https://bugs.webkit.org/show_bug.cgi?id=195568
638
639         Reviewed by Lucas Forschler.
640
641         * BuildSlaveSupport/ews-build/loadConfig.py:
642
643 2019-03-12  Tim Horton  <timothy_horton@apple.com>
644
645         Fix the build
646
647         * TestRunnerShared/spi/PencilKitTestSPI.h:
648         * TestWebKitAPI/ios/PencilKitTestSPI.h:
649
650 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
651
652         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
653         https://bugs.webkit.org/show_bug.cgi?id=194131
654
655         Reviewed by Michael Catanzaro.
656
657         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
658         (uriChanged):
659         (testUnfinishedSubresourceLoad):
660         (serverCallback):
661         (beforeAll):
662
663 2019-03-11  Alex Christensen  <achristensen@webkit.org>
664
665         WTF::Expected should use std::addressof instead of operator&
666         https://bugs.webkit.org/show_bug.cgi?id=195604
667
668         Reviewed by Myles Maxfield.
669
670         * TestWebKitAPI/Tests/WTF/Expected.cpp:
671         (TestWebKitAPI::Unique::Unique):
672         (TestWebKitAPI::Unique::operator&):
673         (TestWebKitAPI::TEST):
674
675 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
676
677         Add Optional to Forward.h.
678         https://bugs.webkit.org/show_bug.cgi?id=195586
679
680         Reviewed by Darin Adler.
681
682         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
683         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
684         Remove unnecessary includes from headers.
685
686 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
687
688         Add testing API to hit-test and scroll overflow scrollers
689         https://bugs.webkit.org/show_bug.cgi?id=195278
690
691         Reviewed by Antti Koivisto.
692         
693         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
694         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
695         
696         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
697
698         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
699         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
700         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
701         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
702         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
703         * TestRunnerShared/UIScriptContext/UIScriptController.h:
704         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
705         (WTR::enclosingScrollViewIncludingSelf):
706         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
707
708 2019-03-11  Tim Horton  <timothy_horton@apple.com>
709
710         API test WebKit.RequestTextInputContext fails on iOS
711         https://bugs.webkit.org/show_bug.cgi?id=195585
712
713         Reviewed by Wenson Hsieh and Simon Fraser.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
716         (applyStyle):
717         (TEST):
718         Add a viewport, so that the coordinates match up on iOS.
719         Scroll by moving the UIScrollView's contentOffset.
720
721 2019-03-11  Chris Dumez  <cdumez@apple.com>
722
723         Assert in WebPageProxy::suspendCurrentPageIfPossible()
724         https://bugs.webkit.org/show_bug.cgi?id=195506
725         <rdar://problem/48733477>
726
727         Reviewed by Alex Christensen.
728
729         Add API test coverage.
730
731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
732
733 2019-03-11  Shawn Roberts  <sroberts@apple.com>
734
735         Adding myself to contributors.json
736
737         Unreviewed, addming myself to contributors.json .
738
739         * Scripts/webkitpy/common/config/contributors.json:
740
741 2019-03-11  Alex Christensen  <achristensen@webkit.org>
742
743         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
744         https://bugs.webkit.org/show_bug.cgi?id=195511
745         <rdar://problem/44873269>
746
747         Reviewed by Darin Adler.
748
749         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
750         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
751         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
752         (TEST_F):
753
754 2019-03-11  Chris Dumez  <cdumez@apple.com>
755
756         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
757         https://bugs.webkit.org/show_bug.cgi?id=195561
758
759         Reviewed by Youenn Fablet.
760
761         Make sure the JS in the test requests for permission to receive device orientation events.
762
763         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
764
765 2019-03-11  Youenn Fablet  <youenn@apple.com>
766
767         Allow storage quota increase by default in WTR
768         https://bugs.webkit.org/show_bug.cgi?id=195541
769
770         Reviewed by Geoffrey Garen.
771
772         Allow storage quota increase by default in WTR.
773         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
774         Use this for tests that explicitly need cache increase.
775
776         Instead of increasing quota by 2, make sure the next request is
777         granted by adding all given parameters.
778
779         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
781         (WTR::TestRunner::setAllowStorageQuotaIncrease):
782         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
783         * WebKitTestRunner/InjectedBundle/TestRunner.h:
784         * WebKitTestRunner/TestController.cpp:
785         (WTR::TestController::setAllowStorageQuotaIncrease):
786         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
787         * WebKitTestRunner/TestController.h:
788         * WebKitTestRunner/TestInvocation.cpp:
789         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
790         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
791         (WTR::TestController::cocoaResetStateToConsistentValues):
792         (WTR::TestController::setAllowStorageQuotaIncrease):
793         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
794         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
795         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
796
797 2019-03-11  Xan Lopez  <xan@igalia.com>
798
799         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
800         https://bugs.webkit.org/show_bug.cgi?id=194147
801
802         Reviewed by Michael Saboff.
803
804         To make --32-bit work correctly on Linux/64bit we need to:
805
806         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
807         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
808         unfortunately CMake only allows us to do this during
809         crosscompilation, which is overkill here.
810         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
811         pkg-config detection module uses the x86 .pc files instead of the
812         x86_64 ones.
813         - Set the -m32 flags for the compiler.
814
815         * Scripts/webkitdirs.pm:
816         (generateBuildSystemFromCMakeProject):
817
818 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
819
820         Add MotionMark-1.1 plan file for run-benchmark script.
821         https://bugs.webkit.org/show_bug.cgi?id=195481
822
823         Rubber-stamped by Darin Adler.
824
825         Run-benchmark script should support MontionMark-1.1.
826
827         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
828
829 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
830
831         [ews-app] Add support for submit-to-ews url
832         https://bugs.webkit.org/show_bug.cgi?id=195477
833
834         Reviewed by Lucas Forschler.
835
836         * BuildSlaveSupport/ews-app/ews/fetcher.py:
837         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
838         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
839         * BuildSlaveSupport/ews-app/ews/urls.py:
840         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
841
842 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
843
844         Unreviewed, rolling out r242688, r242643, r242624.
845
846         Caused multiple layout test failures and crashes on iOS and macOS.
847
848         Reverted changeset:
849
850         "requestAnimationFrame should execute before the next frame"
851         https://bugs.webkit.org/show_bug.cgi?id=177484
852         https://trac.webkit.org/changeset/242624/webkit
853
854         * Tracing/SystemTracePoints.plist:
855
856 2019-03-11  John Wilander  <wilander@apple.com>
857
858         Resource Load Statistics: Make it possible exclude localhost from classification
859         https://bugs.webkit.org/show_bug.cgi?id=195474
860         <rdar://problem/47520577>
861
862         Reviewed by Brent Fulgham.
863
864         This patch allows for localhost to be excluded from classification and
865         treatment as a prevalent resource.
866
867         The WebKit Tools change adds a new function called
868         testRunner.setStatisticsIsRunningTest() which can be used to control this
869         behavior.
870
871         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
872         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
873         (WTR::TestRunner::setStatisticsIsRunningTest):
874         * WebKitTestRunner/InjectedBundle/TestRunner.h:
875         * WebKitTestRunner/TestController.cpp:
876         (WTR::TestController::setStatisticsIsRunningTest):
877         * WebKitTestRunner/TestController.h:
878         * WebKitTestRunner/TestInvocation.cpp:
879         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
880
881 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
882
883         [ews-build] Disable waterfall and console view for ews-build.webkit.org
884         https://bugs.webkit.org/show_bug.cgi?id=195560
885
886         Reviewed by Lucas Forschler.
887
888         * BuildSlaveSupport/ews-build/master.cfg:
889
890 2019-03-11  Alex Christensen  <achristensen@webkit.org>
891
892         Unreviewed, rolling out r242698.
893
894         API test crashes on bots.
895
896         Reverted changeset:
897
898         "Add a WKContentRuleList variant that uses copied memory
899         instead of mmap'd shared memory for class A containerized
900         apps"
901         https://bugs.webkit.org/show_bug.cgi?id=195511
902         https://trac.webkit.org/changeset/242698
903
904 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
905
906         [WPE] Enable web process sandbox
907         https://bugs.webkit.org/show_bug.cgi?id=195169
908
909         Reviewed by Daniel Bates.
910
911         * wpe/install-dependencies:
912         * wpe/jhbuild.modules:
913
914 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
915
916         [ews-app] Use port 17000 for worker communication
917         https://bugs.webkit.org/show_bug.cgi?id=195558
918
919         Reviewed by Lucas Forschler.
920
921         * BuildSlaveSupport/ews-build/master.cfg:
922
923 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
924
925         [ews-build] unit-tests fail when passwords.json is missing
926         https://bugs.webkit.org/show_bug.cgi?id=195557
927
928         Reviewed by Lucas Forschler.
929
930         * BuildSlaveSupport/ews-build/loadConfig.py:
931         (loadBuilderConfig):
932         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
933         (ConfigDotJSONTest.test_configuration):
934         * BuildSlaveSupport/ews-build/master.cfg:
935
936 2019-03-11  Truitt Savell  <tsavell@apple.com>
937
938         Unreviewed, rolling out r242702.
939
940         Broke High Sierra builders.
941
942         Reverted changeset:
943
944         "Add utility function to allow easy reverse range-based
945         iteration of a container"
946         https://bugs.webkit.org/show_bug.cgi?id=195542
947         https://trac.webkit.org/changeset/242702
948
949 2019-03-11  Sam Weinig  <sam@webkit.org>
950
951         Add utility function to allow easy reverse range-based iteration of a container
952         https://bugs.webkit.org/show_bug.cgi?id=195542
953
954         Reviewed by Antti Koivisto.
955
956         * TestWebKitAPI/CMakeLists.txt:
957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
958         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
959         (TestWebKitAPI::TEST):
960         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
961
962 2019-03-10  Alex Christensen  <achristensen@webkit.org>
963
964         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
965         https://bugs.webkit.org/show_bug.cgi?id=195511
966         <rdar://problem/44873269>
967
968         Reviewed by Darin Adler.
969
970         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
971         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
972         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
973         (TEST_F):
974
975 2019-03-10  Tim Horton  <timothy_horton@apple.com>
976
977         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
978         https://bugs.webkit.org/show_bug.cgi?id=195499
979
980         Reviewed by Darin Adler.
981
982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
983         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
984         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
985         (-[WKWebView synchronouslyFocusTextInputContext:]):
986         (applyStyle):
987         (applyIframe):
988         (TEST):
989         Add some tests for this SPI.
990
991 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
992
993         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
994         https://bugs.webkit.org/show_bug.cgi?id=181151
995
996         Reviewed by Don Olmstead.
997
998         * TestWebKitAPI/CMakeLists.txt:
999         * TestWebKitAPI/PlatformWin.cmake:
1000         Enable TestWTF RunLoop tests in all platforms.
1001
1002         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1003         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1004         (TestWebKitAPI::DerivedOneShotTimer::fired):
1005         (TestWebKitAPI::TEST):
1006         Only a few platforms support nested RunLoop.
1007
1008         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1009         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1010
1011 2019-03-10  David Quesada  <david_quesada@apple.com>
1012
1013         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1014         https://bugs.webkit.org/show_bug.cgi?id=152480
1015
1016         Reviewed by Chris Dumez.
1017
1018         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1019         there are no additional references to the process pool besides the one held by
1020         the download, waits for the download to finish (in the sense that the
1021         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1022         measure, also check that the process pool has been deallocated at the end of the
1023         test. The test wouldn't be meaningful if the process pool were still alive.
1024
1025         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1026         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1027         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1028             The download will be canceled because the delegate does not implement the
1029             method to decide the download's destination, so this is where we know the
1030             DownloadProxyMap is done with the DownloadProxy.
1031         (TEST):
1032
1033 2019-03-08  Chris Dumez  <cdumez@apple.com>
1034
1035         Add support for Device Orientation / Motion permission API
1036         https://bugs.webkit.org/show_bug.cgi?id=195329
1037         <rdar://problem/47645367>
1038
1039         Reviewed by Geoffrey Garen.
1040
1041         Add test infrastructure to help test the Device Orientation / Motion permission API.
1042
1043         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1044         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1045         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1046         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1047         * WebKitTestRunner/TestController.cpp:
1048         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1049         (WTR::TestController::createWebViewWithOptions):
1050         (WTR::TestController::resetStateToConsistentValues):
1051         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1052         * WebKitTestRunner/TestController.h:
1053         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1054         * WebKitTestRunner/TestInvocation.cpp:
1055         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1056
1057 2019-03-08  Saam barati  <sbarati@apple.com>
1058
1059         Add a compare-results script to compare benchmark results
1060         https://bugs.webkit.org/show_bug.cgi?id=195486
1061         <rdar://problem/48723397>
1062
1063         Reviewed by Geoffrey Garen.
1064
1065         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1066         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1067         to extend it to learn about our other benchmarks.
1068
1069         * Scripts/compare-results: Added.
1070         (readJSONFile):
1071         (detectJetStream2):
1072         (JetStream2Results):
1073         (detectSpeedometer2):
1074         (Speedometer2Results):
1075         (detectPLT5):
1076         (PLT5Results):
1077         (detectBenchmark):
1078         (biggerIsBetter):
1079         (ttest):
1080         (getOptions):
1081         (main):
1082
1083 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1084
1085         Ensure old tab state is cleared between iterations of run-benchmark
1086         https://bugs.webkit.org/show_bug.cgi?id=195393
1087         <rdar://problem/46885583>
1088
1089         Reviewed by Dewei Zhu.
1090
1091         a) ensure the default to restore state is not set
1092         b) terminate Safari correctly
1093         c) Set the system default to ignore Persistent State in Safari
1094
1095         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1096         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1097         (OSXBrowserDriver.prepare_env): 
1098         (OSXBrowserDriver.restore_env):
1099         (OSXBrowserDriver.close_browsers):
1100         (OSXBrowserDriver._terminate_processes):
1101         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1102         (OSXChromeDriver):
1103         (OSXChromeCanaryDriver):
1104         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1105         (OSXFirefoxDriver):
1106         (OSXFirefoxNightlyDriver):
1107         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1108         (OSXSafariDriver):
1109         (OSXSafariDriver.prepare_env):
1110
1111 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1112
1113         [GTK] Several InputMethodFilter tests are failing
1114         https://bugs.webkit.org/show_bug.cgi?id=195408
1115
1116         Reviewed by Carlos Garcia Campos.
1117
1118         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1119         Regressed in r241751.
1120         Hexadecimal values of keycodes are expressed now in upper letters.
1121         Composited characters should be cast to UTF8 strings.
1122
1123         (TestWebKitAPI::TEST):
1124
1125 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1126
1127         [GTK] Make Tools/gtkdoc python3 compatible
1128         https://bugs.webkit.org/show_bug.cgi?id=195359
1129
1130         Reviewed by Carlos Garcia Campos.
1131
1132         * gtkdoc/generate-gtkdoc:
1133         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1134         work with Python 2 and 3.
1135         (get_gtkdoc_module_paths):
1136         The iteritems() was removed in Python 3, so let's use items() that's
1137         available in Python 2 and 3.
1138         (get_generator_for_config):
1139         * gtkdoc/gtkdoc.py:
1140         (GTKDoc._run_command):
1141         The sys.stdout.write() is expecting str in Python 3 and not bytes
1142         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1143         for passing the bytes there.
1144
1145 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1146
1147         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1148         https://bugs.webkit.org/show_bug.cgi?id=195346
1149         <rdar://problem/48667048>
1150
1151         Unreviewed build fix for clang-cl.
1152
1153         * DumpRenderTree/win/DumpRenderTree.cpp:
1154         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1155
1156 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1157
1158         requestAnimationFrame should execute before the next frame
1159         https://bugs.webkit.org/show_bug.cgi?id=177484
1160
1161         Reviewed by Simon Fraser.
1162
1163         Add trace points for the page RenderingUpdate.
1164
1165         * Tracing/SystemTracePoints.plist:
1166
1167 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1168
1169         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1170         https://bugs.webkit.org/show_bug.cgi?id=195353
1171         <rdar://problem/48626394>
1172
1173         Reviewed by Simon Fraser.
1174
1175         * WebKitTestRunner/ios/TestControllerIOS.mm:
1176         (WTR::TestController::platformResetPreferencesToConsistentValues):
1177
1178 2019-03-07  John Wilander  <wilander@apple.com>
1179
1180         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1181         https://bugs.webkit.org/show_bug.cgi?id=195383
1182         <rdar://problem/48570136>
1183
1184         Reviewed by Brent Fulgham.
1185
1186         This patch adds test infrastructure to purge only script-accessible cookies,
1187         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1188
1189         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1190         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1191         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1192         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1193         * WebKitTestRunner/TestController.cpp:
1194         (WTR::TestController::statisticsDeleteCookiesForHost):
1195         * WebKitTestRunner/TestController.h:
1196         * WebKitTestRunner/TestInvocation.cpp:
1197         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1198
1199 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1200
1201         Unreviewed, rolling out r242354.
1202         https://bugs.webkit.org/show_bug.cgi?id=195402
1203
1204         breaks layout tests in all configurations (Requested by
1205         zdobersek on #webkit).
1206
1207         Reverted changeset:
1208
1209         "[WPE] Enable web process sandbox"
1210         https://bugs.webkit.org/show_bug.cgi?id=195169
1211         https://trac.webkit.org/changeset/242354
1212
1213 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1214
1215         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1216         https://bugs.webkit.org/show_bug.cgi?id=195346
1217
1218         Reviewed by Fujii Hironori.
1219
1220         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1221         (TestWebKitAPI::TEST):
1222         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1223
1224         * DumpRenderTree/win/DumpRenderTree.cpp:
1225         (findFontFallback):
1226         (addFontFallbackIfPresent):
1227         (removeFontFallbackIfPresent):
1228         (main):
1229         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1230         (TestWebKitAPI::Util::moduleDirectory):
1231         (TestWebKitAPI::Util::createInjectedBundlePath):
1232         Use wchar helpers as needed.
1233
1234 2019-03-06  Rob Buis  <rbuis@igalia.com>
1235
1236         Consider supporting the `referrerpolicy` attribute.
1237         https://bugs.webkit.org/show_bug.cgi?id=179053
1238
1239         Reviewed by Darin Adler.
1240
1241         Add a runtime flag for referrerpolicy attribute.
1242
1243         * DumpRenderTree/mac/DumpRenderTree.mm:
1244         (enableExperimentalFeatures):
1245
1246 2019-03-05  Daniel Bates  <dabates@apple.com>
1247
1248         Update expected API test result following r242379
1249         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1250
1251         Update expected x-coordinate of selection rect now that the left padding of
1252         a textarea is sized in ems (so dependent on the font size) just like the left
1253         padding of a text field.
1254
1255         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1256         (TestWebKitAPI::TEST):
1257
1258 2019-03-05  David Quesada  <david_quesada@apple.com>
1259
1260         [WK2] It should be possible to follow links with 'download' attributes
1261         https://bugs.webkit.org/show_bug.cgi?id=195145
1262         rdar://problem/48462642
1263
1264         Reviewed by Alex Christensen.
1265
1266         Add a unit test to verify that activating links with 'download' attributes now
1267         navigates to the linked resource, rather than starts downloading it. Add another
1268         to verify that it is still possible to explicitly download the link via the
1269         'Download' navigation action policy.
1270
1271         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1272         (-[DownloadAttributeTestDelegate init]):
1273         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
1274         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
1275         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
1276         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
1277         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1278         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
1279         (TEST):
1280         * WebKitTestRunner/TestController.cpp:
1281         (WTR::TestController::decidePolicyForNavigationAction):
1282         * WebKitTestRunner/TestController.h:
1283
1284 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
1285
1286         [Curl] Implement Cookie Accept Policy.
1287         https://bugs.webkit.org/show_bug.cgi?id=191645
1288
1289         Reviewed by Fujii Hironori.
1290
1291         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1292         (TestWebKitAPI::Curl::TEST_F):
1293
1294 2019-03-05  Youenn Fablet  <youenn@apple.com>
1295
1296         Rename requestCacheStorageSpace to requestStorageSpace
1297         https://bugs.webkit.org/show_bug.cgi?id=195282
1298
1299         Reviewed by Chris Dumez.
1300
1301         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1302         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1303         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
1304
1305 2019-03-05  Brady Eidson  <beidson@apple.com>
1306
1307         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
1308         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
1309
1310         Reviewed by Tim Horton.
1311
1312         Loading a file: URL into a WKWebView and then loading another file: url from a completely
1313         different directory into that same WKWebView should work.
1314
1315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1316         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
1317
1318 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1319
1320         Add WeakHashSet
1321         https://bugs.webkit.org/show_bug.cgi?id=195152
1322
1323         Reviewed by Antti Koivisto.
1324
1325         Added tests for WeakHashSet.
1326
1327         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1328         (TestWebKitAPI::Base::Base): Moved.
1329         (TestWebKitAPI::Derived::foo): Moved.
1330         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
1331         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
1332         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
1333         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
1334
1335 2019-03-04  Chris Dumez  <cdumez@apple.com>
1336
1337         Do not share WebProcesses between private and regular sessions
1338         https://bugs.webkit.org/show_bug.cgi?id=195189
1339         <rdar://problem/48421064>
1340
1341         Reviewed by Alex Christensen.
1342
1343         Add API test coverage.
1344
1345         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1346         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1347
1348 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1349
1350         [WPE] Enable web process sandbox
1351         https://bugs.webkit.org/show_bug.cgi?id=195169
1352
1353         Reviewed by Daniel Bates.
1354
1355         * wpe/install-dependencies:
1356         * wpe/jhbuild.modules:
1357
1358 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1359
1360         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
1361         https://bugs.webkit.org/show_bug.cgi?id=195206
1362
1363         Reviewed by Žan Doberšek.
1364
1365         Add a new test case.
1366
1367         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1368         (testJSCClass):
1369
1370 2019-03-04  Charlie Turner  <cturner@igalia.com>
1371
1372         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
1373         https://bugs.webkit.org/show_bug.cgi?id=194898
1374
1375         Reviewed by Žan Doberšek.
1376
1377         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
1378         a GCC extension that permits arithmetic on void* pointer. Inline
1379         the macro until this issue is fixed upstream.
1380
1381 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1382
1383         Rid the world of WK_API_ENABLED
1384         https://bugs.webkit.org/show_bug.cgi?id=195263
1385
1386         Reviewed by Dan Bernstein.
1387
1388         List of changed files elided because it's useless.
1389
1390 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
1391
1392         Unreviewed follow-up to r242292.
1393
1394         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
1395
1396         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1397         (TestWebKitAPI::testStrip): Renamed from strip.
1398         (TestWebKitAPI::TEST):
1399
1400 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1401
1402         Unreviewed, remove accidentally-committed URLHelpers.cpp test
1403
1404         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
1405         and bug #194272 for details.
1406
1407         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
1408
1409 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1410
1411         Remove some more unused 32-bit code
1412         https://bugs.webkit.org/show_bug.cgi?id=195255
1413
1414         Reviewed by Darin Adler.
1415
1416         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1417         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
1418         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1419         (NPP_New):
1420         (NPP_HandleEvent):
1421         (handleEventCarbon): Deleted.
1422
1423 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
1424
1425         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
1426
1427         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1428         (TestWebKitAPI::TEST):
1429
1430 2019-03-01  Darin Adler  <darin@apple.com>
1431
1432         Finish removing String::format
1433         https://bugs.webkit.org/show_bug.cgi?id=194893
1434
1435         Reviewed by Daniel Bates.
1436 '
1437         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
1438
1439 2019-03-01  Alex Christensen  <achristensen@webkit.org>
1440
1441         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
1442         https://bugs.webkit.org/show_bug.cgi?id=195229
1443         <rdar://problem/48520362>
1444
1445         Reviewed by Chris Dumez.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1448         (TEST):
1449
1450 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
1451
1452         Add a system trace scope for event region building
1453         https://bugs.webkit.org/show_bug.cgi?id=195226
1454
1455         Reviewed by Jon Lee.
1456
1457         This trace scope measures the time spend converting element rects into Region objects,
1458         which can be large on some pages.
1459
1460         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
1461
1462         * Tracing/SystemTracePoints.plist:
1463
1464 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1465
1466         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
1467         https://bugs.webkit.org/show_bug.cgi?id=194612
1468
1469         Reviewed by Alex Christensen.
1470
1471         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1472         Just test the new string-processing function and don't touch the actual environment.
1473         (Test cases are all as before, but based on operator== instead of strcmp.)
1474
1475 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
1476
1477         [ews-app] Update primary keys for handling multiple Buildbot instances
1478         https://bugs.webkit.org/show_bug.cgi?id=195120
1479
1480         Reviewed by Stephanie Lewis.
1481
1482         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
1483         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
1484         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
1485
1486         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
1487         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
1488         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
1489         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
1490         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
1491         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
1492
1493 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
1494
1495         [WinCairo] Enable service worker
1496         https://bugs.webkit.org/show_bug.cgi?id=188318
1497
1498         Reviewed by Youenn Fablet.
1499
1500         * DumpRenderTree/DumpRenderTreePrefix.h:
1501         * TestWebKitAPI/PlatformWin.cmake:
1502         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
1503         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
1504         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1505
1506 2019-03-01  Justin Fan  <justin_fan@apple.com>
1507
1508         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
1509         https://bugs.webkit.org/show_bug.cgi?id=195191
1510
1511         Rubber-stamped by Dean Jackson.
1512
1513         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
1514
1515         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1516
1517 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
1518
1519         Unreviewed, fix lldb webkitpy tests
1520         https://bugs.webkit.org/show_bug.cgi?id=194375
1521
1522         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
1523
1524         * lldb/lldb_webkit.py:
1525         (WTFStringImplProvider.is_8bit):
1526
1527 2019-02-28  David Quesada  <david_quesada@apple.com>
1528
1529         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1530         https://bugs.webkit.org/show_bug.cgi?id=195121
1531         rdar://problem/48450302
1532
1533         Reviewed by Alex Christensen.
1534
1535         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1536         configurations where the 'download' attribute is absent, blank, or populated
1537         with a filename, and where the anchor element is same-origin or cross-origin
1538         (meaning the 'download' attribute shouldn't be honored).
1539
1540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1541         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1542         (-[NavigationActionTestDelegate init]):
1543         (-[NavigationActionTestDelegate navigationAction]):
1544         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1545         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1546         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1547         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1548         (TEST):
1549
1550 2019-02-28  Antoine Quint  <graouts@apple.com>
1551
1552         Enable the Pointer Events runtime flag by default
1553         https://bugs.webkit.org/show_bug.cgi?id=195156
1554
1555         Reviewed by Dean Jackson.
1556
1557         * DumpRenderTree/mac/DumpRenderTree.mm:
1558         (enableExperimentalFeatures):
1559
1560 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1561
1562         Several PasteImage API tests are flaky
1563         https://bugs.webkit.org/show_bug.cgi?id=195160
1564
1565         Reviewed by Tim Horton.
1566
1567         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1568         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1569         listening for a "load" event after image load is already complete.
1570
1571         To address this, make these tests first register a "load" event handler, then run script to insert an image
1572         element into the document, and finally wait until the load event is observed before checking image size.
1573
1574         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1575
1576 2019-02-28  Chris Dumez  <cdumez@apple.com>
1577
1578         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1579         https://bugs.webkit.org/show_bug.cgi?id=195107
1580
1581         Reviewed by Alex Christensen.
1582
1583         Give some time for the zoom level to get restored.
1584
1585         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1586
1587 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1588
1589         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1590         https://bugs.webkit.org/show_bug.cgi?id=194958
1591
1592         Reviewed by Geoffrey Garen.
1593
1594         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1595         (TEST):
1596
1597 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1598
1599         [ews-app] Update method to save build to handle builder_display_name
1600         https://bugs.webkit.org/show_bug.cgi?id=195047
1601
1602         Reviewed by Dewei Zhu.
1603
1604         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1605         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1606
1607 2019-02-28  Justin Fan  <justin_fan@apple.com>
1608
1609         [Web GPU] Enable Web GPU only on 64-bit
1610         https://bugs.webkit.org/show_bug.cgi?id=195139
1611
1612         Because Metal is only supported on 64 bit apps.
1613
1614         Unreviewed build fix.
1615
1616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1617
1618 2019-02-27  Youenn Fablet  <youenn@apple.com>
1619
1620         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1621         https://bugs.webkit.org/show_bug.cgi?id=194959
1622
1623         Reviewed by Chris Dumez.
1624
1625         Spin loop until getting the condition to remove flakiness.
1626
1627         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1628
1629 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1630
1631         [ews-build] Buildbot should include builder_display_name in the build events
1632         https://bugs.webkit.org/show_bug.cgi?id=195045
1633
1634         Reviewed by Dewei Zhu.
1635
1636         * BuildSlaveSupport/ews-build/events.py:
1637         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1638         buildername to builder_name to be consistent in naming style.
1639         (Events.buildFinished): Ditto.
1640
1641 2019-02-27  Chris Dumez  <cdumez@apple.com>
1642
1643         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1644         https://bugs.webkit.org/show_bug.cgi?id=194480
1645
1646         Reviewed by Brady Eidson.
1647
1648         Update existing API test to make it more likely to reproduce the issue.
1649
1650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1651
1652 2019-02-27  Brady Eidson  <beidson@apple.com>
1653
1654         Universal links from Google search results pages don't open the app.
1655         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1656
1657         Reviewed by Geoffrey Garen.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1660         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1661         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1662         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1663
1664 2019-02-27  Chris Dumez  <cdumez@apple.com>
1665
1666         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1667         https://bugs.webkit.org/show_bug.cgi?id=195102
1668
1669         Reviewed by Geoffrey Garen.
1670
1671         If the number of processes is not yet what we expect, wait a bit and check again to give
1672         processes some time to exit.
1673
1674         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1675
1676 2019-02-27  Chris Dumez  <cdumez@apple.com>
1677
1678         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1679         https://bugs.webkit.org/show_bug.cgi?id=194545
1680
1681         Reviewed by Brady Eidson.
1682
1683         Make sure the test navigates forward and then back only once. Previously, navigating
1684         back would trigger a navigation again in a timer.
1685
1686         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1687
1688 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1689
1690         High Sierra Debug JSC test queue should use faster hardware
1691         https://bugs.webkit.org/show_bug.cgi?id=194603
1692
1693         Rubber-stamped by Alexey Proskuryakov.
1694
1695         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1696
1697         * BuildSlaveSupport/build.webkit.org-config/config.json:
1698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1699         (BubbleQueueServer):
1700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1701         (WebKitBuildbot):
1702         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1703         * QueueStatusServer/config/queues.py:
1704         * Scripts/webkitpy/common/config/ews.json:
1705         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1706         (test_ews_name):
1707
1708 2019-02-27  John Wilander  <wilander@apple.com>
1709
1710         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1711         https://bugs.webkit.org/show_bug.cgi?id=195071
1712         <rdar://problem/48417690>
1713
1714         Reviewed by Alex Christensen and Brent Fulgham.
1715
1716         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1717         (TestWebKitAPI::createURL):
1718             Convenience function.
1719         (TestWebKitAPI::TEST):
1720             WebCore::AdClickAttribution now takes a URL when creating Source and
1721             Destination.
1722         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1723         (TestWebKitAPI::TEST):
1724             WebCore::AdClickAttribution now takes a URL when creating Source and
1725             Destination.
1726
1727 2019-02-27  Antoine Quint  <graouts@apple.com>
1728
1729         Support Pointer Events on macOS
1730         https://bugs.webkit.org/show_bug.cgi?id=195008
1731         <rdar://problem/47454419>
1732
1733         Reviewed by Dean Jackson.
1734
1735         * DumpRenderTree/mac/DumpRenderTree.mm:
1736         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1737         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1738
1739 2019-02-26  Mark Lam  <mark.lam@apple.com>
1740
1741         Remove remaining poisoning code.
1742         https://bugs.webkit.org/show_bug.cgi?id=194138
1743
1744         Reviewed by Saam Barati.
1745
1746         * TestWebKitAPI/CMakeLists.txt:
1747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1748         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1749         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1750         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1751         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1752         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1753         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1754
1755 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1756
1757         Move ephemeral local storage from WebProcess to UIProcess
1758         https://bugs.webkit.org/show_bug.cgi?id=195074
1759         <rdar://problem/47937975>
1760
1761         Reviewed by Geoff Garen.
1762
1763         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1764
1765 2019-02-20  Jer Noble  <jer.noble@apple.com>
1766
1767         [Cocoa] Media elements will restart network buffering just before suspending
1768         https://bugs.webkit.org/show_bug.cgi?id=193691
1769
1770         Reviewed by Eric Carlson.
1771
1772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1774         (TEST):
1775
1776 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1777
1778         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1779         https://bugs.webkit.org/show_bug.cgi?id=191652
1780
1781         Reviewed by Alex Christensen.
1782
1783         Fix WinCairo MiniBrowser behavior of authentication dialog.
1784
1785         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1786         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1787
1788 2019-02-26  Youenn Fablet  <youenn@apple.com>
1789
1790         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1791         https://bugs.webkit.org/show_bug.cgi?id=195028
1792         <rdar://problem/48243733>
1793
1794         Reviewed by Eric Carlson.
1795
1796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1797
1798 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1799
1800         [WPE] Add API for webview background color configuration
1801         https://bugs.webkit.org/show_bug.cgi?id=192305
1802
1803         Reviewed by Michael Catanzaro.
1804
1805         * MiniBrowser/wpe/main.cpp:
1806         (main): Add a new option to configure the webview background
1807         color. Example: --bg-color=transparent.
1808         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1809         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1810         (beforeAll): Ditto.
1811
1812 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1813
1814         scalableNativeWebpageParameters() is not preserved on new page navigation.
1815         https://bugs.webkit.org/show_bug.cgi?id=194892
1816         <rdar://problem/47538280>
1817
1818         Reviewed by Wenson Hsieh.
1819         
1820         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1821
1822         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1823         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1824         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1825         (WTR::UIScriptController::allowsViewportShrinkToFit):
1826         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1827         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1828         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1829         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1830         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1831         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1832
1833 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1834
1835         [ews-app] Add model for handling multiple Buildbot instances
1836         https://bugs.webkit.org/show_bug.cgi?id=194863
1837
1838         Reviewed by Stephanie Lewis.
1839
1840         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1841
1842 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1843
1844         [ews-app] Remove BuilderMapping table
1845         https://bugs.webkit.org/show_bug.cgi?id=194961
1846
1847         Reviewed by Stephanie Lewis.
1848
1849         Store builder name directly in build table, instead of having a separate
1850         table for it.
1851
1852         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1853         * BuildSlaveSupport/ews-app/ews/models/build.py:
1854         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1855         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1856
1857 2019-02-25  John Wilander  <wilander@apple.com>
1858
1859         Introduce and adopt new class RegistrableDomain for eTLD+1
1860         https://bugs.webkit.org/show_bug.cgi?id=194791
1861         <rdar://problem/48179240>
1862
1863         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1864
1865         This patch adds an API test and replaces two instances of
1866         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1867
1868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1869         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1870         (TestWebKitAPI::TEST):
1871             Changed two strings to make sure the registrable domains are still considered
1872             invalid and pass the test.
1873         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1874         (TestWebKitAPI::TEST):
1875         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1876         (WTR::InjectedBundle::didReceiveMessageToPage):
1877
1878 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1879
1880         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1881         https://bugs.webkit.org/show_bug.cgi?id=195001
1882
1883         Reviewed by Carlos Garcia Campos.
1884
1885         API version 1.0 always includes the functionality previously guarded with
1886         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1887         unconditionally.
1888
1889         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1890         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1891         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1892         (WebViewTest::showInWindow): Ditto.
1893         (WebViewTest::hideView): Ditto.
1894         * wpe/backends/HeadlessViewBackend.cpp:
1895         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1896         * wpe/backends/ViewBackend.cpp:
1897         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1898         * wpe/backends/WindowViewBackend.cpp:
1899         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1900         WPE_BACKEND_CHECK_VERSION().
1901         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1902
1903 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1904
1905         [Flatpak] Add support for flatpak > 1.1.2
1906         https://bugs.webkit.org/show_bug.cgi?id=194088
1907
1908         Flatpak 1.2 is now out so we need to support that
1909         version now.
1910
1911         Reviewed by Michael Catanzaro.
1912
1913         * flatpak/flatpakutils.py:
1914         (check_flatpak):
1915         (FlatpakPackages.__init__):
1916         (FlatpakPackages.__detect_packages):
1917         (FlatpakPackages.__detect_packages.in):
1918         (FlatpakRepos.update):
1919
1920 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1921
1922         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1923         https://bugs.webkit.org/show_bug.cgi?id=194998
1924
1925         Reviewed by Carlos Garcia Campos.
1926
1927         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1928         to a Git checkout and using the latest commit containing various fixes
1929         and improvements.
1930
1931 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1932
1933         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1934         https://bugs.webkit.org/show_bug.cgi?id=194981
1935
1936         Reviewed by Žan Doberšek.
1937
1938         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1939         (TestWebKitAPI::TEST):
1940
1941 2019-02-23  Keith Miller  <keith_miller@apple.com>
1942
1943         Add new mac target numbers
1944         https://bugs.webkit.org/show_bug.cgi?id=194955
1945
1946         Reviewed by Tim Horton.
1947
1948         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1949         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1950         * MiniBrowser/Configurations/Base.xcconfig:
1951         * TestWebKitAPI/Configurations/Base.xcconfig:
1952         * WebKitTestRunner/Configurations/Base.xcconfig:
1953
1954 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1955
1956         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1957         https://bugs.webkit.org/show_bug.cgi?id=194846
1958
1959         Reviewed by Don Olmstead.
1960
1961         Added _search_paths() and _port_specific_expectations_files() for
1962         WinCairoPort.
1963
1964         * Scripts/webkitpy/port/win.py:
1965         (WinCairoPort.default_baseline_search_path):
1966         (WinCairoPort):
1967         (WinCairoPort._port_specific_expectations_files):
1968         (WinCairoPort._search_paths):
1969
1970 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1971
1972         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1973         https://bugs.webkit.org/show_bug.cgi?id=194963
1974
1975         Reviewed by Dean Jackson.
1976
1977         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1978         Do a `contains` check instead of `equals`, because in debug builds we
1979         put the GraphicsLayer pointer in a prefix.
1980
1981 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1982
1983         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1984         https://bugs.webkit.org/show_bug.cgi?id=194873
1985         <rdar://problem/46701974>
1986
1987         Reviewed by Tim Horton.
1988
1989         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1990
1991         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1992         (WTR::UIScriptController::menuRect const):
1993         (WTR::UIScriptController::isShowingMenu const):
1994         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1995         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1996         (WTR::UIScriptController::menuRect const):
1997
1998         Add a function to query the bounds of the callout menu in content coordinates.
1999
2000         (WTR::UIScriptController::isShowingMenu const):
2001
2002         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2003
2004         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2005         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2006         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2007         (WTR::UIScriptController::rectForMenuAction const):
2008         (WTR::UIScriptController::menuRect const):
2009         (WTR::UIScriptController::isShowingMenu const):
2010         (WTR::findViewInHierarchyOfType): Deleted.
2011
2012 2019-02-22  Chris Dumez  <cdumez@apple.com>
2013
2014         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2015         https://bugs.webkit.org/show_bug.cgi?id=194954
2016         <rdar://problem/48127957>
2017
2018         Reviewed by Alex Christensen.
2019
2020         Add API test coverage.
2021
2022         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2023         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2024         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2025         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2026
2027 2019-02-22  Chris Dumez  <cdumez@apple.com>
2028
2029         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2030         https://bugs.webkit.org/show_bug.cgi?id=194924
2031         <rdar://problem/48216125>
2032
2033         Reviewed by Geoffrey Garen.
2034
2035         Add API test coverage.
2036
2037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2038
2039 2019-02-22  Chris Dumez  <cdumez@apple.com>
2040
2041         Unreviewed, disable API test added in r241928 on iOS.
2042
2043         The cache is not enabled on devices with less than 3GB of RAM.
2044
2045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2046
2047 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2048
2049         Hardcode Visual Viewports on everywhere except iOS WK1
2050         https://bugs.webkit.org/show_bug.cgi?id=194928
2051
2052         Reviewed by Zalan Bujtas.
2053
2054         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2055         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2056         set it to false. The setting has shipped for several years and there's no need to turn
2057         it off now.
2058
2059         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2060         Visual Viewports are not enabled.
2061         
2062         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2063         that only runs in WK2
2064
2065         * MiniBrowser/mac/SettingsController.h:
2066         * MiniBrowser/mac/SettingsController.m:
2067         (-[SettingsController init]):
2068         (-[SettingsController _populateMenu]):
2069         (-[SettingsController validateMenuItem:]):
2070         (-[SettingsController visualViewportEnabled]): Deleted.
2071         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2072         * MiniBrowser/mac/WK1BrowserWindowController.m:
2073         (-[WK1BrowserWindowController didChangeSettings]):
2074         * MiniBrowser/mac/WK2BrowserWindowController.m:
2075         (-[WK2BrowserWindowController didChangeSettings]):
2076
2077 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2078
2079         Discard cached processes when clearing website data store
2080         https://bugs.webkit.org/show_bug.cgi?id=194894
2081
2082         Reviewed by Chris Dumez.
2083
2084         Added a test case.
2085
2086         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2087         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2088
2089 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2090
2091         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2092         https://bugs.webkit.org/show_bug.cgi?id=194914
2093         <rdar://problem/47586889>
2094
2095         Reviewed by Geoffrey Garen.
2096
2097         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2098         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2099         (TEST):
2100         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2101
2102 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2103
2104         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2105         <https://webkit.org/b/194761>
2106
2107         Reviewed by Myles Maxfield.
2108
2109         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2110         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2111         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2112         to use ARC-compliant cast.
2113         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2114         ARC-compliant cast.
2115         (WTR::installFakeHelvetica): Log `error` to console if
2116         CTFontManagerRegisterFontsForURL() fails, but only on supported
2117         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2118         Call CFRelease() on `error` to fix the leak.  Update to use
2119         ARC-compliant cast.
2120         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2121         cast.
2122
2123 2019-02-21  Chris Dumez  <cdumez@apple.com>
2124
2125         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2126         https://bugs.webkit.org/show_bug.cgi?id=194481
2127
2128         Reviewed by Alex Christensen.
2129
2130         Give the processes a chance to shutdown and wait until we reached the expected number
2131         of processes.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2134
2135 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2136
2137         Fix the macOS build
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2140
2141 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2142
2143         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2144
2145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2146         I am a backwards.
2147
2148 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2149
2150         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2151
2152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2153         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2154         We could force on UI-side compositing, but I feel like the test might be more
2155         valuable exercising the normal path on each platform (though the original
2156         bug was also UI-side specific). Though we can't validate that the overlay
2157         layer was installed successfully, there are layout tests that do that.
2158
2159 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2160
2161         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2162         https://bugs.webkit.org/show_bug.cgi?id=194845
2163         <rdar://problem/47944579>
2164
2165         Reviewed by Antti Koivisto.
2166
2167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2169
2170 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2171
2172         [LFC][Floats] Add support for placing formatting roots in-between floats.
2173         https://bugs.webkit.org/show_bug.cgi?id=194902
2174
2175         Reviewed by Antti Koivisto.
2176
2177         * LayoutReloaded/misc/LFC-passing-tests.txt:
2178
2179 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2180
2181         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2182         https://bugs.webkit.org/show_bug.cgi?id=194901
2183
2184         Unreviewed build fix.
2185
2186         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2187         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2188         WPEBackend-fdo-0.1 as library name.
2189
2190 2019-02-21  Rob Buis  <rbuis@igalia.com>
2191
2192         Update MIME type parser
2193         https://bugs.webkit.org/show_bug.cgi?id=180526
2194
2195         Reviewed by Darin Adler.
2196
2197         Add tests involving leading and trailing whitespace, non-token
2198         characters and quoted strings.
2199
2200         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2201         (TestWebKitAPI::TEST):
2202
2203 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2204
2205         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2206         https://bugs.webkit.org/show_bug.cgi?id=194884
2207
2208         Reviewed by Michael Catanzaro.
2209
2210         * PlatformWin.cmake:
2211
2212 2019-02-20  Chris Dumez  <cdumez@apple.com>
2213
2214         Add API test for <rdar://problem/47471222>
2215         https://bugs.webkit.org/show_bug.cgi?id=194847
2216
2217         Reviewed by Alex Christensen.
2218
2219         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2220
2221 2019-02-20  Chris Dumez  <cdumez@apple.com>
2222
2223         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2224         https://bugs.webkit.org/show_bug.cgi?id=194872
2225         <rdar://problem/47924500>
2226
2227         Reviewed by Alex Christensen.
2228
2229         Add API test coverage.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2232
2233 2019-02-20  Jer Noble  <jer.noble@apple.com>
2234
2235         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2236         https://bugs.webkit.org/show_bug.cgi?id=191332
2237
2238         Reviewed by Dean Jackson.
2239
2240         * Scripts/git-is-in-range: Added.
2241
2242 2019-02-20  Andy Estes  <aestes@apple.com>
2243
2244         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2245         https://bugs.webkit.org/show_bug.cgi?id=194869
2246
2247         Rubber-stamped by Jer Noble.
2248
2249         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2250         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2251         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2252         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2254         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2255
2256 2019-02-20  Chris Dumez  <cdumez@apple.com>
2257
2258         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2259         https://bugs.webkit.org/show_bug.cgi?id=194857
2260         <rdar://problem/47759323>
2261
2262         Reviewed by Alex Christensen.
2263
2264         Add API test coverage.
2265
2266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2267
2268 2019-02-20  Chris Dumez  <cdumez@apple.com>
2269
2270         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
2271         https://bugs.webkit.org/show_bug.cgi?id=194829
2272         <rdar://problem/47889906>
2273
2274         Reviewed by Alexey Proskuryakov.
2275
2276         Every time the TestOptions were changing we were creating both a new Web view and
2277         a new WKContext, which would start a new Network process. In most cases, we only
2278         need to contruct a new Web view and we do can keep reusing the same WKContext.
2279         This patch implements this optimization and thus avoids spinning a lot of new
2280         Network processes while running the layout tests.
2281
2282         * WebKitTestRunner/TestController.cpp:
2283         (WTR::TestController::generateContextConfiguration const):
2284         (WTR::TestController::generatePageConfiguration):
2285         (WTR::TestController::createWebViewWithOptions):
2286         (WTR::TestController::resetPreferencesToConsistentValues):
2287         (WTR::updateTestOptionsFromTestHeader):
2288         * WebKitTestRunner/TestController.h:
2289         * WebKitTestRunner/TestOptions.h:
2290         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
2291         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
2292         (WTR::TestOptions::hasSameInitializationOptions const):
2293         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
2294         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2295         (WTR::TestController::platformAddTestOptions const):
2296
2297 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2298
2299         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
2300         https://bugs.webkit.org/show_bug.cgi?id=167941
2301
2302         Reviewed by Carlos Garcia Campos.
2303
2304         * MiniBrowser/gtk/main.c:
2305         (filterSavedCallback): Added.
2306         (main): Support loading a JSON rule set file for content filtering.
2307         * MiniBrowser/wpe/main.cpp:
2308         (filterSavedCallback): Added.
2309         (main): Support loading a JSON rule set file for content filtering.
2310         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
2311         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
2312         (WTF::derefGPtr): Ditto.
2313         (testEmptyStore):
2314         (testSaveInvalidFilter):
2315         (testSaveLoadFilter):
2316         (testSavedFilterIdentifierMatch):
2317         (testRemoveFilter):
2318         (testSaveMultipleFilters):
2319         (testSaveFilterFromFile):
2320         (testFilterPersistence):
2321         (beforeAll):
2322         (afterAll):
2323         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2324         (removeOldInjectedContentAndResetLists): Also reset content filters.
2325         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
2326         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
2327         the element affected by the style sheet.
2328         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
2329         and returns it to be used by tests.
2330         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
2331         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
2332         (serverCallback): Add support for serving a CSS style sheet for testing.
2333         (beforeAll): Add call to testUserContentManagerContentFilter().
2334         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
2335
2336 2019-02-19  Keith Rollin  <krollin@apple.com>
2337
2338         Add timing information to build output
2339         https://bugs.webkit.org/show_bug.cgi?id=194839
2340         <rdar://problem/48219609>
2341
2342         Reviewed by Alexey Proskuryakov.
2343
2344         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
2345         emit each project's build time to its output. E.g.,
2346
2347             ** BUILD SUCCEEDED ** [0.132 sec]
2348
2349         * Scripts/webkitdirs.pm:
2350         (XcodeOptions):
2351
2352 2019-02-19  Truitt Savell  <tsavell@apple.com>
2353
2354         Unreviewed, rolling out r241784.
2355
2356         Broke all OpenSource builds.
2357
2358         Reverted changeset:
2359
2360         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
2361         instances view"
2362         https://bugs.webkit.org/show_bug.cgi?id=172848
2363         https://trac.webkit.org/changeset/241784
2364
2365 2019-02-19  Zalan Bujtas  <zalan@apple.com>
2366
2367         [LFC][Floats] Remove redundant intersecting logic
2368         https://bugs.webkit.org/show_bug.cgi?id=194804
2369
2370         Reviewed by Antti Koivisto.
2371
2372         * LayoutReloaded/misc/LFC-passing-tests.txt:
2373
2374 2019-02-19  Dean Jackson  <dino@apple.com>
2375
2376         Clean-up output from generate-xcfilelists so it can be filtered
2377         https://bugs.webkit.org/show_bug.cgi?id=194795
2378
2379         Reviewed by Joseph Pecoraro (and Keith Rollin).
2380
2381         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
2382         make a slight tweak to filter-build-webkit so such lines are marked
2383         as plain.
2384
2385         * Scripts/filter-build-webkit:
2386         * Scripts/generate-xcfilelists:
2387
2388 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
2389
2390         pytest is not correctly auto-installed
2391         https://bugs.webkit.org/show_bug.cgi?id=194707
2392
2393         Reviewed by Carlos Garcia Campos.
2394
2395         * Scripts/webkitpy/thirdparty/__init__.py:
2396         (AutoinstallImportHook._install_pytest):
2397
2398 2019-02-18  Chris Dumez  <cdumez@apple.com>
2399
2400         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
2401         https://bugs.webkit.org/show_bug.cgi?id=194797
2402         <rdar://problem/48055151>
2403
2404         Reviewed by Geoffrey Garen.
2405
2406         Add API test coverage.
2407
2408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2409
2410 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2411
2412         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
2413         https://bugs.webkit.org/show_bug.cgi?id=194670
2414         <rdar://problem/39066529>
2415
2416         Reviewed by Tim Horton.
2417
2418         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
2419         pasted in an editable area as attachment elements.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2422         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2423         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
2424         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2425         (TestWebKitAPI::TEST):
2426         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2427         (WTR::InjectedBundlePage::InjectedBundlePage):
2428
2429 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2430
2431         Fix API test after r241728
2432        ​https://bugs.webkit.org/show_bug.cgi?id=194723
2433
2434         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2435         (TEST):
2436         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
2437
2438 2019-02-18  Daniel Bates  <dabates@apple.com>
2439
2440         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2441         https://bugs.webkit.org/show_bug.cgi?id=192824
2442         <rdar://problem/47100332>
2443
2444         Reviewed by Wenson Hsieh.
2445
2446         Fix a bug where the wrong usage code was used for F13 thru F24.
2447
2448         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2449         (keyCodeForDOMFunctionKey):
2450
2451 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
2452
2453         Bytecode cache should a have a boot-specific validation
2454         https://bugs.webkit.org/show_bug.cgi?id=194769
2455         <rdar://problem/48149509>
2456
2457         Reviewed by Keith Miller.
2458
2459         Add test for WTF::bootSessionUUIDString()
2460
2461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2462         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
2463         (TEST):
2464
2465 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2466
2467         Disable safe browsing in WKWebView and remove its WKPreferences API
2468         https://bugs.webkit.org/show_bug.cgi?id=194723
2469         <rdar://problem/48122993>
2470
2471         Reviewed by Geoffrey Garen.
2472
2473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2474         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2475         (TEST):
2476         (safeBrowsingView):
2477         Make tests use SPI instead of API.
2478
2479 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2480
2481         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
2482         https://bugs.webkit.org/show_bug.cgi?id=194586
2483
2484         Reviewed by Ross Kirsling.
2485
2486         * DumpRenderTree/win/DumpRenderTree.cpp:
2487         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
2488         * Scripts/webkitpy/port/driver.py:
2489         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
2490
2491 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2492
2493         Unreviewed, rolling out r241620.
2494
2495         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
2496         (Requested by ddkilzer on #webkit.)
2497
2498         Reverted changeset:
2499
2500         "[WTF] Add environment variable helpers"
2501         https://bugs.webkit.org/show_bug.cgi?id=192405
2502         https://trac.webkit.org/changeset/241620
2503
2504 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2505
2506         [LFC] RenderImage's default intrinsic size is 0.
2507         https://bugs.webkit.org/show_bug.cgi?id=194745
2508
2509         Reviewed by Antti Koivisto.
2510
2511         * LayoutReloaded/misc/LFC-passing-tests.txt:
2512
2513 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2514
2515         [LFC][BFC] Add support for block replaced intrinsic width.
2516         https://bugs.webkit.org/show_bug.cgi?id=194705
2517
2518         Reviewed by Simon Fraser.
2519
2520         * LayoutReloaded/misc/LFC-passing-tests.txt:
2521
2522 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2523
2524         [LFC] Apply min/max width constraints to preferred width computation
2525         https://bugs.webkit.org/show_bug.cgi?id=194739
2526
2527         Reviewed by Simon Fraser.
2528
2529         * LayoutReloaded/misc/LFC-passing-tests.txt:
2530
2531 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2532
2533         [WTF] Add environment variable helpers
2534         https://bugs.webkit.org/show_bug.cgi?id=192405
2535
2536         Reviewed by Michael Catanzaro.
2537
2538         * DumpRenderTree/mac/DumpRenderTree.mm:
2539         (libraryPathForDumpRenderTree):
2540         * DumpRenderTree/win/DumpRenderTree.cpp:
2541         (libraryPathForDumpRenderTree):
2542         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2543         (setUpIOSLayoutTestCommunication):
2544         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2545         (beforeAll):
2546         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2547         (main):
2548         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2549         (WebKitTestBus::run):
2550         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2551         (WTR::getOutputDir):
2552         (WTR::initializeFontConfigSetting):
2553         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2554         (WTR::InjectedBundle::platformInitialize):
2555         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2556         (WTR::topLevelPath):
2557         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2558         (WTR::topLevelPath):
2559         (WTR::getOutputDir):
2560         (WTR::activateFonts):
2561         * WebKitTestRunner/TestController.cpp:
2562         (WTR::TestController::libraryPathForTesting):
2563         (WTR::TestController::generateContextConfiguration const):
2564         (WTR::TestController::generatePageConfiguration):
2565         (WTR::TestController::decideDestinationWithSuggestedFilename):
2566         (WTR::TestController::platformAdjustContext):
2567         * WebKitTestRunner/TestController.h:
2568         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2569         (WTR::TestController::cocoaPlatformInitialize):
2570         (WTR::TestController::platformAdjustContext):
2571         * WebKitTestRunner/gtk/main.cpp:
2572         (main):
2573         * WebKitTestRunner/mac/TestControllerMac.mm:
2574         (WTR::TestController::configureContentExtensionForTest):
2575         * WebKitTestRunner/wpe/main.cpp:
2576         (main):
2577         Utilize WTF::Environment where possible.
2578
2579 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2580
2581         [iOS] WKWebView callout bar is missing Change Writing Direction item
2582         https://bugs.webkit.org/show_bug.cgi?id=190015
2583         <rdar://problem/44810366>
2584
2585         Reviewed by Tim Horton.
2586
2587         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2588         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2589
2590         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2591         (TestWebKitAPI::TEST):
2592
2593 2019-02-15  Chris Dumez  <cdumez@apple.com>
2594
2595         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2596         https://bugs.webkit.org/show_bug.cgi?id=194717
2597         <rdar://problem/47884404>
2598
2599         Reviewed by Brady Eidson.
2600
2601         Add API test coverage.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2604
2605 2019-02-15  Youenn Fablet  <youenn@apple.com>
2606
2607         Make navigator.mediaDevices SecureContext
2608         https://bugs.webkit.org/show_bug.cgi?id=194666
2609
2610         Reviewed by Eric Carlson.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2613         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2614         (TEST_F):
2615
2616 2019-02-15  Brian Burg  <bburg@apple.com>
2617
2618         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2619         https://bugs.webkit.org/show_bug.cgi?id=194411
2620         <rdar://problem/47787614>
2621
2622         Reviewed by Joseph Pecoraro.
2623
2624         Remove unnecessary soft linking macro usage.
2625
2626         * DumpRenderTree/mac/TestRunnerMac.mm:
2627         (TestRunner::inspectorTestStubURL):
2628         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2629         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2630         (WTR::TestRunner::inspectorTestStubURL):
2631
2632 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2633
2634         Unreviewed, rolling out r241559 and r241566.
2635         https://bugs.webkit.org/show_bug.cgi?id=194710
2636
2637         Causes layout test crashes under GuardMalloc (Requested by
2638         ryanhaddad on #webkit).
2639
2640         Reverted changesets:
2641
2642         "[WTF] Add environment variable helpers"
2643         https://bugs.webkit.org/show_bug.cgi?id=192405
2644         https://trac.webkit.org/changeset/241559
2645
2646         "Unreviewed build fix for WinCairo Debug after r241559."
2647         https://trac.webkit.org/changeset/241566
2648
2649 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2650
2651         [LFC] Out-of-flow box is never a float box
2652         https://bugs.webkit.org/show_bug.cgi?id=194704
2653
2654         Reviewed by Antti Koivisto.
2655
2656         * LayoutReloaded/misc/LFC-passing-tests.txt:
2657
2658 2019-02-10  Darin Adler  <darin@apple.com>
2659
2660         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2661         https://bugs.webkit.org/show_bug.cgi?id=194487
2662
2663         Reviewed by Daniel Bates.
2664
2665         * DumpRenderTree/win/DumpRenderTree.cpp:
2666         (applicationId): Use makeString instead of String::format.
2667         (main): Ditto.
2668         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2669         (TestWebKitAPI::Util::createURLForResource): Ditto.
2670         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2671         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2672
2673         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2674         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2675         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2676         (WTR::createStringWithAttributes): Use appendLiteral.
2677         (WTR::AccessibilityUIElement::helpText const): Ditto.
2678         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2679         directly instead of using String::format.
2680         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2681         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2682
2683 2019-02-15  Truitt Savell  <tsavell@apple.com>
2684
2685         Unreviewed, rolling out r241564.
2686
2687         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2688
2689         Reverted changeset:
2690
2691         "[Mac] WebInspectorUI.framework does not need to be soft-
2692         linked anymore"
2693         https://bugs.webkit.org/show_bug.cgi?id=194411
2694         https://trac.webkit.org/changeset/241564
2695
2696 2019-02-15  Saam barati  <sbarati@apple.com>
2697
2698         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2699         https://bugs.webkit.org/show_bug.cgi?id=194036
2700
2701         Reviewed by Yusuke Suzuki.
2702
2703         * Scripts/run-jsc-stress-tests:
2704
2705 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2706
2707         Fix the build.
2708
2709         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2710         (WTR::UIScriptController::drawSquareInEditableImage):
2711         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2712         (TestWebKitAPI::drawSquareInEditableImage):
2713
2714 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2715
2716         Fix the build.
2717
2718         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2719         (WTR::UIScriptController::drawSquareInEditableImage):
2720         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2721         (TestWebKitAPI::drawSquareInEditableImage):
2722
2723 2019-02-14  Brian Burg  <bburg@apple.com>
2724
2725         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2726         https://bugs.webkit.org/show_bug.cgi?id=194411
2727         <rdar://problem/47787614>
2728
2729         Reviewed by Joseph Pecoraro.
2730
2731         Remove unnecessary soft linking macro usage.
2732
2733         * DumpRenderTree/mac/TestRunnerMac.mm:
2734         (TestRunner::inspectorTestStubURL):
2735         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2736         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2737         (WTR::TestRunner::inspectorTestStubURL):
2738
2739 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2740
2741         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2742         https://bugs.webkit.org/show_bug.cgi?id=194599
2743
2744         Reviewed by Lucas Forschler.
2745
2746         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2747         (StatusBubble._build_bubble):
2748
2749 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2750
2751         [ews-app] Set Foreign Key in Django build model
2752         https://bugs.webkit.org/show_bug.cgi?id=194667
2753
2754         Reviewed by Lucas Forschler.
2755
2756         * BuildSlaveSupport/ews-app/ews/models/build.py:
2757         (Build):
2758
2759 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2760
2761         [WTF] Add environment variable helpers
2762         https://bugs.webkit.org/show_bug.cgi?id=192405
2763
2764         Reviewed by Michael Catanzaro.
2765
2766         * DumpRenderTree/mac/DumpRenderTree.mm:
2767         (libraryPathForDumpRenderTree):
2768         * DumpRenderTree/win/DumpRenderTree.cpp:
2769         (libraryPathForDumpRenderTree):
2770         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2771         (setUpIOSLayoutTestCommunication):
2772         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2773         (TestWebKitAPI::strip):
2774         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2775         (beforeAll):
2776         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2777         (main):
2778         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2779         (WebKitTestBus::run):
2780         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2781         (WTR::getOutputDir):
2782         (WTR::initializeFontConfigSetting):
2783         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2784         (WTR::InjectedBundle::platformInitialize):
2785         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2786         (WTR::topLevelPath):
2787         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2788         (WTR::topLevelPath):
2789         (WTR::getOutputDir):
2790         (WTR::activateFonts):
2791         * WebKitTestRunner/TestController.cpp:
2792         (WTR::TestController::libraryPathForTesting):
2793         (WTR::TestController::generateContextConfiguration const):
2794         (WTR::TestController::generatePageConfiguration):
2795         (WTR::TestController::decideDestinationWithSuggestedFilename):
2796         (WTR::TestController::platformAdjustContext):
2797         * WebKitTestRunner/TestController.h:
2798         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2799         (WTR::TestController::cocoaPlatformInitialize):
2800         (WTR::TestController::platformAdjustContext):
2801         * WebKitTestRunner/gtk/main.cpp:
2802         (main):
2803         * WebKitTestRunner/mac/TestControllerMac.mm:
2804         (WTR::TestController::configureContentExtensionForTest):
2805         * WebKitTestRunner/wpe/main.cpp:
2806         (main):
2807         Utilize WTF::Environment where possible.
2808
2809 2019-02-14  Chris Dumez  <cdumez@apple.com>
2810
2811         [PSON] Introduce a WebContent Process cache
2812         https://bugs.webkit.org/show_bug.cgi?id=194594
2813         <rdar://problem/46793397>
2814
2815         Reviewed by Geoff Garen.
2816
2817         Update API tests to turn on the WebContent Process cache.
2818
2819         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2820
2821 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2822
2823         Unreviewed, build fix after r241480
2824
2825         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2826         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2827         (-[DragAndDropSimulator initWithWebView:]):
2828
2829 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2830
2831         AX: ARIA Reflection was disabled in error
2832         https://bugs.webkit.org/show_bug.cgi?id=194647
2833         <rdar://problem/48068336>
2834
2835         Reviewed by Ryosuke Niwa.
2836
2837         Remove test override now that this feature should be enabled by default.
2838
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::TestController::resetPreferencesToConsistentValues):
2841
2842 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2843
2844         Unreviewed, rolling out r241486.
2845         https://bugs.webkit.org/show_bug.cgi?id=194655
2846
2847         causing API failures in builds (Requested by ShawnRoberts on
2848         #webkit).
2849
2850         Reverted changeset:
2851
2852         "[Cocoa] Media elements will restart network buffering just
2853         before suspending"
2854         https://bugs.webkit.org/show_bug.cgi?id=193691
2855         https://trac.webkit.org/changeset/241486
2856
2857 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2858
2859         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2860         https://bugs.webkit.org/show_bug.cgi?id=194622
2861
2862         Reviewed by Antti Koivisto.
2863
2864         * LayoutReloaded/misc/LFC-passing-tests.txt:
2865
2866 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2867
2868         [LFC] Shrink-to-fit-width should be constrained by min/max width
2869         https://bugs.webkit.org/show_bug.cgi?id=194653
2870
2871         Reviewed by Antti Koivisto.
2872
2873         * LayoutReloaded/misc/LFC-passing-tests.txt:
2874
2875 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2876
2877         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2878         https://bugs.webkit.org/show_bug.cgi?id=194641
2879
2880         Reviewed by Geoffrey Garen.
2881
2882         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2883         so that the test would fail without this fix.
2884
2885         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2886         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2887
2888 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2889
2890         [ews-app] Change log level for a log statement
2891
2892         Unreviewed minor fix.
2893
2894         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2895         (Patch.save_patch):
2896
2897 2019-02-13  Jer Noble  <jer.noble@apple.com>
2898
2899         [Cocoa] Media elements will restart network buffering just before suspending
2900         https://bugs.webkit.org/show_bug.cgi?id=193691
2901
2902         Reviewed by Eric Carlson.
2903
2904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2905         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2906         (TEST):
2907
2908 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2909
2910         [ews-app] Fetch builder id to name mapping
2911         https://bugs.webkit.org/show_bug.cgi?id=194355
2912
2913         Reviewed by Lucas Forschler.
2914
2915         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2916         (Buildbot.get_builder_id_to_name_mapping):
2917         (Buildbot._get_display_name_from_builder_name):
2918
2919 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2920
2921         Further restricting webarchive loads
2922         https://bugs.webkit.org/show_bug.cgi?id=194567
2923         <rdar://problem/47610130>
2924
2925         Reviewed by Youenn Fablet.
2926
2927         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2928         navigations on drop.
2929
2930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2931         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2932         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2933         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2934         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2935         (TestWebKitAPI::TEST):
2936         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2937         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2938         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2939         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2940         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2941         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2942         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2943
2944 2019-02-13  John Wilander  <wilander@apple.com>
2945
2946         Store Ad Click Attribution requests in the network process
2947         https://bugs.webkit.org/show_bug.cgi?id=194510
2948         <rdar://problem/47650118>
2949
2950         Reviewed by Alex Christensen and Daniel Bates.
2951
2952         This patch adds two TestRunner functions:
2953         - dumpAdClickAttribution()
2954         - clearAdClickAttribution()
2955
2956         They call into the network process to dump and clear Ad Click
2957         Attribution state, respectively.
2958
2959         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2960         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2961         (WTR::TestRunner::dumpAdClickAttribution):
2962         (WTR::TestRunner::clearAdClickAttribution):
2963         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2964         * WebKitTestRunner/TestController.cpp:
2965         (WTR::TestController::resetStateToConsistentValues):
2966         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2967         (WTR::adClickAttributionStringResultCallback):
2968         (WTR::TestController::dumpAdClickAttribution):
2969         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2970         (WTR::adClickAttributionVoidCallback):
2971         (WTR::TestController::clearAdClickAttribution):
2972         * WebKitTestRunner/TestController.h:
2973         * WebKitTestRunner/TestInvocation.cpp:
2974         (WTR::TestInvocation::dumpResults):
2975         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2976         (WTR::TestInvocation::dumpAdClickAttribution):
2977         * WebKitTestRunner/TestInvocation.h:
2978
2979 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2980
2981         [ews-app] Generate status-bubble
2982         https://bugs.webkit.org/show_bug.cgi?id=194572
2983
2984         Reviewed by Lucas Forschler.
2985
2986         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2987         (StatusBubble._build_bubble):
2988         (StatusBubble._should_show_bubble_for):
2989         (StatusBubble._build_bubbles_for_patch):
2990
2991 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2992
2993         [ews-app] Add status bubble html template
2994         https://bugs.webkit.org/show_bug.cgi?id=194571
2995
2996         Reviewed by Lucas Forschler.
2997
2998         * BuildSlaveSupport/ews-app/ews/templates: Added.
2999         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3000
3001 2019-02-12  Chris Dumez  <cdumez@apple.com>
3002
3003         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3004         https://bugs.webkit.org/show_bug.cgi?id=194568
3005         <rdar://problem/47944490>
3006
3007         Reviewed by Ryosuke Niwa.
3008
3009         Add API test coverage.
3010
3011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3012         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3013
3014 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3015
3016         webkitpy: Remove bug_dummy from parsed test expectations
3017         https://bugs.webkit.org/show_bug.cgi?id=194562
3018         <rdar://problem/47853999>
3019
3020         Reviewed by Lucas Forschler.
3021
3022         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3023         (TestExpectationParser):
3024         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3025         skipped tests.
3026         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3027
3028 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-app] Add method to fetch patch
3031         https://bugs.webkit.org/show_bug.cgi?id=194518
3032
3033         Reviewed by Lucas Forschler.
3034
3035         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3036         (Patch.get_patch):
3037
3038 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3039
3040         [LFC] Expand tests coverage (60 new tests -> 860)
3041
3042         Unreviewed test gardening (run-singly, --child-processes=1).
3043
3044         * LayoutReloaded/misc/LFC-passing-tests.txt:
3045
3046 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3047
3048         Allow pages to trigger programmatic paste from script on iOS
3049         https://bugs.webkit.org/show_bug.cgi?id=194271
3050         <rdar://problem/47808810>
3051
3052         Reviewed by Tim Horton.
3053
3054         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3055
3056         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3057         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3058         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3059         (WTR::UIScriptController::rectForMenuAction const):
3060
3061         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3062         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3063         for when the menu is shown or hidden.
3064
3065         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3066         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3067         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3068         (WTR::UIScriptController::setDidShowMenuCallback):
3069         (WTR::UIScriptController::didShowMenuCallback const):
3070         (WTR::UIScriptController::setDidHideMenuCallback):
3071         (WTR::UIScriptController::didHideMenuCallback const):
3072         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3073         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3074         (WTR::UIScriptController::rectForMenuAction const):
3075         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3076         * WebKitTestRunner/TestController.cpp:
3077         (WTR::TestController::resetPreferencesToConsistentValues):
3078         (WTR::updateTestOptionsFromTestHeader):
3079         * WebKitTestRunner/TestOptions.h:
3080
3081         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
3082         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
3083
3084         (WTR::TestOptions::hasSameInitializationOptions const):
3085         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3086         (WTR::UIScriptController::calendarType const):
3087         (WTR::UIScriptController::platformUndoManager const):
3088         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3089         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3090         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3091         (-[TestRunnerWKWebView dealloc]):
3092         (-[TestRunnerWKWebView _didShowMenu]):
3093         (-[TestRunnerWKWebView _didHideMenu]):
3094
3095         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
3096
3097         * WebKitTestRunner/ios/TestControllerIOS.mm:
3098         (WTR::handleMenuWillHideNotification):
3099         (WTR::handleMenuDidHideNotification):
3100         (WTR::TestController::platformInitialize):
3101         (WTR::TestController::platformDestroy):
3102         (WTR::TestController::platformResetStateToConsistentValues):
3103
3104         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
3105         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
3106
3107         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3108         (WTR::forEachViewInHierarchy):
3109         (WTR::findViewInHierarchyOfType):
3110
3111         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
3112         functions that dig through a given view's hierarchy in search of a view of a given class.
3113
3114         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3115         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3116         (WTR::UIScriptController::selectionCaretViewRect const):
3117         (WTR::UIScriptController::selectionRangeViewRects const):
3118         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3119         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3120
3121         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
3122
3123         (WTR::UIScriptController::rectForMenuAction const):
3124
3125         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
3126         callout bar) whose label matches the given string.
3127
3128         (WTR::UIScriptController::platformContentView const):
3129
3130         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
3131         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
3132         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
3133
3134         (WTR::UIScriptController::platformUndoManager const): Deleted.
3135         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3136         (WTR::UIScriptController::platformContentView const):
3137         (WTR::UIScriptController::platformUndoManager const): Deleted.
3138
3139 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3140
3141         webkitpy: No option to only show unexpected failures in results.html for iPad
3142         https://bugs.webkit.org/show_bug.cgi?id=194554
3143         <rdar://problem/47922442>
3144
3145         Rubber-stamped by Aakash Jain.
3146
3147         Just because a TestExpecations file does not exist for a specific platform does not mean that
3148         TestExpecations are not being used, given that platforms inherit test expectations.
3149
3150         * Scripts/webkitpy/port/base.py:
3151         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
3152         * Scripts/webkitpy/port/base_unittest.py:
3153         (PortTest.test_uses_test_expectations_file):
3154
3155 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3156
3157         Remove setDefersLoading infrastructure from WebKit2
3158         https://bugs.webkit.org/show_bug.cgi?id=194506
3159
3160         Reviewed by Brady Eidson.
3161
3162         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3163         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3164         (WTR::TestRunner::setDefersLoading): Deleted.
3165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3166
3167 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3168
3169         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
3170         https://bugs.webkit.org/show_bug.cgi?id=194522
3171         <rdar://problem/47789393>
3172
3173         Reviewed by Chris Dumez.
3174
3175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3176         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
3177         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3179
3180 2019-02-12  Andy Estes  <aestes@apple.com>
3181
3182         [iOSMac] Enable Parental Controls Content Filtering
3183         https://bugs.webkit.org/show_bug.cgi?id=194521
3184         <rdar://39732376>
3185
3186         Reviewed by Tim Horton.
3187
3188         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3189
3190 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3191
3192         [LFC][IFC] Add intrinsic width support for float boxes.
3193         https://bugs.webkit.org/show_bug.cgi?id=194528
3194
3195         Reviewed by Antti Koivisto.
3196
3197         Expand tests coverage (2 new tests -> 800).
3198         (This is the correct test ordering --runs-singly --child-processes=1)
3199
3200         * LayoutReloaded/misc/LFC-passing-tests.txt:
3201
3202 2019-02-12  Rob Buis  <rbuis@igalia.com>
3203
3204         Implement serializing in MIME type parser
3205         https://bugs.webkit.org/show_bug.cgi?id=193909
3206
3207         Reviewed by Darin Adler.
3208
3209         Add various tests involving upper case, non-ASCII, control/null characters,
3210         various HTTP whitespace, single quotes and an unpaired surrogate.
3211
3212         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3213         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
3214         (TestWebKitAPI::serializeIfValid):
3215         (TestWebKitAPI::TEST):
3216
3217 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
3218
3219         [Cocoa] Ask platform for generic font family mappings
3220         https://bugs.webkit.org/show_bug.cgi?id=187723
3221         <rdar://problem/41892438>
3222
3223         Reviewed by Brent Fulgham.
3224
3225         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3226
3227         * DumpRenderTree/mac/DumpRenderTree.mm:
3228         (allowedFontFamilySet):
3229         * WebKitTestRunner/mac/TestControllerMac.mm:
3230         (WTR::allowedFontFamilySet):
3231
3232 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
3233
3234         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
3235         https://bugs.webkit.org/show_bug.cgi?id=193622
3236
3237         Reviewed by Michael Catanzaro.
3238
3239         This adds support for loading content extension rule sets from the JSON files which
3240         accompany the corresponding layout test, using the C API. The Cocoa specific parts
3241         of WKTR for this could be removed, but that is left for a follow-up patch with
3242         cleanups.
3243
3244         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
3245         * WebKitTestRunner/TestController.cpp:
3246         (WTR::testPath): Subtract one from the length when constructing the result std::string to
3247         avoid having the null-terminator copied into the result.
3248         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
3249         part of the preparations to run a test.
3250         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
3251         (WTR::contentExtensionStoreCallback): Added.
3252         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
3253         used for content extensions test.
3254         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
3255         extensions and compiling the JSON rule set for tests involving content extensions.
3256         (WTR::TestController::resetContentExtensions): Removes the content extension built for
3257         testing and disables content extensions.
3258         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
3259         resetContentExtensions().
3260         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
3261         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
3262         configureContentExtensionForTest(), and userContentController().
3263
3264 2019-02-11  Daniel Bates  <dabates@apple.com>
3265
3266         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3267         https://bugs.webkit.org/show_bug.cgi?id=191446
3268         <rdar://problem/45929460>
3269
3270         Reviewed by Tim Horton.
3271
3272         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3273
3274         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3275         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3276         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3277         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3278         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3279         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3280         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3281         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3282         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3283         (WTR::arrayLength):
3284         (WTR::parseModifierArray):
3285         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3286         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3287         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3288         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3289
3290 2019-02-11  Commit Queue  <commit-queue@webkit.org>
3291
3292         Unreviewed, rolling out r241272 and r241276.
3293         https://bugs.webkit.org/show_bug.cgi?id=194514
3294
3295         Broke the Apple Internal build and the fix requires human
3296         intervention :( (Requested by dydz on #webkit).
3297
3298         Reverted changesets:
3299
3300         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
3301         https://bugs.webkit.org/show_bug.cgi?id=191446
3302         https://trac.webkit.org/changeset/241272
3303
3304         "Fix internal iOS build after r241272"
3305         https://bugs.webkit.org/show_bug.cgi?id=191446
3306         https://trac.webkit.org/changeset/241276
3307
3308 2019-02-11  Truitt Savell  <tsavell@apple.com>
3309
3310         Unreviewed, rolling out r241269.
3311
3312         Caused 5 layout tests crashes on Mac WK1
3313
3314         Reverted changeset:
3315
3316         "DumpRenderTree should report unknown options"
3317         https://bugs.webkit.org/show_bug.cgi?id=191303
3318         https://trac.webkit.org/changeset/241269
3319
3320 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3321
3322         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
3323         https://bugs.webkit.org/show_bug.cgi?id=194313
3324
3325         Reviewed by Tim Horton.
3326
3327         Add a helper to determine whether the web view is presenting modal UI.
3328
3329         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3330         (WTR::UIScriptController::isPresentingModally const):
3331         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3332         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3333         (WTR::UIScriptController::isPresentingModally const):
3334         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3335         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3336         (WTR::UIScriptController::calendarType const): Deleted.
3337         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3338         (WTR::UIScriptController::isPresentingModally const):
3339         (WTR::UIScriptController::calendarType const):
3340         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3341         (WTR::UIScriptController::calendarType const):
3342
3343 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
3344
3345         GCHeapInspector: Show the retained sizes in more places
3346         https://bugs.webkit.org/show_bug.cgi?id=194464
3347
3348         Reviewed by Simon Fraser.
3349
3350         * GCHeapInspector/gc-heap-inspector.html:
3351         * GCHeapInspector/script/interface.js:
3352         (HeapInspectorUtils.humanReadableSize):
3353         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
3354         (HeapInspectorUtils.spanForNode.span.span):
3355         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
3356         (HeapSnapshotInspector.prototype.buildRoots):
3357
3358 2019-02-11  Daniel Bates  <dabates@apple.com>
3359
3360         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3361         https://bugs.webkit.org/show_bug.cgi?id=191446
3362         <rdar://problem/45929460>
3363
3364         Reviewed by Tim Horton.
3365
3366         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3367
3368         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3369         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3370         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3371         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3372         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3373         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3374         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3375         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3376         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3377         (WTR::arrayLength):
3378         (WTR::parseModifierArray):
3379         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3380         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3381         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3382         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3383
3384 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
3385
3386         DumpRenderTree should report unknown options
3387         https://bugs.webkit.org/show_bug.cgi?id=191303
3388
3389         Reviewed by Frédéric Wang.
3390
3391         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
3392         to report unknown options.
3393         Added and assigned test options which are currently used in tests.
3394
3395         * DumpRenderTree/TestOptions.cpp:
3396         (TestOptions::TestOptions):
3397
3398 2019-02-11  Truitt Savell  <tsavell@apple.com>
3399
3400         Unreviewed, rolling out r241229.
3401
3402         Revision broke internal builds for watchOS.
3403
3404         Reverted changeset:
3405
3406         "[Cocoa] Ask platform for generic font family mappings"
3407         https://bugs.webkit.org/show_bug.cgi?id=187723
3408         https://trac.webkit.org/changeset/241229
3409
3410 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
3411
3412         [WinCairo][MiniBrowser] Basic authentication always fails.
3413         https://bugs.webkit.org/show_bug.cgi?id=194496
3414
3415         Reviewed by Don Olmstead.
3416
3417         * MiniBrowser/win/DialogHelper.h:
3418         (Dialog::getText):
3419
3420 2019-02-11  Philippe Normand  <pnormand@igalia.com>
3421
3422         [GStreamer] GstMappedBuffer testsuite build fails
3423         https://bugs.webkit.org/show_bug.cgi?id=194495
3424
3425         Reviewed by Carlos Garcia Campos.
3426
3427         Fix the build by explicitely adding the gstreamer1.0-audio include
3428         directories to the include path.
3429
3430         * TestWebKitAPI/PlatformGTK.cmake:
3431         * TestWebKitAPI/PlatformWPE.cmake:
3432
3433 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3434
3435         [GTK][WPE] Add enable-javascript-markup setting
3436         https://bugs.webkit.org/show_bug.cgi?id=193439
3437
3438         Reviewed by Michael Catanzaro.
3439
3440         Add test cases to check the new setting.
3441
3442         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3443         (testWebKitSettings):
3444         (testWebKitSettingsJavaScriptMarkup):
3445         (beforeAll):
3446
3447 2019-02-10  Darin Adler  <darin@apple.com>
3448
3449         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
3450         https://bugs.webkit.org/show_bug.cgi?id=194485
3451
3452         Reviewed by Daniel Bates.
3453
3454         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
3455
3456 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3457
3458         Add more tests for clampTo<>()
3459         https://bugs.webkit.org/show_bug.cgi?id=194462
3460
3461         Reviewed by Geoffrey Garen.
3462
3463         Darin suggested to test the very last floating point number
3464         at the boundaries when truncating to integer.
3465         I added test for max/min and max-1/min-1.
3466
3467         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3468         (TestWebKitAPI::TEST):
3469
3470 2019-02-09  Darin Adler  <darin@apple.com>
3471
3472         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
3473         https://bugs.webkit.org/show_bug.cgi?id=194021
3474
3475         Reviewed by Geoffrey Garen.
3476
3477         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3478         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
3479         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
3480
3481 2019-02-09  Zalan Bujtas  <zalan@apple.com>
3482
3483         [LFC][IFC] Add intrinsic width support for basic inline containers
3484         https://bugs.webkit.org/show_bug.cgi?id=194473
3485
3486         Reviewed by Antti Koivisto.
3487
3488         Expand tests coverage (11 new tests -> 798)
3489
3490         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
3491
3492 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3493
3494         Fix MiniBrowser's entitlements
3495         https://bugs.webkit.org/show_bug.cgi?id=192431
3496
3497         Reviewed by Joseph Pecoraro.
3498
3499         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
3500         files, making it impossible to load any extension.
3501
3502         * MiniBrowser/MiniBrowser.entitlements:
3503
3504 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
3505
3506         [Cocoa] Ask platform for generic font family mappings
3507         https://bugs.webkit.org/show_bug.cgi?id=187723
3508         <rdar://problem/41892438>
3509
3510         Reviewed by Brent Fulgham.
3511
3512         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3513
3514         * DumpRenderTree/mac/DumpRenderTree.mm:
3515         (allowedFontFamilySet):
3516         * WebKitTestRunner/mac/TestControllerMac.mm:
3517         (WTR::allowedFontFamilySet):
3518
3519 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
3520
3521         [GTK] Implement back/forward touchpad gesture
3522         https://bugs.webkit.org/show_bug.cgi?id=193919
3523
3524         Reviewed by Michael Catanzaro.
3525
3526         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3527         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
3528
3529 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3530
3531         Add SPI to use networking daemon instead of XPC service
3532         https://bugs.webkit.org/show_bug.cgi?id=194427
3533
3534         Reviewed by Geoffrey Garen
3535
3536         * MiniBrowser/MiniBrowser.entitlements:
3537
3538 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3539
3540         [ews-build] Ensure that every builder in config.json has short name
3541         https://bugs.webkit.org/show_bug.cgi?id=194461
3542
3543         Reviewed by Lucas Forschler.
3544
3545         * BuildSlaveSupport/ews-build/loadConfig.py:
3546         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3547
3548 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3549
3550         [ews-build] Add short name to config.json
3551         https://bugs.webkit.org/show_bug.cgi?id=194456
3552
3553         Reviewed by Lucas Forschler.
3554
3555         * BuildSlaveSupport/ews-build/config.json: Added short name.
3556         * BuildSlaveSupport/ews-build/loadConfig.py:
3557         (loadBuilderConfig): Set the short name as the builder description.
3558
3559 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3560
3561         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3562         https://bugs.webkit.org/show_bug.cgi?id=194418
3563
3564         Reviewed by Lucas Forschler.
3565
3566         Do not include errors trying when finding crashlogs at the end of
3567         a run-webkit-tests run since we don't process those errors.
3568
3569         * Scripts/webkitpy/port/darwin.py:
3570         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3571         * Scripts/webkitpy/port/ios_device.py:
3572         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3573         * Scripts/webkitpy/port/watch_device.py:
3574         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3575
3576 2019-02-08  Beth Dakin  <bdakin@apple.com>
3577
3578         Add afterScreenUpdates to WKSnapshotConfiguration
3579         https://bugs.webkit.org/show_bug.cgi?id=194362
3580         -and corresponding-
3581         <rdar://problem/40655528> Please add an "after screen updates" property to 
3582         WKSnapshotConfiguration (to solve blank snapshots)
3583
3584         Reviewed by Tim Horton.
3585
3586         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3587         (TEST):
3588
3589 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3590
3591         clampTo(): do not convert the input to double when dealing with integers
3592         https://bugs.webkit.org/show_bug.cgi?id=194263
3593         <rdar://problem/47692312>
3594
3595         Reviewed by Darin Adler.
3596
3597         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3598         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3599         (TestWebKitAPI::testClampFloatingPointToInteger):
3600         (TestWebKitAPI::testClampSameSignIntegers):
3601         (TestWebKitAPI::testClampUnsignedToSigned):
3602         (TestWebKitAPI::testClampSignedToUnsigned):
3603
3604 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3605
3606         webkitpy: Respect --dedicated-simulators flag
3607         https://bugs.webkit.org/show_bug.cgi?id=194416
3608         <rdar://problem/47894722>
3609
3610         Reviewed by Lucas Forschler.
3611
3612         * Scripts/webkitpy/port/device_port.py:
3613         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3614         available devices can be safely ignored.
3615
3616 2019-02-07  Keith Rollin  <krollin@apple.com>
3617
3618         Remove extra copy of 100x100-red.tga
3619         https://bugs.webkit.org/show_bug.cgi?id=194371
3620         <rdar://problem/47873465>
3621
3622         Reviewed by Said Abou-Hallawa.
3623
3624         In order to help it pass its tests, Bug 194190 added a second copy of
3625         the file 100x100-red.tga. However, it turns out that this additional
3626         file wasn't actually needed, and that that sole previous copy was
3627         sufficient. At the same time, this second copy -- which was copied to
3628         the same location in the build output as the first copy -- now caused
3629         XCBuild to complain because there were two production rules for the
3630         same output file. Address this by removing the newly-added extra copy.
3631
3632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3633         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3634
3635 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3636
3637         Deprecate WKBundlePageSetDefersLoading
3638         https://bugs.webkit.org/show_bug.cgi?id=191394
3639
3640         Reviewed by Dean Jackson.
3641
3642         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3643         (WTR::TestRunner::setDefersLoading):
3644
3645 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3646
3647         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3648         https://bugs.webkit.org/show_bug.cgi?id=194391
3649
3650         Reviewed by Antti Koivisto.
3651
3652         * LayoutReloaded/misc/LFC-passing-tests.txt:
3653
3654 2019-02-06  Keith Rollin  <krollin@apple.com>
3655
3656         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3657         https://bugs.webkit.org/show_bug.cgi?id=193975
3658         <rdar://problem/47643306>
3659
3660         Reviewed by Tim Horton.
3661
3662         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3663         the Info.plist file into the bundle. This step is not necessary as the
3664         implicit "bundle up all the build products into a framework" build
3665         phase does this already. Having the Copy Bundle Resources phase do
3666         this causes a conflict under XCBuild, which objects to two build
3667         phases producing the same file (Info.plist). Address this by removing
3668         Info.plist from the Copy Bundle Resources phase.
3669
3670         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3671
3672 2019-02-06  Keith Rollin  <krollin@apple.com>
3673
3674         Really enable the automatic checking and regenerations of .xcfilelists during builds
3675         https://bugs.webkit.org/show_bug.cgi?id=194357
3676         <rdar://problem/47861231>
3677
3678         Reviewed by Chris Dumez.
3679
3680         Bug 194124 was supposed to enable the automatic checking and
3681         regenerating of .xcfilelist files during the build. While related
3682         changes were included in that patch, the change to actually enable the
3683         operation somehow was omitted. This patch actually enables the
3684         operation. The check-xcfilelist.sh scripts now check
3685         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3686         from the checking.
3687
3688         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3689         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3690
3691 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3692
3693         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3694         <https://webkit.org/b/194286>
3695         <rdar://problem/47815558>
3696
3697         Reviewed by Alexey Proskuryakov.
3698