Remove commit-log-editor's dependency on Module::Load::Conditional
[WebKit-https.git] / Tools / ChangeLog
1 2011-07-08  Adam Roben  <aroben@apple.com>
2
3         Remove commit-log-editor's dependency on Module::Load::Conditional
4
5         This module isn't available in Perl 5.8.8 (the version used on Leopard).
6
7         Fixes <http://webkit.org/b/64198> REGRESSION (r90583):
8         webkitpy.common.checkout.checkout_unittest failing on Leopard
9
10         Reviewed by Daniel Bates.
11
12         * Scripts/commit-log-editor: Use the new loadTermReadKey() function instead of
13         Module::Load::Conditional::can_load.
14         (loadTermReadKey): Added. Tries to load Term::ReadKey and returns true if it's successful.
15
16 2011-07-08  Adam Roben  <aroben@apple.com>
17
18         Make checkout_unittest more robust against files moving around
19
20         Fixes <http://webkit.org/b/64197> checkout_unittest contains ugly, fragile code to find the
21         Scripts directory
22
23         Reviewed by Adam Barth.
24
25         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
26         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Instantiate a real SCM
27         object and use it to get the path to the Scripts directory, rather than hard-coding the
28         relative path from this file to Scripts.
29
30 2011-07-08  Adam Roben  <aroben@apple.com>
31
32         Make TestFailures remember that run-webkit-tests timed out, even across reloads
33
34         Fixes <http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
35         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload
36
37         Reviewed by Daniel Bates.
38
39         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
40         (LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
41         When true, it indicates that there was an error retrieving the results for this build and
42         that the errorCallback should be called.
43
44 2011-07-08  Adam Barth  <abarth@webkit.org>
45
46         Teach garden-o-matic how to display test results
47         https://bugs.webkit.org/show_bug.cgi?id=64141
48
49         Reviewed by Ojan Vafai.
50
51         This patch includes basic infrastructure for probing build.chromium.org
52         for test results.  We only handle text and image tests, not anything
53         complicated like reftests.  Also, we're using the revision/build
54         independent results store on the server, so we're avoiding that
55         complication for now.
56
57         It's slightly hacky that we need to probe the server to see what kinds
58         of results exist.  A better solution would be to add CORS support to
59         the server or to use the local server to help.
60
61         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
62         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
63         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
64         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
65         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
66         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
67
68 2011-07-08  Dirk Pranke  <dpranke@chromium.org>
69
70         REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
71         https://bugs.webkit.org/show_bug.cgi?id=64092
72
73         Reviewed by Tony Chang.
74
75         The code was incorrectly creating empty shards in the
76         shard_in_two case.
77
78         * Scripts/webkitpy/layout_tests/controllers/manager.py:
79         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
80
81 2011-07-08  Adam Roben  <aroben@apple.com>
82
83         Teach buildbot to figure out how many webkitpy/webkitperl tests failed
84
85         Fixes <http://webkit.org/b/64192> It's hard to tell how many test-webkitpy/test-webkitperl
86         tests failed when looking at build.webkit.org
87
88         Reviewed by Eric Seidel.
89
90         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
91         (TestWithFailureCount): New class that represents a test build step which has an associated
92         failure count. Eventually we should move more of our test classes to deriving from this.
93         (TestWithFailureCount.countFailures): Method for subclasses to override to say how many
94         failures occurred.
95
96         (TestWithFailureCount.commandComplete):
97         (TestWithFailureCount.evaluateCommand):
98         (TestWithFailureCount.getText):
99         (TestWithFailureCount.getText2):
100         These were all based on RunGtkAPITests.
101
102         (RunPythonTests): Changed to inherit from TestWithFailureCount.
103         (RunPythonTests.countFailures): Parses the test-webkitpy output looking for the count of
104         failures.
105         (RunPerlTests): Changed to inherit from TestWithFailureCount.
106         (RunPerlTests.countFailures): Parses the test-webkitperl output looking for the count of
107         failures.
108
109 2011-07-08  Adam Roben  <aroben@apple.com>
110
111         Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration
112
113         Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
114         bots due to commit-log-editor errors
115
116         Reviewed by Adam Barth.
117
118         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
119         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
120         $CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
121         commit-log-editor can find a value for the committer's email, and that the committer and
122         author email addresses match, which will prevent commit-log-editor from inserting a "Patch
123         by" line in the commit message.
124
125 2011-07-08  Andreas Kling  <kling@webkit.org>
126
127         [Qt][WK2] Views should expose QActions for basic navigation.
128         https://bugs.webkit.org/show_bug.cgi?id=64174
129
130         Reviewed by Benjamin Poulain.
131
132         Bring the toolbar in Qt's MiniBrowser back to life.
133
134         * MiniBrowser/qt/BrowserView.cpp:
135         (BrowserView::navigationAction):
136         * MiniBrowser/qt/BrowserView.h:
137         * MiniBrowser/qt/BrowserWindow.cpp:
138         (BrowserWindow::BrowserWindow):
139
140 2011-07-08  Adam Roben  <aroben@apple.com>
141
142         Teach TestFailures how to find test names in commit-log-editor-style commit messages
143
144         TestFailures was relying on Trac turning the list of modified files in our commit messages
145         into an HTML list. But Trac only does this when the list of modified files is indented.
146         commit-log-editor doesn't indent the file list, so the list wasn't being turned into an HTML
147         list, which was confusing TestFailures.
148
149         TestFailures now does much simpler parsing of the commit message (i.e., just a substring
150         search) without relying at all on its structure.
151
152         Fixes <http://webkit.org/b/64173> TestFailures page fails to blame r90608 for breaking
153         fast/dom/HTMLProgressElement/progress-element-markup.html on Windows
154
155         Reviewed by David Kilzer.
156
157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
158         (Trac.prototype.getCommitDataForRevisionRange): Instead of trying to parse the commit
159         message, just return its text.
160
161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
162         (ViewController.prototype._domForRegressionRange): Instead of searching for test names in
163         each commit's list of modified files, just search for test names anywhere in the commit's
164         message.
165
166 2011-07-08  Adam Barth  <abarth@webkit.org>
167
168         sheriffbot is too spammy in IRC
169         https://bugs.webkit.org/show_bug.cgi?id=64153
170
171         Reviewed by Eric Seidel.
172
173         Reporting failures in IRC worked well when the tree was greener than it
174         is today.  Nowadays, this feature mostly just results in spam about
175         false positives.  If we reach a greener state, we can bring this code
176         back.
177
178         (Another possibility is to restrict this feature to builder bots,
179         rather than including testers, as we did before this patch.)
180
181         * Scripts/webkitpy/tool/commands/sheriffbot.py:
182         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
183
184 2011-07-08  Adam Roben  <aroben@apple.com>
185
186         Ensure commit-log-editor adds a "Patch by" line when the author and committer are different
187
188         Previously we were only adding a "Patch by" line when the ChangeLog contained a "Reviewed
189         by" line. But some patches (like rollout patches) don't contain that line. Now we always add
190         "Patch by" to the commit log regardless of the ChangeLog's contents.
191
192         Fixes <http://webkit.org/b/64127> Committer for r90588 is commit-queue@webkit.org, but
193         should have been abarth@webkit.org
194
195         Reviewed by Anders Carlsson.
196
197         * Scripts/commit-log-editor:
198         (createCommitMessage): Try to put the "Patch by" line just above the "Reviewed by" line, as
199         before. If there is no "Reviewed by" line, try to put it just above the first modified file.
200         If all else fails, put it at the end of the commit message.
201         (patchAuthorshipString): Added. Code came from createCommitMessage.
202
203 2011-07-08  Herczeg Zoltan  <zherczeg@webkit.org>
204
205         Reviewed by Andreas Kling.
206
207         Adding myself as a reviewer.
208
209         * Scripts/webkitpy/common/config/committers.py:
210
211 2011-07-07  Kevin Ollivier  <kevino@theolliviers.com>
212
213         [wx] Unreviewed build fix, remove old files from the tree and update paths to new ones.
214
215         * wx/build: Removed.
216         * wx/build/build_utils.py: Removed.
217         * wx/build/settings.py: Removed.
218         * wx/build/waf_extensions.py: Removed.
219         * wx/build/wxpresets.py: Removed.
220         * wx/packaging/build-mac-installer.py:
221
222 2011-07-07  Kevin Ollivier  <kevino@theolliviers.com>
223
224         [wx] Unreviewed build fix, more fixes for install name issues.
225
226         * wx/packaging/build-mac-installer.py:
227
228 2011-07-07  Dirk Pranke  <dpranke@chromium.org>
229
230         test-webkitpy fails on chromium win
231         https://bugs.webkit.org/show_bug.cgi?id=64137
232
233         Reviewed by Eric Seidel.
234
235         test-webkitpy doesn't play nicely with the multiprocessing
236         module on win32. An earlier change actually reenabled the tests
237         on win32 by mistake.
238
239         This patch also fixes a few cases where path names will trip
240         things up on win32 (e.g., by testing unix paths on windows).
241         We do not lose any real coverage here with those fixes.
242
243         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
244         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
245         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
246         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
247
248 2011-07-07  Leandro Pereira  <leandro@profusion.mobi>
249
250         [ImageDiff] Calculate/print difference right after reading baseline image.
251         https://bugs.webkit.org/show_bug.cgi?id=64117
252
253         Reviewed by Kent Tamura.
254
255         Otherwise, ImageDiff will block on fgets() until the universe ends or you ^C
256         it.  Whichever happens first.
257
258         * DumpRenderTree/efl/ImageDiff.cpp:
259         (main):
260
261 2011-07-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
262
263         [EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
264         https://bugs.webkit.org/show_bug.cgi?id=64107
265
266         Reviewed by Kent Tamura.
267
268         The pointer is later managed by BitmapContext, but it was being
269         de-refed and deleted earlier by our RefPtr, causing crashes in all
270         pixel tests.
271
272         We now call leakRef() to make sure it is not removed when our
273         createBitmapContextFromWebView goes out of context.
274
275         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
276         (createBitmapContextFromWebView):
277
278 2011-07-07  Adam Roben  <aroben@apple.com>
279
280         Update TestFailures's title and header immediately upon navigation
281
282         Fixes <http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks
283
284         Reviewed by Daniel Bates.
285
286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
287         (ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
288         title.
289         (ViewController.prototype._displayBuilder): Set the page's title and clear out any old
290         content immediately instead of waiting for the first set of results for the history
291         analyzer. As we receive new results from the analyzer we'll just clear out the main content
292         area and replace it with the new info.
293         (ViewController.prototype._displayTesters): Set the page's title and clear out any old
294         content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
295         in a little use of our removeAllChildren helper, too.
296         (ViewController.prototype._setTitle): Added. Set's the page's title and the header text.
297
298 2011-07-07  Adam Roben  <aroben@apple.com>
299
300         Make Checkout use SCM's Executive instead of conjuring up its own
301
302         This will improve integration with the rest of webkitpy, particularly when invoked via
303         webkit-patch.
304
305         Fixes <http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
306         Executive inappropriately
307
308         Reviewed by Adam Barth.
309
310         * Scripts/webkitpy/common/checkout/checkout.py:
311         (Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
312         our own use. SCM might have some super-special Executive that it uses under the covers, and
313         we want to use it, too!
314
315         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
316         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
317         method to call through to Executive.run_command.
318
319 2011-07-07  Adam Roben  <aroben@apple.com>
320
321         Make Term/ReadKey.pm an optional dependency of commit-log-editor
322
323         When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.
324
325         Fixes <http://webkit.org/b/64113> REGRESSION (r90564):
326         webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
327         Term/ReadKey.pm module
328
329         Reviewed by Xan Lopez.
330
331         * Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load
332         Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
333         that existing commit messages will be preserved. (Users can manually remove existing commit
334         messages using git-reset.)
335
336 2011-07-07  Adam Roben  <aroben@apple.com>
337
338         Keep testing that commit messages containing Unicode are handled properly by webkitpy
339
340         Fixes <http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
341         correctly handle Unicode in commit messages
342
343         Reviewed by Eric Seidel.
344
345         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in
346         places in the ChangeLog that will end up being included in the commit message.
347
348 2011-07-07  Andreas Kling  <kling@webkit.org>
349
350         [Qt][WK2] Remove Symbian code.
351         https://bugs.webkit.org/show_bug.cgi?id=64101
352
353         Reviewed by Benjamin Poulain.
354
355         * MiniBrowser/qt/BrowserWindow.cpp:
356         (BrowserWindow::BrowserWindow):
357         (BrowserWindow::screenshot):
358         * MiniBrowser/qt/MiniBrowser.pro:
359         * MiniBrowser/qt/MiniBrowserApplication.h:
360         (WindowOptions::WindowOptions):
361
362 2011-07-07  Andreas Kling  <kling@webkit.org>
363
364         [Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
365         https://bugs.webkit.org/show_bug.cgi?id=64099
366
367         Reviewed by Benjamin Poulain.
368
369         * MiniBrowser/qt/BrowserWindow.cpp:
370         (BrowserWindow::openFile):
371         (BrowserWindow::screenshot):
372         (BrowserWindow::loadURLListFromFile):
373
374 2011-07-07  Adam Roben  <aroben@apple.com>
375
376         Completely ignore too-many-failures builds in TestFailures in most circumstances
377
378         Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
379         really use them to perform regression analysis. The only time we want to pay attention to
380         too-many-failures builds is when we're trying to explain when the current bout of
381         too-many-failures started.
382
383         Fixes <http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
384         in a build that didn't even run it (because it exited early due to too many failues)
385
386         Reviewed by David Kilzer.
387
388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
389         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
390         too-many-failures handling that would cause us to blame builds that didn't even run a given
391         test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
392         build was itself a too-many-failures build.
393
394 2011-07-07  Adam Roben  <aroben@apple.com>
395
396         Teach webkitpy's Checkout class to use commit-log-editor to create commit messages
397
398         Fixes <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
399         commit-log-editor's
400
401         Reviewed by David Kilzer.
402
403         * Scripts/webkitpy/common/checkout/checkout.py:
404         (Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
405         the modified ChangeLogs, to generate the commit message, rather than trying to generate one
406         ourselves.
407
408         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message
409         to match commit-log-editor's format.
410         (CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
411         directories so we can see how the various entries get labeled in the commit message.
412         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
413         instance that knows how to find commit-log-editor and pass it to our Checkout instance.
414         Don't bother capturing output, since there shouldn't be any.
415
416 2011-07-07  Adam Roben  <aroben@apple.com>
417
418         Add a --print-log option to commit-log-editor
419
420         When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
421         generates a commit message from those ChangeLogs, prints it to stdout, and exits.
422
423         Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
424         readable than commit-log-editor's
425
426         Reviewed by David Kilzer.
427
428         * Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log
429         option, which calls through to createCommitMessage, prints the result, and exits.
430         (printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
431         explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.
432
433 2011-07-07  Adam Roben  <aroben@apple.com>
434
435         Extract commit-log-editor's commit-message-generation code into a separate function
436
437         As a bonus, we now skip a bunch of work in the case where we are generating a commit message
438         for staged git changes.
439
440         Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
441         readable than commit-log-editor's
442
443         Reviewed by David Kilzer.
444
445         * Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the
446         file so that it will be defined even if we aren't operating on an existing log message.
447         Moved a bunch of top-level code to generate the commit message from here...
448         (createCommitMessage): ...to here.
449
450 2011-07-07  Carlos Garcia Campos  <cgarcia@igalia.com>
451
452         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
453         https://bugs.webkit.org/show_bug.cgi?id=63988
454
455         Reviewed by Martin Robinson.
456
457         * MiniBrowser/gtk/BrowserWindow.c:
458         (browserWindowConstructed):
459         (decidePolicyForNavigationAction): Ignore the action if a link is
460         clicked with the middle buttonm and open the link in a new window.
461         (browserWindowPolicyClientInit):
462
463 2011-07-07  Adam Barth  <abarth@webkit.org>
464
465         Remove style_references.py
466         https://bugs.webkit.org/show_bug.cgi?id=64070
467
468         Reviewed by Eric Seidel.
469
470         We never really adopted the _references design, and this file is a bit
471         of an orphan at this point.
472
473         * Scripts/check-webkit-style:
474         * Scripts/webkitpy/style/checker.py:
475         * Scripts/webkitpy/style/checker_unittest.py:
476         * Scripts/webkitpy/style/checkers/python.py:
477         * Scripts/webkitpy/style/checkers/test_expectations.py:
478         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
479         * Scripts/webkitpy/style/main_unittest.py:
480         * Scripts/webkitpy/style_references.py: Removed.
481
482 2011-07-07  Eric Seidel  <eric@webkit.org>
483
484         Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
485         https://bugs.webkit.org/show_bug.cgi?id=64056
486
487         Unreviewed.
488
489         I had written this unittest prior to landing my change, but
490         had named it qt_unitest.py, so it wasn't running (nor was
491         it added to my git repo).
492
493         Once I fixe the name of the unittest file, it was very easy
494         to fix the error in webkit.py (which already had a FIXME).
495
496         * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
497         * Scripts/webkitpy/layout_tests/port/webkit.py:
498
499 2011-07-07  Eric Seidel  <eric@webkit.org>
500
501         Unreviewed.  Add more debug logging about which test expectations we're using.
502
503         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
504         * Scripts/webkitpy/layout_tests/port/webkit.py:
505
506 2011-07-06  Adam Barth  <abarth@webkit.org>
507
508         Remove unexpected_results.json
509         https://bugs.webkit.org/show_bug.cgi?id=64065
510
511         Reviewed by Eric Seidel.
512
513         No one should be using this file any more.  This patch removes it from
514         the face of the earth.  This patch also removes two NRWT-specific
515         command line options that were implemented using
516         unexpected_results.json.
517
518         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
519         * Scripts/webkitpy/layout_tests/controllers/manager.py:
520         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
521         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
522         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
523         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
524         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
525
526 2011-07-07  Adam Barth  <abarth@webkit.org>
527
528         REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
529         https://bugs.webkit.org/show_bug.cgi?id=64067
530
531         Reviewed by Eric Seidel.
532
533         The author of r90520 forgot to change the chromium_gpu.py implemenation
534         of this method as well.
535
536         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
537
538 2011-07-06  Eric Seidel  <eric@webkit.org>
539
540         Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
541         https://bugs.webkit.org/show_bug.cgi?id=64056
542
543         Reviewed by Adam Barth.
544
545         This fixes the MacPort's version of baseline_search_path to include
546         wk2 fallback like WebKitPort's does.  This also re-works the QtPort
547         to set self._name (as other ports do) so that WebKitPort's default
548         implementations will understand Qt operating system flavors correctly
549         (including when running wk2 tests).
550
551         In trying to test this, I realized that nearly all of our port-tests
552         use the default FileSystem(), User() and Executive() objects, which
553         is really bad, because they expose details of your system in the unittest results!
554
555         Once I fixed many of the Port() calls to pass MockFileSystem(), then
556         MacPort.test_tests_for_other_platforms started failing, and I had to
557         teach MockFileSystem.glob how to handle directories to make it work again.
558
559         I removed the useless PortTestCase.test_baseline_search_path and replaced
560         it with more useful test_baseline_search_path tests in MacPortTest and QtPortTest.
561
562         * Scripts/webkitpy/common/config/ports.py:
563         * Scripts/webkitpy/common/system/filesystem_mock.py:
564         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
565         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
566         * Scripts/webkitpy/layout_tests/port/mac.py:
567         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
568         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
569         * Scripts/webkitpy/layout_tests/port/qt.py:
570         * Scripts/webkitpy/layout_tests/port/test_files.py:
571         * Scripts/webkitpy/layout_tests/port/win.py:
572         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py:
573         * Scripts/webkitpy/tool/mocktool.py:
574
575 2011-07-06  Adam Barth  <abarth@webkit.org>
576
577         Wean rebaseline-server off unexpected_results.json
578         https://bugs.webkit.org/show_bug.cgi?id=64063
579
580         Reviewed by Eric Seidel.
581
582         In the process of changing this code to use full_results.json, I
583         noticed that the code was broken (because it wasn't tested).  This
584         patch also adds test coverage for the broken code.
585
586         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
587         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
588         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
589
590 2011-07-06  Adam Barth  <abarth@webkit.org>
591
592         Wean resultsjsonparser off unexpected_results.json
593         https://bugs.webkit.org/show_bug.cgi?id=64061
594
595         Reviewed by Eric Seidel.
596
597         We're about to delete unexpected_results.json, so we need to remove all
598         the users.
599
600         * Scripts/webkitpy/common/config/ports.py:
601         * Scripts/webkitpy/common/net/resultsjsonparser.py:
602         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
603         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
604
605 2011-07-06  Adam Barth  <abarth@webkit.org>
606
607         Cleanup result_summary.py
608         https://bugs.webkit.org/show_bug.cgi?id=64057
609
610         Reviewed by Eric Seidel.
611
612         This class had a bunch of out-of-date docstrings that no longer make
613         any sense.
614
615         * Scripts/webkitpy/layout_tests/models/result_summary.py:
616
617 2011-07-06  Adam Barth  <abarth@webkit.org>
618
619         Tweak the ChangeLog for DEPS rolls to say "Unreviewed" so that the
620         patches can be landed by the commit-queue.
621
622         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
623
624 2011-07-06  Adam Barth  <abarth@webkit.org>
625
626         Normalize callers of logging.getLogger to use __name__
627         https://bugs.webkit.org/show_bug.cgi?id=64054
628
629         Reviewed by Eric Seidel.
630
631         Most callers were already using __name__.  This patch makes everyone
632         consistent.
633
634         * Scripts/webkitpy/common/checkout/diff_parser.py:
635         * Scripts/webkitpy/common/checkout/scm/svn.py:
636         * Scripts/webkitpy/common/net/statusserver.py:
637         * Scripts/webkitpy/common/system/executive.py:
638         * Scripts/webkitpy/common/system/file_lock.py:
639         * Scripts/webkitpy/common/system/user.py:
640         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
641         * Scripts/webkitpy/layout_tests/models/result_summary.py:
642         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
643         * Scripts/webkitpy/layout_tests/port/chromium.py:
644         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
645         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
646         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
647         * Scripts/webkitpy/layout_tests/port/gtk.py:
648         * Scripts/webkitpy/layout_tests/port/http_lock.py:
649         * Scripts/webkitpy/layout_tests/port/mac.py:
650         * Scripts/webkitpy/layout_tests/port/qt.py:
651         * Scripts/webkitpy/layout_tests/port/server_process.py:
652         * Scripts/webkitpy/layout_tests/port/webkit.py:
653         * Scripts/webkitpy/layout_tests/port/win.py:
654         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
655         * Scripts/webkitpy/layout_tests/servers/http_server.py:
656         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
657         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
658         * Scripts/webkitpy/layout_tests/views/printing.py:
659         * Scripts/webkitpy/python24/versioning.py:
660         * Scripts/webkitpy/style/checker.py:
661         * Scripts/webkitpy/style/checkers/test_expectations.py:
662         * Scripts/webkitpy/style/patchreader.py:
663         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
664
665 2011-07-06  Adam Barth  <abarth@webkit.org>
666
667         Move model classes out of layout_package and into models
668         https://bugs.webkit.org/show_bug.cgi?id=64053
669
670         Reviewed by Eric Seidel.
671
672         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
673         * Scripts/webkitpy/common/net/layouttestresults.py:
674         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
675         * Scripts/webkitpy/common/net/resultsjsonparser.py:
676         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
677         * Scripts/webkitpy/layout_tests/controllers/manager.py:
678         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
679         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
680         * Scripts/webkitpy/layout_tests/controllers/worker.py:
681         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
682         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
683         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
684         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: Removed.
685         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Removed.
686         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Removed.
687         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Removed.
688         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Removed.
689         * Scripts/webkitpy/layout_tests/layout_package/test_input.py: Removed.
690         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
691         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Removed.
692         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: Removed.
693         * Scripts/webkitpy/layout_tests/models: Added.
694         * Scripts/webkitpy/layout_tests/models/__init__.py: Added.
695         * Scripts/webkitpy/layout_tests/models/result_summary.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/result_summary.py.
696         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py.
697         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py.
698         * Scripts/webkitpy/layout_tests/models/test_failures.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py.
699         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py.
700         * Scripts/webkitpy/layout_tests/models/test_input.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_input.py.
701         * Scripts/webkitpy/layout_tests/models/test_results.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results.py.
702         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py.
703         * Scripts/webkitpy/layout_tests/port/chromium.py:
704         * Scripts/webkitpy/layout_tests/views/printing.py:
705         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
706         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
707         * Scripts/webkitpy/style_references.py:
708         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
709         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
710         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
711         * Scripts/webkitpy/tool/commands/queues_unittest.py:
712         * Scripts/webkitpy/tool/commands/rebaseline.py:
713
714 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
715
716         nrwt: fix typo preventing http startup on windows
717         https://bugs.webkit.org/show_bug.cgi?id=64050
718
719         Reviewed by Eric Siedel.
720
721         NRWT checks whether it needs to start the servers by looking
722         for "/http/" in the test names. After r90520, the leading slash
723         is not present, so the check isn't quite right.
724
725         * Scripts/webkitpy/layout_tests/controllers/manager.py:
726         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
727
728 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
729
730         nrwt: remove --use-apache from the command line
731         https://bugs.webkit.org/show_bug.cgi?id=63358
732
733         Reviewed by Adam Barth.
734
735         Re-land the fix in bug 63358 - the prior fix was flawed in that
736         we were trying to start the http server during check_sys_deps()
737         but not actually setting up the environment properly. This
738         broken prior to this change, but exposed by it, since the patch
739         changes the chromium port to call the base class's checks.
740
741         * Scripts/webkitpy/common/system/executive.py:
742         * Scripts/webkitpy/layout_tests/port/base.py:
743         * Scripts/webkitpy/layout_tests/port/chromium.py:
744         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
745         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
746         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
747         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
748         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
749         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
750
751 2011-07-06  Adam Barth  <abarth@webkit.org>
752
753         Move view-related code out of layout_package and into views
754         https://bugs.webkit.org/show_bug.cgi?id=64051
755
756         Reviewed by Eric Seidel.
757
758         * Scripts/webkitpy/layout_tests/controllers/manager.py:
759         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
760         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
761         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
762         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Removed.
763         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Removed.
764         * Scripts/webkitpy/layout_tests/layout_package/printing.py: Removed.
765         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Removed.
766         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
767         * Scripts/webkitpy/layout_tests/views: Added.
768         * Scripts/webkitpy/layout_tests/views/__init__.py: Added.
769         * Scripts/webkitpy/layout_tests/views/metered_stream.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py.
770         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py.
771         * Scripts/webkitpy/layout_tests/views/printing.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py.
772         * Scripts/webkitpy/layout_tests/views/printing_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py.
773
774 2011-07-06  Adam Barth  <abarth@webkit.org>
775
776         Add goofy comments to explain why we have these files.
777
778         * Scripts/webkitpy/layout_tests/controllers/__init__.py:
779         * Scripts/webkitpy/layout_tests/layout_package/__init__.py:
780
781 2011-07-06  Adam Barth  <abarth@webkit.org>
782
783         Move a bunch of classes out of layout_tests.layout_package and into layout_tests.controllers
784         https://bugs.webkit.org/show_bug.cgi?id=64048
785
786         Reviewed by Eric Seidel.
787
788         * Scripts/webkitpy/layout_tests/controllers: Added.
789         * Scripts/webkitpy/layout_tests/controllers/__init__.py: Added.
790         * Scripts/webkitpy/layout_tests/controllers/manager.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py.
791         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py.
792         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py.
793         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py.
794         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py.
795         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py.
796         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py.
797         * Scripts/webkitpy/layout_tests/controllers/worker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py.
798         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Removed.
799         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Removed.
800         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Removed.
801         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Removed.
802         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
803         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
804         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
805         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Removed.
806         * Scripts/webkitpy/layout_tests/layout_package/worker.py: Removed.
807         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
808
809 2011-07-06  Adam Barth  <abarth@webkit.org>
810
811         Attempt to fix unittest on Leopard.  Let's enumerate the keys in sorted
812         order so the test results are predictable.
813
814         * Scripts/webkitpy/tool/bot/irc_command.py:
815         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
816
817 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
818
819         Reviewed by Eric Siedel.
820
821         nrwt: make the code be consistent about using test names instead of filenames or paths
822
823         https://bugs.webkit.org/show_bug.cgi?id=63597
824
825         It can be hard to figure out where in the code we're assuming
826         test names are listed as unix-style relative filenames and where
827         they are either absolute paths or relative paths following the
828         host filesystem convention.
829
830         This patch changes things so that everything outside of the
831         Port object uses (and must assume) unix-style relative
832         filenames (with one exception, which is specifying host-local
833         filenames as a list of test arguments on the command line).
834
835         This should make things clearer and more consistent, and also
836         removes a lot of path conversion calls.
837
838         The changes in this patch outside of port/base.py are largely
839         cosmetic changes of "filename" to "test". We add a few routines
840         to the base Port implementation to manipulate test names to
841         split them, figure out if we're referring to a directory of
842         tests, etc.
843
844         * Scripts/webkitpy/common/net/layouttestresults.py:
845         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
846         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
847         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
848         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
849         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
850         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
851         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
852         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
853         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
854         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
855         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
856         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
857         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
858         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
859         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
860         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
861         * Scripts/webkitpy/layout_tests/port/base.py:
862         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
863         * Scripts/webkitpy/layout_tests/port/chromium.py:
864         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
865         * Scripts/webkitpy/layout_tests/port/dryrun.py:
866         * Scripts/webkitpy/layout_tests/port/test.py:
867         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
868         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
869         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
870         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
871         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
872         * Scripts/webkitpy/tool/commands/rebaseline.py:
873         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
874
875 2011-07-06  Chris Guillory  <ctguil@chromium.org>
876
877         No review necessary.
878
879         Adding myself to committers list in committers.py.
880         https://bugs.webkit.org/show_bug.cgi?id=63478
881
882         * Scripts/webkitpy/common/config/committers.py:
883
884 2011-07-06  Johnny Ding  <jnd@chromium.org>
885
886         https://bugs.webkit.org/show_bug.cgi?id=63857
887         Implement createPopupMenu for Chromium DRT.
888
889         Reviewed by Tony Chang.
890
891         * DumpRenderTree/chromium/WebViewHost.cpp:
892         (WebViewHost::createPopupMenu):
893         (WebViewHost::~WebViewHost):
894         * DumpRenderTree/chromium/WebViewHost.h:
895
896 2011-07-06  Mihai Parparita  <mihaip@chromium.org>
897
898         Unreviewed, rolling out r90503.
899         http://trac.webkit.org/changeset/90503
900         https://bugs.webkit.org/show_bug.cgi?id=63358
901
902         Makes Chromium Windows canary bots hang.
903
904         * Scripts/webkitpy/layout_tests/port/base.py:
905         * Scripts/webkitpy/layout_tests/port/chromium.py:
906         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
907         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
908         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
909         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
910         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
911         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
912
913 2011-07-06  Adam Barth  <abarth@webkit.org>
914
915         Move buildbot URL in webkitpy to config.urls
916         https://bugs.webkit.org/show_bug.cgi?id=64041
917
918         Reviewed by Eric Seidel.
919
920         This patch prepares for using the buildbot class to talk to the
921         Chromium buildbots.
922
923         * Scripts/webkitpy/common/config/urls.py:
924         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
925         * Scripts/webkitpy/tool/commands/download_unittest.py:
926         * Scripts/webkitpy/tool/commands/queries.py:
927         * Scripts/webkitpy/tool/mocktool.py:
928         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
929
930 2011-07-06  Kevin Ollivier  <kevino@theolliviers.com>
931
932         [wx] Unreviewed build fix, add the correct path to the waf build settings.
933         
934         * wx/packaging/build-win-installer.py:
935
936 2011-07-06  Adam Barth  <abarth@webkit.org>
937
938         Add missing include.
939
940         * Scripts/webkitpy/tool/bot/irc_command.py:
941
942 2011-07-06  Adam Barth  <abarth@webkit.org>
943
944         Add roll-chromium-deps command to sheriff-bot
945         https://bugs.webkit.org/show_bug.cgi?id=64037
946
947         Reviewed by Eric Seidel.
948
949         Lo, and the DEPS were rolled on command.
950
951         * Scripts/webkitpy/tool/bot/irc_command.py:
952         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
953         * Scripts/webkitpy/tool/bot/sheriff.py:
954         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
955         * Scripts/webkitpy/tool/commands/roll.py:
956         * Scripts/webkitpy/tool/commands/roll_unittest.py:
957         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
958
959 2011-07-06  Eric Seidel  <eric@webkit.org>
960
961         Split Driver, DriverOutput and DriverInput out into a new driver.py file
962         https://bugs.webkit.org/show_bug.cgi?id=64031
963
964         Reviewed by Adam Barth.
965
966         This ended up kinda large and I'm happy to break it up if desired.
967
968         As part of cleaning up the Port module, I split Driver, DriverInput and DriverOutput
969         out into its own driver.py file.
970
971         I also cleaned up how we import Port objects, by making port/__init__.py
972         expose Port, Driver, DriverInput, and DriverOutput.  I removed exposure of
973         some various test objects as they were causing circular dependencies.
974         base.py is now an implementation detail of port.  No longer is "base" referenced
975         anywhere in the code.
976
977         I also made Driver.__init__ non-virtual so that sub-classers could all share
978         the data storage on Driver.  This more closely matches how other subclasses
979         work throughout our python code.
980
981         Standard line-unwrapping and doc-string removal as I went through the code.
982
983         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
984         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
985         * Scripts/webkitpy/layout_tests/port/__init__.py:
986         * Scripts/webkitpy/layout_tests/port/base.py:
987         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
988         * Scripts/webkitpy/layout_tests/port/chromium.py:
989         * Scripts/webkitpy/layout_tests/port/driver.py: Added.
990         * Scripts/webkitpy/layout_tests/port/dryrun.py:
991         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
992         * Scripts/webkitpy/layout_tests/port/test.py:
993         * Scripts/webkitpy/layout_tests/port/webkit.py:
994         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
995         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
996         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
997
998 2011-07-06  Adam Roben  <aroben@apple.com>
999
1000         Clear TestFailures's getNumberOfFailingTests cache
1001
1002         Now that we support NRWT, we need to clear out old zero values for the NRWT bots that might
1003         have been cached by old versions of TestFailures.
1004
1005         Fixes <http://webkit.org/b/64029> TestFailures page still doesn't show NRWT bots if you've
1006         used it recently
1007
1008         Reviewed by Adam Barth.
1009
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1011         (Builder.prototype.getNumberOfFailingTests): Added a .version property to the cache data
1012         that must match the current version. Otherwise we'll ignore the cached data.
1013
1014 2011-06-24  Dirk Pranke  <dpranke@chromium.org>
1015
1016         Reviewed by Adam Barth.
1017
1018         nrwt: remove --use-apache from the command line
1019         https://bugs.webkit.org/show_bug.cgi?id=63358
1020
1021         This change removes the --use-apache command line argument. It
1022         was initially put in when we were trying to get the cygwin
1023         apache instance to work with Chromium win, but that code has
1024         bitrotted and doesn't work at all now.
1025
1026         Arguably we should remove all of the code to allow for a choice
1027         of web servers, but since we may still want to switch off of
1028         LigHTTPd at some point on Windows, I'll leave the rest in for
1029         now (or at least yank it in a different change.)
1030
1031         * Scripts/webkitpy/layout_tests/port/base.py:
1032         * Scripts/webkitpy/layout_tests/port/chromium.py:
1033         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1034         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1035         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1036         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1037
1038 2011-07-06  Dimitri Glazkov  <dglazkov@chromium.org>
1039
1040         garden-o-matic should use a favicon to indicate current state.
1041         https://bugs.webkit.org/show_bug.cgi?id=64027
1042
1043         Reviewed by Adam Barth.
1044
1045         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
1046         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
1047         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
1048         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
1049         * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
1050
1051 2011-07-06  Daniel Bates  <dbates@rim.com>
1052
1053         Fix webkitpy error after changeset 90483 <http://trac.webkit.org/changeset/90483>; Add missing
1054         parameter to _fetch_file_from_results lamdba function.
1055
1056         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1057
1058 2011-07-06  Kevin Ollivier  <kevino@theolliviers.com>
1059
1060         [wx] Unreviewed build fix. Generate the proper install_name for dylibs on Mac.
1061
1062         * wx/packaging/build-mac-installer.py:
1063
1064 2011-07-06  Xan Lopez  <xlopez@igalia.com>
1065
1066         [GTK] Only set env. variables in start when strictly needed
1067         https://bugs.webkit.org/show_bug.cgi?id=64026
1068
1069         Reviewed by Eric Seidel.
1070
1071         * Scripts/webkitpy/layout_tests/port/gtk.py: add a
1072         setup_environ_for_server method in GtkPort and set as many
1073         env. variables as possible there.
1074
1075 2011-07-06  Adam Roben  <aroben@apple.com>
1076
1077         Teach TestFailures how to load, parse, and interpret NRWT test results
1078
1079         Fixes <http://webkit.org/b/61877> TestFailures page doesn't show testers that use
1080         new-run-webkit-tests
1081
1082         Reviewed by Adam Barth.
1083
1084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1085         (Builder.prototype.failureDiagnosisTextAndURL): Added support for the new 'flaky' failure
1086         type. For now we don't account for image-only flakes (but TestFailures doesn't deal with
1087         pixel tests at all currently).
1088         (Builder.prototype.getNumberOfFailingTests): Relaxed the regex used for parsing the number
1089         of failing tests from the buildbot output. Make sure not to count "new passes" (a new
1090         category introduced by NRWT) as failures.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1093         (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here to
1094         _fetchAndParseORWTResults. This function now attempts to load NRWT results, then falls back
1095         to loading ORWT results.
1096         (LayoutTestResultsLoader.prototype._fetchAndParseNRWTResults): Added. Tries to load and
1097         parse the full_results.json file for the given build.
1098         (LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added. Code came from start.
1099         Fixed a bug along the way where we were sometimes calling the error callback instead of the
1100         success callback when all tests passed.
1101
1102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Added.
1103         (NRWTResultsParser): Do-nothing constructor.
1104         (NRWTResultsParser.prototype.parse): Uses eval() (eww!) to get the test results out of the
1105         JS string, then iterates over all the tests in the results data and builds up a data
1106         structure matching what ORWTResultsParser returns.
1107
1108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1109         (Array.prototype.contains):
1110         (String.prototype.contains):
1111         Added these simple helper functions.
1112
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1114         NRWTResultsParser.js.
1115
1116 2011-07-06  Adam Roben  <aroben@apple.com>
1117
1118         Extract code to parse ORWT's results.html file into its own class
1119
1120         Prep work for fixing <http://webkit.org/b/61877> TestFailures page doesn't show testers that
1121         use new-run-webkit-tests
1122
1123         Reviewed by Adam Barth.
1124
1125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1126         (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here...
1127
1128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Added.
1129         (ORWTResultsParser):
1130         (ORWTResultsParser.prototype.parse):
1131         ...to here.
1132
1133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1134         ORWTResultsParser.js.
1135
1136 2011-07-06  Eric Seidel  <eric@webkit.org>
1137
1138         Unreviewed.  Fix a unittest from hitting the network. :)
1139
1140         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1141
1142 2011-07-06  Eric Seidel  <eric@webkit.org>
1143
1144         Unreviewed.  Fixing an exception in test-webkitpy, caused by bug 64006.
1145
1146         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1147
1148 2011-07-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1149
1150         Run an Xvfb instance to run the API tests on, like we do for the
1151         layout tests.
1152
1153         Reviewed by Xan Lopez.
1154
1155         * Scripts/run-gtk-tests:
1156
1157 2011-07-06  Daniel Bates  <dbates@webkit.org>
1158
1159         Make SCM unit tests faster
1160         https://bugs.webkit.org/show_bug.cgi?id=63883
1161
1162         Speeds up the SCM unit tests by a factor of 4. Currently, we create a
1163         mock SVN repo for each test_ method in SVNTest and GitTest and creating
1164         this repo is expensive.
1165
1166         Instead, it is significantly faster to create the mock SVN repo once
1167         and then perform a filesystem copy of it for each test_ method.
1168
1169         Note, Python 2.7's unittest module implements support for per class and
1170         per module setup and tear down methods which could be used to implement
1171         similar functionality. At the time of writing, test-webkitpy is designed
1172         to support Python 2.5. So, we can't take advantage of these Python 2.7
1173         features :(
1174
1175         Reviewed by Eric Seidel.
1176
1177         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1178
1179 2011-07-06  Adam Barth  <abarth@webkit.org>
1180
1181         Remove unused parameter from _add_test in test_expectations.py
1182         https://bugs.webkit.org/show_bug.cgi?id=64008
1183
1184         Reviewed by Eric Seidel.
1185
1186         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1187
1188 2011-07-06  Adam Barth  <abarth@webkit.org>
1189
1190         Use old-run-webkit-tests when --leaks is present
1191         https://bugs.webkit.org/show_bug.cgi?id=64012
1192
1193         Reviewed by Adam Roben.
1194
1195         We'll remove this branch once support of --leaks is added to
1196         new-run-webkit-tests.
1197
1198         * Scripts/run-webkit-tests:
1199
1200 2011-07-06  Benjamin Poulain  <benjamin@webkit.org>
1201
1202         [Qt] [WK2] Add touch mocking to Qt's MiniBrowser
1203         https://bugs.webkit.org/show_bug.cgi?id=63995
1204
1205         Reviewed by Andreas Kling.
1206
1207         The mouse events are intercepted through QCoreApplication::notify(),
1208         and fake touch events are generated for mouse events when necessary.
1209
1210         If touch events are received from the platform, we assume the current
1211         hardware has a touch screen and we stop generating fake events.
1212
1213         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1214         (isTouchEvent):
1215         (isMouseEvent):
1216         (MiniBrowserApplication::MiniBrowserApplication):
1217         (MiniBrowserApplication::notify):
1218         * MiniBrowser/qt/MiniBrowserApplication.h:
1219
1220 2011-07-06  Xan Lopez  <xlopez@igalia.com>
1221
1222         Reviewed by Gustavo Noronha.
1223
1224         * Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
1225
1226 2011-07-06  Eric Seidel  <eric@webkit.org>
1227
1228         webkit-patch failure-reason does not understand NRWT results
1229         https://bugs.webkit.org/show_bug.cgi?id=64006
1230
1231         Reviewed by Adam Barth.
1232
1233         Adam Barth tells me failure-reason should be deleted soon,
1234         but aroben's fancy new TestFailures/ page doesn't work for
1235         NRWT yet, and I needed to know when
1236         third-party-cookie-relaxing started failing.
1237
1238         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1239         * Scripts/webkitpy/tool/commands/queries.py:
1240
1241 2011-07-06  Xan Lopez  <xlopez@igalia.com>
1242
1243         [GTK] Add missing environment variables in NWRT
1244         https://bugs.webkit.org/show_bug.cgi?id=64004
1245
1246         Reviewed by Gustavo Noronha Silva.
1247
1248         Add missing environment variables needed by the GTK+ port.
1249
1250         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1251
1252 2011-07-06  Adam Roben  <aroben@apple.com>
1253
1254         Make run-api-tests output intelligible on the bots
1255
1256         run-api-tests's output on the bots was very hard to read for two reasons:
1257           1) It was mixing its own output with gtest's
1258           2) It was using ANSI escape sequences to print colored text, but the bots don't support
1259              that
1260
1261         Now, the --verbose flag turns off almost all of run-api-tests's own output so that gtest's
1262         output will not be obscured. We still print "Timeout" messages even in verbose mode, since
1263         gtest doesn't have any native support for timeouts. Also, when our output is being
1264         redirected to a file, we don't print ANSI escape sequences.
1265
1266         Fixes <http://webkit.org/b/63996> It's very hard to read run-api-tests output on the bots
1267
1268         Reviewed by Sam Weinig.
1269
1270         * Scripts/run-api-tests: Don't use the :constants interface of Term::ANSIColor. We want to
1271         use the colored function instead.
1272         (runAllTestsInSuite): Don't print out suite names in verbose mode; gtest will give us enough
1273         context that they aren't needed.
1274         (runTest): Don't print out test names or pass/fail messages in verbose mode; gtest will do
1275         that for us. Also, use the new possiblyColored function instead of always coloring output.
1276         (possiblyColored): Added. When printing to a tty, returns the string with the appropriate
1277         ANSI color escape sequences added. Otherwise just returns the string unmodified.
1278
1279 2011-07-06  Xan Lopez  <xlopez@igalia.com>
1280
1281         Reviewed by Gustavo Noronha.
1282
1283         Launch Xvfb (mostly) the same way we were launching it in the
1284         bots, for maximum compatibility.
1285
1286         * Scripts/webkitpy/layout_tests/port/gtk.py:
1287
1288 2011-07-06  Andreas Kling  <kling@webkit.org>
1289
1290         [Qt][WK2] Split Qt API into two different web views (touch and desktop)
1291         https://bugs.webkit.org/show_bug.cgi?id=63950
1292
1293         Co-authored with Benjamin Poulain <benjamin@webkit.org>.
1294
1295         Reviewed by Kenneth Rohde Christiansen.
1296
1297         Port WTR/Qt to use QDesktopWebView and force a 800x600 viewport.
1298
1299         The Qt MiniBrowser now defaults to QDesktopWebView but can be started
1300         in QTouchWebView mode by passing -touch on the command line.
1301
1302         A lot of functionality has been removed and/or disabled from
1303         MiniBrowser until we reintroduce the necessary API's.
1304
1305         * MiniBrowser/qt/BrowserView.cpp:
1306         (BrowserView::BrowserView):
1307         (BrowserView::~BrowserView):
1308         (BrowserView::load):
1309         (BrowserView::view):
1310         (BrowserView::touchWebView):
1311         (BrowserView::desktopWebView):
1312         * MiniBrowser/qt/BrowserView.h:
1313         * MiniBrowser/qt/BrowserWindow.cpp:
1314         (newPageFunction):
1315         (BrowserWindow::BrowserWindow):
1316         (BrowserWindow::webView):
1317         (BrowserWindow::newWindow):
1318         (BrowserWindow::showUserAgentDialog):
1319         (BrowserWindow::updateUserAgentList):
1320         * MiniBrowser/qt/BrowserWindow.h:
1321         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1322         (MiniBrowserApplication::handleUserOptions):
1323         * MiniBrowser/qt/MiniBrowserApplication.h:
1324         (WindowOptions::WindowOptions):
1325         * MiniBrowser/qt/UrlLoader.cpp:
1326         (UrlLoader::UrlLoader):
1327         * MiniBrowser/qt/main.cpp:
1328         (main):
1329         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1330         (WTR::WebView::wkView):
1331         (WTR::WebView::pageRef):
1332         (WTR::WebView::WebView):
1333         (WTR::PlatformWebView::page):
1334         (WTR::PlatformWebView::windowFrame):
1335         (WTR::PlatformWebView::setWindowFrame):
1336
1337 2011-07-06  Eric Seidel  <eric@webkit.org>
1338
1339         Unreviewed..
1340
1341         * Scripts/run-webkit-tests:
1342         (useNewRunWebKitTests):
1343          - Fix the pass-thru of --gtk and --qt for old-run-webkit-tests,
1344            it was previously broken by the existence of isGtk/isQt checks which
1345            removed the --gtk/--qt args from @ARGV.
1346
1347 2011-07-06  Eric Seidel  <eric@webkit.org>
1348
1349         new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
1350         https://bugs.webkit.org/show_bug.cgi?id=63983
1351
1352         Reviewed by Xan Lopez.
1353
1354         All WebKit ports want to use a 35s timeout.  Only chromium currently
1355         uses a 6s timeout.  Eventually we'll move all WebKit ports to 6s too
1356         to further speed up new-run-webkit-tests runs, but that's going to be a while.
1357
1358         * Scripts/webkitpy/layout_tests/port/mac.py:
1359         * Scripts/webkitpy/layout_tests/port/webkit.py:
1360         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1361
1362 2011-07-06  Xan Lopez  <xlopez@igalia.com>
1363
1364         Unreviewed.
1365
1366         NWRT actually seems to work locally, so it should work in the bots
1367         as long as we take care of the TIMEOUT issue (which is being fixed
1368         as I write this). Let's give this another shot and fix whatever
1369         breaks.
1370
1371         * Scripts/run-webkit-tests:
1372         (useNewRunWebKitTests):
1373
1374 2011-07-06  Xan Lopez  <xlopez@igalia.com>
1375
1376         Unreviewed.
1377
1378         Disable NWRT on GTK. At the very least it needs an updated exected
1379         results file since NWRT is more sensitive to timeouts, not sure
1380         what the exact problem is.
1381
1382         * Scripts/run-webkit-tests:
1383         (useNewRunWebKitTests):
1384
1385 2011-07-06  Adam Barth  <abarth@webkit.org>
1386
1387         Fix global variable leak detected by noglobals.
1388
1389         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1390
1391 2011-07-06  Adam Barth  <abarth@webkit.org>
1392
1393         garden-o-matic shouldn't show flaky tests by default
1394         https://bugs.webkit.org/show_bug.cgi?id=63979
1395
1396         Reviewed by Ojan Vafai.
1397
1398         If any of the actual test results are PASS, the test is flaky and we
1399         can ignore it (at least for now).  If we get awesome at dealing with
1400         failing tests, we might want to tackle flaky tests by refering the user
1401         to the flakiness dashboard, which is way more awesome at dealing with
1402         flaky tests that this tool ever will be.
1403
1404         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1405         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
1406
1407 2011-07-05  Adam Barth  <abarth@webkit.org>
1408
1409         garden-o-matic should list the failing tests
1410         https://bugs.webkit.org/show_bug.cgi?id=63978
1411
1412         Reviewed by Eric Seidel.
1413
1414         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Added.
1415         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
1416         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
1417         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1418         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
1419         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
1420         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Added.
1421         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Added.
1422         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1423
1424
1425 2011-07-05  Eric Seidel  <eric@webkit.org>
1426
1427         Re-enable NRWT on Leopard now that bug 63973 is fixed.
1428
1429         Reviewed by Adam Barth.
1430
1431         I also made the should-enable expression a black-list instead
1432         of a white-list since every bot on build.webkit.org is
1433         now using NRWT except windows and WebKit2 bots.
1434
1435         * Scripts/run-webkit-tests:
1436         (useNewRunWebKitTests):
1437
1438 2011-07-05  Eric Seidel  <eric@webkit.org>
1439
1440         Perl string concat failure on Leopard (causes NRWT to fail)
1441         https://bugs.webkit.org/show_bug.cgi?id=63973
1442
1443         Reviewed by Daniel Bates.
1444
1445         Leopard's "xcodebuild -version" has a different format from Snow Leopard/Lion
1446         thus the version parsing logic in webkitdirs.pm seems to fail.
1447
1448         Default to "3.0" instead of undef when we can't parse the version number.
1449         This should send us down the correct path for Leopard.
1450
1451         * Scripts/webkitdirs.pm:
1452         (determineBaseProductDir):
1453
1454 2011-07-05  Kevin Ollivier  <kevino@theolliviers.com>
1455
1456         [wx] Unreviewed build fix after addition of Source/WebCore/xml/parser dir.
1457
1458         * waf/build/settings.py:
1459
1460 2011-07-05  Eric Seidel  <eric@webkit.org>
1461
1462         Disable NRWT for Leopard until https://bugs.webkit.org/show_bug.cgi?id=63973 can be fixed.
1463
1464         Reviewed by Adam Barth.
1465
1466         * Scripts/run-webkit-tests:
1467         (useNewRunWebKitTests):
1468
1469 2011-07-05  Eric Seidel  <eric@webkit.org>
1470
1471         Make run-webkit-tests pass --verbose to new-run-webkit-tests on qt/gtk bots.
1472
1473         Reviewed by Adam Barth.
1474
1475         * Scripts/run-webkit-tests:
1476         (runningOnBuildBot):
1477
1478 2011-07-05  Adam Barth  <abarth@webkit.org>
1479
1480         Add results_unittests.js to garden-o-matic
1481         https://bugs.webkit.org/show_bug.cgi?id=63971
1482
1483         Reviewed by Eric Seidel.
1484
1485         Adding these unit tests forced me to commit to an API for the results
1486         module.  I'm not sure if this is the API we'll end up with, but it's
1487         something not entirely unreasonable.
1488
1489         Also, I've changed results.js over to WebKit style, as discussed previously.
1490
1491         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
1492         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1493         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Added.
1494         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
1495
1496 2011-07-05  Eric Seidel  <eric@webkit.org>
1497
1498         Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.
1499
1500         Reviewed by Adam Barth.
1501
1502         * Scripts/run-webkit-tests:
1503
1504 2011-07-05  Adam Barth  <abarth@webkit.org>
1505
1506         Add first unit tests for garden-o-matic
1507         https://bugs.webkit.org/show_bug.cgi?id=63969
1508
1509         Reviewed by Eric Seidel.
1510
1511         I've also reformated base.js to match WebKit style, as discussed in the
1512         previous bug.
1513
1514         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
1515         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
1516         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.
1517
1518 2011-07-05  Eric Seidel  <eric@webkit.org>
1519
1520         Move Qt, Gtk and Leopard to NRWT.
1521
1522         We'll roll out any of these if we see problems.
1523
1524         Reviewed by Adam Barth.
1525
1526         * Scripts/run-webkit-tests:
1527         (useNewRunWebKitTests):
1528
1529 2011-07-05  Adam Barth  <abarth@webkit.org>
1530
1531         garden-o-matic should understand which tests have unexpected failures
1532         https://bugs.webkit.org/show_bug.cgi?id=63965
1533
1534         Reviewed by Eric Seidel.
1535
1536         Currently, this code just logs the list of unexpected failures to the
1537         console.  A future patch will do something useful with this
1538         information.  A testing harness will also come in the next patch.
1539
1540         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
1541         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
1542         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
1543         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1544
1545 2011-07-05  Adam Barth  <abarth@webkit.org>
1546
1547         garden-o-matic should know how to fetch test results from the (NRWT) bots
1548         https://bugs.webkit.org/show_bug.cgi?id=63959
1549
1550         Reviewed by Eric Seidel.
1551
1552         Currently, this code just fetches the results and expectations JSON
1553         blob for Linux from the server and logs it to the console.
1554
1555         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
1556         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Added.
1557         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1558
1559 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
1560
1561         Reviewed by Eric Seidel.
1562
1563         Python tests are failing on leopard
1564         https://bugs.webkit.org/show_bug.cgi?id=63842
1565
1566         Fix the missing flush() call that appears to be needed by the
1567         logging package in python 2.5. Also fix the regressions
1568         introduced in the run_webkit_test tests when we switched from
1569         thread to processes (since processes aren't available on 2.5).
1570
1571         Also fix a missing "from __future__ import with_statement' in
1572         testfilehandler (unreviewed).
1573
1574         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1575         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1576         * TestResultServer/handlers/testfilehandler.py:
1577
1578 2011-07-05  Eric Seidel  <eric@webkit.org>
1579
1580         Reviewed by Adam Barth.
1581
1582         re-enabling new-run-webkit-tests on the Snow Leopard WebKit1 bots
1583         now that we believe the stray http-server issue to be solved.
1584
1585         * Scripts/run-webkit-tests:
1586         (useNewRunWebKitTests):
1587
1588 2011-07-05  Adam Barth  <abarth@webkit.org>
1589
1590         Turns out we need to support numerals too because that's what jQuery
1591         uses by default.
1592
1593         * TestResultServer/handlers/testfilehandler.py:
1594
1595 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
1596
1597         nrwt: allow for multiple http shards
1598         https://bugs.webkit.org/show_bug.cgi?id=63116
1599
1600         Reviewed by Tony Chang.
1601
1602         This modifies the sharding logic to support multiple http
1603         shards, but for now we clamp to one shard until we can test
1604         perf impact and flakiness impact.
1605
1606         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1607         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
1608
1609 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
1610
1611         Re-land nrwt: make sharding tests needing locks less hard-coded
1612         https://bugs.webkit.org/show_bug.cgi?id=63112
1613
1614         Reviewed by Ojan Vafai.
1615
1616         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1617         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
1618
1619 2011-07-05  Adam Barth  <abarth@webkit.org>
1620
1621         TestResultServer should support callback parameter for JSON
1622         https://bugs.webkit.org/show_bug.cgi?id=63961
1623
1624         Reviewed by Ojan Vafai.
1625
1626         This makes using jQuery.ajax so much more pleasant.
1627
1628         * TestResultServer/handlers/testfilehandler.py:
1629
1630 2011-07-05  Eric Seidel  <eric@webkit.org>
1631
1632         buildbot needs to understand whether NRWT exited early after having too many failures
1633         https://bugs.webkit.org/show_bug.cgi?id=63839
1634
1635         Reviewed by Adam Barth.
1636
1637         Fix-up the exited early messages printed by NRWT so that
1638         the buildbot can parse them as expected.
1639         It looks for lines using "if line.find('Exiting early') >= 0:"
1640
1641         I also plumbed the "early exit" status through to results.json
1642         in the form of an "interrupted" bool.  It was unclear to me
1643         if results.json already had enough information to compute this bool
1644         itself.  It's possible Ojan could come up with a better fix.
1645
1646         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1647         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
1648         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1649         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
1650
1651 2011-07-05  Eric Seidel  <eric@webkit.org>
1652
1653         new-run-webkit-tests fails to start http server if one is already running
1654         https://bugs.webkit.org/show_bug.cgi?id=63956
1655
1656         Reviewed by Adam Barth.
1657
1658         * BuildSlaveSupport/kill-old-processes:
1659          - Removed ^M line endings and sorted the process names.
1660          - There are no functional changes to this file.
1661            (except that now that its using unix line endings it can be executed directly!)
1662         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1663          - Change the name to 'httpd' to match old-run-webkit-test paths.
1664
1665 2011-07-05  Adam Barth  <abarth@webkit.org>
1666
1667         Add basic ajax support to garden-o-matic
1668         https://bugs.webkit.org/show_bug.cgi?id=63874
1669
1670         Reviewed by Eric Seidel.
1671
1672         This patch adds some basic infrastructure to garden-o-matic.
1673         Currently, the infrastructure is just used to make the "quit" command
1674         use Ajax, but in the future, this infrastructure will be used to do
1675         more sophistocated remote proceedure calls.
1676
1677         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
1678         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added.
1679         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1680         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1681
1682 2011-07-05  Adam Barth  <abarth@webkit.org>
1683
1684         Add trivial garden-o-matic command (with server)
1685         https://bugs.webkit.org/show_bug.cgi?id=63872
1686
1687         Reviewed by Eric Seidel.
1688
1689         This patch adds a trivial "Hello, world" garden-o-matic command,
1690         complete with an HTTP server.  This command re-uses a bunch of code
1691         from the existing rebaseline-server command.  Over time, this command
1692         will grow to be a tool useful for gardening the WebKit tree.
1693
1694         * Scripts/webkitpy/tool/commands/__init__.py:
1695         * Scripts/webkitpy/tool/commands/abstractservercommand.py: Added.
1696         * Scripts/webkitpy/tool/commands/gardenomatic.py: Added.
1697         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1698         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added.
1699         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added.
1700         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1701
1702 2011-07-05  Adam Roben  <aroben@apple.com>
1703
1704         Make prepare-ChangeLog include modified Perl functions in its ChangeLog template
1705
1706         This is a very simple first cut. Functions must start with a line that starts with "sub "
1707         and end with a line that starts with a closing brace. No leading whitespace is allowed.
1708         Package names aren't parsed at all.
1709
1710         Fixes <http://webkit.org/b/21591> prepare-ChangeLog should know how to find functions in
1711         Perl files
1712
1713         Reviewed by David Kilzer.
1714
1715         * Scripts/prepare-ChangeLog: Removed redundant code that ignored certain files when
1716         searching for function line ranges. This is already done inside the get_function_line_ranges
1717         function.
1718         (get_function_line_ranges): Cleaned up coding style a little bit. Call
1719         get_function_line_ranges_for_perl for files with .pl and .pm extensions. For files with an
1720         unknown extension or no extension, read the shebang line to try to determine the script
1721         interpreter. Call get_function_line_ranges_for_perl if the interpreter seems to be Perl.
1722         (get_function_line_ranges_for_perl): Added. Does extremely basic parsing of the file to find
1723         lines starting with "sub " or "}".
1724
1725 2011-07-05  Adam Roben  <aroben@apple.com>
1726
1727         Clean up run-api-tests output on Windows
1728
1729         We were mixing run-api-tests output with gtest output, and the result was a mess.
1730
1731         Fixes <http://webkit.org/b/63954> run-api-tests output is very confusing on Windows
1732
1733         Reviewed by Dan Bates.
1734
1735         * Scripts/run-api-tests:
1736         (runTest):
1737         (populateTests):
1738         Made Windows use the formerly-Mac-only codepaths which correctly suppress gtest output
1739         except in verbose mode. Most changes are due to indentation. Use of the arch utility is now
1740         the only Mac-specific thing in these functions. Some other platform-specific code was moved
1741         from here...
1742
1743         (prepareEnvironmentForRunningTestTool):
1744         (testToolPath):
1745         ...to here.
1746
1747 2011-07-04  Gavin Barraclough  <barraclough@apple.com>
1748
1749         Reviewed by Sam Weinig.
1750
1751         https://bugs.webkit.org/show_bug.cgi?id=16652
1752         Firefox and JavaScriptCore differ in Number.toString(integer)
1753
1754         Added forwarding header.
1755
1756         * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.
1757
1758 2011-07-04  Anders Carlsson  <andersca@apple.com>
1759
1760         Try to fix Qt build.
1761
1762         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1763
1764 2011-07-04  Anders Carlsson  <andersca@apple.com>
1765
1766         NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
1767         https://bugs.webkit.org/show_bug.cgi?id=63915
1768         <rdar://problem/7124300>
1769
1770         Reviewed by Sam Weinig.
1771
1772         Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.
1773
1774         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1775         (PluginTest::NPN_IdentifierIsString):
1776         (PluginTest::NPN_UTF8FromIdentifier):
1777         (PluginTest::NPN_IntFromIdentifier):
1778         (PluginTest::NPN_RetainObject):
1779         (PluginTest::NPN_ReleaseObject):
1780         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1781         (PluginTest::Object::removeProperty):
1782         (PluginTest::Object::identifierIs):
1783         (PluginTest::Object::NP_RemoveProperty):
1784         (PluginTest::Object::npClass):
1785         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1786         (NPRuntimeRemoveProperty::TestObject::TestObject):
1787         (NPRuntimeRemoveProperty::TestObject::hasProperty):
1788         (NPRuntimeRemoveProperty::TestObject::getProperty):
1789         (NPRuntimeRemoveProperty::TestObject::removeProperty):
1790         (NPRuntimeRemoveProperty::PluginObject::PluginObject):
1791         (NPRuntimeRemoveProperty::PluginObject::~PluginObject):
1792         (NPRuntimeRemoveProperty::PluginObject::hasMethod):
1793         (NPRuntimeRemoveProperty::PluginObject::invoke):
1794         (NPRuntimeRemoveProperty::PluginObject::hasProperty):
1795         (NPRuntimeRemoveProperty::PluginObject::getProperty):
1796         (NPRuntimeRemoveProperty::NPP_GetValue):
1797
1798 2011-07-04  Leandro Pereira  <leandro@profusion.mobi>
1799
1800         Reviewed by Kent Tamura.
1801
1802         [EFL] Add LayoutTestControllerEfl.
1803         https://bugs.webkit.org/show_bug.cgi?id=61974
1804
1805         Only the core features are implemented. Most functions are actually
1806         stubs and will be implemented as soon as its features are needed.
1807         Build system changes will be made as soon as DRT is completely
1808         upstreamed.
1809
1810         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added.
1811         (LayoutTestController::~LayoutTestController):
1812         (LayoutTestController::addDisallowedURL):
1813         (LayoutTestController::clearBackForwardList):
1814         (LayoutTestController::copyDecodedHostName):
1815         (LayoutTestController::copyEncodedHostName):
1816         (LayoutTestController::dispatchPendingLoadRequests):
1817         (LayoutTestController::display):
1818         (LayoutTestController::counterValueForElementById):
1819         (LayoutTestController::keepWebHistory):
1820         (LayoutTestController::computedStyleIncludingVisitedInfo):
1821         (LayoutTestController::nodesFromRect):
1822         (LayoutTestController::layerTreeAsText):
1823         (LayoutTestController::pageNumberForElementById):
1824         (LayoutTestController::numberOfPages):
1825         (LayoutTestController::pageProperty):
1826         (LayoutTestController::isPageBoxVisible):
1827         (LayoutTestController::pageSizeAndMarginsInPixels):
1828         (LayoutTestController::webHistoryItemCount):
1829         (LayoutTestController::workerThreadCount):
1830         (LayoutTestController::notifyDone):
1831         (LayoutTestController::pathToLocalResource):
1832         (LayoutTestController::queueLoad):
1833         (LayoutTestController::setAcceptsEditing):
1834         (LayoutTestController::setAlwaysAcceptCookies):
1835         (LayoutTestController::setCustomPolicyDelegate):
1836         (LayoutTestController::waitForPolicyDelegate):
1837         (LayoutTestController::setScrollbarPolicy):
1838         (LayoutTestController::addOriginAccessWhitelistEntry):
1839         (LayoutTestController::removeOriginAccessWhitelistEntry):
1840         (LayoutTestController::setMainFrameIsFirstResponder):
1841         (LayoutTestController::setTabKeyCyclesThroughElements):
1842         (LayoutTestController::setUseDashboardCompatibilityMode):
1843         (LayoutTestController::setUserStyleSheetEnabled):
1844         (LayoutTestController::setUserStyleSheetLocation):
1845         (LayoutTestController::setValueForUser):
1846         (LayoutTestController::setViewModeMediaFeature):
1847         (LayoutTestController::setWindowIsKey):
1848         (LayoutTestController::setSmartInsertDeleteEnabled):
1849         (waitToDumpWatchdogFired):
1850         (LayoutTestController::setWaitToDump):
1851         (LayoutTestController::windowCount):
1852         (LayoutTestController::setPrivateBrowsingEnabled):
1853         (LayoutTestController::setJavaScriptCanAccessClipboard):
1854         (LayoutTestController::setXSSAuditorEnabled):
1855         (LayoutTestController::setFrameFlatteningEnabled):
1856         (LayoutTestController::setSpatialNavigationEnabled):
1857         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1858         (LayoutTestController::setAllowFileAccessFromFileURLs):
1859         (LayoutTestController::setAuthorAndUserStylesEnabled):
1860         (LayoutTestController::setAutofilled):
1861         (LayoutTestController::disableImageLoading):
1862         (LayoutTestController::setMockDeviceOrientation):
1863         (LayoutTestController::setMockGeolocationPosition):
1864         (LayoutTestController::setMockGeolocationError):
1865         (LayoutTestController::setGeolocationPermission):
1866         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1867         (LayoutTestController::addMockSpeechInputResult):
1868         (LayoutTestController::setIconDatabaseEnabled):
1869         (LayoutTestController::setJavaScriptProfilingEnabled):
1870         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1871         (LayoutTestController::setPopupBlockingEnabled):
1872         (LayoutTestController::setPluginsEnabled):
1873         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1874         (LayoutTestController::execCommand):
1875         (LayoutTestController::findString):
1876         (LayoutTestController::isCommandEnabled):
1877         (LayoutTestController::setCacheModel):
1878         (LayoutTestController::setPersistentUserStyleSheetLocation):
1879         (LayoutTestController::clearPersistentUserStyleSheet):
1880         (LayoutTestController::clearAllApplicationCaches):
1881         (LayoutTestController::setApplicationCacheOriginQuota):
1882         (LayoutTestController::clearApplicationCacheForOrigin):
1883         (LayoutTestController::localStorageDiskUsageForOrigin):
1884         (LayoutTestController::originsWithApplicationCache):
1885         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1886         (LayoutTestController::clearAllDatabases):
1887         (LayoutTestController::setDatabaseQuota):
1888         (LayoutTestController::originsWithLocalStorage):
1889         (LayoutTestController::deleteAllLocalStorage):
1890         (LayoutTestController::deleteLocalStorageForOrigin):
1891         (LayoutTestController::observeStorageTrackerNotifications):
1892         (LayoutTestController::syncLocalStorage):
1893         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1894         (LayoutTestController::goBack):
1895         (LayoutTestController::setDefersLoading):
1896         (LayoutTestController::setAppCacheMaximumSize):
1897         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1898         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1899         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1900         (LayoutTestController::numberOfActiveAnimations):
1901         (LayoutTestController::suspendAnimations):
1902         (LayoutTestController::resumeAnimations):
1903         (LayoutTestController::overridePreference):
1904         (LayoutTestController::addUserScript):
1905         (LayoutTestController::addUserStyleSheet):
1906         (LayoutTestController::setDeveloperExtrasEnabled):
1907         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1908         (LayoutTestController::showWebInspector):
1909         (LayoutTestController::closeWebInspector):
1910         (LayoutTestController::evaluateInWebInspector):
1911         (LayoutTestController::evaluateScriptInIsolatedWorld):
1912         (LayoutTestController::removeAllVisitedLinks):
1913         (LayoutTestController::callShouldCloseOnWebView):
1914         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
1915         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
1916         (LayoutTestController::setWebViewEditable):
1917         (LayoutTestController::markerTextForListItem):
1918         (LayoutTestController::authenticateSession):
1919         (LayoutTestController::setEditingBehavior):
1920         (LayoutTestController::abortModal):
1921         (LayoutTestController::hasSpellingMarker):
1922         (LayoutTestController::hasGrammarMarker):
1923         (LayoutTestController::dumpConfigurationForViewport):
1924         (LayoutTestController::setSerializeHTTPLoads):
1925         (LayoutTestController::setMinimumTimerInterval):
1926         (LayoutTestController::setTextDirection):
1927         (LayoutTestController::allowRoundingHacks):
1928
1929 2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>
1930
1931         Unreviewed, add myself as committer.
1932
1933         * Scripts/webkitpy/common/config/committers.py:
1934
1935 2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1936
1937         Unreviewed, rolling out r90347.
1938         http://trac.webkit.org/changeset/90347
1939         https://bugs.webkit.org/show_bug.cgi?id=63886
1940
1941         Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
1942         (Requested by tkent on #webkit).
1943
1944         * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
1945
1946 2011-07-03  Daniel Bates  <dbates@webkit.org>
1947
1948         Import Checkout in scm_unittests.py and logging in svn.py to fix
1949         Python missing global variable errors
1950
1951         Rubber-stamped by Adam Barth.
1952
1953         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Import Checkout.
1954         * Scripts/webkitpy/common/checkout/scm/svn.py: Import logging.
1955
1956 2011-07-02  Gavin Barraclough  <barraclough@apple.com>
1957
1958         Reviewed by Sam Weinig.
1959
1960         https://bugs.webkit.org/show_bug.cgi?id=16652
1961         Firefox and JavaScriptCore differ in Number.toString(integer)
1962
1963         Added forwarding header.
1964
1965         * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.
1966
1967 2011-04-02  Robert Hogan  <robert@webkit.org>
1968
1969         Reviewed by Benjamin Poulain.
1970
1971         [Qt] Support third-party cookie policy for Qt clients
1972         https://bugs.webkit.org/show_bug.cgi?id=45455
1973
1974         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1975         (LayoutTestController::reset):
1976         (LayoutTestController::setAlwaysAcceptCookies):
1977         (LayoutTestController::setAlwaysBlockCookies):
1978         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1979
1980 2011-07-03  Adam Barth  <abarth@webkit.org>
1981
1982         Factor ReflectionHandler out of the rebaseline server.  Just code motion.
1983
1984         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1985         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1986         * Scripts/webkitpy/tool/servers/reflectionhandler.py: Added.
1987
1988 2011-07-03  Adam Barth  <abarth@webkit.org>
1989
1990         Move the rebaseline server out of the commands package and into the
1991         (new) servers package.  This patch prepares for refactoring this code
1992         to share server infrastructure with the (forthcoming) garden-o-matic
1993         command.
1994
1995         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1996         * Scripts/webkitpy/tool/servers/__init__.py: Added.
1997         * Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js:
1998         * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
1999         * Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js:
2000         * Scripts/webkitpy/tool/servers/rebaselineserver.py: Added.
2001
2002 2011-07-01  Adam Barth  <abarth@webkit.org>
2003
2004         Fix typo in master.cfg, hoping to trigger a master restart.
2005
2006         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2007
2008 2011-07-01  Adam Barth  <abarth@webkit.org>
2009
2010         Turn off new-run-webkit-tests and remove some debug logging.
2011
2012         * Scripts/run-webkit-tests:
2013         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2014
2015 2011-07-01  Adam Barth  <abarth@webkit.org>
2016
2017         Add some more debug logging to try to understand why we're getting
2018         stuck acquring the HTTP lock.
2019
2020         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2021
2022 2011-07-01  Adam Barth  <abarth@webkit.org>
2023
2024         Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
2025         https://bugs.webkit.org/show_bug.cgi?id=63854
2026
2027         Reviewed by Dirk Pranke.
2028
2029         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2030
2031 2011-07-01  Eric Seidel  <eric@webkit.org>
2032
2033         new-run-webkit-tests results does not understand that mac uses test_expectations files
2034         https://bugs.webkit.org/show_bug.cgi?id=63838
2035
2036         Reviewed by Adam Barth.
2037
2038         We've decided to "enable" test_expectations for the Mac port for now.
2039         It makes the results.html results much more confusing to read, but at least they're
2040         no longer lying to us.
2041
2042         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2043         * Scripts/webkitpy/layout_tests/port/base.py:
2044         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2045
2046 2011-07-01  Adam Barth  <abarth@webkit.org>
2047
2048         Temporarily disable waiting for ReportCrash to see how this code
2049         affects performance on the bots.
2050
2051         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2052         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2053
2054 2011-07-01  Dmitry Lomov  <dslomov@google.com>
2055
2056         Reviewed by Adam Roben.
2057
2058         https://bugs.webkit.org/show_bug.cgi?id=63818
2059         Test bots shouldn't attempt to build TestWebKitAPI on Windows.
2060         TestWebKitAPI builds as a part of general webkit build and is a
2061         part of build products archive.
2062
2063         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2064         * Scripts/run-api-tests:
2065
2066 2011-07-01  Adam Barth  <abarth@webkit.org>
2067
2068         We shouldn't wait for ReportCrash while the timeout is running
2069         https://bugs.webkit.org/show_bug.cgi?id=63837
2070
2071         Reviewed by Eric Seidel.
2072
2073         Instead, we should move this check to worker.py.
2074
2075         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2076         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2077
2078 2011-07-01  Adam Roben  <aroben@apple.com>
2079
2080         Stop setting unsafe headers on POSTs via XHR from TestFailures page
2081
2082         Fixes <http://webkit.org/b/63833> TestFailures page causes a bunch of spew in the
2083         Inspector's console about unsafe headers
2084
2085         Reviewed by Dan Bates.
2086
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
2088         (fetchResource): Removed unnecessary code to set Content-Length and Connection headers.
2089
2090 2011-07-01  Eric Seidel  <eric@webkit.org>
2091
2092         Reviewed by Adam Barth.
2093
2094         Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
2095         https://bugs.webkit.org/show_bug.cgi?id=63786
2096
2097         We're down to one bug blocking the "move to NRWT" bug:
2098         https://bugs.webkit.org/show_bug.cgi?id=34984
2099         so we're trying transitioning Snow Leopard to NRWT as an experiment.
2100
2101         If we run into any blocking issues we'll of course roll this back out
2102         (or anyone reading this should feel encouraged to).
2103
2104         * Scripts/run-webkit-tests:
2105
2106 2011-07-01  Adam Barth  <abarth@webkit.org>
2107
2108         Add a compat shim for --leaks.  Support for --leaks will be added in
2109         https://bugs.webkit.org/show_bug.cgi?id=63832.
2110
2111         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2112
2113 2011-07-01  Adam Barth  <abarth@webkit.org>
2114
2115         Reviewed by Darin Adler.
2116
2117         ReportCrash destabilizes new-run-webkit-tests
2118         https://bugs.webkit.org/show_bug.cgi?id=63795
2119
2120         ReportCrash chews up too many system resources that it destablizes
2121         tests run concurrently.  This patch causes us to spin down all the
2122         worker processes when ReportCrash is running.
2123
2124         Also, this patch causes the master process to tell the user we're
2125         waiting for the crash reporter rather than having that be the worker's
2126         job.  This stops the user from getting spammed with too many "waiting
2127         for crash reporter" messages and also cleans up some minor UI issues
2128         with the meter.
2129
2130         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2131         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2132         * Scripts/webkitpy/layout_tests/port/base.py:
2133         * Scripts/webkitpy/layout_tests/port/server_process.py:
2134
2135 2011-07-01  Adam Roben  <aroben@apple.com>
2136
2137         Teach webkitpy about the new format of our ChangeLog template
2138
2139         r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
2140         template. But webkitpy didn't know this, so the various rollout-related commands were
2141         leaving that line in the ChangeLog.
2142
2143         Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot
2144         rollout are broken
2145
2146         Reviewed by Dan Bates.
2147
2148         * Scripts/webkitpy/common/checkout/changelog.py:
2149         (ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
2150         description and bug URL" line instead of the "Reviewed by" line as the first line of the
2151         ChangeLog template.
2152
2153         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2154         (ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
2155         generates.
2156
2157 2011-07-01  Adam Roben  <aroben@apple.com>
2158
2159         Make TestFailures stop loading old builds once we've explained all current failures
2160
2161         We used to do this, but some refactoring in r90165 broke this logic.
2162
2163         Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
2164         builds back to the beginning of time
2165
2166         Reviewed by Dan Bates.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
2169         (LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
2170         all current failures have been explained.
2171
2172 2011-07-01  Adam Roben  <aroben@apple.com>
2173
2174         commit-log-editor reorders ChangeLog entries in unexpected ways
2175         https://bugs.webkit.org/show_bug.cgi?id=63804
2176
2177         Reviewed by Darin Adler.
2178
2179         commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
2180         commit message in order to make git-based tools, which expect the first line of the commit
2181         message to be a summary of the change, to work better. But this reordering of the ChangeLog
2182         entry was unpredictable and unexpected.
2183
2184         I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
2185         so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
2186         try to move them.
2187
2188         * Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"
2189         line and try to move it down below the bug title and URL. The order of the text in the
2190         ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
2191         by" line in cases where the committer and author are not the same person.
2192
2193         * Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
2194
2195 2011-07-01  Mihnea Ovidenie  <mihnea@adobe.com>
2196
2197         Reviewed by Adam Roben.
2198
2199         [CSSRegions] Add build slave
2200         https://bugs.webkit.org/show_bug.cgi?id=62372
2201
2202         * BuildSlaveSupport/build.webkit.org-config/config.json:
2203         Add an entry for a release build of Mac.
2204
2205 2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2206
2207         Unreviewed, rolling out r90213.
2208         http://trac.webkit.org/changeset/90213
2209         https://bugs.webkit.org/show_bug.cgi?id=63792
2210
2211         The SL bot has an errant HTTP server holding port 8080
2212         (Requested by abarth on #webkit).
2213
2214         * Scripts/run-webkit-tests:
2215
2216 2011-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         Unreviewed. Fix WebKit2 GTK build after r90163.
2219
2220         * MiniBrowser/gtk/WebBundle/WebBundleMain.c:
2221         (didCreatePage):
2222
2223 2011-07-01  Adam Barth  <abarth@webkit.org>
2224
2225         Exit faster when we get a keyboard interrupt.  Previously, we'd open
2226         Safari if you ^C NRWT after it found a failure.
2227
2228         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2229
2230 2011-07-01  Eric Seidel  <eric@webkit.org>
2231
2232         Reviewed by Adam Barth.
2233
2234         Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
2235         https://bugs.webkit.org/show_bug.cgi?id=63786
2236
2237         We're down to one bug blocking the "move to NRWT" bug:
2238         https://bugs.webkit.org/show_bug.cgi?id=34984
2239         so we're trying transitioning Snow Leopard to NRWT as an experiment.
2240
2241         If we run into any blocking issues we'll of course roll this back out
2242         (or anyone reading this should feel encouraged to).
2243
2244         * Scripts/run-webkit-tests:
2245
2246 2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2247
2248         Unreviewed, rolling out r90192.
2249         http://trac.webkit.org/changeset/90192
2250         https://bugs.webkit.org/show_bug.cgi?id=63788
2251
2252         Appears to have caused NRWT on Chromium WebKit Vista to hang
2253         (Requested by abarth on #webkit).
2254
2255         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2256         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
2257
2258 2011-06-30  Adam Barth  <abarth@webkit.org>
2259
2260         Reviewed by Eric Seidel.
2261
2262         Remove the concept of "being wedged" from new-run-webkit-tests
2263         https://bugs.webkit.org/show_bug.cgi?id=63767
2264
2265         Worker processes shouldn't ever become wedged.  My understanding is
2266         that this code was originally motivated by the old threading-based
2267         design but no longer servers any purpose.
2268
2269         Note: If we actually have a problem with the test harness getting
2270         stuck, buildbot will kill us.
2271
2272         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2273         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2274         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
2275
2276 2011-06-30  Adam Barth  <abarth@webkit.org>
2277
2278         The win32 implementation of fork is sad about forking test-webkitpy.
2279         Hopefully this will heal the bot.
2280
2281         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2282
2283 2011-06-30  Eric Seidel  <eric@webkit.org>
2284
2285         Reviewed by Adam Barth.
2286
2287         Update new-run-webkit-tests now that the wk2 shared skipped list has moved
2288         https://bugs.webkit.org/show_bug.cgi?id=63780
2289
2290         The shared list was moved from mac-wk2 to wk2 as part of
2291         http://trac.webkit.org/changeset/90125.
2292
2293         * Scripts/webkitpy/layout_tests/port/webkit.py:
2294         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2295
2296 2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>
2297
2298         Reviewed by Darin Adler.
2299
2300         Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
2301         https://bugs.webkit.org/show_bug.cgi?id=62022
2302
2303         Adds XcodeProjectFileChecker to check removal of "developmentRegion".
2304
2305         * Scripts/webkitpy/style/checker.py: Added XcodeProjectFileChecker as a checker for *.pbxproj.
2306         * Scripts/webkitpy/style/checkers/xcodeproj.py: Added.
2307         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: Added.
2308
2309 2011-06-30  Dirk Pranke  <dpranke@chromium.org>
2310
2311         Reviewed by Ojan Vafai.
2312
2313         nrwt: make sharding tests needing locks less hard-coded
2314         https://bugs.webkit.org/show_bug.cgi?id=63112
2315
2316         This change also changes the manager logic so that it will
2317         drop the server lock as soon as all of the shards requiring
2318         the lock have completed.
2319
2320         This change includes some minor namespace/import changes in the
2321         unit tests, and also makes the Manager a new-style object, which
2322         it should've been all along.
2323
2324         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2325         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
2326
2327 2011-06-30  Adam Barth  <abarth@webkit.org>
2328
2329         Reviewed by Eric Seidel.
2330
2331         Remove threaded mode from new-run-webkit-tests
2332         https://bugs.webkit.org/show_bug.cgi?id=63771
2333
2334         This mode is not used and is buggy.  Rather than carry around a bunch
2335         of unused buggy code, we should rip it out and focus on the
2336         multiprocess implementation.
2337
2338         * Scripts/webkitpy/common/system/executive.py:
2339         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2340         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
2341         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2342         * Scripts/webkitpy/layout_tests/port/base.py:
2343         * Scripts/webkitpy/layout_tests/port/chromium.py:
2344         * Scripts/webkitpy/layout_tests/port/mac.py:
2345         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2346         * Scripts/webkitpy/layout_tests/port/server_process.py:
2347         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2348         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2349
2350 2011-06-30  Adam Barth  <abarth@webkit.org>
2351
2352         Reviewed by Darin Adler.
2353
2354         Clean up output from new-run-webkit-tests
2355         https://bugs.webkit.org/show_bug.cgi?id=63759
2356
2357         Printing messages from the child process looks super ugly because of
2358         the way the pretty-printer works.  Printing a blank line first is a
2359         hack, but it makes things at least partially sane.
2360
2361         Also, handle the case where calling sample throws an exception.
2362
2363         * Scripts/webkitpy/layout_tests/port/server_process.py:
2364         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2365
2366 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
2367
2368         Reviewed by Antonio Gomes.
2369
2370         [Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
2371         https://bugs.webkit.org/show_bug.cgi?id=63489
2372
2373         Unskipped:
2374             loader/navigation-while-deferring-loads.html
2375
2376         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2377         (LayoutTestController::goBack):
2378         (LayoutTestController::setDefersLoading):
2379         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2380
2381 2011-06-30  Adam Barth  <abarth@webkit.org>
2382
2383         Reviewed by Dirk Pranke.
2384
2385         new-run-webkit-tests should stop when I ^C it
2386         https://bugs.webkit.org/show_bug.cgi?id=63763
2387
2388         It still doesn't stop fast enough, but at least with this patch it
2389         doesn't run more tests.
2390
2391         Also, I tweaked the UI that happens when there's a keyboard interrupt
2392         to not be amazingly ugly.  There's still a garbage "Te" left on the
2393         console, but that's a problem for another day.
2394
2395         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2396
2397 2011-06-30  Adam Roben  <aroben@apple.com>
2398
2399         Make TestFailures never treat a too-many-failures build as a last-passing build for a test
2400
2401         Fixes <http://webkit.org/b/63758> TestFailures sometimes incorrectly says that a build was
2402         the last passing build for a test, when in fact the test wasn't run due to too many failures
2403         causing old-run-webkit-tests to exit early
2404
2405         Reviewed by Anders Carlsson.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
2408         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): If there were too many
2409         failures in this build, assume that all the tests failed in the last build would have failed
2410         in this build, too, had they been run. Introduced some new local variables to reduce typing,
2411         and used them throughout.
2412
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2414         (LayoutTestResultsLoader.prototype.start): Fix a regression from r89841 where we wouldn't
2415         correctly remember whether old-run-webkit-tests exited early due to too many failures for
2416         builds older than r89610. Also removed an unused parameter while I was at it.
2417
2418 2011-06-30  Adam Roben  <aroben@apple.com>
2419
2420         Make TestFaiulres only load old-results directories as needed
2421
2422         Fixes <http://webkit.org/b/63752> Tester pages on TestFailures page load very slowly
2423
2424         Reviewed by Anders Carlsson.
2425
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2427         (Builder.prototype.getBuildNames): Moved up into the API section of the class. Now just
2428         calls through to _getBuildNamesFromResultsDirectory.
2429         (Builder.prototype.getOldBuildNames): Added. Just calls through to
2430         _getBuildNamesFromResultsDirectory.
2431         (Builder.prototype._getBuildNamesFromResultsDirectory): Renamed from getBuildNames. Now
2432         takes the directory URL as an argument and only fetches that single URL.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
2435         (LayoutTestHistoryAnalyzer.prototype.start): Moved most logic to _analyzeBuilds. First
2436         analyzes builds from Builder.getBuildNames, then from Builder.getOldBuildNames if needed.
2437         (LayoutTestHistoryAnalyzer.prototype._analyzeBuilds): Moved logic here from start. (Most
2438         changes are just indentation.) Now takes a callback to call when we've finished analyzing
2439         all builds in buildNames so that we can try to fetch more build names if needed.
2440
2441 2011-06-30  Mark Rowe  <mrowe@apple.com>
2442
2443         Reviewed by Anders Carlsson.
2444
2445         Update MiniBrowser and WebKitTestRunner to use the client version constants.
2446
2447         * MiniBrowser/gtk/BrowserWindow.c:
2448         (browserWindowLoaderClientInit):
2449         (browserWindowUIClientInit):
2450         * MiniBrowser/gtk/WebBundle/WebBundleMain.c:
2451         (didCreatePage):
2452         (WKBundleInitialize):
2453         * MiniBrowser/gtk/main.c:
2454         (createWKContextWithInjectedBundle):
2455         * MiniBrowser/mac/AppDelegate.m:
2456         (-[BrowserAppDelegate init]):
2457         * MiniBrowser/mac/BrowserWindowController.m:
2458         (-[BrowserWindowController awakeFromNib]):
2459         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2460         (WKBundleInitialize):
2461         * MiniBrowser/win/BrowserView.cpp:
2462         (BrowserView::create):
2463         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2464         (WTR::InjectedBundle::initialize):
2465         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2466         (WTR::InjectedBundlePage::InjectedBundlePage):
2467         * WebKitTestRunner/TestController.cpp:
2468         (WTR::TestController::createOtherPage):
2469         (WTR::TestController::initialize):
2470
2471 2011-06-30  Adam Roben  <aroben@apple.com>
2472
2473         Identify revisions that modified failing tests on TestFailures page
2474
2475         Fixes <http://webkit.org/b/63716> TestFailures page should try to infer which commit caused
2476         a failure by looking at commit logs
2477
2478         Reviewed by David Kilzer.
2479
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2481         (.existing-bugs-list, .suspect-revisions-list): Made this rule apply to the suspect
2482         revisions list, too.
2483
2484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2485         (Trac): Initialize our memory cache.
2486         (Trac.prototype.getCommitDataForRevisionRange): Added. Fetches the commit log in RSS form,
2487         then parses out the revision number, Trac's idea of the commit title, and the files modified
2488         by the commit. (To get the modified files, we rely on the commit message including a
2489         prepare-ChangeLog-style file list.)
2490         (Trac.prototype.logURL): Added a new formatAsRSS parameter.
2491
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
2493         (removePathExtension): Added. Returns a new string with the last dot and everything after it
2494         removed.
2495         (sorted): Added sortFunction parameter.
2496         (Node.prototype.removeAllChildren): Added. Does what it says.
2497
2498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2499         (ViewController.prototype._displayBuilder): Updated for change to _domForRegressionRange.
2500         (ViewController.prototype._domForRegressionRange): Changed argument order to match
2501         _domForNewAndExistingBugs. Now takes the list of failing tests and uses it to figure out
2502         which revisions modified the failing tests and displays the suspect revisions in a list.
2503
2504 2011-06-30  Eric Seidel  <eric@webkit.org>
2505
2506         Reviewed by Adam Barth.
2507
2508         Rename should_kill_dump_render_tree to driver_needs_restart in preparation for supporting WebKitTestRunner
2509         https://bugs.webkit.org/show_bug.cgi?id=63743
2510
2511         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2512         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2513
2514 2011-06-30  Martin Robinson  <mrobinson@igalia.com>
2515
2516         Reviewed by Anders Carlsson.
2517
2518         [GTK] Crash observed with nspluginwrapper and flash
2519         https://bugs.webkit.org/show_bug.cgi?id=62249
2520
2521         Added a TestNetscapePlugin test which verifies that WebKit properly
2522         handles situations where InvalidateRect is called with a null instance.
2523
2524         * DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp: Added.
2525         (CallInvalidateRectWithNullNPPArgument::CallInvalidateRectWithNullNPPArgument):
2526         (CallInvalidateRectWithNullNPPArgument::NPP_New):
2527         * GNUmakefile.am: Add the new file to sources list.
2528
2529 2011-06-30  Eric Seidel  <eric@webkit.org>
2530
2531         Reviewed by Adam Barth.
2532
2533         Remove redundant tests in TestFailuresTest
2534         https://bugs.webkit.org/show_bug.cgi?id=63742
2535
2536         These tests are all already covered by TestFailuresTest.test_loads.
2537         I also added the missing "T" from TestFailuresest. :)
2538
2539         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2540
2541 2011-06-30  Adam Barth  <abarth@webkit.org>
2542
2543         Reviewed by Eric Seidel.
2544
2545         REGRESSION(r84294): new-run-webkit-tests results.html generate links to diffs.html or diff.png that don't exist
2546         https://bugs.webkit.org/show_bug.cgi?id=63494
2547
2548         This patch does two things:
2549
2550         1) Refactor diff_image to return the image diff instead of writing the
2551         diff to a file.  This fixes a bunch of hacks and disentangles a bunch
2552         of code.
2553
2554         2) When there's a checksum mismatch but not image diff, we no longer
2555         report an IMAGE failure to results.html.  That fixes the bug in
2556         question because results.html won't try to link to a non-existent image
2557         diff.
2558
2559         * Scripts/webkitpy/common/system/executive_mock.py:
2560         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2561         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2562         * Scripts/webkitpy/layout_tests/port/base.py:
2563         * Scripts/webkitpy/layout_tests/port/chromium.py:
2564         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2565         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2566         * Scripts/webkitpy/layout_tests/port/test.py:
2567         * Scripts/webkitpy/layout_tests/port/webkit.py:
2568         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2569         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2570
2571 2011-06-28  Hans Wennborg  <hans@chromium.org>
2572
2573         Reviewed by Tony Chang.
2574
2575         IndexedDB: Prepare for running layout tests with LevelDB
2576         https://bugs.webkit.org/show_bug.cgi?id=63593
2577
2578         The TestShell must always provide a temporary folder for LevelDB,
2579         not just when the backing store type is overridden.
2580
2581         * DumpRenderTree/chromium/LayoutTestController.cpp:
2582         (LayoutTestController::setOverrideIndexedDBBackingStore):
2583         (LayoutTestController::clearAllDatabases):
2584         * DumpRenderTree/chromium/LayoutTestController.h:
2585         * DumpRenderTree/chromium/TestShell.cpp:
2586         (TestShell::TestShell):
2587         * DumpRenderTree/chromium/TestShell.h:
2588
2589 2011-06-30  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2590
2591         Reviewed by Csaba Osztrogonác.
2592
2593         [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
2594         qt-wk2, win-wk2, mac-wk2 use this common Skipped list too
2595         https://bugs.webkit.org/show_bug.cgi?id=61785 
2596
2597         * Scripts/old-run-webkit-tests:
2598
2599 2011-06-30  Adam Roben  <aroben@apple.com>
2600
2601         Use a colon to separate test names from failure info on TestFailures
2602
2603         This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
2604         failure info itself includes parentheses.
2605
2606         Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
2607         double parentheses
2608
2609         Reviewed by Darin Adler.
2610
2611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2612         (ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
2613         info in parentheses.
2614
2615 2011-06-30  Adam Roben  <aroben@apple.com>
2616
2617         Robustify PersistentCache against cached data that contains the string ': '
2618
2619         Fixes <http://webkit.org/b/63721> Exceptions thrown while loading TestFailures page due to
2620         passing a bad string to JSON.parse
2621
2622         Reviewed by Darin Adler.
2623
2624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js:
2625         (PersistentCache._parseDateAndJSONFromString): Manually split the string on the separator
2626         using indexOf and substring. (String.prototype.split always splits on all instances of the
2627         separator.)
2628
2629 2011-06-30  Adam Roben  <aroben@apple.com>
2630
2631         Include the crashing symbol in crash logs links on TestFailures
2632
2633         Fixes <http://webkit.org/b/63465> Links to crash logs on TestFailures page should include
2634         the crashing symbol (like links in results.html do)
2635
2636         Reviewed by David Kilzer.
2637
2638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2639         (LayoutTestResultsLoader.prototype.start): Bumped the cache version because we now store
2640         crashing symbols for crashing tests. Renamed testsForResultTable to parseResultTable because
2641         it now returns more than just the test names. Specifically, it now looks for crash log links
2642         and extracts the crashing symbol name from them. Updated callers of parseResultTable to
2643         match its new behavior. Changed to store the crashing symbol along with the failure type in
2644         the data we pass to the callback for tests which crashed.
2645
2646         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2647         (code): Make <code> elements a little smaller because their contents can be quite long.
2648
2649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2650         (ViewController.prototype._domForFailureDiagnosis): Include the crashing symbol inside a
2651         <code> element in the link, if there is a crashing symbol.
2652
2653 2011-06-30  Adam Roben  <aroben@apple.com>
2654
2655         Use objects instead of strings to represent a test result in TestFailures code
2656
2657         This will eventually allow us to store more than just the type of failure for each test.
2658         (E.g., we can store the name of the crashing symbol for tests which crashed.)
2659
2660         Prep work for <http://webkit.org/b/63465> Links to crash logs on TestFailures page should
2661         include the crashing symbol (like links in results.html do)
2662
2663         Reviewed by David Kilzer.
2664
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2666         (Builder.prototype.failureDiagnosisTextAndURL): Changed to expect a testResult object
2667         instead of just a failureType string.
2668
2669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
2670         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Changed to store a
2671         testResult-like object for passing tests.
2672         (FlakyLayoutTestDetector.prototype.flakinessExamples): Changed to expect testResult-like
2673         objects.
2674
2675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2676         (LayoutTestResultsLoader.prototype.start): Store a version number along with the cached data
2677         so we can throw away cached data that's in an old format. Store a testResult object for each
2678         test instead of just its failure type.
2679
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2681         (ViewController.prototype._domForFailedTest):
2682         (ViewController.prototype._domForFailureDiagnosis):
2683         Changed to expect testResult objects instead of failureType strings.
2684
2685 2011-06-30  Adam Roben  <aroben@apple.com>
2686
2687         Show full commit logs when visiting Trac from TestFailures page
2688
2689         Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
2690         should show full commit logs
2691
2692         Reviewed by David Kilzer.
2693
2694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2695         (Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
2696         verbose=on to the log URL to tell Trac to show full commit logs.
2697
2698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2699         (ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.
2700
2701 2011-06-30  Adam Roben  <aroben@apple.com>
2702
2703         Add a link to file a bug about TestFailures to the TestFailures page
2704
2705         Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
2706         about TestFailures itself
2707
2708         Reviewed by Anders Carlsson.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2711         (aside): Added some styles for the new link. It is positioned in the upper-right and
2712         hopefully not to glaringly obvious.
2713
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2715         (ViewController.prototype.loaded): Set up our main content element and auxiliary UI.
2716
2717         (ViewController.prototype._displayBuilder):
2718         (ViewController.prototype._displayTesters):
2719         Modify the main content element instead of the entire body, as there are other things in the
2720         body that we want to preserve.
2721
2722         (ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
2723         that contains a link to file a bug about the TestFailures page.
2724
2725 2011-06-30  Adam Roben  <aroben@apple.com>
2726
2727         Ignore callbacks that correspond to old navigations of the TestFailures page
2728
2729         Fixes <http://webkit.org/b/63711> TestFailures page sometimes ignores back/forward
2730         navigations
2731
2732         Reviewed by Anders Carlsson.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
2735         (LayoutTestHistoryAnalyzer.prototype.start): Check the return value of the callback. If the
2736         callback returns false, stop fetching more data.
2737
2738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2739         (ViewController): Initialize new _navigationID member. This member is used to assign each
2740         navigation by the user a unique ID.
2741         (ViewController.prototype.parseHash): Increment the navigation ID.
2742
2743         (ViewController.prototype._displayBuilder):
2744         (ViewController.prototype._displayTesters):
2745         At the start of these functions, record the current navigation ID. Bail out from callbacks
2746         if the navigation ID has changed, indicating that the user has navigated elsewhere.
2747
2748 2011-06-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2749
2750         Reviewed by Martin Robinson.
2751
2752         [GTK] Add back/forward menu to MiniBrowser toolbar
2753         https://bugs.webkit.org/show_bug.cgi?id=63445
2754
2755         * MiniBrowser/gtk/BrowserWindow.c:
2756         (browser_window_init): Use a GtkMenuToolButton for navigation
2757         widgets.
2758         (browserWindowConstructed): Get the page BackForwardList.
2759         (browserWindowHistoryItemActivated): Go to activated history item.
2760         (browserWindowHistoryItemSelected): Show the url of currently
2761         selected history item in the statusbar.
2762         (createGtkActionFromBackForwardItem): Create a GtkAction from a
2763         WKBackForwardListItemRef.
2764         (browserWindowCreateMenuItemFromBackForwardItem): Create a
2765         GtkMenuItem from a WKBackForwardListItemRef.
2766         (browserWindowCreateBackForwardMenu): Create a GtkMenu with the
2767         given history items.
2768         (browserWindowUpdateNavigationActions): Update navigation widgets
2769         sensitivity and history menus.
2770         (didChangeBackForwardList): Call
2771         browserWindowUpdateNavigationActions().
2772         (browserWindowLoaderClientInit): Add didChangeBackForwardList
2773         callback.
2774
2775 2011-06-30  Dmitry Lomov  <dslomov@google.com>
2776
2777         Reviewed by Adam Roben.
2778
2779         https://bugs.webkit.org/show_bug.cgi?id=63660
2780         This enables unit-tests step on Windows and MacOS SnowLeopard.
2781
2782         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2783
2784 2011-06-30  Balazs Kelemen  <kbalazs@webkit.org>
2785
2786         Reviewed by Kenneth Rohde Christiansen.
2787
2788         [Qt][WK2] Implement the rest of WTR::PlatformWebView
2789         https://bugs.webkit.org/show_bug.cgi?id=63630
2790
2791         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2792         (WTR::PlatformWebView::windowFrame):
2793         (WTR::PlatformWebView::setWindowFrame):
2794
2795 2011-06-29  Dirk Pranke  <dpranke@chromium.org>
2796
2797         Reviewed by Adam Barth.
2798
2799         test-webkitpy is spamming lots of messages about updating test expectations
2800         https://bugs.webkit.org/show_bug.cgi?id=63680
2801
2802         This patch changes the passing_run() function to capture the
2803         output to stdout and stderr and assert that it is empty, and
2804         also specifies --no-new-test-results by default to avoid getting
2805         "generating baseline" messages for the expected-missing results.
2806
2807         Also check that we are logging messages when we generate new
2808         baselines.
2809
2810         Also fix a minor bug in the way test_tolerance() was
2811         checking for whether the tests were passing or not.
2812
2813         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2814
2815 2011-06-29  Yuta Kitamura  <yutak@chromium.org>
2816
2817         Reviewed by Kent Tamura.
2818
2819         DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController
2820         https://bugs.webkit.org/show_bug.cgi?id=63532
2821
2822         LayoutTestController::overridePreference() will be used to change the value of
2823         the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way,
2824         we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but
2825         at least we need to reset preference values in DumpRenderTree every time we start
2826         a new test because preference values changed in some test should not be leaked
2827         to the next test.
2828
2829         * DumpRenderTree/chromium/LayoutTestController.cpp:
2830         (LayoutTestController::overridePreference):
2831         The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h.
2832         * DumpRenderTree/chromium/WebPreferences.cpp:
2833         (WebPreferences::reset):
2834         Set the default value. This will be called from TestShell::resetTestController().
2835         (WebPreferences::applyTo):
2836         * DumpRenderTree/chromium/WebPreferences.h:
2837         * DumpRenderTree/mac/DumpRenderTree.mm:
2838         (resetDefaultsToConsistentValues): Set the default value.
2839         * DumpRenderTree/win/DumpRenderTree.cpp:
2840         (resetDefaultsToConsistentValues): Ditto.
2841
2842 2011-06-29  Kenichi Ishibashi  <bashi@chromium.org>
2843
2844         Reviewed by Adam Barth.
2845
2846         check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
2847         https://webkit.org/b/57360
2848
2849         Modify the regular expression to match https scheme.
2850
2851         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
2852         * Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
2853
2854 2011-06-29  Adam Barth  <abarth@webkit.org>
2855
2856         Reviewed by Eric Seidel.
2857
2858         new-run-webkit-tests: images page switch actual and expected images before they're loaded
2859         https://bugs.webkit.org/show_bug.cgi?id=63199
2860
2861         We now preload the images and keep the DOM nodes in memory instead of
2862         going back to the MemoryCache all the time.  (Also, remove some nutty
2863         </img> HTML.)
2864
2865         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2866
2867 2011-06-29  Adam Barth  <abarth@webkit.org>
2868
2869         Reviewed by Eric Seidel.
2870
2871         new-run-webkit-tests should tell you when it creates new expectations
2872         https://bugs.webkit.org/show_bug.cgi?id=63675
2873
2874         Unforunately, this patch creates a bunch of test-webkitpy spam because
2875         we don't understand how Python logging works well enough to stop the
2876         spam.  :(
2877
2878         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2879
2880 2011-06-29  Eric Seidel  <eric@webkit.org>
2881
2882         Reviewed by Adam Barth.
2883
2884         Refactor WebKitDriver.run_test into smaller pieces
2885         https://bugs.webkit.org/show_bug.cgi?id=63673
2886
2887         There is no functional change here.  Just moving code around.
2888         This is in preparation for adding support for #CRASHED and #CRASHED - WebProcess
2889
2890         * Scripts/webkitpy/layout_tests/port/webkit.py:
2891
2892 2011-06-29  Eric Seidel  <eric@webkit.org>
2893
2894         Reviewed by Adam Barth.
2895
2896         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
2897         https://bugs.webkit.org/show_bug.cgi?id=63501
2898
2899         Re-landing after fixing a bug in WebKitPort.baseline_search_path which broke
2900         the rebaselineserver unit tests.  Also fixed nits brought up by Dirk after previous landing.
2901
2902         The goal was to add support for wk2 skipped lists.
2903         However, I found that our skipped list computation was a
2904         manual hack (which only worked for the mac port).
2905
2906         So I fixed a FIXME to move the skipped list finding
2907         into WebKitPort instead of MacPort.
2908         Doing so required the concept of a "port_name", since previously
2909         the only name accessible from a port object was name()
2910         which includes many things beyond "mac" or "chromium", etc.
2911
2912         Eventually I believe we'll want to re-think the way that we pass
2913         in a port_name argument to Port subclasses and expect them to parse
2914         it.  But for now I just added a cls.port_name variable which contains
2915         the static information needed to compute wk2 names as well as
2916         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
2917
2918         In order to test my new _skipped_file_search_paths method, I
2919         fixed another FIXME by making it return relative paths.
2920
2921         I also fixed the test_expectations_path code in WebKitPort to use port_name.
2922         It was using name() which would return PORT-VERSION so MacPort was overriding
2923         it to use just PORT.  After fixing test_expectations_path to use port_name
2924         (and making it aware of webkit2) I was able to remove the MacPort implementation.
2925
2926         * Scripts/webkitpy/layout_tests/port/base.py:
2927          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
2928          - Document that real_name() seems to have no purpose.
2929         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2930          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
2931         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2932          - Add _parse_port_name.
2933         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2934          - Add _parse_port_name.
2935         * Scripts/webkitpy/layout_tests/port/gtk.py:
2936         * Scripts/webkitpy/layout_tests/port/mac.py:
2937          - Move Skipped-file finding code down to WebKitPort
2938         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2939         * Scripts/webkitpy/layout_tests/port/qt.py:
2940         * Scripts/webkitpy/layout_tests/port/webkit.py:
2941         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2942
2943 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2944
2945         Unreviewed, rolling out r90070.
2946         http://trac.webkit.org/changeset/90070
2947         https://bugs.webkit.org/show_bug.cgi?id=63676
2948
2949         Broke test-webkitpy rebaseline tests (Requested by eseidel2 on
2950         #webkit).
2951
2952         * Scripts/webkitpy/layout_tests/port/base.py:
2953         * Scripts/webkitpy/layout_tests/port/chromium.py:
2954         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2955         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2956         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2957         * Scripts/webkitpy/layout_tests/port/gtk.py:
2958         * Scripts/webkitpy/layout_tests/port/mac.py:
2959         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2960         * Scripts/webkitpy/layout_tests/port/qt.py:
2961         * Scripts/webkitpy/layout_tests/port/webkit.py:
2962         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2963         * Scripts/webkitpy/layout_tests/port/win.py:
2964         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2965
2966 2011-06-29  Adam Barth  <abarth@webkit.org>
2967
2968         Reviewed by Eric Seidel.
2969
2970         new-run-webkit-tests doesn't support sample-on-timeout
2971         https://bugs.webkit.org/show_bug.cgi?id=56731
2972
2973         * Scripts/webkitpy/layout_tests/port/server_process.py:
2974         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2976
2977 2011-06-29  Eric Seidel  <eric@webkit.org>
2978
2979         Reviewed by Adam Barth.
2980
2981         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
2982         https://bugs.webkit.org/show_bug.cgi?id=63501
2983
2984         The goal was to add support for wk2 skipped lists.
2985         However, I found that our skipped list computation was a
2986         manual hack (which only worked for the mac port).
2987
2988         So I fixed a FIXME to move the skipped list finding
2989         into WebKitPort instead of MacPort.
2990         Doing so required the concept of a "port_name", since previously
2991         the only name accessible from a port object was name()
2992         which includes many things beyond "mac" or "chromium", etc.
2993
2994         Eventually I believe we'll want to re-think the way that we pass
2995         in a port_name argument to Port subclasses and expect them to parse
2996         it.  But for now I just added a cls.port_name variable which contains
2997         the static information needed to compute wk2 names as well as
2998         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
2999
3000         In order to test my new _skipped_file_search_paths method, I
3001         fixed another FIXME by making it return relative paths.
3002
3003         I also fixed the test_expectations_path code in WebKitPort to use port_name.
3004         It was using name() which would return PORT-VERSION so MacPort was overriding
3005         it to use just PORT.  After fixing test_expectations_path to use port_name
3006         (and making it aware of webkit2) I was able to remove the MacPort implementation.
3007
3008         * Scripts/webkitpy/layout_tests/port/base.py:
3009          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
3010          - Document that real_name() seems to have no purpose.
3011         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3012          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
3013         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3014          - Add _parse_port_name.
3015         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3016          - Add _parse_port_name.
3017         * Scripts/webkitpy/layout_tests/port/gtk.py:
3018         * Scripts/webkitpy/layout_tests/port/mac.py:
3019          - Move Skipped-file finding code down to WebKitPort
3020         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3021         * Scripts/webkitpy/layout_tests/port/qt.py:
3022         * Scripts/webkitpy/layout_tests/port/webkit.py:
3023         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3024
3025 2011-06-29  Adam Barth  <abarth@webkit.org>
3026
3027         Reviewed by Dirk Pranke.
3028
3029         new-run-webkit-tests complains about missing pixel results instead of plopping down new expectations
3030         https://bugs.webkit.org/show_bug.cgi?id=38063
3031
3032         This patch changes new-run-webkit-tests to match old-run-webkit-tests
3033         in generating new expected results when the expected results are
3034         missing.
3035
3036         There are still a couple details that are different:
3037
3038         1) Image baselines aren't generated unless you run with -p.
3039         2) Render tree dumps are places in the cross-platform directory instead
3040         of the platform-specific directory.
3041
3042         I'm inclined to deal with both of these issues in follow-up patches.
3043
3044         * Scripts/webkitpy/common/net/layouttestresults.py:
3045         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3046         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3047         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3048         * Scripts/webkitpy/layout_tests/port/test.py:
3049         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3050         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3051
3052 2011-06-29  Adam Roben  <aroben@apple.com>
3053
3054         Teach TestFailures to detect possibly flaky tests and list them separately
3055
3056         Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
3057         arbitrary revisions for breaking flaky tests
3058
3059         Reviewed by Dan Bates.
3060
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.
3062         (FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
3063         from various builds (in reverse-chronological order).
3064         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
3065         monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
3066         (FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
3067         given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
3068         and puts them in an array in reverse-chronological order.
3069         (FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
3070         to be possibly flaky.
3071
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
3073         (LayoutTestHistoryAnalyzer): Initialize new members.
3074         (LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
3075         properties: history and possiblyFlaky. history holds the data this function used to pass to
3076         the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
3077         flakiness. Updated documentation comment to match.
3078         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
3079         FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
3080         removed from the failure history, since when they started failing is no longer meaningful.
3081         We tell our caller to keep calling until all current failures have been explained and we've
3082         gone through 5 builds without any new flaky tests being identified.
3083
3084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
3085         (sorted): New helper function to return a sorted copy of an array.
3086         (Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
3087         that matches the predicate.
3088
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3090         (ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
3091         the analyzer. Now puts the list of possibly flaky tests after the failure history.
3092         (ViewController.prototype._domForFailedTest): Moved some code from here...
3093         (ViewController.prototype._domForFailureDiagnosis): ...to here.
3094         (ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
3095         possibly flaky tests and examples of their flakiness and returns it.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
3098         FlakyLayoutTestDetector.js.
3099
3100 2011-06-29  Eric Seidel  <eric@webkit.org>
3101
3102         Adam says cowboys don't review (or unit test).
3103
3104         * Scripts/webkitpy/tool/commands/download.py:
3105
3106 2011-06-29  Eric Seidel  <eric@webkit.org>
3107
3108         Reviewed by Adam Barth.
3109
3110         Make port/config.py mockable for easier unit testing
3111         https://bugs.webkit.org/show_bug.cgi?id=63661
3112
3113         Fix an exception from the unit tests.
3114
3115         * Scripts/webkitpy/layout_tests/port/config.py:
3116
3117 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
3118
3119         Unreviewed build correction.
3120
3121         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
3122         Link against zlib1.dll, not the static zlib.lib.
3123
3124 2011-06-29  Eric Seidel  <eric@webkit.org>
3125
3126         Reviewed by Adam Barth.
3127
3128         Make port/config.py mockable for easier unit testing
3129         https://bugs.webkit.org/show_bug.cgi?id=63661
3130
3131         Right now config.py leaks real system paths for
3132         webkit_base_dir due to using __file__.  This patch
3133         adds a filsystem.py wrapper around __file__ so that
3134         we don't have to jump through hoops in webkit_unittest.py
3135         to avoid leaking local paths to the unit test results.
3136
3137         There are probably many more places where we should now
3138         use filesystem.path_for_module, but starting with just this one.
3139
3140         * Scripts/webkitpy/common/system/filesystem.py:
3141         * Scripts/webkitpy/common/system/filesystem_mock.py:
3142         * Scripts/webkitpy/layout_tests/port/config.py:
3143         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3144         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3145
3146 2011-06-29  Eric Seidel  <eric@webkit.org>
3147
3148         Reviewed by Adam Barth.
3149
3150         Remove duplicate methods in filesystem.py
3151         https://bugs.webkit.org/show_bug.cgi?id=63658
3152
3153         Looks like there was a bad merge at some point.
3154
3155         I also removed a bunch of redundant docstrings.
3156
3157         * Scripts/webkitpy/common/system/filesystem.py:
3158
3159 2011-06-29  Adam Barth  <abarth@webkit.org>
3160
3161         Reviewed by Eric Seidel.
3162
3163         Pass --no-new-test-results to NRWT on build.webkit.org
3164         https://bugs.webkit.org/show_bug.cgi?id=63653
3165
3166         This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.
3167
3168         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3169
3170 2011-06-29  Xan Lopez  <xlopez@igalia.com>
3171
3172         Reviewed by Adam Barth.
3173
3174         [GTK] overlapping drag&drop tests fail on NRWT
3175         https://bugs.webkit.org/show_bug.cgi?id=57640
3176
3177         Make a GTK test driver that spawns one Xvfb instance per
3178         thread. This avoids bad interactions in DnD tests between threads.
3179
3180         * Scripts/webkitpy/layout_tests/port/gtk.py:
3181
3182 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3183
3184         Unreviewed, rolling out r89888.
3185         http://trac.webkit.org/changeset/89888
3186         https://bugs.webkit.org/show_bug.cgi?id=63609
3187
3188          "Seems to be causing merging issues on the dashboard, e.g.
3189         http://test-
3190         results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
3191         (Requested by aboxhall on #webkit).
3192
3193         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3194         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3195         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3196
3197 2011-06-29  Philippe Normand  <pnormand@igalia.com>
3198
3199         Reviewed by Martin Robinson.
3200
3201         [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
3202         https://bugs.webkit.org/show_bug.cgi?id=63624
3203
3204         * Scripts/webkitpy/common/system/executive.py: In some cases the
3205         ps output lines can contain one or more leading white-spaces, so
3206         strip it before splitting the pid and command name.
3207
3208 2011-06-29  Noel Gordon  <noel.gordon@gmail.com>
3209
3210         Reviewed by Kent Tamura.
3211
3212         [Chromium] [DRT] ImageDiff should compile in VS2010
3213         https://bugs.webkit.org/show_bug.cgi?id=63614
3214
3215         * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
3216
3217 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
3218
3219         Reviewed by Kenneth Rohde Christiansen.
3220
3221         [Qt] DRT support for setInteractiveFormValidationEnabled
3222         https://bugs.webkit.org/show_bug.cgi?id=63496
3223
3224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3225         (WebCore::DumpRenderTree::DumpRenderTree):
3226
3227 2011-06-28  Eric Seidel  <eric@webkit.org>
3228
3229         Reviewed by Adam Barth.
3230
3231         Make new-run-webkit-tests -2 actually use WebKitTestRunner
3232         https://bugs.webkit.org/show_bug.cgi?id=63572
3233
3234         new-run-webkit-tests -2 works with this change.  However a zillion
3235         tests fail since it can't find the right skipped lists for wk2.
3236         The Skipped-list fixing is covered in bug 63501.
3237
3238         * Scripts/webkitpy/layout_tests/port/gtk.py:
3239         * Scripts/webkitpy/layout_tests/port/qt.py:
3240         * Scripts/webkitpy/layout_tests/port/webkit.py:
3241
3242 2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3243
3244         Reviewed by Adam Roben.
3245
3246         Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
3247         https://bugs.webkit.org/show_bug.cgi?id=63500
3248
3249         Added google-mac-3 and google-mac-4.
3250
3251         * BuildSlaveSupport/build.webkit.org-config/config.json:
3252
3253 2011-06-28  Eric Seidel  <eric@webkit.org>
3254
3255         Reviewed by Dirk Pranke.
3256
3257         Remove webkitpy's tiger support now that WebKit no longer supports tiger
3258         https://bugs.webkit.org/show_bug.cgi?id=63568
3259
3260         I don't think our support actually fully worked anyway.  Regardless
3261         tiger is dead now (thankfully)!
3262
3263         I also unwrapped some short lines and added a couple FIXMEs while
3264         touring the code.
3265
3266         No new tests, only removing old ones which tested our Tiger support.
3267
3268         * Scripts/webkitpy/layout_tests/port/base.py:
3269         * Scripts/webkitpy/layout_tests/port/builders.py:
3270         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3271         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3272         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3273         * Scripts/webkitpy/layout_tests/port/mac.py:
3274         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3275         * Scripts/webkitpy/tool/commands/rebaseline.py:
3276         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3277
3278 2011-06-28  Eric Seidel  <eric@webkit.org>
3279
3280         Unreviewed, just fixing a typo.
3281
3282         Fix misspellings of "thead" to "thread".
3283
3284         * Scripts/webkitpy/common/checkout/scm/git.py:
3285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3286
3287 2011-06-28  Eric Seidel  <eric@webkit.org>
3288
3289         Reviewed by Tony Chang.
3290
3291         new-run-webkit-tests needs a --webkit-test-runner option
3292         https://bugs.webkit.org/show_bug.cgi?id=63439
3293
3294         This was accidentally fixed in bug 63501 as well.
3295         The root problem here was that the webkit unit tests were not using
3296         enough mocks.  I've fixed them here to use more mocks
3297         which should unbreak windows.
3298
3299         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3300
3301 2011-06-28  Eric Seidel  <eric@webkit.org>
3302
3303         Reviewed by Tony Chang.
3304
3305         new-run-webkit-tests should not run mthml tests when MHTML support is disabled
3306         https://bugs.webkit.org/show_bug.cgi?id=63549
3307
3308         This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
3309         I happen to go looking for what code was deciding that .mht was a supported
3310         extension, found test_files.py and then removed some redundant doc-strings and
3311         if branching.
3312
3313         * Scripts/webkitpy/layout_tests/port/test_files.py:
3314         * Scripts/webkitpy/layout_tests/port/webkit.py:
3315         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3316
3317 2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>
3318
3319         Reviewed by Tony Chang.
3320
3321         Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
3322         https://bugs.webkit.org/show_bug.cgi?id=63514
3323
3324         - change write_text_file to write_binary_file
3325         - check that text_path and binary_path are actually existant files
3326         - change cleanup block from 'except' to 'finally'
3327
3328         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3329
3330 2011-06-28  Adam Roben  <aroben@apple.com>
3331
3332         Roll out r89924 and r89925
3333
3334         I didn't mean to commit them!
3335
3336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
3337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
3338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3339
3340 2011-06-27  Adam Barth  <abarth@webkit.org>
3341
3342         Reviewed by Eric Seidel.
3343
3344         NRWT should wait for ReportCrash
3345         https://bugs.webkit.org/show_bug.cgi?id=63495
3346
3347         When a test crashes on Mac, ReportCrash confuses us into thinking the
3348         test times out.
3349
3350         I'm not sure how to test this in a meaningful way in our current test
3351         harness...
3352
3353         * Scripts/webkitpy/common/system/crashlogs.py:
3354         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3355         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3356         * Scripts/webkitpy/layout_tests/port/base.py:
3357         * Scripts/webkitpy/layout_tests/port/mac.py:
3358         * Scripts/webkitpy/layout_tests/port/server_process.py:
3359         * Scripts/webkitpy/tool/commands/queries.py:
3360
3361 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3362
3363         Unreviewed, rolling out r89881.
3364         http://trac.webkit.org/changeset/89881
3365         https://bugs.webkit.org/show_bug.cgi?id=63513
3366
3367         Makes Qt massively slow (Requested by abarth on #webkit).
3368
3369         * Scripts/webkitpy/common/system/crashlogs.py:
3370         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3371         * Scripts/webkitpy/common/system/executive.py:
3372         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3373         * Scripts/webkitpy/layout_tests/port/base.py:
3374         * Scripts/webkitpy/layout_tests/port/mac.py:
3375         * Scripts/webkitpy/layout_tests/port/server_process.py:
3376         * Scripts/webkitpy/tool/commands/queries.py:
3377
3378 2011-06-27  Alice Boxhall  <aboxhall@chromium.org>
3379
3380         Reviewed by Ojan Vafai.
3381
3382         Convert json_results_generator.py to output version 4 JSON.
3383         https://bugs.webkit.org/show_bug.cgi?id=60869
3384
3385         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3386         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3387         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3388
3389 2011-06-27  Adam Barth  <abarth@webkit.org>
3390
3391         Reviewed by Eric Seidel.
3392
3393         NRWT should wait for ReportCrash
3394         https://bugs.webkit.org/show_bug.cgi?id=63495
3395
3396         When a test crashes on Mac, ReportCrash confuses us into thinking the
3397         test times out.
3398
3399         I'm not sure how to test this in a meaningful way in our current test
3400         harness...
3401
3402         * Scripts/webkitpy/common/system/crashlogs.py:
3403         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3404         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3405         * Scripts/webkitpy/layout_tests/port/base.py:
3406         * Scripts/webkitpy/layout_tests/port/mac.py:
3407         * Scripts/webkitpy/layout_tests/port/server_process.py:
3408         * Scripts/webkitpy/tool/commands/queries.py:
3409
3410 2011-06-27  Adam Barth  <abarth@webkit.org>
3411
3412         Reviewed by Eric Seidel.
3413
3414         new-run-webkit-tests should upload crash logs
3415         https://bugs.webkit.org/show_bug.cgi?id=55907
3416
3417         NRWT used to have a different name for crash logs.  I've changed the
3418         name to patch ORWT.
3419
3420         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3421         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3422
3423 2011-06-27  Eric Seidel  <eric@webkit.org>
3424
3425         Reviewed by Adam Barth.
3426
3427         new-run-webkit-tests needs a --webkit-test-runner option
3428         https://bugs.webkit.org/show_bug.cgi?id=63439
3429
3430         NRWT doesn't actually know how to run with the WebKitTestRunner yet
3431         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
3432
3433         There is a bunch of other little cleanup in this patch which I added as I
3434         took a tour through all of our hard-coded DumpRenderTree strings.
3435
3436         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
3437         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
3438         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
3439         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
3440         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
3441         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
3442         * Scripts/webkitpy/layout_tests/port/config.py:
3443          - build_dumprendertree had no business in this class, removed it.
3444          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
3445          - Exposed _script_path as script_path() (this probably belongs elsewhere).
3446         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3447          - Moved these tests to webkit_unittests.
3448         * Scripts/webkitpy/layout_tests/port/webkit.py:
3449          - Now respects the --webkit-test-runner option.
3450          - setup_test_run is empty in base.py too, no need to override it.
3451         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3452          - Test the new hotness.
3453          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
3454            I think this code is still hitting disk during the unit tests. :(
3455         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3456          - Add the option.
3457         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3458          - Remove optional args option.
3459         * Scripts/webkitpy/tool/commands/commandtest.py:
3460          - Remove optional args option.
3461         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3462          - Remove optional args option.
3463
3464 2011-06-27  Adam Barth  <abarth@webkit.org>
3465
3466         Reviewed by Dirk Pranke.
3467
3468         new-run-webkit-tests does not report stderr output
3469         https://bugs.webkit.org/show_bug.cgi?id=37739
3470
3471         Almost all the infrastructure appears to be in place to report stderr
3472         in results.html.  We just need to wire up a bool to tell results.html
3473         to create the hyperlink.
3474
3475         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3476         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3477         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3478         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3479         * Scripts/webkitpy/layout_tests/port/base.py:
3480
3481 2011-06-27  Adam Barth  <abarth@webkit.org>
3482
3483         Reviewed by Dirk Pranke.
3484
3485         webkitpy unit tests should have more descriptive names than just "Test"
3486         https://bugs.webkit.org/show_bug.cgi?id=63479
3487
3488         Luckily we kept these classes in separate namespaces in the harness so
3489         we were actually running them all even though they had the same name.
3490
3491         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
3492         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3493         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3494
3495 2011-06-27  Greg Simon  <gregsimon@chromium.org>
3496
3497         No review necessary.
3498
3499         Add email addr to contributor list
3500         https://bugs.webkit.org/show_bug.cgi?id=63478
3501
3502         * Scripts/webkitpy/common/config/committers.py:
3503
3504 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3505
3506         Unreviewed, rolling out r89834.
3507         http://trac.webkit.org/changeset/89834
3508         https://bugs.webkit.org/show_bug.cgi?id=63476
3509
3510         Broke test-webkitpy (Requested by abarth on #webkit).
3511
3512         * Scripts/webkitpy/common/net/layouttestresults.py:
3513         * Scripts/webkitpy/common/system/outputcapture.py:
3514         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3515         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3516         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3517         * Scripts/webkitpy/layout_tests/port/base.py:
3518         * Scripts/webkitpy/layout_tests/port/config.py:
3519         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3520         * Scripts/webkitpy/layout_tests/port/webkit.py:
3521         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3522         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3523         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3524         * Scripts/webkitpy/tool/commands/commandtest.py:
3525         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3526
3527 2011-06-27  Jeff Miller  <jeffm@apple.com>
3528
3529         Reviewed by Adam Roben.
3530
3531         Stop copying obsolete WebKit libraries on Windows
3532         https://bugs.webkit.org/show_bug.cgi?id=63474
3533         
3534         Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
3535
3536         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3537         * MiniBrowser/MiniBrowserPostBuild.cmd:
3538         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3539
3540 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
3541
3542         Add Wyatt Carss to the list of non-committer contributors.
3543
3544         * Scripts/webkitpy/common/config/committers.py:
3545
3546 2011-06-27  Adam Barth  <abarth@webkit.org>
3547
3548         Reviewed by Eric Seidel.
3549
3550         webkitpy should understand crash logs
3551         https://bugs.webkit.org/show_bug.cgi?id=63468
3552
3553         We're planning to use this functionality to upload crash logs along
3554         with test results for new-run-webkit-tests.
3555
3556         * Scripts/webkitpy/common/system/crashlog.py: Added.
3557         * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
3558         * Scripts/webkitpy/common/system/executive.py:
3559         * Scripts/webkitpy/common/system/executive_unittest.py:
3560         * Scripts/webkitpy/common/system/filesystem.py:
3561         * Scripts/webkitpy/common/system/filesystem_mock.py:
3562         * Scripts/webkitpy/tool/commands/queries.py:
3563
3564 2011-06-27  Adam Roben  <aroben@apple.com>
3565
3566         Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many
3567         failures
3568
3569         Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
3570         old-run-webkit-tests exited early after reload
3571
3572         Reviewed by Anders Carlsson.
3573
3574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
3575         (LayoutTe