Use iPhone SE as the default simulated device
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
2
3         Use iPhone SE as the default simulated device
4         https://bugs.webkit.org/show_bug.cgi?id=188227
5
6         Reviewed by Aakash Jain.
7
8         * Scripts/webkitpy/port/ios_simulator.py:
9         (IOSSimulatorPort):
10
11 2018-08-01  Commit Queue  <commit-queue@webkit.org>
12
13         Unreviewed, rolling out r234443 and r234445.
14         https://bugs.webkit.org/show_bug.cgi?id=188224
15
16         Revision caused 3 api failures across all platforms.
17         (Requested by Truitt on #webkit).
18
19         Reverted changesets:
20
21         "Add configuration for automatic process pre-warming"
22         https://bugs.webkit.org/show_bug.cgi?id=187108
23         https://trac.webkit.org/changeset/234443
24
25         "Add configuration for automatic process pre-warming"
26         https://bugs.webkit.org/show_bug.cgi?id=187108
27         https://trac.webkit.org/changeset/234445
28
29 2018-07-31  Ben Richards  <benton_richards@apple.com>
30
31         Add configuration for automatic process pre-warming
32         https://bugs.webkit.org/show_bug.cgi?id=187108
33
34         Reviewed by Ryosuke Niwa.
35
36         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
37
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
40         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
41         (TEST):
42
43 2018-07-31  John Wilander  <wilander@apple.com>
44
45         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
46         https://bugs.webkit.org/show_bug.cgi?id=188109
47         <rdar://problem/42664391>
48
49         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
50
51         This patch removes cookie partitioning which reduces the model to just
52         blocked cookies (in third-party contexts) and first-party cookie access.
53
54         Several of the changes are renaming to reflect that there are no more
55         cookie partitions.
56
57         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
58            Removed or renamed functions to reflect that there are no more
59            partitioned cookies.
60         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
61         (WTR::InjectedBundle::didReceiveMessageToPage):
62         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
63         (WTR::TestRunner::statisticsUpdateCookieBlocking):
64         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
65         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
66         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
67         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
68         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
69         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
70         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
71         * WebKitTestRunner/InjectedBundle/TestRunner.h:
72         * WebKitTestRunner/TestController.cpp:
73         (WTR::TestController::statisticsUpdateCookieBlocking):
74         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
75         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
76         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
77         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
78         * WebKitTestRunner/TestController.h:
79         * WebKitTestRunner/TestInvocation.cpp:
80         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
81         (WTR::TestInvocation::didSetBlockCookiesForHost):
82         (WTR::TestInvocation::didSetHasHadUserInteraction):
83         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
84         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
85         * WebKitTestRunner/TestInvocation.h:
86         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
87         (WTR::initializeWebViewConfiguration):
88
89 2018-07-31  Alex Christensen  <achristensen@webkit.org>
90
91         Build fix.  Remove unused variable.
92
93         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
94         (TestWebKitAPI::TEST):
95         transform was never used. It was introduced in r205871
96         Apparently I'm the first one to build in a certain configuration that found it.
97
98 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
99
100         server_process.py should print returncode in debug log if the process crashed
101         https://bugs.webkit.org/show_bug.cgi?id=188160
102
103         Reviewed by Konstantin Tokarev.
104
105         * Scripts/webkitpy/port/server_process.py:
106         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
107
108 2018-07-31  Tomas Popela  <tpopela@redhat.com>
109
110         [WTF] String::formatWithArguments() is unused
111         https://bugs.webkit.org/show_bug.cgi?id=187955
112
113         Reviewed by Darin Adler.
114
115         Remove tests for WTF::String::formatWithArguments() as it's unused and
116         we are removing it.
117
118         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
119
120 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
121
122         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
123
124         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
125         other builders.
126
127 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
128
129         [ews-build] Add support for API tests in OpenSource EWS
130         https://bugs.webkit.org/show_bug.cgi?id=188156
131
132         Reviewed by Lucas Forschler.
133
134         * BuildSlaveSupport/ews-build/config.json:
135         * BuildSlaveSupport/ews-build/factories.py:
136         (BuildFactory.__init__): Added triggers parameter.
137         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
138         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
139         (APITestsFactory): Factory for running API tests.
140         * BuildSlaveSupport/ews-build/steps.py:
141         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
142         source of the property.
143
144 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
145
146         [ews-build] loadConfig should ensure that the triggers are valid
147         https://bugs.webkit.org/show_bug.cgi?id=188134
148
149         Reviewed by Lucas Forschler.
150
151         * BuildSlaveSupport/ews-build/loadConfig.py:
152         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
153         (checkValidSchedulers): Ensures that the scheduler is not un-used.
154         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
155
156 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
157
158         Unreviewed, fix typo in test expectations and mark another test as timing out
159
160         * TestWebKitAPI/glib/TestExpectations.json:
161
162 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
163
164         More unreviewed GTK test gardening
165
166         * TestWebKitAPI/glib/TestExpectations.json:
167
168 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
169
170         Be more conservative with compositing layer creation when memory is low
171         https://bugs.webkit.org/show_bug.cgi?id=187866
172         rdar://problem/42366345
173
174         Reviewed by Zalan Bujtas.
175         
176         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
177         compositing layers. We avoid compositing for these situations:
178         1. Layers with 3D transforms which are affine (like translateZ(0)).
179         2. Layers with will-change
180         3. Layers for canvases (other than WebGL/WebGPU)
181         
182         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
183         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
184         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
185         
186         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
187         flakily falling into a different mode, and so that we can impose the conservative
188         mode for testing.
189
190         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
191         (WTR::InjectedBundlePage::prepare):
192
193 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
194
195         Unreviewed GTK test gardening
196
197         * TestWebKitAPI/glib/TestExpectations.json:
198
199 2018-07-27  Alex Christensen  <achristensen@webkit.org>
200
201         Fix API tests after r234314
202         https://bugs.webkit.org/show_bug.cgi?id=188077
203
204         Make API tests use new delegate method.
205
206         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
207         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
208         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
209
210 2018-07-27  Alex Christensen  <achristensen@webkit.org>
211
212         Fix API tests after r234314
213         https://bugs.webkit.org/show_bug.cgi?id=188077
214
215         Make API tests use new delegate method.
216
217         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
218         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
219         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
220         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
221         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
222         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
223         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
224         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
225         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
226         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
227         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
228
229 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
230
231         [INTL] Remove INTL sub-feature compile flags
232         https://bugs.webkit.org/show_bug.cgi?id=188081
233
234         Reviewed by Michael Catanzaro.
235
236         * Scripts/webkitperl/FeatureList.pm:
237         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
238
239 2018-07-26  Chris Dumez  <cdumez@apple.com>
240
241         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
242         https://bugs.webkit.org/show_bug.cgi?id=188078
243         <rdar://problem/42562493>
244
245         Reviewed by Geoff Garen.
246
247         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
248         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
249
250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
251         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
252         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
253         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
254         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
255         (TEST):
256
257 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
258
259         Add Aaron Chu as a committer to contributors.json
260         https://bugs.webkit.org/show_bug.cgi?id=188066
261
262         Unreviwed. Added myself as committer.
263
264         * Scripts/webkitpy/common/config/contributors.json:
265
266 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
267
268         [ews-build] Add build step to run API Tests
269         https://bugs.webkit.org/show_bug.cgi?id=188079
270
271         Reviewed by Lucas Forschler.
272
273         * BuildSlaveSupport/ews-build/steps.py:
274         (TestWithFailureCount): Common class for various tests with failure count.
275         (TestWithFailureCount.start): Configure Buildbot's logobserver.
276         (TestWithFailureCount.commandComplete): Updates the failure count.
277         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
278         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
279         (RunAPITests): Build step to run API tests.
280         (RunAPITests.countFailures): Count the failures by parsing the output.
281         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
282
283 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
284
285         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
286         https://bugs.webkit.org/show_bug.cgi?id=187963
287
288         Reviewed by Alex Christensen.
289
290         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
291         Add tests for String::split and String::splitAllowingEmptyEntries.
292
293         * TestWebKitAPI/Tests/WTF/StringView.cpp:
294         * WebKitTestRunner/TestController.cpp:
295         (WTR::updateTestOptionsFromTestHeader):
296         Update split/splitAllowingEmptyEntries usage.
297
298 2018-07-26  Commit Queue  <commit-queue@webkit.org>
299
300         Unreviewed, rolling out r234181 and r234189.
301         https://bugs.webkit.org/show_bug.cgi?id=188075
302
303         These are not needed right now (Requested by thorton on
304         #webkit).
305
306         Reverted changesets:
307
308         "Enable Web Content Filtering on watchOS"
309         https://bugs.webkit.org/show_bug.cgi?id=187979
310         https://trac.webkit.org/changeset/234181
311
312         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
313         https://bugs.webkit.org/show_bug.cgi?id=187985
314         https://trac.webkit.org/changeset/234189
315
316 2018-07-04  Darin Adler  <darin@apple.com>
317
318         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
319         https://bugs.webkit.org/show_bug.cgi?id=187333
320
321         Reviewed by Sam Weinig.
322
323         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
324         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
325         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
326         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
327         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
328
329 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
332         https://bugs.webkit.org/show_bug.cgi?id=188031
333
334         Reviewed by Lucas Forschler.
335
336         * BuildSlaveSupport/ews-build/steps.py:
337         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
338         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
339         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
340
341 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
342
343         [ews-build] Add build step UploadBuiltProduct
344         https://bugs.webkit.org/show_bug.cgi?id=188016
345
346         Reviewed by Lucas Forschler.
347
348         * BuildSlaveSupport/ews-build/steps.py:
349         (UploadBuiltProduct): Added build step UploadBuiltProduct.
350         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
351
352 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
353
354         [ews-build] Add build step ArchiveBuiltProduct
355         https://bugs.webkit.org/show_bug.cgi?id=188014
356
357         Reviewed by Lucas Forschler.
358
359         * BuildSlaveSupport/ews-build/steps.py:
360         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
361         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
362
363 2018-07-25  Chris Dumez  <cdumez@apple.com>
364
365         navigator.userAgent may return outdated value after webView.customUserAgent is set
366         https://bugs.webkit.org/show_bug.cgi?id=188009
367         <rdar://problem/42566456>
368
369         Reviewed by Alex Christensen.
370
371         Add API test coverage.
372
373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
374         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
375         (TEST):
376
377 2018-07-25  Charlie Turner  <cturner@igalia.com>
378
379         [Flatpak] Pass more environment variables to sandbox
380         https://bugs.webkit.org/show_bug.cgi?id=188002
381
382         Reviewed by Michael Catanzaro.
383
384         * flatpak/flatpakutils.py:
385         (WebkitFlatpak.run_in_sandbox):
386
387 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
388
389         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
390         https://bugs.webkit.org/show_bug.cgi?id=187997
391
392         Reviewed by Carlos Garcia Campos.
393
394         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
395         the EGL-oriented API that simply serves EGLImageKHR objects instead of
396         raw buffer resources. This allows us not to wrangle with creating and
397         managing lifetime of the same EGLImageKHR by ourselves.
398
399         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
400         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
401         the exportable object. This means that for each frame we're served an
402         EGLImageKHR object that is passed on to the displayBuffer()
403         implementation.
404
405         HeadlessViewBackend now just manages the pending and committed image
406         objects. Width and height values used during pixel data retrieval are
407         gathered from the ViewBackend's size that was specified when
408         constructed.
409
410         WindowViewBackend similarly only manages the committed image object,
411         not having to create an equivalent EGLImageKHR object from the raw
412         buffer resource anymore.
413
414         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
415         classes are removed, and destructors for both classes are made virtual.
416
417         The WPEBackend-fdo version is bumped in order to have the EGL-specific
418         export API available.
419
420         * flatpak/org.webkit.WPE.yaml:
421         * wpe/backends/HeadlessViewBackend.cpp:
422         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
423         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
424         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
425         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
426         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
427         * wpe/backends/HeadlessViewBackend.h:
428         * wpe/backends/ViewBackend.cpp:
429         (WPEToolingBackends::ViewBackend::initialize):
430         * wpe/backends/ViewBackend.h:
431         * wpe/backends/WindowViewBackend.cpp:
432         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
433         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
434         (WPEToolingBackends::WindowViewBackend::displayBuffer):
435         * wpe/backends/WindowViewBackend.h:
436         * wpe/jhbuild.modules:
437
438 2018-07-24  Thomas Denney  <tdenney@apple.com>
439
440         Remove support for the double type from WHLSL
441         https://bugs.webkit.org/show_bug.cgi?id=187977
442
443         Reviewed by Myles C. Maxfield.
444
445         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
446         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
447         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
448         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
449         * WebGPUShadingLanguageRI/Parse.js:
450         (parseTerm): Removed parsing of double literals.
451         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
452         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
453         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
454         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
455         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
456         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
457
458 2018-07-24  Tim Horton  <timothy_horton@apple.com>
459
460         Enable Web Content Filtering on watchOS
461         https://bugs.webkit.org/show_bug.cgi?id=187979
462         <rdar://problem/42559346>
463
464         Reviewed by Wenson Hsieh.
465
466         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
467
468 2018-07-24  Daniel Bates  <dabates@apple.com>
469
470         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
471         https://bugs.webkit.org/show_bug.cgi?id=187971
472
473         Reviewed by Saam Barati.
474
475         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
476         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
477         data type.
478
479         * TestWebKitAPI/CMakeLists.txt:
480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
481         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
482         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
483         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
484         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
485         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
486         (TestWebKitAPI::TEST):
487         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
488         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
489         (TestWebKitAPI::TEST):
490
491 2018-07-24  Thomas Denney  <tdenney@apple.com>
492         Minor changes to the WHLSL interpreter to support the new compiler
493         https://bugs.webkit.org/show_bug.cgi?id=187728
494
495         Reviewed by Myles C. Maxfield.
496
497         This bug contains small changes that are make minor changes to the
498         behaviour of the existing interpreter (the tests are unaffected and all
499         still pass).
500
501         * WebGPUShadingLanguageRI/EnumType.js:
502         (EnumType.prototype.get isEnum): Property added to EnumType and Type
503         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
504         * WebGPUShadingLanguageRI/Func.js:
505         (Func.prototype.get isEntryPoint): Add boolean property
506         * WebGPUShadingLanguageRI/FuncInstantiator.js:
507         (FuncInstantiator.prototype.get instances): Public accessor for existing
508         private field
509         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
510         that it directly wraps a Func instance (therefore the only interface
511         change is to the constructor and the addition of the func accessor).
512         This change allows the de-inlining of functions.
513         (FunctionLikeBlock):
514         (FunctionLikeBlock.prototype.get func):
515         (FunctionLikeBlock.prototype.get returnType):
516         (FunctionLikeBlock.prototype.get parameters):
517         (FunctionLikeBlock.prototype.get body):
518         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
519         constructor
520         (Inliner.prototype.visitCallExpression):
521         (Inliner):
522         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
523         to native functions (with additional support in StandardLibrary.js).
524         This reduces first-time compile-time from around 4s to around 0.1s.
525         (Intrinsics):
526         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
527         comments completes correctly
528         (Lexer.prototype.next):
529         (Lexer):
530         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
531         property, which is based on the type of the lValue and the semantics of
532         the language (the @ operator yields an array reference with the thread
533         scope).
534         (MakeArrayRefExpression):
535         (MakeArrayRefExpression.prototype.get type):
536         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
537         implementationData to support swizzle operator change
538         (NativeFunc.prototype.get implementationData):
539         (NativeFunc.prototype.set implementationData):
540         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
541         constructor
542         (Rewriter.prototype.visitFunctionLikeBlock):
543         * WebGPUShadingLanguageRI/StandardLibrary.js:
544         (_generateSwizzle): Deleted.
545         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
546         carrying metadata about swizzle operators so that they are implemented
547         as native functions rather than generated at compile time.
548         (SwizzleOp):
549         (SwizzleOp.prototype.get outSize):
550         (SwizzleOp.prototype.get components):
551         (SwizzleOp.prototype.get inSize):
552         (SwizzleOp.prototype.toString):
553         (SwizzleOp.allSwizzleOperators.):
554         (SwizzleOp.allSwizzleOperators):
555         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
556         (SwizzleOp.prototype.get outSize):
557         (SwizzleOp.prototype.get components):
558         (SwizzleOp.prototype.get inSize):
559         (SwizzleOp.prototype.toString):
560         (generateSwizzles):
561         (_generateSwizzle): Deleted.
562         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
563         above.
564         (Type.prototype.get isEnum):
565
566 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
567
568         Unreviewed, rolling out r234121.
569
570         Caused perf test failures.
571
572         Reverted changeset:
573
574         "We should cache the compiled sandbox profile in a data vault"
575         https://bugs.webkit.org/show_bug.cgi?id=184991
576         https://trac.webkit.org/changeset/234121
577
578 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
579
580         [Flatpak] Add openh264 as needed by WebRTC
581         https://bugs.webkit.org/show_bug.cgi?id=187956
582
583         Reviewed by Philippe Normand.
584
585         * flatpak/org.webkit.WebKit.yaml:
586
587 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
588
589         WebCore::URL::hostIsIPAddress needs a Windows implementation
590         https://bugs.webkit.org/show_bug.cgi?id=187859
591
592         Reviewed by Fujii Hironori.
593
594         * TestWebKitAPI/Tests/WebCore/URL.cpp:
595         Check for a few other ways an IP address could be invalid.
596
597 2018-07-24  Charlie Turner  <cturner@igalia.com>
598
599         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
600         https://bugs.webkit.org/show_bug.cgi?id=187951
601
602         When running run-webkit-tests --wpe --debug, it was observed that
603         both self.platform != 'wpe' and self.debug != True. This turned
604         out to be because of the "args" argument consuming the remainder
605         of future arguments that came after it. Since the first argument
606         to load_from_args was the test script to run, it would end up
607         never processing the other arguments supplied to the wrapper
608         script.
609
610         Tested this by rebuilding GTK in debug mode, running the
611         minibrowser with various extra options, and running some tests
612         with various extra options.
613
614         Reviewed by Michael Catanzaro.
615
616         * flatpak/flatpakutils.py:
617         (WebkitFlatpak.load_from_args):
618
619 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
620
621         [Flatpak] Remove now unnecessary 'hacks' for running tests
622         https://bugs.webkit.org/show_bug.cgi?id=187608
623
624         Reviewed by Philippe Normand.
625
626         We used to need to not share X11 with the sandbox when running tests
627         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
628         sandbox (we mount it on `/run/host/tmp` now).
629
630         This has the advantage of making running the MiniBrowser to display test
631         results working again.
632
633         * flatpak/flatpakutils.py:
634         (WebkitFlatpak.clean_args):
635         (WebkitFlatpak.run_in_sandbox):
636         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
637
638 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
639
640         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
641         https://bugs.webkit.org/show_bug.cgi?id=187581
642
643         Reviewed by Daniel Bates.
644
645         There are two failures in this test case:
646         1. proc.poll() doesn't return 0.
647         2. stderr is not output.
648
649         For failure #1, this is expected. the process should not exit at
650         the time. proc.poll() should return None because the process is
651         still alive.
652
653         This change added a new test to check proc.poll() becomes 0 after
654         the process successfully exits.
655
656         For failure #2, stderr is not flushed even though stdout is
657         flushed. This change uses '-u' command switch to force stdin,
658         stdout and stderr to be totally unbuffered.
659
660         * Scripts/webkitpy/port/server_process_unittest.py:
661         (TestServerProcess.test_basic): Added -u command switch. Do not
662         flush stdout. Removed the special condition for Windows. Add a new
663         test to check proc.poll() returns 0.
664         (TestServerProcess.test_process_crashing): Added -u command
665         switch. Do not flush stdout.
666
667 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
668
669         WTF::StringView::split should have an allowEmptyEntries flag
670         https://bugs.webkit.org/show_bug.cgi?id=187864
671
672         Reviewed by Konstantin Tokarev.
673
674         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
675
676 2018-07-23  Ben Richards  <benton_richards@apple.com>
677
678         We should cache the compiled sandbox profile in a data vault
679         https://bugs.webkit.org/show_bug.cgi?id=184991
680
681         Reviewed by Ryosuke Niwa.
682
683         Added trace points for sandbox initialization
684
685         * Tracing/SystemTracePoints.plist:
686
687 2018-07-23  Zalan Bujtas  <zalan@apple.com>
688
689         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
690         https://bugs.webkit.org/show_bug.cgi?id=187924
691         <rdar://problem/41745884>
692
693         Reviewed by Simon Fraser.
694
695         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
696
697         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
698         (createBitmapContextFromWebView):
699
700 2018-07-23  Chris Dumez  <cdumez@apple.com>
701
702         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
703         https://bugs.webkit.org/show_bug.cgi?id=187910
704         <rdar://problem/42356526>
705
706         Reviewed by Brent Fulgham.
707
708         Add API test coverage.
709
710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
711         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
712         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
713         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
714         (TEST):
715         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
716
717 2018-07-23  Daniel Bates  <dabates@apple.com>
718
719         test-webkitpy should take configuration command line options
720         https://bugs.webkit.org/show_bug.cgi?id=187872
721
722         Reviewed by David Kilzer.
723
724         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
725         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
726         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
727
728         * BuildSlaveSupport/build.webkit.org-config/steps.py:
729         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
730         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
731         * Scripts/webkitpy/test/main.py:
732         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
733         the specified configuration is None then we fall back to using the default configuration (as set
734         by script set-webkit-configuration).
735         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
736         with a Debug configuration and a Release configuration, respectively
737         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
738         the command line options. It may be None if neither --debug nor --release were passed.
739
740 2018-07-23  Commit Queue  <commit-queue@webkit.org>
741
742         Unreviewed, rolling out r233030.
743         https://bugs.webkit.org/show_bug.cgi?id=187904
744
745         Broke tarball builds (Requested by mcatanzaro on #webkit).
746
747         Reverted changeset:
748
749         "run-gtk-tests (glib/common.py) cannot determine build
750         directory when webKitBranchBuild=true"
751         https://bugs.webkit.org/show_bug.cgi?id=185643
752         https://trac.webkit.org/changeset/233030
753
754 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
755
756         Fix lldb summarizers for HashMaps and HashSets
757         https://bugs.webkit.org/show_bug.cgi?id=187883
758
759         Reviewed by Dan Bates.
760         
761         HashMap and HashSet summarizers were broken in various ways.
762         
763         The 'type summary add -x' regexp needs to match at the start and end of the string
764         to avoid finding types nested inside other templates.
765         
766         The HashTable synthetic child code incorrectly used the type of the key, rather than
767         the value when synthesizing children.
768         
769         Add HashMap and HashSet summarizers.
770
771         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
772
773         * lldb/lldbWebKitTester/main.cpp:
774         (testSummaryProviders):
775         * lldb/lldb_webkit.py:
776         (__lldb_init_module):
777         (__lldb_init_module.lldb_webkit):
778         (WTFHashMap_SummaryProvider):
779         (WTFHashSet_SummaryProvider):
780         (WebCoreColorProvider._to_string_extended):
781         (WebCoreURLProvider.to_string):
782         (WTFHashMapProvider):
783         (WTFHashMapProvider.__init__):
784         (WTFHashMapProvider.tableSize):
785         (WTFHashMapProvider.keyCount):
786         (WTFHashSetProvider):
787         (WTFHashSetProvider.__init__):
788         (WTFHashSetProvider.tableSize):
789         (WTFHashSetProvider.keyCount):
790         (WTFHashTableProvider.tableSize):
791         (WTFHashTableProvider):
792         (WTFHashTableProvider.keyCount):
793         (WTFHashTableProvider.get_child_at_index):
794         (WTFHashTableProvider.update):
795         * lldb/lldb_webkit_unittest.py:
796         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
797         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
798         (TestSummaryProviders):
799         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
800         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
801         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
802
803 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
804
805         Add lldb formatters for WebCore geometry types
806         https://bugs.webkit.org/show_bug.cgi?id=187884
807
808         Reviewed by Daniel Bates.
809         
810         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
811         and LayoutRect.
812         
813         Testing is blocked by webkit.org/b/187872.
814
815         * lldb/lldbWebKitTester/main.cpp:
816         (testSummaryProviders):
817         * lldb/lldb_webkit.py:
818         (__lldb_init_module.lldb_webkit):
819         (__lldb_init_module):
820         (WebCoreLayoutRect_SummaryProvider):
821         (WebCoreIntSize_SummaryProvider):
822         (WebCoreIntPoint_SummaryProvider):
823         (WebCoreFloatSize_SummaryProvider):
824         (WebCoreFloatPoint_SummaryProvider):
825         (WebCoreIntRect_SummaryProvider):
826         (WebCoreFloatRect_SummaryProvider):
827         (WebCoreLayoutRectProvider):
828         (WebCoreLayoutRectProvider.__init__):
829         (WebCoreLayoutRectProvider.get_x):
830         (WebCoreLayoutRectProvider.get_y):
831         (WebCoreLayoutRectProvider.get_width):
832         (WebCoreLayoutRectProvider.get_height):
833         (WebCoreIntPointProvider):
834         (WebCoreIntPointProvider.__init__):
835         (WebCoreIntPointProvider.get_x):
836         (WebCoreIntPointProvider.get_y):
837         (WebCoreIntSizeProvider):
838         (WebCoreIntSizeProvider.__init__):
839         (WebCoreIntSizeProvider.get_width):
840         (WebCoreIntSizeProvider.get_height):
841         (WebCoreIntRectProvider):
842         (WebCoreIntRectProvider.__init__):
843         (WebCoreIntRectProvider.get_x):
844         (WebCoreIntRectProvider.get_y):
845         (WebCoreIntRectProvider.get_width):
846         (WebCoreIntRectProvider.get_height):
847         (WebCoreFloatPointProvider):
848         (WebCoreFloatPointProvider.__init__):
849         (WebCoreFloatPointProvider.get_x):
850         (WebCoreFloatPointProvider.get_y):
851         (WebCoreFloatSizeProvider):
852         (WebCoreFloatSizeProvider.__init__):
853         (WebCoreFloatSizeProvider.get_width):
854         (WebCoreFloatSizeProvider.get_height):
855         (WebCoreFloatRectProvider):
856         (WebCoreFloatRectProvider.__init__):
857         (WebCoreFloatRectProvider.get_x):
858         (WebCoreFloatRectProvider.get_y):
859         (WebCoreFloatRectProvider.get_width):
860         (WebCoreFloatRectProvider.get_height):
861
862 2018-07-20  John Wilander  <wilander@apple.com>
863
864         Resource Load Statistics: Enable basic functionality in experimental debug mode
865         https://bugs.webkit.org/show_bug.cgi?id=187835
866         <rdar://problem/42408590>
867
868         Reviewed by Chris Dumez.
869
870         This patch makes the experimental ITP Debug Mode feature work, at least
871         to a basic level. All of the changes to TestRunner are to support the
872         layout tests for the functionality.
873
874         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
875         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
876         (WTR::InjectedBundle::didReceiveMessageToPage):
877         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
878         (WTR::TestRunner::setStatisticsDebugMode):
879         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
880         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
881         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
882         * WebKitTestRunner/InjectedBundle/TestRunner.h:
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::setStatisticsDebugMode):
885         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
886         * WebKitTestRunner/TestController.h:
887         * WebKitTestRunner/TestInvocation.cpp:
888         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
889         (WTR::TestInvocation::didSetStatisticsDebugMode):
890         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
891         * WebKitTestRunner/TestInvocation.h:
892
893 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
894
895         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
896         https://bugs.webkit.org/show_bug.cgi?id=187846
897
898         Reviewed by Simon Fraser.
899
900         Fixed the bug that testRunner.execCommand was using the second argument as the value.
901
902         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
903         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
904
905         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
906         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
907         (WTR::TestRunner::execCommand):
908         * WebKitTestRunner/InjectedBundle/TestRunner.h:
909
910 2018-07-20  Dean Jackson  <dino@apple.com>
911
912         Accidentally checked in the wrong version of these files.
913
914         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
915         * lldb/lldbWebKitTester/main.cpp:
916         (testSummaryProviders):
917         * lldb/lldb_webkit_unittest.py:
918         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
919         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
920         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
921         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
922         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
923         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
924
925 2018-07-20  Dean Jackson  <dino@apple.com>
926
927         Provide an lldb type summary for WebCore::Color
928         https://bugs.webkit.org/show_bug.cgi?id=187776
929
930         Reviewed by Dan Bates.
931
932         This time without the tests because we don't want to build
933         all of WebKit just for python tests.
934
935         * lldb/lldb_webkit.py: Add a Color summary provider.
936         (__lldb_init_module):
937         (WebCoreColor_SummaryProvider):
938         (WebCoreColorProvider):
939         (WebCoreColorProvider.__init__):
940         (WebCoreColorProvider._is_extended):
941         (WebCoreColorProvider._is_valid):
942         (WebCoreColorProvider._is_semantic):
943         (WebCoreColorProvider._to_string_extended):
944         (WebCoreColorProvider.to_string):
945
946 2018-07-20  Brady Eidson  <beidson@apple.com>
947
948         Add WKNavigation/WKNavigationAction related SPI.
949         https://bugs.webkit.org/show_bug.cgi?id=187826
950
951         Reviewed by Chris Dumez.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
954         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
955         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
956         (TEST):
957
958 2018-07-20  Commit Queue  <commit-queue@webkit.org>
959
960         Unreviewed, rolling out r233943, r233988, r234004, and
961         r234012.
962         https://bugs.webkit.org/show_bug.cgi?id=187856
963
964         webkitpy tests are failing to build lldbWebKitTester
965         (Requested by ryanhaddad on #webkit).
966
967         Reverted changesets:
968
969         "Provide an lldb type summary for WebCore::Color"
970         https://bugs.webkit.org/show_bug.cgi?id=187776
971         https://trac.webkit.org/changeset/233943
972
973         "Provide an lldb type summary for WebCore::Color"
974         https://bugs.webkit.org/show_bug.cgi?id=187776
975         https://trac.webkit.org/changeset/233988
976
977         "Provide an lldb type summary for WebCore::Color"
978         https://bugs.webkit.org/show_bug.cgi?id=187776
979         https://trac.webkit.org/changeset/234004
980
981         "Provide an lldb type summary for WebCore::Color"
982         https://bugs.webkit.org/show_bug.cgi?id=187776
983         https://trac.webkit.org/changeset/234012
984
985 2018-07-20  Philippe Normand  <pnormand@igalia.com>
986
987         [GTK][WPE] enable-media-capabilities websetting
988         https://bugs.webkit.org/show_bug.cgi?id=187847
989
990         Reviewed by Carlos Garcia Campos.
991
992         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
993         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
994
995 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
996
997         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
998         https://bugs.webkit.org/show_bug.cgi?id=187798
999
1000         Reviewed by Michael Catanzaro.
1001
1002         Update test cases to the new API and use a destroy function and vtable in the test case of calling
1003         jsc_context_evaluate_in_object() with a JSCClass.
1004
1005         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1006         (testJSCEvaluateInObject):
1007
1008 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
1009
1010         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
1011         https://bugs.webkit.org/show_bug.cgi?id=187712
1012
1013         Reviewed by Fujii Hironori.
1014
1015         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1016         Mark result of unsigned short test case as platform-specific,
1017         since Windows' behavior is actually *less* surprising here.
1018
1019 2018-07-19  Lucas Forschler  <lforschler@apple.com>
1020
1021         Teach the AWS Lambda to use the [minified]-platforms database
1022         https://bugs.webkit.org/show_bug.cgi?id=187817
1023         
1024         Reviewed by David Kilzer.
1025
1026         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
1027         (lambda_handler): Add support for the platforms.webkit.org database
1028         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
1029         (lambda_handler): Add support for the minified-platforms.webkit.org database
1030
1031 2018-07-19  Dean Jackson  <dino@apple.com>
1032
1033         Provide an lldb type summary for WebCore::Color
1034         https://bugs.webkit.org/show_bug.cgi?id=187776
1035
1036         Dan Bates helped me with this attempted fix. Fingers crossed!
1037
1038         * Scripts/build-lldbwebkittester:
1039
1040 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
1041
1042         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
1043         https://bugs.webkit.org/show_bug.cgi?id=187786
1044
1045         Reviewed by Fujii Hironori.
1046
1047         * Scripts/webkitdirs.pm:
1048         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
1049         for WinCairo builds.
1050
1051 2018-07-19  Dean Jackson  <dino@apple.com>
1052
1053         Provide an lldb type summary for WebCore::Color
1054         https://bugs.webkit.org/show_bug.cgi?id=187776
1055
1056         Another attempted build fix for Debug.
1057
1058         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1059         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1060
1061 2018-07-19  Thomas Denney  <tdenney@apple.com>
1062
1063         [WHLSL] The interpreter doesn't support boolean short-circuiting
1064         https://bugs.webkit.org/show_bug.cgi?id=187779
1065
1066         Reviewed by Alex Christensen.
1067
1068         * WebGPUShadingLanguageRI/Evaluator.js:
1069         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
1070         * WebGPUShadingLanguageRI/Test.js:
1071         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
1072
1073 2018-07-19  Dean Jackson  <dino@apple.com>
1074
1075         Provide an lldb type summary for WebCore::Color
1076         https://bugs.webkit.org/show_bug.cgi?id=187776
1077
1078         Attempted build fix.
1079
1080         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1081
1082 2018-07-19  Brady Eidson  <beidson@apple.com>
1083
1084         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
1085         https://bugs.webkit.org/show_bug.cgi?id=187789
1086
1087         Reviewed by Andy Estes.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1090         (-[PSONNavigationDelegate init]):
1091         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1092
1093 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
1094
1095         [Flatpak] Let flatpak process handle SIGINT
1096         https://bugs.webkit.org/show_bug.cgi?id=187521
1097
1098         Reviewed by Philippe Normand.
1099
1100         Ensuring that flatpak process ends properly and that the sandbox is teard down.
1101         It also avoids showing usless backtrace to the end user and makes gdb
1102         much more usable.
1103
1104         Also make flatpakutils not verbose by default
1105
1106         * flatpak/flatpakutils.py:
1107         (disable_signals):
1108         (WebkitFlatpak.run_in_sandbox):
1109         (WebkitFlatpak.run_gdb):
1110
1111 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1112
1113         Unreviewed. Fix contributors entry.
1114
1115         * Scripts/webkitpy/common/config/contributors.json:
1116
1117 2018-07-18  Dean Jackson  <dino@apple.com>
1118
1119         Provide an lldb type summary for WebCore::Color
1120         https://bugs.webkit.org/show_bug.cgi?id=187776
1121
1122         Reviewed by Dan Bates.
1123
1124         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1125             to get to WebCore.
1126         * lldb/lldbWebKitTester/main.cpp:
1127         (testSummaryProviders): Create some Color objects for testing.
1128
1129         * lldb/lldb_webkit.py: Add a Color summary provider.
1130         (__lldb_init_module):
1131         (WebCoreColor_SummaryProvider):
1132         (WebCoreColorProvider):
1133         (WebCoreColorProvider.__init__):
1134         (WebCoreColorProvider._is_extended):
1135         (WebCoreColorProvider._is_valid):
1136         (WebCoreColorProvider._is_semantic):
1137         (WebCoreColorProvider._to_string_extended):
1138         (WebCoreColorProvider.to_string):
1139
1140         * lldb/lldb_webkit_unittest.py: Tests.
1141         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1142         (TestSummaryProviders):
1143         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1144         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1145         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1146         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1147
1148 2018-07-18  Truitt Savell  <tsavell@apple.com>
1149
1150         Unreviewed, rolling out r233934.
1151
1152         Revision caused 5 webkitpy failures on Mac and broke webkitpy
1153         testing on iOS simulator
1154
1155         Reverted changeset:
1156
1157         "Provide an lldb type summary for WebCore::Color"
1158         https://bugs.webkit.org/show_bug.cgi?id=187776
1159         https://trac.webkit.org/changeset/233934
1160
1161 2018-07-18  Chris Dumez  <cdumez@apple.com>
1162
1163         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
1164         https://bugs.webkit.org/show_bug.cgi?id=187784
1165         <rdar://problem/42329230>
1166
1167         Reviewed by Brady Eidson.
1168
1169         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
1170         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
1171         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
1172
1173         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
1174         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
1175         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
1176         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
1177         result.
1178
1179         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1180         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1181
1182 2018-07-18  Dean Jackson  <dino@apple.com>
1183
1184         Provide an lldb type summary for WebCore::Color
1185         https://bugs.webkit.org/show_bug.cgi?id=187776
1186
1187         Reviewed by Dan Bates.
1188
1189         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1190             to get to WebCore.
1191         * lldb/lldbWebKitTester/main.cpp:
1192         (testSummaryProviders): Create some Color objects for testing.
1193
1194         * lldb/lldb_webkit.py: Add a Color summary provider.
1195         (__lldb_init_module):
1196         (WebCoreColor_SummaryProvider):
1197         (WebCoreColorProvider):
1198         (WebCoreColorProvider.__init__):
1199         (WebCoreColorProvider._is_extended):
1200         (WebCoreColorProvider._is_valid):
1201         (WebCoreColorProvider._is_semantic):
1202         (WebCoreColorProvider._to_string_extended):
1203         (WebCoreColorProvider.to_string):
1204
1205         * lldb/lldb_webkit_unittest.py: Tests.
1206         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1207         (TestSummaryProviders):
1208         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1209         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1210         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1211         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1212
1213 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1214
1215         Adding myself to contributors.json
1216
1217         Unreviewed contributors.json change.
1218
1219         * Scripts/webkitpy/common/config/contributors.json:
1220
1221 2018-07-18  Jer Noble  <jer.noble@apple.com>
1222
1223         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
1224         https://bugs.webkit.org/show_bug.cgi?id=187739
1225         <rdar://problem/42304518>
1226
1227         Reviewed by Tim Horton.
1228
1229         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1230         (TEST):
1231
1232 2018-07-18  Jer Noble  <jer.noble@apple.com>
1233
1234         PiP from Element Fullscreen should match AVKit's behavior
1235         https://bugs.webkit.org/show_bug.cgi?id=187623
1236         <rdar://problem/41212379>
1237
1238         Reviewed by Jon Lee.
1239
1240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1241         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
1242         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
1243         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
1244         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
1245         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
1246         (TestWebKitAPI::TEST):
1247
1248 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
1249
1250         [ews-build] Add build step to run layout-test
1251         https://bugs.webkit.org/show_bug.cgi?id=187674
1252
1253         Reviewed by Lucas Forschler.
1254
1255         * BuildSlaveSupport/ews-build/steps.py:
1256         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
1257         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1258         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
1259
1260 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1261
1262         Add SPI to defer running async script until after document load
1263         https://bugs.webkit.org/show_bug.cgi?id=187748
1264         <rdar://problem/42317378>
1265
1266         Reviewed by Ryosuke Niwa and Tim Horton.
1267
1268         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
1269         executed after the DOMContentLoaded event.
1270
1271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1272         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
1273         (TEST):
1274
1275 2018-07-18  Charlie Turner  <cturner@igalia.com>
1276
1277         [WPE] Update WPEBackend in flatpak
1278         https://bugs.webkit.org/show_bug.cgi?id=187753
1279
1280         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
1281         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
1282         in the version guard,
1283
1284         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
1285
1286         This doesn't work as intended, since the C preprocessor first expands
1287         all macro arguments in the #if expression before evaluating the
1288         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
1289         lead to a syntax error and some head scratching.
1290
1291         A future patch should address the buggy macro check, when it is
1292         decided whether the assume the macro is always defined and bump
1293         the API requirements on WPEBackend, or to move the check into two
1294         conditionals to avoid the expansion problem.
1295
1296         Unreviewed build fix.
1297         
1298         * flatpak/org.webkit.WPE.yaml:
1299
1300 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
1301
1302         Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes
1303         https://bugs.webkit.org/show_bug.cgi?id=187747
1304
1305         Reviewed by Ryosuke Niwa.
1306         
1307         Add textInputController.attributedStringForTyping(), which returns a one-character
1308         attributed string whose attributes are the typing attributes, making it possible to
1309         test -[WebView typingAttributes].
1310         
1311         Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NSDictionary,
1312         so we can't return -typingAttributes directly.
1313
1314         * DumpRenderTree/mac/TextInputControllerMac.m:
1315         (+[TextInputController isSelectorExcludedFromWebScript:]):
1316         (-[TextInputController attributedStringForTyping]):
1317
1318 2018-07-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1319
1320         [GLIB] Add jsc_context_check_syntax() to GLib API
1321         https://bugs.webkit.org/show_bug.cgi?id=187694
1322
1323         Reviewed by Yusuke Suzuki.
1324
1325         Add a new test case.
1326
1327         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1328         (testJSCCheckSyntax):
1329         (main):
1330
1331 2018-07-17  Sihui Liu  <sihui_liu@apple.com>
1332
1333         REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths is a flaky failure
1334         https://bugs.webkit.org/show_bug.cgi?id=187066
1335         <rdar://problem/41609065>
1336
1337         Reviewed by Chris Dumez.
1338
1339         In r232668 we started to do reload if web process crashes by default. As we killed the web 
1340         process explicitly in this test, if web page got reloaded, messages would be sent again, 
1341         and flag set in message handler could keep the test continue to evaluate the expectation 
1342         without waiting for removeDataOfTypes to finish.
1343
1344         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1345         (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDidTerminate:]):
1346         (TEST):
1347
1348 2018-07-17  Chris Dumez  <cdumez@apple.com>
1349
1350         Turn on PSON in WebKitTestRunner
1351         https://bugs.webkit.org/show_bug.cgi?id=186542
1352
1353         Reviewed by Brady Eidson.
1354
1355         Turn on PSON by default in WebKitTestRunner.
1356
1357         * WebKitTestRunner/TestOptions.h:
1358
1359 2018-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1360
1361         Add an SPI hook to allow clients to yield document parsing and script execution
1362         https://bugs.webkit.org/show_bug.cgi?id=187682
1363         <rdar://problem/42207453>
1364
1365         Reviewed by Ryosuke Niwa.
1366
1367         Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
1368         document load, and that doing so doesn't cause deferred `script` to execute in the wrong order (i.e. before
1369         synchronous script, or after "DOMContentLoaded").
1370
1371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1372         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
1373         (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
1374         (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
1375         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1376         (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1377         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1378         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1379
1380         Add an injected bundle object that knows how to take and release multiple document parser yield tokens.
1381
1382         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
1383         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
1384         (+[ParserYieldTokenTestWebView webView]):
1385         (-[ParserYieldTokenTestWebView bundle]):
1386         (-[ParserYieldTokenTestWebView schemeHandler]):
1387         (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
1388         (-[ParserYieldTokenTestWebView didFinishLoad]):
1389         (waitForDelay):
1390         (TEST):
1391         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
1392         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
1393         (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
1394         (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
1395         (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
1396         (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
1397         (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
1398         (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
1399
1400         Add a new test helper class to handle custom schemes via a block-based API.
1401
1402         * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
1403
1404         New test HTML page that contains a deferred script element, a synchronous script element, another deferred
1405         script element, and then some text, images, and links.
1406
1407         * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
1408
1409 2018-07-17  Truitt Savell  <tsavell@apple.com>
1410
1411         Adding myself to Contributors.json
1412
1413         Unreviewed
1414
1415         * Scripts/webkitpy/common/config/contributors.json:
1416
1417 2018-07-17  Aditya Keerthi  <akeerthi@apple.com>
1418
1419         [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
1420         https://bugs.webkit.org/show_bug.cgi?id=187730
1421
1422         Reviewed by Jer Noble.
1423
1424         This regression was introduced by r233865. PIP can now only be initiated from a
1425         window that is on screen.
1426
1427         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1428         (TestWebKitAPI::TEST):
1429
1430 2018-07-17  John Wilander  <wilander@apple.com>
1431
1432         Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
1433         https://bugs.webkit.org/show_bug.cgi?id=187710
1434         <rdar://problem/42252757>
1435
1436         Reviewed by Chris Dumez.
1437
1438         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1439         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1440         (WTR::InjectedBundle::didReceiveMessageToPage):
1441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1442         (WTR::TestRunner::setStatisticsLastSeen):
1443         (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
1444         (WTR::TestRunner::setStatisticsPrevalentResource):
1445         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
1446         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1447         (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
1448         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1449         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
1450         (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
1451         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1452         * WebKitTestRunner/TestController.cpp:
1453         (WTR::TestController::setStatisticsLastSeen):
1454         (WTR::TestController::setStatisticsPrevalentResource):
1455         (WTR::TestController::setStatisticsVeryPrevalentResource):
1456         (WTR::TestController::setStatisticsHasHadUserInteraction):
1457         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
1458         * WebKitTestRunner/TestInvocation.cpp:
1459         (WTR::TestInvocation::didSetLastSeen):
1460         (WTR::TestInvocation::didSetPrevalentResource):
1461         (WTR::TestInvocation::didSetVeryPrevalentResource):
1462         (WTR::TestInvocation::didSetHasHadUserInteraction):
1463         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
1464         * WebKitTestRunner/TestInvocation.h:
1465
1466 2018-07-16  Jeremy Jones  <jeremyj@apple.com>
1467
1468         Fix API Test failures introduced by r233865
1469         https://bugs.webkit.org/show_bug.cgi?id=187720
1470
1471         Unreviewed APITest fix after r233865.
1472
1473         Fullscreen can now only be initiated from a window that is on screen.
1474
1475         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1476         (TestWebKitAPI::TEST):
1477         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
1478         (TestWebKitAPI::TEST):
1479
1480 2018-07-11  Dean Jackson  <dino@apple.com>
1481
1482         Allow removal of white backgrounds
1483         https://bugs.webkit.org/show_bug.cgi?id=187574
1484         <rdar://problem/41146792>
1485
1486         Reviewed by Simon Fraser.
1487
1488         Add a new menu item for punching out white backgrounds in MiniBrowser.
1489         In WebKitTestRunner, expose the new setting and hook that up to
1490         drawing a background in the WebView.
1491
1492         * MiniBrowser/mac/AppDelegate.m:
1493         (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
1494
1495         * MiniBrowser/mac/SettingsController.h: Ditto.
1496         * MiniBrowser/mac/SettingsController.m:
1497         (-[SettingsController _populateMenu]):
1498         (-[SettingsController validateMenuItem:]):
1499         (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
1500         (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
1501
1502         * MiniBrowser/mac/WK1BrowserWindowController.m:
1503         (-[WK1BrowserWindowController didChangeSettings]): Set the new preference.
1504
1505         * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
1506         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
1507         (WTR::PlatformWebView::drawsBackground const):
1508         (WTR::PlatformWebView::setDrawsBackground):
1509         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
1510         (WTR::PlatformWebView::drawsBackground const):
1511         (WTR::PlatformWebView::setDrawsBackground):
1512         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView and
1513         set its SPI.
1514         (WTR::PlatformWebView::drawsBackground const):
1515         (WTR::PlatformWebView::setDrawsBackground):
1516         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.
1517         (WTR::PlatformWebView::drawsBackground const):
1518         (WTR::PlatformWebView::setDrawsBackground):
1519
1520         * WebKitTestRunner/TestController.cpp: Reset and copy the new preference.
1521         (WTR::TestController::resetPreferencesToConsistentValues):
1522         (WTR::updateTestOptionsFromTestHeader):
1523         * WebKitTestRunner/TestOptions.h:
1524         (WTR::TestOptions::hasSameInitializationOptions const):
1525
1526         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1527         (WTR::TestController::platformCreateWebView): If the option for punching
1528         out the background was set, tell the WebView to not draw its background.
1529
1530 2018-07-16  Aditya Keerthi  <akeerthi@apple.com>
1531
1532         [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
1533         https://bugs.webkit.org/show_bug.cgi?id=186531
1534
1535         Reviewed by Tim Horton.
1536
1537         Added isShowingDatalistSuggestions testing hook in order to enable testing of the
1538         visibility of the suggestions view.
1539
1540         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1541         (WTR::UIScriptController::isShowingDataListSuggestions const):
1542         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1543         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1544         (WTR::UIScriptController::isShowingDataListSuggestions const):
1545         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1546         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1547         (WTR::UIScriptController::isShowingDataListSuggestions const):
1548
1549 2018-07-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1550
1551         Add --target-path option to dump-class-layout
1552         https://bugs.webkit.org/show_bug.cgi?id=187687
1553
1554         Reviewed by Simon Fraser.
1555
1556         We add an escape hatch to dump-class-layout for specifying target path directly.
1557         This `--target-path` allows us to use dump-class-layout in the other ports
1558         like JSCOnly.
1559
1560         We can dump class layout if we build the target with clang by using the following command.
1561
1562         Tools/Scripts/dump-class-layout \
1563             --architecture=x86_64 \
1564             --target-path=path/to/libJavaScriptCore.so \
1565             JavaScriptCore \
1566             ScopeNode
1567
1568         * Scripts/dump-class-layout:
1569         (main):
1570
1571 2018-07-16  Sihui Liu  <sihui_liu@apple.com>
1572
1573         IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
1574         https://bugs.webkit.org/show_bug.cgi?id=187631
1575         <rdar://problem/42164227>
1576
1577         Reviewed by Brady Eidson.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1580         (TEST):
1581
1582 2018-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1583
1584         [GLIB] Add API to evaluate code using a given object to store global symbols
1585         https://bugs.webkit.org/show_bug.cgi?id=187639
1586
1587         Reviewed by Michael Catanzaro.
1588
1589         Add a new test case.
1590
1591         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1592         (testJSCEvaluateInObject):
1593         (testJSCExceptions):
1594         (main):
1595
1596 2018-07-15  Zan Dobersek  <zdobersek@igalia.com>
1597
1598         [webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories
1599         https://bugs.webkit.org/show_bug.cgi?id=187353
1600
1601         Reviewed by Youenn Fablet.
1602
1603         When using run-web-platform-tests, allow specifying custom WPT metadata
1604         directory. This will avoid generating such metadata-filled directory
1605         from the port-specific JSON expectations file, and instead will search
1606         for the metadata files and the include manifest inside the specified
1607         directory. The MANIFEST.json file will also be generated under there.
1608
1609         Rationale for this change is prototyping using custom metadata
1610         directories and avoiding generating all this content from a JSON file.
1611         Using this by default in the future would avoid sporradic changes in how
1612         WPT handles metadata .ini files and releases us from the obligation of
1613         adjusting the generator for every such change. This would also allow
1614         managing this metadata content in a separate repository, avoiding
1615         polluting the main webkit.org repository with thousands of .ini files.
1616
1617         If this turns out to be the preferable way of managing the metadata
1618         content, the JSON files under WebPlatformTests/ and the related code in
1619         wpt_runner.py would be removed.
1620
1621         * Scripts/webkitpy/w3c/wpt_runner.py:
1622         (parse_args):
1623         (WPTRunner._wpt_run_paths):
1624         (WPTRunner.run):
1625         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
1626         (WPTRunnerTest.test_run_with_specified_options):
1627
1628 2018-07-13  Ross Kirsling  <ross.kirsling@sony.com>
1629
1630         [WinCairo] run-api-tests is timing out for almost all test cases
1631         https://bugs.webkit.org/show_bug.cgi?id=187547
1632
1633         Reviewed by Fujii Hironori.
1634
1635         * Scripts/webkitpy/port/server_process.py:
1636         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1637         Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
1638
1639         * Scripts/webkitpy/port/server_process_unittest.py:
1640         (TestServerProcess.test_read_after_process_exits):
1641         Add test case.
1642
1643 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1644
1645         Add TestExpectations and baselines for iOS 12
1646         https://bugs.webkit.org/show_bug.cgi?id=187628
1647
1648         Reviewed by Alexey Proskuryakov.
1649
1650         * Scripts/webkitpy/port/ios.py:
1651         (IOSPort): Bump current version to 12.
1652
1653 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1654
1655         Add TestExpectations and baselines for Mojave.
1656         https://bugs.webkit.org/show_bug.cgi?id=187620
1657
1658         Reviewed by Alexey Proskuryakov.
1659
1660         * Scripts/webkitpy/port/mac.py:
1661         (MacPort): Bump current version to 10.14.
1662
1663 2018-07-13  Timothy Hatcher  <timothy@apple.com>
1664
1665         Add _drawsBackground to WKWebViewConfiguration.
1666         https://bugs.webkit.org/show_bug.cgi?id=187665
1667         rdar://problem/42182268
1668
1669         Reviewed by Tim Horton.
1670
1671         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
1672         (TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
1673
1674 2018-07-13  Chris Dumez  <cdumez@apple.com>
1675
1676         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1677         https://bugs.webkit.org/show_bug.cgi?id=187565
1678         <rdar://problem/42095701>
1679
1680         Unreviewed WKTR fix after r233782.
1681
1682         * WebKitTestRunner/TestInvocation.cpp:
1683         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1684
1685 2018-07-13  Chris Dumez  <cdumez@apple.com>
1686
1687         Reduce size of WebCore::URL
1688         https://bugs.webkit.org/show_bug.cgi?id=186820
1689         <rdar://problem/42087508>
1690
1691         Unreviewed, re-generates Service worker registrations database used by API tests after r233789.
1692
1693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1694         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3: Removed.
1695         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-shm: Removed.
1696         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-wal.
1697         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1698         (TEST):
1699
1700 2018-07-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1701
1702         Make it easier to hit the significant rendered text layout milestone on pages with main article elements
1703         https://bugs.webkit.org/show_bug.cgi?id=187578
1704         <rdar://problem/42104637>
1705
1706         Reviewed by Ryosuke Niwa.
1707
1708         Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
1709         page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
1710         articles).
1711
1712         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1713         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
1714         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
1715         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1716         (TEST):
1717
1718 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1719
1720         Change my status to be a WebKit reviewer.
1721
1722         Unreviewed status update.
1723
1724         * Scripts/webkitpy/common/config/contributors.json:
1725
1726 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1727
1728         Unreviewed contributors.json update
1729
1730         Just run "validate-committer-lists -c" to canonicalize the style.
1731
1732         * Scripts/webkitpy/common/config/contributors.json:
1733
1734 2018-07-12  Alex Christensen  <achristensen@webkit.org>
1735
1736         Reduce size of WebCore::URL
1737         https://bugs.webkit.org/show_bug.cgi?id=186820
1738
1739         Reviewed by Yusuke Suzuki and Youenn Fablet.
1740
1741         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1742         (TestWebKitAPI::TEST_F):
1743
1744 2018-07-12  Brady Eidson  <beidson@apple.com>
1745
1746         Make process-swap-on-navigation an experimental feature.
1747         <rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
1748
1749         Reviewed by Chris Dumez.
1750
1751         Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
1752
1753         * WebKitTestRunner/TestController.cpp:
1754         (WTR::TestController::createWebViewWithOptions):
1755         (WTR::TestController::resetPreferencesToConsistentValues):
1756
1757         * WebKitTestRunner/TestOptions.h:
1758         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
1759
1760 2018-07-12  Youenn Fablet  <youenn@apple.com>
1761
1762         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1763         https://bugs.webkit.org/show_bug.cgi?id=187565
1764
1765         Reviewed by Alex Christensen.
1766
1767         Added new test runner API to check for willInjectUserScriptForFrame callback.
1768
1769         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1770         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1771         (WTR::InjectedBundle::resetUserScriptInjectedCount):
1772         (WTR::InjectedBundle::increaseUserScriptInjectedCount):
1773         (WTR::InjectedBundle::userScriptInjectedCount const):
1774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1775         (WTR::InjectedBundlePage::InjectedBundlePage):
1776         (WTR::InjectedBundlePage::resetAfterTest):
1777         (WTR::InjectedBundlePage::willInjectUserScriptForFrame):
1778         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1779         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1780         (WTR::TestRunner::userScriptInjectedCount const):
1781         (WTR::TestRunner::injectUserScript):
1782         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1783         * WebKitTestRunner/TestController.cpp:
1784         (WTR::TestController::injectUserScript):
1785         * WebKitTestRunner/TestController.h:
1786         * WebKitTestRunner/TestInvocation.cpp:
1787         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1788         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1789         (WTR::TestController::injectUserScript):
1790
1791 2018-07-12  Sihui Liu  <sihui_liu@apple.com>
1792
1793         IndexedDB: database file of subframe cannot be removed
1794         https://bugs.webkit.org/show_bug.cgi?id=187564
1795
1796         Reviewed by Youenn Fablet.
1797
1798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1799         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1800         (TEST):
1801
1802 2018-07-12  Timothy Hatcher  <timothy@apple.com>
1803
1804         Make WebKit.LinkColorWithSystemAppearance work across system versions.
1805         https://bugs.webkit.org/show_bug.cgi?id=187573
1806
1807         Reviewed by Wenson Hsieh.
1808
1809         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1810         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.
1811
1812 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1813
1814         [WPE] Pass the backend library name as command line parameter to the web process
1815         https://bugs.webkit.org/show_bug.cgi?id=186841
1816
1817         Reviewed by Žan Doberšek.
1818
1819         * MiniBrowser/wpe/main.cpp:
1820         (main): Stop using WPE_BACKEND_LIBRARY env var.
1821         * Scripts/run-wpe-tests:
1822         (WPETestRunner.__init__): Ditto.
1823         * Scripts/webkitpy/port/wpe.py:
1824         (WPEPort.setup_environ_for_server): Ditto.
1825         * wpe/backends/ViewBackend.cpp:
1826         (WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.
1827         * wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
1828
1829 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         [GLIB] Add API to allow creating variadic functions
1832         https://bugs.webkit.org/show_bug.cgi?id=187517
1833
1834         Reviewed by Michael Catanzaro.
1835
1836         Add test cases.
1837
1838         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1839         (testJSCFunction):
1840         (fooCreateWithFooV):
1841         (multiplyFooV):
1842
1843 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1844
1845         [GLIB] Add jsc_context_get_global_object() to GLib API
1846         https://bugs.webkit.org/show_bug.cgi?id=187515
1847
1848         Reviewed by Michael Catanzaro.
1849
1850         Add test cases.
1851
1852         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1853         (testJSCGlobalObject):
1854         (main):
1855
1856 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1857
1858         [GLIB] Handle G_TYPE_STRV in glib API
1859         https://bugs.webkit.org/show_bug.cgi?id=187512
1860
1861         Reviewed by Michael Catanzaro.
1862
1863         Add test cases.
1864
1865         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1866         (testJSCTypes):
1867         (joinFunction):
1868         (testJSCFunction):
1869
1870 2018-07-11  Aakash Jain  <aakash_jain@apple.com>
1871
1872         [ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
1873         https://bugs.webkit.org/show_bug.cgi?id=187549
1874
1875         Reviewed by Alexey Proskuryakov.
1876
1877         * BuildSlaveSupport/ews-build/factories.py:
1878         (JSCTestsFactory.__init__):
1879         * BuildSlaveSupport/ews-build/steps.py:
1880         (CompileJSCOnlyToT): Build ToT without patch.
1881         (CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
1882         (RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
1883         (ReRunJavaScriptCoreTests): Re-runs JSC tests.
1884         (ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
1885         (ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
1886         (RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
1887         (RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
1888         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1889
1890 2018-07-11  Commit Queue  <commit-queue@webkit.org>
1891
1892         Unreviewed, rolling out r233742.
1893         https://bugs.webkit.org/show_bug.cgi?id=187577
1894
1895         Binary incompatible change with respect to Service Worker
1896         registration map (Requested by dydz on #webkit).
1897
1898         Reverted changeset:
1899
1900         "Reduce size of WebCore::URL"
1901         https://bugs.webkit.org/show_bug.cgi?id=186820
1902         https://trac.webkit.org/changeset/233742
1903
1904 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1905
1906         REGRESSION (231276): Attempting to copy an image fails
1907         https://bugs.webkit.org/show_bug.cgi?id=187212
1908
1909         Reviewed by Ryosuke Niwa.
1910         <rdar://problem/41540074>
1911
1912         Augmented test to include a URL where the lastPathComponent looks similar to a
1913         file URL.
1914
1915         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1916         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1917         (TestWebKitAPI::TEST):
1918
1919 2018-07-11  Alex Christensen  <achristensen@webkit.org>
1920
1921         Add SPI for immediate injection of user scripts
1922         https://bugs.webkit.org/show_bug.cgi?id=173342
1923         <rdar://problem/29202285>
1924
1925         Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
1926
1927         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1928         (waitForMessage):
1929         (TEST):
1930
1931 2018-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
1932
1933         Move WHLSL spec work to the W3C GPUWeb GitHub repository
1934
1935         See https://github.com/gpuweb/WHLSL
1936
1937         * WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
1938         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
1939         * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
1940         * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
1941         * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
1942
1943 2018-07-11  Dean Jackson  <dino@apple.com>
1944
1945         Force WKTR to use the light appearance
1946         https://bugs.webkit.org/show_bug.cgi?id=187572
1947         <rdar://problem/42097805>
1948
1949         Reviewed by Simon Fraser.
1950
1951         Set the NSAppearance on the NSWindow to light mode.
1952
1953         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1954         (WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
1955
1956 2018-07-11  Alex Christensen  <achristensen@webkit.org>
1957
1958         Reduce size of WebCore::URL
1959         https://bugs.webkit.org/show_bug.cgi?id=186820
1960
1961         Reviewed by Yusuke Suzuki.
1962
1963         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1964         (TestWebKitAPI::TEST_F):
1965
1966 2018-07-11  Youenn Fablet  <youenn@apple.com>
1967
1968         Fix remaining Cross-Origin-Resource-Policy failures, if any
1969         https://bugs.webkit.org/show_bug.cgi?id=186761
1970         <rdar://problem/41209829>
1971
1972         Reviewed by Alex Christensen.
1973
1974         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1975         (TestWebKitAPI::TEST):
1976
1977  2018-07-11  Aakash Jain  <aakash_jain@apple.com>
1978  
1979         [ews-build] EWS should unapply the patch and build ToT when patch fails to build
1980         https://bugs.webkit.org/show_bug.cgi?id=187358
1981  
1982         Reviewed by Alexey Proskuryakov.
1983  
1984         * BuildSlaveSupport/ews-build/factories.py:
1985         (BuildFactory.__init__):
1986         * BuildSlaveSupport/ews-build/steps.py:
1987         (CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
1988         (CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
1989         (CompileWebKitToT): Build ToT without patch.
1990         (CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
1991         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
1992
1993 2018-07-11  Robin Morisset  <rmorisset@apple.com>
1994
1995         [WSL] WIP, more of the spec
1996         https://bugs.webkit.org/show_bug.cgi?id=186310
1997
1998         Rubberstamped by Filip Pizlo.
1999
2000         Fixed a few issues with the formal rules (such as adding the restrictions on pointers for compilation to SpirV),
2001         and started writing some of the english in the spec.
2002
2003         * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
2004         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
2005
2006 2018-07-10  Aakash Jain  <aakash_jain@apple.com>
2007
2008         [ews-build] Add build step to UnApply patch
2009         https://bugs.webkit.org/show_bug.cgi?id=187357
2010
2011         Reviewed by Alexey Proskuryakov.
2012
2013         * BuildSlaveSupport/ews-build/steps.py:
2014         (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
2015         (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
2016         properties will be set by build-steps for build and test.
2017         (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
2018
2019 2018-07-10  Dewei Zhu  <dewei_zhu@apple.com>
2020
2021         Update ARES-6.patch file accordingly for r233631.
2022         https://bugs.webkit.org/show_bug.cgi?id=187534
2023
2024         Reviewed by Saam Barati.
2025
2026         Update ARES-6.patch file acoordingly after ARES-6 plan file change to
2027         avoid warning while applying the patch.
2028
2029         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2030
2031 2018-07-10  Tim Horton  <timothy_horton@apple.com>
2032
2033         doAfterNextPresentationUpdate should not be called while content is hidden due to animated resize
2034         https://bugs.webkit.org/show_bug.cgi?id=187500
2035         <rdar://problem/41294139>
2036
2037         Reviewed by Simon Fraser.
2038
2039         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2040         (-[AnimatedResizeWebView _endAnimatedResize]):
2041         Set didEndAnimatedResize before calling super, because it makes the
2042         new test easier and doesn't affect any of the existing ones.
2043
2044         (AnimatedResizeBlocksViewportFitChanges):
2045         This doAfterNextPresentationUpdate is always called during animated resize,
2046         and then synchronously waited for, so it /must/ use
2047         _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting.
2048         
2049         (AnimatedResizeBlocksDoAfterNextPresentationUpdate):
2050         Add a test ensuring that doAfterNextPresentationUpdate is deferred
2051         until endAnimatedResize is called.
2052
2053         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2054         (-[WKWebView _test_waitForDidFinishNavigation]):
2055         _test_waitForDidFinishNavigation is sometimes called during animated resize,
2056         and synchronously waits for a doAfterNextPresentationUpdate, so
2057         it cannot wait for the animated resize to complete.
2058
2059 2018-07-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2060
2061         [GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
2062         https://bugs.webkit.org/show_bug.cgi?id=184441
2063
2064         Reviewed by Michael Catanzaro.
2065
2066         All executables of TestWebKitAPI need the forwarding headers of
2067         WebCore and PAL because config.h includes
2068         <WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
2069
2070         The forwarding headers of WebCore are generated by
2071         generate-forwarding-headers.pl in GTK and WPE ports. The
2072         forwarding headers of PAL are generated by
2073         WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
2074
2075         * TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
2076         ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
2077         ${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
2078         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2079
2080 2018-07-10  Stephan Szabo  <stephan.szabo@sony.com>
2081
2082         [WinCairo] Support display of webinspector ui on non-legacy minibrowser
2083         https://bugs.webkit.org/show_bug.cgi?id=187415
2084
2085         Reviewed by Brian Burg.
2086
2087         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2088         (WebKitBrowserWindow::WebKitBrowserWindow):
2089
2090 2018-07-10  John Wilander  <wilander@apple.com>
2091
2092         Resource Load Statistics: Make testRunner.statisticsResetToConsistentState() take a completion handler
2093         https://bugs.webkit.org/show_bug.cgi?id=187499
2094         <rdar://problem/41999431>
2095
2096         Reviewed by Chris Dumez.
2097
2098         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2099         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2100         (WTR::InjectedBundle::didReceiveMessageToPage):
2101         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2102         (WTR::TestRunner::statisticsResetToConsistentState):
2103         (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
2104         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2105         * WebKitTestRunner/TestController.cpp:
2106         (WTR::TestController::statisticsResetToConsistentState):
2107         * WebKitTestRunner/TestInvocation.cpp:
2108         (WTR::TestInvocation::didResetStatisticsToConsistentState):
2109         * WebKitTestRunner/TestInvocation.h:
2110
2111 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2112
2113         Disable cross-origin-window-policy by default
2114         https://bugs.webkit.org/show_bug.cgi?id=187509
2115
2116         Reviewed by Chris Dumez.
2117
2118         Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
2119
2120         * WebKitTestRunner/TestController.cpp:
2121         (WTR::TestController::resetPreferencesToConsistentValues):
2122
2123 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2124
2125         [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
2126         https://bugs.webkit.org/show_bug.cgi?id=187470
2127
2128         Reviewed by Philippe Normand.
2129
2130         Never force building, the user is responsible to make that decision and the workflow is
2131         now based on external scripts so it doesn't make sense anymore. Doing that leads
2132         to ignoring the options the user passed in.
2133
2134         * flatpak/flatpakutils.py:
2135         (WebkitFlatpak.setup_dev_env):
2136
2137 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2138
2139         [Flatpak] Fix running wpt tests inside flatpak
2140         https://bugs.webkit.org/show_bug.cgi?id=187490
2141
2142         Reviewed by Philippe Normand.
2143
2144         Still not *all* passing but a big majority do.
2145
2146         * Scripts/webkitpy/w3c/wpt_runner.py:
2147         (main): Generate the /etc/hosts and mount it in flatpak as required.
2148         (WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout WPT code before generating /etc/hosts.
2149         (WPTRunner._prepare_wpt_checkout): Deleted.
2150         * flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
2151         added a way to pass extra env to flatpak itself (so we can mount /etc/hosts).
2152         Stopped passing `--device=all` as it is not required since r233638 (Bug 187400).
2153         * flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as required by wpt.
2154
2155 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2156
2157         [Flatpak] Use logging to print debug information
2158         https://bugs.webkit.org/show_bug.cgi?id=187496
2159
2160         Reviewed by Philippe Normand.
2161
2162         * flatpak/flatpakutils.py:
2163         (WebkitFlatpak.load_from_args):
2164         (WebkitFlatpak.clean_args):
2165         (WebkitFlatpak.run_in_sandbox):
2166
2167 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2168
2169         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2170         https://bugs.webkit.org/show_bug.cgi?id=187425
2171         rdar://problem/39948240
2172         rdar://problem/41796865
2173
2174         Reviewed by Tim Horton.
2175
2176         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2177         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Use new color value.
2178
2179 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2180
2181         Fix dump-class-layout to show bit padding, and fix issues with padding offsets
2182         https://bugs.webkit.org/show_bug.cgi?id=187442
2183
2184         Reviewed by Daniel Bates.
2185         
2186         Synthetic padding members were shown with the wrong offset because they used the
2187         absolute offset rather than the class-relative offset. This didn't change the padding
2188         math, but made the output confusing.
2189         
2190         Also add support for showing empty bits in bitfields, and fix computation of padding
2191         after bitfields. Empty bits are computed by inserting a bit padding member after
2192         a bitfield that is not followed by another bitfield (making the assumption that bit
2193         padding will fill to the next byte boundary).
2194         
2195         The computation of padding after bitfields was also wrong, since lldb's member_type.GetByteSize()
2196         just reports the size of the type without the bitfield modifier (e.g. for "unsigned : 2" it returned 4).
2197         Fix by setting the byte size for bitfield fields to the number of bits rounded up to the next byte;
2198         this allows byte padding following the bitfield to be computed correctly.
2199         
2200         Add or modify test to cover these issues.
2201
2202         * lldb/dump_class_layout_unittest.py:
2203         (serial_test_ClassWithPaddedBitfields):
2204         (serial_test_MemberHasBitfieldPadding):
2205         (serial_test_InheritsFromClassWithPaddedBitfields):
2206         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2207         (avoidClassDeadStripping):
2208         * lldb/lldb_dump_class_layout.py:
2209         (ClassLayoutBase):
2210         (ClassLayoutBase._to_string_recursive):
2211         (ClassLayout._parse):
2212         (ClassLayout._compute_padding_recursive):
2213
2214 2018-07-09  Youenn Fablet  <youenn@apple.com>
2215
2216         StringView operator==(char*) should check the length of the string
2217         https://bugs.webkit.org/show_bug.cgi?id=187422
2218
2219         Reviewed by Chris Dumez.
2220
2221         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2222         (TestWebKitAPI::equal2):
2223         (TestWebKitAPI::TEST):
2224
2225 2018-07-09  Ross Kirsling  <rkirsling@gmail.com>
2226
2227         [WinCairo] httpd service install needs to precede server start
2228         https://bugs.webkit.org/show_bug.cgi?id=187283
2229
2230         Reviewed by Daniel Bates.
2231
2232         * Scripts/webkitpy/port/base.py:
2233         (Port.check_build):
2234         Remove unused parameter `needs_http`.
2235         
2236         (Port.check_sys_deps):
2237         (Port.start_http_server):
2238         Move `check_httpd` call.
2239
2240         * Scripts/webkitpy/port/win.py:
2241         (WinPort.check_httpd): Added.
2242         (WinCairoPort.check_httpd): Deleted.
2243         Move `httpd -k install` logic to common Windows location.
2244
2245         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2246         (Manager._set_up_run):
2247         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2248         * Scripts/webkitpy/port/gtk.py:
2249         (GtkPort.check_sys_deps):
2250         * Scripts/webkitpy/port/ios_simulator.py:
2251         (IOSSimulatorPort.check_sys_deps):
2252         * Scripts/webkitpy/port/mock_drt.py:
2253         (MockDRTPort.check_build):
2254         (MockDRTPort.check_sys_deps):
2255         * Scripts/webkitpy/port/port_testcase.py:
2256         (PortTestCase.integration_test_check_sys_deps):
2257         (test_check_build):
2258         * Scripts/webkitpy/port/test.py:
2259         * Scripts/webkitpy/port/wpe.py:
2260         (WPEPort.check_sys_deps):
2261         * Scripts/webkitpy/tool/commands/perfalizer.py:
2262         (PerfalizerTask.run):
2263         Remove `needs_http` arguments.
2264
2265 2018-07-09  Philippe Normand  <pnormand@igalia.com>
2266
2267         [Flatpak] Unreviewed, switch to https for the gst-libav tarball.
2268         
2269         * flatpak/org.webkit.WebKit.yaml:
2270
2271 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2272
2273         [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
2274         https://bugs.webkit.org/show_bug.cgi?id=187384
2275
2276         Reviewed by Philippe Normand.
2277
2278         And make it usable inside the sandbox even when
2279         perl is launched "tainted" (as the PERL5LIB won't
2280         work otherwise).
2281
2282         * flatpak/flatpakutils.py:
2283         (WebkitFlatpak.run_in_sandbox):
2284         * flatpak/org.webkit.WebKit.yaml:
2285
2286 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2287
2288         [WPE][GTK] Mount /dev/shm on /run/shm in sandbox
2289         https://bugs.webkit.org/show_bug.cgi?id=187400
2290
2291         Reviewed by Philippe Normand.
2292
2293         This is where it is expected to be when it is a symlink,
2294         without mounting it the websocket python server can't work
2295         inside the sandbox.
2296
2297         * flatpak/flatpakutils.py:
2298         (WebkitFlatpak.run_in_sandbox):
2299
2300 2018-07-08  Filip Pizlo  <fpizlo@apple.com>
2301
2302         run-benchmark should run ARES-6 1.0.1
2303         https://bugs.webkit.org/show_bug.cgi?id=187452
2304
2305         Reviewed by Sam Weinig.
2306         
2307         We forgot to update this when we released 1.0.1!
2308
2309         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2310
2311 2018-07-07  Youenn Fablet  <youenn@apple.com>
2312
2313         WPT importer should create dummy HTML files for *.window.js script files
2314         https://bugs.webkit.org/show_bug.cgi?id=187426
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
2319         Do the same strategy as done for worker.js/any.js files.
2320
2321         * Scripts/webkitpy/w3c/test_importer.py:
2322         (TestImporter.write_html_files_for_templated_js_tests):
2323
2324 2018-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2325
2326         Introduce a layout milestone to track when the document contains a large number of rendered characters
2327         https://bugs.webkit.org/show_bug.cgi?id=187412
2328         <rdar://problem/41744338>
2329
2330         Reviewed by Ryosuke Niwa.
2331
2332         Add a new API test to check that we observe the new rendering milestone in an article-like document.
2333
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html: Added.
2336         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2337         (TEST):
2338
2339 2018-06-30  Simon Fraser  <simon.fraser@apple.com>
2340
2341         dump-class-layout reports wrong padding in many cases
2342         https://bugs.webkit.org/show_bug.cgi?id=185801
2343
2344         Reviewed by Dan Bates.
2345         
2346         Enhance dump-class-layout, fixing bugs and adding unit tests. This also includes
2347         the patch from bug 187141.
2348         
2349         Move the code that uses lldb to fetch the class layout to its own module,
2350         lldb_dump_class_layout.py, so it can be unit tested. Change this code
2351         to build up a data structure for the class. This is necessary since correct
2352         padding computation is easier with second traversal over the data structure.
2353         
2354         Try to deal with the empty base class optimization, which is necessary to report
2355         correct padding in classes using std::unique_ptr, and correctly handle virtual base classes.
2356         
2357         The ClassLayoutBase class knows how to test for equality and generate a string
2358         or string list representation of itself. The derived ClassLayout class knows
2359         how to build up the class layout using the lldb Python bindings.
2360         
2361         Finally we wrap the lldb debugger instance in LLDBDebuggerInstance so that we don't
2362         have to make a new one for each unit test. The tests have to run serially.
2363         
2364         Add to lldbWebKitTester a .cpp file that contains a set of C++ classes to unit-test
2365         dump-class-layout.
2366
2367         * Scripts/dump-class-layout:
2368         (main):
2369         * lldb/dump_class_layout_unittest.py:
2370         (destroy_cached_debug_session):
2371         (TestDumpClassLayout):
2372         (TestDumpClassLayout.setUpClass):
2373         (TestDumpClassLayout.setUp):
2374         (TestDumpClassLayout.serial_test_BasicClassLayout):
2375         (serial_test_PaddingBetweenClassMembers):
2376         (serial_test_BoolPaddingClass):
2377         (serial_test_ClassWithEmptyClassMembers):
2378         (serial_test_SimpleVirtualClass):
2379         (serial_test_SimpleVirtualClassWithNonVirtualBase):
2380         (serial_test_InterleavedVirtualNonVirtual):
2381         (serial_test_ClassWithTwoVirtualBaseClasses):
2382         (serial_test_ClassWithClassMembers):
2383         (serial_test_ClassWithBitfields):
2384         (serial_test_ClassWithUniquePtrs):
2385         (serial_test_ClassWithOptionals):
2386         (TestDumpClassLayout.test_BasicClassLayout): Deleted.
2387         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2388         (EmptyClass::doStuff):
2389         (VirtualBaseClass::~VirtualBaseClass):
2390         (VirtualBaseClass2::~VirtualBaseClass2):
2391         (SimpleVirtualClass::~SimpleVirtualClass):
2392         (SimpleVirtualClass::doStuff):
2393         (SimpleVirtualClassWithNonVirtualBase::~SimpleVirtualClassWithNonVirtualBase):
2394         (SimpleVirtualClassWithNonVirtualBase::doStuff):
2395         (avoidClassDeadStripping):
2396         * lldb/lldb_dump_class_layout.py:
2397         (ansi_colors):
2398         (ClassLayoutBase):
2399         (ClassLayoutBase.__init__):
2400         (ClassLayoutBase.__ne__):
2401         (ClassLayoutBase.__eq__):
2402         (ClassLayoutBase._to_string_recursive):
2403         (ClassLayoutBase.as_string_list):
2404         (ClassLayoutBase.as_string):
2405         (ClassLayoutBase.dump):
2406         (ClassLayoutExpected):
2407         (ClassLayoutExpected.__init__):
2408         (ClassLayout):
2409         (ClassLayout.__init__):
2410         (ClassLayout._has_polymorphic_base_class):
2411         (ClassLayout._parse):
2412         (ClassLayout._probably_has_empty_base_class_optimization):
2413         (ClassLayout._compute_padding_recursive):
2414         (ClassLayout._compute_padding):
2415         (LLDBDebuggerInstance):
2416         (LLDBDebuggerInstance.__init__):
2417         (LLDBDebuggerInstance.__del__):
2418         (LLDBDebuggerInstance._get_first_file_architecture):
2419         (LLDBDebuggerInstance.layout_for_classname):
2420         (ClassLayoutDumper): Deleted.
2421         (ClassLayoutDumper.__init__): Deleted.
2422         (ClassLayoutDumper._get_first_file_architecture): Deleted.
2423         (ClassLayoutDumper.verify_type): Deleted.
2424         (ClassLayoutDumper.verify_type_recursive): Deleted.
2425         (ClassLayoutDumper._class_layout_as_string): Deleted.
2426         (ClassLayoutDumper.dump_to_string): Deleted.
2427         (ClassLayoutDumper.dump): Deleted.
2428
2429 2018-07-06  Christopher Reid  <chris.reid@sony.com>
2430
2431         [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs
2432         https://bugs.webkit.org/show_bug.cgi?id=187167
2433
2434         Reviewed by Alex Christensen.
2435
2436         A null byte was written past the end of the buffer causing the crash.
2437         Some of the heap allocated buffers were also not getting deleted.
2438
2439         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2440
2441 2018-07-06  Thibault Saunier  <tsaunier@igalia.com>
2442
2443         [WPE][GTK] Build php zlib plugin and enable sockets in flatpak
2444         https://bugs.webkit.org/show_bug.cgi?id=187401
2445
2446         Reviewed by Philippe Normand.
2447
2448         * flatpak/org.webkit.WebKit.yaml:
2449
2450 2018-07-06  Aakash Jain  <aakash_jain@apple.com>
2451
2452         [ews-build] EWS should run javascriptcore tests
2453         https://bugs.webkit.org/show_bug.cgi?id=187365
2454
2455         Reviewed by David Kilzer.
2456
2457         * BuildSlaveSupport/ews-build/steps.py: Added step to run JavaScriptCoreTests.
2458         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2459         * BuildSlaveSupport/ews-build/factories.py:
2460
2461 2018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2462
2463         [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails
2464         https://bugs.webkit.org/show_bug.cgi?id=187383
2465
2466         Reviewed by Žan Doberšek.
2467
2468         This is actually a problem in the test itself. The problem is that we run js, connect to message-received and
2469         quite the main loop when the message is received, which happens before the run js operation has been
2470         completed. The test finishes early and since r233111 an IPC message is still pending (I guess the run js
2471         callback) and the web page is still protected. Just adding a run loop operation before finishing the test would
2472         fix it. We should wait for the js run to complete, instead of the message.
2473
2474         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2475         (UserScriptMessageTest::scriptMessageReceived):
2476         (UserScriptMessageTest::waitUntilMessageReceived):
2477         (UserScriptMessageTest::runJavaScriptFinished):
2478         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2479
2480 2018-07-05  Youenn Fablet  <youenn@apple.com>
2481
2482         REGRESSION (r230843): Flash doesn't work; Produces blue box on page
2483         https://bugs.webkit.org/show_bug.cgi?id=187346
2484         <rdar://problem/41773974>
2485
2486         Reviewed by Ryosuke Niwa.
2487
2488         * WebKitTestRunner/TestController.cpp:
2489         (WTR::TestController::resetStateToConsistentValues):
2490         (WTR::TestController::setBlockAllPlugins):
2491         When not blocked, set the load policy to allow once.
2492         * WebKitTestRunner/TestController.h:
2493
2494 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2495
2496         [ews-build] Bindings-tests-EWS should output result in json
2497         https://bugs.webkit.org/show_bug.cgi?id=187330
2498
2499         Reviewed by David Kilzer.
2500
2501         * BuildSlaveSupport/ews-build/steps.py:
2502         (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
2503         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2504
2505 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2506
2507         [ews-build] WebKitPy-Tests-EWS should output result in json
2508         https://bugs.webkit.org/show_bug.cgi?id=187331
2509
2510         Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.
2511
2512 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2513
2514         [ews-build] WebKitPy-Tests-EWS should output result in json
2515         https://bugs.webkit.org/show_bug.cgi?id=187331
2516
2517         Reviewed by David Kilzer.
2518
2519         * BuildSlaveSupport/ews-build/steps.py:
2520         (RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.
2521         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2522
2523 2018-07-05  Philippe Normand  <pnormand@igalia.com>
2524
2525         [Flatpak] Add gst-libav to dependencies
2526         https://bugs.webkit.org/show_bug.cgi?id=187340
2527
2528         Reviewed by Žan Doberšek.
2529
2530         * flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git
2531         clones because the FFMPeg git server doesn't support shallow
2532         clones.
2533
2534 2018-07-05  Thibault Saunier  <tsaunier@igalia.com>
2535
2536         [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
2537         https://bugs.webkit.org/show_bug.cgi?id=187322
2538
2539         Reviewed by Žan Doberšek.
2540
2541         * flatpak/flatpakutils.py:
2542         (WebkitFlatpak.__init__):
2543
2544 2018-07-05  Zan Dobersek  <zdobersek@igalia.com>
2545
2546         Unreviewed, rolling out r233511.
2547
2548         Proper fix provided in bug #187322
2549
2550         Reverted changeset:
2551
2552         "Unreviewed. Fixing a call in flatpakutils.py to
2553         PortFactory.get(),"
2554         https://trac.webkit.org/changeset/233511
2555
2556 2018-07-04  Zan Dobersek  <zdobersek@igalia.com>
2557
2558         Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
2559         enforcing the passed platform argument to always be lowercase, as is
2560         expected from the PortFactory code.
2561
2562         * flatpak/flatpakutils.py:
2563         (WebkitFlatpak.clean_args):
2564
2565 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2566
2567         Introduce PLATFORM(IOSMAC)
2568         https://bugs.webkit.org/show_bug.cgi?id=187315
2569
2570         Reviewed by Dan Bernstein.
2571
2572         * TestWebKitAPI/Configurations/Base.xcconfig:
2573         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2574
2575 2018-07-03  Brady Eidson  <beidson@apple.com>
2576
2577         WebKit.ResponsivenessTimerCrash sometimes fails.
2578         https://bugs.webkit.org/show_bug.cgi?id=187314
2579
2580         Reviewed by Tim Horton.
2581
2582         Actually unregister observers from objects we're about to destroy before destroying them.
2583
2584         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
2585         (-[ResponsivenessTimerObserver observeValueForKeyPath:ofObject:change:context:]): 
2586
2587 2018-07-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2588
2589         update-webkitgtk-flatpak fails if running with python2
2590         https://bugs.webkit.org/show_bug.cgi?id=187240
2591
2592         Reviewed by Michael Catanzaro.
2593
2594         urllib.urlretrieve of Python2 sends invalid requests. Use
2595         urllib2.urlopen instead.
2596
2597         * flatpak/flatpakutils.py: Import urllib2.urlopen for Python2,
2598         urllib.request.urlopen for Python3.
2599         (FlatpakRepo.repo_file): Copy the content of urlopen result to the
2600         temporary file.
2601
2602 2018-07-03  Chris Dumez  <cdumez@apple.com>
2603
2604         Make CallbackMap::invalidate() safe to re-enter
2605         https://bugs.webkit.org/show_bug.cgi?id=187298
2606         <rdar://problem/41057167>
2607
2608         Reviewed by Geoffrey Garen.
2609
2610         Add API test coverage.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
2613         (TEST):
2614
2615 2018-07-03  Chris Dumez  <cdumez@apple.com>
2616
2617         [Cocoa] Disable vnode guard related simulated crashes for WKTR / DRT and WebSQL
2618         https://bugs.webkit.org/show_bug.cgi?id=187270
2619         <rdar://problem/40674034>
2620
2621         Reviewed by Geoffrey Garen.
2622
2623         Disable vnode guard related simulated crashes for WKTR / DRT by setting the
2624         expected environment variable in the test driver.
2625
2626         * Scripts/webkitpy/port/driver.py:
2627         (Driver._setup_environ_for_driver):
2628
2629 2018-07-03  Eric Carlson  <eric.carlson@apple.com>
2630
2631         Video sometimes flickers when playing to AppleTV
2632         https://bugs.webkit.org/show_bug.cgi?id=187193
2633         <rdar://problem/40153865>
2634
2635         Unreviewed, fix test broken by r233435.
2636
2637         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2638         (TestWebKitAPI::waitUntilAudioSessionCategoryIsEqualTo): Poll for a change in audio session 
2639         category because it doesn't necessarily happen synchronously.
2640         (TestWebKitAPI::TEST):
2641
2642 2018-07-03  Thibault Saunier  <tsaunier@igalia.com>
2643
2644         Unreviewed, add myself as a WebKit committer.
2645
2646         And canonicalize the file as suggested by `check-webkit-style`
2647
2648         * Scripts/webkitpy/common/config/contributors.json:
2649
2650 2018-07-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2651
2652         check-webkit-style: Run the tool without SVN client.
2653         https://bugs.webkit.org/show_bug.cgi?id=187294
2654
2655         Reviewed by Daniel Bates.
2656
2657         When invoking check-webkit-style without SVN client, the exception was raised and terminated.
2658         Using Git repository is acceptable workflow according to the wording on:
2659         <https://webkit.org/getting-the-code/#checking-out-with-git>
2660         and using Subversion is considered optional by following link:
2661         <https://webkit.org/webkit-on-windows/#installing-developer-tools>.
2662         This patch makes it so that people with only a Git checkout of WebKit that commit using
2663         the commit-queue (or another machine with an SVN checkout) can run check-webkit-style.
2664
2665         * Scripts/webkitpy/common/checkout/scm/svn.py:
2666         (SVN.in_working_directory):
2667
2668 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2669
2670         Remove old JSCTestsFactory
2671
2672         Follow-up fix to r233471.
2673
2674 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2675
2676         [ews-build] Add support for JSC-Tests-EWS
2677         https://bugs.webkit.org/show_bug.cgi?id=187201
2678
2679         Reviewed by Lucas Forschler.
2680
2681         * BuildSlaveSupport/ews-build/factories.py:
2682         (JSCTestsFactory): Added JSCTestsFactory.
2683         * BuildSlaveSupport/ews-build/steps.py:
2684         (CompileJSCOnly): Command to compile JSC.
2685         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2686         * BuildSlaveSupport/ews-build/config.json: Changed platform to jsc-only. This matches with build.webkit.org configuration.
2687
2688 2018-07-03  Zalan Bujtas  <zalan@apple.com>
2689
2690         [LFC] Add test-list file for regression testing
2691         https://bugs.webkit.org/show_bug.cgi?id=187296
2692
2693         Reviewed by Antti Koivisto.
2694
2695         run-webkit-tests --test-list=./Tools/LayoutReloaded/misc/LFC-passing-tests.txt
2696
2697         * LayoutReloaded/misc/LFC-passing-tests.txt: Added.
2698
2699 2018-07-03  John Wilander  <wilander@apple.com>
2700
2701         Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
2702         https://bugs.webkit.org/show_bug.cgi?id=187277
2703         <rdar://problem/41745510>
2704
2705         Reviewed by Chris Dumez.
2706
2707         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2708         (WTR::TestController::getAllStorageAccessEntries):
2709
2710 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2711
2712         Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
2713         https://bugs.webkit.org/show_bug.cgi?id=187280
2714
2715         Reviewed by Tim Horton.
2716
2717         Add a missing `adoptNS()`.
2718
2719         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2720         (TestWebKitAPI::TEST):
2721
2722 2018-07-02  Myles C. Maxfield  <mmaxfield@apple.com>
2723
2724         [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
2725         https://bugs.webkit.org/show_bug.cgi?id=187228
2726         <rdar://problem/40967280>
2727
2728         Reviewed by Brent Fulgham.
2729
2730         The test only fails before the patch if the lookup for Helvetica2 is allowed to occur.
2731
2732         * WebKitTestRunner/mac/TestControllerMac.mm:
2733         (WTR::allowedFontFamilySet):
2734
2735 2018-07-02  Ryosuke Niwa  <rniwa@webkit.org>
2736
2737         run-benchmark should include the version number of MotionMark's results
2738         https://bugs.webkit.org/show_bug.cgi?id=187274
2739
2740         Reviewed by Jon Lee.
2741
2742         Append the version number as a part of the suite name.
2743
2744         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2745
2746 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2747
2748         [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave
2749         https://bugs.webkit.org/show_bug.cgi?id=187253
2750
2751         Reviewed by Tim Horton.
2752
2753         Enhances and refactors LayoutTestSpellChecker, which was introduced in r233412.
2754
2755         * DumpRenderTree/TestRunner.cpp:
2756         (setSpellCheckerResultsCallback):
2757
2758         Rename setSpellCheckerTextReplacements to setSpellCheckerResults.
2759
2760         (TestRunner::staticFunctions):
2761         (setSpellCheckerTextReplacementsCallback): Deleted.
2762         * DumpRenderTree/TestRunner.h:
2763         * DumpRenderTree/mac/TestRunnerMac.mm:
2764         (TestRunner::setSpellCheckerResults):
2765         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2766         * DumpRenderTree/win/TestRunnerWin.cpp:
2767         (TestRunner::setSpellCheckerResults):
2768         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2769         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
2770         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2771         (-[LayoutTestTextCheckingResult initWithType:range:replacement:details:]):
2772         (-[LayoutTestTextCheckingResult grammarDetails]):
2773         (-[LayoutTestSpellChecker reset]):
2774         (-[LayoutTestSpellChecker results]):
2775         (-[LayoutTestSpellChecker setResults:]):
2776         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]):
2777
2778         Add support for passing in a list of grammar correction detail ranges. Necessary for simulating grammar errors.
2779
2780         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
2781
2782         Tweaked to always call the superclass method. This ensures that we set the `orthography` and `wordCount`
2783         outpointers if applicable.
2784
2785         (-[LayoutTestSpellChecker requestCheckingOfString:range:types:options:inSpellDocumentWithTag:completionHandler:]):
2786
2787         Added support for simulating asynchronous spell checking.
2788
2789         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]): Deleted.
2790         (-[LayoutTestSpellChecker replacements]): Deleted.
2791         (-[LayoutTestSpellChecker setReplacements:]): Deleted.
2792         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]): Deleted.
2793
2794 2018-07-02  Brady Eidson  <beidson@apple.com>
2795
2796         Another unreviewed followup to:
2797         Crash notifying observers of responsiveness state change
2798
2799         * TestWebKitAPI/cocoa/TestWKWebView.h:
2800         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2801         (-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this
2802           test on iOS for other reasons.
2803
2804 2018-07-02  Brady Eidson  <beidson@apple.com>
2805
2806         Unreviewed followup to:
2807         Crash notifying observers of responsiveness state change
2808
2809         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Need the C-SPI for this test.
2810
2811 2018-07-02  Brady Eidson  <beidson@apple.com>
2812
2813         Crash notifying observers of responsiveness state change
2814         <rdar://problem/41267796> and https://bugs.webkit.org/show_bug.cgi?id=187262
2815
2816         Reviewed by Tim Horton.
2817
2818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2819         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Added.
2820         (-[RTObserver observeValueForKeyPath:ofObject:change:context:]):
2821         (TestWebKitAPI::TEST):
2822         * TestWebKitAPI/cocoa/TestWKWebView.h:
2823         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2824         (-[TestWKWebView typeCharacter:]):
2825         (-[TestWKWebView hostWindow]):
2826
2827 2018-07-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2828
2829         [WPE][GTK] flatpakutils.py should respect set-webkit-configuration build type
2830         https://bugs.webkit.org/show_bug.cgi?id=187218
2831
2832         Reviewed by Philippe Normand.
2833
2834         Using the webkitpy Config module, if the build type is not passed on the command line, we
2835         read it from WebKitBuild/Configuration and respect it.
2836
2837         * flatpak/flatpakutils.py:
2838         (WebkitFlatpak.__init__):
2839         (WebkitFlatpak.clean_args):
2840
2841 2018-07-02  Zan Dobersek  <zdobersek@igalia.com>
2842
2843         [WPE] Add touch support to WindowViewBackend
2844         https://bugs.webkit.org/show_bug.cgi?id=187245
2845
2846         Reviewed by Carlos Garcia Campos.
2847
2848         Add touch input support to the WindowViewBackend implementation,
2849         plugging into the Wayland protocol in order to get properly notified
2850         about these events, and then dispatching them against the appropriate
2851         wpe_view_backend object so that WebKit can process them.
2852
2853         * wpe/backends/ViewBackend.cpp:
2854         (WPEToolingBackends::ViewBackend::dispatchInputTouchEvent):
2855         * wpe/backends/ViewBackend.h:
2856         * wpe/backends/WindowViewBackend.cpp:
2857         * wpe/backends/WindowViewBackend.h:
2858
2859 2018-07-02  Rob Buis  <rbuis@igalia.com>
2860
2861         [GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
2862         https://bugs.webkit.org/show_bug.cgi?id=186838
2863
2864         This URL constructor expects canonicalized input, so fix the passed URL. I missed
2865         this one some weeks ago since I had an older checkout.
2866
2867         Reviewed by Michael Catanzaro.
2868
2869         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2870         (TestWebKitAPI::TEST):
2871
2872 2018-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2873
2874         [macOS] Text replacements that end with symbols are expanded immediately
2875         https://bugs.webkit.org/show_bug.cgi?id=187225
2876         <rdar://problem/41112433>
2877
2878         Reviewed by Darin Adler.
2879
2880         Adds testing support for mocking NSSpellChecker's text checking results. See below for more details, and the new
2881         layout test for an example of its usage.
2882
2883         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2884         * DumpRenderTree/TestRunner.cpp:
2885         (setSpellCheckerTextReplacementsCallback):
2886
2887         Add bindings support in TestRunner to specify a set of text replacement mappings. Each entry in the dictionary
2888         maps a string representing an input to the NSSpellChecker to some information describing the spell checking
2889         result that LayoutTestSpellChecker will return.
2890
2891         (TestRunner::staticFunctions):
2892         * DumpRenderTree/TestRunner.h:
2893         * DumpRenderTree/mac/DumpRenderTree.mm:
2894         (resetWebViewToConsistentStateBeforeTesting):
2895
2896         Restore the original shared NSSpellchecker before transitioning to the next layout test, if needed.
2897
2898         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Removed.
2899         * DumpRenderTree/mac/TestRunnerMac.mm:
2900         (TestRunner::setSpellCheckerLoggingEnabled):
2901         (TestRunner::setSpellCheckerTextReplacements):
2902
2903         These testRunner methods ensure that `-[NSSpellChecker sharedSpellChecker]` is swizzled to return our mock
2904         LayoutTestSpellChecker instance before calling into it.
2905
2906         * DumpRenderTree/win/TestRunnerWin.cpp:
2907         (TestRunner::setSpellCheckerTextReplacements):
2908         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreeSpellChecker.h.
2909         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm: Added.
2910
2911         Moved DumpRenderTreeSpellChecker to LayoutTestSpellChecker, and made it compile for both WebKitTestRunner
2912         (modern WebKit) and DumpRenderTree (legacy WebKit) by putting it in TestRunnerShared.
2913
2914         (existingGlobalLayoutTestSpellChecker):
2915         (ensureGlobalLayoutTestSpellChecker):
2916         (stringForCorrectionResponse):
2917         (nsTextCheckingType):
2918         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]):
2919         (-[LayoutTestTextCheckingResult range]):
2920         (-[LayoutTestTextCheckingResult resultType]):
2921         (-[LayoutTestTextCheckingResult replacementString]):
2922         (-[LayoutTestTextCheckingResult description]):
2923
2924         LayoutTestTextCheckingResult represents a fake NSTextCheckingResult containing spell checking results supplied
2925         by the layout test.
2926
2927         (+[LayoutTestSpellChecker installIfNecessary]):
2928         (+[LayoutTestSpellChecker uninstallAndReset]):
2929
2930         Helper methods to begin and end swizzling the shared NSSpellChecker.
2931
2932         (-[LayoutTestSpellChecker reset]):
2933
2934         Resets the state of the LayoutTestSpellChecker (this entails clearing the fake replacements dictionary and
2935         turning off logging for recorded spellchecking responses).
2936
2937         (-[LayoutTestSpellChecker replacements]):
2938         (-[LayoutTestSpellChecker setReplacements:]):
2939         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]):
2940
2941         Helper method to take a `JSObjectRef` supplied by the test runner and transform it into a map of spell checking
2942         string inputs to LayoutTestTextCheckingResults.
2943
2944         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
2945
2946         Consult the text replacement map and bail early if a match is found, before calling into real NSSpellChecker
2947         logic to perform spellchecking.
2948
2949         (-[LayoutTestSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:]):
2950
2951         Reimplement the original functionality in DumpRenderTreeSpellChecker to make `-recordResponse:…` print to stdout
2952         by overriding the method and printing if the `-spellCheckerLoggingEnabled` property has been set to YES.
2953
2954         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2955
2956 2018-07-01  Thibault Saunier  <tsaunier@igalia.com>
2957
2958         [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
2959         https://bugs.webkit.org/show_bug.cgi?id=187232
2960
2961         Reviewed by Michael Catanzaro.
2962
2963         The place where host tmp folder is mounted changed to /run/host/ we
2964         need to take that into account.
2965
2966         Also explicitely close temporary files as relying on garbage collection to
2967         remove them is a bad idea.
2968
2969         Also minor optimization avoiding to compile regex for each backtrace
2970         retrieval.
2971
2972         * Scripts/webkitpy/port/linux_get_crash_log.py:
2973         (GDBCrashLogGenerator):
2974         (GDBCrashLogGenerator._get_tmp_file_name):
2975         (GDBCrashLogGenerator._get_trace_from_systemd):
2976
2977 2018-06-30  Daniel Bates  <dabates@apple.com>
2978
2979         test-webkitpy never rebuilds lldbWebKitTester
2980         https://bugs.webkit.org/show_bug.cgi?id=187229
2981
2982         Reviewed by David Kilzer.
2983
2984         Have test-webkitpy always call script build-lldbwebkittester to build lldbWebKitTester, if needed.
2985
2986         Currently test-webkitpy only calls script build-lldbwebkittester if lldbWebKitTester does not
2987         exist in the build products directory for the active configuration (e.g. Debug); => we do not
2988         build lldbWebKitTester again if its source changes (say, as a result of hacking on lldbWebKitTester).
2989         Instead we should have test-webkitpy unconditionally call build-lldbwebkittester to ensure
2990         that we have an up-to-date build of lldbWebKitTester.
2991
2992         * Scripts/webkitpy/test/main.py:
2993         (Tester._run_tests):
2994         (_find_lldb_webkit_tester): Deleted.
2995
2996 2018-06-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2997
2998         [CMake] build-webkit should be able to enable address sanitizer
2999         https://bugs.webkit.org/show_bug.cgi?id=187222
3000
3001         Reviewed by Daniel Bates.
3002
3003         If 'set-webkit-configuration --asan' has been run, then build-webkit should pass
3004         -DENABLE_ADDRESS_SANITIZER=ON to CMake, so that it actually does something.
3005
3006         This also works for build-jsc.
3007
3008         * Scripts/webkitdirs.pm:
3009         (generateBuildSystemFromCMakeProject):
3010
3011 2018-06-30  Thibault Saunier  <tsaunier@igalia.com>
3012
3013         Make check_flatpak() not verbose when only trying to run command inside flatpak
3014         https://bugs.webkit.org/show_bug.cgi?id=187187
3015
3016         Reviewed by Michael Catanzaro.
3017
3018         * flatpak/flatpakutils.py:
3019         (run_in_sandbox_if_available):
3020
3021 2018-06-29  Daniel Bates  <dabates@apple.com>
3022
3023         build-webkit: Perl "use of uninitialized value $previousContents"
3024         https://bugs.webkit.org/show_bug.cgi?id=185776
3025
3026         Reviewed by Michael Catanzaro.
3027
3028         Fixes an issue where reading an empty cached argument file would cause
3029         Perl "uninitialized value" warnings of the form:
3030             Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
3031             Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
3032
3033         * Scripts/webkitdirs.pm:
3034         (isCachedArgumentfileOutOfDate):
3035
3036 2018-06-29  Daniel Bates  <dabates@apple.com>
3037
3038         Perl uninitialized value $isEnabled when running build-jsc using a CMake build
3039         https://bugs.webkit.org/show_bug.cgi?id=187208
3040
3041         Reviewed by Tim Horton.
3042
3043         Share logic for computing the feature flags to enable in CMake with both script
3044         build-webkit and script build-jsc instead of duplicating it. This also fixes a
3045         bug in the version of this logic in build-jsc that was inadvertently not updated
3046         in r222394. In r222394 we removed the notion of a default value for a feature flag
3047         listed in webkitperl::FeatureList.
3048
3049         We keep the current behavior of build-jsc and leave it up to the build system
3050         to determine whether to enable or disable ENABLE_EXPERIMENTAL_FEATURES.
3051
3052         * Scripts/build-jsc:
3053         (buildMyProject):
3054         (cMakeArgsFromFeatures): Deleted.
3055         * Scripts/build-webkit:
3056         (cMakeArgsFromFeatures): Deleted; moved to webkitdirs.pm.
3057         * Scripts/webkitdirs.pm:
3058         (cmakeArgsFromFeatures): Moved code from script build-webkit so that it can be shared
3059         with build-jsc.
3060
3061 2018-06-29  Tim Horton  <timothy_horton@apple.com>
3062
3063         Add -apple-color-filter and system appearance toggles to MiniBrowser
3064         https://bugs.webkit.org/show_bug.cgi?id=187210
3065
3066         Reviewed by Simon Fraser.
3067
3068         * MiniBrowser/mac/AppDelegate.m:
3069         (defaultConfiguration):
3070         * MiniBrowser/mac/SettingsController.h:
3071         * MiniBrowser/mac/SettingsController.m:
3072         (-[SettingsController _populateMenu]):
3073         (-[SettingsController validateMenuItem:]):
3074         (-[SettingsController toggleAppleColorFilterEnabled:]):
3075         (-[SettingsController appleColorFilterEnabled]):
3076         (-[SettingsController toggleUseSystemAppearance:]):
3077         (-[SettingsController useSystemAppearance]):
3078         * MiniBrowser/mac/WK1BrowserWindowController.m:
3079         (-[WK1BrowserWindowController didChangeSettings]):
3080         * MiniBrowser/mac/WK2BrowserWindowController.m:
3081         (-[WK2BrowserWindowController didChangeSettings]):
3082
3083 2018-06-29  Aditya Keerthi  <akeerthi@apple.com>
3084
3085         [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard
3086         https://bugs.webkit.org/show_bug.cgi?id=187183
3087
3088         Reviewed by Wenson Hsieh.
3089
3090         Added a 'runSingly' option to the TestOptions struct. Setting this option to true
3091         will force a new PlatformWebView to be created before running a test. This ensures
3092         that any state set by previous tests are not preserved.
3093
3094         One example of the importance of having this ability is in the case where we want
3095         to test functionality that deals with read access to files. If a test were to
3096         load a valid file URL, universal read access will be granted in WebProcessProxy.
3097         This prevents us from testing cases that rely on us not have universal read
3098         access. Now, if we write the test using the 'runSingly' option, any state set
3099         by previous tests is cleared. Consequently, our test will behave as expected.
3100
3101         * WebKitTestRunner/PlatformWebView.h:
3102         (WTR::PlatformWebView::viewSupportsOptions const):
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::updateTestOptionsFromTestHeader):
3105         * WebKitTestRunner/TestOptions.h:
3106         (WTR::TestOptions::hasSameInitializationOptions const):
3107
3108 2018-06-29  Daniel Bates  <dabates@apple.com>
3109
3110         [lldb-webkit] Non-empty strings may be pretty-printed as empty
3111         https://bugs.webkit.org/show_bug.cgi?id=187185
3112
3113         Reviewed by Simon Fraser.
3114
3115         For some reason lldb(1) sometimes has an issue accessing members of WTF::StringImplShape
3116         via a WTF::StringImpl pointer (why?). Explicitly casting a WTF::StringImpl* to a
3117         WTF::StringImplShape* before accessing such members makes LLDB happy.
3118
3119         I tried writing a test for this both for the LLVM project and to add to our lldb_webkit unit
3120         tests to no avail. I have only been able to reproduce this bug sporadically during my WebCore/WebKit
3121         debugging sessions so far.
3122
3123         * lldb/lldb_webkit.py:
3124         (WTFStringImplProvider.__init__): Explicitly cast the WTF::StringImpl* to WTF::StringImplShape*.
3125         (WTFStringImplProvider.get_data8): Update code now that we are directly accessing WTF::StringImplShape*.
3126         (WTFStringImplProvider.get_data16): Ditto.
3127
3128 2018-06-29  Chris Dumez  <cdumez@apple.com>
3129
3130         WebKitLegacy: Can trigger recursive loads triggering debug assertions
3131         https://bugs.webkit.org/show_bug.cgi?id=187121
3132         <rdar://problem/41259430>
3133
3134         Reviewed by Brent Fulgham.
3135
3136         Add API test coverage.
3137
3138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3139         * TestWebKitAPI/Tests/mac/StartLoadInDidFailProvisionalLoad.mm: Added.
3140         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3141         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFinishLoadForFrame:]):
3142         (TestWebKitAPI::TEST):
3143
3144 2018-06-29  Lucas Forschler  <lforschler@apple.com>
3145
3146         Teach bisect-builds to retrieve supported platforms from the rest api.
3147         https://bugs.webkit.org/show_bug.cgi?id=187195
3148         
3149         This patch updates bisect-builds to use v2_2 of the API. v2_2 adds two api endpoints: /platforms, and /minified-platforms.
3150         These endpoints scan a dynamoDB database, returning the identifier key for all available platforms.
3151         The identifier keys are in the format: platform-architecture-configuration.
3152
3153         Reviewed by Aakash Jain.
3154
3155         * Scripts/bisect-builds:
3156         (get_api_archive_url): refactored from get_api_url.
3157         (get_platforms): helper function to retrieve from the platforms api.
3158         (minified_platforms): returns a list of minified platforms currently in the database
3159         (unminified_platforms): returns a list of unminified platforms currently in the database
3160         (is_supported_platform): checks if the platform-architecture-configuration combo is supported
3161         (fetch_revision_list): refactored to use get_api_archive_url
3162         (get_api_url): Deleted/refactored to get_api_archive_url.
3163
3164 2018-06-29  Keith Miller  <keith_miller@apple.com>
3165
3166         run-jsc should print when jsc exits with non-zero status
3167         https://bugs.webkit.org/show_bug.cgi?id=187192
3168
3169         Reviewed by Saam Barati.
3170
3171         * Scripts/run-jsc:
3172
3173 2018-06-29  Aakash Jain  <aakash_jain@apple.com>
3174
3175         [ews-build] Add timeout to webkitpy and webkitperl tests
3176         https://bugs.webkit.org/show_bug.cgi?id=187191
3177
3178         Reviewed by Lucas Forschler.
3179
3180         * BuildSlaveSupport/ews-build/steps.py:
3181         (RunWebKitPerlTests.__init__): Set timeout of 2 minutes.
3182         (RunWebKitPyTests.__init__): Ditto.
3183         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3184
3185 2018-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3186
3187         [WPE]: Fix exception handling when flatpak is not installed
3188         https://bugs.webkit.org/show_bug.cgi?id=186771
3189
3190         Unreviewed followup-fix after r233362
3191
3192         This was causing failures when flatpak is not installed.
3193
3194         * flatpak/flatpakutils.py:
3195         (check_flatpak):
3196
3197 2018-06-29  Ross Kirsling  <ross.kirsling@sony.com>
3198
3199         [JSCOnly] Restore Windows build.
3200         https://bugs.webkit.org/show_bug.cgi?id=187127
3201
3202         Reviewed by Michael Catanzaro.
3203
3204         * Scripts/build-jsc:
3205         Fix condition for disabling FTL JIT on Windows.
3206
3207         * Scripts/webkitdirs.pm:
3208         (executableProductDir):
3209         JSCOnly should still use bin64 on Windows (for consistency with full WebKit build).
3210         (determineIsWin64):
3211         JSCOnly already defaults to 64-bit on Windows with Ninja -- ensure that this is true even with MSBuild.
3212
3213 2018-06-29  Thibault Saunier  <tsaunier@igalia.com>
3214
3215         [GTK][WPE]: Add a way to setup our development environment inside flatpak
3216         https://bugs.webkit.org/show_bug.cgi?id=186771
3217
3218         Reviewed by Carlos Alberto Lopez Perez.
3219
3220         This patch introduce a way to setup the development environment inside flatpak[0]
3221         removing the need for jhbuild when doing so. Anything needed to build/run minibrowser/ run
3222         layout tests is provided either but the org.gnome.Sdk runtime or built with flatpak-builder.
3223
3224         The workflow is very similar to the "jhbuild based" one except that you should use update-webkit$PORTNAME-flatpak instead
3225         of update-webkit$PORTNAME-libs and that script requires to specify a build configuration (--release is default).
3226
3227         Our scripts have been updated to be able to run inside that new build environment.
3228
3229         Since everything runs inside a flatpak sandbox, gdb needs to be run from within the sandbox, the script exposes a way to do it
3230         easily with the `--gdb` option:
3231
3232           $ webkit-flatpak --gdb [-m COREDUMPCTL MATCHES]
3233
3234         The Layout test `GDBCrashLogGenerator` has been taugth how to use that and is able to retrieve stacktrace as with the jhbuild based workflow.
3235
3236         [0] http://flatpak.org
3237
3238         * Scripts/build-webkit:
3239         * Scripts/generate-jsc-bundle:
3240         (main):
3241         * Scripts/run-gtk-tests:
3242         * Scripts/run-minibrowser:
3243         * Scripts/run-webdriver-tests:
3244         * Scripts/run-webkit-tests:
3245         * Scripts/run-wpe-tests:
3246         * Scripts/update-webkitgtk-libs:
3247         * Scripts/update-webkitwpe-libs:
3248         * Scripts/webkit-flatpak: Added.
3249         * Scripts/webkitdirs.pm:
3250         (getJhbuildPath):
3251         (getFlatpakPath):
3252         (inFlatpakSandbox):
3253         (runInFlatpak):
3254         (runInFlatpakIfAvalaible):
3255         (wrapperPrefixIfNeeded):
3256         (shouldUseFlatpak):
3257         * Scripts/webkitpy/port/base.py:
3258         (Port._path_to_apache):
3259         (Port._is_flatpak):
3260         (Port._apache_config_file_name_for_platform):
3261         (Port._should_use_flatpak):
3262         (Port):
3263         (Port._in_flatpak_sandbox):
3264         (Port._should_use_jhbuild):
3265         * Scripts/webkitpy/port/gtk.py:
3266         (GtkPort.setup_environ_for_server):
3267         * Scripts/webkitpy/port/linux_get_crash_log.py:
3268         (GDBCrashLogGenerator._get_trace_from_systemd):
3269         (GDBCrashLogGenerator.generate_crash_log):
3270         * Scripts/webkitpy/port/wpe.py:
3271         (WPEPort.setup_environ_for_server):
3272         * Scripts/webkitpy/w3c/wpt_runner.py:
3273         (main):
3274         * flatpak/files/default.xkm: Added.
3275         * flatpak/files/httpd-autogen.sh: Added.
3276         * flatpak/flatpakutils.py: Added.
3277         (Colors):
3278         (Console):
3279         (Console.message):
3280         (remove_extension_points):
3281         (remove_comments):
3282         (remove_comments._replacer):
3283         (load_manifest):
3284         (expand_manifest):
3285         (FlatpakObject):
3286         (FlatpakObject.__init__):
3287         (FlatpakObject.flatpak):
3288         (FlatpakPackages):
3289         (FlatpakPackages.__init__):
3290         (FlatpakPackages.__detect_packages):
3291         (FlatpakPackages.__detect_packages.in):
3292         (FlatpakPackages.__detect_runtimes):
3293         (FlatpakPackages.__detect_apps):
3294         (FlatpakPackages.__iter__):
3295         (FlatpakRepos):
3296         (FlatpakRepos.__init__):
3297         (FlatpakRepos.update):
3298         (FlatpakRepos.add):
3299         (FlatpakRepo):
3300         (FlatpakRepo.__init__):
3301         (FlatpakRepo.repo_file):
3302         (FlatpakPackage):
3303         (FlatpakPackage.__init__):
3304         (FlatpakPackage.__str__):
3305         (FlatpakPackage.is_installed):
3306         (FlatpakPackage.install):
3307         (FlatpakPackage.update):
3308         (WebkitFlatpak):
3309         (WebkitFlatpak.load_from_args):
3310         (WebkitFlatpak.__init__):
3311         (WebkitFlatpak.check_flatpak):
3312         (WebkitFlatpak.check_flatpak.comparable_version):
3313         (WebkitFlatpak.clean_args):
3314         (WebkitFlatpak.run_in_sandbox):
3315         (WebkitFlatpak.run):
3316         (WebkitFlatpak.has_environment):
3317         (WebkitFlatpak.setup_dev_env):
3318         (WebkitFlatpak.install_all):
3319         (WebkitFlatpak.run_gdb):
3320         (WebkitFlatpak.update_all):
3321         (is_sandboxed):
3322         (run_in_sandbox_if_available):
3323         * flatpak/org.webkit.GTK.yaml: Added.
3324         * flatpak/org.webkit.WPE.yaml: Added.
3325         * flatpak/org.webkit.WebKit.yaml: Added.
3326         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
3327         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Added.
3328
3329 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3330
3331         [iOS] DataTransfer.getData always returns the empty string when dropping text
3332         https://bugs.webkit.org/show_bug.cgi?id=187130
3333         <rdar://problem/41014117>
3334
3335         Reviewed by Ryosuke Niwa.
3336
3337         Add 2 new API tests to verify that:
3338         -   When dropping an item with text, markup, and URL representations, the page is allowed to get "text/html",
3339             "text/plain" and "text/uri-list" data.
3340         -   Adding a suggested name to a plain text item causes WebKit to treat it as a file, and suppress access to
3341             DataTransfer.getData().
3342
3343         Additionally tweaks a couple of existing API tests. Namely, in two API tests
3344         (ExternalSourceOverrideDropFileUpload and ExternalSourceHTMLToUploadArea) only a markup string is dropped, and
3345         we previously expected to handle the drop as a file. To allow this test to continue serving its purpose, tweak
3346         them such that the registered items appear to be file-backed (i.e. by adding a suggested filename in one of the
3347         tests, and specifying UIPreferredPresentationStyleAttachment in the other).
3348
3349         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3350         (TestWebKitAPI::TEST):
3351
3352 2018-06-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3353
3354         Unreviewed, rolling out r226652.
3355         https://bugs.webkit.org/show_bug.cgi?id=180827
3356
3357         "PlatformInfo should never be instantiated in isolation. So, PlatformInfo should
3358         not have default argument values. The preferred way to get a PlatformInfo object
3359         is to instantiate a Host object." (Requested by dbates).
3360
3361         Reverted changeset:
3362
3363         "[webkitpy] PlatformInfo should have default argument for casual use"
3364         https://bugs.webkit.org/show_bug.cgi?id=180827
3365
3366 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3367
3368         Try to address test failures on the bots.
3369
3370         Allow the test to distinguish between a failure to find the variable, and an error
3371         reporting vector capacity.
3372
3373         * lldb/lldb_webkit_unittest.py:
3374         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3375         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3376
3377 2018-06-28  Lucas Forschler  <lforschler@apple.com>
3378
3379         Add Windows support for WEBKIT_API_KEY.
3380         https://bugs.webkit.org/show_bug.cgi?id=187155
3381
3382         Reviewed by Daniel Bates.
3383
3384         * EWSTools/start-queue-win.sh:
3385
3386 2018-06-28  Aakash Jain  <aakash_jain@apple.com>
3387
3388         [ews-build] Add support for WebKitPy-Tests-EWS
3389         https://bugs.webkit.org/show_bug.cgi?id=187148
3390
3391         Reviewed by Lucas Forschler.
3392
3393         * BuildSlaveSupport/ews-build/factories.py: Added WebKitPyFactory.
3394         * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPyTests.
3395         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3396         * BuildSlaveSupport/ews-build/config.json: Updated to use CamelCase. 
3397
3398 2018-06-28  Daniel Bates  <dabates@apple.com>
3399
3400         Fix the iOS build following r233299
3401         (https://bugs.webkit.org/show_bug.cgi?id=183744)
3402
3403         Only build lldbWebKitTester on Mac as that is the only supported platform at the time of writing.
3404
3405         * Makefile:
3406
3407 2018-06-28  Sihui Liu  <sihui_liu@apple.com>
3408
3409         Cookie API: cookie creation time is wrong
3410         https://bugs.webkit.org/show_bug.cgi?id=187101
3411
3412         Reviewed by Geoffrey Garen.
3413
3414         Add test coverage: make sure the cookie creation time returned is the same as set.
3415
3416         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3417         (TEST):
3418
3419 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3420
3421         The lldb vector summary provider always shows zero capacity
3422         https://bugs.webkit.org/show_bug.cgi?id=187132
3423
3424         Reviewed by Daniel Bates.
3425         
3426         WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
3427         on the buffer instead of the valobj.
3428
3429         * lldb/lldbWebKitTester/main.cpp:
3430         (testSummaryProviders):
3431         * lldb/lldb_webkit.py:
3432         (WTFVectorProvider.update):
3433         * lldb/lldb_webkit_unittest.py:
3434         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
3435         (TestSummaryProviders):
3436         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3437         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3438
3439 2018-06-28  Adam Barth  <abarth@webkit.org>
3440
3441         Switch OS(FUCHSIA) to using JSCOnly
3442         https://bugs.webkit.org/show_bug.cgi?id=187133
3443
3444         Reviewed by Yusuke Suzuki.
3445
3446         Switch Fuchsia from being a port to just being an OS. We now use a
3447         CMAKE_TOOLCHAIN_FILE to configure the toolchain and the target triple.
3448
3449         * Scripts/webkitdirs.pm: Remove isFuchsia() and clients. Turns out we
3450         can do everything we need using a CMAKE_TOOLCHAIN_FILE via the
3451         --cmakeargs flag.
3452
3453 2018-06-27  Ryosuke Niwa  <rniwa@webkit.org>
3454
3455         Make MotionMark's plan file more robust against code changes
3456         https://bugs.webkit.org/show_bug.cgi?id=187116
3457         <rdar://problem/41533956>
3458
3459         Reviewed by Saam Barati.
3460
3461         Moved the code to auto-start the test to the load event listener.
3462
3463         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
3464
3465 2018-06-27  Daniel Bates  <dabates@apple.com>
3466
3467         Add some tests for lldb_webkit.py
3468         https://bugs.webkit.org/show_bug.cgi?id=183744
3469
3470         Reviewed by Alexey Proskuryakov.
3471
3472         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
3473         and WTF::String objects.
3474
3475         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
3476         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
3477         on Mac.
3478
3479         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
3480         * Scripts/build-lldbwebkittester: Added.
3481         (buildProjectOrDie):
3482         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
3483         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
3484         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
3485         the file and take advantage of Python's default error semantics to throw an exception
3486         if the import fails instead of handling it ourself. This has the side effect that we
3487         now always import the LLDB Python module even if this script is invoked with --help.
3488         If this turns out to be a significant annoyance then we can look to dynamically import
3489         the module as we did before this change.
3490         (webkit_build_dir):
3491         (main):
3492         (developer_dir): Deleted.
3493         (import_lldb): Deleted.
3494         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
3495         that fact that test-webkitpy does not support class and module fixtures. This is because
3496         test-webkitpy currently implements parallelism by breaking down existing test classes
3497         into individual test methods itself and having each worker run exactly one test method (via
3498         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
3499         setUpModule()/setUpClass() are called for each test method as opposed to once per test
3500         class/test module.
3501         (remove_dir): Ditto.
3502         * Scripts/webkitpy/common/system/systemhost.py:
3503         (SystemHost):
3504         (SystemHost.path_to_lldb_python_directory): Added.
3505         * Scripts/webkitpy/test/main.py:
3506         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
3507         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
3508         lldbWebKitTester on Mac.
3509         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
3510         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
3511         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
3512         If we will run these tests then build lldbWebKitTester if it has not already been built as the
3513         unit tests depend on this program.
3514         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
3515         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
3516         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
3517         * lldb/lldbWebKitTester/Makefile: Added.
3518         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
3519         * lldb/lldbWebKitTester/main.cpp: Added.
3520         (breakForTestingSummaryProviders):
3521         (utf16String):
3522         (testSummaryProviders):
3523         (main):
3524         * lldb/lldb_webkit_unittest.py: Added.
3525         (destroy_cached_debug_session):
3526         (LLDBDebugSession):
3527         (LLDBDebugSession.setup):
3528         (LLDBDebugSession.tearDown):
3529         (TestSummaryProviders):
3530         (TestSummaryProviders.setUpClass):
3531         (TestSummaryProviders._sbFrame):
3532         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
3533         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
3534         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
3535         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
3536         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
3537         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
3538         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
3539         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
3540
3541 2018-06-27  Adam Barth  <abarth@webkit.org>
3542
3543         Add Fuchsia support to build-jsc
3544         https://bugs.webkit.org/show_bug.cgi?id=187086
3545
3546         Reviewed by Yusuke Suzuki.
3547
3548         Add Fuchsia port to webkitdirs.pm. This patch is sufficient to make
3549         build-jsc kick off a cmake for Fuchsia.
3550
3551         * Scripts/webkitdirs.pm:
3552         (determineSourceDir):
3553         (argumentsForConfiguration):
3554         (determineXcodeSDK):
3555         (findMatchingArguments):
3556         (determinePortName):
3557         (isFuchsia):
3558         (setupAppleWinEnv):
3559         (wrapperPrefixIfNeeded):
3560         (relaunchIOSSimulator):
3561         (debugMiniBrowser):
3562
3563 2018-06-27  Daniel Bates  <dabates@apple.com>
3564
3565         style-queue "AttributeError: 'NoneType' object has no attribute 'is_obsolete'" when processing security patch
3566         https://bugs.webkit.org/show_bug.cgi?id=187120
3567
3568         Reviewed by David Kilzer.
3569
3570         Teach the style queue how to refetch a patch from the status server as we did for non-Style
3571         EWS queues.
3572
3573         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3574         (StyleQueueTask.validate): Similar to change made to EarlyWarningSystemTask.validate() in r233107,
3575         only check if the bug associated with the patch we are processing is closed if the attachment has a
3576         non-None Bug object.
3577         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3578         (AbstractEarlyWarningSystem.refetch_patch): Extract logic to refetch a patch from here...
3579         * Scripts/webkitpy/tool/commands/queues.py:
3580         (PatchProcessingQueue._refetch_patch): ... to here.
3581         (StyleQueue.refetch_patch): Turn around and call PatchProcessingQueue._refetch_patch().
3582
3583 2018-06-27  Tadeu Zagallo  <tzagallo@apple.com>
3584
3585         Unreviewed, add myself as a WebKit committer.
3586
3587         * Scripts/webkitpy/common/config/contributors.json:
3588
3589 2018-06-27  Daniel Bates  <dabates@apple.com>
3590
3591         webkit-patch should ignore non-ASCII characters in the status server API key
3592         https://bugs.webkit.org/show_bug.cgi?id=187107
3593
3594         Reviewed by Lucas Forschler.
3595
3596         The API key should only consists of ASCII characters. If it contains any
3597         non-ASCII characters then log a warning and ignore them.
3598
3599         * Scripts/webkitpy/common/net/statusserver.py:
3600         (StatusServer.set_api_key): Force conversion to ASCII.
3601         * Scripts/webkitpy/tool/main.py:
3602         (WebKitPatch._status_server_api_key): Convert to ASCII, ignoring non-ASCII
3603         characters and logging a warning.
3604
3605 2018-06-27  Jonathan Bedard  <jbedard@apple.com>
3606
3607         Enable WebKit iOS 12 build
3608         https://bugs.webkit.org/show_bug.cgi?id=187024
3609         <rdar://problem/39759057>
3610
3611         Reviewed by David Kilzer.
3612
3613         * Scripts/configure-xcode-for-ios-development:
3614         (copyMissingHeadersFromSDKToSDKIfNeeded): Copy launch.h into embedded SDKs.
3615
3616 2018-06-27  Robin Morisset  <rmorisset@apple.com>
3617
3618         [WSL] Add a control-flow stack to the execution rules in WSL.ott
3619         https://bugs.webkit.org/show_bug.cgi?id=186310
3620
3621         Rubberstamped by Filip Pizlo.
3622
3623         The goal of this is to enable (future) rules about uniform control flow for barriers.
3624         It required adding two new special construct: Join(s) and JoinExpr(e) whose only role is to pop the last element of the stack.
3625