User agent string override for navigator.userAgent should be site specific quirks
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2
3         User agent string override for navigator.userAgent should be site specific quirks
4         https://bugs.webkit.org/show_bug.cgi?id=193950
5
6         Reviewed by Brent Fulgham.
7
8         Updated per the _WKWebsitePolicies rename.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
11         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
12
13 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
14
15         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
16         https://bugs.webkit.org/show_bug.cgi?id=193941
17
18         Reviewed by Alex Christensen.
19
20         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
21         * TestWebKitAPI/Tests/WTF/Condition.cpp:
22         * TestWebKitAPI/Tests/WTF/Lock.cpp:
23         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
24         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
25         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
26         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
27         * TestWebKitAPI/Tests/WTF/Time.cpp:
28         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
29         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
30         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
31         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
32
33 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
34
35         Unreviewed, reorder my emails to fix autocomplete in bugzilla
36
37         * Scripts/webkitpy/common/config/contributors.json:
38
39 2019-01-28  Andy Estes  <aestes@apple.com>
40
41         [watchOS] Enable Parental Controls content filtering
42         https://bugs.webkit.org/show_bug.cgi?id=193939
43         <rdar://problem/46641912>
44
45         Reviewed by Ryosuke Niwa.
46
47         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
48
49 2019-01-28  David Kilzer  <ddkilzer@apple.com>
50
51         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
52         <https://webkit.org/b/193884>
53
54         Reviewed by Jiewen Tan.
55
56         * Scripts/webkitpy/style/checkers/cpp.py:
57         (check_language): Add LocalAuthentication to
58         `frameworks_with_soft_links`.
59
60 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
61
62         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
63         https://bugs.webkit.org/show_bug.cgi?id=193891
64
65         Reviewed by Ross Kirsling.
66
67         There were three problems in window sizes of WebView and the host window.
68         1. The sizes of pixel image output were incorrect.
69         2. The host window is going to appear after window.resize was invoked.
70         3. window.resize resized only the host window, not WebView.
71
72         This change solves them with a following approach.
73         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
74         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
75            as well as DumpRenderTree in order to match the client area and the window area.
76         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
77         d. PlatformWebView::setWindowFrame changes both window sizes.
78         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
79
80         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
81         (WTR::PlatformWebView::PlatformWebView): Create the host window
82         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
83         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
84         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
85
86 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
87
88         [ews-app] Add method to save Step data to database
89         https://bugs.webkit.org/show_bug.cgi?id=193890
90
91         Reviewed by Lucas Forschler.
92
93         * BuildSlaveSupport/ews-app/ews/models/step.py:
94         (Step.save_step): Method to save step data.
95         (Step.update_step): Method to update step data.
96         (Step.get_existing_step): Method to fetch existing step from database.
97         (Step.is_valid_result): Method to validate valid step result.
98
99 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
100
101         [ews-app] Add method to save Build data to database
102         https://bugs.webkit.org/show_bug.cgi?id=193735
103
104         Reviewed by Lucas Forschler.
105
106         * BuildSlaveSupport/ews-app/ews/models/build.py:
107         (Build.save_build): Method to save build information to database.
108         (Build.get_existing_build): Method to fetch existing build from database.
109         (Build.is_valid_result): Method to validate build result.
110         * BuildSlaveSupport/ews-app/ews/common/util.py:
111         (is_valid_int_id): Method to validate valid id.
112
113 2019-01-28  Chris Dumez  <cdumez@apple.com>
114
115         Regression(PSON) Crash under WebPageProxy::didStartProgress()
116         https://bugs.webkit.org/show_bug.cgi?id=193915
117         <rdar://problem/47560907>
118
119         Reviewed by Alex Christensen.
120
121         Add API test coverage.
122
123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
124
125 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
126
127         [ews-app] Rename id variables
128         https://bugs.webkit.org/show_bug.cgi?id=193883
129
130         Reviewed by Lucas Forschler.
131
132         * BuildSlaveSupport/ews-app/ews/models/build.py:
133         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
134         * BuildSlaveSupport/ews-app/ews/models/step.py:
135         * BuildSlaveSupport/ews-app/ews/urls.py:
136         * BuildSlaveSupport/ews-app/ews/views/patch.py:
137         * BuildSlaveSupport/ews-app/ews/views/results.py:
138         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
139
140 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
141
142         [ews-app] Allow certain fields to be empty
143         https://bugs.webkit.org/show_bug.cgi?id=193892
144
145         Reviewed by Lucas Forschler.
146
147         * BuildSlaveSupport/ews-app/ews/models/build.py:
148         * BuildSlaveSupport/ews-app/ews/models/step.py:
149
150 2019-01-28  Rob Buis  <rbuis@igalia.com>
151
152         Update MIME type parser
153         https://bugs.webkit.org/show_bug.cgi?id=180526
154
155         Reviewed by Frédéric Wang.
156
157         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
158         (TestWebKitAPI::TEST):
159
160 2019-01-28  Zalan Bujtas  <zalan@apple.com>
161
162         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
163         https://bugs.webkit.org/show_bug.cgi?id=193896
164
165         Reviewed by Antti Koivisto.
166
167         * LayoutReloaded/misc/LFC-passing-tests.txt:
168
169 2018-12-15  Darin Adler  <darin@apple.com>
170
171         Replace many uses of String::format with more type-safe alternatives
172         https://bugs.webkit.org/show_bug.cgi?id=192742
173
174         Reviewed by Mark Lam.
175
176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
177         (WTR::cacheTestRunnerCallback): Use makeString.
178         * WebKitTestRunner/TestController.cpp:
179         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
180         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
181
182 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
183
184         Use a load optimizer for some sites
185         https://bugs.webkit.org/show_bug.cgi?id=193881
186         <rdar://problem/46325455>
187
188         Reviewed by Brent Fulgham.
189
190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
191         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
192
193 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
194
195         AX: Introduce a static accessibility tree
196         https://bugs.webkit.org/show_bug.cgi?id=193348
197         <rdar://problem/47203295>
198
199         Reviewed by Ryosuke Niwa.
200
201         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
202
203 2019-01-26  Zalan Bujtas  <zalan@apple.com>
204
205         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
206         https://bugs.webkit.org/show_bug.cgi?id=193867
207
208         Reviewed by Antti Koivisto.
209
210         * LayoutReloaded/misc/LFC-passing-tests.txt:
211
212 2019-01-26  Zalan Bujtas  <zalan@apple.com>
213
214         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
215         https://bugs.webkit.org/show_bug.cgi?id=193865
216
217         Reviewed by Antti Koivisto.
218
219         * LayoutReloaded/misc/LFC-passing-tests.txt:
220
221 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
222
223         Need a mechanism to override navigator.userAgent
224         https://bugs.webkit.org/show_bug.cgi?id=193762
225         <rdar://problem/47504939>
226
227         Reviewed by Brent Fulgham.
228
229         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
230
231         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
232         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
233         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
234
235 2019-01-25  Dean Jackson  <dino@apple.com>
236
237         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
238         https://bugs.webkit.org/show_bug.cgi?id=193831
239         <rdar://problem/47399263>
240
241         Reviewed by Chris Dumez.
242
243         Two new tests that exercise cross-origin and same-origin System
244         Previews.
245
246         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
247
248 2019-01-25  Keith Rollin  <krollin@apple.com>
249
250         Update Xcode projects with "Check .xcfilelists" build phase
251         https://bugs.webkit.org/show_bug.cgi?id=193790
252         <rdar://problem/47201374>
253
254         Reviewed by Alex Christensen.
255
256         Support for XCBuild includes specifying inputs and outputs to various
257         Run Script build phases. These inputs and outputs are specified as
258         .xcfilelist files. Once created, these .xcfilelist files need to be
259         kept up-to-date. In order to check that they are up-to-date or not,
260         add an Xcode build step that invokes an external script that performs
261         the checking. If the .xcfilelists are found to be out-of-date, update
262         them, halt the build, and instruct the developer to restart the build
263         with up-to-date files.
264
265         At this time, the checking and regenerating is performed only if the
266         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
267         who want to use this facility can set this variable and test out the
268         checking/regenerating. Once it seems like there are no egregious
269         issues that upset a developer's workflow, we'll unconditionally enable
270         this facility.
271
272         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
273         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
274         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
275         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
276
277 2019-01-25  Keith Rollin  <krollin@apple.com>
278
279         Update Xcode projects with "Apply Configuration to XCFileLists" build target
280         https://bugs.webkit.org/show_bug.cgi?id=193781
281         <rdar://problem/47201153>
282
283         Reviewed by Alex Christensen.
284
285         Part of generating the .xcfilelists used as part of adopting XCBuild
286         includes running `make DerivedSources.make` from a standalone script.
287         It’s important for this invocation to have the same environment as
288         when the actual build invokes `make DerivedSources.make`. If the
289         environments are different, then the two invocations will provide
290         different results. In order to get the same environment in the
291         standalone script, have the script launch xcodebuild targeting the
292         "Apply Configuration to XCFileLists" build target, which will then
293         re-invoke our standalone script. The script is now running again, this
294         time in an environment with all workspace, project, target, xcconfig
295         and other environment variables established.
296
297         The "Apply Configuration to XCFileLists" build target accomplishes
298         this task via a small embedded shell script that consists only of:
299
300             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
301
302         The process that invokes "Apply Configuration to XCFileLists" first
303         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
304         evaluated and exports it into the shell environment. When xcodebuild
305         is invoked, it inherits the value of this variable and can `eval` the
306         contents of that variable. Our external standalone script can then set
307         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
308         of command-line parameters needed to restart itself in the appropriate
309         state.
310
311         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
312         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
313
314 2019-01-25  Alex Christensen  <achristensen@webkit.org>
315
316         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
317         https://bugs.webkit.org/show_bug.cgi?id=193802
318         <rdar://problem/46010580>
319
320         Reviewed by Andy Estes.
321
322         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
323         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
324         (TEST):
325
326 2019-01-25  Daniel Bates  <dabates@apple.com>
327
328         [iOS] uiController.keyDown() does not translate Control modified key
329         https://bugs.webkit.org/show_bug.cgi?id=192898
330
331         Reviewed by Wenson Hsieh.
332
333         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
334         key translation, as applicable. Among other cases, key translation occurs when performing
335         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
336         also makes the behavior of uiController.keyDown() more closely match the behavior of a
337         human pressing down and releasing key(s) using a hardware keyboard.
338
339         * WebKitTestRunner/ios/HIDEventGenerator.h:
340         * WebKitTestRunner/ios/HIDEventGenerator.mm:
341         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
342
343         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
344         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
345         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
346         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
347         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
348         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
349         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
350         (-[HIDEventGenerator longPress:completionBlock:]):
351         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
352         Update code for above renaming.
353
354         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
355         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
356
357         (-[HIDEventGenerator keyDown:]): Added.
358         (-[HIDEventGenerator keyUp:]): Added.
359         (-[HIDEventGenerator keyPress:completionBlock:]):
360         (-[HIDEventGenerator eventDispatchThreadEntry:]):
361         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
362         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
363         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
364         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
365         (WTR::parseModifier): Deleted.
366
367 2019-01-25  Keith Rollin  <krollin@apple.com>
368
369         Complete the implementation of generate-xcfilelists
370         https://bugs.webkit.org/show_bug.cgi?id=193782
371
372         Reviewed by Alex Christensen.
373
374         A preliminary version of generate-xcfilelists was added in r238008.
375         This patch updates that script in order to:
376
377         - Support checking of .xcfilelists
378         - Perform better execution of `make DerivedSources.make` by
379           relaunching generate-xcfilelists under xcodebuild
380         - Support incremental generation and checking of .xcfilelists
381         - Support supplementary .xcfilelists files from WebKitAdditions
382         - Support being wrapped by parallel version of generate-xcfilelists in
383           Internal that adds support for (re)generating WebKit projects in
384           that repo.
385         - Support builds that have been performed in WebKitBuild as well as
386           ~/Library/Developer/code/DerivedData
387         - Increase robustness and debugging facilities.
388
389         * Scripts/generate-xcfilelists:
390
391 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
392
393         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
394         https://bugs.webkit.org/show_bug.cgi?id=193297
395         <rdar://problem/47158841>
396
397         Unreviewed test case fix.
398
399         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
400         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
401
402         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
403         (TEST):
404
405 2019-01-25  Keith Rollin  <krollin@apple.com>
406
407         Update existing .xcfilelists
408         https://bugs.webkit.org/show_bug.cgi?id=193791
409         <rdar://problem/47201706>
410
411         Reviewed by Alex Christensen.
412
413         Many .xcfilelist files were added in r238824 in order to support
414         XCBuild. Update these with recent changes to the set of build files
415         and with the current generate-xcfilelist script.
416
417         * DumpRenderTree/DerivedSources-input.xcfilelist:
418         * DumpRenderTree/DerivedSources-output.xcfilelist:
419         * WebKitTestRunner/DerivedSources-input.xcfilelist:
420         * WebKitTestRunner/DerivedSources-output.xcfilelist:
421
422 2019-01-25  Keith Rollin  <krollin@apple.com>
423
424         Fix missing dependencies in extract-dependencies-from-makefile
425         https://bugs.webkit.org/show_bug.cgi?id=193783
426         <rdar://problem/47201571>
427
428         Reviewed by Alex Christensen.
429
430         The extract-dependencies-from-makefile script generates .xcfilelists
431         for XCBuild by invoking a makefile in --debug mode, parsing the
432         dependency information in the output, and extracting information
433         regarding targets and dependents. However, the way `make` emits this
434         dependency information is not rigorous, and so we need to determine
435         what lines to look for and parse by trial and error. This approach
436         didn't coriginally atch all the information we needed to collect, so
437         update the script to look for the additional lines we now know to look
438         for.
439
440         * Scripts/extract-dependencies-from-makefile:
441         (Parser):
442         (Parser.addTarget):
443         (Parser.addPrereq):
444         (Parser.doParse):
445
446 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
447
448         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
449         https://bugs.webkit.org/show_bug.cgi?id=193297
450         <rdar://problem/47158841>
451
452         Reviewed by Alex Christensen.
453
454         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
455             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
456         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
457         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
458         activating the message used to trigger the callback when it is set.
459
460 2019-01-25  Alex Christensen  <achristensen@webkit.org>
461
462         WKWebView.goBack should reload if there is a safe browsing warning
463         https://bugs.webkit.org/show_bug.cgi?id=193805
464         <rdar://problem/46908216>
465
466         Reviewed by Geoff Garen.
467
468         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
469         (+[Simple3LookupContext sharedLookupContext]):
470         (-[Simple3LookupContext lookUpURL:completionHandler:]):
471         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
472         (TEST):
473
474 2019-01-25  Chris Dumez  <cdumez@apple.com>
475
476         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
477         https://bugs.webkit.org/show_bug.cgi?id=193788
478         <rdar://problem/47531231>
479
480         Reviewed by Alex Christensen.
481
482         Add API test coverage.
483
484         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
485         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
486
487 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
488
489         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
490         https://bugs.webkit.org/show_bug.cgi?id=193771
491
492         Unreviewed infrastructure fix.
493
494         * Scripts/webkitpy/port/darwin.py:
495         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
496
497 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
498
499         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
500
501 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
502
503         Add contributors.json entries for Ling Ho and for a new bot watchers group.
504
505         * Scripts/webkitpy/common/config/contributors.json:
506
507 2019-01-25  Chris Dumez  <cdumez@apple.com>
508
509         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
510         https://bugs.webkit.org/show_bug.cgi?id=193779
511         <rdar://problem/46170903>
512
513         Reviewed by Antti Koivisto.
514
515         Add API test that quickly navigates forward to a previous process without waiting for it to
516         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
517         the process' previous page when reconnecting the it for the forward navigation.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
520
521 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
522
523         Need a way for JavaScript (or bundle) code to participate in undo
524         https://bugs.webkit.org/show_bug.cgi?id=190009
525         <rdar://problem/44807048>
526
527         Reviewed by Ryosuke Niwa.
528
529         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
530         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
531
532         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
533         (WTR::UIScriptController::lastUndoLabel const):
534         (WTR::UIScriptController::firstRedoLabel const):
535         (WTR::UIScriptController::platformUndoManager const):
536         * DumpRenderTree/mac/UIScriptControllerMac.mm:
537         (WTR::UIScriptController::lastUndoLabel const):
538         (WTR::UIScriptController::firstRedoLabel const):
539         (WTR::UIScriptController::platformUndoManager const):
540         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
541         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
542         (WTR::UIScriptController::lastUndoLabel const):
543         (WTR::UIScriptController::firstRedoLabel const):
544         * TestRunnerShared/UIScriptContext/UIScriptController.h:
545         * WebKitTestRunner/UIScriptControllerCocoa.mm:
546         (WTR::UIScriptController::lastUndoLabel const):
547         (WTR::UIScriptController::firstRedoLabel const):
548         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
549         (WTR::UIScriptController::platformUndoManager const):
550         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
551         (WTR::UIScriptController::platformUndoManager const):
552
553 2019-01-25  Zalan Bujtas  <zalan@apple.com>
554
555         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
556         https://bugs.webkit.org/show_bug.cgi?id=193824
557
558         Reviewed by Antti Koivisto.
559
560         * LayoutReloaded/misc/LFC-passing-tests.txt:
561
562 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
563
564         Update macOS JSC bot configurations
565         https://bugs.webkit.org/show_bug.cgi?id=193739
566
567         Reviewed by Alexey Proskuryakov.
568
569         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
571         (BubbleQueueServer): Move JSC EWS to Mojave section.
572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
573         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
574         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
575
576 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
577
578         [Win][WebKitTestRunner] Implement EventSenderProxy
579         https://bugs.webkit.org/show_bug.cgi?id=193755
580
581         Reviewed by Don Olmstead.
582
583         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
584         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
585         (WTR::EventSenderProxy::dispatchMessage):
586         (WTR::EventSenderProxy::EventSenderProxy):
587         (WTR::EventSenderProxy::mouseDown):
588         (WTR::EventSenderProxy::mouseUp):
589         (WTR::EventSenderProxy::mouseMoveTo):
590         (WTR::EventSenderProxy::mouseScrollBy):
591         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
592
593 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
594
595         Unreviewed fix for API test failure after r240437.
596
597         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
598
599         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
600
601 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
602
603         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
604         https://bugs.webkit.org/show_bug.cgi?id=193787
605         <rdar://problem/47497634>
606
607         Reviewed by Alexey Proskuryakov.
608
609         * Scripts/webkitdirs.pm:
610         (iosSimulatorApplicationsPath): Pick from available runtime directories.
611
612 2019-01-24  Truitt Savell  <tsavell@apple.com>
613
614         Unreviewed, rolling out r240446.
615
616         Casued 5 API failures
617
618         Reverted changeset:
619
620         "Activate the WebResourceLoadStatisticsStore in the
621         NetworkProcess and deactivate it in the UIProcess."
622         https://bugs.webkit.org/show_bug.cgi?id=193297
623         https://trac.webkit.org/changeset/240446
624
625 2019-01-24  Zalan Bujtas  <zalan@apple.com>
626
627         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
628         https://bugs.webkit.org/show_bug.cgi?id=193741
629         <rdar://problem/47135030>
630
631         Reviewed by Antti Koivisto and Simon Fraser.
632
633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
634         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
635         (TestWebKitAPI::TEST):
636
637 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
638
639         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
640         https://bugs.webkit.org/show_bug.cgi?id=193297
641         <rdar://problem/47158841>
642
643         Reviewed by Alex Christensen.
644
645         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
646         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
647         activating the message used to trigger the callback when it is set.
648
649 2019-01-24  John Wilander  <wilander@apple.com>
650
651         Add Ad Click Attribution as an internal/experimental feature
652         https://bugs.webkit.org/show_bug.cgi?id=193685
653         <rdar://problem/47450399>
654
655         Reviewed by Brent Fulgham.
656
657         Added test option adClickAttributionEnabled.
658
659         * DumpRenderTree/TestOptions.cpp:
660         (TestOptions::TestOptions):
661         * DumpRenderTree/TestOptions.h:
662         * DumpRenderTree/mac/DumpRenderTree.mm:
663         (setWebPreferencesForTestOptions):
664
665 2019-01-24  Antti Koivisto  <antti@apple.com>
666
667         [PSON] Flash on back navigation on Mac
668         https://bugs.webkit.org/show_bug.cgi?id=193716
669         <rdar://problem/47148458>
670
671         Reviewed by Chris Dumez.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
674
675         Closing of the previous page is delayed so waiting for didFinishNavigation is
676         not sufficient to guarantee we have received all the messages. Wait for them.
677
678 2019-01-24  Chris Dumez  <cdumez@apple.com>
679
680         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
681         https://bugs.webkit.org/show_bug.cgi?id=193761
682         <rdar://problem/47456405>
683
684         Reviewed by Alex Christensen.
685
686         Add API test coverage.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
689
690 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
691
692         webkitpy: Missing PID in crashlog name should not be fatal
693         https://bugs.webkit.org/show_bug.cgi?id=193771
694
695         If we can't determine the PID of a crashlog, just ignore the crashlog instead
696         of raising an exception.
697
698         Reviewed by Lucas Forschler.
699
700         * Scripts/webkitpy/port/darwin.py:
701         (DarwinPort._merge_crash_logs):
702
703 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
704
705         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
706         https://bugs.webkit.org/show_bug.cgi?id=193746
707
708         Reviewed by Youenn Fablet.
709
710         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
711         so we'd best just not call it.
712
713         * Scripts/webkitpy/w3c/test_exporter.py:
714         (WebPlatformTestExporter.create_branch_with_patch):
715
716 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
717
718         Move FileSystem to WTF
719         https://bugs.webkit.org/show_bug.cgi?id=193602
720
721         Reviewed by Yusuke Suzuki.
722
723         * DumpRenderTree/win/DumpRenderTree.cpp:
724         * TestWebKitAPI/CMakeLists.txt:
725         * TestWebKitAPI/PlatformGTK.cmake:
726         * TestWebKitAPI/PlatformJSCOnly.cmake:
727         * TestWebKitAPI/PlatformPlayStation.cmake:
728         * TestWebKitAPI/PlatformWPE.cmake:
729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
730         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
731         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
732         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
733         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
734         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
735         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
736         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
737         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
738         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
739
740 2019-01-24  Philippe Normand  <pnormand@igalia.com>
741
742         [WPE] Remove hard dependency on subprocess32 for the API tests
743
744         Rubber-stamped by Carlos Garcia Campos.
745
746         * glib/api_test_runner.py:
747         (TestRunner._run_test_qt): Lazily import subprocess32 and check
748         its presence only when running WPEQt tests.
749
750 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
751
752         [GLIB] Expose JavaScriptCore options in GLib public API
753         https://bugs.webkit.org/show_bug.cgi?id=188742
754
755         Reviewed by Michael Catanzaro.
756
757         Add a test for the new API.
758
759         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
760         (testsJSCOptions):
761         (main):
762
763 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
764
765         [GTK][WPE] Support JPEG 2000 images
766         https://bugs.webkit.org/show_bug.cgi?id=186272
767
768         Reviewed by Žan Doberšek.
769
770         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
771
772         * gtk/jhbuild.modules:
773         * wpe/jhbuild.modules:
774
775 2019-01-23  David Kilzer  <ddkilzer@apple.com>
776
777         check-webkit-style should warn when using soft-linking macros in a header
778         <https://webkit.org/b/193750>
779
780         Reviewed by Darin Adler.
781
782         * Scripts/webkitpy/style/checkers/cpp.py:
783         (check_language): Add softlink/header check by refactoring the
784         softlink/framework check.
785         (CppChecker): Enable softlink/header check by default.
786         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
787         (CppStyleTest.test_softlink_framework): Rename from
788         CppStyleTest.test_softlink() and change test framework name in
789         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
790         files. Set file_name for macros that only appear in headers.
791         (CppStyleTest.test_softlink_header): Add tests for using
792         soft-link macros in headers.
793
794 2019-01-23  Chris Dumez  <cdumez@apple.com>
795
796         Deprecate API to limit the maximum number of WebProcesses
797         https://bugs.webkit.org/show_bug.cgi?id=193725
798         <rdar://problem/47464879>
799
800         Reviewed by Geoff Garen.
801
802         Update existing API tests to stop using deprecated API.
803
804         * MiniBrowser/mac/AppDelegate.m:
805         (defaultConfiguration):
806         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
807         (TestWebKitAPI::TEST):
808         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
809         (TestWebKitAPI::TEST):
810         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
811         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
812         (TEST):
813         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
814         (TEST):
815
816 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
817
818         [ews-app] Rename ews model buildermappings to buildermapping
819         https://bugs.webkit.org/show_bug.cgi?id=193729
820
821         Reviewed by Lucas Forschler.
822
823         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
824         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
825         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
826
827 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
828
829         [ews-app] Rename ews model steps to step
830         https://bugs.webkit.org/show_bug.cgi?id=193697
831
832         Reviewed by Lucas Forschler.
833
834         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
835         (Step): Renamed Steps to Step.
836
837 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
838
839         Clean up IndexedDB files between tests
840         https://bugs.webkit.org/show_bug.cgi?id=192796
841         <rdar://problem/46824999>
842
843         Reviewed by Geoffrey Garen.
844
845         * DumpRenderTree/mac/DumpRenderTree.mm:
846         (runTest):
847         * WebKitTestRunner/TestController.cpp:
848         (WTR::TestController::resetStateToConsistentValues):
849         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
850         (WTR::RemoveAllIndexedDatabasesCallback):
851         (WTR::TestController::ClearIndexedDatabases):
852         * WebKitTestRunner/TestController.h:
853         * WebKitTestRunner/TestInvocation.cpp:
854         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
855
856 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
857
858         [ews-app] Rename ews model Builds to Build
859         https://bugs.webkit.org/show_bug.cgi?id=193695
860
861         Reviewed by Lucas Forschler.
862
863         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
864         (Build): Renamed Builds to Build.
865
866 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
867
868         webkitpy: Wait longer when launching WebKitTestRunner
869         https://bugs.webkit.org/show_bug.cgi?id=193734
870
871         Reviewed by Aakash Jain.
872
873         * Scripts/webkitpy/port/simulator_process.py:
874         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
875
876 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
877
878         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
879         https://bugs.webkit.org/show_bug.cgi?id=193182
880         <rdar://problem/47452154>
881
882         Reviewed by Tim Horton.
883
884         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
885         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
886         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
887
888         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
889         preventing later tests from recognizing gestures.
890
891         * WebKitTestRunner/ios/TestControllerIOS.mm:
892         (WTR::TestController::platformResetStateToConsistentValues):
893
894         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
895
896 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
897
898         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
899         https://bugs.webkit.org/show_bug.cgi?id=193722
900         <rdar://problem/47481475>
901
902         Reviewed by Lucas Forschler.
903
904         iPhone and iPad ports should both use the iOS config.
905
906         * Scripts/webkitpy/port/ios_simulator.py:
907         (IPhoneSimulatorPort.__init__):
908         (IPadSimulatorPort.__init__):
909
910 2019-01-23  Rob Buis  <rbuis@igalia.com>
911
912         Update MIME type parser
913         https://bugs.webkit.org/show_bug.cgi?id=180526
914
915         Reviewed by Frédéric Wang.
916
917         Add unit tests for both parse modes of ParsedContentType.
918
919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
920         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
921         (TestWebKitAPI::TEST):
922
923 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
924
925         [ews-app] fetch loop should not stop on network issues
926         https://bugs.webkit.org/show_bug.cgi?id=193666
927
928         Reviewed by Lucas Forschler.
929
930         * BuildSlaveSupport/ews-app/ews/fetcher.py:
931         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
932
933 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
934
935         [iOS] Multiple WKWebViewAutofillTests are flaky failures
936         https://bugs.webkit.org/show_bug.cgi?id=189165
937         <rdar://problem/47433765>
938
939         Reviewed by Tim Horton.
940
941         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
942         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
943         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
944         process in sufficient to ensure that any previous action that blurred the focused element in the web process
945         would make its way to the UI process by the time the layer tree commit is finished.
946
947         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
948         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
949         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
950         will fail because it asks for -_autofillContext too early.
951
952         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
953         is handled in the UI process.
954
955         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
956
957         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
958         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
959         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
960         input session.
961
962         (-[AutofillTestView textInputHasAutofillContext]):
963
964         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
965
966         * TestWebKitAPI/cocoa/TestWKWebView.h:
967         * TestWebKitAPI/cocoa/TestWKWebView.mm:
968         (nextInputSessionChangeCount):
969
970         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
971         This includes changing the focused element from one to another.
972
973         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
974         (-[TestWKWebView didStartFormControlInteraction]):
975         (-[TestWKWebView didEndFormControlInteraction]):
976         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
977
978         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
979         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
980         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
981         that doesn't require an input session to one that doesn't.
982
983 2019-01-22  David Kilzer  <ddkilzer@apple.com>
984
985         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
986         <https://webkit.org/b/193676>
987
988         Reviewed by Alexey Proskuryakov.
989
990         * Scripts/webkitpy/style/checkers/cpp.py:
991         (check_member_initialization_list):
992         - Don't report missing whitespace around colon if the colon at
993           the start of the line is formatted correctly.
994         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
995         (WebKitStyleTest.test_member_initialization_list):
996         - Add a test for a missing permutation of existing tests.
997         - Add a test this false-positive.
998         - Add blank lines between subtests to make them easier to read.
999
1000 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [build.webkit.org] Unit-test failure after r237113
1003         https://bugs.webkit.org/show_bug.cgi?id=193669
1004
1005         Reviewed by Michael Catanzaro.
1006
1007         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1008         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1009         multiple or zero flags.
1010
1011 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1012
1013         Cache bytecode to disk
1014         https://bugs.webkit.org/show_bug.cgi?id=192782
1015         <rdar://problem/46084932>
1016
1017         Reviewed by Keith Miller.
1018
1019         Add test helper to execute bytecode-cache tests: it executes each test
1020         twice, the first with JSC_diskCachePath set to a temporary directory
1021         and second with JSC_forceDiskCache=true (in addition to the cache path)
1022         to guarantee that only the disk cache is being used and no new
1023         UnlinkedCodeBlocks are being created.
1024
1025         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1026         * Scripts/run-jsc-stress-tests:
1027
1028 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1029
1030         [css-logical] Implement flow-relative margin, padding and border shorthands
1031         https://bugs.webkit.org/show_bug.cgi?id=188697
1032
1033         Reviewed by Simon Fraser and Antti Koivisto.
1034
1035         * DumpRenderTree/TestOptions.cpp:
1036         (TestOptions::TestOptions):
1037         * DumpRenderTree/TestOptions.h:
1038         * DumpRenderTree/mac/DumpRenderTree.mm:
1039         (setWebPreferencesForTestOptions):
1040         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1041
1042         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1043         (JSONCSSPropertiesChecker.check_codegen_properties):
1044         Allow CSS property definitions to have a 'runtime-flag' parameter which
1045         disables the property when the specified runtime flag is disabled.
1046
1047 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1048
1049         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1050         https://bugs.webkit.org/show_bug.cgi?id=193643
1051
1052         Reviewed by Michael Catanzaro.
1053
1054         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1055         * wpe/jhbuild.modules: Ditto.
1056
1057 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1058
1059         [LFC][Floats] Take float top position into account when computing containing block height.
1060         https://bugs.webkit.org/show_bug.cgi?id=193655
1061
1062         Reviewed by Antti Koivisto.
1063
1064         * LayoutReloaded/misc/LFC-passing-tests.txt:
1065
1066 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1067
1068         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1069         <https://webkit.org/b/193645>
1070         <rdar://problem/47421574>
1071
1072         Reviewed by Alex Christensen.
1073
1074         - Now checks for local soft-linking of all frameworks that have
1075           their own *SoftLinking.{cpp,h,mm} files.
1076         - Changes softlink/uikit warning to softlink/framework.
1077
1078         * Scripts/webkitpy/style/checkers/cpp.py:
1079         (check_language):
1080         (CppChecker):
1081         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1082         (CppStyleTest):
1083
1084 2019-01-20  Saam Barati  <sbarati@apple.com>
1085
1086         Rollout r240210: It broke tests on iOS
1087         https://bugs.webkit.org/show_bug.cgi?id=193640
1088
1089         Unreviewed.
1090
1091         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1092         * Scripts/run-jsc-stress-tests:
1093
1094 2019-01-20  chris fleizach  <cfleizach@apple.com>
1095
1096         AX: Support returning relative frames for accessibility
1097         https://bugs.webkit.org/show_bug.cgi?id=193414
1098         <rdar://problem/47268501>
1099
1100         Reviewed by Zalan Bujtas.
1101
1102         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1103         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1104         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1105         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1106         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1107         (WTR::attributesOfElement):
1108         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1109
1110 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1111
1112         Unreviewed, add my new email address
1113
1114         * Scripts/webkitpy/common/config/contributors.json:
1115
1116 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1117
1118         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1119         https://bugs.webkit.org/show_bug.cgi?id=193617
1120
1121         Reviewed by Antti Koivisto.
1122
1123         * LayoutReloaded/misc/LFC-passing-tests.txt:
1124
1125 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1126
1127         Unreviewed, rolling out r240209.
1128
1129         Broke GTK/WPE injected bundle
1130
1131         Reverted changeset:
1132
1133         "AX: Support returning relative frames for accessibility"
1134         https://bugs.webkit.org/show_bug.cgi?id=193414
1135         https://trac.webkit.org/changeset/240209
1136
1137 2019-01-12  Dan Bernstein  <mitz@apple.com>
1138
1139         [Cocoa] Avoid importing directly from subumbrella frameworks
1140         https://bugs.webkit.org/show_bug.cgi?id=186016
1141         <rdar://problem/40591038>
1142
1143         Reviewed by Sam Weinig.
1144
1145         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1146           LaunchServices header.
1147         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1148           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1149         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1150           when using SDKs earlier than 10.13.
1151         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1152           and OTHER_CPLUSPLUSFLAGS.
1153         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1154           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1155         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1156           LaunchServices header.
1157
1158 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1159
1160         Cache bytecode to disk
1161         https://bugs.webkit.org/show_bug.cgi?id=192782
1162         <rdar://problem/46084932>
1163
1164         Reviewed by Keith Miller.
1165
1166         Add test helper to execute bytecode-cache tests: it executes each test
1167         twice, the first with JSC_diskCachePath set to a temporary directory
1168         and second with JSC_forceDiskCache=true (in addition to the cache path)
1169         to guarantee that only the disk cache is being used and no new
1170         UnlinkedCodeBlocks are being created.
1171
1172         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1173         * Scripts/run-jsc-stress-tests:
1174
1175 2019-01-20  chris fleizach  <cfleizach@apple.com>
1176
1177         AX: Support returning relative frames for accessibility
1178         https://bugs.webkit.org/show_bug.cgi?id=193414
1179         <rdar://problem/47268501>
1180
1181         Reviewed by Zalan Bujtas.
1182
1183         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1184         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1185         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1186         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1187         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1188         (WTR::attributesOfElement):
1189         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1190
1191 2019-01-20  Antoine Quint  <graouts@apple.com>
1192
1193         Add a POINTER_EVENTS feature flag
1194         https://bugs.webkit.org/show_bug.cgi?id=193577
1195         <rdar://problem/47408511>
1196
1197         Unreviewed. Also enable Pointer Events for iosmac.
1198
1199         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1200
1201 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1202
1203         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1204         https://bugs.webkit.org/show_bug.cgi?id=193613
1205
1206         Reviewed by Antti Koivisto.
1207
1208         * LayoutReloaded/misc/LFC-passing-tests.txt:
1209
1210 2019-01-19  Antoine Quint  <graouts@apple.com>
1211
1212         Add a POINTER_EVENTS feature flag
1213         https://bugs.webkit.org/show_bug.cgi?id=193577
1214
1215         Reviewed by Dean Jackson.
1216
1217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1218
1219 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1220
1221         Disable the run-jsc-stress-test remote host key check [second round].
1222         https://bugs.webkit.org/show_bug.cgi?id=192988
1223
1224         Reviewed by Dewei Zhu.
1225
1226         * Scripts/run-jsc-stress-tests:
1227
1228 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1229
1230         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1231         https://bugs.webkit.org/show_bug.cgi?id=193597
1232
1233         Reviewed by Lucas Forschler.
1234
1235         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1236
1237 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1240         https://bugs.webkit.org/show_bug.cgi?id=193595
1241
1242         Reviewed by Lucas Forschler.
1243
1244         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1245         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1246         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1247
1248 2019-01-18  Chris Dumez  <cdumez@apple.com>
1249
1250         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1251         https://bugs.webkit.org/show_bug.cgi?id=193588
1252         <rdar://problem/47131566>
1253
1254         Reviewed by Alex Christensen.
1255
1256         Add layout test coverage.
1257
1258         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1259
1260 2019-01-18  Jer Noble  <jer.noble@apple.com>
1261
1262         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1263         https://bugs.webkit.org/show_bug.cgi?id=189553
1264
1265         Reviewed by Tim Horton.
1266
1267         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1268
1269         * ContentExtensionTester/Configurations/Base.xcconfig:
1270         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1271         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1272         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1273         * ImageDiff/cg/Configurations/Base.xcconfig:
1274         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1275         * MiniBrowser/Configurations/Base.xcconfig:
1276         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1277         * MobileMiniBrowser/Configurations/Base.xcconfig:
1278         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1279         * Scripts/webkitpy/style/checker.py:
1280         (_all_categories):
1281         (FileType):
1282         (CheckerDispatcher._file_type):
1283         (CheckerDispatcher._create_checker):
1284         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1285         (SDKVariantChecker):
1286         (SDKVariantChecker.__init__):
1287         (SDKVariantChecker.check):
1288         * TestWebKitAPI/Configurations/Base.xcconfig:
1289         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1290         * WebEditingTester/Configurations/Base.xcconfig:
1291         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1292         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1293         * WebKitTestRunner/Configurations/Base.xcconfig:
1294         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1295         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1296         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1297
1298 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1299
1300         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1301         <https://webkit.org/b/193568>
1302         <rdar://problem/47381130>
1303
1304         Reviewed by Alex Christensen.
1305
1306         Make sure no one re-introduces UIKit soft-linking by adding a
1307         style rule.
1308
1309         * Scripts/webkitpy/style/checkers/cpp.py:
1310         (check_language): Add softlink/uikit check.
1311         (CppChecker): Enable softlink/uikit check.
1312         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1313         (CppStyleTest): Add test for softlink/uikit.
1314
1315 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1316
1317         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1318         https://bugs.webkit.org/show_bug.cgi?id=193584
1319
1320         Change "-dev" to "-devel".
1321
1322         Reviewed by Michael Catanzaro.
1323
1324         * gtk/install-dependencies:
1325
1326 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1327
1328         webkitpy: Add iPhone and iPad ports
1329         https://bugs.webkit.org/show_bug.cgi?id=193537
1330         <rdar://problem/47353390>
1331
1332         Reviewed by Lucas Forschler.
1333
1334         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1335         ports. Note that this separation is optional, the --ios-simulator command remains.
1336
1337         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1338         (RunTest.test_device_type_test_division): Drive-by fix.
1339         (RunTest.test_device_type_specific_listing): Ditto.
1340         (RunTest.test_ipad_test_division):
1341         (RunTest):
1342         (RunTest.test_ipad_listing):
1343         * Scripts/webkitpy/port/factory.py:
1344         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1345         (PortFactory):
1346         * Scripts/webkitpy/port/ios_simulator.py:
1347         (IPhoneSimulatorPort):
1348         (IPadSimulatorPort):
1349
1350 2019-01-18  Chris Dumez  <cdumez@apple.com>
1351
1352         Regression(PSON) Scroll position is not always restored properly when navigating back
1353         https://bugs.webkit.org/show_bug.cgi?id=193578
1354         <rdar://problem/47386331>
1355
1356         Reviewed by Tim Horton.
1357
1358         Add API test coverage.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1361
1362 2019-01-18  Youenn Fablet  <youenn@apple.com>
1363
1364         Add a new SPI to request for cache storage quota increase
1365         https://bugs.webkit.org/show_bug.cgi?id=193323
1366
1367         Reviewed by Alex Christensen.
1368
1369         Implement WebsiteDataStore quota delegate to handle quota requests.
1370         By default, do not update quota.
1371         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1372
1373         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1374         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1375         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1376         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1377         * WebKitTestRunner/TestController.cpp:
1378         (WTR::TestController::allowCacheStorageQuotaIncrease):
1379         * WebKitTestRunner/TestController.h:
1380         * WebKitTestRunner/TestInvocation.cpp:
1381         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1382         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1383         (-[CacheStorageQuotaManager init]):
1384         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1385         (WTR::initializeWebViewConfiguration):
1386         (WTR::TestController::cocoaResetStateToConsistentValues):
1387         (WTR::TestController::allowCacheStorageQuotaIncrease):
1388
1389 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1390
1391         [ews-build] Pass owner to the triggered builds
1392         https://bugs.webkit.org/show_bug.cgi?id=193574
1393
1394         Reviewed by Lucas Forschler.
1395
1396         * BuildSlaveSupport/ews-build/factories.py:
1397         (BuildFactory.propertiesToPassToTriggers):
1398
1399 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1400
1401         [ews-app] Send patch author as a build property
1402         https://bugs.webkit.org/show_bug.cgi?id=193560
1403
1404         Reviewed by Lucas Forschler.
1405
1406         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1407         (BugzillaPatchFetcher.fetch):
1408
1409 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1410
1411         webkitpy: Implement device type specific expected results (Follow-up fix)
1412         https://bugs.webkit.org/show_bug.cgi?id=192162
1413         <rdar://problem/46345449>
1414
1415         Unreviewed infrastructure fix.
1416
1417         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1418         (Manager.run): Don't boot a device if no tests are available to run on it.
1419
1420 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1421
1422         webkitpy: Implement device type specific expected results (Follow-up fix)
1423         https://bugs.webkit.org/show_bug.cgi?id=192162
1424         <rdar://problem/46345449>
1425
1426         Unreviewed infrastructure fix.
1427
1428         * Scripts/webkitpy/api_tests/manager.py:
1429         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1430
1431 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1432
1433         webkitpy: Implement device type specific expected results (Part 2)
1434         https://bugs.webkit.org/show_bug.cgi?id=192162
1435         <rdar://problem/46345449>
1436
1437         Rubber-stamped by Aakash Jain.
1438
1439         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1440         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1441         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1442
1443         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1444         (LayoutTestFinder.find_tests): Pass device_type through.
1445         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1446         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1447         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1448         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1449         (Manager._collect_tests): Pass device type to test finder.
1450         (Manager._needs_web_platform_test):
1451         (Manager._prepare_lists): Index _expectations by device type.
1452         (Manager._test_input_for_file):
1453         (Manager._test_is_slow): Ditto.
1454         (Manager._test_should_dump_jsconsolelog_in_stderr):
1455         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1456         (Manager._get_test_inputs):
1457         (Manager._update_worker_count):
1458         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1459         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1460         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1461         the one which runs the test.
1462         (Manager._run_test_subset):
1463         (Manager._run_tests): Index _expectations by current_device_type.
1464         (Manager._print_expectation_line_for_test): Ditto.
1465         (Manager._print_expectations_for_subset): Ditto.
1466         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1467         Unlike run, this function will behave the same regardless of what devices are available.
1468         (Manager._custom_device_for_test): Deleted.
1469         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1470         (ManagerTest.test_uses_custom_device): Deleted.
1471         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1472         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1473         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1474         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1475         all of the expectations.
1476         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1477         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1478         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1479         (TestExpectations.__init__): Allow device_type to be passed through.
1480         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1481         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1482         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1483         (summarize_results):
1484         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1485         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1486         a test ran with, one must check all expectations to find the first non-skip expectation.
1487         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1488         (RunTest.test_device_type_test_division):
1489         (RunTest):
1490         (RunTest.test_device_type_specific_listing):
1491         * Scripts/webkitpy/port/base.py:
1492         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1493         (Port.supported_device_types): The result of this function will change based on what devices are available.
1494         * Scripts/webkitpy/port/device_port.py:
1495         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1496         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1497         can be used.
1498         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1499         any, or the DEFAULT_DEVICE_TYPES of the port.
1500         * Scripts/webkitpy/port/ios.py:
1501         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1502         * Scripts/webkitpy/port/ios_simulator.py:
1503         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1504         * Scripts/webkitpy/port/watch.py:
1505         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1506         * Scripts/webkitpy/port/watch_simulator.py:
1507         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1508         * Scripts/webkitpy/xcode/device_type.py:
1509         (DeviceType):
1510         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1511
1512 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1513
1514         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1515         https://bugs.webkit.org/show_bug.cgi?id=193575
1516
1517         Reviewed by Michael Catanzaro.
1518
1519         Allow the script to run without explicit port argument because
1520         it's specific to the WPE port anyway.
1521
1522         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1523         and simplify the rest of the code accordingly.
1524
1525 2019-01-18  Charlie Turner  <cturner@igalia.com>
1526
1527         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1528         https://bugs.webkit.org/show_bug.cgi?id=192229
1529
1530         Reviewed by Xabier Rodriguez-Calvar.
1531
1532         * MiniBrowser/wpe/main.cpp:
1533         (main): Enable encrypted-media by default.
1534
1535 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1536
1537         [Flatpak] Missing KeyboardInterrupt exception handler
1538         https://bugs.webkit.org/show_bug.cgi?id=193570
1539
1540         Reviewed by Michael Catanzaro.
1541
1542         * flatpak/flatpakutils.py:
1543         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1544
1545 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1546
1547         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1548         https://bugs.webkit.org/show_bug.cgi?id=193564
1549
1550         Reviewed by Antti Koivisto.
1551
1552         * LayoutReloaded/misc/LFC-passing-tests.txt:
1553
1554 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1555
1556         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1557         https://bugs.webkit.org/show_bug.cgi?id=193562
1558
1559         Reviewed by Antti Koivisto.
1560
1561         * LayoutReloaded/misc/LFC-passing-tests.txt:
1562
1563 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1564
1565         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1566         https://bugs.webkit.org/show_bug.cgi?id=193555
1567
1568         Reviewed by Antti Koivisto.
1569
1570         * LayoutReloaded/misc/LFC-passing-tests.txt:
1571
1572 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1573
1574         [WPE] Add Qt extension
1575         https://bugs.webkit.org/show_bug.cgi?id=191464
1576
1577         Reviewed by Carlos Garcia Campos.
1578
1579         MiniBrowser and API tests for the WPE Qt API. To run the
1580         MiniBrowser a new script is introduced. Example invocation:
1581
1582         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1583
1584         Also note-worthy is the introduction of the python2-subprocess32
1585         dependency to run the GLib API tests.
1586
1587         * MiniBrowser/wpe/CMakeLists.txt:
1588         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1589         * MiniBrowser/wpe/qt/main.cpp: Added.
1590         (main):
1591         * MiniBrowser/wpe/qt/main.qml: Added.
1592         * MiniBrowser/wpe/qt/qml.qrc: Added.
1593         * Scripts/run-gtk-tests:
1594         (GtkTestRunner.is_google_test):
1595         (GtkTestRunner):
1596         (GtkTestRunner.is_qt_test):
1597         * Scripts/run-qt-wpe-minibrowser: Added.
1598         * Scripts/run-wpe-tests:
1599         (WPETestRunner):
1600         (WPETestRunner.is_google_test):
1601         (WPETestRunner.is_qt_test):
1602         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1603         (TestLoad::main):
1604         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1605         (TestLoadHtml::main):
1606         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1607         (TestLoadRequest::main):
1608         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1609         (TestRunJavaScript::main):
1610         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1611         (waitForSignal):
1612         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1613         (LoadSpy::LoadSpy):
1614         (LoadSpy::~LoadSpy):
1615         (LoadSpy::onLoadingChanged):
1616         (LoadStartedCatcher::LoadStartedCatcher):
1617         (LoadStartedCatcher::~LoadStartedCatcher):
1618         (LoadStartedCatcher::onLoadingChanged):
1619         (waitForLoadSucceeded):
1620         (waitForLoadFailed):
1621         * TestWebKitAPI/glib/CMakeLists.txt:
1622         * flatpak/flatpakutils.py:
1623         (WebkitFlatpak.load_from_args):
1624         (WebkitFlatpak.__init__):
1625         (WebkitFlatpak.clean_args):
1626         (WebkitFlatpak.run_in_sandbox):
1627         * flatpak/org.webkit.CommonModules.yaml:
1628         * flatpak/org.webkit.WPE.yaml:
1629         * flatpak/org.webkit.WPEModules.yaml:
1630         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1631         * flatpak/org.webkit.WebKit.yaml:
1632         * glib/api_test_runner.py:
1633         (TestRunner._run_test_qt):
1634         (TestRunner.is_qt_test):
1635         (TestRunner._run_test):
1636
1637 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1638
1639         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1640         https://bugs.webkit.org/show_bug.cgi?id=193494
1641         <rdar://problem/46859627>
1642
1643         Reviewed by Simon Fraser and Tim Horton.
1644
1645         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1646         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1647
1648         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1649         (WTR::UIScriptController::contentOffsetX const):
1650         (WTR::UIScriptController::contentOffsetY const):
1651         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1652         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1653         (WTR::UIScriptController::contentOffsetX const):
1654         (WTR::UIScriptController::contentOffsetY const):
1655         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1656
1657         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1658
1659         * WebKitTestRunner/TestController.cpp:
1660         (WTR::updateTestOptionsFromTestHeader):
1661         * WebKitTestRunner/TestOptions.h:
1662         (WTR::TestOptions::hasSameInitializationOptions const):
1663         * WebKitTestRunner/ios/TestControllerIOS.mm:
1664         (WTR::TestController::platformResetStateToConsistentValues):
1665         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1666         (WTR::UIScriptController::contentOffsetX const):
1667         (WTR::UIScriptController::contentOffsetY const):
1668
1669 2019-01-17  Truitt Savell  <tsavell@apple.com>
1670
1671         Unreviewed, rolling out r240124.
1672
1673         This commit broke an internal build.
1674
1675         Reverted changeset:
1676
1677         "SDK_VARIANT build destinations should be separate from non-
1678         SDK_VARIANT builds"
1679         https://bugs.webkit.org/show_bug.cgi?id=189553
1680         https://trac.webkit.org/changeset/240124
1681
1682 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1683
1684         Fix string concatenation API test after r239920
1685         https://bugs.webkit.org/show_bug.cgi?id=193551
1686         <rdar://problem/47359304>
1687
1688         Reviewed by Youenn Fablet.
1689
1690         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1691         (TestWebKitAPI::TEST):
1692         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1693         in WebKit's build configuration like it apparently is on Linux.
1694
1695 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1696
1697         [ews-build] validate-patch should handle the case when bug_id is None
1698         https://bugs.webkit.org/show_bug.cgi?id=193547
1699
1700         Reviewed by Lucas Forschler.
1701
1702         * BuildSlaveSupport/ews-build/steps.py:
1703         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1704         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1705
1706 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1707
1708         [ews-build] Add patch author information in build
1709         https://bugs.webkit.org/show_bug.cgi?id=193465
1710
1711         Reviewed by Lucas Forschler.
1712
1713         * BuildSlaveSupport/ews-build/steps.py:
1714         (ValidatePatch._is_patch_obsolete):
1715
1716 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1717
1718         [ews-build] Pass bug_id to the triggered builds
1719         https://bugs.webkit.org/show_bug.cgi?id=193548
1720
1721         Reviewed by Lucas Forschler.
1722
1723         * BuildSlaveSupport/ews-build/factories.py:
1724         (BuildFactory.propertiesToPassToTriggers):
1725
1726 2019-01-17  Jer Noble  <jer.noble@apple.com>
1727
1728         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1729         https://bugs.webkit.org/show_bug.cgi?id=189553
1730
1731         Reviewed by Tim Horton.
1732
1733         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1734
1735         * ContentExtensionTester/Configurations/Base.xcconfig:
1736         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1737         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1738         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1739         * ImageDiff/cg/Configurations/Base.xcconfig:
1740         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1741         * MiniBrowser/Configurations/Base.xcconfig:
1742         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1743         * MobileMiniBrowser/Configurations/Base.xcconfig:
1744         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1745         * Scripts/webkitpy/style/checker.py:
1746         (_all_categories):
1747         (FileType):
1748         (CheckerDispatcher._file_type):
1749         (CheckerDispatcher._create_checker):
1750         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1751         (SDKVariantChecker):
1752         (SDKVariantChecker.__init__):
1753         (SDKVariantChecker.check):
1754         * TestWebKitAPI/Configurations/Base.xcconfig:
1755         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1756         * WebEditingTester/Configurations/Base.xcconfig:
1757         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1758         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1759         * WebKitTestRunner/Configurations/Base.xcconfig:
1760         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1761         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1762         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1763
1764 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1765
1766         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1767         https://bugs.webkit.org/show_bug.cgi?id=193534
1768
1769         Reviewed by Antti Koivisto.
1770
1771         * LayoutReloaded/misc/LFC-passing-tests.txt:
1772
1773 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1774
1775         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1776         https://bugs.webkit.org/show_bug.cgi?id=193528
1777
1778         Reviewed by Antti Koivisto.
1779
1780         * LayoutReloaded/misc/LFC-passing-tests.txt:
1781
1782 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1783
1784         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1785         https://bugs.webkit.org/show_bug.cgi?id=193520
1786
1787         Reviewed by Antti Koivisto.
1788
1789         * LayoutReloaded/misc/LFC-passing-tests.txt:
1790
1791 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1792
1793         [ews-build] unapply-patch step should not update source
1794         https://bugs.webkit.org/show_bug.cgi?id=193234
1795
1796         Reviewed by Lucas Forschler.
1797
1798         * BuildSlaveSupport/ews-build/steps.py:
1799         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1800         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1801
1802 2019-01-16  Youenn Fablet  <youenn@apple.com>
1803
1804         Add a new SPI for controlling getUserMedia
1805         https://bugs.webkit.org/show_bug.cgi?id=192793
1806
1807         Reviewed by Eric Carlson.
1808
1809         * MiniBrowser/mac/WK2BrowserWindowController.m:
1810         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1811         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1812         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1813         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1814         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1815         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1816         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1817         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1818         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1819         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1820         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1821         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1822         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1823         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1824
1825 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1826
1827         [LFC][BFC] Inflow non-replaced used width should not be negative.
1828         https://bugs.webkit.org/show_bug.cgi?id=193495
1829
1830         Reviewed by Antti Koivisto.
1831
1832         * LayoutReloaded/misc/LFC-passing-tests.txt:
1833
1834 2019-01-16  Chris Dumez  <cdumez@apple.com>
1835
1836         Regression(PSON) View becomes blank after click a cross-site download link
1837         https://bugs.webkit.org/show_bug.cgi?id=193361
1838         <rdar://problem/47099573>
1839
1840         Reviewed by Geoffrey Garen.
1841
1842         Add API test coverage.
1843
1844         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1845         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1846
1847 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1848
1849         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1850         https://bugs.webkit.org/show_bug.cgi?id=193470
1851
1852         Reviewed by Antti Koivisto.
1853
1854         * LayoutReloaded/misc/LFC-passing-tests.txt:
1855
1856 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1857
1858         [LFC] Adjust margin box verification.
1859         https://bugs.webkit.org/show_bug.cgi?id=193482
1860
1861         Reviewed by Antti Koivisto.
1862
1863         * LayoutReloaded/misc/LFC-passing-tests.txt:
1864
1865 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1866
1867         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1868         https://bugs.webkit.org/show_bug.cgi?id=193451
1869
1870         Reviewed by Geoffrey Garen.
1871
1872         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1873         (TEST):
1874         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1875         (runWebsiteDataStoreCustomPaths):
1876
1877 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1878
1879         webkitpy: Support boolean simctl isAvailable
1880         https://bugs.webkit.org/show_bug.cgi?id=193472
1881         <rdar://problem/47296150>
1882
1883         Reviewed by Ryosuke Niwa.
1884
1885         * Scripts/webkitpy/xcode/simulated_device.py:
1886         (SimulatedDeviceManager._create_runtimes):
1887         (SimulatedDeviceManager._create_device_with_runtime):
1888
1889 2019-01-15  Chris Dumez  <cdumez@apple.com>
1890
1891         Unreviewed, rolling out r239993, r239995, r239997, and
1892         r239999.
1893
1894         Caused assertions under
1895         ViewGestureController::disconnectFromProcess()
1896
1897         Reverted changesets:
1898
1899         "Regression(PSON) View becomes blank after click a cross-site
1900         download link"
1901         https://bugs.webkit.org/show_bug.cgi?id=193361
1902         https://trac.webkit.org/changeset/239993
1903
1904         "Unreviewed iOS build fix after r239993."
1905         https://trac.webkit.org/changeset/239995
1906
1907         "Fix iOS build after r239993"
1908         https://bugs.webkit.org/show_bug.cgi?id=193361
1909         https://trac.webkit.org/changeset/239997
1910
1911         "Unreviewed, revert part of r239997 as it is not needed to fix
1912         the build."
1913         https://trac.webkit.org/changeset/239999
1914
1915 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1916
1917         Cannot tab out of WKWebView on macOS
1918         https://bugs.webkit.org/show_bug.cgi?id=161448
1919         <rdar://problem/28100085>
1920
1921         Reviewed by Dean Jackson.
1922
1923         Add a test that tabbing into and out of WKWebView works correctly.
1924
1925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1926         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1927         (WebKit2_CommandBackForwardTest::SetUp):
1928         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1929         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1930         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1931         (-[FocusableView canBecomeKeyView]):
1932         (TEST):
1933         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1934         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1935         (-[OffscreenWindow initWithSize:]):
1936         (-[OffscreenWindow isKeyWindow]):
1937         (-[OffscreenWindow isVisible]):
1938         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1939         (TestWebKitAPI::PlatformWebView::initialize):
1940         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1941         (-[ActiveOffscreenWindow isVisible]): Deleted.
1942         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1943
1944 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1945
1946         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1947         https://bugs.webkit.org/show_bug.cgi?id=193459
1948
1949         Reviewed by Mark Lam.
1950
1951         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1952         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1953
1954 2019-01-15  Chris Dumez  <cdumez@apple.com>
1955
1956         Regression(PSON) View becomes blank after click a cross-site download link
1957         https://bugs.webkit.org/show_bug.cgi?id=193361
1958         <rdar://problem/47099573>
1959
1960         Reviewed by Geoff Garen.
1961
1962         Add API test coverage.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1965         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1966
1967 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1968
1969         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1970         https://bugs.webkit.org/show_bug.cgi?id=193448
1971
1972         Reviewed by Antti Koivisto.
1973
1974         * LayoutReloaded/misc/LFC-passing-tests.txt:
1975
1976 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1977
1978         webkitpy: Implement device type specific expected results (Part 1)
1979         https://bugs.webkit.org/show_bug.cgi?id=192162
1980
1981         Reviewed by Lucas Forschler.
1982
1983         Device type specific expected results covers two related ideas. The first (covered by this change)
1984         is where to search for -expected.* files. The second is which tests to run based on the
1985         TestExpectations.txt file.
1986
1987         After this change, the baseline search path will be determined by the type of device running a
1988         test. Device type will be passed into any function which picks a file based on the baseline search
1989         path.
1990
1991         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1992         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1993         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1994         (Manager.run): Print baseline search path for each round of devices.
1995         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1996         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1997         (SingleTestRunner._expected_driver_output): Ditto.
1998         (SingleTestRunner._driver_input): Ditto.
1999         * Scripts/webkitpy/layout_tests/views/printing.py:
2000         (Printer.print_config): Move printing of baseline search path to a separate function.
2001         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2002         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2003         (Testprinter.test_print_config):
2004         (Testprinter.test_print_baseline_search_path):
2005         * Scripts/webkitpy/port/base.py:
2006         (Port.baseline_search_path): Pass device_type through.
2007         (Port._expected_baselines_for_suffixes): Ditto.
2008         (Port.expected_baselines): Ditto.
2009         (Port.expected_filename): Ditto.
2010         (Port.expected_checksum): Ditto.
2011         (Port.expected_image): Ditto.
2012         (Port.expected_audio): Ditto.
2013         (Port.expected_text): Ditto.
2014         (Port.reference_files): Ditto.
2015         (Port.tests): Ditto.
2016         (Port._expanded_paths): Ditto.
2017         (Port.skipped_layout_tests): Ditto.
2018         (Port.expectations_dict): Ditto.
2019         (Port._port_specific_expectations_files): Ditto.
2020         (Port.expectations_files): Ditto.
2021         (Port.test_search_path): Ditto.
2022         (Port._tests_for_other_platforms): Ditto.
2023         * Scripts/webkitpy/port/base_unittest.py:
2024         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2025         (PortTest.test_nonexistant_expectations): Ditto.
2026         (test_ref_tests_platform_directory): Ditto.
2027         * Scripts/webkitpy/port/darwin.py:
2028         (DarwinPort._port_specific_expectations_files): Accept device_type.
2029         * Scripts/webkitpy/port/driver.py:
2030         (DriverProxy):
2031         (DriverProxy.host): Expose _target_host for device_type information.
2032         * Scripts/webkitpy/port/gtk.py:
2033         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2034         * Scripts/webkitpy/port/ios.py:
2035         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2036         * Scripts/webkitpy/port/mac.py:
2037         (MacPort. default_baseline_search_path): Ditto.
2038         * Scripts/webkitpy/port/port_testcase.py:
2039         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2040         * Scripts/webkitpy/port/test.py:
2041         * Scripts/webkitpy/port/watch.py:
2042         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2043         * Scripts/webkitpy/port/win.py:
2044         (WinPort.test_search_path): Accept, but do not use, device_type.
2045         * Scripts/webkitpy/port/wpe.py:
2046         (WPEPort._port_specific_expectations_files): Ditto.
2047         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2048         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2049
2050 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2051
2052         [LFC] Use the containing block's padding box to position out-of-flow elements.
2053         https://bugs.webkit.org/show_bug.cgi?id=193431
2054
2055         Reviewed by Antti Koivisto.
2056
2057         * LayoutReloaded/misc/LFC-passing-tests.txt:
2058
2059 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2060
2061         Move a test implementation file that got misplaced in the Xcode project
2062
2063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2064
2065 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2066
2067         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2068         r239913, and r239914.
2069         https://bugs.webkit.org/show_bug.cgi?id=193407
2070
2071         These revisions caused an internal failure (Requested by
2072         Truitt on #webkit).
2073
2074         Reverted changesets:
2075
2076         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2077         https://bugs.webkit.org/show_bug.cgi?id=186016
2078         https://trac.webkit.org/changeset/239901
2079
2080         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2081         https://trac.webkit.org/changeset/239909
2082
2083         "Tried to fix the build."
2084         https://trac.webkit.org/changeset/239910
2085
2086         "Fixed iOS builds after r239910."
2087         https://trac.webkit.org/changeset/239912
2088
2089         "More build fixing."
2090         https://trac.webkit.org/changeset/239913
2091
2092         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2093         https://trac.webkit.org/changeset/239914
2094
2095 2019-01-14  Mark Lam  <mark.lam@apple.com>
2096
2097         Re-enable ability to build --cloop builds.
2098         https://bugs.webkit.org/show_bug.cgi?id=192955
2099         <rdar://problem/46882363>
2100
2101         Reviewed by Saam barati and Keith Miller.
2102
2103         The --cloop build option was being ignored this whole time since r236381.
2104         This patch makes it possible to build CLoop builds again.
2105
2106         * Scripts/build-jsc:
2107         * Scripts/webkitperl/FeatureList.pm:
2108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2109
2110 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2111
2112         webkitpy: Expose device_type from host-like objects
2113         https://bugs.webkit.org/show_bug.cgi?id=193406
2114         <rdar://problem/47262305>
2115
2116         Reviewed by Lucas Forschler.
2117
2118         Devices should expose device_type. As a result, all host objects should
2119         provide a device_type property, even if they do not yet define a device_type.
2120
2121         * Scripts/webkitpy/common/system/systemhost.py:
2122         (SystemHost):
2123         (SystemHost.device_type):
2124         * Scripts/webkitpy/common/system/systemhost_mock.py:
2125         (MockSystemHost):
2126         (MockSystemHost.device_type):
2127         * Scripts/webkitpy/port/device.py:
2128         (Device):
2129         (Device.device_type):
2130         * Scripts/webkitpy/xcode/simulated_device.py:
2131         (SimulatedDeviceManager._find_exisiting_device_for_request):
2132         (SimulatedDeviceManager._disambiguate_device_type):
2133         (SimulatedDeviceManager._does_fulfill_request):
2134         (SimulatedDeviceManager.device_count_for_type):
2135         (SimulatedDeviceManager.initialize_devices):
2136         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2137         (test_available_devices):
2138         (test_swapping_devices):
2139
2140 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2141
2142         webkitpy: Support alternate simctl device list output (Follow-up fix)
2143         https://bugs.webkit.org/show_bug.cgi?id=193362
2144         <rdar://problem/47122965>
2145
2146         Rubber-stamped by Lucas Forschler.
2147
2148         * Scripts/webkitpy/xcode/simulated_device.py:
2149         (SimulatedDeviceManager.populate_available_devices):
2150
2151 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2152
2153         [iOS] Expose SPI to access the current sentence boundary and selection state
2154         https://bugs.webkit.org/show_bug.cgi?id=193398
2155         <rdar://problem/45893108>
2156
2157         Reviewed by Dean Jackson.
2158
2159         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2160         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2161         expected.
2162
2163         * TestWebKitAPI/EditingTestHarness.h:
2164         * TestWebKitAPI/EditingTestHarness.mm:
2165         (-[EditingTestHarness moveBackward]):
2166         (-[EditingTestHarness moveForward]):
2167         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2168
2169         Add a couple of new helper methods on EditingTestHarness.
2170
2171         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2172         (-[SelectionChangeObserver initWithWebView:]):
2173         (-[SelectionChangeObserver webView]):
2174         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2175         (-[SelectionChangeObserver currentSelectionAttributes]):
2176
2177 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2178
2179         [LFC][BFC] Add basic box-sizing support.
2180         https://bugs.webkit.org/show_bug.cgi?id=193392
2181
2182         Reviewed by Antti Koivisto.
2183
2184         * LayoutReloaded/misc/LFC-passing-tests.txt:
2185
2186 2019-01-14  Charlie Turner  <cturner@igalia.com>
2187
2188         [WPE] API test gardening
2189         https://bugs.webkit.org/show_bug.cgi?id=193319
2190
2191         Reviewed by Michael Catanzaro.
2192
2193         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2194         passing tests.
2195
2196 2019-01-14  Charlie Turner  <cturner@igalia.com>
2197
2198         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2199         https://bugs.webkit.org/show_bug.cgi?id=192977
2200
2201         Reviewed by Carlos Garcia Campos.
2202
2203         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2204         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2205         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2206         (TestWebKitAPI::GStreamerTest::SetUp):
2207         (TestWebKitAPI::GStreamerTest::TearDown):
2208         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2209         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2210         (TestWebKitAPI::TEST_F):
2211
2212 2019-01-14  Charlie Turner  <cturner@igalia.com>
2213
2214         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2215         https://bugs.webkit.org/show_bug.cgi?id=193332
2216
2217         Reviewed by Michael Catanzaro.
2218
2219         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2220         defined as a char16_t, which changed in ICU 59, the
2221         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2222         unsigned short. This test is relying on the behaviour that
2223         UChar=unsigned short, which doesn't hold across platforms and ICU
2224         library versions. The full fix would be a special syntax for
2225         literal characters so that these ambiguities do not arise. That
2226         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2227         (TestWebKitAPI::TEST):
2228
2229 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2230
2231         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2232
2233         * Scripts/make-dist:
2234         (Distcheck.configure):
2235
2236 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2237
2238         [ews-build] Update macOS queue configurations
2239         https://bugs.webkit.org/show_bug.cgi?id=193365
2240         <rdar://problem/47221073>
2241
2242         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2243
2244         * BuildSlaveSupport/ews-build/config.json:
2245
2246 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2247
2248         [LFC] Adjust assert for statically positioned fixed elements
2249         https://bugs.webkit.org/show_bug.cgi?id=193385
2250
2251         Reviewed by Antti Koivisto.
2252
2253         * LayoutReloaded/misc/LFC-passing-tests.txt:
2254
2255 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2256
2257         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2258         https://bugs.webkit.org/show_bug.cgi?id=193387
2259
2260         Reviewed by Carlos Garcia Campos.
2261
2262         * MiniBrowser/wpe/main.cpp:
2263         (main):
2264
2265 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2266
2267         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2268         https://bugs.webkit.org/show_bug.cgi?id=191655
2269         rdar://problem/46074680
2270
2271         Reviewed by Megan Gardner.
2272
2273         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2274         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2275
2276 2019-01-12  Dan Bernstein  <mitz@apple.com>
2277
2278         [Cocoa] Avoid importing directly from subumbrella frameworks
2279         https://bugs.webkit.org/show_bug.cgi?id=186016
2280         <rdar://problem/40591038>
2281
2282         Reviewed by Sam Weinig.
2283
2284         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2285           LaunchServices header.
2286         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2287           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2288         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2289           when using SDKs earlier than 10.13.
2290         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2291           and OTHER_CPLUSPLUSFLAGS.
2292         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2293           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2294         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2295           LaunchServices header.
2296
2297 2019-01-11  John Wilander  <wilander@apple.com>
2298
2299         Compile out Web API Statistics Collection
2300         https://bugs.webkit.org/show_bug.cgi?id=193370
2301         <rdar://problem/45388584>
2302
2303         Reviewed by Brent Fulgham.
2304
2305         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2306             Defined ENABLE_WEB_API_STATISTICS, off by default.
2307
2308 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2309
2310         [WPE] Add gtk-doc
2311         https://bugs.webkit.org/show_bug.cgi?id=178900
2312
2313         Reviewed by Michael Catanzaro.
2314
2315         Add Tools/gtkdoc to manifest.txt.in files.
2316         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2317
2318         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2319         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2320
2321 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2322
2323         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2324         https://bugs.webkit.org/show_bug.cgi?id=193364
2325         <rdar://problem/47214117>
2326
2327         Reviewed by Tim Horton.
2328
2329         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2330         precise, whereas dragging near the middle of the textarea does.
2331
2332         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2333         (TestWebKitAPI::TEST):
2334
2335 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2336
2337         webkitpy: Support alternate simctl device list output
2338         https://bugs.webkit.org/show_bug.cgi?id=193362
2339         <rdar://problem/47122965>
2340
2341         Reviewed by Lucas Forschler.
2342
2343         * Scripts/webkitpy/xcode/simulated_device.py:
2344         (SimulatedDeviceManager.populate_available_devices):
2345
2346 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2347
2348         [ews-build] Update macOS queue configurations
2349         https://bugs.webkit.org/show_bug.cgi?id=193365
2350
2351         Reviewed by Lucas Forschler.
2352
2353         * BuildSlaveSupport/ews-build/config.json:
2354
2355 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2356
2357         webkitpy: Incorporate device type into baseline search path
2358         https://bugs.webkit.org/show_bug.cgi?id=193356
2359         <rdar://problem/47215515>
2360
2361         Reviewed by Lucas Forschler.
2362
2363         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2364
2365         * Scripts/webkitpy/port/base.py:
2366         (Port.default_baseline_search_path): Allow device type to be passed in.
2367         * Scripts/webkitpy/port/gtk.py:
2368         (GtkPort.default_baseline_search_path): Ignore device type.
2369         * Scripts/webkitpy/port/ios.py:
2370         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2371         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2372         * Scripts/webkitpy/port/ios_device_unittest.py:
2373         (IOSDeviceTest):
2374         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2375         (IOSSimulatorTest):
2376         * Scripts/webkitpy/port/mac.py:
2377         (MacPort.default_baseline_search_path): Ignore device type.
2378         * Scripts/webkitpy/port/watch.py:
2379         (WatchPort.default_baseline_search_path): Ditto.
2380         * Scripts/webkitpy/port/win.py:
2381         (WinPort.default_baseline_search_path): Ditto.
2382         (WinCairoPort.default_baseline_search_path): Ditto.
2383         * Scripts/webkitpy/port/wpe.py:
2384         (WPEPort.default_baseline_search_path): Ditto.
2385
2386 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2387
2388         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2389         https://bugs.webkit.org/show_bug.cgi?id=193352
2390         <rdar://problem/47210736>
2391
2392         Reviewed by Lucas Forschler.
2393
2394         * Scripts/webkitpy/layout_tests/views/printing.py:
2395         (Printer.print_config): Print list on only baseline search paths which exist. 
2396         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2397         (Testprinter.test_print_config):
2398
2399 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2400
2401         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2402         https://bugs.webkit.org/show_bug.cgi?id=193340
2403
2404         Reviewed by David Kilzer.
2405
2406         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2407         (WTR::InjectedBundle::didReceiveMessageToPage):
2408         Pull the strings out into a WKRetainPtr.
2409
2410         * WebKitTestRunner/WebNotificationProvider.cpp:
2411         (WTR::WebNotificationProvider::closeWebNotification):
2412         Adopt the created value into the WKRetainPtr.
2413
2414         * WebKitTestRunner/mac/TestControllerMac.mm:
2415         (WTR::generateWhitelist):
2416         Immediately adopt a created value to avoid potential mistakes.
2417
2418 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2419
2420         Enable DFG on ARM/Linux again
2421         https://bugs.webkit.org/show_bug.cgi?id=192496
2422
2423         Reviewed by Yusuke Suzuki.
2424
2425         After changing the bytecode format DFG was disabled on all 32-bit
2426         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2427         on ARM by default.
2428
2429         * Scripts/run-jsc-stress-tests:
2430
2431 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2432
2433         Unreviewed, fix #ifdef in API test added in r239851.
2434         https://bugs.webkit.org/show_bug.cgi?id=193327
2435         rdar://problem/47093222
2436
2437         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2438
2439 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2440
2441         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2442         https://bugs.webkit.org/show_bug.cgi?id=193109
2443         <rdar://problem/44807048>
2444
2445         Reviewed by Ryosuke Niwa.
2446
2447         Introduce and respect a test option to enable the UndoManager API.
2448
2449         * WebKitTestRunner/TestController.cpp:
2450         (WTR::updateTestOptionsFromTestHeader):
2451         * WebKitTestRunner/TestOptions.h:
2452         (WTR::TestOptions::hasSameInitializationOptions const):
2453         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2454         (WTR::TestController::platformCreateWebView):
2455
2456 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2457
2458         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2459         https://bugs.webkit.org/show_bug.cgi?id=193346
2460
2461         Reviewed by Antti Koivisto.
2462
2463         * LayoutReloaded/misc/LFC-passing-tests.txt:
2464
2465 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2466
2467         Unreviewed, fix typo that breaks dashboard link.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2470         (WebKitBuildbot):
2471
2472 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2473
2474         Update macOS queue configurations
2475         https://bugs.webkit.org/show_bug.cgi?id=193329
2476
2477         Reviewed by Alexey Proskuryakov.
2478
2479         * BuildSlaveSupport/build.webkit.org-config/config.json:
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2481         (BubbleQueueServer):
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2484         (WebKitBuildbot):
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2486         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2487         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2488
2489 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2490
2491         MiniBrowser should be able to navigate to about:blank
2492         https://bugs.webkit.org/show_bug.cgi?id=193345
2493
2494         Reviewed by Simon Fraser.
2495
2496         * MiniBrowser/mac/BrowserWindowController.m:
2497         (-[BrowserWindowController addProtocolIfNecessary:]):
2498         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2499
2500         * MiniBrowser/mac/WK1BrowserWindowController.m:
2501         (-[WK1BrowserWindowController fetch:]):
2502         * MiniBrowser/mac/WK2BrowserWindowController.m:
2503         (-[WK2BrowserWindowController fetch:]):
2504         Clean up the code that uses this to match style.
2505
2506 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2507
2508         Remove MiniBrowser custom "Process Swap" menu item which does not work
2509         https://bugs.webkit.org/show_bug.cgi?id=193344
2510
2511         Reviewed by Simon Fraser.
2512
2513         There is a menu item under the Experimental menu that does work.
2514
2515         * MiniBrowser/mac/AppDelegate.m:
2516         (defaultConfiguration):
2517         * MiniBrowser/mac/SettingsController.h:
2518         * MiniBrowser/mac/SettingsController.m:
2519         (-[SettingsController _populateMenu]):
2520         (-[SettingsController validateMenuItem:]):
2521         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2522         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2523
2524 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2525
2526         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2527         https://bugs.webkit.org/show_bug.cgi?id=193327
2528         rdar://problem/47093222
2529
2530         Reviewed by Tim Horton.
2531
2532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2533         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2534         (TestWebKitAPI::didFinishNavigation):
2535         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2536         (TestWebKitAPI::TEST):
2537         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2538         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2539         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2540         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2541         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2542
2543 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2544
2545         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2546         https://bugs.webkit.org/show_bug.cgi?id=193338
2547         <rdar://problem/46664774>
2548
2549         Reviewed by David Kilzer.
2550
2551         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2552         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2553
2554 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2555
2556         Unreviewed, rolling out r239825.
2557         https://bugs.webkit.org/show_bug.cgi?id=193330
2558
2559         Broke tests on armv7/linux bots (Requested by guijemont on
2560         #webkit).
2561
2562         Reverted changeset:
2563
2564         "Enable DFG on ARM/Linux again"
2565         https://bugs.webkit.org/show_bug.cgi?id=192496
2566         https://trac.webkit.org/changeset/239825
2567
2568 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2569
2570         Disable the run-jsc-stress-test remote host key check.
2571         https://bugs.webkit.org/show_bug.cgi?id=192988
2572
2573         Reviewed by Alexey Proskuryakov.
2574
2575         * Scripts/run-jsc-stress-tests:
2576
2577 2019-01-10  John Wilander  <wilander@apple.com>
2578
2579         Override the session configuration for cookieAcceptPolicy
2580         https://bugs.webkit.org/show_bug.cgi?id=190925
2581         <rdar://problem/45497382>
2582
2583         Reviewed by Alexey Proskuryakov and Alex Christensen.
2584
2585         Test infrastructure for setting a first-party-only cookie policy.
2586
2587         * DumpRenderTree/TestRunner.cpp:
2588         (setOnlyAcceptFirstPartyCookiesCallback):
2589         (TestRunner::staticFunctions):
2590         * DumpRenderTree/TestRunner.h:
2591         * DumpRenderTree/mac/TestRunnerMac.mm:
2592         (TestRunner::setOnlyAcceptFirstPartyCookies):
2593         * DumpRenderTree/win/TestRunnerWin.cpp:
2594         (TestRunner::setOnlyAcceptFirstPartyCookies):
2595         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2597         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2598         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2599         * WebKitTestRunner/TestInvocation.cpp:
2600         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2601
2602 2019-01-09  Matt Rajca  <mrajca@apple.com>
2603
2604         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2605         https://bugs.webkit.org/show_bug.cgi?id=193301
2606
2607         Reviewed by Jer Noble.
2608         
2609         Added API tests.
2610
2611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2612         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2613         (TEST):
2614         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2615
2616 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2617
2618         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2619         https://bugs.webkit.org/show_bug.cgi?id=193310
2620
2621         Reviewed by Antti Koivisto.
2622
2623         * LayoutReloaded/misc/LFC-passing-tests.txt:
2624
2625 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2626
2627         Enable DFG on ARM/Linux again
2628         https://bugs.webkit.org/show_bug.cgi?id=192496
2629
2630         Reviewed by Yusuke Suzuki.
2631
2632         After changing the bytecode format DFG was disabled on all 32-bit
2633         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2634         on ARM by default.
2635
2636         * Scripts/run-jsc-stress-tests:
2637
2638 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2639
2640         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2641         https://bugs.webkit.org/show_bug.cgi?id=193271
2642
2643         Reviewed by Brent Fulgham.
2644
2645         BSTR is a special data structure created by SysAllocString, not a
2646         wchar_t null-terminated string.
2647
2648         * DumpRenderTree/win/TestRunnerWin.cpp:
2649         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2650         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2651         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2652         BSTR from wide string literals.
2653
2654 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2655
2656         Tweak wording for build/version_check style checker error
2657         https://bugs.webkit.org/show_bug.cgi?id=193256
2658
2659         Reviewed by Tim Horton.
2660
2661         * Scripts/webkitpy/style/checkers/cpp.py:
2662         (check_os_version_checks):
2663         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2664         (WebKitStyleTest.test_os_version_checks):
2665
2666 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2667
2668         [ews-build] Add link to bug along with bug title
2669         https://bugs.webkit.org/show_bug.cgi?id=193293
2670
2671         Reviewed by Lucas Forschler.
2672
2673         * BuildSlaveSupport/ews-build/steps.py:
2674         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2675         (ConfigureBuild.add_bug_id_url): Deleted.
2676         (ConfigureBuild.getBugURL): Deleted.
2677
2678 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2679
2680         [ews-build] Use https for ews-build server
2681         https://bugs.webkit.org/show_bug.cgi?id=193193
2682
2683         Reviewed by Lucas Forschler.
2684
2685         * BuildSlaveSupport/ews-build/steps.py:
2686
2687 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2688
2689         [ews-build] Parse and display number of style failures
2690         https://bugs.webkit.org/show_bug.cgi?id=193280
2691
2692         Reviewed by Lucas Forschler.
2693
2694         * BuildSlaveSupport/ews-build/steps.py:
2695         (CheckStyle): Use TestWithFailureCount as base class.
2696         (CheckStyle.countFailures): Count the number of style failures.
2697
2698 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2699
2700         [ews-build] use patch_id instead of ewspatchid
2701         https://bugs.webkit.org/show_bug.cgi?id=193235
2702
2703         Reviewed by Lucas Forschler.
2704
2705         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2706         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2707         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2708
2709 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2710
2711         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2712         https://bugs.webkit.org/show_bug.cgi?id=192625
2713
2714         Reviewed by Antti Koivisto.
2715
2716         * LayoutReloaded/misc/LFC-passing-tests.txt:
2717
2718 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2719
2720         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2721         https://bugs.webkit.org/show_bug.cgi?id=192841
2722
2723         Reviewed by Carlos Garcia Campos.
2724
2725         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2726         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2727         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2728
2729         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2730
2731         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2732         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2733         (WebKitWebEditorTest::testSelectionChanged):
2734         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2735         (WebKitFrameTest::testMainFrame):
2736         (WebKitFrameTest::testURI):
2737         (WebKitFrameTest::testJavaScriptContext):
2738         (WebKitFrameTest::testJavaScriptValues):
2739         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2740         (testWebViewAuthenticationRequest):
2741         (testWebViewAuthenticationLoadCancelled):
2742         (testWebViewAuthenticationFailure):
2743         (testWebViewAuthenticationStorage):
2744         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2745         (testWebViewAuthenticationProxy):
2746         (testWebViewAuthenticationProxyHTTPS):
2747         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2748         (testAutomationSessionRequestSession):
2749         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2750         (testBackForwardListNavigation):
2751         (testWebKitWebViewSessionState):
2752         (testWebKitWebViewSessionStateWithFormData):
2753         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2754         (ConsoleMessageTest::consoleMessageReceivedCallback):
2755         (testWebKitConsoleMessageConsoleAPI):
2756         (testWebKitConsoleMessageJavaScriptException):
2757         (testWebKitConsoleMessageNetworkError):
2758         (testWebKitConsoleMessageSecurityError):
2759         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2760         (testCookieManagerAcceptPolicy):
2761         (testCookieManagerCookiesChanged):
2762         (testCookieManagerPersistentStorage):
2763         (testCookieManagerPersistentStorageDeleteAll):
2764         (testCookieManagerEphemeral):
2765         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2766         (testWebKitDOMElementAutoFill):
2767         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2768         (downloadLocalFileSuccessfully):
2769         (createFileAtDestination):
2770         (testDownloadOverwriteDestinationDisallowed):
2771         (testDownloadLocalFileError):
2772         (testDownloadRemoteFile):
2773         (testDownloadRemoteFileError):
2774         (testWebViewDownloadURI):
2775         (testPolicyResponseDownload):
2776         (testPolicyResponseDownloadCancel):
2777         (testDownloadMIMEType):
2778         (contextMenuCallback):
2779         (testContextMenuDownloadActions):
2780         (testBlobDownload):
2781         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2782         (testWebKitWebEditorSelectionChanged):
2783         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2784         (testWebKitFrameMainFrame):
2785         (testWebKitFrameURI):
2786         (testWebKitFrameJavaScriptContext):
2787         (testWebKitFrameJavaScriptValues):
2788         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2789         (LoadStopTrackingTest::loadFailed):
2790         (testWebViewTitle):
2791         (testURIRequestHTTPHeaders):
2792         (testURIRequestHTTPMethod):
2793         (testURIResponseHTTPHeaders):
2794         (testRedirectToDataURI):
2795         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2796         (testProcessPerWebView):
2797         (testWebProcessLimit):
2798         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2799         (testWebViewResources):
2800         (testWebResourceLoading):
2801         (testWebResourceSuggestedFilename):
2802         (testWebResourceGetData):
2803         (testWebResourceGetDataError):
2804         (testWebViewResourcesHistoryCache):
2805         (testWebResourceSendRequest):
2806         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2807         (testSSL):
2808         (testInsecureContent):
2809         (testTLSErrorsPolicy):
2810         (testTLSErrorsRedirect):
2811         (testTLSErrorsHTTPAuth):
2812         (testLoadFailedWithTLSErrors):
2813         (testSubresourceLoadFailedWithTLSErrors):
2814         (httpsServerCallback):
2815         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2816         (testWebViewCreateNavigationData):
2817         (testWebViewJavaScriptDialogs):
2818         (testWebViewWindowProperties):
2819         (testWebViewMouseTarget):
2820         (testWebViewFileChooserRequest):
2821         (testWebViewColorChooserRequest):
2822         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2823         (testWebExtensionGetTitle):
2824         (testDocumentLoadedSignal):
2825         (testWebKitWebViewProcessCrashed):
2826         (testWebExtensionWindowObjectCleared):
2827         (testWebExtensionIsolatedWorld):
2828         (permissionRequestCallback):
2829         (didAssociateFormControlsCallback):
2830         (testWebExtensionFormControlsAssociated):
2831         (FormSubmissionTest::FormSubmissionTest):
2832         (FormSubmissionTest::testFormSubmissionResult):
2833         (testWebExtensionFormSubmissionSteps):
2834         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2835         (testNotInitialized):
2836         (testClearDatabase):
2837         (testPrivateBrowsing):
2838         (testGetFavicon):
2839         (testWebViewFavicon):
2840         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2841         (testFindControllerTextFound):
2842         (testFindControllerTextNotFound):
2843         (testFindControllerMatchCount):
2844         (testFindControllerMaxMatchCount):
2845         (testFindControllerNext):
2846         (testFindControllerPrevious):
2847         (testFindControllerCountedMatches):
2848         (testFindControllerOptions):
2849         (testFindControllerHide):
2850         (testFindControllerInstance):
2851         (testFindControllerGetters):
2852         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2853         (testNavigationPolicy):
2854         (testResponsePolicy):
2855         (testNewWindowPolicy):
2856         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2857         (testSecurityOriginBasicConstructor):
2858         (testSecurityOriginURIConstructor):
2859         (testSecurityOriginDefaultPort):
2860         (testSecurityOriginFileURI):
2861         (testOpaqueSecurityOrigin):
2862         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2863         (testWebKitSettings):
2864         (testWebKitSettingsNewWithSettings):
2865         (testWebKitSettingsUserAgent):
2866         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2867         (testWebViewNewWithUserContentManager):
2868         (isStyleSheetInjectedForURLAtPath):
2869         (isScriptInjectedForURLAtPath):
2870         (testUserContentManagerInjectedStyleSheet):
2871         (testUserContentManagerInjectedScript):
2872         (UserScriptMessageTest::scriptMessageReceived):
2873         (UserScriptMessageTest::waitUntilMessageReceived):
2874         (UserScriptMessageTest::runJavaScriptFinished):
2875         (testUserContentManagerScriptMessageReceived):
2876         (testUserContentManagerScriptMessageInWorldReceived):
2877         (testUserContentManagerScriptMessageFromDOMBindings):
2878         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2879         (testWebContextDefault):
2880         (testWebContextEphemeral):
2881         (testWebContextGetPlugins):
2882         (testWebContextURIScheme):
2883         (testWebContextSpellChecker):
2884         (testWebContextLanguages):
2885         (consoleMessageReceivedCallback):
2886         (testWebContextSecurityFileXHR):
2887         (ProxyTest::ProxyTest):
2888         (testWebContextProxySettings):
2889         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2890         (testWebViewWebContext):
2891         (testWebViewWebBackend):
2892         (testWebViewEphemeral):
2893         (testWebViewCustomCharset):
2894         (testWebViewSettings):
2895         (testWebViewRunJavaScript):
2896         (testWebViewCanShowMIMEType):
2897         (testWebViewSubmitForm):
2898         (testWebViewSave):
2899         (testWebViewPageVisibility):
2900         (testWebViewSnapshot):
2901         (testWebViewNotification):
2902         (testWebViewNotificationInitialPermissionAllowed):
2903         (testWebViewNotificationInitialPermissionDisallowed):
2904         (testWebViewIsPlayingAudio):
2905         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2906         (WebsiteDataTest::WebsiteDataTest):
2907         (WebsiteDataTest::remove):
2908         (WebsiteDataTest::clear):
2909         (testWebsiteDataConfiguration):
2910         (testWebsiteDataEphemeral):
2911         (testWebsiteDataCache):
2912         (testWebsiteDataStorage):
2913         (testWebsiteDataDatabases):
2914         (testWebsiteDataAppcache):
2915         (testWebsiteDataCookies):
2916         (testWebsiteDataDeviceIdHashSalt):
2917         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2918         (emitDocumentLoaded):
2919         (emitURIChanged):
2920         (sendRequestCallback):
2921         (contextMenuCallback):
2922         (consoleMessageSentCallback):
2923         (emitFormControlsAssociated):
2924         (formControlsAssociatedCallback):
2925         (emitFormSubmissionEvent):
2926         (willSubmitFormCallback):
2927         (windowObjectCleared):
2928         (methodCallCallback):
2929         (registerGResource):
2930         (webkit_web_extension_initialize_with_user_data):
2931         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2932         (checkLeaks):
2933         (WebProcessTest::create):
2934         (runTest):
2935         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2936         (AutocleanupsTest::testWebProcessAutocleanups):
2937         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2938         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2939         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2940         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2941         (WebKitDOMDOMWindowTest::testSignals):
2942         (WebKitDOMDOMWindowTest::testDispatchEvent):
2943         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2944         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2945         (WebKitDOMNodeFilterTest::testTreeWalker):
2946         (WebKitDOMNodeFilterTest::testNodeIterator):
2947         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2948         (WebKitDOMNodeTest::testHierarchyNavigation):
2949         (WebKitDOMNodeTest::testInsertion):
2950         (WebKitDOMNodeTest::testTagNamesNodeList):
2951         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2952         (WebKitDOMNodeTest::testDOMCache):
2953         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2954         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2955         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2956         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2957         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2958         (testUIProcessAutocleanups):
2959         (testWebProcessAutocleanups):
2960         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2961         (testContextMenuPopulateMenu):
2962         (testContextMenuDismissed):
2963         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2964         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2965         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2966         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2967         (testWebKitDOMDOMWindowSignals):
2968         (testWebKitDOMDOMWindowDispatchEvent):
2969         (testWebKitDOMDOMWindowGetComputedStyle):
2970         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2971         (testWebKitDOMNodeHierarchyNavigation):
2972         (testWebKitDOMNodeInsertion):
2973         (testWebKitDOMNodeTagNamesNodeList):
2974         (testWebKitDOMNodeTagNamesHTMLCollection):
2975         (testWebKitDOMObjectCache):
2976         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2977         (testWebKitDOMNodeFilterTreeWalker):
2978         (testWebKitDOMNodeFilterNodeIterator):
2979         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2980         (testWebKitDOMXPathNSResolverNative):
2981         (testWebKitDOMXPathNSResolverCustom):
2982         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2983         (testInspectorDefault):
2984         (testInspectorManualAttachDetach):
2985         (testInspectorCustomContainerDestroyed):
2986         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2987         (startTestServer):
2988         (testInspectorServerPageList):
2989         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2990         (OptionMenuTest::showOptionMenuCallback):
2991         (OptionMenuTest::menuCloseCallback):
2992         (OptionMenuTest::close):
2993         (OptionMenuTest::activateItem):
2994         (OptionMenuTest::selectItem):
2995         (testOptionMenuSimple):
2996         (testOptionMenuGroups):
2997         (testOptionMenuActivate):
2998         (testOptionMenuSelect):
2999         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3000         (testPrintOperationPrintSettings):
3001         (webViewPrintCallback):
3002         (testPrintOperationPrint):
3003         (testPrintCustomWidget):
3004         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3005         (checkAtspiAccessible):
3006         (testAtspiBasicHierarchy):
3007         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
3008         (testWebKitCheckVersion):
3009         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
3010         (testWebViewEditorCutCopyPasteNonEditable):
3011         (testWebViewEditorCutCopyPasteEditable):
3012         (testWebViewEditorSelectAllNonEditable):
3013         (testWebViewEditorSelectAllEditable):
3014         (loadContentsAndTryToCutSelection):
3015         (testWebViewEditorNonEditable):
3016         (testWebViewEditorEditable):
3017         (testWebViewEditorEditorStateTypingAttributes):
3018         (testWebViewEditorInsertImage):
3019         (testWebViewEditorCreateLink):
3020         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3021         (loadChangedCallback):
3022         (loadFailedCallback):
3023         (loadFailedWithTLSErrorsCallback):
3024         (LoadTrackingTest::LoadTrackingTest):
3025         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3026         (registerGResource):
3027         (removeNonEmptyDirectory):
3028         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3029         (Test::adoptView):
3030         (Test::~Test):
3031         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3032         (WebKitTestBus::getOrCreateConnection):
3033         (WebKitTestBus::createProxy):
3034         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3035         (WebKitTestServer::getWebSocketURIForPath const):
3036         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3037         (WebViewTest::initializeWebView):
3038         (WebViewTest::loadURI):
3039         (WebViewTest::loadHtml):
3040         (WebViewTest::loadPlainText):
3041         (WebViewTest::loadBytes):
3042         (WebViewTest::loadRequest):
3043         (WebViewTest::loadAlternateHTML):
3044         (WebViewTest::goBack):
3045         (WebViewTest::goForward):
3046         (WebViewTest::goToBackForwardListItem):
3047         (resourceGetDataCallback):
3048         (WebViewTest::mainResourceData):
3049         (WebViewTest::javascriptResultToCString):
3050         (WebViewTest::javascriptResultToNumber):
3051         (WebViewTest::javascriptResultToBoolean):
3052         (WebViewTest::javascriptResultIsNull):
3053         (WebViewTest::javascriptResultIsUndefined):
3054         (onSnapshotReady):
3055         (WebViewTest::runWebProcessTest):
3056         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3057         (WebViewTest::platformInitializeWebView):
3058         (WebViewTest::showInWindow):
3059         (WebViewTest::showInWindowAndWaitUntilMapped):
3060         (WebViewTest::mouseMoveTo):
3061         (WebViewTest::emitPopupMenuSignal):
3062         (WebViewTest::keyStroke):
3063         (WebViewTest::doMouseButtonEvent):
3064
3065 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3066
3067         [WPE] API tests can't run in flatpak environment
3068         https://bugs.webkit.org/show_bug.cgi?id=193242
3069
3070         Reviewed by Michael Catanzaro.
3071
3072         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3073         flatpakutils so that it knows which port it's dealing with.
3074         * glib/common.py: Remove build_dir globals so that subsequent
3075         calls actually take args into account.
3076         (library_build_path):
3077         (binary_build_path):
3078
3079 2019-01-08  Dean Jackson  <dino@apple.com>
3080
3081         Blob references for System Previews don't get a correct file extension
3082         https://bugs.webkit.org/show_bug.cgi?id=193268
3083         <rdar://problem/47133037>
3084
3085         Reviewed by Tim Horton.
3086
3087         New test that a Blob download of a USDZ file gets named correctly.
3088
3089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3090         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3091         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3092         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3093         (TEST):
3094         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3095
3096 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3097
3098         [WebAuthN] Support U2F HID Authenticators on macOS
3099         https://bugs.webkit.org/show_bug.cgi?id=191535
3100         <rdar://problem/47102027>
3101
3102         Reviewed by Brent Fulgham.
3103
3104         This patch:
3105         1) adds support for U2F mocking mechanism;
3106         2) updates tests to reflect U2fCommandConstructor changes.
3107
3108         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3109         (TestWebKitAPI::TEST):
3110         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3111         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3112         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3113
3114 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3115
3116         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3117         https://bugs.webkit.org/show_bug.cgi?id=193229
3118         <rdar://problem/46717097>
3119
3120         Reviewed by Tim Horton.
3121
3122         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3123         prevents a drag from starting.
3124
3125         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3126         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3127
3128         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3129
3130 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3131   
3132         Layout test will generate a perf metric file to results dir.
3133         https://bugs.webkit.org/show_bug.cgi?id=192030
3134         <rdar://problem/32779516>
3135
3136         Reviewed by Aakash Jain.
3137
3138         Layout test running time will be collected to a perf metric file.
3139         For now, instead of outputing running time of all tests (which is huge),
3140         we aggregate them by test directories which are at most two level deep. 
3141
3142         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3143         (Manager._end_test_run):
3144         (Manager._output_perf_metrics):
3145         (Manager._print_expectation_line_for_test):
3146         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3147         (add_test_perf_metric):
3148         (test_perf_metrics):
3149         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3150         (JSONGeneratorTest.test_test_timings_trie):
3151         (JSONGeneratorTest):
3152         (JSONGeneratorTest.test_test_perf_metrics):
3153         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3154         (RebaselineTest.test_reset_results):
3155         (RebaselineTest.test_missing_results):
3156         (RebaselineTest.test_new_baseline):
3157
3158 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3159
3160         [WPE][GTK] Add php-json to install-dependencies
3161         https://bugs.webkit.org/show_bug.cgi?id=193233
3162
3163         Reviewed by Michael Catanzaro.
3164
3165         * gtk/install-dependencies:
3166         * wpe/install-dependencies:
3167
3168 2019-01-08  Chris Dumez  <cdumez@apple.com>
3169
3170         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3171         https://bugs.webkit.org/show_bug.cgi?id=193224
3172         <rdar://problem/47097726>
3173
3174         Reviewed by Alex Christensen.
3175
3176         Add API test coverage.
3177
3178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3179
3180 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3181
3182         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3183         <https://webkit.org/b/193222>
3184         <rdar://problem/46862309>
3185
3186         Reviewed by Joseph Pecoraro.
3187
3188         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3189         (WTR::executeCallback): Fix camel case of variable name.
3190         (WTR::EventSendingController::callAfterScrollingCompletes): If
3191         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3192         false, make sure to release the ScrollCompletionCallbackData
3193         object.  This fixes the leak.
3194
3195 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3196
3197         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3198         https://bugs.webkit.org/show_bug.cgi?id=193044
3199
3200         Reviewed by Daniel Bates.
3201
3202         WinCairo EWS bots are using Windows Perl. Binary files should be
3203         opened as binary mode.
3204
3205         * Scripts/svn-apply:
3206         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3207
3208 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3209
3210         [CMake] Add ENABLE_CSS_TYPED_OM option
3211         https://bugs.webkit.org/show_bug.cgi?id=193216
3212
3213         Reviewed by Michael Catanzaro.
3214
3215         * Scripts/webkitperl/FeatureList.pm:
3216
3217 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3218
3219         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3220         <https://webkit.org/b/193056>
3221
3222         Reviewed by Alex Christensen.
3223
3224         * Scripts/webkitpy/style/checker.py:
3225         - Ignore use of new runtime/retainptr check in
3226           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3227           contains tests to ensure RetainPtr<NSObject *> is compatible
3228           with RetainPtr<NSObject>.
3229
3230         * Scripts/webkitpy/style/checkers/cpp.py:
3231         (check_language):
3232         (CppChecker):
3233         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3234           was used instead of a single regex so that angle brackets
3235           could be matched up when checking the type contained within
3236           the RetainPtr<> type.
3237
3238         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3239         (CppStyleTest):
3240         - Add unit test for new runtime/retainptr check.
3241
3242         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3243         * TestWebKitAPI/EditingTestHarness.h:
3244         - Remove '*' from RetainPtr<> type.
3245
3246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3247         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3248           regressed in r201938.
3249
3250         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3251         (TestWebKitAPI::TEST):
3252         - Update tests to match RetainPtr.mm tests (except for the
3253           `*SimilarNSType` tests since there is no CF equivalent of
3254           RetainPtr<NSString> and RetainPtr<NSString *>).
3255
3256         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3257         (TestWebKitAPI::TEST):
3258         - Update tests to:
3259           - Not conflict by name with equivalent CF tests in
3260             RetainPtr.cpp.
3261           - Add test cases for RetainPtr<NSObject>,
3262             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3263           - Add `*SimilarNSType` tests for converting between
3264             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3265           - Change `0` to `nil` as appropriate.
3266           - Re-alphabetize the tests by name.
3267           - Add Optional<RetainPtr<>> tests.
3268           - Add retainPtr() tests.
3269
3270         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3271         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3272         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3273         (TEST):
3274         - Remove '*' from RetainPtr<> type.
3275
3276         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3277         (TEST(WebKit, JITEnabled)):
3278         - Add missing WTFMove().  Apparently a temporary was being
3279           created before in the argument list due to mismatched
3280           RetainPtr<> types.
3281
3282         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3283         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3284         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3285         (TestWebKitAPI::TEST):
3286         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3287         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3288         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3289         (WTR::resourcesDirectoryURL):
3290         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3291         (WTR::InjectedBundle::platformInitialize):
3292         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3293         - Remove '*' from RetainPtr<> type.
3294
3295 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3296
3297         A MediaTime timescale must never be zero
3298         https://bugs.webkit.org/show_bug.cgi?id=193156
3299         <rdar://problem/32504501>
3300
3301         Reviewed by Jer Noble.
3302
3303         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3304         (TestWebKitAPI::TEST): Add tests for zero timescale.
3305
3306 2019-01-07  Youenn Fablet  <youenn@apple.com>
3307
3308         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3309         https://bugs.webkit.org/show_bug.cgi?id=193175
3310
3311         Reviewed by Chris Dumez.
3312
3313         Updated API test as we bumped the SW schema to version 4.
3314
3315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3316         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3317         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3318         (TEST):
3319
3320 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3321
3322         [Win][Clang] Fix compilation warnings of MiniBrowser
3323         https://bugs.webkit.org/show_bug.cgi?id=193029
3324
3325         Reviewed by Ross Kirsling.
3326
3327         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3328         and m_URLBarFont. Reorder member variables to fix -Wreorder
3329         warning.
3330         * MiniBrowser/win/PageLoadTestClient.cpp:
3331         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3332         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3333         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3334         m_currentURLIndex.
3335         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3336         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3337         navigationClient with '{ }' to fix the missing field warning.
3338         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3339         (initDocStruct): Changed the argument type docname to const.
3340
3341 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3342
3343         [WebAuthN] Import U2F command/response converters from Chromium
3344         https://bugs.webkit.org/show_bug.cgi?id=193150
3345         <rdar://problem/47054028>
3346
3347         Reviewed by Brent Fulgham.
3348
3349         Adds API tests.
3350
3351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3352         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3353         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3354         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3355         (TestWebKitAPI::getTestAttestationObjectBytes):
3356         (TestWebKitAPI::getTestSignResponse):
3357         (TestWebKitAPI::getTestU2fRegisterResponse):
3358         (TestWebKitAPI::TEST):
3359         (TestWebKitAPI::convertToVector): Deleted.
3360         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3361         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3362         (TestWebKitAPI::constructMakeCredentialRequest):
3363         (TestWebKitAPI::constructGetAssertionRequest):
3364         (TestWebKitAPI::TEST):
3365
3366 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3367
3368         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3369         https://bugs.webkit.org/show_bug.cgi?id=193136
3370
3371         Reviewed by Michael Catanzaro.
3372
3373         * gtk/install-dependencies:
3374         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3375         they are needed by update-webkitgtk-libs.
3376
3377 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3378
3379         Unreviewed follow-up fix to r239650
3380         https://bugs.webkit.org/show_bug.cgi?id=193140
3381         <rdar://problem/47063037>
3382
3383         Typecast patch_id to string.
3384
3385         * BuildSlaveSupport/ews-build/steps.py:
3386         (ValidatePatch._is_patch_obsolete):
3387
3388 2019-01-04  Daniel Bates  <dabates@apple.com>
3389
3390         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3391         https://bugs.webkit.org/show_bug.cgi?id=193024
3392
3393         Reviewed by Jer Noble.
3394
3395         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3396         for the bitmask type WebEventFlags as an example.
3397
3398         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3399         that can be used to register summary and synthetic child formatters for a bitmask type.
3400         For example, consider the following enum and bitmask typedefs:
3401
3402         typedef enum {
3403             A = 1 << 0,
3404             B = 1 << 1,
3405             C = 1 << 2,
3406         } SpecialFlagValues;
3407         typedef unsigned SpecialFlags;
3408
3409         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3410         __lldb_init_module():
3411
3412             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3413                     1 << 0: "A",
3414                     1 << 1: "B",
3415                     1 << 2: "C",
3416             })
3417
3418         * lldb/lldb_webkit.py:
3419         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3420         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3421         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3422         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3423         A convenience function to dynamically creaste a synthetic formatter class and summary
3424         string function for the specified bitmask type and enumerator value to name map. This
3425         function register the dynamically created class and function with LLDB.
3426
3427         (__lldb_init_module):
3428         (FlagEnumerationProvider):
3429         (FlagEnumerationProvider._enumerator_value_to_name_map):
3430         (FlagEnumerationProvider._bitmask):
3431         (FlagEnumerationProvider._update):
3432         (FlagEnumerationProvider.has_children):
3433         (FlagEnumerationProvider.num_children):
3434         (FlagEnumerationProvider.get_child_index):
3435         (FlagEnumerationProvider.get_child_at_index):
3436         (FlagEnumerationProvider.update):
3437         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3438
3439         (WTFOptionSetProvider):
3440         (WTFOptionSetProvider._enumerator_value_to_name_map):
3441         (WTFOptionSetProvider._bitmask):
3442         (WTFOptionSetProvider._update):
3443         Write in terms of the base class.
3444
3445         (RawBitmaskProviderBase):
3446         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3447         (RawBitmaskProviderBase._bitmask):
3448         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3449         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3450         {
3451             1 << 0: "A",
3452             1 << 1: "B",
3453             1 << 2: "C",
3454         }
3455         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3456         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3457
3458         (WTFOptionSetProvider.has_children): Deleted.
3459         (WTFOptionSetProvider.num_children): Deleted.
3460         (WTFOptionSetProvider.get_child_index): Deleted.
3461         (WTFOptionSetProvider.get_child_at_index): Deleted.
3462         (WTFOptionSetProvider.update): Deleted.
3463
3464 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3465
3466         [ews-build] Add build step to validate the patch before processing it
3467         https://bugs.webkit.org/show_bug.cgi?id=193140
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * BuildSlaveSupport/ews-build/factories.py:
3472         (Factory.__init__): Added ValidatePatch step.
3473         * BuildSlaveSupport/ews-build/steps.py:
3474         (ValidatePatch):
3475         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3476         (ValidatePatch.get_patch_json): Get patch json data.
3477         (ValidatePatch.get_bug_json): Get bug json data.
3478         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3479         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3480         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3481         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3482         (ValidatePatch.skip_build): Skip the build.
3483         (ValidatePatch.start):
3484
3485 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3486
3487         Progress towards fixing Mac CMake build
3488         https://bugs.webkit.org/show_bug.cgi?id=193105
3489
3490         Reviewed by Don Olmstead.
3491
3492         * TestWebKitAPI/PlatformMac.cmake:
3493
3494 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3495
3496         Fix API test after r239631
3497         https://bugs.webkit.org/show_bug.cgi?id=193118
3498
3499         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3500         (TestWebKitAPI::TEST):
3501         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3502         Do the same thing via the API to fix the test.
3503
3504 2019-01-04  Jer Noble  <jer.noble@apple.com>
3505
3506         [WebKitLegacy] Media playback pauses on scroll
3507         https://bugs.webkit.org/show_bug.cgi?id=192829
3508
3509         Reviewed by Eric Carlson.
3510
3511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3512         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3513         (TestWebKitAPI::TEST):
3514         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3515         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3516         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3517         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3518         (TestWebKitAPI::TEST):
3519
3520 2019-01-04  Chris Dumez  <cdumez@apple.com>
3521
3522         Add support for toggling device orientation API support per site
3523         https://bugs.webkit.org/show_bug.cgi?id=193143
3524         <rdar://problem/46605724>
3525
3526         Reviewed by Alex Christensen.
3527
3528         Add API test coverage.
3529
3530         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3531         (-[DataMappingSchemeHandler setTaskHandler:]):
3532         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3533         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3534         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3535         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3536
3537 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3538
3539         [ews-build] use svn-apply script to apply the patches
3540         https://bugs.webkit.org/show_bug.cgi?id=193138
3541
3542         Reviewed by Lucas Forschler.
3543
3544         * BuildSlaveSupport/ews-build/factories.py:
3545         (Factory.__init__): Add the ApplyPatch step.
3546         * BuildSlaveSupport/ews-build/steps.py:
3547         (CheckOutSource): Added step name.
3548         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3549         (ApplyPatch): Build step to apply patch using svn-apply script.
3550         (UnApplyPatchIfRequired):
3551         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3552
3553 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3554
3555         Deprecate WKContextCreate
3556         https://bugs.webkit.org/show_bug.cgi?id=193118
3557
3558         Reviewed by Brady Eidson.
3559
3560         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3561         (WebKitBrowserWindow::WebKitBrowserWindow):
3562         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3563         (TestWebKitAPI::TEST):
3564         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3565         (TestWebKitAPI::TEST):
3566         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3567         (TestWebKitAPI::TEST):
3568         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3569         (TestWebKitAPI::TEST):
3570         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3571         (TestWebKitAPI::TEST):
3572         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3573         (TestWebKitAPI::TEST):
3574         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3575         (TestWebKitAPI::TEST):
3576         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3577         (TestWebKitAPI::TEST):
3578         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3579         (TestWebKitAPI::TEST):
3580         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3583         (TestWebKitAPI::TEST):
3584         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3587         (TestWebKitAPI::TEST):
3588         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3589         (TestWebKitAPI::TEST):
3590         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3591         (TestWebKitAPI::TEST):
3592         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3593         (TestWebKitAPI::TEST):
3594         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3595         (TestWebKitAPI::TEST):
3596         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3597         (TestWebKitAPI::TEST):
3598         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3599         (TestWebKitAPI::loadAlternateHTMLString):
3600         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3601         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3602         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3603         (TestWebKitAPI::buildAndPerformTest):
3604         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3605         (TestWebKitAPI::TEST):
3606         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3607         (TestWebKitAPI::TEST):
3608         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3609         (TestWebKitAPI::TEST):
3610         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3611         (TestWebKitAPI::TEST):
3612         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3615         (TestWebKitAPI::TEST):
3616         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3617         (TestWebKitAPI::TEST):
3618         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3619         (TestWebKitAPI::TEST):
3620         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3621         (TestWebKitAPI::TEST):
3622         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3623         (TestWebKitAPI::TEST):
3624         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3625         (TestWebKitAPI::TEST):
3626         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3627         (TestWebKitAPI::TEST):
3628         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3629         (TestWebKitAPI::TEST):
3630         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3631         (TestWebKitAPI::TEST):
3632         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3633         (TestWebKitAPI::TEST):
3634         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3635         (TestWebKitAPI::TEST):
3636         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3637         (TestWebKitAPI::TEST):
3638         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3639         (TestWebKitAPI::T