1e7b976c1eb2bd6b2b26d72ddb1dd67c83921902
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
2
3         Update list of builders for test results server
4         https://bugs.webkit.org/show_bug.cgi?id=111166
5
6         Reviewed by Ojan Vafai.
7
8         * TestResultServer/static-dashboards/builders.jsonp:
9
10 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
11
12         [GTK] Move basic dependency installation to a script
13         https://bugs.webkit.org/show_bug.cgi?id=110692
14
15         Reviewed by Gustavo Noronha Silva.
16
17         * gtk/install-dependencies: Added. A Script which installs all dependencies
18         necessary for building for Debian-based distributions and Fedora.
19
20 2013-03-05  James Robinson  <jamesr@chromium.org>
21
22         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
23         https://bugs.webkit.org/show_bug.cgi?id=111440
24
25         Reviewed by Adrienne Walker.
26
27         Remove unnecessary WebCompositorSupport::shutdown call
28
29         * DumpRenderTree/chromium/DumpRenderTree.cpp:
30         (main):
31
32 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
33
34         Unreviewed build fix.
35
36         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
37
38 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
39
40         [Qt][MiniBrowser] Improve the update of touch indicators
41         https://bugs.webkit.org/show_bug.cgi?id=111429
42
43         Reviewed by Jocelyn Turcotte.
44
45         MiniBrowserApplication::sendTouchEvent sends an empty list
46         to BrowserWindow::updateVisualMockTouchPoints if the control
47         button is released, in which case the touch indicators should
48         be hidden so that we never end up with a leftover indicator
49         sticking on the screen.
50         This patch also simplifies the lookup of the indicator items by
51         replacing the findChild search in the item tree with a QHash
52         that stores the touch ID's and the pointers to the corresponding
53         indicator items.
54
55         * MiniBrowser/qt/BrowserWindow.cpp:
56         (BrowserWindow::updateVisualMockTouchPoints):
57         * MiniBrowser/qt/BrowserWindow.h:
58         (BrowserWindow):
59
60 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
61
62         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
63         https://bugs.webkit.org/show_bug.cgi?id=81042
64
65         Reviewed by Enrica Casucci.
66
67         Add setAsynchronousSpellCheckingEnabled implementation for
68         WebKitTestRunner to have the possibility to test asynchronous
69         spell checking implementation from bug 109577.
70
71         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
72         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
73         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
74         * WebKitTestRunner/InjectedBundle/TestRunner.h:
75         * WebKitTestRunner/TestController.cpp:
76         (WTR::TestController::resetStateToConsistentValues):
77
78 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
79
80         MediaStream API: Add the getStreamById method on RTCPeerConnection
81         https://bugs.webkit.org/show_bug.cgi?id=111311
82
83         Reviewed by Adam Barth.
84
85         Changing mocks to be more realistic.
86
87         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
88         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
89         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
90         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
91         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
92
93 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
94
95         Add content shell bots to garden-o-matic for general failurse
96         https://bugs.webkit.org/show_bug.cgi?id=111168
97
98         Reviewed by Adam Barth.
99
100         All but the WebKit (Content Shell) Android bot is stable enough. While
101         they're not green yet, there must not be any non-layout test failures on
102         them.
103
104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
105         (.):
106
107 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
108
109         [chromium] remove deprecated WebTestRunner::setFocus API
110         https://bugs.webkit.org/show_bug.cgi?id=111354
111
112         Reviewed by James Robinson.
113
114         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
115         (WebTestDelegate):
116
117 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
118
119         Run the bindings generation tests on EWS and CQ bots
120         https://bugs.webkit.org/show_bug.cgi?id=111358
121
122         Reviewed by Adam Barth.
123
124         The tests are super fast and not flaky.
125
126         * Scripts/webkitpy/common/config/ports.py:
127         (DeprecatedPort.run_bindings_tests_command):
128         * Scripts/webkitpy/common/config/ports_mock.py:
129         (MockPort.run_webkit_tests_command):
130         (MockPort):
131         (MockPort.run_bindings_tests_command):
132         * Scripts/webkitpy/tool/commands/download_unittest.py:
133         * Scripts/webkitpy/tool/steps/runtests.py:
134         (RunTests.run):
135         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
136         (RunTestsTest.test_webkit_run_unit_tests):
137         * Scripts/webkitpy/tool/steps/steps_unittest.py:
138
139 2013-03-04  Eric Seidel  <eric@webkit.org>
140
141         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
142         https://bugs.webkit.org/show_bug.cgi?id=111384
143
144         Reviewed by Ryosuke Niwa.
145
146         Sometimes I want to know why various LayoutTests are slow
147         without having to convert them into PerformanceTests in order
148         to use our fancy profiling.  The Driver already knows how to
149         do the right thing, we just need to expose the options to the user.
150
151         Handling of these options is already unittested in the perftests_unittest.
152
153         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
154         (parse_args):
155
156 2013-03-04  Alan Cutter  <alancutter@chromium.org>
157
158         check-webkit-style says "Have to enable auto props in the subversion config file"
159         https://bugs.webkit.org/show_bug.cgi?id=107724
160
161         Reviewed by Tony Chang.
162
163         Added a standard svn config file for WebKit developers to use.
164         Updated the style and commit queue bot build scripts to load this file.
165
166         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
167         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
168         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
169         * svn-config: Added.
170
171 2013-03-04  James Robinson  <jamesr@chromium.org>
172
173         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
174         https://bugs.webkit.org/show_bug.cgi?id=111285
175
176         Reviewed by Adrienne Walker.
177
178         This removes the need for WebCompositorSupport::initialize and exposes
179         slightly fewer entry points across the repository boundary.
180
181         * DumpRenderTree/chromium/TestShell.cpp:
182         (TestShell::initialize):
183         * DumpRenderTree/chromium/TestShell.h:
184         (TestShell::webCompositorThread):
185         (TestShell):
186         * DumpRenderTree/chromium/WebViewHost.cpp:
187         (WebViewHost::initializeLayerTreeView):
188
189 2013-03-04  Roger Fong  <roger_fong@apple.com>
190
191         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
192
193         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
194
195 2013-03-04  David Kilzer  <ddkilzer@apple.com>
196
197         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
198
199             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
200                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
201                                         ^         ~~~~~~~~~~~~~~~~~~~~~
202             1 error generated.
203
204         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
205         AccessibilityCommonMac.h.
206
207 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
208
209         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
210         https://bugs.webkit.org/show_bug.cgi?id=109828
211
212         Reviewed by Kenneth Rohde Christiansen.
213
214         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
215         callbacks.
216
217         * TestWebKitAPI/CMakeLists.txt:
218
219             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
220             considered.
221
222         * TestWebKitAPI/PlatformEfl.cmake:
223         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
224         (TestWebKitAPI):
225         (TestWebKitAPI::didFinishLoadForFrame):
226         (TestWebKitAPI::setPageLoaderClient):
227         (TestWebKitAPI::webProcessCrashed):
228         (TestWebKitAPI::webProcessDidRelaunch):
229         (TestWebKitAPI::setViewClient):
230         (TestWebKitAPI::TEST):
231
232 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
233
234         AX: Upstream iOS Accessibility DumpRenderTree changes
235         https://bugs.webkit.org/show_bug.cgi?id=111220
236
237         Reviewed by David Kilzer.
238
239         Upstream the iOS changes for accessibility in DumpRenderTree.
240
241         * DumpRenderTree/AccessibilityUIElement.cpp:
242         (headerElementAtIndexCallback):
243         (linkedElementCallback):
244         (elementsForRangeCallback):
245         (increaseTextSelectionCallback):
246         (decreaseTextSelectionCallback):
247         (assistiveTechnologySimulatedFocusCallback):
248         (stringForSelectionCallback):
249         (getIPhoneLabelCallback):
250         (getIPhoneHintCallback):
251         (getIPhoneValueCallback):
252         (getIPhoneIdentifierCallback):
253         (getIPhoneTraitsCallback):
254         (getIPhoneIsElementCallback):
255         (getIPhoneElementTextPositionCallback):
256         (getIPhoneElementTextLengthCallback):
257         (AccessibilityUIElement::getJSClass):
258         * DumpRenderTree/AccessibilityUIElement.h:
259         (AccessibilityUIElement):
260         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
261         * DumpRenderTree/ios: Added.
262         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
263         (AccessibilityController::AccessibilityController):
264         (AccessibilityController::~AccessibilityController):
265         (AccessibilityController::elementAtPoint):
266         (AccessibilityController::focusedElement):
267         (AccessibilityController::rootElement):
268         (findAccessibleObjectById):
269         (AccessibilityController::accessibleElementById):
270         (AccessibilityController::setLogFocusEvents):
271         (AccessibilityController::setLogScrollingStartEvents):
272         (AccessibilityController::setLogValueChangeEvents):
273         (AccessibilityController::setLogAccessibilityEvents):
274         (AccessibilityController::addNotificationListener):
275         (AccessibilityController::removeNotificationListener):
276         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
277         (AccessibilityUIElement::AccessibilityUIElement):
278         (AccessibilityUIElement::~AccessibilityUIElement):
279         (concatenateAttributeAndValue):
280         (AccessibilityUIElement::iphoneLabel):
281         (AccessibilityUIElement::iphoneHint):
282         (AccessibilityUIElement::iphoneValue):
283         (AccessibilityUIElement::iphoneIdentifier):
284         (AccessibilityUIElement::iphoneTraits):
285         (AccessibilityUIElement::iphoneIsElement):
286         (AccessibilityUIElement::iphoneElementTextPosition):
287         (AccessibilityUIElement::iphoneElementTextLength):
288         (AccessibilityUIElement::url):
289         (AccessibilityUIElement::x):
290         (AccessibilityUIElement::y):
291         (AccessibilityUIElement::width):
292         (AccessibilityUIElement::height):
293         (AccessibilityUIElement::clickPointX):
294         (AccessibilityUIElement::clickPointY):
295         (AccessibilityUIElement::getChildren):
296         (AccessibilityUIElement::getChildrenWithRange):
297         (AccessibilityUIElement::childrenCount):
298         (AccessibilityUIElement::elementAtPoint):
299         (AccessibilityUIElement::indexOfChild):
300         (AccessibilityUIElement::getChildAtIndex):
301         (AccessibilityUIElement::headerElementAtIndex):
302         (AccessibilityUIElement::linkedElement):
303         (AccessibilityUIElement::linkedUIElementAtIndex):
304         (AccessibilityUIElement::ariaOwnsElementAtIndex):
305         (AccessibilityUIElement::ariaFlowToElementAtIndex):
306         (AccessibilityUIElement::disclosedRowAtIndex):
307         (AccessibilityUIElement::selectedRowAtIndex):
308         (AccessibilityUIElement::rowAtIndex):
309         (AccessibilityUIElement::titleUIElement):
310         (AccessibilityUIElement::parentElement):
311         (AccessibilityUIElement::disclosedByRow):
312         (AccessibilityUIElement::increaseTextSelection):
313         (AccessibilityUIElement::decreaseTextSelection):
314         (AccessibilityUIElement::stringForSelection):
315         (AccessibilityUIElement::stringForRange):
316         (AccessibilityUIElement::attributedStringForRange):
317         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
318         (AccessibilityUIElement::elementsForRange):
319         (AccessibilityUIElement::getLinkedUIElements):
320         (AccessibilityUIElement::getDocumentLinks):
321         (AccessibilityUIElement::attributesOfLinkedUIElements):
322         (AccessibilityUIElement::attributesOfDocumentLinks):
323         (AccessibilityUIElement::attributesOfChildren):
324         (AccessibilityUIElement::allAttributes):
325         (AccessibilityUIElement::stringAttributeValue):
326         (AccessibilityUIElement::isPressActionSupported):
327         (AccessibilityUIElement::isIncrementActionSupported):
328         (AccessibilityUIElement::isDecrementActionSupported):
329         (AccessibilityUIElement::boolAttributeValue):
330         (AccessibilityUIElement::isAttributeSettable):
331         (AccessibilityUIElement::isAttributeSupported):
332         (AccessibilityUIElement::parameterizedAttributeNames):
333         (AccessibilityUIElement::role):
334         (AccessibilityUIElement::subrole):
335         (AccessibilityUIElement::roleDescription):
336         (AccessibilityUIElement::title):
337         (AccessibilityUIElement::description):
338         (AccessibilityUIElement::orientation):
339         (AccessibilityUIElement::stringValue):
340         (AccessibilityUIElement::language):
341         (AccessibilityUIElement::helpText):
342         (AccessibilityUIElement::intValue):
343         (AccessibilityUIElement::minValue):
344         (AccessibilityUIElement::maxValue):
345         (AccessibilityUIElement::valueDescription):
346         (AccessibilityUIElement::insertionPointLineNumber):
347         (AccessibilityUIElement::isEnabled):
348         (AccessibilityUIElement::isRequired):
349         (AccessibilityUIElement::isFocused):
350         (AccessibilityUIElement::isSelected):
351         (AccessibilityUIElement::isExpanded):
352         (AccessibilityUIElement::isChecked):
353         (AccessibilityUIElement::hierarchicalLevel):
354         (AccessibilityUIElement::ariaIsGrabbed):
355         (AccessibilityUIElement::ariaDropEffects):
356         (AccessibilityUIElement::lineForIndex):
357         (AccessibilityUIElement::boundsForRange):
358         (AccessibilityUIElement::attributesOfColumnHeaders):
359         (AccessibilityUIElement::attributesOfRowHeaders):
360         (AccessibilityUIElement::attributesOfColumns):
361         (AccessibilityUIElement::attributesOfRows):
362         (AccessibilityUIElement::attributesOfVisibleCells):
363         (AccessibilityUIElement::attributesOfHeader):
364         (AccessibilityUIElement::rowCount):
365         (AccessibilityUIElement::columnCount):
366         (AccessibilityUIElement::indexInTable):
367         (AccessibilityUIElement::rowIndexRange):
368         (AccessibilityUIElement::columnIndexRange):
369         (AccessibilityUIElement::cellForColumnAndRow):
370         (AccessibilityUIElement::selectedTextRange):
371         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
372         (AccessibilityUIElement::setSelectedTextRange):
373         (AccessibilityUIElement::increment):
374         (AccessibilityUIElement::decrement):
375         (AccessibilityUIElement::showMenu):
376         (AccessibilityUIElement::press):
377         (AccessibilityUIElement::accessibilityValue):
378         (AccessibilityUIElement::documentEncoding):
379         (AccessibilityUIElement::documentURI):
380         (_accessibilityNotificationCallback):
381         (AccessibilityUIElement::addNotificationListener):
382         (AccessibilityUIElement::removeNotificationListener):
383         (AccessibilityUIElement::isFocusable):
384         (AccessibilityUIElement::isSelectable):
385         (AccessibilityUIElement::isMultiSelectable):
386         (AccessibilityUIElement::isSelectedOptionActive):
387         (AccessibilityUIElement::isVisible):
388         (AccessibilityUIElement::isOffScreen):
389         (AccessibilityUIElement::isCollapsed):
390         (AccessibilityUIElement::isIgnored):
391         (AccessibilityUIElement::hasPopup):
392         (AccessibilityUIElement::takeFocus):
393         (AccessibilityUIElement::takeSelection):
394         (AccessibilityUIElement::addSelection):
395         (AccessibilityUIElement::removeSelection):
396         (AccessibilityUIElement::uiElementForSearchPredicate):
397         (AccessibilityUIElement::numberAttributeValue):
398
399 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
400
401         [chromium] pass all focus handling methods through the WebTestDelegate
402         https://bugs.webkit.org/show_bug.cgi?id=111328
403
404         Reviewed by Nico Weber.
405
406         In content_shell, the focus handling is asynchronous. To allow for
407         switching the focus synchronously between WebViews, we need to intercept
408         didFocus and didBlur and forward it to the WebTestDelegate.
409
410         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
411         (WebTestDelegate):
412         (WebTestRunner::WebTestDelegate::setFocus):
413         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
414         (WebTestRunner::WebTestProxy::didFocus):
415         (WebTestRunner::WebTestProxy::didBlur):
416         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
417         (WebTestRunner::TestRunner::setWindowIsKey):
418         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
419         (WebTestRunner::WebTestProxyBase::didFocus):
420         (WebTestRunner):
421         (WebTestRunner::WebTestProxyBase::didBlur):
422         * DumpRenderTree/chromium/WebViewHost.cpp:
423         (WebViewHost::didFocus):
424         (WebViewHost::didBlur):
425         (WebViewHost::setFocus):
426         * DumpRenderTree/chromium/WebViewHost.h:
427         (WebViewHost):
428
429 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
430
431         [GTK] No need to manually add system paths to jhbuildrc
432         https://bugs.webkit.org/show_bug.cgi?id=110850
433
434         Reviewed by Gustavo Noronha Silva.
435
436         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
437         already takes care of.
438
439 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
440
441         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
442         https://bugs.webkit.org/show_bug.cgi?id=111284
443
444         Disabling the failing two tests on Android.
445
446         Reviewed by Jochen Eisinger.
447
448         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
449         (TestWebKitAPI):
450         (TestWebKitAPI::TEST):
451
452 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
453
454         Add build flag for FontLoader
455         https://bugs.webkit.org/show_bug.cgi?id=111289
456
457         Reviewed by Benjamin Poulain.
458
459         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
460
461         * Scripts/webkitperl/FeatureList.pm:
462         * qmake/mkspecs/features/features.pri:
463
464 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
465
466         [Mac] Get rid of a useless method from DOMHTMLInputElement
467         https://bugs.webkit.org/show_bug.cgi?id=111279
468
469         Reviewed by Sam Weinig.
470
471         * DumpRenderTree/mac/TestRunnerMac.mm:
472         (TestRunner::setValueForUser):
473         The method _setValueForUser: was added for testing. This feature is already
474         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
475         in real use cases. Get rid of the method created for testing, use the real thing
476         instead.
477
478 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
479
480         Some perf. tests have variances that differ greatly between runs
481         https://bugs.webkit.org/show_bug.cgi?id=97510
482
483         Reviewed by Benjamin Poulain.
484
485         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
486         environment on test results (we run each instance after one another, not in parallel).
487
488         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
489         iterations as it was done previously in single process. These values are hard-coded in perftest.py
490         and runner.js but they are to be configurable in the future.
491
492         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
493         metric now reports an array of the length 4 with each element containing an array of 5 iteration
494         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
495
496         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
497         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
498         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
499
500         * Scripts/webkitpy/performance_tests/perftest.py:
501         (PerfTestMetric.append_group): Renamed from append.
502         (PerfTestMetric.grouped_iteration_values): Added.
503         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
504
505         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
506         This parameter is only used by SingleProcessPerfTest.
507
508         (PerfTest.run): Repeat tests using different driver processes.
509         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
510         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
511         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
512         (PerfTest._ensure_metrics): Added.
513
514         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
515         instances of DumpRenderTree/WebKitTestRunner takes too long.
516         (SingleProcessPerfTest.__init__):
517
518         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
519
520         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
521
522         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
523         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
524         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
525
526         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
527         grouped_iteration_values.
528
529         (TestPerfTest._assert_results_are_correct):
530
531         (TestSingleProcessPerfTest): Added.
532         (TestSingleProcessPerfTest.test_use_only_one_process):
533         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
534
535         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
536         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
537
538         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
539         sample standard deviations since we're now running tests 4 times.
540         (MainTest._test_run_with_json_output.mock_upload_json):
541         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
542
543 2013-03-03  Alexandre Elias  <aelias@chromium.org>
544
545         [chromium] Remove WebLayerTreeView::setViewportSize call
546         https://bugs.webkit.org/show_bug.cgi?id=110727
547
548         Reviewed by James Robinson.
549
550         After https://codereview.chromium.org/12328080 lands,
551         setViewportSize is called from the Chromium side. The multiplication
552         by deviceScaleFactor here was prone to off-by-one errors.
553         The layoutSize() function was only used here so delete it as well.
554
555         DumpRenderTree WebViewHost must now call this method as well.
556
557         * DumpRenderTree/chromium/WebViewHost.cpp:
558         (WebViewHost::initializeLayerTreeView):
559         (WebViewHost::setWindowRect):
560         (WebViewHost::setDeviceScaleFactor):
561         (WebViewHost::updateViewportSize):
562         * DumpRenderTree/chromium/WebViewHost.h:
563         (WebViewHost):
564
565 2013-02-27  Darin Adler  <darin@apple.com>
566
567         StringHasher functions require alignment that call sites do not all guarantee
568         https://bugs.webkit.org/show_bug.cgi?id=110171
569
570         Reviewed by Benjamin Poulain.
571
572         * TestWebKitAPI/CMakeLists.txt:
573         * TestWebKitAPI/GNUmakefile.am:
574         * TestWebKitAPI/TestWebKitAPI.gypi:
575         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
576         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
578         * TestWebKitAPI/Tests/WTF/WTF.pro:
579         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
580         Added the StringHasher.cpp file.
581
582         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
583         for the functions in the StringHasher class.
584
585 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
586
587         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
588         https://bugs.webkit.org/show_bug.cgi?id=109772
589
590         Reviewed by Andreas Kling.
591
592         * DumpRenderTree/TestRunner.cpp:
593         (TestRunner::staticFunctions):
594         * DumpRenderTree/TestRunner.h:
595         (TestRunner):
596         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
597         * DumpRenderTree/efl/TestRunnerEfl.cpp:
598         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
599         * DumpRenderTree/mac/TestRunnerMac.mm:
600         * DumpRenderTree/qt/TestRunnerQt.cpp:
601         * DumpRenderTree/qt/TestRunnerQt.h:
602         (TestRunner):
603         * DumpRenderTree/win/TestRunnerWin.cpp:
604         * DumpRenderTree/wx/TestRunnerWx.cpp:
605         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
606         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
607         * WebKitTestRunner/InjectedBundle/TestRunner.h:
608         (TestRunner):
609
610 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
611
612         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
613         https://bugs.webkit.org/show_bug.cgi?id=110943
614
615         Reviewed by Yury Semikhatsky.
616
617         Unfortunately in many cases raw pointer may point to an object that has been deleted.
618         There is no working solution to solve this problem in general.
619         It could be solved only on case by case basis.
620
621         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
622         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
623         (TestWebKitAPI::TEST):
624
625 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
626
627         Move markerTextForListItem from TestRunner to Internals
628         https://bugs.webkit.org/show_bug.cgi?id=110939
629
630         Reviewed by Benjamin Poulain.
631
632         * DumpRenderTree/TestRunner.cpp:
633         (TestRunner::staticFunctions):
634         * DumpRenderTree/TestRunner.h:
635         (TestRunner):
636         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
637         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
638         (WebTestRunner::TestRunner::TestRunner):
639         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
640         (TestRunner):
641         * DumpRenderTree/efl/TestRunnerEfl.cpp:
642         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
643         * DumpRenderTree/mac/TestRunnerMac.mm:
644         * DumpRenderTree/qt/TestRunnerQt.cpp:
645         * DumpRenderTree/qt/TestRunnerQt.h:
646         (TestRunnerQt):
647         * DumpRenderTree/win/TestRunnerWin.cpp:
648         * DumpRenderTree/wx/TestRunnerWx.cpp:
649         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
651         * WebKitTestRunner/InjectedBundle/TestRunner.h:
652         (TestRunner):
653
654 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
655
656         Don't use legacy test names when returning results from PerfTest.run
657         https://bugs.webkit.org/show_bug.cgi?id=111148
658
659         Reviewed by Dirk Pranke.
660
661         * Scripts/webkitpy/performance_tests/perftest.py:
662         (PerfTestMetric.name): Renamed from metric.
663         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
664         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
665         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
666
667         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
668         (TestPerfTestMetric.test_init_set_time_metric):
669         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
670         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
671         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
672
673         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
674         (PerfTestsRunner.__init__):
675         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
676         to obtain the trac URL instead of hard coding it.
677         (PerfTestsRunner._run_tests_set):
678
679 2013-03-01  Roger Fong  <roger_fong@apple.com>
680
681         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
682         https://bugs.webkit.org/show_bug.cgi?id=111202
683
684         This is useful for running VCExpress builds from command line because there is
685         no unified solution output, only per project build logs.
686         The project will be run as the last project in the solution.
687
688         * win/AssembleBuildLogs: Added.
689         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
690         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
691         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
692         * win/AssembleBuildLogs/README: Added.
693
694 2013-03-01  Roger Fong  <roger_fong@apple.com>
695
696         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
697
698         * EWSTools/start-queue-win.sh:
699
700 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
701
702         Don't return statistics in PerfTest.run
703         https://bugs.webkit.org/show_bug.cgi?id=111145
704
705         Reviewed by Dirk Pranke.
706
707         Simply return a list of values obtained in each iteration from PerfTest.run.
708         Also simplify various methods as needed.
709
710         * Scripts/webkitpy/performance_tests/perftest.py:
711         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
712         as needed from PerfTestsRunner._generate_results_dict.
713
714         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
715         that we don't have to worry about the backward compatibility here.
716
717         (PerfTestMetric.iteration_values): Added.
718         (PerfTestMetric.unit): Added.
719         (PerfTestMetric.metric_to_unit):
720         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
721
722         (PerfTest.run):
723         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
724
725         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
726         (TestPerfTestMetric.test_init_set_missing_unit):
727         (TestPerfTestMetric.test_init_set_time_metric): Added.
728         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
729         (TestPerfTestMetric.test_append):
730         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
731         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
732         (TestPerfTest._assert_results_are_correct):
733         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
734         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
735
736         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
737         (PerfTestsRunner._generate_results_dict):
738
739         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
740         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
741         (SomeParserTestData): Ditto.
742         (MemoryTestData): Ditto.
743
744 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
745
746         [Qt] Enable LINK_PREFETCH
747         https://bugs.webkit.org/show_bug.cgi?id=111158
748
749         Reviewed by Simon Hausmann.
750
751         * qmake/mkspecs/features/features.pri:
752
753 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
754
755         [Qt] Update features.pri with new features
756         https://bugs.webkit.org/show_bug.cgi?id=111157
757
758         Reviewed by Jocelyn Turcotte.
759
760         * qmake/mkspecs/features/features.pri:
761
762 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
763
764         [chromium] put WebTestProxy::scheduleComposite back in place
765         https://bugs.webkit.org/show_bug.cgi?id=111146
766
767         Reviewed by Nico Weber.
768
769         The call was removed in http://trac.webkit.org/changeset/144398 because
770         DRT doesn't need it. However, content shell depends on this call.
771
772         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
773         (WebTestRunner::WebTestProxy::scheduleComposite):
774
775 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
776
777         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
778         https://bugs.webkit.org/show_bug.cgi?id=111142
779
780         Reviewed by Adam Barth.
781
782         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
783
784         Also removed _print_status since it's never used anywhere.
785
786         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
787         (PerfTestsRunner.run):
788         (PerfTestsRunner._run_tests_set):
789         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
790         (MainTest.run_test):
791         (MainTest.test_run_test_set):
792         (MainTest.test_run_test_set_kills_drt_per_run):
793         (MainTest.test_run_test_set_for_parser_tests):
794
795 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
796
797         Disable window occlusion detection for WebKitTestRunner Web View on Mac
798         https://bugs.webkit.org/show_bug.cgi?id=111116
799
800         Reviewed by Simon Fraser.
801
802         Window occlusion notifications were causing WebKitTestRunner's Web View
803         to be detected as occluded and causing a few JavaScript timer layout
804         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
805         by initializing the page visibility to "visible" after creating the view.
806         But a better solution is to disable window occlusion detection, so that
807         not only the page but also the view is treated as visible.
808
809         * WebKitTestRunner/TestController.cpp:
810         (WTR::TestController::createWebViewWithOptions): Remove call to
811         setVisibilityState, since it is no longer necessary.
812         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
813         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
814         detection for the created WKView.
815
816 2013-02-28  Li Yin  <li.yin@intel.com>
817
818         [chromium] Events can't be triggered on MediaStreamTrack
819         https://bugs.webkit.org/show_bug.cgi?id=110930
820
821         Reviewed by Kentaro Hara.
822
823         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
824
825         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
826         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
827
828 2013-02-27  James Robinson  <jamesr@chromium.org>
829
830         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
831         https://bugs.webkit.org/show_bug.cgi?id=111017
832
833         Reviewed by Adam Barth.
834
835         This decouples DumpRenderTree from WebLayerTreeViewClient.
836
837         * DumpRenderTree/chromium/WebViewHost.cpp:
838         (WebViewHostDRTLayerTreeViewClient):
839         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
840         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
841         (WebViewHostDRTLayerTreeViewClient::Layout):
842         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
843         (WebViewHost::initializeLayerTreeView):
844         * DumpRenderTree/chromium/WebViewHost.h:
845         (webkit_support):
846         (WebViewHost):
847
848 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
849
850         Unreviewed, add my secondary email address to the list.
851
852         * Scripts/webkitpy/common/config/committers.py:
853
854 2013-02-28  Philip Rogers  <pdr@google.com>
855
856         Add Philip Rogers as a reviewer.
857
858         Unreviewed update of committers.py.
859
860         * Scripts/webkitpy/common/config/committers.py:
861
862 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
863
864         Merge more methods on PerfTest
865         https://bugs.webkit.org/show_bug.cgi?id=111030
866
867         Reviewed by Dirk Pranke.
868
869         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
870         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
871
872         This makes the control flow a lot more comprehensible.
873
874         * Scripts/webkitpy/performance_tests/perftest.py:
875         (PerfTest._run_with_driver):
876         (PerfTest._should_ignore_line):
877         (PerfTest._filter_output):
878
879         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
880         (TestPerfTest._assert_results_are_correct):
881         (test_ignored_stderr_lines):
882
883 2013-02-28  Robert Hogan  <robert@webkit.org>
884
885         Update my IRC nick
886
887         Unreviewed.
888
889         * Scripts/webkitpy/common/config/committers.py:
890
891 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
892
893         [Qt] Enable thin archives before parsing the project files
894
895         Rubber-stamped by Simon Hausmann.
896
897         The targetSubDir() function can be called before default_post.prf has been
898         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
899         which is parsed before the main project file.
900         This issue was revealed by r144299 and fixes the clean build.
901
902         * qmake/mkspecs/features/default_post.prf:
903         * qmake/mkspecs/features/default_pre.prf:
904
905 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
906
907         [Qt] Enable CANVAS_PATH flag
908         https://bugs.webkit.org/show_bug.cgi?id=108508
909
910         Reviewed by Simon Hausmann.
911
912         Also enable CANVAS_PATH flag for Qt.
913
914         * qmake/mkspecs/features/features.pri:
915
916 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
917
918         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
919
920         Rubber-stamped by Csaba Osztrogonác.
921
922         Besides suppressing a warning about the non-existing function this
923         fixes the build if there is a subdirectory (eg. debug-and-release).
924
925         * TestWebKitAPI/InjectedBundle.pri:
926         * TestWebKitAPI/TestWebKitAPI.pri:
927
928 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
929
930         [EFL][WTR] WTR cannot load injected bundle
931         https://bugs.webkit.org/show_bug.cgi?id=111063
932
933         Reviewed by Csaba Osztrogonác.
934
935         WTR was not able to load injected bundle because of undefined 
936         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
937         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
938         solves the problem.
939
940         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
941         (WTR::AccessibilityUIElement::scrollToMakeVisible):
942
943 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
944
945         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
946         https://bugs.webkit.org/show_bug.cgi?id=110464
947
948         Reviewed by Rob Buis.
949
950         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
951
952 2013-02-28  Xan Lopez  <xlopez@rim.com>
953
954         [BlackBerry] DumpRenderTreeSupport: update the set position methods
955         https://bugs.webkit.org/show_bug.cgi?id=110578
956
957         Reviewed by Rob Buis.
958
959         TestRunner::setMockGeolocationPosition() changed in r130416:
960         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
961
962         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
963         setMockGeolocationPositionUnavailableError() in r129444:
964         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
965
966         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
967         (TestRunner::setMockGeolocationPosition):
968         (TestRunner::setMockGeolocationPositionUnavailableError):
969
970 2013-02-28  Xan Lopez  <xlopez@rim.com>
971
972         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
973         https://bugs.webkit.org/show_bug.cgi?id=110465
974
975         Reviewed by Rob Buis.
976
977         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
978         (LoadItem::invoke):
979
980 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
981
982         PerfTestRunner doesn't need _needs_http and _has_http_lock
983         https://bugs.webkit.org/show_bug.cgi?id=111037
984
985         Reviewed by Adam Barth.
986
987         Delete these variables in favor of using a local variable.
988
989         Member variables are like global variables. They introduce implicit dependencies
990         between member functions.
991
992         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
993         (PerfTestsRunner.__init__):
994         (PerfTestsRunner._start_http_servers):
995         (PerfTestsRunner):
996         (PerfTestsRunner._stop_http_servers):
997         (PerfTestsRunner.run):
998
999 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1000
1001         Unreviewed, rolling out r144224.
1002         http://trac.webkit.org/changeset/144224
1003         https://bugs.webkit.org/show_bug.cgi?id=111045
1004
1005         Caused plugins/pass-different-npp-struct.html to time out
1006         (Requested by abarth on #webkit).
1007
1008         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1009         (PassDifferentNPPStruct::NPP_SetWindow):
1010         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1011         (NPP_SetWindow):
1012
1013 2013-02-27  Adam Barth  <abarth@webkit.org>
1014
1015         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1016         https://bugs.webkit.org/show_bug.cgi?id=110907
1017
1018         Reviewed by Eric Seidel.
1019
1020         This patch changes --enable-threaded-html-parser into
1021         --disable-threaded-html-parser and thereby enables the threaded HTML
1022         parser by default for the Chromium port.
1023
1024         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1025         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1026         (WebTestRunner::WebPreferences::reset):
1027         * DumpRenderTree/chromium/TestShell.cpp:
1028         (TestShell::TestShell):
1029
1030 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
1031
1032         Initialize page visibility after creating WebKitTestRunner WebView on Mac
1033         https://bugs.webkit.org/show_bug.cgi?id=111025
1034
1035         Reviewed by Simon Fraser.
1036
1037         Set page visibility to "visible" after creating WebView to override
1038         visibility state inferred from window occlusion notifications on Mac.
1039
1040         * WebKitTestRunner/TestController.cpp:
1041         (WTR::TestController::createWebViewWithOptions): Add call to
1042         setVisibilityState.
1043
1044 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1045
1046         Merge PageLoadingPerfTest into ReplayPerfTest
1047         https://bugs.webkit.org/show_bug.cgi?id=111027
1048
1049         Reviewed by Dirk Pranke.
1050
1051         Merged two classes.
1052
1053         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
1054         part of ReplayPerfTest.
1055
1056         * Scripts/webkitpy/performance_tests/perftest.py:
1057         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
1058         (ReplayPerfTest.__init__):
1059         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
1060         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
1061         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1062         (TestReplayPerfTest):
1063         (TestReplayPerfTest.test_run_single.run_test):
1064         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
1065         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
1066         TestPageLoadingPerfTest.test_run.
1067         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
1068         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
1069         TestPageLoadingPerfTest.test_run_with_memory_output
1070         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
1071         (TestReplayPerfTest.test_prepare_calls_run_single):
1072
1073 2013-02-27  Eric Seidel  <eric@webkit.org>
1074
1075         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
1076         https://bugs.webkit.org/show_bug.cgi?id=111021
1077
1078         Reviewed by Dirk Pranke.
1079
1080         The underlying code (which is shared with run-webkit-tests)
1081         already knew how to support this option, it just wasn't exposed
1082         via the run-perf-tests front-end.  This patch fixes that.
1083
1084         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1085         (PerfTestsRunner._parse_args):
1086
1087 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1088
1089         Stop uploading results to webkit-perf.appspot.com
1090         https://bugs.webkit.org/show_bug.cgi?id=110954
1091
1092         Reviewed by Benjamin Poulain.
1093
1094         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
1095
1096         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1097         (RunAndUploadPerfTests):
1098
1099 2013-02-27  James Simonsen  <simonjam@chromium.org>
1100
1101         [chromium] Lower priority of preloaded images
1102         https://bugs.webkit.org/show_bug.cgi?id=110527
1103
1104         Plumb the didChangePriority signal into DRT so it can be tested.
1105
1106         Reviewed by Nate Chapin.
1107
1108         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1109         (WebKit):
1110         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
1111         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1112         (WebTestRunner::TestRunner::TestRunner):
1113         (WebTestRunner::TestRunner::reset):
1114         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
1115         (WebTestRunner):
1116         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
1117         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1118         (TestRunner):
1119         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1120         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1121         (WebTestRunner::WebTestProxyBase::willSendRequest):
1122         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
1123         (WebTestRunner):
1124
1125 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
1126
1127         AX: Mac platform should support ability to scroll an element into visible
1128         https://bugs.webkit.org/show_bug.cgi?id=109860
1129
1130         Reviewed by Beth Dakin.
1131
1132         * DumpRenderTree/AccessibilityUIElement.cpp:
1133         (scrollToMakeVisibleCallback):
1134         (AccessibilityUIElement::getJSClass):
1135         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1136         (AccessibilityUIElement::scrollToMakeVisible):
1137         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1138         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1139         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1140         (AccessibilityUIElement):
1141         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1142         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1143         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1144         (WTR):
1145
1146 2013-02-27  John Bauman  <jbauman@chromium.org>
1147
1148         Plugin in iframe may not display
1149         https://bugs.webkit.org/show_bug.cgi?id=109879
1150
1151         Reviewed by Simon Fraser.
1152
1153         LogNPPSetWindow will be used with other ports as well.
1154
1155         * DumpRenderTree/DumpRenderTree.gypi:
1156         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1157
1158 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
1159
1160         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
1161         https://bugs.webkit.org/show_bug.cgi?id=110973
1162
1163         Reviewed by Adam Barth.
1164
1165         There is nothing that ensures that the log messages from the plugin
1166         come in before the layout test finished loading.
1167
1168         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1169         (PassDifferentNPPStruct::NPP_SetWindow):
1170         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1171         (NPP_SetWindow):
1172
1173 2013-02-27  Glenn Adams  <glenn@skynav.com>
1174
1175         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
1176         https://bugs.webkit.org/show_bug.cgi?id=110944
1177
1178         Reviewed by Dean Jackson.
1179
1180         * Scripts/webkitperl/FeatureList.pm:
1181         * qmake/mkspecs/features/features.pri:
1182
1183 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
1184
1185         Unreviewed. Remove myself from watchlist.
1186
1187         * Scripts/webkitpy/common/config/watchlist:
1188
1189 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1190
1191         Switch QtWebKit to GStreamer 1.0.
1192         https://bugs.webkit.org/show_bug.cgi?id=106669.
1193
1194         Original patch by Sebastian Dröge.
1195         Reviewed by Csaba Osztrogonác.
1196
1197         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
1198         temporarily to make upgrading easy and the patch suitable for Qt5.
1199
1200         * qmake/mkspecs/features/features.prf:
1201
1202 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1203
1204         Unreviewed. Added myself to committers.py
1205
1206         * Scripts/webkitpy/common/config/committers.py:
1207
1208 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1209
1210         Unreviewed, rolling out r144192.
1211         http://trac.webkit.org/changeset/144192
1212         https://bugs.webkit.org/show_bug.cgi?id=110984
1213
1214         Stored svn password on wrong computer (Requested by kkristof
1215         on #webkit).
1216
1217         * Scripts/webkitpy/common/config/committers.py:
1218
1219 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1220
1221         Unreviewed. Added myself to committers.py
1222
1223         * Scripts/webkitpy/common/config/committers.py:
1224
1225 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1226
1227         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
1228
1229         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1230         (PerfTestsRunner._upload_json):
1231
1232 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1233
1234         Stop uploading results to webkit-perf.appspot.com
1235         https://bugs.webkit.org/show_bug.cgi?id=110954
1236
1237         Reviewed by Benjamin Poulain.
1238
1239         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
1240         Also, always use the new JSON format. Removed the code to generate the old format.
1241
1242         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1243         (PerfTestsRunner._generate_and_show_results):
1244         (PerfTestsRunner._generate_results_dict):
1245         (PerfTestsRunner._merge_slave_config_json):
1246         (PerfTestsRunner._generate_output_files):
1247
1248 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1249
1250         Unreviewed, rolling out r144136, r144143, and r144147.
1251         http://trac.webkit.org/changeset/144136
1252         http://trac.webkit.org/changeset/144143
1253         http://trac.webkit.org/changeset/144147
1254         https://bugs.webkit.org/show_bug.cgi?id=110950
1255
1256         Caused some timeouts and flaky crashes (Requested by abarth on
1257         #webkit).
1258
1259         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1260         (main):
1261         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1262         (WebTestRunner::WebPreferences::reset):
1263         * DumpRenderTree/chromium/TestShell.cpp:
1264         (TestShell::TestShell):
1265
1266 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1267
1268         Use perf.webkit.org JSON format in results page
1269         https://bugs.webkit.org/show_bug.cgi?id=110842
1270
1271         Reviewed by Benjamin Poulain.
1272
1273         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
1274
1275         A whole bunch of integration tests have been updated to use the new JSON format.
1276
1277         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1278         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
1279         and legacy_output_json_path respectively.
1280         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
1281         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
1282         JSON file and the results page out of perf_webkit_output instead of legacy_output.
1283
1284         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1285         (MainTest.test_run_memory_test):
1286         (MainTest._test_run_with_json_output.mock_upload_json):
1287         (MainTest):
1288         (MainTest.test_run_with_json_output):
1289         (MainTest.test_run_with_description):
1290         (MainTest.test_run_generates_json_by_default):
1291         (MainTest.test_run_merges_output_by_default):
1292         (MainTest.test_run_respects_reset_results):
1293         (MainTest.test_run_generates_and_show_results_page):
1294         (MainTest.test_run_with_slave_config_json):
1295         (MainTest.test_run_with_multiple_repositories):
1296         (MainTest.test_run_with_upload_json):
1297         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1298
1299 2013-02-26  Adam Barth  <abarth@webkit.org>
1300
1301         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1302         https://bugs.webkit.org/show_bug.cgi?id=110907
1303
1304         Reviewed by Eric Seidel.
1305
1306         This patch changes --enable-threaded-html-parser into
1307         --disable-threaded-html-parser and thereby enables the threaded HTML
1308         parser by default for the Chromium port.
1309
1310         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1311         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1312         (WebTestRunner::WebPreferences::reset):
1313         * DumpRenderTree/chromium/TestShell.cpp:
1314         (TestShell::TestShell):
1315
1316 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
1317
1318         [chromium] Re-enable the fixed version of freetype on linux
1319         https://bugs.webkit.org/show_bug.cgi?id=110542
1320
1321         Reviewed by Tony Chang.
1322
1323         Re-land the change in r143794 to switch to building with a fixed
1324         version of FreeType for just DumpRenderTree. This allows us to share
1325         one version of pixel baselines for both Lucid and Precise, and run the
1326         layout tests in a stock Precise install (instead of a Lucid chroot).
1327         Going forward, this approach isolates us from os-level changes to the
1328         version of FreeType. Note that Chromium itself still uses the system
1329         FreeType and is unaffected by this change.
1330         
1331         This setting can still be turned off (at compile/gyp-time) by
1332         manually setting use_custom_freetype=0.
1333
1334         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1335
1336 2013-02-26  Nico Weber  <thakis@chromium.org>
1337
1338         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
1339         https://bugs.webkit.org/show_bug.cgi?id=110890
1340
1341         Reviewed by Jochen Eisinger.
1342
1343         Several functions in webkit check that bit to change rendering
1344         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
1345         disables font smoothing in this mode. TestShell and DRT both set
1346         this flag, so content shell drt should set it too.
1347
1348         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1349         (WebTestRunner::TestInterfaces::TestInterfaces):
1350
1351 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1352
1353         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
1354         https://bugs.webkit.org/show_bug.cgi?id=110884
1355
1356         Reviewed by Csaba Osztrogonác.
1357
1358         Adding the missing spaces before ':' in the unit test.
1359
1360         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1361
1362 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1363
1364         new-commit-bot: Some IRC clients doesn't linkify rollout messages
1365         https://bugs.webkit.org/show_bug.cgi?id=110861
1366
1367         Reviewed by Ryosuke Niwa.
1368
1369         Adding the space before ':' in order to fix the links shown for the rollout message.
1370
1371         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1372         (NewCommitBot._summarize_commit_log):
1373
1374 2013-02-26  Joone Hur  <joone.hur@intel.com>
1375
1376         [GTK] Add Clutter to jhbuild
1377         https://bugs.webkit.org/show_bug.cgi?id=110245
1378
1379         Reviewed by Martin Robinson.
1380
1381         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
1382         This allows to build WebKitGtk+ with clutter as an acceleration backend
1383         within the jhbuild environment. 
1384
1385         * gtk/jhbuild-optional.modules:
1386
1387 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1388
1389         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
1390
1391         * Scripts/webkitpy/common/checkout/scm/svn.py:
1392         (SVN.value_from_svn_info):
1393
1394 2013-02-25  Alan Cutter  <alancutter@chromium.org>
1395
1396         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
1397         https://bugs.webkit.org/show_bug.cgi?id=110845
1398
1399         Unreviewed EWS bot fix.
1400
1401         Switch the Queue Status Server address the EWS bots use to a more direct URL that
1402         doesn't seem to be having problems from GCE like queues.webkit.org.
1403
1404         * Scripts/webkitpy/common/net/statusserver.py:
1405         (StatusServer):
1406
1407 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1408
1409         Forgot to delete a no-longer-needed unit test after r143980.
1410
1411         Unreviewed, build fix.
1412
1413         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1414         (ChromiumWinTest.test_path_to_image_diff):
1415
1416 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1417
1418         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
1419         Don't include \r at the end of svn info lines on Windows.
1420
1421         This is similar to r143839.
1422
1423         * Scripts/webkitpy/common/checkout/scm/svn.py:
1424         (SVN.value_from_svn_info):
1425
1426 2013-02-25  James Simonsen  <simonjam@chromium.org>
1427
1428         [Resource Timing] Update test suite so it can be exported to the W3C
1429         https://bugs.webkit.org/show_bug.cgi?id=107343
1430
1431         Reviewed by Tony Gentilcore.
1432
1433         * Scripts/export-w3c-performance-wg-tests: Clean up output.
1434         * Scripts/import-w3c-performance-wg-tests:
1435
1436 2013-02-25  Anders Carlsson  <andersca@apple.com>
1437
1438         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
1439         https://bugs.webkit.org/show_bug.cgi?id=110821
1440         <rdar://problem/13265303>
1441
1442         Reviewed by Beth Dakin.
1443
1444         Update for WebKit2 changes.
1445
1446         * MiniBrowser/mac/WK2BrowserWindowController.m:
1447         (-[WK2BrowserWindowController awakeFromNib]):
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::TestController::createOtherPage):
1450         (WTR::TestController::createWebViewWithOptions):
1451         (WTR::TestController::unavailablePluginButtonClicked):
1452         * WebKitTestRunner/TestController.h:
1453         (TestController):
1454
1455 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
1456
1457         Optionally partition cache to prevent using cache for tracking
1458         https://bugs.webkit.org/show_bug.cgi?id=110269
1459
1460         Reviewed by Maciej Stachowiak.
1461
1462         Add test suite for public suffix functions on Mac.
1463
1464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1465         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
1466         (TestWebKitAPI):
1467         (TestWebKitAPI::TEST_F):
1468
1469 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1470
1471         nrwt: reenable multiple http shards on chromium win
1472         https://bugs.webkit.org/show_bug.cgi?id=110814
1473
1474         Reviewed by Tony Chang.
1475
1476         The underlying bug in DumpRenderTree that was causing us to look for a
1477         pac file and timeout under load was fixed a while ago.
1478
1479         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1480         (ChromiumWinPort.relative_test_filename):
1481
1482 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1483
1484         Make ninja the default w/ build-webkit --chromium on windows.
1485         https://bugs.webkit.org/show_bug.cgi?id=110731
1486
1487         Unreviewed - TBR'ing thakis :).
1488
1489         * Scripts/update-webkit-chromium:
1490
1491 2013-02-25  Anders Carlsson  <andersca@apple.com>
1492
1493         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
1494         https://bugs.webkit.org/show_bug.cgi?id=110793
1495         <rdar://problem/13265303>
1496
1497         Reviewed by Sam Weinig.
1498
1499         Update for WebKit2 API changes.
1500
1501         * MiniBrowser/mac/WK2BrowserWindowController.m:
1502         (-[WK2BrowserWindowController awakeFromNib]):
1503         * WebKitTestRunner/TestController.cpp:
1504         (WTR::TestController::createWebViewWithOptions):
1505
1506 2013-02-25  Nico Weber  <thakis@chromium.org>
1507
1508         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
1509         https://bugs.webkit.org/show_bug.cgi?id=110775
1510
1511         Unreviewed, basically a rebaseline.
1512
1513         * Scripts/webkitpy/common/config/watchlist:
1514
1515 2013-02-25  Nico Weber  <thakis@chromium.org>
1516
1517         [chromium] Try to get the webkit builder to use msvs again
1518         https://bugs.webkit.org/show_bug.cgi?id=110771
1519
1520         Reviewed by Eric Seidel.
1521
1522         The msvs gyp generator apparently doesn't write the sln file on every
1523         run, so check the vcxproj file instead.
1524
1525         * Scripts/webkitdirs.pm:
1526         (determineIsChromiumNinja):
1527
1528 2013-02-25  Nico Weber  <thakis@chromium.org>
1529
1530         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
1531         https://bugs.webkit.org/show_bug.cgi?id=110767
1532
1533         Reviewed by Eric Seidel.
1534
1535         The tester runs gyp, which generates out/Release/build.ninja. The bot
1536         scripts use existence (and timestamp) of that file to decide if the
1537         current build is supposed to be ninja or xcodebuild. The file exists,
1538         so the snapshot is extracted to out/Release. The snapshot doesn't
1539         contain build.ninja however due to
1540         http://trac.webkit.org/changeset/140375 , so after extracting the
1541         snapshot the scripts think that this is an xcodebuild build. So remove
1542         the part of that revision that removed ninja files from the archive,
1543         and the bots should be happy again.
1544
1545         * BuildSlaveSupport/built-product-archive:
1546         (archiveBuiltProduct):
1547
1548 2013-02-25  Nico Weber  <thakis@chromium.org>
1549
1550         Fix tests after r143910
1551         https://bugs.webkit.org/show_bug.cgi?id=110757
1552
1553         Reviewed by Andreas Kling.
1554
1555         While here, also add a test for the bug r143910 fixed.
1556
1557         * Scripts/webkitpy/common/system/executive_unittest.py:
1558         (ScriptErrorTest.test_message_with_output):
1559         (ScriptErrorTest):
1560         (ScriptErrorTest.test_message_with_tuple):
1561
1562 2013-02-25  Nico Weber  <thakis@chromium.org>
1563
1564         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
1565         https://bugs.webkit.org/show_bug.cgi?id=110755
1566
1567         Reviewed by Jochen Eisinger.
1568
1569         * BuildSlaveSupport/built-product-archive:
1570         (archiveBuiltProduct):
1571         (extractBuiltProduct):
1572
1573 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1574
1575         Unreviewed, rolling out r143895.
1576         http://trac.webkit.org/changeset/143895
1577         https://bugs.webkit.org/show_bug.cgi?id=110758
1578
1579         broke a bunch of tests (Requested by thakis__ on #webkit).
1580
1581         * Scripts/update-webkit-chromium:
1582
1583 2013-02-25  Andreas Kling  <akling@apple.com>
1584
1585         Unreviewed, fix simple mistake in r143903.
1586         <http://webkit.org/b/110746>
1587
1588         Reviewed by Andreas Kling.
1589
1590         Pass git revision, not svn revision, to git shell command.
1591
1592         * Scripts/webkitpy/common/checkout/scm/git.py:
1593         (Git.timestamp_of_latest_commit):
1594
1595 2013-02-25  Nico Weber  <thakis@chromium.org>
1596
1597         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
1598         https://bugs.webkit.org/show_bug.cgi?id=110748
1599
1600         Reviewed by Jochen Eisinger.
1601
1602         One of the mac testers runs DRT from out/ but WebKitUnitTests from
1603         xcodebuild. I'm trying to understand what's going on.
1604
1605         * BuildSlaveSupport/built-product-archive:
1606         (archiveBuiltProduct):
1607         (extractBuiltProduct):
1608
1609 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
1610
1611         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
1612         https://bugs.webkit.org/show_bug.cgi?id=110599
1613
1614         Reviewed by Yury Semikhatsky.
1615
1616         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
1617         that were given us via MemoryInstrumentation calls.
1618         So I extended client api with registerString method that pushes the strings
1619         down to the serializer.
1620
1621         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1622         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1623         (TestWebKitAPI::Helper::Helper):
1624         (Helper):
1625         (TestWebKitAPI::Helper::addNode):
1626         (TestWebKitAPI::TEST):
1627
1628 2013-02-25  Nico Weber  <thakis@chromium.org>
1629
1630         Make ScriptError not crash when args is a tuple
1631         https://bugs.webkit.org/show_bug.cgi?id=110747
1632
1633         Reviewed by Jochen Eisinger.
1634
1635         I'm trying to understand the error on
1636         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
1637         better. I'll likely have to revert the ninja switch on windows, but
1638         having error reporting code that doesn't itself crash sounds like a
1639         good thing to have anyways.
1640
1641         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
1642         tuple not a list.
1643
1644         * Scripts/run-chromium-webkit-unit-tests:
1645         * Scripts/webkitpy/common/system/executive.py:
1646         (ScriptError.__init__):
1647
1648 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
1649
1650         [EFL] Align feature defaults
1651         https://bugs.webkit.org/show_bug.cgi?id=110715
1652
1653         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
1654         OptionsEfl.cmake.
1655
1656         Reviewed by Gyuyoung Kim.
1657
1658         * Scripts/webkitperl/FeatureList.pm:
1659
1660 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1661
1662         run-perf-tests reports wrong commit time
1663         https://bugs.webkit.org/show_bug.cgi?id=110746
1664
1665         Reviewed by Andreas Kling.
1666
1667         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
1668         of when the subdirectory was last modified.
1669
1670         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
1671         insufficient since running "svn log -r <revision>" on a partial checkout only returns
1672         an empty result if the revision didn't modify the subdirectory.
1673
1674         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
1675         the interface compatible with svn.
1676
1677         * Scripts/webkitpy/common/checkout/scm/git.py:
1678         (Git.timestamp_of_latest_commit):
1679         * Scripts/webkitpy/common/checkout/scm/scm.py:
1680         (SCM.timestamp_of_latest_commit):
1681         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1682         (MockSCM.timestamp_of_latest_commit):
1683         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1684         (test_timestamp_of_latest_commit):
1685         * Scripts/webkitpy/common/checkout/scm/svn.py:
1686         (SVN.timestamp_of_latest_commit):
1687         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1688         (PerfTestsRunner._generate_results_dict):
1689
1690 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
1691
1692         [chromium] move WebRuntimeFeatures configuration to TestRunner library
1693         https://bugs.webkit.org/show_bug.cgi?id=110712
1694
1695         Reviewed by Nico Weber.
1696
1697         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1698         (WebTestRunner::TestInterfaces::TestInterfaces):
1699         * DumpRenderTree/chromium/TestShell.cpp:
1700         (TestShell::TestShell):
1701
1702 2013-02-25  Nico Weber  <thakis@chromium.org>
1703
1704         Make ninja the default build system for build-webkit --chromium on windows
1705         https://bugs.webkit.org/show_bug.cgi?id=110731
1706
1707         Reviewed by Jochen Eisinger.
1708
1709         With http://crbug.com/169945 fixed, this should now work.
1710
1711         * Scripts/update-webkit-chromium:
1712
1713 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
1714
1715         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
1716         https://bugs.webkit.org/show_bug.cgi?id=110702
1717
1718         Reviewed by Martin Robinson.
1719
1720         * GtkLauncher/main.c: include autotoolsconfig.h.
1721         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
1722         the include ordering check, since it uses autotoolsconfig.h which needs to
1723         come first.
1724
1725 2013-02-24  Hajime Morrita  <morrita@google.com>
1726
1727         [Custom Elements] Implement bare-bone document.register()
1728         https://bugs.webkit.org/show_bug.cgi?id=100229
1729
1730         Reviewed by Adam Barth.
1731
1732         Added enableCustomDOMElements flag.
1733
1734         * DumpRenderTree/chromium/TestShell.cpp:
1735         (TestShell::TestShell):
1736
1737 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
1738
1739         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
1740         https://bugs.webkit.org/show_bug.cgi?id=110606
1741
1742         Reviewed by Adam Barth.
1743
1744         Part of a larger refactoring series; see tracking bug 82948.
1745
1746         * DumpRenderTree/DumpRenderTree.gypi:
1747         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1748         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
1749         (WebKitSupportTestEnvironment::mockPlatform):
1750         (WebKitSupportTestEnvironment):
1751         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
1752         (MockPlatform::create):
1753         (MockPlatform::MockPlatform):
1754         (MockPlatform::~MockPlatform):
1755         (MockPlatform::setInterfaces):
1756         (MockPlatform::cryptographicallyRandomValues):
1757         (MockPlatform::createMediaStreamCenter):
1758         (MockPlatform::createRTCPeerConnectionHandler):
1759         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
1760         (MockPlatform):
1761         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
1762         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
1763         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1764         (WebTestDelegate):
1765         * DumpRenderTree/chromium/TestShell.cpp:
1766         (TestShell::initialize):
1767         * DumpRenderTree/chromium/TestShell.h:
1768         (TestShell):
1769
1770 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1771
1772         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
1773
1774         * Scripts/webkitpy/common/checkout/scm/svn.py:
1775         (SVN.timestamp_of_latest_commit):
1776
1777 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
1778
1779         Move setAutofilled from TestRunner to WebCore
1780         https://bugs.webkit.org/show_bug.cgi?id=110521
1781
1782         Reviewed by Benjamin Poulain.
1783
1784         * DumpRenderTree/TestRunner.cpp:
1785         (TestRunner::staticFunctions):
1786         * DumpRenderTree/TestRunner.h:
1787         (TestRunner):
1788         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1789         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1790         (WebTestRunner::TestRunner::TestRunner):
1791         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1792         (TestRunner):
1793         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1794         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1795         * DumpRenderTree/mac/TestRunnerMac.mm:
1796         * DumpRenderTree/qt/TestRunnerQt.cpp:
1797         * DumpRenderTree/qt/TestRunnerQt.h:
1798         (TestRunnerQt):
1799         * DumpRenderTree/win/TestRunnerWin.cpp:
1800         * DumpRenderTree/wx/TestRunnerWx.cpp:
1801
1802 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
1803
1804         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
1805         https://bugs.webkit.org/show_bug.cgi?id=108577
1806
1807         Reviewed by Dirk Pranke.
1808
1809         Upload results to perf.webkit.org using new JSON format as well as the host specified by
1810         --test-results-server. The new format is needed to provide extra information perf.webkit.org
1811         need such as the subversion commit time and test URLs. This is a temporarily measure until
1812         we complete the transition and the old JSON format and the code to upload results to
1813         webkit-perf.appspot.com can be deleted.
1814
1815         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
1816         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
1817         so that the app can sort performance test results based on the timestamp of the last commit.
1818
1819         It also changes the repository names returned by port objects to be properly capitalized
1820         human readable names such as WebKit instead of lowercased names such as webkit since these names
1821         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
1822         to explicitly lowercase the names.
1823
1824
1825         * Scripts/webkitpy/common/checkout/scm/git.py:
1826         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
1827         git's timestamp granularity is seconds so we're losing some information compared to using a regular
1828         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
1829         UTC so we're going to manually fiddle with timezone.
1830
1831         * Scripts/webkitpy/common/checkout/scm/scm.py:
1832         (SCM.timestamp_of_latest_commit): Added.
1833
1834         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1835         (MockSCM.timestamp_of_latest_commit): Added.
1836
1837         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1838         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
1839
1840         * Scripts/webkitpy/common/checkout/scm/svn.py:
1841         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
1842         the timestamp which is always in UTC.
1843
1844         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1845         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
1846         'chromium' needs to be substituted by 'chrome' for historical reasons.
1847
1848         * Scripts/webkitpy/layout_tests/port/base.py:
1849         (Port.repository_paths): Return WebKit instead of webkit as noted above.
1850
1851         * Scripts/webkitpy/layout_tests/port/chromium.py:
1852         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
1853
1854         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1855         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
1856         (PerfTestsRunner._collect_tests):
1857
1858         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
1859         and upload them appropriately.
1860
1861         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
1862         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
1863
1864         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
1865
1866         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
1867         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
1868         e.g. "processor" would be renamed to "builderProcessor".
1869
1870         (PerfTestsRunner._generate_output_files):
1871
1872         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
1873         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
1874         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
1875         webkit-perf.appspot.com which spits out a plaintext response.
1876
1877         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1878         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
1879         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
1880         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
1881
1882         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1883         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
1884         cases to parse JSON responses.
1885         (MainTest.test_upload_json.MockFileUploader): Refactored.
1886         (MainTest.test_upload_json.MockFileUploader.reset): Added.
1887         (MainTest.test_upload_json.MockFileUploader.__init__):
1888         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
1889
1890 2013-02-22  Roger Fong  <roger_fong@apple.com>
1891
1892         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
1893
1894         * BuildSlaveSupport/build.webkit.org-config/config.json:
1895
1896 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
1897
1898         Unreviewed, rolling out r143794.
1899         http://trac.webkit.org/changeset/143794
1900         https://bugs.webkit.org/show_bug.cgi?id=110542
1901
1902         debug linux builds broken?
1903
1904         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1905
1906 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
1907
1908         [chromium] enable the fixed version of freetype on linux
1909         https://bugs.webkit.org/show_bug.cgi?id=110542
1910
1911         Reviewed by Tony Chang.
1912
1913         Switch to building with a fixed version of FreeType for
1914         just DumpRenderTree. This allows us to share one version
1915         of pixel baselines for both Lucid and Precise, and run
1916         the layout tests in a stock Precise install (instead of a Lucid
1917         chroot). Going forward, this approach isolates us from os-level
1918         changes to the version of FreeType. Note that Chromium itself
1919         still uses the system FreeType and is unaffected by this change.
1920         
1921         This setting can still be turned off (at compile/gyp-time) by
1922         manually setting use_custom_freetype=0.
1923
1924         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1925
1926 2013-02-22  Anders Carlsson  <andersca@apple.com>
1927
1928         Move pluginLoadPolicy to the page loader client
1929         https://bugs.webkit.org/show_bug.cgi?id=110635
1930
1931         Reviewed by Sam Weinig.
1932
1933         * MiniBrowser/mac/WK2BrowserWindowController.m:
1934         (-[WK2BrowserWindowController awakeFromNib]):
1935         * WebKitTestRunner/TestController.cpp:
1936         (WTR::TestController::createOtherPage):
1937         (WTR::TestController::createWebViewWithOptions):
1938
1939 2013-02-22  Kenneth Russell  <kbr@google.com>
1940
1941         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
1942
1943         * Scripts/webkitpy/common/config/committers.py:
1944
1945 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1946
1947         [WTR] Do not dump information about empty subframes.
1948         https://bugs.webkit.org/show_bug.cgi?id=110585
1949
1950         Reviewed by Simon Fraser.
1951
1952         Follow DumpRenderTree more closely by skipping empty frames
1953         (frames which have no document). We are not really interested in
1954         showing anything about them.
1955
1956         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1957         (WTR::dumpDescendantFramesText): Do not print subframe names when they
1958         have no associated Document.
1959
1960 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1961
1962         [EFL][DRT] Do not dump empty frames.
1963         https://bugs.webkit.org/show_bug.cgi?id=110474
1964
1965         Reviewed by Kenneth Rohde Christiansen.
1966
1967         Follow the original Mac implementation more closely by skipping
1968         empty frames (frames which have no document). We are not really
1969         interested in showing anything about them.
1970
1971         * DumpRenderTree/efl/DumpRenderTree.cpp:
1972         (dumpFramesAsText):
1973
1974 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
1975
1976         [chromium] support the lucid version of freetype on precise in DRT
1977         https://bugs.webkit.org/show_bug.cgi?id=107338
1978
1979         Reviewed by Tony Chang.
1980
1981         Modify the DRT build so that we can optionally link against
1982         a fixed version of Freetype2. This allows us to share pixel test
1983         results across multiple versions of Ubuntu without having to
1984         worry about differences in font rendering.
1985
1986         At the moment this feature is off by default. Eventually it will
1987         be on by default on linux.
1988
1989         Note that this only affects DRT; the regular Chromium binary
1990         (and, for now, content_shell) will still use the system version
1991         of Freetype.
1992
1993         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1994
1995 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
1996
1997         [Chromium] Remove the word "cheher" from the list of misspelled words
1998         https://bugs.webkit.org/show_bug.cgi?id=110447
1999
2000         Reviewed by Tony Chang.
2001
2002         Other platforms do not mark "cheher" as a misspelled word in layout tests.
2003         This change is to bring Chromium platform in line with the rest of the
2004         platforms.
2005
2006         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2007         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
2008         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
2009         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
2010
2011 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
2012
2013         [chromium] document WebTestDelegate and WebTestRunner interfaces
2014         https://bugs.webkit.org/show_bug.cgi?id=110472
2015
2016         Reviewed by Adam Barth.
2017
2018         Also remove the default implementation of the remaining WebTestDelegate
2019         methods now that all embedders provide this interface.
2020
2021         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2022         (WebTestDelegate):
2023         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2024         (WebTestRunner):
2025
2026 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2027
2028         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
2029         https://bugs.webkit.org/show_bug.cgi?id=106059
2030
2031         Reviewed by Geoffrey Garen.
2032
2033         Added new tests for the WebKit API portion of the JSC Objective-C API.
2034
2035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2036         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
2037         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
2038         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
2039         (-[MyConsole log:]):
2040         (-[MyConsole printHelloWorld]):
2041         (-[MyConsole add:to:]):
2042         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
2043         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2044         (TestWebKitAPI):
2045         (TestWebKitAPI::TEST):
2046
2047 2013-02-21  Stephen Chenney  <schenney@chromium.org>
2048
2049         Unreviewed, add myself as a reviewer
2050
2051         * Scripts/webkitpy/common/config/committers.py:
2052
2053 2013-02-21  Jer Noble  <jer.noble@apple.com>
2054
2055         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
2056
2057         * Scripts/webkitpy/common/config/committers.py:
2058         * Scripts/webkitpy/common/config/watchlist:
2059
2060 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2061
2062         gtk/DumpRenderTree.cpp is missing <locale.h> include
2063         https://bugs.webkit.org/show_bug.cgi?id=109386
2064
2065         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
2066         by include locale.h when we use setlocale.
2067
2068 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2069
2070         [GTK] Move feature overriding to the configure phase
2071         https://bugs.webkit.org/show_bug.cgi?id=110293
2072
2073         Reviewed by Gustavo Noronha Silva.
2074
2075         * Scripts/webkitdirs.pm:
2076         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
2077         WebKitFeatureOverrides.txt to better match the other filenames used in
2078         the new feature processing.
2079         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
2080         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
2081         and writes WebKitFeatures.txt and WebKitFeatures.h.
2082         * gtk/override-feature-defines: Removed.
2083
2084 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
2085
2086         [Qt] Remove obsolete DEPENDPATH assignment
2087
2088         Reviewed by Simon Hausmann
2089
2090         qmake now adds CONFIG+=depend_includepath by default, making manual
2091         DEPENDPATH setup unnecessary.
2092
2093         * qmake/mkspecs/features/default_post.prf:
2094
2095 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
2096
2097         Unreviewed. Changing primary email id.
2098
2099         * Scripts/webkitpy/common/config/committers.py:
2100
2101 2013-02-14  James Robinson  <jamesr@chromium.org>
2102
2103         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
2104         https://bugs.webkit.org/show_bug.cgi?id=109634
2105
2106         Reviewed by Adrienne Walker.
2107
2108         * DumpRenderTree/chromium/WebViewHost.cpp:
2109         (WebViewHost::createOutputSurface):
2110         (WebViewHost::initializeLayerTreeView):
2111
2112 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
2113
2114         [GTK] Re-enable 3D CSS transforms when using build-webkit
2115         https://bugs.webkit.org/show_bug.cgi?id=110402
2116
2117         Reviewed by Xan Lopez.
2118
2119         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
2120         when building WebKitGTK+.
2121
2122 2013-02-20  Roger Fong  <roger_fong@apple.com>
2123
2124         Get VS2010 Solution B&I ready.
2125         <rdar://problem/1322988>
2126
2127         Rubberstamped by Timothy Horton.        
2128         
2129         Add Production configurations.
2130         
2131         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2132         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2133         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
2134         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2135         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
2136         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2137         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2138         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2139         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
2140         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2141         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
2142         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2143         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2144         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
2145         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2146         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2147         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
2148         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2149         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2150         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2151         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
2152         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2153         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
2154         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2155         * win/record-memory/record-memory.vcxproj:
2156         * win/record-memory/record-memoryProduction.props: Added.
2157         * win/record-memory/record-memoryRelease.props:
2158
2159 2013-02-20  Dirk Schulze  <krit@webkit.org>
2160
2161         Enable CANVAS_PATH flag
2162         https://bugs.webkit.org/show_bug.cgi?id=108508
2163
2164         Reviewed by Simon Fraser.
2165
2166         Enable CANVAS_PATH flag on trunk.
2167
2168         * Scripts/webkitperl/FeatureList.pm:
2169
2170 2013-02-20  Tony Chang  <tony@chromium.org>
2171
2172         Parse author names with commas in ChangeLogs
2173         https://bugs.webkit.org/show_bug.cgi?id=110356
2174
2175         Reviewed by Dirk Pranke.
2176
2177         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
2178
2179         * Scripts/webkitpy/common/checkout/changelog.py:
2180         (ChangeLogEntry): Move name splitting regexp into a constant.
2181         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
2182         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
2183         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
2184         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
2185         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2186         (test_parse_authors): Test case with Paweł's name.
2187
2188 2013-02-15  Dirk Schulze  <krit@webkit.org>
2189
2190         [Chromium] Add runtime flag for CanvasPath
2191         https://bugs.webkit.org/show_bug.cgi?id=109997
2192
2193         Reviewed by Adam Barth.
2194
2195         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
2196         the constructor for Path on DOMWindow would never be activatable, since the script
2197         is running after creating the DOMWindow object.
2198
2199         * DumpRenderTree/chromium/TestShell.cpp:
2200         (TestShell::TestShell):
2201
2202 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2203
2204         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
2205         https://bugs.webkit.org/show_bug.cgi?id=110346
2206
2207         Reviewed by Adam Barth.
2208
2209         Using an index is very brittle, as the TestRunner API does not define
2210         any ordering of windows.
2211
2212         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
2213         trigger the capturing in the browser process before generating the
2214         text dump.
2215
2216         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2217         (WebTestRunner):
2218         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
2219         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2220         (WebTestRunner):
2221         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2222         (TestRunner):
2223         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2224         (WebTestRunner::WebTestProxyBase::captureTree):
2225         * DumpRenderTree/chromium/WebViewHost.cpp:
2226         (WebViewHost::captureHistoryForWindow):
2227         * DumpRenderTree/chromium/WebViewHost.h:
2228         (WebViewHost):
2229
2230 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
2231
2232         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
2233         https://bugs.webkit.org/show_bug.cgi?id=109220
2234
2235         Reviewed by Tony Chang.
2236
2237         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2238         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
2239         (WebTestRunner):
2240         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
2241         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
2242         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
2243         (MockSpellCheck):
2244         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
2245         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
2246
2247 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2248
2249         [Gtk] HTML5 Media controls require a design refresh
2250         https://bugs.webkit.org/show_bug.cgi?id=83869
2251
2252         Reviewed by Philippe Normand.
2253
2254         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2255         (initializeGtkFontSettings): Added gnome as default icon theme for
2256         the DRT.
2257         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2258         (WTR::initializeGtkSettings): Added gnome as default icon theme for
2259         the WTR.
2260         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
2261         dependency.
2262
2263 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2264
2265         [chromium] move most of the remaining mocks to TestRunner library
2266         https://bugs.webkit.org/show_bug.cgi?id=110217
2267
2268         Reviewed by Nico Weber.
2269
2270         While most of the functionality provided by these mocks is also
2271         available in the content module, there is no straight forward way to
2272         inject the mock results required for layout tests.
2273
2274         * DumpRenderTree/DumpRenderTree.gypi:
2275         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2276         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2277         (WebKit):
2278         (WebTestRunner):
2279         (WebTestRunner::WebTestProxy::geolocationClient):
2280         (WebTestRunner::WebTestProxy::speechInputController):
2281         (WebTestRunner::WebTestProxy::speechRecognizer):
2282         (WebTestRunner::WebTestProxy::deviceOrientationClient):
2283         (WebTestRunner::WebTestProxy::requestPointerLock):
2284         (WebTestRunner::WebTestProxy::requestPointerUnlock):
2285         (WebTestRunner::WebTestProxy::isPointerLocked):
2286         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
2287         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
2288         (WebTestRunner):
2289         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
2290         (WebTestRunner::MockWebSpeechInputController::setDelegate):
2291         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
2292         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
2293         (WebTestRunner::MockWebSpeechInputController::clearResults):
2294         (WebTestRunner::MockWebSpeechInputController::startRecognition):
2295         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
2296         (WebTestRunner::MockWebSpeechInputController::stopRecording):
2297         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
2298         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
2299         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
2300         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
2301         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
2302         (WebKit):
2303         (WebTestRunner):
2304         (MockWebSpeechInputController):
2305         (WebTestRunner::MockWebSpeechInputController::taskList):
2306         (SpeechTask):
2307         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
2308         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2309         (WebTestRunner):
2310         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
2311         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
2312         (WebTestRunner::MockWebSpeechRecognizer::start):
2313         (WebTestRunner::MockWebSpeechRecognizer::stop):
2314         (WebTestRunner::MockWebSpeechRecognizer::abort):
2315         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
2316         (WebTestRunner::MockWebSpeechRecognizer::setError):
2317         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
2318         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
2319         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
2320         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
2321         (WebKit):
2322         (WebTestRunner):
2323         (MockWebSpeechRecognizer):
2324         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
2325         (WebTestRunner::MockWebSpeechRecognizer::client):
2326         (WebTestRunner::MockWebSpeechRecognizer::handle):
2327         (WebTestRunner::MockWebSpeechRecognizer::taskList):
2328         (Task):
2329         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
2330         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
2331         (StepTask):
2332         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
2333         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2334         (WebTestRunner::TestInterfaces::TestInterfaces):
2335         (WebTestRunner::TestInterfaces::windowOpened):
2336         (WebTestRunner):
2337         (WebTestRunner::TestInterfaces::windowClosed):
2338         (WebTestRunner::TestInterfaces::windowList):
2339         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2340         (TestInterfaces):
2341         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2342         (WebTestRunner::TestRunner::TestRunner):
2343         (WebTestRunner::TestRunner::reset):
2344         (WebTestRunner::TestRunner::requestPointerLock):
2345         (WebTestRunner):
2346         (WebTestRunner::TestRunner::requestPointerUnlock):
2347         (WebTestRunner::TestRunner::isPointerLocked):
2348         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
2349         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
2350         (WebTestRunner::TestRunner::didLosePointerLockInternal):
2351         (WebTestRunner::TestRunner::windowCount):
2352         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2353         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
2354         (WebTestRunner::TestRunner::setGeolocationPermission):
2355         (WebTestRunner::TestRunner::setMockGeolocationPosition):
2356         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
2357         (WebTestRunner::TestRunner::addMockSpeechInputResult):
2358         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
2359         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
2360         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
2361         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
2362         (WebTestRunner::TestRunner::didAcquirePointerLock):
2363         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
2364         (WebTestRunner::TestRunner::didLosePointerLock):
2365         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
2366         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
2367         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2368         (WebTestRunner):
2369         (TestRunner):
2370         (HostMethodTask):
2371         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
2372         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
2373         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2374         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2375         (WebTestRunner::WebTestProxyBase::setInterfaces):
2376         (WebTestRunner::WebTestProxyBase::setDelegate):
2377         (WebTestRunner::WebTestProxyBase::reset):
2378         (WebTestRunner::WebTestProxyBase::captureTree):
2379         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
2380         (WebTestRunner):
2381         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
2382         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
2383         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
2384         (WebTestRunner::WebTestProxyBase::geolocationClient):
2385         (WebTestRunner::WebTestProxyBase::speechInputController):
2386         (WebTestRunner::WebTestProxyBase::speechRecognizer):
2387         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
2388         (WebTestRunner::WebTestProxyBase::requestPointerLock):
2389         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
2390         (WebTestRunner::WebTestProxyBase::isPointerLocked):
2391         * DumpRenderTree/chromium/WebViewHost.cpp:
2392         (WebViewHost::reset):
2393         * DumpRenderTree/chromium/WebViewHost.h:
2394         (WebKit):
2395         (WebViewHost):
2396
2397 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
2398
2399         [Qt] Make debug builds possible on 32bit Linux
2400         https://bugs.webkit.org/show_bug.cgi?id=110231
2401
2402         Reviewed by Tor Arne Vestbø.
2403
2404         Use the stabs format for debug builds to make the object files
2405         a bit smaller so that they can be linked on a 32bit system.
2406
2407         * qmake/mkspecs/features/unix/default_post.prf:
2408
2409 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
2410
2411         Unreviewed. Add myself to watch lists.
2412
2413         * Scripts/webkitpy/common/config/committers.py:
2414         * Scripts/webkitpy/common/config/watchlist:
2415
2416 2013-02-19  Joshua Bell  <jsbell@chromium.org>
2417
2418         Remove warning from run-bindings-tests
2419         https://bugs.webkit.org/show_bug.cgi?id=110285
2420
2421         Reviewed by Kentaro Hara.
2422
2423         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
2424         "Unknown option: idlattributesfile". That option was removed from
2425         bindings/scripts/preprocess-idls.pl but was still being passed by
2426         the test script. Remove it.
2427
2428         * Scripts/webkitpy/bindings/main.py:
2429         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
2430
2431 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
2432
2433         Unreviewed. Add myself to watch lists.
2434
2435         * Scripts/webkitpy/common/config/committers.py:
2436         * Scripts/webkitpy/common/config/watchlist:
2437
2438 2013-02-19  Hans Muller  <hmuller@adobe.com>
2439
2440         Unreviewed, corrected primary email.
2441
2442         * Scripts/webkitpy/common/config/committers.py:
2443
2444 2013-02-19  Hans Muller  <hmuller@adobe.com>
2445
2446         Unreviewed. Adding myself as a committer.
2447
2448         * Scripts/webkitpy/common/config/committers.py:
2449
2450 2013-02-19  Pravin D  <pravind@webkit.org>
2451
2452         Unreviewed, changing primary email.
2453
2454         * Scripts/webkitpy/common/config/committers.py:
2455
2456 2013-02-19  Alan Cutter  <alancutter@chromium.org>
2457
2458         REGRESSION: Sheriffbot is failing to process rollout requests
2459         https://bugs.webkit.org/show_bug.cgi?id=106945
2460
2461         Reviewed by Adam Barth.
2462
2463         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
2464         This resolves problems when Sheriffbot attempts to perform a rollout request.
2465
2466         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2467         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
2468         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
2469
2470 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
2471
2472         Unreviewed build fix.
2473
2474         * efl/jhbuild.modules:
2475         * gtk/jhbuild.modules:
2476
2477         Bump harfbuzz module to 0.9.7. See related bug 110145.
2478
2479 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
2480
2481         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
2482         https://bugs.webkit.org/show_bug.cgi?id=110215
2483
2484         Reviewed by Tor Arne Vestbø.
2485
2486         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
2487         continuing the build. Otherwise skip with an error message explaining which
2488         programs are missing from the build.
2489
2490         * qmake/mkspecs/features/configure.prf:
2491         * qmake/mkspecs/features/functions.prf:
2492
2493 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2494
2495         Unreviewed, rolling out r143319.
2496         http://trac.webkit.org/changeset/143319
2497         https://bugs.webkit.org/show_bug.cgi?id=110214
2498
2499         Causes build issues on win32 (Requested by carewolf on
2500         #webkit).
2501
2502         * qmake/mkspecs/features/features.pri:
2503
2504 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2505
2506         [Qt] Enable MathML
2507         https://bugs.webkit.org/show_bug.cgi?id=110205
2508
2509         Reviewed by Simon Hausmann.
2510
2511         * qmake/mkspecs/features/features.pri:
2512
2513 2013-02-17  Andrei Bucur  <abucur@adobe.com>
2514
2515         Unreviewed. Adding myself as a committer.
2516
2517         * Scripts/webkitpy/common/config/committers.py:
2518
2519 2013-02-19  Hajime Morrita  <morrita@google.com>
2520
2521         Unreviewed, updated spelling of my name.
2522
2523         * Scripts/webkitpy/common/config/committers.py:
2524
2525 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
2526
2527         Unreviewed. Adjust expectations.
2528
2529         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2530         (TestWebKitAPI::TEST):
2531
2532 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
2533
2534         Unreviewed GTK gardening.
2535
2536         * Scripts/run-gtk-tests:
2537         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
2538
2539 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2540
2541         [Qt][WK2] Remove duped test name and append new test in project file
2542         https://bugs.webkit.org/show_bug.cgi?id=110117
2543
2544         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
2545         add this test into the runnable test suite and remove a duped test in project file.
2546
2547         Reviewed by Jocelyn Turcotte.
2548
2549         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2550
2551 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
2552
2553         [chromium] remove log spew from dumpAllBackForwardLists
2554         https://bugs.webkit.org/show_bug.cgi?id=110108
2555
2556         Reviewed by Nico Weber.
2557
2558         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2559
2560 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2561
2562         [EFL][WK2] Disable failing API tests
2563         https://bugs.webkit.org/show_bug.cgi?id=110081
2564
2565         Reviewed by Kenneth Rohde Christiansen.
2566
2567         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
2568
2569         * TestWebKitAPI/PlatformEfl.cmake:
2570
2571 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
2572
2573         [Qt] Disable the build if certain configure checks fail
2574         https://bugs.webkit.org/show_bug.cgi?id=110094
2575
2576         Reviewed by Tor Arne Vestbø.
2577
2578         Allow for the build to be skipped (clear out SUBDIRS) if certain
2579         configure conditions aren't met.
2580
2581         * qmake/mkspecs/features/configure.prf:
2582
2583 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2584
2585         [Qt][WK2] Support WK2 API tests
2586         https://bugs.webkit.org/show_bug.cgi?id=109843
2587
2588         Reviewed by Jocelyn Turcotte.
2589
2590         * TestWebKitAPI/DerivedSources.pri: Added.
2591         * TestWebKitAPI/InjectedBundle.pri: Added.
2592         * TestWebKitAPI/PlatformWebView.h:
2593         * TestWebKitAPI/TestWebKitAPI.pri:
2594         * TestWebKitAPI/TestWebKitAPI.pro:
2595         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
2596         * TestWebKitAPI/Tests/WTF/WTF.pro:
2597         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
2598         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
2599         (TestWebKitAPI::Util::sleep):
2600         (TestWebKitAPI::Util::createInjectedBundlePath):
2601         (TestWebKitAPI::Util::createURLForResource):
2602         (TestWebKitAPI::Util::isKeyDown):
2603         (Util):
2604         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
2605         (TestWebKitAPI):
2606         (WrapperWindow):
2607         (TestWebKitAPI::WrapperWindow::WrapperWindow):
2608         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
2609         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2610         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2611         (TestWebKitAPI::PlatformWebView::resizeTo):
2612         (TestWebKitAPI::PlatformWebView::page):
2613         (TestWebKitAPI::PlatformWebView::focus):
2614         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2615         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2616         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2617         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2618         * TestWebKitAPI/qt/main.cpp:
2619         (addQtWebProcessToPath):
2620         (main):
2621
2622 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2623
2624         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
2625         https://bugs.webkit.org/show_bug.cgi?id=108598
2626
2627         Reviewed by Kenneth Rohde Christiansen.
2628
2629         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
2630
2631         * MiniBrowser/efl/main.c:
2632         (update_view_favicon):
2633         (on_view_favicon_changed):
2634         (window_create):
2635
2636 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2637
2638         Unreviewed. Add myself as a committer.
2639
2640         * Scripts/webkitpy/common/config/committers.py:
2641
2642 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
2643
2644         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
2645         https://bugs.webkit.org/show_bug.cgi?id=109554
2646
2647         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
2648         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
2649
2650         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
2651         It helps me to do the tests for the serializer.
2652
2653         Reviewed by Yury Semikhatsky.
2654
2655         It is covered by newly added tests in TestWebKitAPI.
2656
2657         * TestWebKitAPI/TestWebKitAPI.gypi:
2658         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
2659         (TestWebKitAPI):
2660         (HeapGraphReceiver):
2661         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
2662         (TestWebKitAPI::HeapGraphReceiver::printGraph):
2663         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
2664         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
2665         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
2666         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
2667         (TestWebKitAPI::HeapGraphReceiver::serializer):
2668         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
2669         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
2670         (TestWebKitAPI::HeapGraphReceiver::stringValue):
2671         (TestWebKitAPI::HeapGraphReceiver::intValue):
2672         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
2673         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
2674         (TestWebKitAPI::HeapGraphReceiver::printNode):
2675         (Helper):
2676         (TestWebKitAPI::Helper::Helper):
2677         (TestWebKitAPI::Helper::addNode):
2678         (TestWebKitAPI::Helper::addEdge):
2679         (TestWebKitAPI::Helper::done):
2680         (Object):
2681         (TestWebKitAPI::Helper::Object::Object):
2682         (TestWebKitAPI::TEST):
2683         (Owner):
2684         (TestWebKitAPI::Owner::Owner):
2685         (TestWebKitAPI::Owner::reportMemoryUsage):
2686
2687 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
2688
2689         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
2690
2691         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2692         (NewCommitBot.next_work_item):
2693
2694 2013-02-17  Kangil Han  <kangil.han@samsung.com>
2695
2696         Unreviewed. Add myself as a committer.
2697
2698         * Scripts/webkitpy/common/config/committers.py:
2699
2700 2013-02-17  Alan Cutter  <alancutter@chromium.org>
2701
2702         GCE EWS bots are all offline
2703         https://bugs.webkit.org/show_bug.cgi?id=110069
2704
2705         Reviewed by Eric Seidel.
2706
2707         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
2708         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
2709
2710         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2711         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2712         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
2713         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2714         * EWSTools/build-vm.sh:
2715         * EWSTools/start-queue.sh:
2716
2717 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
2718
2719         Unreviewed, add myself to commiters.py.
2720
2721         * Scripts/webkitpy/common/config/committers.py:
2722
2723 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
2724
2725         Unreviewed. Add myself as a committer.
2726
2727         * Scripts/webkitpy/common/config/committers.py:
2728
2729 2013-02-17  Roger Fong  <roger_fong@apple.com>
2730
2731         Unreviewed. Fix typo in script.
2732
2733         * EWSTools/start-queue-win.sh:
2734
2735 2013-02-15  Roger Fong  <roger_fong@apple.com>
2736
2737         Pass in bot name as parameter to start-queue-win script.
2738         https://bugs.webkit.org/show_bug.cgi?id=109998.
2739
2740         Reviewed by Darin Adler.
2741
2742         * EWSTools/start-queue-win.sh:
2743
2744 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
2745
2746         Unreviewed. Add myself as a committer.
2747
2748         * Scripts/webkitpy/common/config/committers.py:
2749
2750 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2751
2752         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
2753
2754         Rubber-stamped by Andreas Kling.
2755
2756         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2757         (NewCommitBot.begin_work_queue):
2758
2759 2013-02-16  Glenn Adams  <glenn@skynav.com>
2760
2761         Unreviewed. Add myself as a committer.
2762
2763         * Scripts/webkitpy/common/config/committers.py:
2764
2765 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
2766
2767         new-commit-bot should report the full name of committer and reviewer instead of just nicks
2768         https://bugs.webkit.org/show_bug.cgi?id=110040
2769
2770         Reviewed by Darin Adler.
2771
2772         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
2773
2774         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2775         (NewCommitBot):
2776         (NewCommitBot._summarize_commit_log):
2777         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2778
2779 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
2780
2781         We need a CIA replacement
2782         https://bugs.webkit.org/show_bug.cgi?id=110008
2783
2784         Reviewed by Andreas Kling.
2785
2786         Added new-commit-bot.
2787
2788         * Scripts/webkitpy/tool/bot/queueengine.py:
2789         (QueueEngine.__init__):
2790         (QueueEngine): Made the sleep tiem configurable.
2791         (QueueEngine._sleep_message):
2792         (QueueEngine._sleep):
2793         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2794         (QueueEngineTest.test_sleep_message):
2795         * Scripts/webkitpy/tool/commands/__init__.py:
2796         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
2797         (PingPong): Added. Implements the ping pong protocol.
2798         (NewCommitBot):
2799         (NewCommitBot.begin_work_queue):
2800         (NewCommitBot.work_item_log_path):
2801         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
2802         the last time we checked the head SVN revision.
2803         (NewCommitBot.process_work_item):
2804         (NewCommitBot._update_checkout): svn up.
2805         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
2806         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
2807         (NewCommitBot.handle_unexpected_error):
2808         (NewCommitBot.handle_script_error):
2809         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
2810         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
2811         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
2812         * Scripts/webkitpy/tool/commands/queues.py:
2813         (AbstractQueue.execute):
2814         * Scripts/webkitpy/tool/commands/queuestest.py:
2815         (MockQueueEngine.__init__):
2816         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2817         (SheriffBotTest.test_command_aliases):
2818         * Scripts/webkitpy/tool/main.py:
2819         (WebKitPatch):
2820
2821 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
2822
2823         [chromium] initialize all variables of TestRunner classes
2824         https://bugs.webkit.org/show_bug.cgi?id=110013
2825
2826         Reviewed by Adam Barth.
2827
2828         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2829         (WebTestRunner::TestInterfaces::TestInterfaces):
2830         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2831         (WebTestRunner::TestRunner::TestRunner):
2832
2833 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
2834
2835         [chromium] destroy the TestPlugin when the destroy() method is invoked.
2836         https://bugs.webkit.org/show_bug.cgi?id=110012
2837
2838         Reviewed by Adam Barth.
2839
2840         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
2841         (WebTestRunner::TestPlugin::destroy):
2842
2843 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2844
2845         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
2846         https://bugs.webkit.org/show_bug.cgi?id=109842
2847
2848         Reviewed by Benjamin Poulain.
2849
2850         This new test will kill WebProcess, followed by next resizing the Window. It helps to
2851         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
2852         before making calls into them.
2853
2854         * TestWebKitAPI/GNUmakefile.am:
2855         * TestWebKitAPI/PlatformEfl.cmake:
2856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2857         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
2858         (TestWebKitAPI):
2859         (TestWebKitAPI::didFinishLoad):
2860         (TestWebKitAPI::didCrash):
2861         (TestWebKitAPI::TEST):
2862
2863 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2864
2865         Add CString operators for comparison with const char*
2866         https://bugs.webkit.org/show_bug.cgi?id=109947
2867
2868         Reviewed by Darin Adler.
2869
2870         Add tests for WTF::CString's comparison operators.
2871
2872         * TestWebKitAPI/Tests/WTF/CString.cpp:
2873         (TEST):
2874
2875 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
2876
2877         webkit-patch suggest-reviewers should limit itself to 5 reviewers
2878         https://bugs.webkit.org/show_bug.cgi?id=107528
2879
2880         Reviewed by Eric Seidel.
2881
2882         * Scripts/webkitpy/common/checkout/checkout.py:
2883         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
2884         scraping reviewers from the commit information and in the end producing a list
2885         of reviewers that's sorted from the most to least recent activity of any reviewer
2886         that has reviewed or authored patches for the changed files.
2887         * Scripts/webkitpy/tool/commands/queries.py:
2888         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
2889         the same logic.
2890         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
2891         defaults to False.
2892         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
2893         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
2894         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
2895         bug ID is located in the command's state.
2896
2897 2013-02-15  Pablo Flouret  <pablof@motorola.com>
2898
2899         Unreviewed. Add myself as a committer.
2900
2901         * Scripts/webkitpy/common/config/committers.py:
2902
2903 2013-02-15  Roger Fong  <roger_fong@apple.com>
2904
2905         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
2906
2907         * EWSTools/start-queue-win.sh: Added.
2908
2909 2013-02-15  Andreas Kling  <akling@apple.com>
2910
2911         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
2912
2913         * Scripts/webkitpy/common/config/committers.py:
2914
2915 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>
2916
2917         Unreviewed. Add myself as a committer.
2918
2919         * Scripts/webkitpy/common/config/committers.py:
2920
2921 2013-02-15  Ryosuke Niwa  <rniwa@webkit.org>
2922
2923         NRWT: ML Debug Test bot is timing out after cleaning up ports
2924         https://bugs.webkit.org/show_bug.cgi?id=109912
2925
2926         Reviewed by Simon Fraser.
2927
2928         Added more debug messgaes to diagnose the issue.
2929
2930         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2931         (Manager.run):
2932
2933 2013-02-15  Claudio Saavedra  <csaavedra@igalia.com>
2934
2935         Unreviewed. Add myself as a committer.
2936
2937         * Scripts/webkitpy/common/config/committers.py:
2938
2939 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2940
2941         Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
2942         emails on their behalf.
2943
2944         * Scripts/webkitpy/common/config/committers.py:
2945
2946 2013-02-15  Andrey Lushnikov  <lushnikov@chromium.org>
2947
2948         Web Inspector: implement smart braces functionality
2949         https://bugs.webkit.org/show_bug.cgi?id=109200
2950
2951         Reviewed by Pavel Feldman.
2952
2953         Fix eventSender.keyDown implementation to correctly process opening
2954         round brace symbol.
2955
2956         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2957         (WebTestRunner):
2958         (WebTestRunner::EventSender::keyDown):
2959
2960 2013-02-15  Jochen Eisinger  <jochen@chromium.org>
2961
2962         Speculative build fix for chromium-win.
2963
2964         Unreviewed build fix.
2965
2966         Add declarations of the copy constructor and assignment operator to
2967         WebTestProxyBase, so VS doesn't try to generate them.
2968
2969         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2970
2971 2013-02-15  Simon Hausmann  <simon.hausmann@digia.com>
2972
2973         [Qt] Port GCController to JSC C API
2974         https://bugs.webkit.org/show_bug.cgi?id=109690
2975
2976         Reviewed by Benjamin Poulain.
2977
2978         Rename TestRunner to TestRunnerQt to avoid conflict when
2979         including TestRunner.h in the future.
2980
2981         Replaced QObject based GCController implementation with JSC C API
2982         based one.
2983
2984         * DumpRenderTree/qt/DumpRenderTree.pro:
2985         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2986         (WebCore::DumpRenderTree::DumpRenderTree):
2987         (WebCore::DumpRenderTree::open):
2988         (WebCore::DumpRenderTree::initJSObjects):
2989         (WebCore::methodNameStringForFailedTest):
2990         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2991         (WebCore::DumpRenderTree::testRunner):
2992         (DumpRenderTree):
2993         * DumpRenderTree/qt/GCControllerQt.cpp:
2994         (GCController::getJSObjectCount):
2995         * DumpRenderTree/qt/GCControllerQt.h: Removed.
2996         * DumpRenderTree/qt/TestRunnerQt.cpp:
2997         (TestRunnerQt::TestRunnerQt):
2998         (TestRunnerQt::reset):
2999         (TestRunnerQt::dumpNotifications):
3000         (TestRunnerQt::processWork):
3001         (TestRunnerQt::maybeDump):
3002         (TestRunnerQt::dumpAsText):
3003         (TestRunnerQt::waitUntilDone):
3004         (TestRunnerQt::setViewModeMediaFeature):
3005         (TestRunnerQt::webHistoryItemCount):
3006         (TestRunnerQt::keepWebHistory):
3007         (TestRunnerQt::notifyDone):
3008         (TestRunnerQt::windowCount):
3009         (TestRunnerQt::grantWebNotificationPermission):
3010         (TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
3011         (TestRunnerQt::denyWebNotificationPermission):
3012         (TestRunnerQt::removeAllWebNotificationPermissions):
3013         (TestRunnerQt::simulateWebNotificationClick):
3014         (TestRunnerQt::simulateLegacyWebNotificationClick):
3015         (TestRunnerQt::display):
3016         (TestRunnerQt::displayInvalidatedRegion):
3017         (TestRunnerQt::clearBackForwardList):
3018         (TestRunnerQt::pathToLocalResource):
3019         (TestRunnerQt::dumpEditingCallbacks):
3020         (TestRunnerQt::dumpFrameLoadCallbacks):
3021         (TestRunnerQt::dumpProgressFinishedCallback):
3022         (TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
3023         (TestRunnerQt::dumpResourceLoadCallbacks):
3024         (TestRunnerQt::dumpResourceResponseMIMETypes):
3025         (TestRunnerQt::dumpWillCacheResponse):
3026         (TestRunnerQt::dumpHistoryCallbacks):
3027         (TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
3028         (TestRunnerQt::setWillSendRequestReturnsNull):
3029         (TestRunnerQt::setWillSendRequestClearHeader):
3030         (TestRunnerQt::setDeferMainResourceDataLoad):
3031         (TestRunnerQt::queueBackNavigation):
3032         (TestRunnerQt::queueForwardNavigation):
3033         (TestRunnerQt::queueLoad):
3034         (TestRunnerQt::queueLoadHTMLString):
3035         (TestRunnerQt::queueReload):
3036         (TestRunnerQt::queueLoadingScript):
3037         (TestRunnerQt::queueNonLoadingScript):
3038         (TestRunnerQt::provisionalLoad):
3039         (TestRunnerQt::timerEvent):
3040         (TestRunnerQt::encodeHostName):
3041         (TestRunnerQt::decodeHostName):
3042         (TestRunnerQt::closeWebInspector):
3043         (TestRunnerQt::setDeveloperExtrasEnabled):
3044         (TestRunnerQt::setAsynchronousSpellCheckingEnabled):
3045         (TestRunnerQt::showWebInspector):
3046         (TestRunnerQt::evaluateInWebInspector):
3047         (TestRunnerQt::goBack):
3048         (TestRunnerQt::setDefersLoading):
3049         (TestRunnerQt::setAllowUniversalAccessFromFileURLs):
3050         (TestRunnerQt::setAllowFileAccessFromFileURLs):
3051         (TestRunnerQt::setAppCacheMaximumSize):
3052         (TestRunnerQt::setAutofilled):
3053         (TestRunnerQt::setValueForUser):
3054         (TestRunnerQt::setFixedContentsSize):
3055         (TestRunnerQt::setPrivateBrowsingEnabled):
3056         (TestRunnerQt::setSpatialNavigationEnabled):
3057         (TestRunnerQt::setPopupBlockingEnabled):
3058         (TestRunnerQt::setPluginsEnabled):
3059         (TestRunnerQt::setPOSIXLocale):
3060         (TestRunnerQt::setWindowIsKey):
3061         (TestRunnerQt::setMainFrameIsFirstResponder):
3062         (TestRunnerQt::setJavaScriptCanAccessClipboard):
3063         (TestRunnerQt::setXSSAuditorEnabled):
3064         (TestRunnerQt::dispatchPendingLoadRequests):
3065         (TestRunnerQt::clearAllApplicationCaches):
3066         (TestRunnerQt::clearApplicationCacheForOrigin):
3067         (TestRunnerQt::localStorageDiskUsageForOrigin):
3068         (TestRunnerQt::setApplicationCacheOriginQuota):
3069         (TestRunnerQt::applicationCacheDiskUsageForOrigin):
3070         (TestRunnerQt::originsWithApplicationCache):
3071         (TestRunnerQt::setCacheModel):
3072         (TestRunnerQt::setDatabaseQuota):
3073         (TestRunnerQt::clearAllDatabases):
3074         (TestRunnerQt::addOriginAccessWhitelistEntry):
3075         (TestRunnerQt::removeOriginAccessWhitelistEntry):
3076         (TestRunnerQt::setCustomPolicyDelegate):
3077         (TestRunnerQt::waitForPolicyDelegate):
3078         (TestRunnerQt::overridePreference):
3079         (TestRunnerQt::setUserStyleSheetLocation):
3080         (TestRunnerQt::setCaretBrowsingEnabled):
3081         (TestRunnerQt::setAuthorAndUserStylesEnabled):
3082         (TestRunnerQt::setUserStyleSheetEnabled):
3083         (TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
3084         (TestRunnerQt::callShouldCloseOnWebView):
3085         (TestRunnerQt::setScrollbarPolicy):
3086         (TestRunnerQt::setSmartInsertDeleteEnabled):
3087         (TestRunnerQt::setSelectTrailingWhitespaceEnabled):
3088         (TestRunnerQt::execCommand):
3089         (TestRunnerQt::isCommandEnabled):
3090         (TestRunnerQt::findString):
3091         (TestRunnerQt::markerTextForListItem):
3092         (TestRunnerQt::computedStyleIncludingVisitedInfo):
3093         (TestRunnerQt::elementDoesAutoCompleteForElementWithId):
3094         (TestRunnerQt::authenticateSession):
3095         (TestRunnerQt::setIconDatabaseEnabled):
3096         (TestRunnerQt::setMockDeviceOrientation):
3097         (TestRunnerQt::setGeolocationPermission):
3098         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3099         (TestRunnerQt::setGeolocationPermissionCommon):
3100         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3101         (TestRunnerQt::setMockGeolocationPosition):
3102         (TestRunnerQt::addMockSpeechInputResult):
3103         (TestRunnerQt::setMockSpeechInputDumpRect):
3104         (TestRunnerQt::startSpeechInput):
3105         (TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
3106         (TestRunnerQt::evaluateScriptInIsolatedWorld):
3107         (TestRunnerQt::addUserStyleSheet):
3108         (TestRunnerQt::removeAllVisitedLinks):
3109         (TestRunnerQt::addURLToRedirect):
3110         (TestRunnerQt::originsWithLocalStorage):
3111         (TestRunnerQt::deleteAllLocalStorage):
3112         (TestRunnerQt::deleteLocalStorageForOrigin):
3113         (TestRunnerQt::observeStorageTrackerNotifications):
3114         (TestRunnerQt::syncLocalStorage):
3115         (TestRunnerQt::resetPageVisibility):
3116         (TestRunnerQt::setPageVisibility):
3117         (TestRunnerQt::setAutomaticLinkDetectionEnabled):
3118         (TestRunnerQt::setTextDirection):
3119         (TestRunnerQt::setAlwaysAcceptCookies):
3120         (TestRunnerQt::setAlwaysBlockCookies):
3121         (TestRunnerQt::setAudioData):
3122         * DumpRenderTree/qt/TestRunnerQt.h:
3123         (TestRunnerQt):
3124
3125 2013-02-14  Karen Grunberg  <kareng@chromium.org>
3126
3127         adding myself as a committer
3128
3129         * Scripts/webkitpy/common/config/committers.py:
3130
3131 2013-02-14  Glenn Adams  <glenn@skynav.com>
3132
3133         new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
3134         https://bugs.webkit.org/show_bug.cgi?id=37565
3135
3136         Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
3137         is LayoutTests/TestExpectations.
3138
3139         Reviewed by Dirk Pranke.
3140
3141         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3142         (FakePort.path_to_generic_test_expectations_file):
3143         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3144         (TestExpectations.__init__):
3145         * Scripts/webkitpy/layout_tests/port/base.py:
3146         (Port.path_to_generic_test_expectations_file):
3147         (Port):
3148         (Port._port_specific_expectations_files):
3149         (Port.expectations_files):
3150         * Scripts/webkitpy/layout_tests/port/chromium.py:
3151         (ChromiumPort._port_specific_expectations_files):
3152         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3153         (ChromiumAndroidPort._port_specific_expectations_files):
3154         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3155         (ChromiumPortTestCase.test_expectations_files):
3156         * Scripts/webkitpy/layout_tests/port/efl.py:
3157         (EflPort._port_specific_expectations_files):
3158         * Scripts/webkitpy/layout_tests/port/gtk.py:
3159         (GtkPort._port_specific_expectations_files):
3160         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3161         (GtkPortTest.test_expectations_files):
3162         * Scripts/webkitpy/layout_tests/port/mac.py:
3163         (MacPort._port_specific_expectations_files):
3164         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3165         (PortTestCase.test_expectations_ordering):
3166         (test_expectations_files):
3167         * Scripts/webkitpy/layout_tests/port/qt.py:
3168         (QtPort._port_specific_expectations_files):
3169         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3170         (QtPortTest.test_expectations_files):
3171         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3172         (WinPortTest.test_expectations_files):
3173         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3174         (PrintExpectationsTest.test_paths):
3175         * Scripts/webkitpy/tool/commands/rebaseline.py:
3176         (RebaselineTest._update_expectations_file):
3177
3178 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3179
3180         [chromium] move pixel generation logic to TestRunner library
3181         https://bugs.webkit.org/show_bug.cgi?id=109686
3182
3183         Reviewed by Stephen White.
3184
3185         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3186         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3187         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3188         (WebTestRunner):
3189         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3190         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3191         (WebTestRunner):
3192         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3193         (WebTestRunner::TestInterfaces::~TestInterfaces):
3194         (WebTestRunner::TestInterfaces::setWebView):
3195         (WebTestRunner::TestInterfaces::proxy):
3196         (WebTestRunner):
3197         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3198         (WebTestRunner):
3199         (TestInterfaces):
3200         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3201         (WebTestRunner::TestRunner::setWebView):
3202         (WebTestRunner):
3203         (WebTestRunner::TestRunner::setBackingScaleFactor):
3204         (WebTestRunner::TestRunner::display):
3205         (WebTestRunner::TestRunner::displayInvalidatedRegion):
3206         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3207         (WebTestRunner):
3208         (TestRunner):
3209         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3210         (WebTestRunner::WebTestInterfaces::setWebView):
3211         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3212         (WebTestRunner::WebTestProxyBase::reset):
3213         (WebTestRunner::WebTestProxyBase::capturePixels):
3214         (WebTestRunner):
3215         (WebTestRunner::WebTestProxyBase::paintRect):
3216         (WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
3217         (WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
3218         (WebTestRunner::WebTestProxyBase::canvas):
3219         (WebTestRunner::WebTestProxyBase::displayRepaintMask):
3220         (WebTestRunner::WebTestProxyBase::display):
3221         (WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
3222         (WebTestRunner::WebTestProxyBase::discardBackingStore):
3223         (WebTestRunner::WebTestProxyBase::setWindowRect):
3224         (WebTestRunner::WebTestProxyBase::userMediaClient):
3225         * DumpRenderTree/chromium/TestShell.cpp:
3226         (TestShell::createMainWindow):
3227         (TestShell::~TestShell):
3228         (TestShell::showDevTools):
3229         (TestShell::closeDevTools):
3230         (TestShell::dump):
3231         * DumpRenderTree/chromium/WebViewHost.cpp:
3232         (WebViewHost::setWindowRect):
3233         (WebViewHost::setDeviceScaleFactor):
3234         (WebViewHost::reset):
3235         * DumpRenderTree/chromium/WebViewHost.h:
3236         (WebViewHost):
3237
3238 2013-02-14  Tony Chang  <tony@chromium.org>
3239
3240         Unreviewed, set svn:eol-style native for .sln, .vcproj, and .vsprops files.
3241         https://bugs.webkit.org/show_bug.cgi?id=96934
3242
3243         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3244         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3245         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added property svn:eol-style.
3246         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added property svn:eol-style.
3247         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added property svn:eol-style.
3248         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3249         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added property svn:eol-style.
3250         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added property svn:eol-style.
3251         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3252         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added property svn:eol-style.
3253         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added property svn:eol-style.
3254         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added property svn:eol-style.
3255         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3256         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added property svn:eol-style.
3257         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added property svn:eol-style.
3258         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3259         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added property svn:eol-style.
3260         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3261         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added property svn:eol-style.
3262         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added property svn:eol-style.
3263         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added property svn:eol-style.
3264         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3265         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added property svn:eol-style.
3266         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added property svn:eol-style.
3267         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3268         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added property svn:eol-style.
3269         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added property svn:eol-style.
3270         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added property svn:eol-style.
3271         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added property svn:eol-style.
3272         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added property svn:eol-style.
3273         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added property svn:eol-style.
3274         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3275         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added property svn:eol-style.
3276         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3277         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added property svn:eol-style.
3278         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added property svn:eol-style.
3279         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added property svn:eol-style.
3280         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3281         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added property svn:eol-style.
3282         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added property svn:eol-style.
3283         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3284         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added property svn:eol-style.
3285         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added property svn:eol-style.
3286         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added property svn:eol-style.
3287         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3288         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added property svn:eol-style.
3289         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added property svn:eol-style.
3290         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3291
3292 2013-02-14  Tony Chang  <tony@chromium.org>
3293
3294         Unreviewed, set svn:eol-style CRLF for .sln files.
3295
3296         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3297         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3298         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3299         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3300
3301 2013-02-14  Zan Dobersek  <zdobersek@igalia.com>
3302
3303         [GTK] Errors when building WebKit2 with Clang
3304         https://bugs.webkit.org/show_bug.cgi?id=109603
3305
3306         Reviewed by Alexey Proskuryakov.
3307
3308         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3309         (WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
3310         type when constructing the GtkAllocation.
3311
3312         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3313         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3314         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3315         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3316
3317 2013-02-14  Roger Fong  <roger_fong@apple.com>
3318
3319         Add eol-style=native to solution files. Add a new solution file.
3320
3321         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
3322         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
3323         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
3324
3325 2013-02-14  Mario Sanchez Prada  <mario.prada@samsung.com>
3326
3327         [GTK] Missing call to g_object_ref while retrieving accessible table cells
3328         https://bugs.webkit.org/show_bug.cgi?id=106903
3329
3330         Reviewed by Martin Robinson.
3331
3332         Both DRT and WKTR need to call g_object_unref() now that an extra
3333         reference is added in the implementation of atk_table_ref_at().
3334
3335         * DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
3336         (AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
3337         before returning the new instance of AccessibilityUIElement.
3338         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3339         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
3340
3341 2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3342
3343         Unreviewed, rolling out r142841.
3344         http://trac.webkit.org/changeset/142841
3345         https://bugs.webkit.org/show_bug.cgi?id=109791
3346
3347         Caused webkit_unit_tests to crash on chromium bots. (Requested
3348         by atwilson_ on #webkit).
3349
3350         * DumpRenderTree/chromium/WebViewHost.cpp:
3351         (WebViewHost::createOutputSurface):
3352         (WebViewHost::initializeLayerTreeView):
3353
3354 2013-02-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3355
3356         [EFL][jhbuild] Silence GSettings-related warning.
3357         https://bugs.webkit.org/show_bug.cgi?id=109749
3358
3359         Reviewed by Martin Robinson.
3360
3361         Apply the same change done to the GTK+ port in r109127; this
3362         silences the warnings printed by glib about the memory GSettings
3363         backend being used.
3364
3365         Not only does this make the bots (as well as manual runs of, say,
3366         WebKitTestRunner) much more silent, but it also removes an stderr
3367         line (which run-perf-tests considers as a failure).
3368
3369         * Scripts/webkitpy/layout_tests/port/efl.py:
3370         (EflPort.setup_environ_for_server): Explicitly set the
3371         GSETTINGS_BACKEND environment variable to "memory".
3372
3373 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3374
3375         [chromium] move mock notification presenter to TestRunner library
3376         https://bugs.webkit.org/show_bug.cgi?id=109706
3377
3378         Reviewed by Adam Barth.
3379
3380         * DumpRenderTree/DumpRenderTree.gypi:
3381         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3382         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3383         (WebKit):
3384         (WebTestRunner::WebTestProxy::notificationPresenter):
3385         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.cpp.
3386         (WebTestRunner::NotificationPresenter::NotificationPresenter):
3387         (WebTestRunner):
3388         (WebTestRunner::NotificationPresenter::~NotificationPresenter):
3389         (WebTestRunner::NotificationPresenter::grantPermission):
3390         (WebTestRunner::NotificationPresenter::simulateClick):
3391         (WebTestRunner::NotificationPresenter::show):
3392         (WebTestRunner::NotificationPresenter::cancel):
3393         (WebTestRunner::NotificationPresenter::objectDestroyed):
3394         (WebTestRunner::NotificationPresenter::checkPermission):
3395         (WebTestRunner::NotificationPresenter::requestPermission):
3396         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.h.
3397         (WebTestRunner):
3398         (NotificationPresenter):
3399         (WebTestRunner::NotificationPresenter::setDelegate):
3400         (WebTestRunner::NotificationPresenter::reset):
3401         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3402         (WebTestRunner::TestRunner::TestRunner):
3403         (WebTestRunner::TestRunner::setDelegate):
3404         (WebTestRunner::TestRunner::reset):
3405         (WebTestRunner::TestRunner::notificationPresenter):
3406         (WebTestRunner):
3407         (WebTestRunner::TestRunner::grantWebNotificationPermission):
3408         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
3409         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3410         (WebKit):
3411         (WebTestRunner):
3412         (TestRunner):
3413         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3414         (WebTestRunner::WebTestProxyBase::notificationPresenter):
3415         (WebTestRunner):
3416         * DumpRenderTree/chromium/TestShell.cpp:
3417         (TestShell::initialize):
3418         (TestShell::resetTestController):
3419         * DumpRenderTree/chromium/TestShell.h:
3420         (WebKit):
3421         (TestShell):
3422         * DumpRenderTree/chromium/WebViewHost.cpp:
3423         * DumpRenderTree/chromium/WebViewHost.h:
3424
3425 2013-02-13  Roger Fong  <roger_fong@apple.com>
3426
3427         Unreviewed. Add separate DumpRenderTree VS2010 solution file.
3428
3429         * DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
3430         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
3431
3432 2013-02-12  James Robinson  <jamesr@chromium.org>
3433
3434         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3435         https://bugs.webkit.org/show_bug.cgi?id=109634
3436
3437         Reviewed by Adrienne Walker.
3438
3439         * DumpRenderTree/chromium/WebViewHost.cpp:
3440         (WebViewHost::createOutputSurface):
3441         (WebViewHost::initializeLayerTreeView):
3442
3443 2013-02-13  David Farler  <dfarler@apple.com>
3444
3445         TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
3446         https://bugs.webkit.org/show_bug.cgi?id=109766
3447
3448         Reviewed by David Kilzer.
3449
3450         * TestWebKitAPI/Configurations/Base.xcconfig:
3451         - Don't search Mac OS X header search paths when building on iOS
3452
3453 2013-02-13  Zan Dobersek  <zdobersek@igalia.com>
3454
3455         The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
3456         https://bugs.webkit.org/show_bug.cgi?id=109325
3457
3458         Reviewed by Anders Carlsson.
3459
3460         Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
3461         two methods as they're provided by the C++ standard library being used.
3462
3463         * DumpRenderTree/TestRunner.cpp:
3464         (setAppCacheMaximumSizeCallback):
3465         (setApplicationCacheOriginQuotaCallback):
3466         (setDatabaseQuotaCallback):
3467
3468 2013-02-13  Alan Cutter  <alancutter@chromium.org>
3469
3470         cr-linux debug should use clang and maybe be a components build
3471         https://bugs.webkit.org/show_bug.cgi?id=108512
3472
3473         Reviewed by Adam Barth.
3474
3475         Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
3476         Build bots will update clang with each bot cycle.
3477         Updated GCE image paths to suit gcutil 1.6.1.
3478
3479         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3480         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3481         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3482         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3483         * EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3484         * EWSTools/start-queue.sh:
3485
3486 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3487
3488         Unreviewed, rolling out r142747.
3489         http://trac.webkit.org/changeset/142747
3490         https://bugs.webkit.org/show_bug.cgi?id=109746
3491
3492         broke component build (Requested by alecf_gardening on
3493         #webkit).
3494
3495         * TestWebKitAPI/TestWebKitAPI.gypi:
3496         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3497
3498 2013-02-13  Jochen Eisinger  <jochen@chromium.org>
3499
3500         [chromium] fix TestRunner build with enable_webrtc=0
3501         https://bugs.webkit.org/show_bug.cgi?id=109700
3502
3503         Reviewed by Tony Chang.
3504
3505         We can't use ENABLE() macros in the TestRunner library, however,
3506         ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.
3507
3508         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
3509         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
3510         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
3511         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
3512         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3513         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3514         (WebTestRunner):
3515         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3516         (WebTestRunner::WebTestProxyBase::userMediaClient):
3517         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3518
3519 2013-02-12  Roger Fong  <roger_fong@apple.com>
3520
3521         TestWebKitAPI and record-memory projects and property sheets for VS2010.
3522         https://bugs.webkit.org/show_bug.cgi?id=107034
3523
3524         Reviewed by Brent Fulgham.
3525
3526         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
3527         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
3528         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
3529         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
3530         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
3531         * win/record-memory: Added.
3532         * win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
3533         * win/record-memory/record-memory.vcxproj: Added.
3534         * win/record-memory/record-memory.vcxproj.filters: Added.
3535         * win/record-memory/record-memoryCommon.props: Added.
3536         * win/record-memory/record-memoryDebug.props: Added.
3537         * win/record-memory/record-memoryRelease.props: Added.
3538
3539 2013-02-13  Tommy Widenflycht  <tommyw@google.com>
3540
3541         MediaStream API: Use the source id when creating new tracks
3542         https://bugs.webkit.org/show_bug.cgi?id=109688
3543
3544         Reviewed by Adam Barth.
3545
3546         Switching mock to new API.
3547
3548         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3549         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3550
3551 2013-02-13  Brent Fulgham  <bfulgham@webkit.org>
3552
3553         [Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
3554         to include paths, to match VS2005 build behavior.
3555
3556         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3557         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3558         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3559         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3560         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3561
3562 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3563
3564         Unreviewed, rolling out r142736.
3565         http://trac.webkit.org/changeset/142736
3566         https://bugs.webkit.org/show_bug.cgi?id=109716
3567
3568         Broke ABI, nightly builds crash on launch (Requested by ap on
3569         #webkit).
3570
3571         * MiniBrowser/mac/WK2BrowserWindowController.m:
3572         (-[WK2BrowserWindowController awakeFromNib]):
3573         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3574         (WTR::InjectedBundlePage::InjectedBundlePage):
3575         * WebKitTestRunner/TestController.cpp:
3576         (WTR::TestController::createWebViewWithOptions):
3577
3578 2013-02-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3579
3580         [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
3581         https://bugs.webkit.org/show_bug.cgi?id=109456
3582
3583         Reviewed by Anders Carlsson.
3584
3585         WebView instance must not live longer than EwkView, as EwkView owns
3586         objects that page proxy refers to, doing otherwise leads to a crash.
3587
3588         Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
3589         leads to evas objects deletion. So, the problem was that test controller was
3590         deleted after ewk_shutdown() had been called in main() function causing
3591         crashes on WTR exit.
3592
3593         The patch introduces a scope for test controller so that it is deleted first.
3594
3595         * WebKitTestRunner/efl/main.cpp:
3596         (main):
3597
3598 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3599
3600         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3601         https://bugs.webkit.org/show_bug.cgi?id=109554
3602
3603         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3604         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3605
3606         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3607         It helps me to do the tests for the serializer.
3608
3609         Reviewed by Yury Semikhatsky.
3610
3611         It is covered by newly added tests in TestWebKitAPI.
3612
3613         * TestWebKitAPI/TestWebKitAPI.gypi:
3614         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3615         (TestWebKitAPI):
3616         (HeapGraphReceiver):
3617         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3618         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3619         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3620         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3621         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3622         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3623         (TestWebKitAPI::HeapGraphReceiver::serializer):
3624         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3625         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3626         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3627         (TestWebKitAPI::HeapGraphReceiver::intValue):
3628         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3629         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3630         (TestWebKitAPI::HeapGraphReceiver::printNode):
3631         (Helper):
3632         (TestWebKitAPI::Helper::Helper):
3633         (TestWebKitAPI::Helper::addNode):
3634         (TestWebKitAPI::Helper::addEdge):
3635         (TestWebKitAPI::Helper::done):
3636         (Object):
3637         (TestWebKitAPI::Helper::Object::Object):
3638         (TestWebKitAPI::TEST):
3639         (Owner):
3640         (TestWebKitAPI::Owner::Owner):
3641         (TestWebKitAPI::Owner::reportMemoryUsage):
3642
3643 2013-02-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3644
3645         [WK2] Remove web intents callbacks
3646         https://bugs.webkit.org/show_bug.cgi?id=109654
3647
3648         Reviewed by Benjamin Poulain.
3649
3650         Web intents was removed by r142549.
3651
3652         * MiniBrowser/mac/WK2BrowserWindowController.m:
3653         (-[WK2BrowserWindowController awakeFromNib]):
3654         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3655         (WTR::InjectedBundlePage::InjectedBundlePage):
3656         * WebKitTestRunner/TestController.cpp:
3657         (WTR::TestController::createWebViewWithOptions):
3658
3659 2013-02-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3660
3661         [WK2] Page reloading will crash UIProcess after WebProcess was killed
3662         https://bugs.webkit.org/show_bug.cgi?id=109305
3663
3664         Reviewed by Benjamin Poulain.
3665
3666         Adding a new test to simulate the case of WebProcess crash followed by a trying
3667         to load a new page.
3668
3669         * TestWebKitAPI/GNUmakefile.am:
3670         * TestWebKitAPI/PlatformEfl.cmake:
3671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3672         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.
3673         (TestWebKitAPI):
3674         (TestWebKitAPI::didFinishLoad):
3675         (TestWebKitAPI::TEST):
3676
3677 2013-02-11  Brent Fulgham  <bfulgham@webkit.org>
3678
3679         Update WebKitDirs.pm for new Windows paths
3680         https://bugs.webkit.org/show_bug.cgi?id=107714
3681
3682         Reviewed by Daniel Bates.
3683
3684         * Scripts/webkitdirs.pm: For each existing Windows environment
3685         variable, also include creation of the 'new' variables. The
3686         'old' variables will be removed in a future update.
3687         (windowsSourceSourceDir): New helper routine to return the
3688         actual 'Source' folder of the WebKit source tree.
3689
3690 2013-02-12  Alec Flett  <alecflett@chromium.org>
3691
3692         Fix signedness in WebTestProxy
3693         https://bugs.webkit.org/show_bug.cgi?id=109623
3694
3695         Reviewed by Adam Barth.
3696
3697         Fix signedness problem, using size_t instead of int.
3698
3699         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3700
3701 2013-02-12  Raymond Toy  <rtoy@google.com>
3702
3703         Add alias
3704         https://bugs.webkit.org/show_bug.cgi?id=109621
3705
3706         No review needed.
3707
3708         * Scripts/webkitpy/common/config/committers.py:
3709
3710 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
3711
3712         [chromium] move text dump generation to TestRunner library
3713         https://bugs.webkit.org/show_bug.cgi?id=109575
3714
3715         Reviewed by Adam Barth.
3716
3717         * DumpRenderTree/DumpRenderTree.gypi:
3718         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3719         (WebKit):
3720         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3721         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3722         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3723         (WebTestRunner):
3724         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.
3725         (WebTestRunner::normalizeLayoutTestURL):
3726         (WebTestRunner):
3727         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h:
3728         (WebTestRunner):
3729         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3730         (WebTestRunner::TestRunner::checkResponseMimeType):
3731         (WebTestRunner):
3732         (WebTestRunner::TestRunner::shouldDumpAsText):
3733         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
3734         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3735         (TestRunner):
3736         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
3737         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3738         (WebTestRunner::WebTestProxyBase::captureTree):
3739         (WebTestRunner):
3740         * DumpRenderTree/chromium/TestShell.cpp:
3741         (TestShell::dump):
3742         (TestShell::captureHistoryForWindow):
3743         * DumpRenderTree/chromium/TestShell.h:
3744         (TestShell):
3745         * DumpRenderTree/chromium/WebViewHost.cpp:
3746         (WebViewHost::captureHistoryForWindow):
3747         * DumpRenderTree/chromium/WebViewHost.h:
3748
3749 2013-02-12  Jessie Berlin  <jberlin@apple.com>
3750
3751         Rollout r142618, it broke all the Mac builds.
3752
3753         * TestWebKitAPI/TestWebKitAPI.gypi:
3754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3755         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3756         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3757
3758 2013-02-12  Yury Semikhatsky  <yurys@chromium.org>
3759
3760         Unreviewed. Fix Chromium compilation after r142618.
3761
3762         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3763         (TestWebKitAPI::HeapGraphReceiver::printNode):
3764
3765 2013-02-12  Martin Robinson  <mrobinson@igalia.com>
3766
3767         [GTK] Add an optional moduleset with hard to get packages (including libsecret)
3768         https://bugs.webkit.org/show_bug.cgi?id=109195
3769
3770         Reviewed by Philippe Normand.
3771
3772         Add an optional moduleset that includes libsecret. This moduleset will
3773         be used to install some annoyingly hard to obtain dependencies on older
3774         distributions.
3775
3776         * gtk/jhbuild-optional.modules: Added.
3777         * gtk/jhbuild.modules: Add a reference to the new moduleset file.
3778
3779 2013-02-12  Ilya Tikhonovsky  <loislo@chromium.org>
3780
3781         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3782         https://bugs.webkit.org/show_bug.cgi?id=109554
3783
3784         In some cases leaves have no pointer. As example when we report a leaf via addPrivateBuffer.
3785         This patch has new set of tests for HeapGraphSerializer.
3786
3787         Reviewed by Yury Semikhatsky.
3788
3789         * TestWebKitAPI/TestWebKitAPI.gypi:
3790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3791         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3792         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3793
3794 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3795
3796         Unreviewed followup to r142606, the EFL port also enables the CSS image-set
3797         feature so the new configuration option's default value should reflect that.
3798
3799         * Scripts/webkitperl/FeatureList.pm:
3800
3801 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3802
3803         [GTK] Enable CSS Variables feature in development builds
3804         https://bugs.webkit.org/show_bug.cgi?id=109474
3805
3806         Reviewed by Martin Robinson.
3807
3808         * Scripts/webkitperl/FeatureList.pm: Enable the feature on development
3809         builds of the GTK port.
3810
3811 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3812
3813         [GTK] Enable CSS image-set support in development builds
3814         https://bugs.webkit.org/show_bug.cgi?id=109475
3815
3816         Reviewed by Martin Robinson.
3817
3818         * Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.
3819         Note that the Mac port also enables the feature but does so in Platform.h as the feature
3820         is also enabled for the iOS port which can't at the moment be detected via webkitperl.
3821
3822 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3823
3824         [GTK] Enable DOM4 events constructors in development builds
3825         https://bugs.webkit.org/show_bug.cgi?id=109471
3826
3827         Reviewed by Martin Robinson.
3828
3829         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the GTK port as well.
3830
3831 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3832
3833         Remove unnecessary variables from FeatureList.pm
3834         https://bugs.webkit.org/show_bug.cgi?id=109558
3835
3836         Reviewed by Daniel Bates.
3837
3838         A small cleanup, removing unused variables for which the related configuration
3839         options were already removed.
3840
3841         * Scripts/webkitperl/FeatureList.pm:
3842
3843 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
3844
3845         Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
3846         https://bugs.webkit.org/show_bug.cgi?id=109481
3847
3848         Reviewed by Daniel Bates.
3849
3850         The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
3851         back in r120574. There are still occurrences of it in various build systems
3852         which should all be removed as they are useless.
3853
3854         * Scripts/webkitperl/FeatureList.pm:
3855
3856 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
3857
3858         [chromium] move webrtc mocks to testrunner library
3859         https://bugs.webkit.org/show_bug.cgi?id=109041
3860
3861         Reviewed by Adam Barth.
3862
3863         * DumpRenderTree/DumpRenderTree.gypi:
3864         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3865         (WebKitSupportTestEnvironment):
3866         (WebKitSupportTestEnvironment::mockPlatform):
3867         (main):
3868         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3869         (MockWebKitPlatformSupport::setInterfaces):
3870         (MockWebKitPlatformSupport::createMediaStreamCenter):
3871         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
3872         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
3873         (WebTestRunner):
3874         (MockWebKitPlatformSupport):
3875         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3876         (WebKit):
3877         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3878         (WebKit):
3879         (WebTestRunner):
3880         (WebTestRunner::WebTestProxy::showContextMenu):
3881         (WebTestRunner::WebTestProxy::userMediaClient):
3882         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.cpp.
3883         (WebTestRunner::MockConstraints::verifyConstraints):
3884         (WebTestRunner):
3885         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.h.
3886         (WebKit):
3887         (WebTestRunner):
3888         (MockConstraints):
3889         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp.
3890         (WebTestRunner):
3891         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3892         (WebTestRunner::MockWebMediaStreamCenter::queryMediaStreamSources):
3893         (WebTestRunner::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
3894         (WebTestRunner::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
3895         (WebTestRunner::MockWebMediaStreamCenter::didAddMediaStreamTrack):
3896         (WebTestRunner::MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3897         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
3898         (MockWebAudioDestinationConsumer):
3899         (WebTestRunner::MockWebAudioDestinationConsumer::~MockWebAudioDestinationConsumer):
3900         (WebTestRunner::MockWebMediaStreamCenter::didCreateMediaStream):
3901         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h.
3902         (WebKit):
3903         (WebTestRunner):
3904         (MockWebMediaStreamCenter):
3905         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3906         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp.
3907         (WebTestRunner):
3908         (DTMFSenderToneTask):
3909         (WebTestRunner::DTMFSenderToneTask::DTMFSenderToneTask):
3910         (WebTestRunner::MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
3911         (WebTestRunner::MockWebRTCDTMFSenderHandler::setClient):
3912         (WebTestRunner::MockWebRTCDTMFSenderHandler::currentToneBuffer):
3913         (WebTestRunner::MockWebRTCDTMFSenderHandler::canInsertDTMF):
3914         (WebTestRunner::MockWebRTCDTMFSenderHandler::insertDTMF):
3915         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h.
3916         (WebTestRunner):
3917         (MockWebRTCDTMFSenderHandler):
3918         (WebTestRunner::MockWebRTCDTMFSenderHandler::taskList):
3919         (WebTestRunner::MockWebRTCDTMFSenderHandler::clearToneBuffer):
3920         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.cpp.
3921         (WebTestRunner):
3922         (DataChannelReadyStateTask):
3923         (WebTestRunner::DataChannelReadyStateTask::DataChannelReadyStateTask):
3924         (WebTestRunner::MockWebRTCDataChannelHandler::MockWebRTCDataChannelHandler):
3925         (WebTestRunner::MockWebRTCDataChannelHandler::setClient):
3926         (WebTestRunner::MockWebRTCDataChannelHandler::bufferedAmount):
3927         (WebTestRunner::MockWebRTCDataChannelHandler::sendStringData):
3928         (WebTestRunner::MockWebRTCDataChannelHandler::sendRawData):
3929         (WebTestRunner::MockWebRTCDataChannelHandler::close):
3930         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.h.
3931         (WebTestRunner):
3932         (MockWebRTCDataChannelHandler):
3933         (WebTestRunner::MockWebRTCDataChannelHandler::taskList):
3934         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp.
3935         (WebTestRunner):
3936         (RTCSessionDescriptionRequestSuccededTask):
3937         (WebTestRunner::RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3938         (RTCSessionDescriptionRequestFailedTask):
3939         (WebTestRunner::RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3940         (RTCStatsRequestSucceededTask):
3941         (WebTestRunner::RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
3942         (RTCVoidRequestTask):
3943         (WebTestRunner::RTCVoidRequestTask::RTCVoidRequestTask):
3944         (RTCPeerConnectionStateTask):
3945         (WebTestRunner::RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
3946         (RemoteDataChannelTask):
3947         (WebTestRunner::RemoteDataChannelTask::RemoteDataChannelTask):
3948         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3949         (WebTestRunner::MockWebRTCPeerConnectionHandler::initialize):
3950         (WebTestRunner::MockWebRTCPeerConnectionHandler::createOffer):
3951         (WebTestRunner::MockWebRTCPeerConnectionHandler::createAnswer):
3952         (WebTestRunner::MockWebRTCPeerConnectionHandler::setLocalDescription):
3953         (WebTestRunner::MockWebRTCPeerConnectionHandler::setRemoteDescription):
3954         (WebTestRunner::MockWebRTCPeerConnectionHandler::localDescription):
3955         (WebTestRunner::MockWebRTCPeerConnectionHandler::remoteDescription):
3956         (WebTestRunner::MockWebRTCPeerConnectionHandler::updateICE):
3957         (WebTestRunner::MockWebRTCPeerConnectionHandler::addICECandidate):
3958         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
3959         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
3960         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3961         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDataChannel):
3962         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDTMFSender):
3963         (WebTestRunner::MockWebRTCPeerConnectionHandler::stop):
3964         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
3965         (WebKit):
3966         (WebTestRunner):
3967         (MockWebRTCPeerConnectionHandler):
3968         (WebTestRunner::MockWebRTCPeerConnectionHandler::taskList):
3969         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3970         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3971         (WebTestRunner::TestInterfaces::TestInterfaces):
3972         (WebTestRunner::TestInterfaces::setDelegate):
3973         (WebTestRunner::TestInterfaces::delegate):
3974         (WebTestRunner):
3975         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3976         (TestInterfaces):
3977         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3978         (WebTestRunner::WebTestInterfaces::createMediaStreamCenter):
3979         (WebTestRunner):
3980         (WebTestRunner::WebTestInterfaces::createWebRTCPeerConnectionHandler):
3981         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3982         (WebTestRunner::WebTestProxyBase::userMediaClient):
3983         (WebTestRunner):
3984         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp.
3985         (WebTestRunner):
3986         (UserMediaRequestTask):
3987         (WebTestRunner::UserMediaRequestTask::UserMediaRequestTask):
3988         (MockExtraData):
3989         (WebTestRunner::WebUserMediaClientMock::WebUserMediaClientMock):
3990         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3991         (WebTestRunner::WebUserMediaClientMock::cancelUserMediaRequest):
3992         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
3993         (WebTestRunner):
3994         (WebUserMediaClientMock):
3995         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
3996         (WebTestRunner::WebUserMediaClientMock::taskList):
3997         * DumpRenderTree/chromium/TestShell.cpp:
3998         (TestShell::initialize):
3999         * DumpRenderTree/chromium/TestShell.h:
4000         (TestShell):
4001         * DumpRenderTree/chromium/WebViewHost.cpp:
4002         * DumpRenderTree/chromium/WebViewHost.h:
4003         (WebViewHost):
4004
4005 2013-02-11  Timothy Loh  <timloh@chromium.com>
4006
4007         webkit-patch upload regenerates the WebCore ChangeLog every time it's called
4008         https://bugs.webkit.org/show_bug.cgi?id=108983
4009
4010         Reviewed by Ryosuke Niwa.
4011
4012         This patch puts the behaviour from Bug 74358 behind the flag (default=OFF)
4013         `--update-changelogs', and removes the flag `--no-prepare-changelogs'.
4014         The flag name change from prepare to update is since we still want to
4015         prepare changelogs in the default case when none currently exist.
4016
4017         * Scripts/webkitpy/tool/commands/commandtest.py:
4018         (CommandsTest.assert_execute_outputs):
4019         * Scripts/webkitpy/tool/steps/options.py:
4020         (Options):
4021         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4022         (PrepareChangeLog.options):
4023         (PrepareChangeLog.run):
4024
4025 2013-02-11  Jochen Eisinger  <jochen@chromium.org>
4026
4027         [chromium] move printPage() implementation to testRunner library
4028         https://bugs.webkit.org/show_bug.cgi?id=109436
4029
4030         Reviewed by Adam Barth.
4031
4032         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4033         (WebTestRunner::WebTestProxy::showContextMenu):
4034         (WebTestRunner::WebTestProxy::printPage):
4035         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4036         (WebTestRunner):
4037         (WebTestRunner::WebTestProxyBase::printPage):
4038         * DumpRenderTree/chromium/WebViewHost.cpp:
4039         * DumpRenderTree/chromium/WebViewHost.h:
4040
4041 2013-02-11  James Robinson  <jamesr@chromium.org>
4042
4043         [Chromium] Get rid of WebAnimationController
4044         https://bugs.webkit.org/show_bug.cgi?id=109235
4045
4046         Reviewed by Benjamin Poulain.
4047
4048         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4049         (WebTestRunner::TestRunner::TestRunner):
4050         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4051         (TestRunner):
4052
4053 2013-02-11  Ryosuke Niwa  <rniwa@webkit.org>
4054
4055         Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
4056         https://bugs.webkit.org/show_bug.cgi?id=109534
4057
4058         Reviewed by Anders Carlsson.
4059
4060         * DumpRenderTree/gtk/EditingCallbacks.cpp:
4061         (shouldShowDeleteInterfaceForElement):
4062
4063 2013-02-11  Nico Weber  <thakis@chromium.org>
4064
4065         Remove web intents code
4066         https://bugs.webkit.org/show_bug.cgi?id=109501
4067
4068         Reviewed by Eric Seidel.
4069
4070         See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
4071
4072         * DumpRenderTree/TestRunner.cpp:
4073         (TestRunner::staticFunctions):
4074         * DumpRenderTree/TestRunner.h:
4075         (TestRunner):
4076         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4077         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4078         (WebKit):
4079         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4080         (WebKit):
4081         (WebTestRunner::WebTestProxy::didEndEditing):
4082         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4083         (WebTestRunner::TestRunner::TestRunner):
4084         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4085         (TestRunner):
4086         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4087         * DumpRenderTree/chromium/WebViewHost.cpp:
4088         * DumpRenderTree/chromium/WebViewHost.h:
4089         (WebViewHost):
4090         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4091         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4092         * DumpRenderTree/mac/TestRunnerMac.mm:
4093         * DumpRenderTree/win/TestRunnerWin.cpp:
4094         * DumpRenderTree/wx/TestRunnerWx.cpp:
4095         * Scripts/webkitperl/FeatureList.pm:
4096
4097 2013-02-11  Benjamin Poulain  <benjamin@webkit.org>
4098
4099         Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
4100         https://bugs.webkit.org/show_bug.cgi?id=109349
4101
4102         Reviewed by Sam Weinig.
4103
4104         Get rid of TestRunner's setMinimumTimerInterval and all the related functions.
4105
4106         This also fixes an oddity:
4107         TestRunners were initialized with a minimum timer interval of 10 milliseconds instead
4108         of using the default value. All with the same copy of an outdated comment.
4109
4110         * DumpRenderTree/TestRunner.cpp:
4111         (TestRunner::staticFunctions):
4112         * DumpRenderTree/TestRunner.h:
4113         (TestRunner):
4114         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4115         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
4116         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4117         (WebTestRunner::TestRunner::TestRunner):
4118         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4119         (TestRunner):
4120         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4121         (WebTestRunner::WebPreferences::reset):
4122         (WebTestRunner::WebPreferences::applyTo):
4123         * DumpRenderTree/chromium/WebViewHost.cpp:
4124         (WebViewHost::reset):
4125         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4126         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4127         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4128         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4129         (resetDefaultsToConsistentValues):
4130         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4131         * DumpRenderTree/mac/DumpRenderTree.mm:
4132         (resetWebViewToConsistentStateBeforeTesting):
4133         * DumpRenderTree/mac/TestRunnerMac.mm:
4134         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4135         (WebCore::WebPage::resetSettings):
4136         * DumpRenderTree/qt/TestRunnerQt.cpp:
4137         * DumpRenderTree/qt/TestRunnerQt.h:
4138         (TestRunner):
4139         * DumpRenderTree/win/DumpRenderTree.cpp:
4140         (resetWebViewToConsistentStateBeforeTesting):
4141         * DumpRenderTree/win/TestRunnerWin.cpp:
4142         * DumpRenderTree/wx/TestRunnerWx.cpp:
4143         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4144         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4145         (WTR::InjectedBundle::beginTesting):
4146         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4147         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4148         (TestRunner):
4149
4150 2013-02-11  Dean Jackson  <dino@apple.com>
4151
4152         Remove use of plugInStartLabelImage
4153         https://bugs.webkit.org/show_bug.cgi?id=108273
4154
4155         Reviewed by Simon Fraser.
4156
4157         Take two - after rollout in r142405.
4158         Removed plugInStartLabelImage entry from client structure.
4159
4160         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4161         (WTR::InjectedBundlePage::InjectedBundlePage):
4162
4163 2013-02-11  Tony Chang  <tony@chromium.org>
4164
4165         Move setFrameFlatteningEnabled from layoutTestController to window.internals.settings
4166         https://bugs.webkit.org/show_bug.cgi?id=87149
4167
4168         Reviewed by Simon Fraser.
4169
4170         Remove testRunner.setFrameFlatteningEnabled from DRT and WTR. WebKit API
4171         methods are left because there may be users of it. Add a test for Apple Mac
4172         to ensure that the API for the preference still works using overridePreference.
4173
4174         * DumpRenderTree/TestRunner.cpp:
4175         (TestRunner::staticFunctions):
4176         * DumpRenderTree/TestRunner.h:
4177         (TestRunner):
4178         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4179         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4180         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4181         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4182         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4183         (resetDefaultsToConsistentValues):
4184         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4185         * DumpRenderTree/mac/TestRunnerMac.mm:
4186         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4187         (WebCore::WebPage::resetSettings):
4188         * DumpRenderTree/qt/TestRunnerQt.cpp:
4189         * DumpRenderTree/qt/TestRunnerQt.h:
4190         (TestRunner):
4191         * DumpRenderTree/win/DumpRenderTree.cpp:
4192         (resetDefaultsToConsistentValues):
4193         * DumpRenderTree/win/TestRunnerWin.cpp:
4194         * DumpRenderTree/wx/TestRunnerWx.cpp:
4195         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4196         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4197         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4198         (TestRunner):
4199
4200 2013-02-11  Roger Fong  <roger_fong@apple.com>
4201
4202         Unreviewed. Windows 7 Debug mode build fix.
4203
4204         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4205
4206 2013-02-11  Tiancheng Jiang  <tijiang@rim.com>
4207
4208         [BlackBerry] Set mouse document position for mouse event in DRT.
4209         https://bugs.webkit.org/show_bug.cgi?id=109094.
4210
4211         Reviewed by Rob Buis.
4212
4213         RIM PR 246976.
4214         Internally Reviewed by Nima Ghanavatian & Genevieve Mak.
4215
4216         Set mouse document position when we create mouse event in DRT.
4217
4218         * DumpRenderTree/blackberry/EventSender.cpp:
4219         (setMouseEventDocumentPos):
4220         (mouseDownCallback):
4221         (mouseUpCallback):
4222         (mouseMoveToCallback):
4223
4224 2013-02-11  Mike Lattanzio  <mlattanzio@rim.com>
4225
4226         [BlackBerry] Add graphics subdirectory to include path.
4227         https://bugs.webkit.org/show_bug.cgi?id=109437
4228
4229         Reviewed by Rob Buis.
4230
4231         Add browser/platform/graphics to include path.
4232
4233         Internal review by Jeff Rogers.
4234
4235         * Scripts/webkitdirs.pm:
4236         (blackberryCMakeArguments):
4237
4238 2013-02-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4239
4240         [EFL][WKTR] Regression(r141836) fast/dom/Window/mozilla-focus-blur.html started failing
4241         https://bugs.webkit.org/show_bug.cgi?id=109438
4242
4243         Reviewed by Kenneth Rohde Christiansen.
4244
4245         Some refactoring in r141836 caused the view not to get focus if the focused
4246         frame is not the main one. The idea of the code was to remove focus from the
4247         view if the focused frame was not the main one, and then focus the view again.
4248         However, after the refactoring, the second step never happened: Focus was
4249         removed but not given again.
4250
4251         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4252         (WTR::PlatformWebView::focus):
4253
4254 2013-02-11  Zan Dobersek  <zdobersek@igalia.com>
4255
4256         [GTK] Don't generate documentation if building neither WebKit1 nor WebKit2
4257         https://bugs.webkit.org/show_bug.cgi?id=109420
4258
4259         Reviewed by Philippe Normand.
4260
4261         Don't generate the GTK documentation if neither of the WebKit1 and WebKit2
4262         layers was built. This just results in unnecessary errors being spewed out
4263         by the gtkdoc utilities.
4264
4265         * Scripts/webkitdirs.pm:
4266         (buildAutotoolsProject):
4267
4268 2013-02-11  Antoine Quint  <graouts@apple.com>
4269
4270         Unreviewed change to add myself to the Inspector IDLs watchlist.
4271
4272         * Scripts/webkitpy/common/config/watchlist:
4273
4274 2013-02-11  Krzysztof Czech  <k.czech@samsung.com>
4275
4276         [GTK][EFL] Shares WebKit-GTK's DumpRenderTree accessibility implementation with other Webkit ports
4277         https://bugs.webkit.org/show_bug.cgi?id=105007
4278
4279         Reviewed by Martin Robinson.
4280
4281         Shares specific ATK's accessibility implementation.
4282         Keeps platform specific methods in EFL and GTK's directories.
4283
4284         * DumpRenderTree/atk/AccessibilityCallbacks.h: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.h.
4285         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp.
4286         (printAccessibilityEvent):
4287         (axObjectEventListener):
4288         (connectAccessibilityCallbacks):
4289         (disconnectAccessibilityCallbacks):
4290         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
4291         (AccessibilityController::AccessibilityController):
4292         (AccessibilityController::~AccessibilityController):
4293         (AccessibilityController::elementAtPoint):
4294         (AccessibilityController::setLogFocusEvents):
4295         (AccessibilityController::setLogScrollingStartEvents):
4296         (AccessibilityController::setLogValueChangeEvents):