Move URL from WebCore to WTF
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-30  Alex Christensen  <achristensen@webkit.org>
2
3         Move URL from WebCore to WTF
4         https://bugs.webkit.org/show_bug.cgi?id=190234
5
6         Reviewed by Keith Miller.
7
8         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
9         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
10         * TestWebKitAPI/Tests/WebCore/URL.cpp:
11         (TestWebKitAPI::createURL):
12         (TestWebKitAPI::TEST_F):
13         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
14         (TestWebKitAPI::checkURL):
15         (TestWebKitAPI::checkRelativeURL):
16         (TestWebKitAPI::checkURLDifferences):
17         (TestWebKitAPI::checkRelativeURLDifferences):
18         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
19         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
20         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
21         (TestWebKitAPI::originalDataAsString):
22         (TestWebKitAPI::userVisibleString):
23         (TestWebKitAPI::literalURL):
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
26         (TEST):
27         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
28         (literalURL):
29         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
30         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
31         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
32         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
33         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
34         (TestWebKitAPI::Util::createURLForResource):
35         * lldb/lldb_webkit.py:
36         (__lldb_init_module):
37         (WTFURL_SummaryProvider):
38         (WTFURLProvider):
39         (WebCoreURL_SummaryProvider): Deleted.
40         (WebCoreURLProvider): Deleted.
41         (WebCoreURLProvider.__init__): Deleted.
42         (WebCoreURLProvider.to_string): Deleted.
43
44 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
45
46         webkitpy: Support unicode in MeteredStream
47         https://bugs.webkit.org/show_bug.cgi?id=192260
48
49         Reviewed by Stephanie Lewis.
50
51         It's possible that the test runner returns unicode characters to be logged when
52         running layout tests.
53
54         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
55         (MeteredStream.write): Message written to metered stream should be unicode.
56         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
57         (RegularTest.test_unicode):
58
59 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
60
61         REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
62         https://bugs.webkit.org/show_bug.cgi?id=192257
63         <rdar://problem/46384671>
64
65         Reviewed by Stephanie Lewis.
66
67         Follow-up fix for r238749.
68
69         * Scripts/webkitpy/api_tests/manager.py:
70         (Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.
71
72 2018-11-30  Chris Dumez  <cdumez@apple.com>
73
74         [PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us
75         https://bugs.webkit.org/show_bug.cgi?id=192242
76
77         Reviewed by Geoffrey Garen.
78
79         Add API test coverage.
80
81         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
82
83 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
84
85         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
86         https://bugs.webkit.org/show_bug.cgi?id=192197
87
88         Reviewed by Jiewen Tan.
89
90         * Scripts/webkitperl/FeatureList.pm:
91         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
92
93 2018-11-30  Dean Jackson  <dino@apple.com>
94
95         Add first-class support for .mjs files in jsc binary
96         https://bugs.webkit.org/show_bug.cgi?id=192190
97         <rdar://problem/46375715>
98
99         Reviewed by Keith Miller.
100
101         Add .mjs files to the regexp looking for all JS files.
102
103         * Scripts/run-jsc-stress-tests:
104
105 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
106
107         webkitpy: Use DeviceType instead of str to represent device class
108         https://bugs.webkit.org/show_bug.cgi?id=192160
109         <rdar://problem/46344845>
110
111         Rubber-stamped by Aakash Jain.
112
113         * Scripts/webkitpy/layout_tests/controllers/manager.py:
114         (Manager._custom_device_for_test): Use DeviceTypes instead of strings to represent device type.
115         (Manager._set_up_run): Do not set _options.device_class, use device_type instead of device_class.
116         (Manager.run): Use device_type instead of device_class.
117         (Manager._print_expectations_for_subset): Ditto.
118         (Manager.print_expectations): Ditto.
119         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
120         (ManagerTest.test_uses_custom_device): Use DeviceType and actual device definition.
121         * Scripts/webkitpy/layout_tests/views/printing.py:
122         (Printer.print_workers_and_shards): Outputting the device suffix doesn't really help, and means
123         device type needs to be passed around.
124         * Scripts/webkitpy/port/apple.py:
125         (ApplePort.setup_test_run): Use device_type instead of device_class.
126         * Scripts/webkitpy/port/base.py:
127         (Port):
128         (Port.setup_test_run): Use device_type instead of device_class.
129         * Scripts/webkitpy/port/device_port.py:
130         (DevicePort):
131         (DevicePort.setup_test_run): Receive device_type as DeviceType object.
132         (DevicePort._create_devices): Deleted.
133         * Scripts/webkitpy/port/gtk.py:
134         (GtkPort.setup_test_run): Use device_type instead of device_class.
135         * Scripts/webkitpy/port/ios.py:
136         (IOSPort):
137         * Scripts/webkitpy/port/ios_simulator.py:
138         (IOSSimulatorPort):
139         (IOSSimulatorPort.__init__): Deleted.
140         (IOSSimulatorPort._set_device_class): Deleted.
141         * Scripts/webkitpy/port/test.py:
142         * Scripts/webkitpy/port/watch.py:
143         (WatchPort):
144         * Scripts/webkitpy/port/watch_simulator.py:
145         (WatchSimulatorPort):
146         (WatchSimulatorPort.__init__): Deleted.
147         (WatchSimulatorPort._set_device_class): Deleted.
148         * Scripts/webkitpy/port/win.py:
149         (WinPort.setup_test_run): Use device_type instead of device_class.
150         * Scripts/webkitpy/xcode/simulated_device.py:
151         (SimulatedDeviceManager._disambiguate_device_type): Using the existing devices for this is
152         a problem if no such device exists yet. Use the _device_identifier_to_name dictionary instead
153         since this should have hardware types in the device names.
154
155 2018-11-30  David Quesada  <david_quesada@apple.com>
156
157         -[WKProcessPool _downloadURLRequest:] should allow specifying the initiating web view
158         https://bugs.webkit.org/show_bug.cgi?id=192212
159         rdar://problem/46363706
160
161         Reviewed by Alex Christensen.
162
163         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
164         (-[DownloadProgressTestRunner startDownload:expectedLength:]):
165
166 2018-11-30  Zalan Bujtas  <zalan@apple.com>
167
168         [LFC][BFC] Compute min/maxHeight margins only when they are needed.
169         https://bugs.webkit.org/show_bug.cgi?id=192223
170
171         Reviewed by Antti Koivisto.
172
173         * LayoutReloaded/misc/LFC-passing-tests.txt:
174
175 2018-11-30  Zalan Bujtas  <zalan@apple.com>
176
177         [LFC][BFC][MarginCollapsing] Do not use computed display box values for border and padding
178         https://bugs.webkit.org/show_bug.cgi?id=192214
179
180         Reviewed by Antti Koivisto.
181
182         * LayoutReloaded/misc/LFC-passing-tests.txt:
183
184 2018-11-30  Thibault Saunier  <tsaunier@igalia.com>
185
186         [GTK][MiniBrowser] Handle Device Info permission requests
187         https://bugs.webkit.org/show_bug.cgi?id=191585
188
189         Reviewed by Carlos Garcia Campos.
190
191         * MiniBrowser/gtk/BrowserTab.c:
192         (permissionRequestDataNew):
193         (permissionRequestDataFree):
194         (permissionRequestDialogResponse):
195         (decidePermissionRequest):
196         (browserTabConstructed):
197
198 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
199
200         Unreviewed GTK+ gardening. Stop running tests without complex text enforced
201
202         We have enforced complex text in GTK+ for one release cycle without noticing any major issue nor performance
203         regression.
204
205         * WebKitTestRunner/gtk/main.cpp:
206         (main):
207
208 2018-11-29  Wenson Hsieh  <wenson_hsieh@apple.com>
209
210         REGRESSION (r238635): Dragging a text selection within WKWebView causes the selection highlight to get into a bad state
211         https://bugs.webkit.org/show_bug.cgi?id=192165
212         <rdar://problem/46346682>
213
214         Reviewed by Daniel Bates.
215
216         Fixes 11 API tests that started failing or timing out after r238635. See below for more details.
217
218         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
219         (TestWebKitAPI::webViewForEditActionTesting):
220         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
221
222         Ensure that the web view becomes first responder before executing edit actions.
223
224         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
225         * TestWebKitAPI/Tests/WebKitCocoa/contenteditable-and-textarea.html:
226
227         Tweak these tests to allow selected content to overflow the width of the web view. Without this change,
228         ContentEditableToContentEditable and ContentEditableToTextarea will sometimes fail because the content causes
229         the body to scroll horizontally, so we miss the drop destination.
230
231         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
232         (loadTestPageAndEnsureInputSession):
233
234         Add a new helper to load a test page with a given name, become first responder, and wait until an input session
235         starts. Use this in various drag and drop tests to reduce code duplication.
236
237         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
238         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
239         (-[DragAndDropSimulator initWithWebView:]):
240         (-[DragAndDropSimulator _resetSimulatedState]):
241         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
242         (-[DragAndDropSimulator _advanceProgress]):
243
244         To more accurately emulate UIKit behavior, begin focus preservation when starting a drag, and attempt to clear
245         the focus preservation token when the drag session ends. This allows us to simulate and test the scenario that
246         regressed with r238635.
247
248         (-[DragAndDropSimulator ensureInputSession]):
249         (-[DragAndDropSimulator _webView:didStartInputSession:]):
250         (-[DragAndDropSimulator waitForInputSession]): Deleted.
251
252         Refactored into -ensureInputSession. Instead of assuming that an input session has not yet been started, simply
253         wait for an input session to start if needed.
254
255         * TestWebKitAPI/ios/UIKitSPI.h:
256
257         Add a new SPI declaration.
258
259 2018-11-29  Tim Horton  <timothy_horton@apple.com>
260
261         Inform clients when editable image attachment backing data changes
262         https://bugs.webkit.org/show_bug.cgi?id=192206
263         <rdar://problem/46350277>
264
265         Reviewed by Wenson Hsieh.
266
267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
268         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
269         (-[AttachmentUpdateObserver init]):
270         (-[AttachmentUpdateObserver dataInvalidated]):
271         (-[AttachmentUpdateObserver _webView:didInvalidateDataForAttachment:]):
272         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentInvalidation):
273         (webViewForTestingAttachments):
274         (TestWebKitAPI::forEachViewInHierarchy):
275         (TestWebKitAPI::findEditableImageCanvas):
276         (TestWebKitAPI::drawSquareInEditableImage):
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/ios/PencilKitTestSPI.h: Added.
279         Add a test ensuring that we get an invalidation callback when an editable image is changed.
280
281 2018-11-29  Fujii Hironori  <Hironori.Fujii@sony.com>
282
283         REGRESSION(r238445)[Buildbot] Unknown builder 'GTK Linux 32-bit Release' in scheduler 'trunk'
284         https://bugs.webkit.org/show_bug.cgi?id=192143
285
286         Reviewed by Philippe Normand.
287
288         Buildbot can't start since r238445.
289
290         > Configuration Errors:
291         >   Unknown builder 'GTK Linux 32-bit Release' in scheduler 'trunk'
292         >   Unknown builder 'GTK Linux ARM Release' in scheduler 'trunk'
293
294         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed deprecated builders.
295
296 2018-11-29  David Quesada  <david_quesada@apple.com>
297
298         Add SPI to publish NSProgress on active downloads
299         https://bugs.webkit.org/show_bug.cgi?id=192021
300         rdar://problem/44405661
301
302         Reviewed by Alex Christensen.
303
304         Add API tests to exercise the progress-publishing functionality in a variety of scenarios.
305
306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
307         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Added.
308         (+[DownloadProgressTestProtocol registerProtocolForTestRunner:]):
309         (+[DownloadProgressTestProtocol unregisterProtocol]):
310         (+[DownloadProgressTestProtocol canInitWithRequest:]):
311         (+[DownloadProgressTestProtocol canonicalRequestForRequest:]):
312         (+[DownloadProgressTestProtocol requestIsCacheEquivalent:toRequest:]):
313         (-[DownloadProgressTestProtocol startLoading]):
314         (-[DownloadProgressTestProtocol stopLoading]):
315         (-[DownloadProgressTestRunner init]):
316         (-[DownloadProgressTestRunner startLoadingWithProtocol:]):
317         (-[DownloadProgressTestRunner tearDown]):
318         (-[DownloadProgressTestRunner _didGetProgress:]):
319         (-[DownloadProgressTestRunner _didLoseProgress]):
320         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
321         (-[DownloadProgressTestRunner waitToLoseProgress]):
322         (-[DownloadProgressTestRunner startDownload:expectedLength:]):
323         (-[DownloadProgressTestRunner publishProgress]):
324         (-[DownloadProgressTestRunner receiveData:]):
325         (-[DownloadProgressTestRunner finishDownloadTask]):
326         (-[DownloadProgressTestRunner failDownloadTask]):
327         (-[DownloadProgressTestRunner waitForDownloadDidCreateDestination]):
328         (-[DownloadProgressTestRunner waitForDownloadFinished]):
329         (-[DownloadProgressTestRunner waitForDownloadCanceled]):
330         (-[DownloadProgressTestRunner waitForDownloadFailed]):
331         (-[DownloadProgressTestRunner waitForUpdatedCompletedUnitCount]):
332         (-[DownloadProgressTestRunner observeValueForKeyPath:ofObject:change:context:]):
333         (-[DownloadProgressTestRunner webView:decidePolicyForNavigationResponse:decisionHandler:]):
334         (-[DownloadProgressTestRunner webView:decidePolicyForNavigationAction:decisionHandler:]):
335         (-[DownloadProgressTestRunner _downloadDidStart:]):
336         (-[DownloadProgressTestRunner _download:didCreateDestination:]):
337         (-[DownloadProgressTestRunner _downloadDidFinish:]):
338         (-[DownloadProgressTestRunner _downloadDidCancel:]):
339         (-[DownloadProgressTestRunner _download:didFailWithError:]):
340         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
341         (TEST):
342
343 2018-11-29  Alexey Proskuryakov  <ap@apple.com>
344
345         Exception in bot watcher's dashboard if a hidden platform in no longer configured for display
346         https://bugs.webkit.org/show_bug.cgi?id=185527
347
348         Reviewed by Aakash Jain.
349
350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
351         (updateHiddenPlatforms):
352
353 2018-11-29  Zalan Bujtas  <zalan@apple.com>
354
355         [LFC][BFC][Quirk] Body and html height stretching.
356         https://bugs.webkit.org/show_bug.cgi?id=192154
357
358         Reviewed by Antti Koivisto.
359
360         * LayoutReloaded/misc/LFC-passing-tests.txt:
361
362 2018-11-29  Jonathan Bedard  <jbedard@apple.com>
363
364         webkitpy: Unify device creation
365         https://bugs.webkit.org/show_bug.cgi?id=192158
366         <rdar://problem/46344757>
367
368         Reviewed by Lucas Forschler.
369
370         * Scripts/webkitpy/port/device_port.py:
371         (DevicePort):
372         (DevicePort.setup_test_run): Use DEVICE_MANAGER to create devices based on the specified device class.
373         * Scripts/webkitpy/port/ios.py:
374         (IOSPort): Add DEFAULT_DEVICE_CLASS.
375         * Scripts/webkitpy/port/ios_device.py:
376         (IOSDevicePort):
377         (IOSDevicePort._create_devices): Deleted.
378         * Scripts/webkitpy/port/ios_simulator.py:
379         (IOSSimulatorPort._create_devices): Deleted.
380         * Scripts/webkitpy/port/watch.py:
381         (WatchPort): Add DEFAULT_DEVICE_CLASS.
382         * Scripts/webkitpy/port/watch_device.py:
383         (WatchDevicePort):
384         (WatchDevicePort._create_devices): Deleted.
385         * Scripts/webkitpy/port/watch_simulator.py:
386         (WatchSimulatorPort._create_devices): Deleted.
387         * Scripts/webkitpy/xcode/device_type_unittest.py:
388         (DeviceTypeTest.test_from_string): Test that DeviceTypes without hardware types can be constructed
389         from strings.
390
391 2018-11-29  Jonathan Bedard  <jbedard@apple.com>
392
393         EWS iOS-sim bots sometimes fails to shutdown simulator
394         https://bugs.webkit.org/show_bug.cgi?id=191864
395
396         Reviewed by Aakash Jain.
397
398         * Scripts/webkitpy/xcode/simulated_device.py:
399         (SimulatedDevice._shut_down): Increase time to wait for simulated device to
400         shut down, ignore exit code indicating a device is already shut down.
401
402 2018-11-29  Jonathan Bedard  <jbedard@apple.com>
403
404         webkitpy: Unify ios_version/watchos_version code
405         https://bugs.webkit.org/show_bug.cgi?id=192153
406         <rdar://problem/46343642>
407
408         Reviewed by Lucas Forschler.
409
410         Treating watchOS and iOS versions differently makes it harder to share code between the similar ports.
411
412         * Scripts/webkitpy/port/device_port.py:
413         (DevicePort):
414         (DevicePort.device_version): Added.
415         * Scripts/webkitpy/port/ios.py:
416         (IOSPort.default_baseline_search_path): Use device_version() instead of ios_version().
417         (IOSPort.ios_version): Deleted.
418         * Scripts/webkitpy/port/ios_device.py:
419         (IOSDevicePort.device_version): Renamed from ios_version().
420         (IOSDevicePort.ios_version): Deleted.
421         * Scripts/webkitpy/port/ios_simulator.py:
422         (IOSSimulatorPort.device_version): Renamed from ios_version().
423         (IOSSimulatorPort.default_child_processes.booted_ios_devices_filter): Use device_version() instead of ios_version().
424         (IOSSimulatorPort._create_devices): Ditto.
425         (IOSSimulatorPort.check_sys_deps): Ditto.
426         (IOSSimulatorPort.ios_version): Deleted.
427         * Scripts/webkitpy/port/watch.py:
428         (WatchPort.default_baseline_search_path): Use device_version() instead of watchos_version().
429         (WatchPort.watchos_version): Deleted.
430         * Scripts/webkitpy/port/watch_device.py:
431         (WatchDevicePort.device_version): Renamed from watchos_version().
432         (WatchDevicePort.watchos_version): Deleted.
433         * Scripts/webkitpy/port/watch_simulator.py:
434         (WatchSimulatorPort.device_version): Renamed from watchos_version().
435         (WatchSimulatorPort.default_child_processes.filter_booted_watchos_devices): Use device_version() instead of watchos_version().
436         (WatchSimulatorPort._create_devices): Ditto.
437         (WatchSimulatorPort.check_sys_deps): Ditto.
438         (WatchSimulatorPort.watchos_version): Deleted.
439
440 2018-11-28  Wenson Hsieh  <wenson_hsieh@apple.com>
441
442         [iOSMac] Dropping text selections from web content into editable elements crashes the web process
443         https://bugs.webkit.org/show_bug.cgi?id=192113
444         <rdar://problem/46323701>
445
446         Reviewed by Ryosuke Niwa.
447
448         Add a test to verify that, when dropping an item with both "com.apple.webarchive" and "public.utf8-plain-text"
449         representations, the higher fidelity web archive data is used when handling the drop.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
452
453 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-app] Fetch bugs from Bugzilla and submit to Buildbot
456         https://bugs.webkit.org/show_bug.cgi?id=191947
457
458         Reviewed by Lucas Forschler.
459
460         * BuildSlaveSupport/ews-app/ews/fetcher.py: Added.
461
462 2018-11-28  Alex Christensen  <achristensen@webkit.org>
463
464         Fix iOS API test after r238585
465         https://bugs.webkit.org/show_bug.cgi?id=192022
466
467         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
468         (TEST):
469         On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
470         The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.
471
472 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
473
474         [ews-app] Configure python logging
475         https://bugs.webkit.org/show_bug.cgi?id=192005
476
477         Reviewed by Lucas Forschler.
478
479         * BuildSlaveSupport/ews-app/ews/__init__.py: Configured logging.
480
481 2018-11-28  Keith Rollin  <krollin@apple.com>
482
483         Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
484         https://bugs.webkit.org/show_bug.cgi?id=192031
485         <rdar://problem/46286816>
486
487         Reviewed by Alex Christensen.
488
489         The Generate Derived Sources and Generate Unified Sources build phases
490         in Xcode need to have their inputs and outputs specified. This
491         specification will come in the form of .xcfilelist files that will be
492         attached to these build phases. There is one .xcfilelist file that
493         lists the input file and one that lists the output files. As part of
494         this work, the various generate-{derived,unified}-sources scripts that
495         are executed in these Generate build phases are modified to help in
496         the creation of these .xcfilelist files. In particular, they can now
497         be invoked with command-line parameters. These parameters are then
498         used to alter the normal execution of these scripts, causing them to
499         produce the .xcfilelist files as opposed to actually generating the
500         files that are listed in those files.
501
502         * DumpRenderTree/Scripts/generate-derived-sources.sh:
503         * WebKitTestRunner/Scripts/generate-derived-sources.sh:
504
505 2018-11-28  Keith Rollin  <krollin@apple.com>
506
507         Revert print_all_generated_files work in r238008; tighten up target specifications
508         https://bugs.webkit.org/show_bug.cgi?id=192025
509         <rdar://problem/46284301>
510
511         Reviewed by Alex Christensen.
512
513         In r238008, I added a facility for DerivedSources.make makefiles to
514         print out the list of files that they generate. This output was used
515         in the generation of .xcfilelist files used to specify the output of
516         the associated Generate Derived Sources build phases in Xcode. This
517         approach worked, but it meant that people would need to follow a
518         specific convention to keep this mechanism working.
519
520         Instead of continuing this approach, I'm going to implement a new
521         facility based on the output of `make` when passed the -d flag (which
522         prints dependency information). This new mechanism is completely
523         automatic and doesn't need maintainers to follow a convention. To that
524         end, remove most of the work performed in r238008 that supports the
525         print_all_generated_files target.
526
527         At the same time, it's important for the sets of targets and their
528         dependencies to be complete and correct. Therefore, also include
529         changes to bring those up-to-date. As part of that, you'll see
530         prevalent use of a particular technique. Here's an example:
531
532             BYTECODE_FILES = \
533                 Bytecodes.h \
534                 BytecodeIndices.h \
535                 BytecodeStructs.h \
536                 InitBytecodes.asm \
537             #
538             BYTECODE_FILES_PATTERNS = $(subst .,%,$(BYTECODE_FILES))
539
540             all : $(BYTECODE_FILES)
541
542             $(BYTECODE_FILES_PATTERNS): $(wildcard $(JavaScriptCore)/generator/*.rb) $(JavaScriptCore)/bytecode/BytecodeList.rb
543                 ...
544
545         These lines indicate a set of generated files (those specified in
546         BYTECODE_FILES). These files are generated by the BytecodeList.rb
547         tool. But, as opposed to the normal rule where a single foo.output is
548         generated by foo.input plus some additional dependencies, this rule
549         produces multiple output files from a tool whose connection to the
550         output files is not immediately clear. A special approach is needed
551         where a single rule produces multiple output files. The normal way to
552         implement this is to use an .INTERMEDIATE target. However, we used
553         this approach in the past and ran into a problem with it, addressing
554         it with an alternate approach in r210507. The above example shows this
555         approach. The .'s in the list of target files are replaced with %'s,
556         and the result is used as the left side of the dependency rule.
557
558         * DumpRenderTree/DerivedSources.make:
559         * WebKitTestRunner/DerivedSources.make:
560
561 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
562
563         [ews-app] Add support to get list of Bugzilla patches needing review
564         https://bugs.webkit.org/show_bug.cgi?id=191942
565
566         Reviewed by Lucas Forschler.
567
568         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
569         (Bugzilla.get_list_of_patches_needing_reviews): Get list of patches needing review.
570         (BugzillaBeautifulSoup.fetch_attachment_ids_from_review_queue): Copied from Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
571         (BugzillaBeautifulSoup._load_query): Ditto.
572         (BugzillaBeautifulSoup._parse_attachment_ids_request_query): Ditto.
573
574 2018-11-28  Daniel Bates  <dabates@apple.com>
575
576         [iOS] Page not defocused when Find-in-page becomes first responder
577         https://bugs.webkit.org/show_bug.cgi?id=192084
578         <rdar://problem/46146777>
579
580         Reviewed by Tim Horton.
581
582         Add tests for both Mac and iOS to ensure that when finding a string on the page
583         that we do not start an input session if a match is found in an <input> and the
584         WKWebView is not the first responder.
585
586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
587         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm: Added.
588         (-[WKWebViewFindStringInputDelegate _webView:didStartInputSession:]):
589         (-[WKWebViewFindStringFindDelegate findString]):
590         (-[WKWebViewFindStringFindDelegate _webView:didCountMatches:forString:]):
591         (-[WKWebViewFindStringFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
592         (-[WKWebViewFindStringFindDelegate _webView:didFailToFindString:]):
593         (returnNo):
594         (returnYes):
595         (viewIsFirstResponder):
596         (TestWebKitAPI::TEST):
597         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
598         (WTR::PlatformWebView::PlatformWebView): Make the view the first responder before the
599         window key. This matches the ordering used in PlatformWebView::focus(). No behavior change.
600
601 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
602
603         [ews-app] Add BeautifulSoup
604         https://bugs.webkit.org/show_bug.cgi?id=191994
605
606         Reviewed by Lucas Forschler.
607
608         * BuildSlaveSupport/ews-app/ews/thirdparty: Added.
609         * BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py: Added.
610         * BuildSlaveSupport/ews-app/ews/thirdparty/__init__.py: Added.
611
612 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
613
614         [ews-app] Add support to download Patch from Bugzilla
615         https://bugs.webkit.org/show_bug.cgi?id=191943
616
617         Reviewed by Lucas Forschler.
618
619         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py: Added.
620         (Bugzilla.retrieve_attachment): Retreives the attachment from Bugzilla and saves to disk.
621         (Bugzilla._fetch_attachment_json):
622         (Bugzilla.file_path_for_patch):
623         * BuildSlaveSupport/ews-app/ews/common/util.py: Added.
624         (fetch_data_from_url): Method to fetch data from given url.
625         * BuildSlaveSupport/ews-app/ews/config.py:
626
627 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
628
629         [ews-app] Add methods to update Patch fields
630         https://bugs.webkit.org/show_bug.cgi?id=191931
631
632         Reviewed by Lucas Forschler.
633
634         * BuildSlaveSupport/ews-app/ews/models/patch.py:
635         (Patch.set_sent_to_buildbot):
636         (Patch.set_bug_id):
637         (Patch.set_obsolete):
638
639 2018-11-28  Yongjun Zhang  <yongjun_zhang@apple.com>
640
641         Allow WebKit clients to specify a minimum effective width for layout.
642         https://bugs.webkit.org/show_bug.cgi?id=191499
643         <rdar://problem/45362678>
644
645         Reviewed by Wenson Hsieh.
646
647         Allow UIScriptController to set WKWebView's minimum effective width with a new `setMinimumEffectiveWidth` method.
648
649         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
650         (WTR::UIScriptController::setMinimumEffectiveWidth):
651         * DumpRenderTree/mac/UIScriptControllerMac.mm:
652         (WTR::UIScriptController::setViewScale):
653         (WTR::UIScriptController::setMinimumEffectiveWidth):
654         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
655         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
656         (WTR::UIScriptController::setMinimumEffectiveWidth):
657         * TestRunnerShared/UIScriptContext/UIScriptController.h:
658         * WebKitTestRunner/UIScriptControllerCocoa.mm:
659         (WTR::UIScriptController::setMinimumEffectiveWidth):
660         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
661         (WTR::TestController::cocoaResetStateToConsistentValues):
662
663 2018-11-28  Lucas Forschler  <lforschler@apple.com>
664
665         Fix webkitbot hi command.
666         https://bugs.webkit.org/show_bug.cgi?id=192080
667
668         Reviewed by Alexey Proskuryakov.
669
670         * Scripts/webkitpy/tool/bot/irc_command.py:
671         (Hi.execute):
672
673 2018-11-28  Zalan Bujtas  <zalan@apple.com>
674
675         [LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
676         https://bugs.webkit.org/show_bug.cgi?id=192078
677
678         Reviewed by Antti Koivisto.
679
680         * LayoutReloaded/misc/LFC-passing-tests.txt:
681
682 2018-11-28  Zalan Bujtas  <zalan@apple.com>
683
684         [LFC] Add support for quirk container's collapsing top margin in quirks mode.
685         https://bugs.webkit.org/show_bug.cgi?id=192070
686
687         Reviewed by Antti Koivisto.
688
689         * LayoutReloaded/misc/LFC-passing-tests.txt:
690
691 2018-11-28  Thibault Saunier  <tsaunier@igalia.com>
692
693         [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list
694         https://bugs.webkit.org/show_bug.cgi?id=192026
695
696         Reviewed by Philippe Normand.
697
698         Otherwise we might end up picking a useless one in some applications
699         (not sure what those application do though).
700
701         GStreamer patch proposed as https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/34/diffs
702
703         * flatpak/org.webkit.CommonModules.yaml:
704         * gstreamer/jhbuild.modules:
705         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Added.
706
707 2018-11-28  Tomas Popela  <tpopela@redhat.com>
708
709         [GTK] Silence compilation warnings in glib unittests
710         https://bugs.webkit.org/show_bug.cgi?id=192009
711
712         Reviewed by Michael Catanzaro.
713
714         Mark the destructor as virtual.
715
716         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
717         (Test::~Test):
718
719 2018-11-27  Mark Lam  <mark.lam@apple.com>
720
721         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
722         https://bugs.webkit.org/show_bug.cgi?id=192055
723         <rdar://problem/46288783>
724
725         Reviewed by Saam Barati.
726
727         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
728
729 2018-11-27  Alex Christensen  <achristensen@webkit.org>
730
731         Make synchronous IPC introduced in r237267 asynchronous
732         https://bugs.webkit.org/show_bug.cgi?id=190757
733
734         Reviewed by Chris Dumez.
735
736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
737
738 2018-11-27  Jonathan Bedard  <jbedard@apple.com>
739
740         webkitpy: Add watchOS ports
741         https://bugs.webkit.org/show_bug.cgi?id=191974
742         <rdar://problem/46251051>
743
744         Reviewed by Aakash Jain.
745
746         * Scripts/webkitpy/port/factory.py:
747         (PortFactory): Add WatchDevice and WatchSimulator ports.
748         * Scripts/webkitpy/port/watch.py: Added.
749         (WatchPort): Base class for watchOS ports.
750         * Scripts/webkitpy/port/watch_device.py: Added.
751         (WatchDevicePort): Class for running layout tests on a watchOS device.
752         * Scripts/webkitpy/port/watch_simulator.py: Added.
753         (WatchSimulatorPort): Class for running layout tests on a watchOS simulator.
754         * Scripts/webkitpy/port/watch_simulator_unittest.py: Added.
755         (WatchSimulatorTest):
756         * Scripts/webkitpy/port/watch_testcase.py: Added.
757         (WatchTest):
758
759 2018-11-27  Alex Christensen  <achristensen@webkit.org>
760
761         Safe browsing warning text needs to be visible on High Sierra
762         https://bugs.webkit.org/show_bug.cgi?id=192022
763
764         Reviewed by Tim Horton.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
767         (TEST):
768
769 2018-11-27  Wenson Hsieh  <wenson_hsieh@apple.com>
770
771         Unreviewed, fix the watchOS engineering build
772
773         Disable a newly added API test, since DDScannerResult is unavailable on watchOS.
774
775         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
776
777 2018-11-27  Chris Dumez  <cdumez@apple.com>
778
779         Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
780         https://bugs.webkit.org/show_bug.cgi?id=191983
781         <rdar://problem/46246863>
782
783         Reviewed by Geoffrey Garen.
784
785         Add API test coverage.
786
787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
788
789 2018-11-27  Aakash Jain  <aakash_jain@apple.com>
790
791         [ews-app] Add support to communicate with Buildbot (Follow-up fix)
792         https://bugs.webkit.org/show_bug.cgi?id=191935
793         <rdar://problem/46262314>
794
795         Unreviewed infrastructure fix.
796
797         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
798         (Buildbot.send_patch_to_buildbot):
799
800 2018-11-26  Wenson Hsieh  <wenson_hsieh@apple.com>
801
802         [Cocoa] No way for clients to tell whether the content view is in the responder chain when the web view is
803         https://bugs.webkit.org/show_bug.cgi?id=169212
804         <rdar://problem/30899656>
805
806         Reviewed by Tim Horton.
807
808         Add an API test to exercise the behavior of `-_contentViewIsFirstResponder` when an embedded text input becomes
809         and resigns first responder.
810
811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
812         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFirstResponderTests.mm: Added.
813         (-[FirstResponderTestingView initWithFrame:]):
814         (-[FirstResponderTestingView inputField]):
815         (TestWebKitAPI::TEST):
816
817 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
818
819         [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
820         https://bugs.webkit.org/show_bug.cgi?id=191831
821
822         Reviewed by Michael Catanzaro.
823
824         * WebKitTestRunner/CMakeLists.txt:
825
826 2018-11-26  Tim Horton  <timothy_horton@apple.com>
827
828         Insert <attachment> elements under editable images to make their backing data accessible
829         https://bugs.webkit.org/show_bug.cgi?id=191844
830         <rdar://problem/30900149>
831
832         Reviewed by Simon Fraser.
833
834         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
835         (WTR::UIScriptController::attachmentInfo):
836         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
837         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
838         (WTR::UIScriptController::attachmentInfo):
839         * TestRunnerShared/UIScriptContext/UIScriptController.h:
840         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
841         (WTR::UIScriptController::attachmentInfo):
842         Add a UIScriptController mechanism to retrieve information about
843         a given attachment.
844
845 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
846
847         [ews-app] Add support to communicate with Buildbot
848         https://bugs.webkit.org/show_bug.cgi?id=191935
849
850         Reviewed by Lucas Forschler.
851
852         * BuildSlaveSupport/ews-app/ews/common/__init__.py: Added.
853         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Added.
854
855 2018-11-26  Jonathan Bedard  <jbedard@apple.com>
856
857         webkitpy: Race condition in ServerProcess tests
858         https://bugs.webkit.org/show_bug.cgi?id=191989
859         <rdar://problem/45536844>
860
861         Reviewed by Lucas Forschler.
862
863         Serializing these tests to prevent the race conditions.
864
865         * Scripts/webkitpy/port/server_process_unittest.py:
866         (TestServerProcess.serial_test_basic):
867         (TestServerProcess.serial_test_read_after_process_exits):
868         (TestServerProcess.serial_test_process_crashing):
869         (TestServerProcess.serial_test_process_crashing_no_data):
870         (TestServerProcess.test_basic): Deleted.
871         (TestServerProcess.test_read_after_process_exits): Deleted.
872         (TestServerProcess.test_process_crashing): Deleted.
873         (TestServerProcess.test_process_crashing_no_data): Deleted.
874
875 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
876
877         [ews-app] Add field in Patch object to indicate if it has been sent to Buildbot
878         https://bugs.webkit.org/show_bug.cgi?id=191929
879
880         Reviewed by Lucas Forschler.
881
882         * BuildSlaveSupport/ews-app/ews/models/patch.py:
883         (Patch): Added sent_to_buildbot field.
884         (Patch.is_patch_sent_to_buildbot): Checks if the patch has been sent to Buildbot.
885
886 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
887
888         [ews-app] Add a config file
889         https://bugs.webkit.org/show_bug.cgi?id=191933
890
891         Reviewed by Lucas Forschler.
892
893         * BuildSlaveSupport/ews-app/ews/config.py: Added.
894
895 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
896
897         [ews-app] Add methods to save patch to database
898         https://bugs.webkit.org/show_bug.cgi?id=191928
899
900         Reviewed by Lucas Forschler.
901
902         * BuildSlaveSupport/ews-app/ews/models/patch.py:
903         (Patch.save_patch): Method to save the patch to database.
904         (Patch.save_patches): Method to save multiple patches to database.
905         (Patch.is_valid_patch_id): Checks if the patch id is valid.
906         (Patch.is_existing_patch_id): Checks if the patch id already exists in database.
907
908 2018-11-26  Alex Christensen  <achristensen@webkit.org>
909
910         Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing
911         https://bugs.webkit.org/show_bug.cgi?id=191981
912
913         Reviewed by Tim Horton.
914
915         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
916         (TEST):
917         (safeBrowsingView):
918
919 2018-11-26  Daniel Bates  <dabates@apple.com>
920
921         REGRESSION (r237738): Command Down Arrow doesn't scroll to the end of a page anymore
922         https://bugs.webkit.org/show_bug.cgi?id=191967
923         <rdar://problem/45976390>
924
925         Reviewed by Tim Horton.
926
927         Add more test infrastructure to dispatch key up events.
928
929         * WebKitTestRunner/ios/HIDEventGenerator.h:
930         * WebKitTestRunner/ios/HIDEventGenerator.mm:
931         (createHIDKeyEvent): Renamed from createHIDKeyDownEvent() and modified to take a boolean as
932         to whether to create an event for a key down or key up.
933         (createHIDKeyDownEvent): Deleted; renamed to createHIDKeyEvent().
934         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
935         (WTR::createUIPhysicalKeyboardEvent): Added. Convenience function to create a UIPhysicalKeyboardEvent.
936         (WTR::UIScriptController::keyDown): Modified to dispatch a key up event in addition to dispatching
937         a key down event.
938
939 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-app] Set Foreign Keys in EWS Django app models
942         https://bugs.webkit.org/show_bug.cgi?id=191790
943
944         Reviewed by Lucas Forschler.
945
946         * BuildSlaveSupport/ews-app/ews/models/builds.py: Set Foreign Key.
947         * BuildSlaveSupport/ews-app/ews/models/steps.py: Ditto.
948
949 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
950
951         [ews-app] Do not store patch content in database
952         https://bugs.webkit.org/show_bug.cgi?id=191788
953
954         Reviewed by Lucas Forschler.
955
956         * BuildSlaveSupport/ews-app/ews/models/patch.py: Removed content field.
957
958 2018-11-26  Jonathan Bedard  <jbedard@apple.com>
959
960         webkitpy: Retry app installation on watchOS simulators (Follow-up fix)
961         https://bugs.webkit.org/show_bug.cgi?id=191769
962         <rdar://problem/46139850>
963
964         Unreviewed infrastructure fix.
965
966         * Scripts/webkitpy/xcode/simulated_device.py:
967         (SimulatedDevice): Increase retry attempts.
968
969 2018-11-26  Daniel Bates  <dabates@apple.com>
970
971         Move testRunner.toggleCapsLock() to uiController
972         https://bugs.webkit.org/show_bug.cgi?id=191972
973
974         Reviewed by Tim Horton.
975
976         Move testRunner.toggleCapsLock() to uiController as uiController is the preferred JavaScript
977         object for UI test functions. Having this functionality be on uiController makes it an
978         asynchronous function naturally and complements use of onkeydown, onkeyup listeners to know
979         when the Caps Lock key event is dispatched. It also facilitates its use directly as part of
980         scripts with other uiController functions invocations that are passed in a single invocation
981         of testRunner.runUIScript().
982
983         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
984         (WTR::UIScriptController::toggleCapsLock):
985         * DumpRenderTree/mac/UIScriptControllerMac.mm:
986         (WTR::UIScriptController::toggleCapsLock):
987         Added stub functions that invoke the callback. We do not support toggling caps lock in Legacy
988         WebKit at the moment. Legacy WebKit reads the caps lock key state directly from the OS. Modern
989         WebKit caches the caps lock state in the WebProcess as a natural side effect of the fact that
990         the UIProcess is the only process capable of querying the caps lock key state from the OS and
991         hence the UIProcess must send over this state to the WebProcess.
992
993         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Add IDL for new function.
994         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
995         (WTR::UIScriptController::toggleCapsLock): Added empty implementation for ports non-Cocoa ports.
996         * TestRunnerShared/UIScriptContext/UIScriptController.h:
997
998         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
999         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1000         (WTR::TestRunner::toggleCapsLock): Deleted.
1001         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1002         * WebKitTestRunner/TestController.h:
1003         * WebKitTestRunner/TestInvocation.cpp:
1004         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1005         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1006         (WTR::TestController::toggleCapsLock): Deleted; moved to UIScriptController::toggleCapsLock().
1007         Removed logic to handle testRunner.toggleCapsLock().
1008
1009         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1010         (WTR::UIScriptController::toggleCapsLock): Add stub function that invokes the callback
1011         and a FIXME comment that explains that we will implement this function in <https://bugs.webkit.org/show_bug.cgi?id=191815>.
1012         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1013         (WTR::UIScriptController::toggleCapsLock): Moved the implementation from TestController::toggleCapsLock().
1014
1015 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1016
1017         [Win] Reduce the use of WKSI library calls: CoreAnimation
1018         https://bugs.webkit.org/show_bug.cgi?id=191777
1019         <rdar://problem/46140542>
1020
1021         Reviewed by Zalan Bujtas.
1022
1023         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1024         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1025         directives for WebKitSystemInterface.lib.
1026
1027         * TestWebKitAPI/PlatformWin.cmake:
1028
1029 2018-11-25  Zalan Bujtas  <zalan@apple.com>
1030
1031         [LFC][IFC] Use float box's margin box to adjust the line constraints.
1032         https://bugs.webkit.org/show_bug.cgi?id=191961
1033
1034         Reviewed by Antti Koivisto.
1035
1036         * LayoutReloaded/misc/LFC-passing-tests.txt:
1037
1038 2018-11-25  Zalan Bujtas  <zalan@apple.com>
1039
1040         Unreviewed test fix after r238467.
1041
1042         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1043         (TestWebKitAPI::TEST):
1044
1045 2018-11-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1046
1047         Unreviewed, fix the internal iOS 12 build after r238471
1048
1049         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
1050         (TEST):
1051
1052 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1053
1054         Make it possible to insert editable images with a gesture
1055         https://bugs.webkit.org/show_bug.cgi?id=191937
1056
1057         Reviewed by Wenson Hsieh.
1058
1059         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1060         (WTR::UIScriptController::drawSquareInEditableImage):
1061         If the canvas already has a drawing, draw a new stroke on top of it
1062         instead of removing the existing stroke.
1063
1064 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1065
1066         [Cocoa] Add WKWebView SPI to trigger and remove data detection
1067         https://bugs.webkit.org/show_bug.cgi?id=191918
1068         <rdar://problem/36185051>
1069
1070         Reviewed by Tim Horton.
1071
1072         Add an API test to exercise the new WebKit SPI.
1073
1074         * TestWebKitAPI/DataDetectorsCoreSPI.h: Added.
1075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1076         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
1077         (-[WKWebView synchronouslyDetectDataWithTypes:]):
1078         (-[WKWebView synchronouslyRemoveDataDetectedLinks]):
1079         (TEST):
1080         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1081         (TestWebKitAPI::TEST):
1082         (-[TestWKWebView tagsInBody]): Deleted.
1083         (-[TestWKWebView expectElementTagsInOrder:]): Deleted.
1084         (-[TestWKWebView expectElementCount:tagName:]): Deleted.
1085         (-[TestWKWebView expectElementTag:toComeBefore:]): Deleted.
1086
1087         Rename this from `-expectElementCount:tagName:` to `-expectElementCount:querySelector:`.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/data-detectors.html: Added.
1090
1091         Add a new test page containing some content that can be data detected.
1092
1093         * TestWebKitAPI/cocoa/TestWKWebView.h:
1094         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1095         (-[WKWebView tagsInBody]):
1096         (-[WKWebView expectElementTagsInOrder:]):
1097         (-[WKWebView expectElementCount:querySelector:]):
1098         (-[WKWebView expectElementTag:toComeBefore:]):
1099
1100         Move some testing helper functions from WKAttachmentTests to a testing category on WKWebView. This allows us to
1101         use `-expectElementCount:querySelector:` in tests outside of WKAttachmentTests.
1102
1103         (-[WKWebView objectByEvaluatingJavaScript:]):
1104         (-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
1105         (-[WKWebView stringByEvaluatingJavaScript:]):
1106
1107         Move some common helper functions from TestWKWebView to a testing category on WKWebView.
1108
1109         (-[TestWKWebView objectByEvaluatingJavaScript:]): Deleted.
1110         (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]): Deleted.
1111         (-[TestWKWebView stringByEvaluatingJavaScript:]): Deleted.
1112
1113 2018-11-23  Sam Weinig  <sam@webkit.org>
1114
1115         Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
1116         https://bugs.webkit.org/show_bug.cgi?id=191936
1117
1118         Reviewed by Zalan Bujtas.
1119
1120         Adds tests for raw pointer overloads in ListHashSet.
1121
1122         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1123         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1124
1125 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1126
1127         Enable drag and drop support for iOSMac
1128         https://bugs.webkit.org/show_bug.cgi?id=191818
1129         <rdar://problem/43907454>
1130
1131         Reviewed by Dean Jackson.
1132
1133         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1134
1135 2018-11-23  Zalan Bujtas  <zalan@apple.com>
1136
1137         [LFC][IFC] Add support for variable height runs.
1138         https://bugs.webkit.org/show_bug.cgi?id=191925
1139
1140         Reviewed by Antti Koivisto.
1141
1142         * LayoutReloaded/misc/LFC-passing-tests.txt:
1143
1144 2018-11-23  Alberto Garcia  <berto@igalia.com>
1145
1146         [GTK] [WPE] Tools/Platform{GTK,WPE}.cmake files missing from the tarballs
1147         https://bugs.webkit.org/show_bug.cgi?id=191923
1148
1149         Add Tools/PlatformGTK.cmake and Tools/PlatformWPE.cmake to their
1150         respective tarballs.
1151
1152         Reviewed by Carlos Garcia Campos.
1153
1154         * gtk/manifest.txt.in:
1155         * wpe/manifest.txt.in:
1156
1157 2018-11-22  Chris Dumez  <cdumez@apple.com>
1158
1159         Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
1160         https://bugs.webkit.org/show_bug.cgi?id=191914
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         Add API test coverage.
1165
1166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1167
1168 2018-11-22  Zalan Bujtas  <zalan@apple.com>
1169
1170         [LFC][IFC] Offset formatting context root runs with horizontal margins.
1171         https://bugs.webkit.org/show_bug.cgi?id=191900
1172
1173         Reviewed by Antti Koivisto.
1174
1175         * LayoutReloaded/misc/LFC-passing-tests.txt:
1176
1177 2018-11-22  Philippe Normand  <pnormand@igalia.com>
1178
1179         [GTK] Remove unmaintained bots
1180         https://bugs.webkit.org/show_bug.cgi?id=191467
1181
1182         Reviewed by Alex Christensen.
1183
1184         The Linux 32-bits and ARM build-slaves are no longer maintained
1185         and have been failing for months, so get rid of them.
1186
1187         * BuildSlaveSupport/build.webkit.org-config/config.json:
1188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1189         (WebKitBuildbot):
1190         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1191
1192 2018-11-22  Thibault Saunier  <tsaunier@igalia.com>
1193
1194         [Flatpak] Do not disable signals when running "usual" commands
1195         https://bugs.webkit.org/show_bug.cgi?id=190679
1196
1197         Reviewed by Philippe Normand.
1198
1199         Otherwise <ctr>c doesn't work while compiling. It is not the best fix
1200         as there are cases we want to let only children receive signals, but
1201         it is not clear how to determine when (when running gdb, we still
1202         disable those).
1203
1204         * flatpak/flatpakutils.py:
1205         (WebkitFlatpak.run_in_sandbox):
1206
1207 2018-11-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1208
1209         [Cocoa] [WebKit2] Add support for replacing find-in-page text matches
1210         https://bugs.webkit.org/show_bug.cgi?id=191786
1211         <rdar://problem/45813871>
1212
1213         Reviewed by Ryosuke Niwa.
1214
1215         * MiniBrowser/mac/WK2BrowserWindowController.m:
1216         (-[WK2BrowserWindowController setFindBarView:]):
1217
1218         Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
1219         the "Replace" option.
1220
1221         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1222
1223         Add an API test to exercise find-and-replace API using WKWebView.
1224
1225         (replaceMatches):
1226         (TEST):
1227         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1228         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1229         (WTR::findOptionsFromArray):
1230         (WTR::TestRunner::findString):
1231         (WTR::TestRunner::findStringMatchesInPage):
1232         (WTR::TestRunner::replaceFindMatchesAtIndices):
1233
1234         Add TestRunner hooks to simulate find-in-page and replace.
1235
1236         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1237
1238 2018-11-21  Zalan Bujtas  <zalan@apple.com>
1239
1240         [LFC][IFC] Horizontal margins should be considered as non-breakable space
1241         https://bugs.webkit.org/show_bug.cgi?id=191894
1242
1243         Reviewed by Antti Koivisto.
1244
1245         * LayoutReloaded/misc/LFC-passing-tests.txt:
1246
1247 2018-11-21  Zalan Bujtas  <zalan@apple.com>
1248
1249         [LFC][IFC] Border should be considered as non-breakable space
1250         https://bugs.webkit.org/show_bug.cgi?id=191891
1251
1252         Reviewed by Antti Koivisto.
1253
1254         * LayoutReloaded/misc/LFC-passing-tests.txt:
1255
1256 2018-11-21  Zalan Bujtas  <zalan@apple.com>
1257
1258         [LFC][IFC] Take nonBreakableStart/End into use.
1259         https://bugs.webkit.org/show_bug.cgi?id=191873
1260
1261         Reviewed by Antti Koivisto.
1262
1263         * LayoutReloaded/misc/LFC-passing-tests.txt:
1264
1265 2018-11-20  Jeff Miller  <jeffm@apple.com>
1266
1267         Return nullptr immediately if the key doesn't exist in the HashMap.
1268         https://bugs.webkit.org/show_bug.cgi?id=191841
1269
1270         Reviewed by Chris Dumez.
1271         
1272         Add a test that would crash prior to the fix for this bug.
1273
1274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1275         * TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.
1276         (TestWebKitAPI::TEST):
1277
1278 2018-11-19  Alex Christensen  <achristensen@webkit.org>
1279
1280         Add SPI to disable JIT in a WKWebView
1281         https://bugs.webkit.org/show_bug.cgi?id=191822
1282         <rdar://problem/28119360>
1283
1284         Reviewed by Geoffrey Garen.
1285
1286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1287         * TestWebKitAPI/Tests/WebKitCocoa/DisableJIT.mm: Added.
1288         (TEST):
1289
1290 2018-11-19  Basuke Suzuki  <basuke.suzuki@sony.com>
1291
1292         [Curl] Add API for CertificateInfo.
1293         https://bugs.webkit.org/show_bug.cgi?id=191647
1294
1295         Reviewed by Alex Christensen.
1296
1297         Added test for new WKCertificateInfo API.
1298
1299         * TestWebKitAPI/PlatformWin.cmake:
1300         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Added.
1301         (TestWebKitAPI::Curl::makeCertificateInfo):
1302         (TestWebKitAPI::Curl::isSamePEM):
1303         (TestWebKitAPI::Curl::TEST):
1304
1305 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1306
1307         Unreviewed, fix the internal iOS debug build after r238380
1308
1309         UICalloutBar should only be declared when the public (non-internal) SDK is used to build WebKit; otherwise, we
1310         end up with duplicate declarations of UICalloutBar.
1311
1312         * TestWebKitAPI/ios/UIKitSPI.h:
1313
1314 2018-11-19  David Quesada  <david_quesada@apple.com>
1315
1316         EXC_BAD_ACCESS when invoking a DownloadProxy's destination decision handler after the download has been canceled
1317         https://bugs.webkit.org/show_bug.cgi?id=191762
1318         rdar://problem/46151509
1319
1320         Reviewed by Dean Jackson.
1321
1322         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1323             Enable the Download API test on iOS, since the platform supports downloads. All the
1324             tests pass already, except for one which was written using AppKit-specific code:
1325         TEST(_WKDownload, RedirectedDownload):
1326             Use a more platform-agnostic approach to starting the download in this API test.
1327             Instead of manually triggering an NSMenu item to download a file from a link, the
1328             test will simulate a user-initiated click on the link, and the navigation delegate
1329             will direct the web view to start a download based on the link's navigation action.
1330             Additionally, remove the manual creation of a new NSWindow. TestWKWebView makes its
1331             own UI/NSWindow.
1332         TEST(_WKDownload, DownloadCanceledWhileDecidingDestination):
1333             Add an API test _WKDownload.DownloadCanceledWhileDecidingDestination to simulate the
1334             conditions that would trigger this crash - handling a download's -decideDestination…
1335             delegate call by canceling the download, waiting for the UI process to be notified
1336             that the download has been canceled, and calling the decision handler. This should
1337             not crash.
1338         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidFinish:]):
1339         (-[CancelDownloadWhileDecidingDestinationDelegate _download:didFailWithError:]):
1340         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidCancel:]):
1341         (-[CancelDownloadWhileDecidingDestinationDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1342         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]): Deleted.
1343         * TestWebKitAPI/cocoa/TestWKWebView.h:
1344         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1345         (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
1346             Add a user-initated version of -objectByEvaluatingJavaScript:. This is needed in
1347             order to maintain the behavior of the RedirectedDownload test, which verifies the
1348             state of the _WKDownload.wasUserInitiated property.
1349
1350 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1351
1352         [iOS Debug] Assertion failure in NSComparisonResult UIContentSizeCategoryCompareToCategory()
1353         https://bugs.webkit.org/show_bug.cgi?id=190401
1354         <rdar://problem/45195285>
1355
1356         Reviewed by Dean Jackson.
1357
1358         Work around sporadic UIKit assertions when running API tests that may present a UICalloutBar. Currently, UIKit
1359         asks for the `UIApp`’s `-preferredContentSizeCategory` when showing or laying out the callout bar. However,
1360         TestWebKitAPI lacks a UIApp altogether, and forcing one to be initialized via `UIApplicationInstantiateSingleton`
1361         causes numerous other UIKit and WebKit assertions to be hit.
1362
1363         In lieu of TestWebKitAPI becoming a real UI application (see https://webkit.org/b/175204), simply don't allow
1364         the callout bar to be initialized in TestWKWebView-based API tests. This encompasses all API tests which
1365         have some chance of causing the callout bar to be shown by making a ranged text selections during the test.
1366
1367         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1368         (suppressUICalloutBar):
1369         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1370         * TestWebKitAPI/ios/UIKitSPI.h:
1371
1372 2018-11-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1373
1374         REGRESSION(r238016)[GTK][TestWebKitAPI][Ninja] TestJSC can't compile "Bytecodes.h: No such file or directory"
1375         https://bugs.webkit.org/show_bug.cgi?id=191692
1376
1377         Reviewed by Michael Catanzaro.
1378
1379         r238016 added a new #include, and requires JSC's derived headers
1380         to be copied into the forwarding header directory.
1381
1382         WEBKIT_MAKE_FORWARDING_HEADERS is using POST_BUILD event to copy
1383         derived headers to the forwarding header directory. This is done
1384         after linking JSC library.
1385
1386         GTK port has TestJSC which has a dependency to JSC static library.
1387         And, this dependency is a link time dependency which means
1388         compiling source files of TestJSC starts before the POST_BUILD
1389         event of JSC. Thus, required header can't be found.
1390
1391         Add an intermediate target between TestJSC and JavaScriptCore to
1392         ensure derived headers are copied into the forwarding header
1393         directory.
1394
1395         * TestWebKitAPI/PlatformGTK.cmake: Added a new custom target pre-TestJSC.
1396         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1397
1398 2018-11-19  Alejandro G. Castro  <alex@igalia.com>
1399
1400         [GTK][WPE] Solve some issues in the enumerateDevices code
1401         https://bugs.webkit.org/show_bug.cgi?id=191832
1402
1403         Reviewed by Carlos Garcia Campos.
1404
1405         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1406         (serverCallback): Make all the Strings with HTML code static.
1407         (testWebsiteDataDeviceIdHashSalt): Change the webView settings in
1408         the test.
1409         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1410         (WebViewTest::initializeWebView): Remove the initialization of the
1411         webView settings, we now do it in the specific test.
1412
1413 2018-11-18  Chris Dumez  <cdumez@apple.com>
1414
1415         [PSON] Received an invalid message "WebPageProxy.DidPerformClientRedirect" from the web process
1416         https://bugs.webkit.org/show_bug.cgi?id=191828
1417
1418         Reviewed by Antti Koivisto.
1419
1420         Add API test coverage.
1421
1422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1423         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1424         * TestWebKitAPI/Tests/WebKitCocoa/client-side-redirect.html: Added.
1425
1426 2018-11-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1427
1428         [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
1429         https://bugs.webkit.org/show_bug.cgi?id=191819
1430
1431         Reviewed by Dan Bernstein.
1432
1433         Replace UIItemProvider (and related classes) with NSItemProvider.
1434
1435         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1436         (platformCopyPNG):
1437         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1438         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1439
1440         Replace usages of this deprecated method with `-registerDataRepresentationForTypeIdentifier:visibility:loadHandler:`.
1441
1442         (checkEstimatedSize):
1443         (checkSuggestedNameAndEstimatedSize):
1444         (TestWebKitAPI::TEST):
1445         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
1446         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1447         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1448         (-[MockDragDropSession canLoadObjectsOfClass:]):
1449         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1450         (-[MockDropSession initWithProviders:location:window:allowMove:]):
1451         (-[MockDropSession canCreateItemsOfClass:]):
1452         (-[DragAndDropSimulator _advanceProgress]):
1453         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1454         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1455         * TestWebKitAPI/ios/UIKitSPI.h:
1456
1457 2018-11-17  Chris Dumez  <cdumez@apple.com>
1458
1459         ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver
1460         https://bugs.webkit.org/show_bug.cgi?id=191734
1461         <rdar://problem/46151497>
1462
1463         Reviewed by Ryosuke Niwa.
1464
1465         Add API test coverage.
1466
1467         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1468
1469 2018-11-17  Zalan Bujtas  <zalan@apple.com>
1470
1471         [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
1472         https://bugs.webkit.org/show_bug.cgi?id=191801
1473
1474         Reviewed by Antti Koivisto.
1475
1476         * LayoutReloaded/misc/LFC-passing-tests.txt:
1477
1478 2018-11-17  Jer Noble  <jer.noble@apple.com>
1479
1480         Regression(r233865): Causes synchronous IPC in the middle of layout
1481         https://bugs.webkit.org/show_bug.cgi?id=188307
1482         <rdar://problem/42807306>
1483
1484         Reviewed by Eric Carlson.
1485
1486         Follow-up test fix for r238322:
1487
1488         In ExitFullscreenOnEnterPiP.ElementFullScreen, explicitly make the video
1489         element in element fullscreen the "main content" by playing the video during
1490         a user gesture; only "main content" videos will cause fullscreen mode to exit
1491         when that element is taken into PiP.
1492
1493         In FullscreenZoomInitialFrame.WebKit, the WebView is not visible, so the Page
1494         is considered hidden, and fullscreen is not allowed when the WebView is hidden.
1495         Make the WebView visible by ordering the test window on-screen.
1496
1497         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html:
1498         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1499         (TestWebKitAPI::TEST):
1500         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1501         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1502
1503 2018-11-16  Alex Christensen  <achristensen@webkit.org>
1504
1505         Tweak _showSafeBrowsingWarningWithTitle SPI
1506         https://bugs.webkit.org/show_bug.cgi?id=191799
1507
1508         Reviewed by Wenson Hsieh.
1509
1510         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1511         (TEST):
1512
1513 2018-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1514
1515         REGRESSION (r238294): TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback failing on iOS
1516         https://bugs.webkit.org/show_bug.cgi?id=191783
1517
1518         Reviewed by Chris Dumez.
1519
1520         Allow either WKErrorWebContentProcessTerminated or WKErrorWebViewInvalidated since the test
1521         is closing WebView, thereby invalidating the view, which is racing with the process termination.
1522
1523         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
1524         (TEST):
1525
1526 2018-11-16  Chris Dumez  <cdumez@apple.com>
1527
1528         ProcessSwap.DisableForInspector API test is failing
1529         https://bugs.webkit.org/show_bug.cgi?id=191798
1530
1531         Reviewed by Joseph Pecoraro.
1532
1533         We support process swapping when Web Inspector is shown now so update the
1534         API test accordingly.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1537
1538 2018-11-16  Ryan Haddad  <ryanhaddad@apple.com>
1539
1540         Update buildbot dashboard after Windows 7/10 updates
1541         https://bugs.webkit.org/show_bug.cgi?id=191219
1542
1543         Reviewed by Alexey Proskuryakov.
1544
1545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1546         (BubbleQueueServer):
1547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1549         (WebKitBuildbot):
1550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1551         (table.queue-grid tr.platform td.logo::before):
1552         (table.queue-grid tr.platform.windows-10 td.logo::before):
1553         (table.queue-grid tr.platform.wincairo-windows-10 td.logo::before):
1554         (table.queue-grid tr.platform.windows-7 td.logo::before):
1555         (table.queue-grid tr.platform.wincairo-windows-10 img.logo):
1556
1557 2018-11-16  Chris Dumez  <cdumez@apple.com>
1558
1559         Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
1560         https://bugs.webkit.org/show_bug.cgi?id=191789
1561
1562         Reviewed by Alex Christensen.
1563
1564         Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
1565         SPI no longer works with PSON / Process prewarming.
1566
1567         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1568         (TestWebKitAPI::TEST):
1569
1570 2018-11-16  Jonathan Bedard  <jbedard@apple.com>
1571
1572         webkitpy: Retry app installation on watchOS simulators
1573         https://bugs.webkit.org/show_bug.cgi?id=191769
1574         <rdar://problem/46139850>
1575
1576         Reviewed by Aakash Jain.
1577
1578         * Scripts/webkitpy/xcode/simulated_device.py:
1579         (SimulatedDevice.install_app): Retry app installations.
1580
1581 2018-11-16  Zalan Bujtas  <zalan@apple.com>
1582
1583         Add DidFirstMeaningfulPaint milestone.
1584         https://bugs.webkit.org/show_bug.cgi?id=191754
1585
1586         Reviewed by Simon Fraser.
1587
1588         * TestWebKitAPI/CMakeLists.txt:
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp: Added.
1591         (TestWebKitAPI::didReachMilestone):
1592         (TestWebKitAPI::setPageLoaderClient):
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp: Copied from Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h.
1595         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::FirstMeaningfulPaintMilestoneTest):
1596         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::didCreatePage):
1597
1598 2018-11-16  Takashi Komori  <Takashi.Komori@sony.com>
1599
1600         [WinCairo][WebKitTestRunner] Test contents window is displayed while testing.
1601         https://bugs.webkit.org/show_bug.cgi?id=191593
1602
1603         Reviewed by Alex Christensen.
1604
1605         Hide TestRunner window and taskbar button.
1606
1607         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1608         (WTR::PlatformWebView::PlatformWebView):
1609         (WTR::PlatformWebView::windowSnapshotImage):
1610
1611 2018-11-16  Alex Christensen  <achristensen@webkit.org>
1612
1613         Add API to disable safe browsing checks
1614         https://bugs.webkit.org/show_bug.cgi?id=191610
1615
1616         Reviewed by Dean Jackson.
1617
1618         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1619         (resourceURL):
1620         (TEST):
1621         (safeBrowsingView):
1622         (simpleURL): Deleted.
1623
1624 2018-11-16  Zalan Bujtas  <zalan@apple.com>
1625
1626         [LFC][IFC] Add support for out-of-flow positioned boxes
1627         https://bugs.webkit.org/show_bug.cgi?id=191726
1628
1629         Reviewed by Antti Koivisto.
1630
1631         * LayoutReloaded/misc/LFC-passing-tests.txt:
1632
1633 2018-11-15  Myles C. Maxfield  <mmaxfield@apple.com>
1634
1635         WKPreferencesSetFontSmoothingLevel doesn't actually do anything
1636         https://bugs.webkit.org/show_bug.cgi?id=191708
1637
1638         Reviewed by Simon Fraser.
1639
1640         Delete the symbol because no one calls it and it doesn't do anything
1641
1642         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1643         (TestWebKitAPI::TEST):
1644         * WebKitTestRunner/TestController.cpp:
1645         (WTR::TestController::resetPreferencesToConsistentValues):
1646
1647 2018-11-15  Truitt Savell  <tsavell@apple.com>
1648
1649         Unreviewed, rolling out r238244.
1650
1651         Caused High Sierra test runs to fail early with 50 crashes and
1652         casued 25 API failures.
1653
1654         Reverted changeset:
1655
1656         "[css-logical] Implement flow-relative margin, padding and
1657         border shorthands"
1658         https://bugs.webkit.org/show_bug.cgi?id=188697
1659         https://trac.webkit.org/changeset/238244
1660
1661 2018-11-15  Aakash Jain  <aakash_jain@apple.com>
1662
1663         Increase EWS lock timeout to 3 hours
1664         https://bugs.webkit.org/show_bug.cgi?id=191705
1665
1666         Reviewed by Alexey Proskuryakov.
1667
1668         * QueueStatusServer/config/queues.py: Increased EWS lock timeout to 3 hours.
1669
1670 2018-11-15  Chris Dumez  <cdumez@apple.com>
1671
1672         IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled
1673         https://bugs.webkit.org/show_bug.cgi?id=191671
1674         <rdar://problem/46086062>
1675
1676         Reviewed by Alex Christensen.
1677
1678         Add API test coverage.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1681         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1682         (TEST):
1683
1684 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1685
1686         [css-logical] Implement flow-relative margin, padding and border shorthands
1687         https://bugs.webkit.org/show_bug.cgi?id=188697
1688
1689         Reviewed by Simon Fraser and Antti Koivisto.
1690
1691         * DumpRenderTree/TestOptions.cpp:
1692         (TestOptions::TestOptions):
1693         * DumpRenderTree/TestOptions.h:
1694         * DumpRenderTree/mac/DumpRenderTree.mm:
1695         (setWebPreferencesForTestOptions):
1696         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1697
1698         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1699         (JSONCSSPropertiesChecker.check_codegen_properties):
1700         Allow CSS property definitions to have a 'runtime-flag' parameter which
1701         disables the property when the specified runtime flag is disabled.
1702
1703 2018-11-15  Timothy Hatcher  <timothy@apple.com>
1704
1705         REGRESSION (r238212): WebKit.BackgroundColor* API test failures.
1706         https://bugs.webkit.org/show_bug.cgi?id=191697
1707         rdar://problem/46098570
1708
1709         Reviewed by Dean Jackson.
1710
1711         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
1712         (TestWebKitAPI::TEST): Updated for new default background color.
1713
1714 2018-11-15  Jonathan Bedard  <jbedard@apple.com>
1715
1716         webkitpy: Check for specific process instead of using data migrator (Follow-up fix)
1717         https://bugs.webkit.org/show_bug.cgi?id=191551
1718         <rdar://problem/45993156>
1719
1720         Reviewed by Aakash Jain.
1721
1722         * Scripts/webkitpy/xcode/simulated_device.py:
1723         (SimulatedDevice.is_usable): Use software_variant instead of software_version for watchOS.
1724
1725 2018-11-15  Daniel Bates  <dabates@apple.com>
1726
1727         [iOS] Shift + Tab does not focus previous field
1728         https://bugs.webkit.org/show_bug.cgi?id=191596
1729         <rdar://problem/45892053>
1730
1731         Reviewed by Wenson Hsieh.
1732
1733         Add infrastructure to support testing a key down event with modifiers by creating
1734         and dispatching a UIEvent. This infrastructure replaces the previous mechanism in
1735         Tools/WebKitTestRunner/ios/HIDEventGenerator.mm to generate a IOHIDEvent for a
1736         keydown as it did not support creating an event with modifier key state that would
1737         be recognized by UIKit.
1738
1739         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1740         (WTR::UIScriptController::keyDown):
1741         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1742         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1743         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1744         Add function uiController.keyDown() that takes a character that represents a keyboard key
1745         and an array of modifier keys. The behavior of this function is analogous to eventSender.keyDown().
1746         Remove functions uiController.keyDownUsingHardwareKeyboard() and uiController.keyUpUsingHardwareKeyboard()
1747         as the former is replaced by uiController.keyDown() and the latter was never used.
1748
1749         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1750         (WTR::UIScriptController::keyDown): Added.
1751         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1752         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1753         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1754         * WebKitTestRunner/ios/HIDEventGenerator.h:
1755         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1756         (createHIDKeyDownEvent): Added.
1757         (-[HIDEventGenerator keyDown:completionBlock:]): Deleted.
1758         (-[HIDEventGenerator keyUp:completionBlock:]): Deleted.
1759         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1760         (WTR::arrayLength): Added.
1761         (WTR::parseModifier): Added.
1762         (WTR::parseModifierArray): Added.
1763         (WTR::UIScriptController::keyDown):
1764         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1765         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1766
1767 2018-11-15  Keith Rollin  <krollin@apple.com>
1768
1769         Delete old .xcfilelist files
1770         https://bugs.webkit.org/show_bug.cgi?id=191669
1771         <rdar://problem/46081994>
1772
1773         Reviewed by Chris Dumez.
1774
1775         .xcfilelist files were created and added to the Xcode project files in
1776         https://trac.webkit.org/changeset/238008/webkit. However, they caused
1777         build issues and they were removed from the Xcode projects in
1778         https://trac.webkit.org/changeset/238055/webkit. This check-in removes
1779         the files from the repository altogether. They'll ultimately be
1780         replaced with new files with names that indicate whether the
1781         associated files are inputs to the Run Script phase or are files
1782         created by the Run Script phase.
1783
1784         * DumpRenderTree/DerivedSources.xcfilelist: Removed.
1785         * WebKitTestRunner/DerivedSources.xcfilelist: Removed.
1786
1787 2018-11-14  Zalan Butjas  <zalan@apple.com>
1788
1789         [LFC][IFC] Add support for in-flow positioned inline boxes.
1790         https://bugs.webkit.org/show_bug.cgi?id=191672
1791
1792         Reviewed by Antti Koivisto.
1793
1794         * LayoutReloaded/misc/LFC-passing-tests.txt:
1795
1796 2018-11-14  Keith Rollin  <krollin@apple.com>
1797
1798         Move scripts for Derived and Unified Sources to external files
1799         https://bugs.webkit.org/show_bug.cgi?id=191670
1800         <rdar://problem/46082278>
1801
1802         Reviewed by Keith Miller.
1803
1804         Move the scripts in the Generate Derived Sources and Generate Unified
1805         Sources Run Script phases from the Xcode projects to external shell
1806         script files. Then invoke those scripts from the Run Script phases.
1807         This refactoring is being performed to support later work that will
1808         invoke these scripts in other contexts.
1809
1810         The scripts were maintained as-is when making the move. I did a little
1811         reformatting and added 'set -e' to the top of each file, but that's
1812         it.
1813
1814         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1815         * DumpRenderTree/Scripts/generate-derived-sources.sh: Added.
1816         * WebKitTestRunner/Scripts/generate-derived-sources.sh: Added.
1817         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1818
1819 2018-11-14  Chris Dumez  <cdumez@apple.com>
1820
1821         WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled
1822         https://bugs.webkit.org/show_bug.cgi?id=191640
1823
1824         Reviewed by Alex Christensen.
1825
1826         Add API test coverage.
1827
1828         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1829         (runDecidePolicyForNavigationActionForHyperlinkThatRedirects):
1830         (TEST):
1831
1832 2018-11-14  Chris Dumez  <cdumez@apple.com>
1833
1834         REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
1835         https://bugs.webkit.org/show_bug.cgi?id=191660
1836
1837         Reviewed by Ryosuke Niwa.
1838
1839         The test tries to navigate to an invalid URL and makes sure that we do not process swap
1840         for such load. The test was inherently racing because it was doing:
1841         <body onload="setTimeout(() => alert('DONE'), 0); location.href = 'http://A=a%B=b'">
1842
1843         Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
1844         log an alert, which causes the API test to keep going and check that we did not swap
1845         process. The issue is that a 0 timer may not be sufficient to trigger the load, as
1846         the policy decision is asynchronous and relies on the UIProcess responding to it.
1847
1848         To address the issue, the test now waits for the next policy decision, spins the
1849         run loop and then makes sure we did not swap process. It no longer relies on a message
1850         from the page.
1851
1852         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1853         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1854
1855 2018-11-14  Chris Dumez  <cdumez@apple.com>
1856
1857         WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
1858         https://bugs.webkit.org/show_bug.cgi?id=191638
1859
1860         Reviewed by Alex Christensen.
1861
1862         Add API test coverage.
1863
1864         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1865         (runWebsiteDataStoreCustomPaths):
1866         (TEST):
1867
1868 2018-11-14  Alex Christensen  <achristensen@webkit.org>
1869
1870         Add SPI to show a safe browsing warning
1871         https://bugs.webkit.org/show_bug.cgi?id=191604
1872
1873         Reviewed by Andy Estes.
1874
1875         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1876         (TEST):
1877
1878 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1879
1880         [iOS] A few drag and drop tests are crashing after r238146
1881         https://bugs.webkit.org/show_bug.cgi?id=191617
1882
1883         Reviewed by Dean Jackson.
1884
1885         Augment these crashing tests to verify that selection commands are suppressed during drop over editable elements
1886         via more robust means. These tests currently hit an assertion when revealing the callout bar too early, because
1887         TestWebKitAPI is not a UI application (see <https://webkit.org/b/190401>).
1888
1889         Instead of relying on this other bug, directly ask the text input whether it is suppressing selection commands
1890         during a drop, and remember the answer via DragAndDropSimulator.
1891
1892         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1893         (TestWebKitAPI::TEST):
1894
1895         Add to the existing tests that started failing after r238146.
1896
1897         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1898         * TestWebKitAPI/cocoa/TestWKWebView.h:
1899         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1900         (-[TestWKWebView textInputContentView]):
1901         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1902         (-[DragAndDropSimulator _resetSimulatedState]):
1903         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1904         * TestWebKitAPI/ios/UIKitSPI.h:
1905
1906 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1907
1908         [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
1909         https://bugs.webkit.org/show_bug.cgi?id=191605
1910         <rdar://problem/45813991>
1911
1912         Reviewed by Dean Jackson.
1913
1914         Adds two new API tests to exercise -_pasteAndMatchStyle: and -makeTextWritingDirectionNatural:.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1917         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]): Deleted.
1918         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1919         (TestWebKitAPI::TEST):
1920         * TestWebKitAPI/cocoa/TestWKWebView.h:
1921         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1922
1923         Pull `-_synchronouslyExecuteEditCommand:argument:` out of WKAttachmentTests and into shared code, in a new
1924         category on WKWebView declared in TestWKWebView. Also, fix an unrelated typo in a nearby category.
1925
1926         (-[WKWebView _synchronouslyExecuteEditCommand:argument:]):
1927         * TestWebKitAPI/ios/UIKitSPI.h:
1928
1929 2018-11-14  Chris Dumez  <cdumez@apple.com>
1930
1931         WebKit.ApplicationManifestBasic API test is failing when enabling PSON
1932         https://bugs.webkit.org/show_bug.cgi?id=191602
1933
1934         Reviewed by Alex Christensen.
1935
1936         Add API test coverage.
1937
1938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1939
1940 2018-11-14  Jonathan Bedard  <jbedard@apple.com>
1941
1942         webkitpy: Refactor port code for devices
1943         https://bugs.webkit.org/show_bug.cgi?id=191568
1944         <rdar://problem/46005821>
1945
1946         Reviewed by Alex Christensen.
1947
1948         watchOS and iOS device ports share many characteristics in testing, mostly due
1949         to the fact that both are devices.
1950
1951         * Scripts/webkitpy/port/device_port.py: Added.
1952         (DevicePort): Add base class that all simulated/physical device ports share.
1953         (DevicePort.__init__):
1954         (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
1955         (DevicePort._generate_all_test_configurations): Ditto.
1956         (DevicePort.child_processes): Ditto.
1957         (DevicePort.driver_name): Ditto.
1958         (DevicePort.target_host): Generalize worker access to attached devices and
1959         simulated devices based on the device manager.
1960         (DevicePort.devices): Return a list of all devices associated with this port.
1961         (DevicePort._create_devices):
1962         (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
1963         (DevicePort._install): Moved from iOS port.
1964         (DevicePort.setup_test_run): Ditto.
1965         (DevicePort.clean_up_test_run): Ditto.
1966         (DevicePort.did_spawn_worker): Ditto.
1967         (DevicePort.setup_environ_for_server): Ditto.
1968         * Scripts/webkitpy/port/ios.py:
1969         (IOSPort):
1970         (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
1971         (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
1972         (IOSPort.driver_name): Ditto.
1973         (IOSPort._generate_all_test_configurations): Ditto.
1974         (IOSPort.child_processes): Ditto.
1975         (IOSPort._testing_device): Ditto.
1976         (IOSPort.target_host): Ditto.
1977         (IOSPort._create_devices): Ditto.
1978         (IOSPort.setup_test_run): Ditto.
1979         (IOSPort.clean_up_test_run): Ditto.
1980         (IOSPort.did_spawn_worker): Ditto.
1981         * Scripts/webkitpy/port/ios_device.py:
1982         (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
1983         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
1984         (IOSDevicePort._get_crash_log): Ditto.
1985         (IOSDevicePort.ios_version): Ditto.
1986         (IOSDevicePort._create_devices): Ditto.
1987         (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
1988         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
1989         * Scripts/webkitpy/port/ios_device_unittest.py:
1990         (IOSDeviceTest.test_get_crash_log):
1991         * Scripts/webkitpy/port/ios_simulator.py:
1992         (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
1993         (IOSSimulatorPort._create_devices): Clean up logging statement.
1994         (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
1995         across all devices.
1996         (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
1997         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
1998         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1999         (IOSSimulatorTest.test_32bit):
2000         (IOSSimulatorTest.test_64bit):
2001
2002 2018-11-14  Chris Dumez  <cdumez@apple.com>
2003
2004         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
2005         https://bugs.webkit.org/show_bug.cgi?id=191624
2006
2007         Reviewed by Alex Christensen.
2008
2009         Add API test coverage.
2010
2011         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2012         (runWKHTTPCookieStoreWithoutProcessPool):
2013         (TEST):
2014
2015 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
2016
2017         [WebAuthN] Support CTAP HID authenticators on macOS
2018         https://bugs.webkit.org/show_bug.cgi?id=188623
2019         <rdar://problem/43353777>
2020
2021         Reviewed by Brent Fulgham and Chris Dumez.
2022
2023         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
2024         to hid devices.
2025
2026         * MiniBrowser/MiniBrowser.entitlements:
2027         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2028         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2029
2030 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
2031
2032         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
2033         https://bugs.webkit.org/show_bug.cgi?id=191616
2034
2035         Reviewed by Chris Dumez.
2036
2037         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
2038         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
2039         resulting in the use-after-free.
2040
2041         Made the tests more robust by clearing geolocation provider before exiting each test
2042         since we can't really prevent WKView from entering an autorelease pool.
2043
2044         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
2045         instead of simply the end of the navigation so that the test would continue to work
2046         even if a web content process was created for the second web view (lowAccuracyWebView)
2047
2048         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2049         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
2050         (TestWebKitAPI::clearGeolocationProvider): Added.
2051         (TestWebKitAPI::runJavaScriptAlert): Added.
2052         (TestWebKitAPI::didFinishNavigation): Deleted.
2053         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
2054
2055 2018-11-13  Chris Dumez  <cdumez@apple.com>
2056
2057         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
2058         https://bugs.webkit.org/show_bug.cgi?id=191618
2059
2060         Reviewed by Ryosuke Niwa.
2061
2062         Update API test to explicitly disable automatic process prewarning since it is testing
2063         manual prewarming.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2066         (TEST):
2067
2068 2018-11-13  Chris Dumez  <cdumez@apple.com>
2069
2070         Several Service Worker API tests are failing when enabling PSON
2071         https://bugs.webkit.org/show_bug.cgi?id=191619
2072
2073         Reviewed by Youenn Fablet.
2074
2075         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
2076         not impacted by process prewarming.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2079
2080 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2081
2082         [iOS] Do not show selection UI for editable elements with opacity near zero
2083         https://bugs.webkit.org/show_bug.cgi?id=191442
2084         <rdar://problem/45958625>
2085
2086         Reviewed by Simon Fraser.
2087
2088         Add a couple of new testing helpers to UIScriptController.
2089
2090         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2091         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2092         (WTR::UIScriptController::textSelectionRangeRects const):
2093         (WTR::UIScriptController::selectionCaretViewRect const):
2094         (WTR::UIScriptController::selectionRangeViewRects const):
2095         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2096         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2097         (WTR::UIScriptController::textSelectionRangeRects const):
2098
2099         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
2100         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
2101         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
2102         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
2103         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
2104
2105         Also, drive-by fix a leaked `NSMutableArray`.
2106
2107         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2108         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2109         (WTR::UIScriptController::selectionCaretViewRect const):
2110         (WTR::UIScriptController::selectionRangeViewRects const):
2111
2112         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
2113         rects are also clamped to WKContentView bounds.
2114
2115 2018-11-13  Daniel Bates  <dabates@apple.com>
2116
2117         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
2118         https://bugs.webkit.org/show_bug.cgi?id=173341
2119         <rdar://problem/32752890>
2120
2121         Reviewed by Simon Fraser.
2122
2123         There is little value to making a distinction between forward declarations
2124         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
2125         the contents of these two headers can conflict with each other following
2126         r218275 as DumpRenderTree includes both headers. Instead we should remove
2127         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
2128
2129         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2130         * DumpRenderTree/mac/DumpRenderTree.mm:
2131         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
2132         * WebKitTestRunner/Configurations/Base.xcconfig:
2133         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2134         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2135         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
2136         * WebKitTestRunner/ios/HIDEventGenerator.h:
2137         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2138         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2139         * WebKitTestRunner/ios/TestControllerIOS.mm:
2140         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2141         * WebKitTestRunner/ios/mainIOS.mm:
2142
2143 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
2144
2145         Remove WebKitTestRunnerLib's build warnings.
2146         https://bugs.webkit.org/show_bug.cgi?id=191580
2147
2148         Reviewed by Fujii Hironori.
2149
2150         Include cmakeconfig.h in precompiled header.
2151
2152         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2153
2154 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
2155
2156         Implement Cache API support for WPE/GTK
2157         https://bugs.webkit.org/show_bug.cgi?id=178316
2158
2159         Reviewed by Michael Catanzaro.
2160
2161         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
2162         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
2163
2164         * WebKitTestRunner/TestController.cpp:
2165         (WTR::TestController::generatePageConfiguration):
2166         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2167         (WTR::initializeWebViewConfiguration):
2168
2169 2018-11-12  Christopher Reid  <chris.reid@sony.com>
2170
2171         [Curl] Reject entire cookie if the domain fails a tailmatch.
2172         https://bugs.webkit.org/show_bug.cgi?id=191406
2173
2174         Reviewed by Youenn Fablet.
2175
2176         Added unittests for Curl cookie implementation.
2177
2178         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2179         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
2180
2181 2018-11-12  Alex Christensen  <achristensen@webkit.org>
2182
2183         [iOS] Implement safe browsing in WebKit
2184         https://bugs.webkit.org/show_bug.cgi?id=191441
2185
2186         Reviewed by Tim Horton.
2187
2188         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2189         (checkTitleAndClick):
2190         (TEST):
2191
2192 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
2193
2194         [Curl] Add API Test for Curl cookie backend.
2195         https://bugs.webkit.org/show_bug.cgi?id=191493
2196
2197         Reviewed by Youenn Fablet.
2198
2199         Add unit test to TestWebCore.
2200
2201         * TestWebKitAPI/PlatformWin.cmake:
2202         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
2203
2204 2018-11-12  Tim Horton  <timothy_horton@apple.com>
2205
2206         Make it possible to edit images inline
2207         https://bugs.webkit.org/show_bug.cgi?id=191352
2208         <rdar://problem/30107985>
2209
2210         Reviewed by Dean Jackson.
2211
2212         * WebKitTestRunner/TestController.cpp:
2213         (WTR::updateTestOptionsFromTestHeader):
2214         * WebKitTestRunner/TestOptions.h:
2215         (WTR::TestOptions::hasSameInitializationOptions const):
2216         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2217         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2218         (WTR::TestController::platformCreateWebView):
2219         Add a test option to enable editable images.
2220
2221         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2222         (WTR::UIScriptController::drawSquareInEditableImage):
2223         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2224         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2225         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2226         (WTR::UIScriptController::drawSquareInEditableImage):
2227         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2228         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2229         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
2230         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2231         (WTR::findEditableImageCanvas):
2232         (WTR::UIScriptController::drawSquareInEditableImage):
2233         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2234         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
2235         and also to retrieve the number of strokes currently on the PKCanvasView.
2236         Currently this just takes the first canvas; we might need to make it
2237         take an identifier or something in the future if we need tests with multiple
2238         canvases. The indirect testing mechanism is required because PKCanvasView
2239         can currently not actually paint its strokes in the Simulator.
2240
2241 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
2242
2243         [MediaStream] Screen capture should be an experimental feature on OSX only
2244         https://bugs.webkit.org/show_bug.cgi?id=191552
2245
2246         Unreviewed test gardening.
2247
2248         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
2249
2250 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
2251
2252         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
2253         https://bugs.webkit.org/show_bug.cgi?id=189230
2254         <rdar://problem/44050379>
2255
2256         Reviewed by Joseph Pecoraro.
2257
2258         Runs all png images through zopflipng. This results in a smaller file
2259         size and takes care of this issue as a byproduct.
2260
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
2264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
2272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
2279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
2284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
2287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
2288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
2289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
2292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
2293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
2295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
2296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
2300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
2301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
2302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
2303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
2304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
2305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
2306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
2307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
2308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
2309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
2310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
2311
2312 2018-11-12  Tim Horton  <timothy_horton@apple.com>
2313
2314         Modernize WebKit Tools Xcode projects for localization's sake
2315         https://bugs.webkit.org/show_bug.cgi?id=191495
2316
2317         Reviewed by Alexey Proskuryakov.
2318
2319         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
2320         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2321         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2322         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
2323         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2324         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2325         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2327         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2328         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2329         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2330         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
2331         These are less important because they're not localized, but since
2332         I made the style checker complain, it now complains any time anyone
2333         touches any of these projects... so upgrade them.
2334
2335 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
2336
2337         webkitpy: Check for specific process instead of using data migrator
2338         https://bugs.webkit.org/show_bug.cgi?id=191551
2339         <rdar://problem/45993156>
2340
2341         Rubber-stamped by Aakash Jain.
2342
2343         It's possible for the data migrator process to be stuck, but for a simulator to be
2344         usable. Use device-specific processes to detect when a device is usable.
2345
2346         * Scripts/webkitpy/xcode/simulated_device.py:
2347         (SimulatedDeviceManager._wait_until_device_is_usable):
2348         (SimulatedDeviceManager):
2349         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
2350         since this implies that a device is booted.
2351         (SimulatedDeviceManager.swap): Ditto.
2352         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
2353         process indicating the device is usable can be found.
2354         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
2355         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
2356         it triggers the logic in is_usable()
2357
2358 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
2359
2360         Resurrect WebKitTestRunner for Windows port
2361         https://bugs.webkit.org/show_bug.cgi?id=189257
2362
2363         Reviewed by Fujii Hironori.
2364
2365         Implement WebKitTestRunner for WinCairo.
2366
2367         * PlatformWin.cmake:
2368         * Scripts/build-webkittestrunner:
2369         * WebKitTestRunner/CMakeLists.txt:
2370         * WebKitTestRunner/EventSenderProxy.h:
2371         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2372         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2373         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2374         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2375         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2376         (WTR::rangeToStr):
2377         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2378         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2379         (WTR::TestRunner::TestRunner):
2380         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2381         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
2382         (WTR::AccessibilityController::resetToConsistentState):
2383         (WTR::AccessibilityController::accessibleElementById):
2384         (WTR::AccessibilityController::platformName):
2385         (WTR::AccessibilityController::rootElement):
2386         (WTR::AccessibilityController::focusedElement):
2387         (WTR::AccessibilityController::addNotificationListener):
2388         (WTR::AccessibilityController::removeNotificationListener):
2389         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
2390         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2391         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2392         (WTR::AccessibilityUIElement::isEqual):
2393         (WTR::AccessibilityUIElement::getChildren):
2394         (WTR::AccessibilityUIElement::getChildrenWithRange):
2395         (WTR::AccessibilityUIElement::childrenCount):
2396         (WTR::AccessibilityUIElement::elementAtPoint):
2397         (WTR::AccessibilityUIElement::indexOfChild):
2398         (WTR::AccessibilityUIElement::childAtIndex):
2399         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2400         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2401         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2402         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2403         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2404         (WTR::AccessibilityUIElement::rowAtIndex):
2405         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
2406         (WTR::AccessibilityUIElement::selectedChildrenCount const):
2407         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2408         (WTR::AccessibilityUIElement::titleUIElement):
2409         (WTR::AccessibilityUIElement::parentElement):
2410         (WTR::AccessibilityUIElement::disclosedByRow):
2411         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2412         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2413         (WTR::AccessibilityUIElement::attributesOfChildren):
2414         (WTR::AccessibilityUIElement::allAttributes):
2415         (WTR::AccessibilityUIElement::stringAttributeValue):
2416         (WTR::AccessibilityUIElement::numberAttributeValue):
2417         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2418         (WTR::AccessibilityUIElement::rowHeaders const):
2419         (WTR::AccessibilityUIElement::columnHeaders const):
2420         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
2421         (WTR::AccessibilityUIElement::boolAttributeValue):
2422         (WTR::AccessibilityUIElement::isAttributeSettable):
2423         (WTR::AccessibilityUIElement::isAttributeSupported):
2424         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2425         (WTR::AccessibilityUIElement::role):
2426         (WTR::AccessibilityUIElement::subrole):
2427         (WTR::AccessibilityUIElement::roleDescription):
2428         (WTR::AccessibilityUIElement::computedRoleString):
2429         (WTR::AccessibilityUIElement::title):
2430         (WTR::AccessibilityUIElement::description):
2431         (WTR::AccessibilityUIElement::orientation const):
2432         (WTR::AccessibilityUIElement::stringValue):
2433         (WTR::AccessibilityUIElement::language):
2434         (WTR::AccessibilityUIElement::helpText const):
2435         (WTR::AccessibilityUIElement::x):
2436         (WTR::AccessibilityUIElement::y):
2437         (WTR::AccessibilityUIElement::width):
2438         (WTR::AccessibilityUIElement::height):
2439         (WTR::AccessibilityUIElement::clickPointX):
2440         (WTR::AccessibilityUIElement::clickPointY):
2441         (WTR::AccessibilityUIElement::intValue const):
2442         (WTR::AccessibilityUIElement::minValue):
2443         (WTR::AccessibilityUIElement::maxValue):
2444         (WTR::AccessibilityUIElement::valueDescription):
2445         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2446         (WTR::AccessibilityUIElement::isPressActionSupported):
2447         (WTR::AccessibilityUIElement::isIncrementActionSupported):
2448         (WTR::AccessibilityUIElement::isDecrementActionSupported):
2449         (WTR::AccessibilityUIElement::isEnabled):
2450         (WTR::AccessibilityUIElement::isRequired const):
2451         (WTR::AccessibilityUIElement::isFocused const):
2452         (WTR::AccessibilityUIElement::isSelected const):
2453         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
2454         (WTR::AccessibilityUIElement::isExpanded const):
2455         (WTR::AccessibilityUIElement::isChecked const):
2456         (WTR::AccessibilityUIElement::isIndeterminate const):
2457         (WTR::AccessibilityUIElement::hierarchicalLevel const):
2458         (WTR::AccessibilityUIElement::speakAs):
2459         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
2460         (WTR::AccessibilityUIElement::ariaDropEffects const):
2461         (WTR::AccessibilityUIElement::lineForIndex):
2462         (WTR::AccessibilityUIElement::rangeForLine):
2463         (WTR::AccessibilityUIElement::rangeForPosition):
2464         (WTR::AccessibilityUIElement::boundsForRange):
2465         (WTR::AccessibilityUIElement::stringForRange):
2466         (WTR::AccessibilityUIElement::attributedStringForRange):
2467         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2468         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2469         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2470         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2471         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2472         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2473         (WTR::AccessibilityUIElement::attributesOfColumns):
2474         (WTR::AccessibilityUIElement::attributesOfRows):
2475         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2476         (WTR::AccessibilityUIElement::attributesOfHeader):
2477         (WTR::AccessibilityUIElement::rowCount):
2478         (WTR::AccessibilityUIElement::columnCount):
2479         (WTR::AccessibilityUIElement::indexInTable):
2480         (WTR::AccessibilityUIElement::rowIndexRange):
2481         (WTR::AccessibilityUIElement::columnIndexRange):
2482         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2483         (WTR::AccessibilityUIElement::horizontalScrollbar const):
2484         (WTR::AccessibilityUIElement::verticalScrollbar const):
2485         (WTR::AccessibilityUIElement::selectedTextRange):
2486         (WTR::AccessibilityUIElement::setSelectedTextRange):
2487         (WTR::AccessibilityUIElement::increment):
2488         (WTR::AccessibilityUIElement::decrement):
2489         (WTR::AccessibilityUIElement::showMenu):
2490         (WTR::AccessibilityUIElement::press):
2491         (WTR::AccessibilityUIElement::setSelectedChild const):
2492         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
2493         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
2494         (WTR::AccessibilityUIElement::clearSelectedChildren const):
2495         (WTR::AccessibilityUIElement::accessibilityValue const):
2496         (WTR::AccessibilityUIElement::documentEncoding):
2497         (WTR::AccessibilityUIElement::documentURI):
2498         (WTR::AccessibilityUIElement::url):
2499         (WTR::AccessibilityUIElement::addNotificationListener):
2500         (WTR::AccessibilityUIElement::removeNotificationListener):
2501         (WTR::AccessibilityUIElement::isFocusable const):
2502         (WTR::AccessibilityUIElement::isSelectable const):
2503         (WTR::AccessibilityUIElement::isMultiSelectable const):
2504         (WTR::AccessibilityUIElement::isVisible const):
2505         (WTR::AccessibilityUIElement::isOffScreen const):
2506         (WTR::AccessibilityUIElement::isCollapsed const):
2507         (WTR::AccessibilityUIElement::isIgnored const):
2508         (WTR::AccessibilityUIElement::isSingleLine const):
2509         (WTR::AccessibilityUIElement::isMultiLine const):
2510         (WTR::AccessibilityUIElement::hasPopup const):
2511         (WTR::AccessibilityUIElement::takeFocus):
2512         (WTR::AccessibilityUIElement::takeSelection):
2513         (WTR::AccessibilityUIElement::addSelection):
2514         (WTR::AccessibilityUIElement::removeSelection):
2515         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2516         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2517         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2518         (WTR::AccessibilityUIElement::previousTextMarker):
2519         (WTR::AccessibilityUIElement::nextTextMarker):
2520         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2521         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2522         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2523         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2524         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2525         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2526         (WTR::AccessibilityUIElement::textMarkerForPoint):
2527         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2528         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
2529         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
2530         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2531         (WTR::AccessibilityUIElement::indexForTextMarker):
2532         (WTR::AccessibilityUIElement::isTextMarkerValid):
2533         (WTR::AccessibilityUIElement::textMarkerForIndex):
2534         (WTR::AccessibilityUIElement::startTextMarker):
2535         (WTR::AccessibilityUIElement::endTextMarker):
2536         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2537         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2538         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2539         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2540         (WTR::AccessibilityUIElement::supportedActions const):
2541         (WTR::AccessibilityUIElement::pathDescription const):
2542         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
2543         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
2544         (WTR::AccessibilityUIElement::classList const):
2545         (WTR::AccessibilityUIElement::characterAtOffset):
2546         (WTR::AccessibilityUIElement::wordAtOffset):
2547         (WTR::AccessibilityUIElement::lineAtOffset):
2548         (WTR::AccessibilityUIElement::sentenceAtOffset):
2549         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
2550         (WTR::activateFonts):
2551         (WTR::installFakeHelvetica):
2552         (WTR::uninstallFakeHelvetica):
2553         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
2554         (WTR::InjectedBundle::platformInitialize):
2555         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
2556         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
2557         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
2558         (WTR::TestRunner::pathToLocalResource):
2559         (WTR::TestRunner::inspectorTestStubURL):
2560         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2561         (WTR::TestRunner::platformInitialize):
2562         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2563         (WTR::TestRunner::installFakeHelvetica):
2564         * WebKitTestRunner/PlatformWebView.h:
2565         * WebKitTestRunner/PlatformWin.cmake: Added.
2566         * WebKitTestRunner/TestController.cpp:
2567         (WTR::TestController::resetStateToConsistentValues):
2568         (WTR::createTestURL):
2569         * WebKitTestRunner/TestInvocation.cpp:
2570         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2571         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
2572         (WTR::EventSenderProxy::EventSenderProxy):
2573         (WTR::EventSenderProxy::~EventSenderProxy):
2574         (WTR::EventSenderProxy::mouseDown):
2575         (WTR::EventSenderProxy::mouseUp):
2576         (WTR::EventSenderProxy::mouseMoveTo):
2577         (WTR::EventSenderProxy::mouseScrollBy):
2578         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2579         (WTR::EventSenderProxy::continuousMouseScrollBy):
2580         (WTR::EventSenderProxy::leapForward):
2581         (WTR::EventSenderProxy::keyDown):
2582         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
2583         (WTR::registerWindowClass):
2584         (WTR::PlatformWebView::PlatformWebView):
2585         (WTR::PlatformWebView::~PlatformWebView):
2586         (WTR::PlatformWebView::resizeTo):
2587         (WTR::PlatformWebView::page):
2588         (WTR::PlatformWebView::focus):
2589         (WTR::PlatformWebView::windowFrame):
2590         (WTR::PlatformWebView::setWindowFrame):
2591         (WTR::PlatformWebView::didInitializeClients):
2592         (WTR::PlatformWebView::addChromeInputField):
2593         (WTR::PlatformWebView::removeChromeInputField):
2594         (WTR::PlatformWebView::addToWindow):
2595         (WTR::PlatformWebView::removeFromWindow):
2596         (WTR::PlatformWebView::setWindowIsKey):
2597         (WTR::PlatformWebView::makeWebViewFirstResponder):
2598         (WTR::generateCairoSurfaceFromBitmap):
2599         (WTR::PlatformWebView::windowSnapshotImage):
2600         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2601         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2602         (WTR::PlatformWebView::forceWindowFramesChanged):
2603         (WTR::PlatformWebView::drawsBackground const):
2604         (WTR::PlatformWebView::setDrawsBackground):
2605         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
2606         (WTR::exceptionFilter):
2607         (WTR::runRunLoopUntil):
2608         (WTR::TestController::notifyDone):
2609         (WTR::TestController::setHidden):
2610         (WTR::TestController::platformInitialize):
2611         (WTR::TestController::platformPreferences):
2612         (WTR::TestController::platformDestroy):
2613         (WTR::toWK):
2614         (WTR::TestController::platformInitializeContext):
2615         (WTR::TestController::platformRunUntil):
2616         (WTR::TestController::platformDidCommitLoadForFrame):
2617         (WTR::TestController::initializeInjectedBundlePath):
2618         (WTR::TestController::initializeTestPluginDirectory):
2619         (WTR::TestController::runModal):
2620         (WTR::TestController::platformContext):
2621         (WTR::TestController::platformLibraryPathForTesting):
2622         (WTR::TestController::platformConfigureViewForTest):
2623         (WTR::TestController::platformResetPreferencesToConsistentValues):
2624         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
2625         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
2626         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
2627         (dllLauncherEntryPoint):
2628
2629 2018-11-12  Alicia Boya García  <aboya@igalia.com>
2630
2631         [MSE][GStreamer] Introduce AbortableTaskQueue
2632         https://bugs.webkit.org/show_bug.cgi?id=190902
2633
2634         Reviewed by Xabier Rodriguez-Calvar.
2635
2636         Tests for AbortableTaskQueue are included.
2637
2638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2639         * TestWebKitAPI/PlatformGTK.cmake:
2640         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
2641         (TestWebKitAPI::TEST):
2642         (TestWebKitAPI::FancyResponse::FancyResponse):
2643         (TestWebKitAPI::FancyResponse::operator=):
2644         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
2645         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
2646         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
2647         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
2648
2649 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2650
2651         run-bindings-tests is timing out in some WinCairo bots
2652         https://bugs.webkit.org/show_bug.cgi?id=191348
2653
2654         Reviewed by Alex Christensen.
2655
2656         BuildBot kills run-bindings-tests if it outputs nothing for 20
2657         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
2658         and it takes more than 30 minutes to finish. And, Windows Python
2659         buffers the progress output.
2660
2661         * Scripts/webkitpy/bindings/main.py:
2662         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
2663         test case result is output.
2664
2665 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2666
2667         Implement a new edit command to change the enclosing list type
2668         https://bugs.webkit.org/show_bug.cgi?id=191487
2669         <rdar://problem/45955922>
2670
2671         Reviewed by Ryosuke Niwa.
2672
2673         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
2674         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
2675
2676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2677         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2678         (-[TestWKWebView setPosition:offset:]):
2679         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
2680         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
2681         (TestWebKitAPI::TEST):
2682         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
2683
2684 2018-11-11  Dan Bernstein  <mitz@apple.com>
2685
2686         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
2687         https://bugs.webkit.org/show_bug.cgi?id=191514
2688
2689         Reviewed by Geoffrey Garen.
2690
2691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2692         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
2693         (TEST):
2694
2695 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2696
2697         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2698         https://bugs.webkit.org/show_bug.cgi?id=191492
2699
2700         Reviewed by Alex Christensen.
2701
2702         Update file name.
2703
2704         * DumpRenderTree/mac/DumpRenderTree.mm:
2705         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2706         * WebKitTestRunner/mac/TestControllerMac.mm:
2707
2708 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2709
2710         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2711         https://bugs.webkit.org/show_bug.cgi?id=191492
2712
2713         Reviewed by Alex Christensen.
2714
2715         * DumpRenderTree/mac/DumpRenderTree.mm:
2716         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2717         * WebKitTestRunner/mac/TestControllerMac.mm:
2718
2719 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
2720
2721         Unreviewed, rolling out r238065.
2722
2723         Breaks internal builds.
2724
2725         Reverted changeset:
2726
2727         "Make it possible to edit images inline"
2728         https://bugs.webkit.org/show_bug.cgi?id=191352
2729         https://trac.webkit.org/changeset/238065
2730
2731 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2732
2733         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
2734         https://bugs.webkit.org/show_bug.cgi?id=191221
2735
2736         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
2737         that it is disabled, but we're testing that it is enabled, because I failed to update this
2738         line.
2739
2740         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2741         (testWebKitSettings):
2742
2743 2018-11-10  Tim Horton  <timothy_horton@apple.com>
2744
2745         Make it possible to edit images inline
2746         https://bugs.webkit.org/show_bug.cgi?id=191352
2747         <rdar://problem/30107985>
2748
2749         Reviewed by Dean Jackson.
2750
2751         * WebKitTestRunner/TestController.cpp:
2752         (WTR::updateTestOptionsFromTestHeader):
2753         * WebKitTestRunner/TestOptions.h:
2754         (WTR::TestOptions::hasSameInitializationOptions const):
2755         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2756         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2757         (WTR::TestController::platformCreateWebView):
2758         Add a test option to enable editable images.
2759
2760         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2761         (WTR::UIScriptController::drawSquareInEditableImage):
2762         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2763         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2764         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2765         (WTR::UIScriptController::drawSquareInEditableImage):
2766         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2767         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2768         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
2769         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2770         (WTR::findEditableImageCanvas):
2771         (WTR::UIScriptController::drawSquareInEditableImage):
2772         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2773         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
2774         and also to retrieve the number of strokes currently on the PKCanvasView.
2775         Currently this just takes the first canvas; we might need to make it
2776         take an identifier or something in the future if we need tests with multiple
2777         canvases. The indirect testing mechanism is required because PKCanvasView
2778         can currently not actually paint its strokes in the Simulator.
2779
2780 2018-11-09  Chris Dumez  <cdumez@apple.com>
2781
2782         Suspended page persists even after back/forward list item is gone
2783         https://bugs.webkit.org/show_bug.cgi?id=191488
2784         <rdar://problem/45953006>
2785
2786         Reviewed by Geoffrey Garen.
2787
2788         Add API test coverage.
2789
2790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2791
2792 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2793
2794         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
2795         https://bugs.webkit.org/show_bug.cgi?id=191471
2796         <rdar://problem/45952472>
2797
2798         Reviewed by Tim Horton.
2799
2800         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
2801
2802         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2803         (TestWebKitAPI::webViewForEditActionTesting):
2804         (TestWebKitAPI::TEST):
2805
2806 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
2807
2808         [Curl][WebKit] Implement Proxy configuration API.
2809         https://bugs.webkit.org/show_bug.cgi?id=189053
2810
2811         Reviewed by Youenn Fablet.
2812
2813         Added Proxy Settings dialog to call newly added API.
2814
2815         * MiniBrowser/win/BrowserWindow.h:
2816         * MiniBrowser/win/Common.cpp:
2817         (askProxySettings):
2818         (askCredential):
2819         (authDialogProc): Deleted.
2820         * MiniBrowser/win/Common.h:
2821         * MiniBrowser/win/DialogHelper.h: Added.
2822         (Dialog::run):
2823         (Dialog::doalogProc):
2824         (Dialog::handle):
2825         (Dialog::setup):
2826         (Dialog::update):
2827         (Dialog::validate):
2828         (Dialog::updateOkButton):
2829         (Dialog::command):
2830         (Dialog::ok):
2831         (Dialog::cancel):
2832         (Dialog::close):
2833         (Dialog::hDlg):
2834         (Dialog::item):
2835         (Dialog::setEnabled):
2836         (Dialog::setText):
2837         (Dialog::getText):
2838         (Dialog::getTextLength):
2839         (Dialog::RadioGroup::RadioGroup):
2840         (Dialog::RadioGroup::set):
2841         (Dialog::RadioGroup::get):
2842         (Dialog::radioGroup):
2843         * MiniBrowser/win/MainWindow.cpp:
2844         (MainWindow::WndProc):
2845         * MiniBrowser/win/MiniBrowserLib.rc:
2846         * MiniBrowser/win/MiniBrowserLibResource.h:
2847         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2848         (createWKURL):
2849         (WebKitBrowserWindow::WebKitBrowserWindow):
2850         (WebKitBrowserWindow::updateProxySettings):
2851         (WebKitBrowserWindow::loadURL):
2852         (WebKitBrowserWindow::loadHTMLString):
2853         (WebKitBrowserWindow::openProxySettings):
2854         * MiniBrowser/win/WebKitBrowserWindow.h:
2855         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2856         (WebKitLegacyBrowserWindow::openProxySettings):
2857         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2858
2859 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2860
2861         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
2862         https://bugs.webkit.org/show_bug.cgi?id=191410
2863         <rdar://problem/45898610>
2864
2865         Reviewed by Dean Jackson.
2866
2867         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
2868         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
2869         hooked up to their respective editing commands.
2870
2871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2872         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
2873         (-[TestWKWebView querySelectorExists:]):
2874         (-[TestWKWebView insertString:]):
2875
2876         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
2877         invoking the WKWebView directly on macOS and calling on the content view on iOS.
2878
2879         (TestWebKitAPI::webViewForEditActionTesting):
2880         (TestWebKitAPI::TEST):
2881
2882 2018-11-09  Philippe Normand  <pnormand@igalia.com>
2883
2884         [Flatpak] Refactoring and drive-by fixes
2885         https://bugs.webkit.org/show_bug.cgi?id=191421
2886
2887         Reviewed by Michael Catanzaro.
2888
2889         * Scripts/webkitdirs.pm:
2890         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
2891         the sandbox, so rely on this.
2892         * flatpak/flatpakutils.py:
2893         (expand_manifest): Pass explicit keywords to load_manifest() and
2894         remove unused local variable.
2895         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
2896         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
2897         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
2898         build_type handling a bit.
2899         * flatpak/org.webkit.CommonModules.yaml: Added.
2900         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
2901         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
2902         declaration to CommonModules, so it can be reused later when we
2903         add support for building extra libraries depending on WPE.
2904
2905 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2906
2907 onal supported image formats
2908         https://bugs.webkit.org/show_bug.cgi?id=190454
2909
2910         Reviewed by Simon Fraser.
2911
2912         Test opening a TGA image in WebView which is not allowed by default. The
2913         TGA format will be allowed through WKWebViewConfiguration.
2914
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2916         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
2917         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
2918         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
2919         (runTest):
2920         (TEST):
2921
2922 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2923
2924         Unreviewed, a proper build fix for r237983
2925
2926         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
2927
2928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2929         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
2930         (TestWebKitAPI::TEST):
2931         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
2932         (TestWebKitAPI::getTestCorruptedSignResponse):
2933         (TestWebKitAPI::getTestCredentialRawIdBytes):
2934         (TestWebKitAPI::convertToVector):
2935         (TestWebKitAPI::TEST):
2936
2937 2018-11-08  Keith Rollin  <krollin@apple.com>
2938
2939         Create .xcfilelist files
2940         https://bugs.webkit.org/show_bug.cgi?id=191324
2941         <rdar://problem/45852819>
2942
2943         Reviewed by Alex Christensen.
2944
2945         As part of preparing for enabling XCBuild, create and use .xcfilelist
2946         files. These files are using during Run Script build phases in an
2947         Xcode project. If a Run Script build phase produces new files that are
2948         used later as inputs to subsequent build phases, XCBuild needs to know
2949         about these files. These files can be either specified in an "output
2950         files" section of the Run Script phase editor, or in .xcfilelist files
2951         that are associated with the Run Script build phase.
2952
2953         This patch takes the second approach. It consists of three sets of changes:
2954
2955         - Modify the DerivedSources.make files to have a
2956           'print_all_generated_files" target that produces a list of the files
2957           they create.
2958
2959         - Create a shell script that produces .xcfilelist files from the
2960           output of the previous step, as well as for the files created in the
2961           Generate Unified Sources build steps.
2962
2963         - Add the new .xcfilelist files to the associated projects.
2964
2965         Note that, with these changes, the Xcode workspace and projects can no
2966         longer be fully loaded into Xcode 9. Xcode will attempt to load the
2967         projects that have .xcfilelist files associated with them, but will
2968         fail and display a placeholder for those projects instead. It's
2969         expected that all developers are using Xcode 10 by now and that not
2970         being able to load into Xcode 9 is not a practical issue. Keep in mind
2971         that this is strictly an IDE issue, and that the projects can still be
2972         built with `xcodebuild`.
2973
2974         Also note that the shell script that creates the .xcfilelist files can
2975         also be used to verify that the set of files that's currently checked
2976         in is up-to-date. This checking can be used as part of a check-in hook
2977         or part of check-webkit-style to sooner catch cases where the
2978         .xcfilelist files need to be regenerated.
2979
2980         * DumpRenderTree/DerivedSources.make:
2981         * DumpRenderTree/DerivedSources.xcfilelist: Added.
2982         * Scripts/generate-xcfilelists: Added.
2983         * WebKitTestRunner/DerivedSources.make:
2984         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
2985
2986 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2987
2988         Unreviewed, a quick build fix for r237983
2989
2990         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
2991
2992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
2993         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
2994         (TestWebKitAPI::TEST):
2995         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
2996         (TestWebKitAPI::getTestCorruptedSignResponse):
2997         (TestWebKitAPI::getTestCredentialRawIdBytes):
2998         (TestWebKitAPI::convertToVector):
2999         (TestWebKitAPI::TEST):
3000
3001 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
3002
3003         Fix steps_unittest.py failures related to recent Win10/Win7 changes
3004         https://bugs.webkit.org/show_bug.cgi?id=191290
3005
3006         Reviewed by Alexey Proskuryakov.
3007
3008         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
3009
3010 2018-11-08  Dean Jackson  <dino@apple.com>
3011
3012         Add a String literal that returns a String
3013         https://bugs.webkit.org/show_bug.cgi?id=191425
3014         <rdar://problem/45914556>
3015
3016         Reviewed by Sam Weinig.
3017
3018         Test _str.
3019
3020         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3021         (TestWebKitAPI::TEST):
3022
3023 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
3024
3025         webkitpy: Generalize trailing SDK specifier (Part 2)
3026         https://bugs.webkit.org/show_bug.cgi?id=191275
3027         <rdar://problem/45703660>
3028
3029         Rubber-stamped by Aakash Jain.
3030
3031         Re-landing this change, configuration issues have been resolved.
3032
3033         * Scripts/webkitpy/port/ios_device.py:
3034         (IOSDevicePort): Use normalized SDK.
3035         * Scripts/webkitpy/port/ios_simulator.py:
3036         (IOSSimulatorPort): Use normalized SDK.
3037         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
3038
3039 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
3040
3041         [WebAuthN] Import CTAP device request/response converters from Chromium
3042         https://bugs.webkit.org/show_bug.cgi?id=190784
3043         <rdar://problem/45460333>
3044
3045         Reviewed by Brent Fulgham.
3046
3047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3048         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
3049         (TestWebKitAPI::TEST):
3050         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
3051         (TestWebKitAPI::TEST):
3052         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
3053         (TestWebKitAPI::getTestCorruptedSignResponse):
3054         (TestWebKitAPI::getTestCredentialRawIdBytes):
3055         (TestWebKitAPI::convertToVector):
3056         (TestWebKitAPI::TEST):
3057         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
3058
3059 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
3060
3061         [BigInt] Add support to BigInt into ValueAdd
3062         https://bugs.webkit.org/show_bug.cgi?id=186177
3063
3064         Reviewed by Keith Miller.
3065
3066         * Scripts/run-jsc-benchmarks:
3067
3068 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
3069
3070         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
3071         https://bugs.webkit.org/show_bug.cgi?id=191326
3072         <rdar://problem/45769269>
3073
3074         Reviewed by Geoffrey Garen.
3075
3076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3077         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
3078         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
3079         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
3080         (TEST):
3081
3082 2018-11-07  Daniel Bates  <dabates@apple.com>
3083
3084         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
3085         https://bugs.webkit.org/show_bug.cgi?id=190141
3086
3087         Reviewed by Darin Adler.
3088
3089         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
3090         runs deterministic regardless of whether a hardware keyboard is attached.
3091
3092         * DumpRenderTree/mac/DumpRenderTree.mm:
3093         (overrideIsInHardwareKeyboardMode): Added.
3094         (prepareConsistentTestingEnvironment):
3095         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
3096         * WebKitTestRunner/ios/TestControllerIOS.mm:
3097         (overrideIsInHardwareKeyboardMode): Added.
3098         (WTR::TestController::platformInitialize):
3099
3100 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
3101
3102         Unreviewed, rolling out r237913.
3103
3104         Breaks running tests on Mac without iOS SDK installed
3105
3106         Reverted changeset:
3107
3108         "webkitpy: Generalize trailing SDK specifier (Part 2)"
3109         https://bugs.webkit.org/show_bug.cgi?id=191275
3110         https://trac.webkit.org/changeset/237913
3111
3112 2018-11-07  Zamiul Haque  <zhaque@apple.com>
3113
3114         Force a gregorian calendar to show for credit card expiration date inputs
3115         (autocomplete='cc-exp'*) regardless of default system settings.
3116         https://bugs.webkit.org/show_bug.cgi?id=191096
3117         rdar://problem/42640256
3118
3119         Reviewed by Tim Horton.
3120
3121         Implemented simulateForeignDefaultCalendar and calendarType to be used
3122         for changing the default calendar returned by the system (ie. [NSCalendar
3123         currentCalendar]) and getting the calendar type identifier of a presented date
3124         picker.
3125
3126         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3127         (WTR::UIScriptController::isShowingDataListSuggestions const):
3128         (WTR::UIScriptController::calendarType const):
3129         (WTR::UIScriptController::setDefaultCalendarType):
3130         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3131         (WTR::UIScriptController::calendarType const):
3132         (WTR::UIScriptController::setDefaultCalendarType):
3133         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3134         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3135         (WTR::UIScriptController::calendarType const): Deleted.
3136         * WebKitTestRunner/TestController.cpp:
3137         * WebKitTestRunner/TestController.h:
3138         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3139         (WTR::UIScriptController::calendarType const):
3140         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3141         (WTR::swizzledCalendar):
3142         (WTR::TestController::getOverriddenCalendarIdentifier const):
3143         (WTR::TestController::setDefaultCalendarType):
3144         (WTR::TestController::cocoaResetStateToConsistentValues):
3145         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3146         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3147         (WTR::UIScriptController::calendarType const): Deleted.
3148
3149 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
3150
3151         webkitpy: Boot a single worker for custom devices
3152         https://bugs.webkit.org/show_bug.cgi?id=191312
3153         <rdar://problem/45848717>
3154
3155         Rubber-stamped by Aakash Jain.
3156
3157         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3158         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
3159         simulators is expensive and unneeded for these tests.
3160         * Scripts/webkitpy/port/ios.py:
3161         (IOSPort. child_processes): No reason to memoize this call, and it prevents
3162         overriding the number of child processes when booting custom devices.
3163
3164 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
3165
3166         webkitpy: Generalize trailing SDK specifier (Part 2)
3167         https://bugs.webkit.org/show_bug.cgi?id=191275
3168         <rdar://problem/45703660>
3169
3170         Reviewed by Aakash Jain.
3171
3172         * Scripts/webkitpy/port/ios_device.py:
3173         (IOSDevicePort): Use normalized SDK.
3174         * Scripts/webkitpy/port/ios_simulator.py:
3175         (IOSSimulatorPort): Use normalized SDK.
3176         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
3177
3178 2018-11-06  Justin Fan  <justin_fan@apple.com>
3179
3180         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
3181         https://bugs.webkit.org/show_bug.cgi?id=191291
3182
3183         Reviewed by Myles Maxfield.
3184
3185         Properly disable WEBGPU on all non-Metal platforms for now.
3186
3187         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3188
3189 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
3190
3191         [ews-app] Add URL configuration for OpenSource EWS Django app
3192         https://bugs.webkit.org/show_bug.cgi?id=191132
3193
3194         Rubber-stamped by Lucas Forschler.
3195
3196         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
3197         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
3198
3199 2018-11-06  Youenn Fablet  <youenn@apple.com>
3200
3201         Make mDNS ICE Candidate an experimental flag again
3202         https://bugs.webkit.org/show_bug.cgi?id=191262
3203
3204         Reviewed by Dean Jackson.
3205
3206         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3208         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
3209         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
3210         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3211
3212 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
3213
3214         [ews-app] Add views for OpenSource EWS Django app
3215         https://bugs.webkit.org/show_bug.cgi?id=191131
3216
3217         Rubber-stamped by Lucas Forschler.
3218
3219         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
3220         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3221         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
3222         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
3223
3224 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
3225
3226         [ews-app] Add models for OpenSource EWS Django app
3227         https://bugs.webkit.org/show_bug.cgi?id=191123
3228
3229         Reviewed by Lucas Forschler.
3230
3231         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3232         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
3233         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
3234         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3235         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
3236
3237 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
3238
3239         [ews-app] Fix Invalid HTTP_HOST header
3240         https://bugs.webkit.org/show_bug.cgi?id=191325
3241
3242         Reviewed by Lucas Forschler.
3243
3244         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
3245
3246         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3247
3248 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
3249
3250         [ews-app] Rename EWS_app to ews-app - part 2
3251         https://bugs.webkit.org/show_bug.cgi?id=191317
3252
3253         Reviewed by Lucas Forschler.
3254
3255         * BuildSlaveSupport/ews-app/EWS_app: Removed.
3256         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
3257         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3258         * BuildSlaveSupport/ews-app/ews-app/urls.py:
3259         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
3260         * BuildSlaveSupport/ews-app/manage.py:
3261
3262 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
3263
3264         [ews-app] Rename EWS_app to ews-app - part 1
3265         https://bugs.webkit.org/show_bug.cgi?id=191317
3266
3267         Reviewed by Lucas Forschler.
3268
3269         * BuildSlaveSupport/EWS_app: Removed.
3270         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
3271
3272 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
3273
3274         Spelling dots are drawn in the wrong place
3275         https://bugs.webkit.org/show_bug.cgi?id=190764
3276
3277         Reviewed by Dean Jackson.
3278
3279         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
3280         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
3281         dots to be drawn.
3282
3283         * WebKitTestRunner/TestController.cpp:
3284         (WTR::TestController::resetStateToConsistentValues):
3285         (WTR::updateTestOptionsFromTestHeader):
3286         (WTR::TestController::platformResetStateToConsistentValues):
3287         * WebKitTestRunner/TestController.h:
3288         * WebKitTestRunner/TestOptions.h:
3289         (WTR::TestOptions::hasSameInitializationOptions const):
3290         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3291         (WTR::TestController::cocoaResetStateToConsistentValues):
3292         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3293         * WebKitTestRunner/ios/TestControllerIOS.mm:
3294         (WTR::TestController::platformResetStateToConsistentValues):
3295         * WebKitTestRunner/mac/TestControllerMac.mm:
3296         (WTR::TestController::platformResetStateToConsistentValues):
3297
3298 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
3299
3300         Feature flags not present for Visual Studio when using build-webkit
3301         https://bugs.webkit.org/show_bug.cgi?id=191288
3302
3303         Reviewed by Fujii Hironori.
3304
3305         Passes feature flags to Visual studio builds within build-webkit.
3306         Removes cmakeBasedPortArguments as it is no longer in use.
3307
3308         * Scripts/build-jsc:
3309         * Scripts/build-webkit:
3310         * Scripts/webkitdirs.pm:
3311         (cmakeBasedPortArguments): Deleted.
3312
3313 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
3314
3315         REGRESSION (r230523): Caps lock indicator not shown in password field
3316         https://bugs.webkit.org/show_bug.cgi?id=190056
3317
3318         Reviewed by Ryosuke Niwa.
3319
3320         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3321         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3322         (WTR::TestRunner::toggleCapsLock):
3323         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3324         * WebKitTestRunner/TestController.h:
3325         * WebKitTestRunner/TestInvocation.cpp:
3326         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3327         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3328         (WTR::TestController::toggleCapsLock):
3329
3330 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
3331
3332         IndexedDB: WAL file keeps growing
3333         https://bugs.webkit.org/show_bug.cgi?id=191294
3334         <rdar://problem/41333493>
3335
3336         Reviewed by Chris Dumez.
3337
3338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3339         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
3340         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
3341         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
3342         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
3343         (TEST):
3344
3345 2018-11-06  Alex Christensen  <achristensen@webkit.org>
3346
3347         Fix tests after r237863
3348         https://bugs.webkit.org/show_bug.cgi?id=191315
3349
3350         Reviewed by Chris Dumez.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3353         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
3354         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
3355         to verify that main2.html eventually loads, making this test less timing dependent.
3356
3357 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
3358
3359         Unreviewed, rolling out r237834.
3360
3361         Tests for this change crash on iOS Simulator
3362
3363         Reverted changeset:
3364
3365         "Spelling dots are drawn in the wrong place"
3366         https://bugs.webkit.org/show_bug.cgi?id=190764
3367         https://trac.webkit.org/changeset/237834
3368
3369 2018-11-05  Alex Christensen  <achristensen@webkit.org>
3370
3371         [Mac] Implement safe browsing in WebKit
3372         https://bugs.webkit.org/show_bug.cgi?id=188871
3373
3374         Reviewed by Tim Horton.
3375
3376         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3377         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
3378         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
3379         (-[TestLookupContext lookUpURL:completionHandler:]):
3380         (simpleURL):
3381         (safeBrowsingView):
3382         (TEST):
3383         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
3384         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
3385         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
3386         * TestWebKitAPI/Utilities.h:
3387
3388 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
3389
3390         webkitpy: Generalize trailing SDK specifier (Part 1)
3391         https://bugs.webkit.org/show_bug.cgi?id=191275
3392         <rdar://problem/45703660>
3393
3394         Reviewed by Lucas Forschler.
3395
3396         * Scripts/webkitpy/common/system/platforminfo.py:
3397         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
3398         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3399         (TestPlatformInfo):
3400         (TestPlatformInfo.test_available_sdks):
3401
3402 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
3403
3404         Spelling dots are drawn in the wrong place
3405         https://bugs.webkit.org/show_bug.cgi?id=190764
3406
3407         Reviewed by Dean Jackson.
3408
3409         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
3410         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
3411         dots to be drawn.
3412
3413         * WebKitTestRunner/TestController.cpp:
3414         (WTR::TestController::resetStateToConsistentValues):
3415         (WTR::updateTestOptionsFromTestHeader):
3416         (WTR::TestController::platformResetStateToConsistentValues):
3417         * WebKitTestRunner/TestController.h:
3418         * WebKitTestRunner/TestOptions.h:
3419         (WTR::TestOptions::hasSameInitializationOptions const):
3420         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3421         (WTR::TestController::cocoaResetStateToConsistentValues):
3422         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3423         * WebKitTestRunner/ios/TestControllerIOS.mm:
3424         (WTR::TestController::platformResetStateToConsistentValues):
3425         * WebKitTestRunner/mac/TestControllerMac.mm:
3426         (WTR::TestController::platformResetStateToConsistentValues):
3427
3428 2018-11-05  Chris Dumez  <cdumez@apple.com>
3429
3430         Use same limit for page cache and suspended pages
3431         https://bugs.webkit.org/show_bug.cgi?id=191266
3432
3433         Reviewed by Geoffrey Garen.
3434
3435         Update API tests accordingly.
3436
3437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3438
3439 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3440
3441         [style] Exclude style check for auto generated files.
3442         https://bugs.webkit.org/show_bug.cgi?id=191118
3443
3444         Reviewed by Eric Carlson.
3445
3446         Some files checked in to the repository are generated by other tools. In this patch,
3447         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
3448         VisualStudio.
3449
3450         There's no need to check these files because it's not practical to fix the style errors
3451         or it's hard to maintain those fixes.
3452
3453         * Scripts/webkitpy/style/checkers/cpp.py:
3454         (is_generated_file):
3455         (CppChecker.check):
3456
3457 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
3458
3459         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
3460         https://bugs.webkit.org/show_bug.cgi?id=190680
3461
3462         Reviewed by Philippe Normand.
3463
3464         * flatpak/org.webkit.WebKit.yaml:
3465
3466 2018-11-05  Daniel Bates  <dabates@apple.com>
3467
3468         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
3469         https://bugs.webkit.org/show_bug.cgi?id=191094
3470
3471         Reviewed by Andy Estes.
3472
3473         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
3474         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
3475         Document summary and add closing brace '}' to both Frame and Document summary strings to make
3476         them look pretty.
3477
3478         * lldb/lldb_webkit.py:
3479         (WebCoreFrame_SummaryProvider):
3480         (WebCoreDocument_SummaryProvider):
3481
3482 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3483
3484         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
3485         https://bugs.webkit.org/show_bug.cgi?id=191240
3486         <rdar://problem/44872806>
3487
3488         Reviewed by Tim Horton.
3489
3490         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
3491         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
3492         overriding `-[WKWebView inputAssistantItem]`.
3493
3494         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3495         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
3496         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
3497         (+[InputAssistantItemTestingWebView barButtonIcon]):
3498         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
3499         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
3500         (-[InputAssistantItemTestingWebView inputAssistantItem]):
3501         (TestWebKitAPI::TEST):
3502
3503 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3504
3505         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
3506         https://bugs.webkit.org/show_bug.cgi?id=191226
3507         <rdar://problem/45781765>
3508
3509         Reviewed by Tim Horton.
3510
3511         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
3512         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
3513
3514         * WebKitTestRunner/TestOptions.h:
3515         (WTR::TestOptions::hasSameInitializationOptions const):
3516
3517 2018-11-05  Commit Queue  <commit-queue@webkit.org>
3518
3519         Unreviewed, rolling out r237784 and r237788.
3520         https://bugs.webkit.org/show_bug.cgi?id=191270
3521
3522         Caused mediastream layout test failures (Requested by
3523         ryanhaddad on #webkit).
3524
3525         Reverted changesets:
3526
3527         "[MediaStream] User should not be prompted again after denying
3528         getDisplayMedia request"
3529         https://bugs.webkit.org/show_bug.cgi?id=191227
3530         https://trac.webkit.org/changeset/237784
3531
3532         "[MediaStream] User should not be prompted again after denying
3533         getDisplayMedia request"
3534         https://bugs.webkit.org/show_bug.cgi?id=191227
3535         https://trac.webkit.org/changeset/237788
3536
3537 2018-11-05  Lucas Forschler  <lforschler@apple.com>
3538
3539         https://bugs.webkit.org/show_bug.cgi?id=191268
3540         Remove unused bots.
3541
3542         rubber-stamped by Alexey Proskuryakov.
3543
3544         * BuildSlaveSupport/build.webkit.org-config/config.json:
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3546         (WebKitBuildbot):
3547
3548 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
3549
3550         [WPE][GTK] API test runner fails to respect default build type
3551         https://bugs.webkit.org/show_bug.cgi?id=190247
3552
3553         Reviewed by Carlos Garcia Campos.
3554
3555         Problem is it's looking for a release build, even though I've run set-webkit-configuration
3556         --debug. It should look for a debug build unless I explicitly pass --release.
3557
3558         * glib/api_test_runner.py:
3559         (TestRunner.__init__):
3560
3561 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
3562
3563         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
3564         https://bugs.webkit.org/show_bug.cgi?id=190674
3565
3566         Reviewed by Philippe Normand.
3567
3568         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
3569         it can use to implement encoding for different formats exposing a trimmed down unified API.
3570
3571         It also adds proper handling of H264 profiles.
3572
3573         The added files follow GStreamer coding style as we aim at upstreaming the element
3574         in the future.
3575
3576         Reviewed by Philippe Normand.
3577
3578         * Scripts/webkitpy/style/checker.py:
3579
3580 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
3581
3582         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
3583         https://bugs.webkit.org/show_bug.cgi?id=191221
3584
3585         Reviewed by Carlos Garcia Campos.
3586
3587         This test ensures that MSE is disabled by default, but we now enable it by default, so
3588         reverse the semantics of the test.
3589
3590         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3591         (testWebKitSettings):
3592
3593 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
3594
3595         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
3596         https://bugs.webkit.org/show_bug.cgi?id=191225
3597
3598         Reviewed by Alejandro G. Castro.
3599
3600         Fix a memory leak causing this test to fail.
3601