Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page...
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2
3         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4         https://bugs.webkit.org/show_bug.cgi?id=194914
5         <rdar://problem/47586889>
6
7         Reviewed by Geoffrey Garen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
10         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
11         (TEST):
12         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
13
14 2019-02-21  David Kilzer  <ddkilzer@apple.com>
15
16         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
17         <https://webkit.org/b/194761>
18
19         Reviewed by Myles Maxfield.
20
21         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
22         (WTR::activateSystemCoreWebFonts): Log `error` to console if
23         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
24         to use ARC-compliant cast.
25         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
26         ARC-compliant cast.
27         (WTR::installFakeHelvetica): Log `error` to console if
28         CTFontManagerRegisterFontsForURL() fails, but only on supported
29         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
30         Call CFRelease() on `error` to fix the leak.  Update to use
31         ARC-compliant cast.
32         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
33         cast.
34
35 2019-02-21  Chris Dumez  <cdumez@apple.com>
36
37         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
38         https://bugs.webkit.org/show_bug.cgi?id=194481
39
40         Reviewed by Alex Christensen.
41
42         Give the processes a chance to shutdown and wait until we reached the expected number
43         of processes.
44
45         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
46
47 2019-02-21  Tim Horton  <timothy_horton@apple.com>
48
49         Fix the macOS build
50
51         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
52
53 2019-02-21  Tim Horton  <timothy_horton@apple.com>
54
55         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
56
57         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
58         I am a backwards.
59
60 2019-02-21  Tim Horton  <timothy_horton@apple.com>
61
62         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
63
64         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
65         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
66         We could force on UI-side compositing, but I feel like the test might be more
67         valuable exercising the normal path on each platform (though the original
68         bug was also UI-side specific). Though we can't validate that the overlay
69         layer was installed successfully, there are layout tests that do that.
70
71 2019-02-21  Tim Horton  <timothy_horton@apple.com>
72
73         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
74         https://bugs.webkit.org/show_bug.cgi?id=194845
75         <rdar://problem/47944579>
76
77         Reviewed by Antti Koivisto.
78
79         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
80         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
81
82 2019-02-21  Zalan Bujtas  <zalan@apple.com>
83
84         [LFC][Floats] Add support for placing formatting roots in-between floats.
85         https://bugs.webkit.org/show_bug.cgi?id=194902
86
87         Reviewed by Antti Koivisto.
88
89         * LayoutReloaded/misc/LFC-passing-tests.txt:
90
91 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
92
93         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
94         https://bugs.webkit.org/show_bug.cgi?id=194901
95
96         Unreviewed build fix.
97
98         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
99         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
100         WPEBackend-fdo-0.1 as library name.
101
102 2019-02-21  Rob Buis  <rbuis@igalia.com>
103
104         Update MIME type parser
105         https://bugs.webkit.org/show_bug.cgi?id=180526
106
107         Reviewed by Darin Adler.
108
109         Add tests involving leading and trailing whitespace, non-token
110         characters and quoted strings.
111
112         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
113         (TestWebKitAPI::TEST):
114
115 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
116
117         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
118         https://bugs.webkit.org/show_bug.cgi?id=194884
119
120         Reviewed by Michael Catanzaro.
121
122         * PlatformWin.cmake:
123
124 2019-02-20  Chris Dumez  <cdumez@apple.com>
125
126         Add API test for <rdar://problem/47471222>
127         https://bugs.webkit.org/show_bug.cgi?id=194847
128
129         Reviewed by Alex Christensen.
130
131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
132
133 2019-02-20  Chris Dumez  <cdumez@apple.com>
134
135         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
136         https://bugs.webkit.org/show_bug.cgi?id=194872
137         <rdar://problem/47924500>
138
139         Reviewed by Alex Christensen.
140
141         Add API test coverage.
142
143         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
144
145 2019-02-20  Jer Noble  <jer.noble@apple.com>
146
147         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
148         https://bugs.webkit.org/show_bug.cgi?id=191332
149
150         Reviewed by Dean Jackson.
151
152         * Scripts/git-is-in-range: Added.
153
154 2019-02-20  Andy Estes  <aestes@apple.com>
155
156         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
157         https://bugs.webkit.org/show_bug.cgi?id=194869
158
159         Rubber-stamped by Jer Noble.
160
161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
162         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
163         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
164         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
166         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
167
168 2019-02-20  Chris Dumez  <cdumez@apple.com>
169
170         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
171         https://bugs.webkit.org/show_bug.cgi?id=194857
172         <rdar://problem/47759323>
173
174         Reviewed by Alex Christensen.
175
176         Add API test coverage.
177
178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
179
180 2019-02-20  Chris Dumez  <cdumez@apple.com>
181
182         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
183         https://bugs.webkit.org/show_bug.cgi?id=194829
184         <rdar://problem/47889906>
185
186         Reviewed by Alexey Proskuryakov.
187
188         Every time the TestOptions were changing we were creating both a new Web view and
189         a new WKContext, which would start a new Network process. In most cases, we only
190         need to contruct a new Web view and we do can keep reusing the same WKContext.
191         This patch implements this optimization and thus avoids spinning a lot of new
192         Network processes while running the layout tests.
193
194         * WebKitTestRunner/TestController.cpp:
195         (WTR::TestController::generateContextConfiguration const):
196         (WTR::TestController::generatePageConfiguration):
197         (WTR::TestController::createWebViewWithOptions):
198         (WTR::TestController::resetPreferencesToConsistentValues):
199         (WTR::updateTestOptionsFromTestHeader):
200         * WebKitTestRunner/TestController.h:
201         * WebKitTestRunner/TestOptions.h:
202         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
203         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
204         (WTR::TestOptions::hasSameInitializationOptions const):
205         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
206         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
207         (WTR::TestController::platformAddTestOptions const):
208
209 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
210
211         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
212         https://bugs.webkit.org/show_bug.cgi?id=167941
213
214         Reviewed by Carlos Garcia Campos.
215
216         * MiniBrowser/gtk/main.c:
217         (filterSavedCallback): Added.
218         (main): Support loading a JSON rule set file for content filtering.
219         * MiniBrowser/wpe/main.cpp:
220         (filterSavedCallback): Added.
221         (main): Support loading a JSON rule set file for content filtering.
222         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
223         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
224         (WTF::derefGPtr): Ditto.
225         (testEmptyStore):
226         (testSaveInvalidFilter):
227         (testSaveLoadFilter):
228         (testSavedFilterIdentifierMatch):
229         (testRemoveFilter):
230         (testSaveMultipleFilters):
231         (testSaveFilterFromFile):
232         (testFilterPersistence):
233         (beforeAll):
234         (afterAll):
235         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
236         (removeOldInjectedContentAndResetLists): Also reset content filters.
237         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
238         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
239         the element affected by the style sheet.
240         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
241         and returns it to be used by tests.
242         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
243         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
244         (serverCallback): Add support for serving a CSS style sheet for testing.
245         (beforeAll): Add call to testUserContentManagerContentFilter().
246         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
247
248 2019-02-19  Keith Rollin  <krollin@apple.com>
249
250         Add timing information to build output
251         https://bugs.webkit.org/show_bug.cgi?id=194839
252         <rdar://problem/48219609>
253
254         Reviewed by Alexey Proskuryakov.
255
256         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
257         emit each project's build time to its output. E.g.,
258
259             ** BUILD SUCCEEDED ** [0.132 sec]
260
261         * Scripts/webkitdirs.pm:
262         (XcodeOptions):
263
264 2019-02-19  Truitt Savell  <tsavell@apple.com>
265
266         Unreviewed, rolling out r241784.
267
268         Broke all OpenSource builds.
269
270         Reverted changeset:
271
272         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
273         instances view"
274         https://bugs.webkit.org/show_bug.cgi?id=172848
275         https://trac.webkit.org/changeset/241784
276
277 2019-02-19  Zalan Bujtas  <zalan@apple.com>
278
279         [LFC][Floats] Remove redundant intersecting logic
280         https://bugs.webkit.org/show_bug.cgi?id=194804
281
282         Reviewed by Antti Koivisto.
283
284         * LayoutReloaded/misc/LFC-passing-tests.txt:
285
286 2019-02-19  Dean Jackson  <dino@apple.com>
287
288         Clean-up output from generate-xcfilelists so it can be filtered
289         https://bugs.webkit.org/show_bug.cgi?id=194795
290
291         Reviewed by Joseph Pecoraro (and Keith Rollin).
292
293         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
294         make a slight tweak to filter-build-webkit so such lines are marked
295         as plain.
296
297         * Scripts/filter-build-webkit:
298         * Scripts/generate-xcfilelists:
299
300 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
301
302         pytest is not correctly auto-installed
303         https://bugs.webkit.org/show_bug.cgi?id=194707
304
305         Reviewed by Carlos Garcia Campos.
306
307         * Scripts/webkitpy/thirdparty/__init__.py:
308         (AutoinstallImportHook._install_pytest):
309
310 2019-02-18  Chris Dumez  <cdumez@apple.com>
311
312         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
313         https://bugs.webkit.org/show_bug.cgi?id=194797
314         <rdar://problem/48055151>
315
316         Reviewed by Geoffrey Garen.
317
318         Add API test coverage.
319
320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
321
322 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
323
324         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
325         https://bugs.webkit.org/show_bug.cgi?id=194670
326         <rdar://problem/39066529>
327
328         Reviewed by Tim Horton.
329
330         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
331         pasted in an editable area as attachment elements.
332
333         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
334         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
335         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
336         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
337         (TestWebKitAPI::TEST):
338         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
339         (WTR::InjectedBundlePage::InjectedBundlePage):
340
341 2019-02-18  Alex Christensen  <achristensen@webkit.org>
342
343         Fix API test after r241728
344        ​https://bugs.webkit.org/show_bug.cgi?id=194723
345
346         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
347         (TEST):
348         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
349
350 2019-02-18  Daniel Bates  <dabates@apple.com>
351
352         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
353         https://bugs.webkit.org/show_bug.cgi?id=192824
354         <rdar://problem/47100332>
355
356         Reviewed by Wenson Hsieh.
357
358         Fix a bug where the wrong usage code was used for F13 thru F24.
359
360         * WebKitTestRunner/ios/HIDEventGenerator.mm:
361         (keyCodeForDOMFunctionKey):
362
363 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
364
365         Bytecode cache should a have a boot-specific validation
366         https://bugs.webkit.org/show_bug.cgi?id=194769
367         <rdar://problem/48149509>
368
369         Reviewed by Keith Miller.
370
371         Add test for WTF::bootSessionUUIDString()
372
373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
374         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
375         (TEST):
376
377 2019-02-18  Alex Christensen  <achristensen@webkit.org>
378
379         Disable safe browsing in WKWebView and remove its WKPreferences API
380         https://bugs.webkit.org/show_bug.cgi?id=194723
381         <rdar://problem/48122993>
382
383         Reviewed by Geoffrey Garen.
384
385         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
386         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
387         (TEST):
388         (safeBrowsingView):
389         Make tests use SPI instead of API.
390
391 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
392
393         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
394         https://bugs.webkit.org/show_bug.cgi?id=194586
395
396         Reviewed by Ross Kirsling.
397
398         * DumpRenderTree/win/DumpRenderTree.cpp:
399         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
400         * Scripts/webkitpy/port/driver.py:
401         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
402
403 2019-02-17  David Kilzer  <ddkilzer@apple.com>
404
405         Unreviewed, rolling out r241620.
406
407         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
408         (Requested by ddkilzer on #webkit.)
409
410         Reverted changeset:
411
412         "[WTF] Add environment variable helpers"
413         https://bugs.webkit.org/show_bug.cgi?id=192405
414         https://trac.webkit.org/changeset/241620
415
416 2019-02-16  Zalan Bujtas  <zalan@apple.com>
417
418         [LFC] RenderImage's default intrinsic size is 0.
419         https://bugs.webkit.org/show_bug.cgi?id=194745
420
421         Reviewed by Antti Koivisto.
422
423         * LayoutReloaded/misc/LFC-passing-tests.txt:
424
425 2019-02-16  Zalan Bujtas  <zalan@apple.com>
426
427         [LFC][BFC] Add support for block replaced intrinsic width.
428         https://bugs.webkit.org/show_bug.cgi?id=194705
429
430         Reviewed by Simon Fraser.
431
432         * LayoutReloaded/misc/LFC-passing-tests.txt:
433
434 2019-02-16  Zalan Bujtas  <zalan@apple.com>
435
436         [LFC] Apply min/max width constraints to preferred width computation
437         https://bugs.webkit.org/show_bug.cgi?id=194739
438
439         Reviewed by Simon Fraser.
440
441         * LayoutReloaded/misc/LFC-passing-tests.txt:
442
443 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
444
445         [WTF] Add environment variable helpers
446         https://bugs.webkit.org/show_bug.cgi?id=192405
447
448         Reviewed by Michael Catanzaro.
449
450         * DumpRenderTree/mac/DumpRenderTree.mm:
451         (libraryPathForDumpRenderTree):
452         * DumpRenderTree/win/DumpRenderTree.cpp:
453         (libraryPathForDumpRenderTree):
454         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
455         (setUpIOSLayoutTestCommunication):
456         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
457         (beforeAll):
458         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
459         (main):
460         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
461         (WebKitTestBus::run):
462         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
463         (WTR::getOutputDir):
464         (WTR::initializeFontConfigSetting):
465         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
466         (WTR::InjectedBundle::platformInitialize):
467         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
468         (WTR::topLevelPath):
469         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
470         (WTR::topLevelPath):
471         (WTR::getOutputDir):
472         (WTR::activateFonts):
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::TestController::libraryPathForTesting):
475         (WTR::TestController::generateContextConfiguration const):
476         (WTR::TestController::generatePageConfiguration):
477         (WTR::TestController::decideDestinationWithSuggestedFilename):
478         (WTR::TestController::platformAdjustContext):
479         * WebKitTestRunner/TestController.h:
480         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
481         (WTR::TestController::cocoaPlatformInitialize):
482         (WTR::TestController::platformAdjustContext):
483         * WebKitTestRunner/gtk/main.cpp:
484         (main):
485         * WebKitTestRunner/mac/TestControllerMac.mm:
486         (WTR::TestController::configureContentExtensionForTest):
487         * WebKitTestRunner/wpe/main.cpp:
488         (main):
489         Utilize WTF::Environment where possible.
490
491 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
492
493         [iOS] WKWebView callout bar is missing Change Writing Direction item
494         https://bugs.webkit.org/show_bug.cgi?id=190015
495         <rdar://problem/44810366>
496
497         Reviewed by Tim Horton.
498
499         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
500         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
501
502         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
503         (TestWebKitAPI::TEST):
504
505 2019-02-15  Chris Dumez  <cdumez@apple.com>
506
507         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
508         https://bugs.webkit.org/show_bug.cgi?id=194717
509         <rdar://problem/47884404>
510
511         Reviewed by Brady Eidson.
512
513         Add API test coverage.
514
515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
516
517 2019-02-15  Youenn Fablet  <youenn@apple.com>
518
519         Make navigator.mediaDevices SecureContext
520         https://bugs.webkit.org/show_bug.cgi?id=194666
521
522         Reviewed by Eric Carlson.
523
524         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
525         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
526         (TEST_F):
527
528 2019-02-15  Brian Burg  <bburg@apple.com>
529
530         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
531         https://bugs.webkit.org/show_bug.cgi?id=194411
532         <rdar://problem/47787614>
533
534         Reviewed by Joseph Pecoraro.
535
536         Remove unnecessary soft linking macro usage.
537
538         * DumpRenderTree/mac/TestRunnerMac.mm:
539         (TestRunner::inspectorTestStubURL):
540         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
541         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
542         (WTR::TestRunner::inspectorTestStubURL):
543
544 2019-02-15  Commit Queue  <commit-queue@webkit.org>
545
546         Unreviewed, rolling out r241559 and r241566.
547         https://bugs.webkit.org/show_bug.cgi?id=194710
548
549         Causes layout test crashes under GuardMalloc (Requested by
550         ryanhaddad on #webkit).
551
552         Reverted changesets:
553
554         "[WTF] Add environment variable helpers"
555         https://bugs.webkit.org/show_bug.cgi?id=192405
556         https://trac.webkit.org/changeset/241559
557
558         "Unreviewed build fix for WinCairo Debug after r241559."
559         https://trac.webkit.org/changeset/241566
560
561 2019-02-15  Zalan Bujtas  <zalan@apple.com>
562
563         [LFC] Out-of-flow box is never a float box
564         https://bugs.webkit.org/show_bug.cgi?id=194704
565
566         Reviewed by Antti Koivisto.
567
568         * LayoutReloaded/misc/LFC-passing-tests.txt:
569
570 2019-02-10  Darin Adler  <darin@apple.com>
571
572         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
573         https://bugs.webkit.org/show_bug.cgi?id=194487
574
575         Reviewed by Daniel Bates.
576
577         * DumpRenderTree/win/DumpRenderTree.cpp:
578         (applicationId): Use makeString instead of String::format.
579         (main): Ditto.
580         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
581         (TestWebKitAPI::Util::createURLForResource): Ditto.
582         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
583         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
584
585         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
586         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
587         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
588         (WTR::createStringWithAttributes): Use appendLiteral.
589         (WTR::AccessibilityUIElement::helpText const): Ditto.
590         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
591         directly instead of using String::format.
592         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
593         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
594
595 2019-02-15  Truitt Savell  <tsavell@apple.com>
596
597         Unreviewed, rolling out r241564.
598
599         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
600
601         Reverted changeset:
602
603         "[Mac] WebInspectorUI.framework does not need to be soft-
604         linked anymore"
605         https://bugs.webkit.org/show_bug.cgi?id=194411
606         https://trac.webkit.org/changeset/241564
607
608 2019-02-15  Saam barati  <sbarati@apple.com>
609
610         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
611         https://bugs.webkit.org/show_bug.cgi?id=194036
612
613         Reviewed by Yusuke Suzuki.
614
615         * Scripts/run-jsc-stress-tests:
616
617 2019-02-14  Tim Horton  <timothy_horton@apple.com>
618
619         Fix the build.
620
621         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
622         (WTR::UIScriptController::drawSquareInEditableImage):
623         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
624         (TestWebKitAPI::drawSquareInEditableImage):
625
626 2019-02-14  Tim Horton  <timothy_horton@apple.com>
627
628         Fix the build.
629
630         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
631         (WTR::UIScriptController::drawSquareInEditableImage):
632         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
633         (TestWebKitAPI::drawSquareInEditableImage):
634
635 2019-02-14  Brian Burg  <bburg@apple.com>
636
637         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
638         https://bugs.webkit.org/show_bug.cgi?id=194411
639         <rdar://problem/47787614>
640
641         Reviewed by Joseph Pecoraro.
642
643         Remove unnecessary soft linking macro usage.
644
645         * DumpRenderTree/mac/TestRunnerMac.mm:
646         (TestRunner::inspectorTestStubURL):
647         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
648         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
649         (WTR::TestRunner::inspectorTestStubURL):
650
651 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
652
653         [ews-app] status bubble should fetch builder name info from BuilderMapping table
654         https://bugs.webkit.org/show_bug.cgi?id=194599
655
656         Reviewed by Lucas Forschler.
657
658         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
659         (StatusBubble._build_bubble):
660
661 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
662
663         [ews-app] Set Foreign Key in Django build model
664         https://bugs.webkit.org/show_bug.cgi?id=194667
665
666         Reviewed by Lucas Forschler.
667
668         * BuildSlaveSupport/ews-app/ews/models/build.py:
669         (Build):
670
671 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
672
673         [WTF] Add environment variable helpers
674         https://bugs.webkit.org/show_bug.cgi?id=192405
675
676         Reviewed by Michael Catanzaro.
677
678         * DumpRenderTree/mac/DumpRenderTree.mm:
679         (libraryPathForDumpRenderTree):
680         * DumpRenderTree/win/DumpRenderTree.cpp:
681         (libraryPathForDumpRenderTree):
682         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
683         (setUpIOSLayoutTestCommunication):
684         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
685         (TestWebKitAPI::strip):
686         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
687         (beforeAll):
688         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
689         (main):
690         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
691         (WebKitTestBus::run):
692         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
693         (WTR::getOutputDir):
694         (WTR::initializeFontConfigSetting):
695         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
696         (WTR::InjectedBundle::platformInitialize):
697         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
698         (WTR::topLevelPath):
699         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
700         (WTR::topLevelPath):
701         (WTR::getOutputDir):
702         (WTR::activateFonts):
703         * WebKitTestRunner/TestController.cpp:
704         (WTR::TestController::libraryPathForTesting):
705         (WTR::TestController::generateContextConfiguration const):
706         (WTR::TestController::generatePageConfiguration):
707         (WTR::TestController::decideDestinationWithSuggestedFilename):
708         (WTR::TestController::platformAdjustContext):
709         * WebKitTestRunner/TestController.h:
710         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
711         (WTR::TestController::cocoaPlatformInitialize):
712         (WTR::TestController::platformAdjustContext):
713         * WebKitTestRunner/gtk/main.cpp:
714         (main):
715         * WebKitTestRunner/mac/TestControllerMac.mm:
716         (WTR::TestController::configureContentExtensionForTest):
717         * WebKitTestRunner/wpe/main.cpp:
718         (main):
719         Utilize WTF::Environment where possible.
720
721 2019-02-14  Chris Dumez  <cdumez@apple.com>
722
723         [PSON] Introduce a WebContent Process cache
724         https://bugs.webkit.org/show_bug.cgi?id=194594
725         <rdar://problem/46793397>
726
727         Reviewed by Geoff Garen.
728
729         Update API tests to turn on the WebContent Process cache.
730
731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
732
733 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
734
735         Unreviewed, build fix after r241480
736
737         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
738         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
739         (-[DragAndDropSimulator initWithWebView:]):
740
741 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
742
743         AX: ARIA Reflection was disabled in error
744         https://bugs.webkit.org/show_bug.cgi?id=194647
745         <rdar://problem/48068336>
746
747         Reviewed by Ryosuke Niwa.
748
749         Remove test override now that this feature should be enabled by default.
750
751         * WebKitTestRunner/TestController.cpp:
752         (WTR::TestController::resetPreferencesToConsistentValues):
753
754 2019-02-14  Commit Queue  <commit-queue@webkit.org>
755
756         Unreviewed, rolling out r241486.
757         https://bugs.webkit.org/show_bug.cgi?id=194655
758
759         causing API failures in builds (Requested by ShawnRoberts on
760         #webkit).
761
762         Reverted changeset:
763
764         "[Cocoa] Media elements will restart network buffering just
765         before suspending"
766         https://bugs.webkit.org/show_bug.cgi?id=193691
767         https://trac.webkit.org/changeset/241486
768
769 2019-02-14  Zalan Bujtas  <zalan@apple.com>
770
771         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
772         https://bugs.webkit.org/show_bug.cgi?id=194622
773
774         Reviewed by Antti Koivisto.
775
776         * LayoutReloaded/misc/LFC-passing-tests.txt:
777
778 2019-02-14  Zalan Bujtas  <zalan@apple.com>
779
780         [LFC] Shrink-to-fit-width should be constrained by min/max width
781         https://bugs.webkit.org/show_bug.cgi?id=194653
782
783         Reviewed by Antti Koivisto.
784
785         * LayoutReloaded/misc/LFC-passing-tests.txt:
786
787 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
788
789         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
790         https://bugs.webkit.org/show_bug.cgi?id=194641
791
792         Reviewed by Geoffrey Garen.
793
794         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
795         so that the test would fail without this fix.
796
797         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
798         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
799
800 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
801
802         [ews-app] Change log level for a log statement
803
804         Unreviewed minor fix.
805
806         * BuildSlaveSupport/ews-app/ews/models/patch.py:
807         (Patch.save_patch):
808
809 2019-02-13  Jer Noble  <jer.noble@apple.com>
810
811         [Cocoa] Media elements will restart network buffering just before suspending
812         https://bugs.webkit.org/show_bug.cgi?id=193691
813
814         Reviewed by Eric Carlson.
815
816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
818         (TEST):
819
820 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
821
822         [ews-app] Fetch builder id to name mapping
823         https://bugs.webkit.org/show_bug.cgi?id=194355
824
825         Reviewed by Lucas Forschler.
826
827         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
828         (Buildbot.get_builder_id_to_name_mapping):
829         (Buildbot._get_display_name_from_builder_name):
830
831 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
832
833         Further restricting webarchive loads
834         https://bugs.webkit.org/show_bug.cgi?id=194567
835         <rdar://problem/47610130>
836
837         Reviewed by Youenn Fablet.
838
839         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
840         navigations on drop.
841
842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
843         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
844         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
845         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
846         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
847         (TestWebKitAPI::TEST):
848         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
849         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
850         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
851         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
852         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
853         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
854         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
855
856 2019-02-13  John Wilander  <wilander@apple.com>
857
858         Store Ad Click Attribution requests in the network process
859         https://bugs.webkit.org/show_bug.cgi?id=194510
860         <rdar://problem/47650118>
861
862         Reviewed by Alex Christensen and Daniel Bates.
863
864         This patch adds two TestRunner functions:
865         - dumpAdClickAttribution()
866         - clearAdClickAttribution()
867
868         They call into the network process to dump and clear Ad Click
869         Attribution state, respectively.
870
871         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
872         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
873         (WTR::TestRunner::dumpAdClickAttribution):
874         (WTR::TestRunner::clearAdClickAttribution):
875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
876         * WebKitTestRunner/TestController.cpp:
877         (WTR::TestController::resetStateToConsistentValues):
878         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
879         (WTR::adClickAttributionStringResultCallback):
880         (WTR::TestController::dumpAdClickAttribution):
881         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
882         (WTR::adClickAttributionVoidCallback):
883         (WTR::TestController::clearAdClickAttribution):
884         * WebKitTestRunner/TestController.h:
885         * WebKitTestRunner/TestInvocation.cpp:
886         (WTR::TestInvocation::dumpResults):
887         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
888         (WTR::TestInvocation::dumpAdClickAttribution):
889         * WebKitTestRunner/TestInvocation.h:
890
891 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
892
893         [ews-app] Generate status-bubble
894         https://bugs.webkit.org/show_bug.cgi?id=194572
895
896         Reviewed by Lucas Forschler.
897
898         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
899         (StatusBubble._build_bubble):
900         (StatusBubble._should_show_bubble_for):
901         (StatusBubble._build_bubbles_for_patch):
902
903 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
904
905         [ews-app] Add status bubble html template
906         https://bugs.webkit.org/show_bug.cgi?id=194571
907
908         Reviewed by Lucas Forschler.
909
910         * BuildSlaveSupport/ews-app/ews/templates: Added.
911         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
912
913 2019-02-12  Chris Dumez  <cdumez@apple.com>
914
915         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
916         https://bugs.webkit.org/show_bug.cgi?id=194568
917         <rdar://problem/47944490>
918
919         Reviewed by Ryosuke Niwa.
920
921         Add API test coverage.
922
923         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
924         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
925
926 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
927
928         webkitpy: Remove bug_dummy from parsed test expectations
929         https://bugs.webkit.org/show_bug.cgi?id=194562
930         <rdar://problem/47853999>
931
932         Reviewed by Lucas Forschler.
933
934         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
935         (TestExpectationParser):
936         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
937         skipped tests.
938         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
939
940 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
941
942         [ews-app] Add method to fetch patch
943         https://bugs.webkit.org/show_bug.cgi?id=194518
944
945         Reviewed by Lucas Forschler.
946
947         * BuildSlaveSupport/ews-app/ews/models/patch.py:
948         (Patch.get_patch):
949
950 2019-02-12  Zalan Bujtas  <zalan@apple.com>
951
952         [LFC] Expand tests coverage (60 new tests -> 860)
953
954         Unreviewed test gardening (run-singly, --child-processes=1).
955
956         * LayoutReloaded/misc/LFC-passing-tests.txt:
957
958 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
959
960         Allow pages to trigger programmatic paste from script on iOS
961         https://bugs.webkit.org/show_bug.cgi?id=194271
962         <rdar://problem/47808810>
963
964         Reviewed by Tim Horton.
965
966         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
967
968         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
969         (WTR::UIScriptController::platformSetDidShowMenuCallback):
970         (WTR::UIScriptController::platformSetDidHideMenuCallback):
971         (WTR::UIScriptController::rectForMenuAction const):
972
973         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
974         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
975         for when the menu is shown or hidden.
976
977         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
978         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
979         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
980         (WTR::UIScriptController::setDidShowMenuCallback):
981         (WTR::UIScriptController::didShowMenuCallback const):
982         (WTR::UIScriptController::setDidHideMenuCallback):
983         (WTR::UIScriptController::didHideMenuCallback const):
984         (WTR::UIScriptController::platformSetDidShowMenuCallback):
985         (WTR::UIScriptController::platformSetDidHideMenuCallback):
986         (WTR::UIScriptController::rectForMenuAction const):
987         * TestRunnerShared/UIScriptContext/UIScriptController.h:
988         * WebKitTestRunner/TestController.cpp:
989         (WTR::TestController::resetPreferencesToConsistentValues):
990         (WTR::updateTestOptionsFromTestHeader):
991         * WebKitTestRunner/TestOptions.h:
992
993         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
994         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
995
996         (WTR::TestOptions::hasSameInitializationOptions const):
997         * WebKitTestRunner/UIScriptControllerCocoa.mm:
998         (WTR::UIScriptController::calendarType const):
999         (WTR::UIScriptController::platformUndoManager const):
1000         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1001         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1002         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1003         (-[TestRunnerWKWebView dealloc]):
1004         (-[TestRunnerWKWebView _didShowMenu]):
1005         (-[TestRunnerWKWebView _didHideMenu]):
1006
1007         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1008
1009         * WebKitTestRunner/ios/TestControllerIOS.mm:
1010         (WTR::handleMenuWillHideNotification):
1011         (WTR::handleMenuDidHideNotification):
1012         (WTR::TestController::platformInitialize):
1013         (WTR::TestController::platformDestroy):
1014         (WTR::TestController::platformResetStateToConsistentValues):
1015
1016         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1017         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1018
1019         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1020         (WTR::forEachViewInHierarchy):
1021         (WTR::findViewInHierarchyOfType):
1022
1023         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1024         functions that dig through a given view's hierarchy in search of a view of a given class.
1025
1026         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1027         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1028         (WTR::UIScriptController::selectionCaretViewRect const):
1029         (WTR::UIScriptController::selectionRangeViewRects const):
1030         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1031         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1032
1033         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1034
1035         (WTR::UIScriptController::rectForMenuAction const):
1036
1037         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1038         callout bar) whose label matches the given string.
1039
1040         (WTR::UIScriptController::platformContentView const):
1041
1042         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1043         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1044         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1045
1046         (WTR::UIScriptController::platformUndoManager const): Deleted.
1047         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1048         (WTR::UIScriptController::platformContentView const):
1049         (WTR::UIScriptController::platformUndoManager const): Deleted.
1050
1051 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1052
1053         webkitpy: No option to only show unexpected failures in results.html for iPad
1054         https://bugs.webkit.org/show_bug.cgi?id=194554
1055         <rdar://problem/47922442>
1056
1057         Rubber-stamped by Aakash Jain.
1058
1059         Just because a TestExpecations file does not exist for a specific platform does not mean that
1060         TestExpecations are not being used, given that platforms inherit test expectations.
1061
1062         * Scripts/webkitpy/port/base.py:
1063         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1064         * Scripts/webkitpy/port/base_unittest.py:
1065         (PortTest.test_uses_test_expectations_file):
1066
1067 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1068
1069         Remove setDefersLoading infrastructure from WebKit2
1070         https://bugs.webkit.org/show_bug.cgi?id=194506
1071
1072         Reviewed by Brady Eidson.
1073
1074         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1075         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1076         (WTR::TestRunner::setDefersLoading): Deleted.
1077         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1078
1079 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1080
1081         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1082         https://bugs.webkit.org/show_bug.cgi?id=194522
1083         <rdar://problem/47789393>
1084
1085         Reviewed by Chris Dumez.
1086
1087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1088         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1089         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1090         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1091
1092 2019-02-12  Andy Estes  <aestes@apple.com>
1093
1094         [iOSMac] Enable Parental Controls Content Filtering
1095         https://bugs.webkit.org/show_bug.cgi?id=194521
1096         <rdar://39732376>
1097
1098         Reviewed by Tim Horton.
1099
1100         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1101
1102 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1103
1104         [LFC][IFC] Add intrinsic width support for float boxes.
1105         https://bugs.webkit.org/show_bug.cgi?id=194528
1106
1107         Reviewed by Antti Koivisto.
1108
1109         Expand tests coverage (2 new tests -> 800).
1110         (This is the correct test ordering --runs-singly --child-processes=1)
1111
1112         * LayoutReloaded/misc/LFC-passing-tests.txt:
1113
1114 2019-02-12  Rob Buis  <rbuis@igalia.com>
1115
1116         Implement serializing in MIME type parser
1117         https://bugs.webkit.org/show_bug.cgi?id=193909
1118
1119         Reviewed by Darin Adler.
1120
1121         Add various tests involving upper case, non-ASCII, control/null characters,
1122         various HTTP whitespace, single quotes and an unpaired surrogate.
1123
1124         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1125         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1126         (TestWebKitAPI::serializeIfValid):
1127         (TestWebKitAPI::TEST):
1128
1129 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1130
1131         [Cocoa] Ask platform for generic font family mappings
1132         https://bugs.webkit.org/show_bug.cgi?id=187723
1133         <rdar://problem/41892438>
1134
1135         Reviewed by Brent Fulgham.
1136
1137         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1138
1139         * DumpRenderTree/mac/DumpRenderTree.mm:
1140         (allowedFontFamilySet):
1141         * WebKitTestRunner/mac/TestControllerMac.mm:
1142         (WTR::allowedFontFamilySet):
1143
1144 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1145
1146         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1147         https://bugs.webkit.org/show_bug.cgi?id=193622
1148
1149         Reviewed by Michael Catanzaro.
1150
1151         This adds support for loading content extension rule sets from the JSON files which
1152         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1153         of WKTR for this could be removed, but that is left for a follow-up patch with
1154         cleanups.
1155
1156         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1157         * WebKitTestRunner/TestController.cpp:
1158         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1159         avoid having the null-terminator copied into the result.
1160         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1161         part of the preparations to run a test.
1162         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1163         (WTR::contentExtensionStoreCallback): Added.
1164         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1165         used for content extensions test.
1166         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1167         extensions and compiling the JSON rule set for tests involving content extensions.
1168         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1169         testing and disables content extensions.
1170         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1171         resetContentExtensions().
1172         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1173         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1174         configureContentExtensionForTest(), and userContentController().
1175
1176 2019-02-11  Daniel Bates  <dabates@apple.com>
1177
1178         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1179         https://bugs.webkit.org/show_bug.cgi?id=191446
1180         <rdar://problem/45929460>
1181
1182         Reviewed by Tim Horton.
1183
1184         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1185
1186         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1187         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1188         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1189         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1190         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1191         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1192         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1193         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1194         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1195         (WTR::arrayLength):
1196         (WTR::parseModifierArray):
1197         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1198         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1199         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1200         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1201
1202 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1203
1204         Unreviewed, rolling out r241272 and r241276.
1205         https://bugs.webkit.org/show_bug.cgi?id=194514
1206
1207         Broke the Apple Internal build and the fix requires human
1208         intervention :( (Requested by dydz on #webkit).
1209
1210         Reverted changesets:
1211
1212         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1213         https://bugs.webkit.org/show_bug.cgi?id=191446
1214         https://trac.webkit.org/changeset/241272
1215
1216         "Fix internal iOS build after r241272"
1217         https://bugs.webkit.org/show_bug.cgi?id=191446
1218         https://trac.webkit.org/changeset/241276
1219
1220 2019-02-11  Truitt Savell  <tsavell@apple.com>
1221
1222         Unreviewed, rolling out r241269.
1223
1224         Caused 5 layout tests crashes on Mac WK1
1225
1226         Reverted changeset:
1227
1228         "DumpRenderTree should report unknown options"
1229         https://bugs.webkit.org/show_bug.cgi?id=191303
1230         https://trac.webkit.org/changeset/241269
1231
1232 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1233
1234         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1235         https://bugs.webkit.org/show_bug.cgi?id=194313
1236
1237         Reviewed by Tim Horton.
1238
1239         Add a helper to determine whether the web view is presenting modal UI.
1240
1241         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1242         (WTR::UIScriptController::isPresentingModally const):
1243         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1244         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1245         (WTR::UIScriptController::isPresentingModally const):
1246         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1247         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1248         (WTR::UIScriptController::calendarType const): Deleted.
1249         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1250         (WTR::UIScriptController::isPresentingModally const):
1251         (WTR::UIScriptController::calendarType const):
1252         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1253         (WTR::UIScriptController::calendarType const):
1254
1255 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1256
1257         GCHeapInspector: Show the retained sizes in more places
1258         https://bugs.webkit.org/show_bug.cgi?id=194464
1259
1260         Reviewed by Simon Fraser.
1261
1262         * GCHeapInspector/gc-heap-inspector.html:
1263         * GCHeapInspector/script/interface.js:
1264         (HeapInspectorUtils.humanReadableSize):
1265         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1266         (HeapInspectorUtils.spanForNode.span.span):
1267         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1268         (HeapSnapshotInspector.prototype.buildRoots):
1269
1270 2019-02-11  Daniel Bates  <dabates@apple.com>
1271
1272         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1273         https://bugs.webkit.org/show_bug.cgi?id=191446
1274         <rdar://problem/45929460>
1275
1276         Reviewed by Tim Horton.
1277
1278         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1279
1280         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1281         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1282         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1283         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1284         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1285         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1286         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1287         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1288         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1289         (WTR::arrayLength):
1290         (WTR::parseModifierArray):
1291         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1292         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1293         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1294         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1295
1296 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1297
1298         DumpRenderTree should report unknown options
1299         https://bugs.webkit.org/show_bug.cgi?id=191303
1300
1301         Reviewed by Frédéric Wang.
1302
1303         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1304         to report unknown options.
1305         Added and assigned test options which are currently used in tests.
1306
1307         * DumpRenderTree/TestOptions.cpp:
1308         (TestOptions::TestOptions):
1309
1310 2019-02-11  Truitt Savell  <tsavell@apple.com>
1311
1312         Unreviewed, rolling out r241229.
1313
1314         Revision broke internal builds for watchOS.
1315
1316         Reverted changeset:
1317
1318         "[Cocoa] Ask platform for generic font family mappings"
1319         https://bugs.webkit.org/show_bug.cgi?id=187723
1320         https://trac.webkit.org/changeset/241229
1321
1322 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1323
1324         [WinCairo][MiniBrowser] Basic authentication always fails.
1325         https://bugs.webkit.org/show_bug.cgi?id=194496
1326
1327         Reviewed by Don Olmstead.
1328
1329         * MiniBrowser/win/DialogHelper.h:
1330         (Dialog::getText):
1331
1332 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1333
1334         [GStreamer] GstMappedBuffer testsuite build fails
1335         https://bugs.webkit.org/show_bug.cgi?id=194495
1336
1337         Reviewed by Carlos Garcia Campos.
1338
1339         Fix the build by explicitely adding the gstreamer1.0-audio include
1340         directories to the include path.
1341
1342         * TestWebKitAPI/PlatformGTK.cmake:
1343         * TestWebKitAPI/PlatformWPE.cmake:
1344
1345 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1346
1347         [GTK][WPE] Add enable-javascript-markup setting
1348         https://bugs.webkit.org/show_bug.cgi?id=193439
1349
1350         Reviewed by Michael Catanzaro.
1351
1352         Add test cases to check the new setting.
1353
1354         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1355         (testWebKitSettings):
1356         (testWebKitSettingsJavaScriptMarkup):
1357         (beforeAll):
1358
1359 2019-02-10  Darin Adler  <darin@apple.com>
1360
1361         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1362         https://bugs.webkit.org/show_bug.cgi?id=194485
1363
1364         Reviewed by Daniel Bates.
1365
1366         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1367
1368 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1369
1370         Add more tests for clampTo<>()
1371         https://bugs.webkit.org/show_bug.cgi?id=194462
1372
1373         Reviewed by Geoffrey Garen.
1374
1375         Darin suggested to test the very last floating point number
1376         at the boundaries when truncating to integer.
1377         I added test for max/min and max-1/min-1.
1378
1379         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1380         (TestWebKitAPI::TEST):
1381
1382 2019-02-09  Darin Adler  <darin@apple.com>
1383
1384         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1385         https://bugs.webkit.org/show_bug.cgi?id=194021
1386
1387         Reviewed by Geoffrey Garen.
1388
1389         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1390         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1391         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1392
1393 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1394
1395         [LFC][IFC] Add intrinsic width support for basic inline containers
1396         https://bugs.webkit.org/show_bug.cgi?id=194473
1397
1398         Reviewed by Antti Koivisto.
1399
1400         Expand tests coverage (11 new tests -> 798)
1401
1402         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1403
1404 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1405
1406         Fix MiniBrowser's entitlements
1407         https://bugs.webkit.org/show_bug.cgi?id=192431
1408
1409         Reviewed by Joseph Pecoraro.
1410
1411         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1412         files, making it impossible to load any extension.
1413
1414         * MiniBrowser/MiniBrowser.entitlements:
1415
1416 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1417
1418         [Cocoa] Ask platform for generic font family mappings
1419         https://bugs.webkit.org/show_bug.cgi?id=187723
1420         <rdar://problem/41892438>
1421
1422         Reviewed by Brent Fulgham.
1423
1424         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1425
1426         * DumpRenderTree/mac/DumpRenderTree.mm:
1427         (allowedFontFamilySet):
1428         * WebKitTestRunner/mac/TestControllerMac.mm:
1429         (WTR::allowedFontFamilySet):
1430
1431 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1432
1433         [GTK] Implement back/forward touchpad gesture
1434         https://bugs.webkit.org/show_bug.cgi?id=193919
1435
1436         Reviewed by Michael Catanzaro.
1437
1438         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1439         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1440
1441 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1442
1443         Add SPI to use networking daemon instead of XPC service
1444         https://bugs.webkit.org/show_bug.cgi?id=194427
1445
1446         Reviewed by Geoffrey Garen
1447
1448         * MiniBrowser/MiniBrowser.entitlements:
1449
1450 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1451
1452         [ews-build] Ensure that every builder in config.json has short name
1453         https://bugs.webkit.org/show_bug.cgi?id=194461
1454
1455         Reviewed by Lucas Forschler.
1456
1457         * BuildSlaveSupport/ews-build/loadConfig.py:
1458         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1459
1460 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1461
1462         [ews-build] Add short name to config.json
1463         https://bugs.webkit.org/show_bug.cgi?id=194456
1464
1465         Reviewed by Lucas Forschler.
1466
1467         * BuildSlaveSupport/ews-build/config.json: Added short name.
1468         * BuildSlaveSupport/ews-build/loadConfig.py:
1469         (loadBuilderConfig): Set the short name as the builder description.
1470
1471 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1472
1473         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1474         https://bugs.webkit.org/show_bug.cgi?id=194418
1475
1476         Reviewed by Lucas Forschler.
1477
1478         Do not include errors trying when finding crashlogs at the end of
1479         a run-webkit-tests run since we don't process those errors.
1480
1481         * Scripts/webkitpy/port/darwin.py:
1482         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1483         * Scripts/webkitpy/port/ios_device.py:
1484         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1485         * Scripts/webkitpy/port/watch_device.py:
1486         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1487
1488 2019-02-08  Beth Dakin  <bdakin@apple.com>
1489
1490         Add afterScreenUpdates to WKSnapshotConfiguration
1491         https://bugs.webkit.org/show_bug.cgi?id=194362
1492         -and corresponding-
1493         <rdar://problem/40655528> Please add an "after screen updates" property to 
1494         WKSnapshotConfiguration (to solve blank snapshots)
1495
1496         Reviewed by Tim Horton.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1499         (TEST):
1500
1501 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1502
1503         clampTo(): do not convert the input to double when dealing with integers
1504         https://bugs.webkit.org/show_bug.cgi?id=194263
1505         <rdar://problem/47692312>
1506
1507         Reviewed by Darin Adler.
1508
1509         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1510         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1511         (TestWebKitAPI::testClampFloatingPointToInteger):
1512         (TestWebKitAPI::testClampSameSignIntegers):
1513         (TestWebKitAPI::testClampUnsignedToSigned):
1514         (TestWebKitAPI::testClampSignedToUnsigned):
1515
1516 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1517
1518         webkitpy: Respect --dedicated-simulators flag
1519         https://bugs.webkit.org/show_bug.cgi?id=194416
1520         <rdar://problem/47894722>
1521
1522         Reviewed by Lucas Forschler.
1523
1524         * Scripts/webkitpy/port/device_port.py:
1525         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1526         available devices can be safely ignored.
1527
1528 2019-02-07  Keith Rollin  <krollin@apple.com>
1529
1530         Remove extra copy of 100x100-red.tga
1531         https://bugs.webkit.org/show_bug.cgi?id=194371
1532         <rdar://problem/47873465>
1533
1534         Reviewed by Said Abou-Hallawa.
1535
1536         In order to help it pass its tests, Bug 194190 added a second copy of
1537         the file 100x100-red.tga. However, it turns out that this additional
1538         file wasn't actually needed, and that that sole previous copy was
1539         sufficient. At the same time, this second copy -- which was copied to
1540         the same location in the build output as the first copy -- now caused
1541         XCBuild to complain because there were two production rules for the
1542         same output file. Address this by removing the newly-added extra copy.
1543
1544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1545         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1546
1547 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1548
1549         Deprecate WKBundlePageSetDefersLoading
1550         https://bugs.webkit.org/show_bug.cgi?id=191394
1551
1552         Reviewed by Dean Jackson.
1553
1554         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1555         (WTR::TestRunner::setDefersLoading):
1556
1557 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1558
1559         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1560         https://bugs.webkit.org/show_bug.cgi?id=194391
1561
1562         Reviewed by Antti Koivisto.
1563
1564         * LayoutReloaded/misc/LFC-passing-tests.txt:
1565
1566 2019-02-06  Keith Rollin  <krollin@apple.com>
1567
1568         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1569         https://bugs.webkit.org/show_bug.cgi?id=193975
1570         <rdar://problem/47643306>
1571
1572         Reviewed by Tim Horton.
1573
1574         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1575         the Info.plist file into the bundle. This step is not necessary as the
1576         implicit "bundle up all the build products into a framework" build
1577         phase does this already. Having the Copy Bundle Resources phase do
1578         this causes a conflict under XCBuild, which objects to two build
1579         phases producing the same file (Info.plist). Address this by removing
1580         Info.plist from the Copy Bundle Resources phase.
1581
1582         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1583
1584 2019-02-06  Keith Rollin  <krollin@apple.com>
1585
1586         Really enable the automatic checking and regenerations of .xcfilelists during builds
1587         https://bugs.webkit.org/show_bug.cgi?id=194357
1588         <rdar://problem/47861231>
1589
1590         Reviewed by Chris Dumez.
1591
1592         Bug 194124 was supposed to enable the automatic checking and
1593         regenerating of .xcfilelist files during the build. While related
1594         changes were included in that patch, the change to actually enable the
1595         operation somehow was omitted. This patch actually enables the
1596         operation. The check-xcfilelist.sh scripts now check
1597         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1598         from the checking.
1599
1600         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1601         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1602
1603 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1604
1605         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1606         <https://webkit.org/b/194286>
1607         <rdar://problem/47815558>
1608
1609         Reviewed by Alexey Proskuryakov.
1610
1611         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1612         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1613         WKRetainPtr<> to avoid leaking the WKDataRef.
1614
1615 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1616
1617         Unreviewed, fix a typo
1618
1619         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1620
1621 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1622
1623         [GTK][WPE] force libpsl build to use ICU in jhbuild
1624         https://bugs.webkit.org/show_bug.cgi?id=194288
1625
1626         Reviewed by Carlos Garcia Campos.
1627
1628         * gtk/jhbuild.modules:
1629         Require ICU for libpsl build in jhbuild, like done in WPE.
1630
1631 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1632
1633         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1634         https://bugs.webkit.org/show_bug.cgi?id=194209
1635
1636         Reviewed by Carlos Garcia Campos.
1637
1638         Enhance TestCookieManager to ensure this doesn't happen again.
1639
1640         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1641         (testCookieManagerPersistentStorage):
1642         (beforeAll):
1643
1644 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1645
1646         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1647         https://bugs.webkit.org/show_bug.cgi?id=194324
1648
1649         Reviewed by Andy Estes.
1650
1651         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1652         part of the name is already implicit, since this is in testing code in TestOptions.
1653
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::TestController::generateContextConfiguration const):
1656         (WTR::updateTestOptionsFromTestHeader):
1657         * WebKitTestRunner/TestOptions.h:
1658         (WTR::TestOptions::hasSameInitializationOptions const):
1659
1660 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1661
1662         [ews-build] Allow * as platform for builders and workers
1663         https://bugs.webkit.org/show_bug.cgi?id=188533
1664
1665         Reviewed by Lucas Forschler.
1666
1667         * BuildSlaveSupport/ews-build/loadConfig.py:
1668         (checkWorkersAndBuildersForConsistency):
1669
1670 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1671
1672         [ews-build] Add few bots to config.json
1673         https://bugs.webkit.org/show_bug.cgi?id=194304
1674
1675         Reviewed by Lucas Forschler.
1676
1677         * BuildSlaveSupport/ews-build/config.json:
1678
1679 2019-02-05  Keith Rollin  <krollin@apple.com>
1680
1681         Enable the automatic checking and regenerations of .xcfilelists during builds
1682         https://bugs.webkit.org/show_bug.cgi?id=194124
1683         <rdar://problem/47721277>
1684
1685         Reviewed by Tim Horton.
1686
1687         Bug 193790 add a facility for checking -- during build time -- that
1688         any needed .xcfilelist files are up-to-date and for updating them if
1689         they are not. This facility was initially opt-in by setting
1690         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1691         the process seemed robust. Its now time to enable this facility and
1692         make it opt-out. If there is a need to disable this facility, set and
1693         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1694         running `make` or `build-webkit`, or before running Xcode from the
1695         command line.
1696
1697         Additionally, remove the step that generates a list of source files
1698         going into the UnifiedSources build step. It's only necessarily to
1699         specify Sources.txt and SourcesCocoa.txt as inputs.
1700
1701         * Scripts/generate-xcfilelists:
1702
1703 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1704
1705         [GTK][WPE] force libpsl build to use ICU in jhbuild
1706         https://bugs.webkit.org/show_bug.cgi?id=194288
1707
1708         Reviewed by Philippe Normand.
1709
1710         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1711         This can cause build failures if libidn is detected but libunistring is not available.
1712
1713         Make sure that ICU is used for runtime and builtin PSL data.
1714
1715         * gtk/jhbuild.modules:
1716         * wpe/jhbuild.modules:
1717
1718 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1719
1720         [ews-app] Modified timestamp should be updated on updating data
1721         https://bugs.webkit.org/show_bug.cgi?id=194295
1722
1723         Reviewed by Lucas Forschler.
1724
1725         * BuildSlaveSupport/ews-app/ews/models/build.py:
1726         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1727         * BuildSlaveSupport/ews-app/ews/models/step.py:
1728
1729 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1730
1731         Unreviewed, rolling out r240742.
1732
1733         Causes crashes on iOS simulator.
1734
1735         Reverted changeset:
1736
1737         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1738         not focused in a content-editable element"
1739         https://bugs.webkit.org/show_bug.cgi?id=192824
1740         https://trac.webkit.org/changeset/240742
1741
1742 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1743
1744         run-webkit-tests emits message "...running None" when running tests
1745         https://bugs.webkit.org/show_bug.cgi?id=194133
1746         <rdar://problem/47724738>
1747
1748         Reviewed by Lucas Forschler.
1749
1750         * Scripts/webkitpy/xcode/device_type.py:
1751         (DeviceType.__str__): Use both version mapping tables and use just the variant
1752         name if no version name is available.
1753         * Scripts/webkitpy/xcode/device_type_unittest.py:
1754         (DeviceTypeTest):
1755         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1756         an associated named.
1757
1758 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1759
1760         [WPE] require python3-setuptools for meson build in jhbuild
1761         https://bugs.webkit.org/show_bug.cgi?id=194287
1762
1763         Reviewed by Philippe Normand.
1764
1765         python3-setuptools is needed to build meson in jhbuild.
1766         It is already required by the GTK port.
1767
1768         * wpe/install-dependencies:
1769
1770 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1771
1772         [ews-app] Add method to save BuilderMapping to database
1773         https://bugs.webkit.org/show_bug.cgi?id=194264
1774
1775         Reviewed by Lucas Forschler.
1776
1777         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1778         (BuilderMapping.__str__):
1779         (BuilderMapping):
1780         (BuilderMapping.save_mapping):
1781         (BuilderMapping.update_mapping):
1782         (BuilderMapping.get_existing_mapping):
1783         (BuilderMapping.is_valid_mapping):
1784
1785 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1786
1787         [ews-app] Add timestamp fields for BuilderMappings
1788         https://bugs.webkit.org/show_bug.cgi?id=194266
1789
1790         Reviewed by Lucas Forschler.
1791
1792         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1793         (BuilderMapping):
1794
1795 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1796
1797         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1798         https://bugs.webkit.org/show_bug.cgi?id=174816
1799
1800         Reviewed by Michael Catanzaro.
1801
1802         Add tests for webkit_uri_for_display().
1803
1804         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1805         (testURIForDisplayUnaffected):
1806         (testURIForDisplayAffected):
1807         (beforeAll):
1808         (afterAll):
1809         * TestWebKitAPI/glib/CMakeLists.txt:
1810
1811 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1812
1813         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1814         https://bugs.webkit.org/show_bug.cgi?id=194158
1815         <rdar://problem/47737268>
1816
1817         Rubber-stamped by Aakash Jain.
1818
1819         * Scripts/webkitpy/port/device_port.py:
1820         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1821
1822 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1823
1824         [CG] Enable setAdditionalSupportedImageTypes for WK1
1825         https://bugs.webkit.org/show_bug.cgi?id=194190
1826
1827         Reviewed by Tim Horton.
1828
1829         Add a test similar to the one under WebKit Cocoa but make it create a
1830         WebView instead of a WKWebView.
1831
1832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1833         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1834         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1835         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1836         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1837         (TestWebKitAPI::runTest):
1838         (TestWebKitAPI::TEST):
1839
1840 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1841
1842         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1843         https://bugs.webkit.org/show_bug.cgi?id=194168
1844
1845         Reviewed by Simon Fraser.
1846
1847         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1851         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1852         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1853         (TEST):
1854         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1855         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1856
1857 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1858
1859         REGRESSION (r237269): webkit-patch what-broke is broken 
1860         https://bugs.webkit.org/show_bug.cgi?id=193025
1861
1862         Reviewed by Aakash Jain.
1863
1864         * Scripts/webkitpy/common/host.py:
1865         (Host.buildbot):
1866         (Host.bugzilla): Renamed to 'buildbot'.
1867
1868 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1869
1870         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1871         https://bugs.webkit.org/show_bug.cgi?id=194207
1872
1873         Reviewed by Tim Horton.
1874
1875         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1876         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1877         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1878         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1879         start and delete forwards to remove the original attachment.
1880
1881         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1882         (TestWebKitAPI::TEST):
1883
1884 2019-02-04  Youenn Fablet  <youenn@apple.com>
1885
1886         Capture state should be managed consistently when doing process swapping
1887         https://bugs.webkit.org/show_bug.cgi?id=194122
1888         <rdar://problem/47609293>
1889
1890         Reviewed by Eric Carlson.
1891
1892         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1893         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1894         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1895         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1896         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1898         (WTR::TestRunner::isDoingMediaCapture const):
1899         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1900         * WebKitTestRunner/TestController.cpp:
1901         (WTR::TestController::isDoingMediaCapture const):
1902         * WebKitTestRunner/TestController.h:
1903         * WebKitTestRunner/TestInvocation.cpp:
1904         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1905         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1906         (WTR::TestController::isDoingMediaCapture const):
1907
1908 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1909
1910         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1911         https://bugs.webkit.org/show_bug.cgi?id=194142
1912
1913         Reviewed by Ross Kirsling.
1914
1915         There three 'separator' variables in TestController.cpp. Renamed
1916         it 'pathSeparator', and unified them.
1917
1918         * WebKitTestRunner/TestController.cpp:
1919         (WTR::TestController::generateContextConfiguration const):
1920         (WTR::createTestURL):
1921         (WTR::TestController::platformAdjustContext):
1922
1923 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1924
1925         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1926         https://bugs.webkit.org/show_bug.cgi?id=194198
1927
1928         Reviewed by Antti Koivisto.
1929
1930         No need to set the banner heights on navigation now, since Page stores them.
1931
1932         * MiniBrowser/mac/WK2BrowserWindowController.m:
1933         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1934
1935 2019-02-03  John Wilander  <wilander@apple.com>
1936
1937         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1938         https://bugs.webkit.org/show_bug.cgi?id=194104
1939         <rdar://problem/47649991>
1940
1941         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1942
1943         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1944         (TestWebKitAPI::TEST):
1945             Changed numeric types from unsigned short to uint32_t.
1946
1947 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1948
1949         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1950         <https://webkit.org/b/194178>
1951         <rdar://problem/47753473>
1952
1953         Reviewed by Alexey Proskuryakov.
1954
1955         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1956         (WTR::uninstallFakeHelvetica): Pass nullptr into
1957         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1958
1959 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1960
1961         [LFC] Initialize ICB's style with fixed width/height.
1962         https://bugs.webkit.org/show_bug.cgi?id=194188
1963
1964         Reviewed by Antti Koivisto.
1965
1966         * LayoutReloaded/misc/LFC-passing-tests.txt:
1967
1968 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1969
1970         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1971         https://bugs.webkit.org/show_bug.cgi?id=194185
1972
1973         Reviewed by Antti Koivisto.
1974
1975         * LayoutReloaded/misc/LFC-passing-tests.txt:
1976
1977 2018-12-16  Darin Adler  <darin@apple.com>
1978
1979         Convert additional String::format clients to alternative approaches
1980         https://bugs.webkit.org/show_bug.cgi?id=192746
1981
1982         Reviewed by Alexey Proskuryakov.
1983
1984         * WebKitTestRunner/TestController.cpp:
1985         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1986         as an intermediate in code that ultimately constructs a WTF::String.
1987         (WTR::userMediaOriginHash): Use makeString.
1988         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1989         (WTR::TestController::didPerformClientRedirect): Ditto.
1990         (WTR::TestController::didPerformServerRedirect): Ditto.
1991         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1992
1993 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1994
1995         [ews-build] Add unit test to verify builder keys
1996         https://bugs.webkit.org/show_bug.cgi?id=194152
1997
1998         Reviewed by Lucas Forschler.
1999
2000         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2001         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2002
2003 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2004
2005         [LFC] Expand tests coverage (12 new tests -> 787)
2006
2007         Unreviewed test gardening.
2008
2009         * LayoutReloaded/misc/LFC-passing-tests.txt:
2010
2011 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2012
2013         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2014         https://bugs.webkit.org/show_bug.cgi?id=194163
2015
2016         Reviewed by Simon Fraser.
2017
2018         775
2019
2020         * LayoutReloaded/misc/LFC-passing-tests.txt:
2021
2022 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2023
2024         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2025         https://bugs.webkit.org/show_bug.cgi?id=194140
2026         <rdar://problem/47728098>
2027
2028         Reviewed by Tim Horton.
2029
2030         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2031         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2032         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2033
2034         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2035         test to induce an IPC deadlock when presenting a modal alert during touch start.
2036
2037         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2038         * WebKitTestRunner/TestController.cpp:
2039         (WTR::runJavaScriptAlert):
2040
2041         Add a client callback function for running JavaScript alerts.
2042
2043         (WTR::TestController::createOtherPage):
2044         (WTR::TestController::generateContextConfiguration const):
2045
2046         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2047         the fix in this patch.
2048
2049         (WTR::TestController::createWebViewWithOptions):
2050
2051         Plumb TestOptions to generateContextConfiguration.
2052
2053         (WTR::TestController::resetPreferencesToConsistentValues):
2054         (WTR::TestController::resetStateToConsistentValues):
2055         (WTR::updateTestOptionsFromTestHeader):
2056         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2057         (WTR::TestController::handleJavaScriptAlert):
2058         * WebKitTestRunner/TestController.h:
2059         * WebKitTestRunner/TestInvocation.cpp:
2060         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2061         * WebKitTestRunner/TestOptions.h:
2062         (WTR::TestOptions::hasSameInitializationOptions const):
2063
2064 2019-02-01  Chris Dumez  <cdumez@apple.com>
2065
2066         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2067         https://bugs.webkit.org/show_bug.cgi?id=193740
2068         <rdar://problem/47527267>
2069
2070         Reviewed by Alex Christensen.
2071
2072         Add API test coverage.
2073
2074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2075
2076 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2077
2078         [ews-app] Add display name field to BuilderMapping model
2079         https://bugs.webkit.org/show_bug.cgi?id=194153
2080
2081         Reviewed by Lucas Forschler.
2082
2083         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2084         (BuilderMapping):
2085
2086 2019-02-01  Youenn Fablet  <youenn@apple.com>
2087
2088         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2089         https://bugs.webkit.org/show_bug.cgi?id=194155
2090
2091         Reviewed by Eric Carlson.
2092
2093         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2094         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2095         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2096
2097 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2098
2099         [LFC] Adjust replaced element's intrinsic ratio
2100         https://bugs.webkit.org/show_bug.cgi?id=194154
2101
2102         Reviewed by Antti Koivisto.
2103
2104         761
2105
2106         * LayoutReloaded/misc/LFC-passing-tests.txt:
2107
2108 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2109
2110         [WPE] Show test results in minibrowser
2111         https://bugs.webkit.org/show_bug.cgi?id=194150
2112
2113         Reviewed by Žan Doberšek.
2114
2115         * Scripts/webkitpy/port/wpe.py:
2116         (WPEPort.show_results_html_file):
2117
2118 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2119
2120         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2121         https://bugs.webkit.org/show_bug.cgi?id=194151
2122
2123         Reviewed by Žan Doberšek.
2124
2125         ALT + <- go back
2126         ALT + -> go forward
2127
2128         * MiniBrowser/wpe/main.cpp:
2129         (main):
2130
2131 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2132
2133         [LFC] Set intrinsic size on Layout::Replaced
2134         https://bugs.webkit.org/show_bug.cgi?id=194139
2135
2136         Reviewed by Antti Koivisto.
2137
2138         744
2139
2140         * LayoutReloaded/misc/LFC-passing-tests.txt:
2141
2142 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2143
2144         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2145         https://bugs.webkit.org/show_bug.cgi?id=194146
2146
2147         Reviewed by Xabier Rodriguez-Calvar.
2148
2149         It allows to open relative paths.
2150
2151         * MiniBrowser/wpe/main.cpp:
2152         (main):
2153
2154 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2155
2156         Update flakiness dashboard configuration after recent queue changes
2157         https://bugs.webkit.org/show_bug.cgi?id=194127
2158
2159         Rubber-stamped by Aakash Jain.
2160
2161         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2162
2163         * TestResultServer/static-dashboards/builders.jsonp:
2164
2165 2019-01-31  Youenn Fablet  <youenn@apple.com>
2166
2167         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2168         https://bugs.webkit.org/show_bug.cgi?id=194106
2169         <rdar://problem/47676333>
2170
2171         Reviewed by Ryosuke Niwa.
2172
2173         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2174         (TestWebKitAPI::didFinishNavigation):
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2177
2178 2019-01-31  Chris Dumez  <cdumez@apple.com>
2179
2180         Page zoom level is lost after a process swap or a crash
2181         https://bugs.webkit.org/show_bug.cgi?id=194105
2182         <rdar://problem/47610781>
2183
2184         Reviewed by Alex Christensen.
2185
2186         Add API test coverage.
2187
2188         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2189         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2190
2191 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2192
2193         Revert r238819 which is unneeded and caused a performance regression.
2194         https://bugs.webkit.org/show_bug.cgi?id=192272
2195         <rdar://problem/46664625>
2196
2197         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2198         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2199         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2200
2201 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2202
2203         Formalize WebKitAdditions mechanism of LoadOptimizer
2204         https://bugs.webkit.org/show_bug.cgi?id=193886
2205         <rdar://problem/47696809>
2206
2207         Reviewed by Brent Fulgham.
2208
2209         * MiniBrowser/MiniBrowser.entitlements:
2210         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2211
2212 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2213
2214         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2215         https://bugs.webkit.org/show_bug.cgi?id=194090
2216
2217         Reviewed by Antti Koivisto.
2218
2219         * LayoutReloaded/misc/LFC-passing-tests.txt:
2220
2221 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2222
2223         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2224         https://bugs.webkit.org/show_bug.cgi?id=194074
2225
2226         Reviewed by Antti Koivisto.
2227
2228         * LayoutReloaded/misc/LFC-passing-tests.txt:
2229
2230 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2231
2232         [LFC][BFC] Add support for block level replaced box.
2233         https://bugs.webkit.org/show_bug.cgi?id=194071
2234
2235         Reviewed by Antti Koivisto.
2236
2237         * LayoutReloaded/misc/LFC-passing-tests.txt:
2238
2239 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2240
2241         Fix WebKitTestRunner's testPath with Windows full paths
2242         https://bugs.webkit.org/show_bug.cgi?id=194012
2243
2244         Reviewed by Alex Christensen.
2245
2246         updateTestOptionsFromTestHeader failed to open test files because
2247         testPath returned wrong file paths. It returned a path "/C:/..."
2248         if a URL "file:///C:/..." was given.
2249
2250         * WebKitTestRunner/TestController.cpp:
2251         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2252
2253 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2254
2255         [WPE] Bump font related dependencies to match the GTK+ port
2256         https://bugs.webkit.org/show_bug.cgi?id=194017
2257
2258         Reviewed by Žan Doberšek.
2259
2260         * wpe/jhbuild.modules:
2261         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2262         * wpe/patches/icudata-stdlibs.patch: Added.
2263
2264 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2265
2266         Enable swipe tests on iOS
2267         https://bugs.webkit.org/show_bug.cgi?id=194076
2268
2269         Reviewed by Geoffrey Garen.
2270
2271         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2272         it causes a debug assertion failure in runUIScript.
2273
2274         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2275         (WTR::UIScriptController::beginBackSwipe):
2276         (WTR::UIScriptController::completeBackSwipe):
2277
2278 2019-01-30  Keith Rollin  <krollin@apple.com>
2279
2280         Use correct printf format specifier
2281         https://bugs.webkit.org/show_bug.cgi?id=194062
2282         <rdar://problem/47686167>
2283
2284         Reviewed by Alexey Proskuryakov.
2285
2286         LayoutTestSpellChecker.mm is trying to format a variable of type
2287         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2288         actually an unsigned long long. Fix this by formatting with %llu.
2289
2290         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2291         (-[LayoutTestTextCheckingResult description]):
2292
2293 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2294
2295         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2296         https://bugs.webkit.org/show_bug.cgi?id=193979
2297
2298         Reviewed by Wenson Hsieh.
2299
2300         Fix the test for iOS. Make the test work with iOS UA string.
2301
2302         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2303
2304 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2305
2306         Replace High Sierra LLINT CLoop bot due to hardware failure
2307         https://bugs.webkit.org/show_bug.cgi?id=194066
2308
2309         Reviewed by Aakash Jain.
2310
2311         * BuildSlaveSupport/build.webkit.org-config/config.json:
2312
2313 2019-01-30  Keith Rollin  <krollin@apple.com>
2314
2315         [NSDragItem init] is unavailable
2316         https://bugs.webkit.org/show_bug.cgi?id=194059
2317         <rdar://problem/47685715>
2318
2319         Reviewed by Wenson Hsieh.
2320
2321         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2322         DumpRenderTree and TestWebKitAPI, which both try to create an
2323         NSDragItem in a manner that invokes this method. Address this by using
2324         -initWithPasteboardWriter instead.
2325
2326         Note that the parameter passed to initWithPasteboardWriter is likely
2327         incorrect. In both cases, the object passed does not conform to
2328         NSPasteboardWriting. However, with this fix, we're no worse off than
2329         before, and can now perform builds with newer compilers and SDKs until
2330         a real fix can be crafted. That work is tracked in
2331         https://bugs.webkit.org/show_bug.cgi?id=194060
2332
2333         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2334         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2335         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2336         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2337
2338 2019-01-30  Daniel Bates  <dabates@apple.com>
2339
2340         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2341         https://bugs.webkit.org/show_bug.cgi?id=192824
2342         <rdar://problem/47100332>
2343
2344         Reviewed by Wenson Hsieh.
2345
2346         Fix a bug where the wrong usage code was used for F13 thru F24.
2347
2348         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2349         (keyCodeForDOMFunctionKey):
2350
2351 2019-01-30  Chris Dumez  <cdumez@apple.com>
2352
2353         Regression(PSON) Load hang can occur on history navigation
2354         https://bugs.webkit.org/show_bug.cgi?id=194030
2355         <rdar://problem/47656939>
2356
2357         Reviewed by Antti Koivisto.
2358
2359         Add API test coverage.
2360
2361         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2362
2363 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2364
2365         [LFC] Expand tests coverage.
2366
2367         Unreviewed test gardening.
2368
2369         * LayoutReloaded/misc/LFC-passing-tests.txt:
2370
2371 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2372
2373         [Flatpak] Add openjpeg support
2374         https://bugs.webkit.org/show_bug.cgi?id=194019
2375
2376         Reviewed by Michael Catanzaro.
2377
2378         * flatpak/org.webkit.CommonModules.yaml:
2379
2380 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2381
2382         Unreviewed, rolling out r240708.
2383         https://bugs.webkit.org/show_bug.cgi?id=194022
2384
2385         It broke WPE build (Requested by KaL on #webkit).
2386
2387         Reverted changeset:
2388
2389         "[WPE] Bump font related dependencies to match the GTK+ port"
2390         https://bugs.webkit.org/show_bug.cgi?id=194017
2391         https://trac.webkit.org/changeset/240708
2392
2393 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2394
2395         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2396         https://bugs.webkit.org/show_bug.cgi?id=194001
2397
2398         Reviewed by Antti Koivisto.
2399
2400         * LayoutReloaded/misc/LFC-passing-tests.txt:
2401
2402 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2403
2404         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2405         https://bugs.webkit.org/show_bug.cgi?id=194020
2406
2407         Reviewed by Antti Koivisto.
2408
2409         * LayoutReloaded/misc/LFC-passing-tests.txt:
2410
2411 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2412
2413         AX: Support color well on iOS
2414         https://bugs.webkit.org/show_bug.cgi?id=194010
2415
2416         Reviewed by Joanmarie Diggs.
2417
2418         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2419         (WTR::AccessibilityUIElement::stringAttributeValue):
2420
2421 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2422
2423         [WPE] Bump font related dependencies to match the GTK+ port
2424         https://bugs.webkit.org/show_bug.cgi?id=194017
2425
2426         Reviewed by Žan Doberšek.
2427
2428         * wpe/jhbuild.modules:
2429         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2430         * wpe/patches/icudata-stdlibs.patch: Added.
2431
2432 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2433
2434         [Mac] Update window scale API usage
2435         https://bugs.webkit.org/show_bug.cgi?id=193991
2436         rdar://problem/47614795
2437
2438         Reviewed by Tim Horton.
2439
2440         * DumpRenderTree/mac/DumpRenderTree.mm:
2441         (changeWindowScaleIfNeeded):
2442         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2443         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2444         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2445
2446 2019-01-29  Chris Dumez  <cdumez@apple.com>
2447
2448         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2449         https://bugs.webkit.org/show_bug.cgi?id=193977
2450         <rdar://problem/47643716>
2451
2452         Reviewed by Geoff Garen.
2453
2454         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2455         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2456         to the previous provisional committing *before* we make the last load. 
2457
2458         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2459
2460 2019-01-29  Youenn Fablet  <youenn@apple.com>
2461
2462         Adopt new SPI to evaluate server certificate trust
2463         https://bugs.webkit.org/show_bug.cgi?id=193355
2464
2465         Reviewed by Alex Christensen.
2466
2467         Add infrastructure to handle HTTPS server trust evaluation testing.
2468
2469         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2471         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2472         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2473         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2474         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2475         * WebKitTestRunner/TestController.cpp:
2476         (WTR::TestController::resetPreferencesToConsistentValues):
2477         (WTR::TestController::didReceiveAuthenticationChallenge):
2478         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2479         * WebKitTestRunner/TestController.h:
2480         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2481         * WebKitTestRunner/TestInvocation.cpp:
2482         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2483         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2484         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2485
2486 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2487
2488         [ews-build] Add build step to print bot Configuration
2489         https://bugs.webkit.org/show_bug.cgi?id=193887
2490
2491         Reviewed by Lucas Forschler.
2492
2493         * BuildSlaveSupport/ews-build/steps.py:
2494         (PrintConfiguration): Build step to print configuration.
2495         * BuildSlaveSupport/ews-build/factories.py:
2496
2497 2019-01-29  Chris Dumez  <cdumez@apple.com>
2498
2499         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2500         https://bugs.webkit.org/show_bug.cgi?id=193967
2501         <rdar://problem/47635348>
2502
2503         Reviewed by Alex Christensen.
2504
2505         Add API test coverage.
2506
2507         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2508         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2509
2510 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2511
2512         [ews-app] Handle incoming results data
2513         https://bugs.webkit.org/show_bug.cgi?id=193973
2514
2515         Reviewed by Lucas Forschler.
2516
2517         * BuildSlaveSupport/ews-app/ews/views/results.py:
2518
2519 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2520
2521         [ews-app] Make the results url generic
2522         https://bugs.webkit.org/show_bug.cgi?id=193928
2523
2524         Reviewed by Lucas Forschler.
2525
2526         * BuildSlaveSupport/ews-app/ews/urls.py:
2527
2528 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2529
2530         [ews-build] Configure buildbot to send events to ews-app
2531         https://bugs.webkit.org/show_bug.cgi?id=193968
2532
2533         Reviewed by Lucas Forschler.
2534
2535         * BuildSlaveSupport/ews-build/events.py: Added.
2536         * BuildSlaveSupport/ews-build/master.cfg:
2537
2538 2019-01-29  Keith Rollin  <krollin@apple.com>
2539
2540         Add .xcfilelists to Run Script build phases
2541         https://bugs.webkit.org/show_bug.cgi?id=193792
2542         <rdar://problem/47201785>
2543
2544         Reviewed by Alex Christensen.
2545
2546         As part of supporting XCBuild, update the necessary Run Script build
2547         phases in their Xcode projects to refer to their associated
2548         .xcfilelist files.
2549
2550         Note that the addition of these files bumps the Xcode project version
2551         number to something that's Xcode 10 compatible. This change means that
2552         older versions of the Xcode IDE can't read these projects. Nor can it
2553         fully load workspaces that refer to these projects (the updated
2554         projects are shown as non-expandable placeholders). `xcodebuild` can
2555         still build these projects; it's just that the IDE can't open them.
2556
2557         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2558         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2559
2560 2019-01-29  John Wilander  <wilander@apple.com>
2561
2562         Add data abstraction and validation for Ad Click Attribution
2563         https://bugs.webkit.org/show_bug.cgi?id=193916
2564         <rdar://problem/47603481>
2565
2566         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2567
2568         Ad click attribution has two steps. First, the storage of an ad
2569         campaign ID for a click that takes the user to a destination
2570         site. Second, a conversion on the destination site that can be
2571         attributed to the ad click.
2572
2573         This patch adds a class that represents a request for ad click
2574         attribution. Validation makes sure that the bits of entropy
2575         reported through this mechanism is limited.
2576
2577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2578         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2579         (TestWebKitAPI::TEST):
2580
2581 2019-01-29  Chris Dumez  <cdumez@apple.com>
2582
2583         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2584         https://bugs.webkit.org/show_bug.cgi?id=193932
2585         <rdar://problem/47598947>
2586
2587         Reviewed by Brady Eidson.
2588
2589         Add API test coverage.
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2592
2593 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2594
2595         Adding new passing LFC tests.
2596
2597         Unreviewed test gardening.
2598
2599         * LayoutReloaded/misc/LFC-passing-tests.txt:
2600
2601 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2602
2603         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2604         https://bugs.webkit.org/show_bug.cgi?id=193964
2605
2606         Reviewed by Antti Koivisto.
2607
2608         * LayoutReloaded/misc/LFC-passing-tests.txt:
2609
2610 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2611
2612         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2613         https://bugs.webkit.org/show_bug.cgi?id=193954
2614
2615         Reviewed by Antti Koivisto.
2616
2617         * LayoutReloaded/misc/LFC-passing-tests.txt:
2618
2619 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2620
2621         WebDriver: add support for running subtests
2622         https://bugs.webkit.org/show_bug.cgi?id=193904
2623
2624         Reviewed by Michael Catanzaro.
2625
2626         pytest already supports it by passing test.py::subtest, so we can do the same.
2627
2628         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2629         (get_item_name): Made this global.
2630         (CollectRecorder.__init__): Receive the parameter to ignore.
2631         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2632         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2633         (collect): Add parameter to ignore.
2634         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2635         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2636         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2637         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2638         (WebDriverTestRunnerSelenium.run): Ditto.
2639         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2640         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2641         (WebDriverTestRunnerW3C.run): Ditto.
2642
2643 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2644
2645         User agent string override for navigator.userAgent should be site specific quirks
2646         https://bugs.webkit.org/show_bug.cgi?id=193950
2647
2648         Reviewed by Brent Fulgham.
2649
2650         Updated per the _WKWebsitePolicies rename.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2653         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2654
2655 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2656
2657         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2658         https://bugs.webkit.org/show_bug.cgi?id=193941
2659
2660         Reviewed by Alex Christensen.
2661
2662         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2663         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2664         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2665         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2666         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2667         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2668         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2669         * TestWebKitAPI/Tests/WTF/Time.cpp:
2670         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2671         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2672         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2673         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2674
2675 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2676
2677         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2678
2679         * Scripts/webkitpy/common/config/contributors.json:
2680
2681 2019-01-28  Andy Estes  <aestes@apple.com>
2682
2683         [watchOS] Enable Parental Controls content filtering
2684         https://bugs.webkit.org/show_bug.cgi?id=193939
2685         <rdar://problem/46641912>
2686
2687         Reviewed by Ryosuke Niwa.
2688
2689         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2690
2691 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2692
2693         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2694         <https://webkit.org/b/193884>
2695
2696         Reviewed by Jiewen Tan.
2697
2698         * Scripts/webkitpy/style/checkers/cpp.py:
2699         (check_language): Add LocalAuthentication to
2700         `frameworks_with_soft_links`.
2701
2702 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2703
2704         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2705         https://bugs.webkit.org/show_bug.cgi?id=193891
2706
2707         Reviewed by Ross Kirsling.
2708
2709         There were three problems in window sizes of WebView and the host window.
2710         1. The sizes of pixel image output were incorrect.
2711         2. The host window is going to appear after window.resize was invoked.
2712         3. window.resize resized only the host window, not WebView.
2713
2714         This change solves them with a following approach.
2715         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2716         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2717            as well as DumpRenderTree in order to match the client area and the window area.
2718         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2719         d. PlatformWebView::setWindowFrame changes both window sizes.
2720         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2721
2722         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2723         (WTR::PlatformWebView::PlatformWebView): Create the host window
2724         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2725         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2726         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2727
2728 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2729
2730         [ews-app] Add method to save Step data to database
2731         https://bugs.webkit.org/show_bug.cgi?id=193890
2732
2733         Reviewed by Lucas Forschler.
2734
2735         * BuildSlaveSupport/ews-app/ews/models/step.py:
2736         (Step.save_step): Method to save step data.
2737         (Step.update_step): Method to update step data.
2738         (Step.get_existing_step): Method to fetch existing step from database.
2739         (Step.is_valid_result): Method to validate valid step result.
2740
2741 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2742
2743         [ews-app] Add method to save Build data to database
2744         https://bugs.webkit.org/show_bug.cgi?id=193735
2745
2746         Reviewed by Lucas Forschler.
2747
2748         * BuildSlaveSupport/ews-app/ews/models/build.py:
2749         (Build.save_build): Method to save build information to database.
2750         (Build.get_existing_build): Method to fetch existing build from database.
2751         (Build.is_valid_result): Method to validate build result.
2752         * BuildSlaveSupport/ews-app/ews/common/util.py:
2753         (is_valid_int_id): Method to validate valid id.
2754
2755 2019-01-28  Chris Dumez  <cdumez@apple.com>
2756
2757         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2758         https://bugs.webkit.org/show_bug.cgi?id=193915
2759         <rdar://problem/47560907>
2760
2761         Reviewed by Alex Christensen.
2762
2763         Add API test coverage.
2764
2765         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2766
2767 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2768
2769         [ews-app] Rename id variables
2770         https://bugs.webkit.org/show_bug.cgi?id=193883
2771
2772         Reviewed by Lucas Forschler.
2773
2774         * BuildSlaveSupport/ews-app/ews/models/build.py:
2775         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2776         * BuildSlaveSupport/ews-app/ews/models/step.py:
2777         * BuildSlaveSupport/ews-app/ews/urls.py:
2778         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2779         * BuildSlaveSupport/ews-app/ews/views/results.py:
2780         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2781
2782 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2783
2784         [ews-app] Allow certain fields to be empty
2785         https://bugs.webkit.org/show_bug.cgi?id=193892
2786
2787         Reviewed by Lucas Forschler.
2788
2789         * BuildSlaveSupport/ews-app/ews/models/build.py:
2790         * BuildSlaveSupport/ews-app/ews/models/step.py:
2791
2792 2019-01-28  Rob Buis  <rbuis@igalia.com>
2793
2794         Update MIME type parser
2795         https://bugs.webkit.org/show_bug.cgi?id=180526
2796
2797         Reviewed by Frédéric Wang.
2798
2799         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2800         (TestWebKitAPI::TEST):
2801
2802 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2803
2804         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2805         https://bugs.webkit.org/show_bug.cgi?id=193896
2806
2807         Reviewed by Antti Koivisto.
2808
2809         * LayoutReloaded/misc/LFC-passing-tests.txt:
2810
2811 2018-12-15  Darin Adler  <darin@apple.com>
2812
2813         Replace many uses of String::format with more type-safe alternatives
2814         https://bugs.webkit.org/show_bug.cgi?id=192742
2815
2816         Reviewed by Mark Lam.
2817
2818         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2819         (WTR::cacheTestRunnerCallback): Use makeString.
2820         * WebKitTestRunner/TestController.cpp:
2821         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2822         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2823
2824 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2825
2826         Use a load optimizer for some sites
2827         https://bugs.webkit.org/show_bug.cgi?id=193881
2828         <rdar://problem/46325455>
2829
2830         Reviewed by Brent Fulgham.
2831
2832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2833         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2834
2835 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2836
2837         AX: Introduce a static accessibility tree
2838         https://bugs.webkit.org/show_bug.cgi?id=193348
2839         <rdar://problem/47203295>
2840
2841         Reviewed by Ryosuke Niwa.
2842
2843         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2844
2845 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2846
2847         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2848         https://bugs.webkit.org/show_bug.cgi?id=193867
2849
2850         Reviewed by Antti Koivisto.
2851
2852         * LayoutReloaded/misc/LFC-passing-tests.txt:
2853
2854 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2855
2856         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2857         https://bugs.webkit.org/show_bug.cgi?id=193865
2858
2859         Reviewed by Antti Koivisto.
2860
2861         * LayoutReloaded/misc/LFC-passing-tests.txt:
2862
2863 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2864
2865         Need a mechanism to override navigator.userAgent
2866         https://bugs.webkit.org/show_bug.cgi?id=193762
2867         <rdar://problem/47504939>
2868
2869         Reviewed by Brent Fulgham.
2870
2871         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2872
2873         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2874         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2875         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2876
2877 2019-01-25  Dean Jackson  <dino@apple.com>
2878
2879         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2880         https://bugs.webkit.org/show_bug.cgi?id=193831
2881         <rdar://problem/47399263>
2882
2883         Reviewed by Chris Dumez.
2884
2885         Two new tests that exercise cross-origin and same-origin System
2886         Previews.
2887
2888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2889
2890 2019-01-25  Keith Rollin  <krollin@apple.com>
2891
2892         Update Xcode projects with "Check .xcfilelists" build phase
2893         https://bugs.webkit.org/show_bug.cgi?id=193790
2894         <rdar://problem/47201374>
2895
2896         Reviewed by Alex Christensen.
2897
2898         Support for XCBuild includes specifying inputs and outputs to various
2899         Run Script build phases. These inputs and outputs are specified as
2900         .xcfilelist files. Once created, these .xcfilelist files need to be
2901         kept up-to-date. In order to check that they are up-to-date or not,
2902         add an Xcode build step that invokes an external script that performs
2903         the checking. If the .xcfilelists are found to be out-of-date, update
2904         them, halt the build, and instruct the developer to restart the build
2905         with up-to-date files.
2906
2907         At this time, the checking and regenerating is performed only if the
2908         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2909         who want to use this facility can set this variable and test out the
2910         checking/regenerating. Once it seems like there are no egregious
2911         issues that upset a developer's workflow, we'll unconditionally enable
2912         this facility.
2913
2914         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2915         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2916         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2917         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2918
2919 2019-01-25  Keith Rollin  <krollin@apple.com>
2920
2921         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2922         https://bugs.webkit.org/show_bug.cgi?id=193781
2923         <rdar://problem/47201153>
2924
2925         Reviewed by Alex Christensen.
2926
2927         Part of generating the .xcfilelists used as part of adopting XCBuild
2928         includes running `make DerivedSources.make` from a standalone script.
2929         It’s important for this invocation to have the same environment as
2930         when the actual build invokes `make DerivedSources.make`. If the
2931         environments are different, then the two invocations will provide
2932         different results. In order to get the same environment in the
2933         standalone script, have the script launch xcodebuild targeting the
2934         "Apply Configuration to XCFileLists" build target, which will then
2935         re-invoke our standalone script. The script is now running again, this
2936         time in an environment with all workspace, project, target, xcconfig
2937         and other environment variables established.
2938
2939         The "Apply Configuration to XCFileLists" build target accomplishes
2940         this task via a small embedded shell script that consists only of:
2941
2942             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2943
2944         The process that invokes "Apply Configuration to XCFileLists" first
2945         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2946         evaluated and exports it into the shell environment. When xcodebuild
2947         is invoked, it inherits the value of this variable and can `eval` the
2948         contents of that variable. Our external standalone script can then set
2949         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2950         of command-line parameters needed to restart itself in the appropriate
2951         state.
2952
2953         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2954         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2955
2956 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2957
2958         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2959         https://bugs.webkit.org/show_bug.cgi?id=193802
2960         <rdar://problem/46010580>
2961
2962         Reviewed by Andy Estes.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2965         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2966         (TEST):
2967
2968 2019-01-25  Daniel Bates  <dabates@apple.com>
2969
2970         [iOS] uiController.keyDown() does not translate Control modified key
2971         https://bugs.webkit.org/show_bug.cgi?id=192898
2972
2973         Reviewed by Wenson Hsieh.
2974
2975         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2976         key translation, as applicable. Among other cases, key translation occurs when performing
2977         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2978         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2979         human pressing down and releasing key(s) using a hardware keyboard.
2980
2981         * WebKitTestRunner/ios/HIDEventGenerator.h:
2982         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2983         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2984
2985         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2986         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2987         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2988         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2989         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2990         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2991         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2992         (-[HIDEventGenerator longPress:completionBlock:]):
2993         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2994         Update code for above renaming.
2995
2996         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2997         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2998
2999         (-[HIDEventGenerator keyDown:]): Added.
3000         (-[HIDEventGenerator keyUp:]): Added.
3001         (-[HIDEventGenerator keyPress:completionBlock:]):
3002         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3003         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3004         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3005         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3006         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3007         (WTR::parseModifier): Deleted.
3008
3009 2019-01-25  Keith Rollin  <krollin@apple.com>
3010
3011         Complete the implementation of generate-xcfilelists
3012         https://bugs.webkit.org/show_bug.cgi?id=193782
3013
3014         Reviewed by Alex Christensen.
3015
3016         A preliminary version of generate-xcfilelists was added in r238008.
3017         This patch updates that script in order to:
3018
3019         - Support checking of .xcfilelists
3020         - Perform better execution of `make DerivedSources.make` by
3021           relaunching generate-xcfilelists under xcodebuild
3022         - Support incremental generation and checking of .xcfilelists
3023         - Support supplementary .xcfilelists files from WebKitAdditions
3024         - Support being wrapped by parallel version of generate-xcfilelists in
3025           Internal that adds support for (re)generating WebKit projects in
3026           that repo.
3027         - Support builds that have been performed in WebKitBuild as well as
3028           ~/Library/Developer/code/DerivedData
3029         - Increase robustness and debugging facilities.
3030
3031         * Scripts/generate-xcfilelists:
3032
3033 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3034
3035         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3036         https://bugs.webkit.org/show_bug.cgi?id=193297
3037         <rdar://problem/47158841>
3038
3039         Unreviewed test case fix.
3040
3041         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3042         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3043
3044         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3045         (TEST):
3046
3047 2019-01-25  Keith Rollin  <krollin@apple.com>
3048
3049         Update existing .xcfilelists
3050         https://bugs.webkit.org/show_bug.cgi?id=193791
3051         <rdar://problem/47201706>
3052
3053         Reviewed by Alex Christensen.
3054
3055         Many .xcfilelist files were added in r238824 in order to support
3056         XCBuild. Update these with recent changes to the set of build files
3057         and with the current generate-xcfilelist script.
3058
3059         * DumpRenderTree/DerivedSources-input.xcfilelist:
3060         * DumpRenderTree/DerivedSources-output.xcfilelist:
3061         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3062         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3063
3064 2019-01-25  Keith Rollin  <krollin@apple.com>
3065
3066         Fix missing dependencies in extract-dependencies-from-makefile
3067         https://bugs.webkit.org/show_bug.cgi?id=193783
3068         <rdar://problem/47201571>
3069
3070         Reviewed by Alex Christensen.
3071
3072         The extract-dependencies-from-makefile script generates .xcfilelists
3073         for XCBuild by invoking a makefile in --debug mode, parsing the
3074         dependency information in the output, and extracting information
3075         regarding targets and dependents. However, the way `make` emits this
3076         dependency information is not rigorous, and so we need to determine
3077         what lines to look for and parse by trial and error. This approach
3078         didn't coriginally atch all the information we needed to collect, so
3079         update the script to look for the additional lines we now know to look
3080         for.
3081
3082         * Scripts/extract-dependencies-from-makefile:
3083         (Parser):
3084         (Parser.addTarget):
3085         (Parser.addPrereq):
3086         (Parser.doParse):
3087
3088 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3089
3090         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3091         https://bugs.webkit.org/show_bug.cgi?id=193297
3092         <rdar://problem/47158841>
3093
3094         Reviewed by Alex Christensen.
3095
3096         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3097             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3099         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3100         activating the message used to trigger the callback when it is set.
3101
3102 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3103
3104         WKWebView.goBack should reload if there is a safe browsing warning
3105         https://bugs.webkit.org/show_bug.cgi?id=193805
3106         <rdar://problem/46908216>
3107
3108         Reviewed by Geoff Garen.
3109
3110         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3111         (+[Simple3LookupContext sharedLookupContext]):
3112         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3113         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3114         (TEST):
3115
3116 2019-01-25  Chris Dumez  <cdumez@apple.com>
3117
3118         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3119         https://bugs.webkit.org/show_bug.cgi?id=193788
3120         <rdar://problem/47531231>
3121
3122         Reviewed by Alex Christensen.
3123
3124         Add API test coverage.
3125
3126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3127         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3128
3129 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3130
3131         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3132         https://bugs.webkit.org/show_bug.cgi?id=193771
3133
3134         Unreviewed infrastructure fix.
3135
3136         * Scripts/webkitpy/port/darwin.py:
3137         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3138
3139 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3140
3141         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3142
3143 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3144
3145         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3146
3147         * Scripts/webkitpy/common/config/contributors.json:
3148
3149 2019-01-25  Chris Dumez  <cdumez@apple.com>
3150
3151         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3152         https://bugs.webkit.org/show_bug.cgi?id=193779
3153         <rdar://problem/46170903>
3154
3155         Reviewed by Antti Koivisto.
3156
3157         Add API test that quickly navigates forward to a previous process without waiting for it to
3158         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3159         the process' previous page when reconnecting the it for the forward navigation.
3160
3161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3162
3163 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3164
3165         Need a way for JavaScript (or bundle) code to participate in undo
3166         https://bugs.webkit.org/show_bug.cgi?id=190009
3167         <rdar://problem/44807048>
3168
3169         Reviewed by Ryosuke Niwa.
3170
3171         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3172         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3173
3174         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3175         (WTR::UIScriptController::lastUndoLabel const):
3176         (WTR::UIScriptController::firstRedoLabel const):
3177         (WTR::UIScriptController::platformUndoManager const):
3178         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3179         (WTR::UIScriptController::lastUndoLabel const):
3180         (WTR::UIScriptController::firstRedoLabel const):
3181         (WTR::UIScriptController::platformUndoManager const):
3182         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3183         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3184         (WTR::UIScriptController::lastUndoLabel const):
3185         (WTR::UIScriptController::firstRedoLabel const):
3186         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3187         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3188         (WTR::UIScriptController::lastUndoLabel const):
3189         (WTR::UIScriptController::firstRedoLabel const):
3190         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3191         (WTR::UIScriptController::platformUndoManager const):
3192         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3193         (WTR::UIScriptController::platformUndoManager const):
3194
3195 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3196
3197         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3198         https://bugs.webkit.org/show_bug.cgi?id=193824
3199
3200         Reviewed by Antti Koivisto.
3201
3202         * LayoutReloaded/misc/LFC-passing-tests.txt:
3203
3204 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3205
3206         Update macOS JSC bot configurations
3207         https://bugs.webkit.org/show_bug.cgi?id=193739
3208
3209         Reviewed by Alexey Proskuryakov.
3210
3211         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3213         (BubbleQueueServer): Move JSC EWS to Mojave section.
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3215         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3216         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3217
3218 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3219
3220         [Win][WebKitTestRunner] Implement EventSenderProxy
3221         https://bugs.webkit.org/show_bug.cgi?id=193755
3222
3223         Reviewed by Don Olmstead.
3224
3225         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3226         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3227         (WTR::EventSenderProxy::dispatchMessage):
3228         (WTR::EventSenderProxy::EventSenderProxy):
3229         (WTR::EventSenderProxy::mouseDown):
3230         (WTR::EventSenderProxy::mouseUp):
3231         (WTR::EventSenderProxy::mouseMoveTo):
3232         (WTR::EventSenderProxy::mouseScrollBy):
3233         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3234
3235 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3236
3237         Unreviewed fix for API test failure after r240437.
3238
3239         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3240
3241         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3242
3243 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3244
3245         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3246         https://bugs.webkit.org/show_bug.cgi?id=193787
3247         <rdar://problem/47497634>
3248
3249         Reviewed by Alexey Proskuryakov.
3250
3251         * Scripts/webkitdirs.pm:
3252         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3253
3254 2019-01-24  Truitt Savell  <tsavell@apple.com>
3255
3256         Unreviewed, rolling out r240446.
3257
3258         Casued 5 API failures
3259
3260         Reverted changeset:
3261
3262         "Activate the WebResourceLoadStatisticsStore in the
3263         NetworkProcess and deactivate it in the UIProcess."
3264         https://bugs.webkit.org/show_bug.cgi?id=193297
3265         https://trac.webkit.org/changeset/240446
3266
3267 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3268
3269         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3270         https://bugs.webkit.org/show_bug.cgi?id=193741
3271         <rdar://problem/47135030>
3272
3273         Reviewed by Antti Koivisto and Simon Fraser.
3274
3275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3276         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3277         (TestWebKitAPI::TEST):
3278
3279 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3280
3281         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3282         https://bugs.webkit.org/show_bug.cgi?id=193297
3283         <rdar://problem/47158841>
3284
3285         Reviewed by Alex Christensen.
3286
3287         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3288         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3289         activating the message used to trigger the callback when it is set.
3290
3291 2019-01-24  John Wilander  <wilander@apple.com>
3292
3293         Add Ad Click Attribution as an internal/experimental feature
3294         https://bugs.webkit.org/show_bug.cgi?id=193685
3295         <rdar://problem/47450399>
3296
3297         Reviewed by Brent Fulgham.
3298
3299         Added test option adClickAttributionEnabled.
3300
3301         * DumpRenderTree/TestOptions.cpp:
3302         (TestOptions::TestOptions):
3303         * DumpRenderTree/TestOptions.h:
3304         * DumpRenderTree/mac/DumpRenderTree.mm:
3305         (setWebPreferencesForTestOptions):
3306
3307 2019-01-24  Antti Koivisto  <antti@apple.com>
3308
3309         [PSON] Flash on back navigation on Mac
3310         https://bugs.webkit.org/show_bug.cgi?id=193716
3311         <rdar://problem/47148458>
3312
3313         Reviewed by Chris Dumez.
3314
3315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3316
3317         Closing of the previous page is delayed so waiting for didFinishNavigation is
3318         not sufficient to guarantee we have received all the messages. Wait for them.
3319
3320 2019-01-24  Chris Dumez  <cdumez@apple.com>
3321
3322         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3323         https://bugs.webkit.org/show_bug.cgi?id=193761
3324         <rdar://problem/47456405>
3325
3326         Reviewed by Alex Christensen.
3327
3328         Add API test coverage.
3329
3330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3331
3332 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3333
3334         webkitpy: Missing PID in crashlog name should not be fatal
3335         https://bugs.webkit.org/show_bug.cgi?id=193771
3336
3337         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3338         of raising an exception.
3339
3340         Reviewed by Lucas Forschler.
3341
3342         * Scripts/webkitpy/port/darwin.py:
3343         (DarwinPort._merge_crash_logs):
3344
3345 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3346
3347         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3348         https://bugs.webkit.org/show_bug.cgi?id=193746
3349
3350         Reviewed by Youenn Fablet.
3351
3352         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3353         so we'd best just not call it.
3354
3355         * Scripts/webkitpy/w3c/test_exporter.py:
3356         (WebPlatformTestExporter.create_branch_with_patch):
3357
3358 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3359
3360         Move FileSystem to WTF
3361         https://bugs.webkit.org/show_bug.cgi?id=193602
3362
3363         Reviewed by Yusuke Suzuki.
3364
3365         * DumpRenderTree/win/DumpRenderTree.cpp:
3366         * TestWebKitAPI/CMakeLists.txt:
3367         * TestWebKitAPI/PlatformGTK.cmake:
3368         * TestWebKitAPI/PlatformJSCOnly.cmake:
3369         * TestWebKitAPI/PlatformPlayStation.cmake:
3370         * TestWebKitAPI/PlatformWPE.cmake:
3371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3372         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3373         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3374         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3375         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3376         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3377         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3378         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3379         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3380         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3381
3382 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3383
3384         [WPE] Remove hard dependency on subprocess32 for the API tests
3385
3386         Rubber-stamped by Carlos Garcia Campos.
3387
3388         * glib/api_test_runner.py:
3389         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3390         its presence only when running WPEQt tests.
3391
3392 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3393
3394         [GLIB] Expose JavaScriptCore options in GLib public API
3395         https://bugs.webkit.org/show_bug.cgi?id=188742
3396
3397         Reviewed by Michael Catanzaro.
3398
3399         Add a test for the new API.
3400
3401         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3402         (testsJSCOptions):
3403         (main):
3404
3405 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3406
3407         [GTK][WPE] Support JPEG 2000 images
3408         https://bugs.webkit.org/show_bug.cgi?id=186272
3409
3410         Reviewed by Žan Doberšek.
3411
3412         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3413
3414         * gtk/jhbuild.modules:
3415         * wpe/jhbuild.modules:
3416
3417 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3418
3419         check-webkit-style should warn when using soft-linking macros in a header
3420         <https://webkit.org/b/193750>
3421
3422         Reviewed by Darin Adler.
3423
3424         * Scripts/webkitpy/style/checkers/cpp.py:
3425         (check_language): Add softlink/header check by refactoring the
3426         softlink/framework check.
3427         (CppChecker): Enable softlink/header check by default.
3428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3429         (CppStyleTest.test_softlink_framework): Rename from
3430         CppStyleTest.test_softlink() and change test framework name in
3431         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3432         files. Set file_name for macros that only appear in headers.
3433         (CppStyleTest.test_softlink_header): Add tests for using
3434         soft-link macros in headers.
3435
3436 2019-01-23  Chris Dumez  <cdumez@apple.com>
3437
3438         Deprecate API to limit the maximum number of WebProcesses
3439         https://bugs.webkit.org/show_bug.cgi?id=193725
3440         <rdar://problem/47464879>
3441
3442         Reviewed by Geoff Garen.
3443
3444         Update existing API tests to stop using deprecated API.
3445
3446         * MiniBrowser/mac/AppDelegate.m:
3447         (defaultConfiguration):
3448         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3449         (TestWebKitAPI::TEST):
3450         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3451         (TestWebKitAPI::TEST):
3452         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3453         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3454         (TEST):
3455         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3456         (TEST):
3457
3458 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3459
3460         [ews-app] Rename ews model buildermappings to buildermapping
3461         https://bugs.webkit.org/show_bug.cgi?id=193729
3462
3463         Reviewed by Lucas Forschler.
3464
3465         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3466         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3467         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3468
3469 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3470
3471         [ews-app] Rename ews model steps to step
3472         https://bugs.webkit.org/show_bug.cgi?id=193697
3473
3474         Reviewed by Lucas Forschler.
3475
3476         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3477         (Step): Renamed Steps to Step.
3478
3479 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3480
3481         Clean up IndexedDB files between tests
3482         https://bugs.webkit.org/show_bug.cgi?id=192796
3483         <rdar://problem/46824999>
3484
3485         Reviewed by Geoffrey Garen.
3486
3487         * DumpRenderTree/mac/DumpRenderTree.mm:
3488         (runTest):
3489         * WebKitTestRunner/TestController.cpp:
3490         (WTR::TestController::resetStateToConsistentValues):
3491         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3492         (WTR::RemoveAllIndexedDatabasesCallback):
3493         (WTR::TestController::ClearIndexedDatabases):
3494         * WebKitTestRunner/TestController.h:
3495         * WebKitTestRunner/TestInvocation.cpp:
3496         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3497
3498 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-app] Rename ews model Builds to Build
3501         https://bugs.webkit.org/show_bug.cgi?id=193695
3502
3503         Reviewed by Lucas Forschler.
3504
3505         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3506         (Build): Renamed Builds to Build.
3507
3508 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3509
3510         webkitpy: Wait longer when launching WebKitTestRunner
3511         https://bugs.webkit.org/show_bug.cgi?id=193734
3512
3513         Reviewed by Aakash Jain.
3514
3515         * Scripts/webkitpy/port/simulator_process.py:
3516         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3517
3518 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3519
3520         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3521         https://bugs.webkit.org/show_bug.cgi?id=193182
3522         <rdar://problem/47452154>
3523
3524         Reviewed by Tim Horton.
3525
3526         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3527         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3528         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3529
3530         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3531         preventing later tests from recognizing gestures.
3532
3533         * WebKitTestRunner/ios/TestControllerIOS.mm:
3534         (WTR::TestController::platformResetStateToConsistentValues):
3535
3536         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3537
3538 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3539
3540         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3541         https://bugs.webkit.org/show_bug.cgi?id=193722
3542         <rdar://problem/47481475>
3543
3544         Reviewed by Lucas Forschler.
3545
3546         iPhone and iPad ports should both use the iOS config.
3547
3548         * Scripts/webkitpy/port/ios_simulator.py:
3549         (IPhoneSimulatorPort.__init__):
3550         (IPadSimulatorPort.__init__):
3551
3552 2019-01-23  Rob Buis  <rbuis@igalia.com>
3553
3554         Update MIME type parser
3555         https://bugs.webkit.org/show_bug.cgi?id=180526
3556
3557         Reviewed by Frédéric Wang.
3558
3559         Add unit tests for both parse modes of ParsedContentType.
3560
3561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3562         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3563         (TestWebKitAPI::TEST):
3564
3565 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3566
3567         [ews-app] fetch loop should not stop on network issues
3568         https://bugs.webkit.org/show_bug.cgi?id=193666
3569
3570         Reviewed by Lucas Forschler.
3571
3572         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3573         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3574
3575 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3576
3577         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3578         https://bugs.webkit.org/show_bug.cgi?id=189165
3579         <rdar://problem/47433765>
3580
3581         Reviewed by Tim Horton.
3582
3583         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3584         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3585         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3586         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3587         would make its way to the UI process by the time the layer tree commit is finished.
3588
3589         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3590         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3591         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3592         will fail because it asks for -_autofillContext too early.
3593
3594         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3595         is handled in the UI process.
3596
3597         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3598
3599         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3600         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3601         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3602         input session.
3603
3604         (-[AutofillTestView textInputHasAutofillContext]):
3605
3606         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3607
3608         * TestWebKitAPI/cocoa/TestWKWebView.h:
3609         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3610         (nextInputSessionChangeCount):
3611
3612         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3613         This includes changing the focused element from one to another.
3614
3615         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3616         (-[TestWKWebView didStartFormControlInteraction]):
3617         (-[TestWKWebView didEndFormControlInteraction]):
3618         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3619
3620         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3621         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3622         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3623         that doesn't require an input session to one that doesn't.
3624
3625 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3626
3627         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3628         <https://webkit.org/b/193676>
3629
3630         Reviewed by Alexey Proskuryakov.
3631
3632         * Scripts/webkitpy/style/checkers/cpp.py:
3633         (check_member_initialization_list):
3634         - Don't report missing whitespace around colon if the colon at
3635           the start of the line is formatted correctly.
3636         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3637         (WebKitStyleTest.test_member_initialization_list):
3638         - Add a test for a missing permutation of existing tests.
3639         - Add a test this false-positive.
3640         - Add blank lines between subtests to make them easier to read.
3641
3642 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3643
3644         [build.webkit.org] Unit-test failure after r237113
3645         https://bugs.webkit.org/show_bug.cgi?id=193669
3646
3647         Reviewed by Michael Catanzaro.
3648
3649         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3650         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3651         multiple or zero flags.
3652
3653 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3654
3655         Cache bytecode to disk
3656         https://bugs.webkit.org/show_bug.cgi?id=192782
3657         <rdar://problem/46084932>
3658
3659         Reviewed by Keith Miller.
3660
3661         Add test helper to execute bytecode-cache tests: it executes each test
3662         twice, the first with JSC_diskCachePath set to a temporary directory
3663         and second with JSC_forceDiskCache=true (in addition to the cache path)
3664         to guarantee that only the disk cache is being used and no new
3665         UnlinkedCodeBlocks are being created.
3666
3667         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3668         * Scripts/run-jsc-stress-tests:
3669
3670 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3671
3672         [css-logical] Implement flow-relative margin, padding and border shorthands
3673         https://bugs.webkit.org/show_bug.cgi?id=188697
3674
3675         Reviewed by Simon Fraser and Antti Koivisto.
3676
3677         * DumpRenderTree/TestOptions.cpp:
3678         (TestOptions::TestOptions):
3679         * DumpRenderTree/TestOptions.h:
3680         * DumpRenderTree/mac/DumpRenderTree.mm:
3681         (setWebPreferencesForTestOptions):
3682         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3683
3684         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3685         (JSONCSSPropertiesChecker.check_codegen_properties):
3686         Allow CSS property definitions to have a 'runtime-flag' parameter which
3687         disables the property when the specified runtime flag is disabled.
3688
3689 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3690
3691         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10