2011-06-28 Hans Wennborg <hans@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-28  Hans Wennborg  <hans@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         IndexedDB: Prepare for running layout tests with LevelDB
6         https://bugs.webkit.org/show_bug.cgi?id=63593
7
8         The TestShell must always provide a temporary folder for LevelDB,
9         not just when the backing store type is overridden.
10
11         * DumpRenderTree/chromium/LayoutTestController.cpp:
12         (LayoutTestController::setOverrideIndexedDBBackingStore):
13         (LayoutTestController::clearAllDatabases):
14         * DumpRenderTree/chromium/LayoutTestController.h:
15         * DumpRenderTree/chromium/TestShell.cpp:
16         (TestShell::TestShell):
17         * DumpRenderTree/chromium/TestShell.h:
18
19 2011-06-30  Zsolt Fehér  <h490267@stud.u-szeged.hu>
20
21         Reviewed by Csaba Osztrogonác.
22
23         [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
24         qt-wk2, win-wk2, mac-wk2 use this common Skipped list too
25         https://bugs.webkit.org/show_bug.cgi?id=61785 
26
27         * Scripts/old-run-webkit-tests:
28
29 2011-06-30  Adam Roben  <aroben@apple.com>
30
31         Use a colon to separate test names from failure info on TestFailures
32
33         This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
34         failure info itself includes parentheses.
35
36         Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
37         double parentheses
38
39         Reviewed by Darin Adler.
40
41         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
42         (ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
43         info in parentheses.
44
45 2011-06-30  Adam Roben  <aroben@apple.com>
46
47         Robustify PersistentCache against cached data that contains the string ': '
48
49         Fixes <http://webkit.org/b/63721> Exceptions thrown while loading TestFailures page due to
50         passing a bad string to JSON.parse
51
52         Reviewed by Darin Adler.
53
54         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js:
55         (PersistentCache._parseDateAndJSONFromString): Manually split the string on the separator
56         using indexOf and substring. (String.prototype.split always splits on all instances of the
57         separator.)
58
59 2011-06-30  Adam Roben  <aroben@apple.com>
60
61         Include the crashing symbol in crash logs links on TestFailures
62
63         Fixes <http://webkit.org/b/63465> Links to crash logs on TestFailures page should include
64         the crashing symbol (like links in results.html do)
65
66         Reviewed by David Kilzer.
67
68         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
69         (LayoutTestResultsLoader.prototype.start): Bumped the cache version because we now store
70         crashing symbols for crashing tests. Renamed testsForResultTable to parseResultTable because
71         it now returns more than just the test names. Specifically, it now looks for crash log links
72         and extracts the crashing symbol name from them. Updated callers of parseResultTable to
73         match its new behavior. Changed to store the crashing symbol along with the failure type in
74         the data we pass to the callback for tests which crashed.
75
76         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
77         (code): Make <code> elements a little smaller because their contents can be quite long.
78
79         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
80         (ViewController.prototype._domForFailureDiagnosis): Include the crashing symbol inside a
81         <code> element in the link, if there is a crashing symbol.
82
83 2011-06-30  Adam Roben  <aroben@apple.com>
84
85         Use objects instead of strings to represent a test result in TestFailures code
86
87         This will eventually allow us to store more than just the type of failure for each test.
88         (E.g., we can store the name of the crashing symbol for tests which crashed.)
89
90         Prep work for <http://webkit.org/b/63465> Links to crash logs on TestFailures page should
91         include the crashing symbol (like links in results.html do)
92
93         Reviewed by David Kilzer.
94
95         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
96         (Builder.prototype.failureDiagnosisTextAndURL): Changed to expect a testResult object
97         instead of just a failureType string.
98
99         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
100         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Changed to store a
101         testResult-like object for passing tests.
102         (FlakyLayoutTestDetector.prototype.flakinessExamples): Changed to expect testResult-like
103         objects.
104
105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
106         (LayoutTestResultsLoader.prototype.start): Store a version number along with the cached data
107         so we can throw away cached data that's in an old format. Store a testResult object for each
108         test instead of just its failure type.
109
110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
111         (ViewController.prototype._domForFailedTest):
112         (ViewController.prototype._domForFailureDiagnosis):
113         Changed to expect testResult objects instead of failureType strings.
114
115 2011-06-30  Adam Roben  <aroben@apple.com>
116
117         Show full commit logs when visiting Trac from TestFailures page
118
119         Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
120         should show full commit logs
121
122         Reviewed by David Kilzer.
123
124         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
125         (Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
126         verbose=on to the log URL to tell Trac to show full commit logs.
127
128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
129         (ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.
130
131 2011-06-30  Adam Roben  <aroben@apple.com>
132
133         Add a link to file a bug about TestFailures to the TestFailures page
134
135         Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
136         about TestFailures itself
137
138         Reviewed by Anders Carlsson.
139
140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
141         (aside): Added some styles for the new link. It is positioned in the upper-right and
142         hopefully not to glaringly obvious.
143
144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
145         (ViewController.prototype.loaded): Set up our main content element and auxiliary UI.
146
147         (ViewController.prototype._displayBuilder):
148         (ViewController.prototype._displayTesters):
149         Modify the main content element instead of the entire body, as there are other things in the
150         body that we want to preserve.
151
152         (ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
153         that contains a link to file a bug about the TestFailures page.
154
155 2011-06-30  Adam Roben  <aroben@apple.com>
156
157         Ignore callbacks that correspond to old navigations of the TestFailures page
158
159         Fixes <http://webkit.org/b/63711> TestFailures page sometimes ignores back/forward
160         navigations
161
162         Reviewed by Anders Carlsson.
163
164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
165         (LayoutTestHistoryAnalyzer.prototype.start): Check the return value of the callback. If the
166         callback returns false, stop fetching more data.
167
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
169         (ViewController): Initialize new _navigationID member. This member is used to assign each
170         navigation by the user a unique ID.
171         (ViewController.prototype.parseHash): Increment the navigation ID.
172
173         (ViewController.prototype._displayBuilder):
174         (ViewController.prototype._displayTesters):
175         At the start of these functions, record the current navigation ID. Bail out from callbacks
176         if the navigation ID has changed, indicating that the user has navigated elsewhere.
177
178 2011-06-30  Carlos Garcia Campos  <cgarcia@igalia.com>
179
180         Reviewed by Martin Robinson.
181
182         [GTK] Add back/forward menu to MiniBrowser toolbar
183         https://bugs.webkit.org/show_bug.cgi?id=63445
184
185         * MiniBrowser/gtk/BrowserWindow.c:
186         (browser_window_init): Use a GtkMenuToolButton for navigation
187         widgets.
188         (browserWindowConstructed): Get the page BackForwardList.
189         (browserWindowHistoryItemActivated): Go to activated history item.
190         (browserWindowHistoryItemSelected): Show the url of currently
191         selected history item in the statusbar.
192         (createGtkActionFromBackForwardItem): Create a GtkAction from a
193         WKBackForwardListItemRef.
194         (browserWindowCreateMenuItemFromBackForwardItem): Create a
195         GtkMenuItem from a WKBackForwardListItemRef.
196         (browserWindowCreateBackForwardMenu): Create a GtkMenu with the
197         given history items.
198         (browserWindowUpdateNavigationActions): Update navigation widgets
199         sensitivity and history menus.
200         (didChangeBackForwardList): Call
201         browserWindowUpdateNavigationActions().
202         (browserWindowLoaderClientInit): Add didChangeBackForwardList
203         callback.
204
205 2011-06-30  Dmitry Lomov  <dslomov@google.com>
206
207         Reviewed by Adam Roben.
208
209         https://bugs.webkit.org/show_bug.cgi?id=63660
210         This enables unit-tests step on Windows and MacOS SnowLeopard.
211
212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
213
214 2011-06-30  Balazs Kelemen  <kbalazs@webkit.org>
215
216         Reviewed by Kenneth Rohde Christiansen.
217
218         [Qt][WK2] Implement the rest of WTR::PlatformWebView
219         https://bugs.webkit.org/show_bug.cgi?id=63630
220
221         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
222         (WTR::PlatformWebView::windowFrame):
223         (WTR::PlatformWebView::setWindowFrame):
224
225 2011-06-29  Dirk Pranke  <dpranke@chromium.org>
226
227         Reviewed by Adam Barth.
228
229         test-webkitpy is spamming lots of messages about updating test expectations
230         https://bugs.webkit.org/show_bug.cgi?id=63680
231
232         This patch changes the passing_run() function to capture the
233         output to stdout and stderr and assert that it is empty, and
234         also specifies --no-new-test-results by default to avoid getting
235         "generating baseline" messages for the expected-missing results.
236
237         Also check that we are logging messages when we generate new
238         baselines.
239
240         Also fix a minor bug in the way test_tolerance() was
241         checking for whether the tests were passing or not.
242
243         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
244
245 2011-06-29  Yuta Kitamura  <yutak@chromium.org>
246
247         Reviewed by Kent Tamura.
248
249         DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController
250         https://bugs.webkit.org/show_bug.cgi?id=63532
251
252         LayoutTestController::overridePreference() will be used to change the value of
253         the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way,
254         we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but
255         at least we need to reset preference values in DumpRenderTree every time we start
256         a new test because preference values changed in some test should not be leaked
257         to the next test.
258
259         * DumpRenderTree/chromium/LayoutTestController.cpp:
260         (LayoutTestController::overridePreference):
261         The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h.
262         * DumpRenderTree/chromium/WebPreferences.cpp:
263         (WebPreferences::reset):
264         Set the default value. This will be called from TestShell::resetTestController().
265         (WebPreferences::applyTo):
266         * DumpRenderTree/chromium/WebPreferences.h:
267         * DumpRenderTree/mac/DumpRenderTree.mm:
268         (resetDefaultsToConsistentValues): Set the default value.
269         * DumpRenderTree/win/DumpRenderTree.cpp:
270         (resetDefaultsToConsistentValues): Ditto.
271
272 2011-06-29  Kenichi Ishibashi  <bashi@chromium.org>
273
274         Reviewed by Adam Barth.
275
276         check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
277         https://webkit.org/b/57360
278
279         Modify the regular expression to match https scheme.
280
281         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
282         * Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
283
284 2011-06-29  Adam Barth  <abarth@webkit.org>
285
286         Reviewed by Eric Seidel.
287
288         new-run-webkit-tests: images page switch actual and expected images before they're loaded
289         https://bugs.webkit.org/show_bug.cgi?id=63199
290
291         We now preload the images and keep the DOM nodes in memory instead of
292         going back to the MemoryCache all the time.  (Also, remove some nutty
293         </img> HTML.)
294
295         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
296
297 2011-06-29  Adam Barth  <abarth@webkit.org>
298
299         Reviewed by Eric Seidel.
300
301         new-run-webkit-tests should tell you when it creates new expectations
302         https://bugs.webkit.org/show_bug.cgi?id=63675
303
304         Unforunately, this patch creates a bunch of test-webkitpy spam because
305         we don't understand how Python logging works well enough to stop the
306         spam.  :(
307
308         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
309
310 2011-06-29  Eric Seidel  <eric@webkit.org>
311
312         Reviewed by Adam Barth.
313
314         Refactor WebKitDriver.run_test into smaller pieces
315         https://bugs.webkit.org/show_bug.cgi?id=63673
316
317         There is no functional change here.  Just moving code around.
318         This is in preparation for adding support for #CRASHED and #CRASHED - WebProcess
319
320         * Scripts/webkitpy/layout_tests/port/webkit.py:
321
322 2011-06-29  Eric Seidel  <eric@webkit.org>
323
324         Reviewed by Adam Barth.
325
326         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
327         https://bugs.webkit.org/show_bug.cgi?id=63501
328
329         Re-landing after fixing a bug in WebKitPort.baseline_search_path which broke
330         the rebaselineserver unit tests.  Also fixed nits brought up by Dirk after previous landing.
331
332         The goal was to add support for wk2 skipped lists.
333         However, I found that our skipped list computation was a
334         manual hack (which only worked for the mac port).
335
336         So I fixed a FIXME to move the skipped list finding
337         into WebKitPort instead of MacPort.
338         Doing so required the concept of a "port_name", since previously
339         the only name accessible from a port object was name()
340         which includes many things beyond "mac" or "chromium", etc.
341
342         Eventually I believe we'll want to re-think the way that we pass
343         in a port_name argument to Port subclasses and expect them to parse
344         it.  But for now I just added a cls.port_name variable which contains
345         the static information needed to compute wk2 names as well as
346         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
347
348         In order to test my new _skipped_file_search_paths method, I
349         fixed another FIXME by making it return relative paths.
350
351         I also fixed the test_expectations_path code in WebKitPort to use port_name.
352         It was using name() which would return PORT-VERSION so MacPort was overriding
353         it to use just PORT.  After fixing test_expectations_path to use port_name
354         (and making it aware of webkit2) I was able to remove the MacPort implementation.
355
356         * Scripts/webkitpy/layout_tests/port/base.py:
357          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
358          - Document that real_name() seems to have no purpose.
359         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
360          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
361         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
362          - Add _parse_port_name.
363         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
364          - Add _parse_port_name.
365         * Scripts/webkitpy/layout_tests/port/gtk.py:
366         * Scripts/webkitpy/layout_tests/port/mac.py:
367          - Move Skipped-file finding code down to WebKitPort
368         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
369         * Scripts/webkitpy/layout_tests/port/qt.py:
370         * Scripts/webkitpy/layout_tests/port/webkit.py:
371         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
372
373 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
374
375         Unreviewed, rolling out r90070.
376         http://trac.webkit.org/changeset/90070
377         https://bugs.webkit.org/show_bug.cgi?id=63676
378
379         Broke test-webkitpy rebaseline tests (Requested by eseidel2 on
380         #webkit).
381
382         * Scripts/webkitpy/layout_tests/port/base.py:
383         * Scripts/webkitpy/layout_tests/port/chromium.py:
384         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
385         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
386         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
387         * Scripts/webkitpy/layout_tests/port/gtk.py:
388         * Scripts/webkitpy/layout_tests/port/mac.py:
389         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
390         * Scripts/webkitpy/layout_tests/port/qt.py:
391         * Scripts/webkitpy/layout_tests/port/webkit.py:
392         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
393         * Scripts/webkitpy/layout_tests/port/win.py:
394         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
395
396 2011-06-29  Adam Barth  <abarth@webkit.org>
397
398         Reviewed by Eric Seidel.
399
400         new-run-webkit-tests doesn't support sample-on-timeout
401         https://bugs.webkit.org/show_bug.cgi?id=56731
402
403         * Scripts/webkitpy/layout_tests/port/server_process.py:
404         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
405         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
406
407 2011-06-29  Eric Seidel  <eric@webkit.org>
408
409         Reviewed by Adam Barth.
410
411         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
412         https://bugs.webkit.org/show_bug.cgi?id=63501
413
414         The goal was to add support for wk2 skipped lists.
415         However, I found that our skipped list computation was a
416         manual hack (which only worked for the mac port).
417
418         So I fixed a FIXME to move the skipped list finding
419         into WebKitPort instead of MacPort.
420         Doing so required the concept of a "port_name", since previously
421         the only name accessible from a port object was name()
422         which includes many things beyond "mac" or "chromium", etc.
423
424         Eventually I believe we'll want to re-think the way that we pass
425         in a port_name argument to Port subclasses and expect them to parse
426         it.  But for now I just added a cls.port_name variable which contains
427         the static information needed to compute wk2 names as well as
428         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
429
430         In order to test my new _skipped_file_search_paths method, I
431         fixed another FIXME by making it return relative paths.
432
433         I also fixed the test_expectations_path code in WebKitPort to use port_name.
434         It was using name() which would return PORT-VERSION so MacPort was overriding
435         it to use just PORT.  After fixing test_expectations_path to use port_name
436         (and making it aware of webkit2) I was able to remove the MacPort implementation.
437
438         * Scripts/webkitpy/layout_tests/port/base.py:
439          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
440          - Document that real_name() seems to have no purpose.
441         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
442          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
443         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
444          - Add _parse_port_name.
445         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
446          - Add _parse_port_name.
447         * Scripts/webkitpy/layout_tests/port/gtk.py:
448         * Scripts/webkitpy/layout_tests/port/mac.py:
449          - Move Skipped-file finding code down to WebKitPort
450         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
451         * Scripts/webkitpy/layout_tests/port/qt.py:
452         * Scripts/webkitpy/layout_tests/port/webkit.py:
453         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
454
455 2011-06-29  Adam Barth  <abarth@webkit.org>
456
457         Reviewed by Dirk Pranke.
458
459         new-run-webkit-tests complains about missing pixel results instead of plopping down new expectations
460         https://bugs.webkit.org/show_bug.cgi?id=38063
461
462         This patch changes new-run-webkit-tests to match old-run-webkit-tests
463         in generating new expected results when the expected results are
464         missing.
465
466         There are still a couple details that are different:
467
468         1) Image baselines aren't generated unless you run with -p.
469         2) Render tree dumps are places in the cross-platform directory instead
470         of the platform-specific directory.
471
472         I'm inclined to deal with both of these issues in follow-up patches.
473
474         * Scripts/webkitpy/common/net/layouttestresults.py:
475         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
476         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
477         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
478         * Scripts/webkitpy/layout_tests/port/test.py:
479         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
480         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
481
482 2011-06-29  Adam Roben  <aroben@apple.com>
483
484         Teach TestFailures to detect possibly flaky tests and list them separately
485
486         Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
487         arbitrary revisions for breaking flaky tests
488
489         Reviewed by Dan Bates.
490
491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.
492         (FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
493         from various builds (in reverse-chronological order).
494         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
495         monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
496         (FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
497         given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
498         and puts them in an array in reverse-chronological order.
499         (FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
500         to be possibly flaky.
501
502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
503         (LayoutTestHistoryAnalyzer): Initialize new members.
504         (LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
505         properties: history and possiblyFlaky. history holds the data this function used to pass to
506         the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
507         flakiness. Updated documentation comment to match.
508         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
509         FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
510         removed from the failure history, since when they started failing is no longer meaningful.
511         We tell our caller to keep calling until all current failures have been explained and we've
512         gone through 5 builds without any new flaky tests being identified.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
515         (sorted): New helper function to return a sorted copy of an array.
516         (Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
517         that matches the predicate.
518
519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
520         (ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
521         the analyzer. Now puts the list of possibly flaky tests after the failure history.
522         (ViewController.prototype._domForFailedTest): Moved some code from here...
523         (ViewController.prototype._domForFailureDiagnosis): ...to here.
524         (ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
525         possibly flaky tests and examples of their flakiness and returns it.
526
527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
528         FlakyLayoutTestDetector.js.
529
530 2011-06-29  Eric Seidel  <eric@webkit.org>
531
532         Adam says cowboys don't review (or unit test).
533
534         * Scripts/webkitpy/tool/commands/download.py:
535
536 2011-06-29  Eric Seidel  <eric@webkit.org>
537
538         Reviewed by Adam Barth.
539
540         Make port/config.py mockable for easier unit testing
541         https://bugs.webkit.org/show_bug.cgi?id=63661
542
543         Fix an exception from the unit tests.
544
545         * Scripts/webkitpy/layout_tests/port/config.py:
546
547 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
548
549         Unreviewed build correction.
550
551         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
552         Link against zlib1.dll, not the static zlib.lib.
553
554 2011-06-29  Eric Seidel  <eric@webkit.org>
555
556         Reviewed by Adam Barth.
557
558         Make port/config.py mockable for easier unit testing
559         https://bugs.webkit.org/show_bug.cgi?id=63661
560
561         Right now config.py leaks real system paths for
562         webkit_base_dir due to using __file__.  This patch
563         adds a filsystem.py wrapper around __file__ so that
564         we don't have to jump through hoops in webkit_unittest.py
565         to avoid leaking local paths to the unit test results.
566
567         There are probably many more places where we should now
568         use filesystem.path_for_module, but starting with just this one.
569
570         * Scripts/webkitpy/common/system/filesystem.py:
571         * Scripts/webkitpy/common/system/filesystem_mock.py:
572         * Scripts/webkitpy/layout_tests/port/config.py:
573         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
574         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
575
576 2011-06-29  Eric Seidel  <eric@webkit.org>
577
578         Reviewed by Adam Barth.
579
580         Remove duplicate methods in filesystem.py
581         https://bugs.webkit.org/show_bug.cgi?id=63658
582
583         Looks like there was a bad merge at some point.
584
585         I also removed a bunch of redundant docstrings.
586
587         * Scripts/webkitpy/common/system/filesystem.py:
588
589 2011-06-29  Adam Barth  <abarth@webkit.org>
590
591         Reviewed by Eric Seidel.
592
593         Pass --no-new-test-results to NRWT on build.webkit.org
594         https://bugs.webkit.org/show_bug.cgi?id=63653
595
596         This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.
597
598         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
599
600 2011-06-29  Xan Lopez  <xlopez@igalia.com>
601
602         Reviewed by Adam Barth.
603
604         [GTK] overlapping drag&drop tests fail on NRWT
605         https://bugs.webkit.org/show_bug.cgi?id=57640
606
607         Make a GTK test driver that spawns one Xvfb instance per
608         thread. This avoids bad interactions in DnD tests between threads.
609
610         * Scripts/webkitpy/layout_tests/port/gtk.py:
611
612 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
613
614         Unreviewed, rolling out r89888.
615         http://trac.webkit.org/changeset/89888
616         https://bugs.webkit.org/show_bug.cgi?id=63609
617
618          "Seems to be causing merging issues on the dashboard, e.g.
619         http://test-
620         results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
621         (Requested by aboxhall on #webkit).
622
623         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
624         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
625         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
626
627 2011-06-29  Philippe Normand  <pnormand@igalia.com>
628
629         Reviewed by Martin Robinson.
630
631         [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
632         https://bugs.webkit.org/show_bug.cgi?id=63624
633
634         * Scripts/webkitpy/common/system/executive.py: In some cases the
635         ps output lines can contain one or more leading white-spaces, so
636         strip it before splitting the pid and command name.
637
638 2011-06-29  Noel Gordon  <noel.gordon@gmail.com>
639
640         Reviewed by Kent Tamura.
641
642         [Chromium] [DRT] ImageDiff should compile in VS2010
643         https://bugs.webkit.org/show_bug.cgi?id=63614
644
645         * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
646
647 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
648
649         Reviewed by Kenneth Rohde Christiansen.
650
651         [Qt] DRT support for setInteractiveFormValidationEnabled
652         https://bugs.webkit.org/show_bug.cgi?id=63496
653
654         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
655         (WebCore::DumpRenderTree::DumpRenderTree):
656
657 2011-06-28  Eric Seidel  <eric@webkit.org>
658
659         Reviewed by Adam Barth.
660
661         Make new-run-webkit-tests -2 actually use WebKitTestRunner
662         https://bugs.webkit.org/show_bug.cgi?id=63572
663
664         new-run-webkit-tests -2 works with this change.  However a zillion
665         tests fail since it can't find the right skipped lists for wk2.
666         The Skipped-list fixing is covered in bug 63501.
667
668         * Scripts/webkitpy/layout_tests/port/gtk.py:
669         * Scripts/webkitpy/layout_tests/port/qt.py:
670         * Scripts/webkitpy/layout_tests/port/webkit.py:
671
672 2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>
673
674         Reviewed by Adam Roben.
675
676         Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
677         https://bugs.webkit.org/show_bug.cgi?id=63500
678
679         Added google-mac-3 and google-mac-4.
680
681         * BuildSlaveSupport/build.webkit.org-config/config.json:
682
683 2011-06-28  Eric Seidel  <eric@webkit.org>
684
685         Reviewed by Dirk Pranke.
686
687         Remove webkitpy's tiger support now that WebKit no longer supports tiger
688         https://bugs.webkit.org/show_bug.cgi?id=63568
689
690         I don't think our support actually fully worked anyway.  Regardless
691         tiger is dead now (thankfully)!
692
693         I also unwrapped some short lines and added a couple FIXMEs while
694         touring the code.
695
696         No new tests, only removing old ones which tested our Tiger support.
697
698         * Scripts/webkitpy/layout_tests/port/base.py:
699         * Scripts/webkitpy/layout_tests/port/builders.py:
700         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
701         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
702         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
703         * Scripts/webkitpy/layout_tests/port/mac.py:
704         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
705         * Scripts/webkitpy/tool/commands/rebaseline.py:
706         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
707
708 2011-06-28  Eric Seidel  <eric@webkit.org>
709
710         Unreviewed, just fixing a typo.
711
712         Fix misspellings of "thead" to "thread".
713
714         * Scripts/webkitpy/common/checkout/scm/git.py:
715         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
716
717 2011-06-28  Eric Seidel  <eric@webkit.org>
718
719         Reviewed by Tony Chang.
720
721         new-run-webkit-tests needs a --webkit-test-runner option
722         https://bugs.webkit.org/show_bug.cgi?id=63439
723
724         This was accidentally fixed in bug 63501 as well.
725         The root problem here was that the webkit unit tests were not using
726         enough mocks.  I've fixed them here to use more mocks
727         which should unbreak windows.
728
729         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
730
731 2011-06-28  Eric Seidel  <eric@webkit.org>
732
733         Reviewed by Tony Chang.
734
735         new-run-webkit-tests should not run mthml tests when MHTML support is disabled
736         https://bugs.webkit.org/show_bug.cgi?id=63549
737
738         This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
739         I happen to go looking for what code was deciding that .mht was a supported
740         extension, found test_files.py and then removed some redundant doc-strings and
741         if branching.
742
743         * Scripts/webkitpy/layout_tests/port/test_files.py:
744         * Scripts/webkitpy/layout_tests/port/webkit.py:
745         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
746
747 2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>
748
749         Reviewed by Tony Chang.
750
751         Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
752         https://bugs.webkit.org/show_bug.cgi?id=63514
753
754         - change write_text_file to write_binary_file
755         - check that text_path and binary_path are actually existant files
756         - change cleanup block from 'except' to 'finally'
757
758         * Scripts/webkitpy/common/system/filesystem_unittest.py:
759
760 2011-06-28  Adam Roben  <aroben@apple.com>
761
762         Roll out r89924 and r89925
763
764         I didn't mean to commit them!
765
766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
769
770 2011-06-27  Adam Barth  <abarth@webkit.org>
771
772         Reviewed by Eric Seidel.
773
774         NRWT should wait for ReportCrash
775         https://bugs.webkit.org/show_bug.cgi?id=63495
776
777         When a test crashes on Mac, ReportCrash confuses us into thinking the
778         test times out.
779
780         I'm not sure how to test this in a meaningful way in our current test
781         harness...
782
783         * Scripts/webkitpy/common/system/crashlogs.py:
784         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
785         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
786         * Scripts/webkitpy/layout_tests/port/base.py:
787         * Scripts/webkitpy/layout_tests/port/mac.py:
788         * Scripts/webkitpy/layout_tests/port/server_process.py:
789         * Scripts/webkitpy/tool/commands/queries.py:
790
791 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
792
793         Unreviewed, rolling out r89881.
794         http://trac.webkit.org/changeset/89881
795         https://bugs.webkit.org/show_bug.cgi?id=63513
796
797         Makes Qt massively slow (Requested by abarth on #webkit).
798
799         * Scripts/webkitpy/common/system/crashlogs.py:
800         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
801         * Scripts/webkitpy/common/system/executive.py:
802         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
803         * Scripts/webkitpy/layout_tests/port/base.py:
804         * Scripts/webkitpy/layout_tests/port/mac.py:
805         * Scripts/webkitpy/layout_tests/port/server_process.py:
806         * Scripts/webkitpy/tool/commands/queries.py:
807
808 2011-06-27  Alice Boxhall  <aboxhall@chromium.org>
809
810         Reviewed by Ojan Vafai.
811
812         Convert json_results_generator.py to output version 4 JSON.
813         https://bugs.webkit.org/show_bug.cgi?id=60869
814
815         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
816         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
817         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
818
819 2011-06-27  Adam Barth  <abarth@webkit.org>
820
821         Reviewed by Eric Seidel.
822
823         NRWT should wait for ReportCrash
824         https://bugs.webkit.org/show_bug.cgi?id=63495
825
826         When a test crashes on Mac, ReportCrash confuses us into thinking the
827         test times out.
828
829         I'm not sure how to test this in a meaningful way in our current test
830         harness...
831
832         * Scripts/webkitpy/common/system/crashlogs.py:
833         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
834         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
835         * Scripts/webkitpy/layout_tests/port/base.py:
836         * Scripts/webkitpy/layout_tests/port/mac.py:
837         * Scripts/webkitpy/layout_tests/port/server_process.py:
838         * Scripts/webkitpy/tool/commands/queries.py:
839
840 2011-06-27  Adam Barth  <abarth@webkit.org>
841
842         Reviewed by Eric Seidel.
843
844         new-run-webkit-tests should upload crash logs
845         https://bugs.webkit.org/show_bug.cgi?id=55907
846
847         NRWT used to have a different name for crash logs.  I've changed the
848         name to patch ORWT.
849
850         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
851         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
852
853 2011-06-27  Eric Seidel  <eric@webkit.org>
854
855         Reviewed by Adam Barth.
856
857         new-run-webkit-tests needs a --webkit-test-runner option
858         https://bugs.webkit.org/show_bug.cgi?id=63439
859
860         NRWT doesn't actually know how to run with the WebKitTestRunner yet
861         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
862
863         There is a bunch of other little cleanup in this patch which I added as I
864         took a tour through all of our hard-coded DumpRenderTree strings.
865
866         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
867         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
868         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
869         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
870         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
871         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
872         * Scripts/webkitpy/layout_tests/port/config.py:
873          - build_dumprendertree had no business in this class, removed it.
874          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
875          - Exposed _script_path as script_path() (this probably belongs elsewhere).
876         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
877          - Moved these tests to webkit_unittests.
878         * Scripts/webkitpy/layout_tests/port/webkit.py:
879          - Now respects the --webkit-test-runner option.
880          - setup_test_run is empty in base.py too, no need to override it.
881         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
882          - Test the new hotness.
883          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
884            I think this code is still hitting disk during the unit tests. :(
885         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
886          - Add the option.
887         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
888          - Remove optional args option.
889         * Scripts/webkitpy/tool/commands/commandtest.py:
890          - Remove optional args option.
891         * Scripts/webkitpy/tool/commands/queues_unittest.py:
892          - Remove optional args option.
893
894 2011-06-27  Adam Barth  <abarth@webkit.org>
895
896         Reviewed by Dirk Pranke.
897
898         new-run-webkit-tests does not report stderr output
899         https://bugs.webkit.org/show_bug.cgi?id=37739
900
901         Almost all the infrastructure appears to be in place to report stderr
902         in results.html.  We just need to wire up a bool to tell results.html
903         to create the hyperlink.
904
905         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
906         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
907         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
908         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
909         * Scripts/webkitpy/layout_tests/port/base.py:
910
911 2011-06-27  Adam Barth  <abarth@webkit.org>
912
913         Reviewed by Dirk Pranke.
914
915         webkitpy unit tests should have more descriptive names than just "Test"
916         https://bugs.webkit.org/show_bug.cgi?id=63479
917
918         Luckily we kept these classes in separate namespaces in the harness so
919         we were actually running them all even though they had the same name.
920
921         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
922         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
923         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
924
925 2011-06-27  Greg Simon  <gregsimon@chromium.org>
926
927         No review necessary.
928
929         Add email addr to contributor list
930         https://bugs.webkit.org/show_bug.cgi?id=63478
931
932         * Scripts/webkitpy/common/config/committers.py:
933
934 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
935
936         Unreviewed, rolling out r89834.
937         http://trac.webkit.org/changeset/89834
938         https://bugs.webkit.org/show_bug.cgi?id=63476
939
940         Broke test-webkitpy (Requested by abarth on #webkit).
941
942         * Scripts/webkitpy/common/net/layouttestresults.py:
943         * Scripts/webkitpy/common/system/outputcapture.py:
944         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
945         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
946         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
947         * Scripts/webkitpy/layout_tests/port/base.py:
948         * Scripts/webkitpy/layout_tests/port/config.py:
949         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
950         * Scripts/webkitpy/layout_tests/port/webkit.py:
951         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
952         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
953         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
954         * Scripts/webkitpy/tool/commands/commandtest.py:
955         * Scripts/webkitpy/tool/commands/queues_unittest.py:
956
957 2011-06-27  Jeff Miller  <jeffm@apple.com>
958
959         Reviewed by Adam Roben.
960
961         Stop copying obsolete WebKit libraries on Windows
962         https://bugs.webkit.org/show_bug.cgi?id=63474
963         
964         Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
965
966         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
967         * MiniBrowser/MiniBrowserPostBuild.cmd:
968         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
969
970 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
971
972         Add Wyatt Carss to the list of non-committer contributors.
973
974         * Scripts/webkitpy/common/config/committers.py:
975
976 2011-06-27  Adam Barth  <abarth@webkit.org>
977
978         Reviewed by Eric Seidel.
979
980         webkitpy should understand crash logs
981         https://bugs.webkit.org/show_bug.cgi?id=63468
982
983         We're planning to use this functionality to upload crash logs along
984         with test results for new-run-webkit-tests.
985
986         * Scripts/webkitpy/common/system/crashlog.py: Added.
987         * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
988         * Scripts/webkitpy/common/system/executive.py:
989         * Scripts/webkitpy/common/system/executive_unittest.py:
990         * Scripts/webkitpy/common/system/filesystem.py:
991         * Scripts/webkitpy/common/system/filesystem_mock.py:
992         * Scripts/webkitpy/tool/commands/queries.py:
993
994 2011-06-27  Adam Roben  <aroben@apple.com>
995
996         Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many
997         failures
998
999         Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
1000         old-run-webkit-tests exited early after reload
1001
1002         Reviewed by Anders Carlsson.
1003
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1005         (LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
1006         old-run-webkit-tests exited early due to too many failures in PersistentCache.
1007
1008 2011-06-27  Adam Roben  <aroben@apple.com>
1009
1010         Make TestFailures load build names from build.webkit.org/old-results too
1011
1012         Build results are periodically moved from results to old-results. This change makes those
1013         builds still visible to TestFailures.
1014
1015         Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
1016         have been moved to build.webkit.org/old-results
1017
1018         Reviewed by Anders Carlsson.
1019
1020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1021         (Builder.prototype.getBuildNames): Extracted code to parse build names from a
1022         build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
1023         we now only include directory entries whose names are parseable as build names (since
1024         old-results sometimes contains other random files/directories from who knows what). We now
1025         fetch both results and old-results (with a FIXME about loading old-results on demand),
1026         extract build names from each, and concatenate the two sets of names.
1027
1028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:
1029         (WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
1030         parseable, rather than throwing an exception.
1031
1032 2011-06-26  Adam Roben  <aroben@apple.com>
1033
1034         Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache
1035
1036         It seems silly to have a whole generic cache just to store a single object.
1037
1038         Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
1039         need one
1040
1041         Reviewed by Anders Carlsson.
1042
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
1044         (LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
1045         (LayoutTestHistoryAnalyzer.prototype.start): Ditto.
1046         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
1047         no-longer-needed history argument.
1048
1049 2011-06-26  Adam Roben  <aroben@apple.com>
1050
1051         Move some inappropriate code out of Builder
1052
1053         Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
1054         isn't really about a builder
1055
1056         Reviewed by Anders Carlsson.
1057
1058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1059         (Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
1060         called by other objects.
1061
1062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
1063         Added. Code came from Builder.
1064         (LayoutTestHistoryAnalyzer):
1065         (LayoutTestHistoryAnalyzer.prototype.start):
1066         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):
1067
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
1069         Added. Code came from Builder.
1070         (LayoutTestResultsLoader):
1071         (LayoutTestResultsLoader.prototype.start):
1072
1073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1074         (ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.
1075
1076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new
1077         scripts.
1078
1079 2011-05-17  Nat Duca  <nduca@chromium.org>
1080
1081         Reviewed by James Robinson.
1082
1083         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
1084         https://bugs.webkit.org/show_bug.cgi?id=58408
1085
1086         * DumpRenderTree/chromium/WebViewHost.cpp:
1087         (WebViewHost::paintInvalidatedRegion):
1088
1089 2011-06-27  Eric Seidel  <eric@webkit.org>
1090
1091         Reviewed by Adam Barth.
1092
1093         new-run-webkit-tests needs a --webkit-test-runner option
1094         https://bugs.webkit.org/show_bug.cgi?id=63439
1095
1096         NRWT doesn't actually know how to run with the WebKitTestRunner yet
1097         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
1098
1099         There is a bunch of other little cleanup in this patch which I added as I
1100         took a tour through all of our hard-coded DumpRenderTree strings.
1101
1102         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
1103         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
1104         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
1105         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
1106         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
1107         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
1108         * Scripts/webkitpy/layout_tests/port/config.py:
1109          - build_dumprendertree had no business in this class, removed it.
1110          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
1111          - Exposed _script_path as script_path() (this probably belongs elsewhere).
1112         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1113          - Moved these tests to webkit_unittests.
1114         * Scripts/webkitpy/layout_tests/port/webkit.py:
1115          - Now respects the --webkit-test-runner option.
1116          - setup_test_run is empty in base.py too, no need to override it.
1117         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1118          - Test the new hotness.
1119          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
1120            I think this code is still hitting disk during the unit tests. :(
1121         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1122          - Add the option.
1123         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1124          - Remove optional args option.
1125         * Scripts/webkitpy/tool/commands/commandtest.py:
1126          - Remove optional args option.
1127         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1128          - Remove optional args option.
1129
1130 2011-06-27  Chang Shu  <cshu@webkit.org>
1131
1132         Reviewed by Darin Adler.
1133
1134         [WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
1135         https://bugs.webkit.org/show_bug.cgi?id=63457
1136
1137         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1138         (WTR::InjectedBundle::beginTesting):
1139
1140 2011-06-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
1141
1142         Reviewed by Kent Tamura.
1143
1144         [EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
1145         It will be plugged into the build system as soon as the rest of the
1146         DRT code is fully upstreamed.
1147         https://bugs.webkit.org/show_bug.cgi?id=63086
1148
1149         * DumpRenderTree/efl/DumpRenderTreeView.cpp: Added.
1150         (onConsoleMessage):
1151         (onJavaScriptAlert):
1152         (onJavaScriptConfirm):
1153         (onJavaScriptPrompt):
1154         (drtViewTiledAdd):
1155         * DumpRenderTree/efl/DumpRenderTreeView.h: Added.
1156
1157 2011-06-27  Leandro Pereira  <leandro@profusion.mobi>
1158
1159         Reviewed by Kent Tamura.
1160
1161         [EFL] Add an EventSender implementation to EFL's DumpRenderTree along
1162         with support files.
1163         Build system changes will be made as soon as the whole DumpRenderTree
1164         is upstreamed.
1165         https://bugs.webkit.org/show_bug.cgi?id=61962
1166
1167         * DumpRenderTree/efl/EventSender.cpp: Added.
1168         (setEvasModifiers):
1169         (translateMouseButtonNumber):
1170         (sendMouseEvent):
1171         (sendClick):
1172         (scheduleAsynchronousClickCallback):
1173         (updateClickCount):
1174         (modifierFromJSValue):
1175         (modifiersFromJSValue):
1176         (mouseDownCallback):
1177         (mouseUpCallback):
1178         (mouseMoveToCallback):
1179         (evasMouseEventFromHorizontalAndVerticalOffsets):
1180         (mouseScrollByCallback):
1181         (continuousMouseScrollByCallback):
1182         (keyPadNameFromJSValue):
1183         (keyNameFromJSValue):
1184         (keyDownCallback):
1185         (scalePageByCallback):
1186         (getClass):
1187         (makeEventSender):
1188         * DumpRenderTree/efl/EventSender.h: Added.
1189
1190 2011-06-27  Eric Seidel  <eric@webkit.org>
1191
1192         Reviewed by Adam Barth.
1193
1194         Remove evil uses of hasattr
1195         https://bugs.webkit.org/show_bug.cgi?id=63430
1196
1197         For some reason these classes believe that they may be called with
1198         various flavors of "option" elements and so carefully check to make
1199         sure that the options element has their option before checking it.
1200
1201         We had a set_option_default method which was never called, so I made it
1202         do what callsites seemed to want it to do and replaced 3 callers
1203         who previously used hasattr manually to use set_option_default instead.
1204
1205         * Scripts/webkitpy/layout_tests/port/base.py:
1206         * Scripts/webkitpy/layout_tests/port/webkit.py:
1207
1208 2011-06-27  Kent Tamura  <tkent@chromium.org>
1209
1210         Reviewed by Hajime Morita.
1211
1212         [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
1213         https://bugs.webkit.org/show_bug.cgi?id=63427
1214
1215         ~WebViewHost() navigates to about:blank, so it calls some
1216         callbacks and LayoutTestController functions.
1217
1218         * DumpRenderTree/chromium/TestShell.h:
1219          Move m_printer upper and move m_webViewHost lower.
1220
1221 2011-06-27  Adam Barth  <abarth@webkit.org>
1222
1223         Reviewed by Eric Seidel.
1224
1225         Move server config files to webkitpy.layout_tests.servers
1226         https://bugs.webkit.org/show_bug.cgi?id=63436
1227
1228         The config files belong with the servers.
1229
1230         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
1231         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
1232         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1233         * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
1234         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
1235
1236 2011-06-27  Adam Barth  <abarth@webkit.org>
1237
1238         Reviewed by Eric Seidel.
1239
1240         Move websocket_server and http_server to webkitpy.layout_package.servers
1241         https://bugs.webkit.org/show_bug.cgi?id=63434
1242
1243         These classes do not represent ports.  They represent servers.
1244
1245         * Scripts/new-run-webkit-httpd:
1246         * Scripts/new-run-webkit-websocketserver:
1247         * Scripts/webkitpy/layout_tests/port/base.py:
1248         * Scripts/webkitpy/layout_tests/port/chromium.py:
1249         * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
1250         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
1251         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1252         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1253         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
1254         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1255         * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
1256         * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
1257         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
1258         * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
1259
1260 2011-06-27  Eric Seidel  <eric@webkit.org>
1261
1262         Reviewed by Adam Barth.
1263
1264         Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
1265         https://bugs.webkit.org/show_bug.cgi?id=63428
1266
1267         * Scripts/webkitpy/layout_tests/port/chromium.py:
1268         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1269
1270 2011-06-27  Adam Barth  <abarth@webkit.org>
1271
1272         Reviewed by Eric Seidel.
1273
1274         Move apache_http_server.py to webkitpy.layout_package.servers
1275         https://bugs.webkit.org/show_bug.cgi?id=63433
1276
1277         The apache_http_server.py is a server, not a port.
1278
1279         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
1280         * Scripts/webkitpy/layout_tests/port/base.py:
1281         * Scripts/webkitpy/layout_tests/servers: Added.
1282         * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
1283         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
1284
1285 2011-06-27  Adam Barth  <abarth@webkit.org>
1286
1287         Reviewed by Eric Seidel.
1288
1289         Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
1290         https://bugs.webkit.org/show_bug.cgi?id=63432
1291
1292         This code isn't in the dependency cone of new-run-webkit-tests. It's
1293         unclear what it's final home should be, but this patch moves it out of
1294         layout_tests to simply the package.
1295
1296         * Scripts/rebaseline-chromium-webkit-tests:
1297         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
1298         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
1299         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
1300         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
1301
1302 2011-06-27  Adam Barth  <abarth@webkit.org>
1303
1304         Reviewed by Eric Seidel.
1305
1306         Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
1307         https://bugs.webkit.org/show_bug.cgi?id=63429
1308
1309         This package as nothing to do with the layout_tests package.
1310
1311         * Scripts/update-webgl-conformance-tests:
1312         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
1313         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
1314         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
1315         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
1316
1317 2011-06-27  Adam Barth  <abarth@webkit.org>
1318
1319         Reviewed by Eric Seidel.
1320
1321         Move deduplicate_tests.py into webkitpy.to_be_moved
1322         https://bugs.webkit.org/show_bug.cgi?id=63426
1323
1324         deduplicate_tests.py doesn't haven anything to do with layout tests.
1325         It's really a separate script.  This patch moves it to the (new)
1326         to_be_moved package so that it doesn't distract us when working on NRWT.
1327
1328         * Scripts/deduplicate-tests:
1329         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
1330         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
1331         * Scripts/webkitpy/test/main.py:
1332         * Scripts/webkitpy/to_be_moved: Added.
1333         * Scripts/webkitpy/to_be_moved/__init__.py: Added.
1334         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
1335         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
1336
1337 2011-06-26  Adam Barth  <abarth@webkit.org>
1338
1339         Rubber-stamped by Eric Seidel.
1340
1341         Remove empty directory.
1342
1343         * Scripts/webkitpy/layout_tests/test_types: Removed.
1344
1345 2011-06-25  Naoki Takano  <honten@chromium.org>
1346
1347         Reviewed by Eric Seidel.
1348
1349         Change my entry from contributors to committers.
1350         https://bugs.webkit.org/show_bug.cgi?id=63043
1351
1352         * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
1353
1354 2011-06-25  Adam Barth  <abarth@webkit.org>
1355
1356         Reviewed by Eric Seidel.
1357
1358         [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
1359         https://bugs.webkit.org/show_bug.cgi?id=63394
1360
1361         * DumpRenderTree/chromium/LayoutTestController.cpp:
1362         (LayoutTestController::queueLoad):
1363
1364 2011-06-25  Brent Fulgham  <bfulgham@webkit.org>
1365
1366         Unreviewed build correction after r89426.
1367
1368         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
1369           Link with Cairo DLL for new functionality.
1370         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
1371           code for snprintf.
1372
1373 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
1374
1375         Reviewed by Adam Barth.
1376
1377         run-bindings-tests does not work on Chromium Windows.
1378         https://bugs.webkit.org/show_bug.cgi?id=63382
1379
1380         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
1381
1382 2011-06-25  Dan Bernstein  <mitz@apple.com>
1383
1384         Try to fix the Qt and Chromium builds.
1385
1386         * DumpRenderTree/chromium/LayoutTestController.cpp:
1387         (LayoutTestController::setEncodedAudioData):
1388         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1389
1390 2011-06-24  Dan Bernstein  <mitz@apple.com>
1391
1392         Reviewed by Anders Carlsson.
1393
1394         Add an option to enable legacy rounding hacks
1395         https://bugs.webkit.org/show_bug.cgi?id=63363
1396
1397         Added layoutTestController.allowRoundingHacks() and implemented it
1398         on OS X.
1399
1400         * DumpRenderTree/LayoutTestController.cpp:
1401         (allowRoundingHacksCallback):
1402         (LayoutTestController::staticFunctions):
1403         * DumpRenderTree/LayoutTestController.h:
1404         * DumpRenderTree/chromium/LayoutTestController.cpp:
1405         (LayoutTestController::allowRoundingHacks):
1406         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1407         (LayoutTestController::allowRoundingHacks):
1408         * DumpRenderTree/mac/DumpRenderTree.mm:
1409         (resetWebViewToConsistentStateBeforeTesting):
1410         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1411         (LayoutTestController::allowRoundingHacks):
1412         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1413         (LayoutTestController::allowRoundingHacks):
1414         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1415         (LayoutTestController::allowRoundingHacks):
1416         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1417         (LayoutTestController::allowRoundingHacks):
1418
1419 2011-06-24  Adam Roben  <aroben@apple.com>
1420
1421         Include the directory containing the failing tests in titles of bugs filed from TestFailures
1422         when all the tests won't fit
1423
1424         Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
1425         which tests are failing
1426
1427         Reviewed by David Kilzer.
1428
1429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1430         (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
1431         that ends in a path separator.
1432
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1434         (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
1435         in the title, first try to include the longest common prefix of the test names, then, if
1436         that's still too long or there's no common prefix, fall back to not including any
1437         information about which tests are failing.
1438
1439 2011-06-24  Adam Roben  <aroben@apple.com>
1440
1441         Include links to Trac in bugs filed from TestFailures
1442
1443         Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
1444         Trac for suspect revisions
1445
1446         Reviewed by David Kilzer.
1447
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1449         (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
1450         Trac.
1451
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1453         (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
1454         include a link to Trac for it in the first sentence of the description. Otherwise include a
1455         link to the suspect range after the list of failing tests.
1456
1457 2011-06-24  Nat Duca  <nduca@chromium.org>
1458
1459         Unreviewed, rolling out r89694.
1460         http://trac.webkit.org/changeset/89694
1461         https://bugs.webkit.org/show_bug.cgi?id=58408
1462
1463         Test shell still not ready for animate changes.
1464
1465         * DumpRenderTree/chromium/WebViewHost.cpp:
1466         (WebViewHost::paintInvalidatedRegion):
1467
1468 2011-06-24  Adam Roben  <aroben@apple.com>
1469
1470         Fix typos introduced in r89696
1471
1472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1473         (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
1474         callback, since that's what it expects.
1475
1476 2011-06-24  Adam Roben  <aroben@apple.com>
1477
1478         Make TestFailures correctly remember whether old-run-webkit-tests exited early
1479
1480         Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
1481         completion after reload
1482
1483         Reviewed by David Kilzer.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1486         (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
1487         in the PeristentCache, store an object that contains both the number of failures and whether
1488         old-run-webkit-tests exited early.
1489
1490 2011-06-24  Adam Roben  <aroben@apple.com>
1491
1492         Add links to regression ranges in Trac to the TestFailures page
1493
1494         Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
1495         links to regression ranges in Trac
1496
1497         Reviewed by David Kilzer.
1498
1499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
1500         (Trac): This new class represents a particular instance of Trac for a single project.
1501         (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
1502         repository path between the two specified revisions
1503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1504         (ViewController): Added new trac argument.
1505         (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
1506         passed/failed builds from here...
1507         (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
1508         Trac if there are multiple suspect revisions.
1509
1510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1511         Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
1512
1513 2011-05-17  Nat Duca  <nduca@chromium.org>
1514
1515         Reviewed by James Robinson.
1516
1517         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
1518         https://bugs.webkit.org/show_bug.cgi?id=58408
1519
1520         * DumpRenderTree/chromium/WebViewHost.cpp:
1521         (WebViewHost::paintInvalidatedRegion):
1522
1523 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
1524
1525         Reviewed by Dimitri Glazkov.
1526
1527         Convert shadow DOM-related tests to use window.internals
1528         https://bugs.webkit.org/show_bug.cgi?id=61671
1529
1530         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
1531         removeShadowRoot from layoutTestController; these have been
1532         replaced by equivalents in window.internals instead.
1533
1534         * DumpRenderTree/LayoutTestController.cpp:
1535         (LayoutTestController::staticFunctions):
1536         * DumpRenderTree/LayoutTestController.h:
1537         * DumpRenderTree/chromium/LayoutTestController.cpp:
1538         (LayoutTestController::LayoutTestController):
1539         * DumpRenderTree/chromium/LayoutTestController.h:
1540         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1541         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1542         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1543         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1544         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1545         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1546         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1547         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1548         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1549
1550 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
1551
1552         Reviewed by Dirk Schulze.
1553
1554         Make run-bindings-tests remove its temporary directories.
1555         https://bugs.webkit.org/show_bug.cgi?id=63320
1556
1557         * Scripts/run-bindings-tests:
1558
1559 2011-06-23  MORITA Hajime  <morrita@google.com>
1560
1561         Reviewed by Kent Tamura.
1562
1563         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
1564         https://bugs.webkit.org/show_bug.cgi?id=63216
1565
1566         Deleted m_webViewHost which looks leaked.
1567         
1568         * DumpRenderTree/chromium/TestShell.h:
1569         * DumpRenderTree/chromium/TestShell.cpp:
1570         (TestShell::~TestShell):
1571
1572 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1573
1574         Unreviewed. Fix WebKit2 GTK build.
1575
1576         * WebKitTestRunner/GNUmakefile.am:
1577
1578 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
1579
1580         Unreviewed, add myself as committer.
1581
1582         * Scripts/webkitpy/common/config/committers.py:
1583
1584 2011-06-23  Nat Duca  <nduca@chromium.org>
1585
1586         Unreviewed, add myself as committer.
1587
1588         * Scripts/webkitpy/common/config/committers.py:
1589
1590 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1591
1592         Reviewed by Tony Chang.
1593
1594         nrwt: move http locking code into manager
1595         https://bugs.webkit.org/show_bug.cgi?id=63103
1596
1597         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1598         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1599
1600 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
1601
1602         Reviewed by James Robinson.
1603
1604         [chromium] Add support for running layout tests with accelerated rendering
1605         https://bugs.webkit.org/show_bug.cgi?id=63274
1606
1607         * Scripts/webkitpy/layout_tests/port/chromium.py:
1608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1609
1610 2011-06-23  Adam Roben  <aroben@apple.com>
1611
1612         Avoid fetching JSON data when possible on TestFailures page to determine if
1613         old-run-webkit-tests exited early
1614
1615         As of r89610, results.html includes information about whether old-run-webkit-tests exited
1616         early, so we don't need to look at JSON data to get this information for builds newer than
1617         that.
1618
1619         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
1620         which is slow and limits history to the last build master restart
1621
1622         Reviewed by David Kilzer.
1623
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1625         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
1626         function. If we're dealing with a build that has early-exit information in results.html,
1627         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
1628         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
1629         (as before).
1630
1631 2011-06-23  Eric Seidel  <eric@webkit.org>
1632
1633         Reviewed by Adam Barth.
1634
1635         sheriffbot can no longer restart
1636         https://bugs.webkit.org/show_bug.cgi?id=63221
1637
1638         Fixed and unit tested.
1639
1640         * Scripts/webkitpy/tool/bot/queueengine.py:
1641         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1642         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1643
1644 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
1645
1646         Reviewed by Xan Lopez.
1647
1648         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
1649         https://bugs.webkit.org/show_bug.cgi?id=63287
1650
1651         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
1652         so that the plugin loads properly.
1653
1654         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
1655         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1656         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
1657         of the work for getting an environment variable and converting it to UTF-8.
1658         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
1659         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
1660
1661 2011-06-23  Adam Roben  <aroben@apple.com>
1662
1663         Record whether old-run-webkit-tests aborted early in results.html
1664
1665         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
1666         old-run-webkit-tests stopped running tests early
1667
1668         Reviewed by David Kilzer.
1669
1670         * Scripts/old-run-webkit-tests:
1671         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
1672         Added a <style> element with some styles for the new message. If we stopped running early,
1673         put the reason why at the top of results.html.
1674         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
1675         $stoppedRunningEarlyMessage global.
1676
1677 2011-06-23  Adam Roben  <aroben@apple.com>
1678
1679         Cache some of the TestFailures page's data in localStorage
1680
1681         This makes reloading TestFailures much faster. Right now we only store the number of failing
1682         tests and the list of failing tests for each build. We may choose to store more later, but
1683         it's easy to run up against quota limits.
1684
1685         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
1686         APIs (or similar) to improve loading performance
1687
1688         Reviewed by David Kilzer.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1691         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
1692         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
1693         fetching data to the callback.
1694         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
1695         store the tests in the cache just before calling the callback. (The previous code in this
1696         function relied on being able to modify the tests object after storing it in the cache and
1697         having the cached version be updated. This worked while it was a non-serialized cache, but
1698         PersistentCache uses serialization.)
1699
1700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
1701         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
1702         values, and stores the date that each value was initially stored along with it. This is
1703         later used for pruning the cache.
1704         (PersistentCache.contains): Checks whether the key exists in localStorage.
1705         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
1706         value out of it.
1707         (PersistentCache.set): Serialize the value, add the date to it, and store it in
1708         localStorage. If this fails due to quota limits, empty the whole cache and try again.
1709         (PersistentCache.prune): Delete any cached data that is deemed old enough.
1710         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
1711         (PersistentCache._emptyCache): Delete everything from localStorage.
1712         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
1713         return them.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1716         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
1717         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
1718         where we'd never show the new bug link for tests for which we couldn't determine a passing
1719         revision.
1720
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1722         PersistentCache.js.
1723
1724 2011-06-23  Adam Roben  <aroben@apple.com>
1725
1726         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
1727
1728         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
1729         contain titles that are so long they are rejected by Bugzilla
1730
1731         Reviewed by David Kilzer.
1732
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1734         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
1735         using a query string on the URL. If the search query is very long, using a query string can
1736         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
1737         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1740         (.new-bug-form): Hide the form that we secretly use to file a new bug.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1743         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
1744         query parameters to the URL. Otherwise, send them as the body of the request along with the
1745         appropriate headers.
1746         (getResource): Now just calls through to fetchResource.
1747         (urlEncodedQueryParameters): Added. Moved some code here...
1748         (addQueryParametersToURL): ...from here.
1749
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1751         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
1752         number of failing tests if mentioning all the tests would make the title too long. Improved
1753         the description for large numbers of failures by listing the tests one-per-line instead of
1754         just having them be comma-separated, which was hard to read. Use a form to file the new bug
1755         instead of a link so that we can POST the form data. (Using a URL with a query string can
1756         result in the URL being too long.) The new bug link now just submits the form.
1757
1758 2011-06-23  Adam Roben  <aroben@apple.com>
1759
1760         Show closed bugs on the TestFailures page in addition to open ones
1761
1762         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
1763
1764         Reviewed by David Kilzer.
1765
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1767         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
1768         returned data.
1769         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
1770         the associated bug is still open.
1771
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1773         (addQueryParametersToURL): Add a missing semicolon.
1774         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
1775         object and appends each of the values stored within.
1776
1777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1778         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
1779         bugs will be included in the results. Split the returned bugs into two sets: those which are
1780         open, and those which are closed. Put the open bugs at the top level of the list, and the
1781         closed bugs in a second level.
1782
1783 2011-06-23  Adam Roben  <aroben@apple.com>
1784
1785         Don't count new tests as failures on the TestFailures page
1786
1787         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
1788         they aren't
1789
1790         Reviewed by Anders Carlsson.
1791
1792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1793         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
1794         of failures.
1795
1796 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1797
1798         Reviewed by Eric Seidel.
1799
1800         nrwt: make TestInput objects printable
1801         https://bugs.webkit.org/show_bug.cgi?id=63225
1802
1803         This makes debugging slighlty easier.
1804
1805         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1806
1807 2011-06-22  Daniel Bates  <dbates@webkit.org>
1808
1809         Reviewed by Adam Barth.
1810
1811         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
1812         https://bugs.webkit.org/show_bug.cgi?id=62943
1813
1814         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
1815         by Scripts/webkitpy/common/checkout/__init__.py.
1816
1817         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1818
1819 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
1820
1821         Reviewed by Mark Rowe.
1822
1823         Add window.internals to WebKit2's WebKitTestRunner.
1824         https://bugs.webkit.org/show_bug.cgi?id=61073
1825
1826         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
1827         * WebKitTestRunner/Configurations/Base.xcconfig:
1828         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1829         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1830         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1831         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1832         (WTR::InjectedBundlePage::didClearWindowForFrame):
1833         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1834         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1835
1836 2011-06-22  Eric Seidel  <eric@webkit.org>
1837
1838         Reviewed by Adam Barth.
1839
1840         Make sheriff-bot rollout messages a little nicer
1841         https://bugs.webkit.org/show_bug.cgi?id=63107
1842
1843         itertools.chain.from_iterable is new in 2.6,
1844         use itertools.chain(*list) for 2.5 compat.
1845
1846         * Scripts/webkitpy/tool/bot/irc_command.py:
1847
1848 2011-06-22  Eric Seidel  <eric@webkit.org>
1849
1850         Reviewed by Adam Barth.
1851
1852         Make sheriff-bot robust against exceptions from commands
1853         https://bugs.webkit.org/show_bug.cgi?id=63211
1854
1855         sheriff-bot was acting strange this afternoon.
1856         We don't know if this will fix the cause, but
1857         at least it adds some unit tests and catches
1858         one possible cause.
1859
1860         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1861         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1862
1863 2011-06-22  Mark Rowe  <mrowe@apple.com>
1864
1865         Reviewed by David Levin.
1866
1867         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
1870         be relative to the built products directory rather than using a hard-coded path. Remove the
1871         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
1872         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
1873         rather than in the .xcodeproj directly.
1874
1875 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1876
1877         Reviewed by Ojan Vafai.
1878
1879         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
1880         https://bugs.webkit.org/show_bug.cgi?id=59993
1881
1882         * Scripts/webkitpy/layout_tests/port/base.py:
1883         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1884         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1885         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1886         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1887         * Scripts/webkitpy/layout_tests/port/gtk.py:
1888         * Scripts/webkitpy/layout_tests/port/mac.py:
1889         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1890         * Scripts/webkitpy/layout_tests/port/qt.py:
1891         * Scripts/webkitpy/layout_tests/port/win.py:
1892
1893 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
1894
1895         Reviewed by Andreas Kling.
1896
1897         Move macpherson from contributor list to committer list.
1898         https://bugs.webkit.org/show_bug.cgi?id=63179
1899
1900         * Scripts/webkitpy/common/config/committers.py:
1901         Move macpherson from contributor list to committer list.
1902
1903 2011-06-22  David Levin  <levin@chromium.org>
1904
1905         Reviewed by Adam Barth.
1906
1907         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
1908         https://bugs.webkit.org/show_bug.cgi?id=63204
1909
1910         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
1911           with similar code for the parameter checking.
1912         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
1913           those done for single lines since they don't make sense in that case (variable decls look like function decls).
1914           Removed some redundant comments (one of which was slightly wrong).
1915           Added checks for the new functionality and minor other test changes.
1916
1917 2011-06-22  Nate Chapin  <japhet@chromium.org>
1918
1919         Reviewed by Adam Barth.
1920
1921         Add libsoup to libWebCoreInternals build.
1922         https://bugs.webkit.org/show_bug.cgi?id=62066
1923
1924         * GNUmakefile.am:
1925
1926 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1927
1928         Reviewed by Tony Chang.
1929
1930         nrwt: handle missing httpd cleanly
1931         https://bugs.webkit.org/show_bug.cgi?id=62027
1932
1933         We had reverted the change in r89414, so this adds it back in
1934         (modifying check_sys_deps() in port/base.py to check for an
1935         installed web server).
1936
1937         This change then fixes the change in r89414 to stub out the
1938         check_sys_deps() in the test port so that the unit tests run correctly.
1939
1940         * Scripts/webkitpy/layout_tests/port/base.py:
1941         * Scripts/webkitpy/layout_tests/port/test.py:
1942
1943 2011-06-22  David Levin  <levin@chromium.org>
1944
1945         Reviewed by Adam Barth.
1946
1947         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
1948         https://bugs.webkit.org/show_bug.cgi?id=63188
1949
1950         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
1951         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1952
1953 2011-06-22  Tony Chang  <tony@chromium.org>
1954
1955         Reviewed by Ojan Vafai.
1956
1957         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
1958         https://bugs.webkit.org/show_bug.cgi?id=62891
1959
1960         * BuildSlaveSupport/build.webkit.org-config/config.json:
1961
1962 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1963
1964         Reviewed by Ojan Vafai.
1965
1966         nrwt: don't look for http lock when running the test port
1967         https://bugs.webkit.org/show_bug.cgi?id=63158
1968
1969         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1970         * Scripts/webkitpy/layout_tests/port/test.py:
1971
1972 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
1973
1974         Reviewed by Andreas Kling.
1975
1976         [Qt][WK2] Set up plugin tests
1977         https://bugs.webkit.org/show_bug.cgi?id=63066
1978
1979         * WebKitTestRunner/qt/TestControllerQt.cpp:
1980         (WTR::TestController::initializeTestPluginDirectory):
1981         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
1982         of the test plugin like DRT does.
1983
1984 2011-06-22  Eric Seidel  <eric@webkit.org>
1985
1986         Reviewed by Ojan Vafai.
1987
1988         Make sheriff-bot rollout messages a little nicer
1989         https://bugs.webkit.org/show_bug.cgi?id=63107
1990
1991         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
1992         into urls myself.  So I have now fixed its "preparing" message to include a url.
1993
1994         I also figured that I should make the messages mention all of the responsible parties
1995         so that rollouts are never surprises.  If you're in the channel and were involved
1996         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
1997
1998         As part of doing this I also changed (and tested) _parse_args to fail-fast
1999         when given invalid args.
2000
2001         * Scripts/webkitpy/tool/bot/irc_command.py:
2002         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2003         * Scripts/webkitpy/tool/bot/sheriff.py:
2004         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2005
2006 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
2007
2008         Reviewed by Tony Chang.
2009
2010         run-webkit-websocketserver fails to stop websocket server
2011         https://bugs.webkit.org/show_bug.cgi?id=63123
2012
2013         There's a ten-character change in new-run-webkit-websocketserver
2014         that fixes the actual bug, and then we update the code in
2015         new-run-webkit-httpd to do the actual stop call, and add more tests
2016         (refactoring the existing test code so that it is shared).
2017
2018         * Scripts/new-run-webkit-httpd:
2019         * Scripts/new-run-webkit-websocketserver:
2020         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
2021
2022 2011-06-22  Adam Roben  <aroben@apple.com>
2023
2024         Add links to existing bugs related to failing tests on TestFailures page
2025
2026         I changed the layout of the page a little to make it easier to read with all the new
2027         information. Passing/failing revisions have been moved down below the list of tests to be
2028         closer to the existing bugs and the new bug link. And each set of tests and its relevant
2029         information is in a light gray box.
2030
2031         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
2032         possible
2033
2034         Reviewed by Darin Adler.
2035
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
2037         (Bugzilla): This new class represents a single Bugzilla instance.
2038         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
2039         passing the resulting bug titles and URLs to the callback when complete. If called multiple
2040         times with the same query before the query returns, caches the callbacks so that only one
2041         query is sent over the wire. When the query completes, all pending callbacks are called.
2042
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2044         (#failure-history): Reduce the margin/padding on the top-level list a bit.
2045         (#failure-history > li): Put each set of tests in a gray box, and indent most information
2046         inside the box.
2047         (.test-list): Unindent the list of failing tests so it is visually at the top level.
2048         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
2049         each box isn't a big empty space.
2050         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
2051         quite long.
2052
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
2054         (addQueryParametersToURL): New function extracted from
2055         ViewController.prototype._domForNewAndExistingBugs.
2056
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2058         (ViewController): Take and store an optional Bugzilla instance.
2059         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
2060         purposes and move the list of failing tests above all other information. Only show bug
2061         information once we've determined the most-recent passing revision for a set of tests. It's
2062         not that useful to file a new bug before this information has been determined, and searching
2063         for existing bugs before we've figured out which tests started failing at the same time
2064         would end up giving you information about a bunch of unrelated tests.
2065         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
2066         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
2067         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
2068         failing tests, and adds links to the bugs when the search completes.
2069
2070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
2071         Bugzilla instance for bugs.webkit.org to the ViewController.
2072
2073 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2074
2075         Reviewed by Martin Robinson.
2076
2077         [GTK] Apply current view settings to newly created views in GtkLauncher
2078         https://bugs.webkit.org/show_bug.cgi?id=63142
2079
2080         * GtkLauncher/main.c:
2081         (createWebViewCb):
2082
2083 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2084
2085         Reviewed by Martin Robinson.
2086
2087         [GTK] Use GOption to parse main arguments in GtkLauncher
2088         https://bugs.webkit.org/show_bug.cgi?id=63060
2089
2090         Instead of getting the settings from the view, create a new
2091         settings object not associated with any view so that we can parse
2092         the command line arguments before creating the view. It will also
2093         allows to use the same settings for more than one view if we
2094         eventually support passing more than one uri from the command
2095         line.
2096
2097         * GtkLauncher/main.c:
2098         (parseOptionEntryCallback): Make this function static. Also use
2099         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
2100         of atoi/atof to provide better error messages. And always fill the
2101         error struct when the function fails.
2102         (getOptionEntriesFromWebKitWebSettings): Use an array of
2103         GOptionEntry structs instead of a GArray, since that is what
2104         g_option_group_add_entries() expects and the array size doesn't
2105         change.
2106         (addWebSettingsGroupToContext): Helper function to add the
2107         websettings group to the option context.
2108         (main): Create the option context to parse command line arguments.
2109
2110 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
2111
2112         Reviewed by Adam Roben.
2113
2114         [GTK] Implement pixel dump support for WebKitTestRunner
2115         https://bugs.webkit.org/show_bug.cgi?id=58242
2116
2117         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
2118         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
2119         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
2120         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
2121         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
2122         file so that we can share it across platforms.
2123         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
2124         * WebKitTestRunner/TestInvocation.h: Updated method list.
2125         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
2126         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2127         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
2128
2129 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
2130
2131         Unreviewed, rolling out r89414.
2132         http://trac.webkit.org/changeset/89414
2133         https://bugs.webkit.org/show_bug.cgi?id=63130
2134
2135         It broke webkitpy tests (Requested by Ossy on #webkit).
2136
2137         * Scripts/webkitpy/layout_tests/port/base.py:
2138
2139 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2140
2141         Reviewed by Dirk Pranke.
2142
2143         [NRWT] Print error message when there is no httpd present on the system
2144         https://bugs.webkit.org/show_bug.cgi?id=62027
2145
2146         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2147
2148 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
2149
2150         Unreviewed, build fix.
2151         Fix crashes in new-run-webkit-tests resulting from the
2152         change to the http_server logic in r89400. Python 2.5
2153         on Mac 10.5 has some weird error paths.
2154
2155         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2156         * Scripts/webkitpy/common/system/executive.py:
2157
2158 2011-06-21  MORITA Hajime  <morrita@google.com>
2159
2160         Unreviewed, rolling out r89401 and r89403.
2161         http://trac.webkit.org/changeset/89401
2162         http://trac.webkit.org/changeset/89403
2163         https://bugs.webkit.org/show_bug.cgi?id=62970
2164
2165         Breaks mac build and mistakenly enables the spellcheck API
2166
2167         * Scripts/build-webkit:
2168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2169
2170 2011-06-21  Kent Tamura  <tkent@chromium.org>
2171
2172         [Mac] Sort Xcode project files.
2173
2174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2175
2176 2011-06-20  MORITA Hajime  <morrita@google.com>
2177
2178         Reviewed by Kent Tamura.
2179
2180         Spellcheck API should be build-able.
2181         https://bugs.webkit.org/show_bug.cgi?id=62970
2182
2183         * Scripts/build-webkit:
2184
2185 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
2186
2187         Reviewed by Tony Chang.
2188
2189         nrwt: attempt #3 at fixing server startup/shutdown
2190         https://bugs.webkit.org/show_bug.cgi?id=62829
2191
2192         Attempt yet again to make starting and stopping servers
2193         reliable. It turns out that apache has races between when the
2194         ctl process exists and when it writes/removes the pid file.
2195         This change accounts for the races.
2196
2197         * Scripts/new-run-webkit-httpd:
2198         * Scripts/webkitpy/common/system/executive.py:
2199         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2200         * Scripts/webkitpy/layout_tests/port/base.py:
2201         * Scripts/webkitpy/layout_tests/port/http_server.py:
2202         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2203         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2204         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2205         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2206
2207 2011-06-21  Dmitry Lomov  <dslomov@google.com>
2208
2209         Reviewed by Adam Roben.
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=63080
2212         Unit-tests step on test-only bot is broken.
2213         Removing the step until run-api-tests is fixed.
2214
2215         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2216
2217 2011-06-20  Dmitry Lomov  <dslomov@google.com>
2218
2219         Reviewed by David Levin.
2220
2221         https://bugs.webkit.org/show_bug.cgi?id=63017
2222         "Unit tests" step on bots should provide more information in case of failure.
2223
2224         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
2225
2226 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
2227
2228         Reviewed by Ojan Vafai.
2229
2230         new-run-webkit-tests: order shards by name, not number of tests
2231         https://bugs.webkit.org/show_bug.cgi?id=62753
2232
2233         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2234
2235 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
2236
2237         Reviewed by Ojan Vafai.
2238
2239         we should only log the test names to the tests_run.txt files during layout_tests
2240         https://bugs.webkit.org/show_bug.cgi?id=62751
2241
2242         * Scripts/old-run-webkit-tests:
2243         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2244
2245 2011-06-20  Eric Seidel  <eric@webkit.org>
2246
2247         Reviewed by Adam Barth.
2248
2249         commit-queue/ews-bots should run run-bindings-tests for every patch
2250         https://bugs.webkit.org/show_bug.cgi?id=63010
2251
2252         * Scripts/webkitpy/common/config/ports.py:
2253         * Scripts/webkitpy/tool/commands/download_unittest.py:
2254         * Scripts/webkitpy/tool/steps/runtests.py:
2255         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2256         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2257
2258 2011-06-20  Chang Shu  <cshu@webkit.org>
2259
2260         Reviewed by Adam Barth.
2261
2262         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
2263         https://bugs.webkit.org/show_bug.cgi?id=53676
2264
2265         * WebKitTestRunner/TestController.cpp:
2266         (WTR::TestController::initialize):
2267
2268 2011-06-20  Eric Seidel  <eric@webkit.org>
2269
2270         Reviewed by Adam Barth.
2271
2272         buildbots should run run-bindings-tests
2273         https://bugs.webkit.org/show_bug.cgi?id=63001
2274
2275         run-bindings-tests takes 2.4 seconds on my machine, so
2276         I expect this will not be noticeable on the bots.
2277
2278         I also removed tiger-specific checks since Tiger is no
2279         longer a supported platform for webkit.
2280
2281         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2282
2283 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2284
2285         Unreviewed. Fix WebKit2 GTK build after r89249.
2286
2287         * GtkLauncher/main.c:
2288         (main):
2289
2290 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
2291
2292         Reviewed by Yury Semikhatsky.
2293
2294         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
2295         https://bugs.webkit.org/show_bug.cgi?id=62994
2296
2297         * DumpRenderTree/LayoutTestController.cpp:
2298         (closeWebInspectorCallback):
2299         (LayoutTestController::staticFunctions):
2300         * DumpRenderTree/LayoutTestController.h:
2301         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2302         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2303         * DumpRenderTree/chromium/LayoutTestController.cpp:
2304         (LayoutTestController::LayoutTestController):
2305         * DumpRenderTree/chromium/LayoutTestController.h:
2306         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2307         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2308         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2309         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2310         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2311         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2312         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2313         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2314         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2315
2316 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
2317
2318         Reviewed by Martin Robinson.
2319
2320         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
2321         https://bugs.webkit.org/show_bug.cgi?id=55308
2322
2323         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
2324         (parseOptionEntryCallback): Callback for parsing option entry.
2325         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
2326         list of option entries.
2327         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
2328         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
2329         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
2330         (parseAdditionalOptions): Help function parsing additional commandline options.
2331         (main): Added call to parseAdditionalOptions.
2332
2333 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2334
2335         Reviewed by Andreas Kling.
2336
2337         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
2338         https://bugs.webkit.org/show_bug.cgi?id=62869
2339
2340         Add QFont include to fix "incomlete type QFont" error.
2341
2342         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2343
2344 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
2345
2346         Reviewed by Martin Robinson.
2347
2348         [GTK] Enable Media Stream feature and make it default on
2349         https://bugs.webkit.org/show_bug.cgi?id=60394
2350
2351         * Scripts/build-webkit:
2352
2353 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2354
2355         Unreviewed, rolling out r89198.
2356         http://trac.webkit.org/changeset/89198
2357         https://bugs.webkit.org/show_bug.cgi?id=62953
2358
2359         Chromium breakage on "Linux Tests" (Requested by senorblanco
2360         on #webkit).
2361
2362         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2363         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2364         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2365
2366 2011-06-18  Daniel Bates  <dbates@webkit.org>
2367
2368         Reviewed by Eric Seidel.
2369
2370         Git.push_local_commits_to_server() should use passed username and
2371         password when we don't have cached credentials
2372         https://bugs.webkit.org/show_bug.cgi?id=62941
2373
2374         Fixes a issue where Git.push_local_commits_to_server() would always look
2375         for cached credentials regardless of whether a username and password
2376         were passed as arguments. Instead, if given both a username and password
2377         then we shouldn't look for cached credentials (since we were explicitly given
2378         credentials).
2379
2380         * Scripts/webkitpy/common/checkout/scm/git.py:
2381         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
2382
2383 2011-06-18  Daniel Bates  <dbates@rim.com>
2384
2385         Rubber-stamped by Eric Seidel.
2386
2387         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2388         https://bugs.webkit.org/show_bug.cgi?id=62767
2389
2390         Part 3 of 3
2391
2392         Remove the command-line option --skip-build now that the master BuildBot has been restarted
2393         following <http://trac.webkit.org/changeset/89138>.
2394
2395         Instead, specify --no-build to get analogous functionality.
2396
2397         * Scripts/run-javascriptcore-tests:
2398
2399 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
2400
2401         Reviewed by Tony Chang.
2402
2403         new-run-webkit-tests: fix test sorting
2404         https://bugs.webkit.org/show_bug.cgi?id=58691
2405
2406         This changes the sorting to use a "natural" sort order such that
2407         foo2.html sorts before foo13.html, and sorts the tests so
2408         that all the tests in a directory are run before any test in a
2409         subdirectory.
2410
2411         This change also adds a split() method to the filesystem since
2412         that is needed to cluster files into a directory otherwise.
2413
2414         * Scripts/webkitpy/common/system/filesystem.py:
2415         * Scripts/webkitpy/common/system/filesystem_mock.py:
2416         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2417         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
2418
2419 2011-06-18  Evan Martin  <evan@chromium.org>
2420
2421         Reviewed by Darin Adler.
2422
2423         Compiler warning in double->int conversion in TestNetscapePlugIn
2424         https://bugs.webkit.org/show_bug.cgi?id=51554
2425
2426         This code is providing a JS API for removing a property by numeric ID.
2427         We get it from JS as a double, and must convert it to an int before using it.
2428
2429         Test: LayoutTests/plugins/npruntime/remove-property.html
2430
2431         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
2432         (NPRuntimeRemoveProperty::TestObject::invoke):
2433
2434 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
2435
2436         Reviewed by Eric Seidel.
2437
2438         Don't exit webkit-patch when running on Win32 python
2439         https://bugs.webkit.org/show_bug.cgi?id=55811
2440
2441         Most of the basic actions work in the meantime,
2442         so let people play with in on Win32 now.
2443
2444         * Scripts/webkit-patch:
2445
2446 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
2447
2448         Reviewed by Ojan Vafai.
2449
2450         Convert json_results_generator.py to output version 4 JSON.
2451         https://bugs.webkit.org/show_bug.cgi?id=60869
2452
2453         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2454         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2455         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2456
2457 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
2458
2459         Reviewed by Eric Seidel.
2460
2461         Some names with spaces are incorrectly reported as not containing spaces
2462         while running prepare-ChangeLog
2463         https://bugs.webkit.org/show_bug.cgi?id=55572
2464
2465         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
2466           non-alphanumeric characters in names.
2467
2468 2011-06-18  Michael Saboff  <msaboff@apple.com>
2469
2470         Reviewed by Eric Seidel.
2471
2472         Enhancement: New Script to Format malloc_history output as tree
2473         https://bugs.webkit.org/show_bug.cgi?id=56378
2474
2475         New script to process malloc_history output to tree format.
2476
2477         * Scripts/malloc-tree: Added.
2478
2479 2011-06-17  Dmitry Lomov  <dslomov@google.com>
2480
2481         Reviewed by Daniel Bates.
2482
2483         https://bugs.webkit.org/show_bug.cgi?id=62918 
2484         Pass configuration to UnitTests step in master.cfg
2485
2486         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2487
2488 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
2489
2490         Reviewed by Eric Seidel.
2491
2492         [EFL] Add Evas-based ImageDiff implementation.
2493         https://bugs.webkit.org/show_bug.cgi?id=61942
2494
2495         Build system changes will be performed as soon as the complete
2496         DumpRenderTree implementation is upstreamed.
2497
2498         * DumpRenderTree/efl/ImageDiff.cpp: Added.
2499         (pixelFromImageData):
2500         (differenceImageFromDifferenceBuffer):
2501         (computeDistanceBetweenPixelComponents):
2502         (calculatePixelDifference):
2503         (calculateDifference):
2504         (getTemporaryFile):
2505         (printImage):
2506         (printImageDifferences):
2507         (resizeEcoreEvasIfNeeded):
2508         (readImageFromStdin):
2509         (parseCommandLineOptions):
2510         (shutdownEfl):
2511         (abortWithErrorMessage):
2512         (initEfl):
2513         (main):
2514
2515 2011-06-17  Tony Chang  <tony@chromium.org>
2516
2517         Reviewed by Dirk Pranke.
2518
2519         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
2520         https://bugs.webkit.org/show_bug.cgi?id=62907
2521
2522         This fixes a bug where the ImageDiff on the user's machine doesn't
2523         match the logic used on the Chromium buildbots.  This has the downside
2524         of requiring that the Chromium ImageDiff is built, but it turns out
2525         that even with --tolerance 0, the CG ImageDiff will allow small pixel
2526         differences through.
2527
2528         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2529
2530 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2531
2532         [WinCairo] Unreviewed build correction.
2533
2534         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
2535         Update WinCairo property sheet to link against the Cairo DLL,
2536         now that we are using a more recent Cairo build. 
2537
2538 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2539
2540         Reviewed by Brian Weinstein.
2541
2542         Create a simple example of using the COM-based C++ listeners.
2543         A new onclick event is attached (via C++) to the WebKit logo
2544         in the default test pattern displayed on startup.  Clicking on
2545         the logo causes a message box to be displayed.
2546         https://bugs.webkit.org/show_bug.cgi?id=61885
2547
2548         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
2549           the WebScriptObject and DOMEventListener.
2550         * WinLauncher/WinLauncher.cpp:
2551         (SimpleEventListener::SimpleEventListener): Example implementation
2552           of a simple DOM event listener.
2553         (SimpleEventListener::handleEvent): 
2554         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
2555          to bind a C++ method to the 'onclick' event for the WebKit logo.
2556         (_tWinMain):
2557         * WinLauncher/WinLauncher.h:
2558         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
2559
2560 2011-06-17  Chang Shu  <cshu@webkit.org>
2561
2562         Reviewed by Andreas Kling.
2563
2564         [Qt] [WK2] Support undo/redo in MiniBrowser
2565         https://bugs.webkit.org/show_bug.cgi?id=62809
2566
2567         * MiniBrowser/qt/BrowserWindow.cpp:
2568         (BrowserWindow::BrowserWindow):
2569
2570 2011-06-17  Daniel Bates  <dbates@rim.com>
2571
2572         Rubber-stamped by Eric Seidel.
2573
2574         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2575         https://bugs.webkit.org/show_bug.cgi?id=62767
2576
2577         Part 2 of 3
2578
2579         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
2580         command line option instead of --skip-build.
2581
2582         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
2583         master buildbot picks up the change.
2584
2585         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2586
2587 2011-06-17  Daniel Bates  <dbates@rim.com>
2588
2589         Rubber-stamped by Eric Seidel.
2590
2591         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2592         https://bugs.webkit.org/show_bug.cgi?id=62767
2593
2594         Part 1 of 3
2595
2596         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
2597         run-javascriptcore-tests. Also, add a remark about these options to the usage message
2598         printed by run-javascriptcore-tests.
2599
2600         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
2601
2602         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
2603           of $showHelp.
2604
2605 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
2606
2607         Reviewed by Martin Robinson.
2608
2609         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
2610         https://bugs.webkit.org/show_bug.cgi?id=60687
2611
2612         Replace GdkRectangle by cairo_rectangle_int_t.
2613
2614         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
2615         (createBitmapContextFromWebView):
2616         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
2617         (firstRectForCharacterRangeCallback):
2618
2619 2011-06-16  Dmitry Lomov  <dslomov@google.com>
2620
2621         Reviewed by David Levin.
2622
2623         https://bugs.webkit.org/show_bug.cgi?id=62603
2624         Run run-api-tests on bots in debug mode.
2625         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
2626
2627         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2628
2629 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
2630
2631         Reviewed by Eric Seidel.
2632
2633         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
2634         WorkQueueItem.
2635         They will be plugged into the build system once the EFL's DRT is
2636         fully upstreamed.
2637         https://bugs.webkit.org/show_bug.cgi?id=61958
2638
2639         * DumpRenderTree/efl: Added.
2640         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
2641         (GCController::collect):
2642         (GCController::collectOnAlternateThread):
2643         (GCController::getJSObjectCount):
2644         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
2645         (createBitmapContextFromWebView):
2646         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
2647         (LoadItem::invoke):
2648         (LoadHTMLStringItem::invoke):
2649         (ReloadItem::invoke):
2650         (ScriptItem::invoke):
2651         (BackForwardItem::invoke):
2652         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
2653         (WorkQueueItem::~WorkQueueItem):
2654         (LoadItem::LoadItem):
2655         (LoadHTMLStringItem::LoadHTMLStringItem):
2656         (ScriptItem::ScriptItem):
2657         (LoadingScriptItem::LoadingScriptItem):
2658         (LoadingScriptItem::invoke):
2659         (NonLoadingScriptItem::NonLoadingScriptItem):
2660         (NonLoadingScriptItem::invoke):
2661         (BackForwardItem::BackForwardItem):
2662         (BackItem::BackItem):
2663         (ForwardItem::ForwardItem):
2664
2665 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2666
2667         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
2668         preference like the perl scripts do.
2669
2670         * waf/build/build_utils.py:
2671         * waf/build/settings.py:
2672
2673 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
2674
2675         Reviewed by Tony Gentilcore.
2676
2677         MediaStream API: Runtime enabled features
2678         https://bugs.webkit.org/show_bug.cgi?id=62798
2679
2680         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
2681
2682         * DumpRenderTree/chromium/TestShell.cpp:
2683         (TestShell::TestShell):
2684
2685 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
2686
2687         Reviewed by Eric Seidel.
2688
2689         Add support for sys.platform == 'linux3' by relaxing
2690         conditional statements and/or extending lookup dicts.
2691         This way, Linux kernels >=3.0-rc1 get supported in the
2692         build process.
2693         https://bugs.webkit.org/show_bug.cgi?id=62730
2694
2695         * Scripts/webkitpy/common/system/executive.py:
2696         * Scripts/webkitpy/common/system/file_lock.py:
2697         * Scripts/webkitpy/common/system/path_unittest.py:
2698         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2699         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2700         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2701         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2702         * Scripts/webkitpy/layout_tests/port/factory.py:
2703         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2704         * Scripts/webkitpy/layout_tests/port/qt.py:
2705         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2706
2707 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2708
2709         Unreviewed, rolling out r88796.
2710         http://trac.webkit.org/changeset/88796
2711         https://bugs.webkit.org/show_bug.cgi?id=62790
2712
2713         It made fast/dom/nodesFromRect-basic.html time out on Qt,
2714         64-bit, debug mode (Requested by Ossy on #webkit).
2715
2716         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2717         (LayoutTestController::nodesFromRect):
2718         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2719         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2720         (PlainTextController::plainText):
2721         * DumpRenderTree/qt/PlainTextControllerQt.h:
2722
2723 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2724
2725         Unreviewed, build fix.
2726
2727         Revert the patches in r88995 and r88999; the http servers don't
2728         seem to be shutting down reliably.
2729
2730         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2731         * Scripts/webkitpy/layout_tests/port/base.py:
2732         * Scripts/webkitpy/layout_tests/port/http_server.py:
2733         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2734         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
2735         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2736         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2737
2738 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2739
2740         Unreviewed, build fix.
2741
2742         Add some debugging messages to triage problems introduced in
2743         r88995.
2744
2745         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2746
2747 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2748
2749         Reviewed by Tony Chang.
2750
2751         nrwt: should clean up stale server processes from a previous run
2752         https://bugs.webkit.org/show_bug.cgi?id=62615
2753
2754         This change fixes cases where NRWT might start a server and then
2755         exit, leaving the server still running. Now NRWT should detect
2756         this case and clean up on the next run, without shutting down
2757         any processes it didn't start.
2758
2759         This change also fixes a bug in executive.kill_process on UNIX
2760         where zombies weren't being handled properly.
2761
2762         * Scripts/webkitpy/common/system/executive.py:
2763         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2764         * Scripts/webkitpy/layout_tests/port/base.py:
2765         * Scripts/webkitpy/layout_tests/port/http_server.py:
2766         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2767         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2768         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2769
2770 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2771
2772         Reviewed by Tony Chang.
2773
2774         nrwt: fix http, websocket server startup, shutdown
2775         https://bugs.webkit.org/show_bug.cgi?id=62180
2776
2777         This change refactors all of the server-related code to
2778         have consistent semantics. It pushes the start()/stop()
2779         logic into the base class and adds four much smaller routines
2780         for specialization:
2781         _prepare_config() - for optionally writing config files etc.
2782             to disk prior to starting the server
2783         _remove_stale_log_files()
2784         _spawn_process() - the actual launch of the subprocess
2785         _cleanup_after_stop() - and custom cleanup code
2786
2787         Prior to this change the three server implementations were
2788         fairly inconsistent, leading to lots of weirdness on the bots
2789         with servers being left around, etc.
2790
2791         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2792         * Scripts/webkitpy/layout_tests/port/http_server.py:
2793         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2794         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2795
2796 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2797
2798         Reviewed by Tony Chang.
2799
2800         webkitpy: clean up code prior to functional changes for server startup/shutdown
2801         https://bugs.webkit.org/show_bug.cgi?id=62256
2802
2803         This patch does a bunch of minor cleanup of the code, but there
2804         should be no functional changes except that all of the modules
2805         will now use the same exception type. Other changes include
2806         removing unused code paths and functions, pushing 'name' and
2807         'pid_file' into the base class of the server objects, and using
2808         the Filesystem object instead of the codecs, tempfile, and
2809         shutils modules.
2810
2811         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2812         * Scripts/webkitpy/layout_tests/port/http_server.py:
2813         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2814         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2815
2816 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2817
2818         Reviewed by Tony Chang.
2819
2820         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
2821         https://bugs.webkit.org/show_bug.cgi?id=62251
2822
2823         shut_down_http_server() was a total hack that was only used by
2824         new-run-webkit-httpd, so I've moved the code there and switched
2825         to using executive.kill_process() for the common case. The
2826         method itself will be removed in the patch on bug 59993.
2827
2828         * Scripts/new-run-webkit-httpd:
2829         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2830         * Scripts/webkitpy/layout_tests/port/http_server.py:
2831         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2832         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2833
2834 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2835
2836         Unreviewed, build fix.
2837
2838         Fix test-webkitpy failure introduced in r88986.
2839
2840         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2841
2842 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2843
2844         Reviewed by Eric Seidel.
2845
2846         NRWT: doesn't support webarchives, has stale skipping logic.
2847         https://bugs.webkit.org/show_bug.cgi?id=58293
2848
2849         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2850         * Scripts/webkitpy/layout_tests/port/base.py:
2851         * Scripts/webkitpy/layout_tests/port/webkit.py:
2852
2853 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
2854
2855         Change my email to @webkit.org
2856
2857         * Scripts/webkitpy/common/config/committers.py:
2858
2859 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
2860
2861         Reviewed by David Hyatt.
2862
2863         CSS 2.1: Support replaced elements with relative intrinsic sizes
2864         https://bugs.webkit.org/show_bug.cgi?id=15849
2865
2866         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
2867         https://bugs.webkit.org/show_bug.cgi?id=53099
2868
2869         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
2870
2871         * Scripts/old-run-webkit-tests:
2872         * Scripts/webkitpy/layout_tests/port/test_files.py:
2873
2874 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2875
2876         Reviewed by Martin Robinson.
2877
2878         [GTK] Add a statusbar to MiniBrowser
2879         https://bugs.webkit.org/show_bug.cgi?id=62634
2880
2881         It shows the url of the current hovered link.
2882
2883         * MiniBrowser/gtk/BrowserWindow.c:
2884         (browserWindowConstructed): Create the GtkSatusbar.
2885         (mouseDidMoveOverElement): Update statusbar text.
2886         (browserWindowUIClientInit): Add implementation for
2887         mouseDidMoveOverElement().
2888         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
2889         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
2890         (mouseDidMoveOverElement): Pass the url of the current hovered
2891         link to the UI process.
2892         (didCreatePage): Set the UI client adding an implementation for
2893         mouseDidMoveOverElement().
2894         (WKBundleInitialize):
2895         * MiniBrowser/gtk/main.c:
2896         (createWKContextWithInjectedBundle): Create a global context with
2897         the injected bundle.
2898         (loadURI): Use the global context.
2899         (main):
2900
2901 2011-06-14  Lucas Forschler  <lforschler@apple.com>
2902
2903         Reviewed by Stephanie Lewis.
2904
2905         https://bugs.webkit.org/show_bug.cgi?id=62495
2906         Bug 62495 - combine windows and mac kill-old-processes script
2907         Add a platform agnostic script.  Remove the recently added mac flavor.
2908         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
2909         
2910         * BuildSlaveSupport/kill-old-processes: Added.
2911         * BuildSlaveSupport/mac: Removed.
2912         * BuildSlaveSupport/mac/kill-old-processes: Removed.
2913
2914 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
2915
2916         Reviewed by Tony Chang.
2917
2918         nrwt: handle worker exceptions cleanly
2919         https://bugs.webkit.org/show_bug.cgi?id=62614
2920
2921         This change modifiers new-run-webkit-tests to handle exceptions
2922         raised by worker threads better, by:
2923         - capturing the worker's stack and logging it in the manager
2924         - propagating the worker's exception in the caller correctly
2925         - attempting to cancel the workers and clean up even when
2926           we get an unexpected exception
2927
2928         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2929         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2930         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2931         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2932
2933 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2934
2935         Reviewed by Laszlo Gombos.
2936
2937         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
2938         https://bugs.webkit.org/show_bug.cgi?id=62227
2939
2940         QtWebkit does not yet support different CacheModels. This change will 
2941         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
2942
2943         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2944         (LayoutTestController::setCacheModel):
2945         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2946
2947 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2948
2949         Reviewed by Andreas Kling.
2950
2951         [Qt] tst_QWebFrame::overloadedSlots() fails
2952         https://bugs.webkit.org/show_bug.cgi?id=37319
2953
2954         Since we don't implictly convert 'document' object to QWebElement
2955         in metacalls anymore, change the controller to expect QVariantMap instead.
2956
2957         The method plainText() was updated to use QVariantMap as well to let the bridge
2958         do the conversion directly for us.
2959
2960         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2961         (LayoutTestController::nodesFromRect):
2962         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2963         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2964         (PlainTextController::plainText):
2965         * DumpRenderTree/qt/PlainTextControllerQt.h:
2966
2967 2011-06-14  Andras Becsi  <abecsi@webkit.org>
2968
2969         Reviewed by Csaba Osztrogonác.
2970
2971         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
2972         https://bugs.webkit.org/show_bug.cgi?id=62630
2973
2974         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2975         (NPP_New): remove dead variable 'forceCarbon'
2976
2977 2011-06-13  Hayato Ito  <hayato@chromium.org>
2978
2979         Reviewed by Ojan Vafai.
2980
2981         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
2982         https://bugs.webkit.org/show_bug.cgi?id=59188
2983
2984         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
2985         WebKitDriver should always return an actual hash value if DRT returns that.
2986
2987         No tests since I'll add sample reftests to make sure mismatch reftests work later,
2988         which should be in a separate patch.
2989
2990         * Scripts/webkitpy/layout_tests/port/webkit.py:
2991
2992 2011-06-13  Kent Tamura  <tkent@chromium.org>
2993
2994         [Chromium-win] Fix two wrong assertions exposed by r88757.
2995
2996         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2997         (WebThemeEngineDRTWin::paintTrackbar):
2998
2999 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
3000
3001         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
3002         and commit queue happy.
3003
3004         * Scripts/webkitpy/common/config/committers.py:
3005
3006 2011-06-13  Chris Rogers  <crogers@google.com>
3007
3008         Unreviewed build fix.
3009
3010         Build fix to chromium DRT until we can rebaseline some tests
3011         https://bugs.webkit.org/show_bug.cgi?id=62608
3012
3013         * DumpRenderTree/chromium/TestShell.cpp:
3014         (TestShell::TestShell):
3015
3016 2011-06-13  Chris Rogers  <crogers@google.com>
3017
3018         Reviewed by Dirk Pranke.
3019
3020         Add Web Audio support to chromium DRT
3021         https://bugs.webkit.org/show_bug.cgi?id=62306
3022
3023         * DumpRenderTree/chromium/LayoutTestController.cpp:
3024         (LayoutTestController::LayoutTestController):
3025         (LayoutTestController::reset):
3026         (LayoutTestController::setEncodedAudioData):
3027         * DumpRenderTree/chromium/LayoutTestController.h:
3028         (LayoutTestController::encodedAudioData):
3029         (LayoutTestController::shouldDumpAsAudio):
3030         (LayoutTestController::setShouldDumpAsAudio):
3031         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3032         (DRTPrinter::handleAudioHeader):
3033         (TestShellPrinter::handleAudioHeader):
3034         * DumpRenderTree/chromium/TestEventPrinter.h:
3035         * DumpRenderTree/chromium/TestShell.cpp:
3036         (TestShell::TestShell):
3037         (TestShell::dump):
3038
3039 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
3040
3041         Reviewed by Eric Seidel.
3042
3043         [EFL] Add load error handler to EWebLauncher
3044         https://bugs.webkit.org/show_bug.cgi?id=62347
3045
3046         Add a handler function of "load,error" to EWebLauncher.
3047         EWebLauncher now displays a simple error page on load errors.
3048
3049         * EWebLauncher/main.c:
3050         (on_load_error):
3051         (browserCreate):
3052
3053 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
3054
3055         Reviewed by Eric Seidel.
3056
3057         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
3058         https://bugs.webkit.org/show_bug.cgi?id=62385
3059
3060         Remove duplicate TestNetscapePlugIn implementation. Having two copies
3061         of this code makes keeping it in sync much more difficult. The files are
3062         almost identical and this change ports the X11 changes to main.cpp.
3063
3064         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3065         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
3066         some results on Qt and this seems to be unnecessary for the moment.
3067         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
3068         (handleEventX11): Use the handler to properly convert the keycode. Do not print
3069         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
3070         it should not be in the results.
3071         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
3072         XP_UNIX block is first by guarding against using a null instance.
3073         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
3074         the XP_UNIX define for Linux.
3075         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
3076         * GNUmakefile.am: Update source list.
3077
3078 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3079
3080         Unreviewed, rolling out r88671.
3081         http://trac.webkit.org/changeset/88671
3082         https://bugs.webkit.org/show_bug.cgi?id=62591
3083
3084         "didn't work" (Requested by dpranke on #webkit).
3085
3086         * Scripts/new-run-webkit-httpd:
3087         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3088         * Scripts/webkitpy/layout_tests/port/http_server.py:
3089         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3090         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
3091         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3092         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3093
3094 2011-06-13  Nate Chapin  <japhet@chromium.org>
3095
3096         Reviewed by Darin Fisher.
3097
3098         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
3099
3100         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3101
3102 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
3103
3104         Reviewed by Tony Chang.
3105
3106         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
3107         https://bugs.webkit.org/show_bug.cgi?id=62251
3108
3109         shut_down_http_server() was a total hack that was only used by
3110         new-run-webkit-httpd, so I've moved the code there and switched
3111         to using executive.kill_process() for the common case. The
3112         method itself will be removed in the patch on bug 59993.
3113
3114         * Scripts/new-run-webkit-httpd:
3115         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3116         * Scripts/webkitpy/layout_tests/port/http_server.py:
3117         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
3118         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3119
3120 2011-06-13  Tony Chang  <tony@chromium.org>
3121
3122         Reviewed by Dimitri Glazkov.
3123
3124         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
3125         https://bugs.webkit.org/show_bug.cgi?id=62578
3126
3127         * Scripts/build-webkit:
3128
3129 2011-06-13  Tony Chang  <tony@chromium.org>
3130
3131         Reviewed by Adam Barth.
3132
3133         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
3134         https://bugs.webkit.org/show_bug.cgi?id=62545
3135
3136         * Scripts/build-webkit:
3137
3138 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3139
3140         Reviewed by Martin Robinson.
3141
3142         [GTK] Export an API similar to WebKit1
3143         https://bugs.webkit.org/show_bug.cgi?id=57820
3144
3145         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
3146         code, but linking to libwebkit2gtk.
3147
3148         * GNUmakefile.am:
3149         * GtkLauncher/main.c:
3150         (createBrowser):
3151         (main):
3152
3153 2011-06-12  MORITA Hajime  <morrita@google.com>
3154
3155         Unreviewed, rolling out r88625.
3156         http://trac.webkit.org/changeset/88625
3157         https://bugs.webkit.org/show_bug.cgi?id=61073
3158
3159         Breaks SL Webkit2 Tests
3160
3161         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
3162         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3163         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
3164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3165         (WTR::InjectedBundlePage::didClearWindowForFrame):
3166         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3167
3168 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3169
3170         Reviewed by Antonio Gomes.
3171
3172         [Qt] LayoutTestController needs setTextDirection implementation
3173         https://bugs.webkit.org/show_bug.cgi?id=62442
3174
3175         Implements LayoutController.setTextDirection.
3176
3177         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3178         (LayoutTestController::setTextDirection):
3179         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3180
3181 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
3182
3183         Reviewed by Hajime Morita.
3184
3185         Add window.internals to WebKit2's WebKitTestRunner.
3186         https://bugs.webkit.org/show_bug.cgi?id=61073
3187
3188         Test: fast/harness/internals-object.html
3189
3190         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
3191         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3192         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
3193         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3194         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
3195         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3196
3197 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3198
3199         Unreviewed, rolling out r88616.
3200         http://trac.webkit.org/changeset/88616
3201         https://bugs.webkit.org/show_bug.cgi?id=62517
3202
3203         It broke editing/text-iterator/findString.html (Requested by
3204         tonikitoo on #webkit).
3205
3206         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3207         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3208
3209 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3210
3211         Reviewed by Antonio Gomes.
3212
3213         [Qt] LayoutTestController needs setTextDirection implementation
3214         https://bugs.webkit.org/show_bug.cgi?id=62442
3215
3216         Implements LayoutController.setTextDirection.
3217
3218         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3219         (LayoutTestController::setTextDirection):
3220         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3221
3222 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
3223
3224         Reviewed by Ojan Vafai.
3225
3226         new-run-webkit-tests: 'images' links on results.html don't work
3227         https://bugs.webkit.org/show_bug.cgi?id=62194
3228
3229         Use relative path when generating images-diffs.html
3230
3231         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3232         Added _output_testname.
3233
3234 2011-06-10  Lucas Forschler  <lforschler@apple.com>
3235
3236         Reviewed by Stephanie Lewis.
3237
3238         Script to kill old processes on Mac.
3239         This matches the windows version.
3240         https://bugs.webkit.org/show_bug.cgi?id=62479  
3241         
3242         * BuildSlaveSupport/mac: Added.
3243         * BuildSlaveSupport/mac/kill-old-processes: Added.
3244
3245 2011-06-10  Adam Barth  <abarth@webkit.org>
3246
3247         Reviewed by James Robinson.
3248
3249         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
3250         https://bugs.webkit.org/show_bug.cgi?id=62489
3251
3252         * Scripts/webkitpy/tool/bot/sheriff.py:
3253         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3254
3255 2011-06-10  Tony Chang  <tony@chromium.org>
3256
3257         Reviewed by Ojan Vafai.
3258
3259         add a compile guard ENABLE(FLEXBOX)
3260         https://bugs.webkit.org/show_bug.cgi?id=62049
3261
3262         * Scripts/build-webkit:
3263
3264 2011-06-10  Mark Rowe  <mrowe@apple.com>
3265
3266         Reviewed by Dimitri Glazkov.
3267
3268         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
3269
3270         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
3271         header file.
3272
3273         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3274         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3275
3276 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
3277
3278         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
3279
3280         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3281         (handleEventX11):
3282         (NPP_GetValue):
3283         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3284         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
3285         (webkit_test_plugin_new_instance):
3286         (webkit_test_plugin_destroy_instance):
3287         (webkit_test_plugin_set_window):
3288         (executeScript):
3289         (webkit_test_plugin_new_stream):
3290         (webkit_test_plugin_destroy_stream):
3291         (webkit_test_plugin_stream_as_file):
3292         (webkit_test_plugin_write_ready):
3293         (webkit_test_plugin_write):
3294         (webkit_test_plugin_print):
3295         (keyEventToChar):
3296         (webkit_test_plugin_handle_event):
3297         (webkit_test_plugin_url_notify):
3298         (webkit_test_plugin_get_value):
3299         (webkit_test_plugin_set_value):
3300         (NP_GetMIMEDescription):
3301         (NP_Initialize):
3302         (NP_Shutdown):
3303         (NP_GetValue):
3304         * GNUmakefile.am:
3305
3306 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
3307
3308         Reviewed by Eric Seidel.
3309
3310         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
3311         https://bugs.webkit.org/show_bug.cgi?id=55603
3312
3313         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
3314         TextInputController support.
3315
3316         * DumpRenderTree/gtk/TextInputController.cpp:
3317         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
3318         of start and end. This matches the other ports. Do not use GLib style early returns.
3319         (hasMarkedTextCallback): Added.
3320         (markedRangeCallback): Added.
3321         (insertTextCallback): Cleanup as described above.
3322         (unmarkTextCallback): Cleanup as described above.
3323         (firstRectForCharacterRangeCallback): Cleanup as described above.
3324         (selectedRangeCallback): Cleanup as described above.
3325
3326 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
3327
3328         Reviewed by Tony Chang.
3329
3330         nrwt: support webaudio in chromium driver
3331         https://bugs.webkit.org/show_bug.cgi?id=62226
3332
3333         * Scripts/webkitpy/layout_tests/port/chromium.py:
3334
3335 2011-06-09  Dan Bernstein  <mitz@apple.com>
3336
3337         Reviewed by Anders Carlsson.
3338
3339         Added a test for Vector::reverse()
3340         https://bugs.webkit.org/show_bug.cgi?id=62393
3341
3342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3343         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
3344         (TestWebKitAPI::TEST):
3345         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3346
3347 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
3348
3349         Reviewed by Andreas Kling.
3350
3351         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
3352         https://bugs.webkit.org/show_bug.cgi?id=62385
3353
3354         Remove duplicate TestNetscapePlugIn implementation. Having two copies
3355         of this code makes keeping it in sync much more difficult. The files are
3356         almost identical and this change ports the X11 changes to main.cpp.
3357
3358         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3359         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
3360         (handleEventX11): Use the handler to properly convert the keycode. Do not print
3361         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
3362         it should not be in the results.
3363         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
3364         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
3365         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
3366         * GNUmakefile.am: Update source list.
3367
3368 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
3369
3370         Reviewed by Tony Chang.
3371
3372         Test plugin should support event logging on the windows port.
3373         https://bugs.webkit.org/show_bug.cgi?id=61721
3374
3375         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
3376         calls to mean the plugin handled the event.
3377
3378         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3379         (handleEventWin): Return 0 for each event on windows.
3380
3381 2011-06-09  Chang Shu  <cshu@webkit.org>
3382
3383         Reviewed by Andreas Kling.
3384
3385         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
3386         https://bugs.webkit.org/show_bug.cgi?id=62381
3387
3388         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
3389         QWKPagePrivate::isViewFocused() will check it later.
3390
3391         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3392         (WTR::PlatformWebView::PlatformWebView):
3393
3394 2011-06-09  Robert Hogan  <robert@webkit.org>
3395
3396         Reviewed by Andreas Kling.
3397
3398         Teach Qt about window.internals
3399         https://bugs.webkit.org/show_bug.cgi?id=61074
3400
3401         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3402         (WebCore::DumpRenderTree::initJSObjects):
3403
3404 2011-06-09  Eric Seidel  <eric@webkit.org>
3405
3406         Reviewed by Adam Barth.
3407
3408         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
3409         https://bugs.webkit.org/show_bug.cgi?id=62362
3410
3411         The mac bots are failing inspector tests.  We don't know why yet.
3412         So for now, turning run-webkit-tests off for the mac-ews.
3413
3414         Also noticed that due to the wrong variable name the cr-linux
3415         bots weren't running tests!
3416
3417         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3418
3419 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
3420
3421         Reviewed by Csaba Osztrogonac.
3422
3423         [Qt][WK2] Canvas tests make css2.1 ones failing
3424         https://bugs.webkit.org/show_bug.cgi?id=53427
3425
3426         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
3427         Since the Qt port should eventually go to QRawFont, this issue will be resolved
3428         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
3429         needed for the workaround.
3430
3431         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3432         (WTR::LayoutTestController::platformInitialize):
3433
3434 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
3435
3436         Reviewed by Chris Fleizach.
3437
3438         [GTK] Provide a way in DRT to check the platform name
3439         https://bugs.webkit.org/show_bug.cgi?id=56855
3440
3441         Patch for adding 'platformName' static property to DRT's
3442         LayoutController and provide platform specific implementations.
3443
3444         In principle, this feature will be only of interest for writing
3445         accessibility tests, so that's why it's only implemented in the
3446         Mac, Gtk and Win platforms.
3447
3448         * DumpRenderTree/LayoutTestController.h: New method platformName().
3449         * DumpRenderTree/LayoutTestController.cpp:
3450         (getPlatformNameCallback): New callback for 'platformName'.
3451         (LayoutTestController::staticValues): New static property.
3452
3453         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3454         (LayoutTestController::platformName): Implemented.
3455
3456         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3457         (LayoutTestController::platformName): Implemented.
3458
3459         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3460         (LayoutTestController::platformName): Implemented.
3461
3462 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
3463
3464         Reviewed by James Robinson.
3465
3466         Add mikelawther to committers.py
3467         https://bugs.webkit.org/show_bug.cgi?id=62354
3468
3469         * Scripts/webkitpy/common/config/committers.py:
3470
3471 2011-06-08  Kent Tamura  <tkent@chromium.org>
3472
3473         [Chromium] Fix a typo.
3474
3475         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3476         (WebThemeControlDRTWin::draw):
3477
3478 2011-06-08  Kent Tamura  <tkent@chromium.org>
3479
3480         Reviewed by Hajime Morita.
3481
3482         [Chromium] Support vertical sliders in Windows DRT
3483         https://bugs.webkit.org/show_bug.cgi?id=62352
3484
3485         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3486         (WebThemeControlDRTWin::draw):
3487           Paint VerticalSliderThumbType and VerticalSliderTrackType.
3488         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3489           Add VerticalSliderTrackType and VerticalSliderThumbType.
3490         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3491         (WebThemeEngineDRTWin::paintTrackbar):
3492           Convert Windows identifiers to the internal identifiers for vertical sliders.
3493
3494 2011-06-08  Ojan Vafai  <ojan@chromium.org>
3495
3496         Reviewed by Tony Chang.
3497
3498         add a short-flag for --experimental-fully-parallel
3499         https://bugs.webkit.org/show_bug.cgi?id=62321
3500
3501         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3502
3503 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3504
3505         Reviewed by Tony Chang.
3506
3507         new-run-webkit-tests: don't turn the tree red when there are new passes
3508         https://bugs.webkit.org/show_bug.cgi?id=62311
3509
3510         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
3511         to match commandComplete.
3512
3513         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3514
3515 2011-06-08  Tom Hudson  <tomhudson@google.com>
3516
3517         Reviewed by Mihai Parparita.
3518
3519         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
3520         https://bugs.webkit.org/show_bug.cgi?id=60964
3521
3522         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3523         Add 'Sort tests by metric' link.
3524         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3525         (disableSorting): Activate 'Sort tests by metric' link.
3526         (enableSorting): Deactivate 'Sort tests by metric' link.
3527         (selectDirectory): Call enableSorting()/disableSorting() depending
3528         on currently selected failure type, and sort tests if requested.
3529         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3530         New .disabled-control class for deactivated links.
3531
3532 2011-06-08  Tom Sepez  <tsepez@chromium.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         Add web permissions callbacks for mixed content blocking.
3537         https://bugs.webkit.org/show_bug.cgi?id=61946
3538
3539         * DumpRenderTree/chromium/LayoutTestController.cpp:
3540         (LayoutTestController::setAllowDisplayOfInsecureContent):
3541         (LayoutTestController::setAllowRunningOfInsecureContent):
3542         (LayoutTestController::overridePreference):
3543         * DumpRenderTree/chromium/WebPermissions.cpp:
3544         (WebPermissions::allowDisplayingInsecureContent):
3545         (WebPermissions::allowRunningInsecureContent):
3546         (WebPermissions::setDisplayingInsecureContentAllowed):
3547         (WebPermissions::setRunningInsecureContentAllowed):
3548         (WebPermissions::reset):
3549         * DumpRenderTree/chromium/WebPermissions.h:
3550
3551 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
3552
3553         Reviewed by Tony Chang.
3554
3555         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
3556         https://bugs.webkit.org/show_bug.cgi?id=62259
3557
3558         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3559
3560 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3561
3562         Reviewed by Tony Chang.
3563
3564         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
3565         https://bugs.webkit.org/show_bug.cgi?id=62303
3566
3567         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
3568
3569         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3570
3571 2011-06-08  Greg Simon  <gregsimon@chromium.org>
3572
3573         Reviewed by Dimitri Glazkov.
3574
3575         Control Indexeddb backends from LayoutTestController
3576         https://bugs.webkit.org/show_bug.cgi?id=61000
3577
3578         * DumpRenderTree/chromium/LayoutTestController.cpp:
3579         (LayoutTestController::LayoutTestController):
3580         (LayoutTestController::setOverrideIndexedDBBackingStore):
3581         (LayoutTestController::clearAllDatabases):
3582         * DumpRenderTree/chromium/LayoutTestController.h:
3583
3584 2011-06-08  Andreas Kling  <kling@webkit.org>
3585
3586         Add Pierre Rossi to contributors list for EZ-CC.
3587
3588         * Scripts/webkitpy/common/config/committers.py:
3589
3590 2011-06-08  Ilya Sherman  <isherman@chromium.org>
3591
3592         Reviewed by Andreas Kling.
3593
3594         Add Ilya Sherman to list of committers
3595         https://bugs.webkit.org/show_bug.cgi?id=62270
3596
3597         * Scripts/webkitpy/common/config/committers.py:
3598
3599 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
3600
3601         Reviewed by Tony Chang.
3602
3603         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
3604         https://bugs.webkit.org/show_bug.cgi?id=62178
3605
3606         Added commandComplete and evaluateCommand for NewRunWebKitTests class
3607         to parse new-run-webkit-tests' results.
3608
3609         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3610
3611 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
3612
3613         Reviewed by Eric Seidel.
3614
3615         webkitpy: add a popen() call to executive
3616         https://bugs.webkit.org/show_bug.cgi?id=62179
3617