check-webkit-style of the chromium test_expectations.txt file doesn't test all chromi...
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2
3         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
4         https://bugs.webkit.org/show_bug.cgi?id=76510
5
6         Reviewed by Adam Barth.
7
8         Unlike other style rules, if you get the syntax of the test_expectations.txt
9         file wrong, the layout tests won't run. Also, this check is simple and only
10         slows down committing if you actually modify one of the test_expectations.txt files.
11
12         * Scripts/webkitpy/style/checkers/test_expectations.py:
13         (TestExpectationsChecker.check_test_expectations):
14         (TestExpectationsChecker.check):
15         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
16         (TestExpectationsTestCase.test_check_covers_all_configurations):
17         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
18         (TestExpectationsTestCase):
19         (assert_lines_lint):
20
21 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
22
23         Build fix. Revert an unintentional change to WebKitDriver in r105443.
24
25         * Scripts/webkitpy/layout_tests/port/driver.py:
26         (DriverProxy.__init__):
27
28 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
29
30         remove the duplicated build rules from WebKit.gyp, Tools.gyp
31         https://bugs.webkit.org/show_bug.cgi?id=73384
32
33         Reviewed by Tony Chang.
34
35         This patch removes the no-longer-necessary conditional logic for
36         build_webkit_exes_from_webkit_gyp; we now always build the exes
37         from their own dedicated gyp files.
38
39         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
40
41 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
42
43         make-new-script-test should work with HTTP tests
44         https://bugs.webkit.org/show_bug.cgi?id=76603
45
46         Reviewed by Adam Roben.
47
48         * Scripts/make-new-script-test:
49         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
50         now also creates absolute paths for HTTP.
51
52 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
53
54         Some perf tests time out when ran by run-perf-tests
55         https://bugs.webkit.org/show_bug.cgi?id=76612
56
57         Reviewed by Dirk Pranke and Eric Seidel.
58
59         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
60         Otherwise some tests such as Parser/xml-parser.html will timeout.
61
62         --no-timeout option is currently supported by Chromium and Mac ports.
63
64         * Scripts/webkitpy/layout_tests/port/base.py:
65         (Port.to.create_driver):
66         * Scripts/webkitpy/layout_tests/port/chromium.py:
67         (ChromiumDriver.__init__):
68         (ChromiumDriver._wrapper_options):
69         * Scripts/webkitpy/layout_tests/port/driver.py:
70         (Driver.__init__):
71         (DriverProxy.__init__):
72         * Scripts/webkitpy/layout_tests/port/webkit.py:
73         (WebKitDriver.__init__):
74         (WebKitDriver.cmd_line):
75         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
76         (WebKitDriverTest.test_read_binary_block):
77         (WebKitDriverTest):
78         (WebKitDriverTest.test_no_timeout):
79         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
80         (get_tests_run.RecordingTestDriver.__init__):
81         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
82         (PerfTestsRunner._parse_args):
83         (PerfTestsRunner._run_tests_set):
84         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
85         (create_runner):
86
87 2012-01-19  Ben Wells  <benwells@chromium.org>
88
89         Add support for window.print to chromium DRT
90         https://bugs.webkit.org/show_bug.cgi?id=76479
91
92         When used in a test window.print goes into print mode and then
93         straight out again. This will allow the afterprint event to be
94         tested by having the afterprint event happen before the dump
95         happens.
96
97         Reviewed by Mihai Parparita.
98
99         * DumpRenderTree/chromium/WebViewHost.cpp:
100         (WebViewHost::printPage):
101         * DumpRenderTree/chromium/WebViewHost.h:
102
103 2012-01-18  Enrica Casucci  <enrica@apple.com>
104
105         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
106         https://bugs.webkit.org/show_bug.cgi?id=76588
107         <rdar://problem/9325183>
108
109         Added test.
110         
111         Reviewed by Dan Bernstein.
112
113         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
114         (TestWebKitAPI::TEST):
115
116 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
117
118         [Qt] Do full incremental builds until bots use update-webkit
119
120         Rubber-stamped by Simon Hausmann.
121
122         * Scripts/webkitdirs.pm:
123         (buildQMakeProjects):
124
125 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
126
127         Fix the Qt build
128
129         Unreviewed build fix.
130
131         * Scripts/webkitdirs.pm:
132         (buildQMakeProjects):
133
134 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
135
136         [Qt] Make build-webkit always do safe incremental builds after update-webkit
137
138         When building against Qt5 with GCC we would just run 'make' in the build dir,
139         and rely on the dependency files output by GCC (-MD) to handle dependency
140         tracking, but that fails for special-cases like adding a Q_OBJECT macro
141         to a header.
142
143         To guarantee that an incrmental build will work, we have to run 'make qmake',
144         which we now do on every build-webkit that's followed by a successful run
145         of update-webkit. The reasoning is that update-webkit can result in such
146         potential corner-cases being applied, and since we can't know for sure
147         unless we inspect the diff and account for all the corner cases we assume
148         the worst and always run 'make qmake'.
149
150         After a succesful run of build-webkit we proceed to do just 'make' for any
151         subsequent runs, since we assume that the developer knows what kind of
152         changes he/she is doing, and when a 'make qmake' is needed.
153
154         Reviewed by Simon Hausmann.
155
156         * Scripts/update-webkit:
157         * Scripts/webkitdirs.pm:
158         (determineCurrentSVNRevision):
159         (currentSVNRevision):
160         (buildQMakeProjects):
161         * qmake/mkspecs/features/default_post.prf:
162
163 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
164
165         run-perf-tests should support Skipped list
166         https://bugs.webkit.org/show_bug.cgi?id=76594
167
168         Reviewed by Adam Barth.
169
170         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
171
172         * Scripts/webkitpy/layout_tests/port/base.py:
173         (Port.perf_tests_dir):
174         (Port.skipped_perf_tests):
175         (Port.skips_perf_test):
176         (Port.relative_perf_test_filename):
177         * Scripts/webkitpy/layout_tests/port/test.py:
178         (TestPort.perf_tests_dir):
179         * Scripts/webkitpy/layout_tests/port/webkit.py:
180         (WebKitPort._expectations_from_skipped_files):
181         (WebKitPort):
182         (WebKitPort.skipped_layout_tests):
183         (WebKitPort.skipped_perf_tests):
184         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
185         (PerfTestsRunner._collect_tests):
186         (PerfTestsRunner.run):
187         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
188         (test_run_test_set_with_json_output):
189         (test_run_test_set_with_json_source):
190         (test_collect_tests_with_skipped_list):
191         (test_collect_tests_with_skipped_list.add_file):
192
193 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
194
195         Fix path to chromium_src_dir introduced in previous change.
196
197         Unreviewed, build fix.
198
199         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
200
201 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
202
203         Need infrastructure to test Content-Disposition filename encoding support
204         https://bugs.webkit.org/show_bug.cgi?id=76572
205         <rdar://problem/6421825>
206
207         Reviewed by Sam Weinig.
208
209         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
210
211         WebKitTestRunner does not have a policy delegate yet, bug 42546.
212
213         * DumpRenderTree/mac/PolicyDelegate.mm:
214         (dispositionTypeFromContentDispositionHeader):
215         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
216
217 2012-01-18  Ojan Vafai  <ojan@chromium.org>
218
219         Fix tests from http://trac.webkit.org/changeset/105332.
220
221         The code assumed that if you passed an options object with a configuration
222         attribute that it would have a valid value. A bunch of the testing mocks
223         do things like having a configuration value of None.
224
225         * Scripts/webkitpy/layout_tests/port/base.py:
226         (Port.__init__):
227
228 2012-01-18  Ojan Vafai  <ojan@chromium.org>
229
230         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
231         https://bugs.webkit.org/show_bug.cgi?id=76576
232
233         Reviewed by Adam Barth.
234
235         Avoid calling default_configuration in base.py. We don't need it for
236         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
237         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
238         from common.executive.
239
240         At some point someone should probably look into why that call is so slow
241         since it's on the critical path for run-webkit-tests and build-webkit startup.
242
243         * Scripts/webkitpy/layout_tests/port/base.py:
244         (Port.__init__):
245         * Scripts/webkitpy/style/checkers/test_expectations.py:
246         (TestExpectationsChecker._determine_port_from_exepectations_path):
247
248 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
249
250         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
251         https://bugs.webkit.org/show_bug.cgi?id=76505
252
253         Reviewed by Tony Chang.
254
255         Update chromium build script to use All.gyp instead of WebKit.gyp
256
257         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
258         * Scripts/webkitdirs.pm:
259
260 2012-01-18  Sam Weinig  <sam@webkit.org>
261
262         Don’t hardcode the path to ‘make‘.
263
264         Reviewed by Dan Bernstein.
265
266         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
267
268 2012-01-18  Joshua Bell  <jsbell@chromium.org>
269
270         Adding myself to committers.py
271         https://bugs.webkit.org/show_bug.cgi?id=76569
272
273         Unreviewed.
274
275         * Scripts/webkitpy/common/config/committers.py:
276
277 2012-01-18  Adam Barth  <abarth@webkit.org>
278
279         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
280         https://bugs.webkit.org/show_bug.cgi?id=76567
281
282         Reviewed by Eric Seidel.
283
284         Current the AppleMac port has slightly more failures than we allow on
285         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
286         which should hopefully let the mac-ews run to completion.  Once
287         AppleMac has fewer failures, we can lower the cap again.
288
289         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
290         (LayoutTestResultsReaderTest.test_layout_test_results):
291         * Scripts/webkitpy/tool/steps/runtests.py:
292         (RunTests):
293         * Scripts/webkitpy/tool/steps/steps_unittest.py:
294
295 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
296
297         Provide access to user's list of preferred languages
298         https://bugs.webkit.org/show_bug.cgi?id=76138
299
300         Reviewed by Alexey Proskuryakov.
301
302         * GNUmakefile.am: Add JSInternalsCustom.cpp.
303
304 2012-01-18  Adam Barth  <abarth@webkit.org>
305
306         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
307         configurations.
308
309         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
310         (ChromiumLinuxPort.__init__):
311
312 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
313
314         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
315         https://bugs.webkit.org/show_bug.cgi?id=73460
316
317         Reviewed by Chris Fleizach.
318
319         * DumpRenderTree/AccessibilityUIElement.h:
320         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
321         (AccessibilityUIElement::AccessibilityUIElement):
322         (AccessibilityUIElement::scrollToMakeVisibleCallback):
323         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
324         (AccessibilityUIElement::scrollToGlobalPointCallback):
325         * DumpRenderTree/chromium/AccessibilityUIElement.h:
326         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
327         (AccessibilityUIElement::scrollToMakeVisible):
328         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
329         (AccessibilityUIElement::scrollToGlobalPoint):
330         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
331         (AccessibilityUIElement::scrollToMakeVisible):
332         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
333         (AccessibilityUIElement::scrollToGlobalPoint):
334         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
335         (AccessibilityUIElement::scrollToMakeVisible):
336         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
337         (AccessibilityUIElement::scrollToGlobalPoint):
338
339 2012-01-17  Enrica Casucci  <enrica@apple.com>
340
341         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
342         https://bugs.webkit.org/show_bug.cgi?id=76490
343         <rdar://problem/9460733>
344
345         Added TestWebKitAPI test.
346         
347         Reviewed by Dan Bernstein.
348
349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
350         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
351         changeAttributes to the WebView.
352         
353 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
354
355         [Qt] Consolidate layout test crash logging
356         https://bugs.webkit.org/show_bug.cgi?id=75088
357
358         Reviewed by Simon Hausmann.
359
360         Move backtrace generating logic into WTFReportBacktrace
361         and add a way to deinstall signal handlers if we know
362         that we have already printed the backtrace.
363
364         * DumpRenderTree/qt/main.cpp:
365         (crashHandler):
366         (setupSignalHandlers):
367         (WTFCrashHook):
368         (main):
369         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
370         (WTR::crashHandler):
371         (WTR::setupSignalHandlers):
372         (WTR::crashHook):
373         (WTR::InjectedBundle::platformInitialize):
374
375 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
376
377         Unreviewed build fix after r105256.
378
379         There was a cyclic dependency between self._port and self._host assigments.
380
381         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
382         (PerfTestsRunner.__init__):
383
384 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
385
386         Add new watchlist rule for the Qt build system
387
388         Reviewed by Simon Hausmann.
389
390         * Scripts/webkitpy/common/config/watchlist:
391
392 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
393
394         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
395
396         Reviewed by Simon Hausmann.
397
398         * Tools.pro:
399
400 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
401
402         [Qt] Allow building only a subset of the WebKit sub-projects
403
404         Fixes build-jsc, broken in r104825.
405
406         We no longer need the intermediate buildQMakeQtProject(), as we're the
407         only port using qmake, and buildQMakeProject is now highly Qt specific.
408
409         <http://webkit.org/b/76179>
410
411         Reviewed by Simon Hausmann.
412
413         * Scripts/build-jsc:
414         * Scripts/build-webkit:
415         * Scripts/webkitdirs.pm:
416         (buildQMakeProjects):
417
418 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
419
420         run-perf-tests should generate a json file that summaries the result
421         https://bugs.webkit.org/show_bug.cgi?id=76504
422
423         Reviewed by Adam Barth.
424
425         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
426         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
427         another json file to be merged into the generated json file.
428
429         Also fixed a bug that --build wasn't set by default.
430
431         * Scripts/webkitpy/layout_tests/port/test.py:
432         (TestPort.webkit_base):
433         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
434         (PerfTestsRunner.__init__):
435         (PerfTestsRunner):
436         (PerfTestsRunner._parse_args):
437         (PerfTestsRunner.run):
438         (PerfTestsRunner._generate_json_if_specified):
439         (PerfTestsRunner._process_chromium_style_test_result):
440         (PerfTestsRunner._process_parser_test_result):
441         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
442         (MainTest):
443         (create_runner):
444         (test_run_test_set):
445         (test_run_test_set_for_parser_tests):
446         (test_run_test_set_with_summary_json):
447         (test_collect_tests):
448         (test_parse_args):
449
450 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
451
452         Unreviewed, rolling out r105244.
453         http://trac.webkit.org/changeset/105244
454         https://bugs.webkit.org/show_bug.cgi?id=76518
455
456         broke Chromium Mac (Requested by rolandsteiner on #webkit).
457
458         * DumpRenderTree/AccessibilityUIElement.h:
459         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
460         (AccessibilityUIElement::AccessibilityUIElement):
461         * DumpRenderTree/chromium/AccessibilityUIElement.h:
462         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
463         (AccessibilityUIElement::removeSelection):
464         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
465         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
466         (AccessibilityUIElement::removeSelection):
467
468 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
469
470         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
471         https://bugs.webkit.org/show_bug.cgi?id=73460
472
473         Reviewed by Chris Fleizach.
474
475         * DumpRenderTree/AccessibilityUIElement.h:
476         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
477         (AccessibilityUIElement::AccessibilityUIElement):
478         (AccessibilityUIElement::scrollToMakeVisibleCallback):
479         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
480         (AccessibilityUIElement::scrollToGlobalPointCallback):
481         * DumpRenderTree/chromium/AccessibilityUIElement.h:
482         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
483         (AccessibilityUIElement::scrollToMakeVisible):
484         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
485         (AccessibilityUIElement::scrollToGlobalPoint):
486         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
487         (AccessibilityUIElement::scrollToMakeVisible):
488         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
489         (AccessibilityUIElement::scrollToGlobalPoint):
490         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
491         (AccessibilityUIElement::scrollToMakeVisible):
492         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
493         (AccessibilityUIElement::scrollToGlobalPoint):
494
495 2012-01-17  Adam Barth  <abarth@webkit.org>
496
497         Enable tests on the mac-ews
498         https://bugs.webkit.org/show_bug.cgi?id=76502
499
500         Reviewed by Simon Fraser.
501
502         Apple now has five machines running the mac-ews.  Lucas Forschler has
503         asked that we try enabling tests to see if we have enough bandwidth.
504
505         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
506         (MacEWS):
507
508 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
509
510         Add a check-webkit-style exception for GDBInterface.cpp
511         https://bugs.webkit.org/show_bug.cgi?id=76187
512
513         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
514         that it does not fail the style check.
515
516         Reviewed by Martin Robinson.
517
518         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
519         readability/naming tests on
520         Source/JavaScriptCore/jit/GDBInterface.cpp.
521         * Scripts/webkitpy/style/checker_unittest.py:
522         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
523         the above exception.
524
525 2012-01-17  Hajime Morrita  <morrita@chromium.org>
526
527         https://bugs.webkit.org/show_bug.cgi?id=76245
528         [Mac][DRT] should allow query string for the file URL.
529
530         Reviewed by Tony Chang.
531
532         Taught DRT about file:// as a url instead of a file path.
533         We are now able to use a path file:///foo/bar.html?baz as a url
534         with which DRT opens "/foo/bar.html" with "baz" as a query string.
535
536         * DumpRenderTree/mac/DumpRenderTree.mm:
537         (runTest):
538
539 2012-01-17  Ojan Vafai  <ojan@chromium.org>
540
541         Check style on test_expectations.txt files before commit
542         https://bugs.webkit.org/show_bug.cgi?id=76484
543
544         Reviewed by Adam Barth.
545
546         Unlike other style rules, if you get the syntax of the test_expectations.txt
547         file wrong, the layout tests won't run. Also, this check is simple and only
548         slows down committing if you actually modify one of the test_expectations.txt files.
549
550         * Scripts/webkitpy/tool/steps/commit.py:
551         (Commit._check_test_expectations):
552         (Commit.run):
553         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
554         (CommitTest):
555         (CommitTest.test_check_test_expectations):
556
557 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
558
559         [Qt] Debug build fails with debug qt5
560         https://bugs.webkit.org/show_bug.cgi?id=76463
561
562         Reviewed by Simon Hausmann.
563
564         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
565
566         * QtTestBrowser/cookiejar.h:
567
568 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
569
570         webkitpy: fix json import on linux
571         https://bugs.webkit.org/show_bug.cgi?id=76481
572
573         Reviewed by Adam Barth.
574
575         For some reason, the version of simplejson autoinstalled on my linux
576         box seems to be broken. We should really only be using
577         simplejson if json isn't available anyway, so this change looks
578         for json first.
579
580         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
581         (JSONGeneratorTest.test_test_timings_trie):
582
583 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
584
585         Fix failures in test-webkitpy caused by r105177.
586
587         Unreviewed, build fix.
588
589         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
590         (ChromiumLinuxPort._determine_driver_path_statically):
591         (ChromiumLinuxPort._static_build_path):
592
593 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
594
595         webkitpy: make PortFactory.get() be fully data-driven
596         https://bugs.webkit.org/show_bug.cgi?id=76360
597
598         Reviewed by Eric Seidel.
599
600         Refactor PortFactory.get() to be fully data-driven.
601
602         * Scripts/webkitpy/layout_tests/port/factory.py:
603         (PortFactory):
604         (PortFactory._default_port):
605         (PortFactory.get):
606         (PortFactory.get.in):
607         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
608         (FactoryTest.assert_port):
609
610 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
611
612         webkitpy: add determine_full_port_name(), clean up port.__init__()
613         https://bugs.webkit.org/show_bug.cgi?id=76357
614
615         Reviewed by Adam Barth.
616
617         Each Port class is now required to implement a 'port_name' field
618         that will match the start of all ports constructed by this class and
619         a 'determine_full_port_name' field that will make the port
620         fully-qualified.
621
622         * Scripts/webkitpy/layout_tests/port/apple.py:
623         (ApplePort.__init__):
624         * Scripts/webkitpy/layout_tests/port/base.py:
625         (Port):
626         (Port.determine_port_name):
627         (Port.__init__):
628         * Scripts/webkitpy/layout_tests/port/chromium.py:
629         (ChromiumPort.for):
630         (ChromiumPort.__init__):
631         (ChromiumPort):
632         (ChromiumPort._chromium_base_dir):
633         (ChromiumPort.path_from_chromium_base):
634         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
635         (ChromiumGpuLinuxPort):
636         (ChromiumGpuLinuxPort.__init__):
637         (ChromiumGpuMacPort):
638         (ChromiumGpuMacPort.__init__):
639         (ChromiumGpuWinPort):
640         (ChromiumGpuWinPort.__init__):
641         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
642         (ChromiumLinuxPort):
643         (ChromiumLinuxPort.determine_port_name):
644         (ChromiumLinuxPort.__init__):
645         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
646         (ChromiumMacPort):
647         (ChromiumMacPort.determine_port_name):
648         (ChromiumMacPort.__init__):
649         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
650         (ChromiumWinPort):
651         (ChromiumWinPort.determine_port_name):
652         (ChromiumWinPort.__init__):
653         * Scripts/webkitpy/layout_tests/port/dryrun.py:
654         (DryRunPort):
655         (DryRunPort.determine_port_name):
656         (DryRunPort.__init__):
657         * Scripts/webkitpy/layout_tests/port/efl.py:
658         (EflPort):
659         * Scripts/webkitpy/layout_tests/port/factory.py:
660         (PortFactory):
661         (PortFactory._default_port):
662         (PortFactory.get):
663         (PortFactory.get.in):
664         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
665         (FactoryTest.assert_port):
666         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
667         (GoogleChromeLinux32Port):
668         (GoogleChromeLinux32Port.determine_port_name):
669         (GoogleChromeLinux64Port):
670         (GoogleChromeLinux64Port.determine_port_name):
671         (GoogleChromeMacPort):
672         (GoogleChromeMacPort.determine_port_name):
673         (GoogleChromeWinPort):
674         (GoogleChromeWinPort.determine_port_name):
675         * Scripts/webkitpy/layout_tests/port/gtk.py:
676         (GtkPort):
677         * Scripts/webkitpy/layout_tests/port/mac.py:
678         (MacPort):
679         (MacPort.determine_port_name):
680         (MacPort.__init__):
681         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
682         (test_versions):
683         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
684         (MockDRTPort):
685         (MockDRTPort.determine_port_name):
686         (MockDRTPort.__init__):
687         (MockDRT):
688         (MockDRT.determine_port_name):
689         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
690         (PortTestCase.make_port):
691         * Scripts/webkitpy/layout_tests/port/qt.py:
692         (QtPort):
693         (QtPort.determine_port_name):
694         (QtPort.__init__):
695         * Scripts/webkitpy/layout_tests/port/test.py:
696         (TestPort):
697         (TestPort.determine_port_name):
698         (TestPort.__init__):
699         * Scripts/webkitpy/layout_tests/port/webkit.py:
700         (WebKitPort.__init__):
701         * Scripts/webkitpy/layout_tests/port/win.py:
702         (WinPort):
703         (WinPort.determine_port_name):
704         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
705         (get_test_baselines.AllPlatformsPort.__init__):
706         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
707         (get_test_config.TestMacPort):
708         (get_test_config):
709
710 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
711
712         webkitpy: clean up port code in preparation for static port names
713         https://bugs.webkit.org/show_bug.cgi?id=76356
714
715         Reviewed by Adam Barth.
716
717         To fix bug 76215 and be able to determine appropriate port names
718         in webkitpy without actually constructing Port objects, we need
719         to shuffle some logic in the chromium ports to be able to figure
720         out whether we built DRT in 32 or 64-bit mode.
721
722         * Scripts/webkitpy/layout_tests/port/chromium.py:
723         (ChromiumPort):
724         (ChromiumPort._chromium_base_dir):
725         (ChromiumPort.__init__):
726         (ChromiumPort.path_from_chromium_base):
727         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
728         (ChromiumLinuxPort):
729         (ChromiumLinuxPort._determine_driver_path_statically):
730         (ChromiumLinuxPort._static_build_path):
731         (ChromiumLinuxPort._determine_architecture):
732         (ChromiumLinuxPort.__init__):
733         (ChromiumLinuxPort._build_path):
734
735 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
736
737         Do not remove pixel failures for ref tests.
738         https://bugs.webkit.org/show_bug.cgi?id=76243
739
740         Reviewed by Tony Chang.
741
742         'NRWT --no-pixel-tests' complains when reftests are expected to
743         be image mismatch.
744
745         * Scripts/webkitpy/layout_tests/controllers/manager.py:
746         (Manager._update_summary_with_result):
747         * Scripts/webkitpy/layout_tests/models/test_failures.py:
748         (is_reftest_failure):
749         (determine_result_type):
750
751 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
752
753         REGRESSION(r81225): ORWT should ignore reftests
754         https://bugs.webkit.org/show_bug.cgi?id=67936
755
756         Reviewed by Csaba Osztrogonác.
757
758         * Scripts/old-run-webkit-tests:
759         (isUsedInReftest): $filename should be the first parameter
760         (findTestsToRun): run test if it isn't reftest
761
762 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
763
764         Unreviewed. Fix python unit test I broke with r105142
765
766         * Scripts/webkitpy/common/config/ports_unittest.py:
767         (WebKitPortTest.test_gtk_port):
768
769 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
770
771         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
772
773         Qt 5 no longer has that flag.
774
775         Reviewed by Simon Hausmann.
776
777         * MiniBrowser/qt/MiniBrowserApplication.cpp:
778         (MiniBrowserApplication::notify):
779
780 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
781
782         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
783         https://bugs.webkit.org/show_bug.cgi?id=75857
784
785         Reviewed by Adam Barth.
786
787         * Scripts/webkitdirs.pm:
788         (buildAutotoolsProject): move cleaning the build to happen early,
789         and handle --update-gtk right after that
790         * Scripts/webkitpy/common/config/ports.py:
791         (GtkPort.build_webkit_command): pass --update-gtk as an option to
792         build-webkit, so that it is used in the EWS
793
794 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
795
796         [Qt] Don't add _debug postfix to targets when building debug only
797
798         Reviewed by Simon Hausmann.
799
800         * qmake/mkspecs/features/default_post.prf:
801         * qmake/mkspecs/features/functions.prf:
802
803 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
804
805         [Qt] Add more files to project-files for easier navigation in Qt Creator
806
807         Reviewed by Simon Hausmann.
808
809         * Tools.pro:
810         * qmake/config.tests/README: Added.
811
812 2012-01-17  Philippe Normand  <pnormand@igalia.com>
813
814         [GTK] fast/dom/constructed-objects-prototypes.html fails
815         https://bugs.webkit.org/show_bug.cgi?id=75432
816
817         Reviewed by Martin Robinson.
818
819         * Scripts/build-webkit: Enable video-track in GTK.
820
821 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
822
823         Add toyoshim as a committer.
824         https://bugs.webkit.org/show_bug.cgi?id=76390
825
826         Reviewed by Hajime Morita.
827
828         * Scripts/webkitpy/common/config/committers.py:
829
830 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
831
832         [WinCairo] Build fix after r104155. Several debug targets were not
833         properly including the '*Common' property sheets.
834
835         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
836         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
837         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
838         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
839         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
840
841 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
842
843         REGRESSION(r105072): It broke committers_unittest.py
844         https://bugs.webkit.org/show_bug.cgi?id=76396
845
846         Reviewed by Adam Barth.
847
848         * Scripts/webkitpy/common/config/committers_unittest.py:
849         (CommittersTest._assert_fuzz_match): It should handle more names.
850         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
851
852 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
853
854         [GTK] Include gtk+3 in the jhbuild modules
855         https://bugs.webkit.org/show_bug.cgi?id=76284
856
857         Reviewed by Philippe Normand.
858
859         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
860
861 2012-01-16  Dan Winship  <danw@gnome.org>
862
863         Add myself as a committer
864
865         Unreviewed
866
867         * Scripts/webkitpy/common/config/committers.py:
868
869 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
870
871         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
872
873         Some recent versions of a few Linux distributions have started passing
874         --as-needed and --no-copy-dt-needed-entries by default to the linker,
875         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
876         needed a few symbols from libjavascriptcore_efl.so.
877
878         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
879         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
880         libraries are searched in the right order by the linker.
881
882 2012-01-16  Philippe Normand  <pnormand@igalia.com>
883
884         [GTK] set audio resources path in NRTW
885         https://bugs.webkit.org/show_bug.cgi?id=76380
886
887         Reviewed by Martin Robinson.
888
889         * Scripts/webkitpy/layout_tests/port/gtk.py:
890         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
891         the uninstalled audio resources are used during webaudio tests.
892
893 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
894
895         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
896         https://bugs.webkit.org/show_bug.cgi?id=76369
897
898         Reviewed by Xan Lopez.
899
900         If there's an installed version of webkit and there are new
901         symbols in the build tree, gtkdoc-scanobj fails due to undefined
902         references, because the env ldflags are given before the local
903         ones.
904
905         * gtk/gtkdoc.py:
906         (GTKDoc._run_gtkdoc_scangobj):
907
908 2012-01-15  Pablo Flouret  <pablof@motorola.com>
909
910         Fix compilation errors on build-webkit --debug --no-video on mac.
911         https://bugs.webkit.org/show_bug.cgi?id=75867
912
913         Reviewed by Philippe Normand.
914
915         Add --[no-]video-track to build-webkit, since video track feature
916         depends on video.
917
918         * Scripts/build-webkit:
919
920 2012-01-14  James Robinson  <jamesr@chromium.org>
921
922         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
923         https://bugs.webkit.org/show_bug.cgi?id=76313
924
925         Reviewed by Adam Barth.
926
927         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
928
929         * Scripts/run-chromium-webkit-unit-tests:
930
931 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
932
933         Unreviewed, rolling out r105017.
934         http://trac.webkit.org/changeset/105017
935         https://bugs.webkit.org/show_bug.cgi?id=76333
936
937         broke the build (Requested by philn-tp on #webkit).
938
939         * gtk/jhbuild.modules:
940
941 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
942
943         [GTK] Include gtk+3 in the jhbuild modules
944         https://bugs.webkit.org/show_bug.cgi?id=76284
945
946         Reviewed by Philippe Normand.
947
948         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
949
950 2012-01-13  Adam Barth  <abarth@webkit.org>
951
952         Remove --dry-run support from webkit-patch
953         https://bugs.webkit.org/show_bug.cgi?id=76300
954
955         Reviewed by Dirk Pranke.
956
957         This is the rest of the patch from Bug 76300.  I landed it separtely
958         because main.py had some stray conflict markers that I needed to clean
959         up first.
960
961         * Scripts/webkitpy/test/main.py:
962         (Tester.parse_args):
963         (Tester._run_tests):
964
965 2012-01-13  Adam Barth  <abarth@webkit.org>
966
967         test-webkitpy does not run
968         https://bugs.webkit.org/show_bug.cgi?id=76318
969
970         Unreviewed.
971
972         Looks like some conflict markers got left in the file.
973
974         * Scripts/webkitpy/test/main.py:
975         (Tester.run):
976
977 2012-01-13  Adam Barth  <abarth@webkit.org>
978
979         Remove --dry-run support from webkit-patch
980         https://bugs.webkit.org/show_bug.cgi?id=76300
981
982         Reviewed by Dirk Pranke.
983
984         We don't use this functionality for anything, and it doesn't really
985         work.  Someone in #webkit tried using it and and got sad/confused.  We
986         should just remove it.
987
988         * Scripts/webkitpy/common/checkout/scm/git.py:
989         (Git.push_local_commits_to_server):
990         * Scripts/webkitpy/common/checkout/scm/scm.py:
991         (SCM.__init__):
992         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
993         (_shared_test_commit_with_message):
994         (GitSVNTest.test_commit_text_parsing):
995         * Scripts/webkitpy/common/checkout/scm/svn.py:
996         (SVN.commit_with_message):
997         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
998         (Bugzilla.__init__):
999         (Bugzilla.quips):
1000         (Bugzilla.authenticate):
1001         (Bugzilla.add_attachment_to_bug):
1002         (Bugzilla.add_patch_to_bug):
1003         (Bugzilla.create_bug):
1004         (Bugzilla.clear_attachment_flags):
1005         (Bugzilla.set_flag_on_attachment):
1006         (Bugzilla.obsolete_attachment):
1007         (Bugzilla.add_cc_to_bug):
1008         (Bugzilla.post_comment_to_bug):
1009         (Bugzilla.close_bug_as_fixed):
1010         (Bugzilla.reassign_bug):
1011         (reopen_bug):
1012         * Scripts/webkitpy/test/main.py:
1013         (Tester.parse_args):
1014         (Tester.run_tests):
1015
1016 2012-01-13  David Levin  <levin@chromium.org>
1017
1018         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1019         https://bugs.webkit.org/show_bug.cgi?id=76227
1020
1021         Reviewed by Dirk Pranke.
1022
1023         * Scripts/webkitpy/style/checkers/cpp.py:
1024         (check_for_leaky_patterns): The new check.
1025         (process_line): Added a call to the new check.
1026         (CppChecker): Added the new error type.
1027         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1028         (CppStyleTestBase):
1029         (CppStyleTestBase.perform_leaky_pattern_check):
1030         The check for only leaky pattern errors.
1031         (LeakyPatternTest): Test cases.
1032
1033 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1034
1035         test-webkitpy: clean up handling of test directories, QueueStatusServer
1036         https://bugs.webkit.org/show_bug.cgi?id=76238
1037
1038         Reviewed by Adam Barth.
1039
1040         This patch cleans up a bunch of hacks related to how we find all
1041         of the python unit tests and set up the sys.path variable in
1042         test-webkitpy.
1043
1044         This patch changes how test-webkitpy works slightly in that we
1045         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1046         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1047         This greatly simplifies the mapping of paths to module names and
1048         appears to have no significant performance impact or other drawbacks.
1049
1050         There are other ways that we could remove all of the hacks and
1051         still have a more flexible mapping of paths to module names, but
1052         the ones I've thought of so far add a decent amount of complexity to
1053         the implementation and don't seem to buy us much.
1054         
1055         * QueueStatusServer/__init__.py:
1056         * Scripts/test-webkitpy:
1057         * Scripts/webkitpy/test/main.py:
1058         (Tester._modules_from_paths):
1059         (Tester._is_module):
1060
1061 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1062
1063         test-webkitpy: should support classes and individual test names as well as modules
1064         https://bugs.webkit.org/show_bug.cgi?id=76233
1065
1066         Reviewed by Adam Barth.
1067
1068         The default unittest.main() supports a list of individual
1069         TestCase classes or individual tests as well as modules. This
1070         change adds support for the same to test-webkitpy, so now you
1071         can say
1072
1073           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1074
1075         and
1076
1077           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1078
1079         in addition to
1080
1081           % test-wekbitpy webkitpy.test.cat_unittest
1082
1083         * Scripts/test-webkitpy:
1084         * Scripts/webkitpy/test/cat_unittest.py:
1085         * Scripts/webkitpy/test/main.py:
1086         (Tester.parse_args):
1087         (Tester.run):
1088         (Tester):
1089         (Tester._find_modules):
1090         (Tester._exclude):
1091         (Tester._run_tests):
1092         (Tester._is_module):
1093         (Tester._log_exception):
1094
1095 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1096
1097         test-webkitpy: add basic code coverage support
1098         https://bugs.webkit.org/show_bug.cgi?id=76201
1099
1100         Reviewed by Adam Barth.
1101
1102         This test adds basic code coverage support to test-webkitpy; if
1103         you pass the -c flag, we will generate a new coverage file. We
1104         can start simply with this and add more features as necessary.
1105
1106         This patch requires coverage to be already installed on the
1107         machine. I am not auto-installing this for now.
1108
1109         * Scripts/webkitpy/test/main.py:
1110         (Tester.parse_args):
1111         (Tester.run_tests):
1112
1113 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1114
1115         StatusBubbleTest.test_build_bubble is failing
1116         https://bugs.webkit.org/show_bug.cgi?id=76222
1117
1118         Reviewed by Adam Barth.
1119
1120         * QueueStatusServer/handlers/statusbubble_unittest.py:
1121         (StatusBubbleTest.test_build_bubble):
1122
1123 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1124
1125         nrwt should use multiple http shards
1126         https://bugs.webkit.org/show_bug.cgi?id=75958
1127
1128         Add --max-locked-shards option to the nrwt for manual set
1129         the maximum number of the locked shards
1130
1131         Reviewed by Dirk Pranke.
1132
1133         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1134         (Manager._max_locked_shards):
1135         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1136         (ShardingTests.get_shards):
1137         (ShardingTests.test_multiple_locked_shards):
1138         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1139         (parse_args):
1140
1141 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1142
1143         prepare-ChangeLog: Look for a text editor in a few more variables.
1144         https://bugs.webkit.org/show_bug.cgi?id=76289
1145
1146         Reviewed by Ryosuke Niwa.
1147
1148         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1149         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1150         to the OS X-specific open(1) command.
1151
1152         As there does not seem to be a common way of looking for a text editor
1153         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1154         $EDITOR (set much more often than the other variables in Unix systems)
1155         before falling back to open(1).
1156
1157         * Scripts/prepare-ChangeLog:
1158         (openChangeLogs):
1159
1160 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1161
1162         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1163         https://bugs.webkit.org/show_bug.cgi?id=76269
1164
1165         Reviewed by Martin Robinson.
1166
1167         * gtk/gtkdoc.py:
1168         (GTKDoc._run_gtkdoc_scangobj):
1169
1170 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1171
1172         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1173         https://bugs.webkit.org/show_bug.cgi?id=76247
1174
1175         Reviewed by Kenneth Rohde Christiansen.
1176
1177         * WebKitTestRunner/TestController.cpp:
1178         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1179
1180 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1181
1182         [Mac][DRT] Should support --no-timeout
1183         https://bugs.webkit.org/show_bug.cgi?id=76242
1184
1185         Reviewed by Darin Adler.
1186
1187         * DumpRenderTree/mac/DumpRenderTree.mm:
1188         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1189         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1190         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1191         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1193         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1194
1195 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1196
1197         Mitigate scrollbar differences when running pixel tests
1198         https://bugs.webkit.org/show_bug.cgi?id=67217
1199
1200         Reviewed by Dan Bernstein.
1201         
1202         Enable mock scrollbars by default for tests.
1203
1204         * DumpRenderTree/mac/DumpRenderTree.mm:
1205         (resetDefaultsToConsistentValues):
1206         * WebKitTestRunner/TestController.cpp:
1207         (WTR::TestController::resetStateToConsistentValues):
1208
1209 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1210
1211         Need a script to run tests in PerformanceTests
1212         https://bugs.webkit.org/show_bug.cgi?id=76132
1213
1214         Reviewed by Adam Barth.
1215
1216         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1217         Unfortunately, there isn't an easy way of telling which test uses which format
1218         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1219
1220         All test outputs are re-formatted to match Chromium perf-bot style.
1221
1222         * Scripts/run-inspector-perf-tests.py:
1223         * Scripts/run-perf-tests: Added.
1224         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1225         (PerfTestsRunner):
1226         (PerfTestsRunner.__init__):
1227         (PerfTestsRunner._collect_tests):
1228         (PerfTestsRunner.run):
1229         (PerfTestsRunner._print_status):
1230         (PerfTestsRunner._run_tests_set):
1231         (PerfTestsRunner._process_chromium_style_test_result):
1232         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1233         (PerfTestsRunner._process_parser_test_result):
1234         (PerfTestsRunner._run_single_test):
1235         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1236         (MainTest.TestDriver.run_test):
1237         (create_runner):
1238         (run_test):
1239         (test_run_test_set):
1240         (test_run_test_set_for_parser_tests):
1241         (test_collect_tests):
1242
1243 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1244
1245         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1246         https://bugs.webkit.org/show_bug.cgi?id=76123
1247
1248         Reviewed by Adam Barth.
1249
1250         This change updates the unit tests to be more consistent in how
1251         ports are created, in preparation for making port_name a
1252         mandatory parameter to the constructor and removing any version
1253         interpretation from it.
1254
1255         There should be no functional changes in this patch, but some
1256         tests that are no longer relevant have been removed or reworked.
1257
1258         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1259         (PortTest.test_get_option__default):
1260         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1261         (ChromiumLinuxPortTest):
1262         (ChromiumLinuxPortTest.assert_architecture):
1263         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1264         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1265         (ChromiumMacPortTest):
1266         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1267         (ChromiumPortTest):
1268         (ChromiumPortTest.test_all_test_configurations):
1269         (ChromiumPortTest.TestMacPort.__init__):
1270         (ChromiumPortTest.TestLinuxPort.__init__):
1271         (ChromiumPortTest.TestWinPort.__init__):
1272         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1273         (ChromiumWinTest):
1274         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1275         (EflPortTest):
1276         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1277         (GtkPortTest):
1278         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1279         (MacTest):
1280         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1281         (MockDRTPortTest):
1282         (MockDRTPortTest.make_port):
1283         * Scripts/webkitpy/layout_tests/port/qt.py:
1284         (QtPort._port_flag_for_scripts):
1285         (QtPort.__init__):
1286         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1287         (QtPortTest):
1288         (QtPortTest._assert_search_path):
1289         (QtPortTest.test_baseline_search_path):
1290         (QtPortTest.test_operating_system):
1291         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1292         (WebKitPortTest):
1293         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1294         (WinPortTest):
1295         (WinPortTest._assert_search_path):
1296         (WinPortTest.test_baseline_search_path):
1297         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1298         (get_test_config.TestMacPort.__init__):
1299
1300 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1301
1302         test-webkitpy: clean up logging and provide a real --help message
1303         https://bugs.webkit.org/show_bug.cgi?id=76142
1304
1305         Reviewed by Adam Barth.
1306
1307         This test is mostly more refactoring - it calls objects in
1308         unittest directly instead of routing through unittest.main() --
1309         in order to gain more control over the logging and to provide a
1310         correct --help message. This will also give us a better
1311         foundation for adding more feautures down the road.
1312
1313         This patch adds different levels of logging controlled by the
1314         '-s', '-q', and '-v' options (see --help for details), and
1315         removes the --verbose-logging option.
1316
1317         * Scripts/test-webkitpy:
1318         * Scripts/webkitpy/test/main.py:
1319         (Tester):
1320         (Tester.clean_packages):
1321         (Tester.__init__):
1322         (Tester.parse_args):
1323         (Tester.configure):
1324         (Tester._configure_logging):
1325         (Tester.find_modules):
1326         (Tester._exclude):
1327         (Tester._modules_from_paths):
1328         (Tester.run_tests):
1329
1330 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1331
1332         Make the new WTF module build on Qt
1333         https://bugs.webkit.org/show_bug.cgi?id=76163
1334
1335         Reviewed by Tor Arne Vestbø.
1336
1337         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1338
1339 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1340
1341         Unreviewed, mac DumpRenderTree fix.
1342
1343         * DumpRenderTree/mac/UIDelegate.mm:
1344         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1345
1346 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1347
1348         WebKitTestRunner should not print console message line number when it is equal to zero.
1349         https://bugs.webkit.org/show_bug.cgi?id=76167
1350
1351         Reviewed by Csaba Osztrogonác.
1352
1353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1354         (WTR::InjectedBundlePage::willAddMessageToConsole):
1355
1356 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1357
1358         Make default console messages line numbers consistent.
1359         https://bugs.webkit.org/show_bug.cgi?id=74075
1360
1361         Reviewed by Pavel Feldman.
1362
1363         Unset line numbers are not printed to console now.
1364         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1365
1366         * DumpRenderTree/chromium/WebViewHost.cpp:
1367         (WebViewHost::didAddMessageToConsole):
1368         * DumpRenderTree/efl/CMakeLists.txt:
1369         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1370         (onConsoleMessage):
1371         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1372         (webViewConsoleMessage):
1373         * DumpRenderTree/mac/UIDelegate.mm:
1374         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1375         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1376         (WebCore::WebPage::javaScriptConsoleMessage):
1377         * DumpRenderTree/win/UIDelegate.cpp:
1378         (UIDelegate::webViewAddMessageToConsole):
1379         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1380         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1381
1382 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1383
1384         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1385         https://bugs.webkit.org/show_bug.cgi?id=76021
1386
1387         Reviewed by Eric Seidel.
1388
1389         I plan to add more functionality to test-webkitpy, but it is
1390         difficult to hack on now; this patch is the first of two that
1391         brings test-webkitpy more inline with current coding style by
1392         pushing more logic into the webkitpy.test.main.Tester class (so
1393         that it will be testable itself).
1394         
1395         There should be no functional changes in this patch.
1396
1397         * Scripts/test-webkitpy:
1398         (_path_from_webkit_root):
1399         * Scripts/webkitpy/test/main.py:
1400         (Tester):
1401         (Tester.init):
1402         (Tester.configure_logging):
1403         (Tester.configure_logging.filter):
1404         (Tester.clean_packages):
1405         (Tester.run_tests):
1406
1407 2012-01-11  Wei Jia  <wjia@chromium.org>
1408
1409         implement layout tests for <video> with media stream
1410         https://bugs.webkit.org/show_bug.cgi?id=74882
1411
1412         Reviewed by Kent Tamura.
1413
1414         * DumpRenderTree/DumpRenderTree.gypi:
1415         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1416         (WebKit::WebUserMediaClientMock::create):
1417         (WebKit::WebUserMediaClientMock::IsMockStream):
1418         (WebKit::WebUserMediaClientMock::requestUserMedia):
1419         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1420         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1421         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1422         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1423         * DumpRenderTree/chromium/WebViewHost.cpp:
1424         (WebViewHost::userMediaClient):
1425         (WebViewHost::userMediaClientMock):
1426         (WebViewHost::createMediaPlayer):
1427         (WebViewHost::mediaStreamUtil):
1428         (WebViewHost::testMediaStreamClient):
1429         * DumpRenderTree/chromium/WebViewHost.h:
1430
1431 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1432
1433         Unreviewed, build fix.
1434
1435         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1436
1437         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1438         (ChromiumWinPort.__init__):
1439
1440 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1441
1442         Sheriffbot build fix. Don't emit empty lines on IRC.
1443
1444         * Scripts/webkitpy/tool/bot/irc_command.py:
1445         (LastGreenRevision.execute):
1446
1447 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1448
1449         last-green-revision should report the revision that succeeded on all bots
1450         https://bugs.webkit.org/show_bug.cgi?id=76109
1451
1452         Reviewed by Adam Barth.
1453
1454         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1455         considered green by this algorithm, all matching builders must have a successful run at the revision
1456         or two consecutive successful runs before and after the revision.
1457
1458         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1459         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1460
1461         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1462         (BuildBot._revisions_for_builder):
1463         (BuildBot):
1464         (BuildBot._find_green_revision):
1465         (BuildBot.last_green_revision):
1466         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1467         (MockBuildBot.last_green_revision):
1468         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1469         (test_revisions_for_builder):
1470         (test_find_green_revision):
1471         (test_last_green_revision):
1472         * Scripts/webkitpy/tool/bot/irc_command.py:
1473         (LastGreenRevision.execute):
1474         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1475         (SheriffIRCBotTest.test_lgr):
1476         * Scripts/webkitpy/tool/commands/queries.py:
1477         (LastGreenRevision):
1478
1479 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1480
1481         Unreviewed, fix build bustage on win32 introduced by r104725.
1482
1483         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1484         (MockDRTPortTest.make_port):
1485         (MockChromiumDRTTest.test_pixeltest__fails):
1486
1487 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1488
1489         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1490         https://bugs.webkit.org/show_bug.cgi?id=75618
1491
1492         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1493
1494         Reviewed by Tony Chang.
1495
1496         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1497         (installLayoutTestColorProfile):
1498         (restoreUserColorProfile):
1499         (main):
1500
1501 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1502
1503         test-webkitpy: fix -v and eliminate some spurious warnings
1504         https://bugs.webkit.org/show_bug.cgi?id=76099
1505
1506         Reviewed by Adam Barth.
1507
1508         when we added support for --xml output, we broke the -v flag.
1509
1510         Also, fix the code to swallow a harmless warning from
1511         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1512
1513         test-webkitpy is now silent again except for the one known
1514         logging issue.
1515
1516         * Scripts/webkitpy/common/checkout/checkout.py:
1517         (Checkout.commit_message_for_this_commit):
1518         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1519         (test_commit_message_for_this_commit):
1520         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1521         (JSONChecker.check):
1522         (JSONChecker.line_number_from_json_exception):
1523         * Scripts/webkitpy/test/main.py:
1524         (Tester.run_tests):
1525
1526 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1527
1528         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1529         https://bugs.webkit.org/show_bug.cgi?id=76084
1530
1531         Reviewed by Adam Barth.
1532
1533         This will help make it easier to catch layering violations. This
1534         change just refactors test code; there are no changes to
1535         production code.
1536
1537         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1538         (PortTest.make_port):
1539         (PortTest.test_find_no_paths_specified):
1540         (PortTest.test_find_one_test):
1541         (PortTest.test_find_glob):
1542         (PortTest.test_find_with_skipped_directories):
1543         (PortTest.test_find_with_skipped_directories_2):
1544         (PortTest.test_parse_reftest_list):
1545         (PortTest.test_httpd_returns_error_code):
1546         (PortTest.test_virtual_methods):
1547         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1548         (ChromiumGpuTest.assert_port_works):
1549         (ChromiumGpuTest._assert_baseline_path):
1550         (ChromiumGpuTest.test_graphics_type):
1551         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1552         (ChromiumGpuTest.test_test_files):
1553         (ChromiumGpuTest.test_test_files.test_paths):
1554         (ChromiumGpuTest):
1555         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1556         (ChromiumLinuxPortTest.assert_architecture):
1557         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1558         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1559         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1560         (DriverTest.make_port):
1561         (DriverTest):
1562         (DriverTest.assertVirtual):
1563         (DriverTest._assert_wrapper):
1564         (DriverTest.test_virtual_driver_methods):
1565         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1566         (MockDRTPortTest.make_port):
1567         (MockDRTPortTest.test_port_name_in_constructor):
1568         (MockDRTTest.assertTest):
1569         (MockDRTTest.test_main):
1570         (MockChromiumDRTTest.test_pixeltest__fails):
1571         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1572         (QtPortTest._assert_search_path):
1573         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1574         (TestWebKitPort.__init__):
1575         (WebKitPortUnitTests.test_default_options):
1576         (test_runtime_feature_list):
1577         (test_test_expectations):
1578
1579 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1580
1581         Style skipped tests in the flakiness dashboard
1582         https://bugs.webkit.org/show_bug.cgi?id=76091
1583
1584         Reviewed by Tony Chang.
1585
1586         * TestResultServer/static-dashboards/dashboard_base.js:
1587         Removed "FLAKY" from this list since we don't ever mark individual runs
1588         as flaky. Also deleted an outdated line.
1589         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1590
1591 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1592
1593         Remove gtest normalization code from the test results server
1594         https://bugs.webkit.org/show_bug.cgi?id=76089
1595
1596         Reviewed by Tony Chang.
1597
1598         The normalization now happens on the gtest side.
1599
1600         * TestResultServer/model/jsonresults.py:
1601         (JsonResults.merge):
1602         * TestResultServer/model/jsonresults_unittest.py:
1603         (JsonResultsTest.test_gtest):
1604
1605 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1606
1607         Be more aggressive about deleting unnecessary results from the test-results-server json files
1608         https://bugs.webkit.org/show_bug.cgi?id=76086
1609
1610         Reviewed by Tony Chang.
1611
1612         Remove any tests that only contain skip/pass/nodata values whose runtime
1613         is less than 5 seconds.
1614
1615         * TestResultServer/model/jsonresults.py:
1616         (JsonResults._normalize_results_json):
1617         * TestResultServer/model/jsonresults_unittest.py:
1618         (JsonResultsTest.test_merge_remove_test):
1619         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
1620
1621 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1622
1623         last-green-revision should give us per-bot information
1624         https://bugs.webkit.org/show_bug.cgi?id=76011
1625
1626         Reviewed by Adam Barth.
1627
1628         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
1629         we report the latest green run on each bot from the last 100 runs.
1630
1631         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1632         (BuildBot._fetch_builder_page):
1633         (BuildBot):
1634         (BuildBot._green_revision_for_builder):
1635         (BuildBot.last_green_revision):
1636         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1637         (test_green_revision_for_builder):
1638         (test_last_green_revision):
1639         * Scripts/webkitpy/tool/bot/irc_command.py:
1640         (LastGreenRevision.execute):
1641         * Scripts/webkitpy/tool/commands/queries.py:
1642         (LastGreenRevision.execute):
1643
1644 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1645
1646         webkitpy: clean up version detection in webkitpy.layout_tests.port
1647         https://bugs.webkit.org/show_bug.cgi?id=76016
1648
1649         Reviewed by Adam Barth.
1650
1651         This change updates the code in webkitpy.layout_tests.port to
1652         use the new os_name and os_version fields on host.platform. This
1653         gets layout_tests.port out of the version parsing business. Most
1654         of the diffs are just cleaning up test code to accomodate the
1655         changes.
1656
1657         * Scripts/webkitpy/common/system/executive_mock.py:
1658         (MockExecutive):
1659         (MockExecutive.ignore_error):
1660         (MockExecutive2):
1661         (MockExecutive2.ignore_error):
1662         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1663         (MockPlatformInfo.is_mac):
1664         (MockPlatformInfo.is_linux):
1665         (MockPlatformInfo.is_win):
1666         * Scripts/webkitpy/common/system/systemhost_mock.py:
1667         (MockSystemHost.__init__):
1668         * Scripts/webkitpy/layout_tests/port/apple.py:
1669         (ApplePort.__init__):
1670         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1671         (ChromiumMacPort.__init__):
1672         (ChromiumMacPort.check_wdiff):
1673         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1674         (ChromiumMacPortTest):
1675         (ChromiumMacPortTest.assert_name):
1676         (ChromiumMacPortTest.test_versions):
1677         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1678         (ChromiumPortTest.test_all_test_configurations):
1679         (ChromiumPortTest.TestMacPort.__init__):
1680         (ChromiumPortTest.TestLinuxPort.__init__):
1681         (ChromiumPortTest.TestWinPort.__init__):
1682         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1683         (ChromiumWinPort.__init__):
1684         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1685         (ChromiumWinTest):
1686         (ChromiumWinTest.assert_name):
1687         (ChromiumWinTest.test_versions):
1688         (ChromiumWinTest.test_baseline_path):
1689         (ChromiumWinTest.test_build_path):
1690         * Scripts/webkitpy/layout_tests/port/factory.py:
1691         (PortFactory._port_name_from_arguments_and_options):
1692         (PortFactory.get):
1693         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1694         (FactoryTest):
1695         (FactoryTest.setUp):
1696         (FactoryTest.assert_port):
1697         (FactoryTest.test_mac):
1698         (FactoryTest.test_win):
1699         (FactoryTest.test_google_chrome):
1700         (FactoryTest.test_gtk):
1701         (FactoryTest.test_qt):
1702         (FactoryTest.test_chromium_gpu):
1703         (FactoryTest.test_chromium_gpu_linux):
1704         (FactoryTest.test_chromium_gpu_mac):
1705         (FactoryTest.test_chromium_gpu_win):
1706         (FactoryTest.test_chromium_mac):
1707         (FactoryTest.test_chromium_linux):
1708         (FactoryTest.test_chromium_win):
1709         (FactoryTest.test_unknown_specified):
1710         (FactoryTest.test_unknown_default):
1711         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1712         (TestGoogleChromePort):
1713         (TestGoogleChromePort._verify_baseline_path):
1714         (TestGoogleChromePort._verify_expectations_overrides):
1715         (TestGoogleChromePort.test_get_google_chrome_port):
1716         * Scripts/webkitpy/layout_tests/port/mac.py:
1717         (MacPort):
1718         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1719         (MacTest):
1720         (assert_name):
1721         (test_tests_for_other_platforms):
1722         (test_version):
1723         (test_versions):
1724         (test_is_version_methods):
1725         (test_setup_environ_for_server):
1726         (_assert_search_path):
1727         (test_show_results_html_file):
1728         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1729         (PortTestCase):
1730         (PortTestCase.make_port):
1731         * Scripts/webkitpy/layout_tests/port/win.py:
1732         (WinPort):
1733         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1734         (WinPortTest):
1735         (WinPortTest.test_show_results_html_file):
1736         (WinPortTest._assert_search_path):
1737         (WinPortTest._assert_version):
1738
1739 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
1740
1741         [Qt][WK2] Remove workaround introduced into bug 75470
1742         https://bugs.webkit.org/show_bug.cgi?id=75889
1743
1744         Reviewed by Tor Arne Vestbø.
1745
1746         * MiniBrowser/qt/qml/BrowserWindow.qml:
1747
1748 2012-01-10  Dmitry Lomov  <dslomov@google.com>
1749
1750         [Chromium] Remove obsolete references to WebWorker class.
1751         https://bugs.webkit.org/show_bug.cgi?id=76020
1752
1753         Reviewed by David Levin.
1754
1755         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
1756         * DumpRenderTree/chromium/WebViewHost.cpp:
1757         * DumpRenderTree/chromium/WebViewHost.h:
1758
1759 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1760
1761         [Qt] Some css3 filter tests are failing after r104698
1762         https://bugs.webkit.org/show_bug.cgi?id=76055
1763
1764         Reviewed by Simon Hausmann.
1765
1766         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1767         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
1768
1769 2012-01-11  Tony Chang  <tony@chromium.org>
1770
1771         Don't remove 0 byte files when running build-webkit --chromium
1772         https://bugs.webkit.org/show_bug.cgi?id=75997
1773
1774         Reviewed by Csaba Osztrogonác.
1775
1776         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
1777
1778         * Scripts/webkitdirs.pm:
1779         (determineIsQt):
1780
1781 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1782
1783         Add TestWebKitAPI tests for KURL
1784         <http://webkit.org/b/75774>
1785
1786         Reviewed by Adam Barth.
1787
1788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
1789         WebCore folder and KURL.cpp source file to the project.
1790         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
1791         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
1792         during setup since this test doesn't go through WebKit or
1793         WebKit2.
1794         (TestWebKitAPI::TEST_F): Add two basic tests.
1795
1796 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1797
1798         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
1799
1800         Reviewed by Adam Barth.
1801
1802         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
1803
1804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1805         WTFStringUtilities.h to the project.
1806         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
1807         WTFStringUtilities.h.
1808         * TestWebKitAPI/WTFStringUtilities.h: Added.
1809         (WTF::operator<<):
1810
1811 2012-01-10  Vincent Scheib  <scheib@chromium.org>
1812
1813         Clarify run-webkit-tests options reset-results and new-baseline
1814         https://bugs.webkit.org/show_bug.cgi?id=75993
1815
1816         Reviewed by Dirk Pranke.
1817
1818         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1819         (parse_args):
1820
1821 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
1822
1823         Disabled mock scrollbars should draw differently
1824         https://bugs.webkit.org/show_bug.cgi?id=75995
1825
1826         Reviewed by James Robinson.
1827
1828         When the scrollbar is disabled, paint the entire track of
1829         mock scrollbars with a lighter gray, and hide the thumb.
1830
1831         * DumpRenderTree/mac/DumpRenderTree.mm:
1832         (-[DRTMockScroller drawKnob]):
1833         (-[DRTMockScroller drawRect:]):
1834
1835 2012-01-10  James Robinson  <jamesr@chromium.org>
1836
1837         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
1838         https://bugs.webkit.org/show_bug.cgi?id=75988
1839
1840         Reviewed by Adam Barth.
1841
1842         * Scripts/webkitpy/common/config/ports.py:
1843         (WebKitPort.run_webkit_unit_tests_command):
1844         (WebKitPort):
1845         (ChromiumPort.run_webkit_unit_tests_command):
1846         (ChromiumPort):
1847         * Scripts/webkitpy/common/config/ports_mock.py:
1848         (MockPort.run_webkit_unit_tests_command):
1849         * Scripts/webkitpy/tool/commands/download_unittest.py:
1850         (DownloadCommandsTest.test_build_and_test):
1851         (test_land):
1852         (test_land_red_builders):
1853         * Scripts/webkitpy/tool/steps/runtests.py:
1854         (RunTests.run):
1855         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1856
1857 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1858
1859         webkitpy: add os_name, os_version to platforminfo
1860         https://bugs.webkit.org/show_bug.cgi?id=75931
1861
1862         Reviewed by Eric Siedel.
1863
1864         As a first step in cleaning up the version parsing logic in
1865         webkitpy.layout_tests.port, this adds common routines for
1866         getting the os_name and os_version fields to the PlatformInfo
1867         class. Nothing uses them yet but I've added FIXME's to some of
1868         the code that needs to be deleted in the port files.
1869
1870         * Scripts/webkitpy/common/system/platforminfo.py:
1871         (PlatformInfo.__init__):
1872         (PlatformInfo):
1873         (PlatformInfo._determine_os_name):
1874         (PlatformInfo._determine_mac_version):
1875         (PlatformInfo._determine_linux_version):
1876         (PlatformInfo._determine_win_version):
1877         (PlatformInfo.display_name):
1878         (PlatformInfo.total_bytes_memory):
1879         (PlatformInfo._compute_bytes_from_vm_stat_output):
1880         (PlatformInfo.free_bytes_memory):
1881         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
1882         (TestPlatformInfo):
1883         (TestPlatformInfo.make_info):
1884         (TestPlatformInfo.make_info.mock_run_command):
1885         (TestPlatformInfo.setUp):
1886         (TestPlatformInfo.tearDown):
1887         (TestPlatformInfo.test_basic):
1888         (TestPlatformInfo.integration_test_basic):
1889         (TestPlatformInfo.test_display_name_mac):
1890         (TestPlatformInfo.test_display_name_win32):
1891         (TestPlatformInfo.test_memory_mac):
1892         (TestPlatformInfo.test_memory_win32):
1893         (TestPlatformInfo.test_determine_os_name):
1894         (TestPlatformInfo.test_determine_mac_version):
1895         (TestPlatformInfo.test_determine_linux_version):
1896         (TestPlatformInfo.test_determine_win_version_from_tuple):
1897         (TestPlatformInfo.test_determine_win_version_from_cmd):
1898         * Scripts/webkitpy/layout_tests/port/apple.py:
1899         (ApplePort.__init__):
1900         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1901         (ChromiumMacPort.__init__):
1902         * Scripts/webkitpy/layout_tests/port/mac.py:
1903         (MacPort):
1904         * Scripts/webkitpy/layout_tests/port/win.py:
1905         (WinPort):
1906
1907 2012-01-10  Adam Roben  <aroben@apple.com>
1908
1909         Make it possible to type data: URLs into MiniBrowser on Windows
1910
1911         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
1912         MiniBrowser on Windows
1913
1914         Reviewed by Darin Adler.
1915
1916         * MiniBrowser/win/BrowserWindow.cpp:
1917         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
1918         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
1919         does, we assume it already has a scheme and don't modify it.
1920
1921 2012-01-10  Adam Roben  <aroben@apple.com>
1922
1923         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
1924
1925         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
1926         MiniBrowser on Windows
1927
1928         Reviewed by Darin Adler.
1929
1930         * MiniBrowser/win/BrowserView.cpp:
1931         (BrowserView::goToURL): Pass the typed string through
1932         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
1933
1934 2012-01-10  Ben Wells  <benwells@chromium.org>
1935
1936         Adding myself (benwells) to committers.py
1937         https://bugs.webkit.org/show_bug.cgi?id=75971
1938
1939         Reviewed by Ojan Vafai.
1940
1941         * Scripts/webkitpy/common/config/committers.py:
1942
1943 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
1944
1945         AX: support helpText() in DumpRenderTree
1946         https://bugs.webkit.org/show_bug.cgi?id=40193
1947
1948         Reviewed by Chris Fleizach.
1949
1950         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1951         (AccessibilityUIElement::helpText): Implemented.
1952
1953 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1954
1955         Unreviewed, rolling out r104572.
1956         http://trac.webkit.org/changeset/104572
1957         https://bugs.webkit.org/show_bug.cgi?id=75967
1958
1959         It broke zillion tests (Requested by Ossy on #webkit).
1960
1961         * DumpRenderTree/qt/EventSenderQt.cpp:
1962         (EventSender::EventSender):
1963         (EventSender::sendOrQueueEvent):
1964         (EventSender::replaySavedEvents):
1965         (EventSender::eventFilter):
1966         * DumpRenderTree/qt/EventSenderQt.h:
1967
1968 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
1969
1970         [Qt] fast/events/dont-loose-last-event test fails on WK1
1971         https://bugs.webkit.org/show_bug.cgi?id=73894
1972
1973         Reviewed by Simon Hausmann.
1974
1975         Empty the entire event queue when requested besides using
1976         sendEvent instead of postEvent to make sure all events were
1977         delivered.
1978         This commit also removes not working DRT code to handle drag and drop,
1979         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
1980
1981         * DumpRenderTree/qt/EventSenderQt.cpp:
1982         (EventSender::EventSender):
1983         (EventSender::sendOrQueueEvent):
1984         (EventSender::replaySavedEvents):
1985         * DumpRenderTree/qt/EventSenderQt.h:
1986
1987 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1988
1989         [Qt] Enable CSS_FILTERS in Qt build
1990         https://bugs.webkit.org/show_bug.cgi?id=75777
1991
1992         Add the CSS_FILTERS feature flag to Qt.
1993
1994         Reviewed by Kenneth Rohde Christiansen.
1995
1996         * qmake/mkspecs/features/features.prf:
1997
1998 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1999
2000         [Qt] Unreviewed -Werror build fix.
2001
2002         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2003         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2004         declaration.
2005
2006 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2007
2008         [Qt] Remove dependency to uitools
2009         https://bugs.webkit.org/show_bug.cgi?id=75952
2010
2011         Reviewed by Tor Arne Vestbø.
2012
2013         QUiLoader is used for creating QLabel/QProgressBar widgets for
2014         a layout test, to verify some widget embedding feature. Unfortunately
2015         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2016         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2017         let's break the circular dependency.
2018
2019         * DumpRenderTree/qt/DumpRenderTree.pro:
2020         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2021         (WebCore::WebPage::createPlugin):
2022         * QtTestBrowser/QtTestBrowser.pro:
2023         * QtTestBrowser/launcherwindow.h:
2024         * QtTestBrowser/webpage.cpp:
2025         (WebPage::createPlugin):
2026         * qmake/mkspecs/features/minimal_qt.prf:
2027         * qmake/mkspecs/features/uitools.prf: Removed.
2028
2029 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2030
2031         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2032         https://bugs.webkit.org/show_bug.cgi?id=75894
2033
2034         Reviewed by Tor Arne Vestbø.
2035
2036         * MiniBrowser/qt/MiniBrowserApplication.h:
2037         (MiniBrowserApplication::windowOptions):
2038         * MiniBrowser/qt/main.cpp:
2039         (main):
2040
2041 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2042
2043         [Qt] DRT crashes with Qt 5
2044         https://bugs.webkit.org/show_bug.cgi?id=75951
2045
2046         Reviewed by Ossy.
2047
2048         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2049         Qt relies on font-config to define the default font family.
2050
2051 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2052
2053         [Qt] REGRESSION(r100130): Clean build feature is broken.
2054         https://bugs.webkit.org/show_bug.cgi?id=75863
2055
2056         Reviewed by Tor Arne Vestbø.
2057
2058         * Scripts/webkitdirs.pm:
2059         (buildQMakeProject):
2060
2061 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2062
2063         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2064         https://bugs.webkit.org/show_bug.cgi?id=75885
2065
2066         In QML events are propagated through parents. But since the
2067         WebView may consume key events, a shortcut might never reach
2068         the top QtQuickItem.
2069         Therefore an application wide event handling function in C++
2070         needs to take care of shortcuts for MiniBrowser.
2071
2072         Reviewed by Kenneth Rohde Christiansen.
2073
2074         * MiniBrowser/qt/BrowserWindow.cpp:
2075         (BrowserWindow::reload):
2076         (BrowserWindow::focusAddressBar):
2077         * MiniBrowser/qt/BrowserWindow.h:
2078         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2079         (MiniBrowserApplication::notify):
2080         * MiniBrowser/qt/qml/BrowserWindow.qml:
2081
2082 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2083
2084         Add --efl alias for --platform=efl to run-webkit-test
2085         https://bugs.webkit.org/show_bug.cgi?id=75937
2086
2087         Reviewed by Andreas Kling.
2088         
2089         * Scripts/run-webkit-tests: Add --efl alias.
2090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2091         (parse_args):
2092
2093 2012-01-09  Dan Bernstein  <mitz@apple.com>
2094
2095         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2096         https://bugs.webkit.org/show_bug.cgi?id=75920
2097
2098         Reviewed by Darin Adler.
2099
2100         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2101         (TestWebKitAPI::TEST): Added a test for a range in a
2102         -webkit-user-select: none; block.
2103
2104 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2105
2106         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2107         https://bugs.webkit.org/show_bug.cgi?id=75884
2108
2109         Reviewed by Ryosuke Niwa.
2110
2111         Fix regression introduced (revealed?) in r104340. Chromium file         
2112         url syntax is different on win32 and the test results weren't           
2113         expecting that.                                                         
2114
2115         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2116         (TestExpectations._report_errors):
2117         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2118         (test_parse_error_nonfatal):
2119         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2120         (MockDRTTest.input_line):
2121         (MockChromiumDRTTest.test_pixeltest__fails):
2122         * Scripts/webkitpy/layout_tests/port/test.py:
2123         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2124         (TestRebaseliner.make_rebaseliner):
2125         (TestRebaseliner.test_one_platform):
2126         (TestRebaseliner.test_all_platforms):
2127         (TestRebaseliner.test_png_file_with_comment):
2128         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2129         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2130         (TestRealMain.test_all_platforms):
2131
2132 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2133
2134         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2135
2136         Unreviewed, build fix.
2137
2138         test-webkitpy had a built-in self-test routine to verify that
2139         deleting the .pyc files worked correctly. When I removed the
2140         python24 directory in r104482, I broke the self-test.
2141
2142         I have deleted the self-test for now. Since I am reworking
2143         test-webkitpy I will make sure the new version is adequately
2144         tested.
2145
2146         * Scripts/test-webkitpy:
2147         (configure_logging):
2148         (_clean_pyc_files):
2149         (_clean_packages):
2150         (init):
2151
2152 2012-01-09  Justin Novosad  <junov@chromium.org>
2153
2154         [Chromium] remove all references to the legacy accelerated 2d Canvas
2155         implementation
2156         https://bugs.webkit.org/show_bug.cgi?id=75108
2157
2158         Purging an old settings flag that is no longer referenced
2159
2160         Reviewed by Darin Fisher.
2161
2162         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2163         (main):
2164         * DumpRenderTree/chromium/TestShell.cpp:
2165         (TestShell::TestShell):
2166         (TestShell::resetWebSettings):
2167         * DumpRenderTree/chromium/TestShell.h:
2168         (TestShell::setAccelerated2dCanvasEnabled):
2169         * DumpRenderTree/chromium/WebPreferences.cpp:
2170         (WebPreferences::reset):
2171         (WebPreferences::applyTo):
2172         * DumpRenderTree/chromium/WebPreferences.h:
2173
2174 2012-01-09  Adam Roben  <aroben@apple.com>
2175
2176         Convert Cygwin paths to Windows paths before passing them to DRT
2177
2178         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2179         NRWT
2180
2181         I couldn't find a way to test this because I couldn't figure out how to override the
2182         cygpath function as it is used by WebKitDriver.
2183
2184         Reviewed by Dirk Pranke.
2185
2186         * Scripts/webkitpy/layout_tests/port/webkit.py:
2187         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2188         Windows-style path before passing it to DRT.
2189
2190 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2191
2192         webkitpy: revamp version checking
2193         https://bugs.webkit.org/show_bug.cgi?id=75765
2194
2195         Reviewed by Adam Barth.
2196
2197         The version-checking code in webkitpy/python24/versioning seems really
2198         awkward and overdesigned, especially since we don't support python 2.4
2199         any more.
2200
2201         In addition, I am tired of getting warnings about Python 2.6 being "a
2202         newer release than what is supported" :).
2203
2204         I'm taking a page from the depot_tools python code and just creating a
2205         new webkitpy.common.version_check module that will print a message on
2206         stderr and call sys.exit() if we're running an unsupported version.
2207
2208         * Scripts/check-webkit-style:
2209         * Scripts/new-run-webkit-httpd:
2210         * Scripts/new-run-webkit-tests:
2211         * Scripts/rebaseline-chromium-webkit-tests:
2212         * Scripts/test-webkitpy:
2213         (configure_logging):
2214         (init):
2215         * Scripts/webkit-patch:
2216         (main):
2217         * Scripts/webkitpy/common/system/executive.py:
2218         (Executive._child_process_encoding):
2219         (Executive._should_encode_child_process_arguments):
2220         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2221         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2222         * Scripts/webkitpy/python24/__init__.py: Removed.
2223         * Scripts/webkitpy/python24/versioning.py: Removed.
2224         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2225
2226 2012-01-09  Adam Barth  <abarth@webkit.org>
2227
2228         Remove Chromium Mac CG from the flakiness dashboard
2229         https://bugs.webkit.org/show_bug.cgi?id=75873
2230
2231         Reviewed by Ojan Vafai.
2232
2233         This configuration no longer exists.
2234
2235         * TestResultServer/static-dashboards/builders.js:
2236         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2237         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2238         (testOverrideJustBuildType):
2239         (testPlatformAndBuildType):
2240
2241 2012-01-06  Adam Roben  <aroben@apple.com>
2242
2243         Print an error message when NRWT can't run Apache
2244
2245         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2246
2247         Reviewed by Dirk Pranke.
2248
2249         * Scripts/webkitpy/layout_tests/port/base.py:
2250         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2251         failing silently.
2252
2253         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2254         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2255         run Apache.
2256         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2257         fails.
2258
2259 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2260
2261         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2262         https://bugs.webkit.org/show_bug.cgi?id=75846
2263
2264         Reviewed by Philippe Normand.
2265
2266         * Scripts/webkitdirs.pm:
2267         (runAutogenForAutotoolsProjectIfNecessary):
2268
2269 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2270
2271         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2272         https://bugs.webkit.org/show_bug.cgi?id=75807
2273
2274         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2275         which allows you to dynamically toggle whether touch mocking is
2276         enabled or disabled.
2277
2278         Reviewed by Tor Arne Vestbø.
2279
2280         * MiniBrowser/qt/MiniBrowser.qrc:
2281         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2282         (MiniBrowserApplication::notify):
2283         * MiniBrowser/qt/MiniBrowserApplication.h:
2284         (WindowOptions::WindowOptions):
2285         (WindowOptions::touchMockingEnabled):
2286         (WindowOptions::setTouchMockingEnabled):
2287         * MiniBrowser/qt/icons/touch.png: Added.
2288         * MiniBrowser/qt/qml/BrowserWindow.qml:
2289
2290 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2291
2292         Unreviewed. Fix make distcheck issues.
2293
2294         * MiniBrowser/gtk/GNUmakefile.am:
2295
2296 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2297
2298         Unreviewed, rolling out r104421.
2299         http://trac.webkit.org/changeset/104421
2300         https://bugs.webkit.org/show_bug.cgi?id=75816
2301
2302         Need to rebaseline some tests on Linux (Requested by noamr on
2303         #webkit).
2304
2305         * qmake/mkspecs/features/features.prf:
2306
2307 2012-01-08  Adam Barth  <abarth@webkit.org>
2308
2309         Remove support for Chromium Mac CG from garden-o-matic
2310         https://bugs.webkit.org/show_bug.cgi?id=75814
2311
2312         Reviewed by Eric Seidel.
2313
2314         This configuration no longer exists.  This patch is mostly a matter of
2315         updating config.js and removing the examples from the unit tests.
2316
2317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2322
2323 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2324
2325         [Qt] Enable CSS_FILTERS in Qt build
2326         https://bugs.webkit.org/show_bug.cgi?id=75777
2327
2328         Add the CSS_FILTERS feature flag to Qt.
2329
2330         Reviewed by Kenneth Rohde Christiansen.
2331
2332         * qmake/mkspecs/features/features.prf:
2333
2334 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2335
2336         Categorize bots by ports instead of core/non-core separation
2337         https://bugs.webkit.org/show_bug.cgi?id=75766
2338
2339         Reviewed by Eric Seidel.
2340
2341         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2342         (Chromium still comes before GTK and Qt).
2343
2344         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2345         (loadBuilderConfig):
2346         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2347
2348 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2349
2350         Remove the concept of core builders from webkitpy
2351         https://bugs.webkit.org/show_bug.cgi?id=75809
2352
2353         Reviewed by Ryosuke Niwa.
2354
2355         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2356         and remove the relevant code.
2357
2358         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2359         (BuildBot.__init__):
2360         (BuildBot._matches_regexps):
2361         (BuildBot._builder_statuses_with_names_matching_regexps):
2362         (BuildBot.builder_statuses):
2363         (BuildBot.failure_map):
2364         (BuildBot._latest_builds_from_builders):
2365         (BuildBot.last_green_revision):
2366         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2367         (MockBuildBot.builder_statuses):
2368         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2369         (test_status_parsing):
2370         (test_last_green_revision):
2371         (test_last_green_revision.mock_builds_from_builders):
2372
2373 2012-01-08  Adam Barth  <abarth@webkit.org>
2374
2375         Remove Chromium Mac CG concept from webkitpy
2376         https://bugs.webkit.org/show_bug.cgi?id=75810
2377
2378         Reviewed by Ryosuke Niwa.
2379
2380         This configuration no longer exists.  We can remove all the supporting
2381         code from webkitpy.
2382
2383         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2384         (BaselineOptimizerTest.test_move_baselines):
2385         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2386         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2387         (BaselineOptimizerTest.test_common_directory_includes_root):
2388         (BaselineOptimizerTest.test_complex_shadowing):
2389         * Scripts/webkitpy/common/config/build.py:
2390         (_should_file_trigger_build):
2391         * Scripts/webkitpy/common/config/build_unittest.py:
2392         (ShouldBuildTest):
2393         * Scripts/webkitpy/layout_tests/port/builders.py:
2394         * Scripts/webkitpy/layout_tests/port/chromium.py:
2395         (ChromiumPort):
2396         (ChromiumPort._generate_all_test_configurations):
2397         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2398         (_default_tests_paths):
2399         (ChromiumGpuLinuxPort.tests):
2400         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2401         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2402         (ChromiumGpuTest.assert_port_works):
2403         (ChromiumGpuTest.test_baseline_paths):
2404         (ChromiumGpuTest.test_graphics_type):
2405         (ChromiumGpuTest.test_default_tests_paths):
2406         (ChromiumGpuTest.test_test_files):
2407         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2408         (ChromiumMacPort):
2409         (ChromiumMacPort.__init__):
2410         (ChromiumMacPort.baseline_search_path):
2411         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2412         (ChromiumMacPortTest.test_graphics_type):
2413         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2414         (ChromiumPortTest.test_all_test_configurations):
2415         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2416         * Scripts/webkitpy/layout_tests/port/factory.py:
2417         (PortFactory._port_name_from_arguments_and_options):
2418         (PortFactory.get):
2419         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2420         (FactoryTest.test_chromium_gpu_mac):
2421         (FactoryTest.test_chromium_mac):
2422         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2423         (GetGoogleChromePortTest._verify_expectations_overrides):
2424         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2425         (MockChromiumDRTTest.test_chromium_parse_options):
2426         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2427         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2428         (test_url_fetcher):
2429         (test_zip_factory):
2430         (test_archive):
2431         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2432         (TestRebaseline.test_rebaseline_expectations):
2433
2434 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2435
2436         Categorize bots by ports instead of core/non-core separation
2437         https://bugs.webkit.org/show_bug.cgi?id=75766
2438
2439         Reviewed by Adam Barth.
2440
2441         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2442
2443         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2444         (loadBuilderConfig):
2445         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2446
2447 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2448
2449         Unreviewed, rolling out r104403.
2450         http://trac.webkit.org/changeset/104403
2451         https://bugs.webkit.org/show_bug.cgi?id=75803
2452
2453         It broke all tests on Qt5 (Requested by Ossy_weekend on
2454         #webkit).
2455
2456         * qmake/mkspecs/features/features.prf:
2457
2458 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2459
2460         [Qt] Enable CSS_FILTERS in Qt build
2461         https://bugs.webkit.org/show_bug.cgi?id=75777
2462
2463         Add the CSS_FILTERS feature flag to Qt.
2464
2465         Reviewed by Kenneth Rohde Christiansen.
2466
2467         * qmake/mkspecs/features/features.prf:
2468
2469 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2470
2471         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2472         https://bugs.webkit.org/show_bug.cgi?id=75202
2473
2474         Reviewed by David Kilzer.
2475
2476         The current CSS parser can just parse simple CSSes like
2477
2478             foo bar baz {
2479                 property1: value;
2480                 property2: value;
2481             }
2482
2483         , and cannot parse comments nor a CSS in which a selector and {
2484         appears in different lines. This patch rewrites the CSS parser
2485         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2486         shown in css_unittests.css.
2487
2488         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2489
2490         * Scripts/prepare-ChangeLog:
2491         (get_selector_line_ranges_for_css):
2492         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2493         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2494         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2495         (element1):
2496         (element2):
2497         (element3):
2498         (element4.p):
2499         (element5.p.q.r.s):
2500         (element6#p):
2501         (element7 element8):
2502         (element9.p element10.q):
2503         (element11#p element12#q):
2504         (element13, element14):
2505         (.p):
2506         (#p):
2507         (.p element15 #q element16.r element17#s):
2508         (element18:target):
2509         (element19):
2510         (element20):
2511         (element21):
2512         (element22):
2513
2514 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2515
2516         The Perl parser of prepare-ChangeLog can parse here-documents
2517         https://bugs.webkit.org/show_bug.cgi?id=73208
2518
2519         Reviewed by David Kilzer.
2520
2521         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2522         which results in wrong subroutine names in ChangeLogs.
2523         With this patch, prepare-ChangeLog can judge whether the line of "}"
2524         is the end of a subroutine or a line inside a here-document.
2525
2526         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2527
2528         * Scripts/prepare-ChangeLog:
2529         (get_function_line_ranges_for_perl):
2530         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2531         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2532         Added test cases for here-documents.
2533         (func7):
2534         (func8):
2535         (func9):
2536         (func10):
2537         (func11):
2538         (func12):
2539         (func13):
2540         (func14):
2541         (func15):
2542         (func16):
2543
2544 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2545
2546         Add unittests for the JavaScript parser of prepare-ChangeLog
2547         https://bugs.webkit.org/show_bug.cgi?id=75201
2548
2549         Reviewed by David Kilzer.
2550
2551         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2552         of prepare-ChangeLog.
2553
2554         * Scripts/prepare-ChangeLog:
2555         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
2556         omitted from parsing. Thus,
2557
2558             str = "foo"
2559             function func() {
2560             }
2561
2562         was recognized as equivalent to
2563
2564             str = function func() {
2565             }
2566
2567         This patch replaces a string with a dummy identifier 'string_appeared_here'
2568         to tell the parser that a string appeared there.
2569
2570         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2571         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
2572         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
2573         (func1):
2574         (func2):
2575         (func3):
2576         (func4):
2577         (func5):
2578         (func6):
2579         (func7):
2580         (func8):
2581         (func9):
2582         (func10):
2583         (func11):
2584         (func12):
2585         (funcOverloaded):
2586         (Func1.prototype.get x1):
2587         (Func1.prototype.get x2):
2588         (Func1.prototype.set x1):
2589         (Func1.prototype.set x3):
2590         (Func2.prototype.func13):
2591         (Func2.prototype.func14):
2592         (Func2.prototype.func15):
2593         (func16.func17):
2594         (func16.func18):
2595         (func16.func19):
2596         (func16):
2597
2598 2012-01-08  David Levin  <levin@chromium.org>
2599
2600         [chromium] Add layout test support for autosize code in FrameView.
2601         https://bugs.webkit.org/show_bug.cgi?id=73631
2602
2603         Reviewed by Dmitry Titov.
2604
2605         * DumpRenderTree/chromium/LayoutTestController.cpp:
2606         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
2607         (LayoutTestController::reset): Set the autoresize mode back to false.
2608         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
2609         * DumpRenderTree/chromium/LayoutTestController.h:
2610         * DumpRenderTree/chromium/WebViewHost.cpp:
2611         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
2612         * DumpRenderTree/chromium/WebViewHost.h:
2613
2614 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2615
2616         [WK2][GTK] Each test takes roughly half a second to load
2617         https://bugs.webkit.org/show_bug.cgi?id=70699
2618
2619         Reviewed by Martin Robinson.
2620
2621         Set the XDG_CACHE_HOME environment variable when testing with
2622         WebKitTestRunner. This way the testing is started with a non-existing
2623         application cache. If the cache exists and is not empty, the emptying
2624         and vacuuming that is performed before every test can consume a lot of
2625         time.
2626
2627         This is just a temporary workaround until it becomes possible to set
2628         a desired directory to be used as the application cache location through
2629         WebKitWebContext.
2630
2631         * Scripts/webkitpy/layout_tests/port/gtk.py:
2632         (GtkPort.setup_environ_for_server):
2633
2634 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2635
2636         [GTK] Enable requestAnimationFrame in build-webkit
2637         https://bugs.webkit.org/show_bug.cgi?id=75773
2638
2639         Reviewed by Martin Robinson.
2640
2641         Enable requestAnimationFrame for the Gtk port.
2642
2643         * Scripts/build-webkit:
2644
2645 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
2646
2647         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
2648
2649         * Scripts/webkitdirs.pm:
2650         (buildChromium):
2651         Missing parentheses.
2652
2653 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2654
2655         Fix DRT build on case-sensitive file systems.
2656
2657         Fix case of include of WebDynamicScrollBarsView.h
2658         
2659         * DumpRenderTree/mac/DumpRenderTree.mm:
2660
2661 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2662
2663         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
2664         https://bugs.webkit.org/show_bug.cgi?id=75662
2665
2666         Reviewed by Dan Bernstein.
2667         
2668         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
2669         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
2670         test window uses the main display's color space, so that the pixel values in the bitmap
2671         that gets checksummed are identical to the CSS colors.
2672         
2673         Removed the code that switches the display profile in DRT, since that is no longer required.
2674
2675         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
2676         * DumpRenderTree/mac/DumpRenderTree.mm:
2677         (crashHandler): Remove code that switches display profiles.
2678         (prepareConsistentTestingEnvironment): Ditto.
2679         (dumpRenderTree): Ditto.
2680         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
2681         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
2682         (createBitmapContextFromWebView): Add comment about the colorspace handling.
2683         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2684         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
2685         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
2686         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2687         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
2688         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
2689
2690 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2691
2692         run-api-tests: specify individual suites and tests on the command-line
2693
2694         Reviewed by Adam Roben.
2695
2696         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2697
2698         The run-api-tests script will now accept a list of arguments on
2699         the command-line that are used as prefix filters.  To run all
2700         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
2701         use:
2702
2703             $ run-api-tests WTF
2704
2705         To run only the tests in the "WTF" suite, not the "WTF_Vector"
2706         suite, use:
2707
2708             $ run-api-tests WTF.
2709
2710         * Scripts/run-api-tests: Filter tests if any prefix arguments
2711         are passed on the command-line.
2712
2713 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2714
2715         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
2716
2717         Reviewed by Adam Roben.
2718
2719         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2720
2721         * Scripts/run-api-tests:
2722         (dumpTestsBySuite): Update to accept array of tests instead of
2723         hash data structure.
2724         (runTestsBySuite): Ditto.
2725         (listAllTests): Rename from populateTests().  Update to return
2726         an array of tests instad of the hash data structure.
2727
2728 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2729
2730         webkitpy: clean up test/uri conversion routines
2731         https://bugs.webkit.org/show_bug.cgi?id=75648
2732
2733         Reviewed by Eric Seidel.
2734
2735         This change moves test_to_uri and uri_to_test from the Port
2736         class to the Driver class (the routines were only being
2737         called by the drivers), and removes a bunch of stale and/or
2738         busted logic.
2739
2740         * Scripts/webkitpy/layout_tests/port/base.py:
2741         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2742         * Scripts/webkitpy/layout_tests/port/chromium.py:
2743         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2744         * Scripts/webkitpy/layout_tests/port/driver.py:
2745         (is_http_test):
2746         (test_to_uri):
2747         (uri_to_test):
2748         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2749         (run_one_test):
2750         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2751         (MockDRTTest.input_line):
2752         (input_line):
2753         (expected_output):
2754         * Scripts/webkitpy/layout_tests/port/test.py:
2755         * Scripts/webkitpy/layout_tests/port/webkit.py:
2756         (_command_from_driver_input):
2757
2758 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2759
2760         Mitigate scrollbar differences when running pixel tests
2761         https://bugs.webkit.org/show_bug.cgi?id=67217
2762
2763         Reviewed by Dan Bernstein.
2764         
2765         Add an NSScroller subclass that draws mock scrollbars identically
2766         to the WebCore mock scrollbar theme, and register it with the
2767         WebDynamicScrollbarsView.
2768
2769         * DumpRenderTree/mac/DumpRenderTree.mm:
2770         (-[DRTMockScroller rectForPart:]):
2771         (-[DRTMockScroller drawKnob]):
2772         (-[DRTMockScroller drawRect:]):
2773         (registerMockScrollbars):
2774         (prepareConsistentTestingEnvironment):
2775
2776 2012-01-05  Jon Lee  <jonlee@apple.com>
2777
2778         Update DRT on Mac to draw resize handles on text areas.
2779
2780         Reviewed by John Sullivan.
2781
2782         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
2783         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
2784
2785         * DumpRenderTree/mac/DumpRenderTree.mm:
2786         (resetDefaultsToConsistentValues):
2787
2788 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2789
2790         [Qt] Move listing of include paths and libs to pri files in sources
2791
2792         Includepaths are sometimes modified by non-Qt contributors so keeping
2793         them in files inside Sources makes it more likely that they are updated
2794         along with project files for the other ports.
2795
2796         Using pri files instead of prf files for this also has the benefit that
2797         the include() from the main target file can be parsed and followed by
2798         Qt Creator -- something that does not work with load().
2799
2800         Dependency from a target to a library through the WEBKIT variable are
2801         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
2802         set the source root of the module and include the right pri file.
2803
2804         Ideally we'd use the variant of include() that takes an optional
2805         namespace to read the variables into, or the fromfile() function,
2806         but both of these add an overhead of about 40% on the total qmake
2807         runtime, due to making a deep copy of all the variables in the
2808         project or re-reading all the prf files from scratch.
2809
2810         Reviewed by Simon Hausmann.
2811         Reviewed by Ossy.
2812
2813         * qmake/mkspecs/features/default_post.prf:
2814         * qmake/mkspecs/modules/javascriptcore.prf: Added.
2815         * qmake/mkspecs/modules/webcore.prf: Added.
2816         * qmake/mkspecs/modules/webkit2.prf: Added.
2817         * qmake/mkspecs/modules/wtf.prf: Added.
2818
2819 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
2820
2821         [EFL] Add pre-render handling code in EWebLauncher.
2822         https://bugs.webkit.org/show_bug.cgi?id=73430
2823
2824         Reviewed by Zoltan Herczeg.
2825
2826         Add pre-render handling code by pressing Insert key.
2827
2828         * EWebLauncher/main.c:
2829         (on_key_down):
2830
2831 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
2832
2833         NRWT should use test_expectation.txt on wk2 platforms
2834         https://bugs.webkit.org/show_bug.cgi?id=75417
2835
2836         Reviewed by Dirk Pranke.
2837
2838         * Scripts/webkitpy/layout_tests/port/webkit.py:
2839         (path_to_test_expectations_file):
2840         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2841         (test_path_to_test_expectations_file):
2842
2843 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2844
2845         Don't hardcode expected file URIs in as they depend on the platform
2846         https://bugs.webkit.org/show_bug.cgi?id=75666
2847
2848         Reviewed by Dirk Pranke.
2849
2850         * Scripts/webkitpy/layout_tests/port/win.py:
2851         (WinPort.show_results_html_file):
2852         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2853         (MainTest.test_unexpected_failures):
2854         (MainTest.test_results_directory_default):
2855         (MainTest.test_results_directory_relative):
2856
2857 2012-01-05  Anders Carlsson  <andersca@apple.com>
2858
2859         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
2860         https://bugs.webkit.org/show_bug.cgi?id=75667
2861         <rdar://problem/10389454>
2862
2863         Reviewed by Kevin Decker.
2864
2865         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
2866
2867         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2868         (PluginTest::executeScript):
2869         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2870         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
2871         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
2872         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
2873         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2874
2875 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2876
2877         webkitpy: clean up port factory methods
2878         https://bugs.webkit.org/show_bug.cgi?id=75590
2879
2880         Reviewed by Eric Seidel.
2881
2882         This change consolidates much of the "factory method" logic
2883         of determining which port objects to create for a given set
2884         of configurations by merging the separate factory methods in
2885         chromium_gpu and google_chrome into PortFactory so that at least
2886         all of the logic is in one place.
2887
2888         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2889         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2890         * Scripts/webkitpy/layout_tests/port/factory.py:
2891         (_port_name_from_arguments_and_options):
2892         (get):
2893         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2894         (test_google_chrome):
2895         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2896         (GoogleChromeLinux32Port):
2897         (GoogleChromeLinux32Port.baseline_search_path):
2898         (test_expectations_overrides):
2899         (architecture):
2900         (GoogleChromeLinux64Port):
2901         (GoogleChromeLinux64Port.baseline_search_path):
2902         (GoogleChromeMacPort):
2903         (GoogleChromeMacPort.baseline_search_path):
2904         (GoogleChromeWinPort):
2905         (GoogleChromeWinPort.baseline_search_path):
2906         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2907         (_verify_baseline_path):
2908
2909 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2910
2911         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
2912         https://bugs.webkit.org/show_bug.cgi?id=75617
2913
2914         Reviewed by Dirk Pranke.
2915
2916         * Scripts/webkitpy/common/system/filesystem.py:
2917         (FileSystem.exists):
2918         * Scripts/webkitpy/common/system/filesystem_mock.py:
2919         (MockFileSystem.exists):
2920         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2921         (GenericFileSystemTests.teardown_generic_test_dir):
2922         * Scripts/webkitpy/layout_tests/port/base.py:
2923         (Port.to.show_results_html_file):
2924         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2925         (MainTest.test_results_directory_absolute):
2926
2927 2012-01-05  Adam Roben  <aroben@apple.com>
2928
2929         Remove some unnecessary code from old-run-webkit-tests
2930
2931         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
2932         WebKitTestRunner.
2933
2934         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
2935         Windows
2936
2937         Reviewed by Eric Seidel.
2938
2939         * Scripts/old-run-webkit-tests:
2940         (top level):
2941         (openDumpTool):
2942         Removed calls to setPathForRunningWebKitApp.
2943
2944 2012-01-05  Adam Roben  <aroben@apple.com>
2945
2946         Teach NRWT to use run-safari to open results.html on Apple's Windows port
2947
2948         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
2949         better, since we always want to open results.html using the user's build of WebKit, not
2950         whatever their default browser is.
2951
2952         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
2953         for Apple's Windows port
2954
2955         Reviewed by Eric Seidel.
2956
2957         * Scripts/webkitpy/layout_tests/port/win.py:
2958         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
2959         an obsolete comment.
2960
2961         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2962         (WinPortTest.test_show_results_html_file): Updated expected results.
2963
2964 2012-01-05  Adam Roben  <aroben@apple.com>
2965
2966         Prepend Safari.exe's path to the command-line passed to CreateProcess
2967
2968         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
2969         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
2970         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
2971         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
2972         first argument that WebKitLauncherWin was trying to pass to it.
2973
2974         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
2975
2976         Reviewed by Steve Falkenburg.
2977
2978         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2979         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
2980         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
2981
2982 2012-01-05  Adam Roben  <aroben@apple.com>
2983
2984         Stop using explicit memory management in WebKitLauncherWin
2985
2986         We now use stack-allocated STL objects instead.
2987
2988         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
2989         Safari
2990
2991         Reviewed by Steve Falkenburg.
2992
2993         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2994         (getStringValue):
2995         (applePathFromRegistry):
2996         (safariInstallDir):
2997         (safariBrowserExe):
2998         (_tWinMain):
2999         Changed to use stack-allocated STL objects instead of malloc/free.
3000
3001 2012-01-05  Adam Roben  <aroben@apple.com>
3002
3003         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3004
3005         This allows us to add the Safari and Apple Application Support directories to PATH before
3006         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3007
3008         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3009         Windows port of DumpRenderTree/WebKitTestRunner
3010
3011         Reviewed by Steve Falkenburg.
3012
3013         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3014         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3015
3016         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3017         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3018         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3019
3020         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3021         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3022         the stub launcher.
3023
3024         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3025         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3026         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3027         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3028         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3029         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3030         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3031
3032         * WebKitTestRunner/win/main.cpp:
3033         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3034
3035 2012-01-05  Adam Roben  <aroben@apple.com>
3036
3037         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3038
3039         This allows us to add the Safari and Apple Application Support directories to PATH before
3040         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3041
3042         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3043         Windows port of DumpRenderTree/WebKitTestRunner
3044
3045         Reviewed by Steve Falkenburg.
3046
3047         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
3048         which I forgot to add to this .sln when that project was created.
3049
3050         * DumpRenderTree/win/DumpRenderTree.cpp:
3051         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3052
3053         * DumpRenderTree/win/DumpRenderTree.vcproj:
3054         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3055         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
3056
3057         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
3058         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
3059         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
3060         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
3061         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
3062         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
3063         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
3064         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
3065
3066         * win/DLLLauncher/DLLLauncherMain.cpp:
3067         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
3068         Safari's directory to PATH so that SafariTheme.dll can be found.
3069
3070         (main):
3071         (wWinMain):
3072         Changed to use the new modifyPath function.
3073
3074 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3075
3076         [Qt] Never enable FontConfig on Mac OS X
3077         https://bugs.webkit.org/show_bug.cgi?id=75616
3078
3079         Reviewed by Tor Arne Vestbø.
3080
3081         * qmake/mkspecs/features/features.prf:
3082
3083 2012-01-05  Alpha Lam  <hclam@chromium.org>
3084
3085         Unreviewed, rolling out r104159.
3086         http://trac.webkit.org/changeset/104159
3087         https://bugs.webkit.org/show_bug.cgi?id=75590
3088
3089         Chromium port GPU tests cannot be executed.
3090
3091         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3092         (get):
3093         (_default_tests_paths):
3094         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3095         (ChromiumGpuTest.assert_port_works):
3096         * Scripts/webkitpy/layout_tests/port/factory.py:
3097         (PortFactory._port_name_from_arguments_and_options):
3098         (PortFactory):
3099         (PortFactory._get_kwargs):
3100         (PortFactory.get):
3101         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3102         (FactoryTest.test_google_chrome.names):
3103         (FactoryTest.test_google_chrome):
3104         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3105         (GetGoogleChromePort):
3106         (GetGoogleChromePort.GoogleChromeLinux32Port):
3107         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3108         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3109         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3110         (GetGoogleChromePort.GoogleChromeLinux64Port):
3111         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3112         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3113         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3114         (GetGoogleChromePort.GoogleChromeMacPort):
3115         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3116         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3117         (GetGoogleChromePort.GoogleChromeWinPort):
3118         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3119         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3120         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3121         (GetGoogleChromePortTest._verify_baseline_path):
3122         (GetGoogleChromePortTest._verify_expectations_overrides):
3123
3124 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3125
3126         webkitpy: clean up port factory methods
3127         https://bugs.webkit.org/show_bug.cgi?id=75590
3128
3129         Reviewed by Eric Seidel.
3130
3131         This change consolidates much of the "factory method" logic
3132         of determining which port objects to create for a given set
3133         of configurations by merging the separate factory methods in
3134         chromium_gpu and google_chrome into PortFactory so that at least
3135         all of the logic is in one place.
3136
3137         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3138         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3139         * Scripts/webkitpy/layout_tests/port/factory.py:
3140         (_port_name_from_arguments_and_options):
3141         (get):
3142         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3143         (test_google_chrome):
3144         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3145         (GoogleChromeLinux32Port):
3146         (GoogleChromeLinux32Port.baseline_search_path):
3147         (test_expectations_overrides):
3148         (architecture):
3149         (GoogleChromeLinux64Port):
3150         (GoogleChromeLinux64Port.baseline_search_path):
3151         (GoogleChromeMacPort):
3152         (GoogleChromeMacPort.baseline_search_path):
3153         (GoogleChromeWinPort):
3154         (GoogleChromeWinPort.baseline_search_path):
3155         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3156         (_verify_baseline_path):
3157
3158 2012-01-04  Adam Roben  <aroben@apple.com>
3159
3160         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3161
3162         This allows us to add the Apple Application Support directory to PATH before trying to load
3163         WebKit so that CoreGraphics.dll and friends can be found.
3164
3165         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3166
3167         Reviewed by Anders Carlsson.
3168
3169         * DumpRenderTree/win/ImageDiff.vcproj:
3170         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3171         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3172
3173         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3174         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3175
3176         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3177         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3178         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3179         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3180         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3181         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3182         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3183
3184         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3185         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3186         to main.
3187
3188         * win/DLLLauncher/DLLLauncherMain.cpp:
3189         (main):
3190         (wWinMain):
3191         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3192         stub launcher acts as a console program and calls a console version of
3193         dllLauncherEntryPoint.
3194
3195 2012-01-04  Adam Roben  <aroben@apple.com>
3196
3197         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3198
3199         This allows us to add the Apple Application Support directory to PATH before trying to load
3200         WebKit so that CoreGraphics.dll and friends can be found.
3201
3202         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3203         double-clicked
3204
3205         Reviewed by Anders Carlsson.
3206
3207         * MiniBrowser/MiniBrowser.vcproj:
3208         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3209         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3210
3211         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3212         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3213         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3214         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3215         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3216         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3217         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3218
3219         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3220         but changed to build the stub launcher.
3221
3222         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3223         it needs to be compiled into the .exe instead of the .dll.
3224         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3225         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3226         DLLLauncherMain code.
3227
3228         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
3229         to here.
3230
3231 2012-01-04  Adam Roben  <aroben@apple.com>
3232
3233         Make WinLauncher's window frame respond to clicks/drags again
3234
3235         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
3236         bar when Aero is disabled
3237
3238         Reviewed by Brent Fulgham.
3239
3240         * WinLauncher/WinLauncher.cpp:
3241         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
3242         Also removed an unnecessary "break" keyword.
3243
3244 2012-01-04  Adam Roben  <aroben@apple.com>
3245
3246         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
3247
3248         This allows us to add the Apple Application Support directory to PATH before trying to load
3249         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
3250         should use this mechanism.
3251
3252         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
3253         double-clicked
3254
3255         Reviewed by Anders Carlsson.
3256
3257         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
3258         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
3259         done by the now-removed InitInstance function.
3260         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
3261         calls. Merged code from InitInstance into this function, and change to use the global hInst
3262         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
3263         function, which corresponds to WinLauncher.exe.
3264
3265         * WinLauncher/WinLauncher.vcproj:
3266         * WinLauncher/WinLauncherCommon.vsprops:
3267         Changed to build WinLauncher.dll instead of WinLauncher.exe.
3268
3269         * WinLauncher/WinLauncherLauncher.rc: Added.
3270         * WinLauncher/WinLauncherLauncherResource.h: Added.
3271         This just references the WinLauncher.ico file to set the application icon (though it looks
3272         like that's a default icon).
3273
3274         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
3275         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
3276
3277         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
3278         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
3279         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
3280         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
3281         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
3282         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
3283         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
3284
3285         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
3286         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
3287         program if it detects heap corruption.
3288         (getStringValue): Helper function to read a string value from the registry.
3289         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
3290         application from the registry.
3291         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
3292         Application Support directory.
3293         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
3294         (prependPath): Helper function to prepend a directory to the PATH.
3295         (fatalError): Helper function to display an error to the user.
3296         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
3297         dllLauncherEntryPoint function.
3298
3299 2012-01-05  Kentaro Hara  <haraken@chromium.org>
3300
3301         prepare-ChangeLog cannot parse python code that nests classes and defs
3302         https://bugs.webkit.org/show_bug.cgi?id=75524
3303
3304         Reviewed by Ryosuke Niwa.
3305
3306         This patch fixes the python parser of prepare-ChangeLog so that it can parse
3307         python code that nests classes and defs, like this:
3308
3309         class C:
3310             pass
3311             def f():
3312                 pass
3313             pass
3314
3315         Also, this patch fixes the python parser so that it inserts a dummy line
3316         at the end of the file to pop out all popped scopes.
3317
3318         * Scripts/prepare-ChangeLog:
3319         (get_function_line_ranges_for_python):
3320
3321         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
3322         Added test cases that nest classes and defs.
3323         (func7):
3324         (func7.func8):
3325         (func7.func8.func9):
3326         (Class2):
3327         (Class2.Class3):
3328         (Class2.Class3.Class4):
3329         (Class5):
3330         (Class5.func10):
3331         (Class5.func11):
3332         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
3333
3334 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3335
3336         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
3337         https://bugs.webkit.org/show_bug.cgi?id=75433
3338
3339         Reviewed by Martin Robinson.
3340
3341         * MiniBrowser/gtk/BrowserWindow.c:
3342         (webViewLoadFailed): Reset the progress bar when load fails.
3343         (browserWindowConstructed): Connect to load-failed signal.
3344
3345 2012-01-04  Dan Bernstein  <mitz@apple.com>
3346
3347         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
3348         start WebProcess under gdb and WebProcess will then run the client executable.
3349
3350         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
3351
3352         Reviewed by Anders Carlsson.
3353
3354         * Scripts/webkitdirs.pm:
3355         (shouldTargetWebProcess): Added.
3356         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
3357         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
3358         app using the -client-executable option if targeting the web process.
3359
3360 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3361
3362         Adding myself to committers list.
3363
3364         Unreviewed.
3365
3366         * Scripts/webkitpy/common/config/committers.py:
3367
3368 2012-01-04  David Kilzer  <ddkilzer@apple.com>
3369
3370         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
3371
3372         This reverts commit r103546.
3373
3374         * TestWebKitAPI/TestsController.cpp:
3375         (TestWebKitAPI::TestsController::TestsController):
3376
3377 2012-01-04  James Robinson  <jamesr@chromium.org>
3378
3379         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
3380         https://bugs.webkit.org/show_bug.cgi?id=74583
3381
3382         Reviewed by Darin Fisher.
3383
3384         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
3385
3386         * Scripts/webkitpy/style/checkers/cpp.py:
3387         (check_function_definition):
3388
3389 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3390
3391         [Qt] Fix link order of static libraries and unbreak QtWin32
3392
3393         We were keeping the correct static link order between the intermediate
3394         WebKit libraries, but not the internal dependencies for each of those
3395         libraries. The load() will in some instances mess with LIBS, so we need
3396         to ensure that the dependent libraries are added after the library we
3397         are linking against.
3398
3399         Reviewed by Simon Hausmann.
3400
3401         * qmake/mkspecs/features/default_post.prf:
3402
3403 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3404
3405         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
3406
3407         The custom qmake variable 'WEBKIT' is used for signaling that a
3408         target depends in some way on other subproject of the WebKit
3409         project. For now this is limited to the set of intermediate
3410         libraries: wtf, javascriptcore, webcore, and webkit2.
3411
3412         This replaces the previous convension of using load(foo) for
3413         just include paths, and CONFIG += foo to also link against foo.
3414
3415         Adding a dependency results in additional include paths being
3416         available, and potentially linking to the library. This is
3417         decided by the build system based on conditions such as what
3418         kind of target is being built and the general build config.
3419
3420         An advantage to his approach is that it simplifies the individual
3421         foo.prf files, for example by allowing us to use INCLUDEPATH +=
3422         and LIBS += as normal instead of prepending.
3423
3424         Reviewed by Simon Hausmann.
3425
3426         * DumpRenderTree/qt/DumpRenderTree.pro:
3427         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3428         * QtTestBrowser/QtTestBrowser.pro:
3429         * WebKitTestRunner/InjectedBundle/Target.pri:
3430         * WebKitTestRunner/Target.pri:
3431         * qmake/README:
3432         * qmake/mkspecs/features/default_post.prf:
3433         * qmake/mkspecs/features/functions.prf:
3434         * qmake/mkspecs/features/javascriptcore.prf:
3435         * qmake/mkspecs/features/qtwebkit.prf:
3436         * qmake/mkspecs/features/webcore.prf:
3437         * qmake/mkspecs/features/webkit2.prf:
3438         * qmake/mkspecs/features/wtf.prf:
3439
3440 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
3441
3442         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
3443         https://bugs.webkit.org/show_bug.cgi?id=75488
3444
3445         Reviewed by Tor Arne Vestbø.
3446
3447         * MiniBrowser/qt/MiniBrowser.qrc:
3448         * MiniBrowser/qt/qml/BrowserWindow.qml:
3449         * MiniBrowser/qt/qml/Dialog.qml:
3450         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3451         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3452
3453 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3454
3455         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
3456
3457         It wasn't really a problem at runtime since the right QtWebKit was
3458         already loaded as a dependency of the web process, but the ldd output
3459         would still be busted.
3460
3461         Reviewed by Simon Hausmann.
3462
3463         * WebKitTestRunner/InjectedBundle/Target.pri:
3464
3465 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3466
3467         [Qt] Move use of $$qtLibraryTarget() to a single place
3468
3469         Reviewed by Kenneth Rohde Christiansen.
3470
3471         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3472         * WebKitTestRunner/InjectedBundle/Target.pri:
3473         * qmake/mkspecs/features/default_post.prf:
3474         * qmake/mkspecs/features/webcore.prf:
3475
3476 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3477
3478         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
3479         https://bugs.webkit.org/show_bug.cgi?id=75238
3480
3481         Reviewed by Antonio Gomes.
3482
3483         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
3484         it could initiate download directly if it has the download attribute in the link 
3485         and doesn't need to open new blank page for the target="_blank". Enabling this 
3486         feature in the BlackBerry porting also prepares for later blob feature implementation.
3487
3488         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
3489         for the BlackBerry porting.
3490
3491 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3492
3493         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
3494         https://bugs.webkit.org/show_bug.cgi?id=75475
3495
3496         Reviewed by Martin Robinson.
3497
3498         The problem is that the property blurb contains <a ping> and tree
3499         view uses gtk_tooltip_set_markup() internally, so we need to
3500         escape the text.
3501
3502         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3503         (browserSettingsDialogConstructed): Escape property blurb before
3504         storing it in the GtkTreeModel.
3505
3506 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
3507
3508         When showing results.html pass a correct URL to webbrowser.open
3509         https://bugs.webkit.org/show_bug.cgi?id=75438
3510
3511         Reviewed by Adam Barth.
3512
3513         * Scripts/webkitpy/common/system/filesystem.py:
3514         (file_path_as_url):
3515         * Scripts/webkitpy/common/system/filesystem_mock.py:
3516         (file_path_as_url):
3517         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3518         (test_file_path_as_url):
3519         * Scripts/webkitpy/layout_tests/port/base.py:
3520         (show_results_html_file):
3521         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3522         (test_show_results_html_file):
3523         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3524         (test_results_directory_relative):
3525
3526 2012-01-03  Ojan Vafai  <ojan@chromium.org>
3527
3528         shrink the header on the flakiness dashboard
3529         https://bugs.webkit.org/show_bug.cgi?id=65153
3530
3531         Reviewed by Adam Roben.
3532
3533         Move some of the "show" links to be to the right of the header
3534         instead of below the header when they content they're showing
3535         is hidden. That way we don't waste vertical space on them.
3536
3537         No new tests. This code is covered by existing tests.
3538
3539         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3540
3541 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3542
3543         Add a tool to analyze change logs
3544         https://bugs.webkit.org/show_bug.cgi?id=72243
3545
3546         Reviewed by Eric Seidel.
3547
3548         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3549         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3550         for visualizing json files.
3551
3552         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3553         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3554         generates json files, and N is the number of changelogs to parse.
3555
3556         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3557         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3558         * Scripts/webkitpy/tool/commands/__init__.py:
3559         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3560         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3561         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3562         * Scripts/webkitpy/tool/steps/options.py:
3563
3564 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3565
3566         Add a tool to analyze change logs
3567         https://bugs.webkit.org/show_bug.cgi?id=72243
3568
3569         Reviewed by Eric Seidel.
3570
3571         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3572         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3573         for visualizing json files.
3574
3575         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3576         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3577         generates json files, and N is the number of changelogs to parse.
3578
3579         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3580         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3581         * Scripts/webkitpy/tool/commands/__init__.py:
3582         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3583         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3584         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3585         * Scripts/webkitpy/tool/steps/options.py:
3586
3587 2012-01-03  Adam Roben  <aroben@apple.com>
3588
3589         Make Port subclasses override the operating_system method rather than setting an attribute
3590
3591         Without this patch, any use of Port.operating_system() within a port's __init__ method would
3592         return the default value ("mac"). This was confusing the version-checking logic inside
3593         ApplePort.__init__ on Windows.
3594
3595         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
3596         crashes on launch on Windows 7 SP1
3597
3598         Reviewed by Eric Seidel.
3599
3600         * Scripts/webkitpy/layout_tests/port/apple.py:
3601         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
3602
3603         * Scripts/webkitpy/layout_tests/port/base.py:
3604         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
3605         should now override the operating_system method instead.
3606         (Port.operating_system): Changed to always return "mac". Subclasses should override to
3607         return something else.
3608
3609         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3610         (ChromiumLinuxPort.__init__):
3611         (ChromiumLinuxPort.operating_system):
3612         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3613         (ChromiumMacPort.__init__):
3614         (ChromiumMacPort.operating_system):
3615         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3616         (ChromiumWinPort.__init__):
3617         (ChromiumWinPort.operating_system):
3618         * Scripts/webkitpy/layout_tests/port/mac.py:
3619         (MacPort.__init__):
3620         (MacPort.operating_system):
3621         * Scripts/webkitpy/layout_tests/port/win.py:
3622         (WinPort.__init__):
3623         (WinPort.operating_system):
3624         Changed to override the operating_system method rather than setting the _operating_system
3625         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
3626
3627         * Scripts/webkitpy/layout_tests/port/qt.py:
3628         (QtPort.__init__):
3629         (QtPort._path_to_webcore_library):
3630         Changed to use self.operating_system() instead of self._operating_system, for consistency
3631         with other Port-related code.
3632
3633         (QtPort.operating_system): Added this override of Port.operating_system that returns the
3634         value we determined in our __init__ method.
3635
3636         * Scripts/webkitpy/layout_tests/port/test.py:
3637         (TestPort.operating_system): Added this override of Port.operating_system that returns the
3638         value we determined in our __init__ method.
3639
3640         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3641         (PortTest.test_operating_system):
3642         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3643         (ChromiumLinuxPortTest.test_operating_system):
3644         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3645         (ChromiumMacPortTest.test_operating_system):
3646         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3647         (ChromiumWinPortTest.test_operating_system):
3648         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3649         (MacPortTest.test_operating_system):
3650         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3651         (QtPortTest.test_operating_system):
3652         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3653         (WinPortTest.test_operating_system):
3654         Test that all ports return the expected operating system string.
3655
3656 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>