[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
2
3         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
4         https://bugs.webkit.org/show_bug.cgi?id=197174
5
6         Reviewed by Alex Christensen.
7
8         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
9
10         * TestWebKitAPI/PlatformGTK.cmake:
11         * TestWebKitAPI/PlatformWPE.cmake:
12
13 2019-05-02  Alex Christensen  <achristensen@webkit.org>
14
15         Build fix for internal branch.
16
17         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
18         RetainPtr.h was not explicitly included.
19
20 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
21
22         webkitpy: Ignore errors when shutting down an already shutdown simulator
23         <https://bugs.webkit.org/show_bug.cgi?id=197514>
24         <rdar://problem/50390247>
25
26         Reviewed by Lucas Forschler.
27
28         * Scripts/webkitpy/xcode/simulated_device.py:
29         (SimulatedDevice._shut_down):
30
31 2019-05-02  Frederic Wang  <fwang@igalia.com>
32
33         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
34         https://bugs.webkit.org/show_bug.cgi?id=196142
35
36         This patch introduces some experimental runtime flag to let users
37         disable MathML features that are removed from MathML Core [1]. For now,
38         these features are only disabled on GTK and WPE ports.
39
40         [1] https://mathml-refresh.github.io/mathml-core/
41
42         Reviewed by Rob Buis.
43
44         * DumpRenderTree/TestOptions.cpp:
45         (TestOptions::TestOptions):
46         * DumpRenderTree/TestOptions.h:
47         * DumpRenderTree/mac/DumpRenderTree.mm:
48         (setWebPreferencesForTestOptions):
49
50 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
51
52         TestWebKitAPI config.h should be aware of what suite is being built
53         https://bugs.webkit.org/show_bug.cgi?id=196583
54
55         Reviewed by Konstantin Tokarev.
56
57         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
58         benefit the macro defines BUILDING_* for the executable which allows the includes
59         of the config.h to be tailored to the test suite being built. Because of that the
60         dependencies of the Test* executable are specific to the test suite which may
61         speed up the build.
62
63         Some source files were including "PlatformUtilities.h" which includes WebKit headers
64         when "Utilities.h" is what was needed.
65
66         * TestWebKitAPI/CMakeLists.txt:
67         * TestWebKitAPI/PlatformGTK.cmake:
68         * TestWebKitAPI/PlatformJSCOnly.cmake:
69         * TestWebKitAPI/PlatformMac.cmake:
70         * TestWebKitAPI/PlatformPlayStation.cmake:
71         * TestWebKitAPI/PlatformUtilities.h:
72         * TestWebKitAPI/PlatformWPE.cmake:
73         * TestWebKitAPI/PlatformWin.cmake:
74         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
75         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
76         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
77         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
78         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
79         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
80         * TestWebKitAPI/config.h:
81
82 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
83
84         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
85         https://bugs.webkit.org/show_bug.cgi?id=181950
86         <rdar://problem/43357371>
87
88         Reviewed by Brent Fulgham.
89
90         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
91         (TestWebKitAPI::TEST_F):
92
93 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
94
95         Remove webkitpy and bindings EWS queues from dashboard
96         https://bugs.webkit.org/show_bug.cgi?id=197475
97
98         Reviewed by Alexey Proskuryakov.
99
100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
101
102 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
103
104         Remove webkitpy and bindings test queues from old EWS
105         https://bugs.webkit.org/show_bug.cgi?id=197468
106
107         Reviewed by Alexey Proskuryakov.
108
109         * QueueStatusServer/config/queues.py:
110
111 2019-04-30  Tim Horton  <timothy_horton@apple.com>
112
113         Fix the WebKitTestRunner build
114         https://bugs.webkit.org/show_bug.cgi?id=197449
115         <rdar://problem/50334169>
116
117         Reviewed by Alexey Proskuryakov.
118
119         * WebKitTestRunner/mac/EventSenderProxy.mm:
120         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
121         (WTR::EventSenderProxy::mouseForceChanged):
122         Use some SPI instead of IPI.
123
124 2019-04-30  Chris Dumez  <cdumez@apple.com>
125
126         Regression(PSON) URL scheme handlers can no longer respond asynchronously
127         https://bugs.webkit.org/show_bug.cgi?id=197426
128         <rdar://problem/50256169>
129
130         Reviewed by Brady Eidson.
131
132         Add API test coverage.
133
134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
135         (-[PSONScheme setShouldRespondAsynchronously:]):
136         (-[PSONScheme webView:startURLSchemeTask:]):
137         (-[PSONScheme webView:stopURLSchemeTask:]):
138
139 2019-04-30  Chris Dumez  <cdumez@apple.com>
140
141         Unreviewed, rolling out r244802.
142
143         Caused an API test failure
144
145         Reverted changeset:
146
147         "Regression(PSON) URL scheme handlers can no longer respond
148         asynchronously"
149         https://bugs.webkit.org/show_bug.cgi?id=197426
150         https://trac.webkit.org/changeset/244802
151
152 2019-04-30  Chris Dumez  <cdumez@apple.com>
153
154         Regression(PSON) URL scheme handlers can no longer respond asynchronously
155         https://bugs.webkit.org/show_bug.cgi?id=197426
156         <rdar://problem/50256169>
157
158         Reviewed by Brady Eidson.
159
160         Add API test coverage.
161
162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
163         (-[PSONScheme setShouldRespondAsynchronously:]):
164         (-[PSONScheme webView:startURLSchemeTask:]):
165         (-[PSONScheme webView:stopURLSchemeTask:]):
166
167 2019-04-30  Chris Dumez  <cdumez@apple.com>
168
169         Only use a related page's process if that page has not been closed yet
170         https://bugs.webkit.org/show_bug.cgi?id=197393
171         <rdar://problem/50302423>
172
173         Reviewed by Tim Horton.
174
175         Add API test coverage.
176
177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
178
179 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
180
181         [ews-build] Enable Bindings tests queue on new EWS
182         https://bugs.webkit.org/show_bug.cgi?id=197424
183
184         Reviewed by Lucas Forschler.
185
186         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
187         (StatusBubble):
188         * BuildSlaveSupport/ews-build/config.json:
189
190 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
191
192         [ews-build] Configure ews151 for running various tests
193         https://bugs.webkit.org/show_bug.cgi?id=197419
194
195         Reviewed by Lucas Forschler.
196
197         * BuildSlaveSupport/ews-build/config.json:
198
199 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
200
201         [ews-build] Parse and display bindings test failures
202         https://bugs.webkit.org/show_bug.cgi?id=197423
203
204         Reviewed by Lucas Forschler.
205
206         * BuildSlaveSupport/ews-build/steps.py:
207         (RunBindingsTests.__init__): Set timeout of 5 minutes.
208         (RunBindingsTests.start): Initialize log_observer for json output.
209         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
210         (RunBindingsTests._addToLog): Method to add message to log.
211         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
212
213 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
214
215         Unreviewed. Add myself as a committer.
216
217         * Scripts/webkitpy/common/config/contributors.json:
218
219 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
220
221         [ews-build] Enable webkitpy queue on new EWS
222         https://bugs.webkit.org/show_bug.cgi?id=197396
223
224         Reviewed by Lucas Forschler.
225
226         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
227         (StatusBubble):
228         * BuildSlaveSupport/ews-build/config.json:
229
230 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
231
232         [ews-build] Parse and display webkitpy failures
233         https://bugs.webkit.org/show_bug.cgi?id=197395
234
235         Reviewed by Lucas Forschler.
236
237         * BuildSlaveSupport/ews-build/steps.py:
238         (RunWebKitPyTests.start): Initialize log_observer for json output.
239         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
240         (RunWebKitPyTests._addToLog): Method to add message to log.
241         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
242
243 2019-04-29  Alex Christensen  <achristensen@webkit.org>
244
245         <rdar://problem/50299396> Fix internal High Sierra build
246         https://bugs.webkit.org/show_bug.cgi?id=197388
247
248         * DumpRenderTree/mac/Configurations/Base.xcconfig:
249         * MiniBrowser/Configurations/Base.xcconfig:
250         * MobileMiniBrowser/Configurations/Base.xcconfig:
251         * TestWebKitAPI/Configurations/Base.xcconfig:
252         * WebKitTestRunner/Configurations/Base.xcconfig:
253
254 2019-04-29  Youenn Fablet  <youenn@apple.com>
255
256         Remove spurious GVA printf logging
257         https://bugs.webkit.org/show_bug.cgi?id=197368
258         <rdar://problem/35975256>
259
260         Reviewed by Alexey Proskuryakov.
261
262         * Scripts/webkitpy/port/mac.py:
263         (MacPort.logging_patterns_to_strip):
264
265 2019-04-29  Youenn Fablet  <youenn@apple.com>
266
267         getDisplayMedia should be called on user gesture
268         https://bugs.webkit.org/show_bug.cgi?id=197356
269         <rdar://problem/50296074>
270
271         Reviewed by Eric Carlson.
272
273         Update test configuration to inject internals
274         so that we can use it to simulate a user click to call getDisplayMedia.
275
276         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
277         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
278         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
279
280 2019-04-26  Stephanie Lewis  <slewis@apple.com>
281
282         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
283         https://bugs.webkit.org/show_bug.cgi?id=197339
284
285         Reviewed by Dewei Zhu.
286
287         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
288         test run for setup steps that are too expensive to do every iteration.
289
290         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
291         (BenchmarkRunner._run_benchmark):
292         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
293         (BrowserDriver):
294         (BrowserDriver.prepare_initial_env):
295         (BrowserDriver.restore_env_after_all_testing):
296         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
297         (LinuxBrowserDriver.prepare_initial_env):
298         (LinuxBrowserDriver.restore_env_after_all_testing):
299         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
300         (OSXBrowserDriver.prepare_initial_env):
301         (OSXBrowserDriver.restore_env_after_all_testing):
302
303 2019-04-28  Andy Estes  <aestes@apple.com>
304
305         Fix the watchOS engineering build.
306
307         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
308         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
309
310 2019-04-27  Chris Dumez  <cdumez@apple.com>
311
312         [WKTR] Move test timeout handling to the UIProcess
313         https://bugs.webkit.org/show_bug.cgi?id=197333
314
315         Reviewed by Darin Adler.
316
317         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
318         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
319         every WebContent process in the case of swapping.
320
321         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
322         would lead to crashes when firing the timer.
323
324         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
325         (WTR::InjectedBundle::didReceiveMessageToPage):
326         (WTR::InjectedBundle::done):
327         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
328         (WTR::InjectedBundle::shouldDumpPixels const):
329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
330         (WTR::TestRunner::TestRunner):
331         (WTR::TestRunner::waitUntilDone):
332         (WTR::TestRunner::setWaitUntilDone):
333         * WebKitTestRunner/InjectedBundle/TestRunner.h:
334         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
335         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
336         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
337         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
338         * WebKitTestRunner/TestInvocation.cpp:
339         (WTR::TestInvocation::TestInvocation):
340         (WTR::TestInvocation::createTestSettingsDictionary):
341         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
342         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
343         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
344         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
345         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
346         (WTR::TestInvocation::setWaitUntilDone):
347         (WTR::TestInvocation::done):
348         * WebKitTestRunner/TestInvocation.h:
349
350 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
351
352         [JSC] linkPolymorphicCall now does GC
353         https://bugs.webkit.org/show_bug.cgi?id=197306
354
355         Reviewed by Saam Barati.
356
357         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
358         To add this test, we add `runWithoutBaseOption`.
359
360         * Scripts/run-jsc-stress-tests:
361
362 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
363
364         Update inactive reviewers' status to 'contributor'.
365
366         Accidentally skipped one at first.
367
368         * Scripts/webkitpy/common/config/contributors.json:
369
370 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
371
372         Update inactive reviewers' status to 'contributor'.
373
374         * Scripts/webkitpy/common/config/contributors.json: The change.
375
376         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
377         * Scripts/webkitpy/common/checkout/checkout_mock.py:
378         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
379         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
380         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
381         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
382         * Scripts/webkitpy/tool/commands/queries_unittest.py:
383         * Scripts/webkitpy/tool/commands/upload_unittest.py:
384         Sadly, regression tests operate on a crazy mix of mock and live data for
385         contributors.json. It would be a substantial project to mock all code paths,
386         so changing the tests instead.
387
388 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
389
390         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
391         https://bugs.webkit.org/show_bug.cgi?id=197171
392         <rdar://problem/47454979>
393
394         Reviewed by Youenn Fablet.
395
396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
397         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
398         (TestWebKitAPI::TEST):
399
400 2019-04-26  David Kilzer  <ddkilzer@apple.com>
401
402         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
403         <https://webkit.org/b/197314>
404         <rdar://problem/50245252>
405
406         Reviewed by Simon Fraser.
407
408         * WebKitTestRunner/UIScriptControllerCocoa.mm:
409         (WTR::UIScriptController::lastUndoLabel const):
410         (WTR::UIScriptController::firstRedoLabel const):
411         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
412
413         * WebKitTestRunner/ios/HIDEventGenerator.mm:
414         (-[HIDEventGenerator sendEventStream:completionBlock:]):
415         - Call -autorelease to fix leak of NSDictionary.
416
417         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
418         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
419         (WTR::UIScriptController::selectFormPopoverTitle const):
420         (WTR::UIScriptController::textContentType const):
421         (WTR::UIScriptController::formInputLabel const):
422         (WTR::UIScriptController::scrollingTreeAsText const):
423         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
424
425 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
426
427         webkitpy: Running a single test will always use the default device
428         https://bugs.webkit.org/show_bug.cgi?id=195472
429         <rdar://problem/48724825>
430
431         Reviewed by Lucas Forschler.
432
433         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
434         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
435         requested will be run regardless of what shard they are in.
436
437         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
438         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
439         * Scripts/webkitpy/layout_tests/controllers/manager.py:
440         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
441         on the default device type.
442         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
443         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
444         (RunTest.test_run_part): Ditto.
445
446 2019-04-26  Alex Christensen  <achristensen@webkit.org>
447
448         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
449         https://bugs.webkit.org/show_bug.cgi?id=197165
450
451         Reviewed by Youenn Fablet.
452
453         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
454
455 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
456
457         Replace iOS build queue hardware
458         https://bugs.webkit.org/show_bug.cgi?id=197312
459
460         Reviewed by Aakash Jain.
461
462         * BuildSlaveSupport/build.webkit.org-config/config.json:
463         Use newer hardware that supports macOS Mojave.
464
465 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
466
467         check-webkit-style complains the first block in while loop.
468         https://bugs.webkit.org/show_bug.cgi?id=197307
469
470         The style checker shouldn't complain about an open brace on
471         its own line if the last non-whitespace character on the previous
472         non-blank line is another open brace, because it's likely to
473         indicate the begining of a nested code block.
474
475         Reviewed by Alex Christensen.
476
477         * Scripts/webkitpy/style/checkers/cpp.py:
478         (check_braces):
479         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
480         (WebKitStyleTest.test_braces):
481
482 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
483
484         Stop IDB transactions to release locked database files when network process is ready to suspend
485         https://bugs.webkit.org/show_bug.cgi?id=196372
486         <rdar://problem/48930116>
487
488         Reviewed by Brady Eidson.
489
490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
491         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
492         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
493         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
494         (runTestAndCheckResult):
495         (keepNetworkProcessActive):
496         (TEST):
497
498 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
499
500         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
501         https://bugs.webkit.org/show_bug.cgi?id=188357
502         <rdar://problem/42986633>
503
504         Reviewed by Dean Jackson.
505
506         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
507         tests would fall into low memory mode and have different behavior.
508         
509         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
510         to Internals, so it's shared by DRT and WTR.
511         
512         We no longer need the WK2 C SPI glue.
513
514         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
515         (WTR::InjectedBundlePage::prepare):
516
517 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
518
519         webkitpy: Including skipped tests in the final count
520         https://bugs.webkit.org/show_bug.cgi?id=197298
521         <rdar://problem/49705424>
522
523         Reviewed by Lucas Forschler.
524
525         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
526         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
527
528 2019-04-25  Timothy Hatcher  <timothy@apple.com>
529
530         Disable date and time inputs on iOSMac.
531         https://bugs.webkit.org/show_bug.cgi?id=197287
532         rdar://problem/46794376
533
534         Reviewed by Wenson Hsieh.
535
536         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
537
538 2019-04-25  Alex Christensen  <achristensen@webkit.org>
539
540         Fix test-webkitpy after r244653
541         https://bugs.webkit.org/show_bug.cgi?id=197131
542
543         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
544         Also use C++17.
545
546 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
547
548         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
549         https://bugs.webkit.org/show_bug.cgi?id=196991
550         <rdar://problem/45507423>
551
552         Reviewed by Alex Christensen.
553
554         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
555         (-[NavigationTestDelegate init]):
556         (-[NavigationTestDelegate waitForDidFinishNavigation]):
557         (-[NavigationTestDelegate webView:didFinishNavigation:]):
558         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
559         (TestWebKitAPI::TEST):
560         (TEST): Deleted.
561
562 2019-04-25  Alex Christensen  <achristensen@webkit.org>
563
564         Revert some code accidentally committed with r244653
565         https://bugs.webkit.org/show_bug.cgi?id=197131
566
567         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
568         (TestWebKitAPI::TEST):
569
570 2019-04-25  Alex Christensen  <achristensen@webkit.org>
571
572         Start using C++17
573         https://bugs.webkit.org/show_bug.cgi?id=197131
574
575         Reviewed by Darin Adler.
576
577         * DumpRenderTree/mac/Configurations/Base.xcconfig:
578         * MiniBrowser/Configurations/Base.xcconfig:
579         * MobileMiniBrowser/Configurations/Base.xcconfig:
580         * TestWebKitAPI/Configurations/Base.xcconfig:
581         * WebKitTestRunner/Configurations/Base.xcconfig:
582
583 2019-04-25  Commit Queue  <commit-queue@webkit.org>
584
585         Unreviewed, rolling out r244627.
586         https://bugs.webkit.org/show_bug.cgi?id=197282
587
588         Causing internal build failures (Requested by ShawnRoberts on
589         #webkit).
590
591         Reverted changeset:
592
593         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
594         https://bugs.webkit.org/show_bug.cgi?id=197171
595         https://trac.webkit.org/changeset/244627
596
597 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
598
599         [GTK] Hardcoded text color in input fields
600         https://bugs.webkit.org/show_bug.cgi?id=126907
601
602         Reviewed by Michael Catanzaro.
603
604         Add dark-mode command line option to MiniBrowser.
605
606         * MiniBrowser/gtk/main.c:
607         (main):
608
609 2019-04-24  Zalan Bujtas  <zalan@apple.com>
610
611         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
612         https://bugs.webkit.org/show_bug.cgi?id=196948
613         <rdar://problem/49927131>
614
615         Reviewed by Tim Horton.
616
617         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
618         (TEST):
619         The expected order of incoming events is
620         1. didInvalidateIntrinsicContentSize
621         2. didFirstLayout
622         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
623         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
624         (and remember, all we care about is ordering).
625
626 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
627
628         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
629         https://bugs.webkit.org/show_bug.cgi?id=197171
630         <rdar://problem/47454979>
631
632         Reviewed by Youenn Fablet.
633
634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
635         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
636         (TestWebKitAPI::TEST):
637
638 2019-04-24  Brady Eidson  <beidson@apple.com>
639
640         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
641         https://bugs.webkit.org/show_bug.cgi?id=191362
642
643         Reviewed by Alex Christensen.
644
645         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
646           from an XHR to a custom protocol.
647
648 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
649
650         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
651         https://bugs.webkit.org/show_bug.cgi?id=197273
652
653         Reviewed by Dean Jackson.
654
655         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
656         so that WebCoreTestSupport::resetInternalsObject() is always run.
657
658         * DumpRenderTree/mac/DumpRenderTree.mm:
659         (resetWebViewToConsistentStateBeforeTesting):
660         (runTest):
661
662 2019-04-24  John Wilander  <wilander@apple.com>
663
664         Age out unconverted Ad Click Attributions after one week.
665         https://bugs.webkit.org/show_bug.cgi?id=197238
666         <rdar://problem/50177349>
667
668         Reviewed by Chris Dumez.
669
670         This patch adds infrastructure to allow tests to expire all unconverted
671         attributions early.
672
673         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
675         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
676         * WebKitTestRunner/InjectedBundle/TestRunner.h:
677         * WebKitTestRunner/TestController.cpp:
678         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
679         * WebKitTestRunner/TestController.h:
680         * WebKitTestRunner/TestInvocation.cpp:
681         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
682
683 2019-04-24  Chris Dumez  <cdumez@apple.com>
684
685         Fix flaky crashes in a couple of PSON API tests
686         https://bugs.webkit.org/show_bug.cgi?id=197239
687
688         Reviewed by Tim Horton.
689
690         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
691
692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
693
694 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
695
696         Make it possible to control the renderTreeAsText output by setting options on testRunner
697         https://bugs.webkit.org/show_bug.cgi?id=197133
698
699         Reviewed by Sam Weinig.
700
701         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
702         that make sense in testing (those that don't dump unstable data like addresses), and plumb
703         these flags through the various framework layers.
704
705         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
706
707         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
708         and hand-code DumpRenderTree bindings.
709
710         Some cleanup of the TestRunners, using member initializers.
711
712         * DumpRenderTree/TestRunner.cpp:
713         (TestRunner::TestRunner):
714         (setRenderTreeDumpOptionsCallback):
715         (TestRunner::staticFunctions):
716         (TestRunner::setRenderTreeDumpOptions):
717         * DumpRenderTree/TestRunner.h:
718         (TestRunner::renderTreeDumpOptions const):
719         * DumpRenderTree/mac/DumpRenderTree.mm:
720         (dump):
721         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
722         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
723         (WTR::InjectedBundlePage::dump):
724         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
725         (WTR::TestRunner::TestRunner):
726         (WTR::TestRunner::setRenderTreeDumpOptions):
727         * WebKitTestRunner/InjectedBundle/TestRunner.h:
728         (WTR::TestRunner::renderTreeDumpOptions const):
729
730 2019-04-24  Alex Christensen  <achristensen@webkit.org>
731
732         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
733         https://bugs.webkit.org/show_bug.cgi?id=197078
734         <rdar://problem/49564348>
735
736         Reviewed by Geoff Garen.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
739         (TEST_F):
740         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
741         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
742         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
743
744 2019-04-24  Alex Christensen  <achristensen@webkit.org>
745
746         Add unit test for r239322
747         https://bugs.webkit.org/show_bug.cgi?id=197236
748
749         Reviewed by Chris Dumez.
750
751         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
752         May as well add the test infrastructure which was needed before and will be needed in the future.
753
754         * TestWebKitAPI/TCPServer.cpp:
755         (TestWebKitAPI::TCPServer::TCPServer):
756         * TestWebKitAPI/TCPServer.h:
757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
758         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
759         (TestWebKitAPI::TEST):
760         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
761         (TestWebKitAPI::downloadAtRate):
762         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
763         (TEST):
764         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
765         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
766         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
767         (TestWebKitAPI::TEST):
768         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
769         (TEST):
770
771 2019-04-24  Chris Dumez  <cdumez@apple.com>
772
773         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
774         https://bugs.webkit.org/show_bug.cgi?id=197214
775         <rdar://problem/49237544>
776
777         Reviewed by Alex Christensen.
778
779         Extend API test coverage.
780
781         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
782         (TEST):
783
784 2019-04-24  Philippe Normand  <pnormand@igalia.com>
785
786         [Build][GStreamer] Update to 1.16.0
787         https://bugs.webkit.org/show_bug.cgi?id=197157
788
789         Reviewed by Xabier Rodriguez-Calvar.
790
791         The upstreamed patches were removed and a new one was added for a
792         regression detected in the scaletempo GStreamer element. The GNOME
793         Flatpak was migrated to 3.32 and I switched a few modules to Meson
794         on the way, as it is the preferred build system now in GStreamer
795         1.16.
796
797         * flatpak/files/httpd-autogen.sh:
798         * flatpak/flatpakutils.py:
799         (FlatpakPackage.install):
800         (WebkitFlatpak.run_in_sandbox):
801         * flatpak/org.webkit.CommonModules.yaml:
802         * flatpak/org.webkit.WebKit.yaml:
803         * gstreamer/jhbuild.modules:
804         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
805         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
806         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
807         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
808         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
809         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
810         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
811         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
812         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
813         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
814         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
815         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
816         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
817         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
818         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
819         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
820         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
821         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
822         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
823         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
824         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
825         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
826
827 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
828
829         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
830         https://bugs.webkit.org/show_bug.cgi?id=197156
831
832         Reviewed by Michael Catanzaro.
833
834         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
835         support was added.
836
837         * MiniBrowser/gtk/BrowserTab.c:
838         (browser_tab_set_background_color): Set the passed in color as web view background color.
839         * MiniBrowser/gtk/BrowserTab.h:
840         * MiniBrowser/gtk/BrowserWindow.c:
841         (browser_window_init): Initialize backgroundColor.
842         (browser_window_append_view): Call browser_tab_set_background_color().
843         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
844         are added.
845         * MiniBrowser/gtk/main.c:
846         (main): Call browser_window_set_background_color() before creating the tabs.
847
848 2019-04-23  John Wilander  <wilander@apple.com>
849
850         Move Ad Click Attribution from internal feature to experimental feature
851         https://bugs.webkit.org/show_bug.cgi?id=197218
852         <rdar://problem/47651691>
853
854         Reviewed by Brent Fulgham.
855
856         * DumpRenderTree/TestOptions.cpp:
857         (TestOptions::TestOptions):
858
859 2019-04-23  Andy Estes  <aestes@apple.com>
860
861         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
862         https://bugs.webkit.org/show_bug.cgi?id=196749
863         <rdar://problem/35773454>
864
865         Reviewed by Daniel Bates.
866
867         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
868
869         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
870         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
871         (-[QuickLookDelegate webView:didFinishNavigation:]):
872         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
873         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
874         (runTest):
875         (runTestDecideBeforeLoading):
876         (runTestDecideAfterLoading):
877         (TEST):
878
879 2019-04-23  John Wilander  <wilander@apple.com>
880
881         Remove Ad Click Attribution data when removing website data
882         https://bugs.webkit.org/show_bug.cgi?id=197215
883         <rdar://problem/47668988>
884
885         Reviewed by Chris Dumez.
886
887         This patch adds test infrastructure to delete Ad Click Attribution data
888         through WebsiteDataStore::removeData().
889
890         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
892         (WTR::TestRunner::clearAdClickAttribution):
893         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
894         * WebKitTestRunner/InjectedBundle/TestRunner.h:
895         * WebKitTestRunner/TestController.cpp:
896         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
897         * WebKitTestRunner/TestController.h:
898         * WebKitTestRunner/TestInvocation.cpp:
899         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
900
901 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
902
903         webkitpy: Kill unresponsive worker processes
904         https://bugs.webkit.org/show_bug.cgi?id=197205
905         <rdar://problem/50104388>
906
907         Reviewed by Lucas Forschler.
908
909         * Scripts/webkitpy/common/message_pool.py:
910         (_MessagePool.__init__): Add close timeout.
911         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
912
913 2019-04-23  Alex Christensen  <achristensen@webkit.org>
914
915         Add unit tests for WKWebView.serverTrust
916         https://bugs.webkit.org/show_bug.cgi?id=197202
917
918         Reviewed by Youenn Fablet
919
920         * TestWebKitAPI/TCPServer.cpp:
921         (TestWebKitAPI::deleter<BIO>::operator()):
922         (TestWebKitAPI::deleter<SSL>::operator()):
923         (TestWebKitAPI::deleter<X509>::operator()):
924         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
925         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
926         (TestWebKitAPI::TCPServer::TCPServer):
927         (TestWebKitAPI::TCPServer::listenForConnections):
928         * TestWebKitAPI/TCPServer.h:
929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
930         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
931         (TestWebKitAPI::TEST):
932         (verifyCertificateAndPublicKey):
933         (-[ServerTrustDelegate webView:didFinishNavigation:]):
934         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
935         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
936         (TestWebKitAPI::downloadAtRate):
937         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
938         (TEST):
939         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
940         (TEST):
941
942 2019-04-23  Commit Queue  <commit-queue@webkit.org>
943
944         Unreviewed, rolling out r244556.
945         https://bugs.webkit.org/show_bug.cgi?id=197212
946
947         Causing build failures on multiple builders (Requested by
948         ShawnRoberts on #webkit).
949
950         Reverted changeset:
951
952         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
953         https://bugs.webkit.org/show_bug.cgi?id=197171
954         https://trac.webkit.org/changeset/244556
955
956 2019-04-23  Alex Christensen  <achristensen@webkit.org>
957
958         Fix iOS build.
959         https://bugs.webkit.org/show_bug.cgi?id=195537
960
961         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
962         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
963         AdoptWK constructor is private now.  Use adoptWK instead.
964
965 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
966
967         Accessibility text search and selection API enhancements.
968         https://bugs.webkit.org/show_bug.cgi?id=197095
969         <rdar://problem/48181791>
970
971         Reviewed by Chris Fleizach.
972
973         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
974
975         * DumpRenderTree/AccessibilityTextMarker.h:
976         * DumpRenderTree/AccessibilityUIElement.cpp:
977         (searchTextWithCriteriaCallback):
978         (AccessibilityUIElement::getJSClass):
979         * DumpRenderTree/AccessibilityUIElement.h:
980         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
981         (convertVectorToObjectArray):
982         (convertNSArrayToVector):
983         (searchTextParameterizedAttributeForCriteria):
984         (AccessibilityUIElement::getLinkedUIElements):
985         (AccessibilityUIElement::getDocumentLinks):
986         (AccessibilityUIElement::getChildren):
987         (AccessibilityUIElement::getChildrenWithRange):
988         (AccessibilityUIElement::rowHeaders const):
989         (AccessibilityUIElement::columnHeaders const):
990         (AccessibilityUIElement::uiElementArrayAttributeValue const):
991         (AccessibilityUIElement::searchTextWithCriteria):
992         (AccessibilityUIElement::attributesOfColumnHeaders):
993         (AccessibilityUIElement::attributesOfRowHeaders):
994         (AccessibilityUIElement::attributesOfColumns):
995         (AccessibilityUIElement::attributesOfRows):
996         (AccessibilityUIElement::attributesOfVisibleCells):
997         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
998         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
999         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1000         (WTR::convertVectorToObjectArray):
1001         (WTR::convertNSArrayToVector):
1002         (WTR::searchTextParameterizedAttributeForCriteria):
1003         (WTR::AccessibilityUIElement::getLinkedUIElements):
1004         (WTR::AccessibilityUIElement::getDocumentLinks):
1005         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1006         (WTR::AccessibilityUIElement::getChildren):
1007         (WTR::AccessibilityUIElement::getChildrenWithRange):
1008         (WTR::AccessibilityUIElement::rowHeaders const):
1009         (WTR::AccessibilityUIElement::columnHeaders const):
1010         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1011         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1012         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1013         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1014         (WTR::AccessibilityUIElement::attributesOfColumns):
1015         (WTR::AccessibilityUIElement::attributesOfRows):
1016         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1017         (WTR::convertElementsToObjectArray): Deleted.
1018
1019 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1020
1021         Multiple File Input Icon Set Regardless of File List
1022         https://bugs.webkit.org/show_bug.cgi?id=195537
1023
1024         Reviewed by Alexey Proskuryakov.
1025
1026         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1027         display string in iOS file inputs
1028
1029         * DumpRenderTree/TestRunner.cpp:
1030         (SetOpenPanelFilesMediaIconCallback):
1031         (TestRunner::staticFunctions):
1032         (TestRunner::setOpenPanelFilesMediaIcon):
1033         * DumpRenderTree/TestRunner.h:
1034         (TestRunner::openPanelFilesMediaIcon const):
1035         * DumpRenderTree/mac/UIDelegate.mm:
1036         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1037         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1038         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1039         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1040         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1041         * WebKitTestRunner/TestController.cpp:
1042         (WTR::runOpenPanel):
1043         (WTR::TestController::resetStateToConsistentValues):
1044         * WebKitTestRunner/TestController.h:
1045         (WTR::TestController::openPanelFileURLsMediaIcon const):
1046         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1047         * WebKitTestRunner/TestInvocation.cpp:
1048         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1049
1050 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1051
1052         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1053         https://bugs.webkit.org/show_bug.cgi?id=197171
1054         <rdar://problem/47454979>
1055
1056         Reviewed by Youenn Fablet.
1057
1058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1059         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1060         (TestWebKitAPI::TEST):
1061
1062 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1063
1064         [ews-build] Add unit tests for UnApplyPatchIfRequired
1065         https://bugs.webkit.org/show_bug.cgi?id=197197
1066
1067         Reviewed by Lucas Forschler.
1068
1069         * BuildSlaveSupport/ews-build/steps_unittest.py:
1070         (TestUnApplyPatchIfRequired):
1071         (TestUnApplyPatchIfRequired.test_success):
1072         (TestUnApplyPatchIfRequired.test_failure):
1073         (TestUnApplyPatchIfRequired.test_skip):
1074
1075 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1076
1077         [ews-build] Add unit tests for CleanWorkingDirectory
1078         https://bugs.webkit.org/show_bug.cgi?id=197195
1079
1080         Reviewed by Lucas Forschler.
1081
1082         * BuildSlaveSupport/ews-build/steps_unittest.py:
1083         (TestCleanWorkingDirectory):
1084         (TestCleanWorkingDirectory.test_success):
1085         (TestCleanWorkingDirectory.test_failure):
1086
1087 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1088
1089         [ews-build] Use explicit imports instead of wildcard imports
1090         https://bugs.webkit.org/show_bug.cgi?id=197194
1091
1092         Reviewed by Lucas Forschler.
1093
1094         * BuildSlaveSupport/ews-build/factories.py:
1095         * BuildSlaveSupport/ews-build/loadConfig.py:
1096         * BuildSlaveSupport/ews-build/steps_unittest.py:
1097
1098 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-build] Add unit tests for DownloadBuiltProduct
1101         https://bugs.webkit.org/show_bug.cgi?id=197193
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-build/steps_unittest.py:
1106         (TestDownloadBuiltProduct):
1107         (TestDownloadBuiltProduct.setUp):
1108         (TestDownloadBuiltProduct.tearDown):
1109         (TestDownloadBuiltProduct.test_success):
1110         (TestDownloadBuiltProduct.test_failure):
1111
1112 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-app] Exception while loading status-bubble when no build step has started
1115         https://bugs.webkit.org/show_bug.cgi?id=196676
1116
1117         Reviewed by Lucas Forschler.
1118
1119         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1120         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1121
1122 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1123
1124         [PlayStation] Support running of JSC tests on remote playstation devices
1125         https://bugs.webkit.org/show_bug.cgi?id=197170
1126
1127         Reviewed by Ross Kirsling.
1128
1129         Script changes
1130
1131         * Scripts/run-javascriptcore-tests:
1132         (runJSCStressTests): Pass arguments for playstation to
1133         run-jsc-stress-tests
1134         * Scripts/run-jsc-stress-tests:
1135         Handle $hostOS=="playstation" for determineArchitecture, turning
1136         off $isFTLPlatform and runProfiler and defaulting test writer.
1137         * Scripts/webkitdirs.pm:
1138         (jscPath): PlayStation WebKit executables have .elf extension
1139         (executableProductDir): PlayStation builds on Windows hosts but
1140         uses bin directory rather than bin64/bin32 for executable output
1141         location.
1142         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1143
1144 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1145
1146         [CMake][Win] Use target oriented design for WebKit
1147         https://bugs.webkit.org/show_bug.cgi?id=197173
1148
1149         Reviewed by Alex Christensen.
1150
1151         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1152         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1153
1154 2019-04-23  Chris Dumez  <cdumez@apple.com>
1155
1156         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1157         https://bugs.webkit.org/show_bug.cgi?id=197097
1158         <rdar://problem/50048318>
1159
1160         Reviewed by Alex Christensen.
1161
1162         Add API test coverage.
1163
1164         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1165         (-[PSONScheme webView:startURLSchemeTask:]):
1166
1167 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1168
1169         [ATK] Implement AtkComponentIface scroll_to methods
1170         https://bugs.webkit.org/show_bug.cgi?id=196856
1171
1172         Reviewed by Michael Catanzaro.
1173
1174         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1175         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1176         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1177         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1178
1179 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1180
1181         [ews-build] Improve summary for UploadBuiltProduct step
1182         https://bugs.webkit.org/show_bug.cgi?id=197182
1183
1184         Reviewed by Lucas Forschler.
1185
1186         * BuildSlaveSupport/ews-build/steps.py:
1187         (UploadBuiltProduct): Added descriptionDone.
1188         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1189         * BuildSlaveSupport/ews-build/steps_unittest.py:
1190         (TestUploadBuiltProduct.test_success): Updated unit-test.
1191         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1192
1193 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1194
1195         [ews-build] Trigger queues only after uploading the archive
1196         https://bugs.webkit.org/show_bug.cgi?id=197180
1197
1198         Reviewed by Lucas Forschler.
1199
1200         * BuildSlaveSupport/ews-build/factories.py:
1201         (Factory.__init__):
1202         (BuildFactory.__init__): Remove trigger step from factories.
1203         (BuildFactory.propertiesToPassToTriggers): Deleted.
1204         * BuildSlaveSupport/ews-build/steps.py:
1205         (ConfigureBuild.__init__): Confiure triggers property.
1206         (Trigger): Step to trigger other queues.
1207         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1208         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1209
1210 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1211
1212         Deprecate WKContextCreateWithInjectedBundlePath
1213         https://bugs.webkit.org/show_bug.cgi?id=197169
1214
1215         Reviewed by Youenn Fablet.
1216
1217         * TestWebKitAPI/PlatformUtilities.cpp:
1218         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1219         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1220
1221 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1222
1223         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1224         https://bugs.webkit.org/show_bug.cgi?id=197093
1225         <rdar://problem/49708268>
1226
1227         Reviewed by Chris Dumez.
1228
1229         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1230         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1231         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1232         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1233         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1234
1235         * TestWebKitAPI/TCPServer.cpp:
1236         (TestWebKitAPI::TCPServer::TCPServer):
1237         (TestWebKitAPI::TCPServer::~TCPServer):
1238         (TestWebKitAPI::TCPServer::socketBindListen):
1239         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1240         * TestWebKitAPI/TCPServer.h:
1241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1242         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1243         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1244         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1245         (respondWithChallengeThenOK):
1246         (TestWebKitAPI::TEST):
1247         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1248         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1249         (TEST):
1250
1251 2019-04-22  Chris Dumez  <cdumez@apple.com>
1252
1253         Delayed WebProcessLaunch may break the _relatedWebView SPI
1254         https://bugs.webkit.org/show_bug.cgi?id=197160
1255
1256         Reviewed by Alex Christensen.
1257
1258         Add API test coverage.
1259
1260         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1261
1262 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1263
1264         Use curl to download packages for webkitpy autoinstaller
1265         https://bugs.webkit.org/show_bug.cgi?id=197164
1266
1267         Reviewed by Darin Adler.
1268
1269         * Scripts/webkitpy/common/system/autoinstall.py:
1270         (AutoInstaller._download): Use curl(1) to download packages necessary for
1271         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1272         errors which are not present when using curl(1).
1273
1274 2019-04-22  Chris Dumez  <cdumez@apple.com>
1275
1276         Unreviewed, rolling out r244502.
1277
1278         Caused crashes on the bots
1279
1280         Reverted changeset:
1281
1282         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1283         https://bugs.webkit.org/show_bug.cgi?id=197160
1284         https://trac.webkit.org/changeset/244502
1285
1286 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1287
1288         Unreviewed, rolling out r244437.
1289
1290         Still breaks internal tests.
1291
1292         Reverted changeset:
1293
1294         "InjectedBundle parameters often need initialization function
1295         called before unarchiving"
1296         https://bugs.webkit.org/show_bug.cgi?id=189709
1297         https://trac.webkit.org/changeset/244437
1298
1299 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [ews-build] Use singular verb in failure description in case of single api test failure
1302         https://bugs.webkit.org/show_bug.cgi?id=197013
1303
1304         Reviewed by Lucas Forschler.
1305
1306         * BuildSlaveSupport/ews-build/steps.py:
1307         (AnalyzeAPITestsResults.analyzeResults):
1308
1309 2019-04-22  Chris Dumez  <cdumez@apple.com>
1310
1311         Delayed WebProcessLaunch may break the _relatedWebView SPI
1312         https://bugs.webkit.org/show_bug.cgi?id=197160
1313
1314         Reviewed by Alex Christensen.
1315
1316         Add API test coverage.
1317
1318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1319
1320 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1321
1322         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1323         https://bugs.webkit.org/show_bug.cgi?id=194630
1324
1325         Reviewed by Michael Catanzaro.
1326
1327         Return early from getAttributeSet() is passed in accessible is nullptr.
1328
1329         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1330
1331 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1332
1333         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1334         https://bugs.webkit.org/show_bug.cgi?id=197145
1335         <rdar://problem/50078170>
1336
1337         Reviewed by Darin Adler.
1338
1339         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1340         focus, or showing the font manager.
1341
1342         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1343         (TestWebKitAPI::TEST):
1344         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1345         (TEST):
1346         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1347         (TestWebKitAPI::TEST):
1348
1349 2019-04-21  Brian Burg  <bburg@apple.com>
1350
1351         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1352         https://bugs.webkit.org/show_bug.cgi?id=197125
1353         <rdar://problem/50061468>
1354
1355         Reviewed by Darin Adler.
1356
1357         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1358         using this class rather than making our own ./wpt serve invocation.
1359
1360         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1361         (WebDriverW3CWebServer):
1362         (WebDriverW3CWebServer.document_root): Expose this to clients.
1363         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1364
1365         (WebDriverW3CWebServer.__enter__):
1366         (WebDriverW3CWebServer.__exit__):
1367         Make it possible to use the web server with a 'with' statement.
1368
1369 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1370
1371         [CMake][Win] Use target oriented design for WebKitLegacy
1372         https://bugs.webkit.org/show_bug.cgi?id=197112
1373
1374         Reviewed by Konstantin Tokarev.
1375
1376         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1377
1378         * DumpRenderTree/CMakeLists.txt:
1379         * DumpRenderTree/PlatformWin.cmake:
1380         * DumpRenderTree/win/EventSender.cpp:
1381
1382 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1383
1384         Update text for old EWS submit button
1385         https://bugs.webkit.org/show_bug.cgi?id=197140
1386
1387         Reviewed by Alexey Proskuryakov.
1388
1389         * QueueStatusServer/templates/statusbubble.html:
1390
1391 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1392
1393         [ews-app] New EWS should poll bugzilla more frequently
1394         https://bugs.webkit.org/show_bug.cgi?id=197138
1395
1396         Reviewed by Alexey Proskuryakov.
1397
1398         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1399         (FetchLoop.__init__):
1400
1401 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1402
1403         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1404         https://bugs.webkit.org/show_bug.cgi?id=197139
1405
1406         Reviewed by Alexey Proskuryakov.
1407
1408         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1409         * QueueStatusServer/templates/statusbubble.html:
1410
1411 2019-04-20  Chris Dumez  <cdumez@apple.com>
1412
1413         Unreviewed, fix iOS build with recent SDKs.
1414
1415         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1416
1417 2019-04-19  Keith Miller  <keith_miller@apple.com>
1418
1419         Add script to merge run_benchmark jsons
1420         https://bugs.webkit.org/show_bug.cgi?id=197107
1421
1422         Reviewed by Michael Saboff.
1423
1424         The script basically recursively decends through all json objects until it gets
1425         to an array or JSON primitive and concats or takes the first value, respectively.
1426
1427         This patch also adds +x bits to the compare-results script so it
1428         can be run directly from the command line. I had to add a new line so that svn
1429         will accept the change... yay svn!
1430
1431         * Scripts/compare-results:
1432         * Scripts/merge-result-jsons: Added.
1433         (readJSONFile):
1434         (deepAppend):
1435         (mergeJSONs):
1436         (main):
1437
1438 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1439
1440         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1441         https://bugs.webkit.org/show_bug.cgi?id=197079
1442
1443         Reviewed by Darin Adler.
1444
1445         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1446
1447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1448         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1449
1450 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1451
1452         Unreviewed, rolling out r244434.
1453         https://bugs.webkit.org/show_bug.cgi?id=197089
1454
1455         caused 1 API test failure (Requested by zalan on #webkit).
1456
1457         Reverted changeset:
1458
1459         "Regression (r244291): Broken API Test
1460         AutoLayoutRenderingProgressRelativeOrdering"
1461         https://bugs.webkit.org/show_bug.cgi?id=196948
1462         https://trac.webkit.org/changeset/244434
1463
1464 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1465
1466         Add new compatibility mode API on WKNavigation
1467         https://bugs.webkit.org/show_bug.cgi?id=197069
1468         <rdar://problem/50025800>
1469
1470         Reviewed by Tim Horton.
1471
1472         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1473
1474         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1475         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1476         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1477
1478 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1479
1480         [CMake] Make WebCore headers copies
1481         https://bugs.webkit.org/show_bug.cgi?id=182512
1482         <rdar://problem/37510435>
1483
1484         Reviewed by Alex Christensen.
1485
1486         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1487         ports.
1488
1489         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1490         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1491
1492         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1493         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1494         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1495         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1496         * TestWebKitAPI/CMakeLists.txt:
1497         * TestWebKitAPI/PlatformWin.cmake:
1498         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1499         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1500         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1501
1502 2019-04-18  Jer Noble  <jer.noble@apple.com>
1503
1504         Add support for parsing FairPlayStreaming PSSH boxes.
1505         https://bugs.webkit.org/show_bug.cgi?id=197064
1506
1507         Reviewed by Eric Carlson.
1508
1509         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1510         (TestWebKitAPI::TEST):
1511
1512 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1513
1514         InjectedBundle parameters often need initialization function called before unarchiving
1515         https://bugs.webkit.org/show_bug.cgi?id=189709
1516         <rdar://problem/44573653>
1517
1518         Reviewed by Ryosuke Niwa.
1519
1520         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1521         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1522
1523 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1524
1525         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1526         https://bugs.webkit.org/show_bug.cgi?id=196948
1527         <rdar://problem/49927131>
1528
1529         Reviewed by Tim Horton.
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1532         (TEST): 
1533         The expected order of incoming events is
1534         1. didInvalidateIntrinsicContentSize
1535         2. didFirstLayout
1536         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1537         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1538         (and remember, all we care about is ordering).
1539
1540 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1541
1542         Unreviewed, rolling out r244299.
1543
1544         Breaks internal tests.
1545
1546         Reverted changeset:
1547
1548         "InjectedBundle parameters often need initialization function
1549         called before unarchiving"
1550         https://bugs.webkit.org/show_bug.cgi?id=189709
1551         https://trac.webkit.org/changeset/244299
1552
1553 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1554
1555         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1556         https://bugs.webkit.org/show_bug.cgi?id=197053
1557
1558         Reviewed by Saam Barati.
1559
1560         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1561         (TestWebKitAPI::TEST):
1562
1563 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1564
1565         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1566         https://bugs.webkit.org/show_bug.cgi?id=197028
1567         <rdar://problem/49985290>
1568
1569         Reviewed by Wenson Hsieh.
1570
1571         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1572         (TEST):
1573         Liberal application of waitForNextPresentationUpdate works around a race
1574         where if the page rapidly changes its viewport arguments (or an API client
1575         rapidly changes its viewport arguments), we'd get stuck thinking that the
1576         user had intentionally zoomed the page, and stop resetting the initial scale.
1577         This deserves a separate bug, but no need to keep the test failing while
1578         we think about it.
1579
1580 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1581
1582         REGRESSION (r241988): Switching tabs is slow
1583         https://bugs.webkit.org/show_bug.cgi?id=197037
1584         <rdar://problem/49951473>
1585
1586         Reviewed by Simon Fraser.
1587
1588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1589         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1590         (TEST):
1591         * TestWebKitAPI/cocoa/TestWKWebView.h:
1592         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1593         (-[TestWKWebView addToTestWindow]):
1594         Add a test that hangs without this fix.
1595
1596 2019-04-17  Truitt Savell  <tsavell@apple.com>
1597
1598         Unreviewed, rolling out r244400.
1599
1600         Caused testing to exit early with assertionon Debug WK2
1601
1602         Reverted changeset:
1603
1604         "UI↔Web deadlock when printing with a JavaScript alert
1605         visible"
1606         https://bugs.webkit.org/show_bug.cgi?id=196839
1607         https://trac.webkit.org/changeset/244400
1608
1609 2019-04-17  Brady Eidson  <beidson@apple.com>
1610
1611         Link clicks in PDFs shouldn't send referrer headers.
1612         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1613
1614         Reviewed by Tim Horton.
1615
1616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1617         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1618         (putPDFBytesCallback):
1619         (emptyReleaseInfoCallback):
1620         (createPDFWithLinkToURL):
1621         (TEST):
1622
1623 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1624
1625         UI↔Web deadlock when printing with a JavaScript alert visible
1626         https://bugs.webkit.org/show_bug.cgi?id=196839
1627         <rdar://problem/49157642>
1628
1629         Reviewed by Andy Estes.
1630
1631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1632         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1633         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1634         (TEST):
1635
1636 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1637
1638         WKRetainPtr's adoption constructor should be private
1639         https://bugs.webkit.org/show_bug.cgi?id=197019
1640
1641         Reviewed by Tim Horton.
1642
1643         * DumpRenderTree/mac/DumpRenderTree.mm:
1644         (dumpFramesAsText):
1645         * TestWebKitAPI/InjectedBundleController.cpp:
1646         (TestWebKitAPI::InjectedBundleController::initialize):
1647         * TestWebKitAPI/PlatformUtilities.cpp:
1648         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1649         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1650         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1651         (TestWebKitAPI::Util::toWK):
1652         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1653         (TestWebKitAPI::TEST):
1654         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1657         (TestWebKitAPI::TEST):
1658         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1659         (TestWebKitAPI::TEST):
1660         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1661         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1662         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1663         (TestWebKitAPI::TEST):
1664         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1665         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1666         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1667         (TestWebKitAPI::TEST):
1668         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1669         (TestWebKitAPI::TEST):
1670         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1671         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1672         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1673         (TestWebKitAPI::TEST):
1674         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1675         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1676         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1677         (TestWebKitAPI::TEST):
1678         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1679         (TestWebKitAPI::TEST):
1680         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1681         (TestWebKitAPI::TEST):
1682         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1683         (TestWebKitAPI::TEST):
1684         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1685         (TestWebKitAPI::TEST):
1686         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1687         (TestWebKitAPI::TEST):
1688         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1689         (TestWebKitAPI::TEST):
1690         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1691         (TestWebKitAPI::TEST):
1692         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1693         (TestWebKitAPI::TEST):
1694         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1695         (TestWebKitAPI::TEST):
1696         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1697         (TestWebKitAPI::TEST):
1698         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1699         (TestWebKitAPI::TEST):
1700         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1701         (TestWebKitAPI::TEST):
1702         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1703         (TestWebKitAPI::TEST):
1704         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1705         (TestWebKitAPI::TEST):
1706         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1707         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1708         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1709         (TestWebKitAPI::TEST):
1710         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1711         (TestWebKitAPI::TEST):
1712         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1713         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1714         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1715         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1716         (TestWebKitAPI::TEST):
1717         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1718         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1719         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1720         (TestWebKitAPI::TEST):
1721         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1722         (TestWebKitAPI::TEST):
1723         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1724         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1725         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1726         (TestWebKitAPI::TEST):
1727         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1728         (TestWebKitAPI::loadAlternateHTMLString):
1729         (TestWebKitAPI::TEST):
1730         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1731         (TestWebKitAPI::TEST):
1732         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1733         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1734         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1735         (TestWebKitAPI::buildAndPerformTest):
1736         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1737         (TestWebKitAPI::TEST):
1738         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1739         (TestWebKitAPI::TEST):
1740         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1741         (TestWebKitAPI::TEST):
1742         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1743         (TestWebKitAPI::TEST):
1744         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1745         (TestWebKitAPI::TEST):
1746         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1747         (TestWebKitAPI::TEST):
1748         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1749         (TestWebKitAPI::TEST):
1750         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1751         (TestWebKitAPI::TEST):
1752         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1753         (TestWebKitAPI::TEST):
1754         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1755         (TestWebKitAPI::TEST):
1756         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1757         (TestWebKitAPI::TEST):
1758         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1759         (TestWebKitAPI::TEST):
1760         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1761         (TestWebKitAPI::TEST):
1762         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1765         (TestWebKitAPI::TEST):
1766         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1767         (TestWebKitAPI::TEST):
1768         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1771         (TestWebKitAPI::TEST):
1772         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1773         (TestWebKitAPI::TEST):
1774         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1775         (TestWebKitAPI::TEST):
1776         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1777         (TestWebKitAPI::TEST):
1778         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1779         (TestWebKitAPI::TEST):
1780         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1781         (TestWebKitAPI::TEST):
1782         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1783         (TestWebKitAPI::TEST):
1784         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1785         (TestWebKitAPI::TEST):
1786         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1787         (TestWebKitAPI::TEST):
1788         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1791         (TestWebKitAPI::TEST):
1792         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1793         (TestWebKitAPI::TEST):
1794         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1795         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1796         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1799         (TestWebKitAPI::TEST):
1800         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1801         (TestWebKitAPI::TEST):
1802         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1803         (TestWebKitAPI::TEST):
1804         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1805         (TestWebKitAPI::TEST):
1806         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1807         (TestWebKitAPI::TEST):
1808         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1809         (TestWebKitAPI::TEST):
1810         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1811         (TestWebKitAPI::TEST):
1812         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1813         (TestWebKitAPI::TEST):
1814         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1815         (TestWebKitAPI::TEST):
1816         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1818         (TEST):
1819         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1820         (TEST):
1821         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1822         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1823         (TEST):
1824         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1825         (TestWebKitAPI::TEST):
1826         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1827         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1828         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1829         (WTR::getMenuItemTitleCallback):
1830         (WTR::createMouseMessageBody):
1831         (WTR::EventSendingController::mouseDown):
1832         (WTR::EventSendingController::mouseUp):
1833         (WTR::EventSendingController::mouseMoveTo):
1834         (WTR::EventSendingController::mouseForceClick):
1835         (WTR::EventSendingController::startAndCancelMouseForceClick):
1836         (WTR::EventSendingController::mouseForceDown):
1837         (WTR::EventSendingController::mouseForceUp):
1838         (WTR::EventSendingController::mouseForceChanged):
1839         (WTR::EventSendingController::leapForward):
1840         (WTR::EventSendingController::scheduleAsynchronousClick):
1841         (WTR::createKeyDownMessageBody):
1842         (WTR::EventSendingController::keyDown):
1843         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1844         (WTR::EventSendingController::mouseScrollBy):
1845         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1846         (WTR::EventSendingController::continuousMouseScrollBy):
1847         (WTR::EventSendingController::addTouchPoint):
1848         (WTR::EventSendingController::updateTouchPoint):
1849         (WTR::EventSendingController::setTouchModifier):
1850         (WTR::EventSendingController::setTouchPointRadius):
1851         (WTR::EventSendingController::touchStart):
1852         (WTR::EventSendingController::touchMove):
1853         (WTR::EventSendingController::touchEnd):
1854         (WTR::EventSendingController::touchCancel):
1855         (WTR::EventSendingController::clearTouchPoints):
1856         (WTR::EventSendingController::releaseTouchPoint):
1857         (WTR::EventSendingController::cancelTouchPoint):
1858         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1859         (WTR::InjectedBundle::didCreatePage):
1860         (WTR::InjectedBundle::didReceiveMessage):
1861         (WTR::InjectedBundle::didReceiveMessageToPage):
1862         (WTR::InjectedBundle::booleanForKey):
1863         (WTR::InjectedBundle::done):
1864         (WTR::InjectedBundle::dumpToStdErr):
1865         (WTR::InjectedBundle::outputText):
1866         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1867         (WTR::InjectedBundle::postAddChromeInputField):
1868         (WTR::InjectedBundle::postRemoveChromeInputField):
1869         (WTR::InjectedBundle::postFocusWebView):
1870         (WTR::InjectedBundle::postSetBackingScaleFactor):
1871         (WTR::InjectedBundle::postSetWindowIsKey):
1872         (WTR::InjectedBundle::postSetViewSize):
1873         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1874         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1875         (WTR::InjectedBundle::setGeolocationPermission):
1876         (WTR::InjectedBundle::setMockGeolocationPosition):
1877         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1878         (WTR::InjectedBundle::isGeolocationProviderActive const):
1879         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1880         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1881         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1882         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1883         (WTR::InjectedBundle::setCustomPolicyDelegate):
1884         (WTR::InjectedBundle::setHidden):
1885         (WTR::InjectedBundle::setCacheModel):
1886         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1887         (WTR::InjectedBundle::processWorkQueue):
1888         (WTR::InjectedBundle::queueBackNavigation):
1889         (WTR::InjectedBundle::queueForwardNavigation):
1890         (WTR::InjectedBundle::queueLoad):
1891         (WTR::InjectedBundle::queueLoadHTMLString):
1892         (WTR::InjectedBundle::queueReload):
1893         (WTR::InjectedBundle::queueLoadingScript):
1894         (WTR::InjectedBundle::queueNonLoadingScript):
1895         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1896         (WTR::frameToStr):
1897         (WTR::InjectedBundlePage::InjectedBundlePage):
1898         (WTR::dumpFrameDescriptionSuitableForTestResult):
1899         (WTR::dumpFrameScrollPosition):
1900         (WTR::dumpDescendantFrameScrollPositions):
1901         (WTR::dumpFrameText):
1902         (WTR::dumpDescendantFramesText):
1903         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1904         (WTR::TestRunner::shouldDumpPixels const):
1905         (WTR::TestRunner::setDumpPixels):
1906         (WTR::TestRunner::whatToDump const):
1907         (WTR::TestRunner::setWhatToDump):
1908         (WTR::TestRunner::setWaitUntilDone):
1909         (WTR::TestRunner::shouldWaitUntilDone const):
1910         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1911         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1912         (WTR::TestRunner::clearAllDatabases):
1913         (WTR::TestRunner::setIDBPerOriginQuota):
1914         (WTR::TestRunner::originsWithApplicationCache):
1915         (WTR::TestRunner::setCanOpenWindows):
1916         (WTR::TestRunner::setXSSAuditorEnabled):
1917         (WTR::TestRunner::setMediaDevicesEnabled):
1918         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1919         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1920         (WTR::TestRunner::setCustomUserAgent):
1921         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1922         (WTR::TestRunner::setModernMediaControlsEnabled):
1923         (WTR::TestRunner::setWebGL2Enabled):
1924         (WTR::TestRunner::setWritableStreamAPIEnabled):
1925         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1926         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1927         (WTR::TestRunner::setAllowsAnySSLCertificate):
1928         (WTR::TestRunner::setPluginsEnabled):
1929         (WTR::TestRunner::setValueForUser):
1930         (WTR::TestRunner::setAudioResult):
1931         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1932         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1933         (WTR::TestRunner::setAlwaysAcceptCookies):
1934         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1935         (WTR::TestRunner::isDoingMediaCapture const):
1936         (WTR::TestRunner::queueLoad):
1937         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1938         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1939         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1940         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1941         (WTR::TestRunner::setAuthenticationUsername):
1942         (WTR::TestRunner::setAuthenticationPassword):
1943         (WTR::TestRunner::secureEventInputIsEnabled const):
1944         (WTR::TestRunner::setBlockAllPlugins):
1945         (WTR::TestRunner::setPluginSupportedMode):
1946         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1947         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1948         (WTR::TestRunner::setNavigationGesturesEnabled):
1949         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1950         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1951         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1952         (WTR::TestRunner::terminateNetworkProcess):
1953         (WTR::TestRunner::terminateServiceWorkerProcess):
1954         (WTR::TestRunner::runUIScript):
1955         (WTR::TestRunner::setStatisticsDebugMode):
1956         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1957         (WTR::TestRunner::setStatisticsLastSeen):
1958         (WTR::TestRunner::setStatisticsPrevalentResource):
1959         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1960         (WTR::TestRunner::dumpResourceLoadStatistics):
1961         (WTR::TestRunner::isStatisticsPrevalentResource):
1962         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1963         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1964         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1965         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1966         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1967         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1968         (WTR::TestRunner::setStatisticsGrandfathered):
1969         (WTR::TestRunner::isStatisticsGrandfathered):
1970         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1971         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1972         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1973         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1974         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1975         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1976         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1977         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1978         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1979         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1980         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1981         (WTR::TestRunner::statisticsSubmitTelemetry):
1982         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1983         (WTR::TestRunner::setStatisticsIsRunningTest):
1984         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1985         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1986         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1987         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1988         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1989         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1990         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1991         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1992         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1993         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1994         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1995         (WTR::TestRunner::statisticsResetToConsistentState):
1996         (WTR::TestRunner::setStorageAccessAPIEnabled):
1997         (WTR::TestRunner::getAllStorageAccessEntries):
1998         (WTR::TestRunner::addMockMediaDevice):
1999         (WTR::TestRunner::clearMockMediaDevices):
2000         (WTR::TestRunner::removeMockMediaDevice):
2001         (WTR::TestRunner::resetMockMediaDevices):
2002         (WTR::TestRunner::connectMockGamepad):
2003         (WTR::TestRunner::disconnectMockGamepad):
2004         (WTR::TestRunner::setMockGamepadDetails):
2005         (WTR::TestRunner::setMockGamepadAxisValue):
2006         (WTR::TestRunner::setMockGamepadButtonValue):
2007         (WTR::TestRunner::removeAllSessionCredentials):
2008         (WTR::TestRunner::clearDOMCache):
2009         (WTR::TestRunner::clearDOMCaches):
2010         (WTR::TestRunner::hasDOMCache):
2011         (WTR::TestRunner::domCacheSize):
2012         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2013         (WTR::TestRunner::getApplicationManifestThen):
2014         (WTR::TestRunner::injectUserScript):
2015         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2016         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2017         (WTR::TestRunner::addTestKeyToKeychain):
2018         (WTR::TestRunner::cleanUpKeychain):
2019         (WTR::TestRunner::keyExistsInKeychain):
2020         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2021         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2022         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2023         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2024         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2025         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2026         * WebKitTestRunner/TestController.cpp:
2027         (WTR::TestController::initialize):
2028         (WTR::parseStringTestHeaderValueAsRelativePath):
2029         (WTR::updateTestOptionsFromTestHeader):
2030         (WTR::TestController::runTest):
2031         (WTR::TestController::didReceiveLiveDocumentsList):
2032         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2033         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2034         (WTR::TestController::didFinishNavigation):
2035         (WTR::TestController::didReceiveAuthenticationChallenge):
2036         * WebKitTestRunner/TestInvocation.cpp:
2037         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2038         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2039         (WTR::TestInvocation::uiScriptDidComplete):
2040         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2041         * WebKitTestRunner/WebNotificationProvider.cpp:
2042         (WTR::WebNotificationProvider::closeWebNotification):
2043         * WebKitTestRunner/WorkQueueManager.cpp:
2044         (WTR::ScriptItem::ScriptItem):
2045         (WTR::WorkQueueManager::queueLoad):
2046         (WTR::WorkQueueManager::queueLoadHTMLString):
2047
2048 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2049
2050         Add a comment to make my test from r244139 less mysterious.
2051         https://bugs.webkit.org/show_bug.cgi?id=196744
2052
2053         As suggested by Darin Adler.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2056         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2057
2058 2019-04-17  Chris Dumez  <cdumez@apple.com>
2059
2060         Remember device orientation permission for the duration of the browsing session
2061         https://bugs.webkit.org/show_bug.cgi?id=196992
2062         <rdar://problem/49946067>
2063
2064         Reviewed by Alex Christensen.
2065
2066         Add API test coverage.
2067
2068         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2069         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2070         (TEST):
2071
2072 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2073
2074         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2075         https://bugs.webkit.org/show_bug.cgi?id=196675
2076
2077         Reviewed by Lucas Forschler.
2078
2079         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2080         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2081
2082 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2083
2084         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2085         https://bugs.webkit.org/show_bug.cgi?id=196919
2086         <rdar://problem/41630459>
2087
2088         Reviewed by Tim Horton.
2089
2090         Add iOS support for several new testing hooks. See below for more detail.
2091
2092         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2093         (WTR::UIScriptController::isDismissingMenu const):
2094
2095         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2096         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2097         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2098
2099         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2100         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2101         (WTR::UIScriptController::isDismissingMenu const):
2102         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2103         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2104         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2105         (WTR::InjectedBundle::didReceiveMessageToPage):
2106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2107         (WTR::TestRunner::setAllowedMenuActions):
2108
2109         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2110         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2111         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2112         against the name of the custom action.
2113
2114         (WTR::TestRunner::installCustomMenuAction):
2115
2116         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2117         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2118         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2119         triggered.
2120
2121         (WTR::TestRunner::performCustomMenuAction):
2122
2123         Invoked when the custom menu action is triggered.
2124
2125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2126         * WebKitTestRunner/TestController.cpp:
2127         (WTR::TestController::installCustomMenuAction):
2128         (WTR::TestController::setAllowedMenuActions):
2129         * WebKitTestRunner/TestController.h:
2130         * WebKitTestRunner/TestInvocation.cpp:
2131         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2132         (WTR::TestInvocation::performCustomMenuAction):
2133
2134         Add plumbing to call back into the injected bundle when performing the custom action.
2135
2136         * WebKitTestRunner/TestInvocation.h:
2137         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2138         (WTR::TestController::installCustomMenuAction):
2139         (WTR::TestController::setAllowedMenuActions):
2140         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2141         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2142         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2143         (-[TestRunnerWKWebView becomeFirstResponder]):
2144         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2145
2146         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2147         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2148         in the Mail app on iOS.
2149
2150         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2151         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2152         (-[TestRunnerWKWebView resetCustomMenuAction]):
2153         (-[TestRunnerWKWebView performCustomAction:]):
2154         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2155         (-[TestRunnerWKWebView _willHideMenu]):
2156         (-[TestRunnerWKWebView _didHideMenu]):
2157         * WebKitTestRunner/ios/TestControllerIOS.mm:
2158         (WTR::TestController::platformResetStateToConsistentValues):
2159
2160         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2161         if specified.
2162
2163         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2164         (WTR::UIScriptController::isDismissingMenu const):
2165
2166 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2167
2168         Allow sharing from imageSheet on an image document
2169         https://bugs.webkit.org/show_bug.cgi?id=196891
2170         <rdar://problem/25377386>
2171
2172         Reviewed by Tim Horton.
2173
2174         Test to make sure that the correct imageURL is extracted from an image element.
2175
2176         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2177         (TestWebKitAPI::TEST):
2178
2179 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2180
2181         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2182         https://bugs.webkit.org/show_bug.cgi?id=196995
2183
2184         Reviewed by Brady Eidson.
2185
2186         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2187         (TEST):
2188
2189 2019-04-16  Chris Dumez  <cdumez@apple.com>
2190
2191         URL set by document.open() is not communicated to the UIProcess
2192         https://bugs.webkit.org/show_bug.cgi?id=196941
2193         <rdar://problem/49237544>
2194
2195         Reviewed by Geoff Garen.
2196
2197         Add API test coverage.
2198
2199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2200         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2201         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2202         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2203         (TEST):
2204
2205 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2206
2207         Unreviewed, rolling out r244321.
2208         https://bugs.webkit.org/show_bug.cgi?id=196968
2209
2210         Causing all WK2 Debug builds to exit early after Assertion
2211         failures. (Requested by ShawnRoberts on #webkit).
2212
2213         Reverted changeset:
2214
2215         "URL set by document.open() is not communicated to the
2216         UIProcess"
2217         https://bugs.webkit.org/show_bug.cgi?id=196941
2218         https://trac.webkit.org/changeset/244321
2219
2220 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2221
2222         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2223         https://bugs.webkit.org/show_bug.cgi?id=196948
2224
2225         Reviewed by Zalan Bujtas.
2226
2227         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2228         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2229
2230 2019-04-15  Chris Dumez  <cdumez@apple.com>
2231
2232         URL set by document.open() is not communicated to the UIProcess
2233         https://bugs.webkit.org/show_bug.cgi?id=196941
2234         <rdar://problem/49237544>
2235
2236         Reviewed by Geoffrey Garen.
2237
2238         Add API test coverage.
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2242         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2243         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2244         (TEST):
2245
2246 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2247
2248         Using Tools/Scripts/clean-webkit should not install requests
2249         https://bugs.webkit.org/show_bug.cgi?id=196940
2250
2251         Reviewed by Lucas Forschler.
2252
2253         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2254         existing, depending on the path autoinstalled is run through.
2255         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2256         needed.
2257         (Port.configuration_for_upload):
2258         (Port.commits_for_upload):
2259
2260 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2261
2262         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2263         https://bugs.webkit.org/show_bug.cgi?id=196773
2264
2265         Reviewed by Jer Noble.
2266
2267         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2268         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2269         (TEST):
2270
2271 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2272
2273         ews-build should clearly indicate flaky test failures
2274         https://bugs.webkit.org/show_bug.cgi?id=196947
2275
2276         Reviewed by Lucas Forschler.
2277
2278         * BuildSlaveSupport/ews-build/steps.py:
2279         (AnalyzeAPITestsResults.analyzeResults):
2280
2281 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2282
2283         InjectedBundle parameters often need initialization function called before unarchiving
2284         https://bugs.webkit.org/show_bug.cgi?id=189709
2285         <rdar://problem/44573653>
2286
2287         Reviewed by Ryosuke Niwa.
2288
2289         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2290         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2291
2292 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2293
2294         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2295         https://bugs.webkit.org/show_bug.cgi?id=196681
2296
2297         Reviewed by Darin Adler.
2298
2299         Added tests.
2300
2301         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2302         (WTF_HashSet.RemoveIf):
2303         (WTF_HashSet.RemoveIfShrinkToBestSize):
2304
2305 2019-04-15  John Wilander  <wilander@apple.com>
2306
2307         Send delayed Ad Click Attribution conversion requests to the click source
2308         https://bugs.webkit.org/show_bug.cgi?id=196838
2309         <rdar://problem/47650157>
2310
2311         Reviewed by Chris Dumez and Youenn Fablet.
2312
2313         This patch adds test infrastructure to override the default behavior in
2314         WebKit::NetworkAdClickAttribution.
2315
2316         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2317         (TestWebKitAPI::TEST):
2318         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2320         (WTR::TestRunner::dumpAdClickAttribution):
2321         (WTR::TestRunner::clearAdClickAttribution):
2322         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2323         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2324         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2325         * WebKitTestRunner/TestController.cpp:
2326         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2327         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2328         * WebKitTestRunner/TestController.h:
2329         * WebKitTestRunner/TestInvocation.cpp:
2330         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2331
2332 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2333
2334         [ews-app] status-bubble should display position in queue
2335         https://bugs.webkit.org/show_bug.cgi?id=196607
2336
2337         Reviewed by Lucas Forschler.
2338
2339         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2340         (StatusBubble._build_bubble):
2341         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2342
2343 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-build] Do not run clean build by default on EWS builders
2346         https://bugs.webkit.org/show_bug.cgi?id=196897
2347
2348         Reviewed by Lucas Forschler.
2349
2350         * BuildSlaveSupport/ews-build/steps.py:
2351         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2352         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2353         untracked directories like WebKitBuild).
2354         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2355         untracked files/directories (like WebKitBuild).
2356
2357 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2358
2359         TestRunner::notifyDone() should be safely reentrant
2360         https://bugs.webkit.org/show_bug.cgi?id=196898
2361
2362         Reviewed by Darin Adler.
2363
2364         It is currently possible that TestRunner::notifyDone() will call itself, since
2365         notifyDone() will force a repaint, which can start executing JavaScript, which
2366         may call notifyDone() again. This can lead to test failures and flakiness.
2367         Fix this by setting the m_waitToDump flag before calling the dump() method.
2368
2369         * DumpRenderTree/mac/TestRunnerMac.mm:
2370         (TestRunner::notifyDone):
2371         (TestRunner::forceImmediateCompletion):
2372         * DumpRenderTree/win/TestRunnerWin.cpp:
2373         (TestRunner::notifyDone):
2374         (TestRunner::forceImmediateCompletion):
2375
2376 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2377
2378         [GTK][WPE] Add enable-media websetting
2379         https://bugs.webkit.org/show_bug.cgi?id=196863
2380
2381         Reviewed by Michael Catanzaro.
2382
2383         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2384         (testWebKitSettings): Add test for the enable-media web-setting.
2385
2386 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2387
2388         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2389         https://bugs.webkit.org/show_bug.cgi?id=196905
2390         <rdar://problem/49886096>
2391
2392         Reviewed by Tim Horton.
2393
2394         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2395         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2396         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2397         delay timer, we end up with this sequence of events in the problematic (failure) case:
2398
2399         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2400             ...IPC from UI to web process...
2401         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2402             ...IPC from web to UI process...
2403         (c) [UI]    Invoke completion handler for script #1
2404         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2405             ...IPC from UI to web process...
2406         (e) [Web]   Evaluate script #2 in the web process
2407         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2408
2409         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2410         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2411         #2 is run in step (e).
2412
2413         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2414         the UI process by waiting on a script message posted by the web process, after attachment updates are
2415         dispatched.
2416
2417         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2418         (TestWebKitAPI::TEST):
2419
2420 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2421
2422         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2423         https://bugs.webkit.org/show_bug.cgi?id=196909
2424
2425         Reviewed by Wenson Hsieh.
2426
2427         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2428         (TestWebKitAPI::TEST):
2429
2430 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2431
2432         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2433         https://bugs.webkit.org/show_bug.cgi?id=196880
2434
2435         Reviewed by Yusuke Suzuki.
2436
2437         Add a new function for bytecode cache tests that does not forceDiskCache
2438         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2439         test added in this patch, since the code is invalid and therefore won't be
2440         cached. It should also be useful for tests that evaluate dynamically
2441         generated code.
2442
2443         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2444         * Scripts/run-jsc-stress-tests:
2445
2446 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2447
2448         Update AudioSession route sharing policy
2449         https://bugs.webkit.org/show_bug.cgi?id=196776
2450         <rdar://problem/46501611>
2451
2452         Reviewed by Jer Noble.
2453
2454         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2455         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2456         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2457         (TestWebKitAPI::TEST):
2458
2459 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2460
2461         [iOS] Software keyboard is shown too frequently on some websites
2462         https://bugs.webkit.org/show_bug.cgi?id=195856
2463         <rdar://problem/49191395>
2464
2465         Reviewed by Darin Adler.
2466
2467         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2468
2469         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2470         (WTR::UIScriptController::setHardwareKeyboardAttached):
2471         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2472         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2473         (WTR::UIScriptController::setHardwareKeyboardAttached):
2474         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2475         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2476
2477         Additionally link against GraphicsServices in WebKitTestRunner.
2478
2479         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2480         (WTR::TestController::platformResetStateToConsistentValues):
2481         (WTR::UIScriptController::setHardwareKeyboardAttached):
2482
2483 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2484
2485         [GTK][WPE] Fix pacman install-dependencies packages
2486         https://bugs.webkit.org/show_bug.cgi?id=196817
2487
2488         Reviewed by Žan Doberšek.
2489         
2490         python3-setuptools is called python-setuptools
2491         ruby-highline is only available on AUR
2492         libv4l-devel is incorporated in v4l-utils
2493
2494         * gtk/install-dependencies:
2495         * wpe/install-dependencies:
2496
2497 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2498
2499         [GTK] REGRESSION(r243860): Many tests failing
2500         https://bugs.webkit.org/show_bug.cgi?id=196791
2501
2502         Reviewed by Joanmarie Diggs.
2503
2504         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2505         multiple documents and check that accessibility hierarchy is updated after a navigation.
2506
2507         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2508         (loadChangedCallback):
2509         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2510         (AccessibilityTest::AccessibilityTest):
2511         (AccessibilityTest::~AccessibilityTest):
2512         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2513         (AccessibilityTest::findTestServerApplication):
2514         (AccessibilityTest::findDocumentWeb):
2515         (AccessibilityTest::findRootObject):
2516         (AccessibilityTest::waitUntilChildrenRemoved):
2517         (AccessibilityTest::ensureProxy):
2518         (testAtspiBasicHierarchy):
2519         (beforeAll):
2520         (afterAll):
2521
2522 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2523
2524         [ews-build] Handle bug titles with unicode characters
2525         https://bugs.webkit.org/show_bug.cgi?id=196802
2526
2527         Reviewed by Dewei Zhu.
2528
2529         * BuildSlaveSupport/ews-build/steps.py:
2530         (ValidatePatch._is_bug_closed):
2531
2532 2019-04-11  Michael Saboff  <msaboff@apple.com>
2533
2534         Improve the Inline Cache Stats code
2535         https://bugs.webkit.org/show_bug.cgi?id=196836
2536
2537         Reviewed by Saam Barati.
2538
2539         Added a new script to consolidate and arrange the output of --useICStats option.
2540
2541         This script merges the output from every group into one large table and sorts it from most common to
2542         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2543         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2544         Put together, this is useful to see what property accesses are not getting cached.
2545
2546         * Scripts/ic-stats.py: Added.
2547         (ICStats):
2548         (ICStats.__init__):
2549         (ICStats.parse):
2550         (ICStats.dumpStats):
2551         (usage):
2552
2553 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2554
2555         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2556         https://bugs.webkit.org/show_bug.cgi?id=196809
2557         <rdar://49800762>
2558
2559         Reviewed by Brady Eidson.
2560
2561         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2562         (TEST):
2563
2564 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2565
2566         requestAnimationFrame should execute before the next frame
2567         https://bugs.webkit.org/show_bug.cgi?id=177484
2568
2569         Reviewed by Simon Fraser.
2570
2571         Add trace points for the page RenderingUpdate.
2572
2573         * Tracing/SystemTracePoints.plist:
2574
2575 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2576
2577         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2578         https://bugs.webkit.org/show_bug.cgi?id=196760
2579
2580         Reviewed by Don Olmstead.
2581
2582         vswhere.exe has been bundled since Visual Studio 2017 version
2583         15.2. We shouldn't download vswhere.exe.
2584
2585         * Scripts/build-jsc: Do not call update-vswhere.py.
2586         * Scripts/build-webkit: Ditto.
2587         * Scripts/update-vswhere.py: Removed.
2588         * Scripts/webkitdirs.pm:
2589         (requireModulesForVSWhere): Deleted.
2590         (pickCurrentVisualStudioInstallation): Deleted.
2591         (visualStudioInstallDirVSWhere): Return the latest installed VS
2592         installation path by using the bundled vswhere.exe.
2593         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2594         (visualStudioInstallDirFallback): Removed.
2595
2596 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2597
2598         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2599         https://bugs.webkit.org/show_bug.cgi?id=196780
2600
2601         Reviewed by Alexey Proskuryakov.
2602
2603         * BuildSlaveSupport/ews-build/steps.py:
2604         * BuildSlaveSupport/ews-build/steps_unittest.py:
2605
2606 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2607
2608         Add SPI WKNavigationResponse._downloadAttribute
2609         https://bugs.webkit.org/show_bug.cgi?id=196755
2610         <rdar://49587365>
2611
2612         Reviewed by Brady Eidson.
2613
2614         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2615         (-[NavigationResponseTestDelegate navigationResponse]):
2616         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2617         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2618         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2619         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2620         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2621         (readRequest):
2622         (writeResponse):
2623         (TEST):
2624
2625 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2626
2627         Add modern API for overriding the page's specified viewport configuration
2628         https://bugs.webkit.org/show_bug.cgi?id=167734
2629         <rdar://problem/30331795>
2630
2631         Reviewed by Simon Fraser.
2632
2633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2634         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2635
2636 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2637
2638         Add support for incremental bytecode cache updates
2639         https://bugs.webkit.org/show_bug.cgi?id=195000
2640
2641         Reviewed by Filip Pizlo.
2642
2643         Exit when the initial run to generate bytecode fails.
2644
2645         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2646
2647 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2648
2649         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2650         https://bugs.webkit.org/show_bug.cgi?id=196744
2651         <rdar://49415309>
2652
2653         Reviewed by Chris Dumez.
2654
2655         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2656         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2657
2658 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2659
2660         Add a way to opt into modern compatibility mode in layout tests
2661         https://bugs.webkit.org/show_bug.cgi?id=196770
2662         <rdar://problem/49777550>
2663
2664         Reviewed by Antoine Quint.
2665
2666         Add a new test option to enable modern compatibility mode in layout tests.
2667
2668         * WebKitTestRunner/TestController.cpp:
2669         (WTR::updateTestOptionsFromTestHeader):
2670         * WebKitTestRunner/TestController.h:
2671         * WebKitTestRunner/TestOptions.h:
2672         (WTR::TestOptions::hasSameInitializationOptions const):
2673         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2674         (WTR::TestController::platformCreateWebView):
2675         (WTR::TestController::enableModernCompatibilityMode):
2676
2677 2019-04-10  Andy Estes  <aestes@apple.com>
2678
2679         Try to fix the 32-bit watchOS build.
2680
2681         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2682         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2683
2684 2019-04-10  Antoine Quint  <graouts@apple.com>
2685
2686         Enable Pointer Events on watchOS
2687         https://bugs.webkit.org/show_bug.cgi?id=196771
2688         <rdar://problem/49040909>
2689
2690         Reviewed by Dean Jackson.
2691
2692         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2693
2694 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2695
2696         Unreviewed. Fix WPE accessibility tests after r244059.
2697
2698         We are failing to load the injected bundle due to undefined symbol
2699         AccessibilityUIElement::replaceTextInRange().
2700
2701         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2702         (WTR::AccessibilityUIElement::replaceTextInRange):
2703
2704 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2705
2706         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2707         https://bugs.webkit.org/show_bug.cgi?id=196727
2708
2709         Reviewed by Fujii Hironori.
2710
2711         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2712         (WebKitBrowserWindow::create):
2713
2714 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2715
2716         [ews-build] Add unit tests for PrintConfiguration
2717         https://bugs.webkit.org/show_bug.cgi?id=196752
2718
2719         Reviewed by Dewei Zhu.
2720
2721         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2722
2723 2019-04-09  Keith Rollin  <krollin@apple.com>
2724
2725         Unreviewed build maintenance -- update .xcfilelists.
2726
2727         * DumpRenderTree/DerivedSources-input.xcfilelist:
2728         * DumpRenderTree/DerivedSources-output.xcfilelist:
2729
2730 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2731
2732         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2733         https://bugs.webkit.org/show_bug.cgi?id=196743
2734         <rdar://problem/43897551>
2735
2736         Reviewed by Tim Horton.
2737
2738         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2739         (TEST):
2740
2741 2019-04-09  Youenn Fablet  <youenn@apple.com>
2742
2743         Close service worker database on network process suspension
2744         https://bugs.webkit.org/show_bug.cgi?id=196623
2745         <rdar://problem/48930869>
2746
2747         Reviewed by Alex Christensen.
2748
2749         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2750
2751 2019-04-09  Daniel Bates  <dabates@apple.com>
2752
2753         [iPad] Should open popover when the spacebar is pressed
2754         https://bugs.webkit.org/show_bug.cgi?id=196360
2755         <rdar://problem/49389129>
2756
2757         Reviewed by Brent Fulgham.
2758
2759         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2760
2761         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2762         (WTR::UIScriptController::isShowingPopover const): Added.
2763         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2764         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2765         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2766         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2767         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2768         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2769         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2770         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2771         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2772         (WTR::UIScriptController::isShowingPopover const): Added.
2773         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2774         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2775         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2776         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2777         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2778         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2779         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2780         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2781         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2782         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2783         (WTR::UIScriptController::isShowingPopover const): Added.
2784         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2785         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2786
2787 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2788
2789         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2790         https://bugs.webkit.org/show_bug.cgi?id=196665
2791         <rdar://45115669>
2792
2793         Reviewed by Geoff Garen.
2794
2795         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2796         (goBack):
2797         (+[SimpleLookupContext sharedLookupContext]):
2798         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2799         (TEST):
2800         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2801         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2802
2803 2019-04-09  John Wilander  <wilander@apple.com>
2804
2805         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2806         https://bugs.webkit.org/show_bug.cgi?id=196558
2807         <rdar://problem/47650245>
2808
2809         Reviewed by Youenn Fablet.
2810
2811         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2812         (TestWebKitAPI::TEST):
2813             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2814
2815 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2816
2817         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2818         https://bugs.webkit.org/show_bug.cgi?id=196720
2819
2820         Reviewed by Konstantin Tokarev.
2821
2822         * TestWebKitAPI/PlatformMac.cmake:
2823
2824 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2825
2826         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2827         https://bugs.webkit.org/show_bug.cgi?id=196694
2828         <rdar://problem/48388734>
2829
2830         Rubber-stamped by Aakash Jain.
2831
2832         * Scripts/webkitpy/port/image_diff.py:
2833         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2834         * Scripts/webkitpy/port/server_process.py:
2835         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2836         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2837         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2838         * Scripts/webkitpy/port/server_process_mock.py:
2839         (MockServerProcess.has_available_stdout):
2840         * Scripts/webkitpy/port/server_process_unittest.py:
2841         (TestServerProcess.serial_test_basic):
2842
2843 2019-04-09  Jer Noble  <jer.noble@apple.com>
2844
2845         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2846         https://bugs.webkit.org/show_bug.cgi?id=196097
2847
2848         Reviewed by Eric Carlson.
2849
2850         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2851
2852         * DumpRenderTree/mac/DumpRenderTree.mm:
2853         (resetWebPreferencesToConsistentValues):
2854         * WebKitTestRunner/TestController.cpp:
2855         (WTR::TestController::resetPreferencesToConsistentValues):
2856
2857 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2858
2859         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2860         https://bugs.webkit.org/show_bug.cgi?id=196690
2861
2862         Reviewed by Michael Catanzaro.
2863
2864         * QueueStatusServer/config/queues.py:
2865         * Scripts/webkitpy/common/config/ews.json:
2866         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2867         (test_ews_name):
2868
2869 2019-04-09  Chris Dumez  <cdumez@apple.com>
2870
2871         Loads using loadHTMLString() cause flashing when process-swapping
2872         https://bugs.webkit.org/show_bug.cgi?id=196714
2873         <rdar://problem/49637354>
2874
2875         Reviewed by Antti Koivisto.
2876
2877         Add API test coverage.
2878
2879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2880
2881 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2882
2883         Unreviewed. Fix ATK accessibility tests after r244059.
2884
2885         We are failing to load the injected bundle due to undefined symbol
2886         AccessibilityUIElement::replaceTextInRange().
2887
2888         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2889         (WTR::AccessibilityUIElement::replaceTextInRange):
2890
2891 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2892
2893         AX: Support API: accessibilityReplaceRange:withText
2894         https://bugs.webkit.org/show_bug.cgi?id=196636
2895
2896         Unreviewed build fix for Windows port.
2897
2898         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2899         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2900
2901 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2902
2903         [CMake][WinCairo] Separate copied headers into different directories
2904         https://bugs.webkit.org/show_bug.cgi?id=196655
2905
2906         Reviewed by Michael Catanzaro.
2907
2908         * DumpRenderTree/CMakeLists.txt:
2909         * MiniBrowser/win/CMakeLists.txt:
2910         * TestWebKitAPI/CMakeLists.txt:
2911         * TestWebKitAPI/PlatformWin.cmake:
2912
2913 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2914
2915         Log stack-trace for run-webkit-tests when interrupted
2916         https://bugs.webkit.org/show_bug.cgi?id=176393
2917         <rdar://problem/34262310>
2918
2919         Reviewed by Lucas Forschler.
2920
2921         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2922         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2923         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2924         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2925         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2926         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2927         (main): Set handlers to log stack trace on interruption.
2928
2929 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2930
2931         AX: Support API: accessibilityReplaceRange:withText
2932         https://bugs.webkit.org/show_bug.cgi?id=196636
2933
2934         Unreviewed build fix for Windows port.
2935
2936         * DumpRenderTree/AccessibilityUIElement.cpp:
2937         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2938
2939 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2940
2941         [ews-build] Scripts using Buildbot API have CORS error
2942         https://bugs.webkit.org/show_bug.cgi?id=196709
2943
2944         Reviewed by Alexey Proskuryakov.
2945
2946         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2947
2948 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2949
2950         AX: Support API: accessibilityReplaceRange:withText
2951         https://bugs.webkit.org/show_bug.cgi?id=196636
2952
2953         Reviewed by Daniel Bates.
2954
2955         * DumpRenderTree/AccessibilityUIElement.cpp:
2956         (replaceTextInRangeCallback):
2957         (AccessibilityUIElement::replaceTextInRange):
2958         (AccessibilityUIElement::getJSClass):
2959         * DumpRenderTree/AccessibilityUIElement.h:
2960         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2961         (AccessibilityUIElement::replaceTextInRange):
2962         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2963         (AccessibilityUIElement::replaceTextInRange):
2964         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2965         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2966         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2967         (WTR::AccessibilityUIElement::replaceTextInRange):
2968         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2969         (WTR::AccessibilityUIElement::replaceTextInRange):
2970
2971 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2972
2973         [iOS] Do not allow starting selection drags when selection views are not visible
2974         https://bugs.webkit.org/show_bug.cgi?id=196686
2975         <rdar://problem/49399192>
2976
2977         Reviewed by Tim Horton.
2978
2979         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2980         also add some new API tests to cover scenarios where the web view is not first responder.
2981
2982         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2983         (TestWebKitAPI::TEST):
2984         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2985
2986         Add a switch to optionally make the web view first responder when starting the simulated drag.
2987
2988         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2989         (-[DragAndDropSimulator initWithWebView:]):
2990         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2991
2992 2019-04-08  Justin Fan  <justin_fan@apple.com>
2993
2994         [Web GPU] Fix Web GPU experimental feature on iOS
2995         https://bugs.webkit.org/show_bug.cgi?id=196632
2996
2997         Reviewed by Myles C. Maxfield.
2998
2999         Properly make Web GPU available on iOS 11+.
3000
3001         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3002
3003 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3004
3005         [ews-build] Do not upload archive when Compile Fails
3006         https://bugs.webkit.org/show_bug.cgi?id=196674
3007
3008         Reviewed by Alexey Proskuryakov.
3009
3010         * BuildSlaveSupport/ews-build/factories.py:
3011         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3012         * BuildSlaveSupport/ews-build/steps.py:
3013         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3014         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3015         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3016
3017 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3018
3019         Enable DFG on MIPS
3020         https://bugs.webkit.org/show_bug.cgi?id=196689
3021
3022         Reviewed by Žan Doberšek.
3023
3024         Since the bytecode change, we enabled the baseline JIT on mips in
3025         r240432, but DFG is still missing. With this change, all tests are
3026         passing on a ci20 board.
3027
3028         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3029
3030 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3031
3032         [Flatpak] Second run update-webkitwpe-flatpak fails
3033         https://bugs.webkit.org/show_bug.cgi?id=192702
3034
3035         Reviewed by Carlos Garcia Campos.
3036
3037         * flatpak/flatpakutils.py:
3038         (FlatpakObject.flatpak): Fix typo.
3039         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3040         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3041
3042 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3043
3044         [GTK][WPE] outlook.live.com displays old-fashioned UI
3045         https://bugs.webkit.org/show_bug.cgi?id=196642
3046
3047         Reviewed by Carlos Garcia Campos.
3048
3049         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3050         (TestWebKitAPI::TEST): New Mac platform quirk test.
3051
3052 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3053
3054         Unreviewed, rolling out r243956.
3055         https://bugs.webkit.org/show_bug.cgi?id=196688
3056
3057         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3058         by aakashjain on #webkit).
3059
3060         Reverted changeset:
3061
3062         "Clicking "Go Back" from a safe browsing warning from an
3063         iframe should navigate the WKWebView back to the previous
3064         page"
3065         https://bugs.webkit.org/show_bug.cgi?id=196665
3066         https://trac.webkit.org/changeset/243956
3067
3068 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3071         https://bugs.webkit.org/show_bug.cgi?id=196669
3072
3073         Reviewed by Geoffrey Garen.
3074
3075         Added three new unit tests for WeakHashSet.
3076
3077         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3078         (WTF_WeakPtr.WeakHashSetConstObjects):
3079         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3080         (WTF_WeakPtr.WeakHashSetComputeSize):
3081
3082 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3083
3084         Hide next and previous form control buttons when WKWebView is editable
3085         https://bugs.webkit.org/show_bug.cgi?id=196672
3086         <rdar://problem/35625321>
3087
3088         Reviewed by Tim Horton.
3089
3090         Add a new API test.
3091
3092         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3093         (-[TestWKWebView lastTrailingBarButtonGroup]):
3094         (TestWebKitAPI::TEST):
3095         * TestWebKitAPI/ios/UIKitSPI.h:
3096
3097 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3098
3099         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3100         https://bugs.webkit.org/show_bug.cgi?id=196077
3101         <rdar://problem/49108202>
3102
3103         Reviewed by Chris Dumez.
3104
3105         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3106         on new web view.
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3109
3110 2019-04-05  Saam Barati  <sbarati@apple.com>
3111
3112         Make compare-results understand MotionMark
3113         https://bugs.webkit.org/show_bug.cgi?id=196666
3114
3115         Reviewed by Yusuke Suzuki.
3116
3117         * Scripts/compare-results:
3118         (PLT5Results):
3119         (detectMotionMark):
3120         (detectMotionMark1_1):
3121         (motionMarkResults):
3122         (motionMark1_1Results):
3123         (detectBenchmark):
3124         (biggerIsBetter):
3125         (main):
3126
3127 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3128
3129         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3130         https://bugs.webkit.org/show_bug.cgi?id=196665
3131         <rdar://45115669>
3132
3133         Reviewed by Geoff Garen.
3134
3135         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3136         (goBack):
3137         (+[SimpleLookupContext sharedLookupContext]):
3138         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3139         (TEST):
3140         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3141         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3142
3143 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3144
3145         [ews-build] Add configuration and architecture for windows builders
3146         https://bugs.webkit.org/show_bug.cgi?id=196660
3147
3148         Reviewed by Lucas Forschler.
3149
3150         * BuildSlaveSupport/ews-build/config.json:
3151
3152 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3153
3154         webkitpy: Don't run subsequent rounds if interrupted
3155         https://bugs.webkit.org/show_bug.cgi?id=196646
3156
3157         Reviewed by Aakash Jain.
3158
3159         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3160         (Manager.run): Bail out if interrupted.
3161
3162 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3163
3164         Test sessionStorage in PSON private browsing mode
3165         https://bugs.webkit.org/show_bug.cgi?id=196561
3166
3167         Reviewed by Alex Christensen.
3168
3169         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3170
3171 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3172
3173         Unreviewed, rolling out r243833.
3174         https://bugs.webkit.org/show_bug.cgi?id=196645
3175
3176         This change breaks build of WPE and GTK ports (Requested by
3177         annulen on #webkit).
3178
3179         Reverted changeset:
3180
3181         "[CMake][WTF] Mirror XCode header directories"
3182         https://bugs.webkit.org/show_bug.cgi?id=191662
3183         https://trac.webkit.org/changeset/243833
3184
3185 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3186
3187         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3188         https://bugs.webkit.org/show_bug.cgi?id=196635
3189
3190         Reviewed by Antti Koivisto.
3191         
3192         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3193         for a test to enable async frame scrolling via:
3194             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3195         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3196         
3197         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3198
3199         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3200         (WTR::InjectedBundle::beginTesting):
3201         * WebKitTestRunner/TestController.cpp:
3202         (WTR::TestController::resetPreferencesToConsistentValues):
3203
3204 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3205
3206         Use a correct LC_RPATH when building with ASan
3207         https://bugs.webkit.org/show_bug.cgi?id=196576
3208
3209         Reviewed by David Kilzer.
3210
3211         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3212         so that ../Frameworks is checked. This is simpler and more reliable than updating
3213         each SPC service xcconfig.
3214
3215 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3216
3217         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3218         https://bugs.webkit.org/show_bug.cgi?id=196629
3219
3220         Reviewed by Lucas Forschler.
3221
3222         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3223
3224 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3225
3226         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3227         https://bugs.webkit.org/show_bug.cgi?id=196618
3228
3229         Reviewed by Lucas Forschler.
3230
3231         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3232         (StatusBubble): Added QUEUE_TRIGGERS.
3233         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3234         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3235         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3236         its parent(builder).
3237
3238 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3239
3240         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3241         https://bugs.webkit.org/show_bug.cgi?id=196625
3242
3243         Reviewed by Lucas Forschler.
3244
3245         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3246         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3247
3248 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3249
3250         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3251         https://bugs.webkit.org/show_bug.cgi?id=196630
3252
3253         Reviewed by Wenson Hsieh.
3254
3255         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3256
3257 2019-04-04  Youenn Fablet  <youenn@apple.com>
3258
3259         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3260         https://bugs.webkit.org/show_bug.cgi?id=196543
3261
3262         Reviewed by Alex Christensen.
3263
3264         * WebKitTestRunner/TestController.cpp:
3265         (WTR::TestController::generatePageConfiguration):
3266
3267 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3268
3269         [ews-app] Status bubble should not display skipped buildbot steps
3270         https://bugs.webkit.org/show_bug.cgi?id=196584
3271
3272         Reviewed by Lucas Forschler.
3273
3274         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3275
3276 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3277
3278         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3279         https://bugs.webkit.org/show_bug.cgi?id=196620
3280
3281         Reviewed by Lucas Forschler.
3282
3283         * BuildSlaveSupport/ews-app/ews/config.py:
3284
3285 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3286
3287         [Win] DumpRenderTreeWatchDog.py is not checked into source
3288         https://bugs.webkit.org/show_bug.cgi?id=196567
3289         <rdar://problem/49525901>
3290
3291         Reviewed by Lucas Forschler.
3292
3293         This script is used on Win EWS bots to terminate hanging DRT processes.
3294
3295         * EWSTools/dumprendertreewatchdog.py: Added.
3296
3297 2019-04-04  Chris Dumez  <cdumez@apple.com>
3298
3299         Unreviewed, roll out r243858 which made tests time out.
3300
3301         Disable new API tests on Windows instead.
3302
3303         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3304         (TestWebKitAPI::TEST):
3305
3306 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         [ATK] Cleanup WebPageAccessibilityObjectAtk
3309         https://bugs.webkit.org/show_bug.cgi?id=196537
3310
3311         Reviewed by Michael Catanzaro.
3312
3313         Also consider files under atk directories as exceptions for GObject conventions.
3314
3315         * Scripts/webkitpy/style/checkers/cpp.py:
3316         (check_identifier_name_in_declaration):
3317
3318 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3319
3320         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3321         https://bugs.webkit.org/show_bug.cgi?id=196588
3322         <rdar://problem/49365787>
3323
3324         Unreviewed build fix for Windows port.
3325
3326         error C3861: 'kill': identifier not found
3327
3328         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3329         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3330
3331 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3332
3333         [ews-build] Cancel build and similar operations should have authentication
3334         https://bugs.webkit.org/show_bug.cgi?id=196520
3335
3336         Reviewed by Dewei Zhu.
3337
3338         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3339         environment variables.
3340
3341 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews-build] Do not trigger queues which are not in production yet
3344         https://bugs.webkit.org/show_bug.cgi?id=196581
3345
3346         Reviewed by Dewei Zhu.
3347
3348         * BuildSlaveSupport/ews-build/config.json:
3349
3350 2019-04-03  Chris Dumez  <cdumez@apple.com>
3351
3352         Unreviewed, fix typo in the name of API test added in r243848.
3353
3354         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3355         (TestWebKitAPI::TEST):
3356
3357 2019-04-03  Chris Dumez  <cdumez@apple.com>
3358
3359         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3360         https://bugs.webkit.org/show_bug.cgi?id=196588
3361         <rdar://problem/49365787>
3362
3363         Reviewed by Ryosuke Niwa.
3364
3365         Add API test coverage.
3366
3367         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3368         (TestWebKitAPI::nullJavaScriptCallback):
3369         (TestWebKitAPI::didCrashCheckFrames):
3370         (TestWebKitAPI::TEST):
3371
3372 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3373
3374         run-webkit-tests: Upload test results (new results database)
3375         https://bugs.webkit.org/show_bug.cgi?id=196577
3376         <rdar://problem/34841155>
3377
3378         Reviewed by Lucas Forschler.
3379
3380         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3381         (Manager.run): Upload results after each device shard, since the configuration will be
3382         different for each device.
3383         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3384         uploaded to a results database.
3385         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3386         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3387
3388 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3389
3390         -apple-trailing-word is needed for browser detection
3391         https://bugs.webkit.org/show_bug.cgi?id=196575
3392
3393         Unreviewed.
3394
3395         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3396
3397 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3398
3399         [CMake][WTF] Mirror XCode header directories
3400         https://bugs.webkit.org/show_bug.cgi?id=191662
3401
3402         Reviewed by Konstantin Tokarev.
3403
3404         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3405         builds.
3406
3407         * CMakeLists.txt:
3408         * DumpRenderTree/CMakeLists.txt:
3409         * DumpRenderTree/PlatformWin.cmake:
3410         * MiniBrowser/win/CMakeLists.txt:
3411         * TestWebKitAPI/CMakeLists.txt:
3412         * TestWebKitAPI/PlatformWin.cmake:
3413         * WebKitTestRunner/PlatformGTK.cmake:
3414         * WebKitTestRunner/PlatformWin.cmake:
3415
3416 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3417
3418         [ews-app] Status bubble should not display certain infrastructure status messages
3419         https://bugs.webkit.org/show_bug.cgi?id=196550
3420
3421         Reviewed by Lucas Forschler.
3422
3423         Do not display the steps which are un-needed for end-user. This information is still avaiable
3424         if the user click on the bubble and look at the Buildbot build.
3425         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3426         (StatusBubble._steps_messages):
3427         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3428
3429 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3430
3431         [ews-build] Use https for sending data to ews-app
3432         https://bugs.webkit.org/show_bug.cgi?id=196492
3433
3434         Reviewed by Lucas Forschler.
3435
3436         * BuildSlaveSupport/ews-build/events.py:
3437
3438 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3439
3440         Remove support for -apple-trailing-word
3441         https://bugs.webkit.org/show_bug.cgi?id=196525
3442
3443         Reviewed by Zalan Bujtas.
3444
3445         This CSS property is nonstandard and not used.
3446
3447         * Scripts/webkitperl/FeatureList.pm:
3448         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3449
3450 2019-04-03  Youenn Fablet  <youenn@apple.com>
3451
3452         Add a test for DOMCache on multiple browsing in case of private browsing
3453         https://bugs.webkit.org/show_bug.cgi?id=196524
3454
3455         Reviewed by Alex Christensen.
3456
3457         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3458         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3459
3460 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3461
3462         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3463         https://bugs.webkit.org/show_bug.cgi?id=196540
3464
3465         Reviewed by Aakash Jain.
3466
3467         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3468
3469 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3470
3471         Add plumbing for a compatibility mode preference in WebKit
3472         https://bugs.webkit.org/show_bug.cgi?id=196005
3473
3474         Reviewed by Tim Horton.
3475
3476         Add new API tests.
3477
3478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3479         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3480
3481 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3482
3483         [WPE][GTK] Update libsrtp dependency package for Debian
3484         https://bugs.webkit.org/show_bug.cgi?id=196528
3485
3486         Reviewed by Frédéric Wang.
3487
3488         * gtk/install-dependencies:
3489         * wpe/install-dependencies:
3490
3491 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3492
3493         [WK2] Add support for Window's beforeprint / afterprint events
3494         https://bugs.webkit.org/show_bug.cgi?id=196478
3495         <rdar://problem/49535124>
3496
3497         Unreviewed build fix for MSVC.
3498
3499         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3500
3501         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3502
3503         * WebKitTestRunner/TestController.cpp:
3504         (WTR::printFrame): Use int and float literals.
3505
3506 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3507
3508         [ews-build] Reassign bots to queues
3509
3510         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3511
3512 2019-04-02  Chris Dumez  <cdumez@apple.com>
3513
3514         [WK2] Add support for Window's beforeprint / afterprint events
3515         https://bugs.webkit.org/show_bug.cgi?id=196478
3516
3517         Reviewed by Alex Christensen.
3518
3519         Add minimal implementation for printFrame in WebKitTestRunner.
3520
3521         * WebKitTestRunner/TestController.cpp:
3522         (WTR::printFrame):
3523         (WTR::TestController::createOtherPage):
3524         (WTR::TestController::createWebViewWithOptions):
3525
3526 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3527
3528         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3529         https://bugs.webkit.org/show_bug.cgi?id=196491
3530
3531         Reviewed by Lucas Forschler.
3532
3533         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3534
3535 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3536
3537         [ews-build] Configure buildbot try credentials in environment variables
3538         https://bugs.webkit.org/show_bug.cgi?id=196501
3539
3540         Reviewed by Lucas Forschler.
3541
3542         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3543         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3544         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3545
3546 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3547
3548         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3549         https://bugs.webkit.org/show_bug.cgi?id=196496
3550         <rdar://problem/49521634>
3551
3552         Reviewed by Chris Dumez.
3553
3554         Add new API tests (see WebKit ChangeLog for more detail).
3555
3556         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3557         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3558         (TEST):
3559
3560 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3561
3562         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3563         <https://webkit.org/b/196499>
3564
3565         Reviewed by Alexey Proskuryakov.
3566
3567         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3568         ENABLE_ADDRESS_SANITIZER.
3569
3570 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3571
3572         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3573         https://bugs.webkit.org/show_bug.cgi?id=182757
3574
3575         Reviewed by Don Olmstead.
3576
3577         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3578         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3579
3580 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3581
3582         run-api-tests: Upload test results
3583         https://bugs.webkit.org/show_bug.cgi?id=196323
3584         <rdar://problem/49356714>
3585
3586         Reviewed by Lucas Forschler.
3587
3588         * Scripts/webkitpy/api_tests/manager.py:
3589         (Manager):
3590         (Manager.run): Upload results to a results database.
3591         * Scripts/webkitpy/api_tests/run_api_tests.py:
3592         (parse_args): Add upload arguments.
3593         * Scripts/webkitpy/port/base.py:
3594         (Port):
3595         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3596         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3597         with commits from any other associated repositories.
3598         * Scripts/webkitpy/port/device.py:
3599         (Device):
3600         (Device.build_version): Access build_versoin of underlying platform device.
3601         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3602         (IOSSimulatorTest):
3603         (IOSSimulatorTest.test_configuration_for_upload):
3604         * Scripts/webkitpy/port/device_port.py:
3605         (DevicePort):
3606         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3607         the same as the machine uploading results.
3608         * Scripts/webkitpy/port/mac.py:
3609         (MacPort):
3610         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3611         * Scripts/webkitpy/port/mac_unittest.py:
3612         (MacTest):
3613         (MacTest.test_configuration_for_upload):
3614         * Scripts/webkitpy/xcode/simulated_device.py:
3615         (SimulatedDeviceManager._create_device_with_runtime):
3616         (SimulatedDevice.__init__): Create simulated device with a build_version.
3617         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3618         (test_existing_simulator):
3619
3620 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3621
3622         Remove extra newline characters (Follow-up fix to r243707)
3623
3624         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3625
3626 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3627
3628         [ews-app] Use API_KEY to accept results data
3629         https://bugs.webkit.org/show_bug.cgi?id=196461
3630
3631         Reviewed by Dewei Zhu.
3632
3633         * BuildSlaveSupport/ews-app/ews/views/results.py:
3634         (Results.post): Validate EWS_API_KEY before accepting any data.
3635         * BuildSlaveSupport/ews-build/events.py:
3636         (Events.sendData): Send EWS_API_KEY if available along with event data.
3637
3638 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3639
3640         Unable to copy and paste a PDF from Notes into Mail compose body
3641         https://bugs.webkit.org/show_bug.cgi?id=196442
3642         <rdar://problem/48573098>
3643
3644         Reviewed by Tim Horton.
3645
3646         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3647         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3648         to be specified on the item providers.
3649
3650         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3651         (TestWebKitAPI::mapItemForTesting):
3652         (TestWebKitAPI::contactItemForTesting):
3653
3654 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3655
3656         Make UIWKDocumentContext rects per-character instead of per-word
3657         https://bugs.webkit.org/show_bug.cgi?id=196459
3658
3659         Reviewed by Wenson Hsieh.
3660
3661         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3662         (TEST):
3663         Adjust test results due to switching to per-character rects.
3664
3665 2019-04-01  Chris Dumez  <cdumez@apple.com>
3666