Fix bug in MediaTime comparison for negative values with different scale.
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-05  Alicia Boya García  <aboya@igalia.com>
2
3         Fix bug in MediaTime comparison for negative values with different scale.
4         https://bugs.webkit.org/show_bug.cgi?id=182433
5
6         Improved test coverage for MediaTime::compare().
7
8         Reviewed by Xabier Rodriguez-Calvar.
9
10         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
11         (TestWebKitAPI::TEST):
12
13 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
14
15         [SOUP] WebSockets must use system proxy settings
16         https://bugs.webkit.org/show_bug.cgi?id=126384
17
18         Reviewed by Michael Catanzaro.
19
20         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
21
22         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
23         (ProxyTest::webSocketProxyServerCallback):
24         (ProxyTest::ProxyTest):
25         (ProxyTest::webSocketConnected):
26         (ProxyTest::createWebSocketAndWaitUntilConnected):
27         (webSocketServerCallback):
28         (testWebContextProxySettings):
29         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
30         (WebKitTestServer::~WebKitTestServer):
31         (WebKitTestServer::addWebSocketHandler):
32         (WebKitTestServer::removeWebSocketHandler):
33         (WebKitTestServer::getWebSocketURIForPath const):
34         (WebKitTestServer::getURIForPath const):
35         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
36         (WebKitTestServer::baseURI const):
37         (WebKitTestServer::baseWebSocketURI const):
38
39 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         Add a way to check if a host is an IP address
42         https://bugs.webkit.org/show_bug.cgi?id=182427
43
44         Reviewed by Alex Christensen.
45
46         Add unit test for URL::hostIsIPAddress().
47
48         * TestWebKitAPI/Tests/WebCore/URL.cpp:
49         (TestWebKitAPI::TEST_F):
50
51 2018-02-03  Charlie Turner  <cturner@igalia.com>
52
53         Add libmount to WPE dependencies
54         https://bugs.webkit.org/show_bug.cgi?id=182345
55
56         Reviewed by Michael Catanzaro.
57
58         * wpe/install-dependencies:
59
60 2018-02-02  Youenn Fablet  <youenn@apple.com>
61
62         W3C test exporter should allow exporting newly added files
63         https://bugs.webkit.org/show_bug.cgi?id=182369
64
65         Reviewed by Ryosuke Niwa.
66
67         * Scripts/webkitpy/common/checkout/scm/git.py:
68         (Git.apply_mail_patch):
69
70 2018-02-02  David Quesada  <david_quesada@apple.com>
71
72         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
73         https://bugs.webkit.org/show_bug.cgi?id=182363
74         rdar://problem/37093498
75
76         Reviewed by Ryosuke Niwa.
77
78         Updated ApplicationManifestParserTests to account for the new default scope behavior.
79
80         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
81         (assertManifestHasDefaultValues):
82         (TEST_F):
83
84 2018-02-02  Youenn Fablet  <youenn@apple.com>
85
86         Clearing all service worker registrations should wait for importing service worker registration to finish
87         https://bugs.webkit.org/show_bug.cgi?id=182407
88
89         Reviewed by Chris Dumez.
90
91         Make sure we finish clearing service worker registrations before running tests.
92
93         * WebKitTestRunner/TestController.cpp:
94         (WTR::TestController::resetStateToConsistentValues):
95         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
96         (WTR::clearServiceWorkerRegistrationsCallback):
97         (WTR::TestController::clearServiceWorkerRegistrations):
98         * WebKitTestRunner/TestController.h:
99
100 2018-02-02  Youenn Fablet  <youenn@apple.com>
101
102         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
103         https://bugs.webkit.org/show_bug.cgi?id=182403
104
105         Reviewed by Alex Christensen.
106
107         * WebKitTestRunner/TestController.cpp:
108         (WTR::TestController::generateContextConfiguration const):
109         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
110         (WTR::initializeWebViewConfiguration):
111
112 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
113
114         [GTK] WebDriver: tests step always times out in the bot
115         https://bugs.webkit.org/show_bug.cgi?id=182437
116
117         Reviewed by Carlos Alberto Lopez Perez.
118
119         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
120         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
121
122         * Scripts/run-webdriver-tests: Call teardown() after run().
123         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
124         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
125         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
126         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
127         the display driver once and pass it to the test runners.
128         (WebDriverTestRunner.teardown): Stop the display server.
129         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
130         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
131         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
132         (WebDriverTestRunnerSelenium.run): Ditto.
133         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
134         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
135         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
136         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
137         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
138
139 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
140
141         Unreviewed, rolling out r227999.
142
143         It didn't fix the problem
144
145         Reverted changeset:
146
147         "Unreviewed. Try to avoid webdriver tests step timing out in
148         the bots."
149         https://trac.webkit.org/changeset/227999
150
151 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
152
153         Start timeout for the run-buildbot-test script is too aggressive
154         https://bugs.webkit.org/show_bug.cgi?id=182429
155
156         Reviewed by Carlos Garcia Campos.
157
158         15 seconds is not enough waiting for the update database process
159         to complete on a system backed with rotational HDDs. Raise it to 60.
160
161         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
162         (wait_for_master_ready):
163
164 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
165
166         re-add ARM JSCOnly bots on buildbot waterfall
167         https://bugs.webkit.org/show_bug.cgi?id=182428
168
169         Reviewed by Csaba Osztrogonác.
170
171         * BuildSlaveSupport/build.webkit.org-config/config.json:
172         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
173
174 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
175
176         Remove ARM JSCOnly bots from buildbot waterfall
177         https://bugs.webkit.org/show_bug.cgi?id=182398
178
179         Reviewed by Alexey Proskuryakov.
180
181         * BuildSlaveSupport/build.webkit.org-config/config.json:
182         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
183
184 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
185
186         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
187
188         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
189         workaround for a bug in python2.7 when using multiprocess module.
190
191         * Scripts/run-webdriver-tests:
192
193 2018-02-01  Youenn Fablet  <youenn@apple.com>
194
195         Delay service worker process creation until actually needed by SWServer
196         https://bugs.webkit.org/show_bug.cgi?id=182301
197
198         Reviewed by Chris Dumez.
199
200         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
201         (function):
202
203 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
204
205         Bubbles intermittently disappear from bot watchers dashboard
206         https://bugs.webkit.org/show_bug.cgi?id=182085
207
208         Reviewed by Alexey Proskuryakov.
209
210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
211         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
212         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
213         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
214
215 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
216
217         [GTK] Problem with Washington Post images
218         https://bugs.webkit.org/show_bug.cgi?id=181421
219
220         Reviewed by Carlos Alberto Lopez Perez.
221
222         Add test case for the new user agent quirk.
223
224         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
225         (TestWebKitAPI::TEST):
226
227 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
228
229         [GTK] MiniBrowser settings are just a list of names
230         https://bugs.webkit.org/show_bug.cgi?id=182005
231
232         Reviewed by Sergio Villar Senin.
233
234         The default size we are using is too small to show the values column, and the window is not resizable because
235         GObjectClass::constructed() is not called in the parent class.
236
237         * MiniBrowser/gtk/BrowserSettingsDialog.c:
238         (browser_settings_dialog_init): Use 600x400 as default size.
239         (browserSettingsDialogConstructed): Chain up to parent constructed.
240
241 2018-01-31  Andres Gomez  <agomez@igalia.com>
242
243         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
244
245         * Scripts/webkitpy/common/config/watchlist:
246
247 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
248
249         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
250         https://bugs.webkit.org/show_bug.cgi?id=181204
251         <rdar://problem/36256274>
252
253         Reviewed by Ryosuke Niwa.
254
255         Implement 'testRunner.forceImmediateCompletion()' for WK1.
256
257         * DumpRenderTree/TestRunner.cpp:
258         (forceImmediateCompletionCallback):
259         (TestRunner::staticFunctions):
260
261 2018-01-31  Alex Christensen  <achristensen@webkit.org>
262
263         Unreviewed, rolling out r227942.
264
265         r227875 should not have been rolled out.
266
267         Reverted changeset:
268
269         "Unreviewed, rolling out r227875."
270         https://bugs.webkit.org/show_bug.cgi?id=182357
271         https://trac.webkit.org/changeset/227942
272
273 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
274
275         Unreviewed, rolling out r227875.
276         https://bugs.webkit.org/show_bug.cgi?id=182357
277
278         Missing cross-platform TestController implementation
279
280         Reverted changeset:
281
282         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
283         https://bugs.webkit.org/show_bug.cgi?id=181958
284         https://trac.webkit.org/changeset/227875
285
286         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
288         (WTR::InjectedBundle::didReceiveMessageToPage):
289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
290         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
291         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
292         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
294         * WebKitTestRunner/TestInvocation.cpp:
295         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
296         * WebKitTestRunner/TestInvocation.h:
297         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
298         (WTR::TestController::statisticsUpdateCookiePartitioning):
299         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
300
301 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
302
303         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
304         https://bugs.webkit.org/show_bug.cgi?id=182222
305
306         Reviewed by Alex Christensen.
307
308         Use the new API to notify when resource load statistics deletion is complete.
309
310         * WebKitTestRunner/TestController.cpp:
311         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
312         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
313         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
314
315 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
316
317         Add the support for running StyleBench to run-benchmark
318         https://bugs.webkit.org/show_bug.cgi?id=182323
319
320         Reviewed by Antti Koivisto.
321
322         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
323
324         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
325         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
326
327 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
328
329         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
330         https://bugs.webkit.org/show_bug.cgi?id=182339
331         <rdar://problem/36041396>
332
333         Reviewed by Andy Estes.
334
335         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
336         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
337         check against the length of the data written.
338
339         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
340         (testIconImageData):
341         (runTestWithTemporaryFolder):
342         (TestWebKitAPI::TEST):
343
344 2018-01-31  Dan Bernstein  <mitz@apple.com>
345
346         [macOS] MiniBrowser isn’t app-sandboxed
347         https://bugs.webkit.org/show_bug.cgi?id=182147
348
349         Reviewed by Sam Weinig.
350
351         Enable App Sandbox and add a temporary exception allowing read access to all files.
352
353         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
354         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
355         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
356           and read access from /.
357         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
358
359 2018-01-31  Philippe Normand  <pnormand@igalia.com>
360
361         [JHBuild] Add gstreamer-vaapi in moduleset
362         https://bugs.webkit.org/show_bug.cgi?id=182283
363
364         Reviewed by Carlos Alberto Lopez Perez.
365
366         GStreamer-VAAPI is required for hardware-accelerated video
367         playback support on Intel and AMD (using radeosi driver)
368         platforms.
369
370         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
371         * gtk/install-dependencies: Install libva.
372         * wpe/install-dependencies: Ditto.
373         * Scripts/webkitpy/port/gtk.py:
374         (GtkPort.setup_environ_for_server): Disable va-api support when
375         testing because it's incompatible with Mesa's softGL driver.
376
377 2018-01-31  Charlie Turner  <cturner@igalia.com>
378
379         [WPE] Update jhbuild dependencies
380         https://bugs.webkit.org/show_bug.cgi?id=182286
381
382         This upgrades the following packages,
383         glib 2.44.1 -> 2.54.3
384         glib-networking 2.42.0 -> 2.54.1
385         libsoup 2.48.0 -> 2.60.3
386
387         The initial reason for performing these upgrades was that when
388         visiting https://youtube.com, WPE was getting TLS certificate
389         errors. After upgrading glib-networking, these were fixed, but the
390         upgrade introduced dependencies on newer versions of the other
391         packages upgraded in this commit.
392
393         The upgrade to glib caused a linking error in gstreamer, the
394         following errors were being logged during linking,
395
396         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
397         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
398         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
399
400         This was fixed by adding the glib package built in the jhbuild to
401         harfbuzz.
402
403         Finally, the upgrade of glib caused the glib-warning-fix.patch to
404         no longer apply, so this patch was removed.
405
406         Reviewed by Michael Catanzaro.
407
408         * wpe/jhbuild.modules: Added dependecies.
409         * wpe/patches/glib-warning-fix.patch: Removed.
410
411 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
412
413         Unreviewed, rolling out r227782.
414
415         It didn't fix the problem
416
417         Reverted changeset:
418
419         "Unreviewed. Try to avoid webdriver tests step timing out in
420         the bots."
421         https://trac.webkit.org/changeset/227782
422
423 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
424
425         WebDriver: add domains to server config in w3c tests
426         https://bugs.webkit.org/show_bug.cgi?id=182294
427
428         Reviewed by Carlos Alberto Lopez Perez.
429
430         Several cookie tests expect server_config to have a domains key.
431
432         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
433                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
434
435         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
436         (WebDriverW3CExecutor.__init__):
437
438 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
439
440         Unreviewed. Update W3C WebDriver imported tests.
441
442         Show full pytest failure logs.
443
444         pytest truncates long lists when printing a failed assertion.
445         This is not great for debugging and arguably it should be the
446         default to show the full diff when comparing lists.
447
448         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
449         (run):
450
451 2018-01-30  John Wilander  <wilander@apple.com>
452
453         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
454         https://bugs.webkit.org/show_bug.cgi?id=181958
455         https://bugs.webkit.org/show_bug.cgi?id=182072
456         <rdar://problem/36801804>
457         <rdar://problem/36845795>
458
459         Reviewed by Brent Fulgham.
460
461         Because of the asynchronous nature of XPC and cookies,
462         we need callbacks in these TestRunner functions so that
463         the layout tests can wait for state changes to finish
464         before checking test conditions.
465
466         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
467         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
468         (WTR::InjectedBundle::didReceiveMessageToPage):
469         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
470         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
471         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
472         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
473         * WebKitTestRunner/InjectedBundle/TestRunner.h:
474         * WebKitTestRunner/TestInvocation.cpp:
475         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
476         * WebKitTestRunner/TestInvocation.h:
477         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
478         (WTR::TestController::statisticsUpdateCookiePartitioning):
479         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
480
481 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
482
483         [webkitpy] Config file for apache is copied twice.
484         https://bugs.webkit.org/show_bug.cgi?id=182131
485
486         Reviewed by Daniel Bates.
487
488         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
489         (LayoutTestApacheHttpd.__init__):
490         (LayoutTestApacheHttpd._copy_apache_config_file):
491         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
492
493 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
494
495         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
496         https://bugs.webkit.org/show_bug.cgi?id=182312
497
498         Reviewed by Michael Catanzaro.
499
500         * DumpRenderTree/config.h:
501         * TestWebKitAPI/config.h:
502         * WebKitTestRunner/config.h:
503
504 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
505
506         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
507         https://bugs.webkit.org/show_bug.cgi?id=182307
508         <rdar://problem/36041485>
509
510         Reviewed by Ryosuke Niwa.
511
512         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
513         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
514         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
515         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
516
517         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
518         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
519         (TestWebKitAPI::TEST):
520
521 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
522
523         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
524         https://bugs.webkit.org/show_bug.cgi?id=182284
525
526         Reviewed by Michael Catanzaro.
527
528         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
529         * wpe/manifest.txt.in: Ditto.
530
531 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
532
533         Unreviewed, try to fix JSCOnly build
534         https://bugs.webkit.org/show_bug.cgi?id=177202
535
536         * CMakeLists.txt:
537
538 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
539
540         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
541
542         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
543         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
544         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
545         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
546
547         * Scripts/run-webdriver-tests:
548         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
549         (WebDriverTestRunner.dump_results_to_json_file):
550
551 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
552
553         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
554         https://bugs.webkit.org/show_bug.cgi?id=177202
555
556         Reviewed by Alex Christensen.
557
558         * CMakeLists.txt:
559
560 2018-01-29  Alex Christensen  <achristensen@webkit.org>
561
562         Clean up API after bugs 178240 and 176474
563         https://bugs.webkit.org/show_bug.cgi?id=182259
564
565         Reviewed by Dan Bernstein.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
568         (TEST):
569         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
570
571 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
572
573         [WebAuthN] Add a compile-time feature flag
574         https://bugs.webkit.org/show_bug.cgi?id=182211
575         <rdar://problem/36936365>
576
577         Reviewed by Brent Fulgham.
578
579         * Scripts/webkitperl/FeatureList.pm:
580         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
581
582 2018-01-29  Brady Eidson  <beidson@apple.com>
583
584         Make the API test added in r227737 be Mac-only.
585
586         Unreviewed gardening.
587
588         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
589
590 2018-01-29  Matt Lewis  <jlewis3@apple.com>
591
592         Unreviewed, rolling out r227731.
593
594         This caused and assertion failure in API tests.
595
596         Reverted changeset:
597
598         "Layout Test fast/events/beforeunload-dom-manipulation-
599         crash.html is crashing"
600         https://bugs.webkit.org/show_bug.cgi?id=181204
601         https://trac.webkit.org/changeset/227731
602
603 2018-01-29  Youenn Fablet  <youenn@apple.com>
604
605         WPT test exporter should add WebKit export in its PR description
606         https://bugs.webkit.org/show_bug.cgi?id=182246
607
608         Reviewed by Chris Dumez.
609
610         Updating PR description body to contain the words 'WebKit export'.
611         That way, WPT PR bot will mark the PR as reviewed downstream.
612
613         * Scripts/webkitpy/w3c/test_exporter.py:
614         (TestExporter.__init__):
615         (TestExporter.make_pull_request):
616         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
617         (TestExporterTest.test_export):
618
619 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
620
621         Add the support for running Speedometer 2.0 to run-benchmark
622         https://bugs.webkit.org/show_bug.cgi?id=182231
623
624         Reviewed by Antti Koivisto.
625
626         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
627         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
628         requires aggregating the geometric mean out of total time spent in each suite.
629
630         Also added --show-iteration-values to show individual measured values in each iteration.
631
632         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
633         (BenchmarkResults.format): Added show_iteration_values as an option.
634         (BenchmarkResults._format_tests): Ditto.
635         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
636         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
637         is easily parsable as a JSON array.
638         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
639         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
640         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
641         had exactly one aggregator.
642         (BenchmarkResults._lint_results):
643         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
644         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
645         parent_aggregator_list.
646         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
647         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
648         (BenchmarkResults._lint_configuration):
649         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
650         (test_format_values_with_no_unit_scaling): Added.
651         (test_format_values_with_iteration_values): Added.
652         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
653         (test_aggregate_results_from_another_aggregator): Added.
654         (test_lint_results): Added a test case.
655         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
656         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
657         (BenchmarkRunner._run_benchmark): Ditto.
658         (BenchmarkRunner.show_results): Ditto.
659         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
660         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
661         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
662         (parse_args): Added --show-iteration-values as a boolean argument.
663         (run_benchmark_plan): Ditto.
664         (start): Ditto.
665         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
666         (WebServerBenchmarkRunner.__init__): Ditto.
667
668 2018-01-29  Brady Eidson  <beidson@apple.com>
669
670         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
671         https://bugs.webkit.org/show_bug.cgi?id=182229
672
673         Reviewed by Chris Dumez.
674
675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
676         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
677
678 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
679
680         WebDriver: properly recover w3c tests after a webdriver server crash
681         https://bugs.webkit.org/show_bug.cgi?id=182242
682
683         Reviewed by Carlos Alberto Lopez Perez.
684
685         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
686         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
687         relaunching the server after every test failure, because other failures, even when not crashing the server,
688         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
689         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
690
691         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
692         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
693         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
694         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
695         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
696         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
697         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
698         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
699
700 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
701
702         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
703         https://bugs.webkit.org/show_bug.cgi?id=181204
704         <rdar://problem/36256274>
705
706         Reviewed by Ryosuke Niwa.
707
708         Implement 'testRunner.forceImmediateCompletion()' for WK1.
709
710         * DumpRenderTree/TestRunner.cpp:
711         (forceImmediateCompletionCallback):
712         (TestRunner::staticFunctions):
713
714 2018-01-29  Frederic Wang  <fwang@igalia.com>
715
716         Unreviewed, add myself to some watch lists.
717
718         * Scripts/webkitpy/common/config/watchlist:
719
720 2018-01-27  Dan Bernstein  <mitz@apple.com>
721
722         HaveInternalSDK includes should be "#include?"
723         https://bugs.webkit.org/show_bug.cgi?id=179670
724
725         * DumpRenderTree/mac/Configurations/Base.xcconfig:
726
727 2018-01-26  Chris Dumez  <cdumez@apple.com>
728
729         Make sure service worker code does not launch a StorageProcess unnecessarily
730         https://bugs.webkit.org/show_bug.cgi?id=182192
731         <rdar://problem/36927427>
732
733         Reviewed by Geoffrey Garen.
734
735         Add API test coverage.
736
737         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
738
739 2018-01-26  Chris Dumez  <cdumez@apple.com>
740
741         Offlined content does not work for apps on home screen
742         https://bugs.webkit.org/show_bug.cgi?id=182070
743         <rdar://problem/36843906>
744
745         Reviewed by Youenn Fablet.
746
747         Add API test coverage to make sure an already registered service worker is able to intercept
748         the very first load.
749
750         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
751         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
752
753 2018-01-26  Chris Nardi  <cnardi@chromium.org>
754
755         Addressing post-review comments after r226614
756         https://bugs.webkit.org/show_bug.cgi?id=182151
757
758         Reviewed by Myles C. Maxfield.
759
760         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
761         (TestWebKitAPI::TEST):
762
763 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
764
765         Unreviewed, rolling out r224920.
766
767         Some Win EWS bots are not coming back up after starting reboot.
768
769         * EWSTools/start-queue-win.sh:
770
771 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
772
773         WebDriver: simplify the tests json report
774         https://bugs.webkit.org/show_bug.cgi?id=182171
775
776         Reviewed by Carlos Alberto Lopez Perez.
777
778         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
779         form the subtest name. We should do the same for simplicity and compatibility with WPT.
780
781         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
782         (WebDriverTestRunner.dump_results_to_json_file):
783
784 2018-01-25  Alex Christensen  <achristensen@webkit.org>
785
786         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
787         https://bugs.webkit.org/show_bug.cgi?id=182152
788
789         Reviewed by Joseph Pecoraro.
790
791         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
792         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
793         (TEST):
794
795 2018-01-25  Youenn Fablet  <youenn@apple.com>
796
797         WebPluginInfoProvider should handle null host queries
798         https://bugs.webkit.org/show_bug.cgi?id=182112
799
800         Reviewed by Chris Dumez.
801
802         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
803         (TEST):
804
805 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
806
807         [webkitpy] Stop modifying path information only when running on Cygwin
808         https://bugs.webkit.org/show_bug.cgi?id=182136
809
810         On LayoutTestApacheHttpd, some path configuration is modified when platform
811         is Windows. This modification is only required for AppleWin running on Cygwin.
812         WinCairo uses native Windows environment, so the condition should be changed.
813
814         Reviewed by Per Arne Vollan.
815
816         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
817         (LayoutTestApacheHttpd.__init__):
818         (LayoutTestApacheHttpd._get_apache_config_file_path):
819
820 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
821
822         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
823         https://bugs.webkit.org/show_bug.cgi?id=182038
824         <rdar://problem/36812083>
825
826         Reviewed by Jer Noble.
827
828         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
829         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
830
831 2018-01-24  Daniel Bates  <dabates@apple.com>
832
833         webkit-patch upload emits irrelevant simulator warnings
834         https://bugs.webkit.org/show_bug.cgi?id=181702
835         <rdar://problem/36556359>
836
837         Reviewed by Aakash Jain.
838
839         Remove warning when a person explicitly passes --child-processes with a value greater than
840         the default number of simulator instances webkitpy would have used had --child-processes
841         been omitted. Moreover, the placement of the warning logic to support printing such a message
842         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
843
844         By default, webkitpy will parallelize running tests using the maximum number of simulator
845         instances that can be supported based on available system resources at the time run-webkit-tests
846         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
847         by specifying --child-processes knows what they are doing. The effects of picking a large
848         value be obvious, the system may become sluggish.
849
850         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
851         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
852
853         * Scripts/webkitpy/port/ios_simulator.py:
854         (IOSSimulatorPort.__init__):
855
856 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
857
858         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
859         https://bugs.webkit.org/show_bug.cgi?id=182102
860
861         Reviewed by Carlos Garcia Campos.
862
863         * MiniBrowser/gtk/main.c:
864         (main): Removed the call to set_enable_webvr().
865
866 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
867
868         WebDriver: add support for slow tests
869         https://bugs.webkit.org/show_bug.cgi?id=182095
870
871         Reviewed by Carlos Alberto Lopez Perez.
872
873         Add timeout mark to slow tests.
874
875         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
876         (TestExpectationsMarker.__init__): Save the timeout.
877         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
878         (run): Pass timeout to TestExpectationsMarker constructor.
879
880 2018-01-24  Alex Christensen  <achristensen@webkit.org>
881
882         Gracefully recover from NetworkProcess crashes in private browsing
883         https://bugs.webkit.org/show_bug.cgi?id=182073
884         <rdar://problem/36572023>
885
886         Reviewed by Geoff Garen.
887
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
890         (-[CrashDelegate webView:didFinishNavigation:]):
891         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
892         (-[CrashDelegate webView:didFailNavigation:withError:]):
893         (TEST):
894
895 2018-01-24  Ali Juma  <ajuma@chromium.org>
896
897         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
898         https://bugs.webkit.org/show_bug.cgi?id=182052
899
900         Reviewed by Simon Fraser.
901
902         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
903         immediately.
904
905         Test: fast/visual-viewport/viewport-dimensions.html
906
907         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
908         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
909
910 2018-01-24  Alex Christensen  <achristensen@webkit.org>
911
912         Remove pre-Sierra-OS-specific code in Tools
913         https://bugs.webkit.org/show_bug.cgi?id=182034
914
915         Reviewed by Tim Horton.
916
917         * DumpRenderTree/mac/DumpRenderTree.mm:
918         (setDefaultsToConsistentValuesForTesting):
919         * MiniBrowser/mac/BrowserWindowController.m:
920         (-[BrowserWindowController windowDidLoad]):
921         (-[BrowserWindowController share:]):
922         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
923         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
924         (-[EventStreamPlayer playbackTimerFired:]):
925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
926         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
927         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
928         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
929         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
930         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
931         (WTR::InjectedBundle::platformInitialize):
932         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
933         (WTR::initializeWebViewConfiguration):
934
935 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
936
937         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
938         https://bugs.webkit.org/show_bug.cgi?id=181400
939         <rdar://problem/36358768>
940
941         Reviewed by Joseph Pecoraro.
942
943         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
944
945         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
946         Always disable poisoning when running with --leaks, as this should work locally,
947         not just on bots.
948
949 2018-01-24  Daniel Bates  <dabates@apple.com>
950
951         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
952         https://bugs.webkit.org/show_bug.cgi?id=181993
953         <rdar://problem/36421080>
954
955         Reviewed by David Hyatt.
956
957         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
958         as we no longer support this strategy.
959
960         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
961
962 2018-01-24  David Kilzer  <ddkilzer@apple.com>
963
964         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
965         <https://webkit.org/b/182015>
966         <rdar://problem/36449728>
967
968         Reviewed by Tim Horton.
969
970         * Scripts/webkitpy/style/checkers/cpp.py:
971         (regex_for_lambdas_and_blocks): Update regex to include
972         optional return type for block argument in Objective-C.
973         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
974         (WebKitStyleTest.test_braces): Add test.
975
976 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
977
978         WPE-focused test gardening.
979         https://bugs.webkit.org/show_bug.cgi?id=182051
980
981         Unreviewed test gardening.
982
983         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
984
985 2018-01-23  Mark Lam  <mark.lam@apple.com>
986
987         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
988         https://bugs.webkit.org/show_bug.cgi?id=182017
989         <rdar://problem/36795513>
990
991         Reviewed by Filip Pizlo and JF Bastien.
992
993         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
994         (TestWebKitAPI::TEST):
995         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
996         (TestWebKitAPI::TEST):
997         (TestWebKitAPI::passWithRef):
998         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
999         (TestWebKitAPI::TEST):
1000         (TestWebKitAPI::f1):
1001         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1002         (TestWebKitAPI::TEST):
1003         (TestWebKitAPI::poisonedPtrFoo):
1004         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1005         (TestWebKitAPI::TEST):
1006         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1007         (TestWebKitAPI::TEST):
1008
1009 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
1010
1011         [WebVR] Add OpenVR to the tree and to the build
1012         https://bugs.webkit.org/show_bug.cgi?id=177298
1013
1014         Reviewed by Žan Doberšek.
1015
1016         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
1017         with reduced style checks.
1018
1019 2018-01-24  Chris Nardi  <cnardi@chromium.org>
1020
1021         Add Chris Nardi to contributors list
1022         https://bugs.webkit.org/show_bug.cgi?id=182029
1023
1024         Reviewed by Antti Koivisto.
1025
1026         * Scripts/webkitpy/common/config/contributors.json:
1027
1028 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1029
1030         Mac Sierra perf bots have been failing due to CG errors
1031         https://bugs.webkit.org/show_bug.cgi?id=181955
1032
1033         Reviewed by Antti Koivisto.
1034
1035         Ignore the CoreGraphics error messages on macOS Sierra.
1036
1037         Also added tests for ignoring lines in stdout and stderr.
1038
1039         * Scripts/webkitpy/performance_tests/perftest.py:
1040         (PerfTest.run_failed): Refactored for clarity.
1041         (PerfTest):
1042         (PerfTest.filter_ignored_lines): Added.
1043         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
1044         are now used to ignore lines in other kinds of tests than parser tests.
1045         (PerfTest._errors_to_ignore_in_sierra): Added.
1046         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
1047         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1048         (test_parse_output_with_ignored_stdout): Added.
1049         (test_parse_output_with_ignored_stderr): Added.
1050         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1051
1052 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1053
1054         Resign NowPlaying status when no media element is eligible
1055         https://bugs.webkit.org/show_bug.cgi?id=181914
1056         <rdar://problem/35294116>
1057
1058         Reviewed by Jer Noble.
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1061         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1062         (TestWebKitAPI::TEST):
1063         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1064
1065 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1066
1067         [WinCairo] Use 64-bit toolset
1068         https://bugs.webkit.org/show_bug.cgi?id=181979
1069
1070         Reviewed by Alex Christensen.
1071
1072         Use 64-bit toolset for 64-bit build in order to improve build time. 
1073
1074         * Scripts/webkitdirs.pm:
1075         (generateBuildSystemFromCMakeProject):
1076
1077 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1078
1079         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1080         https://bugs.webkit.org/show_bug.cgi?id=181741
1081         rdar://problem/36593581
1082
1083         Reviewed by Tim Horton.
1084         
1085         If zoomToScale:animated: is called with the current zoom level, call the callback
1086         rather than doing nothing.
1087
1088         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1089         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1090
1091 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1092
1093         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1094         https://bugs.webkit.org/show_bug.cgi?id=180820
1095
1096         Reviewed by David Kilzer.
1097
1098         * Scripts/webkitpy/common/checkout/scm/git.py:
1099         (Git.in_working_directory):
1100         (Git.clone):
1101         (Git.read_git_config):
1102         (Git.apply_reverse_diff):
1103         * Scripts/webkitpy/common/checkout/scm/scm.py:
1104         (SCM.run):
1105         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1106         * Scripts/webkitpy/common/checkout/scm/svn.py:
1107         (SVNRepository.has_authorization_for_realm):
1108         * Scripts/webkitpy/common/net/credentials_unittest.py:
1109         * Scripts/webkitpy/common/system/abstractexecutive.py:
1110         (AbstractExecutive.run_command):
1111         * Scripts/webkitpy/common/system/executive.py:
1112         (Executive.kill_process.is):
1113         (Executive.running_pids):
1114         (Executive.kill_all):
1115         (Executive.run_command):
1116         * Scripts/webkitpy/common/system/executive_mock.py:
1117         (MockExecutive.run_command):
1118         (MockExecutive2.run_command):
1119         * Scripts/webkitpy/common/system/executive_unittest.py:
1120         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
1121         * Scripts/webkitpy/common/system/platforminfo.py:
1122         (PlatformInfo.xcode_sdk_version):
1123         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1124         (Lighttpd._check_and_kill):
1125         * Scripts/webkitpy/port/base.py:
1126         (Port._symbols_string):
1127         * Scripts/webkitpy/port/gtk.py:
1128         (GtkPort.setup_environ_for_server):
1129         * Scripts/webkitpy/port/win.py:
1130         (WinPort._runtime_feature_list):
1131         (WinPort.read_registry_value):
1132         * Scripts/webkitpy/port/win_unittest.py:
1133         (WinPortTest.test_runtime_feature_list):
1134         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1135         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1136
1137 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1138
1139         Unreviewed, rolling out r227279 and r227373.
1140         https://bugs.webkit.org/show_bug.cgi?id=181988
1141
1142         The LayoutTest crash fix introduced an API test failure.
1143         (Requested by ryanhaddad on #webkit).
1144
1145         Reverted changesets:
1146
1147         "Resign NowPlaying status when no media element is eligible"
1148         https://bugs.webkit.org/show_bug.cgi?id=181914
1149         https://trac.webkit.org/changeset/227279
1150
1151         "Resign NowPlaying status when no media element is eligible"
1152         https://bugs.webkit.org/show_bug.cgi?id=181914
1153         https://trac.webkit.org/changeset/227373
1154
1155 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1156
1157         Unreviewed. Add test case for slow in test_expectations.py.
1158
1159         I forgot to also check slow tests in test_expectations.py unit tests.
1160
1161         * Scripts/webkitpy/common/test_expectations_unittest.py:
1162         (assert_slow):
1163         (test_build_type):
1164         (test_slow):
1165
1166 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1167
1168         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
1169
1170         * TestWebKitAPI/glib/TestExpectations.json:
1171
1172 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1173
1174         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
1175         https://bugs.webkit.org/show_bug.cgi?id=181616
1176         <rdar://problem/36484908>
1177
1178         Reviewed by Wenson Hsieh.
1179
1180         Added tests to make sure we sanitize plain HTML, not just web archives,
1181         when and only when custom pasteboard data is enabled.
1182
1183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1184         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
1185         (writeHTMLToPasteboard): Added.
1186         (createWebViewWithCustomPasteboardDataSetting): Added.
1187
1188 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
1189
1190         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1191         https://bugs.webkit.org/show_bug.cgi?id=181400
1192         rdar://problem/36358768
1193
1194         Reviewed by JF Bastien.
1195
1196         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
1197
1198 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1199
1200         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
1201         https://bugs.webkit.org/show_bug.cgi?id=181929
1202
1203         Reviewed by Michael Catanzaro.
1204
1205         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
1206         the website data completion callback is not called immediately, and a new file is created when the operation
1207         finishes. We need to check that the file was removing after calling clear.
1208
1209         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1210         (fileChangedCallback):
1211         (testWebsiteDataResourceLoadStatistics):
1212
1213 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
1216
1217         * TestWebKitAPI/glib/TestExpectations.json:
1218
1219 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1220
1221         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
1222
1223         Partially revert r226782, the fix was wrong for the GLib version we currently use.
1224
1225         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1226         (testWebKitConsoleMessageNetworkError):
1227
1228 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1229
1230         Unreviewed. Remove unused verbose mode from GLib API tests runner.
1231
1232         * glib/api_test_runner.py:
1233         (add_options):
1234
1235 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1236
1237         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1238         https://bugs.webkit.org/show_bug.cgi?id=181918
1239
1240         Reviewed by Tim Horton.
1241
1242         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1243
1244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1245
1246 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
1247
1248         Resign NowPlaying status when no media element is eligible
1249         https://bugs.webkit.org/show_bug.cgi?id=181914
1250         <rdar://problem/35294116>
1251
1252         Reviewed by Jer Noble.
1253
1254         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1255         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1256         (TestWebKitAPI::TEST):
1257         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1258
1259 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
1260
1261         Fix broken unit-tests after r227192
1262         https://bugs.webkit.org/show_bug.cgi?id=181909
1263
1264         Reviewed by Carlos Garcia Campos.
1265
1266         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1267
1268 2018-01-20  Chris Dumez  <cdumez@apple.com>
1269
1270         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
1271         https://bugs.webkit.org/show_bug.cgi?id=174984
1272         <rdar://problem/33665676>
1273
1274         Reviewed by Alexey Proskuryakov.
1275
1276         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
1277
1278         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1279         (TEST):
1280
1281 2018-01-20  Brian Burg  <bburg@apple.com>
1282
1283         WebDriver: fix some nits that prevent running W3C tests on Mac
1284         https://bugs.webkit.org/show_bug.cgi?id=181864
1285
1286         Reviewed by Carlos Garcia Campos.
1287
1288         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1289         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
1290         as we assume that the property exists later.
1291
1292         (WebDriverW3CWebServer.stop): If the temporary file doesn't
1293         exist for some reason, the remove call will raise and exception.
1294         Gracefully handle the case where the file isn't created due to
1295         a problem/exception that happened elsewhere.
1296
1297 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
1298
1299         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
1300         https://bugs.webkit.org/show_bug.cgi?id=181881
1301
1302         Reviewed by Alexey Proskuryakov.
1303
1304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1305         (BubbleQueueServer):
1306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1308         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
1309
1310 2018-01-19  Youenn Fablet  <youenn@apple.com>
1311
1312         Do not go to the storage process when registering a service worker client if there is no service worker registered
1313         https://bugs.webkit.org/show_bug.cgi?id=181740
1314         <rdar://problem/36650400>
1315
1316         Reviewed by Chris Dumez.
1317
1318         Add support for internals inside API tests.
1319
1320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1321         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
1322         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
1323         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
1324         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
1325         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
1326         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1327         (setConfigurationInjectedBundlePath):
1328         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
1329
1330 2018-01-19  John Wilander  <wilander@apple.com>
1331
1332         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
1333         https://bugs.webkit.org/show_bug.cgi?id=181822
1334         https://bugs.webkit.org/show_bug.cgi?id=175263
1335         https://bugs.webkit.org/show_bug.cgi?id=178536
1336         https://bugs.webkit.org/show_bug.cgi?id=181223
1337         https://bugs.webkit.org/show_bug.cgi?id=181482
1338         <rdar://problem/33491222>
1339         <rdar://problem/33805293>
1340         <rdar://problem/36332683>
1341         <rdar://problem/36549026>
1342
1343         Reviewed by Alex Christensen.
1344
1345         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1347         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1348         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1349         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1350         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1351         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1352         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1353
1354 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
1355
1356         run-webkit-tests fails when there is a curly brace in Xcode build output
1357         https://bugs.webkit.org/show_bug.cgi?id=181254
1358         <rdar://problem/36453374>
1359
1360         Reviewed by Daniel Bates.
1361
1362         * Scripts/webkitpy/port/base.py:
1363         (Port._run_script): Encode script output before logging it.
1364
1365 2018-01-19  Chris Dumez  <cdumez@apple.com>
1366
1367         Service worker registrations restored from disk may not be reused when the JS calls register() again
1368         https://bugs.webkit.org/show_bug.cgi?id=181810
1369         <rdar://problem/36591711>
1370
1371         Reviewed by Youenn Fablet.
1372
1373         Add API test coverage.
1374
1375         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1376         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
1377         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
1378
1379 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
1380
1381         Remove El Capitan queues from flakiness dashboard
1382         https://bugs.webkit.org/show_bug.cgi?id=181860
1383
1384         Reviewed by Aakash Jain.
1385
1386         * TestResultServer/static-dashboards/builders.jsonp:
1387
1388 2018-01-19  Keith Miller  <keith_miller@apple.com>
1389
1390         HaveInternalSDK includes should be "#include?"
1391         https://bugs.webkit.org/show_bug.cgi?id=179670
1392
1393         Reviewed by Dan Bernstein.
1394
1395         * MiniBrowser/Configurations/Base.xcconfig:
1396         * MobileMiniBrowser/Configurations/Base.xcconfig:
1397         * TestWebKitAPI/Configurations/Base.xcconfig:
1398         * WebKitTestRunner/Configurations/Base.xcconfig:
1399
1400 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1401
1402         WebDriver: driver environment not passed to pytest when running w3c tests
1403         https://bugs.webkit.org/show_bug.cgi?id=181852
1404
1405         Reviewed by Carlos Alberto Lopez Perez.
1406
1407         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
1408
1409         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1410         (WebDriverW3CExecutor.run):
1411
1412 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1413
1414         [GTK] WebDriver: wayland display no used in wayland bot
1415         https://bugs.webkit.org/show_bug.cgi?id=181851
1416
1417         Reviewed by Carlos Alberto Lopez Perez.
1418
1419         We need to handle the additionalArguments property in the WebDriverTests step.
1420
1421         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1422         (RunWebDriverTests.start):
1423
1424 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1425
1426         [GTK] TERM environment variable is not passed to the test driver.
1427         https://bugs.webkit.org/show_bug.cgi?id=181847
1428
1429         Rubber-stamped by by Carlos Garcia Campos.
1430
1431         * Scripts/webkitpy/port/base.py:
1432         (Port.to.setup_environ_for_server):
1433
1434 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1435
1436         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
1437         https://bugs.webkit.org/show_bug.cgi?id=181844
1438
1439         Reviewed by Carlos Alberto Lopez Perez.
1440
1441         We always try to create the directory where to store the json file, but when the filename is given directly,
1442         like in the bots, the current dir is used.
1443
1444         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1445         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
1446         empty string.
1447
1448 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1449
1450         [GTK] WebDriver tests are running outside the jhbuild env
1451         https://bugs.webkit.org/show_bug.cgi?id=181842
1452
1453         Reviewed by Žan Doberšek.
1454
1455         We need to enter jhbuild env in run-webdriver-tests.
1456
1457         * Scripts/run-webdriver-tests:
1458
1459 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1460
1461         [GTK] Run WebDriver tests in the bots
1462         https://bugs.webkit.org/show_bug.cgi?id=181787
1463
1464         Reviewed by Michael Catanzaro.
1465
1466         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
1467         factory for the GTK port for now.
1468
1469         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1470         (TestFactory.__init__):
1471         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1472         (RunWebDriverTests):
1473         (RunWebDriverTests.start):
1474         (RunWebDriverTests.commandComplete):
1475         (RunWebDriverTests.evaluateCommand):
1476         (RunWebDriverTests.getText):
1477         (RunWebDriverTests.getText2):
1478
1479 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1480
1481         [WinCairo] Pass correct url for http test to test driver.
1482         https://bugs.webkit.org/show_bug.cgi?id=181814
1483
1484         Reviewed by Alex Christensen.
1485
1486         * Scripts/webkitpy/port/driver.py:
1487         (Driver):
1488         (Driver.http_test_path_to_uri):
1489         (Driver.is_secure_path):
1490         (Driver.http_base_url):
1491         (Driver.uri_to_test):
1492
1493 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1494
1495         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
1496
1497         * BuildSlaveSupport/build.webkit.org-config/config.json:
1498
1499 2018-01-18  Dan Bernstein  <mitz@apple.com>
1500
1501         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1502         https://bugs.webkit.org/show_bug.cgi?id=181803
1503
1504         Reviewed by Tim Horton.
1505
1506         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
1507         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
1508         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
1509         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
1510         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
1511         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1512         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1513         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
1515           helpers.
1516         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
1517           settings useful for defining settings that depend on the target macOS version.
1518         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
1519         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
1520
1521 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
1522
1523         Remove Opensource El Capitan queues from buildbot
1524         https://bugs.webkit.org/show_bug.cgi?id=181712
1525
1526         Reviewed by Aakash Jain.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/config.json:
1529         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1530         (WebKitBuildbot):
1531         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1532
1533 2018-01-18  Chris Dumez  <cdumez@apple.com>
1534
1535         Service Workers restored from persistent storage have 'redundant' state
1536         https://bugs.webkit.org/show_bug.cgi?id=181749
1537         <rdar://problem/36556486>
1538
1539         Reviewed by Youenn Fablet.
1540
1541         Add API test coverage.
1542
1543         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1544         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
1545
1546 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1547
1548         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
1549         https://bugs.webkit.org/show_bug.cgi?id=176796
1550
1551         Reviewed by Chris Fleizach.
1552
1553         Add sanity check that we have a URL before calling g_strstr_len().
1554
1555         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1556         (WTR::AccessibilityUIElement::url):
1557
1558 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1559
1560         Add triggers for Sierra test262 and perf queues
1561         https://bugs.webkit.org/show_bug.cgi?id=181799
1562
1563         Reviewed by Aakash Jain.
1564
1565         * BuildSlaveSupport/build.webkit.org-config/config.json:
1566
1567 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1568
1569         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
1570         https://bugs.webkit.org/show_bug.cgi?id=181783
1571         <rdar://problem/35785445>
1572
1573         Reviewed by Ryosuke Niwa.
1574
1575         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
1576         copying an image contains a relevant title.
1577
1578         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1579         (TestWebKitAPI::TEST):
1580         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1581         * TestWebKitAPI/ios/UIKitSPI.h:
1582
1583 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1584
1585         WebDriver: ignore the driver in selenium test names when getting expectations
1586         https://bugs.webkit.org/show_bug.cgi?id=181738
1587
1588         Reviewed by Carlos Alberto Lopez Perez.
1589
1590         In selenium tests, the driver is added as a parameter to every test which results in tests names like
1591         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
1592         driver name in the test expectations file, so we need to remove it when querying the expectations.
1593
1594         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1595         (TestExpectationsMarker.__init__): Save the param to ignore.
1596         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
1597         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
1598         (run): Pass param to ignore to TestExpectationsMarker().
1599         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1600         (WebDriverSeleniumExecutor.__init__): Save the driver name.
1601         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
1602
1603 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1604
1605         [GTK][WPE] Show unit tests unexpectedly passing in the bots
1606         https://bugs.webkit.org/show_bug.cgi?id=181726
1607
1608         Reviewed by Michael Catanzaro.
1609
1610         Now that we have the info, let's show it also in the bots.
1611
1612         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1613         (RunGLibAPITests.commandComplete):
1614
1615 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
1616
1617         Fix broken unittest after r227048
1618         https://bugs.webkit.org/show_bug.cgi?id=181760
1619
1620         Reviewed by Aakash Jain.
1621
1622
1623 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1624
1625         WEBKIT_FRAMEWORK should not modify file-global include directories
1626         https://bugs.webkit.org/show_bug.cgi?id=181656
1627
1628         Reviewed by Konstantin Tokarev.
1629
1630         * TestWebKitAPI/PlatformWPE.cmake:
1631         * TestWebKitAPI/glib/CMakeLists.txt:
1632
1633 2018-01-17  Alicia Boya García  <aboya@igalia.com>
1634
1635         Unreviewed, mark Alicia as committer in contributors.json
1636
1637         * Scripts/webkitpy/common/config/contributors.json:
1638
1639 2018-01-17  Youenn Fablet  <youenn@apple.com>
1640
1641         Put fetch Request.keepalive behind a runtime flag
1642         https://bugs.webkit.org/show_bug.cgi?id=181592
1643
1644         Reviewed by Chris Dumez.
1645
1646         * DumpRenderTree/mac/DumpRenderTree.mm:
1647         (enableExperimentalFeatures):
1648         * DumpRenderTree/win/DumpRenderTree.cpp:
1649         (enableExperimentalFeatures):
1650         * WebKitTestRunner/TestController.cpp:
1651         (WTR::TestController::resetPreferencesToConsistentValues):
1652
1653 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1654
1655         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1656         https://bugs.webkit.org/show_bug.cgi?id=181637
1657         <rdar://problem/36508471>
1658
1659         Reviewed by Tim Horton.
1660
1661         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
1662         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
1663
1664         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1665         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1666         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
1667
1668         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
1669         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
1670
1671         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1672         (webViewForTestingAttachments):
1673         (-[TestWKWebView tagsInBody]):
1674         (-[TestWKWebView expectElementTagsInOrder:]):
1675         (-[TestWKWebView expectElementTag:toComeBefore:]):
1676
1677         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
1678         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
1679
1680         (TestWebKitAPI::TEST):
1681         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1682         (WTR::InjectedBundlePage::InjectedBundlePage):
1683
1684 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1685
1686         WebDriver: add support for test expectations
1687         https://bugs.webkit.org/show_bug.cgi?id=180420
1688
1689         Reviewed by Carlos Alberto Lopez Perez.
1690
1691         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
1692
1693         * Scripts/run-webdriver-tests: Get the retval from process_results().
1694         * Scripts/webkitpy/thirdparty/__init__.py:
1695         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
1696         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1697         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
1698         (TestExpectationsMarker.__init__): Initialize expectations.
1699         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
1700         (run): Create and use TestExpectationsMarker plugin.
1701         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1702         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
1703         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1704         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
1705         (WebDriverTestRunner.run): Do not count results here.
1706         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
1707         amount of failures. Printing the test summary while processing results will be made optional in a follow up
1708         patch.
1709         (WebDriverTestRunner.process_results.report): Return the amount of failures.
1710         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1711         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
1712         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
1713         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
1714         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1715         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
1716         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
1717         (WebDriverTestRunnerW3C._scan_directory): Ditto.
1718         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
1719         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1720         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
1721
1722 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1723
1724         Unreviewed WPE gardening. Mark some known unit test failures.
1725
1726         * TestWebKitAPI/glib/TestExpectations.json:
1727
1728 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1729
1730         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
1731         https://bugs.webkit.org/show_bug.cgi?id=181724
1732
1733         Reviewed by Philippe Normand.
1734
1735         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
1736         reason to use different names. This way we can refer to the same test names for both and we can share the
1737         expectations in the TestExpectations.json file.
1738
1739         * TestWebKitAPI/glib/TestExpectations.json:
1740         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
1741
1742 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1743
1744         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
1745
1746         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
1747         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
1748
1749         * glib/api_test_runner.py:
1750         (TestRunner._run_test_glib):
1751         (TestRunner._run_google_test):
1752
1753 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1754
1755         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
1756         https://bugs.webkit.org/show_bug.cgi?id=179914
1757
1758         Reviewed by Žan Doberšek.
1759
1760         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
1761         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
1762         all symbols listed in the script are present in the library.
1763
1764         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
1765         (bss_symbols):
1766         * Scripts/check-for-invalid-symbols-in-version-script: Added.
1767         (script_symbols):
1768         * Scripts/make-dist:
1769         (Distcheck.build):
1770         (Distcheck):
1771         (Distcheck.check_symbols):
1772         (Distcheck.check):
1773
1774 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1775
1776         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
1777         https://bugs.webkit.org/show_bug.cgi?id=181722
1778
1779         Reviewed by Žan Doberšek.
1780
1781         I forgot to pass the parameters to run() when restarting.
1782
1783         * glib/glib_test_runner.py:
1784         (GLibTestRunner.run):
1785
1786 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1787
1788         [CMake] Remove WebCoreDerivedSources library target
1789         https://bugs.webkit.org/show_bug.cgi?id=181664
1790
1791         Reviewed by Carlos Garcia Campos.
1792
1793         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
1794         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1795
1796 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
1797
1798         Move Debug Test262, Release Test262 and Performance queues to Sierra
1799         https://bugs.webkit.org/show_bug.cgi?id=181692
1800
1801         Unreviewed
1802
1803 2018-01-16  Zach Li  <zachli@apple.com>
1804
1805         Add pop-up policy support in website policies.
1806         https://bugs.webkit.org/show_bug.cgi?id=181544.
1807         rdar://problem/30521400.
1808
1809         Reviewed by Alex Christensen.
1810
1811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1812         Added pop-up-check.html.
1813
1814         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
1815
1816         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1817         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1818         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1819         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1820         (TEST):
1821
1822 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1823
1824         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
1825         https://bugs.webkit.org/show_bug.cgi?id=181638
1826         <rdar://problem/36508702>
1827
1828         Reviewed by Dan Bernstein.
1829
1830         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
1831         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1834         (-[AttachmentUpdateObserver init]):
1835         (-[AttachmentUpdateObserver sourceForIdentifier:]):
1836         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
1837         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
1838         (TestWebKitAPI::TEST):
1839         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
1840
1841 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1842
1843         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
1844
1845         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
1846
1847         * glib/api_test_runner.py:
1848         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
1849         * glib/glib_test_runner.py:
1850         (GLibTestRunner.run): Use given env.
1851
1852 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
1855         https://bugs.webkit.org/show_bug.cgi?id=181676
1856
1857         Reviewed by Carlos Alberto Lopez Perez.
1858
1859         The option was removed in r226967.
1860
1861         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1862         (RunGtkAPITests):
1863         (RunWPEAPITests):
1864
1865 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1866
1867         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
1868
1869         The bots are still passing that option and the step is failing because it was removed in r226967.
1870
1871         * glib/api_test_runner.py:
1872         (add_options):
1873
1874 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1875
1876         [GTK][WPE] Improve the way glib tests are run
1877         https://bugs.webkit.org/show_bug.cgi?id=181674
1878
1879         Reviewed by Žan Doberšek.
1880
1881         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
1882         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
1883         tests failing due to an expected assert in the test and unexpected crashes.
1884         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
1885         not showing the subtest name in stdout in case of timeouts.
1886         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
1887         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
1888         of every test case.
1889
1890         * glib/api_test_runner.py:
1891         (TestRunner._run_test_glib): Use GLibTestRunner.
1892         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
1893         (add_options):
1894         * glib/glib_test_runner.py: Added.
1895         (TestTimeout):
1896         (Message):
1897         (Message.__init__):
1898         (Message.create):
1899         (Message.create.read_unsigned):
1900         (Message.create.read_double):
1901         (Message.create.read_string):
1902         (GLibTestRunner):
1903         (GLibTestRunner.__init__):
1904         (GLibTestRunner._process_data):
1905         (GLibTestRunner._process_message):
1906         (GLibTestRunner._read_from_pipe):
1907         (GLibTestRunner._read_from_stderr):
1908         (GLibTestRunner._start_timeout):
1909         (GLibTestRunner._start_timeout._alarm_handler):
1910         (GLibTestRunner._stop_timeout):
1911         (GLibTestRunner._subtest_start):
1912         (GLibTestRunner._subtest_message):
1913         (GLibTestRunner._subtest_stderr):
1914         (GLibTestRunner._subtest_end):
1915         (GLibTestRunner.run):
1916
1917 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1918
1919         Unreviewed, add Thibault to contributors.json
1920
1921         It's a bit weird to add someone here before their first contribution, but this affects
1922         Bugzilla autocomplete, and that is serious business.
1923
1924         * Scripts/webkitpy/common/config/contributors.json:
1925
1926 2018-01-15  JF Bastien  <jfbastien@apple.com>
1927
1928         Remove makePoisonedUnique
1929         https://bugs.webkit.org/show_bug.cgi?id=181630
1930         <rdar://problem/36498623>
1931
1932         Reviewed by Mark Lam.
1933
1934         Update tests.
1935
1936         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1937         (TestWebKitAPI::TEST):
1938         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1939         (TestWebKitAPI::TEST):
1940
1941 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
1942
1943         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
1944         https://bugs.webkit.org/show_bug.cgi?id=181476
1945
1946         Reviewed by Michael Catanzaro.
1947
1948         Update to xorg-server 1.19.6 which depends on libxfont2, and change
1949         the lists of packages to install libxfont2-devel (or equivalent).
1950
1951         * gtk/install-dependencies:
1952         * gtk/jhbuild.modules:
1953
1954 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1955
1956         [GTK][WPE] Add support for unit test expectations
1957         https://bugs.webkit.org/show_bug.cgi?id=181589
1958
1959         Reviewed by Michael Catanzaro.
1960
1961         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
1962         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
1963         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
1964         script itself is not a good idea either.
1965
1966         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
1967         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
1968         convenient methods to query them.
1969
1970         * Scripts/run-gtk-tests:
1971         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
1972         * Scripts/run-wpe-tests:
1973         (WPETestRunner): Ditto.
1974         * Scripts/webkitpy/common/test_expectations.py: Added.
1975         (TestExpectations):
1976         (TestExpectations.__init__):
1977         (TestExpectations._port_name_for_expected):
1978         (TestExpectations._expected_value):
1979         (TestExpectations.skipped_tests):
1980         (TestExpectations.skipped_subtests):
1981         (TestExpectations._expectation_value):
1982         (TestExpectations.is_slow):
1983         (TestExpectations.get_expectation):
1984         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
1985         (MockTestExpectations):
1986         (MockTestExpectations.__init__):
1987         (MockTestExpectations.is_skip):
1988         (ExpectationsTest):
1989         (assert_exp):
1990         (assert_not_exp):
1991         (assert_bad_exp):
1992         (assert_skip):
1993         (test_basic):
1994         (test_skip):
1995         (test_flaky):
1996         (test_build_type):
1997         * TestWebKitAPI/glib/TestExpectations.json: Added.
1998         * glib/api_test_runner.py:
1999         (TestRunner): Remove SkippedTest implementation.
2000         (TestRunner.__init__): Create a TestExpectations.
2001         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
2002         (TestRunner._should_run_test_program): Ditto.
2003         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
2004         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
2005         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
2006         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
2007         (TestRunner.run_tests.report): Helper to write report to stdout.
2008
2009 2018-01-13  Mark Lam  <mark.lam@apple.com>
2010
2011         Replace all use of ConstExprPoisoned with Poisoned.
2012         https://bugs.webkit.org/show_bug.cgi?id=181542
2013         <rdar://problem/36442138>
2014
2015         Reviewed by JF Bastien.
2016
2017         1. Converted tests to using new uintptr_t& poison type.
2018         2. Added tests for Poisoned comparison operators.
2019
2020         * TestWebKitAPI/CMakeLists.txt:
2021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2022         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
2023         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2024         (TestWebKitAPI::TEST):
2025         (TestWebKitAPI::initializeTestPoison): Deleted.
2026         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2027         (TestWebKitAPI::TEST):
2028         (TestWebKitAPI::passWithRef):
2029         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2030         (TestWebKitAPI::TEST):
2031         (TestWebKitAPI::f1):
2032         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2033         (TestWebKitAPI::TEST):
2034         (TestWebKitAPI::poisonedPtrFoo):
2035         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2036         (TestWebKitAPI::TEST):
2037         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2038         (TestWebKitAPI::TEST):
2039
2040 2018-01-13  David Kilzer  <ddkilzer@apple.com>
2041
2042         check-webkit-style: false positive for [whitespace/braces] with os_log format string
2043         <https://webkit.org/b/181606>
2044
2045         Reviewed by Darin Adler.
2046
2047         * Scripts/webkitpy/style/checkers/cpp.py:
2048         (check_spacing): Modify regular expression to ignore
2049         os_log format strings like '%{public}'.
2050         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2051         (CppStyleTest.test_spacing_before_braces): Add os_log
2052         format string test.
2053
2054 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2055
2056         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2057         https://bugs.webkit.org/show_bug.cgi?id=181626
2058
2059         Reviewed by Joseph Pecoraro.
2060
2061         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2062         Additionally, write a new API test covering the change in r226915.
2063
2064         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2065         (webViewForTestingAttachments):
2066         (TestWebKitAPI::TEST):
2067
2068 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2069
2070         History state should be updated during client redirects with asynchronous policy decisions
2071         https://bugs.webkit.org/show_bug.cgi?id=181358
2072         <rdar://problem/35547689>
2073
2074         Reviewed by Andy Estes.
2075
2076         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2077         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2078         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2079         (TEST):
2080
2081 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2082
2083         webkitpy: Refactor simulator code (Part 4)
2084         https://bugs.webkit.org/show_bug.cgi?id=180555
2085         <rdar://problem/36131381>
2086
2087         Reviewed by Aakash Jain.
2088
2089         Move new_simulated_device.py to simulated_device.py.
2090
2091         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2092         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2093         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2094         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2095         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2096
2097 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2098
2099         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
2100         https://bugs.webkit.org/show_bug.cgi?id=181595
2101
2102         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
2103         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
2104         I change the < and > to $ to make this test pass and continue to test what it used to.
2105
2106         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
2107         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2108         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2109
2110 2018-01-11  Keith Miller  <keith_miller@apple.com>
2111
2112         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2113         https://bugs.webkit.org/show_bug.cgi?id=181573
2114
2115         Reviewed by Simon Fraser.
2116
2117         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2118
2119 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
2120
2121         [WebAuthN] Import a CBOR coder from Chromium
2122         https://bugs.webkit.org/show_bug.cgi?id=181522
2123         <rdar://problem/36055729>
2124
2125         Reviewed by Brent Fulgham.
2126
2127         This patch also imports all unit tests into our API tests to ensure all
2128         workarounds and modification against the original codebase doesn't change
2129         any original functionalities.
2130
2131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2132         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
2135         (TestWebKitAPI::TEST):
2136         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
2137         (TestWebKitAPI::eq):
2138         Workarounds applied.
2139         (TestWebKitAPI::TEST):
2140
2141 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2142
2143         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
2144         https://bugs.webkit.org/show_bug.cgi?id=181538
2145         <rdar://problem/36440580>
2146
2147         Reviewed by Aakash Jain.
2148
2149         When disambiguating a device type, it is possible that the provided device type is sufficiently
2150         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
2151         will result in a failure to disambiguate the type.
2152
2153         * Scripts/webkitpy/xcode/new_simulated_device.py:
2154         (SimulatedDeviceManager._disambiguate_device_type):
2155
2156 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
2157
2158         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
2159         https://bugs.webkit.org/show_bug.cgi?id=181136
2160         <rdar://problem/36116604>
2161
2162         Reviewed by Chris Dumez.
2163
2164         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
2165         browsing sessions.
2166
2167         * Scripts/run-gtk-tests:
2168         (GtkTestRunner): Unskip test now that it passes.
2169         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2170         (TEST): Add new WebsiteDataStoreEphemeral test.
2171
2172 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2173
2174         Unreviewed, rolling out r226816.
2175
2176         This change broke LayoutTests on the bots.
2177
2178         Reverted changeset:
2179
2180         "run-webkit-tests fails when there is a curly brace in Xcode
2181         build output"
2182         https://bugs.webkit.org/show_bug.cgi?id=181254
2183         https://trac.webkit.org/changeset/226816
2184
2185 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2186
2187         webkitpy: Fix flakey webserver tests
2188         https://bugs.webkit.org/show_bug.cgi?id=181555
2189         <rdar://problem/36448273>
2190
2191         Reviewed by Aakash Jain.
2192
2193         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2194         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
2195         determine if a specific server is running.
2196
2197 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2198
2199         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
2200         https://bugs.webkit.org/show_bug.cgi?id=181561
2201         <rdar://problem/36452652>
2202
2203         Reviewed by Aakash Jain.
2204
2205         BeautifulSoup.find may return None, this case should be gracefully handled.
2206
2207         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2208         (BugzillaQueries._parse_result_count):
2209         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
2210
2211 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
2212
2213         run-webkit-tests fails when there is a curly brace in Xcode build output
2214         https://bugs.webkit.org/show_bug.cgi?id=181254
2215
2216         Reviewed by Daniel Bates.
2217
2218         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2219         (MeteredStream.write):
2220
2221 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2222
2223         webkitpy: Reimplement simulator code (Part 3)
2224         https://bugs.webkit.org/show_bug.cgi?id=180555
2225         <rdar://problem/36131381>
2226
2227         Reviewed by Aakash Jain.
2228
2229         Remove old simulator code.
2230
2231         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
2232         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
2233         * Scripts/webkitpy/xcode/simulator.py: Removed.
2234         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
2235
2236 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2237
2238         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
2239         https://bugs.webkit.org/show_bug.cgi?id=181337
2240         <rdar://problem/36324813>
2241
2242         Reviewed by Tim Horton.
2243
2244         Add 3 new API tests for attachment element dragging.
2245
2246         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2247         (-[TestWKWebView expectElementTag:toComeBefore:]):
2248         (-[NSItemProvider expectType:withData:]):
2249         (TestWebKitAPI::TEST):
2250
2251 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2252
2253         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
2254         https://bugs.webkit.org/show_bug.cgi?id=179621
2255         <rdar://problem/35589585>
2256
2257         Unreviewed infrastructure fix.
2258
2259         * Scripts/webkitpy/port/mac.py:
2260         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
2261         list if we are the VERSION_MAX, which usually corresponds with future.
2262
2263 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
2264
2265         CodeBlocks should be in IsoSubspaces
2266         https://bugs.webkit.org/show_bug.cgi?id=180884
2267
2268         Reviewed by Saam Barati.
2269         
2270         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
2271         shouldn't take a long time due to benchmarks we don't optimize for.
2272         
2273         * Scripts/run-jsc-benchmarks:
2274
2275 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
2276
2277         Test gardening for GTK.
2278         https://bugs.webkit.org/show_bug.cgi?id=181477
2279
2280         Unreviewed test gardening.
2281
2282         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
2283         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
2284
2285 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2286
2287         Add the new JSCOnly bot to the scheduler.
2288         https://bugs.webkit.org/show_bug.cgi?id=181487
2289
2290         Unreviewed follow-up patch after r226729
2291
2292         On r226729 I missed to add the new JSCOnly bot the default scheduler.
2293         This is needed to make the bot automatically pick each commit for testing.
2294
2295         * BuildSlaveSupport/build.webkit.org-config/config.json:
2296
2297 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2298
2299         [Attachment Support] Support dragging attachment elements out as files on iOS
2300         https://bugs.webkit.org/show_bug.cgi?id=181199
2301         <rdar://problem/36299316>
2302
2303         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
2304
2305         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
2306         attachment API tests.
2307
2308         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2309         (-[NSItemProvider expectType:withData:]):
2310         (TestWebKitAPI::TEST):
2311
2312         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
2313         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
2314         -expectType:withData: helper to inspect the item providers created from the drag source.
2315
2316         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2317         (TestWebKitAPI::TEST):
2318         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2319         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2320         (-[MockDragSession localContext]):
2321         (-[MockDragSession setLocalContext:]):
2322         (-[DataInteractionSimulator _resetSimulatedState]):
2323         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
2324         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2325         (-[DataInteractionSimulator _advanceProgress]):
2326         (-[DataInteractionSimulator endDataTransfer]):
2327
2328         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
2329         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
2330         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
2331         MockDragSession to hold on to a localContext.
2332
2333 2018-01-11  Ali Juma  <ajuma@chromium.org>
2334
2335         Unreviewed. Add Ali Juma as contributor
2336
2337         * Scripts/webkitpy/common/config/contributors.json:
2338
2339 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2340
2341         Unreviewed. Update Selenium WebDriver imported tests.
2342
2343         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
2344         environment variables.
2345
2346         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2347         (collect): Reorder the arguments to make pytest happy.
2348         (run): Ditto.
2349         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2350         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
2351
2352 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
2353
2354         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
2355         https://bugs.webkit.org/show_bug.cgi?id=181492
2356         <rdar://problem/36359679>
2357
2358         Reviewed by Alexey Proskuryakov. 
2359
2360 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
2361
2362         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
2363         https://bugs.webkit.org/show_bug.cgi?id=181475
2364
2365         Reviewed by Michael Catanzaro.
2366
2367         * gtk/install-dependencies: Update package list for Arch Linux, extend
2368         message shown at end of installation with additional tips.
2369
2370 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2371
2372         REGRESSION(r222507): Composition highlight doesn't render when using IME
2373         https://bugs.webkit.org/show_bug.cgi?id=181485
2374         <rdar://problem/35896516>
2375
2376         Reviewed by Ryosuke Niwa.
2377
2378         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
2379         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
2380         allow rendering composition backgrounds (see InlineTextBox::paint).
2381
2382         * DumpRenderTree/ios/TextInputControllerIOS.m:
2383         (+[TextInputController isSelectorExcludedFromWebScript:]):
2384         (+[TextInputController webScriptNameForSelector:]):
2385         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2386         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2387         * DumpRenderTree/mac/TextInputControllerMac.m:
2388         (+[TextInputController isSelectorExcludedFromWebScript:]):
2389         (+[TextInputController webScriptNameForSelector:]):
2390         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2391         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2392         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2393         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2394         (WTR::TextInputController::setMarkedText):
2395         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2396
2397 2018-01-10  JF Bastien  <jfbastien@apple.com>
2398
2399         Poison small JSObject derivatives which only contain pointers
2400         https://bugs.webkit.org/show_bug.cgi?id=181483
2401         <rdar://problem/36407127>
2402
2403         Reviewed by Mark Lam.
2404
2405         Test the new move-assign and move-copy from unique_ptr, as well as
2406         nullptr_t ctors.
2407
2408         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2409         (TestWebKitAPI::TEST):
2410         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2411         (TestWebKitAPI::TEST):
2412         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2413         (TestWebKitAPI::TEST):
2414
2415 2018-01-10  Chris Dumez  <cdumez@apple.com>
2416
2417         Multiple http/wpt/beacon/contentextensions/ test are flaky.
2418         https://bugs.webkit.org/show_bug.cgi?id=179256
2419         <rdar://problem/35401978>
2420
2421         Reviewed by Alex Christensen.
2422
2423         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
2424         instance gets its own folder to avoid conflicts and flakiness.
2425
2426         * WebKitTestRunner/mac/TestControllerMac.mm:
2427         (WTR::TestController::platformConfigureViewForTest):
2428
2429 2018-01-10  Tim Horton  <timothy_horton@apple.com>
2430
2431         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
2432         https://bugs.webkit.org/show_bug.cgi?id=181269
2433         <rdar://problem/35110344>
2434
2435         Reviewed by Simon Fraser.
2436
2437         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2438         (WTR::UIScriptController::beginBackSwipe):
2439         (WTR::UIScriptController::completeBackSwipe):
2440         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2441         (WTR::UIScriptController::beginBackSwipe):
2442         (WTR::UIScriptController::completeBackSwipe):
2443         (WTR::UIScriptController::overridePreference):
2444         (WTR::UIScriptController::replaceTextAtRange):
2445         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2446         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2447         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2448         (WTR::UIScriptController::beginBackSwipe):
2449         (WTR::UIScriptController::completeBackSwipe):
2450         Implement beginBackSwipe and completeBackSwipe on iOS (they already
2451         exist on Mac) in terms of the new WKWebView testing SPI.
2452
2453 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2454
2455         REGRESSION (r226715): ignore WARNING output in linter tests
2456         https://bugs.webkit.org/show_bug.cgi?id=181486
2457         <rdar://problem/36408847>
2458
2459         Reviewed by Aakash Jain.
2460
2461         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
2462
2463         * Scripts/webkitpy/common/system/outputcapture.py:
2464         (OutputCapture.__init__): Pass logging level to be captured.
2465         * Scripts/webkitpy/style/main_unittest.py:
2466         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
2467         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
2468         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
2469         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
2470         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
2471         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
2472         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
2473         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
2474
2475 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2476
2477         Add a JSCOnly MIPS buildbot
2478         https://bugs.webkit.org/show_bug.cgi?id=181487
2479
2480         Reviewed by Michael Catanzaro.
2481
2482         Add the new bot configs definitions for the master and update the unit tests.
2483
2484         * BuildSlaveSupport/build.webkit.org-config/config.json:
2485         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2486
2487 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2488
2489         REGRESSION (r226715): don't re-check number of simulators in child processes
2490         https://bugs.webkit.org/show_bug.cgi?id=181484
2491         <rdar://problem/36407151>
2492
2493         Reviewed by Aakash Jain.
2494
2495         * Scripts/webkitpy/port/ios_simulator.py:
2496         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
2497         are already initialized.
2498
2499 2018-01-10  Commit Queue  <commit-queue@webkit.org>
2500
2501         Unreviewed, rolling out r226667 and r226673.
2502         https://bugs.webkit.org/show_bug.cgi?id=181488
2503
2504         This caused a flaky crash. (Requested by mlewis13 on #webkit).
2505
2506         Reverted changesets:
2507
2508         "CodeBlocks should be in IsoSubspaces"
2509         https://bugs.webkit.org/show_bug.cgi?id=180884
2510         https://trac.webkit.org/changeset/226667
2511
2512         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
2513         https://bugs.webkit.org/show_bug.cgi?id=180884
2514         https://trac.webkit.org/changeset/226673
2515
2516 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2517
2518         Follow-up fix to r226715
2519         https://bugs.webkit.org/show_bug.cgi?id=180555
2520         <rdar://problem/36131381>
2521
2522         Unreviewed infrastructure fix.
2523
2524         * Scripts/webkitpy/xcode/new_simulated_device.py:
2525         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
2526         of delete.
2527
2528 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2529
2530         webkitpy: Refactor simulator code (Part 2)
2531         https://bugs.webkit.org/show_bug.cgi?id=180555
2532         <rdar://problem/36131381>
2533
2534         Reviewed by Aakash Jain.
2535
2536         The patch leverages the SimulatedDeviceManager when running layout tests.
2537         This patch is primarily code removal, since much of the IOSSimulatorPort
2538         was dedicated to managing simulators. The removed code is either now owned by the
2539         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
2540         boot multiple simulators which was made obsolete in Xcode 9.
2541
2542         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2543         (Manager._custom_device_for_test.in): Device names now have spaces in them,
2544         strip those spaces.
2545         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2546         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
2547         * Scripts/webkitpy/port/ios.py:
2548         (IOSPort.__init__): The _current_device idiom is no longer required since the
2549         SimulatedDeviceManager keeps track of any previously booted devices.
2550         (IOSPort.target_host): Even when only a single device is used, it will be accessed
2551         through the array of managed devices.
2552         (IOSPort.using_multiple_devices): Deleted.
2553         * Scripts/webkitpy/port/ios_device.py:
2554         (IOSDevicePort.using_multiple_devices): Deleted.
2555         * Scripts/webkitpy/port/ios_simulator.py:
2556         (IOSSimulatorPort): Remove constants required to manage simulators, change device
2557         class strings so they can be parsed by the DeviceType class.
2558         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
2559         the number of simulators currently booted, the number of child processes specified
2560         and the maximum number of simulators supported by this system.
2561         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
2562         devices owned by the SimulatedDeviceManager.
2563         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
2564         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
2565         the maximum number of supported simulators on this system.
2566         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
2567         request for each child process and send this list to the SimulatedDeviceManager to
2568         initialize the devices.
2569         (IOSSimulatorPort.clean_up_test_run):
2570         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
2571         specified version of iOS.
2572         (IOSSimulatorPort.reset_preferences):
2573         (IOSSimulatorPort.simulator_runtime): Deleted.
2574         (IOSSimulatorPort.simulator_device_type): Deleted.
2575         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
2576         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
2577         (IOSSimulatorPort._create_simulators): Deleted.
2578         (IOSSimulatorPort._quit_ios_simulator): Deleted.
2579         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
2580         (IOSSimulatorPort.using_multiple_devices): Deleted.
2581         (IOSSimulatorPort._create_device): Deleted.
2582         (IOSSimulatorPort.get_simulator_path): Deleted.
2583         (IOSSimulatorPort._createSimulatorApps): Deleted.
2584         (IOSSimulatorPort._createSimulatorApp): Deleted.
2585         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2586         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
2587         maximum number of simulators run on this system.
2588         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
2589         * Scripts/webkitpy/xcode/new_simulated_device.py:
2590         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
2591
2592 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2593
2594         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
2595         https://bugs.webkit.org/show_bug.cgi?id=181474
2596
2597         Reviewed by Carlos Alberto Lopez Perez.
2598
2599         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
2600         name as the name.
2601
2602         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2603         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
2604         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
2605
2606 2018-01-09  Andy Estes  <aestes@apple.com>
2607
2608         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
2609         https://bugs.webkit.org/show_bug.cgi?id=181459
2610
2611         Reviewed by Dan Bernstein.
2612
2613         * ImageDiff/cg/Configurations/Base.xcconfig:
2614
2615 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
2616
2617         font-display:fallback can cause a visual flash (which is supposed to be impossible)
2618         https://bugs.webkit.org/show_bug.cgi?id=181374
2619
2620         Reviewed by Simon Fraser.
2621
2622         The test requires Palatino.
2623
2624         * DumpRenderTree/mac/DumpRenderTree.mm:
2625         (allowedFontFamilySet):
2626         * WebKitTestRunner/mac/TestControllerMac.mm:
2627         (WTR::allowedFontFamilySet):
2628
2629 2018-01-09  Saam Barati  <sbarati@apple.com>
2630
2631         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
2632         https://bugs.webkit.org/show_bug.cgi?id=181449
2633
2634         Reviewed by JF Bastien.
2635
2636         This allows me to Cmd+f in my terminal to search for things without
2637         having the results become misaligned.
2638
2639         * Scripts/display-profiler-output:
2640
2641 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2642
2643         [webkitpy] PlatformInfo should have default argument for casual use
2644         https://bugs.webkit.org/show_bug.cgi?id=180827
2645
2646         Reviewed by David Kilzer.
2647
2648         PlatformInfo should be the only way to check platform specific thing instead
2649         of sys.platform or other various checks. If there is something you want to check,
2650         it should be placed in PlatformInfo.
2651
2652         Currently to instantiate PlatformInfo, it requires arguments, which is usually
2653         sys, platform and Executive(). They are straight forward and should be handled
2654         by default arguments. Then we can instantiate PlatformInfo more casual.
2655
2656         * Scripts/webkitpy/common/system/platforminfo.py:
2657         (PlatformInfo): Use relative module path import
2658         (PlatformInfo.__init__):
2659         (PlatformInfo.executive): Lazy instantiation of Executive()
2660         (PlatformInfo.total_bytes_memory): Accessing via above property
2661         (PlatformInfo.xcode_sdk_version): Ditto
2662         (PlatformInfo.xcode_simctl_list): Ditto
2663         (PlatformInfo.xcode_version): Ditto
2664         (PlatformInfo._win_version_str): Ditto
2665         * Scripts/webkitpy/common/system/systemhost.py:
2666         (SystemHost.__init__):
2667         * Scripts/webkitpy/common/system/user.py:
2668         (User.__init__):
2669
2670 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2671
2672         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
2673         https://bugs.webkit.org/show_bug.cgi?id=176443
2674
2675         Reviewed by Darin Adler.
2676
2677         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
2678         (TEST):
2679
2680 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
2681
2682         check-webkit-style: Verify syntax for WK_API_AVAILABLE
2683         https://bugs.webkit.org/show_bug.cgi?id=181394
2684
2685         Reviewed by Darin Adler.
2686
2687         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
2688         as the second parameter instead of ios(WK_IOS_TBA). This generally
2689         builds for iOS on EWS but not when using the public SDK. See r224057,
2690         r223207 and r226211 for example. This patch adds a basic style check
2691         for that macro to prevent this kind of mistake.
2692
2693         * Scripts/webkitpy/style/checkers/cpp.py:
2694         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
2695         (check_style): Run new style check.
2696         (CppChecker): Add build type for the new style check.
2697         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2698         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
2699
2700 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2701
2702         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
2703         https://bugs.webkit.org/show_bug.cgi?id=181420
2704         <rdar://problem/36365827>
2705
2706         Reviewed by Alex Christensen.
2707
2708         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
2709         of corresponding _WKAttachments.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2712         (TestWebKitAPI::TEST):
2713
2714 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2715
2716         Add WKNavigationDelegate SPI exposing WebProcess crash reason
2717         https://bugs.webkit.org/show_bug.cgi?id=181410
2718         <rdar://problem/36167199>
2719
2720         Reviewed by Wenson Hsieh.
2721
2722         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2723         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
2724         (TEST):
2725
2726 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2727
2728         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
2729         https://bugs.webkit.org/show_bug.cgi?id=181408
2730         <rdar://problem/35884960>
2731
2732         Reviewed by Tim Horton.
2733
2734         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2735         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2736
2737 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2738
2739         [Attachment Support] Expose file name and content type of WKAttachment
2740         https://bugs.webkit.org/show_bug.cgi?id=181390
2741         <rdar://problem/36336837>
2742
2743         Reviewed by Tim Horton.
2744
2745         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
2746
2747         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2748         (-[_WKAttachment synchronouslyRequestInfo:]):
2749         (-[_WKAttachment synchronouslyRequestData:]):
2750
2751         Reimplement this in terms of -synchronouslyRequestInfo:.
2752
2753         (-[_WKAttachment expectRequestedDataToBe:]):
2754         (TestWebKitAPI::TEST):
2755
2756 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2757
2758         Copying, pasting, and then deleting an attachment element breaks attachment data requests
2759         https://bugs.webkit.org/show_bug.cgi?id=181365
2760         <rdar://problem/36340647>
2761
2762         Reviewed by Tim Horton.
2763
2764         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
2765         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
2766         detail.
2767
2768         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2769         (TestWebKitAPI::TEST):
2770
2771 2018-01-08  Youenn Fablet  <youenn@apple.com>
2772
2773         navigator.onLine does not work inside service workers
2774         https://bugs.webkit.org/show_bug.cgi?id=181079
2775         <rdar://problem/36178606>
2776
2777         Reviewed by Darin Adler.
2778
2779         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2780         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
2781
2782 2018-01-07  Saam Barati  <sbarati@apple.com>
2783
2784         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
2785         https://bugs.webkit.org/show_bug.cgi?id=181372
2786
2787         Reviewed by Filip Pizlo.
2788
2789         Adding these sorting modes makes it easier to analyze functions
2790         that recompile a lot and exit a lot.
2791
2792         * Scripts/display-profiler-output:
2793
2794 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
2795
2796         Unreviewed, remove my Cisco email from contributors.json
2797
2798         * Scripts/webkitpy/common/config/contributors.json:
2799
2800 2018-01-05  JF Bastien  <jfbastien@apple.com>
2801
2802         WebAssembly: poison JS object's secrets
2803         https://bugs.webkit.org/show_bug.cgi?id=181339
2804         <rdar://problem/36325001>
2805
2806         Reviewed by Mark Lam.
2807
2808         Update tests for swap(Poisoned<k, T>, T*)
2809
2810         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
2811         (TestWebKitAPI::TEST):
2812         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2813         (TestWebKitAPI::TEST):
2814         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2815         (TestWebKitAPI::TEST):
2816
2817 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2818
2819         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
2820         https://bugs.webkit.org/show_bug.cgi?id=181359
2821
2822         Reviewed by Tim Horton.
2823
2824         Ensure that these tests still pass using older SDKs.
2825
2826         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2827         (TestWebKitAPI::TEST):
2828
2829 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2830
2831         Rebase API test after r226469
2832         https://bugs.webkit.org/show_bug.cgi?id=181308
2833
2834         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
2835         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2836         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
2837
2838 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2839
2840         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
2841         https://bugs.webkit.org/show_bug.cgi?id=181217
2842
2843         Reviewed by Tim Horton.
2844
2845         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2846         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2847         (TEST):
2848
2849 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2850
2851         Add WKBundleFrameCreateFrameHandle
2852         https://bugs.webkit.org/show_bug.cgi?id=181232
2853         <rdar://problem/35926696>
2854
2855         Reviewed by Tim Horton.
2856
2857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2858         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
2859         (mouseDidMoveOverElement):
2860         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
2861         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2862         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
2863         (TEST):
2864
2865 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
2866
2867         iOS: Build fix after r226432.
2868         
2869         Unreviewed. Stop duplicating speakAs symbols for iOS.
2870
2871         * DumpRenderTree/AccessibilityUIElement.cpp:
2872         (AccessibilityUIElement::speakAs):
2873
2874 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
2875
2876         Unreviewed, added myself as WebKit reviewer
2877
2878         * Scripts/webkitpy/common/config/contributors.json:
2879
2880 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
2881
2882         WPE: Build fix after r226432.
2883
2884         Unreviewed. Rename ::speak() to ::speakAs().
2885         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2886         (WTR::AccessibilityUIElement::speakAs):
2887         (WTR::AccessibilityUIElement::speak): Deleted.
2888
2889 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
2890
2891         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
2892         https://bugs.webkit.org/show_bug.cgi?id=180361
2893
2894         Reviewed by Zalan Bujtas.
2895
2896         * DumpRenderTree/AccessibilityUIElement.cpp:
2897         (speakAsCallback):
2898         (AccessibilityUIElement::speakAs):
2899         (AccessibilityUIElement::getJSClass):
2900         (speakCallback): Deleted.
2901         (AccessibilityUIElement::speak): Deleted.
2902         * DumpRenderTree/AccessibilityUIElement.h:
2903         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2904         (AccessibilityUIElement::speakAs):
2905         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2906         (AccessibilityUIElement::speakAs):
2907         (AccessibilityUIElement::speak): Deleted.
2908         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2909         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2910         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2911         (WTR::AccessibilityUIElement::speakAs):
2912         (WTR::AccessibilityUIElement::speak): Deleted.
2913         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2914         (WTR::AccessibilityUIElement::speakAs):
2915         (WTR::AccessibilityUIElement::speak): Deleted.
2916
2917 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
2918
2919         REGRESSION (r226395): test-webkitperl test expectations incorrect
2920         https://bugs.webkit.org/show_bug.cgi?id=181307
2921         <rdar://problem/36306558>
2922
2923         Rubber-stamped by Aakash Jain.
2924
2925         r226395 added two lines towards the beginning of
2926         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
2927         numbers in the test expectations need to update.
2928
2929         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2930
2931 2018-01-04  Tim Horton  <timothy_horton@apple.com>
2932
2933         WKWebView loses minimum layout size overrides that happen while the process is terminated
2934         https://bugs.webkit.org/show_bug.cgi?id=181306
2935         <rdar://problem/34398288>
2936
2937         Reviewed by Dan Bernstein.
2938
2939         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2940         (TEST):
2941         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
2942         while the process is terminated results in the page getting the correct
2943         minimum layout size.
2944
2945 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
2946
2947         [MediaStream] Add Mock screen capture source
2948         https://bugs.webkit.org/show_bug.cgi?id=181291
2949         <rdar://problem/36298164>
2950
2951         Reviewed by Dean Jackson.
2952
2953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
2954         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2955         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2956
2957 2018-01-04  Lucas Forschler  <lforschler@apple.com>
2958
2959         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
2960
2961         Reviewed by Ling Ho.
2962
2963         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2964
2965 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2966
2967         [Attachment Support] Create attachment elements when dropping files on iOS
2968         https://bugs.webkit.org/show_bug.cgi?id=181192
2969         <rdar://problem/36280945>
2970
2971         Reviewed by Tim Horton.
2972
2973         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
2974         switch is enabled. See below for more details.
2975
2976         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2977         (-[NSItemProvider registerData:type:]):
2978         (platformCopyPNG):
2979         (TestWebKitAPI::TEST):
2980         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2981
2982         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
2983         source item provider when dragging rich text *without* attachments, so this should have been a check for just
2984         kUTTypeRTF instead.
2985
2986         (TestWebKitAPI::TEST):
2987
2988         Tests a few cases of inserting attachment elements via drop:
2989         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
2990             Instead of inserting the contents as inline web content, this should generate attachment elements.
2991         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
2992             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
2993             back to inserting the content as an attachment.
2994         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
2995             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
2996             or at the end).
2997
2998         * TestWebKitAPI/cocoa/TestWKWebView.h:
2999         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3000         (-[TestWKWebView objectByEvaluatingJavaScript:]):
3001
3002         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
3003         -stringByEvaluatingJavaScript to just turn around and call this.
3004
3005         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3006
3007 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
3008
3009         Replace hard-coded paths in shebangs with #!/usr/bin/env
3010         https://bugs.webkit.org/show_bug.cgi?id=181040
3011
3012         Reviewed by Alex Christensen.
3013
3014         * BuildSlaveSupport/build-launcher-app:
3015         * BuildSlaveSupport/build-launcher-dmg:
3016         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3017         * BuildSlaveSupport/built-product-archive:
3018         * BuildSlaveSupport/clean-build:
3019         * BuildSlaveSupport/delete-stale-build-files:
3020         * BuildSlaveSupport/download-built-product:
3021         * BuildSlaveSupport/gtk/buildbot/log/run:
3022         * BuildSlaveSupport/gtk/buildbot/run:
3023         * BuildSlaveSupport/gtk/pulseaudio/run:
3024         * BuildSlaveSupport/kill-old-processes:
3025         * BuildSlaveSupport/test-result-archive:
3026         * BuildSlaveSupport/win/kill-old-processes:
3027         * Scripts/SpacingHeuristics.pm:
3028         * Scripts/add-include:
3029         * Scripts/build-api-tests:
3030         * Scripts/build-dumprendertree:
3031         * Scripts/build-imagediff:
3032         * Scripts/build-jsc:
3033         * Scripts/build-webkit:
3034         * Scripts/build-webkittestrunner:
3035         * Scripts/check-Xcode-source-file-types:
3036         * Scripts/check-dom-results:
3037         * Scripts/check-for-exit-time-destructors:
3038         * Scripts/check-for-global-initializers:
3039         * Scripts/check-for-inappropriate-objc-class-names:
3040         * Scripts/check-for-weak-vtables-and-externals:
3041         * Scripts/clean-header-guards:
3042         * Scripts/compare-timing-files:
3043         * Scripts/configure-xcode-for-ios-development:
3044         * Scripts/copy-webkitlibraries-to-product-directory:
3045         * Scripts/create-exports:
3046         * Scripts/debug-minibrowser:
3047         * Scripts/debug-safari:
3048         * Scripts/debug-test-runner:
3049         * Scripts/do-file-rename:
3050         * Scripts/do-webcore-rename:
3051         * Scripts/dump-webkit-tests-run:
3052         * Scripts/ensure-valid-python:
3053         * Scripts/execAppWithEnv:
3054         * Scripts/extract-localizable-js-strings:
3055         * Scripts/filter-build-webkit:
3056         * Scripts/find-extra-includes:
3057         * Scripts/fix-blink-patch:
3058         * Scripts/generate-coverage-data:
3059         * Scripts/git-add-reviewer:
3060         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3061         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
3062         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
3063         * Scripts/make-new-script-test:
3064         * Scripts/make-script-test-wrappers:
3065         * Scripts/package-root:
3066         * Scripts/parse-malloc-history:
3067         * Scripts/report-include-statistics:
3068         * Scripts/resolve-ChangeLogs:
3069         * Scripts/run-api-tests:
3070         * Scripts/run-bindings-tests:
3071         * Scripts/run-content-extension-tester:
3072         * Scripts/run-iexploder-tests:
3073         * Scripts/run-javascriptcore-tests:
3074         * Scripts/run-jsc:
3075         * Scripts/run-leaks:
3076         * Scripts/run-mangleme-tests:
3077         * Scripts/run-minibrowser:
3078         * Scripts/run-pageloadtest:
3079         * Scripts/run-regexp-tests:
3080         * Scripts/run-safari:
3081         * Scripts/run-sunspider:
3082         * Scripts/run-test-runner:
3083         * Scripts/run-webkit-app:
3084         * Scripts/run-webkit-httpd:
3085         * Scripts/run-webkit-websocketserver:
3086         * Scripts/set-webkit-configuration:
3087         * Scripts/show-pretty-diff:
3088         * Scripts/sort-Xcode-project-file:
3089         * Scripts/split-file-by-class:
3090         * Scripts/sunspider-compare-results:
3091         * Scripts/svn-apply:
3092         * Scripts/svn-unapply:
3093         * Scripts/test-webkit-scripts:
3094         * Scripts/test-webkitperl:
3095         * Scripts/update-iexploder-cssproperties:
3096         * Scripts/update-javascriptcore-test-results:
3097         * Scripts/update-webkit:
3098         * Scripts/update-webkit-auxiliary-libs:
3099         * Scripts/update-webkit-dependency:
3100         * Scripts/update-webkit-libs-jhbuild:
3101         * Scripts/update-webkit-localizable-strings:
3102         * Scripts/update-webkit-support-libs:
3103         * Scripts/update-webkitgtk-libs:
3104         * Scripts/update-webkitwpe-libs:
3105         * Scripts/webkit-build-directory:
3106         * Scripts/webkitperl/LoadAsModule.pm:
3107         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
3108         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3109         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
3110         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
3111         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
3112         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3113         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3114         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3115         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3116         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3117         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
3118         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
3119         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
3120         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3121         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3122         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3123         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3124         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
3125         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
3126         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
3127         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
3128         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
3129         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
3130         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3131         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3132         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3133         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
3134         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
3135         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
3136         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3137         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3138         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
3139         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
3140         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
3141         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
3142         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3143         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3144         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
3145         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
3146         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
3147         * ccache/ccache-clang:
3148         * ccache/ccache-clang++:
3149         * ccache/ccache-wrapper:
3150         * gtk/install-dependencies:
3151         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
3152         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
3153         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
3154         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
3155         * iExploder/iexploder-1.3.2/tools/showtest.rb:
3156         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
3157         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
3158         * iExploder/iexploder-1.7.2/src/webserver.rb:
3159         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
3160         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
3161         * wpe/install-dependencies:
3162
3163 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
3164
3165         filter-build-webkit filters out useful compiler error lines
3166         https://bugs.webkit.org/show_bug.cgi?id=179864
3167
3168         Reviewed by Tim Horton.
3169
3170         Don't filter out lines that contain information about build errors by always showing lines
3171         after a line that contains "note:" or "error:".
3172
3173         * Scripts/filter-build-webkit:
3174         (shouldShowSubsequentLine):
3175         (shouldIgnoreLine):
3176
3177 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3178
3179         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
3180         https://bugs.webkit.org/show_bug.cgi?id=173915
3181
3182         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
3183         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
3184         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
3185         empty string in this case.
3186
3187         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3188         (emitFormSubmissionEvent):
3189
3190 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3191
3192         [GTK] Add web process API to detect when form is submitted via JavaScript
3193         https://bugs.webkit.org/show_bug.cgi?id=173915
3194
3195         Reviewed by Carlos Garcia Campos.
3196
3197         Test it.
3198
3199         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3200         (FormSubmissionTest::FormSubmissionTest):
3201         (FormSubmissionTest::~FormSubmissionTest):
3202         (FormSubmissionTest::testFormSubmissionResult):
3203         (FormSubmissionTest::willSendDOMEventCallback):
3204         (FormSubmissionTest::willCompleteCallback):
3205         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
3206         (testWebExtensionFormSubmissionSteps):
3207         (beforeAll):
3208         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3209         (DelayedSignal::DelayedSignal):
3210         (emitFormSubmissionEvent):
3211         (handleFormSubmissionCallback):
3212         (willSubmitFormCallback):
3213         (pageCreatedCallback):
3214
3215 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3216
3217         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
3218         https://bugs.webkit.org/show_bug.cgi?id=181251
3219
3220         * Scripts/run-gtk-tests:
3221         (GtkTestRunner):
3222
3223 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3224
3225         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
3226         https://bugs.webkit.org/show_bug.cgi?id=181136
3227
3228         * Scripts/run-gtk-tests:
3229         (GtkTestRunner):
3230
3231 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
3232
3233         [macOS, iOS] Adopt new secure coding APIs in WebKit
3234         https://bugs.webkit.org/show_bug.cgi?id=181085
3235         <rdar://problem/34837397>
3236
3237         Reviewed by Tim Horton.
3238
3239         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
3240         capable of supporting NSSecureCoding, so pass through the current coding routines.
3241
3242         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
3243         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
3244         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
3245         routines if necessary.
3246         (TEST): Updated for NSSecureCoding.
3247         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
3248         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
3249
3250 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3251
3252         Remove std::chrono completely
3253         https://bugs.webkit.org/show_bug.cgi?id=181186
3254
3255         Reviewed by Alex Christensen.
3256
3257         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3258         (WTR::TestController::platformRunUntil):
3259
3260 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3261
3262         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
3263         https://bugs.webkit.org/show_bug.cgi?id=181231
3264
3265         Reviewed by Alex Christensen.
3266
3267         Implement TestController APIs needed by ResourceLoadStatistics tests.
3268
3269         * WebKitTestRunner/TestController.cpp:
3270         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3271         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3272
3273 2018-01-02  Tim Horton  <timothy_horton@apple.com>
3274
3275         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
3276         https://bugs.webkit.org/show_bug.cgi?id=181219
3277
3278         Reviewed by Wenson Hsieh.
3279
3280         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3281
3282 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3283
3284         Add a WebAuthentication runtime feature flag
3285         https://bugs.webkit.org/show_bug.cgi?id=181220
3286         <rdar://problem/36055305>
3287
3288         Reviewed by Brent Fulgham.
3289
3290         Renames the CredentialManagement runtime feature flag into WebAuthentication.
3291
3292         * DumpRenderTree/TestOptions.h:
3293         * DumpRenderTree/TestOptions.mm:
3294         (TestOptions::TestOptions):
3295         * DumpRenderTree/mac/DumpRenderTree.mm:
3296         (enableExperimentalFeatures):
3297         (setWebPreferencesForTestOptions):
3298         * WebKitTestRunner/TestController.cpp:
3299         (WTR::TestController::resetPreferencesToConsistentValues):
3300         (WTR::updateTestOptionsFromTestHeader):
3301         * WebKitTestRunner/TestOptions.h:
3302         (WTR::TestOptions::hasSameInitializationOptions const):
3303
3304 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3305
3306         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
3307         https://bugs.webkit.org/show_bug.cgi?id=181143
3308         <rdar://problem/36200381>
3309
3310         Reviewed by Tim Horton.
3311
3312         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
3313         attachment elements are enabled.
3314
3315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3316         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3317         (TestWebKitAPI::TEST):
3318
3319 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3320
3321         Update Credential Management API for WebAuthentication
3322         https://bugs.webkit.org/show_bug.cgi?id=181082
3323         <rdar://problem/36055239>
3324
3325         Reviewed by Brent Fulgham.
3326
3327         Enable Credential Management API for testing.
3328
3329         * DumpRenderTree/TestOptions.h:
3330         * WebKitTestRunner/TestOptions.h:
3331
3332 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3333
3334         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
3335         https://bugs.webkit.org/show_bug.cgi?id=168194
3336
3337         Reviewed by Carlos Garcia Campos.
3338
3339         Fix an assertion and unskip the test. The order that form controls are associated is not
3340         guaranteed.
3341
3342         * Scripts/run-gtk-tests:
3343         (GtkTestRunner):
3344         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3345         (didAssociateFormControlsCallback):
3346
3347 2018-01-02  Alex Christensen  <achristensen@webkit.org>
3348
3349         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
3350         https://bugs.webkit.org/show_bug.cgi?id=180897
3351         <rdar://problem/35535328>
3352
3353         Reviewed by Brent Fulgham.
3354
3355         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
3356
3357         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3358         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3359         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
3360         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3361         (websiteDataStoreTestWebView):
3362         (TEST):
3363
3364 == Rolled over to ChangeLog-2018-01-01 ==