Enable HAVE_AVFOUNDATION_VIDEO_OUTPUT on PLATFORM(IOSMAC)
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
4         https://bugs.webkit.org/show_bug.cgi?id=196675
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
9         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
10
11 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
12
13         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
14         https://bugs.webkit.org/show_bug.cgi?id=196919
15         <rdar://problem/41630459>
16
17         Reviewed by Tim Horton.
18
19         Add iOS support for several new testing hooks. See below for more detail.
20
21         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
22         (WTR::UIScriptController::isDismissingMenu const):
23
24         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
25         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
26         by UIKit when dismissing the callout bar (i.e. UIMenuController).
27
28         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
29         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
30         (WTR::UIScriptController::isDismissingMenu const):
31         * TestRunnerShared/UIScriptContext/UIScriptController.h:
32         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
33         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
34         (WTR::InjectedBundle::didReceiveMessageToPage):
35         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
36         (WTR::TestRunner::setAllowedMenuActions):
37
38         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
39         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
40         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
41         against the name of the custom action.
42
43         (WTR::TestRunner::installCustomMenuAction):
44
45         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
46         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
47         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
48         triggered.
49
50         (WTR::TestRunner::performCustomMenuAction):
51
52         Invoked when the custom menu action is triggered.
53
54         * WebKitTestRunner/InjectedBundle/TestRunner.h:
55         * WebKitTestRunner/TestController.cpp:
56         (WTR::TestController::installCustomMenuAction):
57         (WTR::TestController::setAllowedMenuActions):
58         * WebKitTestRunner/TestController.h:
59         * WebKitTestRunner/TestInvocation.cpp:
60         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
61         (WTR::TestInvocation::performCustomMenuAction):
62
63         Add plumbing to call back into the injected bundle when performing the custom action.
64
65         * WebKitTestRunner/TestInvocation.h:
66         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
67         (WTR::TestController::installCustomMenuAction):
68         (WTR::TestController::setAllowedMenuActions):
69         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
70         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
71         (-[TestRunnerWKWebView initWithFrame:configuration:]):
72         (-[TestRunnerWKWebView becomeFirstResponder]):
73         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
74
75         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
76         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
77         in the Mail app on iOS.
78
79         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
80         (-[TestRunnerWKWebView setAllowedMenuActions:]):
81         (-[TestRunnerWKWebView resetCustomMenuAction]):
82         (-[TestRunnerWKWebView performCustomAction:]):
83         (-[TestRunnerWKWebView canPerformAction:withSender:]):
84         (-[TestRunnerWKWebView _willHideMenu]):
85         (-[TestRunnerWKWebView _didHideMenu]):
86         * WebKitTestRunner/ios/TestControllerIOS.mm:
87         (WTR::TestController::platformResetStateToConsistentValues):
88
89         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
90         if specified.
91
92         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
93         (WTR::UIScriptController::isDismissingMenu const):
94
95 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
96
97         Allow sharing from imageSheet on an image document
98         https://bugs.webkit.org/show_bug.cgi?id=196891
99         <rdar://problem/25377386>
100
101         Reviewed by Tim Horton.
102
103         Test to make sure that the correct imageURL is extracted from an image element.
104
105         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
106         (TestWebKitAPI::TEST):
107
108 2019-04-16  Alex Christensen  <achristensen@webkit.org>
109
110         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
111         https://bugs.webkit.org/show_bug.cgi?id=196995
112
113         Reviewed by Brady Eidson.
114
115         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
116         (TEST):
117
118 2019-04-16  Chris Dumez  <cdumez@apple.com>
119
120         URL set by document.open() is not communicated to the UIProcess
121         https://bugs.webkit.org/show_bug.cgi?id=196941
122         <rdar://problem/49237544>
123
124         Reviewed by Geoff Garen.
125
126         Add API test coverage.
127
128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
129         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
130         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
131         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
132         (TEST):
133
134 2019-04-16  Commit Queue  <commit-queue@webkit.org>
135
136         Unreviewed, rolling out r244321.
137         https://bugs.webkit.org/show_bug.cgi?id=196968
138
139         Causing all WK2 Debug builds to exit early after Assertion
140         failures. (Requested by ShawnRoberts on #webkit).
141
142         Reverted changeset:
143
144         "URL set by document.open() is not communicated to the
145         UIProcess"
146         https://bugs.webkit.org/show_bug.cgi?id=196941
147         https://trac.webkit.org/changeset/244321
148
149 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
150
151         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
152         https://bugs.webkit.org/show_bug.cgi?id=196948
153
154         Reviewed by Zalan Bujtas.
155
156         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
157         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
158
159 2019-04-15  Chris Dumez  <cdumez@apple.com>
160
161         URL set by document.open() is not communicated to the UIProcess
162         https://bugs.webkit.org/show_bug.cgi?id=196941
163         <rdar://problem/49237544>
164
165         Reviewed by Geoffrey Garen.
166
167         Add API test coverage.
168
169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
170         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
171         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
172         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
173         (TEST):
174
175 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
176
177         Using Tools/Scripts/clean-webkit should not install requests
178         https://bugs.webkit.org/show_bug.cgi?id=196940
179
180         Reviewed by Lucas Forschler.
181
182         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
183         existing, depending on the path autoinstalled is run through.
184         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
185         needed.
186         (Port.configuration_for_upload):
187         (Port.commits_for_upload):
188
189 2019-04-15  Alex Christensen  <achristensen@webkit.org>
190
191         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
192         https://bugs.webkit.org/show_bug.cgi?id=196773
193
194         Reviewed by Jer Noble.
195
196         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
197         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
198         (TEST):
199
200 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
201
202         ews-build should clearly indicate flaky test failures
203         https://bugs.webkit.org/show_bug.cgi?id=196947
204
205         Reviewed by Lucas Forschler.
206
207         * BuildSlaveSupport/ews-build/steps.py:
208         (AnalyzeAPITestsResults.analyzeResults):
209
210 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
211
212         InjectedBundle parameters often need initialization function called before unarchiving
213         https://bugs.webkit.org/show_bug.cgi?id=189709
214         <rdar://problem/44573653>
215
216         Reviewed by Ryosuke Niwa.
217
218         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
219         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
220
221 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
222
223         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
224         https://bugs.webkit.org/show_bug.cgi?id=196681
225
226         Reviewed by Darin Adler.
227
228         Added tests.
229
230         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
231         (WTF_HashSet.RemoveIf):
232         (WTF_HashSet.RemoveIfShrinkToBestSize):
233
234 2019-04-15  John Wilander  <wilander@apple.com>
235
236         Send delayed Ad Click Attribution conversion requests to the click source
237         https://bugs.webkit.org/show_bug.cgi?id=196838
238         <rdar://problem/47650157>
239
240         Reviewed by Chris Dumez and Youenn Fablet.
241
242         This patch adds test infrastructure to override the default behavior in
243         WebKit::NetworkAdClickAttribution.
244
245         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
246         (TestWebKitAPI::TEST):
247         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
248         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
249         (WTR::TestRunner::dumpAdClickAttribution):
250         (WTR::TestRunner::clearAdClickAttribution):
251         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
252         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
254         * WebKitTestRunner/TestController.cpp:
255         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
256         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
257         * WebKitTestRunner/TestController.h:
258         * WebKitTestRunner/TestInvocation.cpp:
259         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
260
261 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
262
263         [ews-app] status-bubble should display position in queue
264         https://bugs.webkit.org/show_bug.cgi?id=196607
265
266         Reviewed by Lucas Forschler.
267
268         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
269         (StatusBubble._build_bubble):
270         (StatusBubble._queue_position): Method to calculate patch's position in queue.
271
272 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
273
274         [ews-build] Do not run clean build by default on EWS builders
275         https://bugs.webkit.org/show_bug.cgi?id=196897
276
277         Reviewed by Lucas Forschler.
278
279         * BuildSlaveSupport/ews-build/steps.py:
280         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
281         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
282         untracked directories like WebKitBuild).
283         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
284         untracked files/directories (like WebKitBuild).
285
286 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
287
288         TestRunner::notifyDone() should be safely reentrant
289         https://bugs.webkit.org/show_bug.cgi?id=196898
290
291         Reviewed by Darin Adler.
292
293         It is currently possible that TestRunner::notifyDone() will call itself, since
294         notifyDone() will force a repaint, which can start executing JavaScript, which
295         may call notifyDone() again. This can lead to test failures and flakiness.
296         Fix this by setting the m_waitToDump flag before calling the dump() method.
297
298         * DumpRenderTree/mac/TestRunnerMac.mm:
299         (TestRunner::notifyDone):
300         (TestRunner::forceImmediateCompletion):
301         * DumpRenderTree/win/TestRunnerWin.cpp:
302         (TestRunner::notifyDone):
303         (TestRunner::forceImmediateCompletion):
304
305 2019-04-15  Philippe Normand  <pnormand@igalia.com>
306
307         [GTK][WPE] Add enable-media websetting
308         https://bugs.webkit.org/show_bug.cgi?id=196863
309
310         Reviewed by Michael Catanzaro.
311
312         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
313         (testWebKitSettings): Add test for the enable-media web-setting.
314
315 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
316
317         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
318         https://bugs.webkit.org/show_bug.cgi?id=196905
319         <rdar://problem/49886096>
320
321         Reviewed by Tim Horton.
322
323         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
324         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
325         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
326         delay timer, we end up with this sequence of events in the problematic (failure) case:
327
328         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
329             ...IPC from UI to web process...
330         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
331             ...IPC from web to UI process...
332         (c) [UI]    Invoke completion handler for script #1
333         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
334             ...IPC from UI to web process...
335         (e) [Web]   Evaluate script #2 in the web process
336         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
337
338         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
339         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
340         #2 is run in step (e).
341
342         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
343         the UI process by waiting on a script message posted by the web process, after attachment updates are
344         dispatched.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
347         (TestWebKitAPI::TEST):
348
349 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
350
351         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
352         https://bugs.webkit.org/show_bug.cgi?id=196909
353
354         Reviewed by Wenson Hsieh.
355
356         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
357         (TestWebKitAPI::TEST):
358
359 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
360
361         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
362         https://bugs.webkit.org/show_bug.cgi?id=196880
363
364         Reviewed by Yusuke Suzuki.
365
366         Add a new function for bytecode cache tests that does not forceDiskCache
367         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
368         test added in this patch, since the code is invalid and therefore won't be
369         cached. It should also be useful for tests that evaluate dynamically
370         generated code.
371
372         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
373         * Scripts/run-jsc-stress-tests:
374
375 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
376
377         Update AudioSession route sharing policy
378         https://bugs.webkit.org/show_bug.cgi?id=196776
379         <rdar://problem/46501611>
380
381         Reviewed by Jer Noble.
382
383         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
384         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
385         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
386         (TestWebKitAPI::TEST):
387
388 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
389
390         [iOS] Software keyboard is shown too frequently on some websites
391         https://bugs.webkit.org/show_bug.cgi?id=195856
392         <rdar://problem/49191395>
393
394         Reviewed by Darin Adler.
395
396         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
397
398         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
399         (WTR::UIScriptController::setHardwareKeyboardAttached):
400         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
401         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
402         (WTR::UIScriptController::setHardwareKeyboardAttached):
403         * TestRunnerShared/UIScriptContext/UIScriptController.h:
404         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
405
406         Additionally link against GraphicsServices in WebKitTestRunner.
407
408         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
409         (WTR::TestController::platformResetStateToConsistentValues):
410         (WTR::UIScriptController::setHardwareKeyboardAttached):
411
412 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
413
414         [GTK][WPE] Fix pacman install-dependencies packages
415         https://bugs.webkit.org/show_bug.cgi?id=196817
416
417         Reviewed by Žan Doberšek.
418         
419         python3-setuptools is called python-setuptools
420         ruby-highline is only available on AUR
421         libv4l-devel is incorporated in v4l-utils
422
423         * gtk/install-dependencies:
424         * wpe/install-dependencies:
425
426 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
427
428         [GTK] REGRESSION(r243860): Many tests failing
429         https://bugs.webkit.org/show_bug.cgi?id=196791
430
431         Reviewed by Joanmarie Diggs.
432
433         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
434         multiple documents and check that accessibility hierarchy is updated after a navigation.
435
436         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
437         (loadChangedCallback):
438         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
439         (AccessibilityTest::AccessibilityTest):
440         (AccessibilityTest::~AccessibilityTest):
441         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
442         (AccessibilityTest::findTestServerApplication):
443         (AccessibilityTest::findDocumentWeb):
444         (AccessibilityTest::findRootObject):
445         (AccessibilityTest::waitUntilChildrenRemoved):
446         (AccessibilityTest::ensureProxy):
447         (testAtspiBasicHierarchy):
448         (beforeAll):
449         (afterAll):
450
451 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-build] Handle bug titles with unicode characters
454         https://bugs.webkit.org/show_bug.cgi?id=196802
455
456         Reviewed by Dewei Zhu.
457
458         * BuildSlaveSupport/ews-build/steps.py:
459         (ValidatePatch._is_bug_closed):
460
461 2019-04-11  Michael Saboff  <msaboff@apple.com>
462
463         Improve the Inline Cache Stats code
464         https://bugs.webkit.org/show_bug.cgi?id=196836
465
466         Reviewed by Saam Barati.
467
468         Added a new script to consolidate and arrange the output of --useICStats option.
469
470         This script merges the output from every group into one large table and sorts it from most common to
471         least common.  It also counts the slow path GetById and PutById variants and then calculates the
472         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
473         Put together, this is useful to see what property accesses are not getting cached.
474
475         * Scripts/ic-stats.py: Added.
476         (ICStats):
477         (ICStats.__init__):
478         (ICStats.parse):
479         (ICStats.dumpStats):
480         (usage):
481
482 2019-04-10  Alex Christensen  <achristensen@webkit.org>
483
484         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
485         https://bugs.webkit.org/show_bug.cgi?id=196809
486         <rdar://49800762>
487
488         Reviewed by Brady Eidson.
489
490         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
491         (TEST):
492
493 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
494
495         requestAnimationFrame should execute before the next frame
496         https://bugs.webkit.org/show_bug.cgi?id=177484
497
498         Reviewed by Simon Fraser.
499
500         Add trace points for the page RenderingUpdate.
501
502         * Tracing/SystemTracePoints.plist:
503
504 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
505
506         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
507         https://bugs.webkit.org/show_bug.cgi?id=196760
508
509         Reviewed by Don Olmstead.
510
511         vswhere.exe has been bundled since Visual Studio 2017 version
512         15.2. We shouldn't download vswhere.exe.
513
514         * Scripts/build-jsc: Do not call update-vswhere.py.
515         * Scripts/build-webkit: Ditto.
516         * Scripts/update-vswhere.py: Removed.
517         * Scripts/webkitdirs.pm:
518         (requireModulesForVSWhere): Deleted.
519         (pickCurrentVisualStudioInstallation): Deleted.
520         (visualStudioInstallDirVSWhere): Return the latest installed VS
521         installation path by using the bundled vswhere.exe.
522         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
523         (visualStudioInstallDirFallback): Removed.
524
525 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
526
527         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
528         https://bugs.webkit.org/show_bug.cgi?id=196780
529
530         Reviewed by Alexey Proskuryakov.
531
532         * BuildSlaveSupport/ews-build/steps.py:
533         * BuildSlaveSupport/ews-build/steps_unittest.py:
534
535 2019-04-10  Alex Christensen  <achristensen@webkit.org>
536
537         Add SPI WKNavigationResponse._downloadAttribute
538         https://bugs.webkit.org/show_bug.cgi?id=196755
539         <rdar://49587365>
540
541         Reviewed by Brady Eidson.
542
543         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
544         (-[NavigationResponseTestDelegate navigationResponse]):
545         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
546         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
547         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
548         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
549         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
550         (readRequest):
551         (writeResponse):
552         (TEST):
553
554 2019-04-10  Tim Horton  <timothy_horton@apple.com>
555
556         Add modern API for overriding the page's specified viewport configuration
557         https://bugs.webkit.org/show_bug.cgi?id=167734
558         <rdar://problem/30331795>
559
560         Reviewed by Simon Fraser.
561
562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
563         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
564
565 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
566
567         Add support for incremental bytecode cache updates
568         https://bugs.webkit.org/show_bug.cgi?id=195000
569
570         Reviewed by Filip Pizlo.
571
572         Exit when the initial run to generate bytecode fails.
573
574         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
575
576 2019-04-10  Alex Christensen  <achristensen@webkit.org>
577
578         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
579         https://bugs.webkit.org/show_bug.cgi?id=196744
580         <rdar://49415309>
581
582         Reviewed by Chris Dumez.
583
584         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
585         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
586
587 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
588
589         Add a way to opt into modern compatibility mode in layout tests
590         https://bugs.webkit.org/show_bug.cgi?id=196770
591         <rdar://problem/49777550>
592
593         Reviewed by Antoine Quint.
594
595         Add a new test option to enable modern compatibility mode in layout tests.
596
597         * WebKitTestRunner/TestController.cpp:
598         (WTR::updateTestOptionsFromTestHeader):
599         * WebKitTestRunner/TestController.h:
600         * WebKitTestRunner/TestOptions.h:
601         (WTR::TestOptions::hasSameInitializationOptions const):
602         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
603         (WTR::TestController::platformCreateWebView):
604         (WTR::TestController::enableModernCompatibilityMode):
605
606 2019-04-10  Andy Estes  <aestes@apple.com>
607
608         Try to fix the 32-bit watchOS build.
609
610         * TestWebKitAPI/cocoa/TestWKWebView.mm:
611         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
612
613 2019-04-10  Antoine Quint  <graouts@apple.com>
614
615         Enable Pointer Events on watchOS
616         https://bugs.webkit.org/show_bug.cgi?id=196771
617         <rdar://problem/49040909>
618
619         Reviewed by Dean Jackson.
620
621         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
622
623 2019-04-10  Philippe Normand  <pnormand@igalia.com>
624
625         Unreviewed. Fix WPE accessibility tests after r244059.
626
627         We are failing to load the injected bundle due to undefined symbol
628         AccessibilityUIElement::replaceTextInRange().
629
630         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
631         (WTR::AccessibilityUIElement::replaceTextInRange):
632
633 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
634
635         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
636         https://bugs.webkit.org/show_bug.cgi?id=196727
637
638         Reviewed by Fujii Hironori.
639
640         * MiniBrowser/win/WebKitBrowserWindow.cpp:
641         (WebKitBrowserWindow::create):
642
643 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
644
645         [ews-build] Add unit tests for PrintConfiguration
646         https://bugs.webkit.org/show_bug.cgi?id=196752
647
648         Reviewed by Dewei Zhu.
649
650         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
651
652 2019-04-09  Keith Rollin  <krollin@apple.com>
653
654         Unreviewed build maintenance -- update .xcfilelists.
655
656         * DumpRenderTree/DerivedSources-input.xcfilelist:
657         * DumpRenderTree/DerivedSources-output.xcfilelist:
658
659 2019-04-09  Zalan Bujtas  <zalan@apple.com>
660
661         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
662         https://bugs.webkit.org/show_bug.cgi?id=196743
663         <rdar://problem/43897551>
664
665         Reviewed by Tim Horton.
666
667         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
668         (TEST):
669
670 2019-04-09  Youenn Fablet  <youenn@apple.com>
671
672         Close service worker database on network process suspension
673         https://bugs.webkit.org/show_bug.cgi?id=196623
674         <rdar://problem/48930869>
675
676         Reviewed by Alex Christensen.
677
678         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
679
680 2019-04-09  Daniel Bates  <dabates@apple.com>
681
682         [iPad] Should open popover when the spacebar is pressed
683         https://bugs.webkit.org/show_bug.cgi?id=196360
684         <rdar://problem/49389129>
685
686         Reviewed by Brent Fulgham.
687
688         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
689
690         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
691         (WTR::UIScriptController::isShowingPopover const): Added.
692         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
693         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
694         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
695         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
696         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
697         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
698         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
699         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
700         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
701         (WTR::UIScriptController::isShowingPopover const): Added.
702         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
703         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
704         * TestRunnerShared/UIScriptContext/UIScriptController.h:
705         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
706         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
707         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
708         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
709         (-[TestRunnerWKWebView _willPresentPopover]): Added.
710         (-[TestRunnerWKWebView _didDismissPopover]): Added.
711         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
712         (WTR::UIScriptController::isShowingPopover const): Added.
713         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
714         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
715
716 2019-04-09  Alex Christensen  <achristensen@webkit.org>
717
718         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
719         https://bugs.webkit.org/show_bug.cgi?id=196665
720         <rdar://45115669>
721
722         Reviewed by Geoff Garen.
723
724         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
725         (goBack):
726         (+[SimpleLookupContext sharedLookupContext]):
727         (-[SimpleLookupContext lookUpURL:completionHandler:]):
728         (TEST):
729         (+[Simple3LookupContext sharedLookupContext]): Deleted.
730         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
731
732 2019-04-09  John Wilander  <wilander@apple.com>
733
734         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
735         https://bugs.webkit.org/show_bug.cgi?id=196558
736         <rdar://problem/47650245>
737
738         Reviewed by Youenn Fablet.
739
740         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
741         (TestWebKitAPI::TEST):
742             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
743
744 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
745
746         [CMake] Apple builds should use ICU_INCLUDE_DIRS
747         https://bugs.webkit.org/show_bug.cgi?id=196720
748
749         Reviewed by Konstantin Tokarev.
750
751         * TestWebKitAPI/PlatformMac.cmake:
752
753 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
754
755         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
756         https://bugs.webkit.org/show_bug.cgi?id=196694
757         <rdar://problem/48388734>
758
759         Rubber-stamped by Aakash Jain.
760
761         * Scripts/webkitpy/port/image_diff.py:
762         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
763         * Scripts/webkitpy/port/server_process.py:
764         (ServerProcess.has_available_stdout): Check if stdout has data in it.
765         (ServerProcess._wait_for_data_and_update_buffers_using_select):
766         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
767         * Scripts/webkitpy/port/server_process_mock.py:
768         (MockServerProcess.has_available_stdout):
769         * Scripts/webkitpy/port/server_process_unittest.py:
770         (TestServerProcess.serial_test_basic):
771
772 2019-04-09  Jer Noble  <jer.noble@apple.com>
773
774         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
775         https://bugs.webkit.org/show_bug.cgi?id=196097
776
777         Reviewed by Eric Carlson.
778
779         Drive-by bug fix: allow tests to play audio without a user gesture by default.
780
781         * DumpRenderTree/mac/DumpRenderTree.mm:
782         (resetWebPreferencesToConsistentValues):
783         * WebKitTestRunner/TestController.cpp:
784         (WTR::TestController::resetPreferencesToConsistentValues):
785
786 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
787
788         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
789         https://bugs.webkit.org/show_bug.cgi?id=196690
790
791         Reviewed by Michael Catanzaro.
792
793         * QueueStatusServer/config/queues.py:
794         * Scripts/webkitpy/common/config/ews.json:
795         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
796         (test_ews_name):
797
798 2019-04-09  Chris Dumez  <cdumez@apple.com>
799
800         Loads using loadHTMLString() cause flashing when process-swapping
801         https://bugs.webkit.org/show_bug.cgi?id=196714
802         <rdar://problem/49637354>
803
804         Reviewed by Antti Koivisto.
805
806         Add API test coverage.
807
808         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
809
810 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
811
812         Unreviewed. Fix ATK accessibility tests after r244059.
813
814         We are failing to load the injected bundle due to undefined symbol
815         AccessibilityUIElement::replaceTextInRange().
816
817         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
818         (WTR::AccessibilityUIElement::replaceTextInRange):
819
820 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
821
822         AX: Support API: accessibilityReplaceRange:withText
823         https://bugs.webkit.org/show_bug.cgi?id=196636
824
825         Unreviewed build fix for Windows port.
826
827         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
828         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
829
830 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
831
832         [CMake][WinCairo] Separate copied headers into different directories
833         https://bugs.webkit.org/show_bug.cgi?id=196655
834
835         Reviewed by Michael Catanzaro.
836
837         * DumpRenderTree/CMakeLists.txt:
838         * MiniBrowser/win/CMakeLists.txt:
839         * TestWebKitAPI/CMakeLists.txt:
840         * TestWebKitAPI/PlatformWin.cmake:
841
842 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
843
844         Log stack-trace for run-webkit-tests when interrupted
845         https://bugs.webkit.org/show_bug.cgi?id=176393
846         <rdar://problem/34262310>
847
848         Reviewed by Lucas Forschler.
849
850         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
851         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
852         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
853         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
854         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
855         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
856         (main): Set handlers to log stack trace on interruption.
857
858 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
859
860         AX: Support API: accessibilityReplaceRange:withText
861         https://bugs.webkit.org/show_bug.cgi?id=196636
862
863         Unreviewed build fix for Windows port.
864
865         * DumpRenderTree/AccessibilityUIElement.cpp:
866         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
867
868 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
869
870         [ews-build] Scripts using Buildbot API have CORS error
871         https://bugs.webkit.org/show_bug.cgi?id=196709
872
873         Reviewed by Alexey Proskuryakov.
874
875         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
876
877 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
878
879         AX: Support API: accessibilityReplaceRange:withText
880         https://bugs.webkit.org/show_bug.cgi?id=196636
881
882         Reviewed by Daniel Bates.
883
884         * DumpRenderTree/AccessibilityUIElement.cpp:
885         (replaceTextInRangeCallback):
886         (AccessibilityUIElement::replaceTextInRange):
887         (AccessibilityUIElement::getJSClass):
888         * DumpRenderTree/AccessibilityUIElement.h:
889         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
890         (AccessibilityUIElement::replaceTextInRange):
891         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
892         (AccessibilityUIElement::replaceTextInRange):
893         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
894         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
895         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
896         (WTR::AccessibilityUIElement::replaceTextInRange):
897         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
898         (WTR::AccessibilityUIElement::replaceTextInRange):
899
900 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
901
902         [iOS] Do not allow starting selection drags when selection views are not visible
903         https://bugs.webkit.org/show_bug.cgi?id=196686
904         <rdar://problem/49399192>
905
906         Reviewed by Tim Horton.
907
908         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
909         also add some new API tests to cover scenarios where the web view is not first responder.
910
911         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
912         (TestWebKitAPI::TEST):
913         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
914
915         Add a switch to optionally make the web view first responder when starting the simulated drag.
916
917         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
918         (-[DragAndDropSimulator initWithWebView:]):
919         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
920
921 2019-04-08  Justin Fan  <justin_fan@apple.com>
922
923         [Web GPU] Fix Web GPU experimental feature on iOS
924         https://bugs.webkit.org/show_bug.cgi?id=196632
925
926         Reviewed by Myles C. Maxfield.
927
928         Properly make Web GPU available on iOS 11+.
929
930         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
931
932 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
933
934         [ews-build] Do not upload archive when Compile Fails
935         https://bugs.webkit.org/show_bug.cgi?id=196674
936
937         Reviewed by Alexey Proskuryakov.
938
939         * BuildSlaveSupport/ews-build/factories.py:
940         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
941         * BuildSlaveSupport/ews-build/steps.py:
942         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
943         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
944         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
945
946 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
947
948         Enable DFG on MIPS
949         https://bugs.webkit.org/show_bug.cgi?id=196689
950
951         Reviewed by Žan Doberšek.
952
953         Since the bytecode change, we enabled the baseline JIT on mips in
954         r240432, but DFG is still missing. With this change, all tests are
955         passing on a ci20 board.
956
957         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
958
959 2019-04-08  Philippe Normand  <pnormand@igalia.com>
960
961         [Flatpak] Second run update-webkitwpe-flatpak fails
962         https://bugs.webkit.org/show_bug.cgi?id=192702
963
964         Reviewed by Carlos Garcia Campos.
965
966         * flatpak/flatpakutils.py:
967         (FlatpakObject.flatpak): Fix typo.
968         (FlatpakPackage.install): When installing, also update to the configured remote commit.
969         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
970
971 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
972
973         [GTK][WPE] outlook.live.com displays old-fashioned UI
974         https://bugs.webkit.org/show_bug.cgi?id=196642
975
976         Reviewed by Carlos Garcia Campos.
977
978         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
979         (TestWebKitAPI::TEST): New Mac platform quirk test.
980
981 2019-04-07  Commit Queue  <commit-queue@webkit.org>
982
983         Unreviewed, rolling out r243956.
984         https://bugs.webkit.org/show_bug.cgi?id=196688
985
986         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
987         by aakashjain on #webkit).
988
989         Reverted changeset:
990
991         "Clicking "Go Back" from a safe browsing warning from an
992         iframe should navigate the WKWebView back to the previous
993         page"
994         https://bugs.webkit.org/show_bug.cgi?id=196665
995         https://trac.webkit.org/changeset/243956
996
997 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
998
999         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1000         https://bugs.webkit.org/show_bug.cgi?id=196669
1001
1002         Reviewed by Geoffrey Garen.
1003
1004         Added three new unit tests for WeakHashSet.
1005
1006         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1007         (WTF_WeakPtr.WeakHashSetConstObjects):
1008         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1009         (WTF_WeakPtr.WeakHashSetComputeSize):
1010
1011 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1012
1013         Hide next and previous form control buttons when WKWebView is editable
1014         https://bugs.webkit.org/show_bug.cgi?id=196672
1015         <rdar://problem/35625321>
1016
1017         Reviewed by Tim Horton.
1018
1019         Add a new API test.
1020
1021         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1022         (-[TestWKWebView lastTrailingBarButtonGroup]):
1023         (TestWebKitAPI::TEST):
1024         * TestWebKitAPI/ios/UIKitSPI.h:
1025
1026 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1027
1028         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1029         https://bugs.webkit.org/show_bug.cgi?id=196077
1030         <rdar://problem/49108202>
1031
1032         Reviewed by Chris Dumez.
1033
1034         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1035         on new web view.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1038
1039 2019-04-05  Saam Barati  <sbarati@apple.com>
1040
1041         Make compare-results understand MotionMark
1042         https://bugs.webkit.org/show_bug.cgi?id=196666
1043
1044         Reviewed by Yusuke Suzuki.
1045
1046         * Scripts/compare-results:
1047         (PLT5Results):
1048         (detectMotionMark):
1049         (detectMotionMark1_1):
1050         (motionMarkResults):
1051         (motionMark1_1Results):
1052         (detectBenchmark):
1053         (biggerIsBetter):
1054         (main):
1055
1056 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1057
1058         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1059         https://bugs.webkit.org/show_bug.cgi?id=196665
1060         <rdar://45115669>
1061
1062         Reviewed by Geoff Garen.
1063
1064         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1065         (goBack):
1066         (+[SimpleLookupContext sharedLookupContext]):
1067         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1068         (TEST):
1069         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1070         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1071
1072 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1073
1074         [ews-build] Add configuration and architecture for windows builders
1075         https://bugs.webkit.org/show_bug.cgi?id=196660
1076
1077         Reviewed by Lucas Forschler.
1078
1079         * BuildSlaveSupport/ews-build/config.json:
1080
1081 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1082
1083         webkitpy: Don't run subsequent rounds if interrupted
1084         https://bugs.webkit.org/show_bug.cgi?id=196646
1085
1086         Reviewed by Aakash Jain.
1087
1088         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1089         (Manager.run): Bail out if interrupted.
1090
1091 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1092
1093         Test sessionStorage in PSON private browsing mode
1094         https://bugs.webkit.org/show_bug.cgi?id=196561
1095
1096         Reviewed by Alex Christensen.
1097
1098         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1099
1100 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1101
1102         Unreviewed, rolling out r243833.
1103         https://bugs.webkit.org/show_bug.cgi?id=196645
1104
1105         This change breaks build of WPE and GTK ports (Requested by
1106         annulen on #webkit).
1107
1108         Reverted changeset:
1109
1110         "[CMake][WTF] Mirror XCode header directories"
1111         https://bugs.webkit.org/show_bug.cgi?id=191662
1112         https://trac.webkit.org/changeset/243833
1113
1114 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1115
1116         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1117         https://bugs.webkit.org/show_bug.cgi?id=196635
1118
1119         Reviewed by Antti Koivisto.
1120         
1121         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1122         for a test to enable async frame scrolling via:
1123             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1124         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1125         
1126         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1127
1128         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1129         (WTR::InjectedBundle::beginTesting):
1130         * WebKitTestRunner/TestController.cpp:
1131         (WTR::TestController::resetPreferencesToConsistentValues):
1132
1133 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1134
1135         Use a correct LC_RPATH when building with ASan
1136         https://bugs.webkit.org/show_bug.cgi?id=196576
1137
1138         Reviewed by David Kilzer.
1139
1140         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1141         so that ../Frameworks is checked. This is simpler and more reliable than updating
1142         each SPC service xcconfig.
1143
1144 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1145
1146         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1147         https://bugs.webkit.org/show_bug.cgi?id=196629
1148
1149         Reviewed by Lucas Forschler.
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1152
1153 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1154
1155         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1156         https://bugs.webkit.org/show_bug.cgi?id=196618
1157
1158         Reviewed by Lucas Forschler.
1159
1160         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1161         (StatusBubble): Added QUEUE_TRIGGERS.
1162         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1163         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1164         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1165         its parent(builder).
1166
1167 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1168
1169         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1170         https://bugs.webkit.org/show_bug.cgi?id=196625
1171
1172         Reviewed by Lucas Forschler.
1173
1174         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1175         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1176
1177 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1178
1179         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1180         https://bugs.webkit.org/show_bug.cgi?id=196630
1181
1182         Reviewed by Wenson Hsieh.
1183
1184         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1185
1186 2019-04-04  Youenn Fablet  <youenn@apple.com>
1187
1188         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1189         https://bugs.webkit.org/show_bug.cgi?id=196543
1190
1191         Reviewed by Alex Christensen.
1192
1193         * WebKitTestRunner/TestController.cpp:
1194         (WTR::TestController::generatePageConfiguration):
1195
1196 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [ews-app] Status bubble should not display skipped buildbot steps
1199         https://bugs.webkit.org/show_bug.cgi?id=196584
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1204
1205 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1206
1207         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1208         https://bugs.webkit.org/show_bug.cgi?id=196620
1209
1210         Reviewed by Lucas Forschler.
1211
1212         * BuildSlaveSupport/ews-app/ews/config.py:
1213
1214 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1215
1216         [Win] DumpRenderTreeWatchDog.py is not checked into source
1217         https://bugs.webkit.org/show_bug.cgi?id=196567
1218         <rdar://problem/49525901>
1219
1220         Reviewed by Lucas Forschler.
1221
1222         This script is used on Win EWS bots to terminate hanging DRT processes.
1223
1224         * EWSTools/dumprendertreewatchdog.py: Added.
1225
1226 2019-04-04  Chris Dumez  <cdumez@apple.com>
1227
1228         Unreviewed, roll out r243858 which made tests time out.
1229
1230         Disable new API tests on Windows instead.
1231
1232         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1233         (TestWebKitAPI::TEST):
1234
1235 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1236
1237         [ATK] Cleanup WebPageAccessibilityObjectAtk
1238         https://bugs.webkit.org/show_bug.cgi?id=196537
1239
1240         Reviewed by Michael Catanzaro.
1241
1242         Also consider files under atk directories as exceptions for GObject conventions.
1243
1244         * Scripts/webkitpy/style/checkers/cpp.py:
1245         (check_identifier_name_in_declaration):
1246
1247 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1248
1249         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1250         https://bugs.webkit.org/show_bug.cgi?id=196588
1251         <rdar://problem/49365787>
1252
1253         Unreviewed build fix for Windows port.
1254
1255         error C3861: 'kill': identifier not found
1256
1257         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1258         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1259
1260 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1261
1262         [ews-build] Cancel build and similar operations should have authentication
1263         https://bugs.webkit.org/show_bug.cgi?id=196520
1264
1265         Reviewed by Dewei Zhu.
1266
1267         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1268         environment variables.
1269
1270 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1271
1272         [ews-build] Do not trigger queues which are not in production yet
1273         https://bugs.webkit.org/show_bug.cgi?id=196581
1274
1275         Reviewed by Dewei Zhu.
1276
1277         * BuildSlaveSupport/ews-build/config.json:
1278
1279 2019-04-03  Chris Dumez  <cdumez@apple.com>
1280
1281         Unreviewed, fix typo in the name of API test added in r243848.
1282
1283         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1284         (TestWebKitAPI::TEST):
1285
1286 2019-04-03  Chris Dumez  <cdumez@apple.com>
1287
1288         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1289         https://bugs.webkit.org/show_bug.cgi?id=196588
1290         <rdar://problem/49365787>
1291
1292         Reviewed by Ryosuke Niwa.
1293
1294         Add API test coverage.
1295
1296         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1297         (TestWebKitAPI::nullJavaScriptCallback):
1298         (TestWebKitAPI::didCrashCheckFrames):
1299         (TestWebKitAPI::TEST):
1300
1301 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1302
1303         run-webkit-tests: Upload test results (new results database)
1304         https://bugs.webkit.org/show_bug.cgi?id=196577
1305         <rdar://problem/34841155>
1306
1307         Reviewed by Lucas Forschler.
1308
1309         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1310         (Manager.run): Upload results after each device shard, since the configuration will be
1311         different for each device.
1312         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1313         uploaded to a results database.
1314         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1315         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1316
1317 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1318
1319         -apple-trailing-word is needed for browser detection
1320         https://bugs.webkit.org/show_bug.cgi?id=196575
1321
1322         Unreviewed.
1323
1324         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1325
1326 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1327
1328         [CMake][WTF] Mirror XCode header directories
1329         https://bugs.webkit.org/show_bug.cgi?id=191662
1330
1331         Reviewed by Konstantin Tokarev.
1332
1333         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1334         builds.
1335
1336         * CMakeLists.txt:
1337         * DumpRenderTree/CMakeLists.txt:
1338         * DumpRenderTree/PlatformWin.cmake:
1339         * MiniBrowser/win/CMakeLists.txt:
1340         * TestWebKitAPI/CMakeLists.txt:
1341         * TestWebKitAPI/PlatformWin.cmake:
1342         * WebKitTestRunner/PlatformGTK.cmake:
1343         * WebKitTestRunner/PlatformWin.cmake:
1344
1345 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1346
1347         [ews-app] Status bubble should not display certain infrastructure status messages
1348         https://bugs.webkit.org/show_bug.cgi?id=196550
1349
1350         Reviewed by Lucas Forschler.
1351
1352         Do not display the steps which are un-needed for end-user. This information is still avaiable
1353         if the user click on the bubble and look at the Buildbot build.
1354         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1355         (StatusBubble._steps_messages):
1356         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1357
1358 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1359
1360         [ews-build] Use https for sending data to ews-app
1361         https://bugs.webkit.org/show_bug.cgi?id=196492
1362
1363         Reviewed by Lucas Forschler.
1364
1365         * BuildSlaveSupport/ews-build/events.py:
1366
1367 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1368
1369         Remove support for -apple-trailing-word
1370         https://bugs.webkit.org/show_bug.cgi?id=196525
1371
1372         Reviewed by Zalan Bujtas.
1373
1374         This CSS property is nonstandard and not used.
1375
1376         * Scripts/webkitperl/FeatureList.pm:
1377         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1378
1379 2019-04-03  Youenn Fablet  <youenn@apple.com>
1380
1381         Add a test for DOMCache on multiple browsing in case of private browsing
1382         https://bugs.webkit.org/show_bug.cgi?id=196524
1383
1384         Reviewed by Alex Christensen.
1385
1386         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1387         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1388
1389 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1390
1391         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1392         https://bugs.webkit.org/show_bug.cgi?id=196540
1393
1394         Reviewed by Aakash Jain.
1395
1396         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1397
1398 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1399
1400         Add plumbing for a compatibility mode preference in WebKit
1401         https://bugs.webkit.org/show_bug.cgi?id=196005
1402
1403         Reviewed by Tim Horton.
1404
1405         Add new API tests.
1406
1407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1408         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1409
1410 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1411
1412         [WPE][GTK] Update libsrtp dependency package for Debian
1413         https://bugs.webkit.org/show_bug.cgi?id=196528
1414
1415         Reviewed by Frédéric Wang.
1416
1417         * gtk/install-dependencies:
1418         * wpe/install-dependencies:
1419
1420 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1421
1422         [WK2] Add support for Window's beforeprint / afterprint events
1423         https://bugs.webkit.org/show_bug.cgi?id=196478
1424         <rdar://problem/49535124>
1425
1426         Unreviewed build fix for MSVC.
1427
1428         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1429
1430         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1431
1432         * WebKitTestRunner/TestController.cpp:
1433         (WTR::printFrame): Use int and float literals.
1434
1435 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1436
1437         [ews-build] Reassign bots to queues
1438
1439         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1440
1441 2019-04-02  Chris Dumez  <cdumez@apple.com>
1442
1443         [WK2] Add support for Window's beforeprint / afterprint events
1444         https://bugs.webkit.org/show_bug.cgi?id=196478
1445
1446         Reviewed by Alex Christensen.
1447
1448         Add minimal implementation for printFrame in WebKitTestRunner.
1449
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::printFrame):
1452         (WTR::TestController::createOtherPage):
1453         (WTR::TestController::createWebViewWithOptions):
1454
1455 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1456
1457         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1458         https://bugs.webkit.org/show_bug.cgi?id=196491
1459
1460         Reviewed by Lucas Forschler.
1461
1462         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1463
1464 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1465
1466         [ews-build] Configure buildbot try credentials in environment variables
1467         https://bugs.webkit.org/show_bug.cgi?id=196501
1468
1469         Reviewed by Lucas Forschler.
1470
1471         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1472         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1473         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1474
1475 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1476
1477         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1478         https://bugs.webkit.org/show_bug.cgi?id=196496
1479         <rdar://problem/49521634>
1480
1481         Reviewed by Chris Dumez.
1482
1483         Add new API tests (see WebKit ChangeLog for more detail).
1484
1485         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1486         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1487         (TEST):
1488
1489 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1490
1491         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1492         <https://webkit.org/b/196499>
1493
1494         Reviewed by Alexey Proskuryakov.
1495
1496         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1497         ENABLE_ADDRESS_SANITIZER.
1498
1499 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1500
1501         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1502         https://bugs.webkit.org/show_bug.cgi?id=182757
1503
1504         Reviewed by Don Olmstead.
1505
1506         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1507         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1508
1509 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1510
1511         run-api-tests: Upload test results
1512         https://bugs.webkit.org/show_bug.cgi?id=196323
1513         <rdar://problem/49356714>
1514
1515         Reviewed by Lucas Forschler.
1516
1517         * Scripts/webkitpy/api_tests/manager.py:
1518         (Manager):
1519         (Manager.run): Upload results to a results database.
1520         * Scripts/webkitpy/api_tests/run_api_tests.py:
1521         (parse_args): Add upload arguments.
1522         * Scripts/webkitpy/port/base.py:
1523         (Port):
1524         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1525         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1526         with commits from any other associated repositories.
1527         * Scripts/webkitpy/port/device.py:
1528         (Device):
1529         (Device.build_version): Access build_versoin of underlying platform device.
1530         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1531         (IOSSimulatorTest):
1532         (IOSSimulatorTest.test_configuration_for_upload):
1533         * Scripts/webkitpy/port/device_port.py:
1534         (DevicePort):
1535         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1536         the same as the machine uploading results.
1537         * Scripts/webkitpy/port/mac.py:
1538         (MacPort):
1539         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1540         * Scripts/webkitpy/port/mac_unittest.py:
1541         (MacTest):
1542         (MacTest.test_configuration_for_upload):
1543         * Scripts/webkitpy/xcode/simulated_device.py:
1544         (SimulatedDeviceManager._create_device_with_runtime):
1545         (SimulatedDevice.__init__): Create simulated device with a build_version.
1546         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1547         (test_existing_simulator):
1548
1549 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1550
1551         Remove extra newline characters (Follow-up fix to r243707)
1552
1553         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1554
1555 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1556
1557         [ews-app] Use API_KEY to accept results data
1558         https://bugs.webkit.org/show_bug.cgi?id=196461
1559
1560         Reviewed by Dewei Zhu.
1561
1562         * BuildSlaveSupport/ews-app/ews/views/results.py:
1563         (Results.post): Validate EWS_API_KEY before accepting any data.
1564         * BuildSlaveSupport/ews-build/events.py:
1565         (Events.sendData): Send EWS_API_KEY if available along with event data.
1566
1567 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1568
1569         Unable to copy and paste a PDF from Notes into Mail compose body
1570         https://bugs.webkit.org/show_bug.cgi?id=196442
1571         <rdar://problem/48573098>
1572
1573         Reviewed by Tim Horton.
1574
1575         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1576         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1577         to be specified on the item providers.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1580         (TestWebKitAPI::mapItemForTesting):
1581         (TestWebKitAPI::contactItemForTesting):
1582
1583 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1584
1585         Make UIWKDocumentContext rects per-character instead of per-word
1586         https://bugs.webkit.org/show_bug.cgi?id=196459
1587
1588         Reviewed by Wenson Hsieh.
1589
1590         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1591         (TEST):
1592         Adjust test results due to switching to per-character rects.
1593
1594 2019-04-01  Chris Dumez  <cdumez@apple.com>
1595
1596         UIProcess crash when a prewarmed process is terminated
1597         https://bugs.webkit.org/show_bug.cgi?id=196451
1598         <rdar://problem/49245471>
1599
1600         Reviewed by Geoffrey Garen.
1601
1602         Add API test coverage.
1603
1604         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1605         (TEST):
1606
1607 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1608
1609         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1610         https://bugs.webkit.org/show_bug.cgi?id=196449
1611
1612         Reviewed by Lucas Forschler.
1613
1614         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1615         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1616         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1617         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1618
1619 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1620
1621         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1622         https://bugs.webkit.org/show_bug.cgi?id=196444
1623
1624         Reviewed by Lucas Forschler.
1625
1626         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1627
1628 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1629
1630         Add SPI to canonicalize NSURLs with WTF::URL
1631         https://bugs.webkit.org/show_bug.cgi?id=196415
1632         <rdar://problem/44980271>
1633
1634         Reviewed by Darin Adler.
1635
1636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1637         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1638         (TestWebKitAPI::TEST):
1639
1640 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1641
1642         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1643         https://bugs.webkit.org/show_bug.cgi?id=196441
1644
1645         Reviewed by Carlos Garcia Campos.
1646
1647         Don't cache the wpe_view_backend object that might not exist yet at the
1648         time of EventSenderProxy constructor invocation, but instead retrieve
1649         that object whenever it's required for event dispatching. This should
1650         avoid crashes in this constructor now that it's invoked before any
1651         PlatformWindow has been set up (as changed in r243496).
1652
1653         * WebKitTestRunner/EventSenderProxy.h:
1654         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1655         (WTR::viewBackend):
1656         (WTR::EventSenderProxy::EventSenderProxy):
1657         (WTR::EventSenderProxy::mouseDown):
1658         (WTR::EventSenderProxy::mouseUp):
1659         (WTR::EventSenderProxy::mouseMoveTo):
1660         (WTR::EventSenderProxy::mouseScrollBy):
1661         (WTR::EventSenderProxy::keyDown):
1662         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1663
1664 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1665
1666         [Win][WebKit] MiniBrowser should support high DPI display
1667         https://bugs.webkit.org/show_bug.cgi?id=196391
1668
1669         Reviewed by Alex Christensen.
1670
1671         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1672         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1673         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1674         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1675
1676 2019-03-31  Sam Weinig  <weinig@apple.com>
1677
1678         Remove more i386 specific configurations
1679         https://bugs.webkit.org/show_bug.cgi?id=196430
1680
1681         Reviewed by Alexey Proskuryakov.
1682
1683         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1684         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1685
1686 2019-03-31  Andy Estes  <aestes@apple.com>
1687
1688         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1689         https://bugs.webkit.org/show_bug.cgi?id=196433
1690         <rdar://problem/49293305>
1691
1692         Reviewed by Tim Horton.
1693
1694         Enhanced API test coverage to include all navigation response policy decisions in both
1695         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1696
1697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1698         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1699         (TestWebKitAPI::TEST):
1700         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1701         (readFile):
1702         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1703         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1704         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1705         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1706         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1707         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1708         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1709         (-[QuickLookDelegate _downloadDidStart:]):
1710         (-[QuickLookDelegate _download:didReceiveResponse:]):
1711         (-[QuickLookDelegate _download:didReceiveData:]):
1712         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1713         (-[QuickLookDelegate _downloadDidFinish:]):
1714         (-[QuickLookDelegate _download:didFailWithError:]):
1715         (-[QuickLookDelegate _downloadDidCancel:]):
1716         (-[QuickLookDelegate verifyDownload]):
1717         (runTest):
1718         (runTestDecideBeforeLoading):
1719         (runTestDecideAfterLoading):
1720         (TEST):
1721         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1722         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1723         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1724         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1725         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1726         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1727         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1728         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1729         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1730         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1731         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1732         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1733         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1734         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1735
1736 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1737
1738         [CMake] add testdfg as target with build-jsc
1739         https://bugs.webkit.org/show_bug.cgi?id=196393
1740
1741         Reviewed by Saam Barati.
1742
1743         Added testdfg as one of the targets to build when
1744         using CMake.
1745
1746         * Scripts/build-jsc:
1747
1748 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1749
1750         Delete WebMetal implementation in favor of WebGPU
1751         https://bugs.webkit.org/show_bug.cgi?id=195418
1752
1753         Reviewed by Dean Jackson.
1754
1755         * DumpRenderTree/mac/DumpRenderTree.mm:
1756         (enableExperimentalFeatures):
1757         (resetWebPreferencesToConsistentValues):
1758         * Scripts/webkitperl/FeatureList.pm:
1759         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1761         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1762         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1763         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1764         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1765         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1766         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1767         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1768         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1769         (WTR::InjectedBundle::beginTesting):
1770         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1771         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1773
1774 2019-03-29  Chris Dumez  <cdumez@apple.com>
1775
1776         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1777         https://bugs.webkit.org/show_bug.cgi?id=196405
1778         <rdar://problem/49428130>
1779
1780         Reviewed by Wenson Hsieh.
1781
1782         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1783         the popover presentation methods to be no-ops. Use this in the new test added in
1784         r243523 so that we do not swizzle those methods for all tests. This is needed because
1785         those WatchOS tests rely on the popover getting presented and interactive.
1786
1787         * WebKitTestRunner/TestController.cpp:
1788         (WTR::updateTestOptionsFromTestHeader):
1789         * WebKitTestRunner/TestController.h:
1790         * WebKitTestRunner/TestOptions.h:
1791         (WTR::TestOptions::hasSameInitializationOptions const):
1792         * WebKitTestRunner/ios/TestControllerIOS.mm:
1793         (WTR::TestController::platformInitialize):
1794         (WTR::TestController::platformResetStateToConsistentValues):
1795
1796 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1797
1798         [Curl] Add Server Trust Evaluation Support.
1799         https://bugs.webkit.org/show_bug.cgi?id=191646
1800
1801         Reviewed by Fujii Hironori.
1802
1803         Implemented MiniBrowser UI for asking if user trusts the server.
1804
1805         * MiniBrowser/win/Common.cpp:
1806         (askServerTrustEvaluation):
1807         (replaceString):
1808         * MiniBrowser/win/Common.h:
1809         * MiniBrowser/win/MiniBrowserLib.rc:
1810         * MiniBrowser/win/MiniBrowserLibResource.h:
1811         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1812         (createPEMString):
1813         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1814         (WebKitBrowserWindow::canTrustServerCertificate):
1815         * MiniBrowser/win/WebKitBrowserWindow.h:
1816
1817 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1818
1819         Implement ResizeObserver.
1820         https://bugs.webkit.org/show_bug.cgi?id=157743
1821
1822         Reviewed by Simon Fraser.
1823
1824         Support resizeObserverEnabled webPreferences.
1825
1826         * DumpRenderTree/TestOptions.cpp:
1827         (TestOptions::TestOptions):
1828         * DumpRenderTree/TestOptions.h:
1829         * DumpRenderTree/mac/DumpRenderTree.mm:
1830         (setWebPreferencesForTestOptions):
1831         * DumpRenderTree/win/DumpRenderTree.cpp:
1832         (enableExperimentalFeatures):
1833         * Scripts/webkitperl/FeatureList.pm:
1834         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1835
1836 2019-03-28  John Wilander  <wilander@apple.com>
1837
1838         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1839         https://bugs.webkit.org/show_bug.cgi?id=196281
1840         <rdar://problem/48938748>
1841
1842         Reviewed by Alex Christensen.
1843
1844         This patch adds the function isStatisticsHasLocalStorage() to the
1845         TestRunner. With it, the page can query the WebsiteDataStore in the
1846         UI process to make sure that it sees LocalStorage.
1847
1848         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1849         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1850         (WTR::TestRunner::isStatisticsHasLocalStorage):
1851         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1852         * WebKitTestRunner/TestController.cpp:
1853         (WTR::TestController::isStatisticsHasLocalStorage):
1854         * WebKitTestRunner/TestController.h:
1855         * WebKitTestRunner/TestInvocation.cpp:
1856         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1857
1858 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1859
1860         API::Data::createWithoutCopying should do a null check before calling CFRelease
1861         https://bugs.webkit.org/show_bug.cgi?id=196276
1862         <rdar://problem/48059859>
1863
1864         Reviewed by Alex Christensen.
1865
1866         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1867
1868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1869         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1870         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1871         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1872         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1873         (TestWebKitAPI::TEST):
1874
1875 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1876
1877         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1878         https://bugs.webkit.org/show_bug.cgi?id=186276
1879
1880         Reviewed by Carlos Garcia Campos.
1881
1882         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1883         (webViewLoadChanged):
1884         (testWebResourceGetDataError):
1885         (testWebResourceGetDataEmpty):
1886         (beforeAll):
1887         (webViewloadChanged): Deleted.
1888
1889 2019-03-27  Andy Estes  <aestes@apple.com>
1890
1891         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1892         https://bugs.webkit.org/show_bug.cgi?id=196317
1893
1894         Reviewed by Dan Bernstein.
1895
1896         package-root copies built products into a staging directory using ditto(1), which does not
1897         follow symbolic links as it traverses a directory. Now that the files in
1898         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1899         itself, these become broken links when ditto'd into the staging directory.
1900
1901         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1902
1903         * Scripts/package-root:
1904
1905 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1906
1907         [ews-app] Update display text of Submit for ews analysis
1908         https://bugs.webkit.org/show_bug.cgi?id=196309
1909
1910         Reviewed by Dewei Zhu.
1911
1912         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1913
1914 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1915
1916         run-webkit-tests should check for leaks in WebKit processes
1917         <https://webkit.org/b/193772>
1918         <rdar://problem/46526680>
1919
1920         Reviewed by Ryosuke Niwa.
1921
1922         This works by doing the following:
1923         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1924           The list of child processes are returned one per line:
1925           process.name: pid
1926         - Run the "#LIST CHILD PROCESSES" command just before the
1927           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1928           processes on the ServerProcess object.
1929         - When the `--leaks` switch is handled, run check_for_leaks() on
1930           each child process after the main test harness.
1931
1932         * DumpRenderTree/mac/DumpRenderTree.mm:
1933         (handleControlCommand):
1934         - Use strncmp() instead of strcmp().
1935         - Add support for handling "#LIST CHILD PROCESSES" command.
1936
1937         * Scripts/webkitpy/port/base.py:
1938         (Port.check_for_leaks):
1939         * Scripts/webkitpy/port/darwin.py:
1940         (DarwinPort.check_for_leaks):
1941         - Rename redundant 'process_pid' argument to 'process_id'.
1942
1943         * Scripts/webkitpy/port/driver.py:
1944         (Driver.do_post_tests_work):
1945         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1946           longer the only command this sends to WebKitTestRunner.
1947         - If the `--leaks` switch is present, send the
1948           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1949           result using Port.set_webkit_processes().
1950         (Driver._parse_child_processes_output):
1951         - Add helper method to parse list of child process names and
1952           process IDs returned from WebKitTestRunner.
1953
1954         * Scripts/webkitpy/port/ios_device.py:
1955         (IOSDevicePort.check_for_leaks):
1956         - Rename redundant 'process_pid' argument to 'process_id'.
1957
1958         * Scripts/webkitpy/port/leakdetector.py:
1959         (LeakDetector._parse_leaks_output):
1960         - Return early if there is no leaks_output.
1961         (LeakDetector.check_for_leaks):
1962         - Rename redundant 'process_pid' argument to 'process_id'.
1963
1964         * Scripts/webkitpy/port/server_process.py:
1965         (ServerProcess.__init__):
1966         (ServerProcess.child_processes):
1967         (ServerProcess.set_child_processes):
1968         - Add instance variable to Port to store list of child process
1969           names and process IDs returned from WebKitTestRunner.
1970         (ServerProcess._start):
1971         - Clear self._child_processes.
1972         (ServerProcess.stop):
1973         - If self._child_processes is set, call
1974           self._port.check_for_leaks() for each child process.
1975
1976         * Scripts/webkitpy/port/server_process_unittest.py:
1977         (TrivialMockPort.check_for_leaks):
1978         - Rename redundant 'process_pid' argument to 'process_id'.
1979
1980         * Scripts/webkitpy/port/simulator_process.py:
1981         (SimulatorProcess.stop):
1982         - If self._child_processes is set, call
1983           self._port.check_for_leaks() for each child process.
1984
1985         * Scripts/webkitpy/port/watch_device.py:
1986         (WatchDevicePort.check_for_leaks):
1987         - Rename redundant 'process_pid' argument to 'process_id'.
1988
1989         * WebKitTestRunner/TestController.cpp:
1990         (WTR::TestController::dumpResponse):
1991         - Extract method from findAndDumpWorldLeaks() so that it may be
1992           reused by findAndDumpWebKitProcessIdentifiers().
1993         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1994         - Add method to output process name and process ID of both the
1995           WebContent and Networking processes.
1996         (WTR::TestController::findAndDumpWorldLeaks):
1997         - Fix missing newline in output when there were no abandoned
1998           documents.
1999         - Call dumpResponse() for extracted code.
2000         (WTR::TestController::handleControlCommand):
2001         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2002         - Use strncmp() instead of strcmp().
2003         - Call findAndDumpWebKitProcessIdentifiers() when
2004           "#LIST CHILD PROCESSES" command is sent.
2005         * WebKitTestRunner/TestController.h:
2006         (WTR::TestController::dumpResponse):
2007         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2008         - Declare methods.
2009
2010 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2011
2012         Unreviewed. Add GLib API test cases after r243434.
2013
2014         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2015         (testWebViewActiveURI):
2016         (serverCallback):
2017         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2018         (sendRequestCallback):
2019
2020 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2021
2022         Geolocation request not complete when watch request was started in a different web process
2023         https://bugs.webkit.org/show_bug.cgi?id=195996
2024
2025         Reviewed by Alex Christensen.
2026
2027         Add a test case.
2028
2029         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2030         (TestWebKitAPI::runJavaScriptAlert):
2031         (TestWebKitAPI::TEST):
2032
2033 2019-03-26  Keith Rollin  <krollin@apple.com>
2034
2035         Update the way generate-xcfilelists returns strings from functions
2036         https://bugs.webkit.org/show_bug.cgi?id=195975
2037         <rdar://problem/49040807>
2038
2039         Reviewed by Dean Jackson.
2040
2041         There are places where generate-xcfilelists executes assignments with
2042         statements like:
2043
2044             FOO=$(some_function)
2045
2046         where "some_function" return a string by echoing it. E.g.
2047
2048             some_function()
2049             {
2050                 echo "Hello, World"
2051             }
2052
2053         This is a common idiom, but it has a problem if "some_function" needs
2054         to call "exit" in an attempt to halt the entire script right then and
2055         there. Since "some_function" is called inside of $(), it's being
2056         executed in a sub-shell. Calling exit in that sub-shell simply exits
2057         that shell; it doesn't not exit the outer shell in which the main part
2058         of the script is still running. As such, the main script keeps
2059         executing when the intent was for the script to halt.
2060
2061         The solution to this is to use a different idiom for returning
2062         strings. The one we now is to pass in the name of the variable to
2063         receive the string result:
2064
2065             some_function()
2066             {
2067                 variable_name=$1
2068                 eval $variable_name ="Hello, World"
2069             }
2070
2071         The call site now looks like
2072
2073             some_function FOO
2074
2075         Because there's no invocation of a sub-shell, some_function can now
2076         call "exit" if it wants to, and the entire script will exit at that
2077         point.
2078
2079         * Scripts/generate-xcfilelists:
2080
2081 2019-03-26  Chris Dumez  <cdumez@apple.com>
2082
2083         Add basic layout test coverage for File Picker on iOS
2084         https://bugs.webkit.org/show_bug.cgi?id=196265
2085
2086         Reviewed by Wenson Hsieh.
2087
2088         Add layout test infrastructure to test the file picker on iOS.
2089
2090         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2091         (WTR::UIScriptController::dismissFilePicker):
2092         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2093         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2094         (WTR::UIScriptController::dismissFilePicker):
2095         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2096         * WebKitTestRunner/TestController.cpp:
2097         (WTR::TestController::createWebViewWithOptions):
2098         (WTR::updateTestOptionsFromTestHeader):
2099         * WebKitTestRunner/TestOptions.h:
2100         (WTR::TestOptions::hasSameInitializationOptions const):
2101         * WebKitTestRunner/ios/TestControllerIOS.mm:
2102         (overridePresentViewController):
2103         (WTR::TestController::platformInitialize):
2104         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2105         (WTR::UIScriptController::dismissFilePicker):
2106
2107 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2108
2109         Implement async paste method on UIWKInteractionViewProtocol
2110         https://bugs.webkit.org/show_bug.cgi?id=196267
2111         <rdar://problem/49236346>
2112
2113         Reviewed by Tim Horton.
2114
2115         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2116         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2117         are now a part of all iOS 12 internal SDKs.
2118
2119         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2120
2121         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2122         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2123
2124         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2125         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2126         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2127         * TestWebKitAPI/ios/UIKitSPI.h:
2128
2129 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2130
2131         [ews-build] Use PostgreSQL for ews.webkit.org database
2132         https://bugs.webkit.org/show_bug.cgi?id=196270
2133
2134         Reviewed by Lucas Forschler.
2135
2136         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2137
2138 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2139
2140         [ews] Reset simctl states on reboot
2141         https://bugs.webkit.org/show_bug.cgi?id=196260
2142
2143         Rubber-stamped by Aakash Jain.
2144
2145         * EWSTools/start-queue-mac.sh:
2146
2147 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2148
2149         [ews-build] Use PostgreSQL for ews-build database
2150         https://bugs.webkit.org/show_bug.cgi?id=196229
2151
2152         Reviewed by Lucas Forschler.
2153
2154         * BuildSlaveSupport/ews-build/master.cfg:
2155
2156 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2157
2158         [ews-build] Get master_hostname dynamically in master.cfg
2159         https://bugs.webkit.org/show_bug.cgi?id=196255
2160
2161         Reviewed by Lucas Forschler.
2162
2163         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2164         send events data in test mode.
2165
2166 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-app] Set db_constraint to False for Foreign Keys
2169         https://bugs.webkit.org/show_bug.cgi?id=196252
2170
2171         Reviewed by Lucas Forschler.
2172
2173         * BuildSlaveSupport/ews-app/ews/models/build.py:
2174         * BuildSlaveSupport/ews-app/ews/models/step.py:
2175
2176 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2177
2178         [ews-build] is_test_mode_enabled should default to True
2179         https://bugs.webkit.org/show_bug.cgi?id=196248
2180
2181         Reviewed by Lucas Forschler.
2182
2183         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2184
2185 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2186
2187         [ews-app] Add webkitperl to ENABLED_QUEUES
2188         https://bugs.webkit.org/show_bug.cgi?id=196253
2189
2190         Reviewed by Lucas Forschler.
2191
2192         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2193
2194 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2195
2196         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2197         https://bugs.webkit.org/show_bug.cgi?id=196211
2198         rdar://problem/49110552
2199
2200         Reviewed by Tim Horton.
2201
2202         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2203         Make sure that EventSenderProxy always exists when running tests. We used to create
2204         it when resetting before the first test, which is a bit too late.
2205
2206         * WebKitTestRunner/TestController.h:
2207         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2208         (WTR::TestController::platformCreateWebView):
2209         (WTR::TestController::platformCreateOtherPage):
2210         (WTR::TestController::finishCreatingPlatformWebView):
2211         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2212         (WTR::PlatformWebView::PlatformWebView):
2213         Moved some code that made NSWindow use NSEvent during web view creation. We may
2214         need to move more if some other case us found, but this is enough for now.
2215
2216 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         Unreviewed. Fix typo in GLib geolocation API after r243285.
2219
2220         gelocation -> geolocation.
2221
2222         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2223         (testGeolocationManagerWatchPosition):
2224
2225 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2226
2227         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2228         https://bugs.webkit.org/show_bug.cgi?id=196213
2229
2230         Reviewed by Geoff Garen.
2231
2232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2233         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2234         (credentialWithIdentityAndKeychainPath):
2235         (-[ChallengeDelegate webView:didFinishNavigation:]):
2236         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2237         (TestWebKitAPI::TEST):
2238
2239 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2240
2241         Expected shouldn't assume its contained types are copyable
2242         https://bugs.webkit.org/show_bug.cgi?id=195986
2243
2244         Reviewed by JF Bastien.
2245
2246         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2247         (TestWebKitAPI::NonCopyable::operator== const):
2248         (TestWebKitAPI::NonCopyable::operator!= const):
2249         (TestWebKitAPI::TEST):
2250
2251 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2252
2253         Remove some now-unnecessary dynamic class lookup
2254         https://bugs.webkit.org/show_bug.cgi?id=196237
2255
2256         Reviewed by Simon Fraser.
2257
2258         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2259         (makeRequest):
2260         (TEST):
2261
2262 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2263
2264         Unreviewed, rolling out r243450.
2265
2266         AppleWin and WinCairo port builds get broken.
2267
2268         Reverted changeset:
2269
2270         "Add test for fix of #196095"
2271         https://bugs.webkit.org/show_bug.cgi?id=196097
2272         https://trac.webkit.org/changeset/243450
2273
2274 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2275
2276         Unreviewed, rolling out r243465.
2277         https://bugs.webkit.org/show_bug.cgi?id=196226
2278
2279         the test doesn't build (Requested by thorton on #webkit).
2280
2281         Reverted changeset:
2282
2283         "Do not terminate the NetworkProcess if a third party
2284         application sends a NSCredential with a SecIdentityRef"
2285         https://bugs.webkit.org/show_bug.cgi?id=196213
2286         https://trac.webkit.org/changeset/243465
2287
2288 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2289
2290         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2291         https://bugs.webkit.org/show_bug.cgi?id=196213
2292
2293         Reviewed by Geoff Garen.
2294
2295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2296         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2297         (credentialWithIdentityAndKeychainPath):
2298         (-[ChallengeDelegate webView:didFinishNavigation:]):
2299         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2300         (TestWebKitAPI::TEST):
2301
2302 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2303
2304         [ews-build] Gracefully handle missing patch_id in events
2305         https://bugs.webkit.org/show_bug.cgi?id=196216
2306
2307         Reviewed by Lucas Forschler.
2308
2309         * BuildSlaveSupport/ews-build/events.py:
2310
2311 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2312
2313         [ews-build] use lz4 compression for improving buildbot performance
2314         https://bugs.webkit.org/show_bug.cgi?id=196155
2315
2316         Reviewed by Lucas Forschler.
2317
2318         * BuildSlaveSupport/ews-build/master.cfg:
2319
2320 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2321
2322         Pull some API testing helper methods out of TestWKWebView
2323         https://bugs.webkit.org/show_bug.cgi?id=196212
2324
2325         Reviewed by Tim Horton.
2326
2327         Refactor some more API testing utility methods, so that they can be used in
2328         tests that do not use TestWKWebView.
2329
2330         * TestWebKitAPI/cocoa/TestWKWebView.h:
2331         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2332         (-[WKWebView loadTestPageNamed:]):
2333         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2334         (-[WKWebView synchronouslyLoadHTMLString:]):
2335         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2336         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2337         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2338         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2339         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2340
2341 2019-03-25  Jer Noble  <jer.noble@apple.com>
2342
2343         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2344         https://bugs.webkit.org/show_bug.cgi?id=196097
2345
2346         Reviewed by Eric Carlson.
2347
2348         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2349
2350         * DumpRenderTree/mac/DumpRenderTree.mm:
2351         (resetWebPreferencesToConsistentValues):
2352         * WebKitTestRunner/TestController.cpp:
2353         (WTR::TestController::resetPreferencesToConsistentValues):
2354
2355 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2356
2357         Pull IPadUserInterfaceSwizzler out into a separate header file
2358         https://bugs.webkit.org/show_bug.cgi?id=196193
2359
2360         Reviewed by Anders Carlsson.
2361
2362         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2363         be used in other API tests.
2364
2365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2366         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2367         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2368         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2369         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2370         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2371         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2372
2373 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2374
2375         Remove NavigatorContentUtils in WebCore/Modules
2376         https://bugs.webkit.org/show_bug.cgi?id=196070
2377
2378         Reviewed by Alex Christensen.
2379
2380         NavigatorContentUtils was to support the custom scheme spec [1].
2381         However, in WebKit side, no port has supported the feature in
2382         WebKit layer after EFL port was removed. So there has been the
2383         only IDL implementation of the NavigatorContentUtils in WebCore.
2384         So we don't need to keep the implementation in WebCore anymore.
2385
2386         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2387
2388         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2389
2390 2019-03-24  Andy Estes  <aestes@apple.com>
2391
2392         [watchOS] Remove unused Proximity Networking code
2393         https://bugs.webkit.org/show_bug.cgi?id=196188
2394
2395         Reviewed by Tim Horton.
2396
2397         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2398         (TEST):
2399
2400 2019-03-23  Keith Miller  <keith_miller@apple.com>
2401
2402         Refactor clz/ctz and fix getLSBSet.
2403         https://bugs.webkit.org/show_bug.cgi?id=196162
2404
2405         Reviewed by Saam Barati.
2406
2407         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2408
2409         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2410         (TestWebKitAPI::TEST):
2411
2412 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2413
2414         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2415         https://bugs.webkit.org/show_bug.cgi?id=196143
2416
2417         Reviewed by Michael Catanzaro.
2418
2419         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2420         directories.
2421
2422         * Scripts/webkitpy/style/checkers/cpp.py:
2423         (check_identifier_name_in_declaration):
2424         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2425         (WebKitStyleTest.test_names):
2426
2427 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2428
2429         [Flatpak] Manifest expanding fails for qt WPE extension
2430         https://bugs.webkit.org/show_bug.cgi?id=196148
2431
2432         Reviewed by Alex Christensen.
2433
2434         * flatpak/flatpakutils.py:
2435         (expand_submodules_recurse): The last recurse manifest expand
2436         iteration might lead to a single module so take it into account
2437         and don't try to recurse further.
2438
2439 2019-03-22  Chris Dumez  <cdumez@apple.com>
2440
2441         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2442         https://bugs.webkit.org/show_bug.cgi?id=195348
2443         <rdar://problem/48622090>
2444
2445         Reviewed by Alex Christensen.
2446
2447         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2448         to NO when test.options().shouldIgnoreMetaViewport is false.
2449
2450         * WebKitTestRunner/ios/TestControllerIOS.mm:
2451         (WTR::TestController::platformConfigureViewForTest):
2452
2453 2019-03-22  Chris Dumez  <cdumez@apple.com>
2454
2455         Prewarmed processes should be usable with any website data store
2456         https://bugs.webkit.org/show_bug.cgi?id=196104
2457
2458         Reviewed by Alex Christensen.
2459
2460         Add API test coverage.
2461
2462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2463         (runInitialWarmedProcessUsedTest):
2464         (TEST):
2465
2466 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2467
2468         Back out local changes to Alex's Subversion working directory
2469
2470         They were accidentally committed.
2471
2472         * Scripts/webkitpy/common/system/abstractexecutive.py:
2473         (AbstractExecutive.wait_newest):
2474         * Scripts/webkitpy/common/system/executive.py:
2475         (Executive.running_pids):
2476         * Scripts/webkitpy/common/system/executive_mock.py:
2477         (MockExecutive.running_pids):
2478         * Scripts/webkitpy/common/system/executive_unittest.py:
2479         (ExecutiveTest.serial_test_running_pids):
2480         * Scripts/webkitpy/port/darwin.py:
2481         (DarwinPort.check_for_leaks):
2482         * Scripts/webkitpy/port/leakdetector.py:
2483         (LeakDetector.check_for_leaks):
2484         - This was the hack attached to Bug 193772.
2485
2486         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2487         (+[WebKitTestRunnerEvent mouseLocation]):
2488         - This works around a crash on an internal build.
2489
2490 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2491
2492         Fix the build after r243354
2493         https://bugs.webkit.org/show_bug.cgi?id=196138
2494         <rdar://problem/49145951>
2495
2496         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2497         (TEST):
2498         * TestWebKitAPI/ios/UIKitSPI.h:
2499
2500 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2501
2502         Adopt UIWKDocumentContext
2503         https://bugs.webkit.org/show_bug.cgi?id=196040
2504         <rdar://problem/48642440>
2505
2506         Reviewed by Ryosuke Niwa.
2507
2508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2509         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2510         (makeRequest):
2511         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2512         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2513         (applyStyle):
2514         (TEST):
2515         Add tests for UIWKDocumentContext.
2516
2517         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2518         (TEST):
2519         (recursiveFindWKContentView): Deleted.
2520         * TestWebKitAPI/cocoa/TestWKWebView.h:
2521         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2522         (recursiveFindWKContentView):
2523         (-[TestWKWebView wkContentView]):
2524         * TestWebKitAPI/ios/UIKitSPI.h:
2525         Share the WKContentView finding code between tests.
2526
2527 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2528
2529         [iOS WK2] Turn on async overflow scrolling by default
2530         https://bugs.webkit.org/show_bug.cgi?id=196011
2531         rdar://problem/48453859
2532
2533         Reviewed by Antti Koivisto.
2534         
2535         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2536         since so many basic layout tests have different results when compositing is triggered for
2537         overflow.
2538         
2539         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2540
2541         * WebKitTestRunner/TestController.cpp:
2542         (WTR::TestController::resetPreferencesToConsistentValues):
2543
2544 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2545
2546         [ews-build] Retry API test in case of failures
2547         https://bugs.webkit.org/show_bug.cgi?id=196004
2548
2549         Reviewed by Lucas Forschler.
2550
2551         * BuildSlaveSupport/ews-build/steps.py:
2552         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2553         (CompileWebKitToT.doStepIf): Ditto.
2554         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2555         (ReRunAPITests): Re-run API tests.
2556         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2557         (RunAPITestsWithoutPatch): Run API tests without patch.
2558         (RunAPITestsWithoutPatch.doStepIf):
2559         (RunAPITestsWithoutPatch.hideStepIf):
2560         (RunAPITestsWithoutPatch.evaluateCommand):
2561         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2562         (AnalyzeAPITestsResults.start):
2563         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2564         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2565         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2566         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2567
2568 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2569
2570         [ews-build] Update queues configurations
2571         https://bugs.webkit.org/show_bug.cgi?id=196074
2572
2573         Reviewed by Dewei Zhu.
2574
2575         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2576         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2577
2578 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2579
2580         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2581         https://bugs.webkit.org/show_bug.cgi?id=195680
2582         <rdar://problem/48903534>
2583
2584         Unreviewed infrastructure fix.
2585
2586         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2587         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2588
2589 2019-03-21  Andy Estes  <aestes@apple.com>
2590
2591         [iOS] Apple Pay should be available in documents with no user agent scripts
2592         https://bugs.webkit.org/show_bug.cgi?id=196061
2593         <rdar://problem/48649391>
2594
2595         Reviewed by Brady Eidson.
2596
2597         Added API tests and related infrastructure.
2598
2599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2600         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2601         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2602         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2603         (TestWebKitAPI::TEST):
2604         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2605         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2606         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2607         * TestWebKitAPI/cocoa/TestProtocol.mm:
2608         (-[TestProtocol startLoading]):
2609         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2610         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2611         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2612         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2613
2614 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2615
2616         REGRESSSION (r243297): webkitpy tests broken
2617         https://bugs.webkit.org/show_bug.cgi?id=196108
2618
2619         Reviewed by Aakash Jain.
2620
2621         r243297 updated contributors.json, which broke a few unit tests.
2622
2623         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2624         (IRCCommandTest.test_whois):
2625         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2626
2627 2019-03-21  Chris Dumez  <cdumez@apple.com>
2628
2629         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2630         https://bugs.webkit.org/show_bug.cgi?id=196041
2631         <rdar://problem/49083230>
2632
2633         Reviewed by Alex Christensen.
2634
2635         Add API test coverage.
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2638         (TEST):
2639
2640 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2641
2642         Add SPI to inform applications of WKContentRuleList actions
2643         https://bugs.webkit.org/show_bug.cgi?id=195965
2644         <rdar://problem/42664365>
2645
2646         Reviewed by Geoff Garen.
2647
2648         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2649         (TestWebKitAPI::allActionsForResourceLoad):
2650         (TestWebKitAPI::testRequest):
2651         (TestWebKitAPI::TEST_F):
2652         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2653         (Notification::description):
2654         (Notification::operator== const):
2655         (toVector):
2656         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2657         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2658         (makeContentRuleList):
2659         (TEST):
2660         (makeWarnContentRuleList): Deleted.
2661
2662 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2663
2664         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2665         https://bugs.webkit.org/show_bug.cgi?id=196088
2666
2667         Reviewed by Brian Burg.
2668
2669         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2670         Support checks when only one platform is specified. Also deprecate macosx() and
2671         force the use of macos() instead.
2672
2673         * Scripts/webkitpy/style/checkers/cpp.py:
2674         (check_min_versions_of_wk_api_available):
2675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2676         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2677
2678 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2679
2680         Update status inactive committers' status to 'contributor'.
2681
2682         * Scripts/webkitpy/common/config/contributors.json:
2683
2684 2019-03-21  Xan Lopez  <xan@igalia.com>
2685
2686         [JSC][x86] Drop support for x87 floating point
2687         https://bugs.webkit.org/show_bug.cgi?id=194853
2688
2689         Reviewed by Don Olmstead.
2690
2691         Force SSE2 on x86/32bit builds.
2692
2693         * Scripts/webkitdirs.pm:
2694         (generateBuildSystemFromCMakeProject):
2695
2696 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2697
2698         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2699         https://bugs.webkit.org/show_bug.cgi?id=196073
2700
2701         Reviewed by Michael Catanzaro.
2702
2703         Add test cases to check functions and constructors with no arguments but receiving user data.
2704
2705         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2706         (checkUserData):
2707         (testJSCFunction):
2708         (fooCreateWithUserData):
2709         (testJSCClass):
2710
2711 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2712
2713         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2714
2715         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2716
2717         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2718
2719 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2720
2721         [GTK][WPE] Add API to provide geolocation information
2722         https://bugs.webkit.org/show_bug.cgi?id=195940
2723
2724         Reviewed by Michael Catanzaro.
2725
2726         Add a new test to check the new API.
2727
2728         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2729         (testGeolocationManagerCurrentPosition):
2730         (testGeolocationManagerWatchPosition):
2731         (beforeAll):
2732         (afterAll):
2733         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2734         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2735         (beforeAll): Ditto.
2736         * TestWebKitAPI/glib/CMakeLists.txt:
2737
2738 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2739
2740         [GLib] Returning G_TYPE_OBJECT from a method does not work
2741         https://bugs.webkit.org/show_bug.cgi?id=195574
2742
2743         Reviewed by Michael Catanzaro.
2744
2745         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2746
2747         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2748         (getGFile):
2749         (getParent):
2750         (createGString):
2751         (getGString):
2752         (getGStringCopyWillRaise):
2753         (getGStringCopy):
2754         (getGStringStr):
2755         (getGStringLen):
2756         (freeGString):
2757         (testJSCClass):
2758
2759 2019-03-20  Saam Barati  <sbarati@apple.com>
2760
2761         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2762         https://bugs.webkit.org/show_bug.cgi?id=195721
2763
2764         Reviewed by Filip Pizlo.
2765
2766         * Scripts/run-javascriptcore-tests:
2767
2768 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2769
2770         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2771         https://bugs.webkit.org/show_bug.cgi?id=196049
2772
2773         Reviewed by Tim Horton.
2774
2775         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2776         overflow scrolling in general, so rename it.
2777
2778         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2779
2780 2019-03-20  Daniel Bates  <dabates@apple.com>
2781
2782         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2783         https://bugs.webkit.org/show_bug.cgi?id=196031
2784         <rdar://problem/49078172>
2785
2786         Reviewed by Tim Horton.
2787
2788         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2789         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2790         same code path used when the Done button is pressed to dismiss the <select> picker.
2791
2792         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2793         (TestWebKitAPI::TEST):
2794
2795 2019-03-20  Chris Dumez  <cdumez@apple.com>
2796
2797         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2798         https://bugs.webkit.org/show_bug.cgi?id=196029
2799         <rdar://problem/48954651>
2800
2801         Reviewed by Tim Horton.
2802
2803         Add API test coverage.
2804
2805         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2806
2807 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2808
2809         [ews-build] Improve failure summary string for ApplyPatch step
2810         https://bugs.webkit.org/show_bug.cgi?id=195995
2811
2812         Reviewed by Alexey Proskuryakov.
2813
2814         * BuildSlaveSupport/ews-build/steps.py:
2815         (ApplyPatch.getResultSummary): Override getResultSummary.
2816
2817 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2818
2819         AX: Implement support for new meter ARIA role
2820         https://bugs.webkit.org/show_bug.cgi?id=195966
2821
2822         Reviewed by Chris Fleizach.
2823
2824         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2825         to AXLevelIndicator.
2826
2827         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2828
2829 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2830
2831         [WebAuthN] Implement FIDO AppID extension
2832         https://bugs.webkit.org/show_bug.cgi?id=143491
2833         <rdar://problem/48298273>
2834
2835         Reviewed by Brent Fulgham.
2836
2837         Add a test that covers the new flag of convertToU2fSignCommand.
2838
2839         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2840         (TestWebKitAPI::TEST):
2841         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2842         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2843         (TestWebKitAPI::TEST):
2844
2845 2019-03-19  Keith Rollin  <krollin@apple.com>
2846
2847         Add support for more platforms to generate-xcfilelists
2848         https://bugs.webkit.org/show_bug.cgi?id=195977
2849
2850         Reviewed by Alexey Proskuryakov.
2851
2852         generate-xcfilelists incorrectly complains when involved with building
2853         WebKit for iphonesimulator:
2854
2855             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2856             …
2857             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2858
2859         Address this by teaching generate-xcfilelists about more platforms.
2860
2861         * Scripts/generate-xcfilelists:
2862
2863 2019-03-19  John Wilander  <wilander@apple.com>
2864
2865         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2866         https://bugs.webkit.org/show_bug.cgi?id=195923
2867         <rdar://problem/49001272>
2868
2869         Reviewed by Alex Christensen.
2870
2871         This patch does the following to the TestRunner:
2872         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2873         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2874         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2875
2876         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2877         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2878         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2879         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2880         * WebKitTestRunner/TestController.cpp:
2881         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2882         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2883         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2884         * WebKitTestRunner/TestController.h:
2885         * WebKitTestRunner/TestInvocation.cpp:
2886         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2887
2888 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2889
2890         [CMake] Support more clang and gcc sanitizers
2891         https://bugs.webkit.org/show_bug.cgi?id=195956
2892
2893         Reviewed by Michael Catanzaro.
2894
2895         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2896
2897 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-build] Improve summary for PrintConfiguration step
2900         https://bugs.webkit.org/show_bug.cgi?id=195945
2901
2902         Reviewed by Lucas Forschler.
2903
2904         * BuildSlaveSupport/ews-build/steps.py:
2905         (PrintConfiguration.getResultSummary): Override getResultSummary.
2906
2907 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2908
2909         [ews-build] Improve summary for CheckOutSource step
2910         https://bugs.webkit.org/show_bug.cgi?id=195963
2911
2912         Reviewed by Lucas Forschler.
2913
2914         * BuildSlaveSupport/ews-build/steps.py:
2915         (CheckOutSource.getResultSummary):
2916
2917 2019-03-19  Daniel Bates  <dabates@apple.com>
2918
2919         [iOS] Focus not preserved when switching between tabs
2920         https://bugs.webkit.org/show_bug.cgi?id=195820
2921         <rdar://problem/43614450>
2922
2923         Reviewed by Brent Fulgham.
2924
2925         Add tests to ensure that we restore focus when resigning and becoming first responder.
2926
2927         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2928         (TestWebKitAPI::TEST):
2929
2930 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2931
2932         Make WTFLogChannelState and WTFLogLevel enum classes
2933         https://bugs.webkit.org/show_bug.cgi?id=195904
2934
2935         Reviewed by Eric Carlson.
2936
2937         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2938         (TestWebKitAPI::TEST_F):
2939
2940 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2941
2942         [GStreamer][EME] Backported mssdemux protection data crash fix
2943         https://bugs.webkit.org/show_bug.cgi?id=195918
2944
2945         Reviewed by Philippe Normand.
2946
2947         * gstreamer/jhbuild.modules:
2948         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2949
2950 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2951
2952         Unreviewed, rolling out r243132.
2953
2954         Broke GTK build
2955
2956         Reverted changeset:
2957
2958         "Make WTFLogChannelState and WTFLogLevel enum classes"
2959         https://bugs.webkit.org/show_bug.cgi?id=195904
2960         https://trac.webkit.org/changeset/243132
2961
2962 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2963
2964         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2965
2966         * Scripts/webkitdirs.pm:
2967         (builtDylibPathForName): Adjust the shared library name that's changed
2968         with the API version bump in r243073.
2969
2970 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2971
2972         Make WTFLogChannelState and WTFLogLevel enum classes
2973         https://bugs.webkit.org/show_bug.cgi?id=195904
2974
2975         Reviewed by Eric Carlson.
2976
2977         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2978         (TestWebKitAPI::TEST_F):
2979
2980 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2981
2982         Disable flaky test added in r2431100
2983         https://webkit.org/b/195785
2984
2985         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2986         (TestWebKitAPI::TEST):
2987         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2988
2989 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2990
2991         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2992         https://bugs.webkit.org/show_bug.cgi?id=195916
2993
2994         Reviewed by Tim Horton.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2997         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2998
2999 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3000
3001         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3002
3003         * Scripts/webkitpy/common/config/contributors.json:
3004
3005 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3006
3007         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3008         https://bugs.webkit.org/show_bug.cgi?id=195785
3009
3010         Reviewed by Geoffrey Garen.
3011
3012         * TestWebKitAPI/TCPServer.cpp: Added.
3013         (TestWebKitAPI::TCPServer::TCPServer):
3014         (TestWebKitAPI::TCPServer::~TCPServer):
3015         (TestWebKitAPI::TCPServer::socketBindListen):
3016         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3017         * TestWebKitAPI/TCPServer.h: Added.
3018         (TestWebKitAPI::TCPServer::port const):
3019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3020         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3021         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3022         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3023         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3024         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3025         (TestWebKitAPI::respondSlowly):
3026         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3027         (TestWebKitAPI::downloadAtRate):
3028         (TestWebKitAPI::TEST):
3029
3030 2019-03-18  Saam Barati  <sbarati@apple.com>
3031
3032         Add a plan file for JetStream 2
3033         https://bugs.webkit.org/show_bug.cgi?id=190734
3034
3035         Reviewed by Mark Lam.
3036
3037         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3038
3039 2019-03-18  Chris Dumez  <cdumez@apple.com>
3040
3041         Delay WebProcess launch until a load is triggered in a Web view
3042         https://bugs.webkit.org/show_bug.cgi?id=195758
3043         <rdar://problem/48126013>
3044
3045         Reviewed by Geoff Garen.
3046
3047         Add API test coverage. Also update some existing API tests to not expect
3048         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3049
3050         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3051         (TestWebKitAPI::TEST):
3052         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3053         (TestWebKitAPI::TEST):
3054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3055         (TEST):
3056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3057         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3058         (TEST):
3059         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3060         (TEST):
3061         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3062
3063 2019-03-18  Xan Lopez  <xan@igalia.com>
3064
3065         [CMake] Prevent potential warning when determining $architecture
3066         https://bugs.webkit.org/show_bug.cgi?id=195891
3067
3068         Reviewed by Michael Catanzaro.
3069
3070         It's possible for generateBuildSystemForCMakeProject to be called
3071         before determineArchitecture() is ever called. This will make the
3072         first eq check with $architecture to be bogus (and print a
3073         warning). Change that to an eq check with architecture(), which
3074         implicitly calls determineArchitecture() if needed, and change all
3075         the other similar cases in the method in the same way to prevent
3076         future bugs like this one.
3077
3078         * Scripts/webkitdirs.pm:
3079         (generateBuildSystemFromCMakeProject):
3080
3081 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3082
3083         [WPE] Tarballs generated with “make dist” cannot build documentation
3084         https://bugs.webkit.org/show_bug.cgi?id=195885
3085
3086         Reviewed by Carlos Garcia Campos.
3087
3088         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3089
3090 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3091
3092         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3093         https://bugs.webkit.org/show_bug.cgi?id=195883
3094
3095         Reviewed by Carlos Garcia Campos.
3096
3097         * gtkdoc/gtkdoc.py:
3098         (GTKDoc._run_command): When commands fail to run, include the full command line for
3099         the program invocation and the output it has generated on the standard error stream.
3100
3101 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3102
3103         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3104         https://bugs.webkit.org/show_bug.cgi?id=195786
3105
3106         Reviewed by Philippe Normand.
3107
3108         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3109         * wpe/jhbuild.modules: Ditto.
3110
3111 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3112
3113         [ews-build] Don't run clean builds on EWS builders
3114         https://bugs.webkit.org/show_bug.cgi?id=195851
3115
3116         Reviewed by Geoffrey Garen.
3117
3118         * BuildSlaveSupport/ews-build/factories.py:
3119
3120 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3121
3122         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3123         https://bugs.webkit.org/show_bug.cgi?id=195849
3124
3125         Reviewed by Chris Dumez.
3126
3127         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3128
3129         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3130         (runWebsiteDataStoreCustomPaths):
3131
3132 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3133
3134         webkitpy: Upload test results
3135         https://bugs.webkit.org/show_bug.cgi?id=195755
3136         <rdar://problem/48896182>
3137
3138         Reviewed by Aakash Jain.
3139
3140         Establish a new format for uploading results that is not tied to layout tests, apply
3141         that format to webkitpy tests.
3142
3143         * Scripts/webkitpy/common/checkout/scm/git.py:
3144         (Git.native_branch): Return what branch the current checkout is on.
3145         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3146         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3147         * Scripts/webkitpy/common/checkout/scm/svn.py:
3148         (SVN.native_branch): Ditto.
3149         * Scripts/webkitpy/common/system/platforminfo.py:
3150         (PlatformInfo.build_version): Return a build version for Mac.
3151         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3152         (MockPlatformInfo.__init__):
3153         (MockPlatformInfo.build_version):
3154         * Scripts/webkitpy/results: Added.
3155         * Scripts/webkitpy/results/__init__.py: Added.
3156         * Scripts/webkitpy/results/options.py: Added.
3157         (upload_options): OptParse list for upload options.
3158         * Scripts/webkitpy/results/upload.py: Added.
3159         (Upload): Class which enforces the upload format expected by the results server.
3160         (Upload.Expectations):
3161         (Upload.create_configuration):
3162         (Upload.create_commit):
3163         (Upload.create_details):
3164         (Upload.create_run_stats):
3165         (Upload.create_test_result):
3166         (Upload.__init__):
3167         (Upload.Encoder): Encode Upload object as json.
3168         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3169         * Scripts/webkitpy/results/upload_unittest.py: Added.
3170         * Scripts/webkitpy/test/main.py:
3171         (Tester._parse_args): Add upload arguments.
3172         (Tester._run_tests): Allow results to be uploaded.
3173         * Scripts/webkitpy/test/runner.py:
3174         (Runner.__init__): Record which tests were run, rather than just counting them.
3175         (Runner.handle):
3176         * Scripts/webkitpy/test/runner_unittest.py:
3177         (RunnerTest.test_run):
3178         * Scripts/webkitpy/thirdparty/__init__.py:
3179         (AutoinstallImportHook.find_module): Add requests auto-install.
3180         (AutoinstallImportHook._install_requests):
3181         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3182         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3183
3184 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3185
3186         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3187         https://bugs.webkit.org/show_bug.cgi?id=195810
3188
3189         Reviewed by Tim Horton.
3190
3191         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3192         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3193         ending certain layout tests.
3194
3195         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3196         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3197         (-[TestRunnerWKWebView dealloc]):
3198         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3199
3200         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3201         helper method when destroying the web view, and when resetting state between tests.
3202
3203         * WebKitTestRunner/ios/TestControllerIOS.mm:
3204         (WTR::TestController::platformResetStateToConsistentValues):
3205
3206         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3207
3208 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3209
3210         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3211         https://bugs.webkit.org/show_bug.cgi?id=190350
3212         <rdar://problem/45089503>
3213
3214         Reviewed by Geoffrey Garen.
3215
3216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3217         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3218         (TEST):
3219         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3220         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3221         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3222         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3223         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3224         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3225         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3226         (runTest):
3227         (createDirectories):
3228         (TEST):
3229         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3230         (TEST):
3231         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3232         (TEST):
3233
3234 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3235
3236         Add support to WebPage for getting the contents as an attributed string.
3237         https://bugs.webkit.org/show_bug.cgi?id=195636
3238         rdar://problem/45055697
3239
3240         Reviewed by Tim Horton.
3241
3242         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3243         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3244
3245 2019-03-15  Chris Dumez  <cdumez@apple.com>
3246
3247         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3248         https://bugs.webkit.org/show_bug.cgi?id=195747
3249
3250         Reviewed by Geoff Garen.
3251
3252         Add API test coverage.
3253
3254         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3255
3256 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3257
3258         Unreviewed, rolling out r242952.
3259
3260         Causing API failures on iOS Simulator
3261
3262         Reverted changeset:
3263
3264         "[PSON] Make sure the WebProcessCache is leverage when
3265         relaunching a process after termination"
3266         https://bugs.webkit.org/show_bug.cgi?id=195747
3267         https://trac.webkit.org/changeset/242952
3268
3269 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3270
3271         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3272         https://bugs.webkit.org/show_bug.cgi?id=195740
3273
3274         Reviewed by Ross Kirsling.
3275
3276         window.open doesn't work for WebKitBrowserWindow because it is not
3277         implemented yet.
3278
3279         1. Implemented createNewPage callback of WKPageUIClient.
3280         2. Changed MainWindow to take a BrowserWindow factory function
3281           instead of BrowserWindowType to be flexible to create
3282           BrowserWindow with extra settings.
3283         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3284           because it is not relevant with MainWindow anymore.
3285
3286         * MiniBrowser/win/Common.cpp:
3287         (parseCommandLine):
3288         * MiniBrowser/win/Common.h:
3289         (CommandLineOptions::CommandLineOptions):
3290         * MiniBrowser/win/MainWindow.cpp:
3291         (MainWindow::MainWindow):
3292         (MainWindow::create):
3293         (MainWindow::init):
3294         (MainWindow::WndProc):
3295         * MiniBrowser/win/MainWindow.h:
3296         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3297         (PrintWebUIDelegate::createWebViewWithRequest):
3298         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3299         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3300         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3301         (WebKitBrowserWindow::updateProxySettings):
3302         (WebKitBrowserWindow::createNewPage):
3303         * MiniBrowser/win/WebKitBrowserWindow.h:
3304         * MiniBrowser/win/WinMain.cpp:
3305         (wWinMain):
3306
3307 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3308
3309         Make it possible to test scrolling tree layer manipulation more easily
3310         https://bugs.webkit.org/show_bug.cgi?id=195780
3311
3312         Reviewed by Tim Horton.
3313         
3314         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3315         cuts off communication of scrolling tree scrolls back to the web process
3316         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3317         allows tests to trigger scrolls which run the scrolling tree layer positioning
3318         logic, but never get another commit from the web process that might mask
3319         scrolling tree bugs.
3320         
3321         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3322         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3323         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3324
3325         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3326         (WTR::UIScriptController::scrollUpdatesDisabled const):
3327         (WTR::UIScriptController::setScrollUpdatesDisabled):
3328         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3329         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3330         (WTR::UIScriptController::scrollUpdatesDisabled const):
3331         (WTR::UIScriptController::setScrollUpdatesDisabled):
3332         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3333         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3334         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3335         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3336         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3337         * WebKitTestRunner/ios/TestControllerIOS.mm:
3338         (WTR::TestController::platformResetStateToConsistentValues):
3339         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3340         (WTR::UIScriptController::scrollUpdatesDisabled const):
3341         (WTR::UIScriptController::setScrollUpdatesDisabled):
3342
3343 2019-03-14  Youenn Fablet  <youenn@apple.com>
3344
3345         Move IDB storage in private browsing mode to NetworkProcess
3346         https://bugs.webkit.org/show_bug.cgi?id=195602
3347
3348         Reviewed by Brady Eidson.
3349
3350         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3351         (TEST):
3352
3353 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3354
3355         [ews-build] Make descriptionDone messages more readable
3356         https://bugs.webkit.org/show_bug.cgi?id=195760
3357
3358         Reviewed by Lucas Forschler.
3359
3360         * BuildSlaveSupport/ews-build/steps.py:
3361         * BuildSlaveSupport/ews-build/steps_unittest.py:
3362
3363 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3364
3365         [ews-build] Generate status-bubble hover-over messages
3366         https://bugs.webkit.org/show_bug.cgi?id=195680
3367
3368         Reviewed by Lucas Forschler.
3369
3370         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3371         (StatusBubble):
3372         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3373         on hover-over.
3374         (StatusBubble._iso_time):
3375         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3376         hover-over message.
3377         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3378
3379 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3380
3381         [ews-app] Gracefully handle the case when state_string is None
3382         https://bugs.webkit.org/show_bug.cgi?id=195753
3383
3384         Reviewed by Lucas Forschler.
3385
3386         * BuildSlaveSupport/ews-app/ews/models/build.py:
3387         * BuildSlaveSupport/ews-app/ews/models/step.py:
3388
3389 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-app] Status bubble display pending for currently running build step
3392         https://bugs.webkit.org/show_bug.cgi?id=195744
3393
3394         Reviewed by Lucas Forschler.
3395
3396         * BuildSlaveSupport/ews-build/events.py:
3397         (Events.stepStarted): If state_string is pending, replace it with step name.
3398
3399 2019-03-14  Chris Dumez  <cdumez@apple.com>
3400
3401         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3402         https://bugs.webkit.org/show_bug.cgi?id=195750
3403
3404         Reviewed by Geoffrey Garen.
3405
3406         Add API test coverage.
3407
3408         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3409         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3410         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3411         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3412
3413 2019-03-14  Chris Dumez  <cdumez@apple.com>
3414
3415         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3416         https://bugs.webkit.org/show_bug.cgi?id=195747
3417
3418         Reviewed by Geoff Garen.
3419
3420         Add API test coverage.
3421
3422         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3423
3424 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3425
3426         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3427         https://bugs.webkit.org/show_bug.cgi?id=195725
3428         <rdar://problem/48545062>
3429
3430         Reviewed by Tim Horton.
3431
3432         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3433         handler is nil.
3434
3435         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3436         (TestWebKitAPI::TEST):
3437
3438 2019-03-13  Sam Weinig  <sam@webkit.org>
3439
3440         Add utility function to allow easy reverse range-based iteration of a container
3441         https://bugs.webkit.org/show_bug.cgi?id=195542
3442
3443         Reviewed by Antti Koivisto.
3444
3445         * TestWebKitAPI/CMakeLists.txt:
3446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3447         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3448         (TestWebKitAPI::TEST):
3449         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3450
3451 2019-03-13  Chris Dumez  <cdumez@apple.com>
3452
3453         Use a ServiceWorker process per registrable domain
3454         https://bugs.webkit.org/show_bug.cgi?id=195649
3455
3456         Reviewed by Youenn Fablet.
3457
3458         Update API test coverage.
3459
3460         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3461
3462 2019-03-13  Chris Dumez  <cdumez@apple.com>
3463
3464         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3465         https://bugs.webkit.org/show_bug.cgi?id=195684
3466         <rdar://problem/48294714>
3467
3468         Reviewed by Antti Koivisto.
3469
3470         Add API test coverage.
3471
3472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3473
3474 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3475
3476         [ews-app] Remove unused patch view
3477         https://bugs.webkit.org/show_bug.cgi?id=195669
3478
3479         Reviewed by Lucas Forschler.
3480
3481         * BuildSlaveSupport/ews-app/ews/urls.py:
3482         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3483
3484 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3485
3486         [ews-app] Use Buildbot result code variables
3487         https://bugs.webkit.org/show_bug.cgi?id=195668
3488
3489         Reviewed by Alexey Proskuryakov.
3490
3491         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3492         (Buildbot): Added Buildbot result code variables.
3493         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3494         (StatusBubble._build_bubble): Used Buildbot result code variables.
3495
3496 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3497
3498         [Flatpak] Expand submodule recursively
3499         https://bugs.webkit.org/show_bug.cgi?id=195672
3500
3501         Building WPE with flatpak was impossible without that as it was raising an exception.
3502         Also update wpebackend-fdo to match what is built in jhbuild
3503
3504         Reviewed by Philippe Normand.
3505
3506         * flatpak/flatpakutils.py:
3507         (expand_submodules_recurse):
3508         (expand_manifest):
3509         * flatpak/org.webkit.WPEModules.yaml:
3510
3511 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3512
3513         [ews-app] status bubble should be hidden for certain builds
3514         https://bugs.webkit.org/show_bug.cgi?id=194597
3515
3516         Reviewed by Dewei Zhu.
3517
3518         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3519         (StatusBubble._build_bubble):
3520         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3521         because the patch didn't have relevant changes.
3522         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3523         in production yet.
3524
3525 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3526
3527         [Win] Fix a slew of simple clang-cl warnings.
3528         https://bugs.webkit.org/show_bug.cgi?id=195652
3529
3530         Reviewed by Don Olmstead.
3531
3532         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3533         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3534
3535 2019-03-12  Justin Fan  <justin_fan@apple.com>
3536
3537         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3538         https://bugs.webkit.org/show_bug.cgi?id=195518
3539         <rdar://problem/46322356>
3540
3541         Reviewed by Myles C. Maxfield.
3542
3543         * DumpRenderTree/DerivedSources-input.xcfilelist:
3544         * DumpRenderTree/DerivedSources-output.xcfilelist:
3545
3546 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3547
3548         Unreviewed, rolling out r242825.
3549         https://bugs.webkit.org/show_bug.cgi?id=195648
3550
3551         "Broke webkitpy tests with my change to
3552         lldb_dump_class_layout.py" (Requested by rmorisset on
3553         #webkit).
3554
3555         Reverted changeset:
3556
3557         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3558         classes with suspicious padding"
3559         https://bugs.webkit.org/show_bug.cgi?id=195573
3560         https://trac.webkit.org/changeset/242825
3561
3562 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3563
3564         [ews-build] Show status bubbles while the patch is waiting in queue
3565         https://bugs.webkit.org/show_bug.cgi?id=195618
3566
3567         Reviewed by Lucas Forschler.
3568
3569         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3570         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3571         enabled in initial deployment.
3572         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3573         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3574         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3575         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3576         (StatusBubble._build_bubbles_for_patch):
3577
3578 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3579
3580         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3581         https://bugs.webkit.org/show_bug.cgi?id=195573
3582
3583         Reviewed by Simon Fraser.
3584
3585         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3586
3587         * Scripts/dump-class-layout:
3588         (main):
3589         * lldb/lldb_dump_class_layout.py:
3590         (ClassLayout.__init__):
3591         (ClassLayout._compute_padding_recursive):
3592         (LLDBDebuggerInstance.dump_layout_for_classname):
3593         (LLDBDebuggerInstance):
3594         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3595         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3596
3597 2019-03-12  Chris Dumez  <cdumez@apple.com>
3598
3599         Device Orientation access permission should be denied unless explicitly granted by the client
3600         https://bugs.webkit.org/show_bug.cgi?id=195625
3601
3602         Reviewed by Youenn Fablet.
3603
3604         add API test coverage.
3605
3606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3607         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3608         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3609         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3610         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3611         (runDeviceOrientationTest):
3612         (TEST):
3613         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3614         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3615
3616 2019-03-12  Jer Noble  <jer.noble@apple.com>
3617
3618         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3619         https://bugs.webkit.org/show_bug.cgi?id=195137
3620         <rdar://problem/48810307>
3621
3622         Reviewed by Eric Carlson.
3623
3624         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3625         (TestWebKitAPI::TEST):
3626
3627 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3628
3629         [ews-build] Change urls from uat to production
3630         https://bugs.webkit.org/show_bug.cgi?id=195566
3631
3632         Reviewed by Lucas Forschler.
3633
3634         * BuildSlaveSupport/ews-app/ews/config.py:
3635         * BuildSlaveSupport/ews-build/events.py:
3636         * BuildSlaveSupport/ews-build/steps.py:
3637
3638 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3639
3640         [ews-build] change max_builds for local-worker to 1
3641         https://bugs.webkit.org/show_bug.cgi?id=195568
3642
3643         Reviewed by Lucas Forschler.
3644
3645         * BuildSlaveSupport/ews-build/loadConfig.py:
3646
3647 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3648
3649         Fix the build
3650
3651         * TestRunnerShared/spi/PencilKitTestSPI.h:
3652         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3653
3654 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3655
3656         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3657         https://bugs.webkit.org/show_bug.cgi?id=194131
3658
3659         Reviewed by Michael Catanzaro.
3660
3661         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3662         (uriChanged):
3663         (testUnfinishedSubresourceLoad):
3664         (serverCallback):
3665         (beforeAll):
3666
3667 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3668
3669         WTF::Expected should use std::addressof instead of operator&
3670         https://bugs.webkit.org/show_bug.cgi?id=195604
3671
3672         Reviewed by Myles Maxfield.
3673
3674         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3675         (TestWebKitAPI::Unique::Unique):
3676         (TestWebKitAPI::Unique::operator&):
3677         (TestWebKitAPI::TEST):
3678
3679 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3680
3681         Add Optional to Forward.h.
3682         https://bugs.webkit.org/show_bug.cgi?id=195586
3683
3684         Reviewed by Darin Adler.
3685
3686         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3687         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3688         Remove unnecessary includes from headers.
3689
3690 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3691
3692