[Resource Timing] Add Experimental Feature Flag
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-23  Joseph Pecoraro  <pecoraro@apple.com>
2
3         [Resource Timing] Add Experimental Feature Flag
4         https://bugs.webkit.org/show_bug.cgi?id=167147
5
6         Reviewed by Ryosuke Niwa.
7
8         * DumpRenderTree/mac/DumpRenderTree.mm:
9         (enableExperimentalFeatures):
10         (resetWebPreferencesToConsistentValues):
11         * DumpRenderTree/win/DumpRenderTree.cpp:
12         (enableExperimentalFeatures):
13         (resetWebPreferencesToConsistentValues):
14         Put experimental flags in the experimental section.
15
16 2017-02-23  Beth Dakin  <bdakin@apple.com> + Dan Saunders  <dasau@microsoft.com>
17
18         No reliable way to get a snapshot of WKWebView (macOS)
19         https://bugs.webkit.org/show_bug.cgi?id=161450
20         -and corresponding-
21         <rdar://problem/23846039>
22
23         Reviewed by Tim Horton.
24
25         Test for WKWebView’s new API takeSnapshotWithConfiguration:completionHandler:
26
27         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Added.
29         (convertToCGImage):
30         (getPixelIndex):
31         (TEST):
32
33 2017-02-23  Saam Barati  <sbarati@apple.com>
34
35         Speculative fix for jsc timing out tests
36         https://bugs.webkit.org/show_bug.cgi?id=168791
37
38         Rubber Stamped by Keith Miller.
39
40         Play musical chairs with IRC and Briggs options on
41         ftl-eager and ftl-eager-no-cjit.
42
43         * Scripts/run-jsc-stress-tests:
44
45 2017-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
46
47         Improve error message when the WPT server fails to start.
48         https://bugs.webkit.org/show_bug.cgi?id=168759
49
50         Reviewed by Ryosuke Niwa.
51
52         Check if the WPT server is running after 1 second, and if is not
53         print useful information for helping the user to debug the issue.
54
55         Using check_running_pid() to check if the process is still running
56         doesn't work. A process started via subprocess popen that has ended
57         will be in a zombie state until a call to wait/communicate/poll
58         is done, or until the object is deleted or garbage collected.
59
60         This adds also support for testing the behaviour of subprocess
61         poll() on the unit tests that use MockProcess.
62
63         A new test is added also for the battery of tests for the WPT
64         server.
65
66         * Scripts/webkitpy/common/system/executive_mock.py:
67         (MockProcess.__init__):
68         (MockProcess.wait):
69         (MockProcess.communicate):
70         (MockProcess.poll):
71         (MockExecutive.popen):
72         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
73         (WebPlatformTestServer.__init__):
74         (WebPlatformTestServer._prepare_config):
75         (WebPlatformTestServer._spawn_process):
76         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
77         (TestWebPlatformTestServer.test_corrupted_subserver_files):
78         (TestWebPlatformTestServer):
79         (TestWebPlatformTestServer.test_server_fails_to_start_throws_exception):
80
81 2017-02-23  Wenson Hsieh  <wenson_hsieh@apple.com>
82
83         Unreviewed, temporarily disable DataInteractionTests in TestWebKitAPI.
84
85         These will be reenabled in https://bugs.webkit.org/show_bug.cgi?id=168602.
86
87         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
88
89 2017-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
90
91         Data interaction causes selection to fall out of sync between web/UI processes
92         https://bugs.webkit.org/show_bug.cgi?id=168735
93         <rdar://problem/30657817>
94
95         Reviewed by Tim Horton.
96
97         Adds a new method to TestWKWebView for querying selection view rects from the UI process and augments data
98         interaction unit tests to check for selection rects using this new hook.
99
100         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
101         (makeCGRectValue):
102         (TestWebKitAPI::TEST):
103         * TestWebKitAPI/cocoa/TestWKWebView.h:
104         * TestWebKitAPI/cocoa/TestWKWebView.mm:
105         (-[TestWKWebView selectionRectsAfterPresentationUpdate]):
106         * TestWebKitAPI/ios/DataInteractionSimulator.h:
107         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
108         (-[DataInteractionSimulator _resetSimulatedState]):
109         (-[DataInteractionSimulator runFrom:to:]):
110         (-[DataInteractionSimulator finalSelectionRects]):
111
112 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
113
114         Better handle Thread and RunLoop initialization
115         https://bugs.webkit.org/show_bug.cgi?id=167828
116
117         Reviewed by Yusuke Suzuki.
118
119         Remove unnecessary calls to WTF::initializeMainThread().
120
121         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
122         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
123         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
124         (TestWebKitAPI::ContentExtensionTest::SetUp):
125         * WebKitTestRunner/TestController.cpp:
126         (WTR::TestController::initialize):
127
128 2017-02-22  Myles C. Maxfield  <mmaxfield@apple.com>
129
130         [Cocoa] Remove Yosemite-specific font lookup code
131         https://bugs.webkit.org/show_bug.cgi?id=168682
132
133         Reviewed by Zalan Bujtas.
134
135         * DumpRenderTree/mac/DumpRenderTree.mm:
136         (fontWhitelist):
137         (adjustFonts):
138         (createWebViewAndOffscreenWindow):
139         (drt_NSFontManager_availableFontFamilies): Deleted.
140         (drt_NSFontManager_availableFonts): Deleted.
141         (swizzleNSFontManagerMethods): Deleted.
142         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
143         (WTR::activateFonts):
144         (WTR::allowedFontFamilySet): Deleted.
145         (WTR::systemHiddenFontFamilySet): Deleted.
146         (WTR::wtr_NSFontManager_availableFontFamilies): Deleted.
147         (WTR::wtr_NSFontManager_availableFonts): Deleted.
148         (WTR::swizzleNSFontManagerMethods): Deleted.
149         * WebKitTestRunner/mac/TestControllerMac.mm:
150         (WTR::generateWhitelist):
151         (WTR::TestController::platformInitializeContext):
152
153 2017-02-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
154
155         AutoInstaller should not skip the install step if the package is downloaded but not installed
156         https://bugs.webkit.org/show_bug.cgi?id=168737
157
158         Reviewed by Ryosuke Niwa.
159
160         Don't skip the install step if the package target path don't exists.
161         Fix the description for "should_refresh" optional argument.
162
163         * Scripts/webkitpy/common/system/autoinstall.py:
164         (AutoInstaller.install):
165
166 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
167
168         [GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
169         https://bugs.webkit.org/show_bug.cgi?id=168721
170
171         Reviewed by Michael Catanzaro.
172
173         Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
174         criticals.
175
176         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
177         (WTR::EventSenderProxy::continuousMouseScrollBy):
178
179 2017-02-21  Youenn Fablet  <youenn@apple.com>
180
181         [WebRTC][Mac] Activate libwebrtc
182         https://bugs.webkit.org/show_bug.cgi?id=167293
183         <rdar://problem/30401864>
184
185         Reviewed by Alex Christensen.
186
187         Fixing paths to allow loading libwebrtc.dylib successfully.
188
189         * Scripts/build-webkit:
190         * Scripts/webkitdirs.pm:
191         (setupMacWebKitEnvironment):
192         (setupIOSWebKitEnvironment):
193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
194
195 2017-02-21  Saam Barati  <sbarati@apple.com>
196
197         Add the Briggs optimistic allocator to run on ARM64
198         https://bugs.webkit.org/show_bug.cgi?id=168454
199
200         Reviewed by Filip Pizlo.
201
202         * Scripts/run-jsc-stress-tests:
203
204 2017-02-20  Filip Pizlo  <fpizlo@apple.com>
205
206         The collector thread should only start when the mutator doesn't have heap access
207         https://bugs.webkit.org/show_bug.cgi?id=167737
208
209         Reviewed by Keith Miller.
210         
211         Make more tests collect continuously.
212
213         * Scripts/run-jsc-stress-tests:
214
215 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
216
217         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
218         https://bugs.webkit.org/show_bug.cgi?id=168620
219         <rdar://problem/30617772>
220
221         Reviewed by Tim Horton.
222         
223         Add a setting that allows one to toggle subpixel-antialiased layer text on and off.
224
225         * DumpRenderTree/mac/DumpRenderTree.mm:
226         (resetWebPreferencesToConsistentValues):
227         * MiniBrowser/mac/SettingsController.h:
228         * MiniBrowser/mac/SettingsController.m:
229         (-[SettingsController _populateMenu]):
230         (-[SettingsController validateMenuItem:]):
231         (-[SettingsController toggleSubpixelAntialiasedLayerTextEnabled:]):
232         (-[SettingsController subpixelAntialiasedLayerTextEnabled]):
233         * MiniBrowser/mac/WK1BrowserWindowController.m:
234         (-[WK1BrowserWindowController didChangeSettings]):
235         * MiniBrowser/mac/WK2BrowserWindowController.m:
236         (-[WK2BrowserWindowController didChangeSettings]):
237         * WebKitTestRunner/TestController.cpp:
238         (WTR::TestController::resetPreferencesToConsistentValues):
239
240 2017-02-21  Jonathan Bedard  <jbedard@apple.com>
241
242         webkitpy: Refactor Device class
243         https://bugs.webkit.org/show_bug.cgi?id=168332
244
245         Reviewed by Alexey Proskuryakov.
246
247         Separate the more specific SimulatedDevice from the abstract
248         idea of a device.
249
250         * Scripts/webkitpy/xcode/device.py: Added.
251         (Device):  Base device class.
252         (Device.__init__): Initialize _host, name and udid.
253         (Device.install_app): Function declaration.
254         (Device.launch_app): Ditto.
255         (Device.__eq__): Compare two devices by udid.
256         (Device.__ne__): Ditto.
257         (Device.__repr__): Return device name and udid in formatted string.
258         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/simulator.py.
259         (SimulatedDevice):
260         (SimulatedDevice.__init__): Call Device.__init__ first.
261         (SimulatedDevice.delete): Device -> SimulatedDevice.
262         (SimulatedDevice.reset): Ditto.
263         (SimulatedDevice.__eq__): Moved to device.py.
264         (SimulatedDevice.__ne__): Ditto.
265         (SimulatedDevice.__repr__): Call Device __repr__ first.
266         (DeviceType): Kept in Scripts/webkitpy/xcode/simulator.py.
267         (Runtime): Kept in Scripts/webkitpy/xcode/simulator.py.
268         (Device): Renamed SimulatedDevice.
269         (Simulator): Kept in Scripts/webkitpy/xcode/simulator.py.
270         * Scripts/webkitpy/xcode/simulator.py:
271         (Simulator): Define Simulator.Device class as None.
272         (Simulator.__init__): Import SimulatedDevice as Simulator.Device.
273         (Simulator.delete_device): Use Simulator.Device.
274         (Simulator.reset_device): Ditto.
275         (Simulator._parse_devices): Ditto.
276         (Simulator.lookup_or_create_device): Make 
277         (Device): Moved to simulated_device as SimulatedDevice.
278
279 2017-02-21  JF Bastien  <jfbastien@apple.com>
280
281         Fix cmake build
282         https://bugs.webkit.org/show_bug.cgi?id=168665
283
284         Reviewed by Mark Lam.
285
286         It was broken by r212555 and r212681.
287
288         * DumpRenderTree/PlatformMac.cmake:
289
290 2017-02-21  Alexey Proskuryakov  <ap@apple.com>
291
292         Improve bot watcher's dashboard performance
293         https://bugs.webkit.org/show_bug.cgi?id=168624
294         <rdar://problem/30190109>
295
296         Reviewed by Daniel Bates.
297
298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
299         There was an unnecessary linear complexity algorithm in indexOfRevision().
300
301 2017-02-21  Alex Christensen  <achristensen@webkit.org>
302
303         Unreviewed, rolling out r212699.
304
305         Internal build not ready
306
307         Reverted changeset:
308
309         "[WebRTC][Mac] Activate libwebrtc"
310         https://bugs.webkit.org/show_bug.cgi?id=167293
311         http://trac.webkit.org/changeset/212699
312
313 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
314
315         Remove ENABLE_THREADED_COMPOSITOR build option
316         https://bugs.webkit.org/show_bug.cgi?id=168606
317
318         Reviewed by Michael Catanzaro.
319
320         * Scripts/webkitperl/FeatureList.pm:
321
322 2017-02-20  Youenn Fablet  <youenn@apple.com>
323
324         [WebRTC][Mac] Activate libwebrtc
325         https://bugs.webkit.org/show_bug.cgi?id=167293
326         <rdar://problem/30401864>
327
328         Reviewed by Alex Christensen.
329
330         Fixing paths to allow loading libwebrtc.dylib successfully.
331
332         * Scripts/build-webkit:
333         * Scripts/webkitdirs.pm:
334         (setupMacWebKitEnvironment):
335         (setupIOSWebKitEnvironment):
336
337 2017-02-20  Ryan Haddad  <ryanhaddad@apple.com>
338
339         Unreviewed, rolling out r212685.
340
341         This change broke the 32-bit Sierra build.
342
343         Reverted changeset:
344
345         "Resource Load Statistics: Add alternate classification
346         method"
347         https://bugs.webkit.org/show_bug.cgi?id=168347
348         http://trac.webkit.org/changeset/212685
349
350 2017-02-20  John Wilander  <wilander@apple.com>
351
352         Resource Load Statistics: Add alternate classification method
353         https://bugs.webkit.org/show_bug.cgi?id=168347
354         <rdar://problem/30352793>
355
356         Reviewed by Alex Christensen.
357
358         Added three testRunner functions to facilitate layout tests:
359         - setStatisticsSubframeUnderTopFrameOrigin()
360         - setStatisticsSubresourceUnderTopFrameOrigin()
361         - setStatisticsSubresourceUniqueRedirectTo()
362
363         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
364         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
365         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
366         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
367         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
368         * WebKitTestRunner/InjectedBundle/TestRunner.h:
369         * WebKitTestRunner/TestController.cpp:
370         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
371         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
372         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
373         * WebKitTestRunner/TestController.h:
374         * WebKitTestRunner/TestInvocation.cpp:
375         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
376
377 2017-02-20  Anders Carlsson  <andersca@apple.com>
378
379         Use the new drag code path when dragging links
380         https://bugs.webkit.org/show_bug.cgi?id=168612
381
382         Reviewed by Tim Horton.
383
384         If a type is not dynamic, just use the static UTI.
385
386         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
387         (-[LocalPasteboard writeObjects:]):
388
389 2017-02-17  Anders Carlsson  <andersca@apple.com>
390
391         Add a new drag code path and use it for dragging plain text
392         https://bugs.webkit.org/show_bug.cgi?id=168534
393
394         Reviewed by Geoffrey Garen.
395
396         Update the testing infrastructure to handle NSDraggingSession.
397
398         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
399         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m.
400         (-[LocalPasteboard writeObjects:]):
401         Implement this in terms of the legacy pasteboard API.
402
403         * DumpRenderTree/mac/EventSendingController.mm:
404         (drt_WebHTMLView_beginDraggingSessionWithItemsEventSource):
405         (+[EventSendingController initialize]):
406         Swizzle the drag method instead of adding a delegate method (like the old code does).
407
408 2017-02-20  Florian Bruhin  <git@the-compiler.org>
409
410         Handle EINTR during webkitpy server process select()
411         https://bugs.webkit.org/show_bug.cgi?id=168361
412
413         Reviewed by Michael Catanzaro.
414
415         Otherwise, on my machine, resizing the terminal run-webkit-tests is running in
416         makes it die.
417
418         * Scripts/webkitpy/port/server_process.py:
419         (ServerProcess._wait_for_data_and_update_buffers_using_select):
420
421 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
422
423         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu.
424
425         It can happen that the window onload event is dispatched after the load finished is received in the UI
426         process. Move the script to select the text to the body instead of using a window onload handler.
427
428         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
429         (testContextMenuDefaultMenu):
430
431 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
432
433         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
434         https://bugs.webkit.org/show_bug.cgi?id=167693
435
436         Reviewed by Sergio Villar Senin.
437
438         * Scripts/webkitperl/FeatureList.pm:
439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
440         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
441         (TestWebKitAPI::computeNumberOfTracks):
442         (TestWebKitAPI::TEST):
443         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
444         (TestWebKitAPI::TEST):
445
446 2017-02-19  Commit Queue  <commit-queue@webkit.org>
447
448         Unreviewed, rolling out r212466.
449         https://bugs.webkit.org/show_bug.cgi?id=168577
450
451         causes crashes on AArch64 on linux, maybe it's causing crashes
452         on iOS too (Requested by pizlo on #webkit).
453
454         Reverted changeset:
455
456         "The collector thread should only start when the mutator
457         doesn't have heap access"
458         https://bugs.webkit.org/show_bug.cgi?id=167737
459         http://trac.webkit.org/changeset/212466
460
461 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
462
463         Fix failure from r212579.
464
465         Unreviewed build-fix.
466
467         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
468         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
469
470 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
471
472         EWS should run JavaScriptCore tests
473         https://bugs.webkit.org/show_bug.cgi?id=162458
474
475         Reviewed by Alexey Proskuryakov.
476
477         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
478         * QueueStatusServer/model/queuestatus.py:
479         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
480         * QueueStatusServer/handlers/statusbubble.py:
481         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
482         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
483         (MockSCM.__init__): Add _mockChangedFiles variable.
484         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
485         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
486         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
487         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
488         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
489         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
490         (MacPort.run_webkit_tests_command): Check for JSC.
491         * Scripts/webkitpy/common/config/ports_mock.py:
492         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
493         * Scripts/webkitpy/common/config/ports_unittest.py:
494         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
495         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
496         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
497         (AbstractTestResults.test_results): Stub.
498         (AbstractTestResults.failing_tests): Stub.
499         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
500         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
501         (JSCTestResults): Added.
502         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
503         (JSCTestResults.results_from_string): Use json library to parse results.
504         (JSCTestResults.__init__): Initialize members.
505         (JSCTestResults.equals): This enables unit testing.
506         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
507         (JSCTestResults.all_passed): Getter.
508         (JSCTestResults.failing_tests): Getter.
509         (JSCTestResults.did_exceed_test_failure_limit): Getter.
510         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
511         (JSCTestResultsTest): Class to test JSCTestResults.
512         (JSCTestResultsTest.test_results_from_string): Tests parsing.
513         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
514         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
515         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
516         * Scripts/webkitpy/port/base.py:
517         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
518         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
519         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
520         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
521         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
522         (MockPatchAnalysisTask.__init__): Sets attributes.
523         (MockPatchAnalysisTask._test): Override to not run command.
524         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
525         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
526         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
527         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
528         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
529         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
530         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
531         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
532         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
533         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
534         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
535         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
536         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
537         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
538         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
539         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
540         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
541         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
542         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
543         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
544         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
545         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
546         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
547         (JSCTestResultsReader): Reads results file.
548         (JSCTestResultsReader.__init__): Sets attributes.
549         (JSCTestResultsReader._read_file_contents): Reads file.
550         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
551         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
552         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
553         (PatchAnalysisTask._check_patch_relevance): Added.
554         (PatchAnalysisTask._build): Check for JSC.
555         (PatchAnalysisTask._build_without_patch): Check for JSC.
556         (PatchAnalysisTask._test): Check for JSC.
557         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
558         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
559         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
560         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
561         * Scripts/webkitpy/tool/commands/download.py:
562         (CheckPatchRelevance): Add check-patch-relevance command.
563         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
564         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
565         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
566         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
567         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
568         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
569         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
570         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
571         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
572         (TestEWS): Sample layout test EWS class used for unit testing.
573         (TestJSCEWS): Sample JSC EWS class used for unit testing.
574         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
575         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
576         (AbstractEarlyWarningSystemTest): Add _group variable.
577         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
578         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
579         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
580         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
581         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
582         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
583         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
584         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
585         * Scripts/webkitpy/tool/steps/build.py:
586         (Build.options): Check for JSC.
587         (Build.build): Check for JSC.
588         (Build.run): Check for JSC.
589         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
590         (CheckPatchRelevance): Added.
591         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
592         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
593         * Scripts/webkitpy/tool/steps/options.py:
594         (Options): Add --group command line option.
595         * Scripts/webkitpy/tool/steps/runtests.py:
596         (RunTests.options): Add group.
597         (RunTests.run): Check for JSC.
598         (RunTests._run_webkit_tests): Check for JSC.
599         (RunTests): Add _group attribute.
600         (RunTests._run_javascriptcore_tests): New.
601         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
602
603 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
604
605         Fix tools that were broken by Efl removal
606         https://bugs.webkit.org/show_bug.cgi?id=168496
607
608         Reviewed by Alexey Proskuryakov.
609
610         * QueueStatusServer/config/queues.py:
611         * Scripts/webkitpy/common/config/ews.json:
612         * TestResultServer/static-dashboards/builders.jsonp:
613         * TestResultServer/static-dashboards/flakiness_dashboard.js:
614         * TestResultServer/static-dashboards/loader_unittests.js:
615
616 2017-02-16  Lucas Forschler  <lforschler@apple.com>
617
618         https://bugs.webkit.org/show_bug.cgi?id=168442
619         Move the SVN checkout from http -> https.
620         Update unit tests.
621
622         Reviewed by Alexey Proskuryakov.
623
624         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
625         (CheckOutSource.__init__):
626         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
627         (SVNMirrorTest.get_SVNMirrorFromConfig):
628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
629
630 2017-02-16  Commit Queue  <commit-queue@webkit.org>
631
632         Unreviewed, rolling out r212514.
633         https://bugs.webkit.org/show_bug.cgi?id=168489
634
635         broke test runner (Requested by alexchristensen on #webkit).
636
637         Reverted changeset:
638
639         "Remove EFL-specific files in Tools."
640         http://trac.webkit.org/changeset/212514
641
642 2017-02-16  Alex Christensen  <achristensen@webkit.org>
643
644         Remove EFL-specific files in Tools.
645
646         Rubber-stamped by Anders Carlsson.
647
648         * ImageDiff/efl: Removed.
649         * ImageDiff/efl/ImageDiff.cpp: Removed.
650         * MiniBrowser/efl: Removed.
651         * MiniBrowser/efl/CMakeLists.txt: Removed.
652         * MiniBrowser/efl/main.c: Removed.
653         * Scripts/run-efl-tests: Removed.
654         * Scripts/update-webkitefl-libs: Removed.
655         * Scripts/webkitpy/port/efl.py: Removed.
656         * Scripts/webkitpy/port/efl_unittest.py: Removed.
657         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
658         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
659         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
660         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
661         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
662         * TestWebKitAPI/efl: Removed.
663         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
664         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
665         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
666         * TestWebKitAPI/efl/main.cpp: Removed.
667         * WebKitTestRunner/InjectedBundle/efl: Removed.
668         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
669         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
670         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
671         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
672         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
673         * WebKitTestRunner/efl: Removed.
674         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
675         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
676         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
677         * WebKitTestRunner/efl/main.cpp: Removed.
678         * efl: Removed.
679         * efl/install-dependencies: Removed.
680         * efl/jhbuild-optional.modules: Removed.
681         * efl/jhbuild.modules: Removed.
682         * efl/jhbuildrc: Removed.
683         * efl/patches: Removed.
684         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
685         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
686         * efl/patches/gst-libav.patch: Removed.
687         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
688         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
689         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
690         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
691
692 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
693
694         font-weight in @font-face can cause a font to be downloaded even when it's not used
695         https://bugs.webkit.org/show_bug.cgi?id=168114
696         <rdar://problem/30301317>
697
698         Reviewed by Darin Adler.
699
700         LastResort needs to be usable in tests.
701
702         * DumpRenderTree/mac/DumpRenderTree.mm:
703         (allowedFontFamilySet):
704         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
705         (WTR::allowedFontFamilySet):
706         * WebKitTestRunner/mac/TestControllerMac.mm:
707         (WTR::allowedFontFamilySet):
708
709 2017-02-16  Alex Christensen  <achristensen@webkit.org>
710
711         Remove old URL parser
712         https://bugs.webkit.org/show_bug.cgi?id=168483
713
714         Reviewed by Tim Horton.
715
716         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
717         (TestWebKitAPI::checkURL):
718         (TestWebKitAPI::checkRelativeURL):
719         (TestWebKitAPI::checkURLDifferences):
720         (TestWebKitAPI::checkRelativeURLDifferences):
721
722 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
723
724         [WK2] Add additional test infrastructure and unit tests for data interaction
725         https://bugs.webkit.org/show_bug.cgi?id=168439
726         <rdar://problem/30557942>
727
728         Reviewed by Tim Horton.
729
730         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
731         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
732         support data interaction from  See per-method descriptions below for more details.
733
734         * Configurations/TestWebKitAPI.xcconfig:
735
736         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
737
738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
739
740         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
741         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
742
743         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
744         (-[TestWKWebView editorContainsImageElement]):
745         (-[TestWKWebView editorValue]):
746
747         New helper methods for querying information from the "editor" element in a test page.
748
749         (TestWebKitAPI::TEST):
750         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
751
752         Moves logic for capturing events during a simulated data interaction run from the test file to
753         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
754
755         * TestWebKitAPI/cocoa/TestWKWebView.h:
756         * TestWebKitAPI/cocoa/TestWKWebView.mm:
757         (-[TestMessageHandler removeMessage:]):
758         (-[TestWKWebView clearMessageHandlers:]):
759
760         Add the ability to clear message handlers from the TestWKWebView.
761
762         * TestWebKitAPI/ios/DataInteractionSimulator.h:
763         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
764         (dataInteractionEventNames):
765         (-[DataInteractionSimulator initWithWebView:]):
766         (-[DataInteractionSimulator _resetSimulatedState]):
767
768         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
769         simulating data interaction.
770
771         (-[DataInteractionSimulator observedEventNames]):
772
773         Returns a list of the names of events relevant to data interaction that were observed over the course of the
774         most recent run.
775
776         (-[DataInteractionSimulator runFrom:to:]):
777
778         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
779         to run the same data interaction for multiple simulated gestures.
780
781         (-[DataInteractionSimulator _advanceProgress]):
782         (-[DataInteractionSimulator _finishDataInteraction]):
783         (-[DataInteractionSimulator externalItemProvider]):
784         (-[DataInteractionSimulator setExternalItemProvider:]):
785
786         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
787         phase of a test run.
788
789         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
790         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
791         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
792         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
793
794         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
795         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
796         wherein the the web process might take longer than usual to process the request to start data interaction, and
797         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
798         the web process is received, which then causes no simulated delegate methods to be fired.
799
800         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
801         (-[DataInteractionSimulator run]): Deleted.
802
803 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
804
805         Remove unused test pages in TestWebKitAPI
806         https://bugs.webkit.org/show_bug.cgi?id=168462
807
808         Reviewed by Anders Carlsson.
809
810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
811         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
812         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
813         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
814         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
815         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
816
817 2017-02-16  Alex Christensen  <achristensen@webkit.org>
818
819         Special URLs without a host are invalid
820         https://bugs.webkit.org/show_bug.cgi?id=168461
821
822         Reviewed by Tim Horton.
823
824         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
825         (TestWebKitAPI::TEST_F):
826
827 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
828
829         The collector thread should only start when the mutator doesn't have heap access
830         https://bugs.webkit.org/show_bug.cgi?id=167737
831
832         Reviewed by Keith Miller.
833         
834         Make more tests collect continuously.
835
836         * Scripts/run-jsc-stress-tests:
837
838 2017-02-16  Tim Horton  <timothy_horton@apple.com>
839
840         WKWebView inside a UICollectionView flashes when items are inserted above it
841         https://bugs.webkit.org/show_bug.cgi?id=168376
842         <rdar://problem/29322051>
843
844         Reviewed by Simon Fraser.
845
846         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
847         (-[TestRunnerWKWebView _setStableStateOverride:]):
848         Update the one external caller of this internal method...
849
850         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
851         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
852         * DumpRenderTree/mac/UIScriptControllerMac.mm:
853         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
854         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
855         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
856         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
857         * TestRunnerShared/UIScriptContext/UIScriptController.h:
858         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
859         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
860         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
861         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
862         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
863         back after we dispatch a visible content rect update from the UI process
864         to the Web Content process, so any messages sent from the block will arrive
865         after the visible content rect update.
866
867 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
868
869         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
870         https://bugs.webkit.org/show_bug.cgi?id=168321
871
872         This bots should be added to the trunk build scheduler.
873         Unreviewed fix after r212429.
874
875         * BuildSlaveSupport/build.webkit.org-config/config.json:
876
877 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
878
879         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
880         https://bugs.webkit.org/show_bug.cgi?id=168321
881
882         Reviewed by Michael Catanzaro.
883
884         The additionalArgument --default-cmake-features is used both to
885         skip the JHBuild (InstallGtkDependencies) build step and to build
886         with the default features from the CMake config.
887
888         * BuildSlaveSupport/build.webkit.org-config/config.json:
889         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
890         (Factory.__init__):
891         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
892
893 2017-02-15  Lucas Forschler  <lforschler@apple.com>
894
895         https://bugs.webkit.org/show_bug.cgi?id=168386
896         Remove EFL from build.webkit.org
897
898         Reviewed by Alex Christensen
899
900         * BuildSlaveSupport/build.webkit.org-config/config.json:
901         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
902         (DeleteStaleBuildFiles.start):
903         (appendCustomBuildFlags):
904         (RunWebKitTests.start):
905         (RunBuiltinsTests):
906         (Factory.__init__):
907         (TestFactory.__init__):
908         (loadBuilderConfig):
909         (InstallEflDependencies): Deleted.
910         (RunEflAPITests): Deleted.
911         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
913         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
914         (BubbleQueueServer):
915         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
916         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
917         (Analyzer.prototype._triggeringQueue):
918         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
919         (WebKitBuildbot):
920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
921         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
922         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
923         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
924         (_should_file_trigger_build):
925
926 2017-02-15  Alex Christensen  <achristensen@webkit.org>
927
928         Unreviewed, rolling out r212169.
929
930         Broke iOS WebInspector
931
932         Reverted changeset:
933
934         "WebInspector: refactor RemoteInspector to move cocoa specific
935         code to their own files"
936         https://bugs.webkit.org/show_bug.cgi?id=166681
937         http://trac.webkit.org/changeset/212169
938
939 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
940
941         webkitpy: Fix DarwinPort._get_crash_log()
942         https://bugs.webkit.org/show_bug.cgi?id=168372
943         <rdar://problem/30535156>
944
945         Reviewed by Daniel Bates.
946
947         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
948         DarwinPort should return the expected return value for _get_crash_log.
949
950         * Scripts/webkitpy/port/darwin.py:
951         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
952
953 2017-02-15  Chris Dumez  <cdumez@apple.com>
954
955         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
956         https://bugs.webkit.org/show_bug.cgi?id=168291
957         <rdar://problem/30508593>
958
959         Reviewed by Tim Horton.
960
961         Drop overridePreference() implementation in iOS's UIScriptController
962         as it was only used for the minimum font size setting and this setting
963         is not exposed on iOS.
964
965         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
966         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
967         (WTR::UIScriptController::overridePreference):
968         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
969
970 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
971
972         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
973         https://bugs.webkit.org/show_bug.cgi?id=168329
974         <rdar://problem/30518832>
975
976         Reviewed by Daniel Bates.
977
978         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
979         never change given the same input arguments.  Memoize function for efficiency.
980
981         * Scripts/webkitpy/port/darwin.py: Add memoized import.
982         (DarwinPort):
983         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
984         
985
986 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
987
988         webkitpy: Remove unused import from darwin.py
989         https://bugs.webkit.org/show_bug.cgi?id=168371
990
991         Reviewed by Alex Christensen.
992
993         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
994
995 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
996
997         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
998         https://bugs.webkit.org/show_bug.cgi?id=168364
999
1000         Reviewed by Michael Catanzaro.
1001
1002         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
1003         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
1004         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
1005
1006         Fixes: http/tests/security/credentials-from-different-domains.html
1007                http/tests/xmlhttprequest/cross-origin-no-authorization.html
1008
1009         * gtk/jhbuild.modules:
1010         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
1011         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
1012
1013 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1014
1015         [GTK] Update cookie manager API to properly work with ephemeral sessions
1016         https://bugs.webkit.org/show_bug.cgi?id=168230
1017
1018         Reviewed by Michael Catanzaro.
1019
1020         Update unit tests and add new cases for the new API.
1021
1022         * MiniBrowser/gtk/main.c:
1023         (gotWebsiteDataCallback):
1024         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1025         (testCookieManagerEphemeral):
1026         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1027         (testWebContextEphemeral):
1028         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1029         (testWebViewEphemeral):
1030         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1031         (serverCallback):
1032         (testWebsiteDataEphemeral):
1033         (testWebsiteDataCookies):
1034         (beforeAll):
1035
1036 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1037
1038         [WK2] Support data interaction on links
1039         https://bugs.webkit.org/show_bug.cgi?id=168331
1040         <rdar://problem/30200837>
1041
1042         Reviewed by Tim Horton.
1043
1044         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
1045         editable area results in the link URL being inserted.
1046
1047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1048         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1049         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1050         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1051         (TestWebKitAPI::TEST):
1052
1053 2017-02-14  Jason Rinn  <jrinn@apple.com>
1054
1055         Add a test for new WebKit Cocoa API, _getContentsAsString.
1056         https://bugs.webkit.org/show_bug.cgi?id=168147
1057         <rdar://problem/30502539>
1058
1059         Reviewed by Tim Horton.
1060
1061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1062         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
1063         (TEST):
1064
1065 2017-02-14  Matt Rajca  <mrajca@apple.com>
1066
1067         Website policies: iframes should respect the autoplay policy of the top-level document
1068         https://bugs.webkit.org/show_bug.cgi?id=168333
1069
1070         Reviewed by Alex Christensen.
1071
1072         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
1073         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
1074         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1075         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1076         (TEST):
1077
1078 2017-02-14  Chris Dumez  <cdumez@apple.com>
1079
1080         HTML Form Validation bubble should take minimum font size setting into consideration
1081         https://bugs.webkit.org/show_bug.cgi?id=168271
1082         <rdar://problem/29869869>
1083
1084         Reviewed by Simon Fraser.
1085
1086         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
1087         font size of the validation bubble.
1088
1089         Add an overridePreference() method to UIScriptController. This is currently
1090         used to override the value of the minimumFontSize setting. testRunner's
1091         overridePreference() is not usable on WK2 because it does not update the
1092         value of the preference on the UIProcess side.
1093
1094         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1095         (WTR::UIScriptController::overridePreference):
1096         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1097         (WTR::UIScriptController::overridePreference):
1098         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1099         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1100         * WebKitTestRunner/TestController.cpp:
1101         (WTR::TestController::resetPreferencesToConsistentValues):
1102         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1103         (WTR::UIScriptController::overridePreference):
1104         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1105         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1106         (WTR::UIScriptController::overridePreference):
1107
1108 2017-02-14  Florian Bruhin  <git@the-compiler.org>
1109
1110         Use a set instead of a list for tests when parsing expectations
1111         https://bugs.webkit.org/show_bug.cgi?id=168304
1112
1113         In _collect_matching_tests, a lot of membership tests are done on a giant list
1114         of strings. By making it a set instead, we can make those much faster, and
1115         there's no reason for it to be a list.
1116
1117         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
1118         to 3s on my machine.
1119
1120         Reviewed by Ryosuke Niwa.
1121
1122         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1123         (TestExpectationParser.__init__):
1124         (TestExpectationParser._collect_matching_tests):
1125
1126 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
1127
1128         Unreviewed build-fix after r212297.
1129
1130         * Scripts/webkitpy/port/simulator_process.py:
1131         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
1132
1133 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1134
1135         [CMake] build-webkit should allow building with the default cmake configuration
1136         https://bugs.webkit.org/show_bug.cgi?id=168323
1137
1138         Reviewed by Michael Catanzaro.
1139
1140         Add a --default-cmake-features switch that makes the script pass
1141         no value for any of the features defined by build-webkit, that
1142         way the default values from the port cmake config will be used.
1143
1144         * Scripts/build-webkit:
1145         (cMakeArgsFromFeatures):
1146
1147 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
1148
1149         Unreviewed build-fix after r212297.
1150
1151         * Scripts/webkitpy/port/simulator_process.py:
1152         (SimulatorProcess.stop): Handle case where there is no process to kill.
1153
1154 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1155
1156         [CMake] build-webkit should print the cmake command executed
1157         https://bugs.webkit.org/show_bug.cgi?id=168318
1158
1159         Reviewed by Michael Catanzaro.
1160
1161         Run the cmake commands to configure or start the build through
1162         a wrapper that prints the command before executing it.
1163
1164         * Scripts/webkitdirs.pm:
1165         (systemVerbose):
1166         (generateBuildSystemFromCMakeProject):
1167         (buildCMakeGeneratedProject):
1168         (cleanCMakeGeneratedProject):
1169
1170 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
1171
1172         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
1173         https://bugs.webkit.org/show_bug.cgi?id=168150
1174
1175         Reviewed by Alexey Proskuryakov.
1176
1177         * Scripts/webkitpy/port/simulator_process.py:
1178         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
1179         (SimulatorProcess._kill): Move closing of app into stop().
1180         * Scripts/webkitpy/xcode/simulator.py:
1181         (Device.launch_app):
1182         (Device.terminate_app): Deleted.
1183
1184 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1185
1186         REGRESSION(r212192): [GTK] Broke downloads API tests
1187         https://bugs.webkit.org/show_bug.cgi?id=168193
1188
1189         Unreviewed. Update test expectations after r212192.
1190
1191         The suggested filename now includes a file extensions if the MIME type is known.
1192
1193         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1194         (testDownloadRemoteFile):
1195         (testDownloadMIMEType):
1196
1197 2017-02-14  Commit Queue  <commit-queue@webkit.org>
1198
1199         Unreviewed, rolling out r212237.
1200         https://bugs.webkit.org/show_bug.cgi?id=168298
1201
1202         This was a wrong fix (Requested by rniwa on #webkit).
1203
1204         Reverted changeset:
1205
1206         "Nwtr unexpectedly passes mismatch ref test if the hashes
1207         doesn't match but no diff"
1208         https://bugs.webkit.org/show_bug.cgi?id=168221
1209         http://trac.webkit.org/changeset/212237
1210
1211 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1212
1213         URLs with an invalid IPv4 address should be invalid
1214         https://bugs.webkit.org/show_bug.cgi?id=168260
1215
1216         Reviewed by Tim Horton.
1217
1218         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1219         (TestWebKitAPI::TEST_F):
1220         Update tests to reflect new correct behavior.
1221
1222 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
1223
1224         [WinCairo] Add Build Slave
1225         https://bugs.webkit.org/show_bug.cgi?id=168263
1226
1227         Reviewed by Lucas Forschler.
1228
1229         * BuildSlaveSupport/build.webkit.org-config/config.json:
1230
1231 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1232
1233         Fix the build after r212254
1234
1235         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1236         (-[DataInteractionSimulator _currentLocation]):
1237
1238 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1239
1240         [WK2] Add test infrastructure and unit tests for data interaction
1241         https://bugs.webkit.org/show_bug.cgi?id=168159
1242         <rdar://problem/30477634>
1243
1244         Reviewed by Tim Horton.
1245
1246         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
1247         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
1248         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
1249         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
1250         gesture has already been recognized) at regular intervals over the course of the test.
1251
1252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1253         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1254         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1255         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1256
1257         New test pages for data interaction.
1258
1259         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
1260         (TestWebKitAPI::runTestsExpectingToObserveEvents):
1261         (TestWebKitAPI::TEST):
1262         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1263         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1264         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
1265         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
1266         (-[MockLongPressGestureRecognizer initWithWindow:]):
1267         (-[MockLongPressGestureRecognizer locationInView:]):
1268         (-[MockLongPressGestureRecognizer state]):
1269         (-[MockLongPressGestureRecognizer numberOfTouches]):
1270         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
1271         (-[DataInteractionSimulator dealloc]):
1272         (-[DataInteractionSimulator run]):
1273
1274         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
1275         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
1276         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
1277
1278         (-[DataInteractionSimulator _advanceProgress]):
1279
1280         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
1281         completed, and calls _finishDataInteraction when progress is at 1.
1282
1283         (-[DataInteractionSimulator _finishDataInteraction]):
1284         (-[DataInteractionSimulator _currentLocation]):
1285         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
1286         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
1287         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
1288         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
1289         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
1290
1291 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1292
1293         Percent should be allowed in non-special URL hosts
1294         https://bugs.webkit.org/show_bug.cgi?id=168255
1295
1296         Reviewed by Tim Horton.
1297
1298         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1299         (TestWebKitAPI::TEST_F):
1300
1301 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1302
1303         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
1304         https://bugs.webkit.org/show_bug.cgi?id=168221
1305
1306         Reviewed by Ryosuke Niwa.
1307
1308         There is a logic error in comparing mismatch ref test images. In
1309         mismatch ref tests, it should be failed if two images has no diff.
1310         But, if the hashes are different, nwtr unexpectedly pass the
1311         mismatch ref test.
1312
1313         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1314         (SingleTestRunner._compare_output_with_reference): Fail the
1315         mismatch ref test if hashes of two images are equal. Invoke
1316         ImageDiff if the hashes don't match.
1317
1318 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
1319
1320         Update custom line breaking iterators to the latest version of Unicode
1321         https://bugs.webkit.org/show_bug.cgi?id=168182
1322
1323         Reviewed by Zalan Bujtas.
1324
1325         Treat the system's ICU as the source of truth to compare breaking positions against.
1326
1327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1328         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
1329         (generateJavaScriptForTest):
1330         (breakingLocationsFromICU):
1331         (testAFewStrings):
1332         (TEST):
1333         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
1334         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
1335
1336 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1337
1338         [GTK] Several failing WebViewEditor API tests
1339         https://bugs.webkit.org/show_bug.cgi?id=161608
1340
1341         Reviewed by Carlos Garcia Campos.
1342
1343         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
1344         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
1345         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
1346         except the first one, which is still broken due to unrelated bug #151654.
1347
1348         * Scripts/run-gtk-tests:
1349         (TestRunner):
1350         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1351
1352 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1353
1354         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
1355
1356         * Scripts/run-gtk-tests:
1357         (TestRunner):
1358
1359 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1360
1361         Unreviewed, skip flaky form-controls-associated-signal test
1362
1363         * Scripts/run-gtk-tests:
1364         (TestRunner):
1365
1366 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1367
1368         [GTK] Handle caps lock indicator in event modifiers
1369         https://bugs.webkit.org/show_bug.cgi?id=168186
1370
1371         Reviewed by Michael Catanzaro.
1372
1373         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1374         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
1375
1376 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
1377
1378         MiniBrowser WK1 fails to update URL for within-page navigations
1379         https://bugs.webkit.org/show_bug.cgi?id=168173
1380
1381         Reviewed by Tim Horton.
1382         
1383         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
1384         anchors updates the URL field.
1385
1386         * MiniBrowser/mac/WK1BrowserWindowController.m:
1387         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
1388
1389 2017-02-10  John Wilander  <wilander@apple.com>
1390
1391         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
1392         https://bugs.webkit.org/show_bug.cgi?id=167474
1393         <rdar://problem/24681808>
1394         <rdar://problem/24703286>
1395         <rdar://problem/30290270>
1396
1397         This patch adds test infrastructure to allow testing 
1398         of the various rules in place for data records removal.
1399
1400         Reviewed by Andy Estes.
1401
1402         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1403         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1404         (WTR::InjectedBundle::didReceiveMessageToPage):
1405             Callback mechanism to tell pages that a website data store
1406             scan has happened.
1407         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1408         (WTR::TestRunner::setStatisticsPrevalentResource):
1409         (WTR::TestRunner::isStatisticsPrevalentResource):
1410         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1411         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1412         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1413         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
1414         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
1415         (WTR::TestRunner::statisticsFireDataModificationHandler):
1416         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1417         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1418         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1419         (WTR::TestRunner::statisticsResetToConsistentState):
1420         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1421         * WebKitTestRunner/TestController.cpp:
1422         (WTR::TestController::setStatisticsPrevalentResource):
1423         (WTR::TestController::isStatisticsPrevalentResource):
1424         (WTR::TestController::setStatisticsHasHadUserInteraction):
1425         (WTR::TestController::isStatisticsHasHadUserInteraction):
1426         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1427         (WTR::TestController::statisticsFireDataModificationHandler):
1428         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1429         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1430         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1431         (WTR::TestController::statisticsResetToConsistentState):
1432         * WebKitTestRunner/TestController.h:
1433             These are all configuration and test functions.
1434         * WebKitTestRunner/TestInvocation.cpp:
1435         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1436
1437 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1438
1439         REGRESSION(r182916) run-perf-tests never timeouts
1440         https://bugs.webkit.org/show_bug.cgi?id=167626
1441
1442         Reviewed by Ryosuke Niwa.
1443
1444         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1445         was beeing ignored because the driver was created with no_timeout=True
1446         unconditionally.
1447         This adds a new parameter --no-timeout (disabled by default), that
1448         allows to use the driver with the expected timeout values.
1449         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1450         are always controlled by the Python Driver.
1451
1452         * Scripts/webkitpy/performance_tests/perftest.py:
1453         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1454         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1455         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1456         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1457         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1458         (_run_tests_set): Pass the no-timeout parameter.
1459         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1460         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1461         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1462         (MainTest.test_parse_args): Test that the argument no-timeout.
1463
1464 2017-02-10  Daniel Bates  <dabates@apple.com>
1465
1466         Detach frame from document when entering page cache
1467         https://bugs.webkit.org/show_bug.cgi?id=166774
1468         <rdar://problem/29904368>
1469
1470         Reviewed by Chris Dumez.
1471
1472         * DumpRenderTree/mac/DumpRenderTree.mm:
1473         (resetWebPreferencesToConsistentValues):
1474         * DumpRenderTree/win/DumpRenderTree.cpp:
1475         (resetWebPreferencesToConsistentValues):
1476         * WebKitTestRunner/TestController.cpp:
1477         (WTR::TestController::resetPreferencesToConsistentValues):
1478
1479 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1480
1481         Infinite UI process hang under ensurePositionInformationIsUpToDate
1482         https://bugs.webkit.org/show_bug.cgi?id=168154
1483         <rdar://problem/30428673>
1484
1485         Reviewed by Simon Fraser.
1486
1487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1488         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1489         (recursiveFindHighlightLongPressRecognizer):
1490         (TEST):
1491         Add a somewhat nasty test that does an async interaction information update, but
1492         kills the Web process before it arrives, and then does a sync interaction
1493         information update, which will wait for the oustanding async interaction
1494         information update if we still think it's coming. Before the patch, this
1495         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1496
1497 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1498
1499         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1500         https://bugs.webkit.org/show_bug.cgi?id=168127
1501         rdar://problem/30467120
1502
1503         Reviewed by Tim Horton.
1504
1505         Reparent the web view before we try to fetch it via:
1506             [[[window contentView] subviews] objectAtIndex:0];
1507         which would throw an exception if the test unparented it.
1508
1509         * DumpRenderTree/mac/DumpRenderTree.mm:
1510         (resetWebViewToConsistentStateBeforeTesting):
1511         (runTest):
1512
1513 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1514
1515         [Resource Timing] Enable Resource Timing by default in Tests
1516         https://bugs.webkit.org/show_bug.cgi?id=168145
1517
1518         Reviewed by Ryosuke Niwa.
1519
1520         * DumpRenderTree/mac/DumpRenderTree.mm:
1521         (resetWebPreferencesToConsistentValues):
1522         * DumpRenderTree/win/DumpRenderTree.cpp:
1523         (resetWebPreferencesToConsistentValues):
1524         * WebKitTestRunner/TestController.cpp:
1525         (WTR::TestController::resetPreferencesToConsistentValues):
1526
1527 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1528
1529         Removing LayoutTestRelay
1530         https://bugs.webkit.org/show_bug.cgi?id=165927
1531
1532         Reviewed by Daniel Bates.
1533         Part 2
1534
1535         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1536         simulators through simctl (iOS 10 and later), use this functionality instead.
1537
1538         * BuildSlaveSupport/built-product-archive:
1539         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1540         Added a FIXME that we will need to implement similar archiving machinery once we build
1541         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1542         * BuildSlaveSupport/kill-old-processes:
1543         (main): Remove LayoutTestRelay from list of processes.
1544         * LayoutTestRelay: Removed LayoutTestRelay.
1545         * Makefile:
1546         * Scripts/build-layouttestrelay: Removed.
1547         * Scripts/build-webkit: Removed LayoutTestRelay references.
1548
1549 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1550
1551         [WebCrypto] Add WebCryptoAPI to watchlist
1552         https://bugs.webkit.org/show_bug.cgi?id=168138
1553
1554         Reviewed by Youenn Fablet.
1555
1556         * Scripts/webkitpy/common/config/watchlist:
1557
1558 2017-02-10  Brady Eidson  <beidson@apple.com>
1559
1560         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1561         https://bugs.webkit.org/show_bug.cgi?id=168124
1562
1563         Reviewed by Geoffrey Garen.
1564
1565         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1566         
1567         * MiniBrowser/mac/main.m:
1568         (main):
1569         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1570         (main):
1571         * TestWebKitAPI/ios/mainIOS.mm:
1572         (main):
1573         * TestWebKitAPI/mac/mainMac.mm:
1574         (main):
1575         * WebKitTestRunner/ios/mainIOS.mm:
1576         (main):
1577         * WebKitTestRunner/mac/main.mm:
1578         (setDefaultsToConsistentValuesForTesting):
1579
1580 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1581
1582         Fix El Capitan build.
1583
1584         * Scripts/build-webkit:
1585         Don't build libwebrtc anywhere for now.
1586
1587 2017-02-10  Andy Estes  <aestes@apple.com>
1588
1589         Move two MiniBrowserBundle settings out of the .pbxproj
1590         https://bugs.webkit.org/show_bug.cgi?id=168106
1591
1592         Reviewed by Tim Horton.
1593
1594         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1595         the project file. This removes the project file override.
1596
1597         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1598
1599         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1600         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1601
1602 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1603
1604         Fix 32-and-64-bit build on El Capitan.
1605
1606         * Scripts/build-webkit:
1607         Somebody's building with something like this:
1608         build-webkit ARCHS="i386 x86_64"
1609         We want this to also not build libwebrtc for now.
1610
1611 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1612
1613         Fix 32-bit build on El Capitan.
1614
1615         * Scripts/build-webkit:
1616         The bot uses ARCHS=i386 instead of --32-bit.
1617         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1618
1619 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1620
1621         Fix 32-bit build on El Capitan.
1622
1623         * Scripts/build-webkit:
1624         Don't build i386 libwebrtc.
1625
1626 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1627
1628         Unreviewed, rolling out r212040.
1629
1630         Broke build.  I'm not surprised
1631
1632         Reverted changeset:
1633
1634         "[WebRTC][Mac] Activate libwebrtc"
1635         https://bugs.webkit.org/show_bug.cgi?id=167293
1636         http://trac.webkit.org/changeset/212040
1637
1638 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1639
1640         Build libwebrtc on bots without using it yet
1641         https://bugs.webkit.org/show_bug.cgi?id=168062
1642
1643         Reviewed by Brent Fulgham.
1644
1645         * Scripts/build-webkit:
1646
1647 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1648
1649         Don't build libwebrtc.
1650
1651         * Scripts/build-webkit:
1652         Not ready yet.  It broke El Capitan and iOS.
1653
1654 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1655
1656         Build libwebrtc on bots without using it yet
1657         https://bugs.webkit.org/show_bug.cgi?id=168062
1658
1659         Reviewed by Brent Fulgham.
1660
1661         * Scripts/build-webkit:
1662
1663 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1664
1665         Rename isAppleMacWebKit to isAppleCocoaWebKit
1666         https://bugs.webkit.org/show_bug.cgi?id=168075
1667
1668         Reviewed by Geoffrey Garen.
1669
1670         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1671
1672         * Scripts/build-api-tests:
1673         * Scripts/build-dumprendertree:
1674         * Scripts/build-jsc:
1675         (buildMyProject):
1676         * Scripts/build-layouttestrelay:
1677         * Scripts/build-webkit:
1678         * Scripts/build-webkittestrunner:
1679         * Scripts/run-api-tests:
1680         (isSupportedPlatform):
1681         (runTest):
1682         (listAllTests):
1683         (prepareEnvironmentForRunningTestTool):
1684         * Scripts/run-content-extension-tester:
1685         * Scripts/run-javascriptcore-tests:
1686         * Scripts/run-minibrowser:
1687         * Scripts/show-pretty-diff:
1688         * Scripts/webkitdirs.pm:
1689         (determineBaseProductDir):
1690         (determineArchitecture):
1691         (determinePassedArchitecture):
1692         (safariPath):
1693         (builtDylibPathForName):
1694         (checkFrameworks):
1695         (isAppleWebKit):
1696         (isAppleCocoaWebKit):
1697         (determineNmPath):
1698         (launcherName):
1699         (wrapperPrefixIfNeeded):
1700         (isCMakeBuild):
1701         (mobileSafariBundle):
1702         (debugSafari):
1703         (runSafari):
1704         (runMiniBrowser):
1705         (debugMiniBrowser):
1706         (runWebKitTestRunner):
1707         (debugWebKitTestRunner):
1708         (isAppleMacWebKit): Deleted.
1709         * Scripts/webkitperl/FeatureList.pm:
1710
1711 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1712
1713         Revert r211991
1714         https://bugs.webkit.org/show_bug.cgi?id=168062
1715
1716         * Scripts/build-webkit:
1717         Not quite ready yet.
1718
1719 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1720
1721         Build libwebrtc on bots without using it yet
1722         https://bugs.webkit.org/show_bug.cgi?id=168062
1723
1724         Reviewed by Brent Fulgham.
1725
1726         * Scripts/build-webkit:
1727         Build libwebrtc on Mac when we build ANGLE.
1728
1729 2017-02-09  Youenn Fablet  <youenn@apple.com>
1730
1731         Improve W3C importer command line options
1732         https://bugs.webkit.org/show_bug.cgi?id=167448
1733
1734         Reviewed by Ryosuke Niwa.
1735
1736         Making the list of test paths to import the main arguments of the script.
1737         Allow passing the source directory to import as a -s option.
1738         Adding a warning when given test paths are skipped by default in ImportExpectations.
1739
1740         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1741         Link conversion rules do not change when imported tests are downloaded by the script.
1742
1743         * Scripts/webkitpy/w3c/test_importer.py:
1744         (main):
1745         (parse_args):
1746         (TestImporter.__init__):
1747         (TestImporter.do_import):
1748         (TestImporter):
1749         (TestImporter.check_imported_expectations):
1750
1751 2017-02-08  Chris Dumez  <cdumez@apple.com>
1752
1753         Update web-platform-tests resources
1754         https://bugs.webkit.org/show_bug.cgi?id=168026
1755
1756         Reviewed by Youenn Fablet.
1757
1758         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1759
1760         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1761         (WebPlatformTestServer._copy_webkit_test_files):
1762
1763 2017-02-08  Andy Estes  <aestes@apple.com>
1764
1765         Custom protocols should not continue loading after a network process crash
1766         https://bugs.webkit.org/show_bug.cgi?id=168028
1767         <rdar://problem/27607520>
1768
1769         Reviewed by Brady Eidson.
1770
1771         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1772         (processGroup):
1773         (-[CloseWhileStartingProtocol startLoading]):
1774         (-[CloseWhileStartingProtocol stopLoading]):
1775         (TestWebKitAPI::runTest):
1776         (TestWebKitAPI::TEST):
1777
1778 2017-02-08  Dan Bernstein  <mitz@apple.com>
1779
1780         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1781         https://bugs.webkit.org/show_bug.cgi?id=168031
1782
1783         Reviewed by Tim Horton.
1784
1785         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1786         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1787         (TEST):
1788         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1789         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1790
1791 2017-02-08  Chris Dumez  <cdumez@apple.com>
1792
1793         Use smaller tiles in windows that are not active to facilitate App Napping
1794         https://bugs.webkit.org/show_bug.cgi?id=167997
1795         <rdar://problem/30358835>
1796
1797         Reviewed by Simon Fraser.
1798
1799         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1800         (WTR::PlatformWebView::setWindowIsKey):
1801         Actually update windowIsKey state of NSWindow so the WebView
1802         properly updates its activity state.
1803
1804 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1805
1806         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1807         https://bugs.webkit.org/show_bug.cgi?id=167942
1808         <rdar://problem/30315079>
1809
1810         Reviewed by Tim Horton.
1811
1812         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1813         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1814         contenteditable in these cases.
1815
1816         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1817         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1818         performDragOperation:) directly.
1819
1820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1821         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1822         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1823         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1824         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1825         (-[DragSource draggingSourceOperationMaskForLocal:]):
1826         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1827         (-[DragInfo lastMousePosition]):
1828         (-[DragInfo setLastMousePosition:]):
1829         (-[DragInfo draggingDestinationWindow]):
1830         (-[DragInfo draggingSourceOperationMask]):
1831         (-[DragInfo draggingLocation]):
1832         (-[DragInfo draggedImageLocation]):
1833         (-[DragInfo draggedImage]):
1834         (-[DragInfo draggingPasteboard]):
1835         (-[DragInfo draggingSource]):
1836         (-[DragInfo draggingSequenceNumber]):
1837         (-[DragInfo slideDraggedImageTo:]):
1838         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1839         (-[DragInfo draggingFormation]):
1840         (-[DragInfo setDraggingFormation:]):
1841         (-[DragInfo animatesToDestination]):
1842         (-[DragInfo setAnimatesToDestination:]):
1843         (-[DragInfo numberOfValidItemsForDrop]):
1844         (-[DragInfo setNumberOfValidItemsForDrop:]):
1845         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1846         (-[DragInfo springLoadingHighlight]):
1847         (-[DragInfo resetSpringLoading]):
1848         (TestWebKitAPI::getTestImage):
1849         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1850         (TestWebKitAPI::TEST):
1851         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1852
1853 2017-02-08  Jer Noble  <jer.noble@apple.com>
1854
1855         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1856         https://bugs.webkit.org/show_bug.cgi?id=168007
1857
1858         Reviewed by Alex Christensen.
1859
1860         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1861         (didFinishLoadForFrame):
1862         (TestWebKitAPI::TEST):
1863
1864 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1865
1866         Unreviewed, rolling out r211873.
1867         https://bugs.webkit.org/show_bug.cgi?id=168001
1868
1869         It's in jhbuild for consistent layout tests (Requested by
1870         mcatanzaro on #webkit).
1871
1872         Reverted changeset:
1873
1874         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1875         https://bugs.webkit.org/show_bug.cgi?id=167993
1876         http://trac.webkit.org/changeset/211873
1877
1878 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1879
1880         [GTK] Add icu packages to Tools/gtk/install-dependencies
1881         https://bugs.webkit.org/show_bug.cgi?id=167993
1882
1883         Reviewed by Michael Catanzaro.
1884
1885         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1886         depending in the GNU/Linux distribution)
1887
1888 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1889
1890         Update flakiness dashboard configuration.
1891         https://bugs.webkit.org/show_bug.cgi?id=167957
1892
1893         Reviewed by Alexey Proskuryakov.
1894
1895         * TestResultServer/static-dashboards/builders.jsonp:
1896
1897 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1898
1899         Replace a bot that has an incorrect configuration.
1900         https://bugs.webkit.org/show_bug.cgi?id=167747
1901
1902         Rubber-stamped by Alexey Proskuryakov.
1903
1904         * BuildSlaveSupport/build.webkit.org-config/config.json:
1905
1906 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1907
1908         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1909         https://bugs.webkit.org/show_bug.cgi?id=167927
1910
1911         Reviewed by Brent Fulgham.
1912
1913         Enable ComplexTextController API tests on the Win and GTK ports.
1914
1915         * TestWebKitAPI/PlatformGTK.cmake:
1916         * TestWebKitAPI/PlatformWin.cmake:
1917
1918 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1919
1920         File index appended to previous file in svn-create-patch with SVN 1.9
1921         https://bugs.webkit.org/show_bug.cgi?id=167903
1922         <rdar://problem/30387395>
1923
1924         Reviewed by Daniel Bates.
1925
1926         * Scripts/VCSUtils.pm:
1927         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1928         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1929         trailing newline character from the expected result before comparing it to the actual result.
1930
1931 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1932
1933         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1934         https://bugs.webkit.org/show_bug.cgi?id=167936
1935
1936         Reviewed by Michael Catanzaro.
1937
1938         * Scripts/webkitdirs.pm:
1939         (determineArchitecture):
1940         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1941         since r195083.
1942
1943 2017-02-07  Youenn Fablet  <youenn@apple.com>
1944
1945         Use a JSON file to define which WPT files/folders to import
1946         https://bugs.webkit.org/show_bug.cgi?id=167923
1947
1948         Reviewed by Alex Christensen.
1949
1950         * Scripts/webkitpy/w3c/test_downloader.py:
1951         (TestDownloader.__init__):
1952         (TestDownloader._init_paths_from_expectations):
1953         * Scripts/webkitpy/w3c/test_importer.py:
1954         (parse_args):
1955         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1956
1957 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1958
1959         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1960         https://bugs.webkit.org/show_bug.cgi?id=167916
1961
1962         Reviewed by Carlos Garcia Campos.
1963
1964         URL of mesa-11.0.6.tar.xz has been moved.
1965
1966         * gtk/jhbuild.modules: Fix the module path.
1967
1968 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1969
1970         Static Analyzer: Address some leaks in MiniBrowser
1971         https://bugs.webkit.org/show_bug.cgi?id=167897
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         * MiniBrowser/mac/BrowserWindowController.m:
1976         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1977         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1978         (-[ExtensionManagerWindowController add:]):
1979         (-[ExtensionManagerWindowController remove:]):
1980         * MiniBrowser/mac/SettingsController.m:
1981         (-[SettingsController _populateMenu]):
1982         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1983         Address obvious leaks caught by the static analyzer.
1984
1985 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1986
1987         Migrate ComplexTextController to use platform-independent types
1988         https://bugs.webkit.org/show_bug.cgi?id=167833
1989
1990         Reviewed by Brent Fulgham.
1991
1992         Migrate tests away from platform-dependent types.
1993
1994         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1995         (TestWebKitAPI::TEST_F):
1996
1997 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1998
1999         Correct File Path Handling in SecurityOrigin and FileSystem
2000         https://bugs.webkit.org/show_bug.cgi?id=167894
2001         <rdar://problem/30380080>
2002
2003         Reviewed by Alexey Proskuryakov.
2004
2005         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
2006         and perform same-volume checks using filesystem-compatible paths.        
2007         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
2008         filesystem paths, and perform validation of same-volume checks.
2009         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
2010         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
2011         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
2012         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
2013
2014 2017-02-06  Jer Noble  <jer.noble@apple.com>
2015
2016         Playback stalls when a SourceBuffer append causes frame eviction
2017         https://bugs.webkit.org/show_bug.cgi?id=167834
2018
2019         Reviewed by Eric Carlson.
2020
2021         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
2022         for the WTF::MediaTime class.
2023
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2025         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2026         (TestWebKitAPI::TEST):
2027         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
2028         (WTF::operator<<):
2029         (TestWebKitAPI::TestSample::create):
2030         (TestWebKitAPI::TestSample::TestSample):
2031         (TestWebKitAPI::TEST_F):
2032
2033 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
2034
2035         Change capitalization in platform name after r211735.
2036
2037         Unreviewed dashboard fix.
2038
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2040         (WebKitBuildbot):
2041
2042 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
2043
2044         Move the Leaks bot to Sierra
2045         https://bugs.webkit.org/show_bug.cgi?id=167886
2046
2047         Reviewed by Daniel Bates.
2048
2049         * BuildSlaveSupport/build.webkit.org-config/config.json:
2050         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2052         (LeaksViewer._displayURLPrompt):
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2054         (WebKitBuildbot):
2055
2056 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
2057
2058         Prevent app crash on launch during simctl install workaround
2059         https://bugs.webkit.org/show_bug.cgi?id=167685
2060
2061         Reviewed by Daniel Bates.
2062
2063         * Scripts/webkitpy/port/simulator_process.py:
2064         (SimulatorProcess.__init__): Pass environment to install.
2065         * Scripts/webkitpy/xcode/simulator.py:
2066         (Device.install_app): Accept environment, pass environment to launch.
2067
2068 2017-02-06  Alex Christensen  <achristensen@webkit.org>
2069
2070         Rebase API tests after r211638
2071         https://bugs.webkit.org/show_bug.cgi?id=167779
2072
2073         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2074         (TestWebKitAPI::TEST_F):
2075         URLs with non-special schemes and characters like % in the host now fail to parse,
2076         more like their special counterparts and according to spec.
2077
2078 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2079
2080         Unreviewed trivial fix after r211697.
2081         https://bugs.webkit.org/show_bug.cgi?id=167863
2082
2083         * Scripts/run-javascriptcore-tests:
2084         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
2085
2086 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
2087
2088         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
2089         https://bugs.webkit.org/show_bug.cgi?id=167850
2090
2091         Reviewed by Tim Horton.
2092
2093         * DumpRenderTree/TestRunner.cpp:
2094         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
2095
2096 2017-02-04  Andreas Kling  <akling@apple.com>
2097
2098         Plug some leaks in TestController and UIScriptContext.
2099         <https://webkit.org/b/167839>
2100
2101         Reviewed by Alexey Proskuryakov.
2102
2103         Fix a couple of the leaks seen on the leaks bot.
2104
2105         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2106         (UIScriptContext::runUIScript):
2107         * WebKitTestRunner/TestController.cpp:
2108         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
2109         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2110
2111 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
2112
2113         WK1 mouse events are missing movementX and movementY for pointerlock.
2114         https://bugs.webkit.org/show_bug.cgi?id=167775
2115         rdar://problem/30343810
2116
2117         Reviewed by Alexey Proskuryakov.
2118
2119         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
2120
2121         * DumpRenderTree/mac/EventSendingController.mm:
2122         (-[EventSendingController mouseMoveToX:Y:]):
2123         * WebKitTestRunner/mac/EventSenderProxy.mm:
2124         (WTR::EventSenderProxy::mouseMoveTo):
2125
2126 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
2127
2128         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
2129         https://bugs.webkit.org/show_bug.cgi?id=167774
2130
2131         Reviewed by Tim Horton.
2132
2133         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
2134         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
2135         web process are async, so the callback fires after the web process gets the new state.
2136
2137         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2138         (WTR::UIScriptController::removeViewFromWindow):
2139         (WTR::UIScriptController::addViewToWindow):
2140         * DumpRenderTree/mac/DumpRenderTree.mm:
2141         (createWebViewAndOffscreenWindow):
2142         (resetWebViewToConsistentStateBeforeTesting):
2143         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2144         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2145         (WTR::UIScriptController::removeViewFromWindow):
2146         (WTR::UIScriptController::addViewToWindow):
2147         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2148         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2149         (WTR::UIScriptController::removeViewFromWindow):
2150         (WTR::UIScriptController::addViewToWindow):
2151         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2152         * WebKitTestRunner/PlatformWebView.h:
2153         * WebKitTestRunner/TestController.cpp:
2154         (WTR::TestController::resetStateToConsistentValues):
2155         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2156         (WTR::PlatformWebView::removeFromWindow):
2157         (WTR::PlatformWebView::addToWindow):
2158         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2159         (WTR::UIScriptController::removeViewFromWindow):
2160         (WTR::UIScriptController::addViewToWindow):
2161         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2162         (WTR::PlatformWebView::removeFromWindow):
2163         (WTR::PlatformWebView::addToWindow):
2164         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2165         (WTR::UIScriptController::removeViewFromWindow):
2166         (WTR::UIScriptController::addViewToWindow):
2167
2168 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
2169
2170         Remove check for SkipSafariExecutableEntitlementChecks
2171         https://bugs.webkit.org/show_bug.cgi?id=167762
2172
2173         Reviewed by Dan Bernstein.
2174
2175         Follow-up fix: don't break internal behavior.
2176
2177         * Scripts/webkitdirs.pm:
2178         (safariPath):
2179         (executableHasEntitlements): Deleted.
2180         (safariPathFromSafariBundle): Deleted.
2181         (installedSafariPath): Deleted.
2182
2183 2017-02-03  Daniel Bates  <dabates@apple.com>
2184
2185         [Mac][WK2] Add SPI to override the Content Security Policy of a page
2186         https://bugs.webkit.org/show_bug.cgi?id=167810
2187         <rdar://problem/30102568>
2188
2189         Reviewed by Anders Carlsson.
2190
2191         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
2192
2193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2194         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
2195         (TEST):
2196         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
2197         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
2198         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
2199         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
2200
2201 2017-02-02  Alex Christensen  <achristensen@webkit.org>
2202
2203         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
2204         https://bugs.webkit.org/show_bug.cgi?id=167773
2205         <rdar://problem/30221102>
2206
2207         Reviewed by Ryosuke Niwa.
2208
2209         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2210         (TestWebKitAPI::TEST_F):
2211
2212 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
2213
2214         Remove check for SkipSafariExecutableEntitlementChecks
2215         https://bugs.webkit.org/show_bug.cgi?id=167762
2216         rdar://problem/22480673
2217
2218         Reviewed by Dan Bernstein.
2219
2220         * Scripts/webkitdirs.pm:
2221         (safariPathFromSafariBundle):
2222         (skipSafariExecutableEntitlementChecks): Deleted.
2223
2224 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
2225
2226         Undefined subroutine in svn-create-patch
2227         https://bugs.webkit.org/show_bug.cgi?id=167742
2228
2229         Unreviewed build-fix after r211543.
2230
2231         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
2232
2233 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2234
2235         Unreviewed. Fix jhbuild dependencies build.
2236
2237         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
2238         Patch updated.
2239
2240 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2241
2242         [EME][GStreamer] Fixed decryptor selection
2243         https://bugs.webkit.org/show_bug.cgi?id=167588
2244
2245         Reviewed by Žan Doberšek.
2246
2247         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
2248
2249         * gtk/jhbuild.modules: Added patches to gstreamer and
2250         gst-plugins-good packages.
2251         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2252         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2253
2254 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
2255
2256         Make run-benchmark script supports 'config' key in test plan.
2257         https://bugs.webkit.org/show_bug.cgi?id=167715
2258
2259         Reviewed by Ryosuke Niwa.
2260
2261         Add support for 'config' key in test paln.
2262         'config' key is a dictionary that specifies environment configurations while test is running.
2263         Specifies orientation to be portrait in MotionMark benchmark.
2264
2265         * Scripts/webkitpy/benchmark_runner/README.md:
2266         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2267         (BenchmarkRunner.__init__):
2268         (BenchmarkRunner._run_benchmark):
2269         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2270         (BrowserDriver.prepare_env):
2271         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2272         (LinuxBrowserDriver.prepare_env):
2273         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2274         (OSXBrowserDriver.prepare_env):
2275         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2276         (OSXSafariDriver.prepare_env):
2277         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2278
2279 2017-02-01  Daniel Bates  <dabates@apple.com>
2280
2281         REGRESSION (r210820): svn-create-patch does not emit property change only diff
2282         https://bugs.webkit.org/show_bug.cgi?id=167169
2283
2284         Reviewed by David Kilzer.
2285
2286         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
2287         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
2288         header from the output of "svn diff" on a file that was copied or moved.
2289
2290         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
2291         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
2292         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
2293         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
2294         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
2295         of a file with only a property change also does not contain any chunk range lines. Therefore
2296         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
2297         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
2298         we should directly test for the presence of a leading SVN diff header with an empty body and
2299         remove such lines from the diff.
2300
2301         * Scripts/VCSUtils.pm:
2302         (fixSVNPatchForAdditionWithHistory): Added.
2303         * Scripts/svn-create-patch:
2304         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
2305         we have a non empty patch for an added file with history (i.e. a copied or moved file).
2306         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
2307
2308 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
2309
2310         [Mac] Update CARingBuffer class
2311         https://bugs.webkit.org/show_bug.cgi?id=167656
2312
2313         Reviewed by Jer Noble.
2314
2315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2316         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
2317         (TestWebKitAPI::CARingBufferTest::SetUp):
2318         (TestWebKitAPI::CARingBufferTest::setup):
2319         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
2320         (TestWebKitAPI::CARingBufferTest::description):
2321         (TestWebKitAPI::CARingBufferTest::bufferList):
2322         (TestWebKitAPI::CARingBufferTest::ringBuffer):
2323         (TestWebKitAPI::CARingBufferTest::capacity):
2324         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
2325         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
2326         (TestWebKitAPI::TEST_F):
2327         (TestWebKitAPI::MixingTest::run):
2328
2329 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
2330
2331         [Mac] TestWebKitAPI includes system frameworks incorrectly
2332         https://bugs.webkit.org/show_bug.cgi?id=167703
2333         rdar://problem/30301498
2334
2335         Reviewed by Ryosuke Niwa.
2336
2337         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
2338         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
2339
2340         Also, reduced the number of subframework search paths, looks like we only need one now.
2341
2342         * TestWebKitAPI/Configurations/Base.xcconfig:
2343
2344 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
2345
2346         Correct "filesHaveSameVolume" predicate
2347         https://bugs.webkit.org/show_bug.cgi?id=167696
2348         <rdar://problem/30298722>
2349
2350         Reviewed by David Kilzer.
2351
2352         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
2353         percent-escaped path inputs.
2354
2355         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2356         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
2357         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
2358         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
2359         (TestWebKitAPI::TEST_F):
2360
2361 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2362
2363         Unreviewed. Fix coding style in MiniBrowser
2364
2365         * MiniBrowser/gtk/BrowserWindow.c:
2366         (editingCommandCallback):
2367         (insertImageCommandCallback):
2368         (insertLinkCommandCallback):
2369
2370 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2371
2372         [GTK] Add an API to add a custom tab into the print dialog
2373         https://bugs.webkit.org/show_bug.cgi?id=151998
2374
2375         Reviewed by Carlos Garcia Campos.
2376
2377         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
2378         that is testing a newly added API.
2379
2380         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2381         (testPrintCustomWidget):
2382         (beforeAll):
2383
2384 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
2385
2386         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
2387         https://bugs.webkit.org/show_bug.cgi?id=166529
2388
2389         Reviewed by Xabier Rodriguez-Calvar.
2390
2391         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
2392         New patch version accepted in GStreamer upstream.
2393
2394 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2395
2396         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
2397         https://bugs.webkit.org/show_bug.cgi?id=167498
2398
2399         Reviewed by Carlos Garcia Campos.
2400
2401         Depending on the distro version you can need either libxfont1-dev
2402         or libfont-dev to build with jhbuild.
2403
2404         * gtk/install-dependencies:
2405
2406 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2407
2408         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
2409         https://bugs.webkit.org/show_bug.cgi?id=167594
2410
2411         Unreviewed test gardening.
2412
2413         Disabling this test while we investigate the cause of a timeout on ios-simulator.
2414
2415         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2416         (TEST):
2417
2418 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
2419
2420         Move slow-running microbenchmarks out of JSTests/microbenchmarks
2421         https://bugs.webkit.org/show_bug.cgi?id=167676
2422
2423         Reviewed by Saam Barati.
2424
2425         * Scripts/run-javascriptcore-tests:
2426         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
2427
2428 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
2429
2430         Make Dump Render Tree not crash
2431         https://bugs.webkit.org/show_bug.cgi?id=167667
2432
2433         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
2434         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
2435         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
2436         This does not fix any tests, it just fixes the crash.
2437         
2438         Reviewed by Simon Fraser.
2439
2440         * DumpRenderTree/TestRunner.cpp:
2441         (TestRunner::callUIScriptCallback):
2442
2443 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2444
2445         Workaround for simctl install failing to report install failure
2446         https://bugs.webkit.org/show_bug.cgi?id=167654
2447
2448         Reviewed by Daniel Bates.
2449
2450         simctl install will sometimes report success even though install has failed.
2451         To workaround this bug, we attempt an app launch after install to ensure
2452         install has succeeded.
2453
2454         * Scripts/webkitpy/xcode/simulator.py:
2455         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2456         (Device.launch_app): Correct comment.
2457
2458 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2459
2460         Unreviewed webkitpy fix after r211405.
2461
2462         * Scripts/webkitpy/xcode/simulator.py:
2463         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2464
2465 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2466
2467         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2468
2469         * gtk/manifest.txt.in:
2470
2471 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2472
2473         AX: enable search predication for iOS
2474         https://bugs.webkit.org/show_bug.cgi?id=167558
2475         <rdar://problem/30251367>
2476
2477         Reviewed by Joanmarie Diggs.
2478
2479         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2480         (AccessibilityUIElement::uiElementForSearchPredicate):
2481         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2482         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2483         (searchPredicateParameterizedAttributeForSearchCriteria):
2484         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2485         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2486         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2487         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2488         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2489         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2490         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2491         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2492         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2493         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2494         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2495
2496 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2497
2498         Workaround for simctl launch bug
2499         https://bugs.webkit.org/show_bug.cgi?id=167613
2500
2501         Reviewed by Daniel Bates.
2502
2503         simctl launch will sometimes fail because of a race condition when many
2504         simulators are being run simultaneously. These failures will always have
2505         an exit code of 1. This change attempts to launch an app multiple times
2506         before reporting a failure to workaround this bug.
2507
2508         * Scripts/webkitpy/xcode/simulator.py:
2509         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2510
2511 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2512
2513         Commit queue fails to look at real name aliases for the reviewer
2514         https://bugs.webkit.org/show_bug.cgi?id=167422
2515
2516         Reviewed by Joseph Pecoraro.
2517
2518         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2519         (test_has_valid_reviewer): Added tests.
2520
2521         * Scripts/webkitpy/common/config/committers.py:
2522         (CommitterList._name_to_contributor_map):
2523         Made _name_to_contributor_map include alias names.
2524
2525         * Scripts/webkitpy/common/config/committers_unittest.py:
2526         (CommittersTest.test_contributors_by_fuzzy_match):
2527         Removed subtests that are now obsolete, as these matches are strict. It is not
2528         obvious if distance based fuzzy matching for names is useful at all, but we can
2529         look into that some other time.
2530
2531 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2532
2533         QueueStatusServer should have an explicit timeout for _fetch_url
2534         https://bugs.webkit.org/show_bug.cgi?id=167467
2535
2536         Reviewed by Alexey Proskuryakov.
2537
2538         * Scripts/webkitpy/common/net/statusserver.py:
2539         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2540
2541 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2542
2543         Add support for Trac instances that host multiple projects.
2544         https://bugs.webkit.org/show_bug.cgi?id=167524
2545
2546         Reviewed by Alexey Proskuryakov.
2547
2548         When multiple projects are hosted on a single Trac instance, the current
2549         behavior will retrieve changesets from all tracked projects.
2550         This patch teaches Trac.js to get project-specific changesets from Trac.
2551         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2552         when querying the Trac timeline.
2553
2554         To tell Trac to be aware of multi-project instances we leverage the 
2555         `options` parameter when creating a new instance: 
2556
2557             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2558
2559         If this option is not provided, the original behaviour will prevail.
2560         Additionally, add corresponding tests.
2561
2562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2563         (Trac): Reason about new optional parameter 'projectIdentifier'.
2564         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2565         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2566         replace default parameter `changeset=on` with `repo-projectname=on`.
2567         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2569         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2571         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2572         Add the following tests:
2573             test("revisionURL")
2574             test("revisionURL with Trac Identifier")
2575             test("_xmlTimelineURL")
2576             test("_xmlTimelineURL with Trac Identifier")
2577         (this.view._latestProductiveIteration): Fix missing ';'.
2578
2579 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2580
2581         Correct spacing regression on inter-element complex path shaping on some fonts
2582         https://bugs.webkit.org/show_bug.cgi?id=166013
2583
2584         Reviewed by Simon Fraser.
2585
2586         Unskip existing tests and make some new tests:
2587         - Testing complex text with no origins
2588         - Testing initial expansions
2589         - Testing the sign of vertical advances
2590
2591         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2592         (TestWebKitAPI::TEST_F):
2593
2594 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2595
2596         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2597         https://bugs.webkit.org/show_bug.cgi?id=167596
2598
2599         Reviewed by Daniel Bates.
2600
2601         We avoid needing a thin directory by invoking the zip program with
2602         the list of directories from the build directory to be zipped,
2603         and by using the zip feature to exclude files matching a pattern.
2604
2605         * BuildSlaveSupport/built-product-archive:
2606         (copyBuildFiles):
2607         (createZipFromList):
2608         (archiveBuiltProduct):
2609
2610 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2611
2612         Use simctl instead of LayoutTestRelay
2613         https://bugs.webkit.org/show_bug.cgi?id=165927
2614
2615         Reviewed by Daniel Bates.
2616
2617         Part 1
2618
2619         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2620         simulators through simctl (iOS 10 and later), use this functionality instead.
2621
2622         * Scripts/webkitpy/port/base.py:
2623         (Port.__init__): Added _test_runner_process_constructor.
2624         * Scripts/webkitpy/port/darwin.py:
2625         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2626         * Scripts/webkitpy/port/driver.py:
2627         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2628         (IOSSimulatorDriver): Deleted.
2629         * Scripts/webkitpy/port/driver_unittest.py:
2630         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2631         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2632         (DriverTest.test_start_actually_starts): Ditto.
2633         * Scripts/webkitpy/port/ios.py:
2634         (IOSSimulatorPort): Remove relay_name.
2635         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2636         (IOSSimulatorPort._create_simulators): Formatting change.
2637         (IOSSimulatorPort.relay_path): Deleted.
2638         (IOSSimulatorPort._check_relay): Deleted.
2639         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2640         (IOSSimulatorPort._build_relay): Deleted.
2641         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2642         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2643         * Scripts/webkitpy/port/ios_unittest.py:
2644         (iosTest.test_32bit): Update test.
2645         (iosTest.test_64bit): Update test.
2646         * Scripts/webkitpy/port/server_process.py:
2647         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2648         (ServerProcess._set_file_nonblocking): Added to share common code.
2649         * Scripts/webkitpy/port/server_process_mock.py:
2650         (MockServerProcess.__init__): Added argument worker_number.
2651         * Scripts/webkitpy/port/simulator_process.py: Added.
2652         (SimulatorProcess): Added.
2653         (SimulatorProcess.Popen): Added.
2654         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2655         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2656         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2657         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2658         (SimulatorProcess._reset): Added. Unlink fifos.
2659         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2660         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2661         * Scripts/webkitpy/xcode/simulator.py:
2662         (Device.__init__): Accept host to run install/launch/terminate.
2663         (Device.install_app): Install app to target Device.
2664         (Device.launch_app): Launch app on target Device.
2665         (Device.terminate_app): Shutdown app on target Device.
2666         (Simulator._parse_devices): Pass host to Device.
2667
2668 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2669
2670         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2671         https://bugs.webkit.org/show_bug.cgi?id=167411
2672
2673         Reviewed by Michael Catanzaro.
2674
2675         Disable the ARM iwMMXt fast path for pixman, because it triggers
2676         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2677
2678         * gtk/jhbuild.modules:
2679
2680 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2681
2682         [GTK] Add API to handle the accelerated compositing policy
2683         https://bugs.webkit.org/show_bug.cgi?id=167509
2684
2685         Reviewed by Michael Catanzaro.
2686
2687         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2688         as a special case. Also add test cases to the get/set API.
2689
2690         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2691         (hardwareAccelerationPolicyToString):
2692         (stringToHardwareAccelerationPolicy):
2693         (cellRendererChanged):
2694         (browserSettingsDialogConstructed):
2695         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2696         (testWebKitSettings):
2697
2698 2017-01-29  Andy Estes  <aestes@apple.com>
2699
2700         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2701         https://bugs.webkit.org/show_bug.cgi?id=167563
2702         <rdar://problem/30253207>
2703
2704         Reviewed by Andreas Kling.
2705
2706         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2707         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2708         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2709         (runTest):
2710         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2711         (TEST):
2712
2713 2017-01-29  Dan Bernstein  <mitz@apple.com>
2714
2715         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2716         https://bugs.webkit.org/show_bug.cgi?id=167565
2717
2718         Reviewed by Sam Weinig.
2719
2720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2721         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2722         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2723         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2724         (TEST):
2725         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2726         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2727         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2728         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2729
2730 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2731
2732         Add Link Preload as an off-by-default experimental feature menu item.
2733         https://bugs.webkit.org/show_bug.cgi?id=167201
2734
2735         Reviewed by Ryosuke Niwa.
2736
2737         * DumpRenderTree/mac/DumpRenderTree.mm:
2738         (resetWebPreferencesToConsistentValues):
2739         * DumpRenderTree/win/DumpRenderTree.cpp:
2740         (resetWebPreferencesToConsistentValues):
2741
2742 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2743
2744         Add User Timing Experimental Feature
2745         https://bugs.webkit.org/show_bug.cgi?id=167542
2746         <rdar://problem/22746307>
2747
2748         Reviewed by Ryosuke Niwa.
2749
2750         * DumpRenderTree/mac/DumpRenderTree.mm:
2751         (enableExperimentalFeatures):
2752         (resetWebPreferencesToConsistentValues):
2753         * DumpRenderTree/win/DumpRenderTree.cpp:
2754         (enableExperimentalFeatures):
2755
2756 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2757
2758         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2759         https://bugs.webkit.org/show_bug.cgi?id=167519
2760
2761         Reviewed by Ryosuke Niwa.
2762
2763         * QueueStatusServer/templates/statusbubble.html:
2764         To measure the bubbleContainer's width, it must not be wrapping based
2765         on its parent container. So when measuring the width temporarily set
2766         the parent to a very large width so as to not artificially wrap us.
2767         Restore the parent's width after measuring.
2768
2769 2017-01-27  Andy Estes  <aestes@apple.com>
2770
2771         [iOS] Add a test for _WKNSFileManagerExtras
2772         https://bugs.webkit.org/show_bug.cgi?id=167478
2773
2774         Reviewed by Andreas Kling.
2775
2776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2777         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2778         (expectAttributes):
2779         (TEST):
2780
2781 2017-01-27  Keith Miller  <keith_miller@apple.com>
2782
2783         run-benchmarks should make sure it passes the test url to the right application
2784         https://bugs.webkit.org/show_bug.cgi?id=167533
2785
2786         Reviewed by Joseph Pecoraro.
2787
2788         This fixes an issue when trying to run-benchmark script with the
2789         system default browser set to STP. Previously, it would run
2790         the test in STP rather than the provided build. Now, it should run
2791         in the provided build.
2792
2793         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2794         (OSXSafariDriver.launch_url):
2795
2796 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2797
2798         [Cocoa] Prepare ComplexTextController for unit testing
2799         https://bugs.webkit.org/show_bug.cgi?id=167493
2800
2801         Reviewed by Simon Fraser.
2802
2803         Addressing post-review comments from Simon Fraser.
2804
2805         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2806         (TestWebKitAPI::TEST_F):
2807
2808 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2809
2810         [Cocoa] Prepare ComplexTextController for unit testing
2811         https://bugs.webkit.org/show_bug.cgi?id=167493
2812
2813         Reviewed by Dean Jackson.
2814
2815         Create four unit tests.
2816
2817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2818         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2819         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2820         (TestWebKitAPI::TEST_F):
2821
2822 2017-01-26  Chris Dumez  <cdumez@apple.com>
2823
2824         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2825         https://bugs.webkit.org/show_bug.cgi?id=167421
2826         <rdar://problem/30188490>
2827
2828         Reviewed by Darin Adler.
2829
2830         Add a new setting allowing layout tests to enable PageCache in a window
2831         that has an opener, for convenience.
2832
2833         * DumpRenderTree/mac/DumpRenderTree.mm:
2834         (resetWebPreferencesToConsistentValues):
2835         * DumpRenderTree/win/DumpRenderTree.cpp:
2836         (resetWebPreferencesToConsistentValues):
2837         * WebKitTestRunner/TestController.cpp:
2838         (WTR::TestController::resetPreferencesToConsistentValues):
2839
2840 2017-01-26  Keith Miller  <keith_miller@apple.com>
2841
2842         classInfo should take a VM so it is not materialized from the object on each call
2843         https://bugs.webkit.org/show_bug.cgi?id=167424
2844
2845         Rubber Stamped by Michael Saboff.
2846
2847         Previously, classInfo() would get the VM from the target's
2848         MarkedBlock.  Most callers already have a VM on hand, so it is
2849         wasteful to compute the VM from the marked block every time. This
2850         patch refactors some of the most common callers of classInfo(),
2851         jsDynamicCast and inherits to take a VM as well.
2852
2853         * DumpRenderTree/TestRunner.cpp:
2854         (setAudioResultCallback):
2855
2856 2017-01-26  Jer Noble  <jer.noble@apple.com>
2857
2858         Autoplay muted videos stop playback of any streaming app in the background
2859         https://bugs.webkit.org/show_bug.cgi?id=163993
2860         <rdar://problem/29020431>
2861
2862         Reviewed by Eric Carlson.
2863
2864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2865         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2866         (TestWebKitAPI::TEST):
2867         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2868
2869 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2870
2871         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2872         https://bugs.webkit.org/show_bug.cgi?id=167466
2873
2874         Unreviewed test gardening.
2875
2876         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2877         (TEST):
2878
2879 2017-01-26  Matt Rajca  <mrajca@apple.com>
2880
2881         Notify clients when the user plays media otherwise prevented from autoplaying
2882         https://bugs.webkit.org/show_bug.cgi?id=167390
2883
2884         Reviewed by Alex Christensen.
2885
2886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2887         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2888         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2889         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2890         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2891         (TEST):
2892         * TestWebKitAPI/cocoa/TestWKWebView.h:
2893         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2894         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2895         (-[TestWKWebView waitForLoad]):
2896         (-[TestWKWebView mouseUpAtPoint:]):
2897         * WebKitTestRunner/TestController.cpp:
2898         (WTR::TestController::createOtherPage):
2899         (WTR::TestController::createWebViewWithOptions):
2900
2901 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2902
2903         Crash when setting custom scale factor.
2904         https://bugs.webkit.org/show_bug.cgi?id=167369
2905
2906         Reviewed by Sam Weinig.
2907
2908         Added API test.
2909
2910         * TestWebKitAPI/PlatformWin.cmake:
2911         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2912         (TestWebKitAPI::WebKitCreateInstance):
2913         (TestWebKitAPI::ScaleWebView::SetUp):
2914         (TestWebKitAPI::ScaleWebView::TearDown):
2915         (TestWebKitAPI::TEST_F):
2916
2917 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2918
2919         run-benchmark nests MotionMark results by the suite name twice
2920         https://bugs.webkit.org/show_bug.cgi?id=164948
2921
2922         Reviewed by Said Abou-Hallawa.
2923
2924         Use a single level MotionMark now that this is the name of the benchmark,
2925         and we no longer have tests that aren't part of the MotionMark suite.
2926
2927         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2928
2929 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2930
2931         Unreviewed, rolling out r211193.
2932
2933         This change broke internal builds.
2934
2935         Reverted changeset:
2936
2937         "Notify clients when the user plays media otherwise prevented
2938         from autoplaying"
2939         https://bugs.webkit.org/show_bug.cgi?id=167390
2940         http://trac.webkit.org/changeset/211193
2941
2942 2017-01-25  Matt Rajca  <mrajca@apple.com>
2943
2944         Notify clients when the user plays media otherwise prevented from autoplaying
2945         https://bugs.webkit.org/show_bug.cgi?id=167390
2946
2947         Reviewed by Alex Christensen.
2948
2949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2950         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2951         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2952         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2953         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2954         (TEST):
2955         * TestWebKitAPI/cocoa/TestWKWebView.h:
2956         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2957         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2958         (-[TestWKWebView waitForLoad]):
2959         (-[TestWKWebView mouseUpAtPoint:]):
2960         * WebKitTestRunner/TestController.cpp:
2961         (WTR::TestController::createOtherPage):
2962         (WTR::TestController::createWebViewWithOptions):
2963
2964 2017-01-25  Matt Rajca  <mrajca@apple.com>
2965
2966         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2967         https://bugs.webkit.org/show_bug.cgi?id=167385
2968
2969         Reviewed by Alex Christensen.
2970
2971         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2972         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2973         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2974         (TEST): Allow inline (rather than full screen) media playback on iOS.
2975
2976 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2977
2978         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2979         https://bugs.webkit.org/show_bug.cgi?id=167414
2980
2981         Reviewed by Michael Catanzaro.
2982
2983         Add a test case to check ephemeral web views don't write favicons to the database.
2984
2985         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2986         (ephemeralViewLoadChanged):
2987         (testPrivateBrowsing):
2988         (testFaviconDatabase):
2989
2990 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2991
2992         [GTK] Add a private browsing mode to MiniBrowser
2993         https://bugs.webkit.org/show_bug.cgi?id=167413
2994
2995         Reviewed by Michael Catanzaro.
2996
2997         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2998         private windows, even on non-private instances.
2999
3000         * MiniBrowser/gtk/BrowserWindow.c:
3001         (webViewTitleChanged): Add [Private] to title window for private windows.
3002         (webViewCreate): Pass web context to browser_window_new.
3003         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
3004         (browserWindowFinalize): Disconnect web context signal handlers.
3005         (browser_window_init): Add shortcut for opening private window.
3006         (browser_window_new): It now receives the context and connect to download-started here.
3007         (browser_window_get_web_context): Return the context.
3008         * MiniBrowser/gtk/BrowserWindow.h:
3009         * MiniBrowser/gtk/main.c:
3010         (createBrowserTab): Create the web view for the window web context.
3011         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
3012         (aboutDataHandleRequest): Ditto.
3013         (aboutURISchemeRequestCallback): Ditto.
3014         (main): Create ephemeral web context if private command line option is used.
3015
3016 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3017
3018         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
3019         https://bugs.webkit.org/show_bug.cgi?id=167409
3020
3021         Reviewed by Antti Koivisto.
3022
3023         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
3024         as well as tests for the newly added matchingElementInFlatTree.
3025
3026         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
3027         (TestWebKitAPI::runJavaScriptAlert):
3028         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
3029         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
3030         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
3031
3032 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3033
3034         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
3035         https://bugs.webkit.org/show_bug.cgi?id=167370
3036
3037         Reviewed by Michael Catanzaro.
3038
3039         Add several test cases of ephemeral web views.
3040
3041         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3042         (testWebViewAuthenticationStorage):
3043         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
3044         (ephemeralViewloadChanged):
3045         (testCookieManagerEphemeral):
3046         (beforeAll):
3047         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3048         (testWebKitSettings):
3049         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3050         (testWebContextEphemeral):
3051         (ephemeralViewloadChanged):
3052         (testWebContextProxySettings):
3053         (beforeAll):
3054         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3055         (ephemeralViewloadChanged):
3056         (testWebViewEphemeral):
3057         (beforeAll):
3058         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
3059         (ephemeralViewloadChanged):
3060         (testWebsiteDataEphemeral):
3061         (beforeAll):
3062
3063 2017-01-24  Alex Christensen  <achristensen@webkit.org>
3064
3065         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
3066         https://bugs.webkit.org/show_bug.cgi?id=167402
3067
3068         Reviewed by Ryosuke Niwa.
3069
3070         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3071         (TestWebKitAPI::TEST):
3072
3073 2017-01-24  Zalan Bujtas  <zalan@apple.com>
3074
3075         Add simple line layout toggle to MiniBrowser
3076         https://bugs.webkit.org/show_bug.cgi?id=167405
3077
3078         Reviewed by Andreas Kling.
3079
3080         * MiniBrowser/mac/SettingsController.h:
3081         * MiniBrowser/mac/SettingsController.m:
3082         (-[SettingsController _populateMenu]):
3083         (-[SettingsController validateMenuItem:]):
3084         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
3085         (-[SettingsController simpleLineLayoutEnabled]):
3086         * MiniBrowser/mac/WK1BrowserWindowController.m:
3087         (-[WK1BrowserWindowController didChangeSettings]):
3088         * MiniBrowser/mac/WK2BrowserWindowController.m:
3089         (-[WK2BrowserWindowController didChangeSettings]):
3090
3091 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
3092
3093         WKR does not include my nick when commit-queue lands my patch
3094         https://bugs.webkit.org/show_bug.cgi?id=167388
3095
3096         Reviewed by Ryosuke Niwa.
3097
3098         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3099         (NewCommitBot._summarize_commit_log):
3100         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3101         Perform nickname insertion before grabbing "Patch by" details.
3102         This way we can include the nickname with the full name.
3103
3104 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
3105
3106         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
3107         https://bugs.webkit.org/show_bug.cgi?id=167394
3108
3109         Reviewed by Ryosuke Niwa.
3110
3111         * Scripts/webkitperl/FeatureList.pm:
3112         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3113
3114 2017-01-24  Youenn Fablet  <youenn@apple.com>
3115
3116         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
3117         https://bugs.webkit.org/show_bug.cgi?id=167353
3118
3119         Reviewed by Alex Christensen.
3120
3121         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3122         (CMakeGenerator.initialize_targets):
3123
3124 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3125
3126         WKR should not confuse Miguel Gomez with Andres Gomez
3127         https://bugs.webkit.org/show_bug.cgi?id=167389
3128
3129         Reviewed by Lucas Forschler.
3130
3131         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
3132         "mAndres Gomez". Fix this.
3133
3134         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3135         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
3136         space on each side of the email address, so expect both spaces to be there before
3137         considering the email for replacement.
3138         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
3139
3140 2017-01-24  Matt Rajca  <mrajca@apple.com>
3141
3142         Pass down website autoplay policies to media elements
3143         https://bugs.webkit.org/show_bug.cgi?id=167355
3144
3145         Reviewed by Alex Christensen.
3146
3147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3148         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
3149         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
3150         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
3151         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3152         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3153         (TEST):
3154
3155 2017-01-24  Nan Wang  <n_wang@apple.com>
3156
3157         AX: Speak Selection does not work in an iframe
3158         https://bugs.webkit.org/show_bug.cgi?id=166794
3159         <rdar://problem/29913013>
3160
3161         Reviewed by Chris Fleizach.
3162
3163         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3164         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3165         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3166         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3167         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3168         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3169         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3170         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3171         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3172         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3173         (-[TestRunnerWKWebView dealloc]):
3174         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
3175         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
3176         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3177         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3178         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3179
3180 2017-01-24  Daniel Bates  <dabates@apple.com>
3181
3182         StringView.split() should use an iterator design pattern instead of allocating a Vector
3183         https://bugs.webkit.org/show_bug.cgi?id=163225
3184
3185         Reviewed by Darin Adler.
3186
3187         Add unit tests for StringView.split().
3188
3189         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3190         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
3191         used in the StringView.split() unit tests.
3192         (TestWebKitAPI::stringViewFromUTF8): Ditto.
3193         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
3194         object to a Vector of String objects.
3195         (TestWebKitAPI::TEST): Added the following tests:
3196             - WTF.StringViewSplitEmptyAndNullStrings
3197             - WTF.StringViewSplitBasic
3198             - WTF.StringViewSplitWithConsecutiveSeparators
3199
3200 2017-01-23  Anders Carlsson  <andersca@apple.com>
3201
3202         The Score Esports crashes on launch
3203         https://bugs.webkit.org/show_bug.cgi?id=167338
3204         rdar://problem/29948645
3205
3206         Reviewed by Dan Bernstein.
3207
3208         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3209         (TestWebKitAPI::TEST):
3210         Add a test.
3211
3212 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3213
3214         [GTK] Add API to WebKitWebsiteDataManager to handle website data
3215         https://bugs.webkit.org/show_bug.cgi?id=146589
3216
3217         Reviewed by Michael Catanzaro.
3218
3219         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
3220         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
3221
3222         * MiniBrowser/gtk/BrowserWindow.c:
3223         (webViewDecidePolicy):
3224         (newTabCallback):
3225         * MiniBrowser/gtk/main.c:
3226         (createBrowserTab):
3227         (aboutDataRequestFree):
3228         (aboutDataRequestNew):
3229         (aboutDataRequestForView):
3230         (websiteDataRemovedCallback):
3231         (websiteDataClearedCallback):
3232         (aboutDataScriptMessageReceivedCallback):
3233         (domainListFree):
3234         (aboutDataFillTable):
3235         (gotWebsiteDataCallback):
3236         (aboutDataHandleRequest):
3237         (aboutURISchemeRequestCallback):
3238         (main):
3239         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3240         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3241         (serverCallback):
3242         (beforeAll):
3243         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
3244         (serverCallback):
3245         (WebsiteDataTest::WebsiteDataTest):
3246         (WebsiteDataTest::~WebsiteDataTest):
3247         (WebsiteDataTest::fetch):
3248         (WebsiteDataTest::remove):
3249         (WebsiteDataTest::clear):
3250         (testWebsiteDataConfiguration):
3251         (testWebsiteDataCache):
3252         (testWebsiteDataStorage):
3253         (testWebsiteDataDatabases):
3254         (testWebsiteDataAppcache):
3255         (beforeAll):
3256         (afterAll):
3257
3258 2017-01-23  Commit Queue  <commit-queue@webkit.org>
3259
3260         Unreviewed, rolling out r211062.
3261         https://bugs.webkit.org/show_bug.cgi?id=167354
3262
3263         broke API tests (Requested by alexchristensen on #webkit).
3264
3265         Reverted changeset:
3266
3267         "Pass down website autoplay policies to media elements"
3268         https://bugs.webkit.org/show_bug.cgi?id=167132
3269         http://trac.webkit.org/changeset/211062
3270
3271 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3272
3273         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
3274         https://bugs.webkit.org/show_bug.cgi?id=167330
3275
3276         Reviewed by Tim Horton.
3277
3278         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3279         (TestWebKitAPI::TEST_F):
3280
3281 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3282
3283         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
3284         https://bugs.webkit.org/show_bug.cgi?id=167317
3285
3286         Reviewed by Sam Weinig.
3287
3288         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3289         (TestWebKitAPI::TEST_F):
3290
3291 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
3292
3293         svn-create-patch should emit properties when files are moved or copied
3294         https://bugs.webkit.org/show_bug.cgi?id=167264
3295
3296         Reviewed by Daniel Bates.
3297
3298         * Scripts/svn-create-patch:
3299         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
3300
3301 2017-01-23  Youenn Fablet  <youenn@apple.com>
3302
3303         [WebRTC] Filter libwebrtc link flags
3304         https://bugs.webkit.org/show_bug.cgi?id=167287
3305
3306         Reviewed by Alex Christensen.
3307
3308         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3309         (CMakeGenerator._compute_link_flags):
3310         (CMakeGenerator._compute_link_flags.keep_flag):
3311         (CMakeGenerator._generate_compile_target_options):
3312
3313 2017-01-23  Youenn Fablet  <youennf@gmail.com>
3314
3315         [WebRTC] Make VP8 optional in libwebrtc
3316         https://bugs.webkit.org/show_bug.cgi?id=167257
3317
3318         Reviewed by Darin Adler.
3319
3320         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3321         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
3322
3323 2017-01-23  Jer Noble  <jer.noble@apple.com>
3324
3325         Video details does not apear and missing scrubber in Control Center
3326         https://bugs.webkit.org/show_bug.cgi?id=167233
3327
3328         Reviewed by Alex Christensen.
3329
3330         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
3331         NowPlayingControlTests for iOS.
3332
3333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3334         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3335         (-[NowPlayingTestWebView setWindowVisible:]):
3336         (TestWebKitAPI::TEST):
3337         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
3338         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3339         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3340         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
3341         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
3342         (SOFT_LINK_CLASS):
3343         (-[TestMessageHandler addMessage:withHandler:]):
3344         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3345         (__simulated_forceClickAssociatedEventsMask):
3346         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3347         (-[TestWKWebViewHostWindow isKeyWindow]):
3348         (-[TestWKWebViewHostWindow makeKeyWindow]):
3349         (-[TestWKWebViewHostWindow resignKeyWindow]):
3350         (-[TestWKWebView initWithFrame:]):
3351         (-[TestWKWebView initWithFrame:configuration:]):
3352         (-[TestWKWebView _setUpTestWindow:]):
3353         (-[TestWKWebView performAfterReceivingMessage:action:]):
3354         (-[TestWKWebView loadTestPageNamed:]):
3355         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
3356         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3357         (-[TestWKWebView waitForMessage:]):
3358         (-[TestWKWebView performAfterLoading:]):
3359         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3360         (-[TestWKWebView typeCharacter:]):
3361
3362 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3363
3364         Unreviewed. Bring back gtk-doc error messages after r209981.
3365
3366         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
3367         impossible to know what's wrong.
3368
3369         * gtk/gtkdoc.py:
3370         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
3371
3372 2017-01-20  Youenn Fablet  <youennf@gmail.com>
3373
3374         [WebRTC] Update build system to make G711 optional in libwebrtc
3375         https://bugs.webkit.org/show_bug.cgi?id=167256
3376
3377         Reviewed by Alex Christensen.
3378
3379         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3380         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
3381
3382 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3383
3384         Cleanup RuntimeEnabledFeatures
3385         https://bugs.webkit.org/show_bug.cgi?id=167228
3386
3387         Reviewed by Simon Fraser.
3388
3389         * DumpRenderTree/mac/DumpRenderTree.mm:
3390         (enableExperimentalFeatures):
3391         (resetWebPreferencesToConsistentValues):
3392         (setWebPreferencesForTestOptions):
3393         (resetWebViewToConsistentStateBeforeTesting):
3394         * DumpRenderTree/win/DumpRenderTree.cpp:
3395         (enableExperimentalFeatures):
3396         (resetWebPreferencesToConsistentValues):
3397         More closely match WebKitTestRunner initialization of preferences
3398         for experimental features.
3399
3400 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3401
3402         Build Fix for Windows DumpRenderTree after r210976
3403         https://bugs.webkit.org/show_bug.cgi?id=167115
3404
3405         * DumpRenderTree/win/DumpRenderTree.cpp:
3406         (resetWebPreferencesToConsistentValues):
3407
3408 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3409
3410         Remove outdated ENABLE(CSP_NEXT) build flag
3411         https://bugs.webkit.org/show_bug.cgi?id=167252
3412
3413         Reviewed by Brent Fulgham.
3414
3415         * Scripts/webkitperl/FeatureList.pm:
3416         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3417
3418 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3419
3420         Build Fix for Windows DumpRenderTree after r210976
3421
3422         * DumpRenderTree/win/DumpRenderTree.cpp:
3423         (resetWebPreferencesToConsistentValues):
3424
3425 2017-01-20  Antoine Quint  <graouts@apple.com>
3426
3427         Web Animations should be off by default and enabled as an experimental feature
3428         https://bugs.webkit.org/show_bug.cgi?id=167115
3429         <rdar://problem/30048963>
3430
3431         Reviewed by Joseph Pecoraro.
3432
3433         Turn Web Animations on in DRT.
3434
3435         * DumpRenderTree/mac/DumpRenderTree.mm:
3436         (resetWebPreferencesToConsistentValues):
3437         * DumpRenderTree/win/DumpRenderTree.cpp:
3438         (resetWebPreferencesToConsistentValues):
3439
3440 2017-01-20  Youenn Fablet  <youenn@apple.com>
3441
3442         [WebRTC] Add libwebrtc build infrastructure
3443         https://bugs.webkit.org/show_bug.cgi?id=167207
3444
3445         Reviewed by Alex Christensen.
3446
3447         Adding a script doing the libwebrtc project json to CMake file conversion.
3448
3449         * Scripts/generate-libwebrtc-cmake: Added.
3450         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3451         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3452
3453 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3454
3455         Mini Browser: Show tooltip for Experimental Features
3456         https://bugs.webkit.org/show_bug.cgi?id=167225
3457
3458         Reviewed by Alex Christensen.
3459
3460         * MiniBrowser/mac/SettingsController.m:
3461         (-[SettingsController _populateMenu]):
3462         Include the full details string as a tooltip.
3463
3464 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3465
3466         [Win] Test output results should not be written twice.
3467         https://bugs.webkit.org/show_bug.cgi?id=167197
3468
3469         Reviewed by Brent Fulgham.
3470
3471         Prevent test output from being written twice by returning early from
3472         the dump() function, if it already has been called.
3473         This patch also adds a missing newline to a test output line. 
3474         
3475         * DumpRenderTree/win/DumpRenderTree.cpp:
3476         (dump):
3477
3478 2017-01-20  Antoine Quint  <graouts@apple.com>
3479
3480         [Modern Media Controls] Turn modern media controls on by default
3481         https://bugs.webkit.org/show_bug.cgi?id=165668
3482
3483         Reviewed by Dean Jackson.
3484
3485         Enabled modern media controls by default in test runners.
3486
3487         * DumpRenderTree/TestOptions.h:
3488         * WebKitTestRunner/TestOptions.h:
3489
3490 2017-01-19  Chris Dumez  <cdumez@apple.com>
3491
3492         iterable<> should be enabled on WK1
3493         https://bugs.webkit.org/show_bug.cgi?id=167221
3494         <rdar://problem/30108531>
3495
3496         Reviewed by Youenn Fablet.
3497
3498         * DumpRenderTree/mac/DumpRenderTree.mm:
3499         (resetWebPreferencesToConsistentValues):
3500         * DumpRenderTree/win/DumpRenderTree.cpp:
3501         (resetWebPreferencesToConsistentValues):
3502         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3503         (WTR::InjectedBundle::beginTesting):
3504         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3505         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3506         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3507
3508 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3509
3510         Ensure status server logs go to log file
3511         https://bugs.webkit.org/show_bug.cgi?id=167210
3512
3513         Reviewed by Alexey Proskuryakov.
3514
3515         * Scripts/webkitpy/common/net/statusserver.py:
3516         (StatusServer.next_work_item): Change log level from debug to info in
3517         order to facilitate deubgging issues.
3518         (StatusServer.update_work_items): Same.
3519
3520 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3521
3522         Additional selection tests and interpolation fix
3523         https://bugs.webkit.org/show_bug.cgi?id=167171
3524
3525         Reviewed by Simon Fraser.
3526
3527         We weren't adding the final event when interpolating event streams.
3528
3529         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3530         (-[HIDEventGenerator interpolatedEvents:]):
3531
3532 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3533
3534         [Cocoa] Variation fonts are erroneously disabled on iOS
3535         https://bugs.webkit.org/show_bug.cgi?id=167172
3536
3537         Reviewed by Simon Fraser.
3538
3539         OpenSource builders don't seem to understand sdk=embedded*.
3540
3541         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3542
3543 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3544
3545         Unreviewed. Fix GTK+ unit tests failing since r210531.
3546
3547         Avoid using paths to files that don't actually exist.
3548
3549         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3550         (testWebKitConsoleMessageNetworkError):
3551         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3552         (testContextMenuDefaultMenu):
3553         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3554         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3555         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3556
3557 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3558
3559         [GTK] Provide API to set proxy settings
3560         https://bugs.webkit.org/show_bug.cgi?id=128674
3561
3562         Reviewed by Michael Catanzaro.
3563
3564         Add tests for new proxy settings API.
3565
3566         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3567         (serverCallback):
3568         (ProxyTest::ProxyTest):
3569         (ProxyTest::~ProxyTest):
3570         (ProxyTest::loadURIAndGetMainResourceData):
3571         (ProxyTest::proxyServerPortAsString):
3572         (testWebContextProxySettings):
3573         (beforeAll):
3574
3575 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3576
3577         Add back my old email address so old commits will still match it.
3578
3579         * Scripts/webkitpy/common/config/contributors.json:
3580
3581 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3582
3583         Remove my old email address from contributors.json and watchlist.
3584
3585         * Scripts/validate-committer-lists:
3586         (CommitterListFromGit): Change the mapping to the correct email.
3587         * Scripts/webkitpy/common/config/contributors.json:
3588         * Scripts/webkitpy/common/config/watchlist:
3589
3590 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3591
3592         Unreviewed, rolling out r210848.
3593
3594         This change introduced media-related LayoutTest failures and
3595         crashes on macOS.
3596
3597         Reverted changeset:
3598
3599         "[Modern Media Controls] Turn modern media controls on by
3600         default"
3601         https://bugs.webkit.org/show_bug.cgi?id=165668
3602         http://trac.webkit.org/changeset/210848
3603
3604 2017-01-18  Andreas Kling  <akling@apple.com>
3605
3606         Document::securityOrigin() should return a reference.
3607         <https://webkit.org/b/167124>
3608
3609         Reviewed by Sam Weinig.
3610
3611         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3612         (TestWebKitAPI::TEST_F):
3613
3614 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3615
3616         [Win] Clipboard tests are flaky.
3617         https://bugs.webkit.org/show_bug.cgi?id=167088
3618
3619         Reviewed by Brent Fulgham.
3620
3621         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3622         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3623
3624         * DumpRenderTree/win/DumpRenderTree.cpp:
3625         (main):
3626
3627 2017-01-18  Antoine Quint  <graouts@apple.com>
3628
3629         [Modern Media Controls] Turn modern media controls on by default
3630         https://bugs.webkit.org/show_bug.cgi?id=165668
3631
3632         Reviewed by Dean Jackson.
3633
3634         Enabled modern media controls by default in test runners. 
3635
3636         * DumpRenderTree/TestOptions.h:
3637         * WebKitTestRunner/TestOptions.h:
3638