1 2015-10-23 Michael Saboff <msaboff@apple.com>
3 REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
4 https://bugs.webkit.org/show_bug.cgi?id=150513
6 Reviewed by Saam Barati.
8 Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
10 * DumpRenderTree/TestRunner.cpp:
11 (simulateWebNotificationClickCallback):
13 (numberOfDFGCompiles):
14 (TestRunner::staticFunctions):
15 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
16 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
17 (WTR::TestRunner::setBlockAllPlugins):
18 (WTR::TestRunner::failNextCodeBlock):
19 (WTR::TestRunner::numberOfDFGCompiles):
20 * WebKitTestRunner/InjectedBundle/TestRunner.h:
22 2015-10-23 Anders Carlsson <andersca@apple.com>
24 Simplify the WebKitLegacy menu conversion code
25 https://bugs.webkit.org/show_bug.cgi?id=150509
27 Reviewed by Andreas Kling.
29 Implement the context menu delegate method so we'll test that code path.
31 * MiniBrowser/mac/WK1BrowserWindowController.m:
32 (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
34 2015-10-23 Per Arne Vollan <peavo@outlook.com>
36 [WinCairo] Improve test results for fast layouttests.
37 https://bugs.webkit.org/show_bug.cgi?id=150464
39 Reviewed by Alex Christensen.
41 Set custom device scale factor to 1.0.
43 * DumpRenderTree/win/DumpRenderTree.cpp:
44 (createWebViewAndOffscreenWindow):
46 2015-10-23 Mark Salisbury <mark.salisbury@hp.com>
48 [GTK] update-webkitgtk-libs should use mesa tarball
50 https://bugs.webkit.org/show_bug.cgi?id=150470
52 update-webkitgtk-libs downloads all build dependencies; in fixing
53 bug 148941 mesa was switched from ftp to git access. Now an http
54 tarball is available, which is preferred over accessing via git.
56 Reviewed by Philippe Normand
58 * gtk/jhbuild.modules:
59 Mesa access changed to http tarball.
61 2015-10-22 Sam Weinig <sam@webkit.org>
63 Navigations on the same host (but with different schemes and ports) should not trigger universal links
64 <rdar://problem/22811325>
65 https://bugs.webkit.org/show_bug.cgi?id=150481
67 Reviewed by Dan Bernstein.
69 * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
70 Update test to test that navigations on the same host but with different schemes does not
71 trigger universal links, but that changes in the host do.
73 2015-10-22 Ryosuke Niwa <rniwa@webkit.org>
75 REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
76 https://bugs.webkit.org/show_bug.cgi?id=150428
78 Reviewed by Antti Koivisto.
80 Added a regression test using WebKit API test.
82 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
83 * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
84 (TestWebKitAPI::didFinishLoadForFrame):
85 (TestWebKitAPI::TEST):
87 2015-10-22 Carlos Garcia Campos <cgarcia@igalia.com>
89 Unreviewed. Fix GTK+ build after r191423.
91 Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
94 (WebKitDOMDocGenerator):
96 2015-10-22 Aakash Jain <aakash_jain@apple.com>
98 [Win][EFL][GTK] webkitpy test failed after r191374.
99 https://bugs.webkit.org/show_bug.cgi?id=150433
101 Reviewed by Alexey Proskuryakov.
103 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
104 (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
105 (CrashLogsTest.test_find_log_darwin): Same.
107 2015-10-21 Brian Burg <bburg@apple.com>
109 Unreviewed, update watchlist for JS builtins.
111 Add a category for JS builtins code generator, similar to other generators.
113 Add a nag message to rebaseline builtins generator tests when touching
114 code generator files in Source/JavaScriptCore/Scripts/builtins/.
116 * Scripts/webkitpy/common/config/watchlist:
118 2015-10-21 Brian Burg <bburg@apple.com>
120 Restructure generate-js-bindings script to be modular and testable
121 https://bugs.webkit.org/show_bug.cgi?id=149929
123 Reviewed by Alex Christensen.
125 Add a stub shell script and basic webkitpy support for running builtins
128 * Scripts/run-builtins-generator-tests: Added.
130 * Scripts/webkitpy/codegen/__init__.py: Added.
131 * Scripts/webkitpy/codegen/main.py: Added.
133 The only interesting difference here from the inspector protocol
134 generator equivalent is that this implementation decodes the target
135 framework and output mode (combined or separate) from the test's file name.
137 (BuiltinsGeneratorTests):
138 (BuiltinsGeneratorTests.__init__):
139 (BuiltinsGeneratorTests.generate_from_js_builtins):
140 (BuiltinsGeneratorTests.write_error_file):
141 (BuiltinsGeneratorTests.detect_changes):
142 (BuiltinsGeneratorTests.run_tests):
143 (BuiltinsGeneratorTests.main):
145 2015-10-21 Aakash Jain <aakash_jain@apple.com>
147 run-webkit-tests does not copy all crash logs for layout test failures on Mac
148 https://bugs.webkit.org/show_bug.cgi?id=150407
149 <rdar://problem/22239750>
151 Reviewed by Alexey Proskuryakov.
153 * Scripts/webkitpy/port/mac.py:
154 (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
155 (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
157 (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
158 from log directory and merge them with the list of already crashed tests.
160 2015-10-21 Filip Pizlo <fpizlo@apple.com>
162 Failures in PutStackSinkingPhase should be less severe
163 https://bugs.webkit.org/show_bug.cgi?id=150400
165 Reviewed by Geoffrey Garen.
167 Add a test mode for no PutStackSinkingPhase.
169 * Scripts/run-jsc-stress-tests:
171 2015-10-21 Nan Wang <n_wang@apple.com>
173 AX: Expose table size and cell indexes on iOS
174 https://bugs.webkit.org/show_bug.cgi?id=150366
176 Reviewed by Chris Fleizach.
178 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
179 (AccessibilityUIElement::rowCount):
180 (AccessibilityUIElement::columnCount):
181 (AccessibilityUIElement::indexInTable):
182 (AccessibilityUIElement::numberAttributeValue):
183 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
184 (WTR::AccessibilityUIElement::numberAttributeValue):
185 (WTR::AccessibilityUIElement::rowCount):
186 (WTR::AccessibilityUIElement::columnCount):
187 (WTR::AccessibilityUIElement::indexInTable):
189 2015-10-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
191 W3C test importer should not import reference files as regular tests
192 https://bugs.webkit.org/show_bug.cgi?id=150331
194 Reviewed by Darin Adler.
196 Updated test_parser to return information that a file can be a referencefile or a manual test.
197 Updated test importer to skip those files.
198 Updated/Added test parser unit tests accordingly.
200 Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
201 Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
202 to mark these files as Skip, since they are not direct tests.
204 * Scripts/webkitpy/w3c/test_importer.py:
205 (TestImporter.__init__):
206 (TestImporter.find_importable_tests):
207 (TestImporter.import_tests):
208 * Scripts/webkitpy/w3c/test_parser.py:
209 (TestParser.analyze_test):
210 * Scripts/webkitpy/w3c/test_parser_unittest.py:
211 (test_analyze_non_html_file):
212 (test_reference_test):
214 2015-10-20 Aakash Jain <aakash_jain@apple.com>
216 run-webkit-tests does not copy all crash logs for layout test failures on iOS
217 https://bugs.webkit.org/show_bug.cgi?id=150056
218 <rdar://problem/9280656>
220 Reviewed by Alexey Proskuryakov.
222 * Scripts/webkitpy/common/system/crashlogs.py:
223 (CrashLogs.find_all_logs): Generic method to find all crash logs.
224 (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
225 It iterates through log directory and returns all the logs based on timestamp.
226 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
227 (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
228 (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
229 (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
230 * Scripts/webkitpy/layout_tests/controllers/manager.py:
231 (Manager.run): Modified start_time to start counting before simulator launch
232 so that we can capture crashes during simualator launch.
233 (Manager._look_for_new_crash_logs): Browse through list of crashes and append
234 any test which is not already marked as CRASH to the run_results.
235 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
236 (TestExpectationsModel.get_expectations_string): return PASS in case there
237 are no expectations defined for this test.
238 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
239 (summarize_results): Add other_crashes in a separte category in full_results.json.
240 * Scripts/webkitpy/port/ios.py:
241 (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
242 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
243 from the log directory.
244 (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
245 logs from log directory and merge them with the list of already crashed tests.
247 2015-10-20 Dana Burkart <dburkart@apple.com>
253 My previous patch was missing a necessary space character.
255 * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
257 2015-10-20 Dana Burkart <dburkart@apple.com>
259 svn-apply fails to apply binary diffs in some cases
260 https://bugs.webkit.org/show_bug.cgi?id=64647
262 Reviewed by Daniel Bates.
264 * Scripts/VCSUtils.pm:
265 (decodeGitBinaryPatchDeltaSize): Modified.
266 We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
267 * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
269 2015-10-20 Alexey Proskuryakov <ap@apple.com>
271 Mac Debug EWS never finishes when there are failures
272 https://bugs.webkit.org/show_bug.cgi?id=150334
274 Reviewed by Daniel Bates.
276 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
277 * Scripts/webkitpy/tool/commands/queues.py:
279 2015-10-20 Philippe Normand <pnormand@igalia.com>
281 [GTK] Enable OpenWebRTC test video/audio sources in tests
283 This is needed because we can't expect the buildbots to have
284 webcam/mic devices plugged in.
286 Rubber-stamped by Carlos Garcia Campos.
288 * Scripts/run-gtk-tests:
289 (TestRunner._setup_testing_environment):
290 * Scripts/webkitpy/port/gtk.py:
291 (GtkPort.setup_environ_for_server):
293 2015-10-20 Yoav Weiss <yoav@yoav.ws>
295 Rename the PICTURE_SIZES flag to CURRENTSRC
296 https://bugs.webkit.org/show_bug.cgi?id=150275
298 Reviewed by Dean Jackson.
300 * Scripts/webkitperl/FeatureList.pm:
302 2015-10-19 Hunseop Jeong <hs85.jeong@samsung.com>
304 Unreviewed, add myself to the committers list.
306 * Scripts/webkitpy/common/config/contributors.json:
308 2015-10-19 Alexey Proskuryakov <ap@apple.com>
310 Add new EWS queues to bot watcher's dashboard
311 https://bugs.webkit.org/show_bug.cgi?id=150297
313 Reviewed by Darin Adler.
315 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
318 2015-10-19 ChangSeok Oh <changseok.oh@collabora.com>
320 REGRESSION(r190262): User media unit test failures after r190262
321 https://bugs.webkit.org/show_bug.cgi?id=149580
323 Reviewed by Carlos Garcia Campos.
325 The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
326 So we do not need to skip them anymore.
328 * Scripts/run-gtk-tests:
329 (TestRunner): Deleted.
331 2015-10-19 Csaba Osztrogonác <ossy@webkit.org>
333 Add historical addresses to contributors.json
334 https://bugs.webkit.org/show_bug.cgi?id=150227
336 Reviewed by Darin Adler.
338 * Scripts/webkitpy/common/config/contributors.json:
340 2015-10-18 Sungmann Cho <sungmann.cho@navercorp.com>
342 [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
343 https://bugs.webkit.org/show_bug.cgi?id=150307
345 Reviewed by Brent Fulgham.
347 The DLL build rules have been changed to generate "{Name}Lib.DLL",
348 but these changes have not yet been applied to the Visual Studio builds.
350 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
352 2015-10-16 Andreas Kling <akling@apple.com>
354 [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
355 <https://webkit.org/b/150153>
359 Just use simple arrays of LChar and UChar for this test instead of creating String
360 objects and then getting the characters8()/characters16() from them, since that
361 doesn't guarantee null-termination (the bug.)
363 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
364 (TestWebKitAPI::TEST):
365 (TestWebKitAPI::build): Deleted.
367 2015-10-16 Tim Horton <timothy_horton@apple.com>
369 WebKit2.AutoLayoutIntegration API test is failing on some of the bots
370 https://bugs.webkit.org/show_bug.cgi?id=150255
372 Reviewed by Simon Fraser.
374 * Scripts/run-api-tests:
376 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
377 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
378 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
379 (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
380 (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
381 Don't set the layout size until after the load finishes and we're waiting
382 for the reply, so that there is no race between the new size coming in
383 and us waiting for it.
385 2015-10-16 Anders Carlsson <andersca@apple.com>
387 WebEditingDelegate should be a formal protocol
388 https://bugs.webkit.org/show_bug.cgi?id=150254
389 <rdar://problem/23149847>
391 Reviewed by Dan Bernstein.
393 * DumpRenderTree/mac/EditingDelegate.h:
394 Conform to the WebEditingDelegate protocol.
396 2015-10-16 Tim Horton <timothy_horton@apple.com>
398 Hook up autolayout intrinsic sizing for WKWebView
399 https://bugs.webkit.org/show_bug.cgi?id=150219
400 <rdar://problem/20016905>
402 Reviewed by Simon Fraser.
404 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
405 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
406 (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
407 (-[AutoLayoutWKWebView load:expectingContentSize:]):
408 (-[AutoLayoutWKWebView expectContentSizeChange:]):
409 (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
411 Add a variety of tests, including one which catches the bug that
412 the WebCore part of this patch fixes.
414 2015-10-15 Csaba Osztrogonác <ossy@webkit.org>
416 Update the help message of --system-malloc
417 https://bugs.webkit.org/show_bug.cgi?id=150169
419 Reviewed by Geoffrey Garen.
421 * Scripts/webkitperl/FeatureList.pm:
423 2015-10-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
425 Update ImportExpectations according currently imported wpt tests
426 https://bugs.webkit.org/show_bug.cgi?id=150158
428 Reviewed by Chris Dumez.
430 * Scripts/webkitpy/w3c/test_downloader.py:
431 (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
433 2015-10-15 Eunmi Lee <eunmi15.lee@samsung.com>
435 Unreviewed, Update my email address.
437 * Scripts/webkitpy/common/config/contributors.json:
439 2015-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
441 [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
442 https://bugs.webkit.org/show_bug.cgi?id=84960
444 Reviewed by Žan Doberšek.
446 * Scripts/run-gtk-tests:
447 (TestRunner): Unskip tests using SessionState.
448 * TestWebKitAPI/PlatformGTK.cmake: Add
449 WKPageCopySessionStateWithFiltering test.
451 2015-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
453 [GTK] Missing return value on TestWebExtensions.cpp:193
454 https://bugs.webkit.org/show_bug.cgi?id=149755
456 Unreviewed. Add missing return value.
458 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
459 (permissionRequestCallback):
461 2015-10-14 Andy Estes <aestes@apple.com>
463 [iOS] build-dumprendertree does not build ImageDiff
464 https://bugs.webkit.org/show_bug.cgi?id=150152
466 Reviewed by Tim Horton.
468 run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
469 On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
470 as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
471 WebKit.xcworkspace), tests that rely on image diffing won't work properly.
473 There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
474 fine on that platform, and results in ImageDiff being built.
476 * Scripts/build-dumprendertree:
478 2015-10-14 Brent Fulgham <bfulgham@apple.com>
480 [Win] Enforce launcher/library naming scheme
481 https://bugs.webkit.org/show_bug.cgi?id=150124
483 Reviewed by Alex Christensen.
485 * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
486 * MiniBrowser/win/CMakeLists.txt: Ditto.
487 * TestWebKitAPI/PlatformWin.cmake: Ditto.
488 * win/DLLLauncher/DLLLauncherMain.cpp:
489 (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
492 2015-10-14 Andreas Kling <akling@apple.com>
494 REGRESSION(r190882): Concatenating a character array and an empty string is broken.
495 <https://webkit.org/b/150135>
497 Reviewed by Geoffrey Garen.
499 Add a new WTF API test that covers this issue.
501 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
502 (TestWebKitAPI::build):
503 (TestWebKitAPI::TEST):
505 2015-10-14 Alex Christensen <achristensen@webkit.org>
507 Add SPI for reloading without content blockers
508 https://bugs.webkit.org/show_bug.cgi?id=150058
509 rdar://problem/22742222
511 Reviewed by Sam Weinig.
513 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
514 (WTR::TestController::cocoaResetStateToConsistentValues):
515 * WebKitTestRunner/mac/TestControllerMac.mm:
516 (WTR::TestController::platformConfigureViewForTest):
518 2015-10-14 Mark Lam <mark.lam@apple.com>
520 Rename some JSC option names to be more uniform.
521 https://bugs.webkit.org/show_bug.cgi?id=150127
523 Reviewed by Geoffrey Garen.
525 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
526 * Scripts/run-jsc-stress-tests:
528 2015-10-14 Anders Carlsson <andersca@apple.com>
530 Change the bundle app cache APIs to take a page
531 https://bugs.webkit.org/show_bug.cgi?id=150123
533 Reviewed by Sam Weinig.
537 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
538 (WTR::InjectedBundle::beginTesting):
539 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
540 (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
541 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
542 (WTR::TestRunner::clearAllApplicationCaches):
543 (WTR::TestRunner::clearApplicationCacheForOrigin):
544 (WTR::TestRunner::setAppCacheMaximumSize):
545 (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
546 (WTR::TestRunner::originsWithApplicationCache):
548 2015-10-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
550 Update web-platform-tests tools to the latest revision
551 https://bugs.webkit.org/show_bug.cgi?id=149645
553 Reviewed by Darin Adler.
555 Disabling git submodules information conversion to json install file for web-platform-tests.
556 Disabling related python unit tests.
557 The tools submodules contain submodules and the conversion tool does not support that yet.
559 Updating wpt launcher script to aling it with web-platform-test main script.
561 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
563 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
564 (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
565 * Scripts/webkitpy/w3c/test_importer_unittest.py:
566 (TestImporterTest.test_submodules_generation):
568 2015-10-13 Alexey Proskuryakov <ap@apple.com>
570 More debug queue build fixing.
572 Preserve the build style in one more place. Changed mock build_style from "both"
573 to "release", as we don't support testing both debug and release.
575 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
576 (MockCommitQueue.archive_last_test_results):
578 (MockCommitQueue.build_style):
579 (MockCommitQueue.did_pass_testing_ews):
580 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
581 (PatchAnalysisTask._test):
582 (PatchAnalysisTask._build_and_test_without_patch):
583 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
584 (EarlyWarningSystemTest._default_expected_logs):
585 * Scripts/webkitpy/tool/commands/queues_unittest.py:
587 2015-10-13 Alexey Proskuryakov <ap@apple.com>
589 More debug queue build fixing.
591 Add build_style argument to derived classes as well.
593 * Scripts/webkitpy/common/config/ports.py:
595 (MacPort.run_webkit_tests_command):
596 (WinPort.run_bindings_tests_command):
598 (WinPort.run_webkit_tests_command):
599 (GtkWK2Port.build_webkit_command):
601 (GtkWK2Port.run_webkit_tests_command):
603 2015-10-13 Myles C. Maxfield <mmaxfield@apple.com>
609 Mach-O section names are limited to 16 characters.
611 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
612 * DumpRenderTree/mac/DumpRenderTree.mm:
615 2015-10-13 Alexey Proskuryakov <ap@apple.com>
617 Build fix for mac-debug EWS queue.
621 Pass --debug to run-webkit-tests.
623 While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
624 will need to be substantially modified to work in EWS, so the dummy implementation
627 * Scripts/webkitpy/common/config/ports.py:
628 (DeprecatedPort.run_javascriptcore_tests_command):
630 (DeprecatedPort.run_webkit_tests_command):
631 (DeprecatedPort.run_python_unittests_command):
632 (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
633 * Scripts/webkitpy/common/config/ports_mock.py:
634 (MockPort.run_javascriptcore_tests_command):
636 (MockPort.run_webkit_tests_command):
637 (MockPort.run_bindings_tests_command):
638 (MockPort.run_webkit_unit_tests_command): Deleted.
639 * Scripts/webkitpy/tool/commands/download_unittest.py:
640 * Scripts/webkitpy/tool/steps/runtests.py:
642 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
643 (RunTestsTest.test_webkit_run_unit_tests):
644 * Scripts/webkitpy/tool/steps/steps_unittest.py:
645 (StepsTest.test_runtests_args):
647 2015-10-13 Brent Fulgham <bfulgham@apple.com>
649 [Win] Generate Crash Traces
650 https://bugs.webkit.org/show_bug.cgi?id=150103
652 Reviewed by Daniel Bates.
654 We were using an exception filter to try to emit "#CRASHED" to stderr
655 when a test program crashed. However, the modern Python implementation
656 seems capable of recognizing crashes on its own. Furthermore, registering
657 the exception handler was preventing the JIT debugger (NTSD) from
658 automatically attaching to the crashing program, so we were not getting
661 * DumpRenderTree/win/DumpRenderTree.cpp:
662 (main): Don't register an exception filter.
663 (exceptionFilter): Deleted.
664 * Scripts/webkitpy/common/system/crashlogs.py:
665 (CrashLogs): Add another regular expression to handle a second crash trace
666 syntax I encountered during testing.
667 (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
668 try the new one. The PID found by the new expression is in hexadecimal, so
669 convert it to an integer before returning it.
670 * Scripts/webkitpy/port/driver.py:
671 (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
672 the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
673 check for "#CRASHED" after stripping off the EOL characters.
674 * Scripts/webkitpy/port/win.py:
675 (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
676 invocation. This is apparently used to signal an event when the debugger is finished.
678 2015-10-13 Alexey Proskuryakov <ap@apple.com>
680 Mac Debug and 32-bit queues should be separate
681 https://bugs.webkit.org/show_bug.cgi?id=150092
683 Reviewed by Lucas Forschler.
685 * QueueStatusServer/config/queues.py:
686 * QueueStatusServer/model/queues.py:
687 (Queue._capitalize_after_dash):
688 (Queue._caplitalize_after_dash): Deleted.
689 * Scripts/webkitpy/common/config/ews.json:
691 2015-10-13 Sergio Villar Senin <svillar@igalia.com>
693 [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
694 https://bugs.webkit.org/show_bug.cgi?id=150085
696 Reviewed by Carlos Garcia Campos.
698 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
700 2015-10-13 Sebastian Dröge <sebastian@centricular.com>
702 Unreviewed, add myself to the committers list.
704 * Scripts/webkitpy/common/config/contributors.json:
706 2015-10-12 Alexey Proskuryakov <ap@apple.com>
708 Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
709 https://bugs.webkit.org/show_bug.cgi?id=149983
711 Reviewed by Dan Bates.
713 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
715 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
717 2015-10-12 Alexey Proskuryakov <ap@apple.com>
719 Fix webkitpy tests after r190922.
721 * Scripts/webkitpy/common/config/ews.json:
722 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
723 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
725 2015-10-12 Alexey Proskuryakov <ap@apple.com>
727 Add a Mac debug EWS queue
728 https://bugs.webkit.org/show_bug.cgi?id=150069
730 Reviewed by Geoffrey Garen.
732 * QueueStatusServer/config/queues.py:
733 * Scripts/webkitpy/common/config/ews.json:
734 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
735 (AbstractEarlyWarningSystem):
736 (AbstractEarlyWarningSystem.archive_last_test_results):
737 (AbstractEarlyWarningSystem.build_style):
738 (AbstractEarlyWarningSystem.refetch_patch):
739 (AbstractEarlyWarningSystem.load_ews_classes):
741 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
743 [GTK] Update jhbuild's version of harfbuzz
744 https://bugs.webkit.org/show_bug.cgi?id=149749
746 Reviewed by Martin Robinson.
748 Update harfbuzz to 0.9.35, following the lead of Debian Stable.
750 * gtk/jhbuild.modules: Updated details for harfbuzz.
752 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
754 [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
755 https://bugs.webkit.org/show_bug.cgi?id=150026
757 Reviewed by Philippe Normand.
759 Backport upstream patch from gst-plugins-bad so that the right version
760 of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
761 gets compiled properly, avoiding crashes on runtime while running tests.
763 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
764 * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
766 2015-10-11 Myles C. Maxfield <mmaxfield@apple.com>
768 Test font-variant-* and font-feature-settings with mocked preinstalled fonts
769 https://bugs.webkit.org/show_bug.cgi?id=149777
771 Reviewed by Simon Fraser.
773 Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
774 to the list of tests to preinstall at startup time.
776 Also, update the generation of the 'name' table in the FontWithFeatures font.
778 * DumpRenderTree/mac/DumpRenderTree.mm:
779 (allowedFontFamilySet):
780 (activateTestingFonts):
782 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
783 (Generator::generate):
784 (Generator::appendCFFTable):
785 (Generator::appendNameSubtable):
786 (Generator::appendNAMETable):
787 * FontWithFeatures/FontWithFeatures/main.cpp:
789 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
790 (WTR::allowedFontFamilySet):
791 (WTR::activateFonts):
792 * WebKitTestRunner/mac/TestControllerMac.mm:
793 (WTR::allowedFontFamilySet):
795 2015-10-11 Jinyoung Hur <hur.ims@navercorp.com>
797 Unreviewed. Add Jinyoung Hur as a committer.
799 * Scripts/webkitpy/common/config/contributors.json:
801 2015-10-10 Dan Bernstein <mitz@apple.com>
803 [iOS] Remove unnecessary iOS version checks
804 https://bugs.webkit.org/show_bug.cgi?id=150002
806 Reviewed by Alexey Proskuryakov.
808 * WebKitTestRunner/ios/HIDEventGenerator.mm:
809 (-[HIDEventGenerator _createIOHIDEventType:]):
810 (-[HIDEventGenerator _sendHIDEvent:]):
811 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
812 * WebKitTestRunner/ios/UIKitSPI.h:
814 2015-10-09 Myles C. Maxfield <mmaxfield@apple.com>
816 Unreviewed, rolling out r190689
817 https://bugs.webkit.org/show_bug.cgi?id=149992
819 Fixed in other repository.
823 "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
824 https://bugs.webkit.org/show_bug.cgi?id=149897
826 2015-10-09 Brian Burg <bburg@apple.com>
828 Teach webkitperl how to figure out IOS versions from the SDK
829 https://bugs.webkit.org/show_bug.cgi?id=149963
831 Reviewed by Daniel Bates.
833 It should be easier to check the major and minor version of IOS SDKs.
835 * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
836 * Scripts/webkitdirs.pm:
837 (splitVersionString): Added.
838 (determineOSXVersion): Use splitVersionString.
839 (determineIOSVersion): Added. Look at the SDK version and make a tuple.
842 2015-10-09 Simon Fraser <simon.fraser@apple.com>
844 [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
845 https://bugs.webkit.org/show_bug.cgi?id=149960
847 Reviewed by Tim Horton.
849 Use adoptWK(), and null out some members (file is not using ARC).
851 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
852 (UIScriptContext::uiScriptComplete):
853 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
854 (-[TestRunnerWKWebView dealloc]):
856 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
858 Remove ENABLE_SUID_SANDBOX_LINUX cruft
859 https://bugs.webkit.org/show_bug.cgi?id=149954
861 Reviewed by Darin Adler.
863 * Scripts/webkitperl/FeatureList.pm:
865 2015-10-09 Daniel Bates <dabates@apple.com>
867 Make iOS builders generate debug information in a separate dSYM file
868 https://bugs.webkit.org/show_bug.cgi?id=149696
870 Reviewed by Darin Adler.
872 Similar to the Mac builders, the iOS builders should write debug information
873 into a separate dSYM file instead of including such information in the binary
874 itself (default Xcode behavior)
876 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
877 (CompileWebKit.start):
879 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
881 Fix webkitpy tests after r190779
882 https://bugs.webkit.org/show_bug.cgi?id=149949
884 Reviewed by Ryosuke Niwa.
886 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
887 (BenchmarkResults.format):
888 (BenchmarkResults._format_values):
890 2015-10-08 Dewei Zhu <dewei_zhu@apple.com>
892 Extend run-benchmark script to support human-readable results conversion.
893 https://bugs.webkit.org/show_bug.cgi?id=149944
895 Reviewed by Ryosuke Niwa.
897 Add '--read-results-json' and '--no-adjust-unit' options.
898 '--read-results-json' option converts result file to human readable format.
899 '--no-adjust-unit' option skips scientific notation convertion.
900 '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
902 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
903 (BenchmarkResults.format):
904 (BenchmarkResults._format_tests):
905 (BenchmarkResults._format_values):
906 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
907 (BenchmarkRunner.__init__):
908 (BenchmarkRunner._run_benchmark):
909 (BenchmarkRunner._dump):
910 (BenchmarkRunner.show_results):
911 (BenchmarkRunner._show_results): Deleted.
912 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
916 2015-10-08 Daniel Bates <dabates@apple.com>
918 Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
919 https://bugs.webkit.org/show_bug.cgi?id=149945
921 Reviewed by Dan Bernstein.
923 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
924 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
925 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
926 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
928 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
929 (table.queue-grid tr.platform.ios-9 img.logo):
931 2015-10-08 Daniel Bates <dabates@apple.com>
933 Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
934 https://bugs.webkit.org/show_bug.cgi?id=149943
936 Reviewed by Dan Bernstein.
938 Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
939 teach build-webkit to install them when building for iOS device using the public iOS SDK.
941 * Scripts/build-webkit:
943 2015-10-08 Daniel Bates <dabates@apple.com>
945 Add LLVM binaries for iOS 9 device
946 https://bugs.webkit.org/show_bug.cgi?id=149913
948 Reviewed by Filip Pizlo.
950 Implement support for building LLVM for ARM64-based iOS devices.
952 * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
953 * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
954 an existing build earlier in the file such that remove previously built
955 libraries before building/copying new ones (if applicable).
956 (fileContains): Moved function outside of if-block.
957 (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
958 (buildLLVM): Added. Extracted machinery to build LLVM into this function and
959 added logic to build LLVM for ARM64-based iOS devices.
960 (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
961 LLVM into the WebKitBuild directory.
963 2015-10-08 Alexey Proskuryakov <ap@apple.com>
965 Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
966 https://bugs.webkit.org/show_bug.cgi?id=149848
968 Reviewed by Darin Adler.
970 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
972 2015-10-07 Brent Fulgham <bfulgham@apple.com>
974 [Win] Support 64-bit Build and Testing
975 https://bugs.webkit.org/show_bug.cgi?id=149904
977 Reviewed by Daniel Bates.
979 Extend our existing scripts to support 64-bit build and test operations on
982 * Scripts/build-dumprendertree: We don't need to build DRT on its own;
983 Windows always builds the whole stack.
984 * Scripts/webkit-build-directory: Add an option to return the location of
985 the executable files produced by a specific configuration. This change is
986 actually useful for Gtk and EFL, too.
987 * Scripts/webkitdirs.pm:
988 (executableProductDir): Added. This function appends the proper binary
989 path to the productDir. This is useful for Windows, Gtk, and EFL ports.
990 (jscProductDir): Use the new 'executableProductDir' method.
991 (setPathForRunningWebKitApp): Ditto.
993 (runMiniBrowser): Ditto.
994 * Scripts/webkitpy/port/factory.py:
995 (configuration_options): Add a 64-bit option, used on Windows to specify
996 which binary target should be used for testing.
997 * Scripts/webkitpy/port/win.py:
998 (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
999 processes when needed.
1000 (WinPort._build_path): Add the correct binary target path to _build_path.
1001 (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1002 64-bit paths for 64-bit tests.
1003 (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1004 NTSD debugger does not understand this argument.
1006 2015-10-07 Myles C. Maxfield <mmaxfield@apple.com>
1008 Test font-variant-* and font-feature-settings with TrueType fonts
1009 https://bugs.webkit.org/show_bug.cgi?id=149776
1011 Reviewed by Simon Fraser.
1013 This test extends our existing FontWithFeatures project to be able to generate a
1014 TrueType font. This font is conceptually similar as the existing OpenType font,
1015 except the feature -> character mapping is different.
1017 The font itself only supports the following characters:
1018 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1019 However, the shape of these letters are either an X or a check mark.
1020 The letter "A" always is a check mark.
1021 The letter "B" always is an X.
1022 Each font feature has an letter associated with it. When the font feature is enabled,
1023 that letter is shown as a check mark. For example, when
1024 "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1027 Here are the mappings of font features to letters:
1028 kLigaturesType / kCommonLigaturesOnSelector: C
1029 kLigaturesType / kContextualLigaturesOnSelector: D
1030 kLigaturesType / kRareLigaturesOnSelector: G
1031 kLigaturesType / kHistoricalLigaturesOnSelector: I
1032 kContextualAlternatesType / kContextualAlternatesOnSelector: L
1033 kVerticalPositionType / kInferiorsSelector: O
1034 kVerticalPositionType / kSuperiorsSelector: P
1035 kLowerCaseType / kLowerCaseSmallCapsSelector: S
1036 kUpperCaseType / kUpperCaseSmallCapsSelector: V
1037 kLowerCaseType / kLowerCasePetiteCapsSelector: T
1038 kUpperCaseType / kUpperCasePetiteCapsSelector: W
1039 kLetterCaseType / 14: Y
1040 kStyleOptionsType / kTitlingCapsSelector: a
1041 kNumberCaseType / kUpperCaseNumbersSelector: c
1042 kNumberCaseType / kLowerCaseNumbersSelector: d
1043 kNumberSpacingType / kProportionalNumbersSelector: f
1044 kNumberSpacingType / kMonospacedNumbersSelector: g
1045 kFractionsType / kDiagonalFractionsSelector: i
1046 kFractionsType / kVerticalFractionsSelector: j
1047 kVerticalPositionType / kOrdinalsSelector: Q
1048 kTypographicExtrasType / kSlashedZeroOnSelector: k
1049 kLigaturesType / kHistoricalLigaturesOnSelector: K
1050 kCharacterShapeType / kJIS1978CharactersSelector: m
1051 kCharacterShapeType / kJIS1983CharactersSelector: n
1052 kCharacterShapeType / kJIS1990CharactersSelector: o
1053 kCharacterShapeType / kJIS2004CharactersSelector: p
1054 kCharacterShapeType / kSimplifiedCharactersSelector: q
1055 kCharacterShapeType / kTraditionalCharactersSelector: r
1056 kTextSpacingType / kMonospacedTextSelector: t
1057 kTextSpacingType / kProportionalTextSelector: u
1058 kRubyKanaType / kRubyKanaOnSelector: v
1060 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1061 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1062 (CFFBuilder::moveTo):
1063 (CFFBuilder::lineTo):
1064 (GLYFBuilder::GLYFBuilder):
1065 (GLYFBuilder::takeResult):
1066 (GLYFBuilder::moveTo):
1067 (GLYFBuilder::lineTo):
1068 (GLYFBuilder::closePath):
1069 (GLYFBuilder::writePoint):
1070 (GLYFBuilder::append16):
1071 (generateBoxCharString):
1072 (generateCheckCharString):
1073 (generateXCharString):
1075 (Generator::generate):
1076 (Generator::insertSelector):
1077 (Generator::insertFeature):
1078 (Generator::generateFeatureDescription):
1079 (Generator::appendCFFTable):
1080 (Generator::appendGLYFTable):
1081 (Generator::appendLOCATable):
1082 (Generator::appendFEATTable):
1083 (Generator::appendMetamorphosisChain):
1084 (Generator::appendMORXTable):
1085 (Generator::appendHEADTable):
1086 (Generator::appendHMTXTable):
1087 (Generator::appendNameSubtable):
1088 (Generator::append2ByteASCIIString):
1089 (Generator::appendNAMETable):
1091 (CFFBuilder::curveToCubic): Deleted.
1092 (charStringForGlyph): Deleted.
1093 * FontWithFeatures/FontWithFeatures/FontCreator.h:
1094 * FontWithFeatures/FontWithFeatures/main.cpp:
1095 (constructFontWithTrueTypeFeature):
1096 (constructFontWithOpenTypeFeature):
1099 (drawTextWithFeature): Deleted.
1101 2015-10-07 Commit Queue <commit-queue@webkit.org>
1103 Unreviewed, rolling out r190572, r190593, r190594, and
1105 https://bugs.webkit.org/show_bug.cgi?id=149897
1107 Breaks Mavericks build (Requested by litherum on #webkit).
1109 Reverted changesets:
1111 "Allow WKRetainPtrs to be used as keys in hashing data
1113 https://bugs.webkit.org/show_bug.cgi?id=149762
1114 http://trac.webkit.org/changeset/190572
1116 "REGRESSION(189668?): http/tests/notifications/events.html
1117 flakily asserts or times out"
1118 https://bugs.webkit.org/show_bug.cgi?id=149218
1119 http://trac.webkit.org/changeset/190593
1121 "Prospective Mavericks build fix."
1122 http://trac.webkit.org/changeset/190594
1124 "Post-review cleanup after r190572."
1125 http://trac.webkit.org/changeset/190639
1127 2015-10-06 Michael Catanzaro <mcatanzaro@igalia.com>
1129 [GTK] Add autocleanups
1130 https://bugs.webkit.org/show_bug.cgi?id=149588
1132 Reviewed by Darin Adler.
1134 * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1135 (AutocleanupsTest::create):
1136 (AutocleanupsTest::testWebProcessAutocleanups):
1138 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1139 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1140 (testUIProcessAutocleanups):
1141 (testWebProcessAutocleanups):
1145 2015-10-06 Brian Burg <bburg@apple.com>
1147 Unreviewed, try to fix the iOS 8 build after r190368.
1149 On older versions, IOHIDEventCreateForceEvent is not available.
1151 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1152 (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1154 2015-10-06 Keith Miller <keith_miller@apple.com>
1156 Add gmalloc option to run-javascriptcore-tests.
1157 https://bugs.webkit.org/show_bug.cgi?id=149858
1159 Reviewed by Geoffrey Garen.
1161 run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1162 If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1164 * Scripts/run-javascriptcore-tests:
1166 2015-10-06 Myles C. Maxfield <mmaxfield@apple.com>
1168 Post-review cleanup after r190572.
1172 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1174 2015-10-06 Brent Fulgham <bfulgham@apple.com>
1176 [Win] Unreviewed build correction.
1178 * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1179 are soft-linked at runtime.
1181 2015-10-06 Keith Miller <keith_miller@apple.com>
1183 Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1184 https://bugs.webkit.org/show_bug.cgi?id=149815
1186 Reviewed by Filip Pizlo.
1188 Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1189 Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1190 running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1191 Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1192 so should just use one test runner.
1194 * Scripts/run-javascriptcore-tests:
1195 (runJSCStressTests):
1196 (runMozillaTests): Deleted.
1197 (defaultJsDriverArgsForMozillaTests): Deleted.
1198 * Scripts/run-jsc-stress-tests:
1200 2015-10-06 Mark Salisbury <mark.salisbury@hp.com>
1202 [GTK] Make update-webkitgtk-libs work behind firewall
1204 update-webkitgtk-libs can work behind a firewall with changes to
1205 a few packages. Where outbound git and active FTP connections
1206 fail, using http protocol succeeds. Most packages are
1207 already accessed using http.
1209 https://bugs.webkit.org/show_bug.cgi?id=148941
1211 Reviewed by Martin Robinson.
1214 * gtk/jhbuild.modules:
1215 Replace git URLs with http. Remove no longer used ftp repositories.
1216 Update argument for libxml2's autogen.sh script (--without-python
1217 is ignored; --with-python=no is correct).
1218 * jhbuild/jhbuild-wrapper:
1219 Instead of connecting to git://git.gnome.org/jhbuild, connect to
1220 http://git.gnome.org/browse/jhbuild.
1222 2015-10-06 Daniel Bates <dbates@webkit.org>
1224 Enable XSLT when building WebKit for iOS using the public iOS SDK
1225 https://bugs.webkit.org/show_bug.cgi?id=149827
1227 Reviewed by Alexey Proskuryakov.
1229 Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1230 and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1231 run this script before building WebKit for iOS or the build will fail because one or more XSLT
1232 headers cannot be found.
1234 * Scripts/configure-xcode-for-ios-development:
1235 (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1237 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
1239 REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1240 https://bugs.webkit.org/show_bug.cgi?id=149218
1242 Reviewed by Alexey Proskuryakov.
1244 Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1245 when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1246 WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1247 and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1248 the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1249 WebNotificationProvider must be updated to appropriately handle multiple
1250 WKNotificationManagerRefs in flight at the same time.
1252 * WebKitTestRunner/WebNotificationProvider.cpp:
1253 (WTR::WebNotificationProvider::~WebNotificationProvider):
1254 (WTR::WebNotificationProvider::showWebNotification):
1255 (WTR::WebNotificationProvider::closeWebNotification):
1256 (WTR::WebNotificationProvider::addNotificationManager):
1257 (WTR::WebNotificationProvider::removeNotificationManager):
1258 (WTR::WebNotificationProvider::simulateWebNotificationClick):
1259 (WTR::WebNotificationProvider::reset):
1260 * WebKitTestRunner/WebNotificationProvider.h:
1262 2015-10-05 Daniel Bates <dabates@apple.com>
1264 Disable Bitcode when building for iOS device
1265 https://bugs.webkit.org/show_bug.cgi?id=149818
1267 Reviewed by Alexey Proskuryakov.
1269 Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1270 when building for iOS device.
1272 * Scripts/webkitdirs.pm:
1275 2015-10-05 Daniel Bates <dabates@apple.com>
1277 [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1278 https://bugs.webkit.org/show_bug.cgi?id=140828
1279 <rdar://problem/19520599>
1281 Reviewed by Alexey Proskuryakov.
1283 Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1284 we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1285 to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1288 * Scripts/webkitdirs.pm:
1289 (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1290 to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1291 Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1292 (hasIOSDevelopmentCertificate): Added.
1294 2015-10-05 Daniel Bates <dabates@apple.com>
1296 DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1297 https://bugs.webkit.org/show_bug.cgi?id=149766
1299 Reviewed by Alexey Proskuryakov.
1301 Create network storage testing session on iOS.
1303 Currently we do not create a network storage testing session on iOS. A network storage testing session always
1304 has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1305 returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1306 NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1307 NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1308 it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1309 create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1310 testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1311 DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1313 As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1314 when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1315 returns a non-null pointer to a cookie store.
1317 * DumpRenderTree/mac/DumpRenderTree.mm:
1318 (prepareConsistentTestingEnvironment):
1320 2015-10-05 Simon Fraser <simon.fraser@apple.com>
1322 Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1325 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1326 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1328 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
1330 Allow WKRetainPtrs to be used as keys in hashing data structures
1331 https://bugs.webkit.org/show_bug.cgi?id=149762
1333 Reviewed by Anders Carlsson.
1335 * TestWebKitAPI/PlatformGTK.cmake:
1336 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1337 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1338 (TestWebKitAPI::TEST):
1340 2015-10-05 Simon Fraser <simon.fraser@apple.com>
1342 Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1343 available, and tidy up the #ifdefs in the UIKitSPI header.
1345 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1346 (-[HIDEventGenerator _sendHIDEvent:]):
1347 * WebKitTestRunner/ios/UIKitSPI.h:
1349 2015-10-04 Zan Dobersek <zdobersek@igalia.com>
1351 [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1352 https://bugs.webkit.org/show_bug.cgi?id=149792
1354 Reviewed by Martin Robinson.
1356 * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1357 for WebKitTestRunner multiple times.
1359 2015-10-04 Daniel Bates <dabates@apple.com>
1361 Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1362 (https://bugs.webkit.org/show_bug.cgi?id=149753)
1364 For now, support calling build-layouttestrelay without --ios-simulator so long
1365 as we are building on a Mac.
1367 * Scripts/build-layouttestrelay:
1369 2015-10-04 Alexey Proskuryakov <ap@apple.com>
1371 Support Trac 1.0.x XML timeline link format
1372 https://bugs.webkit.org/show_bug.cgi?id=149786
1374 Reviewed by Lucas Forschler.
1376 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1377 (Trac.prototype._convertCommitInfoElementToObject):
1379 2015-10-04 Alexey Proskuryakov <ap@apple.com>
1381 Fix some errors on bot watcher's dashboard
1382 https://bugs.webkit.org/show_bug.cgi?id=149789
1384 Reviewed by Lucas Forschler.
1386 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1387 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1388 tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1390 2015-10-04 Alexey Proskuryakov <ap@apple.com>
1392 Bot watcher's dashboard builders should turn yellow when svn fails
1393 https://bugs.webkit.org/show_bug.cgi?id=149791
1395 Reviewed by Lucas Forschler.
1397 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1398 (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1399 (BuildbotBuilderQueueView.prototype.update):
1401 2015-10-02 Daniel Bates <dabates@apple.com>
1403 Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1404 https://bugs.webkit.org/show_bug.cgi?id=149769
1406 Reviewed by Alexey Proskuryakov.
1408 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1409 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1410 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1411 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1413 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1414 (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1416 2015-10-02 Ryosuke Niwa <rniwa@webkit.org>
1418 REGRESSION(r190370): Speedometer spits out an extra console message
1419 https://bugs.webkit.org/show_bug.cgi?id=149720
1421 Unreviewed. Temporarily ignore the console error message.
1423 * Scripts/webkitpy/performance_tests/perftest.py:
1424 (PerfTest._filter_output):
1426 2015-10-02 Brent Fulgham <bfulgham@apple.com>
1428 Provide "--no-ninja" option to avoid using Ninja
1429 https://bugs.webkit.org/show_bug.cgi?id=149757
1431 Reviewed by Alex Christensen.
1433 Add a new command line argument understood by webkitdirs.pm so
1434 that we can conditionally avoid using Ninja. This is an
1435 'opt-out' argument, so no existing Ninja users should be affected.
1437 * Scripts/webkitdirs.pm:
1438 (canUseNinja): Check for option and block ninja if present.
1440 2015-10-02 Aakash Jain <aakash_jain@apple.com>
1442 Flakiness dashboard should support OS X El Capitan
1443 https://bugs.webkit.org/show_bug.cgi?id=149648
1445 Reviewed by Alexey Proskuryakov.
1447 * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1449 2015-10-02 Daniel Bates <dabates@apple.com>
1451 Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1452 (https://bugs.webkit.org/show_bug.cgi?id=149753)
1454 For now, pass --ios-simulator.
1456 * Scripts/webkitpy/port/ios.py:
1457 (IOSSimulatorPort._build_relay):
1459 2015-10-02 Simon Fraser <simon.fraser@apple.com>
1461 Remove a "nullable" that breaks the iOS 8 build.
1463 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1464 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1466 2015-10-02 Daniel Bates <dabates@apple.com>
1468 LayoutTestRelay is not built and archived when building for iOS Simulator
1469 https://bugs.webkit.org/show_bug.cgi?id=149753
1471 Reviewed by Alexey Proskuryakov and Andy Estes.
1473 Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1474 and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1475 product archive when building for iOS Simulator, respectively.
1477 * BuildSlaveSupport/built-product-archive:
1478 (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1479 differentiate between iOS device and iOS Simulator platforms.
1480 (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1481 from determineWebKitBuildDirectories() into this function so that it can be used by both
1482 determineWebKitBuildDirectories() and archiveBuiltProduct().
1483 (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1484 webkitBuildDirectoryForConfigurationAndPlatform().
1485 (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1486 we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1487 argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1488 when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1489 and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1490 for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1491 (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1492 For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1493 build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1494 LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1495 * Scripts/build-layouttestrelay:
1496 - Remove unnecessary include of Perl module POSIX.
1497 - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1498 * Scripts/build-webkit:
1499 - Invoke script build-layouttestrelay when building for iOS Simulator.
1501 2015-10-02 Brent Fulgham <bfulgham@apple.com>
1503 [Win] Unreviewed test fix.
1505 You cannot run 'run-webkit-tests' from the command line because it does not know
1506 to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1507 because they explicitly set use the 'root' argument to provide the full path to
1510 * Scripts/webkitpy/port/win.py:
1511 (WinPort._build_path): Added.
1513 2015-10-02 Alex Christensen <achristensen@webkit.org>
1515 Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1516 https://bugs.webkit.org/show_bug.cgi?id=149430
1517 rdar://problem/22742222
1519 Reviewed by Geoffrey Garen.
1521 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1522 (WTR::TestController::cocoaResetStateToConsistentValues):
1523 * WebKitTestRunner/mac/TestControllerMac.mm:
1524 (WTR::TestController::platformConfigureViewForTest):
1525 Test what happens when you disable content blockers from the SPI.
1527 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1529 [Win] Unreviewed build fix for run-api-tests
1531 * Scripts/run-api-tests:
1532 (testToolPaths): Windows run needs to specify the binary path.
1534 2015-10-01 Daniel Bates <dabates@apple.com>
1536 Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1537 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1539 Following r190424 we can now rely on webkit-build-directory to return the path to
1540 the correct configuration-specific build directory on Windows.
1542 * BuildSlaveSupport/built-product-archive:
1543 (archiveBuiltProduct):
1545 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1547 [Win] Unreviewed build fix.
1549 * Scripts/webkitdirs.pm:
1550 (setupAppleWinEnv): Use 64-bit build tools if available
1552 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1554 [Win] Fix TestWebKitAPI build under CMake.
1556 Reviewed by Alex Christensen.
1558 * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1561 2015-10-01 Brent Fulgham <bfulgham@apple.com>
1563 [Win] Fix behavior of webkit-build-directory script
1564 https://bugs.webkit.org/show_bug.cgi?id=149718
1566 Reviewed by Alex Christensen.
1568 * Scripts/webkitdirs.pm:
1569 (determineConfigurationProductDir): Do not include the binary
1570 sub-directory in the configuration product directory output.
1571 (jscProductDir): Append correct binary path for Windows build.
1572 (setPathForRunningWebKitApp): Include properly binary subdirectories.
1573 (runSafari): Update for revised productDir behavior.
1574 (runMiniBrowser): Ditto.
1576 2015-10-01 Alexey Proskuryakov <ap@apple.com>
1578 Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1579 use iOS SDK, like with all the others.
1581 * Scripts/build-webkit:
1583 2015-10-01 Daniel Bates <dabates@apple.com>
1585 Attempt to fix the iOS 9 Simulator testers
1587 Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1588 build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1589 LayoutTestRelay when building for iOS Simulator.
1591 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1592 * Scripts/build-webkit:
1594 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
1596 [GTK] Websites with invalid auth header keep loading forever
1597 https://bugs.webkit.org/show_bug.cgi?id=149710
1599 Reviewed by Martin Robinson.
1601 Add test case to check that we can authenticate sites with an
1604 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1605 (testWebViewAuthenticationEmptyRealm):
1609 2015-10-01 Alexey Proskuryakov <ap@apple.com>
1611 [Mac] Make run-api-tests work with System Integrity Protection
1612 https://bugs.webkit.org/show_bug.cgi?id=149711
1613 rdar://problem/22928202
1615 Reviewed by Dan Bernstein.
1617 * Scripts/run-api-tests:
1619 (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1621 2015-10-01 Daniel Bates <dabates@apple.com>
1623 Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1624 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1626 For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1627 For now, use the path to the top-level WebKit build directory instead of using the configuration-
1628 specific build directory.
1630 * BuildSlaveSupport/built-product-archive:
1631 (archiveBuiltProduct):
1633 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
1635 [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1636 https://bugs.webkit.org/show_bug.cgi?id=145837
1638 Reviewed by Philippe Normand.
1640 * efl/jhbuild.modules:
1641 * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1642 * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1644 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
1646 Unreviewed. Fix the iOS build after r190407.
1648 * WebKitTestRunner/ios/IOKitSPI.h:
1650 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
1652 Implement keyboard event sending for iOS in WebKitTestRunner
1653 https://bugs.webkit.org/show_bug.cgi?id=149676
1655 Reviewed by Simon Fraser.
1657 Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1658 way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1659 allows us to run code when the keyboard is shown or hidden.
1661 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1662 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1663 (WTR::UIScriptController::setDidShowKeyboardCallback):
1664 (WTR::UIScriptController::didShowKeyboardCallback):
1665 (WTR::UIScriptController::setDidHideKeyboardCallback):
1666 (WTR::UIScriptController::didHideKeyboardCallback):
1667 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1668 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1669 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1670 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1671 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1672 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1673 (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1674 the notifications that the keyboard has been raised or lowered.
1675 (-[TestRunnerWKWebView _keyboardDidShow:]):
1676 (-[TestRunnerWKWebView _keyboardDidHide:]):
1677 * WebKitTestRunner/ios/HIDEventGenerator.h:
1678 * WebKitTestRunner/ios/HIDEventGenerator.m:
1679 (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1680 (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1681 (hidUsageCodeForCharacter): Ditto.
1682 (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1683 a keyDown event in WebKit.
1684 * WebKitTestRunner/ios/IOKitSPI.h:
1685 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1687 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
1689 Unreviewed, rolling out r190399.
1691 Tests are still failing even after r190362
1695 "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1696 http://trac.webkit.org/changeset/190399
1698 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
1700 [jhbuild] switch to new upstream usrsctp library
1701 https://bugs.webkit.org/show_bug.cgi?id=149494
1703 Reviewed by Philippe Normand.
1705 * efl/jhbuild.modules:
1706 * gtk/jhbuild.modules:
1708 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
1710 Unreviewed. Unskip GTK+ user media unit tests after r190362.
1712 They should pass now.
1714 * Scripts/run-gtk-tests:
1717 2015-09-30 Daniel Bates <dabates@apple.com>
1719 Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1720 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1722 * BuildSlaveSupport/built-product-archive:
1723 (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1724 (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1726 2015-09-30 Daniel Bates <dabates@apple.com>
1728 Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1729 (https://bugs.webkit.org/show_bug.cgi?id=149695)
1731 Actually, we need to pass --configuration to script webkit-build-directory to have
1732 it return the path to the configuration-specific build directory.
1734 * BuildSlaveSupport/built-product-archive:
1735 (determineWebKitBuildDirectories):
1737 2015-09-30 Daniel Bates <dabates@apple.com>
1739 built-product-archive archives incorrect build directory for iOS port
1740 https://bugs.webkit.org/show_bug.cgi?id=149695
1742 Reviewed by Darin Adler.
1744 Fixes an issue where the script built-product-archive archives a non-existent
1745 build directory for the iOS port. Without loss of generality, the script assumes
1746 the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1747 But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1749 Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1750 to determine the top-level build directory and computes the configuration-specific
1751 build directory to be the concatenation of the the top-level build directory and
1752 the configuration (e.g. Release). This is incorrect. Instead we should call
1753 webkit-build-directory omitting the flag --top-level to compute the path to the
1754 configuration-specific build directory.
1756 * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1757 (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1758 its purpose and added global variable _configurationBuildDirectory to store the path
1759 to the configuration-specific build directory. Ensure that we have a non-empty string
1760 for both the top-level and configuration-specific build directories.
1761 (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1762 Compute the configuration-specific build directory and store it in the global variable
1763 _configurationBuildDirectory.
1764 (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1765 (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1767 (determineWebKitBuildDirectory): Deleted.
1769 2015-09-30 Hunseop Jeong <hs85.jeong@samsung.com>
1771 [EFL] css3/device-adapt/* tests failed after r190335.
1772 https://bugs.webkit.org/show_bug.cgi?id=149655
1774 Reviewed by Simon Fraser.
1776 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1777 overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1779 * WebKitTestRunner/efl/TestControllerEfl.cpp:
1780 (WTR::shouldUseFixedLayout):
1782 2015-09-30 Dewei Zhu <dewei_zhu@apple.com>
1784 Extend JetStream timeout for slow devices.
1786 Reviewed by Chris Dumez.
1788 Extend JetStream timeout to 20 minutes.
1790 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1792 2015-09-30 Daniel Bates <dabates@apple.com>
1794 Rename iOS builders/testers to include version
1795 https://bugs.webkit.org/show_bug.cgi?id=149685
1797 Reviewed by Simon Fraser.
1799 Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1800 make it clear to a reader the version of iOS these builders/testers are using.
1802 * BuildSlaveSupport/build.webkit.org-config/config.json:
1803 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1805 2015-09-30 Daniel Bates <dabates@apple.com>
1807 Add iOS criterion for triggering a build
1808 https://bugs.webkit.org/show_bug.cgi?id=149679
1810 Rubber-stamped by Alexey Proskuryakov.
1812 First pass at defining criterion for triggering an iOS build.
1814 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1815 (_should_file_trigger_build):
1816 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1818 (ShouldBuildTest.test_should_build):
1820 2015-09-29 Simon Fraser <simon.fraser@apple.com>
1822 [iOS] Allow tests to generate user gestures for UI testing
1823 https://bugs.webkit.org/show_bug.cgi?id=149653
1825 Reviewed by Tim Horton.
1827 Expose functionality in UIScriptController to allow for testing single- and double-tap,
1828 and to listen for completion of scrolling and zooming in the WKWebView.
1830 Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1831 which hides the complexity of creating these events. Event dispatch is asynchronous.
1832 We detect when the last event has been handled by dispatching a vendor-specific event,
1833 which is detected via -_handleHIDEvent: in our UIApplication subclass.
1835 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1836 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1837 for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1838 single and double taps.
1839 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1840 (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1841 Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1842 (UIScriptContext::unregisterCallback):
1843 (UIScriptContext::callbackWithID):
1844 (UIScriptContext::fireCallback):
1845 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1846 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1847 (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1848 (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1849 (WTR::UIScriptController::setDidEndZoomingCallback):
1850 (WTR::UIScriptController::didEndZoomingCallback):
1851 (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1852 (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1853 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1854 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1855 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1856 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1857 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1858 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1859 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1860 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1861 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1862 (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1863 * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1864 * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1866 (calculateNextLocation):
1868 (+[HIDEventGenerator sharedHIDEventGenerator]):
1869 (+[HIDEventGenerator nextEventCallbackID]):
1870 (-[HIDEventGenerator init]):
1871 (-[HIDEventGenerator _createIOHIDEventType:]):
1872 (-[HIDEventGenerator _sendHIDEvent:]):
1873 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1874 (-[HIDEventGenerator _updateTouchPoints:count:]):
1875 (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1876 (-[HIDEventGenerator touchDown:touchCount:]):
1877 (-[HIDEventGenerator touchDown:]):
1878 (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1879 (-[HIDEventGenerator liftUp:touchCount:]):
1880 (-[HIDEventGenerator liftUp:]):
1881 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1882 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1883 (-[HIDEventGenerator tap:completionBlock:]):
1884 (-[HIDEventGenerator doubleTap:completionBlock:]):
1885 (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1886 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1887 (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1888 (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1889 (-[HIDEventGenerator markerEventReceived:]):
1890 * WebKitTestRunner/ios/IOKitSPI.h: Added.
1891 * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1892 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1893 (WTR::globalToContentCoordinates):
1894 (WTR::UIScriptController::singleTapAtPoint):
1895 (WTR::UIScriptController::doubleTapAtPoint):
1896 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1897 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1898 * WebKitTestRunner/ios/mainIOS.mm:
1899 (-[WebKitTestRunnerApp _handleHIDEvent:]):
1901 2015-09-30 Dana Burkart <dburkart@apple.com>
1903 git-add-reviewer should trim trailing spaces/newlines
1904 https://bugs.webkit.org/show_bug.cgi?id=149513
1906 Reviewed by Darin Adler.
1908 * Scripts/git-add-reviewer:
1911 2015-09-30 Eric Carlson <eric.carlson@apple.com>
1913 REGRESSION(r190262): User media unit test failures after r190262
1914 https://bugs.webkit.org/show_bug.cgi?id=149580
1916 Reviewed by Darin Adler.
1918 * WebKitTestRunner/TestController.cpp:
1919 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1920 order to WKUserMediaPermissionRequestAllow.
1922 2015-09-30 Daniel Bates <dabates@apple.com>
1924 Add iOS builders and testers
1925 https://bugs.webkit.org/show_bug.cgi?id=149549
1927 Reviewed by Alexey Proskuryakov.
1929 Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1930 builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1932 * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1933 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1935 2015-09-30 Timothy Hatcher <timothy@apple.com>
1937 Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1938 https://bugs.webkit.org/show_bug.cgi?id=149674
1940 Reviewed by Lucas Forschler.
1942 * WebKitLauncher/WebKitLauncher.entitlements: Added.
1943 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1945 2015-09-30 Jason Marcell <jmarcell@apple.com>
1947 BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1948 have an associated trac instance.
1949 https://bugs.webkit.org/show_bug.cgi?id=149673
1951 Reviewed by Alexey Proskuryakov.
1953 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1954 (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1955 have an associated trac instance.
1957 2015-09-30 Daniel Bates <dabates@apple.com>
1959 Prioritize testing latest build request on iOS test bots
1960 https://bugs.webkit.org/show_bug.cgi?id=149669
1962 Reviewed by Darin Adler.
1964 We should prioritize testing of the latest build request on the iOS test bots
1965 as we do for Mac and Windows test bots.
1967 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1968 (loadBuilderConfig):
1970 2015-09-30 Daniel Bates <dabates@apple.com>
1972 Add buildbot category for iOS builders and testers
1973 https://bugs.webkit.org/show_bug.cgi?id=149667
1975 Reviewed by Darin Adler.
1977 Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1978 for iOS to the build.webkit.org home page.
1980 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1981 (loadBuilderConfig):
1982 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1984 2015-09-30 Daniel Bates <dabates@apple.com>
1986 Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1987 (https://bugs.webkit.org/show_bug.cgi?id=149539)
1989 I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1990 in <http://trac.webkit.org/changeset/190351>.
1992 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1993 (CompileWebKit.start):
1995 2015-09-30 Daniel Bates <dabates@apple.com>
1997 Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1998 (https://bugs.webkit.org/show_bug.cgi?id=149539)
2000 {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2001 respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2003 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2004 (CompileWebKit.start):
2006 2015-09-30 Lucas Forschler <lforschler@apple.com>
2008 bot210 was configured for a queue instead of bot126.
2010 Unreviewed config.json fix.
2012 * BuildSlaveSupport/build.webkit.org-config/config.json:
2014 2015-09-30 Lucas Forschler <lforschler@apple.com>
2016 Bring El Capitan buildbot infrastructure online.
2017 https://bugs.webkit.org/show_bug.cgi?id=149605
2019 Reviewed by Darin Adler.
2021 * BuildSlaveSupport/build.webkit.org-config/config.json:
2023 2015-09-30 Tomas Popela <tpopela@redhat.com>
2025 [GTK] Deprecation warnings in DOMNodeTest
2026 https://bugs.webkit.org/show_bug.cgi?id=149663
2028 After the webkit_dom_document_get_elements_by_tag_name deprecation we
2029 need to update the tests to use webkit_dom_document_query_selector_all
2030 to avoid compilation warnings.
2032 Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2033 (the suggested replacement for the deprecated function).
2035 Reviewed by Carlos Garcia Campos.
2037 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2038 (WebKitDOMNodeTest::testTagNamesNodeList):
2039 (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2041 (WebKitDOMNodeTest::testTagNames): Deleted.
2042 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2043 (prepareDOMForTagNamesTests):
2044 (testWebKitDOMNodeTagNamesNodeList):
2045 (testWebKitDOMNodeTagNamesHTMLCollection):
2047 (testWebKitDOMNodeTagNames): Deleted.
2049 2015-09-29 Simon Fraser <simon.fraser@apple.com>
2051 WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2052 https://bugs.webkit.org/show_bug.cgi?id=149650
2054 Reviewed by Tim Horton.
2056 TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2057 looks at the file path, and not the custom options that come from file comments.
2059 Fix by computing TestOptions before making the TestInvocation, and setting them
2060 as const TestInvocation data. This meant changing various call sites to take
2061 the std::string pathOrURL, rather than the TestInvocation itself.
2063 Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2065 * WebKitTestRunner/CMakeLists.txt:
2066 * WebKitTestRunner/TestController.cpp:
2067 (WTR::TestController::ensureViewSupportsOptionsForTest):
2069 (WTR::createTestURL):
2070 (WTR::updateTestOptionsFromTestHeader):
2071 (WTR::TestController::testOptionsForTest):
2072 (WTR::TestController::updateWebViewSizeForTest):
2073 (WTR::TestController::updateWindowScaleForTest):
2074 (WTR::TestController::runTest):
2075 * WebKitTestRunner/TestController.h:
2076 * WebKitTestRunner/TestInvocation.cpp:
2077 (WTR::TestInvocation::TestInvocation):
2078 (WTR::TestInvocation::invoke):
2079 (WTR::createWKURL): Deleted.
2080 (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2081 (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2082 * WebKitTestRunner/TestInvocation.h:
2083 (WTR::TestInvocation::options):
2084 * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2085 (WTR::pathContains):
2086 (WTR::shouldMakeViewportFlexible):
2087 (WTR::shouldUseFixedLayout):
2088 (WTR::isSVGTestPath):
2089 (WTR::isHiDPITestPath):
2090 (WTR::TestOptions::TestOptions):
2091 * WebKitTestRunner/TestOptions.h:
2092 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2093 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2094 (WTR::pathContains):
2095 (WTR::shouldUseFixedLayout):
2096 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2097 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2098 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2099 * WebKitTestRunner/ios/TestControllerIOS.mm:
2100 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2101 * WebKitTestRunner/mac/TestControllerMac.mm:
2102 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2104 2015-09-29 Aakash Jain <aakash_jain@apple.com>
2106 Flakiness dashboard should support OS X El Capitan
2107 https://bugs.webkit.org/show_bug.cgi?id=149648
2109 Reviewed by Alexey Proskuryakov.
2111 * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
2112 difference between new appscale and old Google App Engine implementation.
2113 * TestResultServer/app.yaml: Same.
2114 * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2116 2015-09-29 Daniel Bates <dabates@apple.com>
2118 configure-xcode-for-ios-development does not work with Xcode 7
2119 https://bugs.webkit.org/show_bug.cgi?id=149640
2121 Reviewed by Alexey Proskuryakov.
2123 When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2124 because it cannot find the Xcode specification files for iOS simulator and device. These
2125 files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2126 relevant definitions to the Xcode 7 specification files directly as opposed to creating
2127 new specification files with the added definitions (as we did in older versions of Xcode)
2128 in order for Xcode 7 to honor these definitions.
2130 * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2131 (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2132 (updateXcode7SpecificationFile): Added.
2133 (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2134 (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2135 appropriate success message.
2136 (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2137 (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2138 (createXcodeSpecificationFromSpecificationAndId): Deleted.
2140 2015-09-29 Brent Fulgham <bfulgham@apple.com>
2142 [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2143 https://bugs.webkit.org/show_bug.cgi?id=149639
2145 Reviewed by Alex Christensen.
2147 * Scripts/VCSUtils.pm:
2148 (exitStatus): Use 'isWindows()' method.
2149 (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2150 an error. This method could probably just go away.
2151 (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2152 always changing to Unix style.
2153 (unixPath): Added. Needed so Windows can always show a Unix path in the
2155 (changeLogName): Work around the fact that 'getpwuid' is not available on
2156 a pure Windows build of Perl.
2157 * Scripts/prepare-ChangeLog:
2158 (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2160 (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2161 support using arrays for 'open' arguments.
2162 (resolveChangeLogsPath): Ditto.
2163 (resolveConflictedChangeLogs): Use new helper functions.
2164 (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2165 (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2166 quotes. Unix systems are happy either way.
2167 (statusCommand): Ditto.
2168 * Scripts/webkitdirs.pm:
2169 (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2171 2015-09-29 Brent Fulgham <bfulgham@apple.com>
2173 [Win] Unreviewed 64-bit build fix after switch to CMake.
2175 * Scripts/webkitdirs.pm:
2176 (determineIsWin64FromArchitecture): Added.
2178 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
2180 printing does not use minimum page zoom factor
2181 https://bugs.webkit.org/show_bug.cgi?id=108507
2183 Reviewed by Darin Adler.
2185 WebKitTestRunner always takes the snapshots from the UI process
2186 (expect for IOS), so in the case of printing, the layout in the
2187 web view is not the expected one. When printing, we need to take
2188 the snapshot in the web process and ensure it's rendered with a
2191 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2192 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2193 kWKSnapshotOptionsPrinting option to
2194 WKBundlePageCreateSnapshotWithOptions() when printing.
2196 2015-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
2198 [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2199 https://bugs.webkit.org/show_bug.cgi?id=149595
2201 Reviewed by Tim Horton.
2203 All ports except IOS implement
2204 PlatformWebView::windowSnapshotImage() to generate the snapshot
2205 for the pixel tests in the UI process. But we are still generating
2206 a snapshot for pixel tests in the Web process too, that is passed
2207 to the UI process but ignored.
2208 Whether a pixel result is needed or not, is only known by the web
2209 process depending on whether the test called dumpAsText with
2210 dumpPixels == true or not. Since the pixels are now dump in the UI
2211 process, we need to pass that information to the UI process when
2212 the test is done. For that we set a PixelResultIsPending bool
2213 parameter to the Done message, and we only add the PixelResult
2214 when UI process doesn't need to generate the pixels dump.
2216 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2217 (WTR::InjectedBundle::didReceiveMessageToPage): Set
2218 m_pixelResultIsPending to false on reset.
2219 (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2220 Done message, and set the PixelResult if m_pixelResultIsPending is false.
2221 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2222 (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2223 (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2224 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2225 (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2227 * WebKitTestRunner/TestInvocation.cpp:
2228 (WTR::TestInvocation::dumpResults): Use either the pixel result
2229 from the web process or generate a pixel result from the web view
2231 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2232 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2233 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2234 is created by the caller now, but the CG implementation needs to
2235 know if it's a Web or UI process snapshot.
2236 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2237 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2238 cairo surface for the given image.
2239 * WebKitTestRunner/cg/TestInvocationCG.cpp:
2240 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2241 CGContext for the given image.
2243 2015-09-28 Dean Johnson <dean_johnson@apple.com>
2245 Fix JS errors on dashboard metrics page
2246 https://bugs.webkit.org/show_bug.cgi?id=149608
2248 Reviewed by Alexey Proskuryakov.
2250 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2251 (initPlatformsByFamily):
2252 (updateHiddenPlatforms):
2253 (parsePlatformFamily): Deleted.
2254 (updateToggleButtons): Deleted.
2255 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2256 (updateHiddenPlatforms): Added to remove errors.
2257 (initPlatformsByFamily): Added to remove errors.
2258 (unhiddenQueues): Updated to use Settings.
2259 (documentReady): Added logic to add toggle buttons to the settings menu.
2260 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2261 (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2262 MetricsMain.js to Settings.
2263 (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2264 MetricsMain.js to Settings.
2265 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2266 (QueueView.prototype._updateHiddenState): Updated to use Settings.
2268 2015-09-28 Aakash Jain <aakash_jain@apple.com>
2270 Appscale query fails because of missing index
2271 https://bugs.webkit.org/show_bug.cgi?id=149609
2273 Reviewed by Darin Adler.
2275 * QueueStatusServer/index.yaml: Added the required index.
2277 2015-09-28 Brent Fulgham <bfulgham@apple.com>
2279 [Win] Fix the 64-bit build after switch to cmake.
2281 Reviewed by Alex Christensen.
2283 * Scripts/webkitdirs.pm:
2284 (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2287 2015-09-28 Brent Fulgham <bfulgham@apple.com>
2289 [Win] Allow Windows to run test-webkitpy without Cygwin
2290 https://bugs.webkit.org/show_bug.cgi?id=149602
2292 Reviewed by Alex Christensen.
2294 These changes mostly shift from hard-coded paths using UNIX-style
2295 separators to Python's "os.path.join" syntax that uses the correct
2296 path separator for each platform.
2298 * Scripts/webkitpy/common/system/path.py:
2299 (cygpath): Don't pass paths through Cygpath on native Windows.
2300 * Scripts/webkitpy/port/win.py:
2301 (WinPort._path_to_apache): Use os.path.join.
2302 (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2303 in 64-bit environments).
2304 * Scripts/webkitpy/style/checker.py: Use os.path.join.
2305 * Scripts/webkitpy/style/checker_unittest.py:
2306 (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2307 (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2308 (GlobalVariablesTest): Ditto.
2309 (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2310 (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2311 (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2312 (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2313 (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2314 (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2315 (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2316 (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2317 (StyleProcessor_CodeCoverageTest): Ditto.
2318 (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2319 (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2320 (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2321 * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2322 manual string concatenation of paths.
2324 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
2326 Add bugzilla addresses of committers to contributors.json
2327 https://bugs.webkit.org/show_bug.cgi?id=149520
2329 Reviewed by Darin Adler.
2331 * Scripts/webkitpy/common/config/contributors.json:
2333 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
2335 validate-committer-lists -b shouldn't need edituser privileges
2336 https://bugs.webkit.org/show_bug.cgi?id=149519
2338 Reviewed by Darin Adler.
2340 * Scripts/validate-committer-lists:
2341 (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2342 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2343 (BugzillaQueries.is_invalid_bugzilla_email):
2344 (BugzillaQueries): Deleted.
2345 (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2347 2015-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
2349 Unreviewed. Gardening: skip media stream tests failing after r190262.
2351 * Scripts/run-gtk-tests:
2354 2015-09-25 Alexey Proskuryakov <ap@apple.com>
2356 [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2357 https://bugs.webkit.org/show_bug.cgi?id=149571
2359 Reviewed by Dan Bernstein.
2361 Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
2363 * DumpRenderTree/mac/Configurations/Base.xcconfig:
2364 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2365 * LayoutTestRelay/Configurations/Base.xcconfig:
2366 * MiniBrowser/Configurations/Base.xcconfig:
2367 * MiniBrowser/Configurations/DebugRelease.xcconfig:
2368 * TestWebKitAPI/Configurations/Base.xcconfig:
2369 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2370 * WebEditingTester/Configurations/Base.xcconfig:
2371 * WebEditingTester/Configurations/DebugRelease.xcconfig:
2372 * WebKitTestRunner/Configurations/Base.xcconfig:
2373 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2374 * WebKitTestRunner/iOS.xcconfig: Removed.
2376 2015-09-25 Eric Carlson <eric.carlson@apple.com>
2378 Clean up user media request internal API
2379 https://bugs.webkit.org/show_bug.cgi?id=149527
2381 Reviewed by Tim Horton.
2383 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2384 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2386 * WebKitTestRunner/TestController.cpp:
2387 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2389 2015-09-25 Simon Fraser <simon.fraser@apple.com>
2391 [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2392 https://bugs.webkit.org/show_bug.cgi?id=149577
2394 Reviewed by Tim Horton.
2396 When calling testRunner.runUIScript() from a page load event, the script could run
2397 in the UI process before the current remote layer tree transaction had been handled
2398 there. This meant that runUIScript() could query state which was about to change.
2400 Fix by delaying the execution of the UI script until a layer tree transaction has
2401 been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2403 * WebKitTestRunner/TestInvocation.cpp:
2404 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2405 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2406 * WebKitTestRunner/TestInvocation.h:
2408 2015-09-25 Alexey Proskuryakov <ap@apple.com>
2410 [Mac] Media tests start to time out after a few days of bot uptime
2411 https://bugs.webkit.org/show_bug.cgi?id=149468
2413 Reviewed by Darin Adler.
2415 Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2416 as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2417 all temporary and cache files go to a custom location.
2419 * Scripts/webkitpy/port/base.py:
2420 * Scripts/webkitpy/port/driver.py:
2421 * Scripts/webkitpy/port/mac.py:
2422 * Scripts/webkitpy/port/win.py:
2423 (WinPort._driver_tempdir_for_environment): Deleted unused function.
2425 2015-09-25 Dan Bernstein <mitz@apple.com>
2427 Removed MiniBrowser.entitlements.
2429 Rubber-stamped by Anders Carlsson.
2431 The entitlements weren’t used anyway.
2433 * MiniBrowser/MiniBrowser.entitlements: Removed.
2434 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2436 2015-09-24 Daniel Bates <dabates@apple.com>
2438 Add WebKitSystemInterface for iOS 9.0
2439 https://bugs.webkit.org/show_bug.cgi?id=149550
2441 Rubber-stamped by Alexey Proskuryakov.
2443 * Scripts/copy-webkitlibraries-to-product-directory:
2445 2015-09-24 Daniel Bates <dabates@apple.com>
2447 Support building for arbitrary architectures
2448 https://bugs.webkit.org/show_bug.cgi?id=149539
2450 Reviewed by Alexey Proskuryakov.
2452 Teach buildbot to pass the architectures associated with the builder to build-webkit
2453 when building on OS X and iOS. As a side effect of this change we now support building
2454 universal binaries when multiples architectures are specified.
2456 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2457 (CompileWebKit.start):
2459 2015-09-24 Daniel Bates <dabates@apple.com>
2461 Fix the build after <http://trac.webkit.org/changeset/190212>
2462 (http://trac.webkit.org/changeset/190212)
2464 I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2466 * BuildSlaveSupport/built-product-archive:
2469 2015-09-24 Daniel Bates <dabates@apple.com>
2471 Support running unit tests on iOS Simulator test bot
2472 https://bugs.webkit.org/show_bug.cgi?id=149536
2474 Reviewed by Alexey Proskuryakov.
2476 Implements support for running unit tests on a iOS test bot. At the time of writing,
2477 the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2479 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2480 (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2481 (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2483 2015-09-24 Daniel Bates <dabates@apple.com>
2485 Add support infrastructure for OpenSource iOS builders and testers
2486 https://bugs.webkit.org/show_bug.cgi?id=149534
2488 Reviewed by Darin Adler.
2490 Towards setting up OpenSource iOS build bots, teach buildbot and its support
2493 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2494 (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2495 --ios-simulator or --device for a builder/tester whose full platform name begins with
2496 "ios-simulator" or "ios", respectively.
2497 (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2498 * BuildSlaveSupport/built-product-archive:
2499 (main): Pass the full platform name to determineWebKitBuildDirectory().
2500 (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2501 command line flag when building for iOS.
2502 (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2503 parameter fullPlatform. This parameter was originally added in r125066 to support the
2504 Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2505 (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2506 * BuildSlaveSupport/clean-build:
2507 (main): Call script webkit-build-directory with the appropriate command line flag when
2509 * BuildSlaveSupport/delete-stale-build-files:
2510 (main): Use the same logic for iOS as we do for Mac.
2511 (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2512 flag when building for iOS.
2513 * BuildSlaveSupport/test-result-archive:
2514 (archiveTestResults): Use the same logic for iOS as we do for Mac.
2516 2015-09-24 Daniel Bates <dabates@apple.com>
2518 Remove Chromium-specific changes to script built-product-archive
2519 https://bugs.webkit.org/show_bug.cgi?id=149530
2521 Rubber-stamped by Csaba Osztrogonác.
2523 Reverts changes made in r113074 and r113067 to support Chromium testers. The
2524 Chromium code has long since been removed from the OpenSource WebKit Project.
2526 * BuildSlaveSupport/built-product-archive:
2527 (createZipManually):
2529 (archiveBuiltProduct):
2531 2015-09-24 Dan Bernstein <mitz@apple.com>
2535 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2537 2015-09-24 Mark Lam <mark.lam@apple.com>
2539 Unreviewed. Make Lucas Forschler a WebKit reviewer.
2541 * Scripts/webkitpy/common/config/contributors.json:
2543 2015-09-24 Carlos Garcia Campos <cgarcia@igalia.com>
2545 Unreviewed. Fix GObject DOM API breaks after r190120.
2547 Bring back code removed in r169931 to handle documentation of
2551 (WebKitDOMDocGenerator):
2552 (WebKitDOMDocGenerator.write_deleted_classes):
2553 (WebKitDOMDocGenerator.generate):
2554 (write_deleted_classes):
2555 (WebKitDOMDocGeneratorSections._deleted_class):
2556 (WebKitDOMDocGeneratorSections._deleted_class.in):
2557 (WebKitDOMDocGeneratorSections.write_deleted_classes):
2558 (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2560 2015-09-23 Myles C. Maxfield <mmaxfield@apple.com>
2562 [Cocoa] [Font Features] Implement font-variant-*
2563 https://bugs.webkit.org/show_bug.cgi?id=148413
2565 Reviewed by Darin Adler.
2567 Update test font to use "lnum" feature.
2569 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2570 (Generator::appendGSUBTable):
2572 2015-09-22 Andy Estes <aestes@apple.com>
2574 ContentFiltering.AllowDownloadAfterAddData is very flaky
2575 https://bugs.webkit.org/show_bug.cgi?id=148885
2576 <rdar://problem/22729563>
2578 Reviewed by Alexey Proskuryakov.
2580 The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2581 but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2582 -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2584 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2587 2015-09-22 Alexey Proskuryakov <ap@apple.com>
2589 Mavericks: Media tests start to time out after a few days of bot uptime
2590 https://bugs.webkit.org/show_bug.cgi?id=149468
2592 Reviewed by Chris Dumez.
2594 * Scripts/webkitpy/port/base.py:
2595 * Scripts/webkitpy/port/driver.py:
2596 * Scripts/webkitpy/port/mac.py:
2598 2015-09-22 Nan Wang <n_wang@apple.com>
2600 Unreviewed, add myself to the committers list.
2602 * Scripts/webkitpy/common/config/contributors.json:
2604 2015-09-21 Simon Fraser <simon.fraser@apple.com>
2606 Remove 'nullable' to fix older iOS builds.
2608 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2609 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2611 2015-09-21 Brent Fulgham <bfulgham@apple.com>
2613 [Win] Show tiled drawing debug overlay on Windows
2614 https://bugs.webkit.org/show_bug.cgi?id=149426
2616 Reviewed by Dean Jackson.
2618 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2619 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2620 * MiniBrowser/win/Common.cpp:
2621 (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2623 * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2625 2015-09-21 Brent Fulgham <bfulgham@apple.com>
2627 [Win] Use command-line argument to launch in regular or High DPI mode.
2628 https://bugs.webkit.org/show_bug.cgi?id=149417
2630 Reviewed by Dean Jackson.
2632 * MiniBrowser/win/Common.cpp:
2633 (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2634 very start of execution, before the MiniBrowser.dll is loaded.
2635 * win/DLLLauncher/DLLLauncherMain.cpp:
2636 (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2637 present. On WinCairo, always use High DPI.
2639 2015-09-21 Ryosuke Niwa <rniwa@webkit.org>
2641 32-bit Mac build fix attempt after r190065.
2643 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2645 2015-09-21 Alexey Proskuryakov <ap@apple.com>
2647 [OS X] Update for Xcode 7.0 on Yosemite
2648 https://bugs.webkit.org/show_bug.cgi?id=149389
2650 Reviewed by Dan Bernstein.
2652 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2653 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2654 Removed unneeded declarations - conforming to a protocol is sufficient.
2656 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2657 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2658 Changed the definitions to be compiled whenever the SDK requires it (so we will have
2659 dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2661 2015-09-21 Simon Fraser <simon.fraser@apple.com>
2663 Add the ability for tests to run script in the UI process in WebKitTestRunner
2664 https://bugs.webkit.org/show_bug.cgi?id=149356
2666 Reviewed by Tim Horton.
2668 This change adds testRunner.runUIScript(script, callback), which allows a test
2669 to execute script in a JSContext which runs in the UI process. That context
2670 has bindings exposed through the UIScriptController interface; currently one test
2671 function, and some iOS-specific functions are included. UIScriptController can be
2672 async with a callback, and runUIScript() itself is asynchronous. When the UI
2673 script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2674 is a string passed back to the web process, and given to the runUIScript()
2677 Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2679 * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2680 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2681 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2682 (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2683 complete, call back into TestRunner.
2684 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2685 (WTR::nextUIScriptCallbackID):
2686 (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2687 (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2688 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2689 * WebKitTestRunner/PlatformWebView.h:
2690 * WebKitTestRunner/TestController.cpp:
2691 (WTR::updateTestOptionsFromTestHeader):
2692 (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2693 (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2694 * WebKitTestRunner/TestInvocation.cpp:
2695 (WTR::TestInvocation::shouldUseFixedLayout):
2696 (WTR::TestInvocation::shouldUseThreadedScrolling):
2697 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2698 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2699 (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2700 (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2701 * WebKitTestRunner/TestInvocation.h:
2702 * WebKitTestRunner/TestOptions.h:
2703 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2704 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2705 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2706 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2707 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2708 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2709 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2710 (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2711 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2712 (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2713 * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2714 (WTR::UIScriptController::doAsyncTask):
2715 (WTR::UIScriptController::zoomToScale):
2716 (WTR::UIScriptController::zoomScale):
2717 (WTR::UIScriptController::minimumZoomScale):
2718 (WTR::UIScriptController::maximumZoomScale):
2719 (WTR::UIScriptController::contentVisibleRect):
2720 * WebKitTestRunner/mac/EventSenderProxy.mm:
2721 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2722 (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2723 * WebKitTestRunner/mac/TestControllerMac.mm:
2724 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2725 (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2726 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2727 * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2728 (UIScriptContext::UIScriptContext):
2729 (UIScriptContext::~UIScriptContext):
2730 (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2731 asynchronous, call the callback.
2732 (UIScriptContext::nextTaskCallbackID):
2733 (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2734 that has a callback). Has to store the callbackID of the script, so code called from the completion
2735 callback knows which UI script invoked it.
2736 (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2737 (UIScriptContext::uiScriptComplete):
2738 (UIScriptContext::objectFromRect): Make a JS object from a rect.
2739 * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2740 (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2741 * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2742 (WTR::UIScriptController::UIScriptController):
2743 (WTR::UIScriptController::makeWindowObject):
2744 (WTR::UIScriptController::wrapperClass):
2745 (WTR::UIScriptController::doAsyncTask):
2746 (WTR::UIScriptController::zoomToScale):
2747 (WTR::UIScriptController::zoomScale):
2748 (WTR::UIScriptController::minimumZoomScale):
2749 (WTR::UIScriptController::maximumZoomScale):
2750 (WTR::UIScriptController::contentVisibleRect):
2751 (WTR::UIScriptController::uiScriptComplete):
2752 * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2753 (WTR::UIScriptController::create):
2754 * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2756 2015-09-21 Tim Horton <timothy_horton@apple.com>
2758 Turn on threaded scrolling by default in the tests
2759 https://bugs.webkit.org/show_bug.cgi?id=149377
2761 Reviewed by Simon Fraser.
2763 * WebKitTestRunner/mac/TestControllerMac.mm:
2764 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2765 (WTR::shouldUseThreadedScrolling): Deleted.
2766 Turn on threaded scrolling by default.
2768 2015-09-21 Carlos Garcia Campos <cgarcia@igalia.com>
2770 [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2771 https://bugs.webkit.org/show_bug.cgi?id=149252
2773 Reviewed by Darin Adler.
2775 In case of glib tests the test runner notifies about tests
2776 crashing, but for google tests we don't get any feedback, which
2777 means that in case of a test crashing we get a list of **PASS**
2778 messages and at the summary we are notified that the test suite
2779 has failed, but it's impossible to know which test cases have failed.
2781 * Scripts/run-gtk-tests:
2782 (TestRunner._run_google_test): Add a **CRASH** message if test
2785 2015-09-20 Alexey Proskuryakov <ap@apple.com>
2787 WebKitTestRunner can leak user content script results between tests
2788 https://bugs.webkit.org/show_bug.cgi?id=149391
2790 Reviewed by Sam Weinig.
2792 Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2793 about:blank, and thus about:blank doesn't have unintended side effects.
2795 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2796 (WTR::InjectedBundle::beginTesting):
2797 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2798 (WTR::InjectedBundlePage::resetAfterTest):
2800 2015-09-20 Alexey Proskuryakov <ap@apple.com>
2802 [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2803 https://bugs.webkit.org/show_bug.cgi?id=149384
2805 Reviewed by Chris Fleizach.
2807 * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2808 (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2809 (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2810 regardless of whether someone else holds a reference (we also call -stopListening in
2813 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2814 (AccessibilityController::platformResetToConsistentState):
2815 (AccessibilityController::addNotificationListener):
2818 2015-09-20 Youenn Fablet <youenn.fablet@crf.canon.fr>
2820 Remove XHR_TIMEOUT compilation guard
2821 https://bugs.webkit.org/show_bug.cgi?id=149260
2823 Reviewed by Benjamin Poulain.
2825 * Scripts/webkitperl/FeatureList.pm:
2827 2015-09-19 Dan Bernstein <mitz@apple.com>
2829 Attempted build fix.
2831 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2833 2015-09-18 Commit Queue <commit-queue@webkit.org>
2835 Unreviewed, rolling out r189908.
2836 https://bugs.webkit.org/show_bug.cgi?id=149368
2838 Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2842 "printing does not use minimum page zoom factor"
2843 https://bugs.webkit.org/show_bug.cgi?id=108507
2844 http://trac.webkit.org/changeset/189908
2846 2015-09-18 Andy Estes <aestes@apple.com>
2848 [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2849 https://bugs.webkit.org/show_bug.cgi?id=149360
2851 Reviewed by Tim Horton.
2855 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2856 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2857 (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2858 (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2859 (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2861 * TestWebKitAPI/ios/pages.pages: Added.
2863 2015-09-18 Nan Wang <n_wang@apple.com>
2865 AX: Implement ARIA 1.1 @aria-current on iOS
2866 https://bugs.webkit.org/show_bug.cgi?id=149297
2868 Reviewed by Chris Fleizach.
2870 Added support to test aria-current on iOS.
2872 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2873 (AccessibilityUIElement::stringAttributeValue):
2874 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2875 (WTR::AccessibilityUIElement::stringAttributeValue):
2877 2015-09-18 Alexey Proskuryakov <ap@apple.com>
2879 iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2880 https://bugs.webkit.org/show_bug.cgi?id=149352
2882 Reviewed by Simon Fraser.
2884 * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2885 m_context can be null. This may indicate a bug in webkitpy too, but
2886 WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2887 wrong with opening and immediately closing it.
2889 2015-09-18 Daniel Bates <dabates@apple.com>
2891 isGitSVNDirectory() returns true when Git is not installed
2892 https://bugs.webkit.org/show_bug.cgi?id=149351
2894 Reviewed by Alexey Proskuryakov.
2896 Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2897 Git is not installed on the machine.
2899 * Scripts/VCSUtils.pm:
2900 (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2901 status code 0 (success).
2903 2015-09-18 Alex Christensen <achristensen@webkit.org>
2905 Prevent build-webkit from building four times on Windows
2906 https://bugs.webkit.org/show_bug.cgi?id=149336
2908 Reviewed by Brent Fulgham.
2910 * Scripts/build-webkit:
2911 Move the Windows code out of the for loop iterating over each subdirectory to be build.
2912 They're built all at once.
2913 * Scripts/webkitdirs.pm:
2914 (buildVisualStudioProject):
2915 (cmakeGeneratedBuildfile):
2916 Don't generate the Visual Studio solution if it already exists.
2917 It will run CMake again if necessary.
2919 2015-09-17 Simon Fraser <simon.fraser@apple.com>
2921 [iOS WK2] WTR fails to set the key window in the UIKit sense
2922 https://bugs.webkit.org/show_bug.cgi?id=149325
2924 Reviewed by Tim Horton.
2926 -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2927 This causes UIKit to bypass code that actually sets the key window, resulting in
2928 [UIAppliation sharedApplication].keyWindow always being nil.
2930 Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2931 -[WebKitTestRunnerWindow isKeyWindow] call super.
2933 * WebKitTestRunner/PlatformWebView.h:
2934 (WTR::PlatformWebView::setWindowIsKey): Deleted.
2935 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2936 (WTR::PlatformWebView::setWindowIsKey):
2937 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2938 (WTR::PlatformWebView::setWindowIsKey):
2939 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2940 (-[WebKitTestRunnerWindow isKeyWindow]):
2941 (WTR::PlatformWebView::PlatformWebView):
2942 (WTR::PlatformWebView::~PlatformWebView):
2943 (WTR::PlatformWebView::setWindowIsKey):
2944 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2945 (WTR::PlatformWebView::setWindowIsKey):
2947 2015-09-17 Simon Fraser <simon.fraser@apple.com>
2949 [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2950 https://bugs.webkit.org/show_bug.cgi?id=149321
2952 Reviewed by Tim Horton.
2954 InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
2955 enabled the "testing" viewport configuration, which disables page scaling.
2957 If we're running viewport tests, we want the normal web page configuration.
2958 Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2959 based on whether the test is in a "viewport" directory.
2961 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2962 (WTR::InjectedBundle::beginTesting):
2963 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2964 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2965 * WebKitTestRunner/TestInvocation.cpp:
2966 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2967 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2968 (WTR::TestInvocation::shouldMakeViewportFlexible):
2969 (WTR::TestInvocation::invoke):
2970 * WebKitTestRunner/TestInvocation.h:
2971 * WebKitTestRunner/ios/TestControllerIOS.mm:
2972 (WTR::TestController::platformConfigureViewForTest):
2973 (WTR::shouldMakeViewportFlexible): Deleted.
2975 2015-09-17 Simon Fraser <simon.fraser@apple.com>
2977 Give iOS WebKitTestRunner a launch storyboard
2978 https://bugs.webkit.org/show_bug.cgi?id=149314
2980 Reviewed by Dan Bates.
2982 Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2983 that it's been built for specific device configurations, and puts the window
2984 at the top of the screen. This simplifies coordinate conversions in a future patch.
2986 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2987 * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2988 * WebKitTestRunner/ios/Launch.storyboard: Added.
2990 2015-09-17 Myles C. Maxfield <mmaxfield@apple.com>
2992 Update licence in r189890
2993 https://bugs.webkit.org/show_bug.cgi?id=149306
2995 Reviewed by Dean Jackson.
2997 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2998 * FontWithFeatures/FontWithFeatures/FontCreator.h:
2999 * FontWithFeatures/FontWithFeatures/main.cpp:
3001 2015-09-17 Mark Lam <mark.lam@apple.com>
3003 Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3004 https://bugs.webkit.org/show_bug.cgi?id=149285
3006 Reviewed by Saam Barati.
3008 Just need to add an option to pass --no-jit to run-jsc-stress-test.
3010 * Scripts/run-javascriptcore-tests:
3011 (runJSCStressTests):
3013 2015-09-17 Alex Christensen <achristensen@webkit.org>
3015 Switch AppleWin build to use CMake
3016 https://bugs.webkit.org/show_bug.cgi?id=149163
3018 Reviewed by Brent Fulgham.
3020 * Scripts/build-webkit:
3021 * Scripts/run-api-tests:
3024 (prepareEnvironmentForRunningTestTool):
3026 (testToolPath): Deleted.
3027 Run the API tests as separate executables on Windows.
3028 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3029 * Scripts/webkitdirs.pm:
3030 (checkRequiredSystemConfig):
3031 (jhbuildWrapperPrefixIfNeeded):
3032 (generateBuildSystemFromCMakeProject):
3033 Fix configuration quirks.
3035 2015-09-17 Dean Johnson <dean_johnson@apple.com>
3037 Added toggle options for hiding and showing certain platform families on the dashboard.
3038 https://bugs.webkit.org/show_bug.cgi?id=148403
3040 Reviewed by David Kilzer.
3042 This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3043 individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3044 families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3045 in lieu of an "all" button in the toggle menu.
3047 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3048 (parsePlatformFamily): Helper function to parse out a platform family.
3049 (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3050 page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3051 (updateToggleButtons): Updates the status of the toggle buttons.
3052 (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3053 (documentReady): Added creation of toggle buttons.
3054 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3055 (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3056 (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3057 (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
3058 this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3059 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3060 (QueueView): Updated to use hiddenPlatformFamilies.
3061 (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3062 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3063 (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3064 (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3065 (Settings.prototype.toggleHiddenPlatform): Deleted.
3066 (Settings.prototype.clearHiddenPlatforms): Deleted.
3067 (Settings.prototype.toggleShowPlatformFamily): Deleted.
3068 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3069 (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3070 (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3071 (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3072 (table.queue-grid tr.headers th):
3073 (div.settingsWrapper.hide):
3074 (div.settingsWrapper):
3075 (div.familyToggleWrapper):
3076 (div.platformFamilyToggleButton):
3077 (div.platformFamilyShowToggleButton:not(:last-child)):
3079 (div.accessibilityButton):
3080 (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3081 (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3082 (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3083 platformFamilyToggleButton and settingsWrapper class.
3084 (.accessibilityButton): Deleted.
3086 2015-09-17 Tim Horton <timothy_horton@apple.com>
3088 Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3089 https://bugs.webkit.org/show_bug.cgi?id=148904
3091 Reviewed by Myles Maxfield.
3093 * WebKitTestRunner/TestController.cpp:
3094 (WTR::parseBooleanTestHeaderValue):
3095 (WTR::updateViewOptionsFromTestHeader):
3096 Check for the key "useThreadedScrolling".
3097 Add some code to check for "true" and "false" for boolean options.
3099 (WTR::TestController::viewOptionsForTest):
3100 Apply the test's overrides last, even after the platform's.
3102 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
3104 printing does not use minimum page zoom factor
3105 https://bugs.webkit.org/show_bug.cgi?id=108507
3107 Reviewed by Darin Adler.
3109 WebKitTestRunner always takes the snapshots from the UI process
3110 (expect for IOS), so in the case of printing, the layout in the
3111 web view is not the expected one. When printing, we need to take
3112 the snapshot in the web process and ensure it's rendered with a
3115 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3116 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3117 kWKSnapshotOptionsPrinting option to
3118 WKBundlePageCreateSnapshotWithOptions() when printing. When not
3119 printing, don't even create the snapshot, since it will be ignored
3120 by the UI process that always creates its own from the WebView (expect for IOS platform)
3121 * WebKitTestRunner/TestInvocation.cpp:
3122 (WTR::TestInvocation::dumpResults): Use always the snapshot image
3123 received from the web process if any when comparing pixel
3124 results. Now we only receive a snapshot from the web process in
3125 case of printing, or when platform is IOS. Otherwhise, generate
3126 the snapshot from the WebView as usual.
3127 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3128 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3129 is created by the caller now, but the CG implementation needs to
3130 know if it's a Web or UI process snapshot.
3131 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3132 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3133 cairo surface for the given image.
3134 * WebKitTestRunner/cg/TestInvocationCG.cpp:
3135 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3136 CGContext for the given image.
3138 2015-09-16 Myles C. Maxfield <mmaxfield@apple.com>
3140 Create a font which can be used for testing font features
3141 https://bugs.webkit.org/show_bug.cgi?id=149237
3143 Reviewed by Simon Fraser.
3145 This patch adds a new project in the Tools/ directory which generates a font which can
3146 be used for testing font features. This is a standalone project consisting of two files:
3147 1. A file which actually generates the byte vector representing the font. This file has
3148 a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3149 specific, and only relies on the C++ STL.
3150 2. A file with a main() which calls generateFont() and writes out the font, as well as
3151 uses the font to render some demonstration text into a .png file. This file is platform
3154 The font itself only supports the following characters:
3155 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3156 However, the shape of these letters are either an X or a check mark.
3158 The letter "A" always is a check mark.
3159 The letter "B" always is an X.
3160 Without any font features turned on, the rest of the letters are shown as X.
3162 Each font feature has an letter associated with it. When the font feature is enabled,
3163 that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3166 Here are the mappings of font features to letters:
3198 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3199 * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3201 (roundDownToPowerOfTwo):
3202 (isFourByteAligned):
3205 (writeCFFEncodedNumber):
3206 (CFFBuilder::CFFBuilder):
3207 (CFFBuilder::takeResult):
3208 (CFFBuilder::moveTo):
3209 (CFFBuilder::lineTo):
3210 (CFFBuilder::curveToCubic):
3211 (CFFBuilder::closePath):
3212 (CFFBuilder::writePoint):
3213 (generateBoxCharString):
3214 (generateCheckCharString):
3215 (generateXCharString):
3216 (charStringForGlyph):
3217 (Generator::generate):
3218 (Generator::Placeholder::Placeholder):
3219 (Generator::Placeholder::populate):
3220 (Generator::Placeholder::~Placeholder):
3221 (Generator::placeholder):
3222 (Generator::append16):
3223 (Generator::append32):
3224 (Generator::append32BitCode):
3225 (Generator::overwrite16):
3226 (Generator::overwrite32):
3227 (Generator::appendCFFTable):
3228 (Generator::appendSubstitutionSubtable):
3229 (Generator::appendScriptSubtable):
3230 (Generator::appendGSUBTable):
3231 (Generator::appendOS2Table):
3232 (Generator::appendFormat12CMAPTable):
3233 (Generator::appendFormat4CMAPTable):
3234 (Generator::appendCMAPTable):
3235 (Generator::appendHEADTable):
3236 (Generator::appendHHEATable):
3237 (Generator::appendHMTXTable):
3238 (Generator::appendMAXPTable):
3239 (Generator::appendNAMETable):
3240 (Generator::appendPOSTTable):
3241 (Generator::calculateChecksum):
3242 (Generator::appendTable):
3244 * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3245 * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3246 (drawTextWithFeature):
3249 2015-09-16 Commit Queue <commit-queue@webkit.org>
3251 Unreviewed, rolling out r189875 and r189878.
3252 https://bugs.webkit.org/show_bug.cgi?id=149235
3254 cygwin cmake build not ready yet (Requested by alexchristensen
3257 Reverted changesets:
3259 "Switch AppleWin build to use CMake"
3260 https://bugs.webkit.org/show_bug.cgi?id=149163
3261 http://trac.webkit.org/changeset/189875
3263 "Cygwin build fix after r189875"
3264 http://trac.webkit.org/changeset/189878
3266 2015-09-16 Alex Christensen <achristensen@webkit.org>
3268 Cygwin build fix after r189875
3270 * Scripts/build-webkit:
3271 * Scripts/webkitdirs.pm:
3272 (jhbuildWrapperPrefixIfNeeded):
3273 (generateBuildSystemFromCMakeProject):
3274 Make things work with cygwin and cmake.
3276 2015-09-16 Alex Christensen <achristensen@webkit.org>
3278 Switch AppleWin build to use CMake
3279 https://bugs.webkit.org/show_bug.cgi?id=149163
3281 Reviewed by Brent Fulgham.
3283 * Scripts/build-webkit:
3285 * Scripts/run-api-tests:
3288 (prepareEnvironmentForRunningTestTool):
3290 (testToolPath): Deleted.
3291 Run the API tests as separate executables on Windows.
3292 It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3294 2015-09-16 Alexey Proskuryakov <ap@apple.com>
3296 Add newer build.webkit.org pages to robots.txt
3297 https://bugs.webkit.org/show_bug.cgi?id=149219
3299 Reviewed by Darin Adler.
3301 Indexing bot watcher's dashboard can't be good.
3303 * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
3305 2015-09-16 Alex Christensen <achristensen@webkit.org>
3307 Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
3309 * BuildSlaveSupport/built-product-archive:
3312 2015-09-16 Csaba Osztrogonác <ossy@webkit.org>
3314 [EFL] Fix the help message of separated web process option of MiniBrowser
3315 https://bugs.webkit.org/show_bug.cgi?id=149212
3317 Reviewed by Gyuyoung Kim.
3319 * MiniBrowser/efl/main.c:
3321 2015-09-16 Alex Christensen <achristensen@webkit.org>
3323 Fix python syntax after r189851.
3325 * BuildSlaveSupport/built-product-archive:
3327 For loops need a colon.
3329 2015-09-15 Alex Christensen <achristensen@webkit.org>
3331 Fix Windows test bots after changing to non-cygwin build
3332 https://bugs.webkit.org/show_bug.cgi?id=149196
3334 Reviewed by Daniel Bates.
3336 * BuildSlaveSupport/built-product-archive:
3338 Using different versions of python makes what I think is https://bugs.python.org/issue15795
3339 prevent us from executing files from the archive on the test bots.
3341 2015-09-15 Ryosuke Niwa <rniwa@webkit.org>
3343 Add ShadowRoot interface and Element.prototype.attachShadow
3344 https://bugs.webkit.org/show_bug.cgi?id=149187
3346 Reviewed by Antti Koivisto.
3348 * Scripts/webkitperl/FeatureList.pm:
3350 2015-09-15 Aakash Jain <aakash_jain@apple.com>
3352 Appscale queue status json output lacks bots
3353 https://bugs.webkit.org/show_bug.cgi?id=149194
3354 <rdar://problem/22171089>
3356 Reviewed by Alexey Proskuryakov.
3358 * QueueStatusServer/handlers/queuestatusjson.py:
3359 (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3360 * QueueStatusServer/index.yaml: Index according to appscale requirements.
3362 2015-09-15 Brent Fulgham <bfulgham@apple.com>
3364 [Win] Provide a means for viewing the layer tree
3365 https://bugs.webkit.org/show_bug.cgi?id=149165
3367 Reviewed by Simon Fraser.
3369 Update MiniBrowser with a new Debug menu option that will
3370 dump the current layer tree to the debug console.
3372 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3373 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3374 * MiniBrowser/win/Common.cpp:
3375 (WndProc): Add handler for 'Print Layer Tree' menu option.
3376 * MiniBrowser/win/MiniBrowser.cpp:
3377 (MiniBrowser::printLayerTree): Added Handler.
3378 * MiniBrowser/win/MiniBrowser.h:
3380 2015-09-14 Myles C. Maxfield <mmaxfield@apple.com>
3382 WebKitTestRunner declarative language setting is broken for iOS
3383 https://bugs.webkit.org/show_bug.cgi?id=149119
3387 In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
3388 lost in the final version which got committed. This simply implements the existing
3389 OS X behavior on iOS.
3391 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3392 (WTR::InjectedBundle::platformInitialize):
3394 2015-09-14 Dewei Zhu <dewei_zhu@apple.com>
3396 Unreviewed, add myself to committers list.
3398 * Scripts/webkitpy/common/config/contributors.json:
3400 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
3402 [Cocoa] Allow testing with the system language
3403 https://bugs.webkit.org/show_bug.cgi?id=148671
3405 Reviewed by Anders Carlsson and Alexey Proskuryakov.
3407 React to tests marked with language=lang1,lang2,etc in their header.
3408 Once this information is parsed, pass it to
3409 WKContextConfigurationSetOverrideLanguages().
3411 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3412 (WTR::InjectedBundle::platformInitialize): Don't clobber the language
3414 * WebKitTestRunner/TestController.cpp:
3415 (WTR::TestController::createWebViewWithOptions): Call
3416 WKContextConfigurationSetOverrideLanguages().
3417 (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
3418 * WebKitTestRunner/TestOptions.h:
3419 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3420 (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
3421 option to restart the web process.
3422 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3423 (WTR::PlatformWebView::viewSupportsOptions): Ditto.
3425 2015-09-12 Myles C. Maxfield <mmaxfield@apple.com>
3427 [WKTR] Allow changing the WKContextConfiguration between successive tests
3428 https://bugs.webkit.org/show_bug.cgi?id=148833
3430 Reviewed by Tim Horton.
3432 Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3433 However, there are certain tests which require specifying options in this object. This patch makes
3434 our existing code for recreating the test runner web view also recreate the WKContext.
3436 As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3439 * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3440 * WebKitTestRunner/PlatformWebView.h:
3441 (WTR::PlatformWebView::options):
3442 * WebKitTestRunner/TestController.cpp:
3443 (WTR::TestController::initialize):
3444 (WTR::TestController::generateContextConfiguration):
3445 (WTR::TestController::generatePageConfiguration):
3446 (WTR::TestController::createWebViewWithOptions):
3447 (WTR::TestController::ensureViewSupportsOptionsForTest):
3448 (WTR::updateContextConfigurationOptionsFromTestHeader):
3449 (WTR::TestController::contextConfigurationOptionsForTest):
3450 (WTR::TestController::platformCreateWebView):
3451 (WTR::TestController::platformCreateOtherPage):
3452 (WTR::updateViewOptionsFromTestHeader): Deleted.
3453 (WTR::TestController::viewOptionsForTest): Deleted.
3454 * WebKitTestRunner/TestController.h:
3455 (WTR::TestController::injectedBundlePath):
3456 (WTR::TestController::testPluginDirectory):
3457 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3458 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3459 (WTR::TestController::platformCreateWebView):
3460 (WTR::TestController::platformCreateOtherPage):
3461 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3462 (WTR::PlatformWebView::PlatformWebView):
3463 (WTR::PlatformWebView::viewSupportsOptions):
3464 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3465 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3466 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3467 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3468 (WTR::PlatformWebView::PlatformWebView):
3469 (WTR::PlatformWebView::viewSupportsOptions):
3470 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3471 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3472 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3473 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3474 (WTR::PlatformWebView::PlatformWebView):
3475 (WTR::PlatformWebView::viewSupportsOptions):
3476 * WebKitTestRunner/ios/TestControllerIOS.mm:
3477 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3478 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3479 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3480 (WTR::PlatformWebView::PlatformWebView):
3481 (WTR::PlatformWebView::viewSupportsOptions):
3482 * WebKitTestRunner/mac/TestControllerMac.mm:
3483 (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3484 (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3486 2015-09-11 Michael Saboff <msaboff@apple.com>
3488 LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
3489 https://bugs.webkit.org/show_bug.cgi?id=149083
3491 Reviewed by Alexey Proskuryakov.
3493 Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
3495 * DumpRenderTree/mac/LayoutTestHelper.m:
3496 (colorProfileURLForDisplay):
3498 2015-09-11 Saam barati <sbarati@apple.com>
3500 There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
3501 https://bugs.webkit.org/show_bug.cgi?id=149058
3503 Reviewed by Geoffrey Garen.
3505 * Scripts/run-jsc-stress-tests:
3507 2015-09-10 Commit Queue <commit-queue@webkit.org>
3509 Unreviewed, rolling out r189595.
3510 https://bugs.webkit.org/show_bug.cgi?id=149052
3512 The tests still fail (Requested by ap on #webkit).
3516 "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
3518 https://bugs.webkit.org/show_bug.cgi?id=142929
3519 http://trac.webkit.org/changeset/189595
3521 2015-09-10 Alexey Proskuryakov <ap@apple.com>
3523 Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
3524 https://bugs.webkit.org/show_bug.cgi?id=142929
3526 Reviewed by Brent Fulgham.
3528 Silence the logging. We'll track fixing the root cause in Radar.
3530 * Scripts/webkitpy/port/mac.py:
3531 (MacPort.stderr_patterns_to_strip): Added a FIXME.
3533 * Scripts/webkitpy/port/win.py:
3534 (WinPort.logging_patterns_to_strip): Added.
3536 2015-09-09 Andy Estes <aestes@apple.com>
3538 [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
3539 https://bugs.webkit.org/show_bug.cgi?id=149022
3541 Reviewed by Daniel Bates.
3543 Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
3544 did not account for this.
3546 * Scripts/webkitpy/xcode/simulator.py:
3547 (Simulator): Optionally matched a revision at the end of a runtime version number.
3548 * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
3550 2015-09-09 Andy Estes <aestes@apple.com>
3552 [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
3553 https://bugs.webkit.org/show_bug.cgi?id=149029
3554 <rdar://problem/22432624>
3556 Reviewed by Daniel Bates.
3558 * Scripts/webkitpy/xcode/simulator.py:
3559 (Simulator): Taught to parse tvOS runtimes.
3560 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3562 2015-09-09 Alexey Proskuryakov <ap@apple.com>
3564 Fix bit rot on bot watcher's dashboard page
3565 https://bugs.webkit.org/show_bug.cgi?id=149012
3567 Reviewed by Tim Horton.
3569 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3570 The code path used by the metrics page was trying to add properties to an undefined.
3572 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3573 Silence an expection that would occur when the step has no logs. This should never
3574 happen, but it did (perhaps buildbot was misconfigured for a while).
3576 2015-09-09 Alexey Proskuryakov <ap@apple.com>
3578 Update LayoutTestRelay xcconfig file.
3580 Rubber-stamped by Dan Bernstein.
3582 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3584 2015-09-09 Saam barati <sbarati@apple.com>
3586 DFG should have a debugging option that runs a phase that flushes all locals
3587 https://bugs.webkit.org/show_bug.cgi?id=148916
3589 Reviewed by Filip Pizlo.
3591 * Scripts/run-jsc-stress-tests:
3593 2015-09-09 Commit Queue <commit-queue@webkit.org>
3595 Unreviewed, rolling out r189530 and r189534.
3596 https://bugs.webkit.org/show_bug.cgi?id=148996
3598 Caused assertion failures on Yosemite (Requested by litherum