[WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2
3         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
4         https://bugs.webkit.org/show_bug.cgi?id=96374
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Implement support for dumpApplicationCacheDelegateCallbacks
9         and disallowIncreaseForApplicationCacheQuota in
10         WebKitTestRunner and properly dump the information
11         expected by the tests.
12
13         If the application cache quota is reached for a given
14         security origin, WebKitTestRunner will reset the quota
15         to its default value, unless intructed not to via
16         disallowIncreaseForApplicationCacheQuota().
17
18         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
19         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
20         (WTR::InjectedBundlePage::InjectedBundlePage):
21         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
22         (WTR):
23         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
24         (InjectedBundlePage):
25         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26         (WTR::TestRunner::TestRunner):
27         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
28         (WTR):
29         * WebKitTestRunner/InjectedBundle/TestRunner.h:
30         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
31         (TestRunner):
32         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
33         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
34
35 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
36
37         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
38         https://bugs.webkit.org/show_bug.cgi?id=96388
39
40         Reviewed by Kenneth Rohde Christiansen.
41
42         Exported TestRunner.workerThreadCount as readonly attribute.
43
44         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
45         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
46         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
47         (WTR):
48         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
49         (TestRunner):
50
51 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
52
53         [chromium] Consume a user gesture when creating a new view.
54         https://bugs.webkit.org/show_bug.cgi?id=96373
55
56         Reviewed by Adam Barth.
57
58         * DumpRenderTree/chromium/WebViewHost.cpp:
59         (WebViewHost::createView):
60
61 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
62
63         [WK2][WTR] Some of TestRunner special options are not reset before testing
64         https://bugs.webkit.org/show_bug.cgi?id=96384
65
66         Reviewed by Kenneth Rohde Christiansen.
67
68         Now values of the following special options are reset:
69         void setAcceptsEditing(in boolean value);
70         void setCloseRemainingWindowsWhenComplete(in boolean value);
71         void setXSSAuditorEnabled(in boolean value);
72         void setAllowFileAccessFromFileURLs(in boolean value);
73         void setPluginsEnabled(in boolean value);
74         void setPopupBlockingEnabled(in boolean value);
75
76         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
77         (WTR::InjectedBundle::beginTesting):
78
79 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
80
81         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
82         https://bugs.webkit.org/show_bug.cgi?id=96273
83
84         Reviewed by Gyuyoung Kim.
85
86         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
87         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
88
89         * WebKitTestRunner/CMakeLists.txt:
90
91 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
92
93         [chromium] rename webkit_resources
94         https://bugs.webkit.org/show_bug.cgi?id=95874
95
96         Reviewed by James Robinson.
97
98         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
99
100 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
101
102         [chromium] don't include content shell builders in the garden-o-matic view
103         https://bugs.webkit.org/show_bug.cgi?id=96418
104
105         Reviewed by James Robinson.
106
107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
108
109 2012-09-11  Adam Klein  <adamk@chromium.org>
110
111         Garden-o-matic should ignore a wider variety of warnings in buildbot json
112         https://bugs.webkit.org/show_bug.cgi?id=96411
113
114         Reviewed by Adam Barth.
115
116         Previously only the exact string "warning" was treated as a warning
117         result. This patch treats any string with "warning" as a substring
118         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
119
120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
121         (.):
122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
123
124 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
125
126         Restore original value of mock scrollbars enabled in InternalSettings
127         https://bugs.webkit.org/show_bug.cgi?id=87680
128
129         Reviewed by Adam Barth.
130
131         Added backup support for mock scrollbars state in
132         InternalSettings::Backup, and removed support for these
133         from Qt's DumpRenderTree.
134
135         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
136         (WebCore::WebPage::resetSettings):
137         * DumpRenderTree/qt/TestRunnerQt.cpp:
138         (TestRunner::setFrameFlatteningEnabled):
139         * DumpRenderTree/qt/TestRunnerQt.h:
140         (TestRunner):
141
142 2012-09-11  Dan Bernstein  <mitz@apple.com>
143
144         Fixed a bug where kill-old-processes failed to kill clang++.
145
146         Rubber-stamped by Alexey Proskuryakov.
147
148         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
149         where it is passed as a regular expression to killall.
150
151 2012-09-11  Philippe Liard  <pliard@google.com>
152
153         Make sure that md5sum is not setup on non-Chromium Android platforms.
154         https://bugs.webkit.org/show_bug.cgi?id=96393
155
156         Reviewed by Adam Barth.
157
158         Previously md5sum was setup in ChromiumAndroidDriver's constructor
159         which is also invoked on non-Chromium Android platforms. The following patch
160         moves this logic to _startup_test() which is guaranteed to be invoked
161         only on Android.
162
163         This also updates the prompt unit test in chromium_android_unittest.py.
164
165         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
166         (ChromiumAndroidDriver.__init__):
167         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
168         (ChromiumAndroidDriver._setup_test):
169
170 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
171
172         [EFL] Rewrite the EFL-related Find modules
173         https://bugs.webkit.org/show_bug.cgi?id=95237
174
175         Reviewed by Kenneth Rohde Christiansen.
176
177         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
178         property and include all the Enlightenment Foundation Libraries
179         required by the target.
180         * EWebLauncher/CMakeLists.txt: Ditto.
181         * MiniBrowser/efl/CMakeLists.txt: Ditto.
182         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
183         now that they are not added implicitly.
184         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
185         property.
186         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
187         property and include all the Enlightenment Foundation Libraries
188         required by the target.
189
190 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
191
192         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
193         https://bugs.webkit.org/show_bug.cgi?id=96379
194
195         Reviewed by Kenneth Rohde Christiansen.
196
197         Add implementation for setApplicationCacheOriginQuota
198         to WebKitTestRunner.
199
200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
202         (WTR::TestRunner::setApplicationCacheOriginQuota):
203         (WTR):
204         * WebKitTestRunner/InjectedBundle/TestRunner.h:
205         (TestRunner):
206
207 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
208
209         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
210         https://bugs.webkit.org/show_bug.cgi?id=91988
211
212         Reviewed by Kenneth Rohde Christiansen.
213
214         Regular key events generated by Qt for the tab key fill both
215         keyCode and keyText, so we should do the same for our fake events.
216
217         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
218         (WTR::EventSenderProxy::keyDown):
219
220 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
221
222         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
223         https://bugs.webkit.org/show_bug.cgi?id=96269
224
225         Reviewed by Kenneth Rohde Christiansen.
226
227         Exported missing testRunner.setSpatialNavigationEnabled() method.
228
229         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
230         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
231         (WTR::InjectedBundle::beginTesting):
232         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
233         (WTR::TestRunner::setSpatialNavigationEnabled):
234         (WTR):
235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
236         (TestRunner):
237
238 2012-09-11  Philippe Liard  <pliard@chromium.org>
239
240         Support LayoutTests on non-rooted devices for Chromium Android.
241         https://bugs.webkit.org/show_bug.cgi?id=95346
242
243         Reviewed by Dirk Pranke.
244
245         We were requiring root permissions to sync resource files with the
246         device by comparing host and device files' timestamp after we
247         synchronized the device and host clocks.
248         We now rely on md5sum provided by Chromium to handle data files
249         synchronization.
250
251         * Scripts/webkitpy/layout_tests/port/chromium.py:
252         (ChromiumPort._check_driver_build_up_to_date):
253         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
254         (ChromiumAndroidDriver.__init__):
255         (ChromiumAndroidDriver._setup_test):
256         (ChromiumAndroidDriver._push_executable):
257         (ChromiumAndroidDriver._push_test_resources):
258         (ChromiumAndroidDriver._read_prompt):
259
260 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
261
262         [Qt] Fix output paths on Windows
263
264         Reviewed by Tor Arne Vestbø.
265
266         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
267         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
268         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
269         incorrect here and instead for the calculation we should use forward slashes.
270
271         * qmake/mkspecs/features/default_pre.prf:
272
273 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
274
275         [Qt] Fix passing of defines from the build system
276
277         We explicitly have to pass -DENABLE_FOO=0 for every single feature
278         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
279         will add it's own defaults if the features are not defined.
280
281         At some point we might want to run a configure-test to inspect what
282         Platform.h will do, so we can sync up the build system's view of
283         the feature-defines with the compile-time situation.
284
285         Reviewed by Simon Hausmann.
286
287         * qmake/mkspecs/features/functions.prf:
288
289 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
290
291         [Qt] Fix --qt option to build-webkit
292
293         Reviewed by Ossy.
294
295         * Scripts/webkitdirs.pm:
296         (buildQMakeProjects):
297
298 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
299
300         [Qt] Add a configure step to the Qt build system
301
302         This allows building the Qt port using just 'qmake WebKit.pro'. Using
303         the build-webkit script is still supported, and will add slightly more
304         logic to the build, such as detecting the need for clean or incremental
305         builds.
306
307         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
308         all things related to configuring the build, such as use/have/enable flags,
309         and these are translated to defines in default_post. Project files should
310         no longer check contains(DEFINES,...) to detect features, but use the new
311         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
312         options have been translated into WEBKIT_CONFIG options as well, and can
313         be checked using build?().
314
315         Reviewed by Simon Hausmann.
316
317         * DumpRenderTree/qt/DumpRenderTree.pro:
318         * MiniBrowser/qt/MiniBrowser.pro:
319         * QtTestBrowser/QtTestBrowser.pro:
320         * Scripts/build-webkit:
321         * Scripts/webkitdirs.pm:
322         (qtFeatureDefaults):
323         (buildQMakeProjects):
324         * Tools.pro:
325         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
326         * WebKitTestRunner/InjectedBundle/Target.pri:
327         * WebKitTestRunner/Target.pri:
328         * qmake/.qmake.cache: Added.
329         * qmake/configure.pri: Removed.
330         * qmake/configure.pro: Removed.
331         * qmake/dump-features: Added.
332         * qmake/mkspecs/features/configure.prf: Added.
333         * qmake/mkspecs/features/default_post.prf:
334         * qmake/mkspecs/features/default_pre.prf:
335         * qmake/mkspecs/features/features.prf:
336         * qmake/mkspecs/features/features.pri:
337         * qmake/mkspecs/features/functions.prf:
338         * qmake/mkspecs/features/gprof.prf:
339         * qmake/mkspecs/features/mac/default_pre.prf:
340         * qmake/mkspecs/features/win32/default_pre.prf:
341
342 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
343
344         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
345         https://bugs.webkit.org/show_bug.cgi?id=96372
346
347         Reviewed by Kenneth Rohde Christiansen.
348
349         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
350
351         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
352         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
353         (WTR::TestRunner::clearApplicationCacheForOrigin):
354         (WTR):
355         * WebKitTestRunner/InjectedBundle/TestRunner.h:
356         (TestRunner):
357
358 2012-09-11  Peter Beverloo  <peter@chromium.org>
359
360         Don't ignore .pak files when making an archive for Android
361         https://bugs.webkit.org/show_bug.cgi?id=96375
362
363         Reviewed by Jochen Eisinger.
364
365         The .pak files do need to be pushed to the device, which is currently
366         preventing the layout test runner from correctly pushing all files.
367
368         * BuildSlaveSupport/built-product-archive:
369         (archiveBuiltProduct):
370
371 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
372
373         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
374         https://bugs.webkit.org/show_bug.cgi?id=96256
375
376         Reviewed by Kenneth Rohde Christiansen.
377
378         Exported TestRunner::setMinimumTimerInterval() method.
379
380         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
381         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
382         (WTR::InjectedBundle::beginTesting):
383         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
384         (WTR::TestRunner::setMinimumTimerInterval):
385         (WTR):
386         * WebKitTestRunner/InjectedBundle/TestRunner.h:
387         (TestRunner):
388
389 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
390
391         MediaStream API: add RTCPeerConnection::onnegotiationneeded
392         https://bugs.webkit.org/show_bug.cgi?id=96097
393
394         Reviewed by Adam Barth.
395
396         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
397         (MockWebRTCPeerConnectionHandler::addStream):
398         (MockWebRTCPeerConnectionHandler::removeStream):
399
400 2012-09-11  Peter Beverloo  <peter@chromium.org>
401
402         Recognize the "--chromium-android" argument in run-webkit-tests
403         https://bugs.webkit.org/show_bug.cgi?id=96369
404
405         Reviewed by Jochen Eisinger.
406
407         Chromium for the Android platform cannot determine the platform based on
408         the host itself, so we'll use the --chromium-android argument as the build
409         master passes to run-webkit-tests. Make sure the layout test runner
410         can pick the right port when doing so.
411
412         * Scripts/run-webkit-tests:
413         * Scripts/webkitpy/layout_tests/port/factory.py:
414         (port_options):
415
416 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
417
418         [QT] Fix build with newer qmake from Qt 5
419
420         Rubber-stamped by Tor Arne Vestbø.
421
422         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
423         it with the use of QT_HOST_DATA/mkspecs.
424         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
425
426         * Scripts/webkitdirs.pm:
427         (builtDylibPathForName):
428         (qtMakeCommand):
429
430 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
431
432         [Qt] Remove Qt 4 syncqt, no longer needed
433
434         Reviewed by Simon Hausmann.
435
436         * qmake/syncqt-4.8: Removed.
437
438 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
439
440         [Qt][WK2] Fix the build with recent Qt5
441         https://bugs.webkit.org/show_bug.cgi?id=96283
442
443         Reviewed by Simon Hausmann.
444
445         We should not use deprecated Qt API because doing that results
446         in build failure since all the deprecated API was disabled
447         in qtbase (https://codereview.qt-project.org/#change,24890).
448
449         * DumpRenderTree/qt/main.cpp:
450         (main):
451         * MiniBrowser/qt/MiniBrowserApplication.cpp:
452         (MiniBrowserApplication::notify):
453         * MiniBrowser/qt/raw/View.cpp:
454         (View::exposeEvent):
455         (main):
456
457 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
458
459         WTR needs an implementation of applicationCacheDiskUsageForOrigin
460         https://bugs.webkit.org/show_bug.cgi?id=87188
461
462         Reviewed by Kenneth Rohde Christiansen.
463
464         Add implementation for applicationCacheDiskUsageForOrigin()
465         in WebKitTestRunner.
466
467         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
468         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
469         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
470         (WTR):
471         * WebKitTestRunner/InjectedBundle/TestRunner.h:
472         (TestRunner):
473
474 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
475
476         Properly expose <legend> elements to ATs
477         https://bugs.webkit.org/show_bug.cgi?id=84137
478
479         Reviewed by Chris Fleizach.
480
481         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
482         the expected platform role, ATK_ROLE_LABEL. Also established the needed
483         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
484
485         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
486         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
487
488 2012-09-10  Jer Noble  <jer.noble@apple.com>
489
490         Unreviewed; rolling out r128081.
491         http://trac.webkit.org/changeset/128081
492         https://bugs.webkit.org/show_bug.cgi?id=96134
493
494         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
495
496         * DumpRenderTree/TestRunner.cpp:
497         (TestRunner::TestRunner):
498         (TestRunner::staticFunctions):
499         * DumpRenderTree/TestRunner.h:
500         (TestRunner):
501         * DumpRenderTree/mac/FrameLoadDelegate.mm:
502         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
503         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
504         (WTR::InjectedBundlePage::InjectedBundlePage):
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
506         (InjectedBundlePage):
507         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
508         (WTR::TestRunner::TestRunner):
509         * WebKitTestRunner/InjectedBundle/TestRunner.h:
510         (TestRunner):
511
512 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
513
514         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
515         https://bugs.webkit.org/show_bug.cgi?id=96205
516
517         Reviewed by Tony Chang.
518
519         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
520         internally, which means that it would support only 1 TestExpectations file per port. This
521         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
522         and efl-wk1 -> efl).
523
524         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
525         instead so that all the ports TestExpectations are recognized. The ports are also
526         constructed twice, with "webkit_test_runner" option set to True and False so that we
527         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
528
529         * Scripts/webkitpy/style/checkers/test_expectations.py:
530         (TestExpectationsChecker._determine_port_from_expectations_path):
531         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
532         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
533
534 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
535
536         [WTR] Generated source files should include config.h
537         https://bugs.webkit.org/show_bug.cgi?id=96254
538
539         Reviewed by Benjamin Poulain.
540
541         Current coding style has encouraged to include config.h at the first position,
542         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
543         this rule.
544         Therefore, this patch added it.
545
546         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
547         (_generateImplementationFile):
548
549 2012-09-10  Rick Byers  <rbyers@chromium.org>
550
551         Add handling of new GestureTapCancel in DRT
552         
553         https://bugs.webkit.org/show_bug.cgi?id=96183
554
555         Reviewed by Adam Barth.
556
557         * DumpRenderTree/chromium/TestWebPlugin.cpp:
558         (TestWebPlugin::handleInputEvent):
559
560 2012-09-10  Brady Eidson  <beidson@apple.com>
561
562         Javascript in foreground tabs should not wait synchronously for plug-ins to load
563         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
564
565         Reviewed by Geoff Garen.
566
567         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
568
569         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
570         (PluginObject):
571         (SlowNPPNew::PluginObject::PluginObject):
572         (SlowNPPNew::PluginObject::~PluginObject):
573         (SlowNPPNew::PluginObject::hasProperty):
574         (SlowNPPNew::PluginObject::getProperty):
575         (SlowNPPNew::NPP_GetValue):
576         (SlowNPPNew):
577
578 2012-09-10  Tim Horton  <timothy_horton@apple.com>
579
580         WKTR often reports an unresponsive WebProcess on Mac bots
581         https://bugs.webkit.org/show_bug.cgi?id=95906
582
583         Reviewed by Dan Bernstein.
584
585         Attempt to work around resource contention issues by increasing the NRWT
586         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
587
588         * Scripts/webkitpy/layout_tests/port/base.py:
589         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
590         * WebKitTestRunner/TestController.cpp:
591         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
592
593 2012-09-07  Jer Noble  <jer.noble@apple.com>
594
595         <audio> and <video> should send Do Not Track when appropriate
596         https://bugs.webkit.org/show_bug.cgi?id=96134
597
598         Reviewed by Eric Carlson.
599
600         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
601         WTR. Add FrameLoaderClient client methods for retrieving that value.
602
603         * DumpRenderTree/TestRunner.cpp:
604         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
605         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
606         * DumpRenderTree/TestRunner.h:
607         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
608         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
609         * DumpRenderTree/mac/FrameLoadDelegate.mm:
610         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
611             Pass the question on to the TestRunner.
612         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
614         (WTR::InjectedBundlePage::InjectedBundlePage):
615             Add the setShouldSendDoNotTrackHTTPHeader client function.
616         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
617             Pass the question on to the TestRunner.
618         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
619         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
620         * WebKitTestRunner/InjectedBundle/TestRunner.h:
621         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
622         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
623
624 2012-09-10  Ojan Vafai  <ojan@chromium.org>
625
626         Make EFL bots work on the flakiness dashboard
627         https://bugs.webkit.org/show_bug.cgi?id=96164
628
629         Reviewed by Tony Chang.
630
631         Also, update outdated unittests that had started failing.
632
633         * TestResultServer/static-dashboards/builders.js:
634         (isWebkitTestRunner):
635         * TestResultServer/static-dashboards/flakiness_dashboard.js:
636         (nonChromiumPlatform):
637         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
638         (test):
639
640 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
641
642         [chromium] MediaStream API: Remove the Descriptor postfix
643         https://bugs.webkit.org/show_bug.cgi?id=96268
644
645         Reviewed by Adam Barth.
646
647         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
648         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
649
650         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
651         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
652         (MockWebRTCPeerConnectionHandler::createOffer):
653         (MockWebRTCPeerConnectionHandler::createAnswer):
654         (MockWebRTCPeerConnectionHandler::setLocalDescription):
655         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
656         (MockWebRTCPeerConnectionHandler::localDescription):
657         (MockWebRTCPeerConnectionHandler::remoteDescription):
658         (MockWebRTCPeerConnectionHandler::addICECandidate):
659         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
660         (MockWebRTCPeerConnectionHandler):
661
662 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
663
664         [Gtk] failure to build jhbuild dependencies with cups 1.6
665         https://bugs.webkit.org/show_bug.cgi?id=95991
666
667         Reviewed by Gustavo Noronha Silva.
668
669         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
670         building with cups >= 1.6 [GNOME #670373].
671
672         * gtk/jhbuild.modules:
673
674 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
675
676         [EFL][DRT] Encoding issue in printed console messages
677         https://bugs.webkit.org/show_bug.cgi?id=96263
678
679         Reviewed by Kenneth Rohde Christiansen.
680
681         Correctly handle CONSOLE messages that contain non-ascii
682         characters in EFL's DRT. We need to use String::fromUTF8()
683         to construct a WTF::String from a raw string.
684
685         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
686         (onConsoleMessage):
687
688 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
689
690         [WK2][WTR] User style sheet location should be reset before each test
691         https://bugs.webkit.org/show_bug.cgi?id=96262
692
693         Reviewed by Kenneth Rohde Christiansen.
694
695         User style sheet location is reset before each test now.
696
697         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
698         (WTR::InjectedBundle::beginTesting):
699
700 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
701
702         Fix build of WTR with Qt on Windows
703         https://bugs.webkit.org/show_bug.cgi?id=96249
704
705         Reviewed by Kenneth Rohde Christiansen.
706
707         Windows loves to define min and max as macros, which beautifully
708         clashes in many places where min and max are used as variable or method
709         names. It can be convinced not to do this when min and max are already
710         define as macros (expanding to themselves). We have this kind of
711         workaround in config.h files all over WebKit and as it turns out when
712         building WTR with Qt on Windows we do end up with such a clash. Therefore
713         we need the same workaround.
714
715         * WebKitTestRunner/config.h:
716
717 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
718
719         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
720         https://bugs.webkit.org/show_bug.cgi?id=95936
721
722         Reviewed by Kenneth Rohde Christiansen.
723
724         Enable interactive form validation setting in WebKitTestRunner as
725         we are currently doing in DumpRenderTree. This is needed for some
726         tests to pass.
727
728         * WebKitTestRunner/TestController.cpp:
729         (WTR::TestController::resetStateToConsistentValues):
730
731 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
732
733         Clean up the code in XvfbDriver
734         https://bugs.webkit.org/show_bug.cgi?id=96202
735
736         Reviewed by Philippe Normand.
737
738         Changes:
739         - Remove unneeded imports,
740         - assign the _lock_file member variable when the display number is determined,
741         - no need for parentheses around a single string format argument,
742         - use FileSystem.exists method when checking if lock file is present as it
743         makes the intention much more clearer.
744
745         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
746         (XvfbDriver._start):
747         (XvfbDriver.stop):
748
749 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
750
751         Make the String initialization on the function side of String::number()
752         https://bugs.webkit.org/show_bug.cgi?id=95940
753
754         Reviewed by Benjamin Poulain.
755
756         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
757         (testBoundaries):
758         (testNumbers):
759
760 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
761
762         [WK2] expose element rect for color input type
763         https://bugs.webkit.org/show_bug.cgi?id=91664
764
765         Reviewed by Simon Hausmann.
766
767         Update the QML logic in MiniBrowser to take advantage of this.
768         The picker size is now hardcoded and we try to place it below the
769         input element if possible.
770
771         * MiniBrowser/qt/qml/ColorChooser.qml:
772
773 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
774
775         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
776         https://bugs.webkit.org/show_bug.cgi?id=95329
777
778         Reviewed by Kenneth Rohde Christiansen.
779
780         Explicitely disable TabToLinks setting in WebKitTestRunner.
781         Tests override the "WebKitTabToLinksPreferenceKey" preference
782         to enable it.
783
784         * WebKitTestRunner/TestController.cpp:
785         (WTR::TestController::resetStateToConsistentValues):
786
787 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
788
789         webkit.py gdb pretty printer can't print CString
790         https://bugs.webkit.org/show_bug.cgi?id=96068
791
792         Reviewed by Tony Chang.
793
794         Update WTFCStringPrinter to follow r126191.
795
796         * gdb/webkit.py:
797         (WTFCStringPrinter.to_string):
798
799 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
800
801         Rename the ustring() accessor to string()
802         https://bugs.webkit.org/show_bug.cgi?id=95919
803
804         Reviewed by Geoffrey Garen.
805
806         Update EFL's DRT.
807
808         Fix some string conversion that have been made useless
809         with recent changes.
810
811         * DumpRenderTree/efl/EventSender.cpp:
812         (keyPadNameFromJSValue):
813         (keyNameFromJSValue):
814         * DumpRenderTree/efl/TestRunnerEfl.cpp:
815         (TestRunner::queueLoad):
816         (TestRunner::addOriginAccessWhitelistEntry):
817         (TestRunner::removeOriginAccessWhitelistEntry):
818         (TestRunner::setUserStyleSheetLocation):
819         (TestRunner::setValueForUser):
820         (TestRunner::elementDoesAutoCompleteForElementWithId):
821         (TestRunner::execCommand):
822         (TestRunner::findString):
823         (TestRunner::isCommandEnabled):
824         (TestRunner::clearApplicationCacheForOrigin):
825         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
826         (TestRunner::pauseAnimationAtTimeOnElementWithId):
827         (TestRunner::pauseTransitionAtTimeOnElementWithId):
828         (toInt):
829         (TestRunner::overridePreference):
830         (TestRunner::addUserScript):
831         (TestRunner::addUserStyleSheet):
832         (TestRunner::evaluateInWebInspector):
833         (TestRunner::evaluateScriptInIsolatedWorld):
834         (TestRunner::setTextDirection):
835         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
836         (LoadItem::invoke):
837         (LoadHTMLStringItem::invoke):
838         (ScriptItem::invoke):
839
840 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
841
842         Extend third-party storage blocking API to optionally allow blocking all storage
843         https://bugs.webkit.org/show_bug.cgi?id=95915
844
845         Reviewed by Brady Eidson.
846
847         Modified API test to use new revised API.
848
849         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
850         (TestWebKitAPI::TEST):
851
852 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
853
854         AX: WebCore accessibility roles should be cross-platform
855         https://bugs.webkit.org/show_bug.cgi?id=94870
856
857         Reviewed by Chris Fleizach.
858
859         Add debug strings to Chromium for new accessibility roles.
860
861         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
862         (roleToString):
863
864 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
865
866         AX: Chromium needs access to canvasHasFallbackContent
867         https://bugs.webkit.org/show_bug.cgi?id=96124
868
869         Reviewed by Chris Fleizach.
870
871         Distinguish between canvas roles with and without fallback
872         content on Chromium.
873
874         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
875         (getRole):
876
877 2012-09-07  Ojan Vafai  <ojan@chromium.org>
878
879         Handle non-existant TestExpectations files gracefully
880         https://bugs.webkit.org/show_bug.cgi?id=96149
881
882         Reviewed by Eric Seidel.
883
884         Even when we get rid of Skipped files, we shouldn't have each port
885         require a TestExpectations file for each platform if it doesn't
886         need one.
887
888         * Scripts/webkitpy/layout_tests/port/base.py:
889         (Port.expectations_dict):
890         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
891         (PortTest.test_nonexistant_expectations):
892
893 2012-09-07  Tony Chang  <tony@chromium.org>
894
895         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
896         https://bugs.webkit.org/show_bug.cgi?id=96136
897
898         Reviewed by Ojan Vafai.
899
900         When we renamed the file to TestExpectations, it was no longer considered a text file so
901         it was no longer being checked. Since then, test_expectations_overrides() has been removed
902         from the port object, so I've removed that from the check. I'm not sure what it was
903         supposed to do.
904
905         * Scripts/webkitpy/style/checker.py:
906         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
907         * Scripts/webkitpy/style/checkers/test_expectations.py:
908         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
909         (TestExpectationsChecker.check): Remove overrides param.
910         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
911         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
912
913 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
914
915         [EFL] Use same default minimum logical font size in DRT and WTR
916         https://bugs.webkit.org/show_bug.cgi?id=96116
917
918         Reviewed by Martin Robinson.
919
920         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
921         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
922         logical font size to 9 to match the value used in WTR.
923         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
924         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
925         logical font size to 9 (default value in WK2)
926
927 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
928
929         MediaStream API: add RTCPeerConnection::createAnswer
930         https://bugs.webkit.org/show_bug.cgi?id=96092
931
932         Reviewed by Adam Barth.
933
934         Expanding and enhancing MockWebRTCPeerConnectionHandler.
935
936         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
937         (MockWebRTCPeerConnectionHandler::createOffer):
938         (MockWebRTCPeerConnectionHandler::createAnswer):
939         (MockWebRTCPeerConnectionHandler::setLocalDescription):
940         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
941         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
942         (MockWebRTCPeerConnectionHandler):
943
944 2012-09-07  Dean Jackson  <dino@apple.com>
945
946         Unreviewed changes to watchlist.
947
948         - Add new WebGL and Filters definitions
949         - Add myself to OpenGL bugs
950
951         * Scripts/webkitpy/common/config/watchlist:
952
953 2012-09-07  Peter Beverloo  <peter@chromium.org>
954
955         Actually trigger the Android Tester
956         https://bugs.webkit.org/show_bug.cgi?id=96118
957
958         Reviewed by Adam Barth.
959
960         * BuildSlaveSupport/build.webkit.org-config/config.json:
961
962 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
963
964         New time input needs accessibility
965         https://bugs.webkit.org/show_bug.cgi?id=96032
966
967         Reviewed by Chris Fleizach.
968
969         Add support for valueDescription for testing.
970
971         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
972         (getValueDescription):
973         (AccessibilityUIElement::AccessibilityUIElement):
974         (AccessibilityUIElement::valueDescriptionGetterCallback):
975         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
976         (AccessibilityUIElement):
977
978 2012-09-07  Peter Beverloo  <peter@chromium.org>
979
980         Add the google-android-tests build slave to the master's config
981         https://bugs.webkit.org/show_bug.cgi?id=96113
982
983         Reviewed by Csaba Osztrogonác.
984
985         * BuildSlaveSupport/build.webkit.org-config/config.json:
986
987 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
988
989         [WK2] [EFL] Set theme for WebKit2 API test runner
990         https://bugs.webkit.org/show_bug.cgi?id=96100
991
992         Reviewed by Kenneth Rohde Christiansen.
993
994         Set the theme generated by the build for the WebKit2 API test runner.
995
996         * TestWebKitAPI/PlatformEfl.cmake:
997         * TestWebKitAPI/efl/PlatformWebView.cpp:
998         (TestWebKitAPI::PlatformWebView::PlatformWebView):
999
1000 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1001
1002         Unreviewed. Add Gábor Ballabás as contributor.
1003
1004         * Scripts/webkitpy/common/config/committers.py:
1005
1006 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1007
1008         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
1009         https://bugs.webkit.org/show_bug.cgi?id=96078
1010
1011         Reviewed by Tor Arne Vestbø.
1012
1013         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
1014
1015         * qmake/mkspecs/features/default_pre.prf:
1016
1017 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
1018
1019         [EFL] Add TestExpectations file for efl-wk1
1020         https://bugs.webkit.org/show_bug.cgi?id=96019
1021
1022         Reviewed by Gyuyoung Kim.
1023
1024         Update TestExpectations cascading for EFL port
1025         so that we use efl-wk1 -> efl search paths
1026         for WebKit1 EFL.
1027
1028         * Scripts/webkitpy/layout_tests/port/efl.py:
1029         (EflPort._search_paths):
1030
1031 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
1032
1033         [NRWT] XvfbDriver should stop the Xvfb more aggressively
1034         https://bugs.webkit.org/show_bug.cgi?id=95097
1035
1036         Reviewed by Dirk Pranke.
1037
1038         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
1039         terminating the process does not always work as expected, leading to timeouts
1040         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
1041         as it's not removed by the killed Xvfb process.
1042
1043         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
1044         is tested in different circumstances - whether pixel tests are enabled or not,
1045         with an arbitrary worker number or with an Xorg process already running on the system.
1046         The stopping of the driver is tested by checking that the Xvfb process is truly killed
1047         and then set to None.
1048
1049         * BuildSlaveSupport/kill-old-processes:
1050         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
1051         is left running, potentially clogging up a display at a certain position.
1052         * Scripts/webkitpy/common/system/executive_mock.py:
1053         (MockExecutive.__init__):
1054         The _running_pids is now a dictionary with process names as keys and pids
1055         as values.
1056         (MockExecutive.check_running_pid):
1057         Check whether the passed-in pid is in the _running_pids dictionary's values.
1058         (MockExecutive):
1059         (MockExecutive.running_pids):
1060         This method returns the list of all the process pids of which the name passes
1061         through the process_name_filter.
1062         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1063         Use the Executive object of the port's host to check for running pids and open
1064         new subprocesses or kill them throughout the class.
1065         (XvfbDriver._start):
1066         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
1067         start the server process after it's created.
1068         (XvfbDriver.stop):
1069         Now kills the Xvfb process instead of terminating it and waiting for it to close.
1070         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
1071         (XvfbDriverTest):
1072         (XvfbDriverTest.make_driver):
1073         (XvfbDriverTest.assertDriverStartSuccessful):
1074         (XvfbDriverTest.test_start_no_pixel_tests):
1075         (XvfbDriverTest.test_start_pixel_tests):
1076         (XvfbDriverTest.test_start_arbitrary_worker_number):
1077         (XvfbDriverTest.test_start_existing_xorg_process):
1078         (XvfbDriverTest.test_stop):
1079         (XvfbDriverTest.test_stop.FakeXvfbProcess):
1080
1081 2012-09-06  Peter Beverloo  <peter@chromium.org>
1082
1083         Introduce the Chromium Android Release (Tests) bot
1084         https://bugs.webkit.org/show_bug.cgi?id=95980
1085
1086         Reviewed by Adam Barth.
1087
1088         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
1089         which will be running layout tests on actual Android devices. Right now,
1090         four Galaxy Nexus phones are attached.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/config.json:
1093
1094 2012-09-06  James Robinson  <jamesr@chromium.org>
1095
1096         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
1097         https://bugs.webkit.org/show_bug.cgi?id=96007
1098
1099         Reviewed by Adrienne Walker.
1100
1101         Fixes initialization / settings code to use WebCompositorSupport.
1102
1103         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1104         (main):
1105         * DumpRenderTree/chromium/TestShell.cpp:
1106         (TestShell::initialize):
1107         (TestShell::setPerTilePaintingEnabled):
1108
1109 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
1110
1111         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
1112         https://bugs.webkit.org/show_bug.cgi?id=95995
1113
1114         Reviewed by Kenneth Rohde Christiansen.
1115
1116         Provide proper implementation for PlatformWebView::windowFrame()
1117         in EFL's WebKitTestRunner.
1118
1119         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1120         (WTR::PlatformWebView::windowFrame):
1121
1122 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
1123
1124         Fix WTF.Lrint on 32-bit platforms
1125         https://bugs.webkit.org/show_bug.cgi?id=96003
1126
1127         Reviewed by Benjamin Poulain.
1128
1129         Fixed failing WTF.Lrint test on 32-bit platforms.
1130
1131         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1132         (TestWebKitAPI::TEST):
1133
1134 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
1135
1136         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
1137         https://bugs.webkit.org/show_bug.cgi?id=95839
1138
1139         Reviewed by Adam Barth.
1140
1141         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
1142         up the task definitions a bit. There was no need to have them in the header file.
1143
1144         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1145         (RTCSessionDescriptionRequestSuccededTask):
1146         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1147         (RTCSessionDescriptionRequestFailedTask):
1148         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1149         (RTCVoidRequestTask):
1150         (RTCVoidRequestTask::RTCVoidRequestTask):
1151         (MockWebRTCPeerConnectionHandler::createOffer):
1152         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1153         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1154         (MockWebRTCPeerConnectionHandler::localDescription):
1155         (MockWebRTCPeerConnectionHandler::remoteDescription):
1156         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1157         (MockWebRTCPeerConnectionHandler):
1158
1159 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
1160
1161         [Qt] Fix build on Mac OS X 10.6
1162         https://bugs.webkit.org/show_bug.cgi?id=95200
1163
1164         Reviewed by Tor Arne Vestbø.
1165
1166         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
1167         10.7 and newer.
1168
1169         * qmake/mkspecs/features/features.prf:
1170
1171 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
1172
1173         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
1174         https://bugs.webkit.org/show_bug.cgi?id=95973
1175
1176         Reviewed by Kenneth Rohde Christiansen.
1177
1178         Correctly map "addSelectionKey" to "Control" modifier
1179         in WKTR's EventSender on other OSes than Mac OS X,
1180         instead of mapping it to the "Meta" modifier.
1181
1182         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1183         (WTR::parseModifier):
1184
1185 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
1186
1187         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
1188         https://bugs.webkit.org/show_bug.cgi?id=95710
1189
1190         Reviewed by Dirk Pranke.
1191
1192         The stdout / stderr output can be None so make sure
1193         we won't raise an exception in this case.
1194
1195         * Scripts/webkitpy/layout_tests/port/driver.py:
1196         (Driver.run_test):
1197
1198 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
1199
1200         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
1201         https://bugs.webkit.org/show_bug.cgi?id=95849
1202
1203         Reviewed by Kenneth Rohde Christiansen.
1204
1205         Sanitize URLs passed by the user as program
1206         argument or typed in the URL bar in order to
1207         be more tolerant.
1208
1209         * EWebLauncher/CMakeLists.txt:
1210         * EWebLauncher/main.c:
1211         (main):
1212         * EWebLauncher/url_bar.c:
1213         (_url_bar_url_get_with_protocol):
1214         (on_urlbar_key_down):
1215         * EWebLauncher/url_utils.c: Added.
1216         (has_scheme):
1217         (url_from_user_input): Add utility function to construct a
1218         URL from user input.
1219         * EWebLauncher/url_utils.h: Added.
1220         * MiniBrowser/efl/CMakeLists.txt:
1221         * MiniBrowser/efl/main.c:
1222         (main):
1223
1224 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
1225
1226         [Qt] Various small Windows / MSVC build fixes
1227         https://bugs.webkit.org/show_bug.cgi?id=95934
1228
1229         Reviewed by Kenneth Rohde Christiansen.
1230
1231         setFocus takes a boolean as argument: Don't try to implicitly convert
1232         an enum to a boolean, MSVC doesn't like that. The intent here is to
1233         enable focus, so just pass true.
1234
1235         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1236         (WTR::PlatformWebView::focus):
1237
1238 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
1239
1240         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
1241         https://bugs.webkit.org/show_bug.cgi?id=95965
1242
1243         Reviewed by Tor Arne Vestbø.
1244
1245         Add ANGLE as a static library module to the Qt WebKit build system.
1246
1247         * qmake/mkspecs/features/default_post.prf:
1248         * qmake/mkspecs/modules/angle.prf: Added.
1249
1250 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
1251
1252         [WK2] Make [Qt]ViewportHandler cross platform
1253         https://bugs.webkit.org/show_bug.cgi?id=91257
1254
1255         Reviewed by Kenneth Rohde Christiansen.
1256
1257         Remove initial scale from viewport info item since it is
1258         set to -1 after applied thus it does not hold any valuable
1259         information.
1260
1261         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1262
1263 2012-09-05  Tony Chang  <tony@chromium.org>
1264
1265         [chromium] Remove dependency on webkit_user_agent
1266         https://bugs.webkit.org/show_bug.cgi?id=95886
1267
1268         Reviewed by Adam Barth.
1269
1270         The code isn't used by DumpRenderTree.
1271
1272         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1273
1274 2012-09-05  Rick Byers  <rbyers@chromium.org>
1275
1276         Update chromium DumpRenderTree for new WebGestureEvent fields
1277         https://bugs.webkit.org/show_bug.cgi?id=95573
1278
1279         Reviewed by James Robinson.
1280
1281         Update EventSender to write gesture details into the appropriate
1282         type-specific WebGestureEvent fields.
1283         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
1284         (EventSender::gestureEvent):
1285         (EventSender::gestureFlingStart):
1286
1287 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
1288
1289         NRWT lies about the number of tests that it's skipping when used with --repeat-each
1290         https://bugs.webkit.org/show_bug.cgi?id=95789
1291
1292         Reviewed by Ojan Vafai.
1293
1294         Fix miscalculation in log message.
1295
1296         * Scripts/webkitpy/layout_tests/views/printing.py:
1297         (Printer.print_found):
1298
1299 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
1300
1301         Unreviewed, rolling out r127612, r127660, and r127664.
1302         http://trac.webkit.org/changeset/127612
1303         http://trac.webkit.org/changeset/127660
1304         http://trac.webkit.org/changeset/127664
1305         https://bugs.webkit.org/show_bug.cgi?id=95920
1306
1307         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1308         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
1309         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
1310         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
1311         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
1312         (MockWebRTCPeerConnectionHandler::createOffer):
1313         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1314         (MockWebRTCPeerConnectionHandler):
1315         (SuccessCallbackTask):
1316         (FailureCallbackTask):
1317
1318 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1319
1320         Ignore-metrics includes scroll offsets.
1321         https://bugs.webkit.org/show_bug.cgi?id=95845
1322
1323         Reviewed by Dirk Pranke.
1324
1325         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
1326
1327         * Scripts/old-run-webkit-tests:
1328         (stripMetrics):
1329         * Scripts/webkitpy/layout_tests/port/driver.py:
1330         (DriverOutput):
1331
1332 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
1333
1334         Unreviewed test fix.
1335
1336         Including a plugin source file into the build that was added in r127595.
1337
1338         * GNUmakefile.am:
1339
1340 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
1341
1342         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
1343         https://bugs.webkit.org/show_bug.cgi?id=95839
1344
1345         Reviewed by Adam Barth.
1346
1347         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
1348         up the task definitions a bit. There was no need to have them in the header file.
1349
1350         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1351         (RTCSessionDescriptionRequestSuccededTask):
1352         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1353         (RTCSessionDescriptionRequestFailedTask):
1354         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1355         (RTCVoidRequestTask):
1356         (RTCVoidRequestTask::RTCVoidRequestTask):
1357         (MockWebRTCPeerConnectionHandler::createOffer):
1358         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1359         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1360         (MockWebRTCPeerConnectionHandler::localDescription):
1361         (MockWebRTCPeerConnectionHandler::remoteDescription):
1362         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1363         (MockWebRTCPeerConnectionHandler):
1364
1365 2012-09-05  Kangil Han  <kangil.han@samsung.com>
1366
1367         [EFL] Remove '+=' usage in String
1368         https://bugs.webkit.org/show_bug.cgi?id=95808
1369
1370         Reviewed by Benjamin Poulain.
1371
1372         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
1373
1374         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1375         (descriptionSuitableForTestResult):
1376
1377 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
1378
1379         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
1380         https://bugs.webkit.org/show_bug.cgi?id=95842
1381
1382         Reviewed by Kenneth Rohde Christiansen.
1383
1384         Provide proper implementation for TestRunner::pathToLocalResource()
1385         in EFL WKTR, identical to the one for DumpRenderTree.
1386
1387         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
1388         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
1389         are found my WebKitTestRunner.
1390
1391         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1392         (WTR::TestRunner::pathToLocalResource):
1393
1394 2012-09-05  Brady Eidson  <beidson@apple.com>
1395
1396         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
1397         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
1398
1399         Reviewed by Andy Estes.
1400
1401         Add a plug-in that always fails to initialize:
1402         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
1403         (NPPNewFails):
1404         (NPPNewFails::NPPNewFails):
1405         (NPPNewFails::NPP_New):
1406
1407         Add it to all the project files:
1408         * DumpRenderTree/DumpRenderTree.gypi:
1409         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1410         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1411         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1412         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1413
1414 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1415
1416         [Qt] Fix makefile race condition between derived sources and target
1417
1418         r121966 removed too much of the old qmake logic, including the rule
1419         that ensured that qmake_all would not trigger dual runs of qmake --
1420         one of the derived sources -qmake-all rule, and one for making the
1421         derived sources.
1422
1423         We now follow a similar pattern as before, by introducing a custom
1424         target that explicitly depends on the derived sources' qmake-all before
1425         doing a manual run of make. That ensures a single qmake run for the derived
1426         sources.
1427
1428         https://bugs.webkit.org/show_bug.cgi?id=93847
1429
1430         Reviewed by Csaba Osztrogonác.
1431
1432         * qmake/mkspecs/features/functions.prf:
1433
1434 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
1435
1436         WKTR doesn't implement dumpWillCacheResponse()
1437         https://bugs.webkit.org/show_bug.cgi?id=94607
1438
1439         Reviewed by Kenneth Rohde Christiansen.
1440
1441         Define shouldCacheResponse() callback in resource
1442         load client and provide implementation for
1443         dumpWillCacheResponse() in WebKitTestRunner.
1444
1445         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1446         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1447         (WTR::InjectedBundlePage::InjectedBundlePage):
1448         (WTR::InjectedBundlePage::shouldCacheResponse):
1449         (WTR):
1450         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1451         (InjectedBundlePage):
1452         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1453         (WTR::TestRunner::TestRunner):
1454         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1455         (WTR::TestRunner::dumpWillCacheResponse):
1456         (WTR::TestRunner::shouldDumpWillCacheResponse):
1457         (TestRunner):
1458
1459 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1460
1461         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
1462         https://bugs.webkit.org/show_bug.cgi?id=92735
1463
1464         Reviewed by Hajime Morita.
1465
1466         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
1467
1468         * DumpRenderTree/TestRunner.cpp:
1469         (TestRunner::staticFunctions):
1470         * DumpRenderTree/TestRunner.h:
1471         (TestRunner):
1472         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1473         (TestRunner::addUserStyleSheet):
1474         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1475         (DRTTestRunner::DRTTestRunner):
1476         (DRTTestRunner::hasCustomPageSizeStyle):
1477         * DumpRenderTree/chromium/DRTTestRunner.h:
1478         (DRTTestRunner):
1479         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1480         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1481         * DumpRenderTree/mac/TestRunnerMac.mm:
1482         * DumpRenderTree/qt/TestRunnerQt.cpp:
1483         (TestRunner::evaluateScriptInIsolatedWorld):
1484         * DumpRenderTree/qt/TestRunnerQt.h:
1485         (TestRunner):
1486         * DumpRenderTree/win/TestRunnerWin.cpp:
1487         * DumpRenderTree/wx/TestRunnerWx.cpp:
1488         (TestRunner::abortModal):
1489         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1490         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1491         (WTR):
1492         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1493         (TestRunner):
1494
1495 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
1496
1497         [Qt] Automate the use of AllInOne files in the Qt build
1498         https://bugs.webkit.org/show_bug.cgi?id=95837
1499
1500         Reviewed by Tor Arne Vestbø.
1501
1502         New feature file that implements the all-in-one file automation by
1503         adding the requested all-in-one files to SOURCES and removing the files
1504         it includes from SOURCES.
1505
1506         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
1507
1508 2012-09-04  Tim Horton  <timothy_horton@apple.com>
1509
1510         Have NRWT log more output when crash logs are missing
1511         https://bugs.webkit.org/show_bug.cgi?id=95814
1512
1513         Reviewed by Dan Bernstein.
1514
1515         Log the stderr and stdout of the test, in order to provide slightly more
1516         context when the WebProcess times out while running tests.
1517
1518         * Scripts/webkitpy/layout_tests/port/driver.py:
1519         (Driver.run_test):
1520
1521 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
1522
1523         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
1524         https://bugs.webkit.org/show_bug.cgi?id=95770
1525
1526         Reviewed by Adam Barth.
1527
1528         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1529         (ChromiumAndroidDriver.__init__):
1530         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
1531         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
1532         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
1533         (ChromiumAndroidDriver._push_executable):
1534         (ChromiumAndroidDriver._push_fonts):
1535         (ChromiumAndroidDriver._push_test_resources):
1536         (ChromiumAndroidDriver._run_adb_command):
1537         (ChromiumAndroidDriver._get_last_stacktrace):
1538         (ChromiumAndroidDriver._get_crash_log):
1539         (ChromiumAndroidDriver._start):
1540         (ChromiumAndroidDriver._start_once):
1541         (ChromiumAndroidDriver._start_once.deadlock_detector):
1542         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1543         (ChromiumAndroidDriverTest.test_get_crash_log):
1544
1545 2012-09-04  Satish Sampath  <satish@chromium.org>
1546
1547         Run git commands within the checkout directory
1548         https://bugs.webkit.org/show_bug.cgi?id=95742
1549
1550         Reviewed by Eric Seidel.
1551
1552         git commands run from scm/git.py are sometimes run with cwd set to the
1553         checkout_root and other times with whatever directory was the default cwd.
1554         Instead all these should run with the checkout root set as the cwd
1555         (except where we explicitly need a different path)
1556
1557         * Scripts/webkitpy/common/checkout/scm/git.py:
1558         (Git._run_git):
1559         (Git.find_checkout_root):
1560         (Git.discard_local_commits):
1561         (Git.local_commits):
1562         (Git.working_directory_is_clean):
1563         (Git.clean_working_directory):
1564         (Git.add_list):
1565         (Git.delete_list):
1566         (Git.exists):
1567         (Git._current_branch):
1568         (Git._changes_files_for_commit):
1569         (Git.revisions_changing_file):
1570         (Git.svn_revision):
1571         (Git._run_git_svn_find_rev):
1572         (Git.contents_at_revision):
1573         (Git.diff_for_file):
1574         (Git.show_head):
1575         (Git.committer_email_for_revision):
1576         (Git.apply_reverse_diff):
1577         (Git.revert_files):
1578         (Git.commit_with_message):
1579         (Git._commit_on_branch):
1580         (Git.svn_commit_log):
1581         (Git.last_svn_commit_log):
1582         (Git.svn_blame):
1583         (Git._branch_ref_exists):
1584         (Git.delete_branch):
1585         (Git.remote_merge_base):
1586         (Git.commit_locally_with_message):
1587         (Git.push_local_commits_to_server):
1588         (Git.commit_ids_from_commitish_arguments):
1589         (Git.commit_message_for_local_commit):
1590         (Git.files_changed_summary_for_commit):
1591
1592 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
1593
1594         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
1595         https://bugs.webkit.org/show_bug.cgi?id=95734
1596
1597         Reviewed by Adam Barth.
1598
1599         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1600         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
1601         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
1602         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
1603         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
1604         (MockWebRTCPeerConnectionHandler::createOffer):
1605         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1606         (MockWebRTCPeerConnectionHandler):
1607         (MockWebRTCPeerConnectionHandler::taskList):
1608         (SuccessCallbackTask):
1609         (FailureCallbackTask):
1610
1611 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
1612
1613         [Chromium-Android] Output time and thread info in crash log
1614         https://bugs.webkit.org/show_bug.cgi?id=95768
1615
1616         Reviewed by Adam Barth.
1617
1618         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1619         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
1620
1621 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
1622
1623         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
1624         https://bugs.webkit.org/show_bug.cgi?id=95721
1625
1626         Reviewed by Adam Barth.
1627
1628         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
1629         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
1630         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
1631         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
1632         (MockWebMediaStreamCenter):
1633
1634 2012-09-04  Tony Chang  <tony@chromium.org>
1635
1636         Elide test names when running new-run-webkit-tests
1637         https://bugs.webkit.org/show_bug.cgi?id=95626
1638
1639         Reviewed by Dirk Pranke.
1640
1641         When the test name exceeds the number of terminal columns, it leaves
1642         text on the screen. Avoid this by eliding the test name when running
1643         tests. This is similar to what ninja does when compiling.
1644
1645         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1646         (MeteredStream):
1647         (MeteredStream.number_of_columns): Helper method to get number of
1648         terminal columns. Won't work on Win32 python, but meh.
1649         * Scripts/webkitpy/layout_tests/views/printing.py:
1650         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
1651         because stderr appears to be ascii only.
1652         (Printer.print_started_test): Route through _test_status_line.
1653         (Printer.print_finished_test): Route through _test_status_line.
1654         (Printer._print_test_trace): Route through _test_status_line.
1655         (Printer._print_baseline): Route through _test_status_line.
1656         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1657         (test_test_status_line): Test for _test_status_line.
1658
1659 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
1660
1661         [GTK] Print API missing documentation when generating gtkdoc
1662         https://bugs.webkit.org/show_bug.cgi?id=95703
1663
1664         Reviewed by Carlos Garcia Campos.
1665
1666         Print out API missing documentation when generating gtkdoc. This makes it
1667         easier to fix documentation errors.
1668
1669         * gtk/generate-gtkdoc:
1670         (print_missing_api): Added.
1671         (generate_doc): Inline the rebase step, since it now reports an error
1672         when you try to rebase without generating documentation first.
1673         * gtk/gtkdoc.py:
1674         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
1675         generating documentation first to enable a small cleanup at the caller.
1676         (GTKDoc.api_missing_documentation): Added.
1677
1678 2012-09-04  Vincent Scheib  <scheib@chromium.org>
1679
1680         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
1681         https://bugs.webkit.org/show_bug.cgi?id=95628
1682
1683         Reviewed by James Robinson.
1684
1685         Future tests need the ability to respond asynchronously that
1686         pointer lock requests have been accepted or rejected. This patch
1687         adds the following:
1688             testRunner.setPointerLockWillRespondAsynchronously();
1689             testRunner.didAcquirePointerLock();
1690             testRunner.didNotAcquirePointerLock();
1691
1692         Tested in existing test:
1693             pointerlockchange-pointerlockerror-events.html
1694
1695         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1696         (DRTTestRunner::DRTTestRunner):
1697         (DRTTestRunner::didAcquirePointerLock):
1698         (DRTTestRunner::didNotAcquirePointerLock):
1699         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
1700         * DumpRenderTree/chromium/DRTTestRunner.h:
1701         (DRTTestRunner):
1702         * DumpRenderTree/chromium/WebViewHost.cpp:
1703         (WebViewHost::requestPointerLock):
1704         (WebViewHost::didAcquirePointerLock):
1705         (WebViewHost::didNotAcquirePointerLock):
1706         * DumpRenderTree/chromium/WebViewHost.h:
1707         (WebViewHost):
1708         (WebViewHost::setPointerLockWillRespondAsynchronously):
1709
1710 2012-09-04  Ojan Vafai  <ojan@chromium.org>
1711
1712         Move content shell bots to their own builder group
1713         https://bugs.webkit.org/show_bug.cgi?id=95765
1714
1715         Reviewed by Adam Barth.
1716
1717         In their current state of instability, they add too much noise. Once they get more stable,
1718         we can add them back to the regular group or just have them replace the other bots.
1719
1720         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
1721
1722         * TestResultServer/static-dashboards/builders.js:
1723         (isWebkitTestRunner):
1724         (isChromiumContentShellTestRunner):
1725         (isChromiumWebkitTipOfTreeTestRunner):
1726         (loadBuildersList):
1727
1728 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
1729
1730         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
1731         https://bugs.webkit.org/show_bug.cgi?id=95689
1732
1733         Reviewed by Kenneth Rohde Christiansen.
1734
1735         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
1736         So, there are bugs that key events are always generated in url bar although
1737         the user clicked the web view.
1738
1739         This patch recovers the focus of the web view when left button is pressed and
1740         adds for MiniBrowser to toggle the focus when middle button is pressed
1741         like EWebLauncher already did.
1742
1743         * EWebLauncher/main.c:
1744         (on_mouse_down):
1745         * MiniBrowser/efl/main.c:
1746         (on_mouse_down):
1747         (browserCreate):
1748
1749 2012-09-03  Tao Bai  <michaelbai@chromium.org>
1750
1751         Added ANDROID_GDBSERVER definition for Ant
1752         https://bugs.webkit.org/show_bug.cgi?id=95265
1753
1754         Reviewed by Adam Barth.
1755
1756         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
1757         is only used for finding the gdbserver.
1758
1759         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1760         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1761
1762 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
1763
1764         MediaStream API: Add Ice-related functionality to RTCPeerConnection
1765         https://bugs.webkit.org/show_bug.cgi?id=95565
1766
1767         Reviewed by Adam Barth.
1768
1769         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1770         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1771         (MockWebRTCPeerConnectionHandler::updateICE):
1772         (MockWebRTCPeerConnectionHandler::addICECandidate):
1773         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1774         (MockWebRTCPeerConnectionHandler):
1775
1776 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
1777
1778         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
1779         https://bugs.webkit.org/show_bug.cgi?id=95670
1780
1781         Reviewed by Kenneth Rohde Christiansen.
1782
1783         Fix layout issues related to the URL bar in Minibrowser
1784         and EWebLauncher when the window is resized.
1785
1786         The URL bar was not resized accordingly and the Web
1787         page was moved behing the URL bar, hiding part of it.
1788
1789         * EWebLauncher/main.c:
1790         (on_ecore_evas_resize):
1791         (closeWindow):
1792         * EWebLauncher/url_bar.c:
1793         (url_bar_width_set):
1794         (url_bar_add):
1795         * EWebLauncher/url_bar.h:
1796         * MiniBrowser/efl/main.c:
1797         (on_ecore_evas_resize):
1798         (main):
1799
1800 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1801
1802         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
1803         https://bugs.webkit.org/show_bug.cgi?id=95605
1804
1805         Reviewed by Dirk Pranke.
1806
1807         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
1808
1809         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1810         (ChromiumAndroidPort.check_sys_deps):
1811         (ChromiumAndroidPort.expectations_files):
1812         (ChromiumAndroidPort.clean_up_test_run):
1813
1814 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
1815
1816         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
1817         https://bugs.webkit.org/show_bug.cgi?id=95180
1818
1819         Reviewed by Chris Fleizach.
1820
1821         The bug that was fixed stood in the way of fully implementing stringValue().
1822         Testing that the bug is fixed requires stringValue() to be fully implemented
1823         and object replacement characters to be printable.
1824
1825         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1826         (replaceCharactersForResults): New method which turns object replacement
1827         characters into "<obj>" so that the characters can be properly shown in
1828         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
1829         accessible text of a single object in the accessible tree doesn't mess up
1830         the readibility of the results.
1831         (AccessibilityUIElement::stringValue): Remove the code that immediately
1832         returned upon encountering an object of ATK_ROLE_PANEL and call the new
1833         replaceCharactersForResults() prior to returning the accessible string
1834         value.
1835
1836 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
1837
1838         MediaStream API: Add MediaStream management to RTCPeerConnection
1839         https://bugs.webkit.org/show_bug.cgi?id=95543
1840
1841         Reviewed by Adam Barth.
1842
1843         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
1844
1845         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1846         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1847         (MockWebRTCPeerConnectionHandler::addStream):
1848         (MockWebRTCPeerConnectionHandler::removeStream):
1849         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1850         (MockWebRTCPeerConnectionHandler):
1851
1852 2012-08-31  Tony Chang  <tony@chromium.org>
1853
1854         Remove ENABLE_CSS3_FLEXBOX compile time flag
1855         https://bugs.webkit.org/show_bug.cgi?id=95382
1856
1857         Reviewed by Ojan Vafai.
1858
1859         Everyone is already enabling this by default and the spec has stablized.
1860
1861         * Scripts/webkitperl/FeatureList.pm:
1862         * qmake/mkspecs/features/features.pri:
1863
1864 2012-08-31  Pratik Solanki  <psolanki@apple.com>
1865
1866         objc_msgSend and IMP should be cast appropriately before using
1867         https://bugs.webkit.org/show_bug.cgi?id=95242
1868
1869         Reviewed by Benjamin Poulain.
1870
1871         Fix for older compilers. Pass id as the return type to the template
1872         instead of relying on default type.
1873
1874         * DumpRenderTree/mac/DumpRenderTree.mm:
1875         (drt_NSFontManager_availableFontFamilies):
1876         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1877         (WTR::wtr_NSFontManager_availableFontFamilies):
1878
1879 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
1880
1881         nrwt: use scm instead of calling svn directly to get the revision in json results generator
1882         https://bugs.webkit.org/show_bug.cgi?id=89616
1883
1884         Reviewed by Eric Seidel.
1885
1886         Add the new 'executive' optional function argument to the SCM.in_working_directory
1887         class method. This way we get to reuse an Executive instance which is necessary in testing
1888         when we're operating with a mock version of the object.
1889
1890         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
1891         the SCMDetector with the generator's FileSystem and Executive instances.
1892
1893         * Scripts/webkitpy/common/checkout/scm/detection.py:
1894         (SCMDetector.detect_scm_system):
1895         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1896         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
1897         Executive output and test it against expected output.
1898         * Scripts/webkitpy/common/checkout/scm/git.py:
1899         (Git.in_working_directory):
1900         * Scripts/webkitpy/common/checkout/scm/scm.py:
1901         (SCM.in_working_directory):
1902         * Scripts/webkitpy/common/checkout/scm/svn.py:
1903         (SVN.in_working_directory):
1904         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1905         (JSONResultsGeneratorBase.__init__):
1906         (JSONResultsGeneratorBase._get_svn_revision):
1907
1908 2012-08-31  Jon Lee  <jonlee@apple.com>
1909
1910         [Tests] Add basic tests to http/tests/notifications
1911         https://bugs.webkit.org/show_bug.cgi?id=95493
1912         <rdar://problem/12209303>
1913
1914         Reviewed by Alexey Proskuryakov.
1915
1916         Add permission request support for WTR.
1917
1918         * WebKitTestRunner/TestController.cpp:
1919         (WTR::TestController::initialize):
1920         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
1921         * WebKitTestRunner/TestController.h:
1922         (TestController):
1923
1924 2012-08-31  Jon Lee  <jonlee@apple.com>
1925
1926         [DRT] Make simulating a web click on a notification a queued task
1927         https://bugs.webkit.org/show_bug.cgi?id=95546
1928         <rdar://problem/12214170>
1929
1930         Reviewed by Alexey Proskuryakov.
1931
1932         Making the web click happen asynchronously better mimics user interaction with the platform.
1933
1934         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
1935         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
1936         not set.
1937         * DumpRenderTree/mac/DumpRenderTree.mm:
1938         (dump): Assert that the flag is not set.
1939         * DumpRenderTree/mac/TestRunnerMac.mm:
1940         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
1941         notification. In the case where the block gets executed after the flag has been unset, we avoid
1942         performing the click.
1943
1944 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
1945
1946         [Qt] ImageDiff output is not in the expected form if image dimensions differ
1947         https://bugs.webkit.org/show_bug.cgi?id=95575
1948
1949         Reviewed by Csaba Osztrogonác.
1950
1951         Output 100% difference in the case of differing image dimensions so
1952         the test harness knows that we won't produce any output further.
1953         This matches the behavior of other ports.
1954
1955         * DumpRenderTree/qt/ImageDiff.cpp:
1956         (main):
1957
1958 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1959
1960         Unreviewed, rolling out r127261.
1961         http://trac.webkit.org/changeset/127261
1962         https://bugs.webkit.org/show_bug.cgi?id=95572
1963
1964         This patch depends on other build fixes (see blockers of bug
1965         95466) which should land first (Requested by milian on
1966         #webkit).
1967
1968         * qmake/mkspecs/features/features.prf:
1969
1970 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
1971
1972         [Qt] Support WebKit2/QML on QNX
1973         https://bugs.webkit.org/show_bug.cgi?id=95466
1974
1975         Reviewed by Noam Rosenthal.
1976
1977         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
1978         this should finally work now.
1979
1980         * qmake/mkspecs/features/features.prf:
1981
1982 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
1983
1984         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
1985         https://bugs.webkit.org/show_bug.cgi?id=95400
1986
1987         Reviewed by Dirk Pranke.
1988
1989         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
1990
1991         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1992         (ChromiumAndroidPort.skipped_layout_tests):
1993
1994 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
1995
1996         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
1997         https://bugs.webkit.org/show_bug.cgi?id=95499
1998
1999         Unreviewed. One more fix to avoid trying to run the empty string.
2000
2001         * Scripts/webkitdirs.pm:
2002         (buildAutotoolsProject):
2003
2004 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2005
2006         Unreviewed, rolling out r127171.
2007         http://trac.webkit.org/changeset/127171
2008         https://bugs.webkit.org/show_bug.cgi?id=95505
2009
2010         testRunner does not need dumpWebNotificationCallbacks().
2011         (Requested by jonlee on #webkit).
2012
2013         * DumpRenderTree/TestRunner.cpp:
2014         (TestRunner::TestRunner):
2015         (TestRunner::staticFunctions):
2016         * DumpRenderTree/TestRunner.h:
2017         (TestRunner):
2018         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2019         (-[MockWebNotificationProvider webView:didShowNotification:]):
2020         (-[MockWebNotificationProvider webView:didClickNotification:]):
2021         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
2022         * DumpRenderTree/mac/UIDelegate.mm:
2023         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
2024
2025 2012-08-30  Pratik Solanki  <psolanki@apple.com>
2026
2027         objc_msgSend and IMP should be cast appropriately before using
2028         https://bugs.webkit.org/show_bug.cgi?id=95242
2029
2030         Reviewed by Benjamin Poulain.
2031
2032         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
2033         to a function pointer with right types when calling objc_msgSend and an
2034         IMP method directly.
2035
2036         * DumpRenderTree/mac/DumpRenderTree.mm:
2037         (drt_NSFontManager_availableFontFamilies):
2038         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2039         (WTR::wtr_NSFontManager_availableFontFamilies):
2040
2041 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
2042
2043         Replace JSC::UString by WTF::String
2044         https://bugs.webkit.org/show_bug.cgi?id=95271
2045
2046         Reviewed by Geoffrey Garen.
2047
2048         Get rid of UString.
2049
2050         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2051         * gdb/webkit.py:
2052         (WTFStringPrinter.to_string):
2053         (JSCIdentifierPrinter.to_string):
2054         (JSCJSStringPrinter.to_string):
2055         (add_pretty_printers):
2056
2057 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2058
2059         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
2060         https://bugs.webkit.org/show_bug.cgi?id=95495
2061
2062         Reviewed by Ojan Vafai.
2063
2064         This is a follow-on to bug 95370 that adds in support for
2065         platform/wk2/TestExpectations and
2066         platform/{mac,win}-$version/TestExpectations.
2067
2068         * Scripts/webkitpy/layout_tests/port/apple.py:
2069         (ApplePort.expectations_files):
2070         * Scripts/webkitpy/layout_tests/port/base.py:
2071         (Port._skipped_file_search_paths):
2072         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2073         (MacTest.test_expectations_files):
2074         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2075         (MockDRTPortTest.make_port):
2076         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2077         (WinPortTest.test_expectations_files):
2078
2079 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2080
2081         executive.run_in_parallel() hangs if given nothing to do
2082         https://bugs.webkit.org/show_bug.cgi?id=95387
2083
2084         Reviewed by Ojan Vafai.
2085
2086         Check to make sure that Executive.run_in_parallel() requires
2087         a non-empty list of commands to execute; passing an empty list
2088         seems surely like a programming error.
2089
2090         * Scripts/webkitpy/common/system/executive.py:
2091         (Executive.run_in_parallel):
2092         * Scripts/webkitpy/common/system/executive_unittest.py:
2093         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
2094
2095 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2096
2097         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
2098         https://bugs.webkit.org/show_bug.cgi?id=94746
2099
2100         Reviewed by Ojan Vafai.
2101
2102         Add an assertion to diff_image() to check that we are passing
2103         tolerance=0 explicitly when diffing ref test results.
2104
2105         * Scripts/webkitpy/layout_tests/port/test.py:
2106         (TestPort.diff_image):
2107
2108 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2109
2110         NRWT should look in mac-wk2 for a TestExpecations file
2111         https://bugs.webkit.org/show_bug.cgi?id=95370
2112
2113         Reviewed by Ojan Vafai.
2114
2115         Adds support for mac-wk2 and win-wk2 to expectations_files()
2116         for the apple mac and apple win ports.
2117         
2118         * Scripts/webkitpy/layout_tests/port/apple.py:
2119         (ApplePort.expectations_files):
2120         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2121         (MacTest.test_expectations_files):
2122         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2123         (WinTest.test_expectations_files):
2124         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2125         (PortTestCase.test_expectations_files):
2126
2127 2012-08-30  Jon Lee  <jonlee@apple.com>
2128
2129         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
2130         https://bugs.webkit.org/show_bug.cgi?id=95232
2131         <rdar://problem/12190776>
2132
2133         Reviewed by Alexey Proskuryakov.
2134
2135         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
2136
2137         * DumpRenderTree/TestRunner.cpp:
2138         (TestRunner::TestRunner):
2139         (dumpWebNotificationCallbacksCallback):
2140         (TestRunner::staticFunctions):
2141         * DumpRenderTree/TestRunner.h:
2142         (TestRunner):
2143         (TestRunner::dumpWebNotificationCallbacks):
2144         (TestRunner::setDumpWebNotificationCallbacks):
2145         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2146         (-[WebNotification _drt_descriptionSuitableForTestResult]):
2147         (-[MockWebNotificationProvider webView:didShowNotification:]):
2148         (-[MockWebNotificationProvider webView:didClickNotification:]):
2149         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
2150         * DumpRenderTree/mac/UIDelegate.mm:
2151         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
2152
2153 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
2154
2155         MediaStream API: Introduce MediaConstraints
2156         https://bugs.webkit.org/show_bug.cgi?id=95198
2157
2158         Reviewed by Adam Barth.
2159
2160         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
2161
2162         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2163         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2164         (isSupportedConstraint):
2165         (isValidConstraint):
2166         (MockWebRTCPeerConnectionHandler::initialize):
2167         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2168         (MockWebRTCPeerConnectionHandler):
2169
2170 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2171
2172         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
2173         https://bugs.webkit.org/show_bug.cgi?id=95454
2174
2175         Reviewed by Kenneth Rohde Christiansen.
2176
2177         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
2178
2179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2180         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2181
2182 2012-08-30  Leo Yang  <leoyang@rim.com>
2183
2184         Update my email address.
2185
2186         Not reviewed.
2187
2188         * Scripts/webkitpy/common/config/committers.py:
2189
2190 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
2191
2192         [NRWT] Add support for recognizing arbitrary process names in crash lines
2193         https://bugs.webkit.org/show_bug.cgi?id=95435
2194
2195         Reviewed by Adam Barth.
2196
2197         When running layout tests in the chromium port using the content shell,
2198         we want to be able to report sub-process crashes as well.
2199
2200         * Scripts/webkitpy/layout_tests/port/driver.py:
2201         (Driver._check_for_driver_crash):
2202         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2203         (DriverTest.test_check_for_driver_crash):
2204
2205 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
2206
2207         Random test-webkitpy failures on the buildbot
2208         https://bugs.webkit.org/show_bug.cgi?id=95096
2209
2210         Reviewed by Dirk Pranke.
2211
2212         Suppress occasional errors when running test-webkitpy on GTK builders
2213         by running these tests serially. The 64-bit Release builder is especially
2214         prone to these as it can run up to 24 tests in parallel.
2215
2216         Despite the tests not being run in parallel, the testing only lasts a handful
2217         of seconds more, so this is a worthy trade-off to avoid unnecessary
2218         false-alarm redness on the GTK builders.
2219
2220         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2221         (RunPythonTests.start):
2222
2223 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
2224
2225         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
2226         https://bugs.webkit.org/show_bug.cgi?id=95380
2227
2228         Reviewed by Michael Saboff.
2229
2230         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2231         Add very basic tests for String::ascii(). This covers the case of null strings that caused
2232         the crash.
2233
2234 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2235
2236         AX: Canvas should have a distinct role
2237         https://bugs.webkit.org/show_bug.cgi?id=95248
2238
2239         Reviewed by Chris Fleizach.
2240
2241         Add support for canvas accessibility role.
2242
2243         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2244         (roleToString):
2245
2246 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
2247
2248         [Gtk] Process Gtk 3.4 smooth scroll events properly
2249         https://bugs.webkit.org/show_bug.cgi?id=88070
2250
2251         Added continousMouseScrollBy support in WebKitTestRunner, and added
2252         implementation for gtk, and stub for Qt, mac and EFL.
2253
2254         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
2255         scroll for emulating multi-tick mouseScrollBy events.
2256
2257         Reviewed by Martin Robinson.
2258
2259         * DumpRenderTree/gtk/EventSender.cpp:
2260         (mouseScrollByCallback):
2261         (continuousMouseScrollByCallback):
2262         * WebKitTestRunner/EventSenderProxy.h:
2263         (EventSenderProxy):
2264         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2265         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2266         (WTR::EventSendingController::mouseScrollBy):
2267         (WTR):
2268         (WTR::EventSendingController::continuousMouseScrollBy):
2269         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2270         (EventSendingController):
2271         * WebKitTestRunner/TestController.cpp:
2272         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2273         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2274         (WTR):
2275         (WTR::EventSenderProxy::mouseScrollBy):
2276         (WTR::EventSenderProxy::continuousMouseScrollBy):
2277         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2278         (WTR):
2279         (WTR::EventSenderProxy::continuousMouseScrollBy):
2280         * WebKitTestRunner/mac/EventSenderProxy.mm:
2281         (WTR::EventSenderProxy::continuousScrollBy):
2282         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2283         (WTR::EventSenderProxy::continuousMouseScrollBy):
2284         (WTR):
2285
2286 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
2287
2288         [chromium] Support high DIP pixel tests with DumpRenderTree
2289         https://bugs.webkit.org/show_bug.cgi?id=94935
2290
2291         Reviewed by James Robinson.
2292
2293         Adding device scale factor into the drt image dumping code
2294
2295         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2296         (DRTTestRunner::reset):
2297         (DRTTestRunner::setBackingScaleFactor):
2298         * DumpRenderTree/chromium/WebViewHost.cpp:
2299         (WebViewHost::setDeviceScaleFactor):
2300         (WebViewHost::paintInvalidatedRegion):
2301         (WebViewHost::canvas):
2302         * DumpRenderTree/chromium/WebViewHost.h:
2303         (WebViewHost):
2304
2305 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
2306
2307         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
2308         https://bugs.webkit.org/show_bug.cgi?id=95177
2309
2310         Reviewed by Dirk Pranke.
2311
2312         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
2313
2314         * Scripts/webkitpy/common/checkout/scm/git.py:
2315
2316 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
2317
2318         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
2319         https://bugs.webkit.org/show_bug.cgi?id=95222
2320
2321         Reviewed by Adam Barth.
2322
2323         The code we had to remove REBASELINE lines from the
2324         TestExpectations files did not handle multiple files (in a
2325         cascade) correctly; we weren't limiting lines to a particular
2326         file correctly in without_rebaseline_modifier(). This patch
2327         fixes that and corrects the tests (which weren't correct and
2328         didn't cover things very well).
2329
2330         Note also that the webkit-patch rebaseline-commands are still
2331         using the include_overrides=False option in a couple places;
2332         this is never correct or needed at this point. This patch fixes
2333         the usage for webkit-patch rebaseline-expectations, but I still
2334         need to fix rebaseline-test-internal, which I will do in a
2335         separate patch (see bug 95268).
2336
2337         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2338         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2339         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2340         (RebaseliningTest.assertRemove):
2341         (RebaseliningTest.test_remove):
2342         * Scripts/webkitpy/tool/commands/rebaseline.py:
2343         (RebaselineExpectations._update_expectations_files):
2344
2345 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
2346
2347         webkit-patch rebaseline-expectations hangs
2348         https://bugs.webkit.org/show_bug.cgi?id=95243
2349
2350         Reviewed by Tony Chang.
2351
2352         Don't try to run no commands in parallel; report an error
2353         instead that we didn't find any tests to rebaseline.
2354
2355         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
2356
2357         * Scripts/webkitpy/tool/commands/rebaseline.py:
2358         (RebaselineExpectations.execute):
2359         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2360         (_assert_command):
2361         (test_rebaseline_expectations_noop):
2362
2363 2012-08-29  Brady Eidson  <beidson@apple.com>
2364
2365         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
2366         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
2367
2368         Reviewed by Sam Weinig.
2369
2370         Add a test plug-in that calls back into the page with info on the NPWindow passed
2371         in to NPP_SetWindow.
2372
2373         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2374         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
2375         (LogNPPSetWindow):
2376         (LogNPPSetWindow::LogNPPSetWindow):
2377         (LogNPPSetWindow::NPP_SetWindow):
2378
2379 2012-08-29  Jon Lee  <jonlee@apple.com>
2380
2381         [Mac] Basic DRT support for web notifications
2382         https://bugs.webkit.org/show_bug.cgi?id=79492
2383         <rdar://problem/10357639>
2384
2385         Reviewed by Alexey Proskuryakov.
2386
2387         This patch implements the stubs for web notification support on DRT. Assume that when
2388         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
2389         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
2390
2391         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
2392         * DumpRenderTree/mac/DumpRenderTree.mm:
2393         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
2394         web view.
2395         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
2396
2397         * DumpRenderTree/mac/TestRunnerMac.mm:
2398         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
2399         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
2400         (TestRunner::removeAllWebNotificationPermissions):
2401         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
2402         simulate the click. This is similar to how WTR performs the click.
2403         * DumpRenderTree/mac/UIDelegate.mm:
2404         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
2405         user allows web notifications.
2406
2407         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
2408         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
2409         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
2410         (+[MockWebNotificationProvider shared]): The provider is a singleton.
2411         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
2412         (-[MockWebNotificationProvider registerWebView:]):
2413         (-[MockWebNotificationProvider unregisterWebView:]):
2414         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
2415         notification did show.
2416         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
2417         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
2418         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
2419         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
2420         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
2421         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
2422         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
2423         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
2424         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
2425         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
2426         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
2427
2428 2012-08-29  Rob Buis  <rbuis@rim.com>
2429
2430         [BlackBerry] Adjust wtf include header style
2431         https://bugs.webkit.org/show_bug.cgi?id=95368
2432
2433         Reviewed by Yong Li.
2434
2435         Switch to #include <wtf/...> like the other ports.
2436
2437         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2438         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
2439         * DumpRenderTree/blackberry/PNGImageEncoder.h:
2440         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2441         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
2442         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
2443
2444 2012-08-29  Roger Fong  <roger_fong@apple.com>
2445
2446         Update cygwin-downloader.zip to match modified downloader script.
2447         https://bugs.webkit.org/show_bug.cgi?id=76936
2448
2449         Rubber Stamped by Jon Honeycutt.
2450
2451         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
2452         Updating zip to reflect changes.
2453
2454         * CygwinDownloader/cygwin-downloader.zip:
2455
2456 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
2457
2458         Stylechecker warns about comparison to zero when comparing to 0.5
2459         https://bugs.webkit.org/show_bug.cgi?id=94913
2460
2461         Reviewed by Dirk Pranke.
2462
2463         According to the python documentation, \W is the character group with all
2464         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
2465         to [^\w]. We need to exclude the dot "." as well, so that floating point
2466         values do not trigger this warning. Adding a unit test that shows the problem.
2467
2468         * Scripts/webkitpy/style/checkers/cpp.py:
2469         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
2470         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2471         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
2472
2473 2012-08-29  Jon Lee  <jonlee@apple.com>
2474
2475         WTR build fixes.
2476
2477         * WebKitTestRunner/CMakeLists.txt:
2478         * WebKitTestRunner/GNUmakefile.am:
2479         * WebKitTestRunner/Target.pri:
2480         * WebKitTestRunner/WebNotificationProvider.cpp:
2481         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
2482         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2483
2484 2012-08-29  Jon Lee  <jonlee@apple.com>
2485
2486         [WK2] Basic WTR support for web notifications
2487         https://bugs.webkit.org/show_bug.cgi?id=95154
2488         <rdar://problem/12184492>
2489
2490         Reviewed by Alexey Proskuryakov.
2491
2492         Implement WTR support, without platform event output (bug 95233).
2493
2494         Legacy APIs will not be supported, since many of the tests are skipped
2495         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
2496         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
2497         the tests to http/tests/notifications.
2498
2499         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
2500         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
2501         be invoked from the UIProcess.
2502
2503         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2504         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2505         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
2506         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
2507         notification's internal ID.
2508         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2509         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2510         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
2511         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
2512         (WTR::TestRunner::removeAllWebNotificationPermissions):
2513         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
2514         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2515
2516         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
2517         class.
2518         * WebKitTestRunner/TestInvocation.cpp:
2519         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
2520         TestInvocation forwards that request to the TestController.
2521         * WebKitTestRunner/TestController.cpp:
2522         (WTR::TestController::initialize): Set the provider.
2523         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
2524         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
2525         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
2526
2527         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
2528         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
2529         * WebKitTestRunner/WebNotificationProvider.h: Added.
2530         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
2531         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
2532         the notification got shown.
2533         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
2534         got closed.
2535         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
2536         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
2537         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
2538         permissions. For testing purposes, we always want this set to be empty.
2539         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
2540         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
2541
2542         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
2543
2544 2012-08-29  Kamil Blank  <k.blank@samsung.com>
2545
2546         [EFL] Add setting API for allow universal/file access from file URLs.
2547         https://bugs.webkit.org/show_bug.cgi?id=83121
2548
2549         Reviewed by Eric Seidel.
2550
2551         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
2552
2553         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2554         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2555         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2556         (TestRunner::setAllowUniversalAccessFromFileURLs):
2557         (TestRunner::setAllowFileAccessFromFileURLs):
2558
2559 2012-08-29  Jon Lee  <jonlee@apple.com>
2560
2561         Update TestRunner API for web notifications
2562         https://bugs.webkit.org/show_bug.cgi?id=95093
2563         <rdar://problem/12179649>
2564
2565         Reviewed by Alexey Proskuryakov.
2566
2567         As it turns out the patch for this accidentally got squashed into the commit for
2568         bug 95099 (r126909). This amendment patch adds some comments about the renaming
2569         of the older TestRunner API for web notifications.
2570
2571         * DumpRenderTree/TestRunner.h:
2572         (TestRunner):
2573
2574 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2575
2576         Unreviewed, rolling out r126972.
2577         http://trac.webkit.org/changeset/126972
2578         https://bugs.webkit.org/show_bug.cgi?id=95349
2579
2580         accessibility/canvas-description-and-role.html has been
2581         failing consistently on several bots and Dominic needs some
2582         time to investigate why (Requested by jchaffraix on #webkit).
2583
2584         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2585         (roleToString):
2586
2587 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
2588
2589         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2590         https://bugs.webkit.org/show_bug.cgi?id=84707
2591
2592         Reviewed by Gustavo Noronha Silva.
2593
2594         Most of the warnings have been fixed now that FindCairo.cmake and
2595         FindGLIB.cmake have been rewritten. The remaining one, related to
2596         FindFontconfig.cmake, shows up when building on a 64-bit
2597         Debian-based systems.
2598
2599         jhbuild installs libraries into lib64/ by default on 64-bit Linux
2600         installations, while CMake does not look for libraries in lib64/
2601         when /etc/debian_version exists on the system. The FIND_LIBRARY()
2602         would then sometimes end up using the system installation instead of
2603         the jhbuild one, causing mismatches and, when pkg-config is not used
2604         at all, failing to find libraries altogether.
2605
2606         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
2607         when use_lib64 is set to force CMake to look into lib64/ regardless
2608         of the presence of /etc/debian_version.
2609
2610 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
2611
2612         The 2d.imageData.object.round canvas test is failing
2613         https://bugs.webkit.org/show_bug.cgi?id=40272
2614
2615         Reviewed by Benjamin Poulain.
2616
2617         Updating patch to address Benjamin's review comments.
2618         Adding a WTF test to test lrint implementation.
2619
2620         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
2621         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
2622         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
2623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
2624         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
2625         (TestWebKitAPI):
2626         (TestWebKitAPI::TEST):
2627         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
2628
2629 2012-08-29  Florin Malita  <fmalita@chromium.org>
2630
2631         Unreviewed, updating Kelly Norton's email address at his request.
2632
2633         * Scripts/webkitpy/common/config/committers.py:
2634
2635 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2636
2637         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
2638         https://bugs.webkit.org/show_bug.cgi?id=93723
2639
2640         Reviewed by Dirk Pranke.
2641
2642         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2643         (TestExpectationParser.expectation_for_skipped_test):
2644         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2645         (SkippedTests.test_skipped_entry_dont_exist):
2646
2647 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2648
2649         Unreviewed, rolling out r120113.
2650         http://trac.webkit.org/changeset/120113
2651         https://bugs.webkit.org/show_bug.cgi?id=95320
2652
2653         Wrong fix for the problem, experimentally rolling it out for
2654         bug 95237. (Requested by rakuco on #webkit).
2655
2656         * efl/jhbuildrc:
2657
2658 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2659
2660         AX: Canvas should have a distinct role
2661         https://bugs.webkit.org/show_bug.cgi?id=95248
2662
2663         Reviewed by Chris Fleizach.
2664
2665         Add support for canvas accessibility role.
2666
2667         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2668         (roleToString):
2669
2670 2012-08-28  Eric Seidel  <eric@webkit.org>
2671
2672         cr-ews bot doesn't set CWD correctly when zipping layout test results
2673         https://bugs.webkit.org/show_bug.cgi?id=91265
2674
2675         Reviewed by Kenneth Russell.
2676
2677         This should make the zips slightly less cumbersome to deal with.
2678
2679         * Scripts/webkitpy/common/system/workspace.py:
2680         (Workspace.create_zip):
2681         * Scripts/webkitpy/common/system/workspace_unittest.py:
2682         (WorkspaceTest.test_create_zip):
2683         (WorkspaceTest.test_create_zip_exception):
2684
2685 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
2686
2687         Fix the Commiters script
2688
2689         Unreviewed.
2690
2691         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
2692
2693         * Scripts/webkitpy/common/config/committers.py:
2694
2695 2012-08-28  Roger Fong  <roger_fong@apple.com>
2696
2697         Unreviewed. Adding myself to committers list.
2698
2699         * Scripts/webkitpy/common/config/committers.py:
2700
2701 2012-08-28  Roger Fong  <roger_fong@apple.com>
2702
2703         Add minires to list of required cygwin install packages.
2704         https://bugs.webkit.org/show_bug.cgi?id=76936
2705
2706         Reviewed by Tim Horton.
2707
2708         * CygwinDownloader/cygwin-downloader.py:
2709
2710 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2711
2712         [Chromium-Android] Upstream layout test expectations (Part 2)
2713         https://bugs.webkit.org/show_bug.cgi?id=95212
2714
2715         Reviewed by Adam Barth.
2716
2717         - Now run both gpu path and non-gpu path of 2d canvas layout tests
2718         because both are used in chromium-android.
2719
2720         - Exclude all webgl tests because webgl is not enabled yet.
2721
2722         - Removed 'win' from the baseline fallback list. This was a mistake.
2723
2724         - Moved some small directories to TestExpectations from skipped_layout_tests().
2725
2726         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2727         (ChromiumAndroidPort):
2728         (ChromiumAndroidPort.skipped_layout_tests):
2729
2730 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
2731
2732         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
2733         https://bugs.webkit.org/show_bug.cgi?id=95185
2734
2735         Reviewed by Chris Fleizach.
2736
2737         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2738         (AccessibilityUIElement::titleUIElement): Implemented
2739         Gets the ATK_RELATION_LABELLED_BY target.
2740         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
2741         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
2742         bug 95180 is fixed.
2743
2744 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
2745
2746         AX: Crash due to object getting deleted inside updateBackingStore
2747         https://bugs.webkit.org/show_bug.cgi?id=94619
2748
2749         Reviewed by Chris Fleizach.
2750
2751         Change isValid to !isDetached after deleting isValid from
2752         chromium WebAccessibilityObject as being redundant.
2753
2754         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2755         (AccessibilityUIElement::isValidGetterCallback):
2756
2757 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2758
2759         Unreviewed, rolling out r126914.
2760         http://trac.webkit.org/changeset/126914
2761         https://bugs.webkit.org/show_bug.cgi?id=95239
2762
2763         it breaks everything and fixes nothing (Requested by pizlo on
2764         #webkit).
2765
2766         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2767         (MockWebSpeechInputController::addMockRecognitionResult):
2768         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2769         (NotificationPresenter::simulateClick):
2770         (NotificationPresenter::show):
2771         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
2772         (CppBoundClass::~CppBoundClass):
2773         (CppBoundClass::invoke):
2774         (CppBoundClass::getProperty):
2775         (CppBoundClass::setProperty):
2776         (CppBoundClass::bindCallback):
2777         (CppBoundClass::bindProperty):
2778         * DumpRenderTree/chromium/WebPreferences.cpp:
2779         (applyFontMap):
2780         * DumpRenderTree/chromium/WebViewHost.cpp:
2781         (WebViewHost::printResourceDescription):
2782         * DumpRenderTree/mac/TestRunnerMac.mm:
2783         (worldIDForWorld):
2784         (TestRunner::evaluateScriptInIsolatedWorld):
2785         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2786         (AccessibilityController::~AccessibilityController):
2787         (AccessibilityController::winNotificationReceived):
2788         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2789         (ResourceLoadDelegate::descriptionSuitableForTestResult):
2790         * DumpRenderTree/win/TestRunnerWin.cpp:
2791         (worldIDForWorld):
2792         (TestRunner::evaluateScriptInIsolatedWorld):
2793         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2794         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
2795         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2796         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
2797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2798         (WTR::TestRunner::worldIDForWorld):
2799         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
2800
2801 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2802
2803         Rename first/second to key/value in HashMap iterators
2804         https://bugs.webkit.org/show_bug.cgi?id=82784
2805
2806         Reviewed by Eric Seidel.
2807
2808         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2809         (MockWebSpeechInputController::addMockRecognitionResult):
2810         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2811         (NotificationPresenter::simulateClick):
2812         (NotificationPresenter::show):
2813         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
2814         (CppBoundClass::~CppBoundClass):
2815         (CppBoundClass::invoke):
2816         (CppBoundClass::getProperty):
2817         (CppBoundClass::setProperty):
2818         (CppBoundClass::bindCallback):
2819         (CppBoundClass::bindProperty):
2820         * DumpRenderTree/chromium/WebPreferences.cpp:
2821         (applyFontMap):
2822         * DumpRenderTree/chromium/WebViewHost.cpp:
2823         (WebViewHost::printResourceDescription):
2824         * DumpRenderTree/mac/TestRunnerMac.mm:
2825         (worldIDForWorld):
2826         (TestRunner::evaluateScriptInIsolatedWorld):
2827         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2828         (AccessibilityController::~AccessibilityController):
2829         (AccessibilityController::winNotificationReceived):
2830         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2831         (ResourceLoadDelegate::descriptionSuitableForTestResult):
2832         * DumpRenderTree/win/TestRunnerWin.cpp:
2833         (worldIDForWorld):
2834         (TestRunner::evaluateScriptInIsolatedWorld):
2835         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2836         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
2837         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2838         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
2839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2840         (WTR::TestRunner::worldIDForWorld):
2841         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
2842
2843 2012-08-27  Jon Lee  <jonlee@apple.com>
2844
2845         Update TestRunner API for web notifications
2846         https://bugs.webkit.org/show_bug.cgi?id=95093
2847         <rdar://problem/12179649>
2848
2849         Reviewed by Jessie Berlin.
2850
2851         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
2852
2853         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
2854         This first patch renames the TestRunner calls to use the term "web notifications" instead of
2855         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
2856         additional calls that will be used in the tests that test the standard API.
2857
2858         * DumpRenderTree/TestRunner.h:
2859         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
2860         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
2861         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
2862         (TestRunner::TestRunner):
2863         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
2864         (simulateLegacyWebNotificationClickCallback): Renamed.
2865         (grantWebNotificationPermissionCallback): Renamed.
2866         (denyWebNotificationPermissionCallback): Added.
2867         (removeAllWebNotificationPermissionsCallback): Added.
2868         (simulateWebNotificationClickCallback): Added.
2869         (TestRunner::staticFunctions):
2870         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
2871
2872         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2873         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
2874         (DRTTestRunner::grantWebNotificationPermission):
2875         (DRTTestRunner::denyWebNotificationPermission): Stub.
2876         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
2877         (DRTTestRunner::simulateWebNotificationClick): Stub.
2878         (DRTTestRunner::simulateLegacyWebNotificationClick):
2879         * DumpRenderTree/chromium/DRTTestRunner.h:
2880         (DRTTestRunner):
2881
2882         Added stubs.
2883         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2884         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2885         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2886         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
2887         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
2888         * DumpRenderTree/win/TestRunnerWin.cpp:
2889
2890 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
2891
2892         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
2893         https://bugs.webkit.org/show_bug.cgi?id=94700
2894
2895         Reviewed by Eric Seidel.
2896
2897         Interrupting download with a timeout would be a possible solution.
2898         I imported the socket module and used the setdefaulttimeout() method.
2899         Fixing it is important, because EWS bots need to be restarted regularly
2900         because of this bug.
2901
2902         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2903         (Bugzilla._get_browser):
2904         (Bugzilla.setdefaulttimeout):
2905
2906 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
2907
2908         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
2909         https://bugs.webkit.org/show_bug.cgi?id=95194
2910
2911         Reviewed by Simon Hausmann.
2912
2913         * Scripts/webkitpy/layout_tests/port/qt.py:
2914         (QtPort.setup_environ_for_server):
2915
2916 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
2917
2918         [watchlist] Unreviewed, subscribe to Qt bugs.
2919
2920         * Scripts/webkitpy/common/config/watchlist:
2921
2922 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
2923
2924         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
2925         https://bugs.webkit.org/show_bug.cgi?id=95054
2926
2927         Reviewed by Eric Seidel.
2928
2929         Enable CSS_IMAGE_SET for the Qt build.
2930
2931         * qmake/mkspecs/features/features.pri:
2932
2933 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
2934
2935         [Qt] Enable CSS sticky position
2936         https://bugs.webkit.org/show_bug.cgi?id=95172
2937
2938         Reviewed by Simon Hausmann.
2939
2940         * qmake/mkspecs/features/features.pri:
2941
2942 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
2943
2944         [GTK] Memory cache should be cleared in between test runs
2945         https://bugs.webkit.org/show_bug.cgi?id=95105
2946
2947         Reviewed by Martin Robinson.
2948
2949         Call the new DumpRenderTreeSupportGtk helper method after every test
2950         to clear the memory cache.
2951
2952         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2953         (runTest):
2954
2955 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2956
2957         Unreviewed, rolling out r126836.
2958         http://trac.webkit.org/changeset/126836
2959         https://bugs.webkit.org/show_bug.cgi?id=95163
2960
2961         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
2962         #webkit).
2963
2964         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2965         (MockWebSpeechInputController::addMockRecognitionResult):
2966         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2967         (NotificationPresenter::simulateClick):
2968         (NotificationPresenter::show):
2969         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
2970         (CppBoundClass::~CppBoundClass):
2971         (CppBoundClass::invoke):
2972         (CppBoundClass::getProperty):
2973         (CppBoundClass::setProperty):
2974         (CppBoundClass::bindCallback):
2975         (CppBoundClass::bindProperty):
2976         * DumpRenderTree/chromium/WebPreferences.cpp:
2977         (applyFontMap):
2978         * DumpRenderTree/chromium/WebViewHost.cpp:
2979         (WebViewHost::printResourceDescription):
2980         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2981         (AccessibilityController::~AccessibilityController):
2982         (AccessibilityController::winNotificationReceived):
2983         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2984         (ResourceLoadDelegate::descriptionSuitableForTestResult):
2985         * DumpRenderTree/win/TestRunnerWin.cpp:
2986         (worldIDForWorld):
2987         (TestRunner::evaluateScriptInIsolatedWorld):
2988         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2989         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
2990         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2991         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
2992         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2993         (WTR::TestRunner::worldIDForWorld):
2994         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
2995
2996 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2997
2998         Rename first/second to key/value in HashMap iterators
2999         https://bugs.webkit.org/show_bug.cgi?id=82784
3000
3001         Reviewed by Eric Seidel.
3002
3003         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3004         (MockWebSpeechInputController::addMockRecognitionResult):
3005         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3006         (NotificationPresenter::simulateClick):
3007         (NotificationPresenter::show):
3008         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3009         (CppBoundClass::~CppBoundClass):
3010         (CppBoundClass::invoke):
3011         (CppBoundClass::getProperty):
3012         (CppBoundClass::setProperty):
3013         (CppBoundClass::bindCallback):
3014         (CppBoundClass::bindProperty):
3015         * DumpRenderTree/chromium/WebPreferences.cpp:
3016         (applyFontMap):
3017         * DumpRenderTree/chromium/WebViewHost.cpp:
3018         (WebViewHost::printResourceDescription):
3019         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3020         (AccessibilityController::~AccessibilityController):
3021         (AccessibilityController::winNotificationReceived):
3022         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3023         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3024         * DumpRenderTree/win/TestRunnerWin.cpp:
3025         (worldIDForWorld):
3026         (TestRunner::evaluateScriptInIsolatedWorld):
3027         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3028         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
3029         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3030         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
3031         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3032         (WTR::TestRunner::worldIDForWorld):
3033         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3034
3035 2012-08-24  James Robinson  <jamesr@chromium.org>
3036
3037         WebGL should not flip textures on presentation if contents are unchanged
3038         https://bugs.webkit.org/show_bug.cgi?id=94961
3039
3040         Reviewed by Kenneth Russell.
3041
3042         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
3043
3044         * Scripts/webkitpy/layout_tests/port/chromium.py:
3045         (ChromiumPort.virtual_test_suites):
3046
3047 2012-08-27  Gavin Peters  <gavinp@chromium.org>
3048
3049         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
3050         https://bugs.webkit.org/show_bug.cgi?id=95104
3051
3052         Reviewed by Adam Barth.
3053
3054         Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
3055
3056         * Scripts/webkitpy/common/net/omahaproxy.py:
3057         (OmahaProxy):
3058         (OmahaProxy.get_revisions):
3059         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
3060         (OmahaProxyTest):
3061         (OmahaProxyTest.test_get_revisions):
3062
3063 2012-08-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3064
3065         [EFL][WK2] Free Url_Bar on program exit
3066         https://bugs.webkit.org/show_bug.cgi?id=95086
3067
3068         Reviewed by Eric Seidel.
3069
3070         Fix a memory leak by freeing the Url_Bar on program exit.
3071
3072         * MiniBrowser/efl/main.c:
3073         (main): Call url_bar_del() to free the Url_Bar.
3074
3075 2012-08-27  James Robinson  <jamesr@chromium.org>
3076
3077         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
3078         https://bugs.webkit.org/show_bug.cgi?id=95115
3079
3080         Reviewed by Adam Barth.
3081
3082         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
3083         code if the unit tests crash.
3084
3085         * Scripts/run-chromium-webkit-unit-tests:
3086
3087 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
3088
3089         Add ECMAScript Number to String conversion to WTF::String
3090         https://bugs.webkit.org/show_bug.cgi?id=95016
3091
3092         Reviewed by Geoffrey Garen.
3093
3094         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3095         (TestWebKitAPI::testNumberToStringECMAScript):
3096         (TestWebKitAPI): Add tests for String's ECMAString number conversion.
3097
3098 2012-08-27  Philippe Normand  <pnormand@igalia.com>
3099
3100         [GStreamer][Qt] WebAudio support
3101         https://bugs.webkit.org/show_bug.cgi?id=94806
3102
3103         Reviewed by Simon Hausmann.
3104
3105         * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
3106
3107 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3108
3109         Rename RegisterProtocolHandler API to NavigatorContentUtils
3110         https://bugs.webkit.org/show_bug.cgi?id=94920
3111
3112         Reviewed by Adam Barth.
3113
3114         Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
3115
3116         * Scripts/webkitperl/FeatureList.pm:
3117         * qmake/mkspecs/features/features.pri:
3118
3119 2012-08-24  Benjamin Poulain  <bpoulain@apple.com>
3120
3121         Unify Number to StringImpl conversion
3122         https://bugs.webkit.org/show_bug.cgi?id=94879
3123
3124         Reviewed by Geoffrey Garen.
3125
3126         Add testing for the new IntegerToStringConversion.
3127
3128         * TestWebKitAPI/CMakeLists.txt:
3129         * TestWebKitAPI/GNUmakefile.am:
3130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3131         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
3132
3133 2012-08-23  James Robinson  <jamesr@chromium.org>
3134
3135         [chromium] Convert WebLayerTreeView interface into pure virtual
3136         https://bugs.webkit.org/show_bug.cgi?id=94866
3137
3138         Reviewed by Adrienne Walker.
3139
3140         Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
3141         tests.
3142
3143         * DumpRenderTree/DumpRenderTree.gypi:
3144         * DumpRenderTree/chromium/WebViewHost.cpp:
3145         (WebViewHost::createOutputSurface):
3146         * DumpRenderTree/chromium/WebViewHost.h:
3147         (WebViewHost):
3148         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
3149         (WebKit):
3150         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
3151         (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
3152         (WebKit::WebViewHostOutputSurface::bindToClient):
3153         (WebKit::WebViewHostOutputSurface::capabilities):
3154         (WebKit::WebViewHostOutputSurface::context3D):
3155         (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
3156         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
3157         (WebKit):
3158         (WebViewHostOutputSurface):
3159
3160 2012-08-24  Xianzhu Wang  <wangxianzhu@chromium.org>
3161
3162         [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
3163         https://bugs.webkit.org/show_bug.cgi?id=94865
3164
3165         Reviewed by Dirk Pranke.
3166
3167         Android detects crash of test by checking if the return value of read() is None.
3168         Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
3169         If set, ServerProcess will set _crashed unconditionaly when there is no data.
3170
3171         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3172         (ChromiumAndroidPort.__init__):
3173         (ChromiumAndroidPort):
3174         (ChromiumAndroidPort._android_server_process_constructor):
3175         (ChromiumAndroidDriver._start_once):
3176         * Scripts/webkitpy/layout_tests/port/server_process.py:
3177         (ServerProcess.__init__):
3178         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3179
3180 2012-08-24  Arnaud Renevier  <a.renevier@sisa.samsung.com>
3181
3182         build-webkit --gtk fails with Can't exec ""
3183         https://bugs.webkit.org/show_bug.cgi?id=94944
3184
3185         Reviewed by Martin Robinson.
3186
3187         When jhbuild wrapper is not needed, do unshift a blank string to build
3188         arguments.
3189
3190         * Scripts/webkitdirs.pm:
3191         (runAutogenForAutotoolsProjectIfNecessary):
3192
3193 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
3194
3195         MediaStream API: Add readyState functionality to RTCPeerConnection
3196         https://bugs.webkit.org/show_bug.cgi?id=94813
3197
3198         Reviewed by Adam Barth.
3199
3200         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3201         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3202         (MockWebRTCPeerConnectionHandler::stop):
3203         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3204         (MockWebRTCPeerConnectionHandler):
3205
3206 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
3207
3208         Unreviewed. Adding myself to committers list.
3209
3210         Also updated email information.
3211
3212         * Scripts/webkitpy/common/config/committers.py:
3213
3214 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
3215
3216         [Qt][WK2] Make viewport related experimental.test properties encapsulated.
3217         https://bugs.webkit.org/show_bug.cgi?id=88320
3218
3219         Reviewed by Kenneth Rohde Christiansen.
3220
3221         Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
3222
3223         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3224
3225 2012-08-23  Dirk Pranke  <dpranke@chromium.org>
3226
3227         leak detection broken after r126247 on mac
3228         https://bugs.webkit.org/show_bug.cgi?id=94893
3229
3230         Unreviewed, build fix.
3231
3232         Adds is_snowleopard(), is_lion back() in for the mac port. We'll
3233         probably need an is_mountainlion() or equivalent at some point,
3234         I'm guessing (but I've deleted the leopard code).
3235
3236         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3237         (LeakDetector._callstacks_to_exclude_from_leaks):
3238         * Scripts/webkitpy/layout_tests/port/mac.py:
3239         (MacPort):
3240         (MacPort.is_snowleopard):
3241         (MacPort.is_lion):
3242
3243 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
3244
3245         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
3246         https://bugs.webkit.org/show_bug.cgi?id=94871
3247
3248         Reviewed by Benjamin Poulain.
3249
3250         * TestWebKitAPI/TestWebKitAPI.gypi:
3251         Added the missing files to Chromium's build system.
3252
3253 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
3254
3255         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
3256
3257         * Scripts/webkitpy/common/config/watchlist:
3258
3259 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
3260
3261         Replay tests take forever to load
3262         https://bugs.webkit.org/show_bug.cgi?id=94764
3263
3264         Reviewed by Adam Barth.
3265
3266         Don't load about:blank at the beginning. This appears to clog the DRT.
3267
3268         * Scripts/webkitpy/performance_tests/perftest.py:
3269         (ReplayPerfTest.run_single):
3270         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3271         (TestReplayPerfTest.test_run_single):
3272         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
3273
3274 2012-08-23  Kenneth Russell  <kbr@google.com>
3275
3276         Unreviewed, rolling out r126497.
3277         http://trac.webkit.org/changeset/126497
3278         https://bugs.webkit.org/show_bug.cgi?id=94764
3279
3280         Caused webkitpy-test step to start failing.
3281
3282         * Scripts/webkitpy/performance_tests/perftest.py:
3283         (ReplayPerfTest.run_single):
3284
3285 2012-08-23  Emil A Eklund  <eae@chromium.org>
3286
3287         Add saturation arithmetic support to FractionalLayoutUnit
3288         https://bugs.webkit.org/show_bug.cgi?id=94364
3289
3290         Reviewed by Benjamin Poulain.
3291
3292         Add test for new saturatedArithmetic functions.
3293
3294         * TestWebKitAPI/CMakeLists.txt:
3295         * TestWebKitAPI/GNUmakefile.am:
3296         * TestWebKitAPI/TestWebKitAPI.gypi:
3297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3298         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
3299         (TestWebKitAPI):
3300         (TestWebKitAPI::TEST):
3301         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3302
3303 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
3304
3305         Replay tests take forever to load
3306         https://bugs.webkit.org/show_bug.cgi?id=94764
3307
3308         Reviewed by Adam Barth.
3309
3310         Don't load about:blank at the beginning. This appears to clog the DRT.
3311
3312         * Scripts/webkitpy/performance_tests/perftest.py:
3313         (ReplayPerfTest.run_single):
3314
3315 2012-08-23  Wei Jia  <wjia@chromium.org>
3316
3317         create different WebKit::WebMediaPlayer based on URL
3318         https://bugs.webkit.org/show_bug.cgi?id=91301
3319
3320         Reviewed by Adam Barth.
3321
3322         Pass URL to createMediaPlayer. This corresponds to change in base
3323         class WebKit::WebFrameClient.
3324
3325         * DumpRenderTree/chromium/WebViewHost.cpp:
3326         (WebViewHost::createMediaPlayer): add URL as additional argument.
3327         * DumpRenderTree/chromium/WebViewHost.h:
3328         (WebViewHost):
3329
3330 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3331
3332         Unreviewed, upgrade gyuyoung to reviewer.
3333         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
3334
3335         * Scripts/webkitpy/common/config/committers.py:
3336
3337 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3338
3339         REGRESSION(r126306): it broke the plugin process
3340         https://bugs.webkit.org/show_bug.cgi?id=94797
3341
3342         Reviewed by Xan Lopez.
3343
3344         * GNUmakefile.am:
3345
3346 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
3347
3348         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
3349         https://bugs.webkit.org/show_bug.cgi?id=63966
3350
3351         Reviewed by Kenneth Rohde Christiansen.
3352
3353         EWebLauncher and MiniBrowser/Efl did not have functionality that users
3354         navigates the site which they want.
3355         This patch adds the urlbar and functionality to load url which users want.
3356
3357         * CMakeLists.txt:
3358         Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
3359         * EWebLauncher/CMakeLists.txt:
3360         Added urlbar.c and dependency of urlbar theme.
3361         In addition, changed macro name to THEME_DIR to share the code easily.
3362         * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
3363         * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
3364         * EWebLauncher/main.c:
3365         Implemented to use the urlbar.
3366         In addition, remove unnecessary border of webview to control webview and urlbar easily.
3367         (_ELauncher):
3368         (on_url_changed):
3369         (browserCreate):
3370         (closeWindow):
3371         (findThemePath):
3372         * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
3373         (_url_bar_url_get_with_protocol):
3374         (on_urlbar_key_down):
3375         (on_urlbar_mouse_down):
3376         (on_urlbar_focus_out):
3377         (url_bar_add):
3378         (url_bar_del):
3379         (url_bar_url_set):
3380         * EWebLauncher/url_bar.h: Added.
3381         * MiniBrowser/efl/CMakeLists.txt:
3382         * MiniBrowser/efl/main.c: Implemented to use the urlbar.
3383         (_MiniBrowser):
3384         (on_url_changed):
3385         (browserCreate):
3386
3387 2012-08-23  Balazs Kelemen  <kbalazs@webkit.org>
3388
3389         [nrwt, WTR] Remove workaround for timeout handing from r126062
3390         https://bugs.webkit.org/show_bug.cgi?id=94609
3391
3392         Reviewed by Dirk Pranke.
3393
3394         Don't try to reset state if a timeout occured but inform
3395         the harness that the web process is no longer reliable.
3396
3397         * Scripts/webkitpy/layout_tests/port/driver.py:
3398         (Driver.run_test): Remove the workaround. Furthermore, handle the case when
3399         the pid is unknown.
3400         * WebKitTestRunner/TestController.cpp:
3401         (WTR::TestController::run):
3402         * WebKitTestRunner/TestInvocation.cpp:
3403         (WTR::TestInvocation::invoke):
3404         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
3405         * WebKitTestRunner/TestInvocation.h:
3406         (TestInvocation):
3407
3408 2012-08-23  Ádám Kallai  <kadam@inf.u-szeged.hu>
3409
3410         Unreviewed. Adding myself to committers list.
3411
3412         * Scripts/webkitpy/common/config/committers.py:
3413
3414 2012-08-22  Alexis Menard  <alexis@webkit.org>
3415
3416         Unreviewed update of my email.
3417
3418         * Scripts/webkitpy/common/config/committers.py:
3419         * Scripts/webkitpy/common/config/watchlist:
3420
3421 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
3422
3423         Fix typos in r126374
3424         https://bugs.webkit.org/show_bug.cgi?id=94665
3425         Unreviewed, build fix.
3426
3427         Fix two issues that snuck in, one that caused a crash if there
3428         were no baselines to optimize and one that occurred as a result
3429         of failing to rename a variable when I changed the recursion to
3430         a loop in the previous patch.
3431
3432         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3433         (BaselineOptimizer._optimize_by_pushing_results_up):
3434
3435 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
3436
3437         Baseline optimizer should try to optimize per-port if global optimization fails
3438         https://bugs.webkit.org/show_bug.cgi?id=94665
3439
3440         Reviewed by Adam Barth.
3441
3442         Add a fallback strategy for optimizing baselines if the default
3443         one fails; this one simply attempts to shift baselines up in the
3444         tree and consolidates them if a parent and child in the fallback
3445         path have the same result. This strategy is somewhat flawed in
3446         that we will always put something in a parent dir even if we
3447         "shouldn't"; for example, if chromium-mac produces a different
3448         result from chromium-win and chromium-linux, then the new
3449         algorithm will move the mac result into platform/chromium,
3450         leaving chromium-mac empty. This result is still correct, but
3451         perhaps confusing.
3452
3453         I haven't done much testing of this algorithm yet, so it's not
3454         clear how many cases where this does a better job than the
3455         default algorithm and how many it'll do a worse job.
3456
3457         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3458         (BaselineOptimizer._find_optimal_result_placement):
3459         (BaselineOptimizer._optimize_by_most_specific_common_directory):
3460         (BaselineOptimizer):
3461         (BaselineOptimizer._optimize_by_pushing_results_up):
3462         (BaselineOptimizer._find_in_fallbackpath):
3463         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3464         (BaselineOptimizerTest.test_platform_mac_different):
3465
3466 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
3467
3468         add debug info, another test to webkit-patch optimize-baselines
3469         https://bugs.webkit.org/show_bug.cgi?id=94762
3470
3471         Reviewed by Adam Barth.
3472
3473         This patch adds more debug logging for optimize-baselines so
3474         that you can tell the before and after states and figure out
3475         what the command is actually deciding to do.
3476
3477         Also, this command adds a (disabled) test for the problem in bug
3478         94665. It's disabled because we don't have the fix yet (that
3479         will be posted in a patch to that bug).
3480
3481         There should be no functional changes in this patch apart from
3482         the additional logging.
3483
3484         Note that adding the debug logging exposed a bug in
3485         filesystem_mock.relpath() (that would return None if the path
3486         wasn't a subpath of the start); the real relpath computes a
3487         relpath with parent dirs. Fixing this revealed a bad check in
3488         the style checker's change_directory() call which was checking
3489         for None.
3490
3491         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3492         (BaselineOptimizer._find_optimal_result_placement):
3493         (BaselineOptimizer):
3494         (BaselineOptimizer._optimize_by_most_specific_common_directory):
3495         (BaselineOptimizer._move_baselines):
3496         (BaselineOptimizer.optimize):
3497         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3498         (BaselineOptimizerTest.disabled_test_platform_mac_different):
3499         * Scripts/webkitpy/common/system/filesystem.py:
3500         (FileSystem):
3501         * Scripts/webkitpy/common/system/filesystem_mock.py:
3502         (MockFileSystem):
3503         (MockFileSystem.__init__):
3504         (MockFileSystem.relpath):
3505         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3506         (RealFileSystemTest.test_sep):
3507         * Scripts/webkitpy/style/main.py:
3508         (change_directory):
3509
3510 2012-08-22  Alejandro Piñeiro  <apinheiro@igalia.com>
3511
3512         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
3513         https://bugs.webkit.org/show_bug.cgi?id=73819
3514
3515         Reviewed by Chris Fleizach.
3516
3517         Added a new role, Toggle Button, based on whether aria-pressed is present.
3518         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
3519
3520         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3521         (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
3522
3523 2012-08-23  Victor Carbune  <victor@rosedu.org>
3524
3525         Add myself to the committer list
3526         https://bugs.webkit.org/show_bug.cgi?id=94659
3527
3528         Reviewed by James Robinson.
3529
3530         Added my email and IRC handle.
3531
3532         * Scripts/webkitpy/common/config/committers.py:
3533
3534 2012-08-22  Scott Graham  <scottmg@chromium.org>
3535
3536         Don't unconditionally define NOMINMAX on Windows
3537         https://bugs.webkit.org/show_bug.cgi?id=94742
3538
3539         Reviewed by Adrienne Walker.
3540
3541         Avoids a warning when building on Windows when NOMINMAX is defined
3542         elsewhere or on the command line.
3543
3544         * TestWebKitAPI/config.h:
3545
3546 2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
3547
3548         REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
3549         https://bugs.webkit.org/show_bug.cgi?id=94704
3550
3551         Reviewed by Dirk Pranke.
3552
3553         Use tolerance=0 when acquiring diff image of reftest output.
3554
3555         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3556         (SingleTestRunner._compare_output_with_reference):
3557
3558 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
3559
3560         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
3561         https://bugs.webkit.org/show_bug.cgi?id=93091
3562
3563         Reviewed by Adam Barth.
3564
3565         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
3566         to complete the infrastructure for RTCPeerConnection.
3567
3568         * DumpRenderTree/DumpRenderTree.gypi:
3569         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3570         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
3571         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
3572         (MockWebKitPlatformSupport):
3573         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3574         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3575         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
3576         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3577         (MockWebRTCPeerConnectionHandler::initialize):
3578         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
3579         (WebKit):
3580         (MockWebRTCPeerConnectionHandler):
3581         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3582
3583 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3584
3585         Merge TestExpectationSerializer into TestExpectationLine
3586         https://bugs.webkit.org/show_bug.cgi?id=94638
3587
3588         Reviewed by Dimitri Glazkov.
3589
3590         Moved all methods except, list_to_string which was moved to TestExpectations
3591         from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
3592
3593         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3594         (TestExpectationEditorTests.assert_remove_roundtrip):
3595         (TestExpectationEditorTests.assert_update_roundtrip):
3596         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3597         (ParseError.__repr__):
3598         (TestExpectationLine):
3599         (TestExpectationLine.create_passing_expectation):
3600         (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
3601         (TestExpectationLine.to_csv): Ditto.
3602         (TestExpectationLine._serialize_parsed_expectations): Ditto.
3603         (TestExpectationLine._serialize_parsed_modifiers): Ditto.
3604         (TestExpectationLine._format_line):
3605         (TestExpectations.remove_configuration_from_test):
3606         (TestExpectations.remove_rebaselined_tests):
3607         (TestExpectations.add_skipped_tests):
3608         (TestExpectations):
3609         (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
3610         (TestExpectations.list_to_string.serialize):
3611         (TestExpectations.list_to_string.nones_out):
3612         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3613         (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
3614         (TestExpectationSerializationTests.__init__):
3615         (TestExpectationSerializationTests.assert_round_trip):
3616         (TestExpectationSerializationTests.assert_list_round_trip):
3617         (TestExpectationSerializationTests.test_unparsed_to_string):
3618         (TestExpectationSerializationTests.test_unparsed_list_to_string):
3619         (TestExpectationSerializationTests.test_parsed_to_string):
3620         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
3621         (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
3622         (TestExpectationSerializationTests.test_format_line):
3623         (TestExpectationSerializationTests.test_reconstitute_only_these):
3624         * Scripts/webkitpy/tool/commands/expectations.py:
3625         (OptimizeExpectations.execute):
3626         * Scripts/webkitpy/tool/commands/queries.py:
3627         (PrintExpectations.execute):
3628         (PrintExpectations._format_lines):
3629         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3630         (GardeningExpectationsUpdater.update_expectations):
3631
3632 2012-08-22  Alexandre Elias  <aelias@chromium.org>
3633
3634         Unreviewed, add aelias@chromium.org to committers
3635
3636         I (aelias@chromium.org) have been approved for commit access and Apple
3637         has confirmed receipt of my committer agreement.
3638
3639         * Scripts/webkitpy/common/config/committers.py:
3640
3641 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
3642
3643         [WK2] Support posting injected bundle messages to a page
3644         https://bugs.webkit.org/show_bug.cgi?id=94630
3645
3646         Reviewed by Sam Weinig.
3647
3648         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3649         * TestWebKitAPI/InjectedBundleController.cpp:
3650         (TestWebKitAPI::InjectedBundleController::initialize):
3651         (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
3652         * TestWebKitAPI/InjectedBundleController.h:
3653         * TestWebKitAPI/InjectedBundleTest.h:
3654         (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):