Unreviewed build fix.
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Unreviewed build fix.
4
5         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
6
7         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
8
9 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
10
11         Fix the previous commit, which made both bubbles green.
12
13         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
14         (.status-line.good .bubble):
15         (.status-line.bad .bubble):
16         (.status-line.good .message):
17
18 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
19
20         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
21         https://bugs.webkit.org/show_bug.cgi?id=144929
22
23         Reviewed by Eric Carlson.
24
25         Tweaked colors as I see fit.
26
27         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
28         (.status-line.good .bubble):
29         (.status-line.bad .bubble):
30
31 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
32
33         [Mac] Share cookie storage between UI process and secondary processes
34         https://bugs.webkit.org/show_bug.cgi?id=144820
35         rdar://problem/20572830
36
37         Reviewed by Darin Adler.
38
39         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
40         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
41         for testing.
42
43 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
44
45         Fix internal build configuration issues
46         https://bugs.webkit.org/show_bug.cgi?id=144762
47
48         Reviewed by David Kilzer.
49
50         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
51
52         * DumpRenderTree/mac/Configurations/Base.xcconfig:
53         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
54         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
55         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
56         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
57         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
58         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
59         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
60
61 2015-05-12  David Kilzer  <ddkilzer@apple.com>
62
63         Switch to launching iOS Simulator using bundle ID
64         <rdar://problem/20916096>
65
66         This is required to fix the layout tests on internal bots.
67
68         * Scripts/webkitdirs.pm:
69         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
70         Simulator.  Add FIXME.
71         (quitIOSSimulator): Add FIXME.
72         * Scripts/webkitpy/port/ios.py:
73         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
74         launch iOS Simulator.  Add FIXME.
75         (IOSSimulatorPort.check_sys_deps): Add FIXME.
76
77 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
78
79         Fix run-javascriptcore-tests step on the WinCairo bot
80         https://bugs.webkit.org/show_bug.cgi?id=144866
81
82         Reviewed by Csaba Osztrogonác.
83
84         Catch exception when failing to create soft link, so we can fall back to copy.
85
86         * Scripts/run-jsc-stress-tests:
87
88 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
89
90         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
91         https://bugs.webkit.org/show_bug.cgi?id=116971
92
93         Reviewed by Chris Fleizach.
94
95         Implement rowAtIndex for ATK.
96
97         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
98         (WTR::AccessibilityUIElement::rowAtIndex):
99
100 2015-05-11  Dan Bernstein  <mitz@apple.com>
101
102         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
103
104         Reviewed by Alexey Proskuryakov.
105
106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
107         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
108         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
109         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
110
111 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
112
113         Fix internal build configuration issues
114         https://bugs.webkit.org/show_bug.cgi?id=144762
115
116         Reviewed by Darin Adler.
117
118         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
119
120         * TestWebKitAPI/Configurations/Base.xcconfig:
121         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
122         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
123         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
124         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
125         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
126         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
127
128 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
129
130         [Win] Move Windows build target to Windows 7 (or newer)
131         https://bugs.webkit.org/show_bug.cgi?id=144890
132         <rdar://problem/20707307>
133
134         Reviewed by Anders Carlsson.
135
136         Update linked SDK and minimal Windows level to be compatible with
137         Windows 7 or newer.
138
139         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
140         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
141         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
142         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
143         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
144         * DumpRenderTree/config.h:
145         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
146         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
147         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
148         * WinLauncher/stdafx.h:
149
150 2015-05-11  Commit Queue  <commit-queue@webkit.org>
151
152         Unreviewed, rolling out r184119.
153         https://bugs.webkit.org/show_bug.cgi?id=144888
154
155         broke JSC tests on Apple Windows bots (Requested by kling on
156         #webkit).
157
158         Reverted changeset:
159
160         "Fix run-javascriptcore-tests step on the WinCairo bot"
161         https://bugs.webkit.org/show_bug.cgi?id=144866
162         http://trac.webkit.org/changeset/184119
163
164 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
165
166         run-benchmark should support Dromaeo
167         https://bugs.webkit.org/show_bug.cgi?id=144849
168
169         Reviewed by Chris Dumez.
170
171         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
172         they can take as much as 15 minutes to run each.
173
174         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
175         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
176         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
177         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
178
179 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
180
181         Build fix. jetstream has a local copy, not remote archive.
182
183         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
184
185 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
186
187         run-benchmark should support SunSpider, Kraken and Octane
188         https://bugs.webkit.org/show_bug.cgi?id=144840
189
190         Reviewed by Darin Adler.
191
192         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
193         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
194         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
195         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
196
197         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
198         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
199
200         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
201         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
202
203         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
204         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
205         now has the ability to run an arbitrary "create script".
206
207         * Scripts/run-benchmark:
208         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
209         This also overrides the remote archive URL specified in the plan.
210
211         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
212
213         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
214         JetStreamBenchmarkBuilder.
215
216         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
217         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
218         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
219         _runCreateScript and _applyPatch to clean after themselves.
220         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
221         JetStream, SunSpider, Kraken all use this feature.
222         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
223         the leaf directory name since the latter is not available when a remote ZIP file is used.
224         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
225         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
226         the benchmark name in the patches.
227
228         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
229
230         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
231         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
232         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
233         the browser opens by planName as the plan file no longer contains that.
234
235         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
236         the top directory of JetStream instead of its parent.
237         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
238         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
239         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
240         the top directory of JetStream instead of its parent.
241         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
242         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
243         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
244         done in JetStream.patch.
245         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
246         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
247         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
248         path from the top directory of JetStream as done in JetStream.patch.
249         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
250
251 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
252
253         Fix run-javascriptcore-tests step on the WinCairo bot
254         https://bugs.webkit.org/show_bug.cgi?id=144866
255
256         Reviewed by Darin Adler.
257
258         * Scripts/run-jsc-stress-tests:
259
260 2015-05-11  Alex Christensen  <achristensen@webkit.org>
261
262         [Content Extensions] Support domain-specific rules and exceptions.
263         https://bugs.webkit.org/show_bug.cgi?id=144833
264
265         Reviewed by Darin Adler.
266
267         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
268         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
269         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
270         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
271         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
272         (TestWebKitAPI::mainDocumentRequest):
273         (TestWebKitAPI::subResourceRequest):
274         (TestWebKitAPI::TEST_F):
275         (TestWebKitAPI::checkCompilerError):
276         Added tests for parsing and functionality of if-domain and unless-domain.
277
278 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
279
280         run-benchmark should support Chrome Canary and Firefox Nightly
281         https://bugs.webkit.org/show_bug.cgi?id=144850
282
283         Reviewed by Darin Adler.
284
285         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
286
287         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
288
289         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
290         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
291         (OSXBrowserDriver):
292         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
293         (OSXBrowserDriver.closeBrowsers): Ditto.
294         (OSXBrowserDriver.launchProcess): Ditto.
295         (OSXBrowserDriver.terminateProcesses): Ditto.
296         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
297         (OSXChromeDriver): Removed the unused self.chromePreferences.
298         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
299         (OSXChromeDriver.closeBrowsers): Ditto.
300         (OSXChromeDriver.launchUrl):
301         (OSXChromeCanaryDriver): Added.
302         (OSXChromeCanaryDriver.launchUrl):
303         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
304         (OSXFirefoxDriver): Added.
305         (OSXFirefoxDriver.launchUrl):
306         (OSXFirefoxNightlyDriver): Added.
307         (OSXFirefoxNightlyDriver.launchUrl):
308         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
309         (OSXSafariDriver):
310         (OSXSafariDriver.closeBrowsers):
311
312 2015-05-11  Tim Horton  <timothy_horton@apple.com>
313
314         Page overlay action context override should indicate the source of the request
315         https://bugs.webkit.org/show_bug.cgi?id=144832
316         <rdar://problem/20562594>
317
318         Reviewed by Darin Adler.
319
320         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
321         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
322
323 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
324
325         [GTK] fast/events/page-visibility-transition-test.html is timing out
326         https://bugs.webkit.org/show_bug.cgi?id=114789
327
328         Reviewed by Darin Adler.
329
330         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
331         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
332         requests visibility changes.
333
334 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
335
336         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
337         https://bugs.webkit.org/show_bug.cgi?id=144798
338
339         Reviewed by Darin Adler.
340
341         * efl/install-dependencies:
342
343 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
344
345         Make arguments of run-benchmark more user friendly
346         https://bugs.webkit.org/show_bug.cgi?id=144835
347
348         Reviewed by Darin Adler.
349
350         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
351         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
352         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
353         default values from --platform and --browser as they are required arguments.
354
355         * Scripts/run-benchmark:
356         (main): Made --build-directory optional, and removed default values from --platform and --browser.
357         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
358         are not dynamically obtained via BrowserDriverFactory.
359         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
360         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
361         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
362         run any benchmark in that case.
363         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
364         the specified file isn't a valid relative or an absolute path.
365         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
366         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
367         and browsers.
368         (BrowserDriverFactory.available_browsers): Ditto.
369         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
370         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
371         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
372         browserBuildPath was None.
373         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
374         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
375         so that we can use locally built WebKit to launch Safari.
376
377 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
378
379         Remove the PICTURE_SIZES build flag
380         https://bugs.webkit.org/show_bug.cgi?id=144679
381
382         Reviewed by Benjamin Poulain.
383
384         Removed the PICTURE_SIZES build time flag.
385
386         * Scripts/webkitperl/FeatureList.pm:
387
388 2015-05-09  David Kilzer  <ddkilzer@apple.com>
389
390         Layout tests broke due to unexpected simctl output
391
392         * Scripts/webkitpy/xcode/simulator.py:
393         (Simulator._parse_devices): Handle new Device Pairs header.
394         * Scripts/webkitpy/xcode/simulator_unittest.py:
395         (test_device_pairs): Add unit test for Device Pairs header.
396
397 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
398
399         Remove convenience constructors for TextRun
400         https://bugs.webkit.org/show_bug.cgi?id=144752
401
402         Reviewed by Anders Carlsson.
403
404         Test the StringView which takes a StringImpl*.
405
406         * TestWebKitAPI/Tests/WTF/StringView.cpp:
407         (StringView8Bit): Testing is8Bit() on StringView
408
409 2015-05-07  Sam Weinig  <sam@webkit.org>
410
411         [Content Extensions] Add simple tester that takes an extension and compiles it
412         https://bugs.webkit.org/show_bug.cgi?id=144781
413
414         Reviewed by Dan Bates.
415
416         * ContentExtensionTester: Added.
417         * ContentExtensionTester/Configurations: Added.
418         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
419         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
420         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
421         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
422         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
423         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
424         * ContentExtensionTester/main.m: Added.
425         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
426
427 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
428
429         Build fix.
430
431         Reviewed by Dan Bernstein.
432
433         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
434         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
435         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
436         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
437         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
438         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
439         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
440         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
441
442 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
443
444         [GTK] Some tests fail because they do not assume the popup menu captures click events
445         https://bugs.webkit.org/show_bug.cgi?id=40601
446
447         Reviewed by Carlos Garcia Campos.
448
449         Popdown all attached menus when moving between tests and between each new
450         event sent to the WebView. This prevents context and popup menus from eating
451         events.
452
453         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
454         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
455         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
456         (WTR::dispatchEvent): Popdown all menus between dispatching events.
457         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
458         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
459         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
460         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
461         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
462         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
463         longer in the platform-independent file.
464         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
465
466 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
467
468         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
469         https://bugs.webkit.org/show_bug.cgi?id=144746
470
471         Reviewed by Carlos Garcia Campos.
472
473         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
474
475         * MiniBrowser/gtk/main.c:
476         (main):
477
478 2015-05-08  Commit Queue  <commit-queue@webkit.org>
479
480         Unreviewed, rolling out r183996.
481         https://bugs.webkit.org/show_bug.cgi?id=144806
482
483         ASan detected use-after free (Requested by ap on #webkit).
484
485         Reverted changeset:
486
487         "Remove convenience constructors for TextRun"
488         https://bugs.webkit.org/show_bug.cgi?id=144752
489         http://trac.webkit.org/changeset/183996
490
491 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
492
493         Remove convenience constructors for TextRun
494         https://bugs.webkit.org/show_bug.cgi?id=144752
495
496         Reviewed by Anders Carlsson.
497
498         Test the StringView which takes a StringImpl*.
499
500         * TestWebKitAPI/Tests/WTF/StringView.cpp:
501         (StringView8Bit): Testing is8Bit() on StringView
502
503 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
504
505         [GTK] WTR doesn't correctly handle the Escape key
506         https://bugs.webkit.org/show_bug.cgi?id=144788
507
508         Reviewed by Martin Robinson.
509
510         Correctly handle 0x001B character code in GTK+ event sender to be
511         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
512         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
513         to dismiss popup menus.
514
515         Fixes editing/selection/5354455-1.html.
516
517         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
518         (WTR::getGDKKeySymForKeyRef):
519
520 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
521
522         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
523         https://bugs.webkit.org/show_bug.cgi?id=144748
524
525         Reviewed by Sergio Villar Senin.
526
527         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
528         (testWebKitSettings): Check the new setting is correctly
529         initialized and updated.
530         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
531         (testWebContextSecurityFileXHR): Check XHR to local files is
532         allowed from file URLs after changing the setting.
533         (beforeAll): Add new test.
534
535 2015-05-08  Commit Queue  <commit-queue@webkit.org>
536
537         Unreviewed, rolling out r183945.
538         https://bugs.webkit.org/show_bug.cgi?id=144789
539
540         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
541
542         Reverted changeset:
543
544         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
545         https://bugs.webkit.org/show_bug.cgi?id=144746
546         http://trac.webkit.org/changeset/183945
547
548 2015-05-07  Anders Carlsson  <andersca@apple.com>
549
550         Build fixes.
551
552         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
553         (TestWebKitAPI::TEST):
554         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
555         (TestWebKitAPI::TEST):
556         Add casts.
557
558 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
559
560         GC has trouble with pathologically large array allocations
561         https://bugs.webkit.org/show_bug.cgi?id=144609
562
563         Reviewed by Geoffrey Garen.
564         
565         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
566         and it's a frequently requested feature.
567         
568         Also add the ability to run a test pretending that your system has a particular RAM size.
569         This is useful for GC tests, and the new GC test that I added uses this.
570
571         * Scripts/run-javascriptcore-tests:
572         (runJSCStressTests):
573         * Scripts/run-jsc-stress-tests:
574
575 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
576
577         [EFL] Bump EFL version to 1.14.0
578         https://bugs.webkit.org/show_bug.cgi?id=144743
579
580         Reviewed by Darin Adler.
581
582         Bump EFL and elementary version to 1.14.0 and removed
583         md5sum, because it isn't used at all if hash is present.
584
585         * efl/jhbuild.modules:
586
587 2015-05-07  Saam Barati  <saambarati1@gmail.com>
588
589         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
590         https://bugs.webkit.org/show_bug.cgi?id=144753
591
592         Reviewed by Mark Lam.
593
594         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
595
596 2015-05-07  Beth Dakin  <bdakin@apple.com>
597
598         New force-related DOM events should fire in WK1 views
599         https://bugs.webkit.org/show_bug.cgi?id=144663
600         -and corresponding-
601         rdar://problem/20281886
602
603         Reviewed by Sam Weinig.
604
605         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
606         now. Just send nil. 
607         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
608         (TestWebKitAPI::buildAndPerformTest):
609
610 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
611
612         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
613         https://bugs.webkit.org/show_bug.cgi?id=144746
614
615         Reviewed by Martin Robinson.
616
617         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
618
619         * MiniBrowser/gtk/main.c:
620         (main):
621
622 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
623
624         Revert "Introducing the Platform Abstraction Layer (PAL)"
625         https://bugs.webkit.org/show_bug.cgi?id=144751
626
627         Unreviewed.
628
629         PAL should be a new target inside WebCore, rather than a top-level folder.
630
631         * Scripts/build-webkit: Add it to build-webkit.
632
633 2015-05-07  Ada Chan  <adachan@apple.com>
634
635         Add a test for WKPageCopySessionState() with filtering.
636         https://bugs.webkit.org/show_bug.cgi?id=144666
637
638         Reviewed by Darin Adler.
639
640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
641         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
642         (TestWebKitAPI::didFinishLoadForFrame):
643         (TestWebKitAPI::setPageLoaderClient):
644         (TestWebKitAPI::filterFirstItemCallback):
645         (TestWebKitAPI::filterAllItemsCallback):
646         (TestWebKitAPI::createSessionStates):
647         (TestWebKitAPI::TEST):
648
649 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
650
651         iOS build fix attempt
652
653         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
654
655         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
656
657 2015-05-06  Matt Baker  <mattbaker@apple.com>
658
659         Unreviewed, updated my list of email addresses.
660
661         * Scripts/webkitpy/common/config/contributors.json:
662
663 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
664
665         Do not link tools to WebKit2.framework
666         https://bugs.webkit.org/show_bug.cgi?id=144699
667
668         Unreviewed build fix.
669
670         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
671         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
672         These linked to WebKit2 in two ways, eliminating the other one.
673
674 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
675
676         Introducing the Platform Abstraction Layer (PAL)
677         https://bugs.webkit.org/show_bug.cgi?id=143358
678
679         Reviewed by Simon Fraser.
680
681         * Scripts/build-webkit: Add it to build-webkit.
682
683 2015-05-06  Alex Christensen  <achristensen@webkit.org>
684
685         Fix api tests after r183877.
686
687         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
688         (TestWebKitAPI::TEST_F):
689         Generate all DFAs before compiling them.
690
691 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
692
693         Do not link tools to WebKit2.framework
694         https://bugs.webkit.org/show_bug.cgi?id=144699
695
696         Reviewed by Tim Horton.
697
698         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
701
702 2015-05-06  Alex Christensen  <achristensen@webkit.org>
703
704         [Content Extensions] Test splitting NFAs by max NFA size.
705         https://bugs.webkit.org/show_bug.cgi?id=144659
706
707         Reviewed by Darin Adler.
708
709         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
710         (TestWebKitAPI::createNFAs):
711         (TestWebKitAPI::TEST_F):
712         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
713         (TestWebKitAPI::createNFAs):
714
715 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
716
717         Remove the remaining vestiges of SVG feature define
718         https://bugs.webkit.org/show_bug.cgi?id=144655
719
720         Reviewed by Alexey Proskuryakov.
721
722         * Scripts/webkitperl/FeatureList.pm:
723
724 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
725
726         Add a layout mode for computing fixed layout size from a minimum size
727         https://bugs.webkit.org/show_bug.cgi?id=144610
728         <rdar://problem/19790341>
729
730         Reviewed by Simon Fraser.
731
732         * MiniBrowser/mac/BrowserWindow.xib:
733         * MiniBrowser/mac/BrowserWindowController.h:
734         * MiniBrowser/mac/WK1BrowserWindowController.m:
735         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
736         * MiniBrowser/mac/WK2BrowserWindowController.m:
737         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
738         Add a optional toolbar item to toggle a minimum view size of 1024x0.
739
740 2015-05-05  Alex Christensen  <achristensen@webkit.org>
741
742         [Content Extensions] Release input NSString when finished copying it.
743         https://bugs.webkit.org/show_bug.cgi?id=144642
744
745         Reviewed by Brian Weinstein.
746
747         * WebKitTestRunner/mac/TestControllerMac.mm:
748         (WTR::TestController::platformConfigureViewForTest):
749         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
750
751 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
752
753         Unreviewed test fix after r183798.
754
755         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
756         (convertToDRTLabel): Mimic behavior of Mac accessibility output
757         so we can share results.
758
759 2015-05-05  Alex Christensen  <achristensen@webkit.org>
760
761         [Content Extensions] Use less memory to store the json input.
762         https://bugs.webkit.org/show_bug.cgi?id=144604
763
764         Reviewed by Benjamin Poulain.
765
766         * MiniBrowser/mac/ExtensionManagerWindowController.m:
767         (-[ExtensionManagerWindowController add:]):
768         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
769         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
770         * WebKitTestRunner/mac/TestControllerMac.mm:
771         (WTR::TestController::platformConfigureViewForTest):
772
773 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
774
775         Unreviewed. Make myself a WebKit reviewer.
776
777         * Scripts/webkitpy/common/config/contributors.json:
778
779 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
780
781         [GTK] r183783 breaks build
782         https://bugs.webkit.org/show_bug.cgi?id=144632
783
784         Reviewed by Martin Robinson.
785
786         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
787
788         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
789         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
790
791 2015-05-05  Alex Christensen  <achristensen@webkit.org>
792
793         [Content Extensions] Combine NFAs properly and free memory as we compile.
794         https://bugs.webkit.org/show_bug.cgi?id=144485
795
796         Reviewed by Benjamin Poulain.
797
798         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
799         (TestWebKitAPI::TEST_F):
800         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
801         Added tests for deep NFAs.
802
803 2015-05-04  Alex Christensen  <achristensen@webkit.org>
804
805         [Content Extensions] Use less memory when writing byte code to file
806         https://bugs.webkit.org/show_bug.cgi?id=144602
807
808         Reviewed by Darin Adler.
809
810         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
811
812 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
813
814         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
815         https://bugs.webkit.org/show_bug.cgi?id=144541
816
817         Reviewed by Žan Doberšek.
818
819         Add a test case to WorkQueue unit test, to check that sources of
820         asynchronous IO operations running in the WorkQueue thread are
821         dispatched by the WorkQueue main loop.
822
823         * TestWebKitAPI/PlatformGTK.cmake:
824         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
825         (TestWebKitAPI::TEST):
826
827 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
828
829         Correct '--show-webview' option for Tiled Drawing tests
830         https://bugs.webkit.org/show_bug.cgi?id=144621
831
832         Reviewed by Simon Fraser.
833
834         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
835         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
836
837         * WebKitTestRunner/mac/TestControllerMac.mm:
838         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
839         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
840
841 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
842
843         Large array shouldn't be slow
844         https://bugs.webkit.org/show_bug.cgi?id=144617
845
846         Reviewed by Geoffrey Garen.
847         
848         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
849         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
850         long-running. So, hash-map sort of belongs here.
851
852         * Scripts/run-jsc-benchmarks:
853
854 2015-05-04  Doug Russell  <d_russell@apple.com>
855
856         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
857         https://bugs.webkit.org/show_bug.cgi?id=144489
858
859         Reviewed by Chris Fleizach.
860
861         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
862         on the returned control.
863         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
864         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
865         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
866         Add support for setSelectedVisibleTextRange() in accessibility tests.
867
868         * DumpRenderTree/AccessibilityUIElement.cpp:
869         (setSelectedVisibleTextRangeCallback):
870         (AccessibilityUIElement::setSelectedVisibleTextRange):
871         (AccessibilityUIElement::getJSClass):
872         (AccessibilityUIElement::textMarkerForIndex): Deleted.
873         * DumpRenderTree/AccessibilityUIElement.h:
874         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
875         (AccessibilityUIElement::setSelectedVisibleTextRange):
876         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
877         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
878         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
879         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
880         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
881         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
882         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
883         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
884         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
885         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
886         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
887
888 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
889
890         [Win] Implement the "--show-webview" option for Windows
891         https://bugs.webkit.org/show_bug.cgi?id=144589
892
893         Reviewed by Alex Christensen.
894
895         Add another runtime flag (--show-webview) that causes DumpRenderTree
896         to draw its view on-screen, rather than the standard offscreen mode.
897
898         * DumpRenderTree/win/DumpRenderTree.cpp:
899         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
900         (initializeGlobalsFromCommandLineOptions): Recognize the new
901         command-line argument, and set the global 'showWebView' state if
902         appropriate.
903
904 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
905
906         Remove dead code from TestInvocationCairo.cpp
907         https://bugs.webkit.org/show_bug.cgi?id=144564
908
909         Reviewed by Gyuyoung Kim.
910
911         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
912
913         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
914         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
915
916 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
917
918         [GTK] Add libnotify in gtk install-dependencies
919         https://bugs.webkit.org/show_bug.cgi?id=144379
920
921         Reviewed by Csaba Osztrogonác.
922
923         * gtk/install-dependencies:
924
925 2015-05-01  Dan Bernstein  <mitz@apple.com>
926
927         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
928         https://bugs.webkit.org/show_bug.cgi?id=144501
929
930         Reviewed by Darin Adler.
931
932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
933         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
934         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
935         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
936
937 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
938
939         check-webkit-style fails due to system pylint
940         https://bugs.webkit.org/show_bug.cgi?id=144360
941
942         Reviewed by Darin Adler.
943
944         Make sure that the directory containing third party autoinstalled modules
945         is at the beginning of the search path, to avoid conflicts with other
946         versions of the same modules installed in the system (e.g. pylint).
947
948         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
949         modules directory to sys.path, instead of appending it.
950
951 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
952
953         Unreviewed, updated my list of email addresses.
954
955         * Scripts/webkitpy/common/config/contributors.json: Updated.
956
957 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
958
959         USE(...) macro should expect unprefixed variables
960         https://bugs.webkit.org/show_bug.cgi?id=144454
961
962         Reviewed by Daniel Bates.
963
964         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
965         * DumpRenderTree/config.h: Ditto.
966         * TestWebKitAPI/config.h: Ditto.
967
968 2015-05-01  Basile Clement  <basile_clement@apple.com>
969
970         Unreviewed. Add myself as a commiter in contributors.json.
971
972         * Scripts/webkitpy/common/config/contributors.json:
973
974 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
975
976         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
977         https://bugs.webkit.org/show_bug.cgi?id=144487
978
979         Reviewed by Ryosuke Niwa.
980
981         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
982         (BenchmarkRunner.merge): Fix bug.
983         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
984
985 2015-05-01  Brady Eidson  <beidson@apple.com>
986
987         Add API to disable meta refreshes.
988         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
989
990         Reviewed by Alexey Proskuryakov.
991
992         * DumpRenderTree/mac/DumpRenderTree.mm:
993         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
994
995 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
996
997         Provide a runtime flag to run-webkit-tests that shows the test view
998         https://bugs.webkit.org/show_bug.cgi?id=144079.
999
1000         Unreviewed correction to r183651.
1001
1002         * WebKitTestRunner/TestController.cpp:
1003         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
1004         flag is included in the options dictionary passed to the PlatformWebView.
1005
1006 2015-05-01  Antti Koivisto  <antti@apple.com>
1007
1008         Remove network process load serialization code
1009         https://bugs.webkit.org/show_bug.cgi?id=144448
1010
1011         Reviewed by Alexey Proskuryakov.
1012
1013         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1014         (WTR::InjectedBundle::beginTesting):
1015         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1016         (WTR::TestRunner::setSerializeHTTPLoads):
1017         (WTR::TestRunner::dispatchPendingLoadRequests):
1018
1019 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1020
1021         [GTK] Add libhyphen-dev to the build dependencies
1022         https://bugs.webkit.org/show_bug.cgi?id=144452
1023
1024         Reviewed by Martin Robinson.
1025
1026         * gtk/install-dependencies: Added hyphen as Fedora and Arch
1027         dependencies.
1028
1029 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
1030
1031         Provide a runtime flag to run-webkit-tests that shows the test view
1032         https://bugs.webkit.org/show_bug.cgi?id=144079.
1033
1034         Reviewed by Dean Jackson.
1035
1036         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
1037         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
1038         option:
1039         
1040         --additional-drt-flag="--show-webview"
1041
1042         * DumpRenderTree/mac/DumpRenderTree.mm:
1043         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
1044         '--show-webview' flag.
1045         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
1046         * WebKitTestRunner/Options.cpp:
1047         (WTR::Options::Options):
1048         (WTR::handleOptionShowWebView):
1049         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
1050         * WebKitTestRunner/Options.h:
1051         * WebKitTestRunner/TestController.cpp:
1052         (WTR::TestController::TestController):
1053         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
1054         * WebKitTestRunner/TestController.h:
1055         (WTR::TestController::shouldShowWebView):
1056         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1057         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
1058         options dictionary. If it is true, display the web view while running the test.
1059
1060 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
1061
1062         r183355 didn't trigger Mac tests
1063         https://bugs.webkit.org/show_bug.cgi?id=144464
1064
1065         Reviewed by Simon Fraser.
1066
1067         Update badly neglected filters and unit tests.
1068
1069         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1070         (_should_file_trigger_build):
1071         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1072         (ShouldBuildTest):
1073         (ShouldBuildTest.test_should_build):
1074
1075 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1076
1077         [GTK] Add libhyphen-dev to the build dependencies
1078         https://bugs.webkit.org/show_bug.cgi?id=144452
1079
1080         Reviewed by Martin Robinson.
1081
1082         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
1083         build dependencies.
1084
1085 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
1086
1087         [GTK] Testing dictionaries are not installed automatically
1088         https://bugs.webkit.org/show_bug.cgi?id=144460
1089
1090         Reviewed by Carlos Garcia Campos.
1091
1092         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
1093
1094 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
1095
1096         Fix return code issue, check return code of safari process and dump results to log
1097         https://bugs.webkit.org/show_bug.cgi?id=144436
1098
1099         Reviewed by Ryosuke Niwa.
1100
1101         * Scripts/run-benchmark:
1102         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1103         (BenchmarkRunner.dump): Correct typo.
1104         (BenchmarkRunner.wrap): Add results to console.
1105         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
1106         (OSXSafariDriver.prepareEnv):
1107         (OSXSafariDriver.launchUrl):
1108         (OSXSafariDriver.closeBrowsers):
1109
1110 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1111
1112         Should no longer need to worry about very old versions of Xcode
1113         https://bugs.webkit.org/show_bug.cgi?id=144437
1114
1115         Reviewed by Dan Bernstein.
1116
1117         * Scripts/check-for-exit-time-destructors:
1118         * Scripts/check-for-global-initializers:
1119         * Scripts/check-for-weak-vtables-and-externals:
1120
1121 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1122
1123         REGRESSION(183583): [Mac] make without SDKROOT has issues
1124         https://bugs.webkit.org/show_bug.cgi?id=144431
1125
1126         Reviewed by Dan Bernstein.
1127
1128         * Makefile:
1129         * WebKitTestRunner/Makefile:
1130         Assume an empty SDKROOT means an macosx variant, so only
1131         enable settings if the SDKROOT is not empty and does not
1132         contain "macosx".
1133
1134 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
1135
1136         Expand test infrastructure to support scrolling tests
1137         https://bugs.webkit.org/show_bug.cgi?id=143684
1138         <rdar://problem/20375516>
1139
1140         Reviewed by Simon Fraser.
1141
1142         * DumpRenderTree/mac/DumpRenderTree.mm:
1143         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
1144         reset before the next test run.
1145         * WebKitTestRunner/TestController.cpp:
1146         (WTR::TestController::resetStateToConsistentValues): Ditto."
1147
1148 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1149
1150         Run javascriptcore tests on Windows without cygwin
1151         https://bugs.webkit.org/show_bug.cgi?id=144419
1152
1153         Reviewed by Brent Fulgham.
1154
1155         * Scripts/run-javascriptcore-tests:
1156         (runJSCStressTests):
1157         Just call ruby, not /usr/bin/env ruby.
1158
1159 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
1160
1161         [GTK] Add --enable-shared option to LLVM to build mesa
1162         https://bugs.webkit.org/show_bug.cgi?id=144393
1163
1164         Reviewed by Martin Robinson.
1165
1166         The updated mesa requires the shared LLVM libraries.
1167         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
1168         to LLVM configure script. It will provide shared libraries in addition to static libraries.
1169
1170         * gtk/jhbuild-optional.modules:
1171
1172 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
1173
1174         [GTK] Add support for automatic hyphenation
1175         https://bugs.webkit.org/show_bug.cgi?id=44478
1176
1177         Reviewed by Carlos Garcia Campos.
1178
1179         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
1180         all systems will use the same dictionaries for testing purposes.
1181
1182 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
1183
1184         Failure when building WebKit for appletvsimulator.
1185         https://bugs.webkit.org/show_bug.cgi?id=144356
1186
1187         Reviewed by Alexey Proskuryakov.
1188
1189         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
1190         make TVOS and WatchOS behave correctly.
1191
1192         * Makefile:
1193         * WebKitTestRunner/Makefile:
1194
1195 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1196
1197         Use-after-free when invalidating WKPageForceRepaint callback
1198         https://bugs.webkit.org/show_bug.cgi?id=144401
1199         rdar://problem/20741111
1200
1201         Reviewed by Tim Horton.
1202
1203         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
1204
1205         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
1206         Don't do anything on error, because the context may be a stale pointer now.
1207
1208 2015-04-29  David Kilzer  <ddkilzer@apple.com>
1209
1210         check-webkit-style: Don't complain about returning value from Objective-C method call in header
1211         <http://webkit.org/b/144395>
1212
1213         Reviewed by Andy Estes.
1214
1215         * Scripts/webkitpy/style/checkers/cpp.py:
1216         (check_spacing): Update regex so 'return' is ignored if it
1217         precedes the whitespace and bracket.  Change category name to
1218         'whitespace/brackets'.  Add period to error message.
1219         (CppChecker): Add 'whitespace/brackets' as a category.
1220         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1221         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
1222         'CppChecker.categories' since that's where the list lives now.
1223         (CppStyleTest.test_spacing_before_brackets): Add tests for
1224         'whitespace/brackets' issues and non-issues.
1225
1226 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1227
1228         Fix WinCairo bot.
1229
1230         * Scripts/webkitdirs.pm:
1231         (determinePassedConfiguration):
1232         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
1233
1234 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
1235
1236         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
1237         https://bugs.webkit.org/show_bug.cgi?id=132159
1238
1239         Reviewed by Darin Adler.
1240
1241         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
1242         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
1243
1244         * DumpRenderTree/mac/DumpRenderTree.mm:
1245         (fontWhitelist):
1246         (adjustFonts):
1247         (createWebViewAndOffscreenWindow):
1248         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1249         (WTR::activateFonts):
1250         * WebKitTestRunner/mac/TestControllerMac.mm:
1251         (WTR::allowedFontFamilySet):
1252         (WTR::systemHiddenFontFamilySet):
1253         (WTR::generateWhitelist):
1254         (WTR::TestController::platformInitializeContext):
1255
1256 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1257
1258         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1259         https://bugs.webkit.org/show_bug.cgi?id=144155
1260
1261         Reviewed by Andreas Kling.
1262
1263         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1264         Make sure that test window is "visible" before each test. While there is no concrete
1265         evidence that this is the problem indeed, the behavior is consistent with what would
1266         happen for an invisible window. Also, WKTR obviously needs to do this to protect
1267         against potential buggy tests that hide the window and don't show it.
1268
1269 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1270
1271         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
1272
1273         Latest changes in the inspector UI made this test fail. We were
1274         relying that the sidebar was always visible and the first 'li'
1275         element of the inspector was the one containing the title. This is
1276         no longer true, so better use document title that is not likely
1277         to change.
1278
1279         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1280         (openRemoteDebuggingSession):
1281
1282 2015-04-29  Andres Gomez  <agomez@igalia.com>
1283
1284         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
1285
1286         * Scripts/webkitpy/common/config/contributors.json:
1287
1288 2015-04-29  Andres Gomez  <agomez@igalia.com>
1289
1290         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
1291
1292         * Scripts/webkitpy/common/config/watchlist:
1293
1294 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
1295
1296         [EFL] Allow to run the tests on the native X display
1297         https://bugs.webkit.org/show_bug.cgi?id=144247
1298
1299         Reviewed by Gyuyoung Kim.
1300
1301         Added the USE_NATIVE_XDISPLAY option for the WTR.
1302         We can select the Xorg driver if environment variable is set up before running the tests.
1303
1304         * Scripts/webkitpy/port/efl.py:
1305         (EflPort._driver_class):
1306
1307 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
1308
1309         [GTK] Add libnotify-dev in gtk install-dependencies
1310         https://bugs.webkit.org/show_bug.cgi?id=144379
1311
1312         Reviewed by Žan Doberšek.
1313
1314         * gtk/install-dependencies:
1315
1316 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
1317
1318         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
1319         https://bugs.webkit.org/show_bug.cgi?id=143001
1320
1321         Reviewed by Gyuyoung Kim.
1322
1323         * WebKitTestRunner/TestController.cpp:
1324         (WTR::shouldUseFixedLayout):
1325
1326 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
1327
1328         Increase stablility of run-benchmark script
1329         https://bugs.webkit.org/show_bug.cgi?id=144361
1330
1331         Reviewed by Ryosuke Niwa.
1332
1333         * Scripts/run-benchmark:
1334         (main):
1335         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
1336         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1337         (GenericBenchmarkBuilder.clean):
1338         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
1339         (BenchmarkRunner.__init__):
1340         (BenchmarkRunner.execute):
1341         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1342         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
1343         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
1344         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
1345         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
1346         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
1347         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
1348         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1349         (HTTPServerDriver.fetchResult):
1350         (HTTPServerDriver):
1351         (HTTPServerDriver.killServer): Add kill server interface.
1352         (HTTPServerDriver.getReturnCode): Add get return code interface.
1353         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
1354         (SimpleHTTPServerDriver.serve):
1355         (SimpleHTTPServerDriver.fetchResult):
1356         (SimpleHTTPServerDriver):
1357         (SimpleHTTPServerDriver.killServer):
1358         (SimpleHTTPServerDriver.getReturnCode):
1359         * Scripts/webkitpy/benchmark_runner/utils.py:
1360         (forceRemove): Provide python version of 'rm -rf'.
1361
1362 2015-04-28  Sam Weinig  <sam@webkit.org>
1363
1364         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
1365         https://bugs.webkit.org/show_bug.cgi?id=144363
1366
1367         Reviewed by Alex Christensen.
1368
1369         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1370         (TestWebKitAPI::createNFAs):
1371         (TestWebKitAPI::TEST_F):
1372         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1373         (TestWebKitAPI::countLiveNodes):
1374         (TestWebKitAPI::createNFAs):
1375         (TestWebKitAPI::buildDFAFromPatterns):
1376         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
1377
1378 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1379
1380         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1381         https://bugs.webkit.org/show_bug.cgi?id=144304
1382
1383         Reviewed by Geoffrey Garen.
1384
1385         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
1386         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1387         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1388
1389 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1390
1391         Unreviewed, rolling out r183514.
1392         https://bugs.webkit.org/show_bug.cgi?id=144359
1393
1394         It broke cloop test bots (Requested by mcatanzaro on #webkit).
1395
1396         Reverted changeset:
1397
1398         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
1399         https://bugs.webkit.org/show_bug.cgi?id=144304
1400         http://trac.webkit.org/changeset/183514
1401
1402 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1403
1404         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1405         https://bugs.webkit.org/show_bug.cgi?id=144304
1406
1407         Reviewed by Geoffrey Garen.
1408
1409         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
1410         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
1411         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1412         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1413
1414 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1415
1416         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
1417         https://bugs.webkit.org/show_bug.cgi?id=144319
1418
1419         Reviewed by Csaba Osztrogonác.
1420
1421         * TestWebKitAPI/CMakeLists.txt:
1422         * TestWebKitAPI/PlatformEfl.cmake:
1423
1424 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
1425
1426         Fix common typo "targetting" => "targeting"
1427         https://bugs.webkit.org/show_bug.cgi?id=144349
1428
1429         Reviewed by Daniel Bates.
1430
1431         * Scripts/webkitdirs.pm:
1432         (execMacWebKitAppForDebugging):
1433
1434 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1435
1436         [GTK][jhbuild] Mesa build failure with llvm 3.6
1437         https://bugs.webkit.org/show_bug.cgi?id=144250
1438
1439         Reviewed by Žan Doberšek.
1440
1441         Bump the version of Mesa to 10.5.4
1442
1443         * gtk/jhbuild.modules:
1444
1445 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
1446
1447         Disable App Nap in WebKitTestRunner UI process
1448         https://bugs.webkit.org/show_bug.cgi?id=144308
1449
1450         Reviewed by Daniel Bates.
1451
1452         * WebKitTestRunner/mac/main.mm:
1453         (disableAppNapInUIProcess):
1454         (main):
1455
1456 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1457
1458         [GTK] Update JHBuild Mesa download directory
1459         https://bugs.webkit.org/show_bug.cgi?id=144318
1460
1461         Update the download directory of Mesa module since the previous one
1462         doesn't exist any more.
1463
1464         Reviewed by Žan Doberšek.
1465
1466         * gtk/jhbuild.modules:
1467
1468 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1469
1470         Unreviewed, rolling out r183477.
1471         https://bugs.webkit.org/show_bug.cgi?id=144334
1472
1473         Roll back the Mesa dependency bump in fear of uncaught
1474         regressions while the testing bots are no-op. (Requested by
1475         zdobersek on #webkit).
1476
1477         Reverted changeset:
1478
1479         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
1480         https://bugs.webkit.org/show_bug.cgi?id=144250
1481         http://trac.webkit.org/changeset/183477
1482
1483 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1484
1485         [GTK][jhbuild] Mesa build failure with llvm 3.6
1486         https://bugs.webkit.org/show_bug.cgi?id=144250
1487
1488         Reviewed by Žan Doberšek.
1489
1490         Bump the version of Mesa to 10.5.4
1491
1492         * gtk/jhbuild.modules:
1493
1494 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
1495
1496         Add '__init__.py' and fix known bug in benchmark runner.
1497         https://bugs.webkit.org/show_bug.cgi?id=144296
1498
1499         Reviewed by Ryosuke Niwa
1500
1501         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
1502         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
1503         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1504         (BenchmarkRunner.__init__):
1505         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
1506         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
1507         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
1508
1509 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1510
1511         More build fix.
1512
1513         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1514         (-[AccessibilityNotificationHandler _notificationReceived:]):
1515         Use -objectForKey:, not array subscript.
1516
1517 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1518
1519         Catch unexpected exits in DumpRenderTree
1520         https://bugs.webkit.org/show_bug.cgi?id=144288
1521
1522         Reviewed by Tim Horton.
1523
1524         * DumpRenderTree/mac/DumpRenderTree.mm:
1525         (atexitFunction):
1526         (DumpRenderTreeMain):
1527
1528 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1529
1530         Build fix
1531
1532         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1533         (-[AccessibilityNotificationHandler _notificationReceived:]):
1534         Use -objectForKey:, not array subscript.
1535
1536 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1537
1538         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1539         https://bugs.webkit.org/show_bug.cgi?id=144155
1540
1541         Reviewed by Tim Horton.
1542
1543         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1544         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
1545         and we clearly don't want App Nap while testing.
1546
1547 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
1548
1549         [CMake] Autogenerate cmakeconfig.h.cmake
1550         https://bugs.webkit.org/show_bug.cgi?id=143997
1551
1552         Reviewed by Csaba Osztrogonác.
1553
1554         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
1555         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
1556
1557 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
1558
1559         REGRESSION(r182879): Images and video can no longer be downloaded
1560         https://bugs.webkit.org/show_bug.cgi?id=144267
1561         <rdar://problem/20702844>
1562
1563         Reviewed by Simon Fraser.
1564
1565         Revise tests to check for proper download menu state.
1566         1. Downloading a loal image should be disabled.
1567         2. Downloading a local media file should be disabled.
1568         3. Downloading non-downloadable media should be disabled.
1569
1570         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1571         (TestWebKitAPI::TEST):
1572
1573 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1574
1575         Merge run-launcher into run-minibrowser
1576         https://bugs.webkit.org/show_bug.cgi?id=141928
1577
1578         Reviewed by Darin Adler.
1579
1580         * Scripts/run-iexploder-tests:
1581         (runSafariWithIExploder):
1582         * Scripts/run-launcher: Removed.
1583         * Scripts/run-minibrowser:
1584         * Scripts/webkitdirs.pm:
1585         (launcherPath):
1586         * Scripts/webkitpy/port/efl.py:
1587         (EflPort.show_results_html_file):
1588         * Scripts/webkitpy/port/efl_unittest.py:
1589         (EflPortTest.test_show_results_html_file):
1590         * Scripts/webkitpy/port/gtk.py:
1591         (GtkPort.print_leaks_summary):
1592         (GtkPort.show_results_html_file):
1593         (GtkPort): Deleted.
1594         * Scripts/webkitpy/port/gtk_unittest.py:
1595         (GtkPortTest.test_show_results_html_file):
1596
1597 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1598
1599         [buildbot] Fix the output of perf-test buildstep on timeout
1600         https://bugs.webkit.org/show_bug.cgi?id=144097
1601
1602         Reviewed by Ryosuke Niwa.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1605         (RunAndUploadPerfTests.getText2):
1606         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1607         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
1608         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1609
1610 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1611
1612         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
1613         https://bugs.webkit.org/show_bug.cgi?id=143874
1614
1615         Reviewed by Gyuyoung Kim.
1616
1617         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
1618
1619 2015-04-24  Philippe Normand  <pnormand@igalia.com>
1620
1621         [JHBuild] Move to upstream OpenWebRTC
1622         https://bugs.webkit.org/show_bug.cgi?id=144145
1623
1624         Reviewed by Carlos Garcia Campos.
1625
1626         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
1627         and add a new simple patch to gst-plugins-base, required for
1628         OpenWebRTC build.
1629         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1630         * gtk/jhbuild.modules: Ditto.
1631         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1632
1633 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1634
1635         [ES6] Implement ES6 template literals
1636         https://bugs.webkit.org/show_bug.cgi?id=142691
1637
1638         Reviewed by Darin Adler.
1639
1640         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
1641
1642         * Scripts/webkitperl/FeatureList.pm:
1643
1644 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1645
1646         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
1647         https://bugs.webkit.org/show_bug.cgi?id=144217
1648
1649         Reviewed by Darin Adler.
1650
1651         * WebKitTestRunner/PlatformEfl.cmake:
1652
1653 2015-04-26  Doug Russell  <d_russell@apple.com>
1654
1655         AX: richer text change notifications (142719)
1656         https://bugs.webkit.org/show_bug.cgi?id=142719
1657
1658         Reviewed by Darin Adler.
1659
1660         Richer accessibility value change notifications. Introduce AXTextEditType,
1661         postTextStateChangeNotification and postTextReplacementNotification to give assistive
1662         tech apps more reliable context for responding to changes in web content. Also implement
1663         a mechanism to post value changes in password form fields in coalesced ticks to thwart
1664         analyzing the cadence of changes.
1665
1666         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
1667         and an overload of postTextReplacementNotification to give assistive tech apps more
1668         reliable context for responding to changes in web content selection. Also block posting
1669         selection changes on password fields.
1670
1671         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1672         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1673         (-[AccessibilityNotificationHandler stopObserving]):
1674         (-[AccessibilityNotificationHandler _notificationReceived:]):
1675         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1676         (AccessibilityUIElement::removeNotificationListener):
1677         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1678         (-[AccessibilityNotificationHandler _notificationReceived:]):
1679         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1680         (WTR::AccessibilityUIElement::removeNotificationListener):
1681
1682 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
1683
1684         Add myself to contributors.json
1685         https://bugs.webkit.org/show_bug.cgi?id=144204
1686
1687         Reviewed by Darin Adler.
1688
1689         * Scripts/webkitpy/common/config/contributors.json:
1690
1691 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
1692
1693         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
1694         https://bugs.webkit.org/show_bug.cgi?id=144182
1695
1696         Reviewed by Simon Fraser.
1697
1698         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
1699
1700 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
1701
1702         https://bugs.webkit.org/show_bug.cgi?id=144038
1703
1704         Reviewed by Ryosuke Niwa
1705
1706         Add a script to run Speedometer and JetStream on a browser.
1707
1708         * Scripts/run-benchmark: Wrapper script to run benchmark.
1709         (main):
1710         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
1711         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
1712         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
1713         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
1714         (BenchmarkBuilderFactory):
1715         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
1716         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
1717         (GenericBenchmarkBuilder):
1718         (GenericBenchmarkBuilder.prepare):
1719         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
1720         (GenericBenchmarkBuilder._applyPatch):
1721         (GenericBenchmarkBuilder.clean):
1722         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
1723         (JetStreamBenchmarkBuilder):
1724         (JetStreamBenchmarkBuilder.prepare):
1725         (JetStreamBenchmarkBuilder._runCreateScript):
1726         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
1727         (BenchmarkRunner):
1728         (BenchmarkRunner.__init__):
1729         (BenchmarkRunner.execute):
1730         (BenchmarkRunner.dump):
1731         (BenchmarkRunner.wrap):
1732         (BenchmarkRunner.merge):
1733         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
1734         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1735         (BrowserDriver):
1736         (BrowserDriver.prepareEnv):
1737         (BrowserDriver.launchUrl):
1738         (BrowserDriver.closeBrowser):
1739         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1740         (BrowserDriverFactory):
1741         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1742         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1743         (OSXChromeDriver):
1744         (OSXChromeDriver.prepareEnv):
1745         (OSXChromeDriver.launchUrl):
1746         (OSXChromeDriver.closeBrowsers):
1747         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1748         (OSXSafariDriver):
1749         (OSXSafariDriver.prepareEnv):
1750         (OSXSafariDriver.launchUrl):
1751         (OSXSafariDriver.closeBrowsers):
1752         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1753         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1754         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1755         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1756         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1757         (GenericFactory):
1758         (GenericFactory.iterateGetItem):
1759         (GenericFactory.create):
1760         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1761         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1762         (ServerControl):
1763         (ServerControl.render_GET):
1764         (ServerControl.render_POST):
1765         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1766         (HTTPServerDriver):
1767         (HTTPServerDriver.serve):
1768         (HTTPServerDriver.fetchResult):
1769         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1770         (HTTPServerDriverFactory):
1771         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1772         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1773         (SimpleHTTPServerDriver):
1774         (SimpleHTTPServerDriver.depends):
1775         (SimpleHTTPServerDriver.__init__):
1776         (SimpleHTTPServerDriver.serve):
1777         (SimpleHTTPServerDriver.baseUrl):
1778         (SimpleHTTPServerDriver.fetchResult):
1779         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1780         (ModuleNotFoundError):
1781         (loadModule):
1782         (getPathFromProjectRoot):
1783         (loadJSONFromFile):
1784         (TimeoutError):
1785         (timeout):
1786         (timeout.__init__):
1787         (timeout.handle_timeout):
1788         (timeout.__enter__):
1789         (timeout.__exit__):
1790
1791 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1792
1793         Unreviewed, rolling out r183303.
1794         https://bugs.webkit.org/show_bug.cgi?id=144181
1795
1796         Change was incorrect, broke builds (Requested by smfr on
1797         #webkit).
1798
1799         Reverted changeset:
1800
1801         "Fix the build."
1802         http://trac.webkit.org/changeset/183303
1803
1804 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
1805
1806         Fix the build.
1807
1808         * MiniBrowser/mac/WK2BrowserWindowController.m:
1809         (-[WK2BrowserWindowController initWithConfiguration:]):
1810
1811 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1812
1813         Disable ActionMenusPDFTest due to timeout on test bot
1814
1815         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1816         (TestWebKitAPI::TEST):
1817
1818 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1819
1820         Unreviewed, rolling out r183266.
1821         https://bugs.webkit.org/show_bug.cgi?id=144164
1822
1823         Broke 32-bit build and a test. (Requested by ap on #webkit).
1824
1825         Reverted changeset:
1826
1827         "AX: richer text change notifications (142719)"
1828         https://bugs.webkit.org/show_bug.cgi?id=142719
1829         http://trac.webkit.org/changeset/183266
1830
1831 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1832
1833         REGRESSION: WebKit2.ActionMenusTest API test fails
1834         https://bugs.webkit.org/show_bug.cgi?id=144149
1835         <rdar://problem/20677770>
1836
1837         Reviewed by Tim Horton.
1838
1839         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1840         as the 'ActionMenusPDFTest'.
1841         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1842         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1843         to match the hit test on the 'action-menu-target.pdf' test file.
1844
1845 2015-04-24  Daniel Bates  <dabates@apple.com>
1846
1847         Cleanup: Use @memoized for property IOSSimulator.testing_device
1848         https://bugs.webkit.org/show_bug.cgi?id=141715
1849
1850         Reviewed by Darin Adler.
1851
1852         Simplify the caching of the result of IOSSimulator.testing_device
1853         and make the code more readable by making use of the @memoized declarator
1854         instead of explicitly managing a private instance variable,
1855         IOSSimulator._testing_device, for the cached result.
1856
1857         * Scripts/webkitpy/port/ios.py:
1858         (IOSPort.determine_full_port_name):
1859         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1860         (IOSSimulatorPort):
1861         (IOSSimulatorPort.testing_device): No need to cache the created device object in
1862         IOSSimulatorPort._testing_device since we are marking this function @memoized.
1863         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1864         of caching in local variable since we only make use of this value exactly once in this function.
1865         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1866         been used since being added in r178622. So, we can remove this constructor since
1867         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1868
1869 2015-04-24  Anders Carlsson  <andersca@apple.com>
1870
1871         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1872         https://bugs.webkit.org/show_bug.cgi?id=144158
1873
1874         Reviewed by Beth Dakin.
1875
1876         * MiniBrowser/mac/WK2BrowserWindowController.m:
1877         (-[WK2BrowserWindowController initWithConfiguration:]):
1878
1879 2015-04-24  Doug Russell  <d_russell@apple.com>
1880
1881         AX: richer text change notifications (142719)
1882         https://bugs.webkit.org/show_bug.cgi?id=142719
1883
1884         Reviewed by Darin Adler.
1885
1886         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1887
1888         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1889
1890         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1891         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1892         (-[AccessibilityNotificationHandler stopObserving]):
1893         (-[AccessibilityNotificationHandler _notificationReceived:]):
1894         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1895         (AccessibilityUIElement::removeNotificationListener):
1896         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1897         (-[AccessibilityNotificationHandler _notificationReceived:]):
1898         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1899         (WTR::AccessibilityUIElement::removeNotificationListener):
1900
1901 2015-04-24  Darin Adler  <darin@apple.com>
1902
1903         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1904         https://bugs.webkit.org/show_bug.cgi?id=128007
1905
1906         Reviewed by Anders Carlsson.
1907
1908         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1909         * DumpRenderTree/win/UIDelegate.h: Ditto.
1910
1911         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1912         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1913
1914         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1915
1916         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1917         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1918         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1919         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1920         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1921         (WebKitDOMDOMWindowTest::create): Ditto.
1922         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1923         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1924         of smart pointers to DelayedSIgnal objects.
1925         (uriChangedCallback): Ditto.
1926
1927 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1928
1929         [Mac] Unreviewed test fix.
1930         https://bugs.webkit.org/show_bug.cgi?id=144149
1931
1932         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1933         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1934         test.
1935
1936 2015-04-23  Darin Adler  <darin@apple.com>
1937
1938         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1939         https://bugs.webkit.org/show_bug.cgi?id=144090
1940
1941         Reviewed by Anders Carlsson.
1942
1943         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1944
1945 2015-04-23  Michael Saboff  <msaboff@apple.com>
1946
1947         lldb macro btjs sometimes can't get a frame description
1948         https://bugs.webkit.org/show_bug.cgi?id=144130
1949
1950         Reviewed by Filip Pizlo.
1951
1952         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1953         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1954         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1955
1956         * lldb/lldb_webkit.py:
1957         (btjs):
1958
1959 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1960
1961         Use less memory when compiling content extensions.
1962         https://bugs.webkit.org/show_bug.cgi?id=144051
1963
1964         Reviewed by Darin Adler and Benjamin Poulain.
1965
1966         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1967         (TestWebKitAPI::TEST_F):
1968         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1969         (TestWebKitAPI::countLiveNodes):
1970
1971 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1972
1973         [CMake] Clean up JSC JIT options
1974         https://bugs.webkit.org/show_bug.cgi?id=143998
1975
1976         Reviewed by Filip Pizlo.
1977
1978         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1979         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1980
1981 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1982
1983         [Mac] Extend action menus to support PDF
1984         https://bugs.webkit.org/show_bug.cgi?id=143895
1985         <rdar://problem/19003333>
1986
1987         Reviewed by Tim Horton.
1988
1989         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1990         of PDF content works.
1991
1992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1993         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1994         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1995         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1996         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1997         Update to support PDF tests.
1998         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1999         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
2000
2001 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2002
2003         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
2004
2005         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2006         (beforeAll):
2007         (testWebViewAudioOnlyUserMediaPermissionRequests):
2008
2009 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2010
2011         Add myself to watchlist
2012         https://bugs.webkit.org/show_bug.cgi?id=144041
2013
2014         Reviewed by Alex Christensen.
2015
2016         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
2017
2018         * Scripts/webkitpy/common/config/watchlist:
2019
2020 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2021
2022         [GTK] MiniBrowser should use NetworkProcess by default
2023         https://bugs.webkit.org/show_bug.cgi?id=143948
2024
2025         Reviewed by Sergio Villar Senin.
2026
2027         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
2028         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
2029
2030         * MiniBrowser/gtk/main.c:
2031         (main):
2032
2033 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
2034
2035         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
2036
2037         Unreviewed build fix.
2038
2039         * Scripts/prepare-ChangeLog:
2040         (get_function_line_ranges_for_cpp):
2041         Use grep instead of any to determine if a string is an element of an array.
2042
2043 2015-04-21  Anders Carlsson  <andersca@apple.com>
2044
2045         Fix block signatures
2046         https://bugs.webkit.org/show_bug.cgi?id=144002
2047
2048         Reviewed by Andreas Kling.
2049
2050         * MiniBrowser/mac/WK2BrowserWindowController.m:
2051         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2052
2053 2015-04-21  Philippe Normand  <pnormand@igalia.com>
2054
2055         [GTK] jhbuild should not use a branch for openwebrtc
2056         https://bugs.webkit.org/show_bug.cgi?id=143981
2057
2058         Reviewed by Carlos Garcia Campos.
2059
2060         * gtk/jhbuild.modules:
2061
2062 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
2063
2064         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
2065
2066         Unreviewed build fix.
2067
2068         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
2069         However, it has been exposed by List::MoreUtils since its inception. This patch uses
2070         the any function exposed by List::MoreUtils for greater compatibility.
2071
2072         * Scripts/prepare-ChangeLog:
2073         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
2074         the any function in all of versions of Perl used by our infrastructure.
2075
2076 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2077
2078         Remove unnecessary logs when resetting tests.
2079
2080         * WebKitTestRunner/mac/TestControllerMac.mm:
2081         (WTR::TestController::platformResetPreferencesToConsistentValues):
2082         In r183020 I added some logs when compiling or removing content extensions fails.
2083         We often try to remove a content extension that does not exist, and that is not a problem.
2084
2085 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2086
2087         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
2088         https://bugs.webkit.org/show_bug.cgi?id=143897
2089
2090         Reviewed by David Kilzer.
2091
2092         This is a speculative fix that addresses two issues:
2093
2094         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
2095         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
2096
2097         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
2098         Before: (723, 729)
2099         After: (721, 720)
2100
2101         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
2102         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
2103
2104         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
2105         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
2106
2107         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
2108
2109         2. Creating git diffs from HEAD and not origin/master by default.
2110
2111         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
2112         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
2113
2114         * Scripts/prepare-ChangeLog:
2115         (originalFile):
2116         Use HEAD instead of origin/master in default Git case.
2117
2118         (generateFunctionLists):
2119         Ensure that the end line is not less than the start line.
2120
2121         (extractLineRangeAfterChange):
2122         Set the end line to the start line if the end line is less than the start line.
2123
2124         (extractLineRangeBeforeChange):
2125         Ditto.
2126
2127 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2128
2129         Suppress warning in prepare-ChangeLog.
2130         https://bugs.webkit.org/show_bug.cgi?id=143882
2131
2132         Reviewed by David Kilzer.
2133
2134         Prune noisy prepare-ChangeLog output by using the List::Util::any function
2135         instead of the deprecated smartmatch operator.
2136
2137         * Scripts/prepare-ChangeLog:
2138         Import the List::Util::any function.
2139
2140         (get_function_line_ranges_for_cpp):
2141         Use the any function instead of smartmatch.
2142
2143 2015-04-20  Anders Carlsson  <andersca@apple.com>
2144
2145         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
2146         https://bugs.webkit.org/show_bug.cgi?id=143966
2147
2148         Reviewed by Dan Bernstein.
2149
2150         * MiniBrowser/mac/WK2BrowserWindowController.m:
2151         (dataTypes):
2152         (-[WK2BrowserWindowController fetchWebsiteData:]):
2153         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2154         (-[WK2BrowserWindowController clearWebsiteData:]):
2155
2156 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2157
2158         Fix content extension test flakiness.
2159         https://bugs.webkit.org/show_bug.cgi?id=143950
2160
2161         Reviewed by Brady Eidson.
2162
2163         * WebKitTestRunner/mac/TestControllerMac.mm:
2164         (WTR::TestController::platformResetPreferencesToConsistentValues):
2165         Remove the TestContentExtensions if it exists.
2166         (WTR::TestController::platformConfigureViewForTest):
2167         Log errors in case there are any.
2168
2169 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2170
2171         Properly report errors from _WKUserContentExtensionStore.
2172         https://bugs.webkit.org/show_bug.cgi?id=143808
2173
2174         Reviewed by Darin Adler.
2175
2176         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2177         (TEST_F):
2178
2179 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2180
2181         Add a rule for NetworkCache to watchlist file
2182         https://bugs.webkit.org/show_bug.cgi?id=143945
2183
2184         Reviewed by Sergio Villar Senin.
2185
2186         And add myself to the list of watchers.
2187
2188         * Scripts/webkitpy/common/config/watchlist:
2189
2190 2015-04-19  Darin Adler  <darin@apple.com>
2191
2192         Update RefPtr documentation and deprecation
2193         https://bugs.webkit.org/show_bug.cgi?id=143936
2194
2195         Reviewed by Andreas Kling.
2196
2197         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
2198
2199 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2200
2201         Introduce bytecode intrinsics
2202         https://bugs.webkit.org/show_bug.cgi?id=143926
2203
2204         Reviewed by Filip Pizlo.
2205
2206         Change cpplint to accept emit_intrinsic_XXX.
2207
2208         * Scripts/webkitpy/style/checkers/cpp.py:
2209         (check_identifier_name_in_declaration):
2210
2211 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
2212
2213         Fix lldb_webkit.py to show StringImpls correctly
2214         https://bugs.webkit.org/show_bug.cgi?id=143920
2215
2216         Reviewed by Andreas Kling.
2217         
2218         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
2219
2220         * lldb/lldb_webkit.py:
2221         (WTFStringImplProvider.is_8bit):
2222
2223 2015-04-17  Daniel Bates  <dabates@apple.com>
2224
2225         Not able to build WebKit against iOS Simulator 8.3 SDK
2226         https://bugs.webkit.org/show_bug.cgi?id=143883
2227
2228         Reviewed by David Kilzer.
2229
2230         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
2231         so that Xcode uses them.
2232
2233         * Scripts/copy-webkitlibraries-to-product-directory:
2234
2235 2015-04-17  Beth Dakin  <bdakin@apple.com>
2236
2237         Force mouse events should go through normal mouse event handling code paths
2238         https://bugs.webkit.org/show_bug.cgi?id=143749
2239         -and corresponding-
2240         rdar://problem/20472895
2241
2242         Reviewed by Dean Jackson.
2243
2244         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2245         Since there is not a way to create an NSEventTypePressure from scratch, we 
2246         subclass NSEvent and override all of the critical methods.
2247
2248         * WebKitTestRunner/EventSenderProxy.h:
2249         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2250         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2251         (WTR::EventSendingController::mouseForceDown):
2252         (WTR::EventSendingController::mouseForceUp):
2253         (WTR::EventSendingController::mouseForceChanged):
2254         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2255         * WebKitTestRunner/TestController.cpp:
2256         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2257         * WebKitTestRunner/mac/EventSenderProxy.mm:
2258         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2259         (-[EventSenderPressureEvent timestamp]):
2260         (-[EventSenderPressureEvent type]):
2261         (-[EventSenderPressureEvent locationInWindow]):
2262         (-[EventSenderPressureEvent location]):
2263         (-[EventSenderPressureEvent stage]):
2264         (-[EventSenderPressureEvent pressure]):
2265         (-[EventSenderPressureEvent phase]):
2266         (-[EventSenderPressureEvent eventNumber]):
2267         (WTR::EventSenderProxy::mouseForceDown):
2268         (WTR::EventSenderProxy::mouseForceUp):
2269         (WTR::EventSenderProxy::mouseForceChanged):
2270
2271 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
2272
2273         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
2274         https://bugs.webkit.org/show_bug.cgi?id=143885
2275
2276         Reviewed by Tim Horton.
2277
2278         Fixed a case where we have two builds with the same revision(s). An in order build
2279         is one for which the revision is strictly higher.
2280
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2282         (BuildbotQueue.prototype._checkForInOrderResult):
2283         (BuildbotQueue.prototype.compareIterationsByRevisions):
2284
2285 2015-04-17  Commit Queue  <commit-queue@webkit.org>
2286
2287         Unreviewed, rolling out r182912 and r182920.
2288         https://bugs.webkit.org/show_bug.cgi?id=143881
2289
2290         Build breakage in some configurations (Requested by ap on
2291         #webkit).
2292
2293         Reverted changesets:
2294
2295         "Force mouse events should go through normal mouse event
2296         handling code paths"
2297         https://bugs.webkit.org/show_bug.cgi?id=143749
2298         http://trac.webkit.org/changeset/182912
2299
2300         http://trac.webkit.org/changeset/182920
2301
2302 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
2303
2304         [GTK] One more unreviewed fix after r182882.
2305
2306         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
2307
2308 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
2309
2310         [GTK] Unreviewed speculative clean build fix after r182882.
2311
2312         TestWebKitAPI's forwarding header generator depended on WeKit2's
2313         which generated SOUP related forwarding headers too.
2314
2315         This dependency isn't necessary and was removed by r182882 to make
2316         forwarding header generators parallelizable. But in this case
2317         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
2318         should generate SOUP related forwarding headers too similar to EFL.
2319
2320         * TestWebKitAPI/PlatformGTK.cmake:
2321         * WebKitTestRunner/PlatformGTK.cmake:
2322
2323 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2324
2325         [SOUP] Redirect to non HTTP destination is broken
2326         https://bugs.webkit.org/show_bug.cgi?id=143866
2327
2328         Reviewed by Sergio Villar Senin.
2329
2330         Add a unit test to check that redirect to a data URI works.
2331
2332         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2333         (testRedirectToDataURI):
2334         (serverCallback):
2335         (beforeAll):
2336
2337 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2338
2339         Changes method of quitting iOS Simulator to be more correct.
2340         https://bugs.webkit.org/show_bug.cgi?id=143847
2341         <rdar://problem/20530344>
2342
2343         Reviewed by Darin Adler.
2344
2345         Fixes by addressing the app by ID rather than by name.
2346
2347         * Scripts/webkitdirs.pm:
2348         (quitIOSSimulator):
2349         * Scripts/webkitpy/port/ios.py:
2350         (IOSSimulatorPort.check_sys_deps):
2351
2352 2015-04-16  Anders Carlsson  <andersca@apple.com>
2353
2354         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
2355         https://bugs.webkit.org/show_bug.cgi?id=143844
2356
2357         Reviewed by Dan Bernstein.
2358
2359         * MiniBrowser/mac/AppDelegate.m:
2360         (-[BrowserAppDelegate newPrivateWindow:]):
2361         * MiniBrowser/mac/WK2BrowserWindowController.m:
2362         (-[WK2BrowserWindowController initWithConfiguration:]):
2363         (-[WK2BrowserWindowController fetchWebsiteData:]):
2364         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2365         (-[WK2BrowserWindowController clearWebsiteData:]):
2366
2367 2015-04-16  Alex Christensen  <achristensen@webkit.org>
2368
2369         32-bit build fix.
2370
2371         * WebKitTestRunner/mac/TestControllerMac.mm:
2372         (WTR::TestController::platformResetPreferencesToConsistentValues):
2373         (WTR::TestController::platformConfigureViewForTest):
2374         Added WK_API_ENABLED.
2375
2376 2015-04-16  Alex Christensen  <achristensen@webkit.org>
2377
2378         Removed unused WKUserContentFilterRef.
2379         https://bugs.webkit.org/show_bug.cgi?id=143852
2380
2381         Reviewed by Sam Weinig.
2382
2383         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2384         * WebKitTestRunner/mac/TestControllerMac.mm:
2385         (WTR::TestController::platformResetPreferencesToConsistentValues):
2386         (WTR::TestController::platformConfigureViewForTest):
2387
2388 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2389
2390         Unreviewed. Adding myself as a commiter in contributers.json.
2391
2392         * Scripts/webkitpy/common/config/contributors.json:
2393
2394 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
2395
2396         It is very hard to attach a debugger to WebProcess to debug tests
2397         https://bugs.webkit.org/show_bug.cgi?id=143837
2398
2399         Reviewed by Chris Dumez.
2400
2401         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
2402         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
2403
2404         Now it disables all timeouts in tools, as is best for debugging tests.
2405
2406         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
2407         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
2408
2409         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
2410         now has the same functionality.
2411
2412 2015-04-16  Beth Dakin  <bdakin@apple.com>
2413
2414         Force mouse events should go through normal mouse event handling code paths
2415         https://bugs.webkit.org/show_bug.cgi?id=143749
2416         -and corresponding-
2417         rdar://problem/20472895
2418
2419         Reviewed by Dean Jackson.
2420
2421         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2422         Since there is not a way to create an NSEventTypePressure from scratch, we 
2423         subclass NSEvent and override all of the critical methods.
2424
2425         * WebKitTestRunner/EventSenderProxy.h:
2426         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2427         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2428         (WTR::EventSendingController::mouseForceDown):
2429         (WTR::EventSendingController::mouseForceUp):
2430         (WTR::EventSendingController::mouseForceChanged):
2431         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2432         * WebKitTestRunner/TestController.cpp:
2433         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2434         * WebKitTestRunner/mac/EventSenderProxy.mm:
2435         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2436         (-[EventSenderPressureEvent timestamp]):
2437         (-[EventSenderPressureEvent type]):
2438         (-[EventSenderPressureEvent locationInWindow]):
2439         (-[EventSenderPressureEvent location]):
2440         (-[EventSenderPressureEvent stage]):
2441         (-[EventSenderPressureEvent pressure]):
2442         (-[EventSenderPressureEvent phase]):
2443         (-[EventSenderPressureEvent eventNumber]):
2444         (WTR::EventSenderProxy::mouseForceDown):
2445         (WTR::EventSenderProxy::mouseForceUp):
2446         (WTR::EventSenderProxy::mouseForceChanged):
2447
2448 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2449
2450         [EFL] Bump LLVM to version 3.6.0 on X86_64
2451         https://bugs.webkit.org/show_bug.cgi?id=143604
2452
2453         Reviewed by Gyuyoung Kim.
2454
2455         * efl/jhbuild.modules:
2456         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
2457         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
2458         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
2459         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
2460
2461 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2462
2463         [EFL] Remove an unnecessary workaround from jhbuildrc
2464         https://bugs.webkit.org/show_bug.cgi?id=143823
2465
2466         Reviewed by Gyuyoung Kim.
2467
2468         * efl/jhbuildrc:
2469
2470 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2471
2472         [GTK] Run forwarding headers generator unconditionally
2473         https://bugs.webkit.org/show_bug.cgi?id=143819
2474
2475         Reviewed by Carlos Garcia Campos.
2476
2477         * TestWebKitAPI/PlatformGTK.cmake:
2478         * WebKitTestRunner/PlatformGTK.cmake:
2479
2480 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2481
2482         [EFL] Add gnutls to jhbuild.module
2483         https://bugs.webkit.org/show_bug.cgi?id=143777
2484
2485         Reviewed by Csaba Osztrogonác.
2486
2487         EFL port has required at least 3.0.0 version of gnutls since r176712.
2488         However some old linux distributions don't support 3.0.0 version. Besides
2489         other projects sometimes need to use lower version of gnutls.
2490
2491         This patch supports to download gnutls through jhbuild, and use it.
2492
2493         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
2494         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
2495
2496 2015-04-15  Mark Lam  <mark.lam@apple.com>
2497
2498         Remove obsolete VMInspector debugging tool.
2499         https://bugs.webkit.org/show_bug.cgi?id=143798
2500
2501         Reviewed by Michael Saboff.
2502
2503         * TestWebKitAPI/CMakeLists.txt:
2504         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2505         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2507         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
2508
2509 2015-04-15  Jer Noble  <jer.noble@apple.com>
2510
2511         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
2512
2513         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2514
2515 2015-04-15  Jer Noble  <jer.noble@apple.com>
2516
2517         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
2518
2519         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2520         (TestWebKitAPI::TEST_F):
2521
2522 2015-04-15  Chris Dumez  <cdumez@apple.com>
2523
2524         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
2525         https://bugs.webkit.org/show_bug.cgi?id=143779
2526
2527         Reviewed by Brent Fulgham.
2528
2529         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
2530         similarly to what is done on Mac / WK1. Without this, PageCache could
2531         stay enabled after page cache tests and cause weird behaviors.
2532
2533         * DumpRenderTree/win/DumpRenderTree.cpp:
2534         (resetWebPreferencesToConsistentValues):
2535
2536 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
2537
2538         Re-enable custom dilation for antialiased fonts
2539         https://bugs.webkit.org/show_bug.cgi?id=143738
2540
2541         Reviewed by Tim Horton.
2542         
2543         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
2544         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
2545         a private WebKit pref. This pref defaults to YES, enabling the feature by default
2546         in WK1 as we do for WK2.
2547
2548         * DumpRenderTree/mac/DumpRenderTree.mm:
2549         (resetWebPreferencesToConsistentValues):
2550         * WebKitTestRunner/TestController.cpp:
2551         (WTR::TestController::resetPreferencesToConsistentValues):
2552
2553 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
2554
2555         Correct layering violation in DumpRenderTree Build
2556         https://bugs.webkit.org/show_bug.cgi?id=143732
2557
2558         Reviewed by Simon Fraser.
2559
2560         Correct a layering violation in DumpRenderTree by calling functions on the
2561         WebCoreTestSupport library, rather than attempting to work with WebCore
2562         types directly.
2563
2564         * DumpRenderTree/mac/EventSendingController.mm:
2565         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
2566         than WebCore itself.,
2567         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
2568
2569 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
2570
2571         Add a conservative DFA minimizer for the content extension matcher
2572         https://bugs.webkit.org/show_bug.cgi?id=143501
2573
2574         Reviewed by Alex Christensen.
2575
2576         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2577         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2578
2579 2015-04-14  Daniel Bates  <dabates@apple.com>
2580
2581         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
2582         https://bugs.webkit.org/show_bug.cgi?id=143693
2583         <rdar://problem/20530316>
2584
2585         Reviewed by Tim Horton.
2586
2587         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
2588         to use the fixed layout code on iOS at this time.
2589
2590         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
2591
2592 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
2593
2594         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
2595         https://bugs.webkit.org/show_bug.cgi?id=143705
2596
2597         Unreviewed change to watchlist file.
2598
2599         * Scripts/webkitpy/common/config/watchlist:
2600
2601 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
2602
2603         [EFL] favicon wasn't updated for google.com sometimes.
2604         https://bugs.webkit.org/show_bug.cgi?id=141940
2605
2606         Reviewed by Gyuyoung Kim.
2607
2608         As elm_entry_utf8_to_markup can include additional characters, parameter for the
2609         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
2610
2611         * MiniBrowser/efl/main.c:
2612         (on_url_changed):
2613
2614 2015-04-13  Tim Horton  <timothy_horton@apple.com>
2615
2616         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
2617         https://bugs.webkit.org/show_bug.cgi?id=143560
2618         <rdar://problem/16302047>
2619
2620         Reviewed by Darin Adler.
2621
2622         * MiniBrowser/mac/BrowserWindowController.h:
2623         * MiniBrowser/mac/MainMenu.xib:
2624         * MiniBrowser/mac/WK1BrowserWindowController.m:
2625         (-[WK1BrowserWindowController setScale:]):
2626         * MiniBrowser/mac/WK2BrowserWindowController.m:
2627         (viewScaleForMenuItemTag):
2628         (-[WK2BrowserWindowController setScale:]):
2629         (-[WK2BrowserWindowController validateMenuItem:]):
2630         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
2631         When in use, we resize the window so that the view fits correctly, and
2632         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
2633         layout size will not change when scaling down (but will update appropriately
2634         when the view is resized).
2635
2636 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2637
2638         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
2639         https://bugs.webkit.org/show_bug.cgi?id=138630
2640
2641         Reviewed by Tim Horton.
2642
2643         Make sure that we always load at least one in order productive iteration.
2644
2645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2646         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
2647         is done loading at least one iteration that wasn't an out of order build.
2648         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
2649         when that's needed to check for out of order builds.
2650         (BuildbotQueue.prototype.update): Ditto.
2651         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
2652         result, and if it does not, load more iterations.
2653         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
2654         an in order iteration loaded too.
2655         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
2656         corrected to always sort loaded iterations before unloaded ones.
2657
2658 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
2659
2660         Expand test infrastructure to support scrolling tests
2661         https://bugs.webkit.org/show_bug.cgi?id=143286
2662         <rdar://problem/20375516>
2663
2664         Reviewed by Simon Fraser.
2665
2666         Extend the WK1 and WK2 test programs to support two new EventSender commands:
2667         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
2668         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
2669         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
2670         relevant rubberband, scroll, and scroll-snap animations are finished.
2671
2672         * DumpRenderTree/mac/EventSendingController.mm:
2673         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
2674         and 'monitorWheelEvents'.
2675         (+[EventSendingController webScriptNameForSelector:]): Ditto.
2676         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
2677         debugging test failures.
2678         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
2679         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
2680         function, then passes it to WebCore to be called once the test deferrals have been cleared.
2681         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
2682         'callAfterScrollingCompletes' method.
2683         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
2684         and 'monitorWheelEvents'.
2685         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2686         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
2687         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
2688         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
2689         'callAfterScrollingComplates' method.
2690         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2691
2692 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2693
2694         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
2695         https://bugs.webkit.org/show_bug.cgi?id=143656
2696
2697         Reviewed by Darin Adler.
2698
2699         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2700         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2701
2702 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
2703
2704         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
2705         https://bugs.webkit.org/show_bug.cgi?id=142387
2706
2707         Reviewed by Carlos Garcia Campos.
2708
2709         Running mixed content is blocked by default since r181134. Updated
2710         the test case to reflect the new default settings.
2711
2712         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2713         (testInsecureContent):
2714
2715 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2716
2717         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
2718         https://bugs.webkit.org/show_bug.cgi?id=143667
2719
2720         Reviewed by Csaba Osztrogonác.
2721
2722         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
2723         since r169017. Added $hardwareConcurrencySupport for it.
2724
2725         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
2726
2727         * Scripts/webkitperl/FeatureList.pm:
2728
2729 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
2730
2731         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
2732         https://bugs.webkit.org/show_bug.cgi?id=143664
2733
2734         Reviewed by Gyuyoung Kim.
2735
2736         * Scripts/webkitperl/FeatureList.pm:
2737
2738 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2739
2740         [EFL] Enable Media Source
2741         https://bugs.webkit.org/show_bug.cgi?id=143635
2742
2743         Reviewed by Csaba Osztrogonác.
2744
2745         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2746
2747 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
2748
2749         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2750         https://bugs.webkit.org/show_bug.cgi?id=143646
2751
2752         Reviewed by David Kilzer.
2753
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2755         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2756
2757 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
2758
2759         Use en_US spell checker for tests on Mac instead of Multilingual
2760         https://bugs.webkit.org/show_bug.cgi?id=143641
2761
2762         Reviewed by Dan Bernstein.
2763
2764         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2765         While at it, override NSUserDictionaryReplacementItems, so that user replacements
2766         cannot affect tests.
2767
2768         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2769         Made this more like WebKit1 version.
2770
2771 2015-04-10  Tim Horton  <timothy_horton@apple.com>
2772
2773         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2774         https://bugs.webkit.org/show_bug.cgi?id=143576
2775
2776         Reviewed by Simon Fraser.
2777
2778         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2779         (TEST):
2780         Adopt.
2781
2782 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2783
2784         Update my email address and expertise.
2785         https://bugs.webkit.org/show_bug.cgi?id=143586
2786
2787         Unreviewed, just update my info.
2788
2789         * Scripts/webkitpy/common/config/contributors.json:
2790
2791 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
2792
2793         Flakiness Dashboard not loading insecure content if loaded with https URL
2794         https://bugs.webkit.org/show_bug.cgi?id=143570
2795
2796         Reviewed by Alexey Proskuryakov.
2797
2798         * TestResultServer/app.yaml:
2799         * TestResultServer/static-dashboards/loader.js:
2800         Switch to https scheme.
2801
2802 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
2803
2804         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2805         https://bugs.webkit.org/show_bug.cgi?id=142907
2806
2807         Reviewed by Carlos Garcia Campos.
2808
2809         * TestWebKitAPI/PlatformEfl.cmake:
2810         * TestWebKitAPI/PlatformGTK.cmake:
2811         * WebKitTestRunner/PlatformEfl.cmake:
2812         * WebKitTestRunner/PlatformGTK.cmake:
2813
2814 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2815
2816         [Mac] Unreviewed test fix after r182584
2817         https://bugs.webkit.org/show_bug.cgi?id=143452
2818
2819         Put both of these tests back to their original state now that the underlying
2820         problem is fixed.
2821
2822         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2823         (TestWebKitAPI::TEST):
2824         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2825         (TestWebKitAPI::TEST):
2826
2827 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
2828
2829         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2830         https://bugs.webkit.org/show_bug.cgi?id=143553
2831
2832         Reviewed by Ryosuke Niwa.
2833         
2834         Remove the spurious printVMs left over from an earlier change.
2835
2836         * Scripts/run-jsc-benchmarks:
2837
2838 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2839
2840         [Mac] Unreviewed test fix after r182581
2841
2842         The behavior of control-left-click is controlled by a system preference.
2843         Our test bots have this turned off.
2844
2845         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2846         (TestWebKitAPI::TEST):
2847         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2848         (TestWebKitAPI::TEST):
2849
2850 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2851
2852         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2853         https://bugs.webkit.org/show_bug.cgi?id=143452
2854         <rdar://problem/20437483>
2855
2856         Reviewed by Tim Horton.
2857
2858         Add a new API test to confirm that Cocoa mouse button press events are properly
2859         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2860
2861         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2862         some registered event handlers that the expected button press and context menu
2863         events are received.
2864
2865         The WK1 unit test creates an NSEvent with the desired button press state, and then
2866         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2867         We check the resulting PlatformMouseEvent for proper state.
2868
2869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2870         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2871         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2872         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2873         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2874         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2875         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2876         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2877         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2878         mouse down events.
2879         * TestWebKitAPI/mac/PlatformWebViewMac.h:
2880
2881 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2882
2883         [GTK] Add pango to jhbuild-optional.modules
2884         https://bugs.webkit.org/show_bug.cgi?id=143537
2885
2886         Reviewed by Martin Robinson.
2887
2888         * gtk/jhbuild-optional.modules: Add pango.
2889
2890 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2891
2892         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2893         https://bugs.webkit.org/show_bug.cgi?id=143530
2894
2895         Reviewed by Žan Doberšek.
2896
2897         Assume that the default value for display (:0) is reserved and start checking on :1
2898         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2899         and for X server named Xorg.bin (previous bug 1376599)
2900
2901         * Scripts/webkitpy/port/xvfbdriver.py:
2902         (XvfbDriver._next_free_display)
2903         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2904         (XvfbDriverTest.test_start_no_pixel_tests):
2905         (XvfbDriverTest.test_start_pixel_tests):
2906         (XvfbDriverTest.test_start_arbitrary_worker_number):
2907         (XvfbDriverTest.test_next_free_display):
2908         (XvfbDriverTest.test_start_next_worker):
2909 2015-04-08  Alex Christensen  <achristensen@webkit.org>
2910
2911         Block popups from content extensions.
2912         https://bugs.webkit.org/show_bug.cgi?id=143497
2913
2914         Reviewed by Brady Eidson.
2915
2916         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2917         (TestWebKitAPI::TEST_F):
2918         Added popup test.
2919
2920 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
2921
2922         Add CMake build system for WinCairo port.
2923         https://bugs.webkit.org/show_bug.cgi?id=115944
2924
2925         Reviewed by Chris Dumez.
2926
2927         * CMakeLists.txt:
2928         * WinLauncher/CMakeLists.txt: Added.
2929
2930 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2931
2932         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2933         https://bugs.webkit.org/show_bug.cgi?id=143521
2934
2935         Reviewed by Martin Robinson.
2936
2937         Add a way to detect unexpected web process crashes to WebViewTest,
2938         and a test case to testDOMCache to trigger the crash.
2939
2940         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2941         (WebKitDOMNodeTest::testDOMCache):
2942         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2943         (testWebKitWebViewProcessCrashed):
2944         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2945         (WebViewTest::WebViewTest):
2946         (WebViewTest::webProcessCrashed):
2947         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2948
2949 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2950
2951         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2952         rdar://problem/20461342
2953
2954         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2955
2956 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2957
2958         Unreviewed, rolling out r182511.
2959         https://bugs.webkit.org/show_bug.cgi?id=143507
2960
2961         caused debug test failures (Requested by alexchristensen on
2962         #webkit).
2963
2964         Reverted changeset:
2965
2966         "Block popups from content extensions."
2967         https://bugs.webkit.org/show_bug.cgi?id=143497
2968         http://trac.webkit.org/changeset/182511
2969
2970 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2971
2972         Block popups from content extensions.
2973         https://bugs.webkit.org/show_bug.cgi?id=143497
2974
2975         Reviewed by Brady Eidson.
2976
2977         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2978         (TestWebKitAPI::TEST_F):
2979         Added popup test.
2980
2981 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2982
2983         Get the features.json files ready for open contributions
2984         https://bugs.webkit.org/show_bug.cgi?id=143436
2985
2986         Reviewed by Darin Adler.
2987
2988         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2989         (JSONFeaturesChecker.check):
2990         Extend the syntax checking a bit, but leave everything non-mandatory
2991         very loose until we figure what fields are important.
2992
2993 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2994
2995         Expose and test fixedLayoutSize via modern WebKit SPI
2996         https://bugs.webkit.org/show_bug.cgi?id=143500
2997
2998         Reviewed by Simon Fraser.
2999
3000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3001         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
3002         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
3003         (TEST):
3004         Add a test that verifies that fixedLayoutSize works at all, that
3005         it persists through a navigation, and that turning it back off reverts to
3006         laying out at the size of the view.
3007
3008 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3009
3010         Unreviewed. Add myself as a committer.
3011
3012         * Scripts/webkitpy/common/config/contributors.json:
3013
3014 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
3015
3016         [Win] Bots complain about missing /etc/catalog
3017         https://bugs.webkit.org/show_bug.cgi?id=143484
3018
3019         Reviewed by Chris Dumez.
3020
3021         The libxml2 build on Mac, iOS, and Windows does not provide the set
3022         of default catalog files. We do not actually need these for our
3023         purposes, but we get warnings and some bot flakiness because they
3024         are not present.
3025
3026         We can avoid both problems the same way the Mac and iOS ports do,
3027         by setting the XML_CATALOG_FILES environment variable to 'empty string',
3028         which avoid the warnings and bot problems.
3029
3030         * Scripts/webkitpy/port/win.py:
3031         (WinPort.setup_environ_for_server): Added.
3032
3033 2015-04-06  Sam Weinig  <sam@webkit.org>
3034
3035         Use content extensions in MiniBrowser.
3036         https://bugs.webkit.org/show_bug.cgi?id=143446
3037
3038         Reviewed by Alex Christensen.
3039
3040         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3041         * MiniBrowser/mac/AppDelegate.h:
3042         * MiniBrowser/mac/AppDelegate.m:
3043         (-[BrowserAppDelegate init]):
3044         (-[BrowserAppDelegate showExtensionsManager:]):
3045         (-[BrowserAppDelegate userContentContoller]):
3046         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
3047         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
3048         (-[ExtensionManagerWindowController init]):
3049         (-[ExtensionManagerWindowController windowDidLoad]):
3050         (-[ExtensionManagerWindowController add:]):
3051         (-[ExtensionManagerWindowController remove:]):
3052         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
3053         * MiniBrowser/mac/MainMenu.xib:
3054
3055 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3056
3057         web-platform-tests server should retrieve the modules file relatively to its docroot path
3058         https://bugs.webkit.org/show_bug.cgi?id=142742
3059
3060         Reviewed by Darin Adler.
3061
3062         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3063         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
3064
3065 2015-04-06  Commit Queue  <commit-queue@webkit.org>
3066
3067         Unreviewed, rolling out r182445.
3068         https://bugs.webkit.org/show_bug.cgi?id=143459
3069
3070         broke 32 bit build (Requested by alexchristensen on #webkit).
3071
3072         Reverted changeset:
3073
3074         "Use content extensions in MiniBrowser."
3075         https://bugs.webkit.org/show_bug.cgi?id=143446
3076         http://trac.webkit.org/changeset/182445
3077
3078 2015-04-06  Sam Weinig  <sam@webkit.org>
3079
3080         Use content extensions in MiniBrowser.
3081         https://bugs.webkit.org/show_bug.cgi?id=143446
3082
3083         Reviewed by Alex Christensen.
3084
3085         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3086         * MiniBrowser/mac/AppDelegate.h:
3087         * MiniBrowser/mac/AppDelegate.m:
3088         (-[BrowserAppDelegate init]):
3089         (-[BrowserAppDelegate showExtensionsManager:]):
3090         (-[BrowserAppDelegate userContentContoller]):
3091         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
3092         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
3093         (-[ExtensionManagerWindowController init]):
3094         (-[ExtensionManagerWindowController windowDidLoad]):
3095         (-[ExtensionManagerWindowController add:]):
3096         (-[ExtensionManagerWindowController remove:]):
3097         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
3098         * MiniBrowser/mac/MainMenu.xib:
3099
3100 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
3101
3102         [GTK] install-dependencies should prefer dnf to yum
3103         https://bugs.webkit.org/show_bug.cgi?id=143441
3104
3105         Reviewed by Martin Robinson.
3106
3107         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
3108
3109         * gtk/install-dependencies:
3110
3111 2015-04-06  Andy Estes  <aestes@apple.com>
3112
3113         [iOS] 'make clean' fails in Tools/WebKitTestRunner
3114         https://bugs.webkit.org/show_bug.cgi?id=143455
3115
3116         Reviewed by Dan Bernstein.
3117
3118         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
3119         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
3120
3121         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
3122
3123 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
3124
3125         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
3126         https://bugs.webkit.org/show_bug.cgi?id=143450
3127
3128         Reviewed by Anders Carlsson.
3129
3130         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
3131         Make sure that the view is actually closed, regardless of anything else that happens beneath.
3132         Also, removed unnecessary get() calls.
3133
3134 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
3135
3136         Reduce the dependency on Flash in regression tests
3137         https://bugs.webkit.org/show_bug.cgi?id=143391
3138
3139         Reviewed by Anders Carlsson.
3140
3141         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
3142         Only allow QuickTime and the test plug-in.
3143
3144 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3145
3146         W3C test importer should generate the modules installed dynamically to run wpt tests
3147         https://bugs.webkit.org/show_bug.cgi?id=142738
3148
3149         Reviewed by Ryosuke Niwa.
3150
3151         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
3152         The implementation is done within TestDownloader and it is activated for the WPT repository.
3153         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
3154
3155         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3156         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
3157         * Scripts/webkitpy/w3c/test_downloader.py:
3158         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
3159         (TestDownloader):
3160         (TestDownloader._git_submodules_description): Computes submodule description.
3161         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
3162         * Scripts/webkitpy/w3c/test_importer.py:
3163         (TestImporter.do_import): Added the possibility to post process the tests.
3164         (TestImporter):
3165         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
3166         (TestImporter.should_convert_test_harness_links): Updated according new options format.
3167         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3168         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
3169         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
3170         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
3171         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
3172         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
3173
3174 2015-04-05  Antti Koivisto  <antti@apple.com>
3175
3176         Bloom filter should support longer hashes
3177         https://bugs.webkit.org/show_bug.cgi?id=143419
3178
3179         Reviewed by Dan Bernstein.
3180
3181         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
3182         (TestWebKitAPI::generateRandomDigests):
3183         (TestWebKitAPI::TEST):
3184
3185 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3186
3187         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
3188         https://bugs.webkit.org/show_bug.cgi?id=143372
3189
3190         Reviewed by Darin Adler.
3191
3192         * Scripts/run-jsc-stress-tests:
3193
3194 2015-04-03  Antti Koivisto  <antti@apple.com>
3195
3196         Add non-counting bloom filter class
3197         https://bugs.webkit.org/show_bug.cgi?id=143366
3198
3199         Reviewed by Sam Weinig.
3200
3201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3202         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
3203         (TestWebKitAPI::generateRandomHashes):
3204         (TestWebKitAPI::TEST):
3205
3206 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3207
3208         FTL JIT tests should fail if LLVM library isn't available
3209         https://bugs.webkit.org/show_bug.cgi?id=143374
3210
3211         Reviewed by Mark Lam.
3212
3213         * Scripts/run-jsc-stress-tests:
3214
3215 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3216
3217         [EFL] Speedup jhbuild with disable running autogen.sh
3218         https://bugs.webkit.org/show_bug.cgi?id=143369
3219
3220         Reviewed by Gyuyoung Kim.
3221
3222         * efl/jhbuild.modules:
3223
3224 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3225
3226         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
3227         https://bugs.webkit.org/show_bug.cgi?id=143282
3228
3229         Reviewed by Daniel Bates.
3230
3231         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
3232
3233 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3234
3235         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
3236         https://bugs.webkit.org/show_bug.cgi?id=143240
3237         rdar://problem/19990425
3238
3239         Reviewed by Tim Horton.
3240
3241         * DumpRenderTree/mac/LayoutTestHelper.m:
3242         (colorProfileURLForDisplay):
3243         (saveDisplayColorProfiles):
3244         Gracefully handle it when the current profile cannot be retrieved, fixing at
3245         least one case when LayoutTestHelper couldn't start.
3246
3247         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3248         (Manager._set_up_run):
3249         (Manager._force_pixel_tests_if_needed):
3250         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
3251         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
3252         Return and check an error from start_helper().
3253
3254 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
3255
3256         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
3257         https://bugs.webkit.org/show_bug.cgi?id=143321
3258
3259         Reviewed by Alexey Proskuryakov.
3260
3261         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
3262
3263 2015-04-01  Enrica Casucci  <enrica@apple.com>
3264
3265         Injected bundle messages should be at the page level.
3266         https://bugs.webkit.org/show_bug.cgi?id=143283
3267
3268         Reviewed by Alexey Proskuryakov.
3269
3270         Updating WebKitTestRunner to use the new page level messaging.
3271         The author of this patch is Tim Horton, I just finished it.
3272
3273         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3274         (WTR::EventSendingController::mouseDown):
3275         (WTR::EventSendingController::mouseUp):
3276         (WTR::EventSendingController::mouseMoveTo):
3277         (WTR::EventSendingController::leapForward):
3278         (WTR::EventSendingController::scheduleAsynchronousClick):
3279         (WTR::EventSendingController::keyDown):
3280         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3281         (WTR::EventSendingController::mouseScrollBy):
3282         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3283         (WTR::EventSendingController::continuousMouseScrollBy):
3284         (WTR::EventSendingController::addTouchPoint):
3285         (WTR::EventSendingController::updateTouchPoint):
3286         (WTR::EventSendingController::setTouchModifier):
3287         (WTR::EventSendingController::setTouchPointRadius):
3288         (WTR::EventSendingController::touchStart):
3289         (WTR::EventSendingController::touchMove):
3290         (WTR::EventSendingController::touchEnd):
3291         (WTR::EventSendingController::touchCancel):
3292         (WTR::EventSendingController::clearTouchPoints):
3293         (WTR::EventSendingController::releaseTouchPoint):
3294         (WTR::EventSendingController::cancelTouchPoint):
3295         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3296         (WTR::InjectedBundle::didReceiveMessage):
3297         (WTR::InjectedBundle::didReceiveMessageToPage):
3298         (WTR::InjectedBundle::done):
3299         (WTR::InjectedBundle::outputText):
3300         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3301         (WTR::InjectedBundle::postAddChromeInputField):
3302         (WTR::InjectedBundle::postRemoveChromeInputField):
3303         (WTR::InjectedBundle::postFocusWebView):
3304         (WTR::InjectedBundle::postSetBackingScaleFactor):
3305         (WTR::InjectedBundle::postSetWindowIsKey):
3306         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3307         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3308         (WTR::InjectedBundle::setGeolocationPermission):
3309         (WTR::InjectedBundle::setMockGeolocationPosition):
3310         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3311         (WTR::InjectedBundle::setUserMediaPermission):
3312         (WTR::InjectedBundle::setCustomPolicyDelegate):
3313         (WTR::InjectedBundle::setHidden):
3314         (WTR::InjectedBundle::setCacheModel):
3315         (WTR::InjectedBundle::shouldProcessWorkQueue):
3316         (WTR::InjectedBundle::processWorkQueue):
3317         (WTR::InjectedBundle::queueBackNavigation):
3318         (WTR::InjectedBundle::queueForwardNavigation):
3319         (WTR::InjectedBundle::queueLoad):
3320         (WTR::InjectedBundle::queueLoadHTMLString):
3321         (WTR::InjectedBundle::queueReload):
3322         (WTR::InjectedBundle::queueLoadingScript):
3323         (WTR::InjectedBundle::queueNonLoadingScript):
3324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3325         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3326         (WTR::TestRunner::setAuthenticationUsername):
3327         (WTR::TestRunner::setAuthenticationPassword):
3328         (WTR::TestRunner::secureEventInputIsEnabled):
3329         (WTR::TestRunner::setBlockAllPlugins):
3330         * WebKitTestRunner/TestController.cpp:
3331         (WTR::TestController::createWebViewWithOptions):
3332         (WTR::TestController::resetStateToConsistentValues):
3333         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
3334         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
3335         * WebKitTestRunner/TestController.h:
3336         * WebKitTestRunner/TestInvocation.cpp:
3337         (WTR::TestInvocation::invoke):
3338         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3339
3340 2015-04-01  Commit Queue  <commit-queue@webkit.org>
3341
3342         Unreviewed, rolling out r182174 and r182177.
3343         https://bugs.webkit.org/show_bug.cgi?id=143314
3344
3345         Try to correct EWS failures (Requested by bfulgham on
3346         #webkit).
3347
3348         Reverted changesets:
3349
3350         "Python SCM should be able to retrieve untracked files"
3351         https://bugs.webkit.org/show_bug.cgi?id=143135
3352         http://trac.webkit.org/changeset/182174
3353
3354         "[buildbot] clean-build script should remove untracked files
3355         and revert local changes too"
3356         https://bugs.webkit.org/show_bug.cgi?id=142400
3357         http://trac.webkit.org/changeset/182177
3358
3359 2015-04-01  Alex Christensen  <achristensen@webkit.org>
3360
3361         [Content Extensions] Properly handle regexes that match everything.
3362         https://bugs.webkit.org/show_bug.cgi?id=143281
3363
3364         Reviewed by Benjamin Poulain.
3365
3366         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3367         (TestWebKitAPI::testRequest):
3368         (TestWebKitAPI::makeBackend):
3369         (TestWebKitAPI::TEST_F):
3370         Removed duplicate code and added test.
3371
3372 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
3373
3374         Content Extensions: split the state machines to minimize prefix states
3375         https://bugs.webkit.org/show_bug.cgi?id=143253
3376
3377         Reviewed by Alex Christensen.
3378
3379         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3380         (TestWebKitAPI::TEST_F):
3381         (TestWebKitAPI::testPatternStatus):
3382
3383 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
3384
3385         Clean up Identifier factories to clarify the meaning of StringImpl*
3386         https://bugs.webkit.org/show_bug.cgi?id=143146
3387
3388         Reviewed by Filip Pizlo.
3389
3390         Simple API tests for StringImpl are added.
3391
3392         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3393         (TestWebKitAPI::TEST):
3394
3395 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
3396
3397         [EFL] Add AArch64 builder and tester bot to build.webkit.org
3398         https://bugs.webkit.org/show_bug.cgi?id=143092
3399
3400         Reviewed by Gyuyoung Kim.
3401
3402         * BuildSlaveSupport/build.webkit.org-config/config.json:
3403         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3404         (Factory.__init__):
3405         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3406
3407 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3408
3409         [buildbot] clean-build script should remove untracked files and revert local changes too
3410         https://bugs.webkit.org/show_bug.cgi?id=142400
3411
3412         Reviewed by Ryosuke Niwa.
3413
3414         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
3415         A helper routine SCM.discard_untracked_files is added for that purpose.
3416
3417         * BuildSlaveSupport/clean-build:
3418         (main): Making call to Scripts/clean-webkit
3419         * Scripts/clean-webkit: Added.
3420         (main): Revert changes and delete untracked files.
3421         * Scripts/webkitpy/common/checkout/scm/scm.py:
3422         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
3423         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3424         (SCMTest._shared_test_discard_untracked_files):
3425         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
3426
3427 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3428
3429         Python SCM should be able to retrieve untracked files
3430         https://bugs.webkit.org/show_bug.cgi?id=143135
3431
3432         Reviewed by Ryosuke Niwa.
3433
3434         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3435         Ignored files may be included or not in this list according boolean passed to the function.
3436
3437         * Scripts/webkitpy/common/checkout/scm/git.py:
3438         (Git.untracked_files):
3439         * Scripts/webkitpy/common/checkout/scm/scm.py:
3440         (SCM.untracked_files):
3441         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3442         (SCMTest._shared_test_untracked_files):
3443         (test_untracked_files):
3444         (GitSVNTest.test_untracked_files):
3445         * Scripts/webkitpy/common/checkout/scm/svn.py:
3446         (SVN.untracked_files):
3447
3448 2015-03-30  Alex Christensen  <achristensen@webkit.org>
3449
3450         [Content Extensions] Correctly handle regular expressions matching everything
3451         https://bugs.webkit.org/show_bug.cgi?id=143235
3452
3453         Reviewed by Benjamin Poulain.
3454
3455         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3456         (TestWebKitAPI::checkCompilerError):
3457         (TestWebKitAPI::TEST_F):
3458         Test ContentExtensionErrors.
3459
3460 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
3461
3462         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
3463         https://bugs.webkit.org/show_bug.cgi?id=143241
3464         rdar://problem/20351297
3465
3466         Reviewed by Mark Lam.
3467
3468         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3469
3470 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3471
3472         [CMake][EFL] Remove redundant library link and include path
3473         https://bugs.webkit.org/show_bug.cgi?id=143221
3474
3475         Reviewed by Csaba Osztrogonác.
3476
3477         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
3478
3479 2015-03-30  Sam Weinig  <sam@webkit.org>
3480
3481         [Content Extensions] Flesh out the UserContentExtensionStore
3482         https://bugs.webkit.org/show_bug.cgi?id=143123
3483
3484         Reviewed by Benjamin Poulain.
3485
3486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3487         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
3488         Add tests for _WKUserContentExtensionStore.
3489
3490 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3491
3492         Update install-dependencies Fedora packages after r181624
3493         https://bugs.webkit.org/show_bug.cgi?id=143215
3494
3495         Add json-glib, libv4l, openssl and pulseaudio development packages to
3496         the Fedora list providing we need them to build WebKit dependencies
3497         for this distribution.
3498
3499         Reviewed by Philippe Normand.
3500
3501         * gtk/install-dependencies:
3502
3503 2015-03-30  Commit Queue  <commit-queue@webkit.org>
3504
3505         Unreviewed, rolling out r182119.
3506         https://bugs.webkit.org/show_bug.cgi?id=143196
3507
3508         problem with syntax (Requested by youenn on #webkit).
3509
3510         Reverted changeset:
3511
3512         "[buildbot] clean-build script should remove untracked files
3513         and revert local changes too"
3514         https://bugs.webkit.org/show_bug.cgi?id=142400
3515         http://trac.webkit.org/changeset/182119
3516
3517 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
3518
3519         Start the features.json files
3520         https://bugs.webkit.org/show_bug.cgi?id=143207
3521
3522         Reviewed by Darin Adler.
3523
3524         I kept the style checking light. We'll have to figure
3525         what is the best format for each field.
3526
3527         * Scripts/webkitpy/style/checker.py:
3528         (CheckerDispatcher._create_checker):
3529         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3530         (JSONContributorsChecker.check):
3531         (JSONFeaturesChecker):
3532         (JSONFeaturesChecker.check):
3533
3534 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3535
3536         [buildbot] clean-build script should remove untracked files and revert local changes too
3537         https://bugs.webkit.org/show_bug.cgi?id=142400
3538
3539         Reviewed by Ryosuke Niwa.
3540
3541         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
3542
3543         * BuildSlaveSupport/clean-build:
3544         (main): Adding call to Tools/Scripts/clean-webkit.
3545         * Scripts/clean-webkit: Added.
3546         (main): Removes untracked and changed files.
3547         * Scripts/webkitpy/common/checkout/scm/git.py:
3548         (Git.untracked_files): Retrieves GIT untracked files.
3549         * Scripts/webkitpy/common/checkout/scm/scm.py:
3550         (SCM.untracked_files): Retrieves SVN untracked files.
3551         (SCM):
3552         (SCM.discard_untracked_files): Deletes untracked files/folders.
3553         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3554         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
3555         (test_untracked_files):
3556         (GitSVNTest.test_untracked_files):
3557         * Scripts/webkitpy/common/checkout/scm/svn.py:
3558         (SVN.untracked_files):
3559
3560 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3561
3562         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
3563         https://bugs.webkit.org/show_bug.cgi?id=143138
3564
3565         Reviewed by Csaba Osztrogonác.
3566
3567         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
3568         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
3569
3570         * ImageDiff/CMakeLists.txt:
3571         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
3572         * WebKitTestRunner/CMakeLists.txt: ditto.
3573
3574 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
3575
3576         Support building WTF on Windows without Cygwin
3577         https://bugs.webkit.org/show_bug.cgi?id=143084
3578
3579         Reviewed by Brent Fulgham.
3580
3581         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
3582         This patch also migrates to using File::Spec->catfile() for directory separators.
3583
3584         * Scripts/update-webkit-dependency:
3585         (wanted):
3586         * Scripts/update-webkit-support-libs:
3587         (wanted):
3588         (downloadExpectedVersionNumber):
3589         (zipFileVersion):
3590         (toUnixPath): Deleted.
3591         * Scripts/webkitdirs.pm:
3592         (determineSourceDir):
3593         (windowsSourceSourceDir):
3594         (windowsLibrariesDir):
3595         (windowsOutputDir):
3596         (checkInstalledTools):
3597         (buildVisualStudioProject):
3598
3599 2015-03-27  Alex Christensen  <achristensen@webkit.org>
3600
3601         Fix WinCairo bot.
3602         https://bugs.webkit.org/show_bug.cgi?id=143086
3603
3604         Reviewed by Brent Fulgham.
3605
3606         * Scripts/webkitdirs.pm:
3607         (buildVisualStudioProject):
3608         (runSvnUpdateAndResolveChangeLogs):
3609         Use ActivePerl-friendly perl.
3610
3611 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3612
3613         URTBF after r182059 to fix the EFL build.
3614
3615         * TestWebKitAPI/CMakeLists.txt:
3616
3617 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
3618
3619         Layout test results URL loads in WK1 but not WK2 minibrowser
3620         https://bugs.webkit.org/show_bug.cgi?id=143117
3621
3622         Reviewed by Tim Horton.
3623
3624         * MiniBrowser/mac/WK2BrowserWindowController.m:
3625         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
3626         everything.
3627         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
3628
3629 2015-03-26  Jer Noble  <jer.noble@apple.com>
3630
3631         Add --allowed-host support to run-webkit-tests
3632         https://bugs.webkit.org/show_bug.cgi?id=142938
3633
3634         Reviewed by Brent Fulgham.
3635
3636         Accept --allowed-host arguments from run-webkit-tests and pass them through to
3637         DumpRenderTree and WebKitTestRunner.
3638
3639         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
3640         are placed in the wrong location. The argument is compared with each tests's path, and if a
3641         relative path or a path with '..' was used, results are placed alongside the test. Take the
3642         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
3643
3644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3645         (parse_args):
3646         * Scripts/webkitpy/port/base.py:
3647         (Port.__init__):
3648         (Port.allowed_hosts):
3649         * Scripts/webkitpy/port/driver.py:
3650         (Driver.cmd_line):
3651
3652 2015-03-26  Jer Noble  <jer.noble@apple.com>
3653
3654         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
3655         https://bugs.webkit.org/show_bug.cgi?id=142931
3656
3657         Reviewed by Brent Fulgham.
3658
3659         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
3660         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
3661         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
3662         runtime.
3663
3664         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified