184eb6e84233b3ee10be3f2c23196db071e278b8
[WebKit-https.git] / Tools / ChangeLog
1 2020-06-29  Jonathan Bedard  <jbedard@apple.com>
2
3         run-javascriptcore-tests: Support Apple Silicon running x86 processes
4         https://bugs.webkit.org/show_bug.cgi?id=213487
5         <rdar://problem/64606667>
6
7         Unreviewed infrastructure fix.
8
9         * Scripts/webkitdirs.pm:
10         (architecturesForProducts): Return architecutre(), not determineArchitecture().
11
12 2020-06-29  Xabier Rodriguez Calvar  <calvaris@igalia.com>
13
14         [webkitpy] PHP7.4 support on Debian platforms
15         https://bugs.webkit.org/show_bug.cgi?id=213721
16
17         Reviewed by Carlos Garcia Campos.
18
19         * Scripts/webkitpy/port/base.py:
20         (Port._debian_php_version):
21
22 2020-06-29  Philippe Normand  <pnormand@igalia.com>
23
24         REGRESSION(r263625): [WPE][GTK] MiniBrowser output no longer includes stderr and stdout
25         https://bugs.webkit.org/show_bug.cgi?id=213696
26
27         Reviewed by Žan Doberšek.
28
29         This patch adds a new optional argument to Executive.run_command() to control stdout output.
30         By default the subprocess.PIPE value is used, to keep backward compatibility. Set the stdout
31         argument to None to display the output on the terminal tty.
32
33         The GTK and WPE run_minibrowser() implementations now use this new argument, along with
34         setting return_stderr to False to indicate we also want stderr displayed on the terminal
35         tty.
36
37         * Scripts/webkitpy/common/system/abstractexecutive.py:
38         (AbstractExecutive.run_command):
39         * Scripts/webkitpy/common/system/executive.py:
40         (Executive.run_command):
41         * Scripts/webkitpy/common/system/executive_mock.py:
42         (MockExecutive.run_command):
43         * Scripts/webkitpy/port/gtk.py:
44         (GtkPort.run_minibrowser):
45         * Scripts/webkitpy/port/wpe.py:
46         (WPEPort.run_minibrowser):
47
48 2020-06-29  Philippe Normand  <pnormand@igalia.com>
49
50         REGRESSION(r263625): run-minibrowser --debug/--release options gone
51         https://bugs.webkit.org/show_bug.cgi?id=213697
52
53         Reviewed by Žan Doberšek.
54
55         * Scripts/webkitpy/minibrowser/run_webkit_app.py:
56         (main): Explicitely skip the --target option. Previous code was also skipping --release and
57         --debug options because their `dest` is the same as with the --target option.
58
59 2020-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
60
61         [GTK][WPE] Add webkit_authentication_request_get_security_origin
62         https://bugs.webkit.org/show_bug.cgi?id=213596
63
64         Reviewed by Michael Catanzaro.
65
66         Update the unit tests to check the new API.
67
68         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
69         (testWebViewAuthenticationRequest):
70         (testWebViewAuthenticationProxy):
71         (testWebViewAuthenticationProxyHTTPS):
72
73 2020-06-28  Geoffrey Garen  <ggaren@apple.com>
74
75         Rename initializeThreading to initialize
76         https://bugs.webkit.org/show_bug.cgi?id=213674
77
78         Reviewed by Mark Lam.
79
80         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
81         (ApplicationManifestParserTest::SetUp):
82         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
83         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
84         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
85         (TestWebKitAPI::ContentExtensionTest::SetUp):
86         * TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
87         (TestWebKitAPI::TEST):
88         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
89         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
90         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
91         (WebKitTestServer::WebKitTestServer):
92         * WebKitTestRunner/TestController.cpp:
93         (WTR::TestController::initialize):
94
95 2020-06-27  Daniel Bates  <dabates@apple.com>
96
97         Revert r262654 because it caused <rdar://problem/64664156>.
98         Moreover it is no longer necessary as the embedding client
99         changes selection through a different SPI after focusing.
100
101         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
102         (TestWebKitAPI::TEST):
103
104 2020-06-27  Keith Miller  <keith_miller@apple.com>
105
106         compare-results should be able to parse multiple JSONs at once by merging them
107         https://bugs.webkit.org/show_bug.cgi?id=213685
108
109         Reviewed by Saam Barati.
110
111         This patch improves the compare-results script to enable it to
112         merge JSON output files. This is handy when running scripts by
113         hand where you'll get many a and b JSONs.  To do the merging this
114         patch moves the logic of merge-result-jsons into a shared library.
115
116         compare-results can take multiple files sequentally or by passing
117         the '-a'/'-b' flags multiple times. e.g. `/compare-results -a
118         OG-1.json -a OG-2.json -a OG-3.json -a OG-4.json -b MC-1.json
119         MC-2.json MC-3.json MC-4.json` will behave as you'd expect;
120         combining all the OG JSONs and the MC JSONs before computing the
121         result.
122
123         Lastly, the benchmark_results script now can handle duplicates of
124         an aggregator in the aggregator list. This is useful because
125         otherwise the logic of merging JSONs is significantly more
126         complicated.
127
128         * Scripts/compare-results:
129         (getOptions):
130         (main):
131         * Scripts/merge-result-jsons:
132         (readJSONFile):
133         (deepAppend): Deleted.
134         (mergeJSONs): Deleted.
135         * Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py: Copied from Tools/Scripts/merge-result-jsons.
136         (deepAppend):
137         (mergeJSONs):
138         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
139         (BenchmarkResults._aggregate_results_for_test):
140         (BenchmarkResults._lint_subtest_results):
141         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
142
143 2020-06-27  Jer Noble  <jer.noble@apple.com>
144
145         iOS Safari incorrectly reports "AppleCoreMedia" as UA string
146         https://bugs.webkit.org/show_bug.cgi?id=213245
147         <rdar://problem/64471582>
148
149         Reviewed by Youenn Fablet.
150
151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
152         * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
153         (TestWebKitAPI::parseUserAgent):
154         (TestWebKitAPI::TEST):
155
156 2020-06-27  Philippe Normand  <pnormand@igalia.com>
157
158         Migrate run-minibrowser to webkitpy
159         https://bugs.webkit.org/show_bug.cgi?id=213431
160
161         Reviewed by Jonathan Bedard.
162
163         The perl version was renamed to old-run-minibrowser and remains used by the Mac ports.
164         run-minibrowser is now a Python script hooking into webkitpy and the Port infrastructure.
165         Both WPE and GTK ports will now use the pure python implementation.
166
167         * Scripts/old-run-minibrowser: Copied from Tools/Scripts/run-minibrowser.
168         * Scripts/run-minibrowser:
169         * Scripts/webkitpy/minibrowser/run_minibrowser.py: Added.
170         (main):
171         (parse_args):
172         * Scripts/webkitpy/port/base.py:
173         (Port.run_minibrowser_arguments):
174         (Port):
175         (Port.run_minibrowser):
176         * Scripts/webkitpy/port/darwin.py:
177         (DarwinPort.environment_for_api_tests):
178         (DarwinPort):
179         (DarwinPort.run_minibrowser_arguments):
180         * Scripts/webkitpy/port/gtk.py:
181         (GtkPort.show_results_html_file):
182         (GtkPort.configuration_for_upload):
183         (GtkPort):
184         (GtkPort.run_minibrowser):
185         * Scripts/webkitpy/port/wpe.py:
186         (WPEPort.show_results_html_file):
187         (WPEPort.configuration_for_upload):
188         (WPEPort):
189         (WPEPort.run_minibrowser):
190
191 2020-06-27  Stephan Szabo  <stephan.szabo@sony.com>
192
193         [PlayStation] Update test runner for changes to Options and signing
194         https://bugs.webkit.org/show_bug.cgi?id=213650
195
196         Reviewed by Don Olmstead.
197
198         * Scripts/webkitdirs.pm: Update extension for PlayStation binary
199
200 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
201
202         [webkitpy] Allow callers to override the reported model (Part 1)
203         https://bugs.webkit.org/show_bug.cgi?id=213677
204         <rdar://problem/64834043>
205
206         Reviewed by Dewei Zhu.
207
208         * Scripts/webkitpy/port/base.py:
209         (Port.configuration_for_upload): Set the model based on --model.
210         * Scripts/webkitpy/port/factory.py:
211         (configuration_options): Add --model option, drive-by fix for --architecture.
212         * Scripts/webkitpy/port/mac.py:
213         (MacPort.configuration_for_upload): --model overrides detected model.
214
215 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
216
217         [webkitpy] Automatically detect hw architecture for supporting Apple Silicon
218         https://bugs.webkit.org/show_bug.cgi?id=213653
219         <rdar://problem/64817656>
220
221         Rubber-stamped by Aakash Jain.
222
223         * Scripts/webkitpy/common/config/ews.json: iOS has the correct defaults, no need to override them.
224         * Scripts/webkitpy/common/system/platforminfo.py:
225         (PlatformInfo):
226         (PlatformInfo.architecture): Retrieve the current system's architecture.
227         * Scripts/webkitpy/common/system/platforminfo_mock.py:
228         (MockPlatformInfo.__init__):
229         (MockPlatformInfo.architecture):
230         * Scripts/webkitpy/port/base.py:
231         (Port.__init__): Remove 'did_override_architecture', should be implied by architecture compared with DEFAULT_ARCHITECTURE.
232         (Port.architecture): Return the architecture specified by the user, if it exists.
233         (Port.set_architecture): Remove 'did_override_architecture'.
234         * Scripts/webkitpy/port/factory.py:
235         (configuration_options): Add --arm and --architecture flags.
236         * Scripts/webkitpy/port/mac.py:
237         (MacPort): Add arm64 to supported architectures.
238         (MacPort.architecture): Convert arm64e to arm64, check the host's architecture.
239         (MacPort._build_driver_flags): Always specify the build architecture since it may be x86_64 or arm64.
240         * Scripts/webkitpy/port/mac_unittest.py:
241         (MacTest.test_64bit):
242         (MacTest):
243         (MacTest.test_arm):
244         (MacTest.test_default):
245         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
246         (AbstractEarlyWarningSystem.run_command): Remove did_override_architecture.
247
248 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
249
250         [Big Sur] Handle baseline search path (Follow-up fix)
251         https://bugs.webkit.org/show_bug.cgi?id=213639
252         <rdar://problem/64789480>
253
254         Unreviewed follow-up fix.
255
256         * Scripts/webkitpy/port/mac.py:
257         (MacPort.default_baseline_search_path): Copy reference version by value, not by reference.
258
259 2020-06-26  Geoffrey Garen  <ggaren@apple.com>
260
261         Initializing the main thread should initialize the main run loop
262         https://bugs.webkit.org/show_bug.cgi?id=213637
263
264         Reviewed by Anders Carlsson.
265
266         Updated TestWebKitAPI to stop using RunLoop::initializeMain directly.
267
268         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
273         (TestWebKitAPI::TEST):
274         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
275         (ApplicationManifestParserTest::SetUp):
276         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
277         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
278         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
279         (TestWebKitAPI::ContentExtensionTest::SetUp):
280         * TestWebKitAPI/Tests/WebCore/DNS.cpp:
281         (TestWebKitAPI::TEST):
282         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
283         (TestWebKitAPI::TEST_F):
284         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
285         (initializeInAppBrowserPrivacyTestSettings):
286         * TestWebKitAPI/TestsController.cpp:
287         (TestWebKitAPI::TestsController::TestsController):
288         * WebKitTestRunner/TestController.cpp:
289         (TestController::initialize):
290
291 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
292
293         run-javascriptcore-tests: Support Apple Silicon running x86 processes
294         https://bugs.webkit.org/show_bug.cgi?id=213487
295         <rdar://problem/64606667>
296
297         Reviewed by Saam Barati.
298
299         * Scripts/run-javascriptcore-tests:
300         (configurationForUpload): Add --architecture flag.
301         (runTest): Run test suite with specific architecture.
302         (runJSCStressTests): Pass architecture to run-jsc-stress-tests.
303         * Scripts/run-jsc-stress-tests: Add --force-architecture flag.
304         * Scripts/webkitdirs.pm:
305         (determineNativeArchitecture): Add function to determine machine's native architecture.
306         (determineArchitecture): Leverage the nativeArchitecture instead of hard-coding simulator
307         architectures.
308         (architecturesForProducts): Determine the architectures supported by a given build.
309         (nativeArchitecture): Return nativeArchitecture.
310
311 2020-06-26  Sihui Liu  <sihui_liu@apple.com>
312
313         Text manipulation should observe adjacent elements with new renderer together
314         https://bugs.webkit.org/show_bug.cgi?id=213333
315
316         Reviewed by Geoffrey Garen.
317
318         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
319         (TestWebKitAPI::TEST):
320
321 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
322
323         [Big Sur] Handle baseline search path
324         https://bugs.webkit.org/show_bug.cgi?id=213639
325         <rdar://problem/64789480>
326
327         Rubber-stamped by Aakash Jain.
328
329         * Scripts/webkitpy/port/mac.py:
330         (MacPort):
331         (MacPort.default_baseline_search_path): Break infinite loop for major version bump.
332         * Scripts/webkitpy/port/mac_unittest.py:
333         (MacTest.test_big_sur_baseline_search_path): Test Big Sur baseline search path.
334
335 2020-06-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
336
337         generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
338         https://bugs.webkit.org/show_bug.cgi?id=213615
339
340         Reviewed by Žan Doberšek.
341
342         Raise an exception if the parameter passed as remote-config-file is not a file.
343
344         * Scripts/generate-jsc-bundle:
345         (main):
346
347 2020-06-26  Takashi Komori  <takashi.komori@sony.com>
348
349         Add myself to contributors.json
350
351         Unreviewed.
352
353         * Scripts/webkitpy/common/config/contributors.json:
354
355 2020-06-25  Ryan Haddad  <ryanhaddad@apple.com>
356
357         [Big Sur] Regression tests fail to run due to failed assert: self._os_version.major == 10
358         https://bugs.webkit.org/show_bug.cgi?id=213639
359
360         Reviewed by Jonathan Bedard.
361
362         * Scripts/webkitpy/port/mac.py:
363         (MacPort.__init__): Remove the assert since it is no longer valid.
364
365 2020-06-25  Commit Queue  <commit-queue@webkit.org>
366
367         Unreviewed, reverting r263537.
368         https://bugs.webkit.org/show_bug.cgi?id=213640
369
370         Broke watchOS and tvOS builds
371
372         Reverted changeset:
373
374         "iOS Safari incorrectly reports "AppleCoreMedia" as UA string"
375         https://bugs.webkit.org/show_bug.cgi?id=213245
376         https://trac.webkit.org/changeset/263537
377
378 2020-06-25  Alex Christensen  <achristensen@webkit.org>
379
380         REGRESSION(r256166, r260596) WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and Accept
381         https://bugs.webkit.org/show_bug.cgi?id=213626
382         <rdar://problem/62374208>
383
384         Reviewed by Darin Adler.
385
386         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
387         (TEST):
388
389 2020-06-25  Jer Noble  <jer.noble@apple.com>
390
391         iOS Safari incorrectly reports "AppleCoreMedia" as UA string
392         https://bugs.webkit.org/show_bug.cgi?id=213245
393         <rdar://problem/64471582>
394
395         Reviewed by Youenn Fablet.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398         * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
399         (TestWebKitAPI::parseUserAgent):
400         (TestWebKitAPI::TEST):
401
402 2020-06-25  Daniel Bates  <dabates@apple.com>
403
404         [iOS] -_requestTextInputContextsInRect cannot find empty Quip spreadsheet title
405         https://bugs.webkit.org/show_bug.cgi?id=213564
406         <rdar://problem/59355847>
407
408         Reviewed by Simon Fraser.
409
410         Add some tests.
411
412         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
413         (TestWebKitAPI::TEST):
414
415 2020-06-25  Sam Weinig  <weinig@apple.com>
416
417         Add a new templated string type to help write more idiomatic parsing code
418         https://bugs.webkit.org/show_bug.cgi?id=213588
419
420         Reviewed by Darin Adler.
421
422         * TestWebKitAPI/CMakeLists.txt:
423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
424         * TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp: Added.
425         (TestWebKitAPI::TEST):
426         Added new tests for new class.
427
428 2020-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
429
430         Text manipulation should exclude text rendered using icon-only fonts
431         https://bugs.webkit.org/show_bug.cgi?id=213446
432         <rdar://problem/63734298>
433
434         Reviewed by Myles Maxfield.
435
436         Add a new API test.
437
438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
439         * TestWebKitAPI/Tests/WebKitCocoa/Ahem.ttf: Added.
440         * TestWebKitAPI/Tests/WebKitCocoa/SpaceOnly.otf: Added.
441         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
442         (TestWebKitAPI::TEST):
443
444 2020-06-25  Aakash Jain  <aakash_jain@apple.com>
445
446         [ews] Share more bots between EWS builder and testers
447         https://bugs.webkit.org/show_bug.cgi?id=213521
448
449         Reviewed by Jonathan Bedard.
450
451         * BuildSlaveSupport/ews-build/config.json:
452
453 2020-06-25  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews] Improve handling of invalid changelog
456         https://bugs.webkit.org/show_bug.cgi?id=213609
457
458         Reviewed by Jonathan Bedard.
459
460         * Scripts/webkitpy/tool/steps/validatereviewer.py:
461         (ValidateReviewer.run):
462
463 2020-06-24  Alexey Proskuryakov  <ap@apple.com>
464
465         macOS Big Sur build fix.
466
467         Remove long obsolete checks for Mac OS X 10.6 that didn't respect the major version.
468
469         * MiniBrowser/Makefile:
470         * TestWebKitAPI/Makefile:
471         * WebKitTestRunner/Makefile:
472
473 2020-06-24  Alex Christensen  <achristensen@webkit.org>
474
475         REGRESSION(r262341) Use UTF-8 to decode CFURLRefs from IPC
476         https://bugs.webkit.org/show_bug.cgi?id=213565
477         <rdar://problem/64408924>
478
479         Reviewed by Darin Adler.
480
481         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
482         (TestWebKitAPI::TEST):
483
484 2020-06-24  Umar Iqbal  <uiqbal@apple.com>
485
486         We should resurrect the older patch that collects some statistics of web API calls
487         https://bugs.webkit.org/show_bug.cgi?id=213319
488
489         Reviewed by Brent Fulgham.
490         
491         + Enabled ENABLE_WEB_API_STATISTICS flag.
492         
493         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
494
495 2020-06-24  Andy Estes  <aestes@apple.com>
496
497         [iOS] Open element actions sometimes result in a hover instead of a click
498         https://bugs.webkit.org/show_bug.cgi?id=213530
499         <rdar://problem/64176707>
500
501         Reviewed by Darin Adler.
502
503         Added an API test.
504
505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
506         * TestWebKitAPI/Tests/ios/ElementActionTests.mm: Added.
507         * TestWebKitAPI/Tests/ios/link-with-hover-menu.html: Added.
508
509 2020-06-24  Caitlin Potter  <caitp@igalia.com>
510
511         [JSC] add microbenchmark for op_get_private_name
512         https://bugs.webkit.org/show_bug.cgi?id=213544
513
514         Reviewed by Yusuke Suzuki.
515
516         Add machinery to add --usePrivateClassFields flag in a family of
517         microbenchmarks.
518  
519         * Scripts/run-jsc-benchmarks:
520
521 2020-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
522
523         [GTK][WPE] Add API to allow applications to handle the HTTP authentication credential storage
524         https://bugs.webkit.org/show_bug.cgi?id=213177
525
526         Reviewed by Michael Catanzaro.
527
528         Update the authentication tests to check the new API.
529
530         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
531         (testWebViewAuthenticationCancel):
532         (testWebViewAuthenticationLoadCancelled):
533         (testWebViewAuthenticationFailure):
534         (testWebViewAuthenticationNoCredential):
535         (testWebViewAuthenticationEphemeral):
536         (testWebViewAuthenticationStorage):
537         (testWebViewAuthenticationSuccess):
538         (testWebViewAuthenticationEmptyRealm):
539         (serverCallback):
540         (beforeAll):
541
542 2020-06-23  Alex Christensen  <achristensen@webkit.org>
543
544         Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled
545         https://bugs.webkit.org/show_bug.cgi?id=213527
546
547         Reviewed by Geoffrey Garen.
548
549         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
550         (TEST):
551
552 2020-06-23  Jonathan Bedard  <jbedard@apple.com>
553
554         [Big Sur] Add 11.0 version to scripts
555         https://bugs.webkit.org/show_bug.cgi?id=213532
556         <rdar://problem/64663032>
557
558         Reviewed by Tim Horton.
559
560         * Scripts/run-javascriptcore-tests:
561         (configurationForUpload): Make version checks more explicit, add Big Sur.
562         * Scripts/webkitpy/common/version_name_map.py:
563         (VersionNameMap.__init__): Add Big Sur.
564         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
565         (TestExpectationParser): Ditto.
566
567 2020-06-23  Wenson Hsieh  <wenson_hsieh@apple.com>
568
569         REGRESSION (r244633): Mail flashes when copying text in an email
570         https://bugs.webkit.org/show_bug.cgi?id=213529
571         <rdar://problem/55025522>
572
573         Reviewed by Tim Horton.
574
575         Add an API test to verify that temporarily changing the height of the document before restoring it to the
576         original value does not cause intrinsic content size to be invalidated.
577
578         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
579         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
580         (-[AutoLayoutWKWebView setInvalidatedIntrinsicContentSizeBlock:]):
581         (-[AutoLayoutWKWebView invalidatedIntrinsicContentSizeBlock]):
582
583 2020-06-23  Diego Pino Garcia  <dpino@igalia.com>
584
585         [ews] Allow archiving 'jsc' product
586         https://bugs.webkit.org/show_bug.cgi?id=213518
587
588         Reviewed by Aakash Jain.
589
590         * BuildSlaveSupport/built-product-archive:
591         (archiveBuiltProduct):
592
593 2020-06-23  Alex Christensen  <achristensen@webkit.org>
594
595         Expose already-available WKNavigationAction.request.HTTPBody through the API
596         https://bugs.webkit.org/show_bug.cgi?id=179077
597
598         Reviewed by Brady Eidson.
599
600         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
601         (TEST):
602
603 2020-06-23  Alicia Boya García  <aboya@igalia.com>
604
605         [GStreamer] Add GStreamer patch to fix EWS glupload racy crash
606         https://bugs.webkit.org/show_bug.cgi?id=210498
607
608         Reviewed by Philippe Normand.
609
610         This WebKit patch backports a patch from GStreamer 1.17 that prevents
611         the crashes in the attached bug to our flatpak build.
612
613         * buildstream/elements/sdk/gst-plugins-base.bst:
614         * buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Added.
615
616 2020-06-23  Alicia Boya García  <aboya@igalia.com>
617
618         [flatpak] Ensure en_US.UTF-8 locale
619         https://bugs.webkit.org/show_bug.cgi?id=212459
620
621         Reviewed by Philippe Normand.
622
623         When developing WebKit we want as few system differences as possible
624         to make tests reproducible.
625
626         en_US.UTF-8 is indeed the only locale installed in our development
627         flatpak, but our scripts were not correctly clearing most locale
628         environment variables, which resulted in warnings when running some
629         tools (notably perl) when the user OS has a different locale.
630
631         This patch ensures all locale environment variables are cleared and
632         LANG is set to en_US.UTF-8. It also removes now redundant code from
633         flatpakutils.py.
634
635         * flatpak/flatpakutils.py:
636         (WebkitFlatpak.run_in_sandbox):
637         * flatpak/webkit-bwrap:
638
639 2020-06-23  Simon Fraser  <simon.fraser@apple.com>
640
641         [ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure
642         https://bugs.webkit.org/show_bug.cgi?id=213351
643         <rdar://problem/64502429>
644
645         Reviewed by Tim Horton.
646
647         The variadic CGEventCreateScrollWheelEvent() seems to have an issue that causes the resulting event
648         to rarely put the x value into the deltaY. Change to the non-variadic CGEventCreateScrollWheelEvent2()
649         to avoid this.
650
651         * DumpRenderTree/mac/EventSendingController.mm:
652         (-[EventSendingController mouseScrollByX:andY:continuously:]):
653         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
654         * WebKitTestRunner/mac/EventSenderProxy.mm:
655         (WTR::EventSenderProxy::mouseScrollBy):
656         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
657
658 2020-06-23  Diego Pino Garcia  <dpino@igalia.com>
659
660         [ews] Rename 'JSCTestsFactory' to 'JSCBuildAndTestsFactory'
661         https://bugs.webkit.org/show_bug.cgi?id=213503
662
663         Reviewed by Aakash Jain.
664
665         * BuildSlaveSupport/ews-build/config.json:
666         * BuildSlaveSupport/ews-build/factories.py:
667         (JSCBuildAndTestsFactory):
668         (JSCTestsFactory): Deleted.
669         (JSCTestsFactory.__init__): Deleted.
670         * BuildSlaveSupport/ews-build/loadConfig.py:
671
672 2020-06-23  Aakash Jain  <aakash_jain@apple.com>
673
674         [ews] Add JSC-Only builders for MIPS and ARMv7 architectures (follow-up fix)
675         https://bugs.webkit.org/show_bug.cgi?id=213366
676
677         Unreviewed follow-up fix.
678
679         Remove unused runTests parameter.
680         * BuildSlaveSupport/ews-build/factories.py:
681
682 2020-06-23  Philippe Normand  <pnormand@igalia.com>
683
684         [Flatpak SDK] relax restriction on build-webkit script name
685         https://bugs.webkit.org/show_bug.cgi?id=213432
686
687         Reviewed by Žan Doberšek.
688
689         * flatpak/flatpakutils.py:
690         (WebkitFlatpak.run_in_sandbox): Match the build-webkit string in the whole command-line
691         argument and thus allow alternative implementations of build-webkit. Also let the
692         MAX_CPU_LOAD env var in the sandbox.
693
694 2020-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
695
696         [GTK] MiniBrowser: set a base directory for website data and cache
697         https://bugs.webkit.org/show_bug.cgi?id=213368
698
699         Reviewed by Michael Catanzaro.
700
701         Stop using the default ones.
702
703         * MiniBrowser/gtk/main.c:
704         (activate):
705
706 2020-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
707
708         [GTK][WPE] Add API to configure and handle DOM cache to WebKitWebsiteDataManager
709         https://bugs.webkit.org/show_bug.cgi?id=213337
710
711         Reviewed by Adrian Perez de Castro.
712
713         Handle new website data in MiniBrowser and add a unit test.
714
715         * MiniBrowser/gtk/main.c:
716         (gotWebsiteDataCallback):
717         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
718         (testWebsiteDataConfiguration):
719         (testWebsiteDataDOMCache):
720         (beforeAll):
721         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
722         (Test::Test):
723
724 2020-06-22  Diego Pino Garcia  <dpino@igalia.com>
725
726         [ews] Add JSC-Only builders for MIPS and ARMv7 architectures
727         https://bugs.webkit.org/show_bug.cgi?id=213366
728
729         Reviewed by Aakash Jain.
730
731         In a follow-up patch the built product of these bots will be consumed
732         by the EWS JSC-Only testing bots.
733
734         * BuildSlaveSupport/ews-build/config.json:
735         * BuildSlaveSupport/ews-build/factories.py:
736         (JSCBuildFactory):
737         (JSCBuildFactory.__init__):
738         * BuildSlaveSupport/ews-build/factories_unittest.py:
739         (TestBuildFactory):
740         (TestBuildFactory.test_jsc_mipsel_factory):
741         (TestBuildFactory.test_jsc_armv7_factory):
742         * BuildSlaveSupport/ews-build/loadConfig.py:
743
744 2020-06-22  Fujii Hironori  <Hironori.Fujii@sony.com>
745
746         [Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing
747         https://bugs.webkit.org/show_bug.cgi?id=213452
748
749         Reviewed by Yusuke Suzuki.
750
751         If window.alert() was given an invalid UTF-16 sequence, Windows
752         DumpRenderTree output it without any conversions. It should output
753         "(null)" to match with WebKitTestRunner behavior.
754
755         * DumpRenderTree/win/UIDelegate.cpp:
756         (toMessage): Added
757         (UIDelegate::runJavaScriptAlertPanelWithMessage):
758         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
759         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
760         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
761         (UIDelegate::setStatusText):
762
763 2020-06-22  Jer Noble  <jer.noble@apple.com>
764
765         [ macOS iOS ] (r263321): TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.SleepDisabler.Reload are constant failures
766         https://bugs.webkit.org/show_bug.cgi?id=213475
767         <rdar://problem/64603555>
768
769         Reviewed by Eric Carlson.
770
771         Looks like the SleepDisabler can come and go while the TestWebKitAPI process is spinning, so make the
772         Reload and Load tests more deterministic by only checking SleepDisabler after getting a "playing" message
773         from the WebContent process.
774
775         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
776         (SleepDisabler::runAndWaitUntilPlaying):
777         (SleepDisabler::loadPlayingPage):
778         (TEST_F):
779
780 2020-06-22  Jonathan Bedard  <jbedard@apple.com>
781
782         resultsdbpy: Make architecture differences explicit
783         https://bugs.webkit.org/show_bug.cgi?id=213473
784         <rdar://problem/64602736>
785
786         Rubber-stamped by Aakash Jain.
787
788         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
789         (Configuration.prototype.toString):
790
791 2020-06-22  Tim Horton  <timothy_horton@apple.com>
792
793         Update macOS version macros
794         https://bugs.webkit.org/show_bug.cgi?id=213484
795
796         Reviewed by Alexey Proskuryakov.
797
798         * ContentExtensionTester/Configurations/Base.xcconfig:
799         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
800         * DumpRenderTree/mac/Configurations/Base.xcconfig:
801         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
802         * ImageDiff/cg/Configurations/Base.xcconfig:
803         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
804         * MiniBrowser/Configurations/Base.xcconfig:
805         * MiniBrowser/Configurations/DebugRelease.xcconfig:
806         * TestWebKitAPI/Configurations/Base.xcconfig:
807         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
808         * WebEditingTester/Configurations/Base.xcconfig:
809         * WebEditingTester/Configurations/DebugRelease.xcconfig:
810         * WebKitTestRunner/Configurations/Base.xcconfig:
811         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
812         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
813         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
814
815 2020-06-22  Tim Horton  <timothy_horton@apple.com>
816
817         API Test WeakLinking.WeakImport fails on arm64
818         https://bugs.webkit.org/show_bug.cgi?id=213477
819
820         Reviewed by Alexey Proskuryakov.
821
822         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
823         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:
824         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd:
825         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd:
826         Add this architecture to the TBD files.
827
828 2020-06-22  Jonathan Bedard  <jbedard@apple.com>
829
830         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x3)
831         https://bugs.webkit.org/show_bug.cgi?id=213402
832         <rdar://problem/64542588>
833
834         Reviewed by Alexey Proskuryakov.
835
836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
837         (WebKitBuildbot): 64 bit is more correct for watchOS embedded builds.
838
839 2020-06-22  Aakash Jain  <aakash_jain@apple.com>
840
841         [ews] Switch contributors.json url from trac to svn server
842         https://bugs.webkit.org/show_bug.cgi?id=213457
843
844         Reviewed by Jonathan Bedard.
845
846         * BuildSlaveSupport/ews-build/steps.py:
847         (ValidateCommiterAndReviewer):
848         (ValidateCommiterAndReviewer.load_contributors_from_trac):
849
850 2020-06-22  Philippe Normand  <pnormand@igalia.com>
851
852         [Flatpak SDK] Persist sccache auth token across flatpak updates
853         https://bugs.webkit.org/show_bug.cgi?id=213427
854
855         Reviewed by Žan Doberšek.
856
857         After a successful flatpak update check if an sccache auth token exists and reuse it when
858         updating the sccache config file.
859
860         * flatpak/flatpakutils.py:
861         (WebkitFlatpak.save_config):
862
863 2020-06-21  Yusuke Suzuki  <ysuzuki@apple.com>
864
865         [WTF] URL should support dataLog
866         https://bugs.webkit.org/show_bug.cgi?id=213450
867
868         Reviewed by Mark Lam.
869
870         Add test for URL::dump.
871
872         * TestWebKitAPI/Tests/WTF/URL.cpp:
873         (TestWebKitAPI::TEST_F):
874
875 2020-06-21  Philippe Normand  <pnormand@igalia.com>
876
877         [Flatpak] Nightly runner fails to extract zip files
878         https://bugs.webkit.org/show_bug.cgi?id=213445
879
880         Reviewed by Darin Adler.
881
882         * Scripts/webkit-flatpak-run-nightly: Ensure the buffered zip data is written to disk before
883         extraction.
884
885 2020-06-21  Jer Noble  <jer.noble@apple.com>
886
887         WebKit fails to leave audio routing arbitration during navigation, closing.
888         https://bugs.webkit.org/show_bug.cgi?id=213426
889         <rdar://problem/64395051>
890
891         Reviewed by Eric Carlson.
892
893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
894         * TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: Added.
895         (AudioRoutingArbitration::statusShouldBecomeEqualTo):
896         (TEST_F):
897
898 2020-06-20  Jer Noble  <jer.noble@apple.com>
899
900         REGRESSION(r259219): Sleep assertion remains active if WKWebView is closed or WebContent process crashes
901         https://bugs.webkit.org/show_bug.cgi?id=213434
902         <rdar://problem/57541662>
903
904         Reviewed by Eric Carlson.
905
906         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
907         (SleepDisabler::loadPlayingPage):
908         (SleepDisabler::hasSleepDisablerShouldBecomeEqualTo):
909         (TEST_F):
910
911 2020-06-20  Jonathan Bedard  <jbedard@apple.com>
912
913         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x2)
914         https://bugs.webkit.org/show_bug.cgi?id=213402
915         <rdar://problem/64542588>
916
917         Unreviewed test fix.
918
919         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Native Macs never
920         use 32 bit tool binaries.
921
922 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
923
924         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix)
925         https://bugs.webkit.org/show_bug.cgi?id=213402
926         <rdar://problem/64542588>
927
928         Unreviewed build-fix.
929
930         * BuildSlaveSupport/build.webkit.org-config/config.json: Use arm64_32 to build watchOS device.
931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
932         (WebKitBuildbot): watchOS device should be considered 32 bit.
933         * Scripts/configure-xcode-for-embedded-development: Force-copy MediaAccessibility.framework.
934         * Scripts/webkitdirs.pm:
935         (extractNonMacOSHostConfiguration): Native Macs never use 32 bit tool binaries.
936
937 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
938
939         Delete dead code for old ews api tests
940         https://bugs.webkit.org/show_bug.cgi?id=213421
941
942         Rubber-stamped by Alexey Proskuryakov.
943
944         * Scripts/webkitpy/common/config/ports.py:
945         (DeprecatedPort.run_api_tests_command): Deleted.
946         * Scripts/webkitpy/common/net/apitestresults.py: Removed.
947         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Removed.
948         * Scripts/webkitpy/port/base.py:
949         (Port.bindings_results_directory):
950         (Port.api_results_directory): Deleted.
951         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Removed.
952         * Scripts/webkitpy/tool/steps/runtests.py:
953         (RunTests._run_api_tests): Deleted.
954         * Scripts/webkitpy/tool/steps/steps_unittest.py:
955         (test_runtests_api_debug): Deleted.
956
957 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
958
959         Bring up watchOS/tvOS on build.webkit.org
960         https://bugs.webkit.org/show_bug.cgi?id=213402
961         <rdar://problem/64542588>
962
963         Unreviewed infrastructure fix.
964
965         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
966         (_should_file_trigger_build): Add tvOS and watchOS.
967         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
968         (ShouldBuildTest):
969         (ShouldBuildTest.test_should_build):
970
971 2020-06-19  Jiewen Tan  <jiewen_tan@apple.com>
972
973         [WebAuthn] Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients if the returned PIN from the client is not valid
974         https://bugs.webkit.org/show_bug.cgi?id=213404
975         <rdar://problem/64543894>
976
977         Reviewed by Brent Fulgham.
978
979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
980         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
981         (TestWebKitAPI::TEST):
982         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-fake-pin-invalid-error-retry.html: Added.
983
984 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
985
986         Bring up watchOS/tvOS on build.webkit.org
987         https://bugs.webkit.org/show_bug.cgi?id=213402
988         <rdar://problem/64542588>
989
990         Reviewed by Aakash Jain.
991
992         * BuildSlaveSupport/build.webkit.org-config/config.json: Add AppleTV and watchOS builders.
993         * BuildSlaveSupport/build.webkit.org-config/factories.py:
994         (BuildFactory.__init__): Support AppleTV and watchOS.
995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13.png: Added.
996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13@2x.png: Added.
997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator.png: Added.
998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator@2x.png: Added.
999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6.png: Added.
1000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6@2x.png: Added.
1001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6.png: Added.
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6@2x.png: Added.
1003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1006         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1007         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1008
1009 2020-06-19  Saam Barati  <sbarati@apple.com>
1010
1011         Have a memory monitor thread in jsc shell when running tests using --memory-limited
1012         https://bugs.webkit.org/show_bug.cgi?id=213389
1013
1014         Reviewed by Mark Lam.
1015
1016         * Scripts/run-jsc-stress-tests:
1017         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
1018         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
1019
1020 2020-06-19  Chris Fleizach  <cfleizach@apple.com>
1021
1022         AX: Make isolated tree enablement status dependent on client preference
1023         https://bugs.webkit.org/show_bug.cgi?id=213355
1024         <rdar://problem/64506577>
1025
1026         Reviewed by Zalan Bujtas.
1027
1028         * MiniBrowser/mac/AppDelegate.m:
1029         (-[BrowserAppDelegate defaultConfiguration]):
1030
1031 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
1032
1033         Improve handling of trac downtime by commit-queue
1034         https://bugs.webkit.org/show_bug.cgi?id=213377
1035
1036         Reviewed by Jonathan Bedard.
1037
1038         * BuildSlaveSupport/ews-build/steps.py: Load contributors.json from disk when loading from trac fails.
1039         (ValidateCommiterAndReviewer.load_contributors_from_disk):
1040         (ValidateCommiterAndReviewer.load_contributors_from_trac):
1041         (ValidateCommiterAndReviewer.load_contributors):
1042         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test
1043
1044 2020-06-19  Lauro Moura  <lmoura@igalia.com>
1045
1046         [WPE] Warn potential issues when creating WindowViewBackend
1047         https://bugs.webkit.org/show_bug.cgi?id=213326
1048
1049         Reviewed by Philippe Normand.
1050
1051         Make it easier to debug eventual GL issues when starting up MiniBrowser in
1052         windowed mode.
1053
1054         * wpe/backends/WindowViewBackend.cpp:
1055         (WPEToolingBackends::WaylandEGLConnection::singleton):
1056         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1057
1058 2020-06-19  Lauro Moura  <lmoura@igalia.com>
1059
1060         [webkitpy][WPE] Default to headless if _display_server is xfvb
1061         https://bugs.webkit.org/show_bug.cgi?id=213327
1062
1063         Reviewed by Philippe Normand.
1064
1065         Xvfb is used as the default display server for some scripts, and the
1066         equivalent for WPE is the headless one.
1067
1068         WTR and the API tests already create only HeadlessViewBackends, but the
1069         WebDriver tests create them through MiniBrowser, which requires the
1070         '--headless' parameter.
1071
1072         * Scripts/run-webdriver-tests: Do not override _display_server
1073         * Scripts/webkitpy/port/base.py:
1074         (Port.__init__): Define _display_server for all ports to avoid
1075         eventually needing to override it.
1076         * Scripts/webkitpy/port/wpe.py:
1077         (WPEPort.__init__): Default to 'headless' if _display_server is 'xvfb'
1078         * Scripts/webkitpy/w3c/wpt_runner.py:
1079         (main): Dot not override _display_server
1080
1081 2020-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1082
1083         Add support for fetching registrable domains with resource load statistics
1084         https://bugs.webkit.org/show_bug.cgi?id=213291
1085
1086         Reviewed by Adrian Perez de Castro.
1087
1088         Update GLib ITP unit test to check also fetch and remove.
1089
1090         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1091         (testWebsiteDataITP):
1092
1093 2020-06-19  Tomoki Imai  <Tomoki.Imai@sony.com>
1094
1095         Change my (Tomoki Imai's) status to committer
1096
1097         Unreviewed, just updating contributors.json for myself.
1098
1099         * Scripts/webkitpy/common/config/contributors.json:
1100
1101 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
1102
1103         Add SPI to preconnect to a server (Follow-up fix)
1104         https://bugs.webkit.org/show_bug.cgi?id=213109
1105         <rdar://problem/64184412>
1106
1107         Unreviewed build-fix.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm: HTTPServer does not exist if HAVE(NETWORK_FRAMEWORK) is false.
1110
1111 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
1112
1113         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions (build-fix)
1114         https://bugs.webkit.org/show_bug.cgi?id=213183
1115         <rdar://problem/64273483>
1116
1117         Unreviewed build fix.
1118
1119         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1120         (webViewWithAutofocusedInput): bool may not be the same type as BOOL.
1121
1122 2020-06-18  Saam Barati  <sbarati@apple.com>
1123
1124         call skip when skipping JetStream2 wasm test
1125         https://bugs.webkit.org/show_bug.cgi?id=213354
1126
1127         Reviewed by Yusuke Suzuki.
1128
1129         So we can see the logging that we're skipping.
1130
1131         * Scripts/run-jsc-stress-tests:
1132
1133 2020-06-18  Joonghun Park  <jh718.park@samsung.com>
1134
1135     Unreviewed. Remove the build warning below since r262971.
1136     warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
1137
1138         * WebKitTestRunner/TestController.cpp:
1139         (WTR::getAllStorageAccessEntriesCallback):
1140
1141 2020-06-18  Ross Kirsling  <ross.kirsling@sony.com>
1142
1143         [Intl] Enable RelativeTimeFormat and Locale by default
1144         https://bugs.webkit.org/show_bug.cgi?id=213324
1145
1146         Reviewed by Yusuke Suzuki.
1147
1148         * Scripts/run-jsc-stress-tests:
1149         Remove feature flags.
1150
1151 2020-06-18  Andy Estes  <aestes@apple.com>
1152
1153         Unreviewed build fix after r263194
1154
1155         * WebKitTestRunner/ios/TestControllerIOS.mm:
1156         (WTR::TestController::platformResetStateToConsistentValues): Guarded code that mentions
1157         UIContextMenuInteraction with USE(UICONTEXTMENU).
1158
1159 2020-06-18  Ryan Haddad  <ryanhaddad@apple.com>
1160
1161         Unreviewed infrastructure fix, temporarily remove ews116 due to hardware failure tracked with rdar://64424245
1162
1163         * BuildSlaveSupport/ews-build/config.json:
1164
1165 2020-06-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1166
1167         [GTK][WPE] Add API to configure and handle service worker registrations to WebKitWebsiteDataManager
1168         https://bugs.webkit.org/show_bug.cgi?id=213290
1169
1170         Reviewed by Michael Catanzaro.
1171
1172         Handle new website data in MiniBrowser and add a unit test.
1173
1174         * MiniBrowser/gtk/main.c:
1175         (gotWebsiteDataCallback):
1176         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1177         (serverCallback):
1178         (testWebsiteDataConfiguration):
1179         (testWebsiteDataEphemeral):
1180         (testWebsiteDataITP):
1181         (testWebsiteDataServiceWorkerRegistrations):
1182         (beforeAll):
1183         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1184         (Test::Test):
1185
1186 2020-06-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1187
1188         RebaselineServer: "Rebaseline queue" button is placed behind the footer
1189         https://bugs.webkit.org/show_bug.cgi?id=213258
1190
1191         Reviewed by Zalan Bujtas.
1192
1193         * Scripts/webkitpy/tool/servers/data/rebaselineserver/index.html: Moved 'log' and 'queue' elements after 'footer' element.
1194         * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
1195         (#queue): Changed 'bottom' property from 3em to 4em.
1196
1197 2020-06-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1198
1199         [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
1200         https://bugs.webkit.org/show_bug.cgi?id=213320
1201         <rdar://problem/63831962>
1202
1203         Reviewed by Tim Horton.
1204
1205         Add a new API test to verify that preventing the "keypress" event for shift+tab in an SPI-editable web view
1206         causes us to avoid relinquishing focus.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1209
1210 2020-06-17  Andy Estes  <aestes@apple.com>
1211
1212         REGRESSION (r258092): fast/forms/ios/file-upload-panel.html fails when HAVE(UICONTEXTMENU_LOCATION)
1213         https://bugs.webkit.org/show_bug.cgi?id=213314
1214         <rdar://problem/60339129>
1215
1216         Reviewed by Maciej Stachowiak.
1217
1218         fast/forms/ios/file-upload-panel.html sets the shouldHandleRunOpenPanel and
1219         shouldPresentPopovers test options to false so that WKTR will (a) not register a
1220         runOpenPanel UI delegate callback, causing WebKit to create a WKFileUploadPanel instead, and
1221         (b) swizzle two UIKit view controller presentation methods to prevent the document picker
1222         menu from being presented. The test merely wants the WKFileUploadPanel instance to exist in
1223         order to query its available actions, not for it to show UI.
1224
1225         In r258092, WKFileUploadPanel now sometimes uses a UIContextMenuInteraction instance to
1226         present the document picker menu, but -[UIContextMenuInteraction _presentMenuAtLocation:]
1227         fails due to WKTR's above-mentioned swizzling. When this failure occurs,
1228         UIContextMenuInteraction calls -contextMenuInteraction:willEndForConfiguration:animator: on
1229         its delegate (the WKFileUploadPanel), which dismisses the open panel before the test has had
1230         a chance to query the available actions.
1231
1232         Fixed this by swizzling -[UIContextMenuInteraction _presentMenuAtLocation:] when the
1233         shouldPresentPopovers test option is false.
1234
1235         * WebKitTestRunner/ios/TestControllerIOS.mm:
1236         (overridePresentMenuOrPopoverOrViewController): Renamed from
1237         overridePresentViewControllerOrPopover.
1238         (WTR::TestController::platformResetStateToConsistentValues): Swizzled
1239         -[UIContextMenuInteraction _presentMenuAtLocation:] with
1240         overridePresentMenuOrPopoverOrViewController when the shouldPresentPopovers test option is
1241         false.
1242         (overridePresentViewControllerOrPopover): Renamed to
1243         overridePresentMenuOrPopoverOrViewController.
1244
1245 2020-06-17  Sihui Liu  <sihui_liu@apple.com>
1246
1247         REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
1248         https://bugs.webkit.org/show_bug.cgi?id=213311
1249         <rdar://problem/64456413>
1250
1251         Reviewed by Wenson Hsieh.
1252
1253         TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long 
1254         enough to make sure TextManipulationController gets notified about the insertion and starts observing.
1255
1256         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1257         (TestWebKitAPI::TEST):
1258
1259 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1260
1261         Delete code for old ews bindings queue
1262         https://bugs.webkit.org/show_bug.cgi?id=213315
1263
1264         Rubber-stamped by Alexey Proskuryakov.
1265
1266         * Scripts/webkitpy/common/config/ews.json:
1267         * Scripts/webkitpy/common/config/ports.py:
1268         (DeprecatedPort.run_bindings_tests_command): Deleted.
1269         (WinPort.run_bindings_tests_command): Deleted.
1270         * Scripts/webkitpy/common/config/ports_mock.py:
1271         (MockPort.run_bindings_tests_command): Deleted.
1272         * Scripts/webkitpy/common/net/generictestresults.py: Removed.
1273         * Scripts/webkitpy/common/net/generictestresults_unittest.py: Removed.
1274         * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Removed.
1275         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1276         (PatchAnalysisTask._retry_bindings_tests): Deleted.
1277         * Scripts/webkitpy/tool/bot/retrylogic_unittest.py:
1278         (MockBindingsEarlyWarningSystem): Deleted.
1279         (MockBindingsEarlyWarningSystem.__init__): Deleted.
1280         (MockBindingsEarlyWarningSystem.test_results): Deleted.
1281         (BindingsEarlyWarningSystemTest): Deleted.
1282         (BindingsEarlyWarningSystemTest._results_indicate_all_passed): Deleted.
1283         (BindingsEarlyWarningSystemTest._create_task): Deleted.
1284         (BindingsEarlyWarningSystemTest.test_success_case): Deleted.
1285         (BindingsEarlyWarningSystemTest.test_test_failure): Deleted.
1286         (BindingsEarlyWarningSystemTest.test_fix): Deleted.
1287         (BindingsEarlyWarningSystemTest.test_ineffective_patch): Deleted.
1288         (BindingsEarlyWarningSystemTest.test_partially_effective_patch): Deleted.
1289         (BindingsEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Deleted.
1290         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1291         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1292         (TestBindingsEWS): Deleted.
1293         (AbstractEarlyWarningSystemTest.test_failing_bindings_tests_message): Deleted.
1294         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1295         * Scripts/webkitpy/tool/steps/runtests.py:
1296         (RunTests._run_bindings_tests): Deleted.
1297         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1298         (test_patch_relevant_bindings): Deleted.
1299         (test_runtests_api): Deleted.
1300
1301 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1302
1303         Delete code for old ews style queue
1304         https://bugs.webkit.org/show_bug.cgi?id=213297
1305
1306         Rubber-stamped by Alexey Proskuryakov.
1307
1308         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Removed.
1309         * Scripts/webkitpy/tool/commands/queues.py:
1310         (StyleQueue): Deleted.
1311         (StyleQueue.__init__): Deleted.
1312         (StyleQueue.review_patch): Deleted.
1313         (StyleQueue.run_command): Deleted.
1314         (StyleQueue.expected_failures): Deleted.
1315         (StyleQueue.refetch_patch): Deleted.
1316         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1317         (TestReviewQueue): Deleted.
1318
1319 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1320
1321         Delete code for old ews webkitpy queue
1322         https://bugs.webkit.org/show_bug.cgi?id=213299
1323
1324         Reviewed by Jonathan Bedard.
1325
1326         * Scripts/webkitpy/common/config/ews.json:
1327         * Scripts/webkitpy/common/net/generictestresults.py:
1328         (WebkitpyTestResults): Deleted.
1329         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1330         * Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Removed.
1331         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1332         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1333         (TestWebkitpyEWS): Deleted.
1334         (AbstractEarlyWarningSystemTest.test_failing_webkitpy_tests_message): Deleted.
1335         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1336         * Scripts/webkitpy/tool/steps/runtests.py:
1337         (RunTests._run_webkitpy_tests): Deleted.
1338         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1339         (test_runtests_webkitpy): Deleted.
1340         (test_patch_not_relevant_bindings): Deleted.
1341         (test_runtests_api_debug): Deleted.
1342
1343 2020-06-17  Keith Miller  <keith_miller@apple.com>
1344
1345         WebKitTestRunner should not crash on alert with invalid utf16 strings
1346         https://bugs.webkit.org/show_bug.cgi?id=213269
1347
1348         Reviewed by Simon Fraser.
1349
1350         * WebKitTestRunner/StringFunctions.h:
1351         (WTR::toWTFString):
1352
1353 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1354
1355         Delete old ews client side code - part 2
1356         https://bugs.webkit.org/show_bug.cgi?id=213262
1357
1358         Reviewed by Alexey Proskuryakov.
1359
1360         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1361         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1362         (PatchAnalysisTaskDelegate.command_passed): Deleted.
1363         (PatchAnalysisTaskDelegate.command_failed): Deleted.
1364         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1365         (AbstractEarlyWarningSystem.command_passed): Deleted.
1366         (AbstractEarlyWarningSystem.command_failed): Deleted.
1367         * Scripts/webkitpy/tool/commands/perfalizer.py:
1368         (PerfalizerTask.command_passed): Deleted.
1369         (PerfalizerTask.command_failed): Deleted.
1370         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1371         * Scripts/webkitpy/tool/commands/queues.py:
1372         (AbstractPatchQueue._next_patch): Deleted.
1373         (AbstractPatchQueue._did_error): Deleted.
1374         (AbstractPatchQueue._did_skip): Deleted.
1375         (AbstractPatchQueue._unlock_patch): Deleted.
1376         (StyleQueue.command_passed): Deleted.
1377         (StyleQueue.command_failed): Deleted.
1378
1379 2020-06-17  Paulo Matos  <pmatos@igalia.com>
1380
1381         Add new Igalia EWS workers for ARM/MIPS
1382         https://bugs.webkit.org/show_bug.cgi?id=212803
1383
1384         Reviewed by Aakash Jain.
1385
1386         * BuildSlaveSupport/ews-build/config.json:
1387
1388 2020-06-16  Mark Lam  <mark.lam@apple.com>
1389
1390         TestWebKitAPI.WebCore.WildcardStringMatching needs to initialize Options before accessing them.
1391         https://bugs.webkit.org/show_bug.cgi?id=213270
1392         <rdar://problem/64427499>
1393
1394         Reviewed by Yusuke Suzuki.
1395
1396         * TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
1397         (TestWebKitAPI::TEST):
1398
1399 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1400
1401         Text manipulation should not re-extract elements whose children have been manipulated
1402         https://bugs.webkit.org/show_bug.cgi?id=213276
1403         <rdar://problem/64193446>
1404
1405         Reviewed by Tim Horton.
1406
1407         Add a new API test where we start and complete text manipulation, and then hide and show the manipulated
1408         element. This test verifies that the new item callbacks are *not* called after element is shown again.
1409
1410         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1411         (TestWebKitAPI::TEST):
1412
1413 2020-06-16  Saam Barati  <sbarati@apple.com>
1414
1415         Fix two typos "signifcant" and "signficance". Should be "significant" and "significance"
1416
1417         * Scripts/compare-results:
1418         (displayStr):
1419         (computeMultipleHypothesesSignificance):
1420         (dumpBreakdowns):
1421         (writeCSV):
1422         (computeMultipleHypothesesSignficance): Deleted.
1423
1424 2020-06-16  Andres Gonzalez  <andresg_22@apple.com>
1425
1426         Fix for accessibility/textarea-selected-text-range.html in isolated tree mode.
1427         https://bugs.webkit.org/show_bug.cgi?id=213257
1428
1429         Reviewed by Chris Fleizach.
1430
1431         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1432         (WTR::setAttributeValue):
1433         (WTR::AccessibilityUIElement::selectedTextRange): Dispatch call into
1434         WebAccessibilityWrapper onto AX secondary thread to simulate isolated
1435         tree mode.
1436
1437 2020-06-16  Saam Barati  <sbarati@apple.com>
1438
1439         Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni
1440         https://bugs.webkit.org/show_bug.cgi?id=213219
1441
1442         Reviewed by Mark Lam.
1443
1444         My previous patch here used Bonferroni to do multiple hypotheses correction.
1445         Bonferroni does a good job at reducing false positive rate (type I error,
1446         saying something is significant when it's not, e.g, rejecting the null
1447         hypothesis when we shouldn't), but at the expense of also having a high
1448         false negative rate (type II error, saying something is not significant when
1449         it is, e.g, not rejecting the null hypothesis when we should).
1450         
1451         After doing a bit more reading, it seems like using a technique called False
1452         Discovery Rate (FDR) is better. It still does a good job at controlling type
1453         I error rate, but without sacrificing a high type II error rate. FDR is based
1454         on a technique for "estimating the proportion of wrongly rejected null hypotheses" [2].
1455         
1456         This patch uses Benjamini and Hochberg estimation of FDR, which relies
1457         on hypotheses being independent. We know subtests in a benchmark aren't
1458         fully independent variables, but it's a good enough approximation.
1459         
1460         You can read more about FDR:
1461         1. https://www.stat.berkeley.edu/~mgoldman/Section0402.pdf
1462         2. https://besjournals.onlinelibrary.wiley.com/doi/10.1111/j.2041-210X.2010.00061.x
1463         3. https://en.wikipedia.org/wiki/False_discovery_rate
1464
1465         * Scripts/compare-results:
1466         (displayStr):
1467         (computeMultipleHypothesesSignficance):
1468         (dumpBreakdowns):
1469         (writeCSV):
1470
1471 2020-06-16  David Kilzer  <ddkilzer@apple.com>
1472
1473         REGRESSION (r262994): Web Inspector is killed when context-clicking anywhere
1474         <https://webkit.org/b/213224>
1475         <rdar://problem/64383320>
1476
1477         Reviewed by Darin Adler.
1478
1479         * TestWebKitAPI/CMakeLists.txt:
1480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1481         - Add ContextMenuAction.cpp to build systems.
1482         * TestWebKitAPI/Tests/WebCore/ContextMenuAction.cpp: Add.
1483         (TestWebKitAPI::TEST):
1484         - Add TestWebKitAPI.WebCore.ContextMenuAction_IsValidEnum.
1485
1486 2020-06-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1487
1488         [Win] Mouse dragging tests are failing because WebKitTestRunner dispatches WM_MOUSELEAVE to the hidden WebView
1489         https://bugs.webkit.org/show_bug.cgi?id=213239
1490
1491         Reviewed by Don Olmstead.
1492
1493         There are two problems:
1494         1. Windows EventSenderProxy::mouseMoveTo doesn't set WPARAM of WM_MOUSEMOVE
1495         2. Unexpected WM_MOUSELEAVE discontinues the mouse dragging events
1496
1497         WPARAM of WM_MOUSEMOVE should represent pressed mouse buttons while dragging.
1498
1499         WM_MOUSELEAVE is unexpectedly dispatched because the mouse cursor
1500         is always out of the hidden WebView. The unexpected WM_MOUSELEAVE
1501         discontinues dragging events. WM_MOUSELEAVE shouldn't be
1502         dispatched in WebKitTestRunner. Ignore it.
1503
1504         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1505         (WTR::EventSenderProxy::mouseDown):
1506         (WTR::EventSenderProxy::mouseUp):
1507         (WTR::EventSenderProxy::mouseMoveTo): Set MK_LBUTTON to WPARAM of
1508         WM_MOUSEMOVE while dragging.
1509         * WebKitTestRunner/win/TestControllerWin.cpp:
1510         (WTR::runRunLoopUntil): Ignore WM_MOUSELEAVE.
1511
1512 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1513
1514         Text manipulation should handle nested item boundary elements
1515         https://bugs.webkit.org/show_bug.cgi?id=213251
1516         <rdar://problem/63371514>
1517
1518         Reviewed by Sihui Liu.
1519
1520         Add a new API test to exercise this scenario.
1521
1522         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1523
1524 2020-06-16  Charlie Turner  <cturner@igalia.com>
1525
1526         [GTK] Disable video autoplay
1527         https://bugs.webkit.org/show_bug.cgi?id=184845
1528
1529         Reviewed by Carlos Garcia Campos.
1530
1531         Update the various callsites for constructing a view to take into
1532         account the default policies. I chose the default as autoplay
1533         allow without sound, which is in keeping with WebCore's choice.
1534
1535         * MiniBrowser/gtk/BrowserWindow.c:
1536         (webViewDecidePolicy):
1537         (newTabCallback):
1538         (openPrivateWindow):
1539         (browser_window_get_or_create_web_view_for_automation):
1540         (browser_window_create_web_view_in_new_tab_for_automation):
1541         * MiniBrowser/gtk/main.c:
1542         (createBrowserTab):
1543         (main):
1544         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Add
1545         autoplay policy tests, and use modern class initializers.
1546         (testAutoplayPolicy):
1547         (beforeAll):
1548
1549 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1550
1551         [Flatpak SDK] Subversion perl bindings unusable
1552         https://bugs.webkit.org/show_bug.cgi?id=213241
1553
1554         Reviewed by Sergio Villar Senin.
1555
1556         * buildstream/elements/sdk/subversion.bst: The svn swig perl library wasn't correctly
1557         installed, leading to undefined symbols when importing it from the bindings. A new
1558         integration command now tests this.
1559
1560 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1561
1562         [Flatpak SDK] Update to Qt 5.15
1563         https://bugs.webkit.org/show_bug.cgi?id=213192
1564
1565         Reviewed by Sergio Villar Senin.
1566
1567         The new patch comes from the upstream KDE SDK: https://github.com/KDE/flatpak-kde-runtime/tree/qt5.15lts/patch
1568         
1569         * buildstream/elements/qt5/qtbase.bst:
1570         * buildstream/elements/qt5/qtdeclarative.bst:
1571         * buildstream/elements/qt5/qtquickcontrols.bst:
1572         * buildstream/elements/qt5/qtquickcontrols2.bst:
1573         * buildstream/elements/qt5/qtwayland.bst:
1574         * buildstream/elements/qt5/qtx11extras.bst:
1575         * buildstream/patches/qtbase-make-sure-to-correctly-construct-base-platform-theme.patch: Added.
1576         * buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Removed.
1577         * buildstream/project.conf:
1578
1579 2020-06-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1580
1581         [GTK][WPE] Add API to configure and enable resource load statistics
1582         https://bugs.webkit.org/show_bug.cgi?id=177943
1583
1584         Reviewed by Michael Catanzaro.
1585
1586         Add --enable-itp command line version to MiniBrowser and unit tests to check the new API.
1587
1588         * MiniBrowser/gtk/main.c:
1589         (gotWebsiteDataCallback):
1590         (activate):
1591         * MiniBrowser/wpe/main.cpp:
1592         (main):
1593         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1594         (serverCallback):
1595         (testWebsiteDataConfiguration):
1596         (testWebsiteDataEphemeral):
1597         (testWebsiteDataITP):
1598         (beforeAll):
1599         * TestWebKitAPI/glib/TestExpectations.json:
1600         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1601         (Test::Test):
1602         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1603         (directoryChangedCallback):
1604         (WebViewTest::waitUntilFileChanged):
1605         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1606
1607 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1608
1609         REGRESSION(r263029): [Flatpak SDK] Broke initial SDK installation
1610
1611         Rubber-stamped by Žan Doberšek.
1612
1613         * flatpak/flatpakutils.py:
1614         (FlatpakObject.version): Gracefully return an empty version when the flatpak info command
1615         fails. This usually means the app has not been installed yet.
1616
1617 2020-06-15  Megan Gardner  <megan_gardner@apple.com>
1618
1619         Text form controls can scroll by 1px when value is the same length as size. No scrolling should happen.
1620         https://bugs.webkit.org/show_bug.cgi?id=212856
1621         <rdar://problem/63541707>
1622
1623         Reviewed by Zalan Bujtas.
1624
1625         Rebased to reflect new sizes.
1626
1627         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1628         (TEST):
1629         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1630         (TestWebKitAPI::TEST):
1631
1632 2020-06-15  Jonathan Bedard  <jbedard@apple.com>
1633
1634         Follow-up fix: Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
1635         https://bugs.webkit.org/show_bug.cgi?id=213144
1636         <rdar://problem/64316743>
1637
1638         Unreviewed build fix.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Guard didFinishNavigation declaration with HAVE(NETWORK_FRAMEWORK).
1641
1642 2020-06-15  Alex Christensen  <achristensen@webkit.org>
1643
1644         Provide alternatively-named SPI for user style sheets and scripts
1645         https://bugs.webkit.org/show_bug.cgi?id=213206
1646
1647         Reviewed by Brady Eidson.
1648
1649         * DumpRenderTree/mac/DumpRenderTree.mm:
1650         (fontAllowList):
1651         (createWebViewAndOffscreenWindow):
1652         (resetWebViewToConsistentStateBeforeTesting):
1653         (fontWhitelist): Deleted.
1654         * DumpRenderTree/mac/TestRunnerMac.mm:
1655         (TestRunner::addOriginAccessWhitelistEntry):
1656         (TestRunner::removeOriginAccessWhitelistEntry):
1657         (TestRunner::addUserScript):
1658         (TestRunner::addUserStyleSheet):
1659         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1660         (TEST):
1661         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
1662         (TEST):
1663         * WebKitTestRunner/mac/TestControllerMac.mm:
1664         (WTR::generateFontAllowList):
1665         (WTR::TestController::platformInitializeContext):
1666         (WTR::generateWhitelist): Deleted.
1667
1668 2020-06-15  Alex Christensen  <achristensen@webkit.org>
1669
1670         Add SPI to preconnect to a server
1671         https://bugs.webkit.org/show_bug.cgi?id=213109
1672         <rdar://problem/64184412>
1673
1674         Reviewed by Geoff Garen.
1675
1676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1677
1678 2020-06-15  Keith Miller  <keith_miller@apple.com>
1679
1680         Signal handlers should have a two phase installation.
1681         https://bugs.webkit.org/show_bug.cgi?id=213160
1682
1683         Reviewed by Mark Lam.
1684
1685         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1686         (TEST):
1687
1688 2020-06-15  Sihui Liu  <sihui_liu@apple.com>
1689
1690         Text manipulation does not observe newly displayed element inside previously observed content
1691         https://bugs.webkit.org/show_bug.cgi?id=213156
1692
1693         Reviewed by Darin Adler.
1694
1695         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1696         (TestWebKitAPI::TEST):
1697
1698 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1699
1700         [Flatpak SDK] Bump Subversion and enable Perl bindings
1701         https://bugs.webkit.org/show_bug.cgi?id=213189
1702
1703         Reviewed by Žan Doberšek.
1704
1705         * buildstream/elements/sdk-build-depends/swig.bst: Added.
1706         * buildstream/elements/sdk/subversion.bst: Enable Perl bindings so that git svn can be used within the sandbox.
1707
1708 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1709
1710         [Flatpak SDK] flatpak update still not displayed
1711         https://bugs.webkit.org/show_bug.cgi?id=213180
1712
1713         Reviewed by Žan Doberšek.
1714
1715         Added a new --version option to the script. We no longer gather the flatpak update command
1716         output to know if something was updated or not. Instead we get the version of the SDK prior
1717         to the update operation and compare that with the version after the update.
1718
1719         * flatpak/flatpakutils.py:
1720         (FlatpakObject.version):
1721         (WebkitFlatpak.load_from_args):
1722         (WebkitFlatpak.main):
1723
1724 2020-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1725
1726         [GTK][WPE] Add API to expose UIClient::requestStorageAccessConfirm
1727         https://bugs.webkit.org/show_bug.cgi?id=210422
1728
1729         Reviewed by Michael Catanzaro.
1730
1731         Handle WebKitWebsiteDataAccessPermissionRequest in MiniBrowser.
1732
1733         * MiniBrowser/gtk/BrowserTab.c:
1734         (decidePermissionRequest):
1735
1736 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1737
1738         [Flatpak SDK] Add libavif
1739         https://bugs.webkit.org/show_bug.cgi?id=212964
1740         <rdar://problem/64291035>
1741
1742         Reviewed by Žan Doberšek.
1743
1744         Because of the ABI bump of dav1d, which ffmpeg depends on, ffmpeg needs to be rebuilt. So
1745         this is a good opportunity to include it in the SDK and not rely on the ffmpeg-full
1746         extension anymore, because it doesn't provide debug symbols.
1747
1748         * buildstream/elements/flatpak/platform.bst:
1749         * buildstream/elements/flatpak/sdk.bst:
1750         * buildstream/elements/freedesktop-sdk.bst:
1751         * buildstream/elements/sdk-platform.bst:
1752         * buildstream/elements/sdk/ffmpeg.bst: Added.
1753         * buildstream/elements/sdk/gst-libav.bst:
1754         * buildstream/elements/sdk/libavif.bst: Added.
1755         * buildstream/elements/sdk/ruby-highline.bst: Remove the spec source, un-needed.
1756         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
1757         * buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Removed.
1758         * buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Removed.
1759         * buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Removed.
1760         * buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Removed.
1761         * buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Removed.
1762         * buildstream/project.conf:
1763         * flatpak/flatpakutils.py:
1764         (WebkitFlatpak._get_packages):
1765
1766 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1767
1768         [Flatpak SDK] Remove webkit-build-directory dependency from flatpakutils
1769         https://bugs.webkit.org/show_bug.cgi?id=213179
1770
1771         Reviewed by Žan Doberšek.
1772
1773         This makes webkit-flatpak usable without installing additional perl modules (version) on the host OS.
1774
1775         * flatpak/flatpakutils.py:
1776         (WebkitFlatpak.load_from_args): Make --release and --debug mutually exclusive, and default to Release builds.
1777         (WebkitFlatpak.__init__):
1778         (WebkitFlatpak.clean_args): No need to pull in webkitpy which pulls webkitdirs.pm only to
1779         determine the default configuration. Assume we use Release by default.
1780
1781 2020-06-15  Paulo Matos  <pmatos@igalia.com>
1782
1783         Properly propagate TZ to the remote test devices
1784         https://bugs.webkit.org/show_bug.cgi?id=212816
1785
1786         Reviewed by Philippe Normand.
1787
1788         * Scripts/run-jsc-stress-tests:
1789
1790 2020-06-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1791
1792         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
1793         https://bugs.webkit.org/show_bug.cgi?id=213183
1794         <rdar://problem/64273483>
1795
1796         Reviewed by Tim Horton.
1797
1798         On recent versions of the iOS SDK, iOS simulators that are not shown on-screen are treated as if the hardware
1799         keyboard is not available (that is, `+[UIIKeyboard isInHardwareKeyboardMode]` returns `NO`). When running API
1800         tests while `Simulator.app` is already launched, an iOS simulator is presented on-screen, whereas the simulator
1801         is not visible when running API tests without launching `Simulator.app` beforehand.
1802
1803         This discrepancy causes two iOS API tests to fail (i.e. `CaretSelectionRectAfterRestoringFirstResponder` and
1804         `RangedSelectionRectAfterRestoringFirstResponder`), due to the fact that `-[WKWebView becomeFirstResponder]` no
1805         longer causes an input session to begin.
1806
1807         Interestingly, these tests already attempt to circumvent this by using `webViewWithAutofocusedInput()`, which
1808         creates and loads a `WKWebView` with a single autofocusing input element, with a `_WKInputDelegate` that
1809         unconditionally allows input sessions to begin. However, this doesn't work as intended in these tests, because
1810         nothing keeps the delegate (a `TestInputDelegate`) alive past the scope of the call to
1811         `webViewWithAutofocusedInput()`. Since `[WKWebView _inputDelegate]` is a weak property, the input delegate
1812         simply disappears after we finish waiting for the load to finish (and the autofocused input element begins its
1813         input session). This causes us to erroneously fall back to default behavior (i.e.
1814         `_WKFocusStartsInputSessionPolicyAuto`) for subsequent calls to show the keyboard for the focused element, as is
1815         the case when these two API tests call `-becomeFirstResponder`. The end result is that the keyboard doesn't
1816         appear and text selection views are not created and laid out, but only when API tests are run without having
1817         launched the Simulator app beforehand.
1818
1819         To fix this, refactor `webViewWithAutofocusedInput()` into `webViewAndInputDelegateWithAutofocusedInput()`,
1820         which returns both the new `WKWebView` as well as the `TestInputDelegate` of the web view. The call site is then
1821         responsible for keeping the input delegate around for as long as it needs.
1822
1823         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1824         (webViewWithAutofocusedInput):
1825
1826         Drive-by fix: fix a potential stack smasher by using an Objective-C block when setting the input delegate's
1827         policy handler, and by using `__block` for the `doneWaiting` boolean flag. This is now a problem becuase this
1828         block may be invoked multiple times.
1829
1830         (webViewAndInputDelegateWithAutofocusedInput):
1831
1832 2020-06-13  Saam Barati  <sbarati@apple.com>
1833
1834         compare-results should have an option to print a breakdown and to save the breakdown as csv file
1835         https://bugs.webkit.org/show_bug.cgi?id=213140
1836
1837         Reviewed by Filip Pizlo.
1838
1839         In this patch, compare-results has a new --breakdown feature which will
1840         break down the results for -a and -b per subtest. It will also show you
1841         p values with a significance threshold determined using the Bonferroni
1842         correction for testing multiple hypotheses:
1843         https://en.wikipedia.org/wiki/Bonferroni_correction
1844         
1845         And there is also now a --csv option to generate a csv file containing
1846         the same per subtest breakdown.
1847         
1848         --breakdown will print out results like:
1849         
1850         ------------------------------------------------------------------------------------------------------------
1851         |               subtest                |     ms       |     ms       |  b / a   | pValue, alpha = 0.003125 |
1852         ------------------------------------------------------------------------------------------------------------
1853         | Elm-TodoMVC                          |616.625000    |583.625000    |0.946483  | 0.065002                 |
1854         | VueJS-TodoMVC                        |89.425000     |83.225000     |0.930668  | 0.039102                 |
1855         | EmberJS-TodoMVC                      |695.875000    |664.000000    |0.954194  | 0.088901                 |
1856         | Flight-TodoMVC                       |263.600000    |257.600000    |0.977238  | 0.249259                 |
1857         | BackboneJS-TodoMVC                   |213.025000    |201.550000    |0.946133  | 0.000636 (significant)   |
1858         | Preact-TodoMVC                       |48.800000     |47.550000     |0.974385  | 0.502768                 |
1859         | AngularJS-TodoMVC                    |745.300000    |704.275000    |0.944955  | 0.011779                 |
1860         | Inferno-TodoMVC                      |607.900000    |354.800000    |0.583649  | 0.000000 (significant)   |
1861         | Vanilla-ES2015-TodoMVC               |214.950000    |200.575000    |0.933124  | 0.005018                 |
1862         | Angular2-TypeScript-TodoMVC          |191.575000    |187.025000    |0.976250  | 0.542229                 |
1863         | VanillaJS-TodoMVC                    |162.075000    |160.375000    |0.989511  | 0.747186                 |
1864         | jQuery-TodoMVC                       |855.275000    |833.825000    |0.974920  | 0.103439                 |
1865         | EmberJS-Debug-TodoMVC                |2056.250000   |1952.050000   |0.949325  | 0.000003 (significant)   |
1866         | React-TodoMVC                        |475.225000    |428.950000    |0.902625  | 0.007566                 |
1867         | React-Redux-TodoMVC                  |791.100000    |736.675000    |0.931203  | 0.066091                 |
1868         | Vanilla-ES2015-Babel-Webpack-TodoMVC |208.050000    |202.000000    |0.970920  | 0.152470                 |
1869         ------------------------------------------------------------------------------------------------------------
1870
1871         * Scripts/compare-results:
1872         (readJSONFile):
1873         (speedometer2Breakdown):
1874         (jetStream2Breakdown):
1875         (motionMarkBreakdown):
1876         (plt5Breakdown):
1877         (displayStr):
1878         (dumpBreakdowns):
1879         (writeCSV):
1880         (detectMotionMark1_1):
1881         (detectMotionMark1_1_1):
1882         (motionMarkResults):
1883         (detectBenchmark):
1884         (getOptions):
1885         (main):
1886         (motionMark1_1Results): Deleted.
1887
1888 2020-06-13  Sam Weinig  <weinig@apple.com>
1889
1890         Extended Color: Experiment with strongly typed ColorComponents
1891         https://bugs.webkit.org/show_bug.cgi?id=212396
1892
1893         Reviewed by Darin Adler.
1894
1895         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
1896         (TestWebKitAPI::TEST):
1897         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
1898         (TestWebKitAPI::TEST):
1899         Update for changed names (e.g. toSRGBAComponentsLossy() -> toSRGBALossy())
1900         and use of explicit types.
1901
1902 2020-06-13  Diego Pino Garcia  <dpino@igalia.com>
1903
1904         Unreviewed, fix configuration setting of WPE Debug (Tests JS) bot
1905         https://bugs.webkit.org/show_bug.cgi?id=213164
1906
1907         The bot was meant to run as Debug.
1908
1909         * BuildSlaveSupport/build.webkit.org-config/config.json:
1910
1911 2020-06-12  Keith Miller  <keith_miller@apple.com>
1912
1913         Tests expecting a crash should use a signal handler in the JSC CLI process
1914         https://bugs.webkit.org/show_bug.cgi?id=212479
1915
1916         Reviewed by Yusuke Suzuki.
1917
1918         Crashing tests should now exit with status zero.
1919
1920         * Scripts/run-jsc-stress-tests:
1921         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
1922         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
1923         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
1924
1925 2020-06-12  Alex Christensen  <achristensen@webkit.org>
1926
1927         Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
1928         https://bugs.webkit.org/show_bug.cgi?id=213144
1929
1930         Reviewed by Geofferey Garen.
1931
1932         Most changes are straightforward moving to HTTPServer, which is more tolerant of different numbers of connections except these two:
1933
1934         The ResourceLoadDelegate.Challenge API test was checking the output of _WKResourceLoadDelegate.didReceiveChallenge
1935         by using a server trust challenge.  Now that preconnecting happens, the server trust evaluation would happen with a
1936         PreconnectTask, not the main resource load.  The WKNavigationDelegate still gets the challenge and there is no problem
1937         here, but in order to continue to test _WKResourceLoadDelegate.didReceiveChallenge I use a basic authentication challenge
1938         instead of a server trust evaluation.
1939
1940         The WebKit.FastServerTrust API test now has two failed attempts (one from the preconnect attempt, one from the main resource load attempt),
1941         but only when _strictTrustEvaluate is not available.
1942
1943         * TestWebKitAPI/TCPServer.cpp:
1944         (TestWebKitAPI::TCPServer::TCPServer):
1945         * TestWebKitAPI/TCPServer.h:
1946         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1947         (TEST):
1948         (TestWebKitAPI::TEST):
1949         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1950         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1951         * TestWebKitAPI/cocoa/HTTPServer.h:
1952         * TestWebKitAPI/cocoa/HTTPServer.mm:
1953         (TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
1954
1955 2020-06-12  Diego Pino Garcia  <dpino@igalia.com>
1956
1957         [buildbot] [GTK][WPE] Move WebDriver test to own bot
1958         https://bugs.webkit.org/show_bug.cgi?id=212527
1959
1960         Reviewed by Carlos Alberto Lopez Perez.
1961
1962         Move 'webdriver-test' step from GTK Release and GTK Debug test bots
1963         to separated bots.
1964
1965         For bots that require a Wayland display (WPE and GTK Wayland),
1966         'webdriver-test' step is run on the corresponding general test bot,
1967         since it's not possible at the moment to run tests that require a 
1968         Wayland display in a bot set as a container.
1969
1970         * BuildSlaveSupport/build.webkit.org-config/config.json:
1971         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1972         (TestFactory.__init__):
1973         (TestWebDriverFactory):
1974         (TestWebDriverFactory.__init__):
1975         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1976
1977 2020-06-12  Takashi Komori  <Takashi.Komori@sony.com>
1978
1979         [Curl] Implement functions to use ResourceLoadStatistics.
1980         https://bugs.webkit.org/show_bug.cgi?id=207692
1981
1982         Reviewed by Don Olmstead.
1983
1984         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
1985
1986         Tests: http/tests/resourceLoadStatistics/
1987
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
1990         (WTR::getAllStorageAccessEntriesCallback):
1991         (WTR::TestController::getAllStorageAccessEntries):
1992
1993 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
1994
1995         Support building test runners for watchOS and tvOS
1996         https://bugs.webkit.org/show_bug.cgi?id=213128
1997         <rdar://problem/64298006>
1998
1999         Reviewed by Tim Horton.
2000
2001         * DumpRenderTree/mac/Configurations/Base.xcconfig: Link against framework stubs.
2002         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Apply iOS rules to all embedded sdks.
2003         * WebKitTestRunner/Configurations/Base.xcconfig: Link against framework stubs.
2004         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Apply iOS rules to all embedded sdks.
2005         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Use watchOS entitlements for tvOS.
2006
2007 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
2008
2009         TestWebKitAPI: Build for watchOS and tvOS
2010         https://bugs.webkit.org/show_bug.cgi?id=213127
2011         <rdar://problem/64297979>
2012
2013         Reviewed by Tim Horton.
2014
2015         * TestWebKitAPI/Configurations/Base.xcconfig: Link against framework stubs.
2016         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Apply iOS rules to all embedded sdks.
2017         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Ditto.
2018         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Link against framework stubs.
2019         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Apply iOS rules to all embedded sdks.
2020         * TestWebKitAPI/config.h: WatchOS uses SSL.
2021
2022 2020-06-12  Commit Queue  <commit-queue@webkit.org>
2023
2024         Unreviewed, reverting r262942.
2025         https://bugs.webkit.org/show_bug.cgi?id=213132
2026
2027         Broke gst-libav due to dav1d ABI bump
2028
2029         Reverted changeset:
2030
2031         "[Flatpak SDK] Add libavif"
2032         https://bugs.webkit.org/show_bug.cgi?id=212964
2033         https://trac.webkit.org/changeset/262942
2034
2035 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2036
2037         Unreviewed. Fix GTK WebDriver tests after r262938
2038
2039         Ensure a valid title for backforward items in MiniBrowser, using the URL when the title is empty.
2040
2041         * MiniBrowser/gtk/BrowserWindow.c:
2042         (browserWindowCreateBackForwardMenu):
2043
2044 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2045
2046         [Flatpak SDK] Update GTK4 to 3.98.5
2047
2048         Rubber-stamped by Carlos Alberto Lopez Perez.
2049
2050         * buildstream/elements/sdk/gtk.bst:
2051
2052 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2053
2054         [Flatpak SDK] Add libavif
2055         https://bugs.webkit.org/show_bug.cgi?id=212964
2056
2057         Reviewed by Carlos Alberto Lopez Perez.
2058
2059         * buildstream/elements/freedesktop-sdk.bst:
2060         * buildstream/elements/sdk-platform.bst:
2061         * buildstream/elements/sdk/libavif.bst: Added.
2062         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
2063
2064 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2065
2066         [Flatpak SDK] Add libkate
2067         https://bugs.webkit.org/show_bug.cgi?id=212865
2068
2069         Reviewed by Carlos Alberto Lopez Perez.
2070
2071         The GStreamer kate decoder is required for some media/track tests being re-enabled in bug
2072         120665.
2073
2074         * buildstream/elements/sdk-platform.bst:
2075         * buildstream/elements/sdk/gst-plugins-bad.bst:
2076         * buildstream/elements/sdk/libkate.bst: Added.
2077
2078 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2079
2080         [GTK4] Get MiniBrowser ready for GTK4
2081         https://bugs.webkit.org/show_bug.cgi?id=210276
2082
2083         Reviewed by Adrian Perez de Castro.
2084
2085         Port MiniBrowser to GTK4. BrowserSearchBar has been renamed as BrowserSearchBox, because in GTK GtkSearchBar is
2086         final class, so we derive from GtkBox and to be used as contents of a GtkSearchBar.
2087
2088         * MiniBrowser/gtk/BrowserCellRendererVariant.c:
2089         (browserCellRendererVariantCellRendererSnapshot):
2090         (browser_cell_renderer_variant_class_init):
2091         * MiniBrowser/gtk/BrowserCellRendererVariant.h:
2092         * MiniBrowser/gtk/BrowserSearchBar.c: Removed.
2093         * MiniBrowser/gtk/BrowserSearchBox.c: Added.
2094         (setFailedStyleForEntry):
2095         (doSearch):
2096         (searchNext):
2097         (searchPrevious):
2098         (searchEntryMenuIconPressedCallback):
2099         (searchEntryClearIconReleasedCallback):
2100         (searchEntryChangedCallback):
2101         (searchEntryActivatedCallback):
2102         (searchPreviousButtonCallback):
2103         (searchNextButtonCallback):
2104         (searchMenuCheckButtonToggledCallback):
2105         (findControllerFailedToFindTextCallback):
2106         (findControllerFoundTextCallback):
2107         (browserSearchBoxFinalize):
2108         (browserSearchBoxDispose):
2109         (browserSearchBoxSizeAllocate):
2110         (browser_search_box_class_init):
2111         (browser_search_box_new):
2112         (browser_search_box_get_entry):
2113         * MiniBrowser/gtk/BrowserSearchBox.h: Renamed from Tools/MiniBrowser/gtk/BrowserSearchBar.h.
2114         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2115         (browser_settings_dialog_init):
2116         (browser_settings_dialog_new):
2117         * MiniBrowser/gtk/BrowserSettingsDialog.h:
2118         * MiniBrowser/gtk/BrowserTab.c:
2119         (loadChanged):
2120         (createInfoBarQuestionMessage):
2121         (tlsErrorsDialogResponse):
2122         (loadFailedWithTLSerrors):
2123         (permissionRequestDialogResponse):
2124         (decidePermissionRequest):
2125         (colorChooserRequestFinished):
2126         (runColorChooserCallback):
2127         (tabCloseClicked):
2128         (browserTabConstructed):
2129         (browserTabIsSearchBarOpen):
2130         (browser_tab_start_search):
2131         (browser_tab_stop_search):
2132         (browser_tab_enter_fullscreen):
2133         (browser_tab_leave_fullscreen):
2134         * MiniBrowser/gtk/BrowserWindow.c:
2135         (settingsCallback):
2136         (resetEntryProgress):
2137         (webViewLoadProgressChanged):
2138         (browserWindowCreateBackForwardMenu):
2139         (browserWindowUpdateNavigationMenu):
2140         (navigationButtonPressed):
2141         (navigationButtonPressCallback):
2142         (scrollEventCallback):
2143         (webViewIsLoadingChanged):
2144         (searchCallback):
2145         (insertImageDialogResponse):
2146         (insertImageCommandCallback):
2147         (insertLinkDialogResponse):
2148         (insertLinkCommandCallback):
2149         (typingAttributesChanged):
2150         (browserWindowSaveSession):
2151         (browserWindowFinalize):
2152         (browserWindowDispose):
2153         (addToolbarButton):
2154         (browserWindowSwitchTab):
2155         (browserWindowTabAddedOrRemoved):
2156         (browserWindowBuildPopoverMenu):
2157         (browserWindowCloseRequest):
2158         (browserWindowDeleteEvent):
2159         (browser_window_class_init):
2160         (browser_window_append_view):
2161         (browser_window_set_background_color):
2162         * MiniBrowser/gtk/CMakeLists.txt:
2163
2164 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2165
2166         [GTK] MiniBrowser: stop using GtkToolbar
2167         https://bugs.webkit.org/show_bug.cgi?id=212898
2168
2169         Reviewed by Adrian Perez de Castro.
2170
2171         GtkToolbar iss no longer available in GTK4, use a GtkBox with buttons instead. Also use symbolic icons and move
2172         some of the actions to a gear menu.
2173
2174         * MiniBrowser/gtk/BrowserWindow.c:
2175         (browserWindowHistoryItemActivated):
2176         (browserWindowCreateBackForwardMenu):
2177         (browserWindowUpdateNavigationMenu):
2178         (navigationButtonPressCallback):
2179         (browserWindowCanZoomDefault):
2180         (browserWindowUpdateZoomActions):
2181         (webViewIsLoadingChanged):
2182         (addToolbarButton):
2183         (browserWindowBuildPopoverMenu):
2184         (resetStatusText): Deleted.
2185         (browserWindowHistoryItemSelected): Deleted.
2186         (browserWindowSetupEditorToolbarItem): Deleted.
2187
2188 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2189
2190         [GTK] MiniBrowser: stop using GtkToolbar for the search bar
2191         https://bugs.webkit.org/show_bug.cgi?id=212817
2192
2193         Reviewed by Adrian Perez de Castro.
2194
2195         Use a GtkSearchBar instead, because GtkToolbar is no longer available in GTK4. Also use a GtkPopover for the
2196         options menu instead of the GtkMenu.
2197
2198         * MiniBrowser/gtk/BrowserSearchBar.c:
2199         (setFailedStyleForEntry):
2200         (doSearch):
2201         (searchEntryMenuIconPressedCallback):
2202         (searchEntryChangedCallback):
2203         (searchMenuCheckButtonToggledCallback):
2204         (browserSearchBarFinalize):
2205         (browser_search_bar_new):
2206         (browser_search_bar_open):
2207         (browser_search_bar_close):
2208         (browser_search_bar_is_open):
2209         (searchCloseButtonClickedCallback): Deleted.
2210         (searchEntryClearIconReleasedCallback): Deleted.
2211         * MiniBrowser/gtk/BrowserSearchBar.h:
2212         * MiniBrowser/gtk/BrowserTab.c:
2213         (browser_tab_start_search):
2214         (browser_tab_stop_search):
2215
2216 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         [GTK4] Make WebDriver work
2219         https://bugs.webkit.org/show_bug.cgi?id=212316
2220
2221         Reviewed by Adrian Perez de Castro.
2222
2223         Stop connecting to WebKitWebView::close signal twice for newaly created windows.
2224
2225         * MiniBrowser/gtk/BrowserWindow.c:
2226         (webViewCreate):
2227
2228 2020-06-11  Saam Barati  <sbarati@apple.com>
2229
2230         Skip wasm-js2 test on memory limited devices
2231         https://bugs.webkit.org/show_bug.cgi?id=213099
2232
2233         Reviewed by Yusuke Suzuki.
2234
2235         * Scripts/run-jsc-stress-tests:
2236
2237 2020-06-11  Alex Christensen  <achristensen@webkit.org>
2238
2239         Re-enable download resume tests
2240         https://bugs.webkit.org/show_bug.cgi?id=213098
2241         <rdar://problem/63512518>
2242
2243         Reviewed by Geoffrey Garen.
2244
2245         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2246
2247 2020-06-11  Commit Queue  <commit-queue@webkit.org>
2248
2249         Unreviewed, reverting r262696.
2250         https://bugs.webkit.org/show_bug.cgi?id=213097
2251
2252         It broke running JSC tests on watchOS
2253
2254         Reverted changeset:
2255
2256         "Allow run-jsc-stress-tests still run if some of the remote
2257         hosts are not available"
2258         https://bugs.webkit.org/show_bug.cgi?id=201426
2259         https://trac.webkit.org/changeset/262696
2260
2261 2020-06-11  Sihui Liu  <sihui_liu@apple.com>
2262
2263         REGRESSION (r262879): 3 TestWebKitAPI.TextManipulation tests are failing
2264         https://bugs.webkit.org/show_bug.cgi?id=213079
2265         <rdar://problem/64256870>
2266
2267         Reviewed by Wenson Hsieh.
2268
2269         Update a few tests after behavior change in r262879. From r262879, we no longer use visible positions of element
2270         to calculate range to observe. Instead, we use the first and end position in the element to decide the range. In
2271         previous implementation, the range can be extended to outside of the element, like some visible positon before 
2272         or after the element.
2273
2274         TextManipulation.StartTextManipulationFindNewlyDisplayedParagraph: Different elements would make separate ranges 
2275         because we create range with the boundaries of element. We can consider merging adjacent ranges later.
2276         TextManipulation.StartTextManipulationFindSameParagraphWithNewContent: The newly observing range only includes
2277         the newly inserted element now.
2278         TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem: The p element
2279         is not manipulated as it is the common ancestor of manipulated elements. And we want to make sure the newly
2280         inserted element is child of a manipulated element.
2281
2282         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2283         (TestWebKitAPI::TEST):
2284
2285 2020-06-11  Andy Estes  <aestes@apple.com>
2286
2287         [iOS] nullptr deref in FileInputType::iconLoaded when the input's type attribute is modified by a change event listener
2288         https://bugs.webkit.org/show_bug.cgi?id=208244
2289         <rdar://problem/41855350>
2290
2291         Reviewed by Wenson Hsieh.
2292
2293         * DumpRenderTree/TestRunner.cpp:
2294         (SetOpenPanelFilesMediaIconCallback):
2295         (TestRunner::staticFunctions):
2296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2297         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2298
2299 2020-06-11  Sergio Villar Senin  <svillar@igalia.com>
2300
2301         Unreviewed, updated libsoup dependency in jhbuild.
2302
2303         * wpe/jhbuild.modules:
2304
2305 2020-06-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2306
2307         [macOS]: The File Picker of the <input> file element should show the selection filter
2308         https://bugs.webkit.org/show_bug.cgi?id=212485
2309
2310         Reviewed by Darin Adler.
2311
2312         Create a view with an NSPopupButton for the file extensions filter. Set
2313         this view as the AccessoryView of the OpenPanel. Create a customized target
2314         for the NSPopupButton to respond to changing its selection.
2315
2316         * MiniBrowser/mac/WK2BrowserWindowController.m:
2317         (-[FileExtensionsPopupTarget initWithOpenPanel:allowedFileExtensions:]):
2318         (-[FileExtensionsPopupTarget popupAction:]):
2319         (-[FileExtensionsPopupTarget dealloc]):
2320         (-[WK2BrowserWindowController dealloc]):
2321         (-[WK2BrowserWindowController createFilterView:popupTarget:]):
2322         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2323
2324 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
2325
2326         Generalize configure-xcode-for-ios-development (Part 2)
2327         https://bugs.webkit.org/show_bug.cgi?id=207043
2328         <rdar://problem/63946933>
2329
2330         Reviewed by Darin Adler.
2331
2332         * EWSTools/start-queue-mac.sh: Use configure-xcode-for-embedded-development over configure-xcode-for-ios-development.
2333         * Scripts/configure-xcode-for-ios-development: Removed.
2334
2335 2020-06-10  Sihui Liu  <sihui_liu@apple.com>
2336
2337         Text manipulation does not observe inserted elements that are invisible
2338         https://bugs.webkit.org/show_bug.cgi?id=213057
2339         <rdar://problem/63768253>
2340
2341         Reviewed by Wenson Hsieh.
2342
2343         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2344         (TestWebKitAPI::TEST):
2345
2346 2020-06-10  Geoffrey Garen  <ggaren@apple.com>
2347
2348         Some style improvements to main thread code
2349         https://bugs.webkit.org/show_bug.cgi?id=213051
2350
2351         Reviewed by Darin Adler.
2352
2353         Updated for rename.
2354         
2355         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2356         (TestWebKitAPI::TEST):
2357         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2358         (TestWebKitAPI::TEST):
2359         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2360         (TestWebKitAPI::TEST):
2361         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2362         (ApplicationManifestParserTest::SetUp):
2363         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2364         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2365         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2366         (TestWebKitAPI::ContentExtensionTest::SetUp):
2367         * TestWebKitAPI/Tests/WebCore/DNS.cpp:
2368         (TestWebKitAPI::TEST):
2369         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2370         (TestWebKitAPI::TEST_F):
2371         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2372         (initializeInAppBrowserPrivacyTestSettings):
2373         * WebKitTestRunner/TestController.cpp:
2374         (WTR::TestController::initialize):
2375
2376 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
2377
2378         results.webkit.org: Health check should access redis and Cassandra
2379         https://bugs.webkit.org/show_bug.cgi?id=212899
2380         <rdar://problem/64118077>
2381
2382         Reviewed by Stephanie Lewis.
2383
2384         * resultsdbpy/resultsdbpy/example/main.py:
2385         (health): Check the health status of the model.
2386         * resultsdbpy/resultsdbpy/model/model.py:
2387         (Model.HealthTable):
2388         (Model.__init__): Construct a Cassandra table used to check the health of our Cassandra connection.
2389         (Model.healthy): Make both a read and write connection to our two database dependencies so that if
2390         our connection to those databases fails, an instance will be forced to restart.
2391         * resultsdbpy/resultsdbpy/model/model_unittest.py: Added.
2392         (ModelTest):
2393         (ModelTest.init_database):
2394         (ModelTest.test_health):
2395
2396 2020-06-10  Keith Miller  <keith_miller@apple.com>
2397
2398         run-jsc-stress-tests should skip tests marked as slow in quick mode.
2399         https://bugs.webkit.org/show_bug.cgi?id=213042
2400
2401         Reviewed by Yusuke Suzuki.
2402
2403         * Scripts/run-jsc-stress-tests:
2404
2405 2020-06-10  Antoine Quint  <graouts@webkit.org>
2406
2407         Subframes should not autosize independently
2408         https://bugs.webkit.org/show_bug.cgi?id=212984
2409         <rdar://problem/64175493>
2410
2411         Reviewed by Simon Fraser.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2414         (TEST): Added test for <object>.
2415
2416 2020-06-09  Ryan Haddad  <ryanhaddad@apple.com>
2417
2418         [Mojave] Flaky API Test: TestWebKitAPI.WebKitLegacy.CrossPartitionFileSchemeAccess
2419         https://bugs.webkit.org/show_bug.cgi?id=206956
2420
2421         Unreviewed test gardening.
2422
2423         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Disable this test for Mojave.
2424
2425 2020-06-10  Alex Christensen  <achristensen@webkit.org>
2426
2427         Revert r259770
2428         https://bugs.webkit.org/show_bug.cgi?id=210097
2429         <rdar://problem/64175992>
2430
2431         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2432         (TEST):
2433
2434 2020-06-10  Commit Queue  <commit-queue@webkit.org>
2435
2436         Unreviewed, reverting r262807.
2437         https://bugs.webkit.org/show_bug.cgi?id=213019
2438
2439         It is breaking JSC queues (Requested by caiolima on #webkit).
2440
2441         Reverted changeset:
2442
2443         "Add a timeout monitor for JSC stress test"
2444         https://bugs.webkit.org/show_bug.cgi?id=211978
2445         https://trac.webkit.org/changeset/262807
2446
2447 2020-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2448
2449         Unreviewed, reverting r262791.
2450
2451         WinCairo WebKit1 is crashing.
2452
2453         Reverted changeset:
2454
2455         "[Curl] Implement functions to use ResourceLoadStatistics."
2456         https://bugs.webkit.org/show_bug.cgi?id=207692
2457         https://trac.webkit.org/changeset/262791
2458
2459 2020-06-09  Zhifei Fang  <zhifei_fang@apple.com>
2460
2461         Add a timeout monitor for JSC stress test
2462         https://bugs.webkit.org/show_bug.cgi?id=211978
2463
2464         Reviewed by Jonathan Bedard.
2465
2466         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Add timeout monitor inside the jsc stress test runner, it will kill the process in case of jsc timeout handler not working
2467
2468 2020-06-09  Tim Horton  <timothy_horton@apple.com>
2469
2470         WebKit.ShrinkToFit is failing on some bots
2471         https://bugs.webkit.org/show_bug.cgi?id=212932
2472         <rdar://problem/60972407>
2473
2474         Reviewed by Simon Fraser.
2475
2476         TestWebKitAPI was failing to stabilize the overlay scrollbar preference,
2477         because the only stabilization attempt was in the injected bundle 
2478         initialization code, and most tests (including ShrinkToFit) do not have
2479         an injected bundle.
2480
2481         Because this preference is manually propagated to the Web Content process,
2482         we can set the default in the volatile domain in the UI process at startup.
2483
2484         We can't move other preferences yet, because they are not manually propagated,
2485         and WebKit's NSUserDefault synchronization mechanism ignores defaults in the
2486         volatile domain (and the initial preference load reads from disk, not
2487         from the UI process, so it wouldn't find them anyway).
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2490         (TEST):
2491         Explain why the final value of the test is different than the starting value.
2492
2493         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2494         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2495         Leave a FIXME for future generations.
2496
2497         * TestWebKitAPI/mac/mainMac.mm:
2498         (main):
2499         Override overlay scrollbar preferences in the UI process, so it affects all tests.
2500
2501         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2502         This test is also affected by using non-overlay scrollbars; we now have less space, so take up more pages.
2503
2504 2020-06-09  Youenn Fablet  <youenn@apple.com>
2505
2506         BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit
2507         https://bugs.webkit.org/show_bug.cgi?id=212970
2508
2509         Reviewed by Eric Carlson.
2510
2511         Add an option to capture in UI process so that the same test can run on both MacOS and iOS.
2512         This eases the testing infra to be able to get audio capture unit state in WebProcess as is the case in iOS.
2513
2514         * WebKitTestRunner/TestController.cpp:
2515         (WTR::TestController::resetPreferencesToConsistentValues):
2516         (WTR::updateTestOptionsFromTestHeader):
2517         * WebKitTestRunner/TestOptions.h:
2518         (WTR::TestOptions::hasSameInitializationOptions const):
2519
2520 2020-06-09  Takashi Komori  <Takashi.Komori@sony.com>
2521
2522         [Curl] Implement functions to use ResourceLoadStatistics.
2523         https://bugs.webkit.org/show_bug.cgi?id=207692
2524
2525         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
2526
2527         Tests: http/tests/resourceLoadStatistics/
2528
2529         Reviewed by Don Olmstead.
2530
2531         * WebKitTestRunner/TestController.cpp:
2532         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
2533         (WTR::getAllStorageAccessEntriesCallback):
2534         (WTR::TestController::getAllStorageAccessEntries):
2535
2536 2020-06-09  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2537
2538         [Flatpak][GStreamer] enhance GST_ environment variable passing
2539         https://bugs.webkit.org/show_bug.cgi?id=212905
2540
2541         Reviewed by Philippe Normand.
2542
2543         Handle the passing of several GST environment variables,
2544         particularly GST_DEBUG, which, when using * symbol, python adds
2545         quotes, but they break the parsing in GStreamer.
2546
2547         Also the variables are handled by gst-env.py when using
2548         GST_BUILD_PATH, so they are filtered out when it's exported,
2549         avoiding duplication. But it GST_BUILD_PATH is not defined, the
2550         variables are passed to flatpak.
2551
2552         * flatpak/flatpakutils.py:
2553         (WebkitFlatpak.setup_gstbuild):
2554         (WebkitFlatpak.run_in_sandbox):
2555
2556 2020-06-09  Sihui Liu  <sihui_liu@apple.com>
2557
2558         TextManipulationController range of paragraph may be wrong after r262601
2559         https://bugs.webkit.org/show_bug.cgi?id=212874
2560
2561         Reviewed by Wenson Hsieh.
2562
2563         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2564         (TestWebKitAPI::TEST):
2565
2566 2020-06-08  Sihui Liu  <sihui_liu@apple.com>
2567
2568         TextManipulation should only convert text from Node's text content to tokens
2569         https://bugs.webkit.org/show_bug.cgi?id=212928
2570
2571         Reviewed by Wenson Hsieh.
2572
2573         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2574         (TestWebKitAPI::TEST):
2575
2576 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
2577
2578         [webkitpy] Check 'bug-search' returns a non null result before parsing
2579         https://bugs.webkit.org/show_bug.cgi?id=212906
2580
2581         Reviewed by Jonathan Bedard.
2582
2583         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2584         (BugzillaQueries._parse_result_count): Check quick-search query
2585         response is non-null and a non-empty text.
2586
2587 2020-06-08  Sam Weinig  <weinig@apple.com>
2588
2589         Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
2590         https://bugs.webkit.org/show_bug.cgi?id=212917
2591
2592         Reviewed by Darin Adler.
2593
2594         Addresses feedback from Darin.
2595
2596         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2597         (TestWebKitAPI::TEST):
2598
2599 2020-06-08  Sam Weinig  <weinig@apple.com>
2600
2601         Fix test results after r262733.
2602
2603         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2604         (TestWebKitAPI::TEST):
2605
2606 2020-06-08  David Kilzer  <ddkilzer@apple.com>
2607
2608         [IPC] Adopt enum class for DragOperation
2609         <https://webkit.org/b/212870>
2610         <rdar://problem/64069940>
2611
2612         Reviewed by Darin Adler.
2613
2614         * Scripts/do-webcore-rename:
2615         - Do DragOperation renames.
2616
2617 2020-06-08  Commit Queue  <commit-queue@webkit.org>
2618
2619         Unreviewed, reverting r262685.
2620         https://bugs.webkit.org/show_bug.cgi?id=212914
2621
2622         caused flakey crashes in an iOS test
2623
2624         Reverted changeset:
2625
2626         "Clear WebPageProxy event state between tests"
2627         https://bugs.webkit.org/show_bug.cgi?id=212864
2628         https://trac.webkit.org/changeset/262685
2629
2630 2020-06-08  Sam Weinig  <weinig@apple.com>
2631
2632         Extended Color: Unify rounding / clamping conversions between 0-1 float components and 0-255 byte components
2633         https://bugs.webkit.org/show_bug.cgi?id=212871
2634
2635         Reviewed by Simon Fraser.
2636
2637         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2638         (TestWebKitAPI::TEST):
2639         Switch to using makeSimpleColor(hslToSRGB(...)) directly.
2640
2641 2020-06-08  Sam Weinig  <weinig@apple.com>
2642
2643         Extended Color: Replace uses of differenceSquared() with luminance based computations
2644         https://bugs.webkit.org/show_bug.cgi?id=212872
2645
2646         Reviewed by Darin Adler.
2647
2648         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2649         (TestWebKitAPI::TEST):
2650         Add basic tests for Color::luminance(), ensuring white == 1, black == 0, and 
2651         darken() and lighten() creat colors with less than / greater than luminance.
2652
2653 2020-06-08  Per Arne Vollan  <pvollan@apple.com>
2654
2655         [Cocoa] CFPrefs synchronization does not always work for global preference changes
2656         https://bugs.webkit.org/show_bug.cgi?id=212783
2657
2658         Reviewed by Tim Horton.
2659
2660         Add API test, and add some synchronization to avoid flakiness.
2661
2662         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
2663         (-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
2664         (TEST):
2665         (sharedInstanceMethodOverride):
2666
2667 2020-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2668
2669         [iOS] Hit-testing on icloud.com is offset after closing a tab
2670         https://bugs.webkit.org/show_bug.cgi?id=212890
2671         <rdar://problem/58775297>
2672
2673         Reviewed by Simon Fraser.
2674
2675         Add a new API test to verify that the scroll position doesn't get stuck at -30px after shifting both the top
2676         content inset and top obscured inset by 30px. See WebKit ChangeLog for more details.
2677
2678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2679         * TestWebKitAPI/Tests/WebKitCocoa/overflow-hidden.html: Added.
2680         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2681         (-[ScrollViewDelegate scrollViewDidScroll:]):
2682         (TestWebKitAPI::TEST):
2683         * TestWebKitAPI/ios/UIKitSPI.h:
2684
2685 2020-06-08  Philippe Normand  <pnormand@igalia.com>
2686
2687         [Flatpak SDK] Add flatpak-run-nightly
2688         https://bugs.webkit.org/show_bug.cgi?id=212882
2689
2690         Reviewed by Carlos Alberto Lopez Perez.
2691
2692         This new script is able to download WPE and GTK builds from the Igalia servers and run the
2693         corresponding binaries (like MiniBrowser, jsc) within the Flatpak SDK.
2694
2695         Unzipped builds will be saved in /tmp and can be reused in further runs (by providing the
2696         path with the -p argument).
2697
2698         Example:
2699         $ webkit-flatpak-run-nightly --wpe MiniBrowser https://webkit.org
2700         <SDK installs to ~/.cache/wk-nightly>
2701         Downloading build release_r262699_b33885.zip from https://wpewebkit-release.igalia.com/built-products/
2702         Extracting build to /tmp/wpewebkit-release-b33885
2703         <MiniBrowser starts>
2704
2705         $ webkit-flatpak-run-nightly --wpe -p /tmp/wpewebkit-release-b33885 jsc
2706         Looking for updates…
2707         Nothing to do.
2708         >>> 2+2
2709         4
2710
2711         * Scripts/webkit-flatpak-run-nightly: Added.
2712
2713 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
2714
2715         [webkitpy] Make 'webkit-path rebaseline' to not update expectations file by default
2716         https://bugs.webkit.org/show_bug.cgi?id=212835
2717
2718         Reviewed by Carlos Alberto Lopez Perez.
2719
2720         `webkit-patch rebaseline` let us add or update a test baseline
2721         from a test bot. By default, the command also updates the
2722         corresponding expectations file. This update is actually a brand-new
2723         generation of an expectations file based on the results of the bot,
2724         which in most cases messes up the current contents of the file.
2725
2726         This patch makes the default to not update the expectations file and
2727         adds a new option '--update-expectations' to explicitly request an
2728         update.
2729
2730         * Scripts/webkitpy/tool/commands/rebaseline.py:
2731         (AbstractRebaseliningCommand):
2732         (RebaselineTest.__init__):
2733         (RebaselineTest._rebaseline_tests):
2734         (RebaselineTest.execute):
2735         (AbstractParallelRebaselineCommand._rebaseline_commands):
2736         (RebaselineExpectations.__init__):
2737         (RebaselineExpectations.execute):
2738         (Rebaseline.__init__):
2739         (RebaselineTest._rebaseline_test_and_update_expectations): Deleted.
2740         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2741         (TestRebaselineTest.setUp):
2742
2743 2020-06-08  Youenn Fablet  <youenn@apple.com>
2744
2745         File URLs with hostnames are misleading
2746         https://bugs.webkit.org/show_bug.cgi?id=212739
2747         <rdar://problem/63754917>
2748
2749         Reviewed by Alex Christensen.
2750
2751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2752         * TestWebKitAPI/Tests/WebKit/open-window-with-file-url-with-host.html: Added.
2753         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2754         (TEST):
2755
2756 2020-06-07  Caio Lima  <ticaiolima@gmail.com>
2757
2758         Allow run-jsc-stress-tests still run if some of the remote hosts are not available
2759         https://bugs.webkit.org/show_bug.cgi?id=201426
2760
2761         Reviewed by Saam Barati.
2762
2763         This patch allows run-jsc-stress-tests to keep on running if some of
2764         the remote hosts are not available. To do this, we created a new
2765         function `checkAndPrepareRemoteHosts` that is responsible to check the
2766         connection and read/write permissions of given remote hosts list. It
2767         filters out every unavailable remote host.
2768         These checks and filter happen in the beginning of the script and is
2769         excuted only once, in the beggining of the script. It means that if
2770         some remote device becomes unavailable after the check and preparation
2771         is done, the script execution will be interupted.
2772
2773         * Scripts/run-jsc-stress-tests:
2774
2775 2020-06-07  Philippe Normand  <pnormand@igalia.com>
2776
2777         Remove ENABLE_VIDEO_TRACK ifdef guards
2778         https://bugs.webkit.org/show_bug.cgi?id=212568
2779
2780         Reviewed by Youenn Fablet.
2781
2782         * Scripts/webkitperl/FeatureList.pm:
2783         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2784
2785 2020-06-06  Simon Fraser  <simon.fraser@apple.com>
2786
2787         Clear WebPageProxy event state between tests
2788         https://bugs.webkit.org/show_bug.cgi?id=212864
2789
2790         Reviewed by Anders Carlsson.
2791
2792         Make sure that event state doesn't leak between tests via events queued in WebPageProxy.
2793
2794         * WebKitTestRunner/TestController.cpp:
2795         (WTR::TestController::resetStateToConsistentValues):
2796
2797 2020-06-06  Peng Liu  <peng.liu6@apple.com>
2798
2799         REGRESSION (r262456): [iOS Debug] TestWebKitAPI.WKWebViewCloseAllMediaPresentations.PictureInPicture is frequently timing out
2800         https://bugs.webkit.org/show_bug.cgi?id=212777
2801
2802         Unreviewed test gardening.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2805         Disable the PictureInPicture test for old iOS devices.
2806
2807 2020-06-05  Ryan Haddad  <ryanhaddad@apple.com>
2808
2809         [iOS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2810         https://bugs.webkit.org/show_bug.cgi?id=208451
2811
2812         Unreviewed test gardening.
2813
2814         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable this test again because it is still failing on certain bots.
2815
2816 2020-06-05  Daniel Bates  <dabates@apple.com>
2817
2818         -_focusTextInputContext should reposition the caret if called for an already focused text input context
2819         https://bugs.webkit.org/show_bug.cgi?id=212830
2820         <rdar://problem/64032956>
2821
2822         Reviewed by Wenson Hsieh.
2823
2824         Re-purpose some existing tests to check for the new behavior.
2825
2826         In TextInteraction_FocusingAssistedElementShouldScrollToReveal, keep in mind that the caret position is
2827         changing: on iOS, calling input.focus() places the caret at the end of the field's content.
2828
2829         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2830         (TestWebKitAPI::TEST):
2831
2832 2020-06-05  Jonathan Bedard  <jbedard@apple.com>
2833
2834         Generalize configure-xcode-for-ios-development (Part 1)
2835         https://bugs.webkit.org/show_bug.cgi?id=207043
2836
2837         Rubber-stamped by David Kilzer.
2838
2839         Patch by Keith Rollin and Jonathan Bedard.
2840
2841         Replace configure-xcode-for-ios-development with a Python script that works for iOS,
2842         watchOS and tvOS.
2843
2844         * Scripts/configure-xcode-for-embedded-development: Added.
2845
2846 2020-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2847
2848         Text manipulation should exclude characters outside of the unicode private use area
2849         https://bugs.webkit.org/show_bug.cgi?id=212800
2850         <rdar://problem/63736417>
2851
2852         Reviewed by Sihui Liu.
2853
2854         Add a new API test to verify the new behavior when extracting PUA characters.
2855
2856         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2857         (TestWebKitAPI::TEST):
2858
2859 2020-06-05  Dean Jackson  <dino@apple.com>
2860
2861         REGRESSION (r262366): [ Mac wk1 ] webgl/webgl-backing-store-size-update.html is failing
2862         https://bugs.webkit.org/show_bug.cgi?id=212647
2863         <rdar://problem/63882960>
2864
2865         Reviewed by Eric Carlson.
2866
2867         Drive-by comment from Simon. Remove some useless braces.
2868
2869         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm:
2870
2871 2020-06-05  Saam Barati  <sbarati@apple.com>
2872
2873         Try to reduce jetsams further on iOS devices running jsc stress tests
2874         https://bugs.webkit.org/show_bug.cgi?id=212786
2875
2876         Reviewed by Mark Lam.
2877
2878         * Scripts/run-jsc-stress-tests:
2879
2880 2020-06-05  Peng Liu  <peng.liu6@apple.com>
2881
2882         REGRESSION (r262456?): [macOS] media/picture-in-picture/picture-in-picture-api tests are flaky timeouts
2883         https://bugs.webkit.org/show_bug.cgi?id=212762
2884
2885         Reviewed by Eric Carlson.
2886
2887         Skip the Picture-in-Picture test if Picture-in-Picture is not supported and add playsinline attribute
2888         to the video element.
2889
2890         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2891         (TEST):
2892
2893 2020-06-05  Andy Estes  <aestes@apple.com>
2894
2895         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
2896         https://bugs.webkit.org/show_bug.cgi?id=212541
2897         <rdar://problem/63781452>
2898
2899         Reviewed by Darin Adler.
2900
2901         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
2902
2903         * Scripts/webkitperl/FeatureList.pm:
2904         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2905
2906 2020-06-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2907
2908         [GTK] MiniBrowser: use GAction API for actions and shortcuts in preparation for GTK4
2909         https://bugs.webkit.org/show_bug.cgi?id=212740
2910
2911         Reviewed by Adrian Perez de Castro.
2912
2913         Make MiniBrowser a GtkApplication and BrowserWindow a GtkApplicationWindow to easily install actions and shortcuts.
2914
2915         * MiniBrowser/gtk/BrowserMain.c: Removed.
2916         * MiniBrowser/gtk/BrowserMain.h: Removed.
2917         * MiniBrowser/gtk/BrowserSearchBar.c:
2918         (searchPreviousButtonCallback):
2919         (searchNextButtonCallback):
2920         * MiniBrowser/gtk/BrowserSearchBar.h:
2921         * MiniBrowser/gtk/BrowserTab.c:
2922         * MiniBrowser/gtk/BrowserTab.h:
2923         * MiniBrowser/gtk/BrowserWindow.c:
2924         (reloadOrStopCallback):
2925         (goBackCallback):
2926         (goForwardCallback):
2927         (settingsCallback):
2928         (browserWindowUpdateNavigationMenu):
2929         (browserWindowTryCloseCurrentWebView):
2930         (browserWindowTryClose):
2931         (webViewCreate):
2932         (browserWindowUpdateZoomActions):
2933         (webViewZoomLevelChanged):
2934         (zoomInCallback):
2935         (zoomOutCallback):
2936         (defaultZoomCallback):
2937         (searchCallback):
2938         (newTabCallback):
2939         (toggleWebInspector):
2940         (openPrivateWindow):
2941         (focusLocationBar):
2942         (reloadPage):
2943         (reloadPageIgnoringCache):
2944         (stopPageLoad):
2945         (loadHomePage):
2946         (toggleFullScreen):
2947         (printPage):
2948         (editingActionCallback):
2949         (typingAttributesChanged):
2950         (browserWindowFinalize):
2951         (browserWindowSetupEditorToolbarItem):
2952         (browserWindowSetupToolbarItem):
2953         (browserWindowDeleteEvent):
2954         (browser_window_new):
2955         (browser_window_append_view):
2956         (browser_window_get_or_create_web_view_for_automation):
2957         (browser_window_create_web_view_in_new_tab_for_automation):
2958         * MiniBrowser/gtk/BrowserWindow.h:
2959         * MiniBrowser/gtk/CMakeLists.txt:
2960         * MiniBrowser/gtk/main.c:
2961         (createWebViewForAutomationInWindowCallback):
2962         (createWebViewForAutomationInTabCallback):
2963         (automationStartedCallback):
2964         (startup):
2965         (activate):
2966         (main):
2967
2968 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
2969
2970         Text manipulation: first and last unit in a paragraph should not contain only excluded tokens
2971         https://bugs.webkit.org/show_bug.cgi?id=212759
2972
2973         Reviewed by Wenson Hsieh.
2974
2975         Modify existing test for changed behavior that leading and trailing excluded units are not included in paragraph
2976         now.
2977
2978         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2979         (TestWebKitAPI::TEST):
2980
2981 2020-06-04  Chris Dumez  <cdumez@apple.com>
2982
2983         UIProcess may crash after its prewarmed WebProcess gets terminated
2984         https://bugs.webkit.org/show_bug.cgi?id=212790
2985         <rdar://problem/63696191>
2986
2987         Reviewed by Geoffrey Garen.
2988
2989         Add API test coverage.
2990
2991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2992         (TEST):
2993
2994 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
2995
2996         REGRESSION: (r262398) Text manipulation crashes when content is added
2997         https://bugs.webkit.org/show_bug.cgi?id=212785
2998
2999         Reviewed by Ryosuke Niwa.
3000
3001         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3002         (TestWebKitAPI::TEST):
3003
3004 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3005
3006         Improve watchlist logic for comments on patches touching imported WPT tests.
3007         https://bugs.webkit.org/show_bug.cgi?id=212597
3008
3009         Reviewed by Youenn Fablet.
3010
3011         On r262295 I added a watchlist comment for patches touching the imported WPT tests.
3012         However, this is commenting on patches that are importing WPT tests.
3013
3014         To avoid this situations, this patch adds a new rule to detect if the changes modify
3015         any of the w3c-import.log files, and then changes the logic to make the comment only
3016         for patches that modify the WPT imported tests but not the w3c-import.log files.
3017
3018         In order to support this new logic, watchlist rule parsing is improved to support
3019         the "and" and "not" operators. Previously it only supported the "or" operator.
3020
3021         * Scripts/webkitpy/common/config/watchlist:
3022         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3023         (WatchListParser._rule_definitions_as_set):
3024         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3025         (WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion):
3026         (WatchListParserTest):
3027         (WatchListParserTest.test_cc_rule_with_complex_logic):
3028         * Scripts/webkitpy/common/watchlist/watchlistrule.py:
3029         (WatchListRule.__init__):
3030         (WatchListRule._match_test_definitions):
3031         (WatchListRule.match):
3032         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
3033         (WatchListRuleTest.test_complex_definition_or):
3034         (WatchListRuleTest):
3035         (WatchListRuleTest.test_complex_definition_and):
3036         (WatchListRuleTest.test_complex_definition_not):
3037         (WatchListRuleTest.test_complex_definition_combined):
3038
3039 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3040
3041         svn-apply command is too slow with big patches
3042         https://bugs.webkit.org/show_bug.cgi?id=212766
3043
3044         Reviewed by Darin Adler.
3045
3046         The script svn-apply was calling a "git add" or "svn add" command
3047         after adding each new file. This caused the git or svn command to
3048         re-check the internal SCM database each time they were called, and
3049         this was really slow when lot of new files are added.
3050         Instead of doing this, we queue the list of new files in memory,
3051         and at the end we call "git add" or "svn add" once (or a few times).
3052
3053         On top of that, another optimization is added for the case of git,
3054         to avoid calling scmKnowsOfFile() inside addDirectoriesIfNeeded(),
3055         which is a slow operation and gets called a lot (once per file).
3056         Doing that for git is totally unneeded, as the only thing we have
3057         to take care about, is of ensuring that the directory is created.
3058         See: https://wkb.ug/86973
3059
3060         This reduces the time spent in the large test patch that caused
3061         this issue (see bug):
3062          - Git: 8 hours (before) -> 8 minutes (now).
3063          - SVN: 25 minutes (before) -> 5 minutes (now).
3064
3065         * Scripts/svn-apply:
3066         (addDirectoriesIfNeeded):
3067         (handleBinaryChange):
3068         (handleGitBinaryChange):
3069         (patch):
3070         (scmRemove):
3071         (scmAddQueued):
3072         (scmCommitQueueAdded):
3073         (scmToggleExecutableBitQueued):
3074         (scmCommitQueueToggledExecutableBit):
3075
3076 2020-06-04  Jonathan Bedard  <jbedard@apple.com>
3077
3078         Add watchOS and tvOS to build-webkit
3079         https://bugs.webkit.org/show_bug.cgi?id=212719
3080         <rdar://problem/63951600>
3081
3082         Reviewed by Tim Horton.
3083
3084         * Scripts/build-webkit: Add tvOS and watchOS flags, generalize embedded if statements.
3085         * Scripts/webkitdirs.pm:
3086         (determineArchitecture): Add tvOS and watchOS architectures.
3087         (argumentsForConfiguration): Add tvOS and watchOS flags.
3088         (extractNonMacOSHostConfiguration): Ditto.
3089
3090 2020-06-04  Tim Horton  <timothy_horton@apple.com>
3091
3092         Work around broken system version macro
3093         https://bugs.webkit.org/show_bug.cgi?id=212726
3094
3095         Reviewed by Dan Bernstein.
3096
3097         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3098         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3099         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3100         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3101         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3102         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3103         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3104         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
3105
3106 2020-06-04  Andy Estes  <aestes@apple.com>
3107
3108         [watchOS] Re-enable content filtering in the simulator build
3109         https://bugs.webkit.org/show_bug.cgi?id=212711
3110         <rdar://problem/63938350>
3111
3112         Reviewed by Wenson Hsieh.
3113
3114         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3115
3116 2020-06-04  Philippe Normand  <pnormand@igalia.com>
3117
3118         [Flatpak SDK] Update definitions
3119         https://bugs.webkit.org/show_bug.cgi?id=212698
3120
3121         Reviewed by Žan Doberšek.
3122
3123         * buildstream/elements/freedesktop-sdk.bst: Update to FDO 19.08.11
3124         * buildstream/elements/sdk/gtk.bst: Update GTK4
3125         * buildstream/patches/fdo/0001-Pango-Bump-to-1.45-master.patch: Added. Needed for GTK4
3126         * buildstream/patches/fdo/0001-Add-Jack.patch: Removed. This will be used when we update to the 20.08 FDO SDK.
3127         * buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Removed. Ditto.
3128         * buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Removed. Ditto.
3129
3130 2020-06-03  Tadeu Zagallo  <tzagallo@apple.com>
3131
3132         Disable B3 hoistLoopInvariantValues by default
3133         https://bugs.webkit.org/show_bug.cgi?id=212511
3134         <rdar://problem/63813245>
3135
3136         Reviewed by Mark Lam.
3137
3138         Enable the B3 hoistLoopInvariantValues pass in one of our existing configurations to
3139         avoid bit rot since we'd like to re-enable it eventually.
3140
3141         * Scripts/run-jsc-stress-tests:
3142
3143 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3144
3145         [Text manipulation] Extract the value attribute in inputs of type "text" and "search"
3146         https://bugs.webkit.org/show_bug.cgi?id=212706
3147         <rdar://problem/63876969>
3148
3149         Reviewed by Tim Horton.
3150
3151         Add a new test case (similar to the existing test `StartTextManipulationExtractsValuesFromButtonInputs`) to
3152         verify that we extract text from the `value` of inputs of type "text" and "search".
3153
3154         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3155         (TestWebKitAPI::TEST):
3156
3157 2020-06-03  Michael Saboff  <msaboff@apple.com>
3158
3159         [iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug simulator builds
3160         https://bugs.webkit.org/show_bug.cgi?id=211650
3161
3162         Reviewed by Saam Barati.
3163
3164         The prior change to disable this test for Debug actually enabled it
3165         only for Debug IOS builds of any type, simulator or real HW.
3166
3167         This test has intermittently failed or timed out on Debug simulator
3168         builds for for almost a year.  We want to test Release builds as well as
3169         hardware builds. Therefore we should disable Debug simulator builds,
3170         and test all other variants.
3171
3172         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3173
3174 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3175
3176         dataTransfer.types is empty when handling the "dragstart" event
3177         https://bugs.webkit.org/show_bug.cgi?id=212685
3178         <rdar://problem/61368402>
3179
3180         Reviewed by Andy Estes.
3181
3182         Adds new API tests and test infrastructure to verify that DataTransfer types and data are accessible during
3183         the "dragstart" event. See below for more details.
3184
3185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3186         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3187         (-[TestWKWebView selectElementWithID:]):
3188         (-[DragAndDropSimulator dragFromElementWithID:to:]):
3189
3190         Add a few (very specialized) helper methods to assist with simulating drags over the various elements in the new
3191         drag and drop test harness page below (dragstart-data.html).
3192
3193         (runDragStartDataTestCase):
3194
3195         Test the following scenarios (split between three API tests) by dumping the resulting DataTransfer types and
3196         their data strings, and observing the results:
3197
3198         - Dragging a normal text selection.
3199         - Dragging a normal text selection, and then adding a URL string.
3200         - Dragging a normal text selection, and then adding a custom pasteboard type.
3201         - Dragging a normal text selection, but then replacing the data with just a URL string.
3202         - Dragging a normal text selection, but then replacing the data with just a custom data type.
3203         - Dragging an image element.
3204         - Dragging an image element, and then overriding the plain text data.
3205         - Dragging a link (anchor element).
3206         - Dragging a link, and then adding a custom type.
3207
3208         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-data.html: Added.
3209
3210         Add a new test harness to help test DataTransfer types when starting a drag. This test page can also be used as
3211         a manual test harness, by simply opening the test page, starting drags on the various elements and observing the
3212         output in the textarea.
3213
3214         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
3215
3216         Tweak this test page to replace the DataTransfer with custom data (rather than simply append it) by calling
3217         `DataTransfer.clearData()` prior to writing the custom types.
3218
3219         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3220         * TestWebKitAPI/cocoa/TestWKWebView.h:
3221         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3222         (-[TestWKWebViewHostWindow initWithWebView:contentRect:styleMask:backing:defer:]):
3223
3224         Add a `__weak` reference on TestWKWebViewHostWindow back to the TestWKWebView, so that we can consult
3225         `-eventTimestamp` when synthesizing mouse events on macOS during API tests.
3226
3227         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
3228         (-[TestWKWebViewHostWindow _mouseUpAtPoint:clickCount:]):
3229         (-[TestWKWebViewHostWindow initWithWebView:frame:]):
3230         (-[TestWKWebView _setUpTestWindow:]):
3231         (-[TestWKWebView setEventTimestampOffset:]):
3232         (-[TestWKWebView eventTimestamp]):
3233
3234         Add a mechanism to offset synthetic event timestamps by a given time interval (i.e. the event timestamp offset).
3235
3236         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
3237         (-[TestWKWebView _mouseEventWithType:atLocation:]):
3238         (-[TestWKWebView typeCharacter:]):
3239         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3240         (-[DragAndDropSimulator runFrom:to:]):
3241
3242         While simulating drag and drop on macOS, use `-setEventTimestampOffset:` to "leap forward" in time, so that the
3243         150 millisecond delay when dragging a text selection doesn't prevent drags from beginning.
3244
3245 2020-06-03  Sihui Liu  <sihui_liu@apple.com>
3246
3247         Text manipulation sometimes fails to replace text in attributes
3248         https://bugs.webkit.org/show_bug.cgi?id=212701
3249
3250         Reviewed by Wenson Hsieh.
3251
3252         Modify TextManipulation.CompleteTextManipulationShouldReplaceTextContentWithMultipleTokens to cover text 
3253         manipulation for attributes.
3254
3255         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3256         (TestWebKitAPI::TEST):
3257
3258 2020-06-03  Diego Pino Garcia  <dpino@igalia.com>
3259
3260         [WPE] lint-test-expectations doesn't work when platform is WPE
3261         https://bugs.webkit.org/show_bug.cgi?id=212700
3262
3263         Reviewed by Carlos Alberto Lopez Perez.
3264
3265         When passing arguments '--wpe' or '--platform=wpe*',
3266         lint-test-expectations does nothing for WPE, despite currently 
3267         there are many lint errors in WPE's TestExpectations file.
3268
3269         As a side-effect of this patch, now `Tools/Scripts/webkit-path
3270         rebaseline` lists the WPE Release and Debug bots.
3271
3272         * Scripts/webkitpy/port/builders.py: Add WPE to the list of
3273         exact_matches and fuzzy_matches.
3274         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3275
3276 2020-06-03  Jonathan Bedard  <jbedard@apple.com>
3277
3278         Allow using web processes for service workers even though they loaded about URLs (Follow-up fix)
3279         https://bugs.webkit.org/show_bug.cgi?id=212464
3280
3281         Unreviewed build fix.
3282
3283         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: didFinishNavigation is now used unconditionally.
3284
3285 2020-06-02  Keith Rollin  <krollin@apple.com>
3286
3287         Revert FEATURES_DEFINES related changes
3288         https://bugs.webkit.org/show_bug.cgi?id=212664
3289         <rdar://problem/63893033>
3290
3291         Reviewed by Andy Estes.
3292
3293         Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to
3294         FEATURE_DEFINES and how the values there relate to those found in the
3295         Platform*.h files. Those changes break XCBuild (by removing the
3296         .xcfilelist related to UnifiedSources and the process for generating
3297         them), and so are being reverted.
3298
3299         * Scripts/webkitperl/FeatureList.pm:
3300         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3301         (WebCoreGenerator):
3302         (WebCoreGenerator._get_generate_unified_sources_script):
3303         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3304
3305 2020-06-02  Peng Liu  <peng.liu6@apple.com>
3306
3307         Stressing webkitSetPresentationMode leads to wrong inline video dimensions
3308         https://bugs.webkit.org/show_bug.cgi?id=202425
3309
3310         Reviewed by Eric Carlson.
3311
3312         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3313         (TEST):
3314
3315 2020-06-02  Youenn Fablet  <youenn@apple.com>
3316
3317         Allow using web processes for service workers even though they loaded about URLs
3318         https://bugs.webkit.org/show_bug.cgi?id=212464
3319
3320         Reviewed by Chris Dumez.
3321
3322         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3323
3324 2020-06-02  Diego Pino Garcia  <dpino@igalia.com>
3325
3326         [buildbot] [GTK][WPE] Move JavaScript related tests to own bot
3327         https://bugs.webkit.org/show_bug.cgi?id=212481
3328
3329         Reviewed by Carlos Alberto Lopez Perez.
3330
3331         Currently GTK and WPE tests bots run too many tests. This makes
3332         the total running time for each build very long.
3333
3334         This patch moves JavaScript related tests (jscore-test and
3335         test262-test) to a separated bot which will be triggered by the
3336         corresponding build bot of each platform.
3337
3338         * BuildSlaveSupport/build.webkit.org-config/config.json:
3339         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3340         (TestFactory.__init__):
3341         (TestJSFactory):
3342         (TestJSFactory.__init__):
3343         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3344
3345 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3346
3347         [GTK4] Make popup menus work
3348         https://bugs.webkit.org/show_bug.cgi?id=211178
3349
3350         Reviewed by Adrian Perez de Castro.
3351
3352         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3353         (WTR::PlatformWebView::dismissAllPopupMenus):
3354
3355 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3356
3357         [GTK4] Make it possible to run layout tests
3358         https://bugs.webkit.org/show_bug.cgi?id=212328
3359
3360         Reviewed by Carlos Alberto Lopez Perez.
3361
3362         Build WTR with GTK4.
3363
3364         * PlatformGTK.cmake:
3365         * Scripts/webkitdirs.pm:
3366         (builtDylibPathForName): Try with both 4 and 5 API versions.
3367         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3368         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3369         (WTR::PlatformWebView::PlatformWebView):
3370         (WTR::PlatformWebView::~PlatformWebView):
3371         (WTR::PlatformWebView::setWindowIsKey):
3372         (WTR::PlatformWebView::windowFrame):
3373         (WTR::PlatformWebView::setWindowFrame):
3374         (WTR::PlatformWebView::addToWindow):
3375         (WTR::PlatformWebView::removeFromWindow):
3376         (WTR::PlatformWebView::windowSnapshotImage):
3377         (WTR::PlatformWebView::dismissAllPopupMenus):
3378         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3379         (WTR::UIScriptControllerGtk::copyText):
3380
3381 2020-06-01  Noam Rosenthal  <noam@webkit.org>
3382
3383         Make unicode-bidi:isolate the default for an element with a dir attribute (instead of unicode-bidi:embed)
3384         https://bugs.webkit.org/show_bug.cgi?id=134630
3385
3386         Reviewed by Simon Fraser.
3387
3388         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
3389         (TEST):
3390                 Test was expecting unicode-bidi:embed, changed expectation.
3391
3392 2020-06-01  Sihui Liu  <sihui_liu@apple.com>
3393
3394         TextManipulationController should put one Node in only one paragraph
3395         https://bugs.webkit.org/show_bug.cgi?id=212548
3396
3397         Reviewed by Wenson Hsieh.
3398
3399         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3400         (TestWebKitAPI::TEST):
3401
3402 2020-06-01  Alex Christensen  <achristensen@webkit.org>
3403
3404         Make CustomDisplayName and DefaultDisplayName API tests fail instead of timing out when something changes
3405         https://bugs.webkit.org/show_bug.cgi?id=212480
3406
3407         This saves time when debugging and running all the tests.
3408
3409         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
3410         (TestWebKitAPI::checkUntilDisplayNameIs):
3411
3412 2020-06-01  Philippe Normand  <pnormand@igalia.com>
3413
3414         [Flatpak SDK] Install and update don't provide any terminal output
3415         https://bugs.webkit.org/show_bug.cgi?id=212579
3416
3417         Reviewed by Žan Doberšek.
3418
3419         The `show_output` option was removed from the process execution routines. We now assume the
3420         output will be displayed, unless the call-site asks `gather_output`. This change makes
3421         webkit-flatpak more chatty, which is nice during install/update operations.
3422
3423         * flatpak/flatpakutils.py:
3424         (run_sanitized):
3425         (FlatpakObject.flatpak):
3426         (FlatpakPackage.install):
3427         (FlatpakPackage.update):
3428         (WebkitFlatpak.setup_builddir):
3429         (WebkitFlatpak.run_in_sandbox):
3430
3431 2020-06-01  Chris Dumez  <cdumez@apple.com>
3432
3433         ASSERTION FAILURE (r220931): !m_function in ~CompletionHandler() after switch tabs
3434         https://bugs.webkit.org/show_bug.cgi?id=212537
3435         <rdar://problem/63766838>
3436
3437         Reviewed by Alex Christensen.
3438
3439         Add API test coverage.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspension.mm: Added.
3443         (TEST):
3444
3445 2020-06-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3446
3447         [EWS] Add a special case for running the layout test step without aborting in case of many failures for WPT tests
3448         https://bugs.webkit.org/show_bug.cgi?id=212381
3449
3450         Reviewed by Jonathan Bedard.
3451
3452         Add a special case for patches uploaded by the bugzilla user that would be used
3453         for prototyping a bot that helps automating the import of WPT tests. For patches
3454         uploaded by this user don't pass the parameters that make the step abort early in
3455         case of many errors, and only run the layout tests inside the WPT import directory.
3456
3457         * BuildSlaveSupport/ews-build/steps.py:
3458         (RunWebKitTests):
3459         (RunWebKitTests.start):
3460         * BuildSlaveSupport/ews-build/steps_unittest.py:
3461         (test_success):
3462         (test_warnings):
3463         (test_parse_results_json_regression):
3464         (test_parse_results_json_flakes):
3465         (test_parse_results_json_flakes_and_regressions):
3466         (test_parse_results_json_with_newlines):
3467         (test_unexpected_error):
3468         (test_failure):
3469         (test_success_wpt_import_bot):
3470         (TestRunWebKitTestsWithoutPatch.test_success):
3471         (TestRunWebKitTestsWithoutPatch.test_failure):
3472         (TestRunWebKit1Tests.test_success):
3473         (TestRunWebKit1Tests.test_failure):
3474
3475 2020-06-01  Sam Weinig  <weinig@apple.com>
3476
3477         Extended Color: Replace Color constructors taking numeric values with type specific factory functions
3478         https://bugs.webkit.org/show_bug.cgi?id=212576
3479
3480         Reviewed by Tim Horton.
3481
3482         Replaces all remaining implicit and explicit uses of the Color constructors taking numeric
3483         values with explicit calls to makeSimpleColor/makeSimpleColorFromFloats/makeExtendedColor,
3484         giving us a consistent way to create colors. Also addes use constexpr SimpleColors where possible.
3485
3486         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
3487         (TestWebKitAPI::TEST):
3488         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3489         (TestWebKitAPI::TEST):
3490         (TestWebKitAPI::makeColor):
3491         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
3492         (TestWebKitAPI::TEST):
3493         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
3494         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
3495
3496 2020-05-31  Dean Jackson  <dino@apple.com>
3497
3498         AutoTrader crashed while browsing search results
3499         https://bugs.webkit.org/show_bug.cgi?id=212461
3500         rdar://60733185
3501
3502         Reviewed by Sam Weinig.
3503
3504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3505         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm: Added.
3506         (-[WebGLPrepareDisplayOnWebThreadDelegate webViewDidFinishLoad:]):
3507         (-[WebGLPrepareDisplayOnWebThreadDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3508         (TestWebKitAPI::TEST):
3509         * TestWebKitAPI/Tests/WebKitLegacy/ios/webgl.html: Added.
3510
3511 2020-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3512
3513         Unreviewed. Fix GTK4 build with current GTK
3514
3515         * MiniBrowser/gtk/BrowserTab.c:
3516         (audioMutedChanged):
3517
3518 2020-05-30  Sam Weinig  <weinig@apple.com>
3519
3520         Extended Color: Additional color cleanups
3521         https://bugs.webkit.org/show_bug.cgi?id=212567
3522
3523         Reviewed by Simon Fraser.
3524
3525         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3526         (TestWebKitAPI::TEST):
3527         Update for rename from ExtendedColor::channels() to ExtendedColor::components()
3528
3529 2020-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3530
3531         [GTK] WebDriver: stop using GdkEvent API in preparation for GTK4
3532         https://bugs.webkit.org/show_bug.cgi?id=212465
3533
3534         Reviewed by Adrian Perez de Castro.
3535
3536         Update to the new webkitWebViewBaseSynthesizeKeyEvent() API.
3537
3538         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3539         (WTR::EventSenderProxy::keyDown):
3540
3541 2020-05-29  Alex Christensen  <achristensen@webkit.org>
3542
3543         Use correct encoding when converting a WTF::URL to CFURLRef
3544         https://bugs.webkit.org/show_bug.cgi?id=212486
3545
3546         Reviewed by Darin Adler.
3547
3548         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3549         (TestWebKitAPI::TEST):
3550
3551 2020-05-29  Andy Estes  <aestes@apple.com>
3552
3553         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
3554         https://bugs.webkit.org/show_bug.cgi?id=212541
3555
3556         Reviewed by Darin Adler.
3557
3558         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
3559
3560         * Scripts/webkitperl/FeatureList.pm:
3561         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3562
3563 2020-05-29  Jan-Michael Brummer  <jan.brummer@tabos.org>
3564
3565         [GTK][WPE] API for WebView audio mute support
3566         https://bugs.webkit.org/show_bug.cgi?id=176119
3567
3568         Reviewed by Michael Catanzaro.
3569
3570         * MiniBrowser/gtk/BrowserTab.c:
3571         (audioClicked):
3572         (audioMutedChanged):
3573         (browserTabConstructed):
3574         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3575         (testWebViewIsAudioMuted):
3576         (beforeAll):
3577
3578 2020-05-29  Darin Adler  <darin@apple.com>
3579
3580         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
3581         https://bugs.webkit.org/show_bug.cgi?id=212418
3582
3583         Rubber-stamped by Simon Fraser.
3584
3585         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add back ENABLE_CSS_CONIC_GRADIENTS,
3586         removed by accident.
3587
3588 2020-05-29  Pavel  <pavel.feldman@gmail.com>
3589
3590         [Win] Allow compiling with the TOUCH_EVENTS enabled
3591         https://bugs.webkit.org/show_bug.cgi?id=212528
3592
3593         Reviewed by Fujii Hironori.
3594
3595         Aligning Win with GTK, adding missing EventSenderProxy stubs.
3596         This allows compiling Win with TOUCH_EVENTS and unlocks event
3597         injection / processing by the automation drivers
3598
3599         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3600         (WTR::EventSenderProxy::addTouchPoint):
3601         (WTR::EventSenderProxy::updateTouchPoint):
3602         (WTR::EventSenderProxy::setTouchModifier):
3603         (WTR::EventSenderProxy::setTouchPointRadius):
3604         (WTR::EventSenderProxy::touchStart):
3605         (WTR::EventSenderProxy::touchMove):
3606         (WTR::EventSenderProxy::touchEnd):
3607         (WTR::EventSenderProxy::touchCancel):
3608         (WTR::EventSenderProxy::clearTouchPoints):
3609         (WTR::EventSenderProxy::releaseTouchPoint):
3610         (WTR::EventSenderProxy::cancelTouchPoint):
3611
3612 2020-05-27  Darin Adler  <darin@apple.com>
3613
3614         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
3615         https://bugs.webkit.org/show_bug.cgi?id=212418
3616
3617         Reviewed by Andy Estes.
3618
3619         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Removed 83 of the 119 things
3620         defined in this file. There are 36 more that are slightly more complex that we can
3621         remove carefully later.
3622
3623 2020-05-29  Darin Adler  <darin@apple.com>
3624
3625         Make generate-unified-sources.sh not depend on features being listed in FEATURE_DEFINES environment variable
3626         https://bugs.webkit.org/show_bug.cgi?id=212420
3627
3628         Reviewed by Andy Estes.
3629
3630         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3631         (WebCoreGenerator._get_generate_derived_sources_script): Removed the code
3632         to generate UnifiedSources-output.xcfilelist.
3633
3634 2020-05-29  Keith Rollin  <krollin@apple.com>
3635
3636         Revert switch to XCBuild
3637         https://bugs.webkit.org/show_bug.cgi?id=212530
3638         <rdar://problem/63764632>
3639
3640         Unreviewed build fix.
3641
3642         Bug 209890 enabled the use of XCBuild by default. Since then, some
3643         build issues have shown up. While addressing them, temporarily turn
3644         off the use of XCBuild by default.
3645
3646         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3647         * Scripts/build-webkit:
3648         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3649
3650 2020-05-29  Philippe Normand  <pnormand@igalia.com>
3651
3652         [Flatpak][GStreamer] all commands, except webkit-build, fails if GST_BUILD_PATH is set
3653         https://bugs.webkit.org/show_bug.cgi?id=212408
3654
3655         Reviewed by Žan Doberšek.
3656
3657         Don't run gst-env.py in the sandbox because that can lead to command-line options clashing
3658         with build-webkit and other WebKit scripts. So instead we now parse the output of the
3659         environment variables gst-build requires and we forward those to the sandbox.
3660
3661         * flatpak/flatpakutils.py:
3662         (run_sanitized):
3663         (check_flatpak):
3664         (FlatpakObject.flatpak):
3665         (WebkitFlatpak.execute_command):
3666         (WebkitFlatpak.setup_gstbuild):
3667         (WebkitFlatpak.run_in_sandbox):
3668         (flatpak_run_sanitized): Deleted.
3669
3670 2020-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3671
3672         Add watchlist comment for patches touching imported WPT tests.
3673         https://bugs.webkit.org/show_bug.cgi?id=212362
3674
3675         Reviewed by Youenn Fablet.
3676
3677         Add a watchlist trigger to comment on patches touching imported WPT tests
3678         with a link to documentation about the export process.
3679
3680         * Scripts/webkitpy/common/config/watchlist:
3681
3682 2020-05-29  Lauro Moura  <lmoura@igalia.com>
3683
3684         [Flatpak] Fix os.system return code for better signal handling.
3685
3686         Rubber-stamped by Philippe Normand.
3687
3688         The previous fix in r262270 correctly fixed the return code issue
3689         but made signal handling pass through python. For example, when you
3690         ctlr+C running MiniBrowser, you'd get a python stacktrace deep inside
3691         subprocess.call.
3692
3693         So, revert back to os.system but fixing the return code.
3694
3695         * flatpak/webkit-bwrap:
3696
3697 2020-05-29  Philippe Normand  <pnormand@igalia.com>
3698
3699         [Flatpak SDK] Update OpenXR
3700         https://bugs.webkit.org/show_bug.cgi?id=212518
3701
3702         Reviewed by Žan Doberšek.
3703
3704         Upstream now builds fine with GCC 9.3.0. Removing downstream patch.
3705         
3706         * buildstream/elements/sdk/openxr.bst:
3707         * buildstream/patches/openxr-0001-cmake-Check-for-C-17-and-conditionally-enable-it.patch: Removed.
3708
3709 2020-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3710
3711         REGRESSION (r261812): editing/async-clipboard/clipboard-item-get-type-basic.html is flaky
3712         https://bugs.webkit.org/show_bug.cgi?id=212281
3713         <rdar://problem/63554912>
3714
3715         Reviewed by Tim Horton.
3716
3717         On some shipping versions of iOS, returning `NO` from `-supportsImagePaste` still results in UIKit keyboard
3718         code pinning temporary items to the general pasteboard, which increments the change count of the pasteboard.
3719         If this happens in the middle of an attempt to read from the pasteboard, we end up falsely denying access to the
3720         contents of the pasteboard, since we believe that the contents of the pasteboard have changed.
3721
3722         This has the potential to affect any test that attempts to read from the pasteboard on iOS, though the titular
3723         layout test seems to trigger the bug more frequently than other tests.
3724
3725         This item pinning was added in support of being able to insert Memojis from the software keyboard, and works by
3726         pretending to copy a temporary PNG image, asking the delegate whether it `-canPerformAction:withSender:`, and
3727         then restoring the items previously on the pasteboard. To work around this in the test runner, we can simply
3728         swizzle out `-[UIKeyboardImpl delegateSupportsImagePaste]` to always return `NO`, which has the same effect as
3729         disabling the Memoji keyboard.
3730
3731         * WebKitTestRunner/TestController.h:
3732         * WebKitTestRunner/ios/TestControllerIOS.mm:
3733         (overrideKeyboardDelegateSupportsImagePaste):
3734         (WTR::TestController::platformResetStateToConsistentValues):
3735
3736 2020-05-28  Myles C. Maxfield  <mmaxfield@apple.com>
3737
3738         Make fast/text/user-installed-fonts/extended-character.html more robust
3739         https://bugs.webkit.org/show_bug.cgi?id=212487
3740         <rdar://problem/63235370>
3741
3742         Unreviewed.
3743
3744         Update the font to use the new character.
3745
3746         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf:
3747
3748 2020-05-28  Lauro Moura  <lmoura@igalia.com>
3749
3750         [Flatpak] Use subprocess.call instead of os.system to forward the return code correctly.
3751
3752         os.system reports error codes from the child process like wait(),
3753         which seems to not be playing well with flatpak/bwrap.
3754
3755         This was causing flatpak to return 0 to some failed commands (like
3756         build-webkit), making failures show as successes in the bots.
3757
3758         Unreviewed build fix.
3759
3760         * flatpak/webkit-bwrap:
3761
3762 2020-05-28  Tim Horton  <timothy_horton@apple.com>
3763
3764         makeValueRefForValue should be robust against the type encoding of a NSNumber backed by a boolean
3765         https://bugs.webkit.org/show_bug.cgi?id=212456
3766
3767         Reviewed by Anders Carlsson.
3768
3769         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
3770         (WTR::makeValueRefForValue):
3771         Apply the fix from r260515 to this second copy of the code too.
3772
3773 2020-05-27  Saam Barati  <sbarati@apple.com>
3774
3775         revert logging for detecting failures in run-jsc-stress-tests
3776         https://bugs.webkit.org/show_bug.cgi?id=212447
3777
3778         Reviewed by Alexey Proskuryakov.
3779
3780         * Scripts/run-jsc-stress-tests:
3781
3782 2020-05-27  Tim Horton  <timothy_horton@apple.com>
3783
3784         REGRESSION (PSON): Resizing WKWebView during cross-site navigation results in the page laying out at the wrong size
3785         https://bugs.webkit.org/show_bug.cgi?id=212434
3786         <rdar://problem/51621621>
3787
3788         Reviewed by Chris Dumez.
3789
3790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3791         Add a test ensuring that we correctly update the view size if it changes
3792         during the provisional phase of the navigation.
3793
3794 2020-05-27  Lauro Moura  <lmoura@igalia.com>
3795
3796         Unreviewed. A couple transformations missing from r262214.
3797
3798         Was making fast/events/touch/tap-highlight-color.html to fail.
3799
3800         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3801         (WTR::EventSenderProxy::keyDown):
3802         (WTR::EventSenderProxy::addTouchPoint):
3803
3804 2020-05-27  Kenneth Russell  <kbr@chromium.org>
3805
3806         Update MobileMiniBrowser project settings to current Xcode
3807         https://bugs.webkit.org/show_bug.cgi?id=212428
3808
3809         Reviewed by Dean Jackson.
3810
3811         Apply suggestions from Dean to automatically switch between the
3812         internal and public SDKs.
3813
3814         * MobileMiniBrowser/Configurations/Base.xcconfig:
3815
3816 2020-05-27  Lauro Moura  <lmoura@igalia.com>
3817
3818         [WPE] Avoid possible WTR event timing going back in time and fix conversion from s to ms
3819         https://bugs.webkit.org/show_bug.cgi?id=212338
3820
3821         Reviewed by Michael Catanzaro.
3822
3823         Make sure we cast the double m_time timestamp from seconds to uint32_t
3824         milliseconds expected by WPE input events.
3825
3826         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3827         (WTR::secToMsTimestamp):
3828         (WTR::EventSenderProxy::EventSenderProxy): Use monotonic time instead
3829         of zero as the time origin. This is used only in a relative manner,
3830         and we need monotonic behavior so conversion to DOM event timestamps
3831         makes sense.
3832         (WTR::EventSenderProxy::mouseDown):
3833         (WTR::EventSenderProxy::mouseUp):
3834         (WTR::EventSenderProxy::mouseMoveTo):
3835         (WTR::EventSenderProxy::mouseScrollBy):
3836         (WTR::EventSenderProxy::updateTouchPoint):
3837         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3838         (WTR::EventSenderProxy::releaseTouchPoint):
3839
3840 2020-05-27  Kate Cheney  <katherine_cheney@apple.com>
3841
3842         Make sure bundle identifier testing override is set in the network process
3843         https://bugs.webkit.org/show_bug.cgi?id=212288
3844         <rdar://problem/63539061>
3845
3846         Reviewed by Chris Dumez.
3847
3848         Set the bundle identifier in the network process if a layout test
3849         updates it. This value usually only gets updated when a new network
3850         process is initialized, which does not happen for every test. So it
3851         should be set/cleared as needed.
3852
3853         * WebKitTestRunner/TestController.cpp:
3854         (WTR::TestController::createWebViewWithOptions):
3855         (WTR::TestController::updateBundleIdentifierInNetworkProcess):
3856         * WebKitTestRunner/TestController.h:
3857
3858 2020-05-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3859
3860         [Clipboard API] Support reading "image/png" on ClipboardItem
3861         https://bugs.webkit.org/show_bug.cgi?id=212339
3862         <rdar://problem/63588957>
3863
3864         Reviewed by Tim Horton.
3865
3866         Add a new API test to verify that TIFF images on the system pasteboard on macOS are automatically converted to
3867         PNG data, and is accessible through `ClipboardItem` through the "image/png" type.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
3870
3871 2020-05-27  Per Arne Vollan  <pvollan@apple.com>
3872
3873         Unreviewed, reverting r260840.
3874
3875         This patch is no longer needed after preferences root cause
3876         has been fixed.
3877
3878         Reverted changeset:
3879
3880         "[Cocoa] Global preferences are not accessible in the
3881         WebContent process when CFPrefs direct mode is enabled"
3882         https://bugs.webkit.org/show_bug.cgi?id=211075
3883         https://trac.webkit.org/changeset/260840
3884
3885 2020-05-27  Devin Rousso  <drousso@apple.com>
3886
3887         Web Inspector: replace `featureGuard` and `availability` with a combined `condition` that accepts any macro
3888         https://bugs.webkit.org/show_bug.cgi?id=210014
3889
3890         Reviewed by Brian Burg.
3891
3892         Previously, the generated InspectorBackendCommands.js would include code for things that the
3893         backend doesn't actually support. By using actual macros and preprocessing that file, we can
3894         ensure that the frontend doesn't incorrectly think that something is supported by the page
3895         being inspected:
3896          - the `Canvas` commands and events related to shader programs/pipelines should only exist
3897            when the corresponding context type exists, namely `ENABLE(WEBGL)` and `ENABLE(WEBGPU)`.
3898          - iOS doesn't support showing rulers, so create a variant of `DOM.setInspectModeEnabled`
3899            that only exists for `PLATFORM(IOS_FAMILY)` that doesn't have the `showRulers` optional
3900            parameter, as well as removing `Page.setShowRulers` entirely.
3901          - setting the forced appearance should only be possible if dark mode is supported.
3902          - web archives only exist if CF is used.
3903
3904         * Configurations/FeatureDefines.xcconfig:
3905         Add `ENABLE_WEB_ARCHIVE` since it's always enabled in wtf/PlatformEnableCocoa.h.
3906
3907         * Scripts/webkitpy/inspector/main.py:
3908         (InspectorGeneratorTests.generate_from_json):
3909         (InspectorGeneratorTests.run_tests):
3910         (InspectorGeneratorTests.main):
3911
3912 2020-05-27  Philippe Normand  <pnormand@igalia.com>
3913
3914         [Flatpak SDK] Update openxr recipe
3915         https://bugs.webkit.org/show_bug.cgi?id=212403
3916
3917         Reviewed by Sergio Villar Senin.
3918
3919         * buildstream/elements/sdk/openxr.bst: Explicitely list dependencies and bump to latest git master.
3920
3921 2020-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3922
3923         [GTK][WTR] EventSender: stop using GdkEvent API in preparation for GTK4
3924         https://bugs.webkit.org/show_bug.cgi?id=212298
3925
3926         Reviewed by Adrian Perez de Castro.
3927
3928         Use WebKitWebViewBase internal API to synthesize events instead of GdkEvents. The touch events support has been
3929         removed because we are no longer testing touch events, since they need an actual touchscreen.
3930
3931         * WebKitTestRunner/EventSenderProxy.h:
3932         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3933         (WTR::getGDKKeySymForKeyRef):
3934         (WTR::toWebKitGLibAPI):
3935         (WTR::EventSenderProxy::keyDown):
3936         (WTR::EventSenderProxy::mouseDown):
3937         (WTR::EventSenderProxy::mouseUp):
3938         (WTR::EventSenderProxy::mouseMoveTo):
3939         (WTR::EventSenderProxy::mouseScrollBy):
3940         (WTR::EventSenderProxy::continuousMouseScrollBy):
3941         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3942         (WTR::EventSenderProxy::leapForward):
3943         (WTR::EventSenderProxy::addTouchPoint):
3944         (WTR::EventSenderProxy::updateTouchPoint):
3945         (WTR::EventSenderProxy::touchStart):
3946         (WTR::EventSenderProxy::touchMove):
3947         (WTR::EventSenderProxy::touchEnd):
3948         (WTR::EventSenderProxy::touchCancel):
3949         (WTR::EventSenderProxy::clearTouchPoints):
3950         (WTR::EventSenderProxy::releaseTouchPoint):
3951         (WTR::EventSenderProxy::cancelTouchPoint):
3952         (WTR::EventSenderProxy::setTouchPointRadius):
3953         (WTR::EventSenderProxy::setTouchModifier):
3954
3955 2020-05-26  Alex Christensen  <achristensen@webkit.org>
3956
3957         UTF-8 encode strings of invalid URLs when converting WTF::URL to NSURL instead of truncating the UTF-16 encoding
3958         https://bugs.webkit.org/show_bug.cgi?id=212393
3959         <rdar://problem/63095503>
3960
3961         Reviewed by Tim Horton.
3962
3963         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3964         (TestWebKitAPI::TEST):
3965
3966 2020-05-26  Mark Lam  <mark.lam@apple.com>
3967
3968         Enhance Bitmap::setEachNthBit() to also take an end index.
3969         https://bugs.webkit.org/show_bug.cgi?id=212386
3970         <rdar://problem/63643324>
3971
3972         Reviewed by Robin Morisset.
3973
3974         * TestWebKitAPI/Tests/WTF/Bitmap.cpp:
3975         (TestWebKitAPI::testBitmapSetEachNthBitImpl):
3976
3977 2020-05-26  Fujii Hironori  <Hironori.Fujii@sony.com>
3978
3979         [WinCairo][WK2] Use GraphicsLayerTextureMapper for Accelerated Compositing mode
3980         https://bugs.webkit.org/show_bug.cgi?id=211883
3981
3982         Reviewed by Don Olmstead.
3983
3984         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3985         (WebKitBrowserWindow::setPreference): Call WKPreferencesSet* for
3986         menu items IDM_ACC_COMPOSITING, IDM_COMPOSITING_BORDERS and
3987         IDM_DEBUG_INFO_LAYER.
3988
3989 2020-05-26  Sam Weinig  <weinig@apple.com>
3990
3991         Extended Color Cleanup: Remove red()/green()/blue() accessors from ExtendedColor in preperation for supporting non-RGB based ColorSpaces
3992         https://bugs.webkit.org/show_bug.cgi?id=212366
3993
3994         Reviewed by Simon Fraser.
3995
3996         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3997         (TestWebKitAPI::TEST):
3998         Update tests to pull values from the channels rather than from the red()/green()/blue() accessors.
3999
4000 2020-05-26  Peng Liu  <peng.liu6@apple.com>
4001
4002         ASSERTION FAILED: m_clientCounts.contains(contextId) - WebKit::VideoFullscreenManagerProxy::removeClientForContext()
4003         https://bugs.webkit.org/show_bug.cgi?id=212308
4004
4005         Disable TestWebKitAPI.PictureInPicture.ExitPiPOnSuspendVideoElement for old iOS versions
4006         due to an issue of AVKit.
4007
4008         In addition, don't run the test if Picture-in-Picture is not supported.
4009
4010         Reviewed by Jer Noble.
4011
4012         * TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm:
4013         (TestWebKitAPI::TEST):
4014
4015 2020-05-26  Keith Rollin  <krollin@apple.com>
4016
4017         Enable the use of XCBuild by default in Apple builds
4018         https://bugs.webkit.org/show_bug.cgi?id=209890
4019         <rdar://problem/44182078>
4020
4021         Reviewed by Darin Adler.
4022
4023         Switch from the "legacy" Xcode build system to the "new" build system
4024         (also known as "XCBuild"). Switching to the new system speeds up
4025         builds by a small percentage, better validates projects for
4026         build-related issues (such as dependency cycles), lets WebKit benefit
4027         from future improvements in XCBuild such as those coming from the
4028         underlying llbuild open source project, and prepares us for any other
4029         tools built for this new ecosystem.
4030
4031         Specific changes:
4032
4033         - Remove Xcode project and workspace settings that selected the Build
4034           system, allowing the default to take hold (which is currently the
4035           New build system).
4036         - Updated webkitdirs.pm with a terser check for Xcode version.
4037         - Update build-webkit and Makefile.shared to be explicit when using
4038           the old build system (no longer treat it as a default or fall-back
4039           configuration).
4040         - Update various xcconfig files similarly to treat the default as
4041           using the new build system.
4042         - Update various post-processing build steps to check for Xcode 11.4
4043           and to no longer treat the default as using the old build system.
4044
4045         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4046         * Scripts/build-webkit:
4047         * Scripts/webkitdirs.pm:
4048         (canUseXCBuild):
4049         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4050
4051 2020-05-26  Jonathan Bedard  <jbedard@apple.com>
4052
4053         webkitpy: simctl list may have stderr logging
4054         https://bugs.webkit.org/show_bug.cgi?id=212376
4055         <rdar://problem/63517635>
4056
4057         Unreviewed infrastructure fix.
4058
4059         * Scripts/webkitpy/xcode/simulated_device.py:
4060         (SimulatedDeviceManager.populate_available_devices): Only parse stdout, log error when
4061         json decoding fails.
4062         (SimulatedDevice.is_usable): Only parse stdout.
4063         (SimulatedDevice.launch_app): Ditto.
4064
4065 2020-05-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4066
4067         [iOS] ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink is failing consistently
4068         https://bugs.webkit.org/show_bug.cgi?id=212363
4069         <rdar://problem/63508866>
4070
4071         Reviewed by Tim Horton.
4072
4073         This test began to consistently throw an exception after <https://trac.webkit.org/r261157>, due to how
4074         UserInterfaceSwizzler always instantiates the shared UIApplication. This apparently causes -[WKContentView
4075         resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:] to return `nil` instead of a replica view. As a
4076         result, we crash under `createFallbackTargetedPreview` as we're attempting to assemble a targeted preview for
4077         the context menu interaction.
4078
4079         Since this seems to only affect this particular API test, work around it by swizzling out
4080         `-resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:` in this API test to return a non-null UIView.
4081
4082         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
4083         (TestWebKitAPI::swizzledResizableSnapshotViewFromRect):
4084         (TestWebKitAPI::TEST):
4085
4086 2020-05-24  Sam Weinig  <weinig@apple.com>
4087
4088         Extended Color Cleanup: Use the name SimpleColor consistently
4089         https://bugs.webkit.org/show_bug.cgi?id=212337
4090
4091         Reviewed by Anders Carlsson.
4092
4093         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
4094         (TestWebKitAPI::TEST):
4095         Update test for rename of makeRGBAFromHSLA to makeSimpleColorFromHSLA.
4096
4097 2020-05-25  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
4098
4099         [Flatpak][GStreamer] compilation fails when GST_BUILD_PATH is defined
4100         https://bugs.webkit.org/show_bug.cgi?id=212343
4101
4102         Reviewed by Philippe Normand.
4103
4104         Flatpak's command has to be expressed before gst-env declaration.
4105
4106         * flatpak/flatpakutils.py:
4107         (WebkitFlatpak.run_in_sandbox):
4108
4109 2020-05-25  Adrian Perez de Castro  <aperez@igalia.com>
4110
4111         [WPE][WKTR] Fix typo in EventSenderProxyWPE
4112         https://bugs.webkit.org/show_bug.cgi?id=212340
4113
4114         Reviewed by Carlos Garcia Campos.
4115
4116         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
4117         (WTR::wpeKeySymForKeyRef): Fix typo rightArror -> rightArrow.
4118
4119 2020-05-25  Philippe Normand  <pnormand@igalia.com>
4120
4121         REGRESSION(r262057): [Flatpak SDK] sccache-dist server no longer starting
4122         https://bugs.webkit.org/show_bug.cgi?id=212326
4123
4124         Reviewed by Žan Doberšek.
4125
4126         A few mount points were missing in the sandbox created by
4127         `flatpak run` preventing the sccache-dist server to start and keep running.
4128
4129         * flatpak/flatpakutils.py:
4130         (WebkitFlatpak.run_in_sandbox):
4131         * flatpak/webkit-bwrap:
4132
4133 2020-05-25  Philippe Normand  <pnormand@igalia.com>
4134
4135         [Flatpak SDK] Fixup icecc support
4136         https://bugs.webkit.org/show_bug.cgi?id=212301
4137
4138         Reviewed by Žan Doberšek.
4139
4140         * flatpak/flatpakutils.py:
4141         (WebkitFlatpak.run_in_sandbox): Allow homedir access from the
4142         sandbox, this is needed because the icecc toolchains paths refer
4143         to the host environment, not the sandbox.
4144         (WebkitFlatpak.pack_toolchain): Fix byte-string formatting issue, happening in Python3.
4145
4146 2020-05-25  Philippe Normand  <pnormand@igalia.com>
4147
4148         [GTK4] SDK contains too old GTK4
4149         https://bugs.webkit.org/show_bug.cgi?id=212334
4150
4151         Reviewed by Adrian Perez de Castro.
4152
4153         * buildstream/elements/sdk/gtk.bst: Update GTK4 to 3.98.4.
4154
4155 2020-05-24  Sam Weinig  <weinig@apple.com>
4156
4157         Extended Color Cleanup: Stop allowing direct access to the underlying SimpleColor (it is almost always incorrect with respect to extended colors)
4158         https://bugs.webkit.org/show_bug.cgi?id=212184
4159
4160         Reviewed by Dean Jackson.
4161
4162         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
4163         (TestWebKitAPI::TEST):
4164         Use toSRGBASimpleColorLossy() to get access to color components.
4165
4166 2020-05-22  Alex Christensen  <achristensen@webkit.org>
4167
4168         Make download resume workaround forgiving of changes in CFNetwork
4169         https://bugs.webkit.org/show_bug.cgi?id=212273
4170
4171         Reviewed by Geoffrey Garen.
4172
4173         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4174
4175 2020-05-22  Paulo Matos  <pmatos@igalia.com>
4176
4177         Add support for [no-]use-ccache option in build-jsc
4178         https://bugs.webkit.org/show_bug.cgi?id=212259
4179
4180         Reviewed by Mark Lam.
4181
4182         * Scripts/build-jsc:
4183
4184 2020-05-22  Alex Christensen  <achristensen@webkit.org>
4185
4186         Add SPI to unblock third party cookies from WKWebViews with ResourceLoadStatistics turned on
4187         https://bugs.webkit.org/show_bug.cgi?id=212058
4188         <rdar://problem/60595539>
4189
4190         Reviewed by John Wilander.
4191
4192         I also add _test_waitForAlert to make tests less verbose.
4193
4194         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4195         (TEST):
4196         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
4197         (TEST):
4198         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
4199         (TestWebKitAPI::TEST):
4200         * TestWebKitAPI/cocoa/HTTPServer.h:
4201         (TestWebKitAPI::Connection::Connection):
4202         * TestWebKitAPI/cocoa/HTTPServer.mm:
4203         (TestWebKitAPI::HTTPServer::HTTPServer):
4204         (TestWebKitAPI::dataFromString):
4205         (TestWebKitAPI::nullTerminatedRequest):
4206         (TestWebKitAPI::HTTPServer::request const):
4207         (TestWebKitAPI::Connection::receive const):
4208         (TestWebKitAPI::Connection::send const):
4209         * TestWebKitAPI/cocoa/TestUIDelegate.h:
4210         * TestWebKitAPI/cocoa/TestUIDelegate.mm:
4211         (-[WKWebView _test_waitForAlert]):
4212
4213 2020-05-22  Chris Dumez  <cdumez@apple.com>
4214
4215         [WKTR] Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank
4216         https://bugs.webkit.org/show_bug.cgi?id=212268
4217         <rdar://problem/63493074>
4218
4219         Reviewed by Geoffrey Garen.
4220
4221         Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank.
4222
4223         In <rdar://problem/63493074>, we have evidence that TestController::resetStateToConsistentValues() sometimes
4224         fails to load about:blank, likely due to an unresponsive WebProcess. When this happens, WebKitTestRunner
4225         reports the test as timing out and logs this on stderr:
4226         """
4227         <unknown> - TestController::run - Failed to reset state to consistent values
4228         #PROCESS UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 57421)
4229         """
4230
4231         This is unfortunate because this does not indicate that anything is particularly wrong with the test in
4232         question. Rather, it indicates that the WebProcess is unresponsive (likely due to a hang caused by a
4233         previous test), which prevents WebKitTestRunner to reset the state in order to run the test.
4234
4235         I propose that if we fail to load about:blank once, we log an error message to stderr but then terminate
4236         the WebProcess and try once again, to make WebKitTestRunner more robust.
4237         I have verified the change locally, by injecting a script in resetStateToConsistentValues() that causes
4238         a WebProcess hang. Before my change, the test would time out and the same logging as in
4239         <rdar://problem/63493074> would show. After my change though, the test would pass successfully despite the
4240         WebProcess hang.
4241
4242         * WebKitTestRunner/TestController.cpp:
4243         (WTR::TestController::resetStateToConsistentValues):
4244
4245 2020-05-22  ChangSeok Oh  <changseok@webkit.org>
4246
4247         [GTK] jhbuild is broken with GCC 10.0
4248         https://bugs.webkit.org/show_bug.cgi?id=212256
4249
4250         Reviewed by Carlos Alberto Lopez Perez.
4251
4252         GCC 10.0 enables -fno-common as default, so many 'multiple definitions' failures occur
4253         in building dependencies via jhbuild. This patch addresses them by back-porting patches
4254         from corresponding source repositories.
4255
4256         * gstreamer/jhbuild.modules:
4257         * gstreamer/patches/libsrtp-Fix-building-with-gcc-10.patch: Added.
4258         * gstreamer/patches/orc-satisfy-fno-common-under-gcc10.patch: Added.
4259         * gtk/jhbuild.modules:
4260         * gtk/patches/at-spi2-atk-tests-Replace-common-variable-with-usual-external.patch: Added.
4261         * gtk/patches/at-spi2-atk-tests-fix-child_pid-reference.patch: Added.
4262         * gtk/patches/mesa-gallium-build-fix-to-make-gcc-10-happy.patch: Added.
4263         * gtk/patches/xserver-Fix-building-with-fno-common.patch: Added.
4264
4265 2020-05-22  Philippe Normand  <pnormand@igalia.com>
4266
4267         [Flatpak SDK] Add bubblewrap ... wrapper
4268         https://bugs.webkit.org/show_bug.cgi?id=212077
4269
4270         Reviewed by Carlos Alberto Lopez Perez.
4271
4272         The bind-mounts are now handled through webkit-bwrap.
4273
4274         * flatpak/flatpakutils.py:
4275         (WebkitFlatpak.execute_command):
4276         (WebkitFlatpak.run_in_sandbox):
4277         * flatpak/webkit-bwrap: Added.
4278
4279 2020-05-22  Javier Fernandez  <jfernandez@igalia.com>
4280
4281         [Flatpak SDK] CCACHE_ env vars are not forwarded to the sandbox environment
4282         https://bugs.webkit.org/show_bug.cgi?id=212257
4283
4284         Reviewed by Philippe Normand.
4285
4286         Added the "CCACHE" prefix to the ones the SDK should keep from the
4287         user's environment, and forwarded to the Flatpak sandbox.
4288
4289         * flatpak/flatpakutils.py:
4290         (WebkitFlatpak.run_in_sandbox):
4291
4292 2020-05-22  Tim Horton  <timothy_horton@apple.com>
4293
4294         iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back
4295         https://bugs.webkit.org/show_bug.cgi?id=212243
4296         <rdar://problem/59127764>
4297
4298         Reviewed by Wenson Hsieh.
4299
4300         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
4301         (-[FocusDelegate _webView:takeFocus:]):
4302         (-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4303         (TEST):
4304
4305 2020-05-21  Wenson Hsieh  <wenson_hsieh@apple.com>
4306
4307         DataTransfer.files contains multiple files when pasting a single image with multiple representations
4308         https://bugs.webkit.org/show_bug.cgi?id=212245