180dcc1bca790d21c8d09cd8ada2010fb33964e7
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2
3         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
4         https://bugs.webkit.org/show_bug.cgi?id=130336
5
6         Reviewed by Gyuyoung Kim.
7
8         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
9         requires a space between literal and string macro [-Wliteral-suffix]'
10         warning treated as error.
11
12         This patch applies a solution from r162448 to the EFL port.
13
14         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
15         * efl/jhbuild.modules: Added appropriate patch section.
16
17 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
18
19         webkitpy test rebaseline.
20
21         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
22         (MainTest.test_default_args):
23
24 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
25
26         --profile should imply --test-runner-count=1 in run-perf-tests
27         https://bugs.webkit.org/show_bug.cgi?id=130375
28
29         Reviewed by Benjamin Poulain.
30
31         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
32
33         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
34         (PerfTestsRunner._parse_args): Use -1 as the default value.
35         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
36         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
37         should be 1.
38
39 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
40
41         Address some style nits.
42
43         * MiniBrowser/mac/WK2BrowserWindowController.m:
44
45 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
46
47         Add transparent window support back into MiniBrowser
48         https://bugs.webkit.org/show_bug.cgi?id=130363
49
50         Reviewed by Anders Carlsson.
51         
52         Re-enable transparent window support for WK2.
53
54         * MiniBrowser/mac/WK2BrowserWindowController.m:
55         (-[WK2BrowserWindowController validateMenuItem:]):
56         (-[WK2BrowserWindowController toggleTransparentWindow:]):
57
58 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
59
60         Fix the 32-bit build; make the open panel make a WK1 window.
61
62         * MiniBrowser/mac/AppDelegate.m:
63         (-[BrowserAppDelegate openDocument:]):
64
65 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
66
67         Convert MiniBrowser to use WKWebView API
68         https://bugs.webkit.org/show_bug.cgi?id=130061
69
70         Reviewed by Anders Carlsson.
71         
72         Convert the MiniBrowser WK2 window to use WebKit2 API as much
73         as possible.
74         
75         Some functionality was removed temporarily:
76             - text zoom, page zoom
77             - reload
78             - pagination mode
79             - transparent window
80             - dumping source
81             - window.open support
82             - beforeUnload panel
83             - find in page
84
85         * MiniBrowser/mac/AppDelegate.h:
86         * MiniBrowser/mac/AppDelegate.m:
87         (-[BrowserAppDelegate init]):
88         (-[BrowserAppDelegate newWindow:]):
89         (-[BrowserAppDelegate applicationWillTerminate:]):
90         (-[BrowserAppDelegate openDocument:]):
91         * MiniBrowser/mac/WK2BrowserWindowController.h:
92         * MiniBrowser/mac/WK2BrowserWindowController.m:
93         (-[WK2BrowserWindowController awakeFromNib]):
94         (-[WK2BrowserWindowController dealloc]):
95         (-[WK2BrowserWindowController fetch:]):
96         (-[WK2BrowserWindowController validateMenuItem:]):
97         (-[WK2BrowserWindowController reload:]):
98         (-[WK2BrowserWindowController goBack:]):
99         (-[WK2BrowserWindowController goForward:]):
100         (-[WK2BrowserWindowController toggleZoomMode:]):
101         (-[WK2BrowserWindowController resetZoom:]):
102         (-[WK2BrowserWindowController canResetZoom]):
103         (-[WK2BrowserWindowController dumpSourceToConsole:]):
104         (-[WK2BrowserWindowController togglePaginationMode:]):
105         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
106         (-[WK2BrowserWindowController windowShouldClose:]):
107         (-[WK2BrowserWindowController applicationTerminating]):
108         (-[WK2BrowserWindowController currentZoomFactor]):
109         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
110         (-[WK2BrowserWindowController toggleTransparentWindow:]):
111         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
112         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
113         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
114         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
115         (-[WK2BrowserWindowController find:]):
116         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
117         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
118         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
119         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
120         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
121         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
122         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
123         * WebKitTestRunner/PlatformWebView.h:
124         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
125         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
126
127 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
128
129         Use RunLoop objects through references instead of pointers
130         https://bugs.webkit.org/show_bug.cgi?id=130313
131
132         Reviewed by Andreas Kling.
133
134         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
135         return RunLoop reference instead of a pointer.
136
137         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
138         (loadedCallback):
139         (clickedCallback):
140
141 2014-03-17  Tim Horton  <timothy_horton@apple.com>
142
143         sort-export-file --help doesn't work (missing 'use')
144         https://bugs.webkit.org/show_bug.cgi?id=130338
145
146         Reviewed by Anders Carlsson.
147
148         * Scripts/sort-export-file:
149         Add a missing 'use', and fix a typo in an error message.
150
151 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
152
153         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
154         https://bugs.webkit.org/show_bug.cgi?id=130155
155
156         Reviewed by Philippe Normand.
157
158         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
159
160 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
161
162         [GTK] MiniBrowser fails to load injected bundle lib
163         https://bugs.webkit.org/show_bug.cgi?id=130332
164
165         Reviewed by Anders Carlsson.
166
167         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
168
169         * MiniBrowser/gtk/main.c:
170         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
171         process is spawn.
172
173 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
174
175         [EFL] Enable TOUCH_SLIDER macro
176         https://bugs.webkit.org/show_bug.cgi?id=130185
177
178         Reviewed by Gyuyoung Kim.
179
180         * Scripts/webkitperl/FeatureList.pm:
181
182 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
183
184         [GTK][CMake] Build with -fno-rtti
185         https://bugs.webkit.org/show_bug.cgi?id=130261
186
187         Reviewed by Martin Robinson.
188
189         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
190         defined to 0 to prevent typeid use in included GTest headers.
191
192 2014-03-16  Brian Burg  <bburg@apple.com>
193
194         Web Inspector: vended backend commands file should be generated as part of the build
195         https://bugs.webkit.org/show_bug.cgi?id=130110
196
197         Reviewed by Timothy Hatcher.
198
199         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
200
201 2014-03-16  Diego Pino García  <dpino@igalia.com>
202
203         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
204         https://bugs.webkit.org/show_bug.cgi?id=128999
205
206         Reviewed by Philippe Normand.
207
208         * MiniBrowser/gtk/BrowserWindow.c:
209         (reloadPage):
210         (reloadPageIgnoringCache):
211         (browser_window_init):
212
213 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
214
215         [GTK] Improve ninja detection in webkitdirs.pm
216         https://bugs.webkit.org/show_bug.cgi?id=129902
217
218         Reviewed by Daniel Bates.
219
220         * Scripts/webkitdirs.pm:
221         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
222         us to look for ninja-build as well.
223
224 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
225
226         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
227         https://bugs.webkit.org/show_bug.cgi?id=130276
228         <rdar://problem/16266927>
229         
230         Reviewed by Simon Fraser.
231
232         * BuildSlaveSupport/build-launcher-app:
233         * BuildSlaveSupport/build-launcher-dmg:
234         * DumpRenderTree/DumpRenderTree.h:
235         * DumpRenderTree/DumpRenderTreePrefix.h:
236         * DumpRenderTree/GCController.cpp:
237         * DumpRenderTree/GCController.h:
238         * DumpRenderTree/JavaScriptThreading.cpp:
239         * DumpRenderTree/JavaScriptThreading.h:
240         * DumpRenderTree/PixelDumpSupport.cpp:
241         * DumpRenderTree/PixelDumpSupport.h:
242         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
243         * DumpRenderTree/TestRunner.cpp:
244         * DumpRenderTree/TestRunner.h:
245         * DumpRenderTree/WorkQueue.cpp:
246         * DumpRenderTree/WorkQueue.h:
247         * DumpRenderTree/WorkQueueItem.h:
248         * DumpRenderTree/atk/AccessibilityCallbacks.h:
249         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
250         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
251         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
252         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
253         * DumpRenderTree/cg/PixelDumpSupportCG.h:
254         * DumpRenderTree/efl/EditingCallbacks.cpp:
255         * DumpRenderTree/efl/EditingCallbacks.h:
256         * DumpRenderTree/efl/EventSender.cpp:
257         * DumpRenderTree/efl/EventSender.h:
258         * DumpRenderTree/efl/GCControllerEfl.cpp:
259         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
260         * DumpRenderTree/efl/TestRunnerEfl.cpp:
261         * DumpRenderTree/gtk/DumpRenderTree.cpp:
262         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
263         * DumpRenderTree/gtk/EditingCallbacks.cpp:
264         * DumpRenderTree/gtk/EditingCallbacks.h:
265         * DumpRenderTree/gtk/EventSender.cpp:
266         * DumpRenderTree/gtk/EventSender.h:
267         * DumpRenderTree/gtk/GCControllerGtk.cpp:
268         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
269         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
270         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
271         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
272         * DumpRenderTree/gtk/TextInputController.cpp:
273         * DumpRenderTree/gtk/TextInputController.h:
274         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
275         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
276         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
277         * DumpRenderTree/mac/AppleScriptController.h:
278         * DumpRenderTree/mac/AppleScriptController.m:
279         * DumpRenderTree/mac/CheckedMalloc.cpp:
280         * DumpRenderTree/mac/CheckedMalloc.h:
281         * DumpRenderTree/mac/DumpRenderTree.mm:
282         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
283         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
284         * DumpRenderTree/mac/DumpRenderTreeMac.h:
285         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
286         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
287         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
288         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
289         * DumpRenderTree/mac/EditingDelegate.h:
290         * DumpRenderTree/mac/EditingDelegate.mm:
291         * DumpRenderTree/mac/EventSendingController.h:
292         * DumpRenderTree/mac/EventSendingController.mm:
293         * DumpRenderTree/mac/FrameLoadDelegate.h:
294         * DumpRenderTree/mac/FrameLoadDelegate.mm:
295         * DumpRenderTree/mac/GCControllerMac.mm:
296         * DumpRenderTree/mac/MockWebNotificationProvider.h:
297         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
298         * DumpRenderTree/mac/NavigationController.h:
299         * DumpRenderTree/mac/NavigationController.m:
300         * DumpRenderTree/mac/ObjCController.h:
301         * DumpRenderTree/mac/ObjCController.m:
302         * DumpRenderTree/mac/ObjCPlugin.h:
303         * DumpRenderTree/mac/ObjCPlugin.m:
304         * DumpRenderTree/mac/ObjCPluginFunction.h:
305         * DumpRenderTree/mac/ObjCPluginFunction.m:
306         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
307         * DumpRenderTree/mac/PolicyDelegate.h:
308         * DumpRenderTree/mac/PolicyDelegate.mm:
309         * DumpRenderTree/mac/ResourceLoadDelegate.h:
310         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
311         * DumpRenderTree/mac/TestRunnerMac.mm:
312         * DumpRenderTree/mac/TextInputController.h:
313         * DumpRenderTree/mac/TextInputController.m:
314         * DumpRenderTree/mac/UIDelegate.h:
315         * DumpRenderTree/mac/UIDelegate.mm:
316         * DumpRenderTree/mac/WorkQueueItemMac.mm:
317         * DumpRenderTree/win/DRTDataObject.cpp:
318         * DumpRenderTree/win/DRTDataObject.h:
319         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
320         * DumpRenderTree/win/DRTDropSource.cpp:
321         * DumpRenderTree/win/DRTDropSource.h:
322         * DumpRenderTree/win/DraggingInfo.h:
323         * DumpRenderTree/win/DumpRenderTree.cpp:
324         * DumpRenderTree/win/DumpRenderTreeWin.h:
325         * DumpRenderTree/win/EditingDelegate.cpp:
326         * DumpRenderTree/win/EditingDelegate.h:
327         * DumpRenderTree/win/EventSender.cpp:
328         * DumpRenderTree/win/EventSender.h:
329         * DumpRenderTree/win/FrameLoadDelegate.cpp:
330         * DumpRenderTree/win/FrameLoadDelegate.h:
331         * DumpRenderTree/win/GCControllerWin.cpp:
332         * DumpRenderTree/win/HistoryDelegate.cpp:
333         * DumpRenderTree/win/HistoryDelegate.h:
334         * DumpRenderTree/win/MD5.cpp:
335         * DumpRenderTree/win/MD5.h:
336         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
337         * DumpRenderTree/win/PolicyDelegate.cpp:
338         * DumpRenderTree/win/PolicyDelegate.h:
339         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
340         * DumpRenderTree/win/ResourceLoadDelegate.h:
341         * DumpRenderTree/win/TestRunnerWin.cpp:
342         * DumpRenderTree/win/TextInputController.cpp:
343         * DumpRenderTree/win/TextInputController.h:
344         * DumpRenderTree/win/TextInputControllerWin.cpp:
345         * DumpRenderTree/win/UIDelegate.cpp:
346         * DumpRenderTree/win/UIDelegate.h:
347         * DumpRenderTree/win/WorkQueueItemWin.cpp:
348         * EWebLauncher/main.c:
349         * GtkLauncher/main.c:
350         * ImageDiff/efl/ImageDiff.cpp:
351         * ImageDiff/gtk/ImageDiff.cpp:
352         * MiniBrowser/gtk/main.c:
353         * Scripts/SpacingHeuristics.pm:
354         * Scripts/VCSUtils.pm:
355         * Scripts/bisect-builds:
356         * Scripts/build-dumprendertree:
357         * Scripts/build-jsc:
358         * Scripts/build-webkit:
359         * Scripts/check-dom-results:
360         * Scripts/check-for-exit-time-destructors:
361         * Scripts/check-for-global-initializers:
362         * Scripts/commit-log-editor:
363         * Scripts/compare-timing-files:
364         * Scripts/debug-minibrowser:
365         * Scripts/debug-safari:
366         * Scripts/do-file-rename:
367         * Scripts/find-extra-includes:
368         * Scripts/generate-coverage-data:
369         * Scripts/make-script-test-wrappers:
370         * Scripts/malloc-tree:
371         * Scripts/old-run-webkit-tests:
372         * Scripts/parse-malloc-history:
373         * Scripts/report-include-statistics:
374         * Scripts/resolve-ChangeLogs:
375         * Scripts/run-bindings-tests:
376         * Scripts/run-iexploder-tests:
377         * Scripts/run-javascriptcore-tests:
378         * Scripts/run-jsc:
379         * Scripts/run-launcher:
380         * Scripts/run-leaks:
381         * Scripts/run-mangleme-tests:
382         * Scripts/run-minibrowser:
383         * Scripts/run-pageloadtest:
384         * Scripts/run-regexp-tests:
385         * Scripts/run-safari:
386         * Scripts/run-sunspider:
387         * Scripts/run-webkit-app:
388         * Scripts/sampstat:
389         * Scripts/set-webkit-configuration:
390         * Scripts/sort-Xcode-project-file:
391         * Scripts/sort-export-file:
392         * Scripts/split-file-by-class:
393         * Scripts/sunspider-compare-results:
394         * Scripts/svn-apply:
395         * Scripts/svn-create-patch:
396         * Scripts/svn-unapply:
397         * Scripts/test-webkit-scripts:
398         * Scripts/update-javascriptcore-test-results:
399         * Scripts/update-webkit:
400         * Scripts/update-webkit-auxiliary-libs:
401         * Scripts/update-webkit-dependency:
402         * Scripts/update-webkit-localizable-strings:
403         * Scripts/update-webkit-support-libs:
404         * Scripts/update-webkit-wincairo-libs:
405         * Scripts/webkit-build-directory:
406         * Scripts/webkitdirs.pm:
407         (installedSafariPath):
408         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
409         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
410         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
411         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
412         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
413         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
414         * Scripts/webkitperl/features.pm:
415         * Scripts/webkitperl/httpd.pm:
416         * Scripts/webkitpy/bindings/main.py:
417         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
418         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
419         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
420         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
421         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
422         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
423         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
424         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
425         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
426         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
427         * WebKitTestRunner/PixelDumpSupport.cpp:
428         * WebKitTestRunner/PixelDumpSupport.h:
429         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
430         * WinLauncher/WinLauncher.cpp:
431         * WinLauncher/WinLauncher.h:
432         * WinLauncher/stdafx.cpp:
433         * WinLauncher/stdafx.h:
434
435 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
436
437         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
438         https://bugs.webkit.org/show_bug.cgi?id=130265
439
440         Reviewed by Michael Saboff.
441
442         * Scripts/build-webkit:
443         * Scripts/copy-webkitlibraries-to-product-directory:
444
445 2014-03-14  Landry Breuil  <landry@openbsd.org>
446
447         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
448         Also allow to set MAKE in the environment.
449         https://bugs.webkit.org/show_bug.cgi?id=129991
450
451         Reviewed by Andreas Kling.
452
453         * Scripts/webkitdirs.pm:
454         (determineArchitecture):
455         (determineNumberOfCPUs):
456         (isBSD):
457         (buildAutotoolsProject):
458         * Scripts/webkitpy/common/system/platforminfo.py:
459         (PlatformInfo.__init__):
460         (PlatformInfo.is_openbsd):
461         (PlatformInfo):
462         (PlatformInfo.is_netbsd):
463         (PlatformInfo._determine_os_name):
464
465 2014-03-14  Dean Jackson  <dino@apple.com>
466
467         Remove libWebKitSystemInterfaceLion.a
468         https://bugs.webkit.org/show_bug.cgi?id=130254
469
470         Reviewed by Geoffrey Garen and Andreas Kling.
471
472         No need to copy the Lion libraries into the build.
473
474         * Scripts/copy-webkitlibraries-to-product-directory:
475
476 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
477
478         [EFL][MiniBrowser] Revise help messages of command line parameters
479         https://bugs.webkit.org/show_bug.cgi?id=130222
480
481         Reviewed by Csaba Osztrogonác.
482
483         Correct the default value description and make help messages to be consistent.
484
485         * MiniBrowser/efl/main.c:
486
487 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
488
489         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
490         https://bugs.webkit.org/show_bug.cgi?id=129612
491
492         Reviewed by Darin Adler.
493
494         For new code use static NeverDestroyed<T> instead.
495
496         * DumpRenderTree/JavaScriptThreading.cpp:
497         (javaScriptThreadsMutex):
498         (javaScriptThreads):
499         * DumpRenderTree/efl/EventSender.cpp:
500         (touchPointList):
501         (delayedEventQueue):
502         * DumpRenderTree/win/FrameLoadDelegate.cpp:
503         (delegatesWithDelayedWork):
504         * Scripts/check-for-exit-time-destructors:
505         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
506         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
507         (testsMap):
508
509 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
510
511         [EFL][WK2] Fix compilation warning in Minibrowser
512         https://bugs.webkit.org/show_bug.cgi?id=130132
513
514         Reviewed by Csaba Osztrogonác.
515
516         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
517
518         * MiniBrowser/efl/main.c:
519         (on_download_request):
520
521 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
522
523         FTL should support IsBlah
524         https://bugs.webkit.org/show_bug.cgi?id=130202
525
526         Reviewed by Geoffrey Garen.
527         
528         Running existing JSRegress tests with noInline gives us coverage for these
529         changes. Chances are, this will also give coverage for other interesting things
530         as well.
531
532         * Scripts/run-jsc-stress-tests:
533
534 2014-03-12  Brian Burg  <bburg@apple.com>
535
536         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
537         https://bugs.webkit.org/show_bug.cgi?id=129744
538
539         Reviewed by Timothy Hatcher.
540
541         * DumpRenderTree/TestRunner.cpp:
542         (evaluateInWebInspectorCallback):
543         * DumpRenderTree/TestRunner.h:
544         * DumpRenderTree/efl/TestRunnerEfl.cpp:
545         (TestRunner::evaluateInWebInspector):
546         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
547         (TestRunner::evaluateInWebInspector):
548         * DumpRenderTree/mac/TestRunnerMac.mm:
549         (TestRunner::evaluateInWebInspector):
550         * DumpRenderTree/win/TestRunnerWin.cpp:
551         (TestRunner::evaluateInWebInspector):
552         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
553         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
554         (WTR::TestRunner::evaluateInWebInspector):
555         * WebKitTestRunner/InjectedBundle/TestRunner.h:
556
557 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
558
559         [GTK] build-webkit shouldn't show error message when ninja isn't installed
560         https://bugs.webkit.org/show_bug.cgi?id=130129
561
562         Reviewed by Csaba Osztrogonác.
563
564         * Scripts/webkitdirs.pm:
565         (canUseNinja): Redirecting stderr to /dev/null
566
567 2014-03-13  Andres Gomez  <agomez@igalia.com>
568
569         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
570         https://bugs.webkit.org/show_bug.cgi?id=130092
571
572         Reviewed by Csaba Osztrogonác.
573
574         Added "python-dev" as dependency for deb based distros. It is
575         already present for rpm based distros. This dependency will allow
576         libxml2 to generate its python bindings, needed by gtk-doc.
577
578         * gtk/install-dependencies:
579
580 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
581
582         Unreviewed. Fix GTK+ cmake build after r165488.
583
584         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
585
586 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
587
588         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
589         https://bugs.webkit.org/show_bug.cgi?id=130014
590
591         Reviewed by Martin Robinson.
592
593         Include cmake or autotools config header.
594
595         * MiniBrowser/gtk/BrowserDownloadsBar.c:
596         * MiniBrowser/gtk/BrowserSearchBar.c:
597         * MiniBrowser/gtk/BrowserWindow.c:
598         * MiniBrowser/gtk/main.c:
599
600 2014-03-12  Commit Queue  <commit-queue@webkit.org>
601
602         Unreviewed, rolling out r165471.
603         https://bugs.webkit.org/show_bug.cgi?id=130139
604
605         Didn't really fix the issue and broke another bot (Requested
606         by mrobinson on #webkit).
607
608         Reverted changeset:
609
610         "[CMake] Newer versions of CMake cannot find older versions of
611         Freetype"
612         https://bugs.webkit.org/show_bug.cgi?id=130107
613         http://trac.webkit.org/changeset/165471
614
615 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
616
617         It should be possible to build WebKit with FTL on iOS
618         https://bugs.webkit.org/show_bug.cgi?id=130116
619
620         Reviewed by Dan Bernstein.
621
622         * Scripts/build-webkit:
623         * Scripts/copy-webkitlibraries-to-product-directory:
624
625 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
626
627         [Win] Remove use of QTSDK
628         https://bugs.webkit.org/show_bug.cgi?id=130049
629
630         Reviewed by Darin Adler.
631
632         * DumpRenderTree/win/DumpRenderTree.cpp:
633         (initialize): Remove QuickTime code.
634         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
635         building QTMovieWin.
636
637 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
638
639         [GTK][CMAKE] Too verbose build output
640         https://bugs.webkit.org/show_bug.cgi?id=130076
641
642         Reviewed by Carlos Garcia Campos.
643
644         Instead of building with cmake --build which isn't smart about pretty printing and
645         colors, we build with a script which calls the proper build command.
646
647         * Scripts/webkitdirs.pm:
648         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
649         the CMake configuration pass.
650
651 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
652
653         [CMake] Newer versions of CMake cannot find older versions of Freetype
654         https://bugs.webkit.org/show_bug.cgi?id=130107
655
656         Reviewed by Gustavo Noronha Silva.
657
658         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
659         to CMake during jhbuild initialization.
660
661 2014-03-12  Zalan Bujtas  <zalan@apple.com>
662
663         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
664         https://bugs.webkit.org/show_bug.cgi?id=129961
665
666         Reviewed by Simon Fraser.
667
668         Now scaled content can go through the window capturing mechanism too for compositing content.
669         AppleMagnifiedMode is redundant.
670
671         * DumpRenderTree/mac/DumpRenderTree.mm:
672         (setDefaultsToConsistentValuesForTesting):
673         (runTest):
674         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
675         (createBitmapContextFromWebView):
676         * WebKitTestRunner/PlatformWebView.h:
677         * WebKitTestRunner/cg/TestInvocationCG.cpp:
678         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
679         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
680         (WTR::PlatformWebView::didInitializeClients):
681         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
682         (WTR::PlatformWebView::forceWindowFramesChanged):
683         * WebKitTestRunner/mac/main.mm:
684         (setDefaultsToConsistentValuesForTesting):
685
686 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
687
688         Unreviewed. Add myself as a committer.
689
690         * Scripts/webkitpy/common/config/contributors.json:
691
692 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
693
694         Unreviewed build fix on the EFL port when used lower version of ATK
695
696         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
697         (WTR::AccessibilityUIElement::y): Fixed typo.
698
699 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
700
701         Some images are blank in the rebaseline server UI
702         https://bugs.webkit.org/show_bug.cgi?id=130104
703
704         Reviewed by Tim Horton.
705
706         Let the server check for images in the 'retries' directory
707         if it can't find an image otherwise.
708
709         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
710         (RebaselineHTTPRequestHandler.test_result):
711
712 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
713
714         [GTK][CMake] --update-gtk has no effect
715         https://bugs.webkit.org/show_bug.cgi?id=130088
716
717         Reviewed by Philippe Normand.
718
719         * Scripts/webkitdirs.pm:
720         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
721         as an argument.
722
723 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
724
725         Add "System Font" to the list of whitelisted DRT fonts
726         https://bugs.webkit.org/show_bug.cgi?id=130046
727
728         Reviewed by Darin Adler.
729
730         * DumpRenderTree/mac/DumpRenderTree.mm:
731         (allowedFontFamilySet):
732         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
733
734 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
735
736         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
737         https://bugs.webkit.org/show_bug.cgi?id=130064
738
739         Reviewed by Philippe Normand.
740
741         * efl/jhbuildrc: Remove duplicated code.
742         * gtk/jhbuildrc: Remove duplicated code.
743         * jhbuild/jhbuildrc_common.py:
744         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
745         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
746         and is apparently necessary for GTK+.
747
748 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
749
750         check-webkit-style failed to complain about missing braces
751         https://bugs.webkit.org/show_bug.cgi?id=34189
752
753         Reviewed by Ryosuke Niwa.
754
755         * Scripts/webkitpy/style/checkers/cpp.py:
756         (check_braces):
757         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
758         (WebKitStyleTest.test_braces):
759
760 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
761
762         Remove Qt cruft from style checker.
763         https://bugs.webkit.org/show_bug.cgi?id=130085
764
765         Reviewed by Csaba Osztrogonác.
766
767         There is no 'foreach' keyword in c++. That was a Qt feature
768         added in: http://trac.webkit.org/changeset/46113
769         Qt was removed from WebKit, so we should remove the checks
770         of this keyword from check-webkit-style scripts.
771
772         * Scripts/webkitpy/style/checkers/cpp.py:
773         (check_spacing_for_function_call):
774         (check_spacing):
775         (check_braces):
776         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
777         (CppStyleTest.test_mismatching_spaces_in_parens):
778         (CppStyleTest.test_spacing_for_fncall):
779         (WebKitStyleTest.test_braces):
780
781 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
782
783         [GTK] update-webkitgtk-libs needs itstool
784         https://bugs.webkit.org/show_bug.cgi?id=130082
785
786         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
787         itstool is a dependency of building gtk-doc from version 1.19, so it should
788         be added to Tools/gtk/install-dependencies script, too.
789
790         Reviewed by Philippe Normand.
791
792         * gtk/install-dependencies:
793
794 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
795
796         webkitbot rollout ChangeLogs should be nicer
797         https://bugs.webkit.org/show_bug.cgi?id=122654
798
799         Reviewed by Csaba Osztrogonác.
800
801         Added bug urls and descriptions of rolled out patches to the rollout changelog
802         if they are present in the original changelog. Additionally removed the list of
803         changed files and functions.
804
805         * Scripts/webkitpy/common/checkout/changelog.py:
806         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
807         * Scripts/webkitpy/common/checkout/checkout.py:
808         (Checkout._changelog_data_for_revision): Store bug description.
809         * Scripts/webkitpy/common/checkout/checkout_mock.py:
810         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
811         (CheckoutTest.test_commit_info_for_revision):
812         * Scripts/webkitpy/common/checkout/commitinfo.py:
813         (CommitInfo.bug_description): Added.
814         (CommitInfo.to_json):
815         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
816         (CommitInfoTest.test_commit_info_creation):
817         * Scripts/webkitpy/tool/commands/download.py:
818         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
819         out patches for creating rollout changelog.
820         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
821         caused the regression is stored in state["bug_blocked"] now.
822         * Scripts/webkitpy/tool/commands/download_unittest.py:
823         (test_prepare_rollout):
824         (test_create_rollout_multiple_revision):
825         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
826         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
827         rolled out patches to the changelog.
828         (PrepareChangeLogForRevert.run):
829         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
830         (UpdateChangeLogsForRevertTest):
831         (test_message_for_revert):
832         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
833         (ReopenBugAfterRollout.run):
834
835 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
836
837         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
838         https://bugs.webkit.org/show_bug.cgi?id=130021
839
840         Reviewed by Mario Sanchez Prada.
841
842         Replace deprecated functions to use new API from ATK 2.11.90.
843
844         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
845         (AccessibilityUIElement::x):
846         (AccessibilityUIElement::y):
847         (AccessibilityUIElement::width):
848         (AccessibilityUIElement::height):
849         (AccessibilityUIElement::clickPointX):
850         (AccessibilityUIElement::clickPointY):
851         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
852         (WTR::AccessibilityUIElement::x):
853         (WTR::AccessibilityUIElement::y):
854         (WTR::AccessibilityUIElement::width):
855         (WTR::AccessibilityUIElement::height):
856         (WTR::AccessibilityUIElement::clickPointX):
857         (WTR::AccessibilityUIElement::clickPointY):
858
859 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
860
861         [ATK] Expose aria-posinset and aria-setsize through object attributes
862         https://bugs.webkit.org/show_bug.cgi?id=130011
863
864         Reviewed by Chris Fleizach.
865
866         Added missing implementation of numberAttributeValue both to WKTR and DRT.
867
868         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
869         (AccessibilityUIElement::numberAttributeValue):
870         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
871         (WTR::AccessibilityUIElement::numberAttributeValue):
872
873 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
874
875         [Win] Unreviewed build fix.
876
877         Some bad Windows code was committed at some point that prevents the Apple Windows port
878         from finding its runtime dependencies reliably.
879
880         * win/DLLLauncher/DLLLauncherMain.cpp:
881         (appleApplicationSupportDirectory): Restored this function.
882         (modifyPath): Update to use appleApplicationSupportDirectory function.
883
884 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
885
886         Let the user define the full address of the performance-site-server for uploading results
887         https://bugs.webkit.org/show_bug.cgi?id=129819
888
889         Reviewed by Ryosuke Niwa.
890
891         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
892         can be confusing. It's more straightforward, if you need to define explicitly the server's full
893         address along with the protocol, when you're using this parameter. I added HTTPS as the default
894         protocol for now, in order to avoid breaking the perf bots.
895
896         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
897         (_upload_json):
898         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
899         (MainTest.test_upload_json):
900
901 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
902
903         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
904         https://bugs.webkit.org/show_bug.cgi?id=130023
905
906         Reviewed by Dean Jackson.
907
908         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
909         /SAFESEH flag to DLL launcher process.
910
911 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
912
913         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
914         https://bugs.webkit.org/show_bug.cgi?id=129980
915
916         Reviewed by Carlos Garcia Campos.
917
918         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
919
920 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
921
922         [GTK] Remove the WebView source-mode WebKit1 test
923         https://bugs.webkit.org/show_bug.cgi?id=129976
924
925         Reviewed by Carlos Garcia Campos.
926
927         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
928
929 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
930
931         Unreviewed build fix for GTKbuild after the switch to CMake
932
933         * gtk/common.py:
934         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
935         test-only bot doesn't have any build files.
936
937 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
938
939         [GTK] built-product-archive does not handle GTK+ CMake build
940         https://bugs.webkit.org/show_bug.cgi?id=129941
941
942         * BuildSlaveSupport/built-product-archive:
943         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
944         the CMake build.
945
946 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
947
948         [GTK] Include CMake into install-dependencies script
949         https://bugs.webkit.org/show_bug.cgi?id=129909
950
951         Reviewed by Martin Robinson.
952
953         As since r165267 buid-webkit uses CMake by default, the dependency
954         with 'cmake' package should be introduced.
955
956         * gtk/install-dependencies: Ditto.
957
958 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
959
960         REGRESSION(165267): Broke a webkitpy unit tests
961         https://bugs.webkit.org/show_bug.cgi?id=129904
962
963         Reviewed by Jon Honeycutt.
964
965         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
966         (GtkPort._is_cmake_build):
967
968 2014-03-07  Andres Gomez  <agomez@igalia.com>
969
970         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
971         https://bugs.webkit.org/show_bug.cgi?id=129893
972
973         Reviewed by Martin Robinson.
974
975         Added "git-svn" as dependency for deb based distros and,
976         additionally, "subversion" for rpm based distros.
977
978         * gtk/install-dependencies:
979
980 2014-03-07  Roger Fong  <roger_fong@apple.com>
981
982         Remove dummy setSystemWebGLLoadPolicy client method.
983         https://bugs.webkit.org/show_bug.cgi?id=129873.
984
985         Reviewed by Dean Jackson.
986
987         * WebKitTestRunner/TestController.cpp:
988         (WTR::TestController::createWebViewWithOptions):
989
990 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
991
992         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
993         https://bugs.webkit.org/show_bug.cgi?id=129886
994
995         Reviewed by Mark Lam.
996
997         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
998         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
999         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1000         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1001         make it through when in non-verbose mode.
1002
1003 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1004
1005         [GTK] buid-webkit should use CMake by default
1006         https://bugs.webkit.org/show_bug.cgi?id=129855
1007
1008         Reviewed by Carlos Garcia Campos.
1009
1010         Make the CMake build the default GTK+ build when using build-webkit. This will
1011         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1012         so that we have --gtk and --gtkautotools.
1013
1014         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1015         * Scripts/webkitpy/port/gtk.py: Ditto.
1016
1017 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1018
1019         [CMake] [GTK] Build with ninja when it is available
1020         https://bugs.webkit.org/show_bug.cgi?id=129805
1021
1022         Reviewed by Philippe Normand.
1023
1024         * Scripts/webkitdirs.pm:
1025         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1026         if it's available on the system.
1027         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1028         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1029
1030 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1031
1032         If the FTL is build-time enabled then it should be run-time enabled.
1033
1034         Rubber stamped by Geoffrey Garen.
1035
1036         * Scripts/run-jsc-stress-tests:
1037
1038 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1039
1040         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1041         https://bugs.webkit.org/show_bug.cgi?id=129837
1042
1043         Reviewed by Michael Saboff.
1044
1045         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1046         The fix is to use find instead of ls like we do in shell-runner.sh.
1047
1048         * Scripts/run-jsc-stress-tests:
1049
1050 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1051
1052         filter-build-webkit should not strip .o
1053         https://bugs.webkit.org/show_bug.cgi?id=129614
1054
1055         Reviewed by Dean Jackson.
1056
1057         This makes it much easier to jump from the failing output at
1058         the end back up to the compile errors earlier in the output.
1059
1060         * Scripts/filter-build-webkit:
1061
1062 2014-03-06  Anders Carlsson  <andersca@apple.com>
1063
1064         Build WebKit2 before building WebKit
1065         https://bugs.webkit.org/show_bug.cgi?id=129831
1066         <rdar://problem/15920020>
1067
1068         Reviewed by Dan Bernstein.
1069
1070         * Scripts/build-webkit:
1071         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1072
1073 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1074
1075         make-3.82 fails to build on ARM/Linux
1076         https://bugs.webkit.org/show_bug.cgi?id=107926
1077
1078         Reviewed by Martin Robinson.
1079
1080         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1081         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1082         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1083         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1084
1085         * gtk/patches/make-3.82-arg-list-length.patch:
1086
1087 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1088
1089         [GTK] Close the page when the view is disposed instead of when finalized
1090         https://bugs.webkit.org/show_bug.cgi?id=129783
1091
1092         Reviewed by Sergio Villar Senin.
1093
1094         Add test case but disabled for now because it's affetected by bug #129684.
1095
1096         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1097         (testProcessPerWebView):
1098
1099 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1100
1101         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1102         https://bugs.webkit.org/show_bug.cgi?id=129738
1103
1104         Reviewed by Sergio Villar Senin.
1105
1106         The problem is that we are calling g_object_unref() for the
1107         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1108         view only increases the reference counter when the settings is not
1109         the same it currently has. We should release our reference once.
1110
1111         * MiniBrowser/gtk/main.c:
1112         (createBrowserWindow):
1113         (main):
1114
1115 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1116
1117         [GTK][CMake] Tarball is created with wrong tarball paths
1118         https://bugs.webkit.org/show_bug.cgi?id=129496
1119
1120         Reviewed by Daniel Bates.
1121
1122         * gtk/make-dist.py:
1123         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1124         landing the original patch with some suggestions from the reviewer. With the
1125         checks corrected, the tarball path is constructed properly.
1126
1127 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1128
1129         Unreviewed. Update my email in contributors.json
1130
1131         * Scripts/webkitpy/common/config/contributors.json:
1132
1133 2014-03-05  Dean Jackson  <dino@apple.com>
1134
1135         [WebGL] Use WKSI to see what the system policy for WebGL is
1136         https://bugs.webkit.org/show_bug.cgi?id=129722
1137         <rdar://problem/15790542>
1138
1139         Reviewed by Tim Horton.
1140
1141         Dummy entry for setSystemWebGLLoadPolicy.
1142
1143         * WebKitTestRunner/TestController.cpp:
1144         (WTR::TestController::createWebViewWithOptions):
1145
1146 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1147
1148         [GTK][CMake] Generate documentation for the DOM bindings
1149         https://bugs.webkit.org/show_bug.cgi?id=126211
1150
1151         Reviewed by Carlos Garcia Campos.
1152
1153         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1154         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1155         * gtk/generate-webkitdom-doc-files: Removed.
1156         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1157         that it can be called by generate-gtkdoc.
1158
1159 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1160
1161         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1162         https://bugs.webkit.org/show_bug.cgi?id=129380
1163
1164         Reviewed by Philippe Normand.
1165
1166         * Scripts/webkitdirs.pm:
1167         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1168         skipping CMake execution.
1169
1170 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1171
1172         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1173         https://bugs.webkit.org/show_bug.cgi?id=129651
1174
1175         Reviewed by Philippe Normand.
1176
1177         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1178
1179 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1180
1181         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1182         https://bugs.webkit.org/show_bug.cgi?id=129637
1183
1184         Reviewed by Carlos Garcia Campos.
1185
1186         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1187         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1188         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1189         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1190         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1191         (TestFactory.__init__): Add the test for GTK+.
1192         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1193
1194 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1195
1196         [ATK] Expose missing functionalities of AtkTableCell to AT
1197         https://bugs.webkit.org/show_bug.cgi?id=129492
1198
1199         Reviewed by Mario Sanchez Prada.
1200
1201         Reducing some code by using new API of AtkTableCell.
1202
1203         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1204         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1205
1206 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1207
1208         Preparing to run layout tests on Wincairo.
1209         https://bugs.webkit.org/show_bug.cgi?id=129709
1210
1211         Reviewed by Brent Fulgham.
1212
1213         * Scripts/webkitdirs.pm:
1214         (setPathForRunningWebKitApp):
1215         Add GStreamer directory for WinCairo running layout tests.
1216         * win/DLLLauncher/DLLLauncherMain.cpp:
1217         (modifyPath):
1218         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1219
1220 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1221
1222         [GTK] Simplify the GObject DOM bindings API break check into one step
1223         https://bugs.webkit.org/show_bug.cgi?id=129571
1224
1225         Reviewed by Carlos Garcia Campos.
1226
1227         * GNUmakefile.am: Add the API break check to 'make check.'
1228         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1229         * gtk/check-gdom-symbols: Removed.
1230         * gtk/webkitdom.py: Added.
1231         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1232         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1233
1234 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1235
1236         Add Jeremy Jones to the contributors list as a contributor.
1237
1238         * Scripts/webkitpy/common/config/contributors.json:
1239
1240 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1241
1242         Unreviewed. Update contact email.
1243         https://bugs.webkit.org/show_bug.cgi?id=129610
1244
1245         * Scripts/webkitpy/common/config/contributors.json:
1246
1247 2014-03-02  Brian Burg  <bburg@apple.com>
1248
1249         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1250         https://bugs.webkit.org/show_bug.cgi?id=129460
1251
1252         Reviewed by Dan Bernstein.
1253
1254         Don't unconditionally open the inspector before running an inspector test.
1255         Instead, the test should request that the inspector open when it's ready.
1256
1257         This change was lost during a rebase, but is the same change made to
1258         DumpRenderTree.
1259
1260         * WebKitTestRunner/TestInvocation.cpp:
1261         (WTR::TestInvocation::invoke): 
1262
1263 2014-03-02  Darin Adler  <darin@apple.com>
1264
1265         Split TextIteratorBehavior into a separate header
1266         https://bugs.webkit.org/show_bug.cgi?id=129578
1267
1268         Reviewed by Sam Weinig.
1269
1270         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1271         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1272         task easy, but the remove is still a bit of a pain.
1273
1274 2014-03-02  Darin Adler  <darin@apple.com>
1275
1276         Sort Mac platform export files so they merge better
1277         https://bugs.webkit.org/show_bug.cgi?id=129581
1278
1279         Reviewed by Sam Weinig.
1280
1281         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1282         Mac export files in a "canonical" order for this project.
1283
1284 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1285
1286         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1287         https://bugs.webkit.org/show_bug.cgi?id=129438
1288
1289         Reviewed by Simon Fraser.
1290
1291         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1292         offscreen window. It makes testing subpixel rendering and positioning possible.
1293
1294         Both the offscreen window's and WebKit's scaling are set accordingly.
1295
1296         * DumpRenderTree/mac/DumpRenderTree.mm:
1297         (createWebViewAndOffscreenWindow): cleanup
1298         (destroyWebViewAndOffscreenWindow): cleanup
1299         (dumpRenderTree):
1300         (changeWindowScaleIfNeeded):
1301         (runTest):
1302         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1303         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1304         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1305         * WebKitTestRunner/PlatformWebView.h:
1306         * WebKitTestRunner/TestInvocation.cpp:
1307         (WTR::changeWindowScaleIfNeeded):
1308         (WTR::TestInvocation::invoke):
1309         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1310         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1311         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1312         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1313         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1314         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1315         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1316         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1317
1318 2014-02-28  Anders Carlsson  <andersca@apple.com>
1319
1320         Remove logging.
1321
1322         Reviewed by Dan Bernstein.
1323
1324         * MiniBrowser/mac/WK2BrowserWindowController.m:
1325         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1326
1327 2014-02-28  Daniel Bates  <dabates@apple.com>
1328
1329         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1330         https://bugs.webkit.org/show_bug.cgi?id=129163
1331
1332         Reviewed by David Kilzer.
1333
1334         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1335         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1336         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1337         bundle.
1338
1339         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1340         which is specified either explicitly when building with MAKE(1) or implicitly by
1341         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1342         the OS X SDK and toolchain since the built products are only applicable to OS X.
1343
1344         * DumpRenderTree/ios/PerlSupport/Makefile:
1345
1346 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1347
1348         Unreviewed, rolling out r164859.
1349         http://trac.webkit.org/changeset/164859
1350         https://bugs.webkit.org/show_bug.cgi?id=129483
1351
1352         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1353         #webkit).
1354
1355         * DumpRenderTree/mac/DumpRenderTree.mm:
1356         (createWebViewAndOffscreenWindow):
1357         (dumpRenderTree):
1358         (runTest):
1359         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1360         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1361         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1362         * WebKitTestRunner/PlatformWebView.h:
1363         * WebKitTestRunner/TestInvocation.cpp:
1364         (WTR::TestInvocation::invoke):
1365         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1366         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1367         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1368         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1369         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1370
1371 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1372
1373         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1374         https://bugs.webkit.org/show_bug.cgi?id=129438
1375
1376         Reviewed by Simon Fraser.
1377
1378         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1379         offscreen window. It makes testing subpixel rendering and positioning possible.
1380
1381         Both the offscreen window's and WebKit's scaling are set accordingly.
1382
1383         * DumpRenderTree/mac/DumpRenderTree.mm:
1384         (createWebViewAndOffscreenWindow): unrelated cleanup.
1385         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1386         (dumpRenderTree):
1387         (changeOffscreenWindowScaleIfNeeded):
1388         (runTest):
1389         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1390         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1391         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1392         * WebKitTestRunner/PlatformWebView.h:
1393         * WebKitTestRunner/TestInvocation.cpp:
1394         (WTR::changeOffscreenWindowScaleIfNeeded):
1395         (WTR::TestInvocation::invoke):
1396         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1397         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1398
1399 2014-02-27  Brian Burg  <bburg@apple.com>
1400
1401         Web Inspector: model tests should use a special Test.html inspector page
1402         https://bugs.webkit.org/show_bug.cgi?id=129190
1403
1404         Reviewed by Timothy Hatcher.
1405
1406         Remove code that immediately opens the Web Inspector based on the file path of the test.
1407         Instead, the test page should request that the inspector open inside its `test()` method.
1408
1409         This change is necessary because otherwise, the inspector would be opened too early for
1410         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1411         will get loaded instead of the minimal test page.
1412
1413         * DumpRenderTree/efl/DumpRenderTree.cpp:
1414         (createTestRunner):
1415         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1416         (runTest):
1417         * DumpRenderTree/mac/DumpRenderTree.mm:
1418         (runTest):
1419         * DumpRenderTree/win/DumpRenderTree.cpp:
1420         (runTest):
1421
1422 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1423
1424         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1425         https://bugs.webkit.org/show_bug.cgi?id=127076
1426
1427         Reviewed by Anders Carlsson.
1428
1429         Avoid match for :: as start of a member initialization list. Modify expression to match
1430         after a colon either non-colon character or end of line.
1431
1432         * Scripts/webkitpy/style/checkers/cpp.py:
1433         (check_member_initialization_list):
1434         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1435         (WebKitStyleTest.test_member_initialization_list):
1436
1437 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1438
1439         Unreviewed. Update my email addresses in contributors.json.
1440
1441         * Scripts/webkitpy/common/config/contributors.json:
1442
1443 2014-02-27  Alberto Garcia  <berto@igalia.com>
1444
1445         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1446         https://bugs.webkit.org/show_bug.cgi?id=128927
1447
1448         Reviewed by Philippe Normand.
1449
1450         Encode manually the data for sys.{stdout,stderr}.write.
1451
1452         * gtk/gtkdoc.py:
1453         (GTKDoc._run_command):
1454
1455 2014-02-27  Andres Gomez  <agomez@igalia.com>
1456
1457         Unreviewed. Add myself to watchlists
1458
1459         * Scripts/webkitpy/common/config/watchlist: Add myself to
1460         watchlists.
1461
1462 2014-02-27  Andres Gomez  <agomez@igalia.com>
1463
1464         Unreviewed, rolling out r164790.
1465         http://trac.webkit.org/changeset/164790
1466
1467         Revert r164790 because of erroneous commit log
1468
1469         * Scripts/webkitpy/common/config/watchlist:
1470
1471 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1472
1473         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1474         https://bugs.webkit.org/show_bug.cgi?id=129250
1475
1476         Reviewed by Mario Sanchez Prada.
1477
1478         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1479         Implementing methods so that we could test column/row headers represented as an array of cells.
1480
1481         * DumpRenderTree/AccessibilityUIElement.cpp:
1482         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1483         (AccessibilityUIElement::columnHeaders):
1484         (AccessibilityUIElement::rowHeaders):
1485         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1486         (AccessibilityUIElement::columnHeaders):
1487         (AccessibilityUIElement::rowHeaders):
1488         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1489         (WTR::AccessibilityUIElement::rowHeaders):
1490         (WTR::AccessibilityUIElement::columnHeaders):
1491         * efl/jhbuild.modules:
1492         * gtk/jhbuild.modules:
1493
1494 2014-02-27  Andres Gomez  <agomez@igalia.com>
1495
1496         Unreviewed. Add myself to watchlists
1497
1498         * Scripts/webkitpy/common/config/watchlist: Add myself to
1499         watchlists.
1500
1501 2014-02-27  Andres Gomez  <agomez@igalia.com>
1502
1503         Unreviewed. Add myself as a committer.
1504
1505         * Scripts/webkitpy/common/config/contributors.json:
1506
1507 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1508
1509         Unreviewed. Add Víctor Jáquez and myself to watchlists
1510
1511         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1512         myself to watchlists.
1513
1514 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1515
1516         Unreviewed. Add myself as a committer.
1517
1518         * Scripts/webkitpy/common/config/contributors.json:
1519
1520 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1521
1522         Unreviewed. Moved myself to the list of committers.
1523
1524         * Scripts/webkitpy/common/config/contributors.json:
1525
1526 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1527
1528         [GTK] Reduplicate common.top_level_path in scripts
1529         https://bugs.webkit.org/show_bug.cgi?id=129291
1530
1531         Reviewed by Philippe Normand.
1532
1533         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1534         path manipulation and weird dependencies on the jhbuild infrastructure.
1535
1536         * Scripts/run-gtk-tests: Use common again.
1537         (TestRunner._setup_testing_environment): Ditto.
1538         * gtk/check-gdom-symbols: Ditto.
1539         * gtk/common.py:
1540         (top_level_path): Re-add top_level_path..
1541         (get_build_path): Use the builtin top_level_path again.
1542         * gtk/find-make-dist-errors: Use common again.
1543         (get_missing_headers): Ditto.
1544         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1545
1546 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1547
1548         runscript: line 42: /bin/ls: Argument list too long
1549         https://bugs.webkit.org/show_bug.cgi?id=129376
1550
1551         Reviewed by Michael Saboff.
1552
1553         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1554         We should use find instead, which generates the list of files rather than expanding them all on 
1555         the command line and spitting them back out.
1556
1557         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1558
1559 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1560
1561         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1562         https://bugs.webkit.org/show_bug.cgi?id=129377
1563
1564         Reviewed by Csaba Osztrogonác.
1565
1566         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1567
1568 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1569
1570         [GTK] Re-enable gtk-doc in EWS
1571         https://bugs.webkit.org/show_bug.cgi?id=128369
1572
1573         Reviewed by Carlos Garcia Campos.
1574
1575         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1576
1577         * Scripts/webkitpy/common/config/ports.py:
1578         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1579         (GtkWK2Port.build_webkit_command): Ditto.
1580         * Scripts/webkitpy/common/config/ports_unittest.py:
1581         (DeprecatedPortTest.test_gtk_port): Ditto.
1582         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1583
1584 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1585
1586         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1587         https://bugs.webkit.org/show_bug.cgi?id=129319
1588
1589         Reviewed by Carlos Garcia Campos.
1590
1591         * gtk/generate-gtkdoc:
1592         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1593
1594 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1595
1596         Unreviewed. Add myself as a committer.
1597
1598         * Scripts/webkitpy/common/config/contributors.json:
1599
1600 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1601
1602         [CSS Grid Layout] Add ENABLE flag
1603         https://bugs.webkit.org/show_bug.cgi?id=129153
1604
1605         Reviewed by Simon Fraser.
1606
1607         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
1608         all ports for developer builds.
1609
1610         * Scripts/webkitperl/FeatureList.pm:
1611
1612 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1613
1614         Added myself as a committer.
1615
1616         Unreviewed.
1617
1618         * Scripts/webkitpy/common/config/contributors.json:
1619
1620 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1621
1622         Unreviewed. Moved myself to the list of committers.
1623
1624         * Scripts/webkitpy/common/config/contributors.json:
1625
1626 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1627
1628         Move myself to the committers list.
1629
1630         Unreviewed.
1631
1632         * Scripts/webkitpy/common/config/contributors.json:
1633
1634 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
1635
1636         Unreviewed. Add myself as a committer.
1637
1638         * Scripts/webkitpy/common/config/contributors.json:
1639
1640 2014-02-25  Commit Queue  <commit-queue@webkit.org>
1641
1642         Unreviewed, rolling out r164639.
1643         http://trac.webkit.org/changeset/164639
1644         https://bugs.webkit.org/show_bug.cgi?id=129302
1645
1646         gtk-doc still have problems in EWS (Requested by rego on
1647         #webkit).
1648
1649         * Scripts/webkitpy/common/config/ports.py:
1650         (GtkPort.build_webkit_command):
1651         (GtkWK2Port.build_webkit_command):
1652         * Scripts/webkitpy/common/config/ports_unittest.py:
1653         (DeprecatedPortTest.test_gtk_port):
1654         (DeprecatedPortTest.test_gtk_wk2_port):
1655
1656 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
1657
1658         [GTK] Re-enable gtk-doc in EWS
1659         https://bugs.webkit.org/show_bug.cgi?id=128369
1660
1661         Reviewed by Carlos Garcia Campos.
1662
1663         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1664
1665         * Scripts/webkitpy/common/config/ports.py:
1666         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1667         (GtkWK2Port.build_webkit_command): Ditto.
1668         * Scripts/webkitpy/common/config/ports_unittest.py:
1669         (DeprecatedPortTest.test_gtk_port): Ditto.
1670         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1671
1672 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1673
1674         [GTK] Mark view source mode methods as deprecated
1675         https://bugs.webkit.org/show_bug.cgi?id=128920
1676
1677         Reviewed by Martin Robinson.
1678
1679         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1680         (beforeAll): Remove view mode test.
1681
1682 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1683
1684         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
1685         https://bugs.webkit.org/show_bug.cgi?id=128417
1686
1687         Reviewed by Carlos Garcia Campos.
1688
1689         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
1690         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
1691         a makefile. This allows accepting a header list from the build system, which can be used
1692         to dynamically build a list of ignored files. We can ignore any source file that doesn't
1693         have a corresponding header file on the header list. 
1694         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
1695         source directories to gtkdoc-scan.
1696
1697 2014-02-24  Anders Carlsson  <andersca@apple.com>
1698
1699         Add a DefaultVisitedLinkProvider and route visited link actions through it
1700         https://bugs.webkit.org/show_bug.cgi?id=129285
1701
1702         Reviewed by Dan Bernstein.
1703
1704         * MiniBrowser/mac/AppDelegate.m:
1705         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1706         Set a shared history so we'll get visited link tracking.
1707
1708         * MiniBrowser/mac/WK1BrowserWindowController.m:
1709         (-[WK1BrowserWindowController awakeFromNib]):
1710         Set a group name.
1711
1712 2014-02-24  Dan Bernstein  <mitz@apple.com>
1713
1714         iOS build fix after r164577.
1715
1716         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1717         (AccessibilityUIElement::selectedChildrenCount):
1718         (AccessibilityUIElement::selectedChildAtIndex):
1719
1720 2014-02-24  David Kilzer  <ddkilzer@apple.com>
1721
1722         [ASan] Remove methods from ignore list that no longer cause crashes
1723         <http://webkit.org/b/129257>
1724
1725         Reviewed by Anders Carlsson.
1726
1727         * asan/webkit-asan-ignore.txt: Remove old methods.
1728
1729 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1730
1731         Extract common parts from jhbuildrc files.
1732         https://bugs.webkit.org/show_bug.cgi?id=125986
1733
1734         Reviewed by Csaba Osztrogonác.
1735
1736         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
1737
1738         * Scripts/run-gtk-tests:
1739         (TestRunner._setup_testing_environment):
1740         * efl/common.py: Removed.
1741         * efl/jhbuildrc:
1742         * gtk/check-gdom-symbols:
1743         * gtk/common.py:
1744         (binary_build_path):
1745         (get_build_path):
1746         * gtk/find-make-dist-errors:
1747         (get_missing_headers):
1748         * gtk/generate-gtkdoc:
1749         (get_webkit2_options):
1750         (get_webkit1_options.src_path):
1751         (get_webkit1_options):
1752         (get_webkitdom_options.src_path):
1753         (get_webkitdom_options):
1754         * gtk/generate-inspector-gresource-manifest.py:
1755         * gtk/jhbuildrc:
1756         * jhbuild/jhbuildrc_common.py: Added.
1757         (script_path):
1758         (top_level_path):
1759         (init):
1760
1761 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
1762
1763         Unreviewed. Fix code indentation and spacing.
1764
1765         * Scripts/webkitpy/style/checkers/js.py:
1766         (SingleQuoteChecker.check):
1767
1768 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
1769
1770         [ATK] Wrong selected element at a given index in a list box.
1771         https://bugs.webkit.org/show_bug.cgi?id=129039
1772
1773         Reviewed by Chris Fleizach.
1774
1775         Added missing implementation and proposed some new function for testing selection
1776         in a list boxes.
1777
1778         * DumpRenderTree/AccessibilityUIElement.cpp:
1779         (setSelectedChildAtIndexCallback):
1780         (removeSelectionAtIndexCallback):
1781         (AccessibilityUIElement::getJSClass):
1782         * DumpRenderTree/AccessibilityUIElement.h:
1783         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1784         (AccessibilityUIElement::selectedChildrenCount):
1785         (AccessibilityUIElement::selectedChildAtIndex):
1786         (AccessibilityUIElement::setSelectedChildAtIndex):
1787         (AccessibilityUIElement::removeSelectionAtIndex):
1788         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1789         (AccessibilityUIElement::selectedChildrenCount):
1790         (AccessibilityUIElement::selectedChildAtIndex):
1791         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1792         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1793         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1794         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1795         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1796         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1797         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1798         (WTR::AccessibilityUIElement::selectedChildrenCount):
1799         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1800         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1801
1802 2014-02-23  Diego Pino García  <dpino@igalia.com>
1803
1804         [GTK] Fix build after Web Inspector code reorganization (r164543)
1805         https://bugs.webkit.org/show_bug.cgi?id=129231
1806
1807         Reviewed by Dean Jackson.
1808
1809         * gtk/generate-inspector-gresource-manifest.py:
1810         Modify paths to Web Inspector code.
1811
1812 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1813
1814         [GTK] generate-gtkdoc should use argparse
1815         https://bugs.webkit.org/show_bug.cgi?id=128418
1816
1817         Reviewed by Carlos Garcia Campos.
1818
1819         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
1820         to all functions, and guard the main routine with a __name__ == __main__ check.
1821
1822 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1823
1824         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
1825         https://bugs.webkit.org/show_bug.cgi?id=129191
1826
1827         Reviewed by Anders Carlsson.
1828
1829         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
1830         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
1831         name of the directory is "lib" and not "libs". Instead we should use the CMake
1832         variable specifically assigned to this task.
1833
1834 2014-02-23  David Kilzer  <ddkilzer@apple.com>
1835
1836         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
1837         <http://webkit.org/b/129209>
1838
1839         Reviewed by Geoffrey Garen.
1840
1841         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
1842         ignore list to make ASan builds usable again.  Follow-up
1843         investigation is tracked by <rdar://problem/16055903>.
1844
1845 2014-02-20  David Farler  <dfarler@apple.com>
1846
1847         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
1848         https://bugs.webkit.org/show_bug.cgi?id=128622
1849
1850         Reviewed by Simon Fraser.
1851
1852         With this change, we now have layout tests running in both DumpRenderTree
1853         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
1854         simulator.
1855
1856         * Scripts/old-run-webkit-tests:
1857         In general, make any specific reference to DumpRenderTree
1858         able to refer to WebKitTestRunner wherever possible:
1859         - Rename functions to remove DRT-specific naming.
1860         - Name FIFOs after the tool that is being used.
1861         -- Clean up FIFO creation code
1862         Other necessary changes:
1863         - Allow use of an ios-sim-wk2 platform.
1864         - Clean up platform hierarchy creation where the simulator platform behavior differed.
1865         * WebKitTestRunner/TestController.cpp:
1866         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
1867         (WTR::TestController::TestController):
1868         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1869         Copy the injected bundle into the app bundle.
1870
1871 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
1872
1873         run-webkit-httpd fails to find httpd configuation file.
1874
1875         Reviewed by Ryosuke Niwa.
1876
1877         * Scripts/webkitperl/httpd.pm:
1878         (getHTTPDConfigPathForTestDirectory):
1879
1880 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
1881
1882         Fix TimeRanges layering violations
1883         https://bugs.webkit.org/show_bug.cgi?id=128717
1884
1885         Reviewed by Jer Noble.
1886
1887         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
1888         (TestWebKitAPI::TEST):
1889
1890 2014-02-21  Diego Pino García  <dpino@igalia.com>
1891
1892         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
1893         https://bugs.webkit.org/show_bug.cgi?id=128422
1894
1895         Reviewed by Joseph Pecoraro.
1896
1897         * Scripts/webkitpy/style/checkers/js.py:
1898         (JSChecker.__init__):
1899         (JSChecker.check):
1900         (SingleQuoteChecker):
1901         (SingleQuoteChecker.__init__):
1902         (SingleQuoteChecker.check):
1903         * Scripts/webkitpy/style/checkers/js_unittest.py:
1904         (JSTestCase.assertError.error_for_test):
1905         (JSTestCase.assertError):
1906         (JSTestCase.test_no_error):
1907         (JSTestCase.test_error):
1908
1909 == Rolled over to ChangeLog-2014-02-20 ==