Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32)...
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-13  Sam Weinig  <weinig@apple.com>
2
3         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
4         https://bugs.webkit.org/show_bug.cgi?id=200675
5
6         Reviewed by Darin Adler.
7
8         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
9         (TestWebKitAPI::TEST):
10         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
11
12 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
13
14         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
15         https://bugs.webkit.org/show_bug.cgi?id=200456
16
17         Reviewed by Jonathan Bedard.
18
19         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
20
21         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
22
23         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
24         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
25         (pointPolygonCollisionDetect): Detact
26         (pointRightRayLineSegmentCollisionDetect):
27         (ColorBatchRender):
28         (ColorBatchRender.prototype.lazyCreateColorSeqs):
29         (ColorBatchRender.prototype.addSeq):
30         (ColorBatchRender.prototype.batchRender):
31         (ColorBatchRender.prototype.clear):
32         (xScrollStreamRenderFactory):
33         (Timeline.CanvasSeriesComponent):
34         (offscreenCachedRenderFactory): Deleted.
35
36 2019-08-13  John Wilander  <wilander@apple.com>
37
38         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
39         https://bugs.webkit.org/show_bug.cgi?id=200642
40         <rdar://problem/53962073>
41
42         Reviewed by Alex Christensen.
43
44         This patch adds test infrastructure to query whether an origin has an
45         isolated NSURLSession or not.
46
47         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
48         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
49         (WTR::TestRunner::hasStatisticsIsolatedSession):
50         * WebKitTestRunner/InjectedBundle/TestRunner.h:
51         * WebKitTestRunner/TestController.cpp:
52         (WTR::TestController::hasStatisticsIsolatedSession):
53         * WebKitTestRunner/TestController.h:
54         * WebKitTestRunner/TestInvocation.cpp:
55         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
56
57 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
58
59         Update my status in contributors.json to committer.
60
61         Reviewed by Unreviewed
62
63         * Scripts/webkitpy/common/config/contributors.json:
64
65 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
66
67         Adds WebAuthn and AppSSO into watchlist
68         https://bugs.webkit.org/show_bug.cgi?id=200647
69
70         Reviewed by Dewei Zhu.
71
72         * Scripts/webkitpy/common/config/watchlist:
73
74 2019-08-13  Chris Dumez  <cdumez@apple.com>
75
76         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
77         https://bugs.webkit.org/show_bug.cgi?id=200674
78         <rdar://problem/50692748>
79
80         Reviewed by Geoff Garen.
81
82         Add API test coverage.
83
84         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
85
86 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
87
88         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
89         https://bugs.webkit.org/show_bug.cgi?id=199857
90
91         Reviewed by Yusuke Suzuki.
92
93         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
94         (TestWebKitAPI::countThreadGroups):
95         (TestWebKitAPI::TEST):
96
97 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
98
99         AX: Homebrew is not allowed to run any script under sudo.
100         https://bugs.webkit.org/show_bug.cgi?id=173801
101
102         Reviewed by Carlos Alberto Lopez Perez.
103
104         Latest versions of Homebrew throw an error when run as root.
105         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
106
107         * gtk/install-dependencies:
108
109 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
110
111         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
112         https://bugs.webkit.org/show_bug.cgi?id=200644
113
114         Reviewed by Aakash Jain.
115
116         * Scripts/webkitpy/port/simulator_process.py:
117         (SimulatorProcess._start): Define system PID after launching app.
118
119 2019-08-12  Sam Weinig  <weinig@apple.com>
120
121         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
122         https://bugs.webkit.org/show_bug.cgi?id=200614
123
124         Reviewed by Darin Adler.
125
126         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
127         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
128         
129         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
130         StringBuilder::appendSubstring(...).
131
132         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
133         (TestWebKitAPI::TEST):
134         Update for renames.
135
136 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
137
138         Fix Crash in Mail Search
139         https://bugs.webkit.org/show_bug.cgi?id=200589
140
141         Reviewed by Tim Horton.
142
143         If you search backwards first in mail, we would crash,
144         this tests that codepath.
145
146         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
147         (TEST):
148
149 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
150
151         [iPadOS] Web pages sometimes load at half width in Safari
152         https://bugs.webkit.org/show_bug.cgi?id=200624
153         <rdar://problem/52694257>
154
155         Reviewed by Simon Fraser.
156
157         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
158         web page is created using the post-animated-resize web view dimensions, rather than the original layout
159         dimensions.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
162
163 2019-08-12  Daniel Bates  <dabates@apple.com>
164
165         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
166         https://bugs.webkit.org/show_bug.cgi?id=200548
167
168         Reviewed by Darin Adler.
169
170         Expose infrastructure to simulate a literal raw key down and a literal key up event.
171
172         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
173         * TestRunnerShared/UIScriptContext/UIScriptController.h:
174         (WTR::UIScriptController::rawKeyDown):
175         (WTR::UIScriptController::rawKeyUp):
176         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
177         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
178         (WTR::UIScriptControllerIOS::rawKeyDown):
179         (WTR::UIScriptControllerIOS::rawKeyUp):
180
181 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
182
183         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
184         https://bugs.webkit.org/show_bug.cgi?id=200584
185
186         Reviewed by Philippe Normand.
187
188         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
189         Ignore style libwebrtc optionnal 'style issue'
190
191         * Scripts/webkitpy/style/checker.py:
192         * gstreamer/jhbuild.modules:
193         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
194
195 2019-08-12  Youenn Fablet  <youenn@apple.com>
196
197         Remove IDB-specific quota
198         https://bugs.webkit.org/show_bug.cgi?id=196545
199
200         Reviewed by Alex Christensen.
201
202         * DumpRenderTree/TestRunner.cpp:
203         (TestRunner::staticFunctions):
204         (setIDBPerOriginQuotaCallback): Deleted.
205         * DumpRenderTree/TestRunner.h:
206         * DumpRenderTree/mac/DumpRenderTree.mm:
207         (runTest):
208         * DumpRenderTree/mac/TestRunnerMac.mm:
209         (TestRunner::setIDBPerOriginQuota): Deleted.
210         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
212         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
214         * WebKitTestRunner/TestController.cpp:
215         (WTR::TestController::resetStateToConsistentValues):
216         (WTR::TestController::setIDBPerOriginQuota): Deleted.
217         * WebKitTestRunner/TestController.h:
218         * WebKitTestRunner/TestInvocation.cpp:
219         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
220
221 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
222
223         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
224         https://bugs.webkit.org/show_bug.cgi?id=200621
225
226         Reviewed by Dan Bernstein.
227
228         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
229
230 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
231
232         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
233         https://bugs.webkit.org/show_bug.cgi?id=200604
234         <rdar://problem/51273130>
235
236         Reviewed by Megan Gardner.
237
238         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
239         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
240         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
241         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
242         remains the same.
243
244         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
245         the caret rect at initial scale 1.
246
247         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
248
249 2019-08-09  Ali Juma  <ajuma@chromium.org>
250
251         Don't allow cross-origin iframes to autofocus
252         https://bugs.webkit.org/show_bug.cgi?id=200515
253         <rdar://problem/54092988>
254
255         Reviewed by Ryosuke Niwa.
256
257         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
258         of cross-origin iframes, since it depends on focusing one of the
259         frames.
260
261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
262         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
265
266 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
267
268         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
269         https://bugs.webkit.org/show_bug.cgi?id=200591
270         <rdar://problem/54102238>
271
272         Reviewed by Ryosuke Niwa and Tim Horton.
273
274         Add a new API test to exercise -supportsImagePaste.
275
276         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/ios/UIKitSPI.h:
279
280 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
281
282         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
283         [ews-build] Set svn:ignore to various EWS Buildbot files
284         https://bugs.webkit.org/show_bug.cgi?id=200581
285
286         Reviewed by Jonathan Bedard.
287
288         * BuildSlaveSupport/ews-build: Added property svn:ignore.
289
290 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
291
292         [ews-build] Set svn:ignore to various EWS Buildbot files
293         https://bugs.webkit.org/show_bug.cgi?id=200581
294
295         Reviewed by Jonathan Bedard.
296
297         * BuildSlaveSupport/ews-build: Added property svn:ignore.
298
299 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
300
301         [ews] Add buildbot.tac to repository
302         https://bugs.webkit.org/show_bug.cgi?id=200580
303
304         Reviewed by Jonathan Bedard.
305
306         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
307
308 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
309
310         [GTK] Add missing spellchecking packages to dependencies script
311         https://bugs.webkit.org/show_bug.cgi?id=200574
312
313         Reviewed by Philippe Normand.
314
315         These are needed for the spellchecking test in WebContext API tests.
316
317         * gtk/install-dependencies:
318
319 2019-08-08  Jon Lee  <jonlee@apple.com>
320
321         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
322
323 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
324
325         webkitpy: Disable shared clipboard between Simulators
326         https://bugs.webkit.org/show_bug.cgi?id=200546
327
328         Reviewed by Aakash Jain.
329
330         * Scripts/webkitpy/xcode/simulated_device.py:
331         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
332         managed by run-webkit-tests.
333
334 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
335
336         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
337         https://bugs.webkit.org/show_bug.cgi?id=200539
338         <rdar://problem/54082550>
339
340         Reviewed by Dean Jackson.
341
342         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
343         * PlatformFTW.cmake: Added.
344
345 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
346
347         [iOS] Position image information should respect the image orientation
348         https://bugs.webkit.org/show_bug.cgi?id=200487
349
350         Reviewed by Simon Fraser.
351
352         Add an API test to verify the position image information is drawn rotated
353         because of respecting its image orientation.
354
355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
356         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
357         (TestWebKitAPI::TEST):
358         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
359         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
360
361 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
362
363         [GTK] Fix WebContext languages test
364         https://bugs.webkit.org/show_bug.cgi?id=200538
365
366         Reviewed by Alex Christensen.
367
368         This test broke after the format of Accepted-Languages
369         was changed in r238236, update.
370
371         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
372         (testWebContextLanguages):
373
374 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
375
376         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
377         https://bugs.webkit.org/show_bug.cgi?id=200536
378
379         Reviewed by Carlos Alberto Lopez Perez.
380
381         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
382         (testWebsiteDataDatabases): Databases take a moment to be written,
383         wait before fetching the data as it's done in other tests.
384
385 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
386
387         results.webkit.org: Use canvas for timeline
388         https://bugs.webkit.org/show_bug.cgi?id=200172
389
390         Rubber-stamped by Aakash Jain.
391
392         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
393         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
394         (Commit.compare): Ditto.
395         (_CommitBank.commitByUuid): Ditto.
396         (_CommitBank._loadSiblings): Ditto.
397         (_CommitBank._load): Ditto.
398         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
399         (tickForCommit): Deleted.
400         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
401         which encompasses all results. Crucially, this function must exclude an UUIDs which may
402         refer to results excluded because of the limit argument.
403         (renderTimeline): Deleted.
404         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
405         with those results.
406         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
407         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
408         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
409         (inPlaceCombine): Combine result objects together.
410         (statsForSingleResult): Turn a single result into a stat object.
411         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
412         (Dot): Deleted.
413         (TimelineFromEndpoint): Renamed from Timeline.
414         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
415         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
416         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
417         cache contents.
418         (TimelineFromEndpoint.reload): Remove management of nested timelines.
419         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
420         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
421         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
422
423 2019-08-08  Brady Eidson  <beidson@apple.com>
424
425         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
426         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
427
428         Reviewed by Geoff Garen.
429
430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
431         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
432
433 2019-08-08  Rob Buis  <rbuis@igalia.com>
434
435         Add runtime flag for lazy image loading
436         https://bugs.webkit.org/show_bug.cgi?id=199794
437
438         Reviewed by Darin Adler.
439
440         Set lazyImageLoading preference as part of experimental features. Add
441         TestOption for lazy image loading.
442
443         * DumpRenderTree/TestOptions.cpp:
444         (TestOptions::TestOptions):
445         * DumpRenderTree/TestOptions.h:
446         * DumpRenderTree/mac/DumpRenderTree.mm:
447         (enableExperimentalFeatures):
448         (setWebPreferencesForTestOptions):
449         * DumpRenderTree/win/DumpRenderTree.cpp:
450         (enableExperimentalFeatures):
451
452 2019-08-08  Rob Buis  <rbuis@igalia.com>
453
454         Import lazy loading WPT tests
455         https://bugs.webkit.org/show_bug.cgi?id=199795
456
457         Reviewed by Darin Adler.
458
459         Only do loading/ exception for WebKit specific, non WPT tests.
460
461         * DumpRenderTree/mac/DumpRenderTree.mm:
462         (shouldLogFrameLoadDelegates):
463         * WebKitTestRunner/TestInvocation.cpp:
464         (WTR::TestInvocation::TestInvocation):
465
466 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
467
468         [Win][MiniBrowser] Add key accelerators for reload and close window
469         https://bugs.webkit.org/show_bug.cgi?id=200497
470
471         Reviewed by Brent Fulgham.
472
473         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
474
475         * MiniBrowser/win/MainWindow.cpp:
476         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
477         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
478         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
479
480 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
481
482         Add WHLSL and WebGPU to the watchlist file
483         https://bugs.webkit.org/show_bug.cgi?id=200509
484
485         Reviewed by Robin Morisset.
486
487         * Scripts/webkitpy/common/config/watchlist:
488
489 2019-08-07  Keith Rollin  <krollin@apple.com>
490
491         Unreviewed build fix after r248317 -- disable XCBuild because it
492         breaks incremental builds.
493
494         * Scripts/webkitdirs.pm:
495         (canUseXCBuild):
496
497 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
498
499         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
500         https://bugs.webkit.org/show_bug.cgi?id=200465
501
502         Reviewed by Alex Christensen.
503
504         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
505         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
506         finishing the test.
507         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
508         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
509
510 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
511
512         Unreviewed, a build fix after r248308
513
514         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
515
516         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
517
518 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
519
520         Unreviewed, a build fix after r248319
521
522         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
523
524         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
525         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
526         (WTR::TestController::addTestKeyToKeychain):
527         (WTR::TestController::cleanUpKeychain):
528         (WTR::TestController::keyExistsInKeychain):
529
530 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
531
532         Unreviewed, a build fix after r248308
533
534         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
535
536         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
537         (WTR::TestController::addTestKeyToKeychain):
538         (WTR::TestController::cleanUpKeychain):
539         (WTR::TestController::keyExistsInKeychain):
540
541 2019-08-06  Keith Rollin  <krollin@apple.com>
542
543         Enable XCBuild for `make` and `build-webkit` builds
544         https://bugs.webkit.org/show_bug.cgi?id=200476
545         <rdar://problem/50771065>
546
547         Reviewed by Jonathan Bedard.
548
549         All projects have now been tested under XCBuild and successfully
550         build. Enable the use of XCBuild when performing builds with `make` or
551         `build-webkit` and when using a sufficient version of Xcode. We set
552         this version to Xcode 11 since Xcode 10 -- even though it supports
553         XCBuild -- does not support a build facility needed to build WebKit
554         (Bug 197072, Bug 197116, Bug 197340).
555
556         Do not enable XCBuild in the Xcode projects themselves since these
557         projects may need to be used under older versions of Xcode and there's
558         no way to make those project changes sensitive to the version of Xcode
559         being used. This means that builds performed in the Xcode IDE will not
560         use XCBuild.
561
562         * Scripts/webkitdirs.pm:
563         (canUseXCBuild):
564
565 2019-08-06  Chris Dumez  <cdumez@apple.com>
566
567         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
568         https://bugs.webkit.org/show_bug.cgi?id=200475
569
570         Reviewed by Darin Adler.
571
572         * TestWebKitAPI/Tests/WTF/StringView.cpp:
573         (TestWebKitAPI::stringViewFromLiteral):
574         (TestWebKitAPI::stringViewFromUTF8):
575
576 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
577
578         Update my status in contributors.json to reviewer.
579
580         Regained the status after following the procedure for inactive contributors.
581         See r247136 for further explanation.
582
583         * Scripts/webkitpy/common/config/contributors.json:
584
585 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
586
587         [WebAuthN] Enable LocalAuthenticator for macOS
588         https://bugs.webkit.org/show_bug.cgi?id=182772
589         <rdar://problem/43347920>
590
591         Reviewed by Brent Fulgham.
592
593         Add an entitlement file to WebKitTestRunner such that it can access
594         the modern macOS keychain.
595
596         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
597         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
598         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
599         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
600         (WTR::TestController::addTestKeyToKeychain):
601         (WTR::TestController::cleanUpKeychain):
602         (WTR::TestController::keyExistsInKeychain):
603
604 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
605
606         [results.webkit.org Timeline] Performance improvements
607         https://bugs.webkit.org/show_bug.cgi?id=200406
608
609         Reviewed by Jonathan Bedard.
610
611         1. Unhook the scroll event when a series/axis have been removed from the container
612         2. Fix the axis's cache data structure out of sync.
613         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
614         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
615
616
617         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
618         (Signal.prototype.removeListener):
619         (prototype.stopAction): Unregsiter an action handler
620         (Ref):
621         (Ref.prototype.apply):
622         (Ref.prototype.destory):
623         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
624         (ApplyNewChildren):
625         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
626         (Timeline.CanvasSeriesComponent):
627
628 2019-08-06  Jer Noble  <jer.noble@apple.com>
629
630         Add test for behavior introduced in r248174
631         https://bugs.webkit.org/show_bug.cgi?id=200446
632
633         Reviewed by Eric Carlson.
634
635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
636         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
637         (WebKit::configureSecheuristic):
638         (WebKit::TEST):
639
640 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
641
642         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
643         https://bugs.webkit.org/show_bug.cgi?id=200464
644
645         Reviewed by Ross Kirsling.
646
647         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
648         menu, Alt-F4 to close window, and etc) don't work.
649
650         WK1 WebView doesn't have this issue because it processes key events
651         properly.
652
653         * MiniBrowser/win/WebKitBrowserWindow.cpp:
654         (WebKitBrowserWindow::WebKitBrowserWindow):
655         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
656         unhandled key events to the main window.
657         * MiniBrowser/win/WebKitBrowserWindow.h:
658
659 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
660
661         iOS 13: Overflow:hidden on body prevents PDF scroll
662         https://bugs.webkit.org/show_bug.cgi?id=200435
663         rdar://problem/53942888
664
665         Reviewed by Tim Horton.
666
667         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
668         to make sure that the scroll view is scrollable.
669
670         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
671         (TestWebKitAPI::TEST):
672
673 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
674
675         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
676         https://bugs.webkit.org/show_bug.cgi?id=200400
677
678         Reviewed by Jonathan Bedard.
679
680         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
681         (StatusBubble._build_bubble):
682         (StatusBubble._queue_position):
683
684 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
685
686         run-webkit-tests asserts when the iPhone XR simulator is running
687         https://bugs.webkit.org/show_bug.cgi?id=200404
688         <rdar://problem/53878739>
689
690         Reviewed by Dean Jackson.
691
692         Support unicode in all logging statements tied to device model.
693
694         * Scripts/webkitpy/layout_tests/controllers/manager.py:
695         (Manager.run):
696         * Scripts/webkitpy/layout_tests/views/printing.py:
697         (Printer.print_baseline_search_path):
698         * Scripts/webkitpy/port/device.py:
699         (Device.__repr__):
700         * Scripts/webkitpy/port/device_port.py:
701         (DevicePort._install):
702         (DevicePort.setup_test_run):
703         (DevicePort.clean_up_test_run):
704         (DevicePort.configuration_for_upload):
705         * Scripts/webkitpy/port/ios.py:
706         (IOSPort.default_baseline_search_path):
707         * Scripts/webkitpy/xcode/device_type.py:
708         (DeviceType.__str__):
709         * Scripts/webkitpy/xcode/simulated_device.py:
710         (SimulatedDeviceManager.populate_available_devices):
711         (SimulatedDeviceManager._find_available_name):
712         (SimulatedDeviceManager._get_device_identifier_for_type):
713         (SimulatedDeviceManager._create_or_find_device_for_request):
714         (SimulatedDeviceManager._does_fulfill_request):
715         (SimulatedDeviceManager._wait_until_device_in_state):
716         (SimulatedDeviceManager._wait_until_device_is_usable):
717         (SimulatedDeviceManager._boot_device):
718         (SimulatedDeviceManager.initialize_devices):
719         (SimulatedDeviceManager.max_supported_simulators):
720         (SimulatedDeviceManager.swap):
721         (SimulatedDevice.is_usable):
722         (SimulatedDevice._shut_down):
723         (SimulatedDevice._delete):
724         (SimulatedDevice.launch_app):
725         (SimulatedDevice.__repr__):
726
727 2019-08-04  Chris Dumez  <cdumez@apple.com>
728
729         Ping loads should not prevent page caching
730         https://bugs.webkit.org/show_bug.cgi?id=200418
731         <rdar://problem/53901632>
732
733         Reviewed by Darin Adler.
734
735         Add TestOption to enable PageCache at UIProcess-level so that we can test
736         page caching when navigating cross-origin with PSON enabled.
737
738         * WebKitTestRunner/TestController.cpp:
739         (WTR::TestController::resetPreferencesToConsistentValues):
740         (WTR::updateTestOptionsFromTestHeader):
741         * WebKitTestRunner/TestOptions.h:
742         (WTR::TestOptions::hasSameInitializationOptions const):
743
744 2019-08-02  Keith Rollin  <krollin@apple.com>
745
746         Consistently use Obj-C boolean literals
747         https://bugs.webkit.org/show_bug.cgi?id=200405
748         <rdar://problem/53880043>
749
750         Reviewed by Simon Fraser, Joseph Pecoraro.
751
752         There are places where we use equivalent but different expressions for
753         Obj-C boolean objects. For example, we use both [NSNumber
754         numberWithBool:YES] and @YES. There are places where both are used in
755         the same function, such as -[WebPreferences initialize]. The boolean
756         literal is in greater use and is more succinct, so standardize on
757         that. Also, change @(YES/NO) to @YES/NO.
758
759         * DumpRenderTree/mac/ObjCController.m:
760         (-[ObjCController objectOfClass:]):
761         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
762         (TEST):
763         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
764         (overrideAddObserverForName):
765         * TestWebKitAPI/ios/mainIOS.mm:
766         (main):
767         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
768         (TestWebKitAPI::InjectedBundleController::platformInitialize):
769         * TestWebKitAPI/mac/mainMac.mm:
770         (main):
771         * WebKitLauncher/WebKitNightlyEnabler.m:
772         (enableWebKitNightlyBehaviour):
773
774 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
775
776         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
777         https://bugs.webkit.org/show_bug.cgi?id=200402
778         <rdar://problem/53823368>
779
780         Reviewed by Tim Horton.
781
782         Make it possible to run this test using the iPad simulator.
783
784         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
785
786         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
787         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
788         since this would result in differently sized text.
789
790         (mainScreenReferenceBoundsOverride):
791         * TestWebKitAPI/ios/UIKitSPI.h:
792
793 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
794
795         API tests using permanent credentials should clear credentials left by previous tests
796         https://bugs.webkit.org/show_bug.cgi?id=199729
797
798         Reviewed by Alex Christensen.
799
800         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
801         credentials will not affect tests running after. There is a case where permanent credentials were left on the
802         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
803         failure. To prevent this from happening again, add cleanup at the begining of the tests.
804
805         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
806         (TEST):
807         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
808         (TestWebKitAPI::TEST):
809
810 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
811
812         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
813         https://bugs.webkit.org/show_bug.cgi?id=200394
814         <rdar://problem/52914964>
815
816         Reviewed by Chris Fleizach.
817
818         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
819
820         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
821         (WTR::AccessibilityUIElement::isInTableCell const):
822         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
823         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
824         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
825         (WTR::AccessibilityUIElement::isInTableCell const):
826
827 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
828
829         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
830         https://bugs.webkit.org/show_bug.cgi?id=200397
831
832         Reviewed by Jonathan Bedard.
833
834         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
835
836 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
837
838         [macOS 10.15] Image dragged from Safari does not appear in Notes
839         https://bugs.webkit.org/show_bug.cgi?id=188490
840         <rdar://problem/39462717>
841
842         Reviewed by Andy Estes.
843
844         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
845
846         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
847
848 2019-08-02  Alex Christensen  <achristensen@webkit.org>
849
850         Fix API test after r248139
851         https://bugs.webkit.org/show_bug.cgi?id=200102
852
853         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
854         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
855         This was supposed to be removed as part of reverting r245322.
856
857 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
858
859         results.webkit.org: Force update cache when timeline updated
860         https://bugs.webkit.org/show_bug.cgi?id=200363
861
862         Reviewed by Jonathan Bedard.
863
864         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
865         (offscreenCachedRenderFactory): Add ability to force the redraw.
866         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
867         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
868
869 2019-08-01  Alex Christensen  <achristensen@webkit.org>
870
871         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
872         https://bugs.webkit.org/show_bug.cgi?id=200360
873
874         Reviewed by Tim Horton.
875
876         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
877         (cleanupITPDatabase):
878         (TEST):
879
880 2019-08-01  Alex Christensen  <achristensen@webkit.org>
881
882         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
883         https://bugs.webkit.org/show_bug.cgi?id=200102
884         <rdar://problem/53275114>
885
886         Reviewed by Darin Adler.
887
888         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
889         and because clicking on a TestWKWebView only works on Mac.
890
891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
892         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
893         (-[UploadDelegate initWithDirectory:]):
894         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
895         (-[UploadDelegate sentDirectory]):
896         (TEST):
897         * TestWebKitAPI/cocoa/TestWKWebView.h:
898         * TestWebKitAPI/cocoa/TestWKWebView.mm:
899         (-[TestWKWebView sendClickAtPoint:]):
900
901 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
902
903         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
904         https://bugs.webkit.org/show_bug.cgi?id=200321
905
906         Reviewed by Jonathan Bedard.
907
908         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
909         Let the axis' height be defined in the option. Timeine component will use this value as
910         padding-top for headers which allows headers start in the right position, even with multiple
911         top axises.
912         (Timeline.CanvasSeriesComponent):
913         (prototype.Timeline.CanvasContainer):
914
915 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
916
917         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
918         https://bugs.webkit.org/show_bug.cgi?id=200347
919
920         Reviewed by Jonathan Bedard.
921
922         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
923         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
924
925 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
926
927         Improve flakiness of SOAuthorizationRedirect tests
928         https://bugs.webkit.org/show_bug.cgi?id=200320
929         <rdar://problem/53767057>
930
931         Reviewed by Alex Christensen.
932
933         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
934         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
935         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
936         is executed.
937
938         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
939         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
940         (resetState):
941         (TestWebKitAPI::TEST):
942
943 2019-08-01  Keith Rollin  <krollin@apple.com>
944
945         Update TestWebKitAPI for XCBuild
946         https://bugs.webkit.org/show_bug.cgi?id=200311
947         <rdar://problem/53773804>
948
949         Reviewed by Alex Christensen.
950
951         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
952         technique. Now update WebKitLegacy to build under XCBuild after those
953         changes. This work involves adding an "Apply Configuration to
954         XCFileLists" build target, adding a check-xcfilelists.sh script,
955         adding a "Check xcfilelists" build phase that calls that script,
956         adding knowledge of the project to the generate-xcfilelists script,
957         creating new .xcfilelist files, and adding those to the project.
958
959         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
960         (Application.__init__):
961         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
962         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
963         (TestWebKitAPIGenerator):
964         (TestWebKitAPIGenerator._get_project_file_path):
965         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
966         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
968         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
969
970 2019-08-01  Youenn Fablet  <youenn@apple.com>
971
972         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
973         https://bugs.webkit.org/show_bug.cgi?id=200317
974
975         Reviewed by Eric Carlson.
976
977         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
979         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
980         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
981         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
982         (TestWebKitAPI::TEST):
983
984 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
985
986         New EWS: Cannot see build status page when patch is waiting for tester
987         https://bugs.webkit.org/show_bug.cgi?id=200333
988
989         Reviewed by Jonathan Bedard.
990
991         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
992         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
993
994 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
995
996         [SOUP] Switch to use libsoup WebSockets API
997         https://bugs.webkit.org/show_bug.cgi?id=200162
998
999         Reviewed by Michael Catanzaro.
1000
1001         Update libsoup version to 2.67.90.
1002
1003         * gtk/jhbuild.modules:
1004         * wpe/jhbuild.modules:
1005
1006 2019-07-31  Andy Estes  <aestes@apple.com>
1007
1008         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
1009         https://bugs.webkit.org/show_bug.cgi?id=200293
1010         <rdar://problem/52937749>
1011
1012         Reviewed by Alex Christensen.
1013
1014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1015         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
1016         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1017         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1018         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
1019         (TEST):
1020
1021 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
1022
1023         [ews-build] Enable all macOS queues on new EWS
1024         https://bugs.webkit.org/show_bug.cgi?id=199944
1025
1026         Reviewed by Jonathan Bedard.
1027
1028         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
1029         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1030         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
1031         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
1032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
1033         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
1034
1035 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1036
1037         Unreviewed test gardening, disable failing test for rdar://51752593.
1038
1039         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1040
1041 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
1042
1043         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
1044         https://bugs.webkit.org/show_bug.cgi?id=200318
1045
1046         Reviewed by Aakash Jain.
1047
1048         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1049         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
1050         (Timeline.CanvasXAxisComponent): Use getLabel function.
1051
1052 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
1053
1054         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
1055         https://bugs.webkit.org/show_bug.cgi?id=200306
1056
1057         Reviewed by Michael Catanzaro.
1058
1059         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
1060         jsc-glib-4.0-scan for example).
1061
1062         * Scripts/webkitdirs.pm:
1063         (generateBuildSystemFromCMakeProject):
1064
1065 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1066
1067         Unreviewed test gardening, disable failing test for rdar://52355829.
1068
1069         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1070         (TEST):
1071
1072 2019-07-31  Keith Rollin  <krollin@apple.com>
1073
1074         Update WebKitLegacy for XCBuild
1075         https://bugs.webkit.org/show_bug.cgi?id=200310
1076         <rdar://problem/53773708>
1077
1078         Reviewed by Alex Christensen.
1079
1080         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
1081         technique. Now update WebKitLegacy to build under XCBuild after those
1082         changes. This work involves adding an "Apply Configuration to
1083         XCFileLists" build target, adding a check-xcfilelists.sh script,
1084         adding a "Check xcfilelists" build phase that calls that script,
1085         adding knowledge of the project to the generate-xcfilelists script,
1086         creating new .xcfilelist files, and adding those to the project.
1087
1088         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1089         (Application.__init__):
1090         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1091         (JavaScriptCoreGenerator):
1092         (WebCoreGenerator):
1093         (WebKitGenerator):
1094         (WebKitGenerator._get_generate_unified_sources_script):
1095         (WebKitLegacyGenerator):
1096         (WebKitLegacyGenerator._get_project_file_path):
1097         (WebKitLegacyGenerator._get_generate_unified_sources_script):
1098
1099 2019-07-31  Chris Dumez  <cdumez@apple.com>
1100
1101         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1102         https://bugs.webkit.org/show_bug.cgi?id=200086
1103         <rdar://problem/53501721>
1104
1105         Reviewed by Alex Christensen.
1106
1107         re-enable the API test.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1110         (TEST):
1111
1112 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1113
1114         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
1115         https://bugs.webkit.org/show_bug.cgi?id=200291
1116         <rdar://problem/53717946>
1117
1118         Reviewed by Megan Gardner.
1119
1120         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
1121         after closing the web view, while the web view's content view isn't the first responder.
1122
1123         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
1124         * TestWebKitAPI/ios/UIKitSPI.h:
1125
1126 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1127
1128         [GTK] Datalist element support for TextFieldInputType
1129         https://bugs.webkit.org/show_bug.cgi?id=98934
1130
1131         Reviewed by Michael Catanzaro.
1132
1133         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
1134
1135         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1136         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
1137         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
1138
1139 2019-07-30  Tim Horton  <timothy_horton@apple.com>
1140
1141         Remove some needless comments that snuck into the tree
1142
1143         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1144         (WTR::UIScriptController::setHardwareKeyboardAttached):
1145         (WTR::UIScriptController::playBackEventStream):
1146
1147 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1148
1149         [WebKit] Add PageLoadState::Observer C API
1150         https://bugs.webkit.org/show_bug.cgi?id=199848
1151
1152         Reviewed by Alex Christensen.
1153
1154         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1155         (WebKitBrowserWindow::WebKitBrowserWindow):
1156         (WebKitBrowserWindow::didChangeTitle):
1157         (WebKitBrowserWindow::didFinishNavigation): Deleted.
1158         * MiniBrowser/win/WebKitBrowserWindow.h:
1159         * TestWebKitAPI/CMakeLists.txt:
1160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1161         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
1162         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
1163         (TestWebKitAPI::didChangeActiveURL):
1164         (TestWebKitAPI::didChangeCanGoBack):
1165         (TestWebKitAPI::didChangeCanGoForward):
1166         (TestWebKitAPI::didChangeCertificateInfo):
1167         (TestWebKitAPI::didChangeEstimatedProgress):
1168         (TestWebKitAPI::didChangeHasOnlySecureContent):
1169         (TestWebKitAPI::didChangeIsLoading):
1170         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
1171         (TestWebKitAPI::didChangeTitle):
1172         (TestWebKitAPI::didChangeWebProcessIsResponsive):
1173         (TestWebKitAPI::didSwapWebProcesses):
1174         (TestWebKitAPI::willChangeActiveURL):
1175         (TestWebKitAPI::willChangeCanGoBack):
1176         (TestWebKitAPI::willChangeCanGoForward):
1177         (TestWebKitAPI::willChangeCertificateInfo):
1178         (TestWebKitAPI::willChangeEstimatedProgress):
1179         (TestWebKitAPI::willChangeHasOnlySecureContent):
1180         (TestWebKitAPI::willChangeIsLoading):
1181         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
1182         (TestWebKitAPI::willChangeTitle):
1183         (TestWebKitAPI::willChangeWebProcessIsResponsive):
1184         (TestWebKitAPI::didFinishNavigation):
1185         (TestWebKitAPI::TEST):
1186
1187 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
1188
1189         DumpRenderTree.app: Add CFBundleShortVersionString
1190         https://bugs.webkit.org/show_bug.cgi?id=200269
1191         <rdar://problem/53412596>
1192
1193         Rubber-stamped by Aakash Jain.
1194
1195         * DumpRenderTree/ios/Info.plist:
1196
1197 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1198
1199         Add layout test coverage for <https://webkit.org/b/200215>
1200         https://bugs.webkit.org/show_bug.cgi?id=200245
1201         <rdar://problem/52976965>
1202
1203         Reviewed by Tim Horton.
1204
1205         Add new testing infrastructure. See below for more details.
1206
1207         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1208         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1209         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1210         (WTR::UIScriptController::setWillCreateNewPageCallback):
1211         (WTR::UIScriptController::willCreateNewPageCallback const):
1212
1213         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
1214         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
1215
1216         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1217         (WTR::UIScriptController::becomeFirstResponder):
1218
1219         Add and implement a Cocoa platform hook to make the web view first responder.
1220
1221         * WebKitTestRunner/TestController.cpp:
1222         (WTR::TestController::createOtherPage):
1223         * WebKitTestRunner/TestInvocation.cpp:
1224         (WTR::TestInvocation::willCreateNewPage):
1225         * WebKitTestRunner/TestInvocation.h:
1226         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1227         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1228         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
1229
1230 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1231
1232         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
1233         https://bugs.webkit.org/show_bug.cgi?id=200217
1234
1235         Reviewed by Alex Christensen.
1236
1237         * MiniBrowser/win/BrowserWindow.h:
1238         * MiniBrowser/win/MainWindow.cpp:
1239         (MainWindow::init):
1240         (MainWindow::resizeSubViews):
1241         (MainWindow::WndProc):
1242         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
1243         * MiniBrowser/win/MiniBrowserLib.rc:
1244         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
1245         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1246         (WebKitBrowserWindow::reload):
1247         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
1248         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1249         (WebKitLegacyBrowserWindow::reload):
1250         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1251
1252 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1253
1254         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
1255         https://bugs.webkit.org/show_bug.cgi?id=200218
1256
1257         Reviewed by Alex Christensen.
1258
1259         Moved the scheme supplementing logic from
1260         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
1261
1262         * MiniBrowser/win/MainWindow.cpp:
1263         (MainWindow::loadURL):
1264         (MainWindow::onURLBarEnter):
1265         * MiniBrowser/win/MainWindow.h:
1266         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1267         (WebKitLegacyBrowserWindow::loadURL):
1268
1269 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
1270
1271         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1272         https://bugs.webkit.org/show_bug.cgi?id=200254
1273
1274         Unreviewed infrastructure fix.
1275
1276         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
1277
1278 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
1279
1280         [Canvas Timeline] Compact canvas timeline
1281         https://bugs.webkit.org/show_bug.cgi?id=200177
1282
1283         Reviewed by Jonathan Bedard.
1284
1285         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1286         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1287         (Timeline.CanvasSeriesComponent):
1288
1289 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1290
1291         Multiple context menu actions broken for YouTube videos
1292         https://bugs.webkit.org/show_bug.cgi?id=199999
1293
1294         Reviewed by Eric Carlson.
1295
1296         Add a test case to check copy link address, open in new window and download options are not included in the
1297         context menu for non-downloadable media.
1298
1299         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1300         (writeNextChunk):
1301         (serverCallback):
1302         (testContextMenuLiveStream):
1303         (beforeAll):
1304         (afterAll):
1305
1306 2019-07-28  Tim Horton  <timothy_horton@apple.com>
1307
1308         Reorganize UIScriptController into platform-specific subclasses
1309         https://bugs.webkit.org/show_bug.cgi?id=200027
1310
1311         Reviewed by Simon Fraser.
1312
1313         Instead of a mishmash of #ifdefs and extraneous empty functions,
1314         reorganize UIScriptController so that we have a base class
1315         with functions that assert if called (to make it harder to
1316         accidentally write a test that depends on unimplemented
1317         functionality), and override them in platform specific subclasses
1318         as functionality is added.
1319
1320         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1321         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
1322         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1323         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
1324         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1325         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1326         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1327         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1328         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
1329         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
1330         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1331         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
1332         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
1333         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1334         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
1335         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1336
1337 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1338
1339         [Win][MiniBrowser] Remove PageLoadTestClient
1340         https://bugs.webkit.org/show_bug.cgi?id=200155
1341
1342         Reviewed by Brent Fulgham.
1343
1344         It is not used nowadays.
1345
1346         * MiniBrowser/win/CMakeLists.txt:
1347         * MiniBrowser/win/Common.cpp:
1348         (parseCommandLine):
1349         * MiniBrowser/win/Common.h:
1350         * MiniBrowser/win/MainWindow.cpp:
1351         (MainWindow::init):
1352         * MiniBrowser/win/MainWindow.h:
1353         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1354         (MiniBrowserWebHost::updateAddressBar):
1355         (MiniBrowserWebHost::didFinishLoadForFrame):
1356         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
1357         (MiniBrowserWebHost::didFailLoadWithError):
1358         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
1359         (MiniBrowserWebHost::didFirstLayoutInFrame):
1360         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
1361         * MiniBrowser/win/PageLoadTestClient.h: Removed.
1362         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1363         (ResourceLoadDelegate::identifierForInitialRequest):
1364         (ResourceLoadDelegate::willSendRequest):
1365         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1366         (ResourceLoadDelegate::didFailLoadingWithError):
1367         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1368         (WebKitBrowserWindow::create):
1369         (WebKitBrowserWindow::createNewPage):
1370         * MiniBrowser/win/WebKitBrowserWindow.h:
1371         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1372         (WebKitLegacyBrowserWindow::create):
1373         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1374         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
1375         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1376         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
1377         * MiniBrowser/win/WinMain.cpp:
1378         (wWinMain):
1379
1380 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1381
1382         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
1383         https://bugs.webkit.org/show_bug.cgi?id=200150
1384         <rdar://problem/53280170>
1385
1386         Reviewed by Brent Fulgham.
1387
1388         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1389         (TestWebKitAPI::TEST):
1390
1391 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1392
1393         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
1394         https://bugs.webkit.org/show_bug.cgi?id=200090
1395
1396         Unreviewed follow-up fix.
1397
1398         * resultsdbpy/resultsdbpy/view/view_routes.py:
1399         (ViewRoutes.__init__): Keep /search endpoint for existing links
1400
1401 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1402
1403         results.webkit.org: Add switch to filter results by expectation
1404         https://bugs.webkit.org/show_bug.cgi?id=200134
1405
1406         Rubber-stamped by Aakash Jain.
1407
1408         Users of the results database should be able to easily differentiate tests which are expected
1409         to fail verse tests which are unexpectedly failing.
1410
1411         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1412         (Timeline.render): Respect the willFilterExpected variable.
1413         (LegendLabel): Generates html for label in the legend.
1414         (Legend): Add switch for filter results.
1415         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
1416         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1417
1418 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
1419
1420         [ews-build] Use update-webkit script in Style EWS
1421         https://bugs.webkit.org/show_bug.cgi?id=193196
1422
1423         Reviewed by Jonathan Bedard.
1424
1425         * BuildSlaveSupport/ews-build/factories.py:
1426         (StyleFactory): Updated to use CheckOutSource step as well.
1427         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
1428         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1429
1430 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1431
1432         results.webkit.org: Support buildbot 0.8 CI links
1433         https://bugs.webkit.org/show_bug.cgi?id=200146
1434
1435         Reviewed by Aakash Jain.
1436
1437         * resultsdbpy/resultsdbpy/model/ci_context.py:
1438         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
1439         (BuildbotEightURLFactory.__init__):
1440         (BuildbotEightURLFactory.url):
1441         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
1442         (URLFactoryTest.test_old_builder_url):
1443         (URLFactoryTest):
1444         (URLFactoryTest.test_old_worker_url):
1445
1446 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1447
1448         results.webkit.org: Suite results shouldn't be the landing page
1449         https://bugs.webkit.org/show_bug.cgi?id=200090
1450
1451         Reviewed by Aakash Jain.
1452
1453         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
1454         * resultsdbpy/resultsdbpy/view/view_routes.py:
1455         (ViewRoutes.__init__): Make search the landing page instead of suite results.
1456         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1457         (WebSiteUnittest.test_main):
1458
1459 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1460
1461         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
1462         https://bugs.webkit.org/show_bug.cgi?id=200127
1463
1464         Unreviewed follow-up fix.
1465
1466         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1467         (Dot.toString): Use self instead of this in render callback.
1468
1469 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
1470
1471         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
1472         https://bugs.webkit.org/show_bug.cgi?id=200108
1473         <rdar://problem/53521238>
1474
1475         Reviewed by Chris Dumez.
1476
1477         Added an API test.
1478
1479         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1480         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1481         (TEST):
1482
1483 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
1484
1485         results.webkit.org: Color should be the worst result, count should include all results
1486         https://bugs.webkit.org/show_bug.cgi?id=200127
1487
1488         Rubber-stamped by Aakash Jain.
1489
1490         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1491         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
1492
1493 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
1494
1495         [Timeline]: Make timeline header width automatic, instead of fixed width
1496         https://bugs.webkit.org/show_bug.cgi?id=200059
1497
1498         Reviewed by Jonathan Bedard.
1499
1500         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1501         (.dot.crash):
1502         (.timeline>.header): Deleted.
1503         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1504         (.timeline>.content):
1505         (.timeline>.header):
1506
1507 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
1508
1509         [ESNext] Implement nullish coalescing
1510         https://bugs.webkit.org/show_bug.cgi?id=200072
1511
1512         Reviewed by Darin Adler.
1513
1514         * Scripts/run-jsc-stress-tests:
1515
1516 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1517
1518         Add Takashi Komori and Tomoki Imai as contributors
1519
1520         Unreviewed.
1521
1522         * Scripts/webkitpy/common/config/contributors.json:
1523
1524 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
1525
1526         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
1527         https://bugs.webkit.org/show_bug.cgi?id=200103
1528
1529         Reviewed by Mark Lam.
1530
1531         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
1532         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
1533
1534         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
1535         to the future implementation changes while it catches the severe issues we had.
1536
1537         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1538         (assertEmptyPointerSet):
1539         (assertHasOnlyObjects):
1540         (assertClean):
1541         (TEST):
1542         (allocateAndDeallocate):
1543
1544 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1545
1546         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
1547         https://bugs.webkit.org/show_bug.cgi?id=200074
1548
1549         Reviewed by Michael Catanzaro.
1550
1551         There was a latent issue. PluginTest::indicateTestFailure was
1552         using WTF::sleep without linking WTF.
1553
1554         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1555         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
1556
1557 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1558
1559         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
1560         https://bugs.webkit.org/show_bug.cgi?id=200073
1561
1562         Reviewed by Michael Catanzaro.
1563
1564         * TestWebKitAPI/PlatformGTK.cmake:
1565         * TestWebKitAPI/PlatformWPE.cmake:
1566         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
1567
1568 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1569
1570         [webkitperl] runCommand doesn't work in Windows Perl
1571         https://bugs.webkit.org/show_bug.cgi?id=199900
1572
1573         Reviewed by Don Olmstead.
1574
1575         runCommand was always failing implicit fork by using 'open' with
1576         '-|' in Windows Perl. Explicitly specify the command to 'open' not
1577         to do the implicit fork.
1578
1579         There is one more difference between Windows and Unix. 'open'
1580         successes on Windows even for non existent command while it fails
1581         on Unix. So, return the same error code on Unix as well as
1582         Windows.
1583
1584         * Scripts/VCSUtils.pm: Specified the command to 'open'.
1585         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
1586         command is not available on Windows. Use Perl ($^X) instead.
1587
1588 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
1589
1590         Allow Clients to Add Fields to the AutoFillContext Dictionary.
1591         https://bugs.webkit.org/show_bug.cgi?id=199326
1592         rdar://problem/42816957
1593
1594         Reviewed by Wenson Hsieh.
1595
1596         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1597         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
1598         is being properly populated with additional context dictionary.
1599
1600         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1601         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1602         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
1603         which will populate the additional autofill context dictionary.
1604
1605         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
1606         populates the additional autofill context dictionary.
1607
1608         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
1609         context dictionary.
1610
1611         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
1612         input field requires strong password work.
1613
1614         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
1615         input field requires strong password work.
1616
1617         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
1618         password work.
1619
1620 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
1621
1622         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1623         https://bugs.webkit.org/show_bug.cgi?id=199489
1624
1625         Reviewed by Aakash Jain.
1626
1627         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1628         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
1629         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
1630         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1631         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
1632         (runTest): Record test binary failure
1633         (reportTestFailures): Report test binary failure
1634         (runJSCStressTests):
1635         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
1636         (JscOnlyPort.build_jsc_command):
1637         (JscOnlyPort):
1638         (JscOnlyPort.run_javascriptcore_tests_command):
1639         * Scripts/webkitpy/common/config/ports_unittest.py:
1640         (DeprecatedPortTest.test_jsconly_port):
1641
1642 2019-07-24  Zalan Bujtas  <zalan@apple.com>
1643
1644         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
1645         https://bugs.webkit.org/show_bug.cgi?id=200079
1646         <rdar://problem/53474325>
1647
1648         Reviewed by Wenson Hsieh.
1649
1650         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
1651
1652         * WebKitTestRunner/ios/TestControllerIOS.mm:
1653         (WTR::TestController::platformResetPreferencesToConsistentValues):
1654
1655 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1656
1657         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
1658         https://bugs.webkit.org/show_bug.cgi?id=199927
1659
1660         Reviewed by Alex Christensen.
1661
1662         convertAbsolutepathToWebKitPath was failing to convert paths on
1663         Windows Perl due to path separators mismatch.
1664
1665         Renamed convertAbsolutepathToWebKitPath to
1666         convertAbsolutePathToRelativeUnixPath, and changed it to replace
1667         paths to relative Unix paths.
1668
1669         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1670         (convertAbsolutePathToRelativeUnixPath): Added.
1671         (convertAbsolutepathToWebKitPath): Deleted.
1672
1673 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1674
1675         Fix iOS API test after r247759
1676         https://bugs.webkit.org/show_bug.cgi?id=200045
1677
1678         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1679         (TEST):
1680         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
1681         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
1682
1683 2019-07-23  Keith Rollin  <krollin@apple.com>
1684
1685         Remove rest of NavigatorContentUtils support
1686         https://bugs.webkit.org/show_bug.cgi?id=200052
1687         <rdar://problem/53467357>
1688
1689         Reviewed by Alex Christensen.
1690
1691         Bug 196070 removes most of the support for the never-used
1692         NavigatorContentUtils facility. However, there were still a couple of
1693         left-over references after that change. This patch sweeps those up.
1694
1695         * Scripts/webkitperl/FeatureList.pm:
1696
1697 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1698
1699         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1700         https://bugs.webkit.org/show_bug.cgi?id=200045
1701
1702         Reviewed by Mark Lam.
1703
1704         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1705         (TEST):
1706
1707 2019-07-23  Russell Epstein  <repstein@apple.com>
1708
1709         Unreviewed, rolling out r247745.
1710
1711         This broke API test
1712         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
1713         indicated by EWS
1714
1715         Reverted changeset:
1716
1717         "Move javaScriptConfigurationDirectory SPI from
1718         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
1719         runtime switchable"
1720         https://bugs.webkit.org/show_bug.cgi?id=200045
1721         https://trac.webkit.org/changeset/247745
1722
1723 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1724
1725         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1726         https://bugs.webkit.org/show_bug.cgi?id=200045
1727
1728         Reviewed by Mark Lam.
1729
1730         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1731         (TEST):
1732
1733 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1734
1735         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
1736         https://bugs.webkit.org/show_bug.cgi?id=199972
1737
1738         Reviewed by Jer Noble.
1739
1740         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1741         (TEST):
1742
1743 2019-07-23  Alicia Boya García  <aboya@igalia.com>
1744
1745         [WTF] Add DataMutex and MainThreadData wrappers
1746         https://bugs.webkit.org/show_bug.cgi?id=199831
1747
1748         Reviewed by Alex Christensen.
1749
1750         Added a very simple test that checks that DataMutex<T> indeed takes
1751         the lock and indeed holds data.
1752
1753         * TestWebKitAPI/CMakeLists.txt:
1754         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
1755         (TestWebKitAPI::TEST):
1756
1757 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1758
1759         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
1760         https://bugs.webkit.org/show_bug.cgi?id=200021
1761         <rdar://problem/53301325>
1762
1763         Reviewed by Ryosuke Niwa.
1764
1765         Add support for grabbing the child menu items of a context menu item.
1766
1767         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1768         (WTR::getMenuItemChildrenCallback):
1769
1770 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
1771
1772         WebKit should strip away system font names from the pasted content
1773         https://bugs.webkit.org/show_bug.cgi?id=199975
1774         <rdar://problem/53336353>
1775
1776         Reviewed by Darin Adler.
1777
1778         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1782         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
1783
1784 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1785
1786         [ews-build] EWS fails to parse multi-line full_results.json
1787         https://bugs.webkit.org/show_bug.cgi?id=199992
1788
1789         Reviewed by Alexey Proskuryakov.
1790
1791         * BuildSlaveSupport/ews-build/layout_test_failures.py:
1792         (LayoutTestFailures.results_from_string): Concatenate content into single line.
1793         * BuildSlaveSupport/ews-build/steps_unittest.py:
1794         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
1795
1796 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1797
1798         resultsdbpy: Handle case where the previous commit doesn't have the changelog
1799         https://bugs.webkit.org/show_bug.cgi?id=200015
1800
1801         Reviewed by Aakash Jain.
1802
1803         * resultsdbpy/resultsdbpy/model/repository.py:
1804         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
1805
1806 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1807
1808         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
1809         https://bugs.webkit.org/show_bug.cgi?id=200013
1810         <rdar://problem/52526901>
1811
1812         Reviewed by Simon Fraser.
1813
1814         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
1815
1816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1817         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
1818         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
1819         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
1820         * TestWebKitAPI/ios/UIKitSPI.h:
1821
1822 2019-07-22  Jer Noble  <jer.noble@apple.com>
1823
1824         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
1825         https://bugs.webkit.org/show_bug.cgi?id=199971
1826         <rdar://problem/51951218>
1827
1828         Reviewed by Alex Christensen.
1829
1830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1831         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
1832         (TestWebKitAPI::TEST):
1833
1834 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1835
1836         [ews-build] Add an EWS to run services tests
1837         https://bugs.webkit.org/show_bug.cgi?id=199994
1838
1839         Reviewed by Jonathan Bedard.
1840
1841         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
1842         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
1843         * BuildSlaveSupport/ews-build/steps.py:
1844         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
1845         (RunEWSUnitTests): Build step to run EWS unit-tests.
1846         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
1847         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1848         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
1849
1850 2019-07-22  Youenn Fablet  <youenn@apple.com>
1851
1852         Disable MediaRecorder for legacy WebKit
1853         https://bugs.webkit.org/show_bug.cgi?id=200001
1854         <rdar://problem/53400030>
1855
1856         Reviewed by Eric Carlson.
1857
1858         Enable MediaRecorder for testing purposes.
1859
1860         * DumpRenderTree/mac/DumpRenderTree.mm:
1861         (createWebViewAndOffscreenWindow):
1862
1863 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1864
1865         results.webkit.org: Timeline header is too small
1866         https://bugs.webkit.org/show_bug.cgi?id=199955
1867
1868         Reviewed by Aakash Jain.
1869
1870         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1871         (.timeline>.header): Make timeline header larder to fit configuration names.
1872
1873 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1874
1875         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
1876         https://bugs.webkit.org/show_bug.cgi?id=199954
1877
1878         Reviewed by Geoff Garen.
1879
1880         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1881         (TEST):
1882
1883 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1884
1885         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
1886         https://bugs.webkit.org/show_bug.cgi?id=199917
1887
1888         Reviewed by Sam Weinig.
1889
1890         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1891         (TEST):
1892
1893 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1894
1895         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
1896         https://bugs.webkit.org/show_bug.cgi?id=199980
1897
1898         Reviewed by Jonathan Bedard.
1899
1900         * BuildSlaveSupport/ews-build/steps.py:
1901         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
1902         * BuildSlaveSupport/ews-build/steps_unittest.py:
1903         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
1904         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
1905
1906 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1907
1908         [webkitpy] Add an unit test for setting up the driver environment without starting it.
1909         https://bugs.webkit.org/show_bug.cgi?id=199945
1910
1911         Reviewed by Michael Catanzaro.
1912
1913         This adds an unit test for the change implemented in r247663.
1914
1915         * Scripts/webkitpy/port/driver_unittest.py:
1916         (DriverTest.test_setup_environ_base_vars):
1917         (DriverTest):
1918         (DriverTest.test_setup_environ_without_starting_driver):
1919
1920 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1921
1922         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
1923         https://bugs.webkit.org/show_bug.cgi?id=199993
1924         <rdar://problem/49523528>
1925
1926         Reviewed by Beth Dakin.
1927
1928         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
1929
1930         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1931         (TestWebKitAPI::TEST):
1932         * TestWebKitAPI/cocoa/TestWKWebView.h:
1933
1934 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
1935
1936         Add accessibilityInsertText for text insertion in edit fields.
1937         https://bugs.webkit.org/show_bug.cgi?id=199973
1938
1939         Reviewed by Chris Fleizach.
1940
1941         Renamed accessibilityInsertText to _accessibilityInsertText.
1942
1943         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1944         (AccessibilityUIElement::insertText):
1945         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1946         (AccessibilityUIElement::insertText):
1947         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1948         (WTR::AccessibilityUIElement::insertText):
1949         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1950         (WTR::AccessibilityUIElement::insertText):
1951
1952 2019-07-20  Chris Dumez  <cdumez@apple.com>
1953
1954         Speed up HashTable decoding by reserving capacity and avoiding rehashing
1955         https://bugs.webkit.org/show_bug.cgi?id=199982
1956
1957         Reviewed by Saam Barati.
1958
1959         Add API test coverage.
1960
1961         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1962         (TestWebKitAPI::TEST):
1963
1964 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
1965
1966         Add accessibilityInsertText for text insertion in edit fields.
1967         https://bugs.webkit.org/show_bug.cgi?id=199973
1968
1969         Reviewed by Chris Fleizach.
1970
1971         Glue code to run new LayoutTests.
1972         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1973         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1974         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1975         (WTR::AccessibilityUIElement::insertText):
1976         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1977         (WTR::AccessibilityUIElement::insertText):
1978         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1979         (WTR::AccessibilityUIElement::insertText):
1980         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1981         (WTR::AccessibilityUIElement::insertText):
1982
1983 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1984
1985         Move webkit.css to opensource to support resultsdbpy's frontend
1986         https://bugs.webkit.org/show_bug.cgi?id=199957
1987
1988         Reviewed by Jonathan Bedard.
1989
1990         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
1991         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
1992         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
1993         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
1994
1995 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1996
1997         Move Ref.js to WebKit to support resultsdbpy's frontend
1998         https://bugs.webkit.org/show_bug.cgi?id=199956
1999
2000         Reviewed by Jonathan Bedard.
2001
2002         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2003         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2004         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2005         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
2006         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
2007         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
2008         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
2009         * resultsdbpy/resultsdbpy/view/templates/base.html:
2010         * resultsdbpy/resultsdbpy/view/templates/commits.html:
2011         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
2012         * resultsdbpy/resultsdbpy/view/templates/search.html:
2013         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2014         * resultsdbpy/resultsdbpy/view/view_routes.py:
2015
2016 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2017
2018         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
2019         https://bugs.webkit.org/show_bug.cgi?id=199945
2020
2021         Reviewed by Michael Catanzaro.
2022
2023         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
2024         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
2025         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
2026
2027         * Scripts/webkitpy/port/driver.py:
2028         (Driver._setup_environ_for_driver):
2029         (Driver._create_temporal_directories):
2030         (Driver):
2031         (Driver._start):
2032         (Driver._delete_temporal_directories):
2033         (Driver.stop):
2034         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
2035         (main):
2036         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
2037         (WebDriverTestRunner.__init__):
2038         * glib/api_test_runner.py:
2039         (TestRunner._setup_testing_environment): Ditto.
2040
2041 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
2042
2043         [ews-build] Display pre-existing Layout test failure names in the build summary
2044         https://bugs.webkit.org/show_bug.cgi?id=199941
2045
2046         Reviewed by Jonathan Bedard.
2047
2048         * BuildSlaveSupport/ews-build/steps.py:
2049         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2050
2051 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2052
2053         [GTK][WPE] run-webkit-tests should run with a temporal homedir
2054         https://bugs.webkit.org/show_bug.cgi?id=199738
2055
2056         Reviewed by Michael Catanzaro.
2057
2058         Run the tests with an empty homedir that is created inside the driver tmpdir.
2059         The driver tmpdir is a random directory created for each test runner that is purged after the run.
2060
2061         This is done to ensure that the test results are not affected by the user settings of any library.
2062
2063         * Scripts/webkitpy/port/driver.py:
2064         (Driver._setup_environ_for_driver):
2065         * Scripts/webkitpy/port/driver_unittest.py:
2066         (DriverTest.test_setup_environ_base_vars):
2067         (DriverTest):
2068         (DriverTest.test_create_temporal_home_dir):
2069
2070 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2071
2072         Remove pywebsockets from thirdparty
2073         https://bugs.webkit.org/show_bug.cgi?id=199710
2074
2075         Reviewed by Jonathan Bedard.
2076
2077         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
2078         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
2079
2080         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2081         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
2082         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
2083         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
2084         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
2085         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
2086         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
2087         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
2088         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
2089         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
2090         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
2091         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
2092         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
2093         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
2094         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
2095         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
2096         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
2097         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
2098         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
2099         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
2100         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
2101         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
2102
2103 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
2104
2105         results.webkit.org: Move resultsdbpy to WebKit
2106         https://bugs.webkit.org/show_bug.cgi?id=199837
2107         <rdar://problem/53172130>
2108
2109         Rubber-stamped by Aakash Jain.
2110
2111         Moving the entirety of the resultsdbpy library, which provides utilities to build
2112         a database designed to store, visualize and organize test results, into WebKit.
2113
2114         * Scripts/webkitpy/style/checker.py:
2115         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
2116         * resultsdbpy: Added.
2117         * resultsdbpy/MANIFEST.in: Added.
2118         * resultsdbpy/README.md: Added.
2119         * resultsdbpy/resultsdbpy: Added.
2120         * resultsdbpy/resultsdbpy/__init__.py: Added.
2121         * resultsdbpy/resultsdbpy/controller: Added.
2122         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
2123         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
2124         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
2125         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
2126         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
2127         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
2128         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
2129         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
2130         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
2131         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
2132         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
2133         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
2134         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
2135         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
2136         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
2137         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
2138         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
2139         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
2140         * resultsdbpy/resultsdbpy/flask_support: Added.
2141         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
2142         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
2143         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
2144         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
2145         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
2146         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
2147         * resultsdbpy/resultsdbpy/model: Added.
2148         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
2149         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
2150         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
2151         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
2152         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
2153         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
2154         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
2155         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
2156         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
2157         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
2158         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
2159         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
2160         * resultsdbpy/resultsdbpy/model/docker.py: Added.
2161         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
2162         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
2163         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
2164         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
2165         * resultsdbpy/resultsdbpy/model/model.py: Added.
2166         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
2167         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
2168         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
2169         * resultsdbpy/resultsdbpy/model/repository.py: Added.
2170         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
2171         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
2172         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
2173         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
2174         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
2175         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
2176         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
2177         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
2178         * resultsdbpy/resultsdbpy/run-tests: Added.
2179         * resultsdbpy/resultsdbpy/view: Added.
2180         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
2181         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
2182         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
2183         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
2184         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
2185         * resultsdbpy/resultsdbpy/view/static: Added.
2186         * resultsdbpy/resultsdbpy/view/static/css: Added.
2187         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
2188         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
2189         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
2190         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
2191         * resultsdbpy/resultsdbpy/view/static/js: Added.
2192         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
2193         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
2194         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
2195         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
2196         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
2197         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
2198         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
2199         * resultsdbpy/resultsdbpy/view/templates: Added.
2200         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
2201         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
2202         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
2203         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
2204         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
2205         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
2206         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
2207         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
2208         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
2209         * resultsdbpy/setup.py: Added.
2210
2211 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2212
2213         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
2214         https://bugs.webkit.org/show_bug.cgi?id=199923
2215
2216         Reviewed by Youenn Fablet.
2217
2218         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2219         (TestWebKitAPI::TEST):
2220
2221 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews-build] Enable iOS WK2 tester queue on new EWS
2224         https://bugs.webkit.org/show_bug.cgi?id=199867
2225
2226         Reviewed by Jonathan Bedard.
2227
2228         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
2229         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
2231         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
2232
2233 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2234
2235         [ews-build] Add build step to AnalyzeLayoutTestsResults
2236         https://bugs.webkit.org/show_bug.cgi?id=199877
2237
2238         Reviewed by Jonathan Bedard.
2239
2240         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
2241
2242         * BuildSlaveSupport/ews-build/steps.py:
2243         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
2244         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
2245         (AnalyzeLayoutTestsResults.report_failure):
2246         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2247         (AnalyzeLayoutTestsResults.retry_build):
2248         (AnalyzeLayoutTestsResults._results_failed_different_tests):
2249         (AnalyzeLayoutTestsResults._report_flaky_tests):
2250         (AnalyzeLayoutTestsResults.start):
2251         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2252
2253 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2254
2255         Move NetworkCache ownership from NetworkProcess to NetworkSession
2256         https://bugs.webkit.org/show_bug.cgi?id=199817
2257
2258         Reviewed by Geoff Garen.
2259
2260         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2261         (TEST):
2262         * TestWebKitAPI/cocoa/TestWKWebView.h:
2263         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2264         (-[WKWebView synchronouslyLoadRequest:]):
2265
2266 2019-07-18  Youenn Fablet  <youenn@apple.com>
2267
2268         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
2269         https://bugs.webkit.org/show_bug.cgi?id=199769
2270         <rdar://problem/49390297>
2271
2272         Reviewed by Myles C. Maxfield.
2273
2274         Add a font containing one extended character not found in system fonts.
2275
2276         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2277         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
2278
2279 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
2280
2281         Unreviewed, Add Olivier Blin as contributor
2282
2283         * Scripts/webkitpy/common/config/contributors.json:
2284
2285 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2286
2287         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2288         https://bugs.webkit.org/show_bug.cgi?id=199855
2289
2290         Reviewed by Michael Catanzaro.
2291
2292         The webkitpy drivers for GTK and WPE use their own versions for setting
2293         up the environment and starting/stopping the drivers.
2294         This refactors those drivers to use the base class driver functions.
2295         As a benefit we get some fixes like support for setting the profiler
2296         environment variables, and a simpler code.
2297
2298         * Scripts/webkitpy/port/driver.py:
2299         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2300         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2301         * Scripts/webkitpy/port/headlessdriver.py:
2302         (HeadlessDriver._setup_environ_for_test):
2303         * Scripts/webkitpy/port/waylanddriver.py:
2304         (WaylandDriver._setup_environ_for_test):
2305         * Scripts/webkitpy/port/westondriver.py:
2306         (WestonDriver._setup_environ_for_test):
2307         (WestonDriver.stop):
2308         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2309         (WestonDriverTest.make_driver):
2310         * Scripts/webkitpy/port/xorgdriver.py:
2311         (XorgDriver._setup_environ_for_test):
2312         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2313         (XvfbDriver._setup_environ_for_test):
2314         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2315         (XvfbDriverTest.make_driver):
2316         (XvfbDriverTest.test_start):
2317         (XvfbDriverTest.test_start_arbitrary_worker_number):
2318         * Scripts/webkitpy/w3c/wpt_runner.py:
2319         (main): Start the driver before trying to get its environment to define all the environment variables.
2320         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2321         (WebDriverTestRunner.__init__): Ditto.
2322         * glib/api_test_runner.py:
2323         (TestRunner._setup_testing_environment): Ditto.
2324
2325 2019-07-17  Antoine Quint  <graouts@apple.com>
2326
2327         Disable Pointer Events prior to watchOS 6
2328         https://bugs.webkit.org/show_bug.cgi?id=199890
2329         <rdar://problem/53206113>
2330
2331         Reviewed by Dean Jackson.
2332
2333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2334
2335 2019-07-17  Christopher Reid  <chris.reid@sony.com>
2336
2337         Bytecode cache should use FileSystem
2338         https://bugs.webkit.org/show_bug.cgi?id=199759
2339
2340         Reviewed by Yusuke Suzuki.
2341
2342         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2343
2344 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
2345
2346         check-webkit-style: Add limited Python3 support
2347         https://bugs.webkit.org/show_bug.cgi?id=199870
2348
2349         Rubber-stamped by Aakash Jain.
2350
2351         Since new services will be added in the near future which are Python 3, we
2352         need to support Python 3 style checks. For now, assume all Python files are
2353         Python 2 unless otherwise specified.
2354
2355         * Scripts/webkitpy/style/checker.py:
2356         (_all_categories): Add pycodestyle to valid categories for testing.
2357         (CheckerDispatcher._create_checker): Check that the provided Python file is in
2358         one of the declared Python 3 directories.
2359         * Scripts/webkitpy/style/checkers/python.py:
2360         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
2361         instead of pep8.
2362         (Python3Checker.__init__):
2363         (Python3Checker.check):
2364         * Scripts/webkitpy/thirdparty/__init__.py:
2365         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
2366         (AutoinstallImportHook._install_pycodestyle):
2367
2368 2019-07-17  Sam Weinig  <weinig@apple.com>
2369
2370         Add StringBuilder member function which allows makeString() style variadic argument construction
2371         https://bugs.webkit.org/show_bug.cgi?id=198997
2372
2373         Reviewed by Darin Adler.
2374
2375         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2376         Add basic test showing that StringBuilder::flexibleAppend can be used to
2377         append one or more string adaptable types.
2378
2379         * TestWebKitAPI/CMakeLists.txt:
2380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2381         Add WTFStringUtilities.cpp
2382
2383         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2384         Add basic test showing that StringBuilder::flexibleAppend can be used to
2385         append one or more string adaptable types.
2386
2387         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2388         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
2389         * TestWebKitAPI/WTFStringUtilities.h:
2390         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
2391         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
2392
2393 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2394
2395         Remove the file superfluously added in r247535.
2396
2397         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
2398         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
2399
2400 2019-07-17  Alex Christensen  <achristensen@webkit.org>
2401
2402         Add a runtime-disabled dialog element skeleton
2403         https://bugs.webkit.org/show_bug.cgi?id=199839
2404
2405         Reviewed by Ryosuke Niwa.
2406
2407         * DumpRenderTree/mac/DumpRenderTree.mm:
2408         (resetWebPreferencesToConsistentValues):
2409         * WebKitTestRunner/TestController.cpp:
2410         (WTR::TestController::resetPreferencesToConsistentValues):
2411         Enable the dialog element for layout tests.
2412
2413 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2414
2415         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
2416         https://bugs.webkit.org/show_bug.cgi?id=199851
2417
2418         Reviewed by Wenson Hsieh.
2419
2420         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
2421         this code is getting directly triggered from UIKeyboard's code.
2422
2423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2424         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
2425         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
2426         * TestWebKitAPI/ios/UIKitSPI.h:
2427
2428 2019-07-17  Commit Queue  <commit-queue@webkit.org>
2429
2430         Unreviewed, rolling out r247505.
2431         https://bugs.webkit.org/show_bug.cgi?id=199871
2432
2433         "Caused failed ASSERT in stress test" (Requested by creid on
2434         #webkit).
2435
2436         Reverted changeset:
2437
2438         "Bytecode cache should use FileSystem"
2439         https://bugs.webkit.org/show_bug.cgi?id=199759
2440         https://trac.webkit.org/changeset/247505
2441
2442 2019-07-17  Russell Epstein  <russell_e@apple.com>
2443
2444         Adding self to contributors.json
2445
2446         Unreviewed.
2447
2448         * Scripts/webkitpy/common/config/contributors.json:
2449
2450 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
2451
2452         [ews-build] Parse full_results.json for layout-tests
2453         https://bugs.webkit.org/show_bug.cgi?id=199804
2454
2455         Reviewed by Jonathan Bedard.
2456
2457         * BuildSlaveSupport/ews-build/steps.py:
2458         (RunWebKitTests.start): Monitor json output.
2459         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
2460         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
2461         by the patch or are pre-existing.
2462         (ReRunWebKitTests.commandComplete): Ditto.
2463         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
2464         * BuildSlaveSupport/ews-build/steps_unittest.py:
2465         (BuildStepMixinAdditions.getProperty): Added.
2466         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
2467         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
2468
2469 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2470
2471         Unreviewed, rolling out r247512.
2472
2473         Broke API test runners
2474
2475         Reverted changeset:
2476
2477         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
2478         for setting up the environment and start the drivers."
2479         https://bugs.webkit.org/show_bug.cgi?id=199855
2480         https://trac.webkit.org/changeset/247512
2481
2482 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2483
2484         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2485         https://bugs.webkit.org/show_bug.cgi?id=199855
2486
2487         Reviewed by Carlos Garcia Campos.
2488
2489         The webkitpy drivers for GTK and WPE use their own versions for setting
2490         up the environment and starting/stopping the drivers.
2491         This refactors those drivers to use the base class driver functions.
2492         As a benefit we get some fixes like support for setting the profiler
2493         environment variables, and a simpler code.
2494
2495         * Scripts/webkitpy/port/driver.py:
2496         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2497         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2498         * Scripts/webkitpy/port/headlessdriver.py:
2499         (HeadlessDriver._setup_environ_for_test):
2500         * Scripts/webkitpy/port/waylanddriver.py:
2501         (WaylandDriver._setup_environ_for_test):
2502         * Scripts/webkitpy/port/westondriver.py:
2503         (WestonDriver._setup_environ_for_test):
2504         (WestonDriver.stop):
2505         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2506         (WestonDriverTest.make_driver):
2507         * Scripts/webkitpy/port/xorgdriver.py:
2508         (XorgDriver._setup_environ_for_test):
2509         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2510         (XvfbDriver._setup_environ_for_test):
2511         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2512         (XvfbDriverTest.make_driver):
2513         (XvfbDriverTest.test_start):
2514         (XvfbDriverTest.test_start_arbitrary_worker_number):
2515
2516 2019-07-16  Christopher Reid  <chris.reid@sony.com>
2517
2518         Bytecode cache should use FileSystem
2519         https://bugs.webkit.org/show_bug.cgi?id=199759
2520
2521         Reviewed by Yusuke Suzuki.
2522
2523         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2524
2525 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
2526
2527         svn-create-patch duplicates diffs when adding directories
2528         https://bugs.webkit.org/show_bug.cgi?id=199842
2529
2530         Reviewed by Dewei Zhu.
2531
2532         * Scripts/svn-create-patch:
2533         (findKind): Add function which returns what 'kind' of file the provided path is.
2534         (generateFileList): If the path is a directory and being added, don't add it.
2535         Instead, rely on the fact that its children will be added.
2536
2537 2019-07-16  Tim Horton  <timothy_horton@apple.com>
2538
2539         NSTextFinder holes don't scroll with the page
2540         https://bugs.webkit.org/show_bug.cgi?id=199815
2541         <rdar://problem/52280514>
2542
2543         Reviewed by Simon Fraser.
2544
2545         * MiniBrowser/mac/WK2BrowserWindowController.m:
2546         (-[MiniBrowserNSTextFinder performAction:]):
2547         (-[WK2BrowserWindowController awakeFromNib]):
2548         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
2549         -performAction: so that we can intercept the close action and
2550         hide our own find UI, since there is no delegate for that action yet.
2551
2552         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2553         (TEST):
2554
2555 2019-07-15  Keith Miller  <keith_miller@apple.com>
2556
2557         JSGlobalObject type macros should support feature flags and WeakRef should have one
2558         https://bugs.webkit.org/show_bug.cgi?id=199601
2559
2560         Reviewed by Mark Lam.
2561
2562         JSC options need to be set before the window is created for the test.
2563
2564         * DumpRenderTree/mac/DumpRenderTree.mm:
2565         (resetWebViewToConsistentStateBeforeTesting):
2566         * DumpRenderTree/win/DumpRenderTree.cpp:
2567         (setJSCOptions):
2568         (resetWebViewToConsistentStateBeforeTesting):
2569
2570 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
2571
2572         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
2573         https://bugs.webkit.org/show_bug.cgi?id=193108
2574
2575         Reviewed by Simon Fraser.
2576
2577         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
2578         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
2579         at the wrong scale.
2580
2581         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2582         (takeWindowSnapshot):
2583         (createBitmapContextFromWebView):
2584
2585 2019-07-15  Brady Eidson  <beidson@apple.com>
2586
2587         Make WKURLSchemeTask thread safe.
2588         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
2589
2590         Reviewed by Alex Christensen.
2591
2592         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2593
2594 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2595
2596         Unreviewed, a build fix after r247437
2597
2598         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2599         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
2600
2601 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2602
2603         [macOS 10.15] Cannot unbold selected text when the system font is used
2604         https://bugs.webkit.org/show_bug.cgi?id=199788
2605         <rdar://problem/52142570>
2606
2607         Reviewed by Tim Horton.
2608
2609         Add a new API test to verify that bolding and unbolding updates the
2610         shared font manager's selected font.
2611
2612         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2613         (TestWebKitAPI::TEST):
2614
2615 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2616
2617         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
2618         https://bugs.webkit.org/show_bug.cgi?id=199790
2619         <rdar://problem/52790112>
2620
2621         Reviewed by Brent Fulgham.
2622
2623         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
2624
2625         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2626         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
2627         (configureSOAuthorizationWebView):
2628         (TestWebKitAPI::TEST):
2629         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
2630         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
2631         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2632         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2633         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
2634
2635 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
2636
2637         window.openDatabase is not writable
2638         https://bugs.webkit.org/show_bug.cgi?id=199737
2639         <rdar://problem/52551332>
2640
2641         Reviewed by Chris Dumez.
2642
2643         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
2644         (TEST):
2645         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
2646
2647 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
2648
2649         [ews-build] Parse and display layout test failures
2650         https://bugs.webkit.org/show_bug.cgi?id=199709
2651
2652         Rubber-stamped by Jonathan Bedard.
2653
2654         * BuildSlaveSupport/ews-build/steps.py:
2655         (RunWebKitTests.start): Initialize log_observer.
2656         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
2657         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
2658         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
2659         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
2660         (RunWebKitTests.getResultSummary): Update build and step summary.
2661         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
2662
2663 2019-07-15  Commit Queue  <commit-queue@webkit.org>
2664
2665         Unreviewed, rolling out r247393.
2666         https://bugs.webkit.org/show_bug.cgi?id=199797
2667
2668         broke mips and arm EWS (Requested by guijemont on #webkit).
2669
2670         Reverted changeset:
2671
2672         "run-javascriptcore-tests won't report test results for
2673         testmasm, testair, testb3, testdfg and test api"
2674         https://bugs.webkit.org/show_bug.cgi?id=199489
2675         https://trac.webkit.org/changeset/247393
2676
2677 2019-07-12  Andy Estes  <aestes@apple.com>
2678
2679         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
2680         https://bugs.webkit.org/show_bug.cgi?id=199768
2681         <rdar://problem/52002206>
2682
2683         Reviewed by Geoffrey Garen.
2684
2685         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2686         (TEST):
2687
2688 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2689
2690         [ews-build] Remove wincairo queue from old EWS and dashboard
2691         https://bugs.webkit.org/show_bug.cgi?id=199776
2692
2693         Reviewed by Don Olmstead.
2694
2695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2696         * QueueStatusServer/config/queues.py:
2697
2698 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2699
2700         [ews-build] Enable wincairo queue on new EWS
2701         https://bugs.webkit.org/show_bug.cgi?id=199593
2702
2703         Reviewed by Don Olmstead.
2704
2705         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
2706         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
2707         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2708         (StatusBubble): Enable wincairo status-bubble.
2709
2710 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2711
2712         [ews-app] Enable logging for clicking SubmitToEWS button
2713         https://bugs.webkit.org/show_bug.cgi?id=199757
2714
2715         Unreviewed minor infrastructure fix.
2716
2717         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2718         (SubmitToEWS.post): Change logging level from debug to info.
2719
2720 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2721
2722         Enable client certificate authentication unit test
2723         https://bugs.webkit.org/show_bug.cgi?id=199735
2724
2725         Reviewed by Chris Dumez.
2726
2727         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2728         (TEST):
2729         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
2730         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
2731
2732 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2733
2734         Begin unifying TestWebKitAPI build
2735         https://bugs.webkit.org/show_bug.cgi?id=199728
2736
2737         Reviewed by Keith Miller.
2738
2739         * TestWebKitAPI/Configurations/Base.xcconfig:
2740         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
2741         * TestWebKitAPI/Sources.txt: Added.
2742         * TestWebKitAPI/SourcesCocoa.txt: Added.
2743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2744
2745 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
2746
2747         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
2748         https://bugs.webkit.org/show_bug.cgi?id=199489
2749         <rdar://problem/47891081>
2750
2751         Reviewed by Aakash Jain.
2752
2753         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2754         (RunJavaScriptCoreTests.countFailures):
2755         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2756         * Scripts/run-javascriptcore-tests:
2757         (runTest):
2758         (reportTestFailures):
2759         (runJSCStressTests):
2760
2761 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2762
2763         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
2764         https://bugs.webkit.org/show_bug.cgi?id=199743
2765
2766         Reviewed by Jonathan Bedard.
2767
2768         * BuildSlaveSupport/ews-build/steps.py:
2769         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2770
2771 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2772
2773         Unreviewed follow-up fix to r247364.
2774         [ews-build] Add build step to clean up .git/index.lock file
2775         https://bugs.webkit.org/show_bug.cgi?id=199722
2776
2777         * BuildSlaveSupport/ews-build/steps.py:
2778         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
2779         to be run after this step.
2780
2781 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
2782
2783         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
2784         https://bugs.webkit.org/show_bug.cgi?id=199524
2785         <rdar://problem/52783816>
2786
2787         Reviewed by Saam Barati.
2788
2789         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
2790         But this test has several problems.
2791
2792         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
2793            number is calculated by pageSize / sizeof(T), and this does not account the header
2794            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
2795            is very small, we can have many objects in one IsoPage. As a result, we need a large
2796            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
2797            less than numObjects.
2798
2799         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
2800            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
2801            page. This also makes the intention of this test wrong.
2802
2803         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
2804
2805         We make this test robust while we still keep this test white-box one to test the critical feature
2806         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
2807         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
2808         tier live, and check whether the deallocated memory is reused.
2809
2810         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2811         (TEST):
2812
2813 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
2814
2815         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
2816         https://bugs.webkit.org/show_bug.cgi?id=199625
2817
2818         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
2819         with ENABLE(ACCESSIBILITY) in the code.
2820
2821         Additionally, the TestRunner code generator now honors the
2822         Conditional IDL format.
2823
2824         Reviewed by Konstantin Tokarev.
2825
2826         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2827         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2828         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2829         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2830         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2831         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2832         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2833         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2834         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2835         (_generateImplementationFile):
2836
2837 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2838
2839         [ews-build] Add build step to clean up .git/index.lock file
2840         https://bugs.webkit.org/show_bug.cgi?id=199722
2841
2842         Reviewed by Jonathan Bedard.
2843
2844         * BuildSlaveSupport/ews-build/steps.py:
2845         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
2846         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
2847         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
2848         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2849
2850 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
2851
2852         [iOS 13] Enable WebKit build
2853         https://bugs.webkit.org/show_bug.cgi?id=199481
2854         <rdar://problem/52619048>
2855
2856         Reviewed by Tim Horton.
2857
2858         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
2859
2860 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
2861
2862         Add test expectations and baselines for iOS 13
2863         https://bugs.webkit.org/show_bug.cgi?id=199329
2864
2865         Reviewed by Jonathan Bedard.
2866
2867         * Scripts/webkitpy/port/ios.py:
2868         (IOSPort): Increment current version to 13.
2869         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
2870         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
2871         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
2872         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
2873         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
2874         (IOSSimulatorTest.make_port):
2875         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
2876         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
2877         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
2878         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
2879         (IOSTest.make_port):
2880
2881 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
2882
2883         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
2884         https://bugs.webkit.org/show_bug.cgi?id=199692
2885
2886         Reviewed by Chris Fleizach.
2887
2888         Add support for output of AXDeletion and AXInsertion roles for tests.
2889         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
2890         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
2891
2892         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2893         * gtk/jhbuild.modules:
2894         * wpe/jhbuild.modules:
2895
2896 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
2897
2898         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
2899         https://bugs.webkit.org/show_bug.cgi?id=199707
2900
2901         Reviewed by Aakash Jain.
2902
2903         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
2904
2905 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
2906
2907         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
2908         https://bugs.webkit.org/show_bug.cgi?id=199693
2909         rdar://problem/51930364
2910
2911         Reviewed by Tim Horton.
2912
2913         New API tests that test scrollability with various combinations of content, insets,
2914         input accessory bars etc.
2915
2916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2917         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
2918         (TestWebKitAPI::webViewWithAutofocusedInput):
2919         (TestWebKitAPI::TEST):
2920
2921 2019-07-10  Tim Horton  <timothy_horton@apple.com>
2922
2923         Long pressing on attachments will crash the WebContent process
2924         https://bugs.webkit.org/show_bug.cgi?id=199696
2925         <rdar://problem/52920241>
2926
2927         Reviewed by Dean Jackson.
2928
2929         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2930         (TestWebKitAPI::TEST):
2931         Add a test that previously crashed.
2932
2933 2019-07-10  Dean Jackson  <dino@apple.com>
2934
2935         Support MacCatalyst in run-webkit-app
2936         https://bugs.webkit.org/show_bug.cgi?id=199690
2937
2938         Reviewed by Tim Horton.
2939
2940         Add a --maccatalyst option to run-webkit-app that
2941         can launch MacCatalyst applications with a built WebKit.
2942
2943         * Scripts/webkitdirs.pm:
2944         (argumentsForConfiguration):
2945         (determineXcodeSDK):
2946         (xcodeSDKPlatformName):
2947         (determineConfigurationProductDir):
2948         (determinePortName):
2949         (isCatalystWebKit):
2950         (isAppleCocoaWebKit):
2951         (willUseCatalystSDK):
2952
2953 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2954
2955         [MacOS] Filter VPA info logged to stdout
2956         https://bugs.webkit.org/show_bug.cgi?id=199673
2957
2958         Reviewed by Eric Carlson.
2959
2960         * Scripts/webkitpy/port/mac.py:
2961         (MacPort.logging_patterns_to_strip):
2962
2963 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2964
2965         Unreviewed, rolling out r247286.
2966
2967         Caused TestWTF.WTF.StringOperators to fail on debug bots
2968
2969         Reverted changeset:
2970
2971         "Add StringBuilder member function which allows makeString()
2972         style variadic argument construction"
2973         https://bugs.webkit.org/show_bug.cgi?id=198997
2974         https://trac.webkit.org/changeset/247286
2975
2976 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
2977
2978         [ews-build] Explicitly use perl or python while invoking scripts
2979         https://bugs.webkit.org/show_bug.cgi?id=199669
2980
2981         Reviewed by Jonathan Bedard.
2982
2983         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
2984         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2985
2986 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
2987
2988         Run tests on mips EWS
2989         https://bugs.webkit.org/show_bug.cgi?id=196854
2990
2991         Reviewed by Carlos Garcia Campos.
2992
2993         * Scripts/webkitpy/common/config/ews.json:
2994
2995 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2996
2997         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
2998         https://bugs.webkit.org/show_bug.cgi?id=199579
2999
3000         Reviewed by Carlos Garcia Campos.
3001
3002         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
3003         (TestWebKitAPI::TEST):
3004
3005 2019-07-09  Chris Dumez  <cdumez@apple.com>
3006
3007         Fix integer type encoding / decoding in WKRemoteObjectCoder
3008         https://bugs.webkit.org/show_bug.cgi?id=199643
3009         <rdar://problem/52732342>
3010
3011         Reviewed by Anders Carlsson.
3012
3013         Update API test coverage.
3014
3015         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3016         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3017         (TEST):
3018         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3019         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
3020         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
3021         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
3022         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
3023
3024 2019-07-09  Sam Weinig  <weinig@apple.com>
3025
3026         Add StringBuilder member function which allows makeString() style variadic argument construction
3027         https://bugs.webkit.org/show_bug.cgi?id=198997
3028
3029         Reviewed by Darin Adler.
3030
3031         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3032         Add basic test showing that StringBuilder::flexibleAppend can be used to
3033         append one or more string adaptable types.
3034
3035 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
3036
3037         Only allow fetching and removing session credentials from WebsiteDataStore
3038         https://bugs.webkit.org/show_bug.cgi?id=199385
3039         <rdar://problem/52622080>
3040
3041         Reviewed by Alex Christensen.
3042
3043         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
3044         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
3045         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
3046
3047         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3048         (TEST):
3049         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3050         (TestWebKitAPI::TEST):
3051
3052 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3053
3054         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
3055         https://bugs.webkit.org/show_bug.cgi?id=199628
3056
3057         Reviewed by Brady Eidson.
3058
3059         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3060         (TestWebKitAPI::TEST_F):
3061
3062 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3063
3064         Remove invalid assertion in URLParser::domainToASCII
3065         https://bugs.webkit.org/show_bug.cgi?id=199624
3066
3067         Reviewed by Brady Eidson.
3068
3069         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3070         (TestWebKitAPI::TEST_F):
3071
3072 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3073
3074         URLParser should reserialize IPv6 addresses that end with a colon
3075         https://bugs.webkit.org/show_bug.cgi?id=199627
3076
3077         Reviewed by Brady Eidson.
3078
3079         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3080         (TestWebKitAPI::TEST_F):
3081
3082 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3083
3084         [ews-build] Do not run unix commands for windows in PrintConfiguration
3085         https://bugs.webkit.org/show_bug.cgi?id=199605
3086
3087         Reviewed by Jonathan Bedard.
3088
3089         * BuildSlaveSupport/ews-build/steps.py:
3090
3091 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3092
3093         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
3094         https://bugs.webkit.org/show_bug.cgi?id=199487
3095
3096         Reviewed by Ross Kirsling.
3097
3098         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
3099         failing to open testglobalscope_constructors_file which was
3100         created by using tempfile.mkstemp() because it keeps the file
3101         open. Use tempfile.mkdtemp() to create temporary files in the
3102         temporary directory instead of tempfile.mkstemp().
3103
3104         * Scripts/webkitpy/bindings/main.py:
3105         (BindingsTests.run_tests):
3106         (BindingsTests.main):
3107         (BindingsTests.close_and_remove): Deleted.
3108
3109 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3110
3111         [ews-build] Add KillOldProcesses step before running API or Layout tests
3112         https://bugs.webkit.org/show_bug.cgi?id=199592
3113
3114         Reviewed by Jonathan Bedard.
3115
3116         * BuildSlaveSupport/ews-build/factories.py:
3117
3118 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
3119
3120         test-webkitpy: Explicitly use Python 2.7 lldb library
3121         https://bugs.webkit.org/show_bug.cgi?id=199578
3122         <rdar://problem/51853557>
3123
3124         Reviewed by Aakash Jain.
3125
3126         * Scripts/webkitpy/common/system/systemhost.py:
3127         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
3128         * Scripts/webkitpy/test/main.py:
3129         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
3130
3131 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
3132
3133         Add test expectations and baselines for Catalina
3134         https://bugs.webkit.org/show_bug.cgi?id=199328
3135
3136         Reviewed by Jonathan Bedard.
3137
3138         * Scripts/webkitpy/port/mac.py:
3139         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
3140
3141 2019-07-08  Christopher Reid  <chris.reid@sony.com>
3142
3143         Implement MappedFileData for Windows
3144         https://bugs.webkit.org/show_bug.cgi?id=198269
3145
3146         Reviewed by Darin Adler.
3147
3148         * TestWebKitAPI/PlatformWin.cmake:
3149
3150 2019-07-08  Charlie Turner  <cturner@igalia.com>
3151
3152         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
3153         https://bugs.webkit.org/show_bug.cgi?id=197558
3154
3155         Reviewed by Xabier Rodriguez-Calvar.
3156
3157         On shutdown we can easily deadlock the web process if we don't
3158         ensure all network operations are completed before comitting state
3159         changes. In HLS, make sure the network operations are cancelled,
3160         and also prevent hlsdemux's retry logic from scuppering our
3161         efforts.
3162
3163         * gstreamer/jhbuild.modules: Include the patch.
3164         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
3165
3166 2019-07-08  Antoine Quint  <graouts@apple.com>
3167
3168         [Pointer Events] Enable only on the most recent version of the supported iOS family
3169         https://bugs.webkit.org/show_bug.cgi?id=199562
3170         <rdar://problem/52766511>
3171
3172         Reviewed by Dean Jackson.
3173
3174         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3175
3176 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
3177
3178         Long hang when loading a cnn.com page on iOS
3179         https://bugs.webkit.org/show_bug.cgi?id=199556
3180
3181         Reviewed by Zalan Bujtas.
3182
3183         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
3184         to load a test page of your choice.
3185
3186         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
3187         (-[WebViewController viewDidLoad]):
3188
3189 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3190
3191         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
3192         https://bugs.webkit.org/show_bug.cgi?id=199503
3193
3194         Reviewed by Wenson Hsieh.
3195
3196         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
3197         _requestActivatedElementAtPosition
3198
3199         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3200         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3201         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3202         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3203         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3204         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3205         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3206         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3207         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3208         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3209         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
3210         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3211
3212 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3213
3214         Unreviewed, rolling out r247115.
3215
3216         Breaks lldbWebKitTester (and by extension, test-webkitpy)
3217
3218         Reverted changeset:
3219
3220         "[WHLSL] Standard library is too big to directly include in
3221         WebCore"
3222         https://bugs.webkit.org/show_bug.cgi?id=198186
3223         https://trac.webkit.org/changeset/247115
3224
3225 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3226
3227         Unreviewed, rolling out r247123.
3228
3229         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
3230         fail.
3231
3232         Reverted changeset:
3233
3234         "Only allow fetching and removing session credentials from
3235         WebsiteDataStore"
3236         https://bugs.webkit.org/show_bug.cgi?id=199385
3237         https://trac.webkit.org/changeset/247123
3238
3239 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3240
3241         Touching media controls sometimes shows software keyboard
3242         https://bugs.webkit.org/show_bug.cgi?id=199490
3243         <rdar://problem/52076270>
3244
3245         Reviewed by Eric Carlson.
3246
3247         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
3248         ChangeLog entries for more detail.
3249
3250         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3251         (WTR::UIScriptController::hasInputSession const):
3252         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3253         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3254         (WTR::UIScriptController::hasInputSession const):
3255         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3256         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3257         (WTR::UIScriptController::hasInputSession const):
3258
3259 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
3260
3261         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
3262         https://bugs.webkit.org/show_bug.cgi?id=199458
3263
3264         Reviewed by Michael Catanzaro.
3265
3266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3267         * QueueStatusServer/config/queues.py:
3268
3269 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3270
3271         [GTK] Fix browserperfdash script after r239522
3272         https://bugs.webkit.org/show_bug.cgi?id=199496
3273
3274         Reviewed by Michael Catanzaro.
3275
3276         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
3277         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
3278
3279 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3280
3281         [webkitpy] test-webkitpy is broken on Linux since r246662
3282         https://bugs.webkit.org/show_bug.cgi?id=199493
3283
3284         Reviewed by Michael Catanzaro.
3285
3286         * Scripts/webkitpy/test/main.py:
3287         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
3288
3289 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3290
3291         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
3292         https://bugs.webkit.org/show_bug.cgi?id=199406
3293
3294         Reviewed by Michael Catanzaro.
3295
3296         Install the Woff2 libraries and headers from the system package
3297         and stop building them on the JHBuild.
3298
3299         * gtk/install-dependencies:
3300         * gtk/jhbuild.modules:
3301         * wpe/install-dependencies:
3302         * wpe/jhbuild.modules:
3303
3304 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3305
3306         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
3307         https://bugs.webkit.org/show_bug.cgi?id=199449
3308
3309         Reviewed by Michael Catanzaro.
3310
3311         * Scripts/webkitdirs.pm:
3312         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
3313
3314 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3315
3316         Unreviewed, GTK a11y tests fix after r247071
3317
3318         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3319         (WTR::AccessibilityUIElement::popupValue const):
3320
3321 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3322
3323         [ews-build] Enable WPE and GTK queues on new EWS
3324         https://bugs.webkit.org/show_bug.cgi?id=199234
3325
3326         Reviewed by Jonathan Bedard.
3327
3328         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
3329         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
3330         * BuildSlaveSupport/ews-build/steps.py:
3331         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
3332         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3333         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3334         (StatusBubble): Enable gtk and wpe status-bubbles.
3335
3336 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
3337
3338         Only allow fetching and removing session credentials from WebsiteDataStore
3339         https://bugs.webkit.org/show_bug.cgi?id=199385
3340
3341         Reviewed by Alex Christensen.
3342
3343         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3344         (TestWebKitAPI::TEST):
3345
3346 2019-07-03  Tim Horton  <timothy_horton@apple.com>
3347
3348         UI process exception when dragging an <attachment> with no content type
3349         https://bugs.webkit.org/show_bug.cgi?id=199480
3350         <rdar://problem/44351353>
3351
3352         Reviewed by Wenson Hsieh.
3353
3354         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3355         (TestWebKitAPI::TEST):
3356         Add a test; before the change, it crashes.
3357
3358 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
3359
3360         [Catalina] Enable WebKit build
3361         https://bugs.webkit.org/show_bug.cgi?id=199209
3362
3363         Reviewed by Darin Adler.
3364
3365         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
3366
3367 2019-07-03  Sam Weinig  <weinig@apple.com>
3368
3369         Adopt simple structured bindings in more places
3370         https://bugs.webkit.org/show_bug.cgi?id=199247
3371
3372         Reviewed by Alex Christensen.
3373
3374         Replaces simple uses of std::tie() with structured bindings. Does not touch
3375         uses of std::tie() that are not initial declarations, use std::ignore or in
3376         case where the binding is captured by a lambda, as structured bindings don't
3377         work for those cases yet.
3378
3379         * TestWebKitAPI/ios/PreferredContentMode.mm:
3380         (TestWebKitAPI::TEST):
3381
3382 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3383
3384         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
3385
3386         * BuildSlaveSupport/ews-build/steps.py:
3387         (PrintConfiguration.run):
3388
3389 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-build] Add build steps to Install Wpe and Gtk dependencies
3392         https://bugs.webkit.org/show_bug.cgi?id=199408
3393
3394         Reviewed by Michael Catanzaro.
3395
3396         * BuildSlaveSupport/ews-build/steps.py:
3397         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
3398         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
3399         (InstallWpeDependencies): Ditto for WPE.
3400         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3401
3402 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3403
3404         [ews-build] Allow skipping uploading built product for few builders
3405         https://bugs.webkit.org/show_bug.cgi?id=199422
3406
3407         Reviewed by Michael Catanzaro.
3408
3409         * BuildSlaveSupport/ews-build/steps.py:
3410         (CompileWebKit.__init__): Added optional skipUpload parameter.
3411         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
3412
3413 2019-07-02  Tim Horton  <timothy_horton@apple.com>
3414
3415         REGRESSION (r243240): Unable to swipe back in Safari
3416         https://bugs.webkit.org/show_bug.cgi?id=199394
3417         <rdar://problem/51137447>
3418
3419         Reviewed by Wenson Hsieh.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3422         Make sure that we actually end up with swipe gesture recognizers installed
3423         after process swap and crash.
3424
3425 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
3426
3427         Enhance support of aria-haspopup per ARIA 1.1 specification.
3428         https://bugs.webkit.org/show_bug.cgi?id=199216
3429         <rdar://problem/46221342>
3430
3431         Reviewed by Chris Fleizach.
3432
3433         * DumpRenderTree/AccessibilityUIElement.cpp:
3434         (getPopupValueCallback):
3435         (AccessibilityUIElement::getJSClass):
3436         * DumpRenderTree/AccessibilityUIElement.h:
3437         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3438         (AccessibilityUIElement::popupValue const):
3439         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3440         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3441         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3442         (WTR::AccessibilityUIElement::popupValue const):
3443         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3444         (WTR::AccessibilityUIElement::popupValue const):
3445
3446 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [ews-build] Do not print worker environment variables in each build step [part 2]
3449         https://bugs.webkit.org/show_bug.cgi?id=199405
3450
3451         Reviewed by Jonathan Bedard.
3452
3453         * BuildSlaveSupport/ews-build/steps.py:
3454         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
3455         (CleanWorkingDirectory.__init__): Ditto.
3456         (RunBindingsTests.__init__): Ditto.
3457         (RunWebKitPerlTests.__init__): Ditto.
3458         (RunWebKitPyTests.__init__): Ditto.
3459         (CompileWebKit.__init__): Ditto.
3460         (ArchiveTestResults.__init__): Ditto.
3461         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3462
3463 2019-07-02  Jer Noble  <jer.noble@apple.com>
3464
3465         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
3466         https://bugs.webkit.org/show_bug.cgi?id=199381
3467         <rdar://problem/52483103>
3468
3469         Reviewed by Eric Carlson.
3470
3471         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
3472
3473 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3474
3475         [ews-build] Update bot configuration for WPE and GTK
3476         https://bugs.webkit.org/show_bug.cgi?id=199238
3477
3478         Reviewed by Michael Catanzaro.
3479
3480         * BuildSlaveSupport/ews-build/config.json:
3481
3482 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3483
3484         [ews-build] Make PrintConfiguration platform aware
3485         https://bugs.webkit.org/show_bug.cgi?id=196657
3486
3487         Reviewed by Lucas Forschler.
3488
3489         * BuildSlaveSupport/ews-build/steps.py:
3490         (PrintConfiguration): Specified platform-specific command lists.
3491         (PrintConfiguration.run): Override run method and specify platform specific commands.
3492         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3493
3494 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
3495
3496         [Wasm-References] Disable references by default
3497         https://bugs.webkit.org/show_bug.cgi?id=199390
3498
3499         Reviewed by Saam Barati.
3500
3501         * Scripts/run-jsc-stress-tests:
3502
3503 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
3504
3505         Unreviewed. Revert r246965 to fix build break
3506         since r247019 reverted its related changes.
3507
3508         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3509         (WTR::AccessibilityUIElement::popupValue const): Deleted.
3510
3511 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3512
3513         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
3514         https://bugs.webkit.org/show_bug.cgi?id=199371
3515         <rdar://problem/52352905>
3516
3517         Reviewed by Tim Horton.
3518
3519         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3520         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
3521         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3522         (-[NavigationActionSPIDelegate spiCalled]):
3523         (TEST):
3524
3525 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3526
3527         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
3528         https://bugs.webkit.org/show_bug.cgi?id=199296
3529         <rdar://problem/51041960>
3530
3531         Reviewed by Darin Adler.
3532
3533         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3534         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
3535
3536 2019-07-01  Truitt Savell  <tsavell@apple.com>
3537
3538         Unreviewed, rolling out r246958.
3539
3540         Broke inspector/dom/getAccessibilityPropertiesForNode.html
3541
3542         Reverted changeset:
3543
3544         "Enhance support of aria-haspopup per ARIA 1.1 specification."
3545         https://bugs.webkit.org/show_bug.cgi?id=199216
3546         https://trac.webkit.org/changeset/246958
3547
3548 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3549
3550         Unreviewed, GTK a11y tests fix after r246958
3551
3552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3553         (WTR::AccessibilityUIElement::popupValue const):
3554
3555 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
3556
3557         Enhance support of aria-haspopup per ARIA 1.1 specification.
3558         https://bugs.webkit.org/show_bug.cgi?id=199216
3559         <rdar://problem/46221342>
3560
3561         Reviewed by Chris Fleizach.
3562
3563         * DumpRenderTree/AccessibilityUIElement.cpp:
3564         (getPopupValueCallback):
3565         (AccessibilityUIElement::getJSClass):
3566         * DumpRenderTree/AccessibilityUIElement.h:
3567         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3568         (AccessibilityUIElement::popupValue const):
3569         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3570         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3571         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3572         (WTR::AccessibilityUIElement::popupValue const):
3573         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3574         (WTR::AccessibilityUIElement::popupValue const):
3575
3576 2019-06-28  Robin Morisset  <rmorisset@apple.com>
3577
3578         Adding myself as a reviewer to contributors.json.
3579
3580         Unreviewed.
3581
3582         * Scripts/webkitpy/common/config/contributors.json:
3583
3584 2019-06-28  Jer Noble  <jer.noble@apple.com>
3585
3586         Add new -[WKWebView _closeAllMediaPresentations] SPI
3587         https://bugs.webkit.org/show_bug.cgi?id=199294
3588         <rdar://problem/51965958>
3589
3590         Reviewed by Alex Christensen.
3591
3592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3593         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
3594         (TEST):
3595
3596 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
3597
3598         Add a regression test for change r246901
3599         https://bugs.webkit.org/show_bug.cgi?id=199290
3600
3601         Reviewed by Geoffrey Garen.
3602
3603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3604         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3605         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3606         (TEST):
3607         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
3608
3609 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
3610
3611         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
3612         https://bugs.webkit.org/show_bug.cgi?id=199317
3613
3614         Reviewed by Michael Catanzaro.
3615
3616         While IconDatabase and all code using it was removed,
3617         ENABLE_ICONDATABASE still exists as build option and C++ macro.
3618
3619         * Scripts/webkitperl/FeatureList.pm:
3620         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3621         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
3622         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
3623
3624 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3625
3626         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
3627         https://bugs.webkit.org/show_bug.cgi?id=199310
3628         <rdar://problem/52292137>
3629
3630         Reviewed by Megan Gardner.
3631
3632         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
3633         _elementDidFocus.
3634
3635         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3636         (TestWebKitAPI::TEST):
3637         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3638         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3639         (-[TestInputDelegate setDidStartInputSessionHandler:]):
3640         (-[TestInputDelegate didStartInputSessionHandler]):
3641
3642         Add plumbing for a handler block in TestInputDelegate.
3643
3644         (-[TestInputDelegate setWillStartInputSessionHandler:]):
3645
3646         Drive-by style fixes to add a space between id and < for Objective-C protocols.
3647
3648         (-[TestInputDelegate willStartInputSessionHandler]):
3649         (-[TestInputDelegate _webView:willStartInputSession:]):
3650         (-[TestInputDelegate _webView:didStartInputSession:]):
3651         * TestWebKitAPI/cocoa/TestWKWebView.h:
3652         * TestWebKitAPI/ios/UIKitSPI.h:
3653
3654         Add a declaration for _selectionClipRects.
3655