Build fix for non-USE_SIM_SERVICE_CONTEXT builds
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2
3         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
4         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
5
6 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
7
8         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
9         https://bugs.webkit.org/show_bug.cgi?id=160985
10
11         Reviewed by Alexey Proskuryakov.
12         
13         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
14         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
15         must not be @memoized, because their return value depends on the value of simulator_device_type().
16         
17         Fix by adding some global state in simulator.py that tracks the created devices 
18         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
19         and delete them in clean_up_test_run().
20         
21         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
22         that killing the Simulator apps isn't enough.
23         
24         Simulator tracks the devices in a global dictionary, since state needs to persist
25         across different instances of IOSSimulatorPort.
26         
27         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
28         any setup. Rather than implicitly creating a device here (which the old code did),
29         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
30         and set flag to say that device_id_for_worker_number() doesn't need to return a real
31         device id.
32
33         * Scripts/webkitpy/layout_tests/views/printing.py:
34         (print_options):
35         (Printer.print_config):
36         * Scripts/webkitpy/port/base.py:
37         (Port.driver_cmd_line_for_logging):
38         (Port.driver_cmd_line): Deleted.
39         * Scripts/webkitpy/port/driver.py:
40         (IOSSimulatorDriver.cmd_line):
41         * Scripts/webkitpy/port/ios.py:
42         (IOSSimulatorPort.__init__):
43         (IOSSimulatorPort.driver_cmd_line_for_logging):
44         (IOSSimulatorPort._create_simulators):
45         (IOSSimulatorPort.setup_test_run):
46         (IOSSimulatorPort.clean_up_test_run):
47         (IOSSimulatorPort._create_device):
48         (IOSSimulatorPort):
49         (IOSSimulatorPort._remove_device):
50         (IOSSimulatorPort._testing_device):
51         (IOSSimulatorPort.device_id_for_worker_number):
52         (IOSSimulatorPort._set_device_class): Deleted.
53         (IOSSimulatorPort.testing_device): Deleted.
54         * Scripts/webkitpy/port/port_testcase.py:
55         (PortTestCase.test_driver_cmd_line):
56         * Scripts/webkitpy/xcode/simulator.py:
57         (Device.shutdown):
58         (Device.delete):
59         (Device.reset):
60         (Simulator.create_device):
61         (Simulator.remove_device):
62         (Simulator.device_number):
63         (Simulator.device_state_description):
64         (Simulator.wait_until_device_is_in_state):
65
66 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
67
68         Adopt SimServiceContext in LayoutTestRelay
69         https://bugs.webkit.org/show_bug.cgi?id=161000
70         <rdar://problem/25765594>
71
72         Reviewed by Daniel Bates.
73
74         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
75         * LayoutTestRelay/LayoutTestRelay/main.m:
76
77 2016-08-19  Lucas Forschler  <lforschler@apple.com>
78
79         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
80
81         Reviewed by Kocsen Chung.
82
83         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
84         (WebKitBuildbot):
85
86 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
87
88         Partial revert of r203811 - this key is not needed.
89
90         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
91
92 2016-08-19  Daniel Bates  <dabates@apple.com>
93
94         Another attempt to fix the iOS 9.3 build
95
96         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
97
98         * DumpRenderTree/mac/Configurations/Base.xcconfig:
99         * WebKitTestRunner/Configurations/Base.xcconfig:
100
101 2016-08-19  Lucas Forschler  <lforschler@apple.com>
102
103         Remove Yosemite Leaks bot from config.json
104         
105         Reviewed by Alexey Proskuryakov.
106
107         * BuildSlaveSupport/build.webkit.org-config/config.json:
108
109 2016-08-18  Dan Bernstein  <mitz@apple.com>
110
111         [Cocoa] API::Number needs to be wrapped by an NSNumber
112         https://bugs.webkit.org/show_bug.cgi?id=160977
113         <rdar://problem/27877735>
114
115         Reviewed by Anders Carlsson.
116
117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
118         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
119         (TestWebKitAPI::TEST):
120
121 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
122
123         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
124         https://bugs.webkit.org/show_bug.cgi?id=160895
125
126         Reviewed by Dean Jackson.
127
128         Link to the existing CoreText framework.
129
130         * DumpRenderTree/PlatformWin.cmake:
131         * TestWebKitAPI/PlatformWin.cmake:
132
133 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
134
135         [Win] Remove old libraries from build inputs
136         https://bugs.webkit.org/show_bug.cgi?id=160949
137
138         Reviewed by Dean Jackson.
139
140         Modify the download script to remove the old 'icuuc.lib' and
141         'icuin.lib' files for Windows builds.
142
143         * Scripts/update-webkit-auxiliary-libs:
144
145 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
146
147         Extra logging for crash reason
148         https://bugs.webkit.org/show_bug.cgi?id=160943
149
150         Reviewed by Alexey Proskuryakov.
151
152         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
153
154         * Scripts/webkitpy/port/server_process.py:
155         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
156         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
157         (ServerProcess.has_crashed): Ditto.
158
159 2016-08-17  Dan Bernstein  <mitz@apple.com>
160
161         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
162         https://bugs.webkit.org/show_bug.cgi?id=160938
163         <rdar://problem/27876652>
164
165         Reviewed by Anders Carlsson.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
169         (TestWebKitAPI::TEST):
170
171 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
172
173         AX: Support abbreviations in iOS
174         https://bugs.webkit.org/show_bug.cgi?id=160907
175
176         Reviewed by Joanmarie Diggs.
177
178         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
179         (AccessibilityUIElement::stringAttributeValue):
180         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
181         (WTR::AccessibilityUIElement::stringAttributeValue):
182
183 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
184
185         [EFL] Bump efl version from 1.17 to 1.18
186         https://bugs.webkit.org/show_bug.cgi?id=160899
187
188         Reviewed by Antonio Gomes.
189
190         To use efl-1.18, EFL port needs to update install dependencies as well.
191
192         * efl/install-dependencies:
193         * efl/jhbuild.modules:
194
195 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
196
197         [Win] Add tests for linked fonts.
198         https://bugs.webkit.org/show_bug.cgi?id=160898
199
200         Reviewed by Brent Fulgham.
201
202         Add tests for https://trac.webkit.org/changeset/204502.
203
204         * TestWebKitAPI/PlatformWin.cmake:
205         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
206         (TestWebKitAPI::TEST):
207
208 2016-08-16  Daniel Bates  <dabates@apple.com>
209
210         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
211         https://bugs.webkit.org/show_bug.cgi?id=160924
212
213         Reviewed by Stephanie Lewis.
214
215         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
216         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
217         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
218         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
219         object that mocks out the file system and SCM operations.
220
221         * Scripts/VCSUtils.pm:
222         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
223         * Scripts/prepare-ChangeLog:
224         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
225         abstracting the logic to query the file system and SCM into functions on a delegate object that
226         we pass to it.
227         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
228         (diffHeaderFormat): Deleted.
229
230 2016-08-16  Alex Christensen  <achristensen@webkit.org>
231
232         URLParser should parse URLs without credentials
233         https://bugs.webkit.org/show_bug.cgi?id=160913
234
235         Reviewed by Brady Eidson.
236
237         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
238         (TestWebKitAPI::s):
239         (TestWebKitAPI::checkURL):
240         (TestWebKitAPI::TEST_F):
241
242 2016-08-16  Anders Carlsson  <andersca@apple.com>
243
244         Add WTF::ScopeExit
245         https://bugs.webkit.org/show_bug.cgi?id=160908
246
247         Reviewed by Geoffrey Garen.
248
249         * TestWebKitAPI/CMakeLists.txt:
250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
251         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
252         (TestWebKitAPI::TEST):
253
254 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
255
256         EWS logs file are rotated too quickly
257         https://bugs.webkit.org/show_bug.cgi?id=160724
258
259         Reviewed by Daniel Bates.
260
261         Currently we are rotating the log file after 10 iterations of queue. If the queue
262         doesn't have any pending patches, these iterations result in very small amount of 
263         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
264         This results in a lot of log files in a day. This patch ensures that we rotate the
265         log file when its file size is greater than or equal to 100 KB.
266
267         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
268
269 2016-08-16  Daniel Bates  <dabates@apple.com>
270
271         WKSI static library should be named by major iOS revision, not individual updates
272         https://bugs.webkit.org/show_bug.cgi?id=160727
273         <rdar://problem/22274848>
274
275         Reviewed by Alexey Proskuryakov.
276
277         * DumpRenderTree/mac/Configurations/Base.xcconfig:
278         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
279         * Scripts/copy-webkitlibraries-to-product-directory:
280         * WebKitTestRunner/Configurations/Base.xcconfig:
281         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
282
283 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
284
285         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
286         https://bugs.webkit.org/show_bug.cgi?id=160909
287
288         Reviewed by Enrica Casucci.
289         
290         Add functions to UIScriptController to dismiss the form accessory view for iOS,
291         and to programmatically pick a row from a <select> picker.
292
293         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
294         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
295         (WTR::UIScriptController::dismissFormAccessoryView):
296         (WTR::UIScriptController::selectFormAccessoryPickerRow):
297         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
298         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
299         (WTR::UIScriptController::dismissFormAccessoryView):
300         (WTR::UIScriptController::selectFormAccessoryPickerRow):
301
302 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
303
304         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
305         https://bugs.webkit.org/show_bug.cgi?id=160878
306
307         Reviewed by Tim Horton.
308         
309         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
310         now that we have the ability to run tests in the iPad simulator.
311
312         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
313         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
314         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
315         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
316         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
317         * WebKitTestRunner/ios/TestControllerIOS.mm:
318         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
319         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
320         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
321         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
322
323 2016-08-15  Anders Carlsson  <andersca@apple.com>
324
325         Add an address-of operator to RetainPtr
326         https://bugs.webkit.org/show_bug.cgi?id=160879
327
328         Reviewed by Tim Horton.
329
330         Test HashMap and HashSet with an object whose operator& is deleted.
331
332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
333         Sort the Xcode project.
334
335         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
336         (DeletedAddressOfOperator::DeletedAddressOfOperator):
337         (DeletedAddressOfOperator::value):
338         (DeletedAddressOfOperator::operator==):
339         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
340         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
341         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
342         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
343         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
344         (TestWebKitAPI::TEST):
345         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
346         (TestWebKitAPI::TEST):
347
348 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
349
350         False crashes in fast/text/emoji-gender-* tests
351         https://bugs.webkit.org/show_bug.cgi?id=160779
352
353         Reviewed by Alexey Proskuryakov.
354
355         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
356
357         * Scripts/webkitpy/port/driver.py:
358         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
359         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
360         * Scripts/webkitpy/port/server_process.py:
361         (ServerProcess.write): Allow caller to disable crash flag on exception.
362
363 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
364
365         webkitpy error in TestRunResults.merge()
366         https://bugs.webkit.org/show_bug.cgi?id=160882
367
368         Reviewed by Daniel Bates.
369         
370         The argument to TestRunResults.merge() can be None if there are no device-specifc
371         initial results or retry results in Manager.run(), so just return early in that case.
372
373         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
374         (TestRunResults.merge):
375
376 2016-08-15  Sam Weinig  <sam@webkit.org>
377
378         Speed up compile times by not including wtf/Variant.h so much
379         https://bugs.webkit.org/show_bug.cgi?id=160847
380
381         Reviewed by Alex Christensen and Saam Barati.
382
383         * TestWebKitAPI/Tests/WTF/Variant.cpp:
384         (TestWebKitAPI::TEST):
385         Explicitly use std::experimental::variant.
386
387 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
388
389         Allow a port to run tests with a custom device setup
390         https://bugs.webkit.org/show_bug.cgi?id=160833
391
392         Reviewed by Daniel Bates.
393
394         These changes allow the IOSSimulator port to run tests in iPad mode.
395
396         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
397         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
398         a custom device will be collected into a set, and run in that device's environment after
399         the other tests have run.
400
401         * Scripts/webkitpy/layout_tests/controllers/manager.py:
402         (Manager._custom_device_for_test): If the test contains a directory matching a
403         custom device suffix, return that custom device.
404         (Manager._set_up_run): Push the custom device class, if any, into options so
405         that the Worker can get to it.
406         (Manager.run): Go through the list of tests, and break it down into device-generic
407         tests, and tests for each device class. _run_test_subset is then called for
408         each collection of tests, and the results merged.
409         (Manager._run_test_subset): Some lines unwrapped.
410         (Manager._end_test_run):
411         (Manager._run_tests):
412         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
413         (SingleTestRunner.__init__): Unwrapped a line.
414         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
415         (TestRunResults.merge): Add this function to merge TestRunResults
416         * Scripts/webkitpy/layout_tests/views/printing.py:
417         (Printer.print_workers_and_shards): Print the custom device, if any.
418         * Scripts/webkitpy/port/base.py:
419         (Port): Base port has empty array of custom devices.
420         (Port.setup_test_run): Add device_class argument.
421         * Scripts/webkitpy/port/driver.py:
422         (DriverInput.__repr__):
423         (Driver.check_driver.implementation):
424         * Scripts/webkitpy/port/efl.py:
425         (EflPort.setup_test_run):
426         * Scripts/webkitpy/port/gtk.py:
427         (GtkPort.setup_test_run):
428         * Scripts/webkitpy/port/ios.py:
429         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
430         (IOSSimulatorPort.__init__):
431         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
432         based on the custom device class.
433         (IOSSimulatorPort._set_device_class):
434         (IOSSimulatorPort._create_simulators): Factor some code into this function.
435         (IOSSimulatorPort.setup_test_run):
436         (IOSSimulatorPort.testing_device):
437         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
438         seemed wrong for this function. That was moved to setup_test_run().
439         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
440         but this happened too early, before we knew which kind of devices to create. Devices
441         are now created in setup_test_run().
442         * Scripts/webkitpy/port/win.py:
443         (WinPort.setup_test_run):
444
445 2016-08-15  Daniel Bates  <dabates@apple.com>
446
447         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
448         private frameworks and libraries
449         https://bugs.webkit.org/show_bug.cgi?id=155931
450         <rdar://problem/25807989>
451
452         Reviewed by Dan Bernstein.
453
454         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
455         where X is the major version of the active iOS SDK.
456
457         * DumpRenderTree/mac/Configurations/Base.xcconfig:
458         * WebKitTestRunner/Configurations/Base.xcconfig:
459
460 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
461
462         Add a setting and preferences to enable visual viewport mode
463         https://bugs.webkit.org/show_bug.cgi?id=160843
464
465         Reviewed by Sam Weinig.
466         
467         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
468
469         * MiniBrowser/mac/SettingsController.h:
470         * MiniBrowser/mac/SettingsController.m:
471         (-[SettingsController _populateMenu]):
472         (-[SettingsController validateMenuItem:]):
473         (-[SettingsController visualViewportEnabled]):
474         (-[SettingsController toggleVisualViewportEnabled:]):
475         * MiniBrowser/mac/WK1BrowserWindowController.m:
476         (-[WK1BrowserWindowController didChangeSettings]):
477         * MiniBrowser/mac/WK2BrowserWindowController.m:
478         (-[WK2BrowserWindowController didChangeSettings]):
479
480 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
481
482         Allow using make-dist with non-GTK ports
483         https://bugs.webkit.org/show_bug.cgi?id=160842
484
485         Reviewed by Michael Catanzaro.
486
487         This patch adds support for setting base name of tarball and argument
488         passed to cmake's -DPORT= via command line arguments.
489
490         * gtk/make-dist.py:
491         (Distcheck.configure):
492         (Distcheck.check):
493         (get_tarball_root_and_output_filename_from_arguments):
494
495 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
496
497         [GTK] Install script lacks gstreamer related dependencies
498         https://bugs.webkit.org/show_bug.cgi?id=160814
499
500         Reviewed by Carlos Garcia Campos.
501
502         * gtk/install-dependencies: Fedora case had already listed this dependencies,
503         but both Arch and Debian/Ubuntu were missing them.
504
505 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
506
507         make-dist.py should not allow unknown rules in manifest
508         https://bugs.webkit.org/show_bug.cgi?id=160841
509
510         Reviewed by Carlos Garcia Campos.
511
512         * gtk/make-dist.py:
513         (Manifest.process_line):
514
515 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
516
517         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
518         https://bugs.webkit.org/show_bug.cgi?id=160809
519
520         Reviewed by Carlos Garcia Campos.
521
522         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
523         case, and use it also for the new package names of libpng and libgeoclue.
524         * gtk/install-dependencies: Ditto.
525
526 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
527
528         Skip to check directories existence in build-webkit
529         https://bugs.webkit.org/show_bug.cgi?id=160691
530
531         Reviewed by Alex Christensen.
532
533         CMake checks if directories are there itself. So CMake ports
534         don't need to check it in the build-webkit script.
535
536         * Scripts/build-webkit:
537         * Scripts/webkitdirs.pm:
538         (determineSourceDir):
539         (isCMakeBuild):
540
541 2016-08-12  Alex Christensen  <achristensen@webkit.org>
542
543         Make URLParser work with URLs missing URL parts
544         https://bugs.webkit.org/show_bug.cgi?id=160824
545
546         Reviewed by Brady Eidson.
547
548         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
549         (TestWebKitAPI::s):
550         (TestWebKitAPI::checkURL):
551         (TestWebKitAPI::TEST_F):
552         (TestWebKitAPI::eq): Deleted.
553
554 2016-08-12  John Wilander  <wilander@apple.com>
555
556         Add HashCountedSet API tests to TestWTFLibrary target
557         https://bugs.webkit.org/show_bug.cgi?id=160815
558
559         Reviewed by Alex Christensen.
560
561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
562             Added HashCountedSet.cpp and sorted the file reference section
563             according to UNIX sort.
564
565 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
566
567         run-benchmark should run JetStream 1.1 instead of 1.0.1
568         https://bugs.webkit.org/show_bug.cgi?id=160816
569
570         Reviewed by Filip Pizlo.
571
572         Use the latest JetStream 1.1 in run-benchmark.
573
574         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
575         (BenchmarkBuilder.__exit__):
576         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
577         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
578         change to JetStream directory.
579
580 2016-08-12  Alex Christensen  <achristensen@webkit.org>
581
582         Initial URLParser implementation
583         https://bugs.webkit.org/show_bug.cgi?id=160811
584
585         Reviewed by Brady Eidson.
586
587         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
588         (TestWebKitAPI::eq):
589         (TestWebKitAPI::checkURL):
590         (TestWebKitAPI::TEST_F):
591
592 2016-08-12  Brady Eidson  <beidson@apple.com>
593
594         Fix the 32-bit Mac build after:
595         Add WK2 ExperimentalFeature support to MiniBrowser
596         https://bugs.webkit.org/show_bug.cgi?id=160788
597
598         Unreviewed.
599
600         Sprinkle "#if WK_API_ENABLED"s liberally.
601         
602         * MiniBrowser/mac/AppDelegate.m:
603         (defaultConfiguration):
604         * MiniBrowser/mac/SettingsController.m:
605         (-[SettingsController _populateMenu]):
606         (-[SettingsController validateMenuItem:]):
607
608 2016-08-12  Philippe Normand  <pnormand@igalia.com>
609
610         [GStreamer][OWR] Video rendering fixes
611         https://bugs.webkit.org/show_bug.cgi?id=160764
612
613         Reviewed by Xabier Rodriguez-Calvar.
614
615         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
616
617 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
618
619         Add missing return statement in convertFast function added in r204376.
620
621         Unreviewed.
622
623         * Scripts/webkitpy/common/system/path.py:
624         (_CygPath.convertFast):
625
626 2016-08-11  Brady Eidson  <beidson@apple.com>
627
628         Add WK2 ExperimentalFeature support to MiniBrowser.
629         https://bugs.webkit.org/show_bug.cgi?id=160788
630
631         Reviewed by Alex Christensen.
632
633         * MiniBrowser/mac/AppDelegate.h:
634         * MiniBrowser/mac/AppDelegate.m:
635         (defaultConfiguration):
636         (defaultPreferences):
637         
638         * MiniBrowser/mac/SettingsController.m:
639         (-[SettingsController _populateMenu]):
640         (-[SettingsController validateMenuItem:]):
641         (-[SettingsController toggleExperimentalFeature:]):
642
643 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
644
645         Keep EWS logs for longer
646         https://bugs.webkit.org/show_bug.cgi?id=160776
647
648         Reviewed by Daniel Bates.
649
650         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
651
652 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
653
654         iOS DRT/WTR project cleanup
655         https://bugs.webkit.org/show_bug.cgi?id=160778
656
657         Reviewed by Tim Horton.
658
659         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
660
661         Remove AppDelegate.* which were unused.
662
663         Exclude ios/Launch.storyboard on more platforms.
664
665         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
666         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
667         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
668         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
669         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
670         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
671         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
672
673 2016-08-11  Alex Christensen  <achristensen@webkit.org>
674
675         Fix Yosemite bots' cookie accept policies after r204365.
676         https://bugs.webkit.org/show_bug.cgi?id=160758
677
678         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
679         (TEST):
680         This makes the test fully clean up after itself.
681
682 2016-08-11  Alex Christensen  <achristensen@webkit.org>
683
684         Fix Yosemite bots' cookie accept policies after r204365.
685         https://bugs.webkit.org/show_bug.cgi?id=160758
686
687         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
688         (TEST):
689         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
690         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
691         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
692         causing any problems because there are no other API tests that do anything with cookies.
693         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
694         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
695         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
696
697 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
698
699         EWS should check if the patch is still valid before executing every major step
700         https://bugs.webkit.org/show_bug.cgi?id=160739
701         rdar://problem/27768813
702
703         Reviewed by Alexey Proskuryakov.
704
705         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
706         (CommitQueueTask.run): validate method is now executed in base class.
707         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
708         (EarlyWarningSystemTask.run): validate method is now executed in base class.
709         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
710         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
711         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
712         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
713         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
714         * Scripts/webkitpy/tool/commands/perfalizer.py:
715         (PerfalizerTask.validate): Added.
716         * Scripts/webkitpy/tool/commands/queues_unittest.py:
717         (test_manual_reject_during_processing): Updated test case.
718
719 2016-08-11  Alex Christensen  <achristensen@webkit.org>
720
721         Add URLParser stub
722         https://bugs.webkit.org/show_bug.cgi?id=160770
723
724         Reviewed by Sam Weinig.
725
726         * TestWebKitAPI/PlatformGTK.cmake:
727         * TestWebKitAPI/PlatformWin.cmake:
728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
729         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
730         (TestWebKitAPI::TEST_F):
731
732 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
733
734         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
735         https://bugs.webkit.org/show_bug.cgi?id=160761
736
737         Reviewed by Tim Horton.
738
739         Give iOS DRT a Launch storyboard.
740
741         Have it use a UIViewController so future forms testing works correctly.
742
743         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
744         can run in iPad mode.
745
746         Remove empty InfoPlist.strings files.
747
748         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
749         * DumpRenderTree/ios/Info.plist:
750         * DumpRenderTree/ios/Launch.storyboard: Added.
751         * DumpRenderTree/mac/DumpRenderTree.mm:
752         (createWebViewAndOffscreenWindow):
753         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
754         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
755         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
756         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
757
758 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
759
760         [Win] Unable to reliably run tests in parallel
761         https://bugs.webkit.org/show_bug.cgi?id=140914
762
763         Reviewed by Brent Fulgham.
764
765         The cygpath utility function can fail badly when running with multiple DumpRenderTree
766         processes. We can use string replacement to convert the Cygwin path to a Windows path
767         instead.
768
769         * Scripts/webkitpy/common/system/path.py:
770         (cygpathFast):
771         * Scripts/webkitpy/port/driver.py:
772         (Driver._command_from_driver_input):
773
774 2016-08-10  Alex Christensen  <achristensen@webkit.org>
775
776         Fix crash when changing cookie accept policy after r204327
777         https://bugs.webkit.org/show_bug.cgi?id=160758
778
779         Reviewed by Simon Fraser.
780
781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
782         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
783         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
784         (TEST):
785         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
786
787 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
788
789         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
790         https://bugs.webkit.org/show_bug.cgi?id=160757
791
792         Reviewed by Tim Horton.
793
794         When programmatically creating the test UIWindow, make a root UIViewController and parent
795         the WKWebView in its view. This makes the app more like a normal UIKit application.
796         
797         Move the WKWebView down 20px to avoid the status bar.
798         
799         Give the UIWindow a gray background so it's obvious where the window and view positioned.
800
801         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
802         
803         Remove duplicate references to Launch.storyboard.
804
805         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
806         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
807         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
808         (-[AppDelegate applicationWillResignActive:]): Deleted.
809         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
810         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
811         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
812         (-[AppDelegate applicationWillTerminate:]): Deleted.
813         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
814         (WTR::viewRectForWindowRect):
815         (WTR::PlatformWebView::PlatformWebView):
816         (WTR::PlatformWebView::setWindowFrame):
817
818 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
819
820         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
821         https://bugs.webkit.org/show_bug.cgi?id=160748
822
823         Reviewed by Tim Horton.
824         
825         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
826         opens the door for tests using other device sizes.
827
828         * WebKitTestRunner/ios/TestControllerIOS.mm:
829         (WTR::TestController::platformConfigureViewForTest):
830
831 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
832
833         Sort the feature flags in the FEATURE_DEFINES lines
834         https://bugs.webkit.org/show_bug.cgi?id=160742
835
836         Reviewed by Anders Carlsson.
837         
838         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
839
840 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
841
842         Logging and other minor improvements to iOS webkitpy
843         https://bugs.webkit.org/show_bug.cgi?id=160722
844
845         Reviewed by Dan Bates.
846
847         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
848         to make it easier to debug launching issues.
849
850         Have reset_preferences() reset the device, rather than just nuking the data
851         directory (which broke some versions of the simulator).
852
853         Make the Simulator.app launch in the background with open -g.
854
855         Wait for the simulator device to be in a known state in some more places.
856
857         * Scripts/webkitpy/port/ios.py:
858         (IOSSimulatorPort.setup_test_run):
859         (IOSSimulatorPort._quit_ios_simulator):
860         (IOSSimulatorPort.clean_up_test_run):
861         (IOSSimulatorPort.setup_environ_for_server):
862         (IOSSimulatorPort.reset_preferences):
863         * Scripts/webkitpy/xcode/simulator.py:
864         (Device.create):
865         (Device.delete):
866         (Device):
867         (Device.reset):
868         (Simulator.wait_until_device_is_booted):
869         (Simulator.wait_until_device_is_in_state):
870         (Simulator):
871         (Simulator.delete_device):
872         (Simulator.reset_device):
873         (Simulator.lookup_or_create_device):
874
875 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
876
877         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
878         https://bugs.webkit.org/show_bug.cgi?id=160697
879
880         Reviewed by Antonio Gomes.
881
882         * Scripts/webkitpy/port/base.py:
883         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
884         list of environment variables to copy.
885
886 2016-08-09  George Ruan  <gruan@apple.com>
887
888         Implement functionality of media capture on iOS
889         https://bugs.webkit.org/show_bug.cgi?id=158945
890         <rdar://problem/26893343>
891
892         Reviewed by Tim Horton.
893
894         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
895         Capture feature on iOS.
896
897 2016-08-09  Saam Barati  <sbarati@apple.com>
898
899         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
900         https://bugs.webkit.org/show_bug.cgi?id=160671
901         <rdar://problem/27756112>
902
903         Reviewed by Mark Lam.
904
905         * Scripts/run-jsc-stress-tests:
906
907 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
908
909         Make directory reading code in iOSSimulatorDevices() more strict
910         https://bugs.webkit.org/show_bug.cgi?id=160702
911
912         Reviewed by Tim Horton.
913
914         * Scripts/webkitdirs.pm:
915         (iOSSimulatorDevices):
916
917 2016-08-06  Sam Weinig  <sam@webkit.org>
918
919         Replace NodeOrString with std::variant<RefPtr<Node>, String>
920         https://bugs.webkit.org/show_bug.cgi?id=160638
921
922         Reviewed by Anders Carlsson.
923
924         * TestWebKitAPI/CMakeLists.txt:
925         * TestWebKitAPI/Tests/WTF/Variant.cpp:
926         Add additional tests for the initial state of std::variant and using
927         makeVisitor for visiting.
928
929 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
930
931         EWS logging should ensure the logging to file is stopped on queue termination
932         https://bugs.webkit.org/show_bug.cgi?id=160698
933         rdar://problem/24464570
934
935         Reviewed by Daniel Bates.
936
937         * Scripts/webkitpy/tool/bot/queueengine.py:
938         (QueueEngine._stopping): Stop logging to file on queue termination.
939         (QueueEngine._begin_logging): Configure the Python logger to log to file.
940         * Scripts/webkitpy/common/system/logutils.py:
941         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
942         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
943         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
944         * Scripts/webkitpy/tool/commands/queues.py:
945         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
946         (AbstractQueue.queue_log_path): Same.
947         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
948         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
949         which moved to QueueEngine now.
950         (PatchProcessingQueue.__init__): Same.
951         (CommitQueue.__init__): Same.
952         (AbstractReviewQueue.__init__): Same.
953         (StyleQueue.__init__): Same.
954         * Scripts/webkitpy/tool/commands/queues_unittest.py:
955         (TestCommitQueue): Removed host parameter.
956         (TestCommitQueue.__init__): Same.
957         (AbstractPatchQueueTest.test_next_patch): Same.
958         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
959         (test_commit_queue_failure): Same.
960         (mock_run_webkit_patch):
961         (MockCommitQueueTask.results_from_patch_test_run): Same.
962         (test_rollout_lands): Same.
963         (test_non_valid_patch): Same.
964         (test_auto_retry): Same.
965         (test_style_queue_with_watch_list_exception): Same.
966         (TestQueue.__init__): Deleted.
967         (TestReviewQueue.__init__): Deleted.
968         (TestFeederQueue.__init__): Deleted.
969
970 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
971
972         webkit-gtk tarball fails to build due to missing files
973         https://bugs.webkit.org/show_bug.cgi?id=160684
974
975         Reviewed by Alex Christensen.
976
977         * gtk/manifest.txt.in: Added back spi directories.
978
979 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
980
981         [GTK] Build the jhbuild with -O2 optimization level by default
982         https://bugs.webkit.org/show_bug.cgi?id=160544
983
984         Reviewed by Michael Catanzaro.
985
986         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
987         which don't increases the required disk space significatively and
988         provides better debug information than no passing it.
989
990 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
991
992         Allow more --cmakeargs option in build-jsc and build-webkit
993         https://bugs.webkit.org/show_bug.cgi?id=160340
994
995         Reviewed by Michael Catanzaro.
996
997         * Scripts/build-jsc:
998         * Scripts/build-webkit:
999
1000 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1001
1002         Do not check if WebKitLibraries folder exists on EFL and GTK
1003         https://bugs.webkit.org/show_bug.cgi?id=160659
1004
1005         Reviewed by Csaba Osztrogonác.
1006
1007         Though WebKitLibraries is only needed by mac and win ports,
1008         EFL and GTK ports have checked whether it exists.
1009
1010         * Scripts/build-webkit:
1011
1012 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1013
1014         Some EWS console logs doesn't go to log file
1015         https://bugs.webkit.org/show_bug.cgi?id=160585
1016         rdar://problem/24464570
1017
1018         Reviewed by Daniel Bates.
1019
1020         * Scripts/webkitpy/common/system/logutils.py:
1021         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1022         any possible overwriting.
1023         * Scripts/webkitpy/common/system/filesystem.py:
1024         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1025         * Scripts/webkitpy/common/system/filesystem_mock.py:
1026         (MockFileSystem.open_text_file_for_writing): Same.
1027         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1028         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1029         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1030         * Scripts/webkitpy/tool/commands/queues.py:
1031         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1032         This will ensure that all the sub-modules inside webkitpy will log to file.
1033
1034 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1035
1036         Have the iOS platform interit from the Apple platform in webkitpy
1037         https://bugs.webkit.org/show_bug.cgi?id=160672
1038
1039         Reviewed by Dan Bates.
1040         
1041         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1042         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1043         ApplePort.
1044         
1045         Since WinPort also inherits from ApplePort, it needs to stub out some things
1046         that are unavailable on Windows (leaks, sampling).
1047         
1048         Some SnowLeopard-related code and the associated test were removed.
1049
1050         * Scripts/webkitpy/port/apple.py:
1051         (ApplePort.__init__):
1052         (ApplePort):
1053         (ApplePort._make_leak_detector):
1054         (ApplePort.default_timeout_ms):
1055         (ApplePort.supports_per_test_timeout):
1056         (ApplePort.should_retry_crashes):
1057         (ApplePort._generate_all_test_configurations):
1058         (ApplePort.check_for_leaks):
1059         (ApplePort.print_leaks_summary):
1060         (ApplePort._path_to_webcore_library):
1061         (ApplePort.show_results_html_file):
1062         (ApplePort._merge_crash_logs):
1063         (ApplePort._look_for_all_crash_logs_in_log_dir):
1064         (ApplePort._get_crash_log):
1065         (ApplePort.look_for_new_crash_logs):
1066         (ApplePort.sample_process):
1067         (ApplePort.sample_file_path):
1068         (ApplePort.look_for_new_samples):
1069         (ApplePort._path_to_helper):
1070         (ApplePort.determine_full_port_name): Deleted.
1071         * Scripts/webkitpy/port/ios.py:
1072         (IOSSimulatorPort):
1073         (IOSSimulatorPort.__init__):
1074         (IOSSimulatorPort.default_timeout_ms): Deleted.
1075         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1076         (IOSSimulatorPort.should_retry_crashes): Deleted.
1077         (IOSSimulatorPort.check_for_leaks): Deleted.
1078         (IOSSimulatorPort.print_leaks_summary): Deleted.
1079         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1080         (IOSSimulatorPort.show_results_html_file): Deleted.
1081         (IOSSimulatorPort.sample_file_path): Deleted.
1082         (IOSSimulatorPort._merge_crash_logs): Deleted.
1083         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1084         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1085         (IOSSimulatorPort.look_for_new_samples): Deleted.
1086         (IOSSimulatorPort.sample_process): Deleted.
1087         (IOSSimulatorPort._path_to_helper): Deleted.
1088         (IOSSimulatorPort.make_command): Deleted.
1089         * Scripts/webkitpy/port/mac.py:
1090         (MacPort.__init__):
1091         (MacPort.make_command):
1092         (MacPort._build_java_test_support):
1093         (MacPort): Deleted.
1094         (MacPort.default_timeout_ms): Deleted.
1095         (MacPort.supports_per_test_timeout): Deleted.
1096         (MacPort.should_retry_crashes): Deleted.
1097         (MacPort.default_child_processes): Deleted.
1098         (MacPort.check_for_leaks): Deleted.
1099         (MacPort.print_leaks_summary): Deleted.
1100         (MacPort._path_to_webcore_library): Deleted.
1101         (MacPort.show_results_html_file): Deleted.
1102         (MacPort.sample_file_path): Deleted.
1103         (MacPort._merge_crash_logs): Deleted.
1104         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1105         (MacPort.look_for_new_crash_logs): Deleted.
1106         (MacPort.look_for_new_samples): Deleted.
1107         (MacPort.sample_process): Deleted.
1108         (MacPort._path_to_helper): Deleted.
1109         * Scripts/webkitpy/port/mac_unittest.py:
1110         (MacTest.test_default_child_processes): Deleted.
1111         * Scripts/webkitpy/port/win.py:
1112         (WinPort.look_for_new_samples):
1113         (WinPort):
1114         (WinPort.sample_process):
1115         (WinPort._make_leak_detector):
1116         (WinPort.check_for_leaks):
1117         (WinPort.print_leaks_summary):
1118         (WinPort._path_to_webcore_library):
1119
1120 2016-08-08  Matt Baker  <mattbaker@apple.com>
1121
1122         Unreviewed: moved myself to the reviewers list.
1123
1124         * Scripts/webkitpy/common/config/contributors.json:
1125
1126 2016-08-08  Chris Dumez  <cdumez@apple.com>
1127
1128         Update API tests in mac/SetDocumentURI.mm after r204247
1129         https://bugs.webkit.org/show_bug.cgi?id=160660
1130
1131         Reviewed by Alex Christensen.
1132
1133         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1134         (TestWebKitAPI::TEST):
1135
1136 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1137
1138         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1139         https://bugs.webkit.org/show_bug.cgi?id=159827
1140
1141         Reviewed by Daniel Bates.
1142
1143         This change was spurred by a process hang which occurred between tests and did
1144         not produce a meaningful crashlog.
1145
1146         * Scripts/webkitpy/port/driver.py:
1147         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1148
1149          * Scripts/webkitpy/port/ios.py:
1150         (IOSSimulatorPort):
1151         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1152         * Scripts/webkitpy/port/mac.py:
1153         (MacPort):
1154         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1155
1156         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1157         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1158
1159         * WebKitTestRunner/TestController.h:
1160         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1161         * WebKitTestRunner/TestInvocation.cpp:
1162         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1163
1164 2016-08-07  Dan Bernstein  <mitz@apple.com>
1165
1166         [Cocoa] Reply block leaks if the remote object doesn’t call it
1167         https://bugs.webkit.org/show_bug.cgi?id=160642
1168
1169         Reviewed by Sam Weinig.
1170
1171         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1172         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1173         (TEST): Added a test case that checks that the reply block is released even when it’s not
1174           called.
1175         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1176         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1177           calling the completion handler.
1178
1179 2016-08-07  Chris Dumez  <cdumez@apple.com>
1180
1181         Write API test to cover crash fix in r204135
1182         https://bugs.webkit.org/show_bug.cgi?id=160587
1183
1184         Reviewed by Darin Adler.
1185
1186         Add API test to cover crash fix in r204135. This reproduces the crash
1187         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1188         callback.
1189
1190         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1191         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1192         (TEST):
1193
1194 2016-08-06  Chris Dumez  <cdumez@apple.com>
1195
1196         Unreviewed, rolling out r204226.
1197
1198         Broke some API tests
1199
1200         Reverted changeset:
1201
1202         "Write API test to cover crash fix in r204135"
1203         https://bugs.webkit.org/show_bug.cgi?id=160587
1204         http://trac.webkit.org/changeset/204226
1205
1206 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1207
1208         EWS Style Queue fails to process patches which fails validation
1209         https://bugs.webkit.org/show_bug.cgi?id=160632
1210
1211         Reviewed by Alexey Proskuryakov.
1212
1213         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1214         (StyleQueueTask.validate): Add more information about validation failure.
1215         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1216         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1217         (test_non_valid_patch): Add a unit test to test the above code path.
1218
1219 2016-08-06  Sam Weinig  <sam@webkit.org>
1220
1221         WTF needs a variant implementation
1222         https://bugs.webkit.org/show_bug.cgi?id=160618
1223
1224         Reviewed by Darin Adler.
1225
1226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1227         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1228         Add tests for the variant implementation.
1229
1230 2016-08-06  Chris Dumez  <cdumez@apple.com>
1231
1232         Write API test to cover crash fix in r204135
1233         https://bugs.webkit.org/show_bug.cgi?id=160587
1234
1235         Reviewed by Darin Adler.
1236
1237         Add API test to cover crash fix in r204135. This reproduces the crash
1238         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1239         callback.
1240
1241         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1242         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1243         (TEST):
1244
1245 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1246
1247         run-api-tests should use a headed simulator
1248         https://bugs.webkit.org/show_bug.cgi?id=160611
1249
1250         Reviewed by Sam Weinig.
1251
1252         CADisplayLink doesn't work in a headless simulator, but is
1253         vital for the proper functioning of WebKit2 painting on iOS.
1254         So, we should not use a headless simulator.
1255
1256         * Scripts/run-api-tests:
1257         Launch a simulator app, don't just boot the simulator.
1258
1259         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1260         Re-enable a test that works now.
1261
1262 2016-08-05  Dan Bernstein  <mitz@apple.com>
1263
1264         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1265         https://bugs.webkit.org/show_bug.cgi?id=160589
1266
1267         Reviewed by Tim Horton.
1268
1269         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1270         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1271           blocks, which wasn’t caught because the test wasn’t run correctly.
1272         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1273         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1274           added a test that sends over an NSRange.
1275         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1276         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1277           handler with the range‘s location and length.
1278
1279 2016-08-05  Enrica Casucci  <enrica@apple.com>
1280
1281         Fixing tests failing after r204175.
1282
1283         Unreviewed.
1284
1285         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1286
1287 2016-08-05  Enrica Casucci  <enrica@apple.com>
1288
1289         Build fix after 204053.
1290
1291         Unreviewed.
1292
1293         * TestWebKitAPI/Configurations/Base.xcconfig:
1294         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1295         (-[MockContentFilterEnabler initWithCoder:]):
1296         (-[MockContentFilterEnabler dealloc]):
1297
1298 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1299
1300         Print test name in "Last character read from DRT..." error message.
1301         https://bugs.webkit.org/show_bug.cgi?id=160559
1302
1303         Reviewed by Michael Catanzaro.
1304
1305         * Scripts/webkitpy/port/driver.py:
1306         (Driver.run_test):
1307         (Driver._read_first_block):
1308         (Driver._read_optional_image_block):
1309         (Driver._read_block):
1310         * Scripts/webkitpy/port/driver_unittest.py:
1311         (DriverTest.test_read_block):
1312         (DriverTest.test_read_binary_block):
1313         (DriverTest.test_read_base64_block):
1314
1315 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1316
1317         Unreviewed, rolling out r204123.
1318         https://bugs.webkit.org/show_bug.cgi?id=160597
1319
1320         Caused layout test timeouts on Windows. (Requested by perarne
1321         on #webkit).
1322
1323         Reverted changeset:
1324
1325         "[Win] Unable to reliably run tests in parallel"
1326         https://bugs.webkit.org/show_bug.cgi?id=140914
1327         http://trac.webkit.org/changeset/204123
1328
1329 2016-08-04  Saam Barati  <sbarati@apple.com>
1330
1331         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1332         https://bugs.webkit.org/show_bug.cgi?id=151241
1333
1334         Reviewed by Benjamin Poulain.
1335
1336         * Scripts/run-jsc-stress-tests:
1337
1338 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1339
1340         UI improvements to Flakiness Dashboard.
1341         https://bugs.webkit.org/show_bug.cgi?id=153295
1342
1343         Reviewed by Alexey Proskuryakov.
1344
1345         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1346         (td.options-container): Center text in most fields.
1347         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1348         (createBugHTML): Text/Grammar updates.
1349         (tableHeaders): Ditto.
1350         (htmlForSingleTestRow): Ditto.
1351         (headerForTestTableHtml): Ditto.
1352         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1353         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1354
1355 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1356
1357         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1358         https://bugs.webkit.org/show_bug.cgi?id=160518
1359
1360         Reviewed by Michael Catanzaro.
1361
1362         * Scripts/webkitpy/thirdparty/__init__.py:
1363         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1364         * gtk/install-dependencies:
1365
1366 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1367
1368         Optimize bot watcher's dashboard a little
1369         https://bugs.webkit.org/show_bug.cgi?id=160515
1370         rdar://problem/26096900
1371
1372         Reviewed by Lucas Forschler.
1373
1374         Made re-sorting after loading an iteration more efficient.
1375
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1377         (BuildbotIteration.prototype._updateWithData):
1378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1379         (BuildbotQueue.prototype.updateIterationPosition):
1380
1381 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1382
1383         [Win] Unable to reliably run tests in parallel
1384         https://bugs.webkit.org/show_bug.cgi?id=140914
1385
1386         Reviewed by Brent Fulgham.
1387
1388         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1389         processes. We can use string replacement to convert the Cygwin path to a Windows path
1390         instead.
1391  
1392         * Scripts/webkitpy/common/system/path.py:
1393         (cygpathFast):
1394         * Scripts/webkitpy/port/driver.py:
1395         (Driver._command_from_driver_input):
1396
1397 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1398
1399         Document instructions for increasing process and file limits
1400         https://bugs.webkit.org/show_bug.cgi?id=160528
1401         rdar://problem/24777576
1402
1403         Reviewed by Alexey Proskuryakov.
1404
1405         * Scripts/webkitpy/port/ios.py:
1406         (IOSSimulatorPort.default_child_processes):
1407
1408 2016-08-03  Anders Carlsson  <andersca@apple.com>
1409
1410         Remove the Objective-C bindings generator
1411         https://bugs.webkit.org/show_bug.cgi?id=160526
1412
1413         Reviewed by Sam Weinig.
1414
1415         * Scripts/run-bindings-tests:
1416         Update test.
1417
1418 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1419
1420         Revise a TestWebKitAPI comment to mention the actual underlying problem
1421
1422         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1423         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1424
1425 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1426
1427         Benchmark test content-animation timeouts always
1428         https://bugs.webkit.org/show_bug.cgi?id=160057
1429
1430         Reviewed by Simon Fraser.
1431
1432         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1433         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1434         (start):
1435
1436 2016-08-02  Nan Wang  <n_wang@apple.com>
1437
1438         AX: Simulated touch events are not working on iOS
1439         https://bugs.webkit.org/show_bug.cgi?id=160395
1440         <rdar://problem/27633597>
1441
1442         Reviewed by Chris Fleizach.
1443
1444         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1445         (WTR::AccessibilityUIElement::press):
1446         (WTR::AccessibilityUIElement::setSelectedChild):
1447
1448 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1449
1450         run-javascriptcore-tests should accept multiple --extra-tests
1451         https://bugs.webkit.org/show_bug.cgi?id=160486
1452
1453         Reviewed by Saam Barati.
1454         
1455         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1456         test suites. This does it by using GetOpt::Long's array support.
1457
1458         * Scripts/run-javascriptcore-tests:
1459         (runJSCStressTests):
1460
1461 2016-08-02  Enrica Casucci  <enrica@apple.com>
1462
1463         Allow building with content filtering disabled.
1464         https://bugs.webkit.org/show_bug.cgi?id=160454
1465
1466         Reviewed by Simon Fraser.
1467
1468         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1469
1470 2016-08-02  Brady Eidson  <beidson@apple.com>
1471
1472         Removing IndexedDB WebsiteData can fail for some users.
1473         https://bugs.webkit.org/show_bug.cgi?id=160463
1474
1475         Reviewed by Alex Christensen.
1476
1477         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1478
1479 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1480
1481         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1482         https://bugs.webkit.org/show_bug.cgi?id=160437
1483         <rdar://problem/27578272>
1484
1485         Reviewed by Brady Eidson.
1486
1487         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1488         (-[DownloadDelegate _download:didReceiveResponse:]):
1489         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1490         (runTest):
1491         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1492
1493 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1494
1495         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1496         https://bugs.webkit.org/show_bug.cgi?id=160414
1497
1498         Reviewed by Michael Catanzaro.
1499
1500         * Scripts/webkitpy/port/linux_get_crash_log.py:
1501         (GDBCrashLogGenerator._wait_for_corefile):
1502
1503 2016-08-01  Youenn Fablet  <youenn@apple.com>
1504
1505         Make wpt server generate its certificates in layout test results folder
1506         https://bugs.webkit.org/show_bug.cgi?id=160422
1507
1508         Reviewed by Chris Dumez.
1509
1510         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1511         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1512
1513 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1514
1515         Function Call on NULL Object
1516         https://bugs.webkit.org/show_bug.cgi?id=160325
1517
1518         Reviewed by Darin Adler.
1519
1520         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1521         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1522         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1523
1524 2016-08-01  Keith Miller  <keith_miller@apple.com>
1525
1526         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1527         https://bugs.webkit.org/show_bug.cgi?id=160372
1528
1529         Rubber stamped by Geoffrey Garen.
1530
1531         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1532         a new top level directory, JSTests. Having the tests in the Source directory
1533         was both confusing an inconvenient for people that just want to checkout the
1534         source code of WebKit. Since there is no other obvious place to put all the
1535         JavaScript tests a new top level directory seemed the most sensible.
1536
1537         * Scripts/import-test262-tests:
1538         * Scripts/run-javascriptcore-tests:
1539         * Scripts/update-javascriptcore-test-res:
1540
1541 2016-07-31  Nan Wang  <n_wang@apple.com>
1542
1543         AX: Add a check for touch event listener on iOS accessibility object
1544         https://bugs.webkit.org/show_bug.cgi?id=160388
1545
1546         Reviewed by Chris Fleizach.
1547
1548         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1549         (AccessibilityUIElement::boolAttributeValue):
1550         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1551         (WTR::AccessibilityUIElement::boolAttributeValue):
1552
1553 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1554
1555         Unreviewed: add myself to the reviewers list.
1556
1557         * Scripts/webkitpy/common/config/contributors.json:
1558
1559 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1560
1561         Undo r203939, and copy over a rule that clips the logos.
1562
1563         Sierra wasn't the only logo without transparency.
1564
1565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1568
1569 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1570
1571         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1572         https://bugs.webkit.org/show_bug.cgi?id=160377
1573
1574         Reviewed by Brian Weinstein.
1575
1576         Update assets to remove the white background and use a transparent background instead.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1580
1581 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1582
1583         Ignore most check-webkit-style checks for ANGLE project
1584         <https://webkit.org/b/160333>
1585
1586         Reviewed by Daniel Bates.
1587
1588         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1589         - No tabs.
1590         - No spaces at the end of lines.
1591         - No carriage returns (DOS line endings).
1592
1593 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1594
1595         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1596         https://bugs.webkit.org/show_bug.cgi?id=160360
1597         <rdar://problem/27179484>
1598
1599         Reviewed by Myles C. Maxfield.
1600
1601         Adds two tests verifying that videos may be considered main content as long as they
1602         are large enough and cover a majority of the mainframe's viewport.
1603
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1605         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1606         (TestWebKitAPI::TEST):
1607         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1608         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1609
1610 2016-07-29  Mark Lam  <mark.lam@apple.com>
1611
1612         Gardening: removed unused variable.
1613
1614         Not reviewed.
1615
1616         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1617         (TestWebKitAPI::TEST):
1618
1619 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1620
1621         Add TestWebKitAPI support for interacting with media controls
1622         https://bugs.webkit.org/show_bug.cgi?id=160342
1623         <rdar://problem/27610246>
1624
1625         Reviewed by Beth Dakin.
1626
1627         Adds support for testing interaction with some media controls, as well as a basic test
1628         verifying that media control teardown after interaction does not result in a crash.
1629
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1631         (-[WKWebView mouseDownAtPoint:]):
1632         (-[WKWebView performAfterLoading:]):
1633         (TestWebKitAPI::TEST):
1634
1635 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1636
1637         Crash Log Clobbering on Unbound Crashes
1638         https://bugs.webkit.org/show_bug.cgi?id=160198
1639         <rdar://problem/27472618>
1640
1641         Reviewed by Alexey Proskuryakov.
1642
1643         * Scripts/webkitpy/common/system/crashlogs.py:
1644         (CrashLogs): Fix header order.
1645         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1646         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1647
1648 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1649
1650         Update for contributors.json
1651         https://bugs.webkit.org/show_bug.cgi?id=160294
1652
1653         * Scripts/webkitpy/common/config/contributors.json:
1654
1655 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1656
1657         Remove deprecated SPI for video inline / fullscreen controls
1658         https://bugs.webkit.org/show_bug.cgi?id=160318
1659
1660         Reviewed by Tim Horton.
1661
1662         * DumpRenderTree/mac/DumpRenderTree.mm:
1663         (setDefaultsToConsistentValuesForTesting): Deleted.
1664         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1665         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1666         * WebKitTestRunner/TestController.cpp:
1667         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1668         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1669         (WTR::initializeWebViewConfiguration): Deleted.
1670
1671 2016-07-28  Daniel Bates  <dabates@apple.com>
1672
1673         [iOS] TestWebKitAPI bundle targets are not code signed
1674         https://bugs.webkit.org/show_bug.cgi?id=160328
1675         <rdar://problem/27409246>
1676
1677         Reviewed by Andy Estes.
1678
1679         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1680         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1681         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1682
1683         * TestWebKitAPI/Configurations/Base.xcconfig:
1684
1685 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1686
1687         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1688
1689         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1690         (animatedResizeWebView):
1691         (TEST):
1692         This test times out only when run in the WebKit Testing simulator environment,
1693         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1694
1695 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1696
1697         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1698         https://bugs.webkit.org/show_bug.cgi?id=160289
1699         <rdar://problem/27553464>
1700
1701         Reviewed by Simon Fraser.
1702
1703         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1705         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1706         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1707         (-[AnimatedResizeWebView _endAnimatedResize]):
1708         (animatedResizeWebView):
1709         (TEST):
1710         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1711         Add two tests that ensure that hidden-content and animated resizes
1712         don't cause unnecessary synchronous waits. Only the hidden-content
1713         one fails before my patch, but it seemed reasonable to add both anyway.
1714
1715 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1716
1717         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1718         <https://webkit.org/b/83342>
1719
1720         Reviewed by Ryosuke Niwa.
1721
1722         * Scripts/webkitpy/common/checkout/scm/git.py:
1723         (Git.revisions_changing_file): Remove code to raise an exception
1724         when the file doesn't exist.  If a file was moved or renamed,
1725         then this caused the script to terminate, which was very
1726         frustrating when you wanted a list of reviewers.
1727         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1728         (SCMTest._shared_test_revisions_changing_file): Update test
1729         expectation to return an empty list of revisions.
1730         (test_create_patch_is_full_patch): Drive-by fix when running all
1731         webkitpy tests (including scm tests).
1732         * Scripts/webkitpy/common/checkout/scm/svn.py:
1733         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1734         return an empty array of revisions if this occurs.
1735
1736 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1737
1738         EWS error message "Error: * did not process patch" should include explanation
1739         https://bugs.webkit.org/show_bug.cgi?id=159903
1740         <rdar://problem/27410788>
1741
1742         Reviewed by Alexey Proskuryakov.
1743
1744         * QueueStatusServer/handlers/statusbubble.py:
1745         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1746         is not processed.
1747         * QueueStatusServer/handlers/processingtimesjson.py:
1748         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1749         of the code.
1750         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1751         (CommitQueueTask.validate): Add more information about validation failure.
1752         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1753         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1754         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1755         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1756         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1757         (PatchIsNotValid.__init__): Add the failure_message argument.
1758         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1759         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1760         failure details.
1761         * Scripts/webkitpy/tool/commands/queues.py:
1762         (CommitQueue.process_work_item): Same.
1763         (StyleQueue.review_patch): Same.
1764         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1765         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1766
1767 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1768
1769         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1770         https://bugs.webkit.org/show_bug.cgi?id=160262
1771
1772         Reviewed by Daniel Bates.
1773
1774         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1775         (-[LTRelayController installApp]):
1776
1777 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1778
1779         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1780         https://bugs.webkit.org/show_bug.cgi?id=160225
1781
1782         Reviewed by Alexey Proskuryakov.
1783
1784         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1785
1786 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1787
1788         [GTK] Fix some video/canvas tests that should be passing
1789         https://bugs.webkit.org/show_bug.cgi?id=160023
1790
1791         Reviewed by Carlos Garcia Campos.
1792
1793         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1794         EFL or GTK platforms.
1795
1796         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1797         (WTR::TestController::platformConfigureViewForTest):
1798         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1799         (WTR::TestController::platformConfigureViewForTest):
1800
1801 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1802
1803         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1804         https://bugs.webkit.org/show_bug.cgi?id=160247
1805
1806         Reviewed by Michael Catanzaro.
1807
1808         * BuildSlaveSupport/built-product-archive:
1809         (createZip):
1810         (dirContainsdwo):
1811         (archiveBuiltProduct):
1812
1813 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1814
1815         Fix tests after r203743.
1816         https://bugs.webkit.org/show_bug.cgi?id=156947
1817
1818         * WebKitTestRunner/TestController.cpp:
1819         (WTR::TestController::resetStateToConsistentValues):
1820         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1821
1822 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1823
1824         [iPhone] Playing a video on tudou.com plays only sound, no video
1825         https://bugs.webkit.org/show_bug.cgi?id=160178
1826         <rdar://problem/27535468>
1827
1828         Reviewed by Dan Bernstein.
1829
1830         * DumpRenderTree/mac/DumpRenderTree.mm:
1831         (setDefaultsToConsistentValuesForTesting):
1832         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1833         (RequiresUserActionForPlaybackTest::SetUp):
1834         * WebKitTestRunner/TestController.cpp:
1835         (WTR::TestController::resetPreferencesToConsistentValues):
1836         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1837         (WTR::initializeWebViewConfiguration):
1838
1839 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1840
1841         Allow LOG macros to be used outside the namespace, and other logging cleanup
1842         https://bugs.webkit.org/show_bug.cgi?id=160216
1843
1844         Reviewed by Anders Carlsson.
1845         
1846         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1847
1848         * DumpRenderTree/TestRunner.cpp:
1849         * DumpRenderTree/mac/DumpRenderTree.mm:
1850         (resetWebViewToConsistentStateBeforeTesting):
1851
1852 2016-07-26  David Kilzer <ddkilzer@apple.com>
1853
1854         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1855         https://bugs.webkit.org/show_bug.cgi?id=156947
1856         <rdar://problem/23325160>
1857
1858         Reviewed by Alex Christensen.
1859
1860         * DumpRenderTree/TestRunner.cpp:
1861         (TestRunner::TestRunner):
1862         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1863         * DumpRenderTree/TestRunner.h:
1864         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1865         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1866         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1867         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1868         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1869         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1870         (WTR::TestRunner::queueNonLoadingScript):
1871         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1872         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1873         * WebKitTestRunner/TestController.cpp:
1874         (WTR::TestController::didReceiveAuthenticationChallenge):
1875         * WebKitTestRunner/TestController.h:
1876         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1877         * WebKitTestRunner/TestInvocation.cpp:
1878         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1879         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1880
1881 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1882
1883         check-for-exit-time-destructors should be usable outside Xcode
1884         <https://webkit.org/b/160195>
1885
1886         Reviewed by Darin Adler.
1887
1888         * Scripts/check-for-exit-time-destructors: Update to parse
1889         -h|--help switch, or to take one argument to a binary to check
1890         for exit time destructors on the command-line.  The clang
1891         compiler will find these at compile-time with the
1892         -Wexit-time-destructors switch, but this script will check for
1893         them after-the-fact.
1894
1895 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1896
1897         Test svn.webkit.org functionality after maintenance.
1898
1899 2016-07-25  Brady Eidson  <beidson@apple.com>
1900
1901         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1902         https://bugs.webkit.org/show_bug.cgi?id=153783
1903
1904         Reviewed by Alex Christensen.
1905
1906         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1907         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1908         
1909         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1910         
1911         Change the relevant API tests to make sure this continues to be no longer required.
1912
1913         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1914         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1915         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1916         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1917         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1918         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1919
1920 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1921
1922         Media controls should not be displayed for a video until it starts playing
1923         https://bugs.webkit.org/show_bug.cgi?id=160092
1924         <rdar://problem/26986673>
1925
1926         Reviewed by Beth Dakin.
1927
1928         Verify that multiple videos do or don't show the media controller depending on whether videos
1929         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1930         passing because we were always showing media controls for large videos with audio, even if they
1931         had not played back yet. This change ensures that large videos with audio show media controls
1932         only after they begin to play back, and not by virtue of being large enough for main content.
1933
1934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1935         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1936         (TestWebKitAPI::TEST):
1937         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1938         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1939         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1940
1941 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1942
1943         Media controls on apple.com don't disappear when movie finishes playing
1944         https://bugs.webkit.org/show_bug.cgi?id=160068
1945         <rdar://problem/26668526>
1946
1947         Reviewed by Darin Adler.
1948
1949         Adds new API tests. Please see WebCore ChangeLog for more details.
1950
1951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1952         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1953         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1954         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1955         (TestWebKitAPI::TEST):
1956         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1957         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1958         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1959         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1960         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1961
1962 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1963
1964         Unreviewed, fix test-webkitpy after r203674.
1965
1966         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1967         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1968
1969 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1970
1971         Unreviewed, forgot to commit this file in r203674.
1972
1973         * Scripts/process-linux-coredump: Added.
1974         (main):
1975
1976 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1977
1978         Improve GDB backtrace generation for GTK/EFL
1979         https://bugs.webkit.org/show_bug.cgi?id=128928
1980
1981         Reviewed by Carlos Garcia Campos.
1982
1983         The PID of the crashed process is now correctly supplied to the
1984         crash log reporter. The kernel core_pattern needs to be updated
1985         after this change to something like:
1986
1987         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1988
1989         * Scripts/process-linux-coredump: Added.
1990         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1991         * Scripts/webkitpy/port/efl.py:
1992         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1993         * Scripts/webkitpy/port/gtk.py:
1994         (GtkPort._get_crash_log): Ditto.
1995         * Scripts/webkitpy/port/linux_get_crash_log.py:
1996         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1997         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1998         (GDBCrashLogGenerator): Deleted.
1999         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2000         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2001         * WebKitTestRunner/TestController.cpp:
2002         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2003         (WTR::TestController::databaseProcessDidCrash): Ditto.
2004         (WTR::TestController::processDidCrash): Ditto.
2005
2006 2016-07-23  Youenn Fablet  <youenn@apple.com>
2007
2008         WPT stash server should be kept running when launching wpt server
2009         https://bugs.webkit.org/show_bug.cgi?id=160052
2010
2011         Reviewed by Sam Weinig.
2012
2013         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2014         (main): waiting to read stdin while stash server is started.
2015
2016 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2017
2018         Media controls should be displayed for media in media documents
2019         https://bugs.webkit.org/show_bug.cgi?id=160104
2020         <rdar://problem/27438936>
2021
2022         Reviewed by Myles C. Maxfield.
2023
2024         Verifies that even a small video with audio in a media document gets media controls.
2025
2026         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2027         (TestWebKitAPI::TEST):
2028
2029 2016-07-22  Michael Saboff  <msaboff@apple.com>
2030
2031         REGRESSION(203616): no FTL testing was inadvertently removed
2032         https://bugs.webkit.org/show_bug.cgi?id=160100
2033
2034         Rubber-stamped by Filip Pizlo.
2035
2036         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2037         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2038         logic for the runLayout and runNoisy variants to match the run test logic,
2039         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2040         enabled platforms.
2041
2042         * Scripts/run-jsc-stress-tests:
2043
2044 2016-07-22  Brady Eidson  <beidson@apple.com>
2045
2046         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2047         https://bugs.webkit.org/show_bug.cgi?id=160089
2048
2049         Reviewed by Darin Adler.
2050
2051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2052         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2053         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2054
2055 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2056
2057         [GTK] Improved exclusion patterns in make-dist.py manifest.
2058         https://bugs.webkit.org/show_bug.cgi?id=160094
2059
2060         Reviewed by Michael Catanzaro.
2061
2062         * gtk/manifest.txt.in:
2063         Exclude Platform*.cmake files for more ports.
2064         Removed obsolete .gyp and .pro.user patterns.
2065         Exclude 'Configurations' and 'spi' directories.
2066         Exclude CMakeLists.txt.user (Qt Creator IDE).
2067
2068 2016-07-22  Michael Saboff  <msaboff@apple.com>
2069
2070         Don't run FTL related JSC stress tests on non-FTL platforms
2071         https://bugs.webkit.org/show_bug.cgi?id=160033
2072
2073         Reviewed by Mark Lam.
2074
2075         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2076         Refactored several of the runXXX test methods to always runXXXDefault and made those
2077         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2078         doesn't cause a problem.
2079
2080         * Scripts/run-jsc-stress-tests:
2081
2082 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2083
2084         IWebView::mainFrame crashes if called after IWebView::close
2085         https://bugs.webkit.org/show_bug.cgi?id=32868
2086
2087         Reviewed by Brent Fulgham.
2088
2089         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2090         (TestWebKitAPI::TEST_F): Added test.
2091
2092 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2093
2094         [GTK] Enable threaded compositor by default
2095         https://bugs.webkit.org/show_bug.cgi?id=160079
2096
2097         Reviewed by Žan Doberšek.
2098
2099         * Scripts/webkitperl/FeatureList.pm:
2100
2101 2016-07-22  Youenn Fablet  <youenn@apple.com>
2102
2103         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2104         https://bugs.webkit.org/show_bug.cgi?id=159921
2105
2106         Reviewed by Brian Burg.
2107
2108         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2109
2110         * Scripts/webkitpy/codegen/main.py:
2111         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2112         (BuiltinsGeneratorTests):
2113         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2114         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2115         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2116         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2117
2118 2016-07-21  Dan Bernstein  <mitz@apple.com>
2119
2120         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2121         https://bugs.webkit.org/show_bug.cgi?id=160072
2122
2123         Reviewed by Andy Estes.
2124
2125         * Scripts/webkitdirs.pm:
2126         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2127           for old Xcode versions.
2128         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2129           to readXcodeUserDefault.
2130         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2131           debugger.
2132         (determineDebugger): Ditto.
2133         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2134           7.0.
2135         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2136           switches.
2137         (execMacWebKitAppForDebugging): Removed support for GDB.
2138
2139 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2140
2141         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2142         https://bugs.webkit.org/show_bug.cgi?id=160066
2143
2144         Reviewed by Dean Jackson.
2145
2146         * DumpRenderTree/mac/DumpRenderTree.mm:
2147         (setDefaultsToConsistentValuesForTesting): Deleted.
2148         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2149         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2150         * WebKitTestRunner/TestController.cpp:
2151         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2153         (WTR::initializeWebViewConfiguration): Deleted.
2154
2155 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2156
2157         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2158         https://bugs.webkit.org/show_bug.cgi?id=159980
2159         rdar://problem/27450825
2160
2161         Reviewed by Dan Bernstein.
2162
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2165         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2166         when our delegate has hit -dealloc.
2167         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2168         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2169         will not be messaged.
2170
2171 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2172
2173         Follow-up patch to r203520
2174         https://bugs.webkit.org/show_bug.cgi?id=159967
2175         <rdar://problem/26964090>
2176
2177         Unreviewed.
2178
2179         * DumpRenderTree/mac/DumpRenderTree.mm:
2180         (setDefaultsToConsistentValuesForTesting):
2181         * WebKitTestRunner/TestController.cpp:
2182         (WTR::TestController::resetPreferencesToConsistentValues):
2183
2184 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2185
2186         [iPhone] Playing a video on tudou.com plays only sound, no video
2187         https://bugs.webkit.org/show_bug.cgi?id=159967
2188         <rdar://problem/26964090>
2189
2190         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2191
2192         Migrate tests to use new SPI.
2193
2194         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2195         (RequiresUserActionForPlaybackTest::SetUp):
2196         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2197         (WTR::initializeWebViewConfiguration):
2198
2199 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2200
2201         Clarify testing mode names in run-jsc-stress-tests
2202         https://bugs.webkit.org/show_bug.cgi?id=160021
2203
2204         Reviewed by Mark Lam.
2205
2206         Default should mean really default, not default with disabled FTL, renamed
2207         - runMozillaTestDefault to runMozillaTestNoFTL
2208         - runMozillaTestDefaultFTL to runMozillaTestDefault
2209         - runDefault to runNoFTL
2210         - runDefaultFTL to runDefault
2211         - runLayoutTestDefault to runLayoutTestNoFTL
2212         - runLayoutTestDefaultFTL to runLayoutTestDefault
2213         - runNoisyTestDefault to runNoisyTestNoFTL
2214         - runNoisyTestDefaultFTL to runNoisyTestDefault
2215
2216         * Scripts/run-jsc-stress-tests:
2217
2218 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2219
2220         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2221         https://bugs.webkit.org/show_bug.cgi?id=159986
2222
2223         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2224         to 0.
2225
2226         Reviewed by Dan Bernstein.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2230         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2231         (TEST):
2232
2233 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2234
2235         [GTK] Web view background colors don't work in accelerated compositing mode
2236         https://bugs.webkit.org/show_bug.cgi?id=159455
2237
2238         Reviewed by Michael Catanzaro.
2239
2240         Set always RGBA visual to the view widget when setting a background color.
2241
2242         * MiniBrowser/gtk/BrowserWindow.c:
2243         (browser_window_set_background_color):
2244
2245 2016-07-20  Youenn Fablet  <youenn@apple.com>
2246
2247         Bots should run built-ins generator tests
2248         https://bugs.webkit.org/show_bug.cgi?id=159971
2249
2250         Reviewed by Alexey Proskuryakov.
2251
2252         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2253         (RunBuiltinsTests): New step to run built-in generator tests.
2254         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2255         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2257
2258 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2259
2260         Revert temporary fix r203417
2261         https://bugs.webkit.org/show_bug.cgi?id=160001
2262
2263         Reviewed by Alexey Proskuryakov.
2264
2265         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2266
2267 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2268
2269         REGRESSION(r148588): ews classes might get garbage collected
2270         https://bugs.webkit.org/show_bug.cgi?id=159990
2271
2272         Reviewed by Ryosuke Niwa.
2273
2274         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2275         in a variable so that they do not get garbage collected.
2276
2277 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2278
2279         Add API test for layout constraints after exit fullscreen
2280         https://bugs.webkit.org/show_bug.cgi?id=159900
2281
2282         Reviewed by Jon Lee.
2283
2284         Added Fullscreen.LaytoutConstraints API test. 
2285         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2286
2287         This test compares layout constraints on the web view before and after fullscreen to make sure 
2288         they are preserved.
2289
2290         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2291         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2292         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2293         (TestWebKitAPI::TEST):
2294
2295 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2296
2297         Disable two failing API tests.
2298
2299         Unreviewed test gardening.
2300
2301         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2302         (TestWebKitAPI::TEST):
2303
2304 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2305
2306         Unreviewed iOS build fix.
2307
2308         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2309
2310 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2311
2312         Media controls don't appear when pausing a small autoplaying video
2313         https://bugs.webkit.org/show_bug.cgi?id=159972
2314         <rdar://problem/27180657>
2315
2316         Reviewed by Beth Dakin.
2317
2318         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2319         for simulating basic user interaction in VideoControlsManager.
2320
2321         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2322         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2323         (-[WKWebView mouseDownAtPoint:]):
2324         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2325         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2326         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2327         (TestWebKitAPI::TEST):
2328         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2329
2330 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2331
2332         [Win] MathML fonts are not found.
2333         https://bugs.webkit.org/show_bug.cgi?id=159920
2334
2335         Reviewed by Alex Christensen.
2336
2337         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2338         for a specific registry key value.
2339
2340         * Scripts/webkitdirs.pm:
2341         (fontExists):
2342
2343 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2344
2345         Improve prepare-ChangeLog for @media blocks
2346         https://bugs.webkit.org/show_bug.cgi?id=159907
2347
2348         Reviewed by Timothy Hatcher.
2349
2350         * Scripts/prepare-ChangeLog:
2351         (get_selector_line_ranges_for_css):
2352         Get a range for @media blocks just like a selector.
2353             Start Line = line with '{'
2354             End line = line with '}'
2355             Name = "@media ..."
2356
2357         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2358         Improved error messages for unbalanced portions.
2359
2360         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2361         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2362         (.media-query::before):
2363         (@media only screen and (max-width: 980px)):
2364         (.media-query a):
2365         (@media (-webkit-min-device-pixel-ratio: 2)):
2366         (.both a):
2367         (.both b):
2368         (.media-query b):
2369         (.media-query::after):
2370
2371 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2372
2373         Fix expectedFailErrorHandler in run-jsc-stress-tests
2374         https://bugs.webkit.org/show_bug.cgi?id=159811
2375
2376         Reviewed by Yusuke Suzuki.
2377
2378         * Scripts/run-jsc-stress-tests:
2379
2380 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2381
2382         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2383
2384         * TestWebKitAPI/PlatformMac.cmake:
2385
2386 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2387
2388         The default testing mode should not involve disabling the FTL JIT
2389         https://bugs.webkit.org/show_bug.cgi?id=159929
2390
2391         Rubber stamped by Mark Lam and Saam Barati.
2392         
2393         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2394         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2395         FTL was not the default. You had to enable it with an option.
2396         
2397         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2398         all of the major ports. This has become a serious pain. For example, it's useful to be able
2399         to say that a test should only run in the default config that is representative of what a
2400         normal user would see if they ran JSC. Clearly, this would be a config that does not
2401         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2402         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2403         
2404         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2405         try to fix it, because:
2406         
2407         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2408           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2409           doesn't do anything. The code is not really structured to allow this.
2410         
2411         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2412           disabled in testing. On the other hand there are already build bots that do FTL tests
2413           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2414           preserving this broken feature, we should create something that (a) acknowledges the fact
2415           that the FTL is the default on those platforms that support it and (b) avoids running
2416           no-ftl tests on precisely those platforms that don't have FTL.
2417         
2418         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2419           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2420           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2421           pretending that the FTL JIT is not the default just because some bots used that as an
2422           optimization.
2423         
2424         This change allows me to speed up some debug tests and paint some bots green.
2425
2426         * Scripts/run-javascriptcore-tests:
2427         (runJSCStressTests):
2428         * Scripts/run-jsc-stress-tests:
2429
2430 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2431
2432         Fix API test after r203426.
2433         https://bugs.webkit.org/show_bug.cgi?id=159949
2434
2435         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2436         (TEST):
2437         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2438         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2439
2440 2016-07-19  Andy Estes  <aestes@apple.com>
2441
2442         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2443         https://bugs.webkit.org/show_bug.cgi?id=159956
2444
2445         Reviewed by Dan Bernstein.
2446
2447         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2448         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2449         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2450         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2451
2452 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2453
2454         Add regression test for r203392
2455         https://bugs.webkit.org/show_bug.cgi?id=159949
2456
2457         Reviewed by Brady Eidson.
2458
2459         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2460         (fileSize):
2461         (swizzledBundleIdentifierWebBookmarksD):
2462         (defaultApplicationCacheDirectory):
2463         (TEST):
2464         (swizzledBundleIdentifierMobileSafari): Deleted.
2465         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2466         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2467         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2468
2469 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2470
2471         Add regression test for r203392
2472         https://bugs.webkit.org/show_bug.cgi?id=159949
2473
2474         Reviewed by Brady Eidson.
2475
2476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2477         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2478         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2480         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2481         (TEST):
2482         (fileSize):
2483         (swizzledBundleIdentifierMobileSafari):
2484         (swizzledBundleIdentifierWebBookmarksD):
2485         (defaultApplicationCacheDirectory):
2486         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2487         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2488         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2489         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2490
2491 2016-07-19  Keith Miller  <keith_miller@apple.com>
2492
2493         Test262 should have a file with the revision and url
2494         https://bugs.webkit.org/show_bug.cgi?id=159937
2495
2496         Reviewed by Mark Lam.
2497
2498         The import script should update the information from
2499         the path to the test262 repository it gets.
2500
2501         * Scripts/import-test262-tests:
2502
2503 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2504
2505         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2506         To be deleted once the root cause is found and addressed.
2507
2508         * EWSTools/start-queue-mac.sh:
2509
2510 2016-07-19  Frederic Wang  <fwang@igalia.com>
2511
2512         [win] Fixup the register name for STIX Math and Latin Modern Math
2513
2514         Unreviewed follow-up of r203406
2515
2516         * Scripts/webkitdirs.pm:
2517         (checkInstalledTools):
2518
2519 2016-07-19  Frederic Wang  <fwang@igalia.com>
2520
2521         [win] Update the list of MathML fonts
2522         https://bugs.webkit.org/show_bug.cgi?id=156838
2523
2524         The set of recommended math fonts is now described at
2525         https://trac.webkit.org/wiki/MathML/Fonts
2526         We update the Perl script to use the latest list of fonts.
2527
2528         Reviewed by Brent Fulgham.
2529
2530         * Scripts/webkitdirs.pm:
2531         (checkInstalledTools):
2532
2533 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2534
2535         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2536         https://bugs.webkit.org/show_bug.cgi?id=159342
2537
2538         Reviewed by Darin Adler.
2539
2540         Implement required functions in event sender.
2541
2542         * DumpRenderTree/PlatformWin.cmake:
2543         * DumpRenderTree/win/EventSender.cpp:
2544         (monitorWheelEvents): Added.
2545         (callAfterScrollingCompletes): Added.
2546
2547 2016-07-19  Youenn Fablet  <youenn@apple.com>
2548
2549         Add new aliases to http test server
2550         https://bugs.webkit.org/show_bug.cgi?id=159878
2551
2552         Reviewed by Darin Adler.
2553
2554         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2555         Adding explicitly these links to perl script.
2556         Extracting default alias in an aliases.json file.
2557         Reading that file from python scripts to initialize aliases from that file.
2558
2559         Python script changes covered by unit tests and changed layout test.
2560
2561         * Scripts/webkitperl/httpd.pm:
2562         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2563         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2564         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2565         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2566         Adding -c directives for each alias.
2567         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2568         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2569         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2570         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2571         Adding alias directive for each alias.
2572         (Lighttpd._prepare_config):
2573         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2574         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2575         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2576         layout tests directory.
2577         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2578         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2579         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2580
2581 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2582
2583         EWS console logs doesn't go to log file
2584         https://bugs.webkit.org/show_bug.cgi?id=159539
2585         <rdar://problem/24464570>
2586
2587         Reviewed by David Kilzer.
2588
2589         * Scripts/webkitpy/common/system/logutils.py:
2590         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2591         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2592         to filesystem. It also supports passing MockFilesystem.
2593         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2594         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2595         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2596         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2597         (_test_ews): Same.
2598         * Scripts/webkitpy/tool/commands/queues.py:
2599         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2600         (AbstractQueue._log_directory): Using filesystem object instead of os.
2601         (AbstractQueue.queue_log_path): Same.
2602         (AbstractQueue.__init__): Passed host parameter.
2603         (PatchProcessingQueue.__init__): Same.
2604         (CommitQueue.__init__): Same.
2605         (AbstractReviewQueue.__init__): Same.
2606         (StyleQueue.__init__): Same.
2607         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2608         (TestCommitQueue): Passed MockHost() as host.
2609         (TestCommitQueue.__init__): Same.
2610         (TestQueue.__init__): Same.
2611         (TestReviewQueue.__init__): Same.
2612         (TestFeederQueue.__init__): Same.
2613         (AbstractPatchQueueTest.test_next_patch): Same.
2614         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2615         (test_commit_queue_failure): Same.
2616         (MockCommitQueueTask.results_from_patch_test_run): Same.
2617         (test_rollout_lands): Same.
2618         (test_non_valid_patch): Same.
2619         (test_auto_retry): Same.
2620         (test_style_queue_with_watch_list_exception): Same.
2621
2622 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2623
2624         WTF::Lock should be fair eventually
2625         https://bugs.webkit.org/show_bug.cgi?id=159384
2626
2627         Reviewed by Geoffrey Garen.
2628
2629         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2630
2631 2016-07-17  Sam Weinig  <sam@webkit.org>
2632
2633         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2634         <rdar://problem/26554137>
2635         https://bugs.webkit.org/show_bug.cgi?id=159856
2636
2637         Reviewed by Dan Bernstein.
2638
2639         * MiniBrowser/mac/WK2BrowserWindowController.m:
2640         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2641         Add basic window.open implementation.
2642
2643         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2644         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2645         to open a single non-web URL, all others are dropped.
2646
2647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2648         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2649         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2650         Add API for the new SPI.
2651
2652 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2653
2654         [JSC] Enable test262 module tests
2655         https://bugs.webkit.org/show_bug.cgi?id=159854
2656
2657         Reviewed by Saam Barati.
2658
2659         Use --module-file instead.
2660
2661         * Scripts/run-jsc-stress-tests:
2662
2663 2016-07-16  Chris Dumez  <cdumez@apple.com>
2664
2665         Unreviewed, rolling out r203318.
2666
2667         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2668         SunSpider)
2669
2670         Reverted changeset:
2671
2672         "[JSC] Change some parameters based on a random search"
2673         https://bugs.webkit.org/show_bug.cgi?id=158514
2674         http://trac.webkit.org/changeset/203318
2675
2676 2016-07-16  Chris Dumez  <cdumez@apple.com>
2677
2678         Add move constructor / assignment operator to ListHashSet
2679         https://bugs.webkit.org/show_bug.cgi?id=159837
2680
2681         Reviewed by Darin Adler.
2682
2683         Add API tests.
2684
2685         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2686         (TestWebKitAPI::TEST):
2687
2688 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2689
2690         [JSC] Change some parameters based on a random search
2691         https://bugs.webkit.org/show_bug.cgi?id=158514
2692
2693         Reviewed by Saam Barati.
2694
2695         * Scripts/run-jsc-stress-tests:
2696
2697 2016-07-15  Jon Davis  <jond@apple.com>
2698
2699         Changed the start page URL for WebKit Nightly builds.
2700         https://bugs.webkit.org/show_bug.cgi?id=159816
2701
2702         Reviewed by Timothy Hatcher.
2703
2704         * WebKitLauncher/start.html:
2705
2706 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2707
2708         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2709         https://bugs.webkit.org/show_bug.cgi?id=159414
2710
2711         Reviewed by Brent Fulgham.
2712
2713         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2714         when the HDC parameter is invalid.
2715
2716         * TestWebKitAPI/PlatformWin.cmake:
2717         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2718         (TestWebKitAPI::TEST):
2719
2720 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2721
2722         [GTK] Add basic tabs support to MiniBrowser
2723         https://bugs.webkit.org/show_bug.cgi?id=159803
2724
2725         Reviewed by Sergio Villar Senin.
2726
2727         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2728         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2729
2730         * MiniBrowser/gtk/BrowserTab.c: Added.
2731         (titleChanged):
2732         (isLoadingChanged):
2733         (decidePolicy):
2734         (removeChildIfInfoBar):
2735         (loadChanged):
2736         (createInfoBarQuestionMessage):
2737         (tlsErrorsDialogResponse):
2738         (loadFailedWithTLSerrors):
2739         (permissionRequestDialogResponse):
2740         (decidePermissionRequest):
2741         (colorChooserRGBAChanged):
2742         (popoverColorClosed):
2743         (colorChooserRequestFinished):
2744         (runColorChooserCallback):
2745         (inspectorOpenedInWindow):
2746         (inspectorClosed):
2747         (browserTabSetProperty):
2748         (browserTabFinalize):
2749         (browser_tab_init):
2750         (browserTabConstructed):
2751         (browser_tab_class_init):
2752         (getInternalURI):
2753         (browser_tab_new):
2754         (browser_tab_get_web_view):
2755         (browser_tab_load_uri):
2756         (browser_tab_get_title_widget):
2757         (browser_tab_set_status_text):
2758         (browser_tab_toggle_inspector):
2759         (browser_tab_start_search):
2760         (browser_tab_stop_search):
2761         (browser_tab_add_accelerators):
2762         (fullScreenMessageTimeoutCallback):
2763         (browser_tab_enter_fullscreen):
2764         (browser_tab_leave_fullscreen):
2765         * MiniBrowser/gtk/BrowserTab.h: Added.
2766         * MiniBrowser/gtk/BrowserWindow.c:
2767         (getExternalURI):
2768         (browserWindowSetStatusText):
2769         (reloadOrStopCallback):
2770         (goBackCallback):
2771         (goForwardCallback):
2772         (settingsCallback):
2773         (webViewURIChanged):
2774         (browserWindowHistoryItemActivated):
2775         (browserWindowUpdateNavigationActions):
2776         (webViewCreate):
2777         (webViewEnterFullScreen):
2778         (webViewLeaveFullScreen):
2779         (webViewDecidePolicy):
2780         (browserWindowCanZoomIn):
2781         (browserWindowCanZoomOut):
2782         (browserWindowZoomIn):
2783         (browserWindowZoomOut):
2784         (scrollEventCallback):
2785         (faviconChanged):
2786         (webViewIsLoadingChanged):
2787         (defaultZoomCallback):
2788         (searchCallback):
2789         (newTabCallback):
2790         (toggleWebInspector):
2791         (reloadPage):
2792         (reloadPageIgnoringCache):
2793         (stopPageLoad):
2794         (loadHomePage):
2795         (editingCommandCallback):
2796         (insertImageCommandCallback):
2797         (insertLinkCommandCallback):
2798         (browserWindowSetupEditorToolbar):
2799         (browserWindowSwitchTab):
2800         (browserWindowTabAddedOrRemoved):
2801         (browser_window_init):
2802         (browserWindowConstructed):
2803         (browserWindowSaveSession):
2804         (browserWindowDeleteEvent):
2805         (browser_window_new):
2806         (browser_window_append_view):
2807         (browser_window_load_uri):
2808         (browser_window_load_session):
2809         (browser_window_set_background_color):
2810         (resetStatusText): Deleted.
2811         (activateUriEntryCallback): Deleted.
2812         (webViewTitleChanged): Deleted.
2813         (resetEntryProgress): Deleted.
2814         (browserWindowCreateBackForwardMenu): Deleted.
2815         (webViewReadyToShow): Deleted.
2816         (webViewLoadFailed): Deleted.
2817         (webViewMouseTargetChanged): Deleted.
2818         (browserWindowUpdateZoomActions): Deleted.
2819         (webViewZoomLevelChanged): Deleted.
2820         (updateUriEntryIcon): Deleted.
2821         (zoomInCallback): Deleted.
2822         (zoomOutCallback): Deleted.
2823         (toggleFullScreen): Deleted.
2824         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2825         (browserWindowFinalize): Deleted.
2826         (browser_window_class_init): Deleted.
2827         * MiniBrowser/gtk/BrowserWindow.h:
2828         * MiniBrowser/gtk/CMakeLists.txt:
2829         * MiniBrowser/gtk/main.c:
2830         (createBrowserTab):
2831         (aboutURISchemeRequestCallback):
2832         (main):
2833         (parseBackgroundColor): Deleted.
2834
2835 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2836
2837         Allow RefPtrs of const RefCounted types
2838         https://bugs.webkit.org/show_bug.cgi?id=158269
2839
2840         Reviewed by Anders Carlsson.
2841
2842         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2843         (TestWebKitAPI::TEST):
2844         (TestWebKitAPI::ConstRefCounted::create):
2845         (TestWebKitAPI::returnConstRefCountedRef):
2846         (TestWebKitAPI::returnRefCountedRef):
2847
2848 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2849
2850         Test WTF.StringViewIterators is crashing since r203119
2851         https://bugs.webkit.org/show_bug.cgi?id=159710
2852
2853         Reviewed by Darin Adler.
2854
2855         There are two problems in the test case added in r203119. First is that it's testing
2856         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2857         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2858         const reference to the string view member of the deleted CodePoints object.
2859
2860         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2861         (TestWebKitAPI::TEST):
2862
2863 2016-07-13  Daniel Bates  <dabates@apple.com>
2864
2865         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2866         https://bugs.webkit.org/show_bug.cgi?id=159738
2867         <rdar://problem/27304649>
2868
2869         Reviewed by Dan Bernstein.
2870
2871         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2872         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2873         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2874         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2875
2876         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2877         * WebKitTestRunner/ios/TestControllerIOS.mm:
2878         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2879         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2880
2881 2016-07-13  Beth Dakin  <bdakin@apple.com>
2882
2883         Attempted build fix.
2884
2885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2886
2887 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2888
2889         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2890         https://bugs.webkit.org/show_bug.cgi?id=159686
2891
2892         Reviewed by Chris Dumez.
2893
2894         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2895
2896         * WebKitTestRunner/TestController.cpp:
2897         (WTR::runOpenPanel):
2898         (WTR::TestController::createOtherPage):
2899         (WTR::TestController::createWebViewWithOptions):
2900
2901 2016-07-13  Beth Dakin  <bdakin@apple.com>
2902
2903         Add more candidate tests
2904         https://bugs.webkit.org/show_bug.cgi?id=159730
2905
2906         Reviewed by Tim Horton.
2907
2908         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2909         two new tests to that file.
2910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2911         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2912         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2913         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2914         (TestWebKitAPI::TEST):
2915         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2916
2917 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2918
2919         AX: [ATK] spinbutton-crash.html fails
2920         https://bugs.webkit.org/show_bug.cgi?id=159723
2921
2922         Reviewed by Chris Fleizach.
2923
2924         Implement support for AXDecrementButton and AXIncrementButton in
2925         ATK's AccessibilityUIElement::uiElementAttributeValue().
2926
2927         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2928         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2929
2930 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2931
2932         [EFL] [GTK] Enable back crypto subtle on development builds.
2933         https://bugs.webkit.org/show_bug.cgi?id=159260
2934
2935         Reviewed by Carlos Garcia Campos.
2936
2937         * Scripts/webkitperl/FeatureList.pm:
2938
2939 2016-07-12  Mark Lam  <mark.lam@apple.com>
2940
2941         We should use different stack limits for stack checks from JS and host code.
2942         https://bugs.webkit.org/show_bug.cgi?id=159442
2943         <rdar://problem/26889188>
2944
2945         Reviewed by Geoffrey Garen.
2946
2947         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2948         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2949         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2950         order to keep the js/regress-139548.html test happy with this patch.
2951
2952         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2953         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2954
2955         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2956         (-[LTRelayController _environmentVariables]):
2957         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2958         (main):
2959
2960 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2961
2962         platformUserPreferredLanguages on Mac should not try to put the region into the language
2963         https://bugs.webkit.org/show_bug.cgi?id=159693
2964
2965         Rubber stamped by Alexey Proskuryakov.
2966         
2967         Revert the test change in r200105.
2968
2969         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2970         (TestWebKitAPI::languageForSystemLanguage):
2971
2972 2016-07-12  Chris Dumez  <cdumez@apple.com>
2973
2974         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2975         https://bugs.webkit.org/show_bug.cgi?id=159663
2976         <rdar://problem/18995873>
2977
2978         Reviewed by Benjamin Poulain.
2979
2980         Add API test coverage.
2981
2982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2983         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2984         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2985         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2986         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2987         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2988         (TEST):
2989
2990 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2991
2992         Relax ordering requirements on StringView::CodePoints iterator
2993         https://bugs.webkit.org/show_bug.cgi?id=159609
2994
2995         Reviewed by Darin Adler.
2996
2997         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2998         (TestWebKitAPI::TEST):
2999
3000 2016-07-12  Youenn Fablet  <youenn@apple.com>
3001
3002         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3003         https://bugs.webkit.org/show_bug.cgi?id=159564
3004
3005         Reviewed by Brian Burg.
3006
3007         * Scripts/webkitpy/codegen/main.py:
3008         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3009
3010 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3011
3012         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3013         https://bugs.webkit.org/show_bug.cgi?id=159671
3014
3015         Reviewed by Csaba Osztrogonác.
3016
3017         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3018         https://bugs.webkit.org/show_bug.cgi?id=89235
3019
3020         So this guard can be removed in build scripts.
3021
3022         * Scripts/webkitperl/FeatureList.pm:
3023         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3024
3025 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3026
3027         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3028         https://bugs.webkit.org/show_bug.cgi?id=159652
3029
3030         Reviewed by Daniel Bates.
3031
3032         * Scripts/webkitpy/common/checkout/scm/svn.py:
3033         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3034
3035 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3036
3037         Implement grapheme cluster iterator on StringView
3038         https://bugs.webkit.org/show_bug.cgi?id=159598
3039
3040         Reviewed by Anders Carlsson.
3041
3042         This is in preparation for honoring the second argument to FontFaceSet.load().
3043
3044         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3045         (TestWebKitAPI::compareLoopIterations):
3046         (TestWebKitAPI::TEST):
3047
3048 2016-07-11  Nan Wang  <n_wang@apple.com>
3049
3050         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3051         https://bugs.webkit.org/show_bug.cgi?id=158364
3052
3053         Reviewed by Anders Carlsson.
3054
3055         Added a function in TestRunner so that we can toggle the ignoring viewport
3056         scale limits setting. Also added a test option for that in order to change the 
3057         configuration of the webview in test.
3058
3059         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3060         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3061         (WTR::TestRunner::setNavigationGesturesEnabled):
3062         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3063         (WTR::nextUIScriptCallbackID):
3064         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3065         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3066         * WebKitTestRunner/TestController.cpp:
3067         (WTR::TestController::resetStateToConsistentValues):
3068         (WTR::updateTestOptionsFromTestHeader):
3069         (WTR::TestController::setNavigationGesturesEnabled):
3070         (WTR::TestController::setIgnoresViewportScaleLimits):
3071         (WTR::TestController::platformWillRunTest):
3072         * WebKitTestRunner/TestController.h:
3073         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3074         * WebKitTestRunner/TestInvocation.cpp:
3075         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3076         * WebKitTestRunner/TestOptions.h:
3077         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3078         (WTR::TestController::platformCreateWebView):
3079
3080 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3081
3082         [GTK] install-dependencies should not install packages built by jhbuild.
3083         https://bugs.webkit.org/show_bug.cgi?id=159628
3084
3085         Reviewed by Michael Catanzaro.
3086
3087         * gtk/install-dependencies:
3088         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3089
3090 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3091
3092         System proxy settings not used when building deps with jhbuild
3093         https://bugs.webkit.org/show_bug.cgi?id=159567
3094
3095         Reviewed by Michael Catanzaro.
3096
3097         This adds the gsettings-desktop-schemas-devel build dep to enable
3098         the libgiognomeproxy.so gio module in glib-networking, which uses
3099         GSettings on org.gnome.system.proxy.
3100         This is needed to query system proxy settings for Gnome desktops.
3101
3102         dconf can be manually added to jhbuild to build the
3103         libdconfsettings.so gio module for GSettings, so that
3104         libgiognomeproxy.so can access system settings.
3105           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3106
3107         As an alternative to dconf settings, this commit also adds the
3108         libproxy-devel build dep to enable the libgiolibproxy.so module in
3109         glib-networking (suggested by Fujii Hironori).
3110
3111         It is useful to read proxy settings from environment variables.
3112         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3113         environment variable to force using the envvar module in libproxy.
3114
3115         * gtk/install-dependencies:
3116
3117 2016-07-11  Mark Lam  <mark.lam@apple.com>
3118
3119         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3120         https://bugs.webkit.org/show_bug.cgi?id=159524
3121
3122         Reviewed by Michael Saboff.
3123
3124         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3125         Also fixed up some tests to behave better to work with this new limit.  This
3126         should make stack overflow tests complete sooner.
3127
3128         * Scripts/run-jsc-stress-tests:
3129         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3130         (main):
3131
3132 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3133
3134         [GTK] Whitespace fixes in install-dependencies script
3135
3136         Unreviewed.
3137
3138         * gtk/install-dependencies:
3139
3140 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3141
3142         [GTK] Install missing Fedora dependencies
3143
3144         Unreviewed.
3145
3146         * gtk/install-dependencies:
3147
3148 2016-07-09  Dan Bernstein  <mitz@apple.com>
3149
3150         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3151         https://bugs.webkit.org/show_bug.cgi?id=159600
3152
3153         Reviewed by Daniel Bates.
3154
3155         * Scripts/git-add-reviewer:
3156         Added the -s|--rubber-stamp option.
3157         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3158           new option.
3159
3160 2016-07-08  Andy Estes  <aestes@apple.com>
3161
3162         [Content Filtering] Load blocked pages more like other error pages are loaded
3163         https://bugs.webkit.org/show_bug.cgi?id=159485
3164         <rdar://problem/26014076>
3165
3166         Reviewed by Brady Eidson.
3167
3168         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3169         to a content filtering provisional navigation failure is ignored in preference of
3170         ContentFilter's own error page.
3171
3172         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3174         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3175         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3176         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3177         (loadAlternateTest):
3178         (TEST):
3179         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3180         (-[MockContentFilterEnabler initWithCoder:]):
3181         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3182         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3183         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3184         (TestWebKitAPI::loadAlternateTest):
3185         (TestWebKitAPI::TEST):
3186
3187 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3188
3189         Unreviewed, rolling out r202944.
3190         https://bugs.webkit.org/show_bug.cgi?id=159570
3191
3192         caused some tests to crash under GuardMalloc (Requested by
3193         estes on #webkit).
3194
3195         Reverted changeset:
3196
3197         "[Content Filtering] Load blocked pages more like other error
3198         pages are loaded"
3199         https://bugs.webkit.org/show_bug.cgi?id=159485
3200         http://trac.webkit.org/changeset/202944
3201
3202 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3203
3204         Remove mrobinson from the MathML watchlist
3205         https://bugs.webkit.org/show_bug.cgi?id=159559
3206
3207         Reviewed by Philippe Normand.
3208
3209         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3210
3211 2016-07-08  Brady Eidson  <beidson@apple.com>
3212
3213         Clearing LocalStorage doesn't also delete -wal and -shm files.
3214         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3215
3216         Reviewed by Brent Fulgham.
3217         Also helpfully picked over by Andy "Never Forgets" Estes.
3218
3219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3220         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3221         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3222
3223 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3224
3225         Removed Qt leftovers from Tools.
3226         https://bugs.webkit.org/show_bug.cgi?id=159557
3227
3228         Reviewed by Csaba Osztrogonác.
3229
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3231         Removed 'qt' platform config.
3232         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3233         Deleted non-functional e-mail address.
3234
3235 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3236
3237         Unreviewed, rolling out r202967.
3238         https://bugs.webkit.org/show_bug.cgi?id=159556
3239
3240         This patch caused crashes in https tests on Windows (Requested
3241         by perarne on #webkit).
3242
3243         Reverted changeset:
3244
3245         "[Win] The test http/tests/security/contentSecurityPolicy
3246         /upgrade-insecure-requests/basic-upgrade.https.html is
3247         failing."
3248         https://bugs.webkit.org/show_bug.cgi?id=159510
3249         http://trac.webkit.org/changeset/202967
3250
3251 2016-07-08  Youenn Fablet  <youenn@apple.com>
3252
3253         Generate WebCore builtin wrapper files
3254         https://bugs.webkit.org/show_bug.cgi?id=159461
3255
3256         Reviewed by Brian Burg.
3257
3258         * Scripts/webkitpy/codegen/main.py:
3259         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3260         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3261
3262 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3263
3264         [EFL] Fix build when media-stream is enabled.
3265         https://bugs.webkit.org/show_bug.cgi?id=159206
3266
3267         Bump up the openwebrtc to find the correct package.
3268
3269         Reviewed by Gyuyoung Kim.
3270
3271         * efl/jhbuild.modules:
3272         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3273
3274 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3275
3276         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3277         https://bugs.webkit.org/show_bug.cgi?id=159510
3278
3279         Reviewed by Brent Fulgham.
3280
3281         Allow any https certificate when running tests.
3282
3283         * DumpRenderTree/win/DumpRenderTree.cpp:
3284         (runTest):
3285
3286 2016-07-07  Beth Dakin  <bdakin@apple.com>
3287
3288         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3289         https://bugs.webkit.org/show_bug.cgi?id=159532
3290         -and corresponding-
3291         rdar://problem/27177179
3292
3293         Reviewed by Tim Horton.
3294
3295         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3296         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3297
3298 2016-07-07  Andy Estes  <aestes@apple.com>
3299
3300         [Content Filtering] Load blocked pages more like other error pages are loaded
3301         https://bugs.webkit.org/show_bug.cgi?id=159485
3302         <rdar://problem/26014076>
3303
3304         Reviewed by Brady Eidson.
3305
3306         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3307         to a content filtering provisional navigation failure is ignored in preference of
3308         ContentFilter's own error page.
3309
3310         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3312         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3313         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3314         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3315         (loadAlternateTest):
3316         (TEST):
3317         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3318         (-[MockContentFilterEnabler initWithCoder:]):
3319         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3320         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3321         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3322         (TestWebKitAPI::loadAlternateTest):
3323         (TestWebKitAPI::TEST):
3324
3325 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3326
3327         Unreviewed: add myself to the reviewers list.
3328
3329         * Scripts/webkitpy/common/config/contributors.json:
3330
3331 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3332
3333         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3334         https://bugs.webkit.org/show_bug.cgi?id=159509
3335
3336         Reviewed by Alex Christensen.
3337
3338         We should always insert the url in the url map when identifierForInitialRequest
3339         is called. Otherwise we can end up with identifiers not having an entry in the
3340         url map when urls are written to the test output file. 
3341
3342         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3343         (ResourceLoadDelegate::identifierForInitialRequest):
3344
3345 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3346
3347         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3348         https://bugs.webkit.org/show_bug.cgi?id=159498
3349         <rdar://problem/26719903>
3350
3351         Reviewed by Sam Weinig.
3352
3353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3354         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3355         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3356         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3357         (expectLinkCount):
3358         (TEST):
3359         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3360         when deciding what to linkify.
3361
3362 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3363
3364         Build fix - work around rdar://problem/27196668.
3365
3366         * LayoutTestRelay/Configurations/Base.xcconfig:
3367
3368 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3369
3370         Enhance Windows DRT implementation to support platform scroll wheel events.
3371         https://bugs.webkit.org/show_bug.cgi?id=36002
3372
3373         Reviewed by Brent Fulgham.
3374
3375         Implement function continuousMouseScrollBy in Windows event sender.
3376
3377         * DumpRenderTree/win/EventSender.cpp:
3378         (mouseScrollBy):
3379         (continuousMouseScrollBy):
3380
3381 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3382
3383         [Sierra] Rebaseline tests to use un-mocked system font metrics
3384         https://bugs.webkit.org/show_bug.cgi?id=159311
3385         <rdar://problem/24138411>
3386
3387         Reviewed in person by Alexey Proskuryakov.
3388
3389         Stop mocking the system font on Sierra.
3390
3391         * DumpRenderTree/mac/DumpRenderTree.mm:
3392         (setDefaultsToConsistentValuesForTesting):
3393         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3394         (WTR::InjectedBundle::platformInitialize):
3395
3396 2016-07-05  Brady Eidson  <beidson@apple.com>
3397
3398         Database process crashes deleting a corrupt SQLite database file (null deref).
3399         https://bugs.webkit.org/show_bug.cgi?id=155506.
3400
3401         Reviewed by Alex Christensen.
3402
3403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3404         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3405         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3406         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3407         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3408         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3409
3410 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3411
3412         run-webkit-tests should print more complete baseline search paths
3413         https://bugs.webkit.org/show_bug.cgi?id=159354
3414
3415         Reviewed by Daniel Bates.
3416
3417         run-webkit-tests used to only print directory names in baseline search paths.
3418         This was ok in basic usage, but quickly got confusing when using
3419         --additional-platform-directory flags.
3420
3421         * Scripts/webkitpy/layout_tests/views/printing.py:
3422         (Printer.print_config):
3423         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3424         (Testprinter.test_print_config):
3425         (Testprinter.test_print_one_line_summary):
3426
3427 2016-07-04  Brady Eidson  <beidson@apple.com>
3428
3429         WebProcesses don't handle DatabaseProcess going away uncleanly..
3430         https://bugs.webkit.org/show_bug.cgi?id=159371
3431
3432         Reviewed by Alex Christensen.
3433
3434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3435         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3436         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3437         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3438         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3439
3440 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3441
3442         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3443         https://bugs.webkit.org/show_bug.cgi?id=158141
3444
3445         Rubber-stamped by Michael Catanzaro.
3446
3447         Instead of checking for an specific Ubuntu version, query the apt
3448         database to see which version of PHP is available.
3449
3450         * efl/install-dependencies:
3451         * gtk/install-dependencies:
3452
3453 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3454
3455         webkit-patch failure-reason always raises TypeError
3456         https://bugs.webkit.org/show_bug.cgi?id=159394
3457
3458         Reviewed by Benjamin Poulain.
3459
3460         In r170637 (Bug 133067), the first and second arguments of
3461         pluralize were swapped.
3462
3463         * Scripts/webkitpy/tool/commands/queries.py:
3464         (FailureReason._builder_to_explain): Swap the first and second
3465         arguments of pluralize.
3466
3467 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3468
3469         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3470         https://bugs.webkit.org/show_bug.cgi?id=152486
3471
3472         Reviewed by Daniel Bates.
3473
3474         Add launch of web-platform-tests server by run-webkit-httpd.
3475         Add two options to disable starting httpd and web-platform-tests servers.
3476
3477         * Scripts/run-webkit-httpd:
3478         (parse_args):
3479         (main):
3480
3481 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3482
3483         REGRESSION(r189668): Notification tests are flakey
3484         https://bugs.webkit.org/show_bug.cgi?id=159375
3485         <rdar://problem/22760990>
3486
3487         Reviewed by Alexey Proskuryakov.
3488
3489         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3490         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3491         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3492         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3493
3494         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3495         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3496         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3497         global notification ID mapping, causing the wrong notification to be investigated.
3498
3499         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3500         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3501         notification is created or destroyed. However, because this object is implemented outside WebKit,
3502         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3503         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3504         WebNotificationProvider can properly map between the different IDs.
3505
3506         * WebKitTestRunner/TestController.cpp:
3507         (WTR::TestController::runTestingServerLoop):
3508         (WTR::TestController::simulateWebNotificationClick):
3509         * WebKitTestRunner/WebNotificationProvider.cpp:
3510         (WTR::WebNotificationProvider::showWebNotification):
3511         (WTR::removeGlobalIDFromIDMap):
3512         (WTR::WebNotificationProvider::closeWebNotification):
3513         (WTR::WebNotificationProvider::removeNotificationManager):
3514         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3515         (WTR::WebNotificationProvider::reset):
3516         * WebKitTestRunner/WebNotificationProvider.h:
3517
3518 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3519
3520         Simplify LayoutTestRelay
3521         https://bugs.webkit.org/show_bug.cgi?id=159353
3522
3523         Reviewed by Daniel Bates.
3524
3525         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3526         by name and runtime makes no sense.
3527         2. Removed code to create devices, webkitpy always does this in advance.
3528         3. Don't create copies of testing apps - we can install the same one into
3529         each simulator, now that we don't run multiple tester processes in a single simulator.
3530         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3531         5. Removed code that kept testing apps alive in the background.
3532         6. Slightly updated coding style in functions that I touched.
3533
3534         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3535         Updated for what we acually use at this point.
3536
3537         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3538         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3539         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3540         (-[LTRelayController ipcIdentifier]):
3541         (-[LTRelayController processName]):
3542         (-[LTRelayController didReceiveStdoutData:]):
3543         (-[LTRelayController didCrashWithMessage:]):
3544         (-[LTRelayController installApp]):
3545         (-[LTRelayController _environmentVariables]):
3546         (-[LTRelayController launchApp]):
3547         (-[LTRelayController start]):
3548         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3549         (-[LTRelayController uniqueAppPath]): Deleted.
3550         (-[LTRelayController uniqueAppURL]): Deleted.
3551         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3552         (-[LTRelayController createUniqueApp]): Deleted.
3553         * LayoutTestRelay/LayoutTestRelay/main.m:
3554         (usage):
3555         (getRequiredStringArgument):
3556         (main):
3557         (getTestingSimDevice): Deleted.
3558         * Scripts/webkitpy/port/driver.py:
3559         (IOSSimulatorDriver.cmd_line):
3560         * WebKitTestRunner/ios/TestControllerIOS.mm:
3561         (WTR::TestController::platformInitialize):
3562         * WebKitTestRunner/ios/mainIOS.mm:
3563         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3564         * DumpRenderTree/mac/DumpRenderTree.mm:
3565         (dumpRenderTree):
3566         (-[DumpRenderTree applicationDidEnterBackground:]):
3567
3568 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3569
3570         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3571         https://bugs.webkit.org/show_bug.cgi?id=159344
3572
3573         Reviewed by Alex Christensen.
3574
3575         * DumpRenderTree/CMakeLists.txt:
3576
3577 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3578
3579         Add a runtime flag for DOM iterators
3580         https://bugs.webkit.org/show_bug.cgi?id=159300
3581
3582         Reviewed by Alex Christensen.
3583
3584         * DumpRenderTree/mac/DumpRenderTree.mm:
3585         (resetWebPreferencesToConsistentValues):
3586         * DumpRenderTree/win/DumpRenderTree.cpp:
3587         (resetWebPreferencesToConsistentValues):
3588         * Scripts/webkitperl/FeatureList.pm:
3589         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3590         (WTR::InjectedBundle::beginTesting):
3591         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3592         (WTR::TestRunner::setDOMIteratorEnabled):
3593         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3594
3595 2016-06-30  Tina Liu  <iting_liu@apple.com>
3596
3597         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3598         https://bugs.webkit.org/show_bug.cgi?id=159326
3599
3600         Reviewed by Brady Eidson.
3601
3602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3603         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3604         (TestWebKitAPI::didFinishLoadForFrame):
3605         (TestWebKitAPI::didChangeBackForwardListForPage):
3606         (TestWebKitAPI::setPageLoaderClient):
3607         Set the page loader client and register for didFinishLoadForFrame and
3608         didChangeBackForwardList callbacks.
3609         (TestWebKitAPI::createSessionStateData):
3610         Load a webpage ("simple.html") and return the session state for this page.
3611         (TestWebKitAPI::TEST):
3612         Restore the page session state with that of "simple.html" without navigation.
3613         Verify that the committed URL is NULL since there's no navigation involved.
3614         Verify that the current item in the back forward list, which should be what
3615         we restored from the session state, has the expected URL.
3616
3617 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3618
3619         Generators violate bytecode liveness validation
3620         https://bugs.webkit.org/show_bug.cgi?id=159279
3621
3622         Reviewed by Yusuke Suzuki.
3623         
3624         Add Basic to our test harness.
3625
3626         * Scripts/run-javascriptcore-tests:
3627         (runJSCStressTests):
3628
3629 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3630
3631         [Win][Debug] Assertion fails in TestWTF.
3632         https://bugs.webkit.org/show_bug.cgi?id=159299
3633
3634         Reviewed by Alex Christensen.
3635
3636         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3637         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3638         the assertion failure. Since the variable is actually used, there is no need to use the
3639         UNUSED_PARAM macro.
3640
3641         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3642         (TestWebKitAPI::TEST):
3643