Simplify sandbox enabling macros
[WebKit-https.git] / Tools / ChangeLog
1 2019-10-04  Alex Christensen  <achristensen@webkit.org>
2
3         Simplify sandbox enabling macros
4         https://bugs.webkit.org/show_bug.cgi?id=202536
5
6         Reviewed by Brent Fulgham.
7
8         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9
10 2019-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
11
12         [GTK][WPE] Print the revision number on command "--version" of the MiniBrowser
13         https://bugs.webkit.org/show_bug.cgi?id=202581
14
15         Reviewed by Carlos Garcia Campos.
16
17         When WebKit its build from source repository instead of a tarball
18         we can print the SVN revision to be more precise about the version
19         of WebKit when the option --version is passed to the MiniBrowser.
20
21         * MiniBrowser/gtk/main.c:
22         (main):
23         * MiniBrowser/wpe/main.cpp:
24         (main):
25
26 2019-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
27
28         Unreviewed. Fix GTK distcheck
29
30         * gtk/manifest.txt.in: Add Source/WebKit/Resources/gtk to the tarball.
31
32 2019-10-03  Per Arne Vollan  <pvollan@apple.com>
33
34         REGRESSION(249649): Unable to open local files in MiniBrowser on macOS
35         https://bugs.webkit.org/show_bug.cgi?id=201798
36
37         Reviewed by Brent Fulgham.
38
39         Added API test WKWebView.LoadFileWithLoadRequest.
40
41         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
42
43 2019-10-03  Jonathan Bedard  <jbedard@apple.com>
44
45         Add myself to various tools watchlists
46         https://bugs.webkit.org/show_bug.cgi?id=202532
47
48         Reviewed by Aakash Jain.
49
50         * Scripts/webkitpy/common/config/watchlist: Add myself to the watchlist of
51         PerformanceTests, SVNScripts, webkitperl and webkitpy.
52
53 2019-10-03  Jiewen Tan  <jiewen_tan@apple.com>
54
55         Support googleLegacyAppidSupport extension
56         https://bugs.webkit.org/show_bug.cgi?id=202427
57         <rdar://problem/55887473>
58
59         Reviewed by Brent Fulgham.
60
61         Adds an API test for googleLegacyAppidSupport extension.
62
63         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
64         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
65         (TestWebKitAPI::constructMakeCredentialRequest):
66         (TestWebKitAPI::constructMakeCredentialRequestWithGoogleLegacyAppidSupport):
67         (TestWebKitAPI::TEST):
68
69 2019-10-03  Thibault Saunier  <tsaunier@igalia.com>
70
71         REGRESSION(r249428): [GStreamer] VP9 video rendered green
72         https://bugs.webkit.org/show_bug.cgi?id=201422
73
74         Adding patches in -base to fix the issue.
75
76         Reviewed by Philippe Normand.
77
78         * gstreamer/jhbuild.modules:
79         * gstreamer/patches/base-0001-glupload-Add-VideoMetas-and-GLSyncMeta-to-the-raw-up.patch: Added.
80
81 2019-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
82
83         [GTK] Make PSON optional
84         https://bugs.webkit.org/show_bug.cgi?id=200967
85
86         Reviewed by Michael Catanzaro.
87
88         Enable PSON in MiniBrowser and unit tests. Also add more tests to page-id to check that we can still talk to the
89         right web process after cross-site history navigation.
90
91         * MiniBrowser/gtk/main.c:
92         (main):
93         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
94         (testWebExtensionPageID):
95         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
96         (Test::Test):
97
98 2019-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
99
100         [GTK][WPE] Add WebKitWebView:page-id property
101         https://bugs.webkit.org/show_bug.cgi?id=201642
102
103         Reviewed by Michael Catanzaro.
104
105         Add a test case to check the new property.
106
107         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
108         (checkTitle):
109         (testWebExtensionGetTitle):
110         (webViewPageIDChanged):
111         (testWebExtensionPageID):
112         (beforeAll):
113
114 2019-10-02  Jonathan Bedard  <jbedard@apple.com>
115
116         results.webkit.org: Only automatically search when multiple lines are pasted
117         https://bugs.webkit.org/show_bug.cgi?id=202496
118
119         Rubber-stamped by Aakash Jain.
120
121         * resultsdbpy/resultsdbpy/view/static/js/search.js:
122         (SearchBar): If only a single line has been pasted, do not automatically dispatch
123         the search.
124
125 2019-10-02  Jonathan Bedard  <jbedard@apple.com>
126
127         Python 3: Add test-webkitpy for Python 3 (Follow-up fix)
128         https://bugs.webkit.org/show_bug.cgi?id=201954
129
130         Unreviewed follow-up fix.
131
132         * Scripts/test-webkitpy-python3: Add copyright.
133
134 2019-10-02  Thibault Saunier  <tsaunier@igalia.com>
135
136         [GSTreamer] Let playbin handle redirects for us when appropriate
137         https://bugs.webkit.org/show_bug.cgi?id=195326
138
139         Added required patche in GStreamer
140
141         Reviewed by Xabier Rodriguez-Calvar.
142
143         * gstreamer/patches/base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
144         * gstreamer/patches/good-0001-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
145
146 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
147
148         [ews] Add API endpoint to retry failed builds for a patch
149         https://bugs.webkit.org/show_bug.cgi?id=202424
150
151         Reviewed by Jonathan Bedard.
152
153         * BuildSlaveSupport/ews-app/ews/urls.py: Added url mapping for /retry.
154         * BuildSlaveSupport/ews-app/ews/views/retrypatch.py: Added.
155         (RetryPatch.get): Display the web-form to retry the patch. Retry button which will be added soon will 
156         use this form.
157         (RetryPatch.post): Handle the post request and retry the patch.
158         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
159         (StatusBubble.find_failed_builds_for_patch): Method to find failed builds for a patch.
160         * BuildSlaveSupport/ews-app/ews/templates/retry.html: Added, similar to submittoews.html. This
161         allows to retry a patch through a web-form as well.
162
163 2019-10-02  Kate Cheney  <katherine_cheney@apple.com>
164
165         Updated resource load statistics are never merged into the SQLite Database backend (202372).
166         https://bugs.webkit.org/show_bug.cgi?id=202372
167         <rdar://problem/55854542>
168
169         Reviewed by Brent Fulgham. 
170
171         Added testing functionality to the mergeStatistics() function of the 
172         SQLite backend.
173
174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
176         (WTR::InjectedBundle::didReceiveMessageToPage):
177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
178         (WTR::TestRunner::setStatisticsMergeStatistic):
179         (WTR::TestRunner::statisticsCallDidSetMergeStatisticCallback):
180         * WebKitTestRunner/InjectedBundle/TestRunner.h:
181         * WebKitTestRunner/TestController.cpp:
182         (WTR::TestController::setStatisticsMergeStatistic):
183         * WebKitTestRunner/TestController.h:
184         * WebKitTestRunner/TestInvocation.cpp:
185         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
186         (WTR::TestInvocation::didMergeStatistic):
187         * WebKitTestRunner/TestInvocation.h:
188
189 2019-10-02  Aakash Jain  <aakash_jain@apple.com>
190
191         [ews] windows or wincairo queue should use del instead of rm command
192         https://bugs.webkit.org/show_bug.cgi?id=202477
193
194         Reviewed by Jonathan Bedard.
195
196         * BuildSlaveSupport/ews-build/steps.py:
197         (CleanUpGitIndexLock.start): Use 'del' command instead of rm for windows and wincairo.
198         * BuildSlaveSupport/ews-build/steps_unittest.py:
199         (TestCleanUpGitIndexLock.test_success_wincairo): Added unit-test.
200
201 2019-10-02  youenn fablet  <youenn@apple.com>
202
203         Add a test to check the case of launching two service worker processes shortly one after the other
204         https://bugs.webkit.org/show_bug.cgi?id=202450
205
206         Reviewed by Chris Dumez.
207
208         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
209
210 2019-10-02  Aakash Jain  <aakash_jain@apple.com>
211
212         [ews] Dedicate a bot for macOS-High-Sierra-Debug-Build-EWS queue
213         https://bugs.webkit.org/show_bug.cgi?id=202469
214
215         Reviewed by Jonathan Bedard.
216
217         * BuildSlaveSupport/ews-build/config.json: Dedicate ews112 to macOS debug builder queue.
218
219 2019-10-01  Jonathan Bedard  <jbedard@apple.com>
220
221         Python 3: Add test-webkitpy for Python 3
222         https://bugs.webkit.org/show_bug.cgi?id=201954
223
224         Reviewed by Aakash Jain.
225
226         * Scripts/test-webkitpy-python3: Added.
227
228 2019-10-02  Carlos Garcia Campos  <cgarcia@igalia.com>
229
230         [GTK][WPE] Stop using legacy custom protocol implementation
231         https://bugs.webkit.org/show_bug.cgi?id=202407
232
233         Reviewed by Žan Doberšek.
234
235         Remove the tests to check failure after committed, because it's not possible to test it with current code.
236
237         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
238         (testWebContextURIScheme):
239
240 2019-10-01  Alexey Shvayka  <shvaikalesh@gmail.com>
241
242         [win-ews] No such file or directory: u'/cygdrive/C/cygwin/home/buildbot/WebKit/WebKitBuild/Release/bin32/layout-test-results/pywebsocket.ws.log-out.txt'
243         https://bugs.webkit.org/show_bug.cgi?id=188640
244
245         Reviewed by Alex Christensen.
246
247         1. Properly shutdown WebSocket server so that port 8880 is released.
248         2. Prevent failure of WebSocket tests when launched in freshly cloned repository.
249
250         * Scripts/new-run-webkit-websocketserver:
251         (main): Tweak import and use class constants of PyWebSocket directly.
252         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
253         (PyWebSocket._prepare_config): Create test output directory if it doesn't exist.
254
255 2019-10-01  Alex Christensen  <achristensen@webkit.org>
256
257         Progress towards a functioning CMake build on Mac
258         https://bugs.webkit.org/show_bug.cgi?id=202443
259
260         Rubber-stamped by Tim Horton.
261
262         * DumpRenderTree/PlatformMac.cmake:
263         * MiniBrowser/mac/CMakeLists.txt:
264         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm:
265         * TestWebKitAPI/CMakeLists.txt:
266         * TestWebKitAPI/PlatformMac.cmake:
267         * WebKitTestRunner/PlatformMac.cmake:
268
269 2019-10-01  John Wilander  <wilander@apple.com>
270
271         Storage Access API: document.hasStorageAccess() should return true when the cookie policy allows access
272         https://bugs.webkit.org/show_bug.cgi?id=202435
273         <rdar://problem/55718526>
274
275         Reviewed by Brent Fulgham.
276
277         This change makes sure topPrivatelyControlledDomain() correctly handles domains
278         with leading dots, as often used in cookie domains.
279
280         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
281         (TestWebKitAPI::TEST_F):
282
283 2019-10-01  Jonathan Bedard  <jbedard@apple.com>
284
285         results.webkit.org: Standardize styles in the drawer
286         https://bugs.webkit.org/show_bug.cgi?id=202428
287
288         Rubber-stamped by Aakash Jain.
289
290         * resultsdbpy/resultsdbpy/view/static/css/search.css: Rename boldInverseColor.
291         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Ditto.
292         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Move style specifications into webkit.css.
293         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Ditto.
294         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
295         (.input>label): Use the boldInverseColor instead of grey.
296         (.input>input[type="text"][required], .input>input[type="number"][required],): Darken the border,
297         decrease the font weight.
298         (.input>input[type="text"][required]~label, .input>input[type="number"][required]~label,): Use the inverseColor instead of grey.
299
300 2019-10-01  Antti Koivisto  <antti@apple.com>
301
302         [CSS Shadow Parts] Parse 'part' attribute
303         https://bugs.webkit.org/show_bug.cgi?id=202409
304
305         Reviewed by Ryosuke Niwa.
306
307         * DumpRenderTree/mac/DumpRenderTree.mm:
308         (enableExperimentalFeatures):
309
310 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
311
312         Follow-up fix to r250572 to fix a typo.
313         [ews] Add method to retry a build using Buildbot API
314         https://bugs.webkit.org/show_bug.cgi?id=202408
315
316         Unreviewed follow-up fix.
317
318         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
319
320 2019-10-01  Aakash Jain  <aakash_jain@apple.com>
321
322         [ews] Add method to retry a build using Buildbot API
323         https://bugs.webkit.org/show_bug.cgi?id=202408
324
325         Reviewed by Jonathan Bedard.
326
327         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
328         (Buildbot.retry_build): Method to retry given build using Buildbot API.
329
330 2019-10-01  David Kilzer  <ddkilzer@apple.com>
331
332         clang-tidy: Fix unnecessary copying/ref churn of for loop variables in Tools
333         <https://webkit.org/b/202387>
334
335         Reviewed by Darin Adler.
336
337         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
338         (WTR::TestController::setAllowedMenuActions): Make loop variable
339         a reference to fix unnecessary copying/ref churn.
340
341 2019-10-01  Nikolas Zimmermann  <nzimmermann@igalia.com>
342
343         Update my affiliation - since today I work for Igalia.
344
345         Unreviewed.
346
347         * Scripts/webkitpy/common/config/contributors.json:
348
349 2019-10-01  Keith Miller  <keith_miller@apple.com>
350
351         Add support for the Wasm multi-value proposal
352         https://bugs.webkit.org/show_bug.cgi?id=202250
353
354         Reviewed by Saam Barati.
355
356         * Scripts/run-jsc-stress-tests:
357
358 2019-10-01  youenn fablet  <youenn@apple.com>
359
360         Remove races condition when validating capture sandbox extension revocation
361         https://bugs.webkit.org/show_bug.cgi?id=202133
362         <rdar://problem/55660905>
363
364         Reviewed by Eric Carlson.
365
366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
367         Updated test to not use page cache so that on going back, the page is reloaded and will call getUserMedia again.
368
369 2019-09-30  Alex Christensen  <achristensen@webkit.org>
370
371         Resurrect Mac CMake build
372         https://bugs.webkit.org/show_bug.cgi?id=202384
373
374         Rubber-stamped by Tim Horton.
375
376         * DumpRenderTree/PlatformMac.cmake:
377         * TestWebKitAPI/PlatformMac.cmake:
378
379 2019-09-30  Zhifei Fang  <zhifei_fang@apple.com>
380
381         [results.webkit.org Timeline] New axis style
382         https://bugs.webkit.org/show_bug.cgi?id=202292
383
384         Reviewed by Jonathan Bedard.
385
386         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
387
388 2019-09-30  Alex Christensen  <achristensen@webkit.org>
389
390         Move DownloadMonitor test speed multiplier from WebProcessPool to WebsiteDataStoreConfiguration
391         https://bugs.webkit.org/show_bug.cgi?id=202339
392
393         Reviewed by Youenn Fablet.
394
395         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
396         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
397
398 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
399
400         [GTK] IconDatabase is not thread-safe
401         https://bugs.webkit.org/show_bug.cgi?id=201303
402
403         Reviewed by Žan Doberšek.
404
405         Rewrite the WebKitFaviconDatabase tests, splitting tests cases again and making them independent to each other.
406
407         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
408         (testFaviconDatabaseInitialization):
409         (testFaviconDatabaseGetFavicon):
410         (ephemeralViewFaviconChanged):
411         (testFaviconDatabaseEphemeral):
412         (testFaviconDatabaseClear):
413         (beforeAll):
414         (afterAll):
415         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFaviconDatabase shouls always pass now.
416
417 2019-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
418
419         [GTK][WPE] Add about:gpu
420         https://bugs.webkit.org/show_bug.cgi?id=202305
421
422         Reviewed by Žan Doberšek.
423
424         Allow to use about:gpu in MiniBrowser. Add a script to get the current svn revision.
425
426         * MiniBrowser/gtk/BrowserTab.c:
427         (getInternalURI):
428         * MiniBrowser/gtk/main.c:
429         (argumentToURL):
430         * MiniBrowser/wpe/main.cpp:
431         (main):
432         * glib/svn-revision: Added.
433
434 2019-09-27  Andres Gonzalez  <andresg_22@apple.com>
435
436         Support accessibility for <figure> element on iOS.
437         https://bugs.webkit.org/show_bug.cgi?id=202272
438         <rdar://problem/54789907>
439
440         Reviewed by Chris Fleizach.
441
442         Implemented titleUIElement and roleDescription properties for <figure> elements on iOS.
443         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
444         (WTR::AccessibilityUIElement::titleUIElement):
445         (WTR::AccessibilityUIElement::roleDescription):
446
447 2019-09-27  Alex Christensen  <achristensen@webkit.org>
448
449         Move shouldUseTestingNetworkSession from NetworkProcessCreationParameters to NetworkSessionCreationParameters
450         https://bugs.webkit.org/show_bug.cgi?id=202327
451
452         Reviewed by Tim Horton.
453
454         * WebKitTestRunner/TestController.cpp:
455         (WTR::TestController::websiteDataStore):
456
457 2019-09-27  Alex Christensen  <achristensen@webkit.org>
458
459         Move service worker process termination delay disabling from process pool to website data store
460         https://bugs.webkit.org/show_bug.cgi?id=202308
461
462         Reviewed by Chris Dumez.
463
464         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
465
466 2019-09-27  Alex Christensen  <achristensen@webkit.org>
467
468         Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
469         https://bugs.webkit.org/show_bug.cgi?id=202285
470
471         Reviewed by Youenn Fablet.
472
473         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
474         (-[ServerTrustDelegate webView:didFinishNavigation:]):
475         (-[ServerTrustDelegate webView:didFailProvisionalNavigation:withError:]):
476         (-[ServerTrustDelegate waitForDidFinishNavigation]):
477         (-[ServerTrustDelegate waitForDidFailProvisionalNavigationError]):
478         (-[ServerTrustDelegate authenticationChallengeCount]):
479         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
480         (TestWebKitAPI::TEST):
481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
482         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
483         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation): Deleted.
484         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess): Deleted.
485         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount): Deleted.
486         * WebKitTestRunner/InjectedBundle/TestRunner.h:
487         * WebKitTestRunner/TestController.cpp:
488         (WTR::TestController::resetStateToConsistentValues):
489         (WTR::TestController::didReceiveAuthenticationChallenge):
490         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
491         * WebKitTestRunner/TestController.h:
492         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const): Deleted.
493         * WebKitTestRunner/TestInvocation.cpp:
494         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
495         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
496         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const): Deleted.
497
498 2019-09-27  Alex Christensen  <achristensen@webkit.org>
499
500         Remove unused APIProcessPoolConfiguration::diskCacheSpeculativeValidationEnabled
501         https://bugs.webkit.org/show_bug.cgi?id=202290
502
503         Reviewed by Carlos Garcia Campos.
504
505         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
506         (TEST):
507         * WebKitTestRunner/TestController.cpp:
508         (WTR::TestController::websiteDataStore):
509         (WTR::TestController::generatePageConfiguration):
510
511 2019-09-27  Youenn Fablet  <youenn@apple.com>
512
513         Make IsNSURLSessionWebSocketEnabled an experimental flag
514         https://bugs.webkit.org/show_bug.cgi?id=202135
515         <rdar://problem/55694721>
516
517         Reviewed by Geoff Garen.
518
519         * WebKitTestRunner/TestController.cpp:
520         (WTR::TestController::resetPreferencesToConsistentValues):
521         Set preference to false by default.
522
523 2019-09-27  Jiewen Tan  <jiewen_tan@apple.com>
524
525         SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
526         https://bugs.webkit.org/show_bug.cgi?id=202061
527         <rdar://problem/55485666>
528
529         Reviewed by Youenn Fablet.
530
531         Adds tests that check the order of messages posted by SubFrameSOAuthorizationSession.
532
533         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
534         (-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
535         (resetState):
536         (TestWebKitAPI::TEST):
537
538 2019-09-26 Kate Cheney <katherine_cheney@apple.com>
539
540         Resource Load Statistics: Downgrade all third-party referrer headers
541         https://bugs.webkit.org/show_bug.cgi?id=201353
542         <rdar://problem/54895650>
543
544         Majority of this patch was written by John Wilander <wilander@apple.com>.
545
546         Reviewed by Brent Fulgham. 
547
548         The changes to the TestRunner facilitates an opt-out for test cases
549         that either test the referrer mechanism explicitly or tests that
550         rely on the full referrer to be sent. 
551
552         The new boolean variable and early return in 
553         TestRunner::setStatisticsShouldDowngradeReferrer() prevent the same
554         event from trying to set multiple TestRunner callbacks.
555
556         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
557         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
558         (WTR::InjectedBundle::didReceiveMessageToPage):
559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
560         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
561         (WTR::TestRunner::statisticsCallDidSetShouldDowngradeReferrerCallback):
562         * WebKitTestRunner/InjectedBundle/TestRunner.h:
563         * WebKitTestRunner/TestController.cpp:
564         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
565         * WebKitTestRunner/TestController.h:
566         * WebKitTestRunner/TestInvocation.cpp:
567         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
568         (WTR::TestInvocation::didSetShouldDowngradeReferrer):
569         * WebKitTestRunner/TestInvocation.h:
570
571 2019-09-26  Dean Jackson  <dino@apple.com>
572
573         Build fix.
574
575         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
576         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]): Deleted.
577         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]): Deleted.
578         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]): Deleted.
579         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]): Deleted.
580
581 2019-09-26  Dean Jackson  <dino@apple.com>
582
583         ContextMenu on a link in an email no longer shows web preview
584         https://bugs.webkit.org/show_bug.cgi?id=201120
585         <rdar://54353617>
586
587         Reviewed by Wenson Hsieh.
588
589         Test context menus on a link that is also an image.
590
591         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
592         (contextMenuWebViewDriver):
593         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
594         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuWillPresentForElement:]):
595         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
596         (-[TestContextMenuImageWithoutConfigurationUIDelegate webView:contextMenuDidEndForElement:]):
597         (TEST):
598
599 2019-09-26  Frederic Wang  <fwang@igalia.com>
600
601         run-safari --ios-simulator is no longer working with Xcode 11
602         https://bugs.webkit.org/show_bug.cgi?id=199852
603
604         Path of MobileSafari.app has changed in Xcode 11. This patch updates
605         the run-safari script to use the new path. This removes support for
606         running Safari on iOS < 13, see discussions on bug 177595.
607
608         Reviewed by Jonathan Bedard.
609
610         * Scripts/webkitdirs.pm:
611         (iosSimulatorApplicationsPath):
612
613 2019-09-26  Zhifei Fang  <zhifei_fang@apple.com>
614
615         [results.webkit.org] Timeline support Image inner label
616         https://bugs.webkit.org/show_bug.cgi?id=202180
617
618         Reviewed by Jonathan Bedard.
619
620         * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
621         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
622         (.lengend>.item .dot img): support img symbol for lengend and dot
623         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
624         (Timeline.CanvasSeriesComponent): Support user pass a Image object or a image url as inner label
625
626 2019-09-26  Chris Dumez  <cdumez@apple.com>
627
628         Stop using testRunner.overridePreference() to turn on Page Cache
629         https://bugs.webkit.org/show_bug.cgi?id=202274
630
631         Reviewed by Alex Christensen.
632
633         * DumpRenderTree/TestRunner.cpp:
634         (overridePreferenceCallback):
635         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
636         (WTR::TestRunner::overridePreference):
637
638 2019-09-26  Jonathan Bedard  <jbedard@apple.com>
639
640         results.webkit.org: Use cursor: pointer for clickable elements
641         https://bugs.webkit.org/show_bug.cgi?id=202268
642
643         Rubber-stamped by Aakash Jain.
644
645         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Give collapse button a pointer for cursor.
646         * resultsdbpy/resultsdbpy/view/templates/search.html: Make 'X' to close test timeline a link-button.
647
648 2019-09-26  Kate Cheney  <katherine_cheney@apple.com>
649
650         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
651         https://bugs.webkit.org/show_bug.cgi?id=195420                          
652         <rdar://problem/54213551>                                               
653
654         Reviewed by Brent Fulgham.                                             
655
656         Added in logic to send a message from the UIProcess to the Network      
657         Process which will initalize the ITP Database backend to allow for      
658         layout testing.                                                         
659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
660         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
661         (WTR::TestRunner::setUseITPDatabase):
662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
663         * WebKitTestRunner/TestController.cpp:
664         (WTR::TestController::setUseITPDatabase):
665         * WebKitTestRunner/TestController.h:
666         * WebKitTestRunner/TestInvocation.cpp:
667         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
668
669 2019-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
670
671         TestWebKitAPI.WebKit.ReloadWithDifferingInitialScale is failing consistently
672         https://bugs.webkit.org/show_bug.cgi?id=202273
673
674         Reviewed by Aakash Jain.
675
676         The content width scaling limits added in r250361 prevent this test from scaling down the content width (2000px
677         wide) to fit the viewport (375px). To avoid this issue, change the content width from 2000px to 1500px, which is
678         still a very wide content width for a web page.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm:
681
682 2019-09-26  Alexey Shvayka  <shvaikalesh@gmail.com>
683
684         toExponential, toFixed, and toPrecision should allow arguments up to 100
685         https://bugs.webkit.org/show_bug.cgi?id=199163
686
687         Reviewed by Ross Kirsling.
688
689         Adjust StringNumberFixedWidth test due to lowering kMaxFixedDigitsBeforePoint.
690
691         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
692
693 2019-09-26  Jiewen Tan  <jiewen_tan@apple.com>
694
695         TestWebKitAPI.SOAuthorizationSubFrame.AuthorizationOptions is failing consistently on iOS API tests EWS
696         https://bugs.webkit.org/show_bug.cgi?id=202249
697
698         Reviewed by Alex Christensen.
699
700         Swizzles +[AKAuthorizationController isURLFromAppleOwnedDomain:] following other tests.
701
702         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
703         (TestWebKitAPI::TEST):
704
705 2019-09-25  Alex Christensen  <achristensen@webkit.org>
706
707         Add replacement SPI on _WKWebsiteDataStoreConfiguration for enabling speculative cache validation and IPC-free server trust evaluation
708         https://bugs.webkit.org/show_bug.cgi?id=202251
709
710         Reviewed by Tim Horton.
711
712         Adopt new SPI instead of deprecated SPI.
713
714         * MiniBrowser/mac/AppDelegate.m:
715         (persistentDataStore):
716         (defaultConfiguration):
717         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
718         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
719         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
720
721 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
722
723         Python 3: Add support in webkitpy.common.system
724         https://bugs.webkit.org/show_bug.cgi?id=201826
725         <rdar://problem/55452671>
726
727         Reviewed by Stephanie Lewis.
728
729         Tested compatibility by running 'python3 -m unittest webkitpy.common.system.<_unittest>' on
730         each of the effected files.
731
732         * Scripts/webkitpy/common/checkout/changelog.py: Import StringIO from io module.
733         (set_reviewer):
734         (set_short_description_and_bug_url):
735         * Scripts/webkitpy/common/checkout/checkout.py:  Import StringIO from io module.
736         (Checkout._latest_entry_for_changelog_at_revision):
737         * Scripts/webkitpy/common/config/committers.py:
738         (CommitterList.load_json): iteritems -> items.
739         * Scripts/webkitpy/common/net/networktransaction.py:
740         (NetworkTransaction.run): urllib2 is urllib in Python3. 
741         * Scripts/webkitpy/common/system/abstractexecutive.py:
742         (AbstractExecutive._stringify_args):
743         (AbstractExecutive.command_for_printing): The str type is unicode in Python3.
744         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Explicitly encode and decode binary crashlogs.
745         * Scripts/webkitpy/common/system/environment_unittest.py: Use absolute imports.
746         * Scripts/webkitpy/common/system/executive.py:
747         (ScriptError.message_with_output): The str type is unicode in Python3.
748         (Executive.WrappedPopen): Python3's Popen object is a context manager. To allow us to use it as one,
749         our Python2 Popen needs to be one as well.
750         (Executive.WrappedPopen.__init__):
751         (Executive.WrappedPopen.__enter__):
752         (Executive.WrappedPopen.__exit__):
753         (Executive._run_command_with_teed_output): Simplify loop, decode unicode strings.
754         (Executive.run_and_throw_if_fail): The child output file should not be unicode strings.
755         (Executive.running_pids): Use the Popen context manager to guarantee clean-up.
756         (Executive._compute_stdin):
757         (Executive.run_command): Use the Popen context manager to guarantee clean-up.
758         (Executive._stringify_args): The str type is unicode in Python3.
759         (Executive.popen): Return a context manager if the Popen object is not one.
760         * Scripts/webkitpy/common/system/executive_mock.py:
761         (MockProcess.__init__): StringIO -> BytesIO.
762         (MockProcess.__enter__):
763         (MockProcess):
764         (MockProcess.__exit__):
765         * Scripts/webkitpy/common/system/executive_unittest.py:
766         (ExecutiveTest.test_auto_stringify_args): Use the Popen context manager to guarantee clean-up.
767         (ExecutiveTest.test_popen_args): Ditto.
768         (ExecutiveTest.serial_test_kill_process): Ditto.
769         (ExecutiveTest.serial_test_kill_all): Ditto.
770         * Scripts/webkitpy/common/system/filesystem.py:
771         (FileSystem.read_binary_file): Use 'open' instead of 'file'.
772         (FileSystem.write_binary_file): Ditto.
773         (FileSystem.write_text_file): The str type is unicode in Python3. 
774         (FileSystem.relpath):
775         (FileSystem.remove): The WindowsError is just anther OSError in Python3.
776         (FileSystem._WindowsError): Deleted.
777         * Scripts/webkitpy/common/system/filesystem_mock.py:
778         (MockFileSystem.glob): filter returns a generator instead of a list.
779         (WritableBinaryFileObject.__init__): Binary files are comprised of bytes, not string in Python3.
780         (WritableBinaryFileObject.write): Ditto.
781         (ReadableTextFileObject.__init__): Ditto.
782         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
783         (MockFileSystemTest.test_normpath):
784         (MockFileSystemTest.test_dirs_under): assertEquals -> assertEqual.
785         * Scripts/webkitpy/common/system/filesystem_unittest.py:
786         (RealFileSystemTest.test_read_and_write_file): Explicitly define byte arrays instead of strings.
787         (RealFileSystemTest.test_remove_file_with_retry.remove_with_exception): The WindowsError is just
788         anther OSError in Python3.
789         * Scripts/webkitpy/common/system/outputcapture.py:
790         * Scripts/webkitpy/common/system/outputtee_unittest.py:
791         (SimpleTeeTest.test_simple_tee):
792         * Scripts/webkitpy/common/system/path.py:
793         (_escape): urllib library has been broken into parts.
794         * Scripts/webkitpy/common/system/pemfile.py:
795         (_parse_pem_format.find_end): Python3 does not define a maxint.
796         * Scripts/webkitpy/common/system/pemfile_unittest.py:
797         * Scripts/webkitpy/common/system/platforminfo.py:
798         (PlatformInfo.total_bytes_memory): Not 'long' type in Python3.
799         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
800         (TestPlatformInfo.test_real_code): assertNotEquals -> assertNotEqual.
801         (TestPlatformInfo.test_display_name): Ditto.
802         * Scripts/webkitpy/common/system/profiler.py:
803         (ProfilerFactory.create_profiler): Manually implement ifilter.
804         * Scripts/webkitpy/common/system/profiler_unittest.py: Use absolute imports.
805         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
806         (current_thread_id): items() returns a generator in Python3.
807         * Scripts/webkitpy/common/system/systemhost.py: Use absolute imports.
808         * Scripts/webkitpy/common/system/urlfetcher.py: Removed.
809         * Scripts/webkitpy/common/system/urlfetcher_mock.py: Removed.
810         * Scripts/webkitpy/common/system/user.py:
811         (User.prompt): Use absolute imports, raw_input -> input.
812         (User.prompt_with_multiple_lists):
813         (User.prompt_with_list):
814         (User.confirm):
815         * Scripts/webkitpy/common/unicode.py: Tooling to manage compatibility between Python 2
816         and Python 3 unicode handling.
817         * Scripts/webkitpy/common/system/user_mock.py:
818         (MockUser.prompt): raw_input -> input.
819         (MockUser.prompt_with_list): Ditto.
820         * Scripts/webkitpy/common/version.py:
821         (Version.from_iterable): xrange -> range.
822         (Version.from_name): Use absolute import path.
823         (Version.__contains__): xrange -> range.
824         (Version.__str__): xrange -> range.
825         (Version.__cmp__): amp is no longer an operator in Python3, but versions are comprised
826         Of integers, so subtraction has the same effect.
827         (Version):
828         (Version.__eq__): __cmp__ operator is no longer respected, so we need to implement
829         each comparison.
830         (Version.__ne__): Ditto.
831         (Version.__lt__): Ditto.
832         (Version.__le__): Ditto.
833         (Version.__gt__): Ditto.
834         (Version.__ge__): Ditto.
835         * Scripts/webkitpy/common/version_name_map.py:
836         (VersionNameMap._automap_to_major_version):
837         (VersionNameMap.to_name): xrange -> range.
838         (VersionNameMap.from_name): iteritems -> items.
839         * Scripts/webkitpy/common/version_name_map_unittest.py: Use absolute imports.
840         * Scripts/webkitpy/common/version_unittest.py: Ditto.
841         * Scripts/webkitpy/common/wavediff.py:
842         (WaveDiff.__init__): StringIO -> BytesIO.
843         * Scripts/webkitpy/port/__init__.py:
844         (outside):
845
846 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
847
848         [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests
849         https://bugs.webkit.org/show_bug.cgi?id=202216
850
851         Reviewed by Jonathan Bedard.
852
853         * BuildSlaveSupport/ews-build/steps.py:
854         (RunJavaScriptCoreTestsToT): Removed the command so as to use the command from base class.
855         * BuildSlaveSupport/ews-build/steps_unittest.py: Updatd unit-tests.
856
857 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
858
859         [ews] JSC queues should run or skip tests based on runTests key from config.json
860         https://bugs.webkit.org/show_bug.cgi?id=202223
861
862         Reviewed by Jonathan Bedard.
863
864         * BuildSlaveSupport/ews-build/config.json: Added the runTests key.
865         * BuildSlaveSupport/ews-build/factories.py:
866         (JSCTestsFactory.__init__): Add RunJavaScriptCoreTests step based on runTests key.
867         * BuildSlaveSupport/ews-build/loadConfig.py:
868         (loadBuilderConfig): Pass the runTests key to the factory.
869         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
870         (ConfigDotJSONTest.test_builder_keys): Added the runTests key.
871
872 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
873
874         results.webkit.org: Add investigation drawer
875         https://bugs.webkit.org/show_bug.cgi?id=202106
876
877         Reviewed by Dewei Zhu.
878
879         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Support multiple 'main' classes.
880         * resultsdbpy/resultsdbpy/view/static/js/expectations.js: Added.
881         (Expectations.colorMap): Return a dictionary mapping type strings to colors.
882         (Expectations.stringToStateId): Map a string to a state ID for sorting.
883         (Expectations.typeForId): Return a type string given an ID.
884         (Expectations.symbolForId): Return a symbol for a type given an ID.
885         (Expectations.colorForId): Return a color given an ID.
886         (Expectations.unexpectedResults): Given a list of actual results and expected results,
887         return a state.
888         (Expectations):
889         * resultsdbpy/resultsdbpy/view/static/js/investigate.js: Added.
890         (commitsForUuid):
891         (testRunLink):
892         (elapsed):
893         (percentage):
894         (contentForAgregateData):
895         (contentForData):
896         (_InvestigateDrawer):
897         (_InvestigateDrawer.prototype.isRendered):
898         (_InvestigateDrawer.prototype.expand): Expand the investigation drawer.
899         (_InvestigateDrawer.prototype.collapse): Collapse the investigation drawer.
900         (_InvestigateDrawer.prototype.select): Select an element to investigate.
901         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
902         (statsForSingleResult): Move Expectation constants.
903         (TimelineFromEndpoint.prototype.render): Investigate specific data points instead
904         of jumping to the build.
905         (Expectations.stringToStateId): Deleted.
906         (Expectations.unexpectedResults): Deleted.
907         (Expectations): Deleted.
908         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
909         (.drawer.display): Make minimum height.
910         (@media screen and (min-width: 600px)): Move main and sidebar so they override drawer.
911         (@media screen and (min-width: 768px)): Ditto.
912         * resultsdbpy/resultsdbpy/view/templates/commits.html:
913         * resultsdbpy/resultsdbpy/view/templates/search.html:
914         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
915
916 2019-09-25  Alex Christensen  <achristensen@webkit.org>
917
918         Remove duplicate WebsiteDataStoreConfiguration copying code
919         https://bugs.webkit.org/show_bug.cgi?id=202215
920
921         Reviewed by Tim Horton.
922
923         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
924         (TEST):
925
926 2019-09-25  Alex Christensen  <achristensen@webkit.org>
927
928         Replace WebsiteDataStoreParameters::privateSessionParameters with re-initializing all sessions immediately upon NetworkProcess resumption
929         https://bugs.webkit.org/show_bug.cgi?id=202211
930
931         Reviewed by Tim Horton.
932
933         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
934         (checkRecoveryAfterCrash):
935         (TEST):
936
937 2019-09-25  Aakash Jain  <aakash_jain@apple.com>
938
939         [EWS] JSC queues should dynamically add required build steps for re-testing the patch
940         https://bugs.webkit.org/show_bug.cgi?id=202170
941
942         Reviewed by Jonathan Bedard.
943
944         * BuildSlaveSupport/ews-build/factories.py:
945         (JSCTestsFactory.__init__): Do not add ReRunJavaScriptCoreTests and related steps here, as
946         these are dynamically added (if required) in steps.py.
947         * BuildSlaveSupport/ews-build/steps.py:
948         (CompileJSCToT): Remove doStepIf() and hideStepIf() method, these are no longer required as we add
949         this step dynamically only if required. We don't need an extra property ('patchFailedToBuild') to be set.
950         (RunJavaScriptCoreTests.evaluateCommand): Dynamically add ReRunJavaScriptCoreTests step if required.
951         (ReRunJavaScriptCoreTests): Removed doStepIf() and hideStepIf() method.
952         (ReRunJavaScriptCoreTests.evaluateCommand): Dynamically add UnApplyPatchIfRequired(), CompileJSCToT() and RunJavaScriptCoreTestsToT steps.
953         (RunJavaScriptCoreTestsToT.evaluateCommand): Overriden to avoid caling the base-class method which dynamically adds
954         more steps.
955         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
956
957 2019-09-25  Wenson Hsieh  <wenson_hsieh@apple.com>
958
959         [iPadOS] [DataActivation] Focus moves away after focusing input fields on www.att.com
960         https://bugs.webkit.org/show_bug.cgi?id=202167
961         <rdar://problem/55185021>
962
963         Reviewed by Tim Horton.
964
965         Rebaseline an API test.
966
967         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
968         (TestWebKitAPI::TEST):
969
970 2019-09-25  Jonathan Bedard  <jbedard@apple.com>
971
972         Unreviewed, rolling out r250324.
973
974         Tools/ChangeLog
975
976         Reverted changeset:
977
978         "Enable LayoutTests using ResourceLoadStatistics SQLite
979         backend (195420)"
980         https://bugs.webkit.org/show_bug.cgi?id=195420
981         https://trac.webkit.org/changeset/250324
982
983 2019-09-24  Fujii Hironori  <Hironori.Fujii@sony.com>
984
985         [Windows][webkitpy] _apache_config_file_name_for_platform should take the system PHP version into account
986         https://bugs.webkit.org/show_bug.cgi?id=202134
987
988         Reviewed by Jonathan Bedard.
989
990         _apache_config_file_name_for_platform always returns a config file
991         name for PHP5 on Cygwin Python, one for PHP7 on Win32 Python. It
992         should detect the system PHP version as Linux ports do.
993
994         Both AppleWin and WinCairo are using XAMPP Apache. Unify the code
995         paths for them. And, remove a stale conf file.
996
997         This change makes it possible to use Cygwin Python with PHP7.
998
999         * Scripts/webkitpy/port/base.py:
1000         (Port._win_php_version): Added.
1001         (Port._apache_config_file_name_for_platform): Unified cygwin and
1002         win32 code path by using _win_php_version.
1003         * Scripts/webkitpy/port/port_testcase.py:
1004         (test_apache_config_file_name_for_platform): Updated cygwin and
1005         win32 test cases.
1006
1007 2019-09-24  Matt Lewis  <jlewis3@apple.com>
1008
1009         Bring up queues for iPadOS Simulator Tests
1010         https://bugs.webkit.org/show_bug.cgi?id=202151
1011
1012         Reviewed by Jonathan Bedard.
1013
1014         * BuildSlaveSupport/build.webkit.org-config/config.json:
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1016         (WebKitBuildbot):
1017         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1018
1019 2019-09-24  Kate Cheney  <katherine_cheney@apple.com>
1020
1021         Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420) 
1022         https://bugs.webkit.org/show_bug.cgi?id=195420                          
1023         <rdar://problem/54213551>                                               
1024
1025         Reviewed by Brent Fulgham.                                             
1026
1027         Added in logic to send a message from the UIProcess to the Network      
1028         Process which will initalize the ITP Database backend to allow for      
1029         layout testing.                                                         
1030         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1031         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1032         (WTR::TestRunner::setUseITPDatabase):
1033         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1034         * WebKitTestRunner/TestController.cpp:
1035         (WTR::TestController::setUseITPDatabase):
1036         * WebKitTestRunner/TestController.h:
1037         * WebKitTestRunner/TestInvocation.cpp:
1038         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1039
1040 2019-09-24  Patrick Griffis  <pgriffis@igalia.com>
1041
1042         Add Patrick Griffis to contributors.json
1043
1044         Unreviewed.
1045
1046         * Scripts/webkitpy/common/config/contributors.json:
1047
1048 2019-09-24  Aakash Jain  <aakash_jain@apple.com>
1049
1050         [ews-build] Improve summary for Validate Patch step
1051         https://bugs.webkit.org/show_bug.cgi?id=202163
1052
1053         Reviewed by Jonathan Bedard.
1054
1055         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Remove the redundant message saying:
1056         'Some messages were logged while the patch was still eligible'.
1057         * BuildSlaveSupport/ews-build/steps.py:
1058         (ValidatePatch.skip_build): Updated the descritionDone with the reason to skip the patch.
1059         (ValidatePatch.getResultSummary): Overrode this method so as to prevent buildbot from automatically
1060         appending '(failure)' at the end of the summary string.
1061
1062 2019-09-24  Keith Rollin  <krollin@apple.com>
1063
1064         Coalesce or remove PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
1065         https://bugs.webkit.org/show_bug.cgi?id=202119
1066         <rdar://problem/55638792>
1067
1068         Reviewed by Alex Christensen.
1069
1070         After refactoring and other code evolution, some platform checks have
1071         ended up looking like PLATFORM(MAC) || PLATFORM(IOS_FAMILY) (or
1072         vice-versa). These can be converted into the equivalent
1073         PLATFORM(COCOA). Where the instance occurs in a Cocoa-only file, the
1074         check can be removed altogether (along with any "#else" branches).
1075
1076         * DumpRenderTree/AccessibilityTextMarker.h:
1077         * DumpRenderTree/AccessibilityUIElement.cpp:
1078         (AccessibilityUIElement::setValue):
1079
1080 2019-09-24  Zhifei Fang  <zhifei_fang@apple.com>
1081
1082         Add tests for Ref.js.
1083         https://bugs.webkit.org/show_bug.cgi?id=201778.
1084
1085         Reviewed by Jonathan Bedard.
1086
1087         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
1088         (applyStateDiff): null, 0, false are all valid state
1089         (Ref.prototype.setState): We should do nothing for undefined stateDiff
1090         * resultsdbpy/resultsdbpy/view/static/library/js/Test.js: Added.
1091         (AssertFailedError):
1092         (Expect): Perform assertions during unit tests.
1093         (Expect.prototype.isType):
1094         (Expect.prototype.equalToValue):
1095         (Expect.prototype.equalToHtmlWithoutRef):
1096         (Expect.prototype.notEqualToValue):
1097         (Expect.prototype.greaterThan):
1098         (Expect.prototype.greaterThanOrEqualTo):
1099         (Expect.prototype.lessThan):
1100         (Expect.prototype.lessThanOrEqualTo):
1101         (TestSuite): Common TestSuite class for user to extend. 
1102         (TestSuite.prototype.expect):
1103         (TestSuite.prototype.sleep): Test will sleep for certain ms
1104         (TestSuite.prototype.waitForSignal): Wait until we receive a certain signal with timeout
1105         (TestSuite.prototype.waitForRefMounted): Wait until we receive ref object's onElementMount signal with timeout
1106         (TestSuite.prototype.waitForRefUnmounted): Wait until we receive ref object's onElementUnmount signal with timeout
1107         (TestSuite.prototype.waitForStateUpdated):Wait until we receive ref object's onStateUpdate signal with timeout
1108         (TestSuite.prototype.async.setup): Common interface for setup a test suite
1109         (TestSuite.prototype.async.clearUp): Common interface for clear up a test suite
1110         (getTestFucntionNames): Collect all the test method of a test instance.
1111         (TestResult):
1112         (TestResult.prototype.catchException):
1113         (async.getTestResult): Run the test and generate a TestResult object
1114         (TestController):
1115         (TestController.prototype.addResultHandler): Test controller will send notification of a test result to result handler
1116         (TestController.prototype.addSetupArgs): This gives some additional args for the common setup method for each test class, 
1117         it is the best place to setup something like a root element, a fake data source, etc
1118         (TestController.prototype.collect): This method used for collect the test classes.
1119         (TestController.prototype.async.collectFile): It will import the file as a module dynamicly and collect all the test classes that module export
1120         (TestController.prototype.async.runTest): It will run a test method of a test class
1121         (TestController.prototype.async.run): It will run all test or a test class or a test method
1122         * resultsdbpy/resultsdbpy/view/static/library/js/components/TestComponents.js: components for test app.
1123         * resultsdbpy/resultsdbpy/view/static/library/js/test/RefTest.js: Ref.js test cases.
1124         * resultsdbpy/resultsdbpy/view/static/library/js/test/index.html: Test app entry.
1125
1126 2019-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1127
1128         FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState triggers a debug assertion
1129         https://bugs.webkit.org/show_bug.cgi?id=202145
1130         <rdar://problem/51273128>
1131
1132         Reviewed by Tim Horton.
1133
1134         Fixes this API test to work on iPad as well as iPhone. Importantly, we show a popover when focusing
1135         select elements on iPad, which means that there is no -inputView present on WKContentView, and upon
1136         dismissing the form accessory view, the select element is still focused.
1137
1138         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1139
1140 2019-09-25  Cathie Chen  <cathiechen@igalia.com>
1141
1142         Add Cathie Chen as WebKit committer
1143
1144         Unreviewed.
1145
1146         * Scripts/webkitpy/common/config/contributors.json:
1147
1148 2019-09-24  Alex Christensen  <achristensen@webkit.org>
1149
1150         Require a WebsiteDataStore when creating or resuming downloads
1151         https://bugs.webkit.org/show_bug.cgi?id=202081
1152
1153         Reviewed by Youenn Fablet.
1154
1155         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1156         (-[DownloadProgressTestRunner startDownload:expectedLength:]):
1157
1158 2019-09-23  Zan Dobersek  <zdobersek@igalia.com>
1159
1160         run-web-platform-tests: remove support for in-repository manifest, expectation management
1161         https://bugs.webkit.org/show_bug.cgi?id=202037
1162
1163         Reviewed by Carlos Alberto Lopez Perez.
1164
1165         Instead of keeping wpt metadata inside the WebKit repository or have it
1166         generated on-the-fly, provide additional option flags for the
1167         run-web-platform-tests script that allows detailed specification of the
1168         metadata, manifest and include manifest locations, if necessary.
1169
1170         If the metadata location is not provided, the wptrunner tool will simply
1171         not rely on any metadata to adjust expected results. With no manifest
1172         path specified, the manifest will be generated inside the wpt checkout.
1173         If no include manifest is specified, all the tests will be initially
1174         selected for running (until they're possibly filtered through additional
1175         command line arguments).
1176
1177         * Scripts/webkitpy/common/config/ports_mock.py:
1178         (MockPort.run_bindings_tests_command):
1179         (MockPort.wpt_metadata_directory): Deleted.
1180         (MockPort.wpt_manifest_file): Deleted.
1181         * Scripts/webkitpy/port/base.py:
1182         (Port.default_results_directory):
1183         (Port.wpt_metadata_directory): Deleted.
1184         (Port.wpt_manifest_file): Deleted.
1185         * Scripts/webkitpy/w3c/wpt_runner.py:
1186         (parse_args):
1187         (WPTRunner.prepare_wpt_checkout):
1188         (WPTRunner.run):
1189         (WPTRunner._generate_metadata_directory): Deleted.
1190         (WPTRunner._wpt_run_paths): Deleted.
1191         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
1192         (WPTRunnerTest.TestInstance.__init__):
1193         (WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
1194         (WPTRunnerTest.test_run):
1195         (WPTRunnerTest.test_run_with_specified_options):
1196         (WPTRunnerTest.test_run_with_args):
1197         (WPTRunnerTest.TestInstance.prepare_mock_files_for_run): Deleted.
1198         (WPTRunnerTest.test_generate_metadata_directory): Deleted.
1199
1200 2019-09-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1201
1202         [Win][WebKitTestRunner] Implement EventSenderProxy::keyDown
1203         https://bugs.webkit.org/show_bug.cgi?id=201913
1204
1205         Reviewed by Ross Kirsling.
1206
1207         Implemented eventSender.keyDown for Windows WebKitTestRunner based
1208         on DumpRenderTree implementation.
1209
1210         There is a difference between them. Only WTR truns KF_UP and
1211         KF_REPEAT flags on for WM_KEYUP event.
1212         EventSenderProxy::dispatchMessage is used in WTR. It calls
1213         TranslateMessage, this introduces the difference. If I didn't turn
1214         those bits, TranslateMessage posts WM_CHAR even for WM_KEYUP.
1215         According the spec, WM_KEYUP needs those bits.
1216         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-keyup>
1217         DRT doesn't need the those bits becasuse it doesn't use
1218         TranslateMessage for WM_KEYUP.
1219
1220         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1221         (WTR::makeKeyDataForScanCode): Added.
1222         (WTR::pumpMessageQueue): Added.
1223         (WTR::EventSenderProxy::keyDown): Implemented by using DRT code.
1224
1225 2019-09-23  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [EWS] Rename CompileJSCOnly to CompileJSC
1228         https://bugs.webkit.org/show_bug.cgi?id=202118
1229
1230         Reviewed by Jonathan Bedard.
1231
1232         * BuildSlaveSupport/ews-build/factories.py:
1233         (JSCTestsFactory.__init__): Renamed CompileJSCOnly to CompileJSC.
1234         * BuildSlaveSupport/ews-build/steps.py:
1235         (CompileWebKit.evaluateCommand): Ditto.
1236         (AnalyzeCompileWebKitResults.start): Ditto.
1237         (CompileJSC): Changed step-name to 'compile-jsc' to better match with similar steps like 'compile-webkit'. 
1238         (CompileJSCToT): Ditto for 'compile-jsc-tot'.
1239         * BuildSlaveSupport/ews-build/steps_unittest.py: Renamed CompileJSCOnly to CompileJSC and CompileJSCOnlyToT to CompileJSCToT.
1240
1241 2019-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1242
1243         [iOS] Drop animation when dragging images from Photos to WebKit2 Mail compose is incorrect
1244         https://bugs.webkit.org/show_bug.cgi?id=201674
1245         <rdar://problem/51250952>
1246
1247         Reviewed by Tim Horton.
1248
1249         Add a couple of new API tests to exercise the new image placeholder drop codepath, in addition to testing
1250         infrastructure to simulate the timing of drop animation delegate calls.
1251
1252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1253         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1254         (-[NSArray _attachmentWithName:]):
1255         (-[TestWKWebView allBoundingClientRects:]):
1256
1257         Add some new API testing helper methods.
1258
1259         (TestWebKitAPI::targetedImageDragPreview):
1260         (TestWebKitAPI::TEST):
1261
1262         Add two new tests, to:
1263         (1) verify that images are dropped as attachment-backed placeholder image elements when the web view is editable
1264             and enables attachment elements, and
1265         (2) verify that when dropping an image taller than the web view, the bottom portion of the drop preview is
1266             clipped using the targeted preview parameter's visiblePath.
1267
1268         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1269         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
1270         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1271         * TestWebKitAPI/cocoa/NSItemProviderAdditions.h: Added.
1272         * TestWebKitAPI/cocoa/NSItemProviderAdditions.mm: Added.
1273
1274         Move some common helpers for registering data on a NSItemProvider to a separate file, so that it can be used in
1275         both WKAttachmentTests and DragAndDropTests.
1276
1277         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1278         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:loadingDelay:]):
1279         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1280         (-[DragAndDropSimulator initWithWebView:]):
1281         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
1282         (-[DragAndDropSimulator clearExternalDragInformation]):
1283         (-[DragAndDropSimulator setExternalItemProviders:defaultDropPreviews:]):
1284
1285         Add a new method to allow tests to specify both a list of externally dragged item providers, as well as default
1286         targeted previews for each of the corresponding items. These default previews are used when invoking the drop
1287         interaction delegate's preview generation methods.
1288
1289         (-[DragAndDropSimulator addAnimations:]):
1290
1291         Not implemented yet; for now, this simply asserts.
1292
1293         (-[DragAndDropSimulator addCompletion:]):
1294
1295         Queues a completion handler, which is invoked when the drop animation for each item completes. Depending on the
1296         value of DragAndDropSimulator's -dropAnimationTiming, this may occur either before or after handling the drop.
1297         By default, these will be invoked after the drop completes, which represents the common case where data can be
1298         loaded quickly relative to the drop animation.
1299
1300         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
1301         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1302
1303 2019-09-23  Jonathan Bedard  <jbedard@apple.com>
1304
1305         results.webkit.org: Collapse results with the same version name (Follow-up fix)
1306         https://bugs.webkit.org/show_bug.cgi?id=201779
1307
1308         Rubber-stamped by Aakash Jain.
1309
1310         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1311         (Configuration.prototype.compare): Correctly compare constructed version names.
1312
1313 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
1314
1315         [WebAuthn] LocalAuthenticator tests are failing on internal bots
1316         https://bugs.webkit.org/show_bug.cgi?id=201844
1317         <rdar://problem/54278693>
1318
1319         Reviewed by Brent Fulgham.
1320
1321         LocalAuthenticator tests utilize Keychain for mock testing. Unlike iOS simulator tests which
1322         each test runner is running in different simulator containers, all test runners are running
1323         in the same macOS container in macOS. Therefore, Keychain is shared among all test runners
1324         in macOS while it is not in iOS simulators. And therefore, race conditions would happen in
1325         macOS which make the current tests flaky given they don't consider race conditions.
1326
1327         This patch then makes each test generate a random credential, and thus no other tests would
1328         be able to access it, and therefore eliminate any race condition. To support this, a few new
1329         functionalities are introduced to the mock test infrastructure as well:
1330         1) TestRunner.cleanUpKeychain accepts a new parameter to more precisely identify an item.
1331         2) WebAuthenticationMockConfiguration.Local has a new member to uniquely select a credential
1332         for getAssertion ceremony when multiple presents.
1333
1334         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1335         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1336         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1337         (WTR::TestRunner::cleanUpKeychain):
1338         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1339         * WebKitTestRunner/TestController.h:
1340         * WebKitTestRunner/TestInvocation.cpp:
1341         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1342         * WebKitTestRunner/TestController.cpp:
1343         (WTR::TestController::cleanUpKeychain):
1344         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1345         (WTR::TestController::cleanUpKeychain):
1346
1347 2019-09-20  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [EWS] JSC queues should re-build ToT and compare results on build failure
1350         https://bugs.webkit.org/show_bug.cgi?id=201999
1351
1352         Reviewed by Jonathan Bedard.
1353
1354         * BuildSlaveSupport/ews-build/factories.py:
1355         (JSCTestsFactory.__init__): Do not add the UnApplyPatchIfRequired and CompileJSCOnlyToT step here, as
1356         these are dynamically added (if required) in steps.py in CompileWebKit.evaluateCommand() using addStepsAfterCurrentStep().
1357         Also setting skipUpload=False since we don't need to upload the archive for this queue. Building and testing is done in same build.
1358         * BuildSlaveSupport/ews-build/steps.py:
1359         (CompileWebKit.evaluateCommand): Add CompileJSCOnlyToT or CompileWebKitToT build-step based on 'group' property.
1360         (AnalyzeCompileWebKitResults.start): Ditto.
1361         (CompileJSCOnly.start): Set the 'group' property to 'jsc'.
1362         (CompileJSCOnlyToT.evaluateCommand): Over-ride evaluateCommand, so that base-class' (CompileWebKit) evaluateCommand is 
1363         not used, base class evaluateCommand adds build-steps dynamically.
1364
1365 2019-09-20  Keith Rollin  <krollin@apple.com>
1366
1367         Remove some support for < iOS 13
1368         https://bugs.webkit.org/show_bug.cgi?id=201967
1369         <rdar://problem/55504738>
1370
1371         Reviewed by Andy Estes.
1372
1373         Remove some support for iOS versions less than 13.0.
1374
1375         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1376         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1377         values >= 130000. This means that expressions like
1378         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
1379         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
1380
1381         After version checks have been removed, there are some cases where the
1382         preprocessor conditional looks like "#if PLATFORM(MAC) ||
1383         PLATFORM(IOS_FAMILY)". These can be collapsed into "#if
1384         PLATFORM(COCOA)". This additional cleanup will be performed in a
1385         subsequent patch.
1386
1387         This removal is part of a series of patches effecting the removal of
1388         dead code for old versions of iOS. This particular pass involves
1389         changes in which Andy Estes was involved. These changes are isolated
1390         from other similar changes in order to facilitate the reviewing
1391         process.
1392
1393         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: Removed.
1394
1395 2019-09-20  Alex Christensen  <achristensen@webkit.org>
1396
1397         Begin moving WebsiteDataStore setters to WebsiteDataStoreConfiguration
1398         https://bugs.webkit.org/show_bug.cgi?id=202025
1399
1400         Reviewed by Chris Dumez.
1401
1402         One expected change in behavior is that the resource load statistics directory is not created on startup with an ephemeral session any more
1403         because we call the constructor of WebsiteDataStoreConfiguration inside _WKWebsiteDataStoreConfiguration and set the default directory like we do the other directories.
1404
1405         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
1406         * WebKitTestRunner/TestController.cpp:
1407         (WTR::TestController::websiteDataStore):
1408         (WTR::TestController::generatePageConfiguration):
1409
1410 2019-09-20  Keith Rollin  <krollin@apple.com>
1411
1412         Remove some support for < iOS 13
1413         https://bugs.webkit.org/show_bug.cgi?id=201973
1414         <rdar://problem/55506966>
1415
1416         Reviewed by Alex Christensen.
1417
1418         Remove some support for iOS versions less than 13.0.
1419
1420         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1421         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1422         values >= 130000. This means that expressions like
1423         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
1424         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
1425
1426         This removal is part of a series of patches effecting the removal of
1427         dead code for old versions of iOS. This particular pass involves
1428         changes in which Chris Dumez was involved. These changes are isolated
1429         from other similar changes in order to facilitate the reviewing
1430         process.
1431
1432         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1433
1434 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
1435
1436         [FTW] Enable WebKitTestRunner build
1437         https://bugs.webkit.org/show_bug.cgi?id=201996
1438
1439         Reviewed by Fujii Hironori.
1440
1441         It's time to start getting the test system up and running for FTW.
1442
1443         This patch does the following:
1444
1445         1. Adds relevant CMake changes to get things building.
1446         2. Adds a "--ftw" flag to the build scripts that will trigger a relevant build.
1447         3. Updates 'webkitpy' to recognize the 'ftw' port.
1448
1449         Note: Pixel tests are not yet supported.
1450
1451         * PlatformFTW.cmake: Build the WK2 test runner.
1452         * Scripts/build-webkit: Update to recognize the FTW port.
1453         * Scripts/webkitdirs.pm: Ditto.
1454         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Ditto.
1455         * Scripts/webkitpy/common/config/ports.py: Ditto.
1456         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1457         * Scripts/webkitpy/common/version_name_map.py: Ditto.
1458         * Scripts/webkitpy/port/factory.py: Ditto.
1459         * Scripts/webkitpy/port/win.py: Ditto.
1460         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1461         (WTR::InjectedBundlePage::dumpDOMAsWebArchive): Don't build or run this method
1462         on Windows.
1463         * WebKitTestRunner/PlatformFTW.cmake: Added.
1464         * WebKitTestRunner/PlatformWebView.h:
1465         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1466         * WebKitTestRunner/win/TestInvocationDirect2D.cpp: Added.
1467         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add stub implementation.
1468
1469 2019-09-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1470
1471         [Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
1472         https://bugs.webkit.org/show_bug.cgi?id=201976
1473
1474         Reviewed by Don Olmstead.
1475
1476         This change consists of three refactorings:
1477         1. Replaced explicit QueryInterface with _com_ptr_t methods
1478         2. Replaced typedef with _COM_SMARTPTR_TYPEDEF macro
1479         3. Replaced WebCore's COMPtr with _com_ptr_t because it is not a public WebKit API
1480
1481         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1482         (MiniBrowserWebHost::didFirstLayoutInFrame): Deleted.
1483         * MiniBrowser/win/MiniBrowserWebHost.h:
1484         (MiniBrowserWebHost::didFirstLayoutInFrame):
1485         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1486         (getHandleFromWebView):
1487         (PrintWebUIDelegate::webViewPrintingMarginRect):
1488         (PrintWebUIDelegate::runModal):
1489         (PrintWebUIDelegate::createModalDialog):
1490         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1491         (WebKitLegacyBrowserWindow::init):
1492         (WebKitLegacyBrowserWindow::setToDefaultPreferences):
1493         (WebKitLegacyBrowserWindow::showLastVisitedSites):
1494         (WebKitLegacyBrowserWindow::reload):
1495         (WebKitLegacyBrowserWindow::resetZoom):
1496         (WebKitLegacyBrowserWindow::zoomIn):
1497         (WebKitLegacyBrowserWindow::zoomOut):
1498         (WebKitLegacyBrowserWindow::showLayerTree):
1499         (WebKitLegacyBrowserWindow::print):
1500         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1501         (WebKitLegacyBrowserWindow::privatePreferences):
1502         * MiniBrowser/win/WinMain.cpp:
1503         (wWinMain):
1504         * MiniBrowser/win/stdafx.h:
1505
1506 2019-09-19  Joanmarie Diggs  <jdiggs@igalia.com>
1507
1508         [GTK] Dependency hunspell-en-gb cannot be found on Fedora 30
1509         https://bugs.webkit.org/show_bug.cgi?id=202009
1510
1511         Update package name to hunspell-en-GB.
1512
1513         Reviewed by Carlos Alberto Lopez Perez.
1514
1515         * gtk/install-dependencies:
1516
1517 2019-09-19  Jonathan Bedard  <jbedard@apple.com>
1518
1519         results.webkit.org: Collapse results with the same version name
1520         https://bugs.webkit.org/show_bug.cgi?id=201779
1521
1522         Rubber-stamped by Aakash Jain.
1523
1524         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1525         (Configuration.prototype.const.ending.this.version_name.substring):
1526         (Configuration.prototype.toKey): Prefer version_name over version number in key.
1527         (Configuration.prototype.compare): version_name comparison should always override version comparison.
1528         (Configuration.prototype.compareSDKs): Make SDK regex global.
1529         (Configuration.prototype.toParams): Remove E tag on version_name.
1530         (Configuration): Append E tag on the version_name based on the SDK.
1531         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1532         (TimelineFromEndpoint.prototype.toString): Print version number with SDK.
1533
1534 2019-09-19  Ryan Haddad  <ryanhaddad@apple.com>
1535
1536         REGRESSION: [iOS 13?] TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments is failing
1537         https://bugs.webkit.org/show_bug.cgi?id=201902
1538
1539         Unreviewed test gardening.
1540
1541         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Disable the test on iOS.
1542
1543 2019-09-19  Aakash Jain  <aakash_jain@apple.com>
1544
1545         [ews] Fix platform for JSC EWS
1546         https://bugs.webkit.org/show_bug.cgi?id=201997
1547
1548         Reviewed by Jonathan Bedard.
1549
1550         * BuildSlaveSupport/ews-build/config.json:
1551
1552 2019-09-19  Brent Fulgham  <bfulgham@apple.com>
1553
1554         Create InjectedBundle SPI to better support NSSecureCoding
1555         https://bugs.webkit.org/show_bug.cgi?id=201810
1556         <rdar://problem/55265713>
1557
1558         The encoding/decoding routines used by WebKit’s InjectedBundles are based on NSCoding.
1559         While we have changed WebKit internals to use NSSecureCoding, there are a number of
1560         injected bundles that need to serialize custom classes between the InjectedBundle and
1561         the relevant WebKit UIProcess.
1562
1563         We need to lock down this communications channel by enforcing NSSecureCoding.
1564
1565         This patch creates new SPI to allow the UIProcess to specify classes that it will accept
1566         in messages from the WebContet Process (and Injected Bundle).
1567
1568         It adds the following property to the WKProcessPoolConfiguration:
1569
1570             @property (nonatomic, copy) NSSet<Class> *customClassesForParameterCoder;
1571
1572         If no custom classes are specified, the standard serialization primitives are supported:
1573             NSArray, NSData, NSDate, NSDictionary, NSNull, NSNumber, NSSet, NSString,
1574             NSTimeZone, NSURL, and NSUUID.
1575
1576         Reviewed by Brady Eidson.
1577
1578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1579         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegate.mm: Added.
1580         (-[BundleFormDelegateRemoteObject didGetFocus]):
1581         (-[FormInputDelegate _webView:decidePolicyForFocusedElement:]):
1582         (TEST):
1583         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegatePlugIn.mm: Added.
1584         (-[BundleFormDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1585         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:willBeginInputSessionForElement:inFrame:userIsInteracting:]):
1586         (-[BundleFormDelegatePlugIn _webProcessPlugInBrowserContextController:didFocusTextField:inFrame:]):
1587         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegateProtocol.h: Copied from Tools/TestWebKitAPI/WKWebViewConfigurationExtras.h.
1588         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1589         (TEST):
1590         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1591         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1592         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
1593         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:andCustomParameterClasses:]):
1594
1595 2019-09-18  Zhifei Fang  <zhifei_fang@apple.com>
1596
1597         [results.webkit.org] fix missing col classes
1598         https://bugs.webkit.org/show_bug.cgi?id=201949
1599
1600         Reviewed by Jonathan Bedard.
1601
1602         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1603         (@media screen and (min-width: 768px)):
1604         (.row):
1605         (.col-1):
1606         (.col-2):
1607         (.col-3):
1608         (.col-4):
1609         (.col-5):
1610         (.col-6):
1611         (.col-7):
1612         (.col-8):
1613         (.col-9):
1614         (.col-10):
1615         (.col-11):
1616         (.col-12):
1617         (@media screen and (min-width: 600px)):
1618
1619 2019-09-18  Ryan Haddad  <ryanhaddad@apple.com>
1620
1621         Update flakiness dashboard configuration for iOS 13 queues
1622         https://bugs.webkit.org/show_bug.cgi?id=201711
1623
1624         Reviewed by Jonathan Bedard.
1625
1626         * TestResultServer/static-dashboards/builders.jsonp:
1627
1628 2019-09-18  Adrian Perez de Castro  <aperez@igalia.com>
1629
1630         [WPE][GTK] Update build environments to use libwpe+WPEBackend-fdo 1.4.0
1631         https://bugs.webkit.org/show_bug.cgi?id=201915
1632
1633         Reviewed by Michael Catanzaro.
1634
1635         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.4.0
1636         * gtk/jhbuild.modules: Ditto.
1637         * wpe/jhbuild.modules: Ditto.
1638
1639 2019-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1640
1641         [Win][MiniBrowser] Remove unused DOMDefaultImpl.cpp
1642         https://bugs.webkit.org/show_bug.cgi?id=201867
1643
1644         Reviewed by Darin Adler.
1645
1646         * MiniBrowser/win/CMakeLists.txt: Removed DOMDefaultImpl.cpp.
1647         * MiniBrowser/win/DOMDefaultImpl.cpp: Removed.
1648         * MiniBrowser/win/DOMDefaultImpl.h: Removed.
1649         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1650
1651 2019-09-17  Dean Jackson  <dino@apple.com>
1652
1653         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
1654         https://bugs.webkit.org/show_bug.cgi?id=201864
1655         <rdar://55190038>
1656
1657         Reviewed by Simon Fraser.
1658
1659         Test for the suggested actions.
1660
1661         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1662         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1663         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
1664         (TEST):
1665
1666 2019-09-17  Jonathan Bedard  <jbedard@apple.com>
1667
1668         results.webkit.org results bubbles' tooltips should include SDK information
1669         https://bugs.webkit.org/show_bug.cgi?id=201823
1670
1671         Rubber-stamped by Aakash Jain.
1672
1673         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
1674         (Configuration.prototype.compare): Like the Python instance of this class,
1675         support using null as a wildcard.
1676         (Configuration.prototype.compareSDKs): Ditto.
1677         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1678         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Construct a configuration
1679         object from all bits of data used to construct a given bubble.
1680         (TimelineFromEndpoint.prototype.render):
1681
1682 2019-09-17  Keith Rollin  <krollin@apple.com>
1683
1684         Remove some support for < iOS 12
1685         https://bugs.webkit.org/show_bug.cgi?id=201851
1686         <rdar://problem/55422044>
1687
1688         Reviewed by Jiewen Tan and Alexey Proskuryakov.
1689
1690         Remove some support for iOS versions less than 12.0.
1691
1692         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
1693         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
1694         values >= 120000. This means that expressions like
1695         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101200" are always False and
1696         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101200" are always True.
1697
1698         This removal is part of a series of patches effecting such removal.
1699
1700         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1701         (WTR::installFakeHelvetica):
1702
1703 2019-09-17  David Kilzer  <ddkilzer@apple.com>
1704
1705         run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
1706         <https://webkit.org/b/201873>
1707
1708         Reviewed by Jonathan Bedard.
1709
1710         * Scripts/webkitpy/port/driver.py:
1711         (Driver.run_test): Call self.do_post_tests_work() when a test
1712         shard has completed, but didn't crash or time out.
1713
1714 2019-09-17  Chris Dumez  <cdumez@apple.com>
1715
1716         REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
1717         https://bugs.webkit.org/show_bug.cgi?id=201859
1718         <rdar://problem/55426742>
1719
1720         Reviewed by Alex Christensen.
1721
1722         Update API test to use WKWebsiteDataStoreRef C API to do private browsing instead of using
1723         the legacy WKPreferencesSetPrivateBrowsingEnabled() C API.
1724
1725         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1726         (TestWebKitAPI::TEST):
1727
1728 2019-09-17  Ryan Haddad  <ryanhaddad@apple.com>
1729
1730         Bring up queues for iOS 13
1731         https://bugs.webkit.org/show_bug.cgi?id=201710
1732
1733         Reviewed by Jonathan Bedard.
1734
1735         * BuildSlaveSupport/build.webkit.org-config/config.json: Move iOS 12 queues to iOS 13.
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Ditto.
1737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1738         (WebKitBuildbot):
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1740         (table.queue-grid tr.platform.ios-simulator-12 img.logo): Deleted.
1741         (table.queue-grid tr.platform.ios-12 img.logo): Deleted.
1742         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit tests.
1743         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1744         (_should_file_trigger_build):
1745         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1746         (ShouldBuildTest):
1747         (ShouldBuildTest.test_should_build):
1748         * BuildSlaveSupport/ews-build/config.json: Move iOS 12 queues to iOS 13.
1749
1750 2019-09-17  Truitt Savell  <tsavell@apple.com>
1751
1752         Unreviewed, rolling out r249950.
1753
1754         Broke the iOS build.
1755
1756         Reverted changeset:
1757
1758         "Remove the "Show Link Previews" and "Hide Link Previews"
1759         action menus in the preview platter"
1760         https://bugs.webkit.org/show_bug.cgi?id=201864
1761         https://trac.webkit.org/changeset/249950
1762
1763 2019-09-17  Dean Jackson  <dino@apple.com>
1764
1765         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
1766         https://bugs.webkit.org/show_bug.cgi?id=201864
1767         <rdar://55190038>
1768
1769         Reviewed by Simon Fraser.
1770
1771         Test for the suggested actions.
1772
1773         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1774         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1775         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
1776         (TEST):
1777
1778 2019-09-16  Alex Christensen  <achristensen@webkit.org>
1779
1780         Remove "gopher" from list of special schemes in URLParser
1781         https://bugs.webkit.org/show_bug.cgi?id=201852
1782
1783         Reviewed by Simon Fraser.
1784
1785         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1786         (TestWebKitAPI::TEST_F):
1787         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
1788         (TestWebKitAPI::TEST_F):
1789         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1790
1791 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
1792
1793         results.webkit.org: Shard result archives
1794         https://bugs.webkit.org/show_bug.cgi?id=201734
1795
1796         Reviewed by Dewei Zhu.
1797
1798         Cassandra advertises being able to store up to 2 GB in a single blob-storage row.
1799         In practice, this usually doesn't work according to the Cassandra developers,
1800         large blobs should be broken up into shards of, at most, 10 MB.
1801
1802         * resultsdbpy/resultsdbpy/model/archive_context.py:
1803         (ArchiveContext):
1804         (ArchiveContext.ArchiveMetaDataByCommit): Point to the archive shards by hash.
1805         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
1806         (ArchiveContext.ArchiveChunks): Store archive shards, indexed by hash.
1807         (ArchiveContext.__init__):
1808         (ArchiveContext.register): When saving archives, save a reference hash and then
1809         shard the actual archive data before saving.
1810         (ArchiveContext.find_archive): Search for archive by meta-data, then reconstruct
1811         the archive. Raise an exception if we determine that memory usage is a problem.
1812         (ArchiveContext.ArchivesByCommit): Deleted.
1813         (ArchiveContext.ArchivesByCommit.unpack): Deleted.
1814         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py:
1815         (ArchiveContextTest.init_database): Allow configuration and archive to be specified.
1816         (ArchiveContextTest):
1817         (ArchiveContextTest.test_large_archive): Test archive sharding.
1818
1819 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
1820
1821         [WebAuthn] Support more than two FIDO protocol versions
1822         https://bugs.webkit.org/show_bug.cgi?id=198408
1823         <rdar://problem/51292176>
1824
1825         Reviewed by Chris Dumez.
1826
1827         Adds a new test case that includes a FIDO_2_1_PRE version string.
1828
1829         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1830         (TestWebKitAPI::TEST):
1831         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1832
1833 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
1834
1835         results.webkit.org: Configurations should be branch specific
1836         https://bugs.webkit.org/show_bug.cgi?id=201561
1837
1838         Reviewed by Dewei Zhu.
1839
1840         Partition configurations by branch in both Redis and Cassandra.
1841
1842         * resultsdbpy/resultsdbpy/controller/upload_controller.py:
1843         (UploadController.suites): Allow the user to specify branches while listing suites.
1844         * resultsdbpy/resultsdbpy/model/archive_context.py:
1845         (ArchiveContext.register): Register each configuration with a branch.
1846         * resultsdbpy/resultsdbpy/model/configuration_context.py:
1847         (ConfigurationContext.ByPlatform): Index by branch.
1848         (ConfigurationContext.ByPlatformAndVersion): Ditto.
1849         (ConfigurationContext.ByArchitecture): Ditto.
1850         (ConfigurationContext.ByModel): Ditto.
1851         (ConfigurationContext.__init__): Populate Redis cache with branch.
1852         (ConfigurationContext._convert_to_redis_key): Accept branch in Redis key.
1853         (ConfigurationContext._register_in_redis): Register configuration with branch.
1854         (ConfigurationContext.register_configuration): Ditto.
1855         (ConfigurationContext.search_for_configuration): Search for configuration with branch.
1856         (ConfigurationContext.search_for_recent_configuration): Ditto.
1857         (ConfigurationContext.select_from_table_with_configurations): Ditto.
1858         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
1859         (ConfigurationContextTest.register_configurations): Register with branch.
1860         (ConfigurationContextTest.test_repopulate_recent): Construct ConfigurationContext with
1861         CommitContext object.
1862         * resultsdbpy/resultsdbpy/model/upload_context.py:
1863         (UploadContext.SuitesByConfiguration): Index by branch.
1864         (UploadContext.upload_test_results): Register each configuration with a branch.
1865         (UploadContext.find_suites): Pass branch to search for configurations.
1866         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Check for new configurations when the branch is changed.
1867         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add branch to suites query.
1868
1869 2019-09-16  David Kilzer  <ddkilzer@apple.com>
1870
1871         check-webkit-style: Fix warning message for std::make_unique<typename[]>
1872         <https://webkit.org/b/201818>
1873
1874         Reviewed by Darin Adler.
1875
1876         * Scripts/webkitpy/style/checkers/cpp.py:
1877         (check_wtf_make_unique): Emit different error message when using
1878         std::make_unique<>() to create an array.  Personalize the error
1879         message by including the original type name, which also
1880         demonstrates that WTF::makeUniqueArray<>() does not need square
1881         brackets for its typename.
1882         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1883         (WebKitStyleTest.test_wtf_make_unique): Add test.
1884         (WebKitStyleTest.test_wtf_make_unique_array): Ditto.
1885
1886 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
1887
1888         Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
1889         https://bugs.webkit.org/show_bug.cgi?id=201820
1890
1891         Reviewed by Chris Fleizach.
1892
1893         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1894         (AccessibilityUIElement::insertText):
1895         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1896         (AccessibilityUIElement::insertText):
1897         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1898         (WTR::AccessibilityUIElement::insertText):
1899         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1900         (WTR::AccessibilityUIElement::insertText):
1901
1902 2019-09-16  David Kilzer  <ddkilzer@apple.com>
1903
1904         Fix leaks in DumpRenderTree and WebKitTestRunner
1905         <https://webkit.org/b/201814>
1906
1907         Reviewed by Darin Adler.
1908
1909         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1910         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
1911         Add CF_RETURNS_RETAINED to document behavior.
1912         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1913         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
1914
1915         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1916         (takeWindowSnapshot): Add CF_RETURNS_RETAINED to document
1917         behavior.
1918         (createBitmapContextFromWebView): Fix leak of CGImageRef when
1919         generating a replacement image.
1920
1921         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Add @dynamic
1922         declaration for _stableStateOverride so compiler wouldn't try to
1923         create another instance variable for it.
1924
1925         * WebKitTestRunner/mac/EventSenderProxy.mm:
1926         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1927         Release `cgEvent` to fix leak.
1928
1929 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
1930
1931         Expose misspelling ranges for editable content to accessibility clients.
1932         https://bugs.webkit.org/show_bug.cgi?id=201752
1933         <rdar://problem/49556828>
1934
1935         Reviewed by Chris Fleizach.
1936
1937         Test code needed for LayoutTests/accessibility/misspelling-range.html.
1938         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1939         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1940         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1941         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
1942         (WTR::AccessibilityUIElement::indexForTextMarker):
1943         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1944         (WTR::misspellingSearchParameterizedAttributeForCriteria):
1945         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
1946
1947 2019-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1948
1949         REGRESSION(r249142): [GTK] Epiphany delayed page loads continue indefinitely
1950         https://bugs.webkit.org/show_bug.cgi?id=201544
1951
1952         Reviewed by Michael Catanzaro.
1953
1954         Add new test cases.
1955
1956         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1957         (testWebViewActiveURI):
1958         (testWebViewIsLoading):
1959         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1960         (loadChangedCallback):
1961         (LoadTrackingTest::loadAlternateHTML):
1962         (LoadTrackingTest::reset):
1963         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h:
1964
1965 2019-09-15  David Kilzer  <ddkilzer@apple.com>
1966
1967         block-spammers should obtain credentials the same way as webkit-patch
1968         <https://webkit.org/b/201733>
1969
1970         Reviewed by Lucas Forschler.
1971
1972         * Scripts/block-spammers: Import Credentials from webkitpy.
1973         Remove unused imports.  Enable logging at info level to match
1974         webkit-patch.
1975         (get_bugzilla_token): Use Credentials module to get
1976         bugs.webkit.org credentials.
1977         * Scripts/webkitpy/common/net/credentials.py:
1978         (Credentials._run_security_tool): Change logging level from
1979         error to info since multiple attempts are made at reading the
1980         keychain.  Fix typos in comment.
1981         (Credentials._credentials_from_security_command): Extract common
1982         logic from Credentials._credentials_from_keychain into new
1983         method.
1984         (Credentials._credentials_from_keychain): Make fallback logic
1985         for checking for credentials in the keychain more consistent and
1986         easier to read.  Add error logging if no credentials are found.
1987
1988 2019-09-13  Youenn Fablet  <youenn@apple.com>
1989
1990         WPT importer should check META global tag in .any.js files to generate the valid .html stub files
1991         https://bugs.webkit.org/show_bug.cgi?id=201718
1992
1993         Reviewed by Chris Dumez.
1994
1995         Read meta tag information to select the environments where the any.js template tests will be run.
1996         Added support to run service worker tests from any.js template tests.
1997
1998         Covered by unit test.
1999         Since we import only a single repository nowadays, use a test config file with just one repository
2000         to simplify the new test.
2001
2002         * Scripts/webkitpy/w3c/test_importer.py:
2003         (TestImporter.__init__):
2004         (TestImporter.readEnvironmentsForTemplateTest):
2005         (TestImporter.write_html_files_for_templated_js_tests):
2006         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2007         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
2008         (TestImporterTest.test_import_dir_with_no_tests):
2009         (TestImporterTest.test_import_dir_with_empty_init_py):
2010         (TestImporterTest.test_harnesslinks_conversion):
2011         (TestImporterTest.test_submodules_generation):
2012         (test_checkout_directory):
2013         (test_clean_directory_option):
2014         (test_git_ignore_generation):
2015         (test_initpy_generation):
2016         (test_remove_obsolete_content):
2017         (test_manual_slow_test):
2018         (test_webkit_test_runner_options):
2019         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
2020         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
2021         (test_template_test):
2022
2023 2019-09-13  Dean Jackson  <dino@apple.com>
2024
2025         Provide a prototype for AR QuickLook to trigger processing in the originating page
2026         https://bugs.webkit.org/show_bug.cgi?id=201371
2027         <rdar://54904781>
2028
2029         Disable the test for the moment.
2030
2031         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
2032         (TestWebKitAPI::TEST):
2033
2034 2019-09-11  Dean Jackson  <dino@apple.com>
2035
2036         Provide a prototype for AR QuickLook to trigger processing in the originating page
2037         https://bugs.webkit.org/show_bug.cgi?id=201371
2038         <rdar://54904781>
2039
2040         Reviewed by Simon Fraser.
2041
2042         * TestWebKitAPI/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
2043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2044         * TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: Added.
2045
2046 2019-09-13  Youenn Fablet  <youenn@apple.com>
2047
2048         Partition processes running service workers by session ID
2049         https://bugs.webkit.org/show_bug.cgi?id=201643
2050
2051         Reviewed by Chris Dumez.
2052
2053         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2054
2055 2019-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
2056
2057         Re-add myself to the list of committers
2058
2059         Unreviewed.
2060
2061         * Scripts/webkitpy/common/config/contributors.json:
2062
2063 2019-09-13  Alex Christensen  <achristensen@webkit.org>
2064
2065         [iOS] TestWebKitAPI.WebKit.TLSVersionWebSocket is a flaky failure
2066         https://bugs.webkit.org/show_bug.cgi?id=201745
2067
2068         Reviewed by Chris Dumez.
2069
2070         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2071         (TestWebKitAPI::TEST):
2072         The exact message isn't important.  The fact that the TLS handshake failed is, which is checked by the TCPServer.
2073
2074 2019-09-13  Patrick Griffis  <pgriffis@igalia.com>
2075
2076         [JHBuild] Fix building gst-plugins-good against glibc 2.30
2077         https://bugs.webkit.org/show_bug.cgi?id=201715
2078
2079         Reviewed by Xabier Rodriguez-Calvar.
2080
2081         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Added.
2082
2083 2019-09-12  Chris Dumez  <cdumez@apple.com>
2084
2085         [WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
2086         https://bugs.webkit.org/show_bug.cgi?id=201546
2087
2088         Reviewed by Alex Christensen.
2089
2090         Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() from WebKitTestRunner as it does not do
2091         the right thing for WebKit2 and tests have been rewritten to not use it.
2092
2093         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2094         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2095         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED): Deleted.
2096         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2097
2098 2019-09-12  Brady Eidson  <beidson@apple.com>
2099
2100         PDF exporting on iOS should include URL rects.
2101         <rdar://problem/54900133> and https://bugs.webkit.org/show_bug.cgi?id=201693
2102
2103         Reviewed by Tim Horton.
2104
2105         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2106         (TestWebKitAPI::TEST): Enable on iOS.
2107
2108 2019-09-12  Adrian Perez de Castro  <aperez@igalia.com>
2109
2110         [GTK][WPE] webkit_settings_set_user_agent() allows content forbidden in HTTP headers
2111         https://bugs.webkit.org/show_bug.cgi?id=201077
2112
2113         Reviewed by Carlos Garcia Campos.
2114
2115         * TestWebKitAPI/CMakeLists.txt: Add missing HTTPParsers.cpp to be built into TestWebCore.
2116         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
2117         (TestWebKitAPI::TEST): Add tests for WebCore::isValidUserAgentHeaderValue().
2118
2119 2019-09-12  Mark Lam  <mark.lam@apple.com>
2120
2121         Harden JSC against the abuse of runtime options.
2122         https://bugs.webkit.org/show_bug.cgi?id=201597
2123         <rdar://problem/55167068>
2124
2125         Reviewed by Filip Pizlo.
2126
2127         Linux parts contributed by Carlos Garcia Campos <cgarcia@igalia.com>.
2128         Windows parts contributed by Fujii Hironori <Hironori.Fujii@sony.com>.
2129
2130         Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
2131         to disable the hardening on test runs.  Tests rely on setting options to enable
2132         test features.
2133
2134         * DumpRenderTree/mac/DumpRenderTree.mm:
2135         (dumpRenderTree):
2136         * DumpRenderTree/win/DumpRenderTree.cpp:
2137         (initialize):
2138         * TestWebKitAPI/PlatformUtilities.cpp:
2139         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2140         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2141         (main):
2142         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
2143         (TestWebKitAPI::TEST):
2144         (TestWebKitAPI::runActiveSessionTest):
2145         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2146         (TEST):
2147         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2148         (TEST):
2149         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
2150         (TestWebKitAPI::TEST):
2151         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2152         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2153         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
2154         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
2155         * WebKitTestRunner/TestController.cpp:
2156         (WTR::TestController::generateContextConfiguration const):
2157
2158 2019-09-12  Keith Rollin  <krollin@apple.com>
2159
2160         Fix PDFKit references in TestWebKitAPI
2161         https://bugs.webkit.org/show_bug.cgi?id=201700
2162         <rdar://problem/55279539>
2163
2164         Reviewed by Youenn Fablet.
2165
2166         These references fail in watchOS and tvOS, so remove them on those
2167         platforms.
2168
2169         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2171         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2172         * TestWebKitAPI/cocoa/TestPDFDocument.h:
2173         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
2174         * TestWebKitAPI/config.h:
2175
2176 2019-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2177
2178         [Win][MiniBrowser] Select all text in the URL bar by clicking it
2179         https://bugs.webkit.org/show_bug.cgi?id=201677
2180
2181         Reviewed by Don Olmstead.
2182
2183         * MiniBrowser/win/MainWindow.cpp:
2184         (EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.
2185
2186 2019-09-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2187
2188         [GTK][WPE] Stop using the session bus in the unit tests
2189         https://bugs.webkit.org/show_bug.cgi?id=201636
2190
2191         Reviewed by Žan Doberšek.
2192
2193         We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
2194         use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
2195         the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
2196         test. The server address is passed to the web extension as initialization parameter to connect directly to
2197         it. We keep a global list of connections to the server and a HashMap to get the current active connection for
2198         a WebKitWebView.
2199
2200         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2201         (beforeAll):
2202         (afterAll):
2203         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2204         (testProcessPerWebView):
2205         (beforeAll):
2206         (afterAll):
2207         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2208         (testWebExtensionGetTitle):
2209         (testWebExtensionInputElementIsUserEdited):
2210         (testDocumentLoadedSignal):
2211         (testWebKitWebViewProcessCrashed):
2212         (testWebExtensionIsolatedWorld):
2213         (testInstallMissingPluginsPermissionRequest):
2214         (testWebExtensionFormControlsAssociated):
2215         (FormSubmissionTest::FormSubmissionTest):
2216         (beforeAll):
2217         (afterAll):
2218         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2219         (DelayedSignal::DelayedSignal):
2220         (emitPageCreated):
2221         (pageCreatedCallback):
2222         (webkit_web_extension_initialize_with_user_data):
2223         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2224         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2225         (AccessibilityTest::AccessibilityTest):
2226         (AccessibilityTest::ensureProxy):
2227         (beforeAll):
2228         (afterAll):
2229         * TestWebKitAPI/glib/CMakeLists.txt:
2230         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2231         (dbusConnectionClosed):
2232         (dbusServerConnection):
2233         (startDBusServer):
2234         (stopDBusServer):
2235         (main):
2236         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2237         (Test::initializeWebExtensions):
2238         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
2239         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
2240         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2241         (WebViewTest::~WebViewTest):
2242         (WebViewTest::extensionProxy):
2243         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2244
2245 2019-09-10  Dean Jackson  <dino@apple.com>
2246
2247         setup-git-clone is using http not https
2248         https://bugs.webkit.org/show_bug.cgi?id=201658
2249
2250         Reviewed by Sam Weinig.
2251
2252         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2253         (SetupGitClone.execute):
2254
2255 2019-09-10  Matt Lewis  <jlewis3@apple.com>
2256
2257         run-webkit-test: Allow results to be uploaded without scm checkout
2258         https://bugs.webkit.org/show_bug.cgi?id=200787
2259
2260         Reviewed by Jonathan Bedard.
2261
2262         * Scripts/webkitpy/common/checkout/scm/detection.py:
2263         (SCMDetector.detect_scm_system): Added in detection of stub repository.
2264         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
2265         (StubRepository):
2266         (StubRepository.__init__):
2267         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
2268         find the directory containing the checkout_information.json of the stub repository.
2269         (StubRepository.in_working_directory): Required functions to be implemented.
2270         (StubRepository.svn_revision): Required functions to be implemented.
2271         (StubRepository.native_revision): Required functions to be implemented.
2272         (StubRepository.native_branch): Required functions to be implemented.
2273         (StubRepository._decode_json): Decodes checkout_information.json.
2274         (StubRepository.find_checkout_root): Required functions to be implemented.
2275         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
2276         (StubRepositoryTest): Unit test for stub_repository SCM.
2277         (StubRepositoryTest.mock_host_for_stub_repository):
2278         (StubRepositoryTest.test_in_working_directory):
2279         (StubRepositoryTest.test_native_revision):
2280         (StubRepositoryTest.test_native_branch):
2281         (StubRepositoryTest.test_svn_revision):
2282         (StubRepositoryTest.test_find_checkout_root):
2283         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2284         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
2285         * Scripts/webkitpy/port/base.py:
2286         (Port.commits_for_upload): Removed unnecessary scm initialization.
2287
2288 2019-09-10  Brady Eidson  <beidson@apple.com>
2289
2290         Add SPI to save a PDF from the contents of a WKWebView.
2291         <rdar://problem/48955900> and https://bugs.webkit.org/show_bug.cgi?id=195765
2292
2293         Reviewed by Tim Horton.
2294
2295         -Add an "Export to PDF..." menu option to MiniBrowser.
2296         -Add API tests for the API itself.
2297
2298         * MiniBrowser/MiniBrowser.entitlements:
2299
2300         * MiniBrowser/mac/BrowserWindowController.h:
2301         * MiniBrowser/mac/BrowserWindowController.m:
2302         (-[BrowserWindowController forceRepaint:]):
2303         (-[BrowserWindowController saveAsPDF:]):
2304
2305         * MiniBrowser/mac/MainMenu.xib:
2306
2307         * MiniBrowser/mac/WK1BrowserWindowController.m:
2308         (-[WK1BrowserWindowController validateMenuItem:]):
2309         * MiniBrowser/mac/WK2BrowserWindowController.m:
2310         (-[WK2BrowserWindowController validateMenuItem:]):
2311         (-[WK2BrowserWindowController saveAsPDF:]):
2312
2313         * TestWebKitAPI/Configurations/Base.xcconfig:
2314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2315         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.
2316         (TestWebKitAPI::TEST):
2317         * TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
2318         * TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.
2319         (TestWebKitAPI::toCGRect):
2320         (TestWebKitAPI::toPlatformPoint):
2321         (TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
2322         (TestWebKitAPI::TestPDFAnnotation::isLink const):
2323         (TestWebKitAPI::TestPDFAnnotation::bounds const):
2324         (TestWebKitAPI::TestPDFAnnotation::linkURL const):
2325         (TestWebKitAPI::TestPDFPage::create):
2326         (TestWebKitAPI::TestPDFPage::TestPDFPage):
2327         (TestWebKitAPI::TestPDFPage::annotations):
2328         (TestWebKitAPI::TestPDFPage::characterCount const):
2329         (TestWebKitAPI::TestPDFPage::text const):
2330         (TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
2331         (TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
2332         (TestWebKitAPI::TestPDFPage::bounds const):
2333         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
2334         (TestWebKitAPI::TestPDFDocument::createFromData):
2335         (TestWebKitAPI::TestPDFDocument::TestPDFDocument):
2336         (TestWebKitAPI::TestPDFDocument::pageCount const):
2337         (TestWebKitAPI::TestPDFDocument::page):
2338
2339 2019-09-10  Keith Rollin  <krollin@apple.com>
2340
2341         Remove SSL-based TLSDeprecation.mm contents
2342         https://bugs.webkit.org/show_bug.cgi?id=201657
2343         <rdar://problem/55237678>
2344
2345         Reviewed by Alex Christensen.
2346
2347         This file does not build on watchOS due to references to SSL
2348         facilities. Conditionalize out the contents on HAVE_SSL.
2349
2350         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2351
2352 2019-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2353
2354         Unreviewed, remove myself from watchlists
2355
2356         * Scripts/webkitpy/common/config/watchlist:
2357
2358 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2359
2360         Rebase API test after r249675
2361         https://bugs.webkit.org/show_bug.cgi?id=201596
2362
2363         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2364         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2365         We removed the restriction on WebsitePolicies with non-default persistent sessions.
2366         We needed to change the expectations of the test that exercised that code path.
2367
2368 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2369
2370         Fix iOS API tests after r249684
2371         https://bugs.webkit.org/show_bug.cgi?id=201573
2372
2373         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2374         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
2375         (TestWebKitAPI::TEST):
2376         The web thread still exists :(
2377         That makes iOS immediate failure results more like WK2, which is fine.
2378         The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.
2379
2380 2019-09-09  Chris Dumez  <cdumez@apple.com>
2381
2382         REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
2383         https://bugs.webkit.org/show_bug.cgi?id=201550
2384
2385         Reviewed by Alex Christensen.
2386
2387         Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
2388         anything or not.
2389
2390         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2391         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2392         (WTR::InjectedBundle::statisticsNotifyObserver):
2393         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2394         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2395         (WTR::TestRunner::statisticsNotifyObserver):
2396         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2397
2398 2019-09-09  Timothy Hatcher  <timothy@apple.com>
2399
2400         Tap and hold on Facebook sometimes creates a tall empty selection.
2401         https://bugs.webkit.org/show_bug.cgi?id=201618
2402         rdar://53630145
2403
2404         Reviewed by Megan Gardner.
2405
2406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2407         * TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.
2408
2409 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2410
2411         [EWS] Watchlist doesn't work sometimes
2412         https://bugs.webkit.org/show_bug.cgi?id=201433
2413
2414         Reviewed by Michael Catanzaro.
2415
2416         * Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with
2417         corresponding Bugzilla accounts.
2418
2419 2019-09-09  Alex Christensen  <achristensen@webkit.org>
2420
2421         Disable TLS 1.0 and 1.1 in WebSockets
2422         https://bugs.webkit.org/show_bug.cgi?id=201573
2423
2424         Reviewed by Youenn Fablet.
2425
2426         * TestWebKitAPI/SourcesCocoa.txt:
2427         * TestWebKitAPI/TCPServer.cpp:
2428         (sk_CRYPTO_BUFFER_num):
2429         (sk_CRYPTO_BUFFER_value):
2430         (TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
2431         (TestWebKitAPI::TCPServer::TCPServer):
2432         (TestWebKitAPI::TCPServer::listenForConnections):
2433         (TestWebKitAPI::deleter<X509>::operator()): Deleted.
2434         (TestWebKitAPI::deleter<uint8_t::operator()): Deleted.
2435         * TestWebKitAPI/TCPServer.h:
2436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2437         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.
2438         (-[WebSocketDelegate waitForMessage]):
2439         (-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2440         (TestWebKitAPI::TEST):
2441         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2442         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2443         (-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2444         (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
2445
2446 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2447
2448         [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
2449         https://bugs.webkit.org/show_bug.cgi?id=201600
2450
2451         Reviewed by Brent Fulgham.
2452
2453         There were some circular references between
2454         WebKitLegacyBrowserWindow and its delegation classes. For
2455         example, WebKitLegacyBrowserWindow has a reference of
2456         WebDownloadDelegate, and WebDownloadDelegate shares the ref
2457         counter with WebKitLegacyBrowserWindow.
2458
2459         WebNotificationObserver was leaked because it wasn't unregistered
2460         from the default notification center by using
2461         IWebNotificationCenter::removeObserver.
2462
2463         If a new legacy window was created by mouse right click a link,
2464         WebView was released twice because
2465         PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
2466         WebView.
2467
2468         This change does:
2469         1. Make delegation classes have own ref-counter to avoid circular references
2470         2. Do removeObserver notification observers
2471         3. AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest
2472
2473         * MiniBrowser/win/AccessibilityDelegate.cpp:
2474         (AccessibilityDelegate::AddRef):
2475         (AccessibilityDelegate::Release):
2476         * MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
2477         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2478         (MiniBrowserWebHost::QueryInterface):
2479         (MiniBrowserWebHost::AddRef):
2480         (MiniBrowserWebHost::Release):
2481         * MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
2482         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2483         (PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
2484         (PrintWebUIDelegate::AddRef):
2485         (PrintWebUIDelegate::Release):
2486         * MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
2487         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2488         (ResourceLoadDelegate::AddRef):
2489         (ResourceLoadDelegate::Release):
2490         * MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
2491         * MiniBrowser/win/WebDownloadDelegate.cpp:
2492         (WebDownloadDelegate::AddRef):
2493         (WebDownloadDelegate::Release):
2494         * MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
2495         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2496         (WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
2497         (WebKitLegacyBrowserWindow::init):
2498         (WebKitLegacyBrowserWindow::setUIDelegate):
2499         (WebKitLegacyBrowserWindow::setAccessibilityDelegate):
2500         (WebKitLegacyBrowserWindow::setResourceLoadDelegate):
2501         (WebKitLegacyBrowserWindow::setDownloadDelegate):
2502         (WebKitLegacyBrowserWindow::AddRef): Deleted.
2503         (WebKitLegacyBrowserWindow::Release): Deleted.
2504         (WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
2505         (WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.
2506         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2507
2508 2019-09-09  Chris Dumez  <cdumez@apple.com>
2509
2510         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
2511         https://bugs.webkit.org/show_bug.cgi?id=201596
2512
2513         Reviewed by Alex Christensen.
2514
2515         Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
2516         test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
2517         do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
2518         the WebCore::Document think it changed session.
2519
2520         * DumpRenderTree/TestRunner.cpp:
2521         (setShouldSwapToEphemeralSessionOnNextNavigationCallback):
2522         (setShouldSwapToDefaultSessionOnNextNavigationCallback):
2523         (TestRunner::staticFunctions):
2524         (TestRunner::willNavigate):
2525         * DumpRenderTree/TestRunner.h:
2526         (TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
2527         (TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
2528         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2529         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2530         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2531         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2532         (WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
2533         (WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
2534         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2535         * WebKitTestRunner/TestController.cpp:
2536         (WTR::TestController::decidePolicyForNavigationAction):
2537         * WebKitTestRunner/TestController.h:
2538         (WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
2539         (WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):
2540         * WebKitTestRunner/TestInvocation.cpp:
2541         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2542
2543 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2544
2545         EWS testtube emoji doesn't exist on macOS Mojave
2546         https://bugs.webkit.org/show_bug.cgi?id=201532
2547
2548         Reviewed by Simon Fraser.
2549
2550         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2551         (StatusBubble): Change the emoji to microscope emoji.
2552
2553 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
2554
2555         [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
2556         https://bugs.webkit.org/show_bug.cgi?id=201607
2557
2558         Reviewed by Jonathan Bedard.
2559
2560         * BuildSlaveSupport/ews-build/steps.py:
2561         (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
2562         (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
2563
2564 2019-09-07  Keith Miller  <keith_miller@apple.com>
2565
2566         OSR entry into wasm misses some contexts
2567         https://bugs.webkit.org/show_bug.cgi?id=201569
2568
2569         Reviewed by Yusuke Suzuki.
2570
2571         Add new test harness mode for tests created from wast files.
2572
2573         * Scripts/run-jsc-stress-tests:
2574
2575 2019-09-09  Daniel Bates  <dabates@apple.com>
2576
2577         Remove all selection view animations before dumping results
2578         https://bugs.webkit.org/show_bug.cgi?id=199241
2579
2580         Reviewed by Wenson Hsieh.
2581
2582         On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
2583         historical tests that were written for Mac and expect Mac's lack of animations that we run on
2584         iOS and are flaky. Let's try to remove all selection view animations before dumping results and
2585         see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
2586         API for a test to remove selection animations at any time during the run.
2587
2588         * WebKitTestRunner/ios/TestControllerIOS.mm:
2589         (WTR::TestController::notifyDone):
2590
2591 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
2592
2593         run-webkit-tests: Report results archive to results.webkit.org
2594         https://bugs.webkit.org/show_bug.cgi?id=201321
2595
2596         Reviewed by Aakash Jain.
2597
2598         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2599         (Manager.run): After all tests are finish, upload the results archive for each
2600         configuration.
2601         * Scripts/webkitpy/results/upload.py:
2602         (Upload):
2603         (Upload.__init__): Automatically define timestamp.
2604         (Upload.upload_archive): Upload an archive associated with the test run.
2605         * Scripts/webkitpy/results/upload_unittest.py:
2606         (UploadTest.test_buildbot):
2607         (UploadTest):
2608         (UploadTest.test_archive_upload):
2609
2610 2019-09-09  Chris Dumez  <cdumez@apple.com>
2611
2612         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
2613         https://bugs.webkit.org/show_bug.cgi?id=201590
2614
2615         Reviewed by Youenn Fablet.
2616
2617         Add a new API test to check that if the default session registers a service worker, the
2618         hasServiceWorkerRegistration flag is still false in an ephemeral session.
2619
2620         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2621
2622 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
2623
2624         results.webkit.org: mobile-sidebar-control should override button
2625         https://bugs.webkit.org/show_bug.cgi?id=201566
2626
2627         Rubber-stamped by Aakash Jain.
2628
2629         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2630         (@media screen and (min-width: 600px)):
2631         (.mobile-sidebar-control):
2632         (.mobile-sidebar-control.display):
2633
2634 2019-09-07  Chris Dumez  <cdumez@apple.com>
2635
2636         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
2637         https://bugs.webkit.org/show_bug.cgi?id=201574
2638
2639         Reviewed by Alex Christensen.
2640
2641         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that
2642         we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which
2643         does not work well for WK2.
2644
2645         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2646
2647 2019-09-07  Chris Dumez  <cdumez@apple.com>
2648
2649         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
2650         https://bugs.webkit.org/show_bug.cgi?id=201547
2651
2652         Reviewed by Alex Christensen.
2653
2654         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so
2655         it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED()
2656         hack.
2657
2658         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2659         (-[LocalStorageNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2660         (-[LocalStorageNavigationDelegate webView:didFinishNavigation:]):
2661         (TEST):
2662
2663 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2664
2665         Remove WebsiteDataStore::legacyDefaultDataStoreConfiguration
2666         https://bugs.webkit.org/show_bug.cgi?id=200054
2667
2668         Reviewed by Carlos Garcia Campos.
2669
2670         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2671         This test relied on the default data store having been instantiated.
2672
2673 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2674
2675         Remove calls to WKContextGetWebsiteDataStore missed in r249614
2676         https://bugs.webkit.org/show_bug.cgi?id=200050
2677
2678         * WebKitTestRunner/TestController.cpp:
2679         (WTR::TestController::resetPreferencesToConsistentValues):
2680         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2681         * WebKitTestRunner/TestInvocation.cpp:
2682         (WTR::TestInvocation::invoke):
2683
2684 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2685
2686         Remove invalid assertion added in r249614
2687         https://bugs.webkit.org/show_bug.cgi?id=200050
2688
2689         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2690         (WTR::TestController::cocoaResetStateToConsistentValues):
2691         Something is instantiating the default data store, which is no problem right now.
2692
2693 2019-09-07  Ryan Haddad  <ryanhaddad@apple.com>
2694
2695         Unreviewed, rolling out r249353.
2696
2697         The test for this change is a flaky failure.
2698
2699         Reverted changeset:
2700
2701         "Add support for postMessage buffering between the service
2702         worker and window"
2703         https://bugs.webkit.org/show_bug.cgi?id=201169
2704         https://trac.webkit.org/changeset/249353
2705
2706 2019-09-07  Alex Christensen  <achristensen@webkit.org>
2707
2708         Deprecate WKContextGetWebsiteDataStore
2709         https://bugs.webkit.org/show_bug.cgi?id=200050
2710
2711         Reviewed by Geoff Garen.
2712
2713         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2714         (WebKitBrowserWindow::updateProxySettings):
2715         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2716         * WebKitTestRunner/TestController.cpp:
2717         (WTR::TestController::generateContextConfiguration const):
2718         (WTR::TestController::websiteDataStore):
2719         (WTR::TestController::generatePageConfiguration):
2720         (WTR::TestController::resetStateToConsistentValues):
2721         (WTR::TestController::platformAdjustContext):
2722         (WTR::TestController::clearServiceWorkerRegistrations):
2723         (WTR::TestController::clearDOMCache):
2724         (WTR::TestController::clearDOMCaches):
2725         (WTR::TestController::ClearIndexedDatabases):
2726         (WTR::TestController::hasDOMCache):
2727         (WTR::TestController::domCacheSize):
2728         (WTR::TestController::setStatisticsDebugMode):
2729         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2730         (WTR::TestController::setStatisticsLastSeen):
2731         (WTR::TestController::setStatisticsPrevalentResource):
2732         (WTR::TestController::setStatisticsVeryPrevalentResource):
2733         (WTR::TestController::dumpResourceLoadStatistics):
2734         (WTR::TestController::isStatisticsPrevalentResource):
2735         (WTR::TestController::isStatisticsVeryPrevalentResource):
2736         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2737         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2738         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2739         (WTR::TestController::setStatisticsHasHadUserInteraction):
2740         (WTR::TestController::isStatisticsHasHadUserInteraction):
2741         (WTR::TestController::setStatisticsGrandfathered):
2742         (WTR::TestController::isStatisticsGrandfathered):
2743         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2744         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2745         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2746         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2747         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2748         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2749         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2750         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2751         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2752         (WTR::TestController::statisticsUpdateCookieBlocking):
2753         (WTR::TestController::statisticsSubmitTelemetry):
2754         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2755         (WTR::TestController::setStatisticsIsRunningTest):
2756         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2757         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2758         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2759         (WTR::TestController::setStatisticsGrandfatheringTime):
2760         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2761         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2762         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2763         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2764         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2765         (WTR::TestController::statisticsDeleteCookiesForHost):
2766         (WTR::TestController::isStatisticsHasLocalStorage):
2767         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2768         (WTR::TestController::statisticsResetToConsistentState):
2769         (WTR::TestController::setWebAuthenticationMockConfiguration):
2770         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2771         * WebKitTestRunner/TestController.h:
2772         * WebKitTestRunner/TestInvocation.cpp:
2773         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2774         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2775         (WTR::initializeWebViewConfiguration):
2776
2777 2019-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2778
2779         Incorrect selection rect revealed after pasting images in a contenteditable element
2780         https://bugs.webkit.org/show_bug.cgi?id=201549
2781         <rdar://problem/50956429>
2782
2783         Reviewed by Simon Fraser.
2784
2785         Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
2786         directly written to the pasteboard.
2787
2788         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2789
2790 2019-09-06  Matt Lewis  <jlewis3@apple.com>
2791
2792         Unreviewed, rolling out r249582.
2793
2794         This caused results.html fail to be created on internal
2795         testers.
2796
2797         Reverted changeset:
2798
2799         "run-webkit-test: Allow results to be uploaded without scm
2800         checkout"
2801         https://bugs.webkit.org/show_bug.cgi?id=200787
2802         https://trac.webkit.org/changeset/249582
2803
2804 2019-09-06  Aakash Jain  <aakash_jain@apple.com>
2805
2806         [ews-app] Status bubble should only display important messages in pop-over - part 2
2807         https://bugs.webkit.org/show_bug.cgi?id=201557
2808
2809         Reviewed by Jonathan Bedard.
2810
2811         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2812         (StatusBubble): Add few more strings to STEPS_TO_HIDE.
2813
2814 2019-09-06  Alex Christensen  <achristensen@webkit.org>
2815
2816         Deprecate all WKCookieManagerRef functions
2817         https://bugs.webkit.org/show_bug.cgi?id=201473
2818
2819         Reviewed by Chris Dumez.
2820
2821         Adopt replacement C API in WebKitTestRunner.
2822
2823         * TestWebKitAPI/CMakeLists.txt:
2824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2825         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
2826         * WebKitTestRunner/TestController.cpp:
2827         (WTR::TestController::resetPreferencesToConsistentValues):
2828         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2829         * WebKitTestRunner/TestInvocation.cpp:
2830         (WTR::TestInvocation::invoke):
2831         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2832         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2833         (WTR::initializeWebViewConfiguration):
2834
2835 2019-09-06  Tim Horton  <timothy_horton@apple.com>
2836
2837         Marking up a note on iOS results in a PDF with no contents
2838         https://bugs.webkit.org/show_bug.cgi?id=201530
2839         <rdar://problem/53686019>
2840
2841         Reviewed by Andy Estes.
2842
2843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2844         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
2845         Add some tests for WKWebViewPrintFormatter; specifically that it is
2846         possible to _recalcPageCount twice in quick succession, and that
2847         we don't hang if we start painting the printed content immediately
2848         after a Web Content process crash.
2849
2850 2019-09-06  Matt Lewis  <jlewis3@apple.com>
2851
2852         run-webkit-test: Allow results to be uploaded without scm checkout
2853         https://bugs.webkit.org/show_bug.cgi?id=200787
2854
2855         Reviewed by Jonathan Bedard.
2856
2857         * Scripts/webkitpy/common/checkout/scm/detection.py:
2858         (SCMDetector.detect_scm_system): Added in detection of stub repository.
2859         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
2860         (StubRepository):
2861         (StubRepository.__init__):
2862         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
2863         find the directory containing the checkout_information.json of the stub repository.
2864         (StubRepository.in_working_directory): Required functions to be implemented.
2865         (StubRepository.svn_revision): Required functions to be implemented.
2866         (StubRepository.native_revision): Required functions to be implemented.
2867         (StubRepository.native_branch): Required functions to be implemented.
2868         (StubRepository._decode_json): Decodes checkout_information.json.
2869         (StubRepository.find_checkout_root): Required functions to be implemented.
2870         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
2871         (StubRepositoryTest): Unit test for stub_repository SCM.
2872         (StubRepositoryTest.mock_host_for_stub_repository):
2873         (StubRepositoryTest.test_in_working_directory):
2874         (StubRepositoryTest.test_native_revision):
2875         (StubRepositoryTest.test_native_branch):
2876         (StubRepositoryTest.test_svn_revision):
2877         (StubRepositoryTest.test_find_checkout_root):
2878         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2879         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
2880         * Scripts/webkitpy/port/base.py:
2881         (Port.commits_for_upload): Removed unnecessary scm initialization.
2882
2883 2019-09-06  Alex Christensen  <achristensen@webkit.org>
2884
2885         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
2886         https://bugs.webkit.org/show_bug.cgi?id=201480
2887
2888         Reviewed by Youenn Fablet.
2889
2890         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2891         (WTR::InjectedBundle::beginTesting):
2892         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2893         (WTR::TestRunner::setPrivateBrowsingEnabled):
2894
2895 2019-09-06  Rob Buis  <rbuis@igalia.com>
2896
2897         Add runtime flag for lazy image loading
2898         https://bugs.webkit.org/show_bug.cgi?id=199794
2899
2900         Reviewed by Frédéric Wang.
2901
2902         Remove parts of r248409 that were meant for WK1 since
2903         lazy image loading is WK2 only.
2904
2905         * DumpRenderTree/TestOptions.cpp:
2906         (TestOptions::TestOptions):
2907         * DumpRenderTree/TestOptions.h:
2908         * DumpRenderTree/mac/DumpRenderTree.mm:
2909         (enableExperimentalFeatures):
2910         (setWebPreferencesForTestOptions):
2911         * DumpRenderTree/win/DumpRenderTree.cpp:
2912         (enableExperimentalFeatures):
2913
2914 2019-09-05  Chris Dumez  <cdumez@apple.com>
2915
2916         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
2917         https://bugs.webkit.org/show_bug.cgi?id=201519
2918
2919         Reviewed by Alex Christensen.
2920
2921         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
2922         as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
2923         TestOption::useEphemeralSession flag based on the test folder.
2924
2925         * DumpRenderTree/mac/DumpRenderTree.mm:
2926         (shouldUseEphemeralSession):
2927         (runTest):
2928         * WebKitTestRunner/TestOptions.cpp:
2929         (WTR::shouldUseEphemeralSession):
2930         (WTR::TestOptions::TestOptions):
2931
2932 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
2933
2934         [Win] Support Per-Monitor (V2) DPI Awareness
2935         https://bugs.webkit.org/show_bug.cgi?id=201450
2936
2937         Reviewed by Don Olmstead.
2938
2939         * MiniBrowser/win/MainWindow.cpp:
2940         (MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.
2941         * MiniBrowser/win/WinMain.cpp:
2942         (wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.
2943
2944 2019-09-05  Chris Dumez  <cdumez@apple.com>
2945
2946         REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
2947         https://bugs.webkit.org/show_bug.cgi?id=201440
2948         <rdar://problem/54998427>
2949
2950         Reviewed by Alex Christensen.
2951
2952         Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
2953         This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
2954         created in the WebContent process is the one that is currently running the test and that we want to talk to.
2955         Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.
2956
2957         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2958         (WTR::InjectedBundle::page const):
2959
2960 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2961
2962         results.webkit.org: Assign notifyRerender before calling
2963         https://bugs.webkit.org/show_bug.cgi?id=201510
2964
2965         Reviewed by Aakash Jain.
2966
2967         Timelines should define notifyRerender to an empty function,
2968         rename notifiyRerender to notifyRerender.
2969
2970         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2971         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2972         * resultsdbpy/resultsdbpy/view/templates/search.html:
2973         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2974
2975 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2976
2977         results.webkit.org: Fix prepending search result on empty list 
2978         https://bugs.webkit.org/show_bug.cgi?id=201512
2979
2980         Reviewed by Aakash Jain.
2981
2982         * resultsdbpy/resultsdbpy/view/templates/search.html:
2983
2984 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
2985
2986         results.webkit.org: Retain certain parameters when following menu links
2987         https://bugs.webkit.org/show_bug.cgi?id=201463
2988
2989         Rubber-stamped by Aakash Jain.
2990
2991         * resultsdbpy/resultsdbpy/view/site_menu.py:
2992         (SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.
2993         * resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,
2994         retain the specified parameters
2995         * resultsdbpy/resultsdbpy/view/view_routes.py:
2996         (ViewRoutes.__init__):
2997
2998 2019-09-05  Chris Dumez  <cdumez@apple.com>
2999
3000         [WK2] Add proper layout test support for ephemeral sessions
3001         https://bugs.webkit.org/show_bug.cgi?id=201475
3002
3003         Reviewed by Antti Koivisto.
3004
3005         Add proper layout test support for ephemeral sessions via:
3006         <!-- webkit-test-runner [ useEphemeralSession=true ] -->
3007
3008         This actually creates a new WebView using an ephemeral data store to load the test which
3009         is *true* private browsing.
3010
3011         testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
3012         process, which is a hack and does not truly enable private browsing because the UIProcess and
3013         the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
3014         to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
3015         get rid of it.
3016
3017         Note that WK2 does not support using a WebContent process for different sessions / data stores.
3018         Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
3019         is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
3020         simply to support testRunner.setPrivateBrowsingEnabled().
3021
3022         * DumpRenderTree/TestOptions.cpp:
3023         (TestOptions::TestOptions):
3024         * DumpRenderTree/TestOptions.h:
3025         * DumpRenderTree/TestRunner.cpp:
3026         (TestRunner::staticFunctions):
3027         * DumpRenderTree/mac/DumpRenderTree.mm:
3028         (setWebPreferencesForTestOptions):
3029         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3030         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3031         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):
3032         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3033         * WebKitTestRunner/TestController.cpp:
3034         (WTR::TestController::generatePageConfiguration):
3035         (WTR::updateTestOptionsFromTestHeader):
3036         * WebKitTestRunner/TestOptions.h:
3037         (WTR::TestOptions::hasSameInitializationOptions const):
3038         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3039         (WTR::TestController::platformCreateWebView):
3040
3041 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
3042
3043         REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
3044         https://bugs.webkit.org/show_bug.cgi?id=201490
3045
3046         Reviewed by Daniel Bates.
3047
3048         Added a test.
3049
3050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3051         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3052         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.
3053
3054 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
3055
3056         Remove unused SPI that accesses MemoryCache directly
3057         https://bugs.webkit.org/show_bug.cgi?id=201468
3058
3059         Reviewed by Youenn Fablet.
3060
3061         Removed the API test.
3062
3063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3064         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.
3065
3066 2019-09-04  Timothy Hatcher  <timothy@apple.com>
3067
3068         Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
3069         https://bugs.webkit.org/show_bug.cgi?id=201368
3070         rdar://problem/40529867
3071
3072         Reviewed by Ryosuke Niwa.
3073
3074         Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
3075             PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
3076
3077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3078         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3079         (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
3080         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
3081         (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
3082         * TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
3083         * TestWebKitAPI/cocoa/TestWKWebView.h:
3084         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3085         (-[TestWKWebView forceDarkMode]):
3086
3087 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3088
3089         MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
3090         https://bugs.webkit.org/show_bug.cgi?id=201479
3091         <rdar://problem/51511834>
3092
3093         Reviewed by Tim Horton.
3094
3095         Add a test to verify that the UI process doesn't crash when invoking `_share:` while there's no selection.
3096
3097         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3098         * TestWebKitAPI/ios/UIKitSPI.h:
3099
3100 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3101
3102         -[WKContentView selectedText] returns an empty string when selecting more than 200 characters
3103         https://bugs.webkit.org/show_bug.cgi?id=201471
3104         <rdar://problem/55039227>
3105
3106         Reviewed by Tim Horton.
3107
3108         Add an API test to ensure that -selectedText is non-empty in the case where more than 200 characters are
3109         selected.
3110
3111         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3112         (TestWebKitAPI::TEST):
3113         * TestWebKitAPI/ios/UIKitSPI.h:
3114
3115 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
3116
3117         results.webkit.org: Fix mobile vs desktop mode
3118         https://bugs.webkit.org/show_bug.cgi?id=201441
3119
3120         Rubber-stamped by Aakash Jain.
3121
3122         We should unconditionally use desktop mode if the device screen-width
3123         is large enough.
3124
3125         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3126
3127 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
3128
3129         run-api-tests: Add support for specifying additional environment variables
3130         https://bugs.webkit.org/show_bug.cgi?id=201311
3131         <rdar://problem/54852698>
3132
3133         Reviewed by Daniel Bates.
3134
3135         * Scripts/webkitpy/api_tests/run_api_tests.py:
3136         (parse_args): Add --additional-env-var flag.
3137         * Scripts/webkitpy/port/base.py:
3138         (Port._append_value_colon_separated): Use os.pathsep instead of ':'.
3139         (Port.environment_for_api_tests): Add the values from --additional-env-var to the
3140         environment.
3141
3142 2019-09-04  Aakash Jain  <aakash_jain@apple.com>
3143
3144         EWS bubbles should indicate builder vs tester
3145         https://bugs.webkit.org/show_bug.cgi?id=201253
3146
3147         Reviewed by Jonathan Bedard.
3148
3149         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3150         (StatusBubble._build_bubble): Add icons to the bubbles appropriately.
3151         (StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
3152         (StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
3153         (StatusBubble.get):
3154         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3155         (Buildbot.fetch_config): Method to fetch the config from Buildbot server.
3156         (Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.
3157         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3158         (FetchLoop.run): Update the icons for queues mapping.
3159         * BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
3160         * BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
3161         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: .
3162         (test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.
3163
3164 2019-09-03  Yusuke Suzuki  <ysuzuki@apple.com>
3165
3166         [bmalloc] IsoTLSLayout and AllIsoHeaps registration is racy with derived class initialization with virtual functions
3167         https://bugs.webkit.org/show_bug.cgi?id=201448
3168
3169         Reviewed by Mark Lam.
3170
3171         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3172         (TEST):
3173
3174 2019-09-03  Dean Jackson  <dino@apple.com>
3175
3176         Test for ContextMenus with images
3177         https://bugs.webkit.org/show_bug.cgi?id=201437
3178
3179         Reviewed by Wenson Hsieh.
3180
3181         Add a test for ContextMenus that trigger on images, and make
3182         sure that they ask for alternate URLs (added in r249171).
3183
3184         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3185         (contextMenuWebViewDriver):
3186         (-[TestContextMenuImageUIDelegate _webView:contextMenuConfigurationForElement:completionHandler:]):
3187         (-[TestContextMenuImageUIDelegate _webView:alternateURLFromImage:userInfo:]):
3188         (-[TestContextMenuImageUIDelegate webView:contextMenuWillPresentForElement:]):
3189         (-[TestContextMenuImageUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
3190         (-[TestContextMenuImageUIDelegate webView:contextMenuDidEndForElement:]):
3191         (TEST):
3192
3193 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
3194
3195         results.webkit.org: Move legend into sidebar
3196         https://bugs.webkit.org/show_bug.cgi?id=201258
3197
3198         Rubber-stamped by Aakash Jain.
3199
3200         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: 
3201         (Legend): Make the legend vertical instead of horizontal, add ToolTip to dots in the legend.
3202         * resultsdbpy/resultsdbpy/view/static/js/tooltip.css: Add left and right tooltip arrows.
3203         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
3204         (isPointInElement): Make bound check include borders.
3205         (_ToolTip.toString): Add left/right cases.
3206         (_ToolTip.prototype.setByElement): Set the tooltip location given an element.
3207         * resultsdbpy/resultsdbpy/view/templates/search.html: Put the legend into the sidebar.
3208         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
3209
3210 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
3211
3212         results.webkit.org: Increase default limit for LimitSlider
3213         https://bugs.webkit.org/show_bug.cgi?id=201424
3214
3215         Reviewed by Aakash Jain.
3216
3217         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
3218         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
3219
3220 2019-09-03  Antoine Quint  <graouts@apple.com>
3221
3222         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
3223         https://bugs.webkit.org/show_bug.cgi?id=201420
3224         <rdar://problem/53207786>
3225
3226         Reviewed by Simon Fraser.
3227
3228         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
3229         -[HIDEventGenerator twoFingerTap:completionBlock:].
3230
3231         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3232         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3233         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
3234         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3235         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3236         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
3237
3238 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
3239
3240         [WPE] MiniBrowser should handle the WebKitWebView::create signal
3241         https://bugs.webkit.org/show_bug.cgi?id=201417
3242
3243         Reviewed by Carlos Garcia Campos.
3244
3245         WPE's MiniBrowser should connect to and handle the
3246         WebKitWebView::create signal, constructing a new bit related
3247         WebKitWebView object upon invocation.
3248
3249         * MiniBrowser/wpe/main.cpp:
3250         (webViewClose):
3251         (createWebView):
3252         (main):
3253
3254 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
3255
3256         [WPE] Make view backends multi-view-friendly
3257         https://bugs.webkit.org/show_bug.cgi?id=201415
3258
3259         Reviewed by Carlos Garcia Campos.
3260
3261         Have the Wayland EGL connection for WindowViewBackend instances managed
3262         through a per-process singleton, allowing multiple backend objects
3263         use it for different views. HeadlessViewBackend already does this, but
3264         the code there is refurbished into a singleton structure.
3265
3266         The ViewBackend classes are adjusted to work with the backend-specific
3267         EGLDisplay objects (as constructed through the backend-specific EGL
3268         connection approach).
3269
3270         * wpe/backends/HeadlessViewBackend.cpp:
3271         (WPEToolingBackends::HeadlessEGLConnection::singleton):
3272         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
3273         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
3274         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
3275         (WPEToolingBackends::getEGLDisplay): Deleted.
3276         * wpe/backends/ViewBackend.cpp:
3277         (WPEToolingBackends::ViewBackend::initialize):
3278         (WPEToolingBackends::ViewBackend::deinitialize):
3279         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
3280         * wpe/backends/ViewBackend.h:
3281         * wpe/backends/WindowViewBackend.cpp:
3282         (WPEToolingBackends::WaylandEGLConnection::singleton):
3283         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
3284         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
3285         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3286
3287 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3288
3289         [WPE][GTK] Deprecate nonfunctional process limit APIs
3290         https://bugs.webkit.org/show_bug.cgi?id=193749
3291
3292         Reviewed by Žan Doberšek.
3293
3294         * MiniBrowser/gtk/main.c:
3295         (main):
3296         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3297         (beforeAll):
3298         (testWebProcessLimit): Deleted.
3299
3300 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
3301
3302         [WPE] WindowBackend should do resizing properly
3303         https://bugs.webkit.org/show_bug.cgi?id=201386
3304
3305         Reviewed by Carlos Garcia Campos.
3306
3307         The WindowBackend implementation is resized via the XDG protocol. The
3308         initial size is stored for the object's lifetime and fallen back to when
3309         the XDG protocol reports (0,0) configuration size.
3310
3311         Upon each resize, we have to recreate the texture. We also have to size
3312         the GL viewport accordingly.
3313
3314         * wpe/backends/WindowViewBackend.cpp:
3315         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
3316         (WPEToolingBackends::WindowViewBackend::createViewTexture):
3317         (WPEToolingBackends::WindowViewBackend::resize):
3318         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3319         * wpe/backends/WindowViewBackend.h:
3320
3321 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
3322
3323         Unreviewed, rolling out r249366.
3324
3325         WinCairo WebKit2 crashes in some websites and the device scale
3326         factor is not correct in high DPI.
3327
3328         Reverted changeset:
3329
3330         "[WinCairo, FTW] Properly handle device scale factor"
3331         https://bugs.webkit.org/show_bug.cgi?id=201361
3332         https://trac.webkit.org/changeset/249366
3333
3334 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3335
3336         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
3337         https://bugs.webkit.org/show_bug.cgi?id=201346
3338         <rdar://problem/54885784>
3339
3340         Reviewed by Dean Jackson.
3341
3342         Add a new test option to allow tests to disable link previews.
3343
3344         * WebKitTestRunner/TestController.cpp:
3345         (WTR::updateTestOptionsFromTestHeader):
3346         * WebKitTestRunner/TestOptions.h:
3347
3348         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
3349
3350         (WTR::TestOptions::hasSameInitializationOptions const):
3351         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3352         (WTR::TestController::platformCreateWebView):
3353
3354 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
3355
3356         [WinCairo, FTW] Properly handle device scale factor
3357         https://bugs.webkit.org/show_bug.cgi?id=201361
3358
3359         Reviewed by Don Olmstead.
3360
3361         Reset zoom to 1.0; device scale is handled elsewhere.
3362
3363         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3364         (WebKitBrowserWindow::resetZoom):
3365
3366 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
3367
3368         [results.webkit.org Timeline] Add notify rerender API for timeline
3369         https://bugs.webkit.org/show_bug.cgi?id=201363
3370
3371         Reviewed by Jonathan Bedard.
3372
3373         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
3374         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3375         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render 
3376         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
3377         (prototype.Timeline.CanvasContainer):
3378
3379 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
3380
3381         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
3382         https://bugs.webkit.org/show_bug.cgi?id=201350
3383
3384         Reviewed by Jonathan Bedard.
3385
3386         * BuildSlaveSupport/ews-build/steps.py:
3387         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
3388         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
3389
3390 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
3391
3392         results.webkit.org: Add endpoints to upload and download archives
3393         https://bugs.webkit.org/show_bug.cgi?id=201100
3394
3395         Reviewed by Aakash Jain.
3396
3397         Add the endpoint to upload and download a zip archive associated with a test run.
3398
3399         * resultsdbpy/resultsdbpy/controller/api_routes.py:
3400         (APIRoutes.__init__): Add archive endpoint.
3401         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
3402         (ArchiveController):
3403         (ArchiveController.__init__):
3404         (ArchiveController.endpoint):
3405         (ArchiveController.download):
3406         (ArchiveController.upload):
3407         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
3408         (ArchiveControllerUnittest):
3409         * resultsdbpy/resultsdbpy/model/configuration_context.py:
3410         (ClusteredByConfiguration.register_configuration): Make error message more clear.
3411
3412 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
3413
3414         Add system tracing points for compositing updates, and touch-event dispatching
3415         https://bugs.webkit.org/show_bug.cgi?id=201327
3416
3417         Reviewed by Alex Christensen.
3418
3419         * Tracing/SystemTracePoints.plist:
3420
3421 2019-08-30  Keith Rollin  <krollin@apple.com>
3422
3423         Simplify PLATFORM expression
3424         https://bugs.webkit.org/show_bug.cgi?id=201286
3425         <rdar://problem/54822347>
3426
3427         Reviewed by Alexey Proskuryakov.
3428
3429         The preprocessor expression conditionalizing the inclusion of the body
3430         of ExitFullscreenOnEnterPiP.mm evolved into:
3431
3432             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
3433
3434         Simplify this to just:
3435
3436             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
3437
3438         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3439
3440 2019-08-30  Keith Rollin  <krollin@apple.com>
3441
3442         Remove AppKitCompatibilityDeclarations.h
3443         https://bugs.webkit.org/show_bug.cgi?id=201283
3444         <rdar://problem/54822042>
3445
3446         Reviewed by Alexey Proskuryakov.
3447
3448         The two copies of these files -- on in WTF, one in MiniBrowser -- are
3449         empty and can be removed.
3450
3451         * DumpRenderTree/mac/EventSendingController.mm:
3452         * DumpRenderTree/mac/TextInputControllerMac.m:
3453         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
3454         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3455         * MiniBrowser/mac/SettingsController.m:
3456         * MiniBrowser/mac/WK1BrowserWindowController.m:
3457         * MiniBrowser/mac/WK2BrowserWindowController.m:
3458         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
3459         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3460         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3461         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3462         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
3463         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
3464         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3465         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3466         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3467         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
3468         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3469         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3470         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
3471         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3472         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3473         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3474         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3475         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3476         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3477         * WebKitTestRunner/mac/EventSenderProxy.mm:
3478         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3479         * WebKitTestRunner/mac/TestControllerMac.mm:
3480
3481 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
3482
3483         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
3484         https://bugs.webkit.org/show_bug.cgi?id=200479
3485
3486         Reviewed by Carlos Garcia Campos.
3487
3488         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3489         (testUserContentManagerContentFilter): Test also the new
3490         webkit_user_content_manager_remove_filter_by_id() public API function.
3491
3492 2019-08-30  Philippe Normand  <pnormand@igalia.com>
3493
3494         [WPE][Qt] loadingChanged signal parameter is unusable
3495         https://bugs.webkit.org/show_bug.cgi?id=201301
3496
3497         Reviewed by Carlos Garcia Campos.
3498
3499         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
3500         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
3501         readablity/parameter_name code styl checker rule.
3502
3503 2019-08-29  Keith Rollin  <krollin@apple.com>
3504
3505         Update .xcconfig symbols to reflect the current set of past and future product versions.
3506         https://bugs.webkit.org/show_bug.cgi?id=200720
3507         <rdar://problem/54305032>
3508
3509         Reviewed by Alex Christensen.
3510
3511         Remove version symbols related to old OS's we no longer support,
3512         ensure that version symbols are defined for OS's we do support.
3513
3514         * ContentExtensionTester/Configurations/Base.xcconfig:
3515         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3516         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3517         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3518         * ImageDiff/cg/Configurations/Base.xcconfig:
3519         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3520         * MiniBrowser/Configurations/Base.xcconfig:
3521         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3522         * TestWebKitAPI/Configurations/Base.xcconfig:
3523         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3524         * WebEditingTester/Configurations/Base.xcconfig:
3525         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3526         * WebKitTestRunner/Configurations/Base.xcconfig:
3527         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3528         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3529         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
3530
3531 2019-08-29  Keith Rollin  <krollin@apple.com>
3532
3533         Remove empty FontCache.cpp file in TestWebKitAPI
3534         https://bugs.webkit.org/show_bug.cgi?id=201277
3535         <rdar://problem/54820726>
3536
3537         Reviewed by Alex Christensen.
3538
3539         Bug 200694 emptied out the contents of FontCache.cpp. This patch
3540         removes the file from the project.
3541
3542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3543         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
3544
3545 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
3546
3547         [ews-app] Status bubble should only display important messages in pop-over
3548         https://bugs.webkit.org/show_bug.cgi?id=201308
3549
3550         Reviewed by Jonathan Bedard.
3551
3552         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
3553         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
3554
3555 2019-08-29  Keith Rollin  <krollin@apple.com>
3556
3557         Remove support for macOS < 10.13 (part 3)
3558         https://bugs.webkit.org/show_bug.cgi?id=201224
3559         <rdar://problem/54795934>
3560
3561         Reviewed by Darin Adler.
3562
3563         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
3564         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
3565         like _MACOS_SINCE_1013.
3566
3567         Also added some macOS target numbers.
3568
3569         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
3570
3571 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
3572
3573         results.webkit.org: Remove border from tooltip
3574         https://bugs.webkit.org/show_bug.cgi?id=201239
3575
3576         Reviewed by Alex Christensen.
3577
3578         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
3579         (.tooltip-content): Remove border.
3580
3581 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3582
3583         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
3584         https://bugs.webkit.org/show_bug.cgi?id=201215
3585
3586         Reviewed by Don Olmstead.
3587
3588         MiniBrowser crashed if it was going to go to a unreachable page