Resource Load Statistics: Grandfather domains for existing data records
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-18  John Wilander  <wilander@apple.com>
2
3         Resource Load Statistics: Grandfather domains for existing data records
4         https://bugs.webkit.org/show_bug.cgi?id=172155
5         <rdar://problem/24913532>
6
7         Reviewed by Alex Christensen.
8
9         Adds test infrastructure needed for the added functionality.
10
11         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
13         (WTR::InjectedBundle::didReceiveMessageToPage):
14         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
15         (WTR::TestRunner::setStatisticsGrandfathered):
16         (WTR::TestRunner::isStatisticsGrandfathered):
17         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
18         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
19         (WTR::TestRunner::setStatisticsGrandfatheringTime):
20         * WebKitTestRunner/InjectedBundle/TestRunner.h:
21         * WebKitTestRunner/TestController.cpp:
22         (WTR::TestController::setStatisticsGrandfathered):
23         (WTR::TestController::isStatisticsGrandfathered):
24         (WTR::TestController::setStatisticsGrandfatheringTime):
25         * WebKitTestRunner/TestController.h:
26         * WebKitTestRunner/TestInvocation.cpp:
27         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
28
29 2017-05-18  Saam Barati  <sbarati@apple.com>
30
31         WebAssembly: perform stack checks
32         https://bugs.webkit.org/show_bug.cgi?id=165546
33         <rdar://problem/29760307>
34
35         Reviewed by Filip Pizlo.
36
37         Add some new testing modes for using and not using fast TLS wasm contexts.
38
39         * Scripts/run-jsc-stress-tests:
40
41 2017-05-18  Daniel Bates  <dabates@apple.com>
42
43         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
44         window CSP when object-src 'none' is set
45         https://bugs.webkit.org/show_bug.cgi?id=172038
46         <rdar://problem/32258262>
47
48         Reviewed by Andy Estes.
49
50         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
51         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
52
53         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
54         (NPP_New):
55
56 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
57
58         [Win] Many layout tests are failing.
59         https://bugs.webkit.org/show_bug.cgi?id=172286
60
61         Reviewed by Brent Fulgham.
62
63         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
64  
65         * DumpRenderTree/win/TestRunnerWin.cpp:
66         (TestRunner::grantWebNotificationPermission):
67         (TestRunner::denyWebNotificationPermission):
68         (TestRunner::removeAllWebNotificationPermissions):
69         (TestRunner::simulateWebNotificationClick):
70
71 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
72
73         [Win] Remove usage of _snprintf
74         https://bugs.webkit.org/show_bug.cgi?id=172251
75
76         Reviewed by Per Arne Vollan.
77
78         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
79         * MiniBrowser/win/PageLoadTestClient.cpp:
80         (PageLoadTestClient::dumpRunStatistics):
81
82 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
83
84         Unreviewed, rolling out r217014.
85
86         This change caused mac-wk2 LayoutTests to exit early due to
87         crashes.
88
89         Reverted changeset:
90
91         "Resource Load Statistics: Grandfather domains for existing
92         data records"
93         https://bugs.webkit.org/show_bug.cgi?id=172155
94         http://trac.webkit.org/changeset/217014
95
96 2017-05-17  John Wilander  <wilander@apple.com>
97
98         Resource Load Statistics: Grandfather domains for existing data records
99         https://bugs.webkit.org/show_bug.cgi?id=172155
100         <rdar://problem/24913532>
101
102         Reviewed by Alex Christensen.
103
104         Adds test infrastructure needed for the added functionality.
105
106         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
107         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
108         (WTR::InjectedBundle::didReceiveMessageToPage):
109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
110         (WTR::TestRunner::setStatisticsGrandfathered):
111         (WTR::TestRunner::isStatisticsGrandfathered):
112         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
113         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
114         (WTR::TestRunner::setStatisticsGrandfatheringTime):
115         * WebKitTestRunner/InjectedBundle/TestRunner.h:
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::setStatisticsGrandfathered):
118         (WTR::TestController::isStatisticsGrandfathered):
119         (WTR::TestController::setStatisticsGrandfatheringTime):
120         * WebKitTestRunner/TestController.h:
121         * WebKitTestRunner/TestInvocation.cpp:
122         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
123
124 2017-05-17  Alex Christensen  <achristensen@webkit.org>
125
126         Fix ios-simulator API test after r216977
127         https://bugs.webkit.org/show_bug.cgi?id=171987
128
129         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
130         (TEST):
131         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
132         not as urgent as having the rest of this working. Notably the ephemeral part of the
133         test works, so something is just wrong with the persistent part.
134
135 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
136
137         Unreviewed, rolling out r216955.
138
139         This change caused strange behavior with web-platform-tests
140         locally and on EWS.
141
142         Reverted changeset:
143
144         "webkitpy: Start servers before setting-up for testing"
145         https://bugs.webkit.org/show_bug.cgi?id=172176
146         http://trac.webkit.org/changeset/216955
147
148 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
149
150         A URL type is vended for a non-URL plain text string when starting data interaction
151         https://bugs.webkit.org/show_bug.cgi?id=172228
152         <rdar://problem/32166729>
153
154         Reviewed by Andy Estes.
155
156         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
157         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
158         still vended when beginning data interaction on something that resembles a link.
159
160         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
161
162 2017-05-17  David Kilzer  <ddkilzer@apple.com>
163
164         BlobDataFileReference::generateReplacementFile() should use mkstemp()
165         <https://webkit.org/b/172192>
166
167         Reviewed by Brent Fulgham.
168
169         * Scripts/webkitpy/style/checkers/cpp.py:
170         (check_language): Add check for mktemp.
171         (CppChecker): Add 'security/temp_file' category.
172         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
173         (CppStyleTest.test_insecure_temp_file): Add test.
174
175 2017-05-17  Devin Rousso  <drousso@apple.com>
176
177         Unreviewed, change my email.
178
179         * Scripts/webkitpy/common/config/contributors.json:
180
181 2017-05-17  Matt Lewis  <jlewis3@apple.com>
182
183         Unreviewed, rolling out r216974.
184
185         Revision caused consistent timeouts on all platforms.
186
187         Reverted changeset:
188
189         "Add a RuntimeEnabledFeature for display: contents, defaulted
190         to false."
191         https://bugs.webkit.org/show_bug.cgi?id=171984
192         http://trac.webkit.org/changeset/216974
193
194 2017-05-17  Alex Christensen  <achristensen@webkit.org>
195
196         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
197         https://bugs.webkit.org/show_bug.cgi?id=171987
198
199         Reviewed by Brady Eidson.
200
201         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
202         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
203         (TEST):
204
205 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
206
207         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
208         https://bugs.webkit.org/show_bug.cgi?id=171984
209
210         Reviewed by Antti Koivisto.
211
212         * DumpRenderTree/mac/DumpRenderTree.mm:
213         (enableExperimentalFeatures):
214         * WebKitTestRunner/TestController.cpp:
215         (WTR::TestController::resetPreferencesToConsistentValues):
216
217 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
218
219         Fix the build
220
221         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
222         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
223
224 2017-05-16  Tim Horton  <timothy_horton@apple.com>
225
226         PageVisibilityStateWithWindowChanges tests sometimes time out
227         https://bugs.webkit.org/show_bug.cgi?id=172202
228         <rdar://problem/29653266>
229
230         Reviewed by Dean Jackson.
231
232         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
233         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
234         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
235
236 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
237
238         webkitpy: Start servers before setting-up for testing
239         https://bugs.webkit.org/show_bug.cgi?id=172176
240         <rdar://problem/32225538>
241
242         Reviewed by Alexey Proskuryakov.
243
244         On-device testing requires that servers are started before ports set-up their
245         test environments.
246
247         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
248         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
249         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
250         * Scripts/webkitpy/layout_tests/controllers/manager.py:
251         (Manager.__init__): Delay construction of the test runner until we can determine
252         if servers need to be started.
253         (Manager.run): Determine if servers need to be started and construct the test runner.
254         (Manager._run_tests): Move the determination of servers to run into Manager.run.
255
256 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
257
258         Unreviewed, adding myself to contributors.json
259
260         * Scripts/webkitpy/common/config/contributors.json:
261
262 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
263
264         [GTK] Tests that always pass when run alone, but fail in the bots
265         https://bugs.webkit.org/show_bug.cgi?id=168572
266
267         Reviewed by Michael Catanzaro.
268
269         PlatformWebView::viewSupportsOptions() is basically a comparison
270         that checks that the passed options are the ones supported by the
271         web view. There is no reason for them to be implemented for each
272         platform differently. In fact doing so causes issues each time a
273         new option is added, if the corresponding platform implementation
274         is not updated accordingly.
275
276         A consequence of not updating the viewSupportOptions()
277         implementations when new options are added is that tests that need
278         these options might fail if they are executed after a test that
279         didn't need the option, as the webview will be reused even if the
280         option is not supported. This cannot be spotted when running the
281         tests individually. See bug #165133 for other example of the same
282         problem.
283
284         Remove the platform implementations and make the comparison a
285         method of the TestOptions structure, so that the check is in one
286         place. For the time being, only include in the comparison the
287         options that were checked in the mac platform, which seem to be
288         the only ones relevant this far (unless newer ones have also been
289         forgotten).
290
291         * WebKitTestRunner/PlatformWebView.h:
292         (WTR::PlatformWebView::viewSupportsOptions): Use the method
293         defined below.
294         * WebKitTestRunner/TestOptions.h:
295         (WTR::TestOptions::hasSameInitializationOptions): Added.
296         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
297         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
298         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
299         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
300         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
301         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
302         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
303         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
304
305 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
306
307         [JSC] Build testapi in non Apple ports
308         https://bugs.webkit.org/show_bug.cgi?id=172103
309
310         Reviewed by Filip Pizlo.
311
312         Now testapi is drived in JSCOnly, GTK and WPE ports too.
313
314         * Scripts/build-jsc:
315         * Scripts/run-javascriptcore-tests:
316
317 2017-05-15  Youenn Fablet  <youenn@apple.com>
318
319         WPT test importer should not account for slow manual tests
320         https://bugs.webkit.org/show_bug.cgi?id=172127
321
322         Reviewed by Ryosuke Niwa.
323
324         Making sure manual tests are not triggering updating tests-options.json file.
325
326         * Scripts/webkitpy/w3c/test_importer.py:
327         (TestImporter.find_importable_tests):
328         (TestImporter._already_identified_as_resource_file):
329         (TestImporter.update_tests_options):
330         * Scripts/webkitpy/w3c/test_importer_unittest.py:
331         (test_manual_slow_test):
332
333 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
334
335         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
336         https://bugs.webkit.org/show_bug.cgi?id=172142
337
338         Reviewed by Tim Horton.
339
340         * Scripts/webkitpy/xcode/simulator.py:
341         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
342         around runtime identifiers.
343         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
344
345 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
346
347         Update ARES-6 plan file to use the latest version
348         https://bugs.webkit.org/show_bug.cgi?id=172139
349
350         Reviewed by Keith Miller.
351
352         Include r216538.
353
354         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
355
356 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
357
358         Disable Picture In Picture API tests on unsupported platforms.
359         https://bugs.webkit.org/show_bug.cgi?id=172125
360         rdar://problem/32199477
361
362         Reviewed by Simon Fraser.
363
364         The callbacks and allowing picture-in-picture require new SPI.
365
366         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
367
368 2017-05-15  Brady Eidson  <beidson@apple.com>
369
370         [ios-simulator] API test WKWebView.ClearAppCache is failing.
371         https://bugs.webkit.org/show_bug.cgi?id=172120
372
373         Unreviewed test gardening.
374
375         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
376         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
377           Restoring that code fixes this.
378
379 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
380
381         Null deref under WebContentReader::readURL when interacting with a file URL
382         https://bugs.webkit.org/show_bug.cgi?id=172045
383         <rdar://problem/25880647>
384
385         Reviewed by Wenson Hsieh.
386
387         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
388         (TestWebKitAPI::TEST):
389         The text of the file URL is pasted because a textual version of it gets
390         onto the pasteboard. However, this test would have crashed before. Also
391         tests that we don't make an <a>.
392
393 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
394
395         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
396         https://bugs.webkit.org/show_bug.cgi?id=172071
397
398         Reviewed by Alexey Proskuryakov.
399
400         * DumpRenderTree/win/DumpRenderTree.cpp:
401         (resetWebPreferencesToConsistentValues):
402
403 2017-05-14  Chris Dumez  <cdumez@apple.com>
404
405         Drop PassRefPtr class from WTF
406         https://bugs.webkit.org/show_bug.cgi?id=172091
407
408         Reviewed by Alex Christensen.
409
410         Drop API test coverage.
411
412         * TestWebKitAPI/Tests/WTF/Ref.cpp:
413         (TestWebKitAPI::TEST):
414         (TestWebKitAPI::passWithPassRefPtr): Deleted.
415
416 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
417
418         [MediaStream] deviceId constraint doesn't work with getUserMedia
419         https://bugs.webkit.org/show_bug.cgi?id=171877
420         <rdar://problem/31899730>
421
422         Reviewed by Jer Noble.
423
424         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
425         implement the "checkUserMediaPermission" callback.
426         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
427         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
428         (TestWebKitAPI::checkUserMediaPermissionCallback):
429         (TestWebKitAPI::TEST):
430
431         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
432         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
433
434 2017-05-13  Chris Dumez  <cdumez@apple.com>
435
436         Stop using RefPtr::release()
437         https://bugs.webkit.org/show_bug.cgi?id=172074
438
439         Reviewed by Geoffrey Garen.
440
441         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
442         (TestWebKitAPI::TEST):
443
444 2017-05-13  Commit Queue  <commit-queue@webkit.org>
445
446         Unreviewed, rolling out r216808.
447         https://bugs.webkit.org/show_bug.cgi?id=172075
448
449         caused lldb to hang when debugging (Requested by smfr on
450         #webkit).
451
452         Reverted changeset:
453
454         "Use Mach exceptions instead of signals where possible"
455         https://bugs.webkit.org/show_bug.cgi?id=171865
456         http://trac.webkit.org/changeset/216808
457
458 2017-05-12  Alex Christensen  <achristensen@webkit.org>
459
460         Rename WKContentExtension to WKContentRuleList
461         https://bugs.webkit.org/show_bug.cgi?id=172053
462         <rdar://problem/32141005>
463
464         Reviewed by Geoffrey Garen.
465
466         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
467         (WKContentRuleListStoreTest::SetUp):
468         (TEST_F):
469         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
470         (WKContentExtensionStoreTest::SetUp): Deleted.
471         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
472
473 2017-05-12  Keith Miller  <keith_miller@apple.com>
474
475         Use Mach exceptions instead of signals where possible
476         https://bugs.webkit.org/show_bug.cgi?id=171865
477
478         Reviewed by Mark Lam.
479
480         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
481         (runThreadMessageTest):
482         (TEST):
483
484 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
485
486         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
487         https://bugs.webkit.org/show_bug.cgi?id=172048
488         rdar://problem/32163054
489
490         Reviewed by Simon Fraser.
491
492         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
493
494         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
495         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
496         (hasVideoInPictureInPictureDidChange):
497         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
498         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
499         (TestWebKitAPI::TEST):
500
501 2017-05-12  Brady Eidson  <beidson@apple.com>
502
503         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
504         https://bugs.webkit.org/show_bug.cgi?id=172030
505
506         Unreviewed - Test gardening
507
508         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
509         before the test starts.
510
511         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
512         (defaultWebsiteCacheDirectory):
513         (defaultApplicationCacheDirectory):
514         (TEST):
515         (defaultWebsiteDataDirectory): Deleted.
516
517 2017-05-12  David Quesada  <david_quesada@apple.com>
518
519         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
520         https://bugs.webkit.org/show_bug.cgi?id=172000
521         rdar://problem/32144756
522
523         Reviewed by Simon Fraser.
524
525         Added API tests to verify that WKWebView provides the expected value for
526         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
527         inside a scrollview but not clipped, clipped by an ancestor scrollview,
528         clipped by the webview's _enclosingViewForExposedRectComputation)
529
530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
531         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
532         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
533         (TestWebKitAPI::TEST):
534
535 2017-05-12  Brady Eidson  <beidson@apple.com>
536
537         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
538         https://bugs.webkit.org/show_bug.cgi?id=172030
539
540         Unreviewed - Test gardening, in effect...
541
542         More exploration as to why this continues to fail on the bots.
543         
544         This change should give us a smoking gun.
545         
546         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
547         (TEST):
548
549 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
550
551         [GTK] Fix compile warnings in PlatformImageCairo.cpp
552         https://bugs.webkit.org/show_bug.cgi?id=171850
553
554         Reviewed by Michael Catanzaro.
555
556         * ImageDiff/cairo/PlatformImageCairo.cpp:
557         (ImageDiff::PlatformImage::createFromStdin):
558         (ImageDiff::PlatformImage::writeAsPNGToStdout):
559
560 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
561
562         Add UIClient callback for when picture-in-picture is activated.
563         https://bugs.webkit.org/show_bug.cgi?id=172023
564
565         Reviewed by Simon Fraser.
566
567         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
568
569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
570         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
571         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
572         (onLoadedCompletedCallback):
573         (waitUntilOnLoadIsCompleted):
574         (didFinishLoadForFrame):
575         (setHasVideoInPictureInPicture):
576         (TestWebKitAPI::TEST):
577
578 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
579
580         Unreviewed follow-up to r216776.
581
582         * Scripts/webkitpy/port/base.py:
583         (Port.path_to_crash_logs): Raise not implemented.
584         * Scripts/webkitpy/port/test.py:
585         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
586         * Scripts/webkitpy/port/win.py:
587         (WinPort.path_to_crash_logs): Ditto.
588
589 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
590
591         Bot watcher's dashboard shows results links twice sometimes
592         https://bugs.webkit.org/show_bug.cgi?id=172043
593
594         Reviewed by Tim Horton.
595
596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
597         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
598
599 2017-05-12  Brady Eidson  <beidson@apple.com>
600
601         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
602         https://bugs.webkit.org/show_bug.cgi?id=172030
603
604         Unreviewed - Test gardening, in effect...
605
606         This failure is only being seen by the bots.
607         
608         I believe this test is utterly broken in the first place; when it checks the .wal file's
609         size that is not actually an indicator that the records were deleted.
610         
611         But that isn't what's coming up as failure on the bots.
612         
613         This patch is an attempt to:
614         1 - More forcefully clear the Website data directory of leftovers before the test starts.
615         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
616
617         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
618         (defaultWebsiteDataDirectory):
619         (defaultApplicationCacheDirectory):
620         (TEST):
621
622 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
623
624         webkitpy: Pass directory with crash logs into CrashLogs
625         https://bugs.webkit.org/show_bug.cgi?id=172033
626         <rdar://problem/32157616>
627
628         Reviewed by Daniel Bates.
629
630         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
631         the location of crash logs.
632
633         * Scripts/webkitpy/common/system/crashlogs.py:
634         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
635         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
636         generating one.
637         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
638         self._results_directory.
639         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
640         generating one.
641         (CrashLogs._log_directory_darwin): Moved to port.
642         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
643         to the crash log is no longer owned by CrashLogs.
644         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
645         directory for uploading crash logs. Note that crash logs are only supported on Mac
646         and Windows.
647         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
648         * Scripts/webkitpy/port/base.py:
649         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
650         to be in the results directory.
651         * Scripts/webkitpy/port/darwin.py:
652         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
653         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
654         (DarwinPort._get_crash_log): Ditto.
655         * Scripts/webkitpy/port/darwin_testcase.py:
656         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
657         the path to crash logs.
658         * Scripts/webkitpy/port/ios_device.py:
659         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
660         * Scripts/webkitpy/port/ios_device_unittest.py:
661         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
662         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
663         * Scripts/webkitpy/port/mac.py: Ditto.
664         * Scripts/webkitpy/port/test.py:
665         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
666         * Scripts/webkitpy/port/win.py:
667         (WinPort._get_crash_log): Ditto.
668         * Scripts/webkitpy/tool/commands/queries.py:
669         (execute): Construct a port object since this is the object which owns the path to crash logs.
670
671 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
672
673         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
674
675         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
676         URL parameter using the default value "about:blank" when not provided.
677
678         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
679         (testWebViewCreateNavigationData):
680
681 2017-05-11  Youenn Fablet  <youenn@apple.com>
682
683         Allow WPT server to serve specific WebKit test
684         https://bugs.webkit.org/show_bug.cgi?id=171479
685
686         Reviewed by Ryosuke Niwa.
687
688         Adding a new mount point to WPT server.
689         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
690
691         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
692
693         * Scripts/webkitpy/layout_tests/controllers/manager.py:
694         (Manager.__init__):
695         (Manager._is_http_test):
696         (Manager._needs_web_platform_test):
697         (Manager._run_tests):
698         (Manager._is_web_platform_test): Deleted.
699         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
700         (build_routes):
701         (main):
702         * Scripts/webkitpy/port/driver.py:
703         (Driver):
704         (Driver.is_webkit_specific_web_platform_test):
705         (Driver.test_to_uri):
706         (Driver._command_from_driver_input):
707
708 2017-05-11  Brady Eidson  <beidson@apple.com>
709
710         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
711         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
712
713         Reviewed by Andy Estes.
714         Informal review by Maureen Daum.
715
716         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
717         (TEST):
718
719 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
720
721         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
722         https://bugs.webkit.org/show_bug.cgi?id=171989
723
724         Reviewed by Brian Burg.
725
726         * lldb/lldb_webkit.py:
727         (WTFStringImplProvider.get_data8):
728         (WTFStringImplProvider.get_data16):
729         m_data8 and m_data16 are now part of the superclass StringImplShape
730         instead of directly in StringImpl. So first get the shape by getting
731         index 0, and the data properties are the same offset within that.
732
733 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
734
735         Remove Vibration API
736         https://bugs.webkit.org/show_bug.cgi?id=171766
737
738         Rubber-stamped by Alexey Proskuryakov.
739
740         * Scripts/webkitperl/FeatureList.pm:
741
742 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
743
744         Add WPE release bots
745         https://bugs.webkit.org/show_bug.cgi?id=171973
746
747         Reviewed by Žan Doberšek.
748
749         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
750         It also adds a new WPE buildbot category.
751
752         * BuildSlaveSupport/build.webkit.org-config/config.json:
753         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
754         (InstallWpeDependencies):
755         (appendCustomBuildFlags):
756         (Factory.__init__):
757         (loadBuilderConfig):
758         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
759         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
760
761 2017-05-09  Sam Weinig  <sam@webkit.org>
762
763         Remove support for legacy Notifications
764         https://bugs.webkit.org/show_bug.cgi?id=171487
765
766         Reviewed by Jon Lee.
767
768         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
769         (DRTDesktopNotificationPresenter::checkNotificationPermission):
770         * Scripts/webkitperl/FeatureList.pm:
771         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
772         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
773
774 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
775
776         Remove user agent quirk for Slack
777         https://bugs.webkit.org/show_bug.cgi?id=171869
778
779         Reviewed by Carlos Garcia Campos.
780
781         Remove the corresponding test.
782
783         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
784         (TestWebKitAPI::TEST):
785
786 2017-05-10  Commit Queue  <commit-queue@webkit.org>
787
788         Unreviewed, rolling out r216578.
789         https://bugs.webkit.org/show_bug.cgi?id=171920
790
791         Broke the GTK+ build with Wayland enabled (Requested by KaL on
792         #webkit).
793
794         Reverted changeset:
795
796         "[GTK] Bump GTK+ and its dependencies in jhbuild"
797         https://bugs.webkit.org/show_bug.cgi?id=171918
798         http://trac.webkit.org/changeset/216578
799
800 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
801
802         [GTK] Bump GTK+ and its dependencies in jhbuild
803         https://bugs.webkit.org/show_bug.cgi?id=171918
804
805         Reviewed by Carlos Alberto Lopez Perez.
806
807         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
808         (WTR::initializeGtkSettings):
809         * gtk/jhbuild.modules:
810         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
811         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
812
813 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
814
815         [Win] Set CMake args in build-webkit
816         https://bugs.webkit.org/show_bug.cgi?id=171436
817
818         Reviewed by Per Arne Vollan.
819
820         * Scripts/build-webkit:
821
822 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
823
824         ImageDiff: Add CG implementation for new ImageDiff
825         https://bugs.webkit.org/show_bug.cgi?id=170608
826
827         Reviewed Alex Christensen.
828
829         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
830         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
831         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
832         * ImageDiff/CMakeLists.txt:
833         * ImageDiff/Cairo.cmake:
834         * ImageDiff/ImageDiff.cpp:
835         (main):
836         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
837         * ImageDiff/PlatformImage.cpp:
838         * ImageDiff/PlatformImage.h:
839         * ImageDiff/cairo/PlatformImageCairo.cpp:
840         * ImageDiff/cg/ImageDiff.cpp: Removed.
841         * ImageDiff/cg/PlatformImageCG.cpp: Added.
842         (ImageDiff::PlatformImage::createFromStdin):
843         (ImageDiff::PlatformImage::createFromDiffData):
844         (ImageDiff::PlatformImage::PlatformImage):
845         (ImageDiff::PlatformImage::~PlatformImage):
846         (ImageDiff::PlatformImage::width):
847         (ImageDiff::PlatformImage::height):
848         (ImageDiff::PlatformImage::rowBytes):
849         (ImageDiff::PlatformImage::hasAlpha):
850         (ImageDiff::PlatformImage::pixels):
851         (ImageDiff::PlatformImage::writeAsPNGToStdout):
852
853 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
854
855         Enable FTL JIT by default on AArch64
856         https://bugs.webkit.org/show_bug.cgi?id=144039
857
858         Reviewed by Yusuke Suzuki.
859
860         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
861         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
862         as an unsupported FTL platform.
863         * Scripts/webkitdirs.pm:
864         (isARM64): Returns 1 if the determined architecture is 'arm64'.
865         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
866
867 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
868
869         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
870         https://bugs.webkit.org/show_bug.cgi?id=170857
871         <rdar://problem/31635373>
872
873         Reviewed by Aakash Jain.
874
875         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
876         code to search for crash logs.
877
878         * Scripts/webkitpy/port/darwin.py:
879         (DarwinPort._get_crash_log): Moved from MacPort.
880         * Scripts/webkitpy/port/darwin_testcase.py:
881         (DarwinTest.test_get_crash_log): Moved from MacTest.
882         * Scripts/webkitpy/port/ios_device.py:
883         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
884         devices must search for crash-logs remotely.
885         * Scripts/webkitpy/port/ios_simulator.py:
886         (IOSSimulatorPort._get_crash_log): Deleted.
887         * Scripts/webkitpy/port/ios_simulator_unittest.py:
888         (IOSSimulatorTest.test_get_crash_log): Deleted.
889         * Scripts/webkitpy/port/mac.py:
890         (MacPort._get_crash_log): Moved to DarwinPort
891         * Scripts/webkitpy/port/mac_unittest.py:
892         (MacTest.test_get_crash_log): Moved to DarwinTest.
893
894 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
895
896         build ImageDiff with host SDK from Make
897         https://bugs.webkit.org/show_bug.cgi?id=171835
898
899         Reviewed by Alexey Proskuryakov.
900
901         ImageDiff should be built for the default SDK and default architecture when
902         the SDKROOT is set to either iOS device or iOS simulator. Check the
903         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
904
905         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
906         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
907
908 2017-05-09  Matt Lewis  <jlewis3@apple.com>
909
910         Unreviewed, adding myself to contributors.json
911
912         * Scripts/webkitpy/common/config/contributors.json:
913
914 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
915
916         REGRESSION: ImageDiff not building with make
917         https://bugs.webkit.org/show_bug.cgi?id=171788
918
919         Reviewed by Alex Christensen.
920
921         * Makefile: Build ImageDiff for all platforms.
922
923 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
924
925         [Win] ImageDiff isn't built since Bug 168945
926         https://bugs.webkit.org/show_bug.cgi?id=171847
927
928         Reviewed by Alex Christensen.
929
930         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
931         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
932         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
933
934 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
935
936         Upstream the WPE port
937         https://bugs.webkit.org/show_bug.cgi?id=171110
938
939         Reviewed by Alex Christensen.
940
941         webkit-dev thread:
942         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
943
944         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
945         In-file changes removed from this ChangeLog entry for brevity.
946
947         * BuildSlaveSupport/built-product-archive:
948         * BuildSlaveSupport/test-result-archive:
949         * CMakeLists.txt:
950         * ImageDiff/PlatformWPE.cmake: Added.
951         * Scripts/build-dumprendertree:
952         * Scripts/build-webkit:
953         * Scripts/build-webkittestrunner:
954         * Scripts/update-webkit-libs-jhbuild:
955         * Scripts/update-webkitwpe-libs: Added.
956         * Scripts/webkitdirs.pm:
957         * Scripts/webkitperl/FeatureList.pm:
958         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
959         * Scripts/webkitpy/port/factory.py:
960         * Scripts/webkitpy/port/wpe.py: Added.
961         * TestWebKitAPI/PlatformWPE.cmake: Added.
962         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
963         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
964         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
965         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
966         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
967         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
968         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
969         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
970         * WebKitTestRunner/InjectedBundle/TestRunner.h:
971         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
972         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
973         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
974         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
975         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
976         * WebKitTestRunner/PlatformWPE.cmake: Added.
977         * WebKitTestRunner/PlatformWebView.h:
978         * WebKitTestRunner/TestController.cpp:
979         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
980         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
981         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
982         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
983         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
984         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
985         * jhbuild/jhbuild-wrapper:
986         * wpe/generate-inspector-gresource-manifest.py: Added.
987         * wpe/jhbuild.modules: Added.
988         * wpe/jhbuildrc: Added.
989         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
990         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
991         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
992         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
993         * wpe/patches/glib-warning-fix.patch: Added.
994         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
995         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
996         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
997         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
998         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
999
1000 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
1001
1002         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
1003         https://bugs.webkit.org/show_bug.cgi?id=169421
1004         <rdar://problem/30950171>
1005
1006         Reviewed by Tim Horton.
1007
1008         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1009         (createBitmapContextFromWebView): Implement for IOSurface.
1010         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1011         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
1012
1013 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
1014
1015         buildbot: Cleanup simulators after running tests
1016         https://bugs.webkit.org/show_bug.cgi?id=171679
1017
1018         Reviewed by Aakash Jain.
1019
1020         simctl is partitioned for each user. Since kill-old-processes
1021         is run as root, we need to specify the buildbot user when tearing
1022         down simulators between steps.
1023
1024         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1025         (KillOldProcesses): Pass buildbot user to kill-old-processes.
1026         * BuildSlaveSupport/kill-old-processes:
1027         (main): Specify the user for simctl if one has been provided.
1028
1029 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1030
1031         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
1032         https://bugs.webkit.org/show_bug.cgi?id=171681
1033
1034         Reviewed by Carlos Garcia Campos.
1035
1036         * gtk/install-dependencies:
1037
1038 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1039
1040         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
1041
1042         Glib uses now Unicode quotes in error messages.
1043
1044         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1045         (testWebKitConsoleMessageNetworkError):
1046
1047 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1048
1049         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
1050
1051         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
1052         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
1053         characters to the input. Also fix typo in the function name.
1054
1055         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1056         (testWebViewJavaScriptDialogs):
1057
1058 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1059
1060         [GTK] Cannot sign in with new Google sign-in page
1061         https://bugs.webkit.org/show_bug.cgi?id=171770
1062
1063         Unreviewed. This just adds a test.
1064
1065         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1066         (TestWebKitAPI::TEST):
1067
1068 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
1069
1070         [iOS WK2] Make rotation tests more reliable
1071         https://bugs.webkit.org/show_bug.cgi?id=171778
1072
1073         Reviewed by Tim Horton.
1074
1075         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
1076         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
1077         with override layout parameters, and an override orientation, and these caused viewport
1078         size to leak into later tests, and WebCore orientation to not get reset correctly.
1079
1080         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
1081         an override orientation was set, and would never re-register, causing lost orientationchanged
1082         events.
1083
1084         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
1085         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
1086
1087         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
1088         the WebProcess is caught up before proceeding with the test.
1089
1090         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1091         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
1092         * WebKitTestRunner/ios/TestControllerIOS.mm:
1093         (WTR::TestController::platformResetStateToConsistentValues):
1094         (WTR::TestController::platformConfigureViewForTest):
1095
1096 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
1097
1098         [Mac][cmake] Buildfix after r216047
1099         https://bugs.webkit.org/show_bug.cgi?id=171769
1100
1101         Unreviewed buildfix.
1102
1103         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1104
1105 2017-05-05  Brady Eidson  <beidson@apple.com>
1106
1107         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
1108         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
1109
1110         Reviewed by Andy Estes.
1111
1112         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1113         (TEST):
1114
1115 2017-05-05  Brian Burg  <bburg@apple.com>
1116
1117         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
1118         https://bugs.webkit.org/show_bug.cgi?id=171748
1119         <rdar://problem/32027327>
1120
1121         Reviewed by Michael Catanzaro.
1122
1123         Remove temporary workaround now that the assertion failure is fixed.
1124
1125         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1126         (TEST):
1127
1128 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
1129
1130         Make it possible to test rotation in iOS WebKitTestRunner
1131         https://bugs.webkit.org/show_bug.cgi?id=171755
1132
1133         Reviewed by Tim Horton.
1134
1135         Add to UIScriptController:
1136             void simulateRotation(DeviceOrientation orientation, object callback);
1137             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
1138
1139         The former just does a view resize, as a simple WKWebView app would do. The second does
1140         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
1141         layout size and interface orientation. The two behaviors produce different resize and
1142         orientationchange events and sizes, and both need to be tested.
1143
1144         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
1145         which is now a custom subclass (PlatformWebViewController).
1146
1147         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1148         (WTR::UIScriptController::simulateRotation):
1149         (WTR::UIScriptController::simulateRotationLikeSafari):
1150         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1151         (WTR::UIScriptController::simulateRotation):
1152         (WTR::UIScriptController::simulateRotationLikeSafari):
1153         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1154         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1155         (WTR::toDeviceOrientation):
1156         (WTR::UIScriptController::simulateRotation):
1157         (WTR::UIScriptController::simulateRotationLikeSafari):
1158         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1159         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1160         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1161         (-[TestRunnerWKWebView dealloc]):
1162         (-[TestRunnerWKWebView _didEndRotation]):
1163         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1164         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
1165         (WTR::PlatformWebView::PlatformWebView):
1166         * WebKitTestRunner/ios/TestControllerIOS.mm:
1167         (WTR::TestController::platformResetStateToConsistentValues):
1168         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1169         (WTR::toUIDeviceOrientation):
1170         (WTR::UIScriptController::simulateRotation):
1171         (WTR::UIScriptController::simulateRotationLikeSafari):
1172         (WTR::UIScriptController::platformClearAllCallbacks):
1173         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1174         (WTR::UIScriptController::simulateRotation):
1175         (WTR::UIScriptController::simulateRotationLikeSafari):
1176
1177 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1178
1179         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
1180         https://bugs.webkit.org/show_bug.cgi?id=168945
1181         <rdar://problem/30745695>
1182
1183         Reviewed by David Kilzer.
1184
1185         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
1186         target SDK. These two changes must happen simultaneously because some archives will
1187         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
1188
1189         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
1190         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
1191         tools directory still includes ImageDiff.
1192         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
1193         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
1194         * Scripts/webkitpy/port/darwin.py: 
1195         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
1196         locally or when running archives.
1197         * Scripts/webkitpy/port/image_diff.py:
1198         (IOSSimulatorImageDiffer): Deleted.
1199         * Scripts/webkitpy/port/ios_simulator.py:
1200         (IOSSimulatorPort.diff_image): Deleted.
1201
1202 2017-05-05  Brian Burg  <bburg@apple.com>
1203
1204         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
1205         https://bugs.webkit.org/show_bug.cgi?id=171748
1206
1207         Unreviewed test gardening.
1208
1209         The assertion failure will be investigated separately in order to avoid rolling out
1210         the fix for "secure" cookies. This assertion fails even without r216258 applied.
1211
1212         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1213         (TEST):
1214
1215 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1216
1217         Unreviewed, rolling out r216260.
1218
1219         Breaks internal iOS testers
1220
1221         Reverted changeset:
1222
1223         "Use ImageDiff built by host SDK and remove ImageDiff from
1224         DumpRenderTree"
1225         https://bugs.webkit.org/show_bug.cgi?id=168945
1226         http://trac.webkit.org/changeset/216260
1227
1228 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1229
1230         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
1231         https://bugs.webkit.org/show_bug.cgi?id=168945
1232         <rdar://problem/30745695>
1233
1234         Reviewed by David Kilzer.
1235
1236         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
1237         target SDK. These two changes must happen simultaneously because some archives will
1238         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
1239
1240         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
1241         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
1242         tools directory still includes ImageDiff.
1243         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
1244         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
1245         * Scripts/webkitpy/port/darwin.py: 
1246         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
1247         locally or when running archives.
1248         * Scripts/webkitpy/port/image_diff.py:
1249         (IOSSimulatorImageDiffer): Deleted.
1250         * Scripts/webkitpy/port/ios_simulator.py:
1251         (IOSSimulatorPort.diff_image): Deleted.
1252
1253 2017-05-05  Brian Burg  <bburg@apple.com>
1254
1255         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
1256         https://bugs.webkit.org/show_bug.cgi?id=171700
1257         <rdar://problem/32017975>
1258
1259         Reviewed by Brady Eidson.
1260
1261         Fix a mistake in the test that should have caught this bug.
1262
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1264         (TEST):
1265         The assertions that were meant to check round-tripping were actually checking
1266         the properties of the original cookie objects, not the round-tripped ones.
1267         This test now fails without the bugfix and passes when it is applied.
1268
1269 2017-05-05  Daniel Bates  <dabates@apple.com>
1270
1271         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
1272         https://bugs.webkit.org/show_bug.cgi?id=171698
1273
1274         Reviewed by Darin Adler.
1275
1276         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
1277         so that we get pretty diff output when the actual string differs from the expected
1278         string as opposed to seeing a boolean result. The former makes makes it straightforward
1279         to diagnose a regression without reading the code for the test or instrumenting it to
1280         determine the actual string that was compared.
1281
1282         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1283         (TestWebKitAPI::TEST):
1284         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
1285         (TestWebKitAPI::TEST_F):
1286         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
1287         (TestWebKitAPI::TEST_F):
1288
1289 2017-05-05  Chris Dumez  <cdumez@apple.com>
1290
1291         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
1292         https://bugs.webkit.org/show_bug.cgi?id=171624
1293
1294         Reviewed by Dan Bernstein.
1295
1296         Extend API test coverage to cover crashes in addition to terminations requested by the client.
1297
1298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1299         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
1300         (TestWebKitAPI::webProcessWasTerminatedByClient):
1301         (TestWebKitAPI::webProcessCrashed):
1302         (TestWebKitAPI::TEST):
1303
1304 2017-05-04  Mark Lam  <mark.lam@apple.com>
1305
1306         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
1307         https://bugs.webkit.org/show_bug.cgi?id=171716
1308         <rdar://problem/30878027>
1309
1310         Reviewed by Saam Barati.
1311
1312         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
1313         does JS conversion and therefore, potentially JS allocations) and accessing
1314         methods of internal JS data structures (which may do JS invocation, etc).
1315
1316         * DumpRenderTree/TestRunner.cpp:
1317         (setAudioResultCallback):
1318
1319 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1320
1321         buildbot: Cleanup simulators after running tests
1322         https://bugs.webkit.org/show_bug.cgi?id=171679
1323         <rdar://problem/31994361>
1324
1325         Reviewed by Aakash Jain.
1326
1327         We shutdown the simulator process between tests, but in some cases, this is not
1328         sufficient. Explicitly shutdown every booted simulator.
1329
1330         * BuildSlaveSupport/kill-old-processes:
1331         (main): Shutdown all booted simulators.
1332
1333 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1334
1335         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
1336         https://bugs.webkit.org/show_bug.cgi?id=171644
1337
1338         Reviewed by Michael Catanzaro.
1339
1340         Check that only one WebKitWebContext can have automation enabled.
1341
1342         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1343         (testAutomationSessionRequestSession):
1344
1345 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1346
1347         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
1348         https://bugs.webkit.org/show_bug.cgi?id=171724
1349
1350         Reviewed by Michael Catanzaro.
1351
1352         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
1353
1354         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1355         (WTR::timeoutSource):
1356
1357 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1358
1359         Unreviewed. Fix wrong assert after r215176.
1360
1361         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
1362         could also be RGB24 when created from a web view snapshot.
1363
1364         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1365         (WTR::computeMD5HashStringForCairoSurface):
1366
1367 2017-05-04  Brian Burg  <bburg@apple.com>
1368
1369         lldb_webkit.py should provide a type summary for WebCore::URL
1370         https://bugs.webkit.org/show_bug.cgi?id=171670
1371
1372         Reviewed by Jer Noble.
1373
1374         Just print out the underlying string using the WTFString provider.
1375
1376         * lldb/lldb_webkit.py:
1377         (__lldb_init_module):
1378         (WebCoreURL_SummaryProvider):
1379         (WebCoreURLProvider):
1380         (WebCoreURLProvider.__init__):
1381         (WebCoreURLProvider.to_string):
1382
1383 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1384
1385         Unreviewed, rolling out r216206.
1386         https://bugs.webkit.org/show_bug.cgi?id=171714
1387
1388         Multiple LayoutTests crashing in Document::page() (Requested
1389         by ap on #webkit).
1390
1391         Reverted changeset:
1392
1393         "Remove support for legacy Notifications"
1394         https://bugs.webkit.org/show_bug.cgi?id=171487
1395         http://trac.webkit.org/changeset/216206
1396
1397 2017-05-04  Mark Lam  <mark.lam@apple.com>
1398
1399         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
1400         https://bugs.webkit.org/show_bug.cgi?id=171702
1401
1402         Reviewed by Filip Pizlo.
1403
1404         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
1405         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
1406         confirm that the test will detect a regression.  Unfortunately, I forgot to
1407         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
1408         This patch fixes that.
1409
1410         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1411         (TestWebKitAPI::neverDestroyedString):
1412
1413 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
1414
1415         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
1416         https://bugs.webkit.org/show_bug.cgi?id=170195
1417
1418         Unreviewed test gardening.
1419
1420         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1421         (TEST):
1422
1423 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
1424
1425         [Win] Remove redundant macros that are set in the CMake config
1426         https://bugs.webkit.org/show_bug.cgi?id=171571
1427
1428         Reviewed by Brent Fulgham.
1429
1430         * DumpRenderTree/config.h:
1431         * MiniBrowser/win/stdafx.h:
1432         * TestWebKitAPI/config.h:
1433
1434 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1435
1436         Add testRunner.display() to force displaying the web page for testing
1437         https://bugs.webkit.org/show_bug.cgi?id=171694
1438
1439         Reviewed by Simon Fraser.
1440
1441         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
1442         drawing the web page but without track repaints.
1443
1444         * DumpRenderTree/TestRunner.cpp:
1445         (displayCallback):
1446         (TestRunner::staticFunctions):
1447         * DumpRenderTree/TestRunner.h:
1448         * DumpRenderTree/mac/TestRunnerMac.mm:
1449         (TestRunner::display):
1450         * DumpRenderTree/win/TestRunnerWin.cpp:
1451         (TestRunner::display):
1452         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1453         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1454         (WTR::TestRunner::display):
1455         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1456
1457 2017-05-04  Mark Lam  <mark.lam@apple.com>
1458
1459         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
1460         https://bugs.webkit.org/show_bug.cgi?id=171586
1461         <rdar://problem/31873190>
1462
1463         Reviewed by Yusuke Suzuki.
1464
1465         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
1466
1467         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1468         (TestWebKitAPI::neverDestroyedString):
1469         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
1470         (TestWebKitAPI::TEST):
1471
1472 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1473
1474         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
1475         https://bugs.webkit.org/show_bug.cgi?id=171585
1476         <rdar://problem/31544320>
1477
1478         Reviewed by Beth Dakin and Zalan Bujtas.
1479
1480         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
1481         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
1482         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
1483         operation rather than a copy.
1484
1485         See WebCore ChangeLog for more details.
1486
1487         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
1488                 DataInteractionSimulator.ContentEditableToTextarea
1489                 DataInteractionSimulator.ContentEditableMoveParagraphs
1490                 DataInteractionSimulator.TextAreaToInput
1491
1492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1493         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
1494         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1495         (TestWebKitAPI::TEST):
1496         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1497         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1498         (-[DataInteractionSimulator initWithWebView:]):
1499         (-[DataInteractionSimulator dealloc]):
1500         (-[DataInteractionSimulator _advanceProgress]):
1501         (-[DataInteractionSimulator waitForInputSession]):
1502         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
1503         (-[DataInteractionSimulator _webView:didStartInputSession:]):
1504
1505 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1506
1507         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
1508         https://bugs.webkit.org/show_bug.cgi?id=171641
1509
1510         Reviewed by Simon Fraser.
1511
1512         The plan is to add back the TestRunner.display() which does the display
1513         only without track repaints.
1514
1515         * DumpRenderTree/DumpRenderTree.h:
1516         * DumpRenderTree/TestRunner.cpp:
1517         (displayAndTrackRepaintsCallback):
1518         (TestRunner::staticFunctions):
1519         (displayCallback): Deleted.
1520         (displayInvalidatedRegionCallback): Deleted.
1521         * DumpRenderTree/TestRunner.h:
1522         * DumpRenderTree/mac/DumpRenderTree.mm:
1523         (displayWebView):
1524         (displayAndTrackRepaintsWebView):
1525         * DumpRenderTree/mac/TestRunnerMac.mm:
1526         (TestRunner::displayAndTrackRepaints):
1527         (TestRunner::display): Deleted.
1528         * DumpRenderTree/win/TestRunnerWin.cpp:
1529         (TestRunner::displayAndTrackRepaints):
1530         (TestRunner::display): Deleted.
1531         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1532         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1533         (WTR::TestRunner::displayAndTrackRepaints):
1534         (WTR::TestRunner::display): Deleted.
1535         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1536
1537 2017-05-04  Brady Eidson  <beidson@apple.com>
1538
1539         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
1540         https://bugs.webkit.org/show_bug.cgi?id=171513
1541
1542         Unreviewed gardening.
1543
1544         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1545         (TEST): Skip the failing parts of the test on iOS for now.
1546
1547 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
1548
1549         Make ImageDiff stand-alone
1550         https://bugs.webkit.org/show_bug.cgi?id=168939
1551
1552         Reviewed by David Kilzer.
1553
1554         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
1555         stand-alone project. Note that this change does not eliminate the ImageDiff inside
1556         the DumpRenderTree project.
1557
1558         * ImageDiff/ImageDiff.xcodeproj: Added.
1559         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
1560         * ImageDiff/Makefile: Use ImageDiff project.
1561         * ImageDiff/PlatformMac.cmake: Added.
1562         * ImageDiff/PlatformWin.cmake: Added.
1563         * ImageDiff/cg: Added.
1564         * ImageDiff/cg/Configurations: Added.
1565         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
1566         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
1567         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
1568         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
1569         (createImageFromStdin): Stop using RetainPtr.
1570         (createDifferenceImage): Ditto.
1571         (main): Ditto.
1572         * Scripts/build-imagediff: Stop building WTF and bmalloc.
1573
1574 2017-05-04  Sam Weinig  <sam@webkit.org>
1575
1576         Remove support for legacy Notifications
1577         https://bugs.webkit.org/show_bug.cgi?id=171487
1578
1579         Reviewed by Jon Lee.
1580
1581         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1582         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1583         * Scripts/webkitperl/FeatureList.pm:
1584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1585         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
1586
1587 2017-05-04  Andy Estes  <aestes@apple.com>
1588
1589         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
1590         https://bugs.webkit.org/show_bug.cgi?id=171673
1591
1592         Reviewed by Dan Bernstein.
1593
1594         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1595         (TEST):
1596         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
1597         (TEST):
1598         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1599         (TEST):
1600         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1601         (TEST):
1602         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
1603         (TEST):
1604         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1605         (configurationWithContentFilterSettings):
1606         (-[LazilyLoadPlatformFrameworksController init]):
1607         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1608         (TEST):
1609         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1610         (runTestWithWidth):
1611         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
1612         (TEST):
1613         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1614         (TestWebKitAPI::TEST):
1615         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1616         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1617         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
1618         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
1619         +_test_configurationWithTestPlugInClassName:
1620
1621 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
1622
1623         [MediaStream] Allow host application to enable/disable media capture
1624         https://bugs.webkit.org/show_bug.cgi?id=171292
1625         <rdar://problem/31821492>
1626
1627         Reviewed by Jer Noble.
1628
1629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1631         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1632         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1633         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1634         (MediaCaptureDisabledTest::SetUp):
1635         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1636         (TEST_F):
1637         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1638
1639 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
1640
1641         Unreviewed, Adding self to contributors.json
1642
1643         * Scripts/webkitpy/common/config/contributors.json: Added name.
1644
1645 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
1646
1647         Fix compilation with ICU 59.1
1648         https://bugs.webkit.org/show_bug.cgi?id=171612
1649
1650         Reviewed by Mark Lam.
1651
1652         ICU 59.1 has broken source compatibility. Now it defines UChar as
1653         char16_t, which does not allow automatic type conversion from unsigned
1654         short in C++ code.
1655
1656         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1657         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1658
1659 2017-05-04  Andy Estes  <aestes@apple.com>
1660
1661         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
1662         https://bugs.webkit.org/show_bug.cgi?id=171646
1663         <rdar://problem/30306321>
1664
1665         Reviewed by Tim Horton.
1666
1667         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1668         (runTestWithWidth):
1669         (TEST):
1670         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
1671         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
1672         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1673         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1674         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
1675         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
1676
1677 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
1678
1679         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
1680         https://bugs.webkit.org/show_bug.cgi?id=171649
1681
1682         Reviewed by Carlos Garcia Campos.
1683
1684         Add two patches picked from the upstream repository to fix building of
1685         the Fontconfig module in JHBuild. Additionally, this needed a patch to
1686         add "autogen.sh" as it is not included in release tarballs. Also:
1687         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
1688         being regenerated (which is needed) so this is disabled for the
1689         Fontconfig module.
1690
1691         * gtk/jhbuild.modules:
1692         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
1693         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
1694         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
1695
1696 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1697
1698         Unreviewed, rolling out r216172.
1699         https://bugs.webkit.org/show_bug.cgi?id=171654
1700
1701         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
1702         implementation. (Requested by ddkilzer on #webkit).
1703
1704         Reverted changeset:
1705
1706         "[MediaStream] Allow host application to enable/disable media
1707         capture"
1708         https://bugs.webkit.org/show_bug.cgi?id=171292
1709         http://trac.webkit.org/changeset/216172
1710
1711 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1712
1713         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
1714         https://bugs.webkit.org/show_bug.cgi?id=171595
1715
1716         Reviewed by Xabier Rodriguez-Calvar.
1717
1718         * gtk/jhbuild.modules:
1719         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1720         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1721         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
1722         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
1723         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1724         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1725         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1726
1727 2017-05-03  Saam Barati  <sbarati@apple.com>
1728
1729         How we build polymorphic cases is wrong when making a call from Wasm
1730         https://bugs.webkit.org/show_bug.cgi?id=171527
1731
1732         Reviewed by JF Bastien.
1733
1734         * Scripts/run-jsc-stress-tests:
1735
1736 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1737
1738         [MediaStream] Allow host application to enable/disable media capture
1739         https://bugs.webkit.org/show_bug.cgi?id=171292
1740         <rdar://problem/31821492>
1741
1742         Reviewed by Jer Noble.
1743
1744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1745         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1746         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1747         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1748         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1749         (MediaCaptureDisabledTest::SetUp):
1750         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1751         (TEST_F):
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1753
1754 2017-05-03  John Wilander  <wilander@apple.com>
1755
1756         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
1757         https://bugs.webkit.org/show_bug.cgi?id=171584
1758         <rdar://problem/24702576>
1759
1760         Reviewed by Brent Fulgham.
1761
1762         New function to call the clear function that takes a modifiedSince parameter.
1763
1764         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1765         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1766         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1767         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1768         * WebKitTestRunner/TestController.cpp:
1769         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1770         * WebKitTestRunner/TestController.h:
1771         * WebKitTestRunner/TestInvocation.cpp:
1772         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1773
1774 2017-05-03  Commit Queue  <commit-queue@webkit.org>
1775
1776         Unreviewed, rolling out r216160 and r216161.
1777         https://bugs.webkit.org/show_bug.cgi?id=171640
1778
1779         These changes broke the iOS build. (Requested by mlewis13 on
1780         #webkit).
1781
1782         Reverted changesets:
1783
1784         "[MediaStream] Allow host application to enable/disable media
1785         capture"
1786         https://bugs.webkit.org/show_bug.cgi?id=171292
1787         http://trac.webkit.org/changeset/216160
1788
1789         "[MediaStream] Allow host application to enable/disable media
1790         capture"
1791         https://bugs.webkit.org/show_bug.cgi?id=171292
1792         http://trac.webkit.org/changeset/216161
1793
1794 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1795
1796         [MediaStream] Allow host application to enable/disable media capture
1797         https://bugs.webkit.org/show_bug.cgi?id=171292
1798         <rdar://problem/31821492>
1799
1800         Reviewed by Jer Noble.
1801
1802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1803         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1804         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1805         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1806         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1807         (MediaCaptureDisabledTest::SetUp):
1808         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1809         (TEST_F):
1810         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1811
1812 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
1813
1814         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
1815         https://bugs.webkit.org/show_bug.cgi?id=171350
1816         <rdar://problem/28600836>
1817
1818         Patched by Brady Eidson.
1819
1820         Reviewed by Brent Fulgham.
1821
1822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1823         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
1824         (TestWebKitAPI::runJavaScriptAlert):
1825         (TestWebKitAPI::decidePolicyForNavigationAction):
1826         (TestWebKitAPI::decidePolicyForNavigationResponse):
1827         (TestWebKitAPI::TEST):
1828         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
1829
1830 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
1831
1832         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
1833         https://bugs.webkit.org/show_bug.cgi?id=171619
1834         https://bugs.webkit.org/show_bug.cgi?id=170195
1835
1836         Reviewed by Tim Horton.
1837
1838         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
1839
1840         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1841         (TEST):
1842
1843 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1844
1845         YouTube user agent quirk breaks new YouTube
1846         https://bugs.webkit.org/show_bug.cgi?id=171603
1847
1848         Reviewed by Carlos Garcia Campos.
1849
1850         Remove the YouTube quirk test.
1851
1852         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1853         (TestWebKitAPI::TEST):
1854
1855 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
1856
1857         Async image decoding should be disabled for snapshots, printing and preview
1858         https://bugs.webkit.org/show_bug.cgi?id=171467
1859
1860         Reviewed by Simon Fraser.
1861
1862         Add a API test for snapshotting with large images. Ensure the images are
1863         drawn correctly which implies they should have been synchronously decoded.
1864
1865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1866         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
1867         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
1868         (TEST):
1869
1870 2017-05-03  Chris Dumez  <cdumez@apple.com>
1871
1872         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
1873         https://bugs.webkit.org/show_bug.cgi?id=171565
1874         <rdar://problem/31204417>
1875
1876         Reviewed by Sam Weinig.
1877
1878         Add API test coverage.
1879
1880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1881         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
1882         (TestWebKitAPI::didFinishNavigation):
1883         (TestWebKitAPI::didCrashWithReason):
1884         (TestWebKitAPI::TEST):
1885
1886 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1887
1888         check-webkit-style should also keep js-test-post[-async].js in sync
1889         <https://webkit.org/b/171568>
1890
1891         Reviewed by Joseph Pecoraro.
1892
1893         * Scripts/webkitpy/style/checker.py:
1894         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
1895         JavaScript files not to be skipped.
1896         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
1897         (CheckerDispatcher._create_checker): Update to use
1898         _NEVER_SKIPPED_JS_FILES.
1899
1900         * Scripts/webkitpy/style/checkers/jstest.py:
1901         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
1902         This is the list of files containing functions that need to be
1903         kept in sync.
1904         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
1905         we can keep more sets of files in sync between
1906         LayoutTests/resources and LayoutTests/http/tests/resources.
1907         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
1908         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
1909         (JSTestChecker.check_js_test_files): Add 'file_group' argument
1910         for list of files to check instead of using
1911         KEEP_JS_TEST_FILES_IN_SYNC.
1912         (JSTestChecker.check_js_test_functions): Update for
1913         ALL_JS_TEST_FUNCTION_FILES rename.
1914
1915         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
1916         (JSTestCheckerTestCase):
1917         (JSTestCheckerTestCase.test_map_functions_to_dict):
1918         - Add test case for map_functions_to_dict() in jstest.py.
1919
1920 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
1921
1922         ews should indicate in logs when it fails to fetch the attachment
1923         https://bugs.webkit.org/show_bug.cgi?id=171583
1924
1925         Reviewed by Alexey Proskuryakov.
1926
1927         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1928         (Bugzilla.fetch_attachment): Added log statement.
1929
1930 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1931
1932         Rolling out jstest_unittest.py so it can be reviewed
1933
1934         Follow-up fix for:
1935         check-webkit-style should keep JavaScript test functions in sync
1936         <https://webkit.org/b/171424>
1937
1938         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
1939
1940 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1941
1942         check-webkit-style should keep JavaScript test functions in sync
1943         <https://webkit.org/b/171424>
1944
1945         Reviewed by Joseph Pecoraro.
1946
1947         Add a new JSTestChecker for check-webkit-style that keeps these
1948         two files in sync:
1949
1950             LayoutTests/http/tests/resources/js-test-pre.js
1951             LayoutTests/resources/js-test-pre.js
1952
1953         And keeps implementations of shouldBe(), shouldNotBe(),
1954         shouldNotThrow(), and shouldThrow() in sync across multiple
1955         files (with the ability to add more functions later):
1956
1957             JSTests/stress/resources/standalone-pre.js
1958             LayoutTests/http/tests/resources/js-test-pre.js
1959             LayoutTests/resources/js-test-pre.js
1960             LayoutTests/resources/js-test.js
1961             LayoutTests/resources/standalone-pre.js
1962
1963         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
1964         import for JSTestChecker.
1965         (_NEVER_SKIPPED_FILES): Add array of file names that are never
1966         skipped regardless of other rules.
1967         (_all_categories): Add JSTestChecker categories.
1968         (CheckerDispatcher.should_skip_without_warning): Use
1969         _NEVER_SKIPPED_FILES.
1970         (CheckerDispatcher._create_checker): Return JSTestChecker for
1971         the files to check.
1972
1973         * Scripts/webkitpy/style/checkers/jstest.py: Add.
1974         (map_functions_to_dict): Parse JavaScript source by splitting on
1975         /^function\s+/ regex.  This is good enough for the sanity checks
1976         to keep function implementations in sync.
1977         (strip_blank_lines_and_comments): Strips blank lines and lines
1978         with comments from the end of a chunk of text representing a
1979         function.
1980         (JSTestChecker): New checker.
1981         (JSTestChecker.__init__):
1982         (JSTestChecker.check):
1983         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
1984         (JSTestChecker.check_js_test_functions): Keeps individual
1985         functions in sync.
1986
1987         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
1988         case.
1989         (JSTestTestCase):
1990         (JSTestTestCase.test_map_functions_to_dict):
1991
1992 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
1993
1994         AX: Update implementation of aria-orientation
1995         https://bugs.webkit.org/show_bug.cgi?id=171166
1996
1997         Reviewed by Chris Fleizach.
1998
1999         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
2000         are both absent from the state set. Before we were returning an empty string
2001         which was not consistent with what the Mac port does, thus making shared tests
2002         harder.
2003
2004         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2005         (WTR::AccessibilityUIElement::orientation):
2006
2007 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2008
2009         Stop using sprintf() in JavaScriptCore debugger
2010         <https://webkit.org/b/171512>
2011
2012         Reviewed by Keith Miller.
2013
2014         * Scripts/webkitpy/style/checker.py:
2015         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
2016         Source/JavaScriptCore/disassembler/udis86/ is generated code.
2017
2018 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
2019
2020         Expose viewport-fit instead of clip-to-safe-area
2021         https://bugs.webkit.org/show_bug.cgi?id=171503
2022         <rdar://problem/31918249>
2023
2024         Reviewed by Simon Fraser.
2025
2026         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2027         (WTR::UIScriptController::setSafeAreaInsets):
2028         (WTR::UIScriptController::setObscuredInsets): Deleted.
2029         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2030         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2031         (WTR::UIScriptController::setSafeAreaInsets):
2032         (WTR::UIScriptController::setObscuredInsets): Deleted.
2033         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2034         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2035         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2036         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
2037         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
2038         * WebKitTestRunner/ios/TestControllerIOS.mm:
2039         (WTR::TestController::platformResetStateToConsistentValues):
2040         * WebKitTestRunner/ios/UIKitSPI.h:
2041         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2042         (WTR::UIScriptController::setSafeAreaInsets):
2043         (WTR::UIScriptController::setObscuredInsets): Deleted.
2044         Expose a safe area inset setter instead of obscured insets.
2045
2046 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2047
2048         Unreviewed, fix the build on a new internal SDK
2049
2050         Replace usages of NSItemProviderRepresentationVisibilityAll with
2051         UIItemProviderRepresentationOptionsVisibilityAll.
2052
2053         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2054         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2055         (TestWebKitAPI::TEST):
2056
2057 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2058
2059         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
2060         <https://webkit.org/b/171493>
2061
2062         Reviewed by Dan Bernstein.
2063
2064         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2065         Remove UIKit soft-link since TestWebKitAPI links to
2066         UIKit.framework.
2067         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
2068         UIWindow and UIWebView classes directly.
2069         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2070         Remove UIKit soft-link since TestWebKitAPI links to
2071         UIKit.framework.
2072         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
2073         class directly.
2074
2075 2017-05-01  Brady Eidson  <beidson@apple.com>
2076
2077         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
2078         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
2079
2080         Reviewed by Andy Estes.
2081
2082         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2083         (-[SchemeHandler webView:startURLSchemeTask:]):
2084         (-[SchemeHandler webView:stopURLSchemeTask:]):
2085         (-[SchemeHandler webView:startTask:]): Deleted.
2086         (-[SchemeHandler webView:stopTask:]): Deleted.
2087
2088 2017-05-01  Jason Marcell  <jmarcell@apple.com>
2089
2090         Add a new function for getting the Git hash for a pure git directory.
2091         https://bugs.webkit.org/show_bug.cgi?id=171450
2092
2093         Reviewed by David Kilzer.
2094
2095         * Scripts/VCSUtils.pm:
2096         (gitHashForDirectory):
2097
2098 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
2099
2100         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
2101         https://bugs.webkit.org/show_bug.cgi?id=171496
2102
2103         Reviewed by Chris Fleizach.
2104
2105         Add new attribute names so that the values of the object attributes can be tested.
2106
2107         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2108         (WTR::AccessibilityUIElement::numberAttributeValue):
2109
2110 2017-05-01  Beth Dakin  <bdakin@apple.com>
2111
2112         On-screen panel for candidate bar is in the wrong place when the caret is at the 
2113         start of a paragraph
2114         https://bugs.webkit.org/show_bug.cgi?id=171453
2115         -and corresponding-
2116         rdar://problem/29779764
2117
2118         Reviewed by Tim Horton.
2119
2120         This test hard-codes the y-coordinate for the expected candidateRect. 
2121         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2122         (TEST):
2123
2124 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2125
2126         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
2127         <https://webkit.org/b/171494>
2128
2129         Reviewed by Brent Fulgham.
2130
2131         * Scripts/webkitpy/style/checkers/cpp.py:
2132         (check_language): Change categories for certain checkers from
2133         'runtime/printf' to 'security/printf' so they are no longer
2134         filtered.
2135         (CppChecker.categories): Add 'security/printf'.
2136         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2137         (CppStyleTest.test_insecure_string_operations): Add new test for
2138         sprintf(), strcat() and strcpy().
2139         (CppStyleTest.test_format_strings): Update test results for new
2140         'security/printf' category use.
2141
2142 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
2143
2144         AX: [GTK] Add support to query for aria-current
2145         https://bugs.webkit.org/show_bug.cgi?id=149016
2146
2147         Reviewed by Chris Fleizach.
2148
2149         Implement support for "AXARIACurrent" string attribute value.
2150
2151         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2152
2153 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2154
2155         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
2156
2157         Unreviewed.
2158
2159         Follow-up fix for:
2160         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
2161         https://bugs.webkit.org/show_bug.cgi?id=171486
2162
2163         * Scripts/webkitpy/style/checkers/cpp.py:
2164         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
2165         match and capture the function name.  The latter also mistakenly
2166         matches C-preprocessor directives.
2167         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
2168         is a requirement for the CppChecker class.
2169
2170 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2171
2172         [GTK] Add automation session API
2173         https://bugs.webkit.org/show_bug.cgi?id=171428
2174
2175         Reviewed by Carlos Alberto Lopez Perez.
2176
2177         Add an automation mode to MiniBrowser using the new API and add a unit test too.
2178
2179         * MiniBrowser/gtk/BrowserWindow.c:
2180         (webViewTitleChanged):
2181         (webViewDecidePolicy):
2182         (newTabCallback):
2183         (openPrivateWindow):
2184         (browserWindowFinalize):
2185         (browser_window_init):
2186         (browser_window_get_or_create_web_view_for_automation):
2187         * MiniBrowser/gtk/BrowserWindow.h:
2188         * MiniBrowser/gtk/main.c:
2189         (createBrowserTab):
2190         (createWebViewForAutomationCallback):
2191         (automationStartedCallback):
2192         (main):
2193         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2194         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
2195         (testAutomationSessionRequestSession):
2196         (beforeAll):
2197         (afterAll):
2198
2199 2017-04-30  Dan Bernstein  <mitz@apple.com>
2200
2201         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
2202         https://bugs.webkit.org/show_bug.cgi?id=171486
2203
2204         Reviewed by Sam Weinig.
2205
2206         * Scripts/webkitpy/style/checkers/cpp.py:
2207         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
2208           alloc…Instance() instead.
2209         (check_style): Invoke new check.
2210
2211 2017-04-30  Brady Eidson  <beidson@apple.com>
2212
2213         More fixing after r215991
2214         https://bugs.webkit.org/show_bug.cgi?id=171483
2215
2216         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2217         (TEST):
2218
2219 2017-04-30  Brady Eidson  <beidson@apple.com>
2220
2221         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
2222         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
2223
2224         Reviewed by Geoff Garen (and kind of Andy Estes).
2225
2226         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2227         (TEST):
2228
2229 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2230
2231         [ATK] Implement support for aria-autocomplete
2232         https://bugs.webkit.org/show_bug.cgi?id=171167
2233
2234         Reviewed by Chris Fleizach.
2235
2236         Add "AXSupportsAutoCompletion" attribute so the presence of
2237         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
2238
2239         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2240         (WTR::AccessibilityUIElement::boolAttributeValue):
2241
2242 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2243
2244         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
2245         https://bugs.webkit.org/show_bug.cgi?id=171170
2246
2247         Reviewed by Chris Fleizach.
2248
2249         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
2250
2251         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2252         (WTR::AccessibilityUIElement::boolAttributeValue):
2253
2254 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2255
2256         [ATK] Emit object:state-changed:busy event when aria-busy value changes
2257         https://bugs.webkit.org/show_bug.cgi?id=171181
2258
2259         Reviewed by Chris Fleizach.
2260
2261         Add handler for AXElementBusyChanged notifications.
2262
2263         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2264
2265 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
2266
2267         Use PEP8 style guide for raising exceptions in webkitpy.
2268         https://bugs.webkit.org/show_bug.cgi?id=171439
2269
2270         Reviewed by Daniel Bates.
2271
2272         As per https://www.python.org/dev/peps/pep-0008/
2273         "When raising an exception in Python 2, use raise ValueError('message') 
2274         instead of the older form raise ValueError, 'message'"
2275
2276         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
2277         * Scripts/webkitpy/common/thread/messagepump.py: Same.
2278         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
2279         * Scripts/webkitpy/tool/commands/queues.py: Same.
2280         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
2281         * Scripts/webkitpy/tool/multicommandtool.py: Same.
2282         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
2283
2284 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
2285
2286         Add system trace points for Document::updateTouchEventRegions()
2287         https://bugs.webkit.org/show_bug.cgi?id=171470
2288         rdar://problem/31901239
2289
2290         Reviewed by Tim Horton.
2291
2292         Add trace markers for updateTouchEventRegions.
2293
2294         * Tracing/SystemTracePoints.plist:
2295
2296 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2297
2298         webkitpy: Add apple_additions to webkitpy to insert Internal tools
2299         https://bugs.webkit.org/show_bug.cgi?id=170461
2300         <rdar://problem/31433077>
2301
2302         Reviewed by Daniel Bates.
2303
2304         Allow a package to be pulled in by run-webkit-tests which provides an interface to
2305         run layout tests on an iOS device.  If this package is not available, throw an
2306         exception when attempting to run layout tests on an iOS device.
2307
2308         * Scripts/webkitpy/port/config.py:
2309         (apple_additions): Import apple_additions package.
2310         * Scripts/webkitpy/port/device.py:
2311         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
2312         installed on a device.
2313         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
2314         host, the bundle id of the app to be used for testing and a path to the layout test
2315         directory to be mounted on the device.
2316         (Device.finished_testing):
2317         * Scripts/webkitpy/port/factory.py:
2318         (platform_options): Add apple_additions platform options if apple_additions exists.
2319         * Scripts/webkitpy/port/ios.py:
2320         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
2321         to forward, the bundle ID of the testing app and the layout tests directory to
2322         each device.
2323         * Scripts/webkitpy/port/ios_device.py:
2324         (IOSDevicePort):
2325         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
2326         processes to be run.
2327         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
2328         a single device is used, it is still accessed through an array.
2329         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
2330         for worker number map.
2331         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
2332         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
2333         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
2334         (IOSDevicePort.look_for_new_crash_logs): Ditto.
2335         (IOSDevicePort.look_for_new_samples): Ditto.
2336         (IOSDevicePort.sample_process): Ditto.
2337         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
2338         (IOSDevicePort._create_devices): Check that devices are available for testing and check
2339         that we have enough devices for each child process.
2340         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
2341         * Scripts/webkitpy/port/ios_device_unittest.py:
2342         (IOSDeviceTest.test_operating_system):
2343         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
2344         (IOSDeviceTest.test_sample_process): Ditto.
2345         (IOSDeviceTest.test_sample_process_exception): Ditto.
2346
2347 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2348
2349         Fix and re-enable data interaction unit tests
2350         https://bugs.webkit.org/show_bug.cgi?id=171446
2351         <rdar://problem/31820646>
2352
2353         Reviewed by Tim Horton.
2354
2355         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
2356         registering with the UIItemProvider, and instead just register data directly via
2357         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
2358
2359         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2360         (TestWebKitAPI::TEST):
2361         (temporaryURLForDataInteractionFileLoad): Deleted.
2362         (cleanUpDataInteractionTemporaryPath): Deleted.
2363         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
2364         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2365         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2366
2367 2017-04-28  Brady Eidson  <beidson@apple.com>
2368
2369         Teach the DatabaseProcess to be fully SessionID aware
2370         https://bugs.webkit.org/show_bug.cgi?id=171451
2371
2372         Reviewed by Geoffrey Garen.
2373
2374         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2375
2376 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2377
2378         Unreviewed follow-up to r214705.
2379
2380         shut.copytree will fail if given a file as an argument instead of a directory.
2381
2382         * Scripts/webkitpy/common/system/filesystem.py:
2383         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
2384         when source is a file.
2385         (FileSystem.copy_from_base_host): Ditto.
2386
2387 2017-04-28  Chris Dumez  <cdumez@apple.com>
2388
2389         Update DOMTokenList.replace() to match the latest DOM specification
2390         https://bugs.webkit.org/show_bug.cgi?id=171388
2391
2392         Reviewed by Alex Christensen.
2393
2394         Add API test coverage for new Vector API.
2395
2396         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2397         (TestWebKitAPI::TEST):
2398
2399 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2400
2401         WebKitTestRunner/DumpRenderTree prevent device from sleeping
2402         https://bugs.webkit.org/show_bug.cgi?id=170731
2403
2404         Reviewed by Alex Christensen.
2405
2406         While running layout tests on a device, the device should not be put asleep.
2407
2408         * DumpRenderTree/mac/DumpRenderTree.mm:
2409         (dumpRenderTree): Disable idle timer.
2410         * WebKitTestRunner/ios/TestControllerIOS.mm:
2411         (WTR::TestController::platformInitialize): Ditto.
2412
2413 2017-04-28  Brady Eidson  <beidson@apple.com>
2414
2415         Start of support for multiple WebsiteDataStore/SessionIDs per process
2416         https://bugs.webkit.org/show_bug.cgi?id=171422
2417
2418         Reviewed by Geoffrey Garen.
2419
2420         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2421         (TEST):
2422
2423 2017-04-28  Youenn Fablet  <youenn@apple.com>
2424
2425         Adding a runtime flag specific to MediaDevices
2426         https://bugs.webkit.org/show_bug.cgi?id=171433
2427
2428         Reviewed by Geoffrey Garen.
2429
2430         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
2431         Setting media devices runtime flag to true for WTR and DRT.
2432
2433         * DumpRenderTree/mac/DumpRenderTree.mm:
2434         (enableExperimentalFeatures):
2435         (resetWebPreferencesToConsistentValues):
2436         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
2437         (TestWebKitAPI::TEST):
2438         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2439         (TestWebKitAPI::TEST):
2440         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2441         (WTR::InjectedBundle::beginTesting):
2442         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2443         (WTR::TestRunner::setMediaDevicesEnabled):
2444         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
2445         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
2446         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2447         * WebKitTestRunner/TestController.cpp:
2448         (WTR::TestController::resetPreferencesToConsistentValues):
2449
2450 2017-04-28  Dean Jackson  <dino@apple.com>
2451
2452         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
2453         https://bugs.webkit.org/show_bug.cgi?id=171441
2454         <rdar://problem/31826915>
2455
2456         Reviewed by Tim Horton.
2457
2458         Add an API test for GPUCommandQueue, exercising creation
2459         and setting the label.
2460
2461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2462         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
2463         (TestWebKitAPI::TEST_F):
2464
2465 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2466
2467         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
2468         https://bugs.webkit.org/show_bug.cgi?id=171188
2469
2470         Reviewed by Chris Fleizach.
2471
2472         Add "AXModal" attribute string so that we can test the state's exposure.
2473
2474         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2475         (WTR::AccessibilityUIElement::boolAttributeValue):
2476
2477 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2478
2479         [ATK] GridCellRole should implement AtkTableCell (regression?)
2480         https://bugs.webkit.org/show_bug.cgi?id=171179
2481
2482         Reviewed by Chris Fleizach.
2483
2484         Add new "AXInterfaceTableCell" attribute so that we can test whether or
2485         not there is an implementation of AtkTableCell (i.e. without risking false
2486         negatives from bugs in the interface's implementation).
2487
2488         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2489         (WTR::AccessibilityUIElement::boolAttributeValue):
2490
2491 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2492
2493         Move UUID from WebCore/platform to WTF
2494         https://bugs.webkit.org/show_bug.cgi?id=171372
2495
2496         Reviewed by Michael Catanzaro.
2497
2498         * WebKitTestRunner/TestController.cpp:
2499
2500 2017-04-27  Alex Christensen  <achristensen@webkit.org>
2501
2502         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
2503         https://bugs.webkit.org/show_bug.cgi?id=171399
2504
2505         Reviewed by Brady Eidson.
2506
2507         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
2508         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2509         (TEST):
2510
2511 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
2512
2513         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
2514         https://bugs.webkit.org/show_bug.cgi?id=167914
2515
2516         Unreviewed test gardening.
2517
2518         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
2519         (TEST):
2520
2521 2017-04-26  Saam Barati  <sbarati@apple.com>
2522
2523         Add some more testing modes for Wasm tests now that we have tier up
2524         https://bugs.webkit.org/show_bug.cgi?id=171360
2525
2526         Reviewed by Keith Miller.
2527
2528         Lets enable the FTL on all Wasm tests. Let's also run each
2529         test with and without CJIT.
2530
2531         * Scripts/run-jsc-stress-tests:
2532
2533 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
2534
2535         JSC EWS Patch Relevance skips few JSC scripts
2536         https://bugs.webkit.org/show_bug.cgi?id=171351
2537
2538         Reviewed by Alexey Proskuryakov.
2539
2540         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2541         (CheckPatchRelevance): Added few jsc related scripts.
2542
2543 2017-04-26  Youenn Fablet  <youenn@apple.com>
2544
2545         Test importer should delete obsolete files based on w3c-import.log
2546         https://bugs.webkit.org/show_bug.cgi?id=171348
2547
2548         Reviewed by Chris Dumez.
2549
2550         * Scripts/webkitpy/w3c/test_importer.py:
2551         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
2552         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
2553         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2554         (test_remove_obsolete_content):
2555
2556 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
2557
2558         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
2559         <rdar://problem/31816459>
2560
2561         Unreviewed infrastructure fix.
2562
2563         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
2564         DYLD_FRAMEWORK_PATH when installing an app.
2565
2566         * Scripts/webkitpy/port/ios.py:
2567         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
2568
2569 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
2570
2571         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
2572         https://bugs.webkit.org/show_bug.cgi?id=171163
2573
2574         Reviewed by Chris Fleizach.
2575
2576         Add support for state-change notifications for ATK_STATE_ACTIVE.
2577
2578         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2579
2580 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
2581
2582         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
2583         https://bugs.webkit.org/show_bug.cgi?id=171293
2584
2585         Reviewed by Aakash Jain.
2586
2587         We should make an effort to teardown simulators which we booted even when an exception is
2588         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
2589         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
2590         torn down.
2591
2592         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2593         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
2594         * Scripts/webkitpy/port/ios_simulator.py:
2595         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
2596         iOS simulators and teardown and managed devices.
2597         (IOSSimulatorPort._create_simulators): Register teardown function.
2598         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
2599         (IOSSimulatorPort._remove_device): Deleted.
2600
2601 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
2602
2603         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
2604         https://bugs.webkit.org/show_bug.cgi?id=171164
2605
2606         Reviewed by Chris Fleizach.
2607
2608         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
2609         AtkStateSet; not what is found in the AtkObject's attributes.
2610
2611         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2612         (WTR::AccessibilityUIElement::hasPopup):
2613
2614 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2615
2616         Encoded filename should be decoded for WKContentExtension.identifier
2617         https://bugs.webkit.org/show_bug.cgi?id=171316
2618
2619         Reviewed by Andy Estes.
2620
2621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2622         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
2623         (TEST_F):
2624         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
2625
2626 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2627
2628         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
2629         https://bugs.webkit.org/show_bug.cgi?id=171297
2630         <rdar://problem/31530719>
2631
2632         Reviewed by Geoffrey Garen.
2633
2634         * TestWebKitAPI/PlatformWebView.h:
2635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2636         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
2637         (TestWebKitAPI::didFinishLoadForFrame):
2638         (TestWebKitAPI::mouseDidMoveOverElement):
2639         (TestWebKitAPI::setClients):
2640         (TestWebKitAPI::TEST):
2641         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2642         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2643         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2644
2645 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2646
2647         Unreviewed, temporarily disable the data interaction unit tests.
2648
2649         The API around data interaction will change significantly in the near future, and
2650         these tests will begin to fail. These will be reenabled once the bots are on an SDK
2651         that supports the updated data interaction API.
2652
2653         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2654         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2655         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2656
2657 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
2658
2659         Limit allowed size of document.title to avoid locking WebKit clients
2660         https://bugs.webkit.org/show_bug.cgi?id=165113
2661         <rdar://problem/28324389>
2662
2663         Reviewed by Darin Adler.
2664
2665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2666         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
2667         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
2668         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
2669
2670 2017-04-25  John Wilander  <wilander@apple.com>
2671
2672         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
2673         https://bugs.webkit.org/show_bug.cgi?id=171295
2674         <rdar://problem/31823818>
2675
2676         Reviewed by Brent Fulgham.
2677
2678         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2679         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2680         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
2681         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
2682         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2683         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2684         * WebKitTestRunner/TestController.cpp:
2685         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
2686         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
2687         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2688         * WebKitTestRunner/TestController.h:
2689         * WebKitTestRunner/TestInvocation.cpp:
2690         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2691
2692 2017-04-25  Tim Horton  <timothy_horton@apple.com>
2693
2694         Try to fix the WKTR build after r215758
2695
2696         * Scripts/build-webkittestrunner:
2697
2698 2017-04-25  Daniel Bates  <dabates@apple.com>
2699
2700         Remove more EFL code
2701         https://bugs.webkit.org/show_bug.cgi?id=171288
2702
2703         Rubber-stamped by Simon Fraser.
2704
2705         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
2706         that was part of the EFL port.
2707
2708         * CMakeLists.txt:
2709         * DumpRenderTree/AccessibilityController.h:
2710         * DumpRenderTree/AccessibilityUIElement.cpp:
2711         (AccessibilityUIElement::getJSClass):
2712         * DumpRenderTree/AccessibilityUIElement.h:
2713         * DumpRenderTree/DumpRenderTree.h:
2714         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2715         * ImageDiff/efl/ImageDiff.cpp: Removed.
2716         * MiniBrowser/efl/CMakeLists.txt: Removed.
2717         * MiniBrowser/efl/main.c: Removed.
2718         * Scripts/build-dumprendertree:
2719         * Scripts/build-jsc:
2720         * Scripts/build-webkit:
2721         * Scripts/build-webkittestrunner:
2722         * Scripts/run-minibrowser:
2723         * Scripts/update-webkit-libs-jhbuild:
2724         * Scripts/update-webkitefl-libs: Removed.
2725         * Scripts/webkitdirs.pm:
2726         (argumentsForConfiguration):
2727         (extractNonMacOSHostConfiguration):
2728         (executableProductDir):
2729         (builtDylibPathForName):
2730         (determinePortName):
2731         (launcherPath):
2732         (launcherName):
2733         (getJhbuildPath):
2734         (wrapperPrefixIfNeeded):
2735         (generateBuildSystemFromCMakeProject):
2736         (buildCMakeProjectOrExit):
2737         (isEfl): Deleted.
2738         * Scripts/webkitperl/FeatureList.pm:
2739         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2740         * Scripts/webkitpy/common/config/ports.py:
2741         (DeprecatedPort.port):
2742         (GtkWK2Port.run_webkit_tests_command):
2743         (EflWK2Port): Deleted.
2744         (EflWK2Port.build_webkit_command): Deleted.
2745         * Scripts/webkitpy/port/builders.py:
2746         * Scripts/webkitpy/port/efl.py: Removed.
2747         * Scripts/webkitpy/port/efl_unittest.py: Removed.
2748         * Scripts/webkitpy/port/factory.py:
2749         (platform_options):
2750         (PortFactory):
2751         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2752         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2753         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2754         (TestRebaselineTest.test_baseline_directory):
2755         (TestRebaselineExpectations.test_rebaseline_expectations):
2756         * TestWebKitAPI/PlatformEfl.cmake: Removed.
2757         * TestWebKitAPI/PlatformWebView.h:
2758         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2759         (TestWebKitAPI::TEST):
2760         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
2761         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
2762         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
2763         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
2764         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
2765         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
2766         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
2767         * TestWebKitAPI/efl/main.cpp: Removed.
2768         * WebKitTestRunner/EventSenderProxy.h:
2769         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2770         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2771         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2772         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2773         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2774         (WTR::EventSendingController::contextClick):
2775         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2776         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2777         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2778         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2779         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
2780         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
2781         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
2782         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
2783         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
2784         * WebKitTestRunner/PlatformEfl.cmake: Removed.
2785         * WebKitTestRunner/PlatformWebView.h:
2786         * WebKitTestRunner/TestController.cpp:
2787         (WTR::TestController::resetStateToConsistentValues):
2788         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
2789         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
2790         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
2791         * WebKitTestRunner/efl/main.cpp: Removed.
2792         * efl/install-dependencies: Removed.
2793         * efl/jhbuild-optional.modules: Removed.
2794         * efl/jhbuild.modules: Removed.
2795         * efl/jhbuildrc: Removed.
2796         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
2797         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
2798         * efl/patches/gst-libav.patch: Removed.
2799         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2800         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2801         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2802         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
2803         * gtk/manifest.txt.in:
2804
2805 2017-04-25  Daniel Bates  <dabates@apple.com>
2806
2807         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
2808         https://bugs.webkit.org/show_bug.cgi?id=136452
2809         <rdar://problem/23412620>
2810
2811         Reviewed by Brent Fulgham.
2812
2813         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
2814
2815         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
2816         as the EFL port is no longer in the WebKit OpenSource repository.
2817         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2818
2819 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2820
2821         Unreviewed follow-up to r215739 and r215740.
2822
2823         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
2824         This (and r215740) was supposed to land in r215739, but I managed to
2825         specify the previous version of the patch.
2826
2827 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2828
2829         Unreviewed follow-up to r215739.
2830
2831         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
2832         libgcrypt patch that enforces the use of /dev/urandom.
2833
2834 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2835
2836         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
2837         https://bugs.webkit.org/show_bug.cgi?id=171270
2838
2839         Reviewed by Michael Catanzaro.
2840
2841         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
2842         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
2843         that use systems that don't yet provide libgcrypt >= 1.7.0.
2844
2845 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2846
2847         [GTK] Improve an unit test for the JHBuild wrapper.
2848         https://bugs.webkit.org/show_bug.cgi?id=168036
2849
2850         Unreviewed follow-up patch after r215727
2851
2852         * Scripts/webkitpy/port/base_unittest.py:
2853         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
2854         wasn't there before calling MockFileSystem.maybe_make_directory(), and
2855         also that it exists after calling it.
2856
2857 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2858
2859         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
2860         https://bugs.webkit.org/show_bug.cgi?id=168036
2861
2862         Reviewed by Michael Catanzaro.
2863
2864         Call ImageDiff with the JHBuild wrapper if we should use it.
2865         Also add some unit tests for the JHBuild wrapper feature.
2866
2867         * Scripts/webkitpy/port/base.py:
2868         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
2869         * Scripts/webkitpy/port/base_unittest.py:
2870         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
2871         * Scripts/webkitpy/port/image_diff.py:
2872         (ImageDiffer._start): The actual fix, use the wrapper if we should.
2873         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
2874         * Scripts/webkitpy/port/port_testcase.py:
2875         (PortTestCase):
2876         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
2877         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
2878         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
2879
2880 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2881
2882         Support reading NSURL titles from the pasteboard when performing data interaction
2883         https://bugs.webkit.org/show_bug.cgi?id=171156
2884         <rdar://problem/31356937>
2885
2886         Reviewed by Tim Horton.
2887
2888         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
2889
2890         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2891         (TestWebKitAPI::TEST):
2892
2893 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2894
2895         Respect fidelity order when reading web content from item providers
2896         https://bugs.webkit.org/show_bug.cgi?id=171155
2897         <rdar://problem/31356937>
2898
2899         Reviewed by Tim Horton.
2900
2901         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
2902         more details.
2903
2904         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2905         (TestWebKitAPI::TEST):
2906
2907 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2908
2909         SyntaxError fix after r215702.
2910         https://bugs.webkit.org/show_bug.cgi?id=168944
2911
2912         Unreviewed "build" fix.
2913
2914         * BuildSlaveSupport/built-product-archive:
2915         (archiveBuiltProduct):
2916
2917 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
2918
2919         Package ImageDiff built with host SDK
2920         https://bugs.webkit.org/show_bug.cgi?id=168944
2921         <rdar://problem/30745642>
2922
2923         Reviewed by David Kilzer.
2924
2925         iOS Simulator and iOS device should archive the ImageDiff built for the host
2926         machine.
2927
2928         * BuildSlaveSupport/built-product-archive:
2929         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
2930         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
2931
2932 2017-04-24  Keith Miller  <keith_miller@apple.com>
2933
2934         ThreadMessage API tests failing on release bots
2935         https://bugs.webkit.org/show_bug.cgi?id=171246
2936
2937         Reviewed by Saam Barati.
2938
2939         Need to make sure that C++ doesn't optimize away our spin loop.
2940
2941         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2942         (runThreadMessageTest):
2943         (TEST):
2944
2945 2017-04-24  Alex Christensen  <achristensen@webkit.org>
2946
2947         Reduce copies and allocations in SharedBuffer::append
2948         https://bugs.webkit.org/show_bug.cgi?id=170956
2949
2950         Reviewed by Andreas Kling.
2951
2952         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2953         (TestWebKitAPI::TEST_F):
2954
2955 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2956
2957         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
2958         https://bugs.webkit.org/show_bug.cgi?id=166680
2959
2960         Reviewed by Michael Catanzaro.
2961
2962         Update remote inspector unit tests.
2963
2964         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
2965         (main):
2966         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2967         (connectToInspectorServer):
2968         (waitUntilInspectorServerIsReady):
2969         (startTestServer):
2970         (testInspectorServerPageList):
2971         (beforeAll):
2972
2973 2017-04-23  Youenn Fablet  <youenn@apple.com>
2974
2975         Add a tool to update expected.txt files from EWS bot results
2976         https://bugs.webkit.org/show_bug.cgi?id=169538
2977
2978         Reviewed by Ryosuke Niwa.
2979
2980         This script updates expected-txt files from bugzilla posted EWS results.
2981         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
2982         have results different from the generic baseline.
2983
2984         * Scripts/update-test-expectations-from-bugzilla: Added.
2985         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
2986         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
2987         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
2988
2989 2017-04-22  Youenn Fablet  <youenn@apple.com>
2990
2991         Add an option to import tip-of-tree WPT tests
2992         https://bugs.webkit.org/show_bug.cgi?id=171152
2993
2994         Reviewed by Joseph Pecoraro.
2995
2996         Adding a '-t' option to import tip of tree WPT tests.
2997         Updating importer based on the fact that csswg-test is no longer a thing. 
2998
2999         * Scripts/webkitpy/w3c/test_downloader.py:
3000         (TestDownloader.download_tests):
3001         * Scripts/webkitpy/w3c/test_importer.py:
3002         (configure_logging):
3003         (TestImporter.do_import):
3004         (TestImporter.write_import_log):
3005
3006 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3007
3008         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
3009         https://bugs.webkit.org/show_bug.cgi?id=171177
3010         <rdar://problem/31765379>
3011
3012         Reviewed by Andy Estes.
3013
3014         Tests uploading a JSON file to a file input.
3015
3016         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3017         (TestWebKitAPI::TEST):
3018
3019 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3020
3021         Support writing link titles to the pasteboard when beginning data interaction on a link
3022         https://bugs.webkit.org/show_bug.cgi?id=171154
3023         <rdar://problem/31356937>
3024
3025         Reviewed by Andy Estes.
3026
3027         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
3028         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
3029         matching the title of the link.
3030
3031         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3032         (TestWebKitAPI::TEST):
3033
3034 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3035
3036         Unreviewed, rolling out r215608.
3037
3038         Hundreds of test failures on GTK bot
3039
3040         Reverted changeset:
3041
3042         "Reduce copies and allocations in SharedBuffer::append"
3043         https://bugs.webkit.org/show_bug.cgi?id=170956
3044         http://trac.webkit.org/changeset/215608
3045
3046 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3047
3048         [WK2] Add delegate hooks for overriding unhanded data interaction operations
3049         https://bugs.webkit.org/show_bug.cgi?id=171005
3050         <rdar://problem/31669646>
3051
3052         Reviewed by Tim Horton.
3053
3054         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
3055         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
3056         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
3057
3058         New API test:
3059         DataInteractionTests.OverrideDataInteractionOperation
3060
3061         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3062         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
3063         (TestWebKitAPI::TEST):
3064         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3065         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3066         (-[DataInteractionSimulator initWithWebView:]):
3067         (-[DataInteractionSimulator dealloc]):
3068         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
3069         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
3070         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
3071
3072 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
3073
3074         Temporarily disable two flaky API tests.
3075
3076         Unreviewed test gardening.
3077
3078         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
3079         (TEST):
3080         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3081         (TEST):
3082
3083 2017-04-21  Keith Miller  <keith_miller@apple.com>
3084
3085         Unreviewed, rolling out r215634.
3086
3087         underlying build issues should have been fixed
3088
3089         Reverted changeset:
3090
3091         "Unreviewed, rolling out r215620 and r215623."
3092         https://bugs.webkit.org/show_bug.cgi?id=171139
3093         http://trac.webkit.org/changeset/215634
3094
3095 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
3096
3097         Bubbles on dashboard doesn't turn red for test262 failures
3098         https://bugs.webkit.org/show_bug.cgi?id=171129
3099
3100         Reviewed by Alexey Proskuryakov.
3101
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
3103
3104 2017-04-21  Commit Queue  <commit-queue@webkit.org>
3105
3106         Unreviewed, rolling out r215620 and r215623.
3107         https://bugs.webkit.org/show_bug.cgi?id=171139
3108
3109         broke arm64 build (Requested by keith_miller on #webkit).
3110
3111         Reverted changesets:
3112
3113         "Add signaling API"
3114         https://bugs.webkit.org/show_bug.cgi?id=170976
3115         http://trac.webkit.org/changeset/215620
3116
3117         "Unreviewed, fix Cloop build."
3118         http://trac.webkit.org/changeset/215623
3119
3120 2017-04-20  Keith Miller  <keith_miller@apple.com>
3121
3122         Add signaling API
3123         https://bugs.webkit.org/show_bug.cgi?id=170976
3124
3125         Reviewed by Filip Pizlo.
3126
3127         Add tests for ThreadMessages.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
3131         (runThreadMessageTest):
3132         (TEST):
3133
3134 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
3135
3136         commit-log-editor should respect the git editor if one is set
3137         https://bugs.webkit.org/show_bug.cgi?id=171085
3138         <rdar://problem/31745506>
3139
3140         Reviewed by Daniel Bates.
3141
3142         * Scripts/commit-log-editor:
3143         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
3144         deciding which editor to present. We examine the global editor preference since that may be
3145         set automatically by installers or third-party tools.
3146
3147 2017-04-21  Alex Christensen  <achristensen@webkit.org>
3148
3149         Reduce copies and allocations in SharedBuffer::append
3150         https://bugs.webkit.org/show_bug.cgi?id=170956
3151
3152         Reviewed by Andreas Kling.
3153
3154         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3155         (TestWebKitAPI::TEST_F):
3156
3157 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
3158
3159         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
3160         https://bugs.webkit.org/show_bug.cgi?id=171071
3161
3162         Reviewed by Michael Catanzaro.
3163
3164         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
3165         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
3166         be available for all ports.
3167
3168         * DumpRenderTree/PlatformMac.cmake:
3169         * MiniBrowser/mac/CMakeLists.txt:
3170         * MiniBrowser/win/CMakeLists.txt:
3171         * TestWebKitAPI/PlatformJSCOnly.cmake:
3172         * TestWebKitAPI/PlatformMac.cmake:
3173         * TestWebKitAPI/PlatformWin.cmake:
3174         * WebKitTestRunner/PlatformMac.cmake:
3175
3176 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
3177
3178         Test262 bot does not go red with failures
3179         https://bugs.webkit.org/show_bug.cgi?id=171044
3180
3181         Reviewed by Aakash Jain.
3182
3183         The piped output of run-jsc-stress-tests is different from
3184         its non-piped output. Switch to parsing the correct output.
3185
3186         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3187         (RunTest262Tests.countFailures):
3188         Just count the number of lines that start with "FAIL:".
3189
3190         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3191         (RunTest262TestsTest.test_no_regressions_output):
3192         (test_failure_output):
3193         (test_failures_output):
3194         Updated tests with new sample output produced partially from bots and
3195         locally. In cases of failure the return code of run-jsc-stress-tests
3196         is still 0 so update the expected return code in the tests.
3197
3198 2017-04-20  Brady Eidson  <beidson@apple.com>
3199
3200         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
3201         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
3202
3203         Reviewed by Andy Estes.
3204
3205         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
3206         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3207         (resetToConsistentState):
3208         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
3209         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3210         (TEST):
3211         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3212
3213 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3214
3215         [ios-simulator] PositionInformationTests API tests are timing out
3216         https://bugs.webkit.org/show_bug.cgi?id=171089
3217
3218         Rubber-stamped by Tim Horton.
3219
3220         Addresses failures observed in the new position information tests added in r215573 by only running them if the
3221         DATA_INTERACTION feature flag is enabled.
3222
3223         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3224
3225 2017-04-20  Brady Eidson  <beidson@apple.com>
3226
3227         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
3228         https://bugs.webkit.org/show_bug.cgi?id=171083
3229
3230         Unreviewed.
3231
3232         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3233
3234 2017-04-20  Brady Eidson  <beidson@apple.com>
3235
3236         Add CompletionHandlerCallChecker to SPI added in r215545.
3237         https://bugs.webkit.org/show_bug.cgi?id=171067
3238
3239         Reviewed by Dan Bernstein.
3240
3241         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3242         (TEST):
3243         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3244
3245 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3246
3247         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
3248         https://bugs.webkit.org/show_bug.cgi?id=170922
3249         <rdar://problem/31634990>
3250
3251         Reviewed by Tim Horton.
3252
3253         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
3254         WebKit2 ChangeLog for more details.
3255
3256         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3257         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
3258         (TestWebKitAPI::TEST):
3259         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
3260
3261 2017-04-20  Xan Lopez  <xlopez@igalia.com>
3262
3263         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
3264         https://bugs.webkit.org/show_bug.cgi?id=170942
3265
3266         Reviewed by Carlos Garcia Campos.
3267
3268         Update glib and glib-networking to the last stable releases. This
3269         is needed to get working TLS certificate verification at all at
3270         least in Fedora.
3271
3272         * gtk/install-dependencies: add libmount, needed for newer glib.
3273         * gtk/jhbuild.modules: update glib and glib-networking to last
3274         stable releases.
3275
3276 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
3277
3278         [ATK] Implement support for DPub ARIA roles
3279         https://bugs.webkit.org/show_bug.cgi?id=170679
3280
3281         Reviewed by Chris Fleizach.
3282
3283         Add DPub ARIA landmark roles to roleToString().
3284
3285         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3286
3287 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
3288
3289         Remove WebKitTestRunner code for enabling features that are already enabled by default
3290         https://bugs.webkit.org/show_bug.cgi?id=171033
3291
3292         Reviewed by Ryosuke Niwa.
3293
3294         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3295         (WTR::InjectedBundle::beginTesting):
3296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3297         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
3298         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
3299         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
3300         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
3301         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3302
3303 2017-04-19  Youenn Fablet  <youenn@apple.com>
3304
3305         [Mac] Allow customizing H264 encoder
3306         https://bugs.webkit.org/show_bug.cgi?id=170829
3307
3308         Reviewed by Alex Christensen.
3309
3310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3311
3312 2017-04-19  Brady Eidson  <beidson@apple.com>
3313
3314         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
3315         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
3316
3317         Reviewed by Tim Horton.
3318
3319         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3320         (TEST):
3321         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3322         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3323
3324 2017-04-19  Brady Eidson  <beidson@apple.com>
3325
3326         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
3327         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
3328
3329         Reviewed by Alex Christensen.
3330
3331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3332         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
3333
3334 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
3335
3336         [WK2] Run tests with ResourceLoadStatistics enabled
3337         https://bugs.webkit.org/show_bug.cgi?id=170952
3338
3339         Reviewed by Andy Estes.
3340
3341         Excercise the load statistics code during tests.
3342
3343         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3344         (WTR::initializeWebViewConfiguration):
3345
3346 2017-04-19  Bill Ming  <mbbill@gmail.com>
3347
3348         close_fds should be set to False on Windows.
3349         https://bugs.webkit.org/show_bug.cgi?id=170838
3350
3351         Reviewed by Brent Fulgham.
3352
3353         * Scripts/webkitpy/common/system/executive.py:
3354         (Executive._should_close_fds):
3355
3356 2017-04-19  David Kilzer  <ddkilzer@apple.com>
3357
3358         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
3359         <https://webkit.org/b/170994>
3360         <rdar://problem/29889932>
3361
3362         Reviewed by Brent Fulgham.
3363
3364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3365         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
3366         target.
3367         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
3368         (TestWebKitAPI::strip): Helper method to set/get environment
3369         variable for testing.
3370         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
3371         tests.
3372
3373 2017-04-19  JF Bastien  <jfbastien@apple.com>
3374
3375         WebAssembly: add script which can import GCC torture tests
3376         https://bugs.webkit.org/show_bug.cgi?id=170740
3377
3378         Reviewed by Saam Barati.
3379
3380         Add a script which can import the GCC torture tests and create a
3381         yaml file to run them as part of jsc's WebAssembly regression
3382         tests.
3383
3384         This patch doesn't commit the tests themselves because they're
3385         licensed differently.
3386
3387         * Scripts/run-jsc-stress-tests: learn how to run
3388         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
3389         the options because WebAssembly is enabled by default.
3390         * Scripts/update-wasm-gcc-torture.py: Added.
3391         (parse_args):
3392         (update_lkgr):
3393         (untar_torture):
3394         (list_js_files):
3395         (waterfall_known_failures):
3396         (create_yaml):
3397         (main):
3398
3399 2017-04-19  Youenn Fablet  <youenn@apple.com>
3400
3401         Import web-platform-tests/tools
3402         https://bugs.webkit.org/show_bug.cgi?id=170718
3403
3404         Reviewed by Alex Christensen.
3405
3406         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3407         (main):
3408         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3409         (WebPlatformTestServer.ports_to_forward):
3410         (WebPlatformTestServer._prepare_config):
3411         (WebPlatformTestServer._install_modules): Deleted.
3412         * Scripts/webkitpy/w3c/test_importer.py:
3413         (TestImporter.write_html_files_for_templated_js_tests):
3414
3415 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3416
3417         [WK2] Add infrastructure and unit tests for file uploads using data interaction
3418         https://bugs.webkit.org/show_bug.cgi?id=170903
3419         <rdar://problem/31314689>
3420
3421         Reviewed by Tim Horton.
3422
3423         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
3424         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
3425         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
3426         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
3427
3428         New tests:
3429         DataInteractionTests.ExternalSourceImageToFileInput
3430         DataInteractionTests.ExternalSourceHTMLToUploadArea
3431         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
3432         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
3433         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
3434
3435         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3436         (testIconImage):
3437         (temporaryURLForDataInteractionFileLoad):
3438         (cleanUpDataInteractionTemporaryPath):
3439
3440         Creates and tears down temporary file directories for testing data interaction.
3441
3442         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
3443         (TestWebKitAPI::TEST):
3444         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3445         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3446
3447         Make necessary changes to be able to test what happens when data interaction ends over an element with no
3448         operation. Previously, we would always simulate performing a data interaction operation when ending the
3449         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
3450         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
3451         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
3452         the phase to Cancelled and end the run.
3453
3454         (-[DataInteractionSimulator _resetSimulatedState]):
3455         (-[DataInteractionSimulator runFrom:to:]):
3456         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3457         (-[DataInteractionSimulator _advanceProgress]):
3458         (-[DataInteractionSimulator externalItemProviders]):
3459         (-[DataInteractionSimulator setExternalItemProviders:]):
3460
3461         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
3462         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
3463         take multiple item providers.
3464
3465         (-[DataInteractionSimulator externalItemProvider]): Deleted.
3466         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
3467
3468 2017-04-18  John Wilander  <wilander@apple.com>
3469
3470         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
3471         https://bugs.webkit.org/show_bug.cgi?id=170798
3472         <rdar://problem/31595108>
3473
3474         Reviewed by Alex Christensen.
3475
3476         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3477         (TestWebKitAPI::TEST_F):
3478             Added two negative test cases for WebCore::isPublicSuffix().
3479             Added test cases with mixed case domains, localhost, and
3480             non-ASCII for WebCore::topPrivatelyControlledDomain().
3481
3482 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
3483
3484         Unreviewed, rolling out r215346 and 215361.
3485
3486         The problem these changes were fixing was addressed in
3487         <https://trac.webkit.org/changeset/215416/webkit>.
3488
3489         Reverted changesets:
3490
3491         "webkitpy: Ignore previously launched pid when system is under
3492         stress"
3493         https://bugs.webkit.org/show_bug.cgi?id=170741
3494         http://trac.webkit.org/changeset/215346
3495         http://trac.webkit.org/changeset/215361
3496
3497 2017-04-17  Alex Christensen  <achristensen@webkit.org>
3498
3499         Allow Variants of RetainPtrs
3500         https://bugs.webkit.org/show_bug.cgi?id=170923
3501
3502         Reviewed by Tim Horton and Sam Weinig.
3503
3504         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3505         (TestWebKitAPI::TEST):
3506         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
3507         work in Variants.
3508
3509 2017-04-17  Brady Eidson  <beidson@apple.com>
3510
3511         Make WKHTTPCookieStore public.
3512         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
3513
3514         Reviewed by Geoffrey Garen.
3515
3516         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3517         (TEST):
3518
3519 2017-04-17  Youenn Fablet  <youenn@apple.com>
3520
3521         Disable outdated WritableStream API
3522         https://bugs.webkit.org/show_bug.cgi?id=170749
3523         <rdar://problem/31446233>
3524
3525         Reviewed by Alex Christensen.
3526
3527         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
3528         - A STREAMS_API compilation flag.
3529         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
3530
3531         * DumpRenderTree/mac/DumpRenderTree.mm:
3532         (enableExperimentalFeatures):
3533         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3535         (WTR::InjectedBundle::beginTesting):
3536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3537         (WTR::TestRunner::setFetchAPIEnabled):
3538         (WTR::TestRunner::setWritableStreamAPIEnabled):
3539         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
3540         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3541
3542 2017-04-17  Tim Horton  <timothy_horton@apple.com>
3543
3544         Provide a viewport parameter to disable clipping to the safe area
3545         https://bugs.webkit.org/show_bug.cgi?id=170766
3546         <rdar://problem/31564634>
3547
3548         Reviewed by Beth Dakin.
3549
3550         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3551         (WTR::UIScriptController::setObscuredInsets):
3552         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3553         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3554         (WTR::UIScriptController::setObscuredInsets):
3555         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3556         * WebKitTestRunner/ios/TestControllerIOS.mm:
3557         (WTR::TestController::platformResetStateToConsistentValues):
3558         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3559         (WTR::UIScriptController::setObscuredInsets):
3560         Add a UIScriptController mechanism to install obscured insets
3561         on the web view.
3562
3563 2017-04-17  Dan Bernstein  <mitz@apple.com>
3564
3565         [Cocoa] Move isNullFunctionPointer down into WTF
3566         https://bugs.webkit.org/show_bug.cgi?id=170892
3567
3568         Reviewed by Sam Weinig.
3569
3570         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
3571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3572         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
3573         (TestWebKitAPI::TEST):
3574         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
3575         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
3576         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
3577         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
3578
3579 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
3580
3581         webkitpy: Correct poll when killing ServerProcess
3582
3583         Unreviewed infrastructure fix.
3584
3585         * Scripts/webkitpy/port/server_process.py:
3586         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
3587
3588 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
3589
3590         [MediaStream] Enable getUserMedia API test
3591         https://bugs.webkit.org/show_bug.cgi?id=170901
3592         <rdar://problem/31656594>
3593
3594         Reviewed by Youenn Fablet.
3595
3596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
3597
3598         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3599         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3600         (TestWebKitAPI::TEST): Enable capture with mock devices.
3601         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
3602
3603 2017-04-17  Xan Lopez  <xan@igalia.com>
3604
3605         [GTK] Update the Fedora dependencies for WebKitGTK+
3606         https://bugs.webkit.org/show_bug.cgi?id=170590
3607
3608         Reviewed by Carlos Alberto Lopez Perez.
3609
3610         * gtk/install-dependencies: add a bunch of modules necessary to
3611         get a proper set of GStreamer codecs for WebRTC.
3612
3613 2017-04-16  Sam Weinig  <sam@webkit.org>
3614
3615         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
3616         https://bugs.webkit.org/show_bug.cgi?id=170843
3617
3618         Reviewed by Chris Dumez.
3619
3620         * DumpRenderTree/DerivedSources.make:
3621         * WebKitTestRunner/DerivedSources.make:
3622         * Scripts/webkitpy/bindings/main.py:
3623         (BindingsTests.generate_from_idl):
3624         Pass IDLAttributes.json, as it is now mandatory to have one.
3625
3626 2017-04-14  Mark Lam  <mark.lam@apple.com>
3627
3628         Update architectures in xcconfig files.
3629         https://bugs.webkit.org/show_bug.cgi?id=170867
3630         <rdar://problem/31628104>
3631
3632         Reviewed by Joseph Pecoraro.
3633
3634         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3635         * MobileMiniBrowser/Configurations/Base.xcconfig:
3636         * TestWebKitAPI/Configurations/Base.xcconfig:
3637         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3638         * WebKitTestRunner/Configurations/Base.xcconfig:
3639
3640 2017-04-14  Brady Eidson  <beidson@apple.com>
3641
3642         Fix basic WKURLSchemeHandler bugs.
3643         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
3644
3645         Reviewed by Andy Estes.
3646
3647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3648         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
3649         (-[SchemeHandler initWithData:mimeType:]):
3650         (-[SchemeHandler dealloc]):
3651         (-[SchemeHandler webView:startTask:]):
3652         (-[SchemeHandler webView:stopTask:]):
3653         (TEST):
3654