14d714bb34a5e0a240625903a37bbb3d168ea740
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-23  Beth Dakin  <bdakin@apple.com> + Dan Saunders  <dasau@microsoft.com>
2
3         No reliable way to get a snapshot of WKWebView (macOS)
4         https://bugs.webkit.org/show_bug.cgi?id=161450
5         -and corresponding-
6         <rdar://problem/23846039>
7
8         Reviewed by Tim Horton.
9
10         Test for WKWebView’s new API takeSnapshotWithConfiguration:completionHandler:
11
12         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Added.
14         (convertToCGImage):
15         (getPixelIndex):
16         (TEST):
17
18 2017-02-23  Saam Barati  <sbarati@apple.com>
19
20         Speculative fix for jsc timing out tests
21         https://bugs.webkit.org/show_bug.cgi?id=168791
22
23         Rubber Stamped by Keith Miller.
24
25         Play musical chairs with IRC and Briggs options on
26         ftl-eager and ftl-eager-no-cjit.
27
28         * Scripts/run-jsc-stress-tests:
29
30 2017-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
31
32         Improve error message when the WPT server fails to start.
33         https://bugs.webkit.org/show_bug.cgi?id=168759
34
35         Reviewed by Ryosuke Niwa.
36
37         Check if the WPT server is running after 1 second, and if is not
38         print useful information for helping the user to debug the issue.
39
40         Using check_running_pid() to check if the process is still running
41         doesn't work. A process started via subprocess popen that has ended
42         will be in a zombie state until a call to wait/communicate/poll
43         is done, or until the object is deleted or garbage collected.
44
45         This adds also support for testing the behaviour of subprocess
46         poll() on the unit tests that use MockProcess.
47
48         A new test is added also for the battery of tests for the WPT
49         server.
50
51         * Scripts/webkitpy/common/system/executive_mock.py:
52         (MockProcess.__init__):
53         (MockProcess.wait):
54         (MockProcess.communicate):
55         (MockProcess.poll):
56         (MockExecutive.popen):
57         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
58         (WebPlatformTestServer.__init__):
59         (WebPlatformTestServer._prepare_config):
60         (WebPlatformTestServer._spawn_process):
61         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
62         (TestWebPlatformTestServer.test_corrupted_subserver_files):
63         (TestWebPlatformTestServer):
64         (TestWebPlatformTestServer.test_server_fails_to_start_throws_exception):
65
66 2017-02-23  Wenson Hsieh  <wenson_hsieh@apple.com>
67
68         Unreviewed, temporarily disable DataInteractionTests in TestWebKitAPI.
69
70         These will be reenabled in https://bugs.webkit.org/show_bug.cgi?id=168602.
71
72         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
73
74 2017-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
75
76         Data interaction causes selection to fall out of sync between web/UI processes
77         https://bugs.webkit.org/show_bug.cgi?id=168735
78         <rdar://problem/30657817>
79
80         Reviewed by Tim Horton.
81
82         Adds a new method to TestWKWebView for querying selection view rects from the UI process and augments data
83         interaction unit tests to check for selection rects using this new hook.
84
85         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
86         (makeCGRectValue):
87         (TestWebKitAPI::TEST):
88         * TestWebKitAPI/cocoa/TestWKWebView.h:
89         * TestWebKitAPI/cocoa/TestWKWebView.mm:
90         (-[TestWKWebView selectionRectsAfterPresentationUpdate]):
91         * TestWebKitAPI/ios/DataInteractionSimulator.h:
92         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
93         (-[DataInteractionSimulator _resetSimulatedState]):
94         (-[DataInteractionSimulator runFrom:to:]):
95         (-[DataInteractionSimulator finalSelectionRects]):
96
97 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
98
99         Better handle Thread and RunLoop initialization
100         https://bugs.webkit.org/show_bug.cgi?id=167828
101
102         Reviewed by Yusuke Suzuki.
103
104         Remove unnecessary calls to WTF::initializeMainThread().
105
106         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
107         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
108         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
109         (TestWebKitAPI::ContentExtensionTest::SetUp):
110         * WebKitTestRunner/TestController.cpp:
111         (WTR::TestController::initialize):
112
113 2017-02-22  Myles C. Maxfield  <mmaxfield@apple.com>
114
115         [Cocoa] Remove Yosemite-specific font lookup code
116         https://bugs.webkit.org/show_bug.cgi?id=168682
117
118         Reviewed by Zalan Bujtas.
119
120         * DumpRenderTree/mac/DumpRenderTree.mm:
121         (fontWhitelist):
122         (adjustFonts):
123         (createWebViewAndOffscreenWindow):
124         (drt_NSFontManager_availableFontFamilies): Deleted.
125         (drt_NSFontManager_availableFonts): Deleted.
126         (swizzleNSFontManagerMethods): Deleted.
127         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
128         (WTR::activateFonts):
129         (WTR::allowedFontFamilySet): Deleted.
130         (WTR::systemHiddenFontFamilySet): Deleted.
131         (WTR::wtr_NSFontManager_availableFontFamilies): Deleted.
132         (WTR::wtr_NSFontManager_availableFonts): Deleted.
133         (WTR::swizzleNSFontManagerMethods): Deleted.
134         * WebKitTestRunner/mac/TestControllerMac.mm:
135         (WTR::generateWhitelist):
136         (WTR::TestController::platformInitializeContext):
137
138 2017-02-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
139
140         AutoInstaller should not skip the install step if the package is downloaded but not installed
141         https://bugs.webkit.org/show_bug.cgi?id=168737
142
143         Reviewed by Ryosuke Niwa.
144
145         Don't skip the install step if the package target path don't exists.
146         Fix the description for "should_refresh" optional argument.
147
148         * Scripts/webkitpy/common/system/autoinstall.py:
149         (AutoInstaller.install):
150
151 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
152
153         [GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
154         https://bugs.webkit.org/show_bug.cgi?id=168721
155
156         Reviewed by Michael Catanzaro.
157
158         Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
159         criticals.
160
161         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
162         (WTR::EventSenderProxy::continuousMouseScrollBy):
163
164 2017-02-21  Youenn Fablet  <youenn@apple.com>
165
166         [WebRTC][Mac] Activate libwebrtc
167         https://bugs.webkit.org/show_bug.cgi?id=167293
168         <rdar://problem/30401864>
169
170         Reviewed by Alex Christensen.
171
172         Fixing paths to allow loading libwebrtc.dylib successfully.
173
174         * Scripts/build-webkit:
175         * Scripts/webkitdirs.pm:
176         (setupMacWebKitEnvironment):
177         (setupIOSWebKitEnvironment):
178         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
179
180 2017-02-21  Saam Barati  <sbarati@apple.com>
181
182         Add the Briggs optimistic allocator to run on ARM64
183         https://bugs.webkit.org/show_bug.cgi?id=168454
184
185         Reviewed by Filip Pizlo.
186
187         * Scripts/run-jsc-stress-tests:
188
189 2017-02-20  Filip Pizlo  <fpizlo@apple.com>
190
191         The collector thread should only start when the mutator doesn't have heap access
192         https://bugs.webkit.org/show_bug.cgi?id=167737
193
194         Reviewed by Keith Miller.
195         
196         Make more tests collect continuously.
197
198         * Scripts/run-jsc-stress-tests:
199
200 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
201
202         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
203         https://bugs.webkit.org/show_bug.cgi?id=168620
204         <rdar://problem/30617772>
205
206         Reviewed by Tim Horton.
207         
208         Add a setting that allows one to toggle subpixel-antialiased layer text on and off.
209
210         * DumpRenderTree/mac/DumpRenderTree.mm:
211         (resetWebPreferencesToConsistentValues):
212         * MiniBrowser/mac/SettingsController.h:
213         * MiniBrowser/mac/SettingsController.m:
214         (-[SettingsController _populateMenu]):
215         (-[SettingsController validateMenuItem:]):
216         (-[SettingsController toggleSubpixelAntialiasedLayerTextEnabled:]):
217         (-[SettingsController subpixelAntialiasedLayerTextEnabled]):
218         * MiniBrowser/mac/WK1BrowserWindowController.m:
219         (-[WK1BrowserWindowController didChangeSettings]):
220         * MiniBrowser/mac/WK2BrowserWindowController.m:
221         (-[WK2BrowserWindowController didChangeSettings]):
222         * WebKitTestRunner/TestController.cpp:
223         (WTR::TestController::resetPreferencesToConsistentValues):
224
225 2017-02-21  Jonathan Bedard  <jbedard@apple.com>
226
227         webkitpy: Refactor Device class
228         https://bugs.webkit.org/show_bug.cgi?id=168332
229
230         Reviewed by Alexey Proskuryakov.
231
232         Separate the more specific SimulatedDevice from the abstract
233         idea of a device.
234
235         * Scripts/webkitpy/xcode/device.py: Added.
236         (Device):  Base device class.
237         (Device.__init__): Initialize _host, name and udid.
238         (Device.install_app): Function declaration.
239         (Device.launch_app): Ditto.
240         (Device.__eq__): Compare two devices by udid.
241         (Device.__ne__): Ditto.
242         (Device.__repr__): Return device name and udid in formatted string.
243         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/simulator.py.
244         (SimulatedDevice):
245         (SimulatedDevice.__init__): Call Device.__init__ first.
246         (SimulatedDevice.delete): Device -> SimulatedDevice.
247         (SimulatedDevice.reset): Ditto.
248         (SimulatedDevice.__eq__): Moved to device.py.
249         (SimulatedDevice.__ne__): Ditto.
250         (SimulatedDevice.__repr__): Call Device __repr__ first.
251         (DeviceType): Kept in Scripts/webkitpy/xcode/simulator.py.
252         (Runtime): Kept in Scripts/webkitpy/xcode/simulator.py.
253         (Device): Renamed SimulatedDevice.
254         (Simulator): Kept in Scripts/webkitpy/xcode/simulator.py.
255         * Scripts/webkitpy/xcode/simulator.py:
256         (Simulator): Define Simulator.Device class as None.
257         (Simulator.__init__): Import SimulatedDevice as Simulator.Device.
258         (Simulator.delete_device): Use Simulator.Device.
259         (Simulator.reset_device): Ditto.
260         (Simulator._parse_devices): Ditto.
261         (Simulator.lookup_or_create_device): Make 
262         (Device): Moved to simulated_device as SimulatedDevice.
263
264 2017-02-21  JF Bastien  <jfbastien@apple.com>
265
266         Fix cmake build
267         https://bugs.webkit.org/show_bug.cgi?id=168665
268
269         Reviewed by Mark Lam.
270
271         It was broken by r212555 and r212681.
272
273         * DumpRenderTree/PlatformMac.cmake:
274
275 2017-02-21  Alexey Proskuryakov  <ap@apple.com>
276
277         Improve bot watcher's dashboard performance
278         https://bugs.webkit.org/show_bug.cgi?id=168624
279         <rdar://problem/30190109>
280
281         Reviewed by Daniel Bates.
282
283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
284         There was an unnecessary linear complexity algorithm in indexOfRevision().
285
286 2017-02-21  Alex Christensen  <achristensen@webkit.org>
287
288         Unreviewed, rolling out r212699.
289
290         Internal build not ready
291
292         Reverted changeset:
293
294         "[WebRTC][Mac] Activate libwebrtc"
295         https://bugs.webkit.org/show_bug.cgi?id=167293
296         http://trac.webkit.org/changeset/212699
297
298 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
299
300         Remove ENABLE_THREADED_COMPOSITOR build option
301         https://bugs.webkit.org/show_bug.cgi?id=168606
302
303         Reviewed by Michael Catanzaro.
304
305         * Scripts/webkitperl/FeatureList.pm:
306
307 2017-02-20  Youenn Fablet  <youenn@apple.com>
308
309         [WebRTC][Mac] Activate libwebrtc
310         https://bugs.webkit.org/show_bug.cgi?id=167293
311         <rdar://problem/30401864>
312
313         Reviewed by Alex Christensen.
314
315         Fixing paths to allow loading libwebrtc.dylib successfully.
316
317         * Scripts/build-webkit:
318         * Scripts/webkitdirs.pm:
319         (setupMacWebKitEnvironment):
320         (setupIOSWebKitEnvironment):
321
322 2017-02-20  Ryan Haddad  <ryanhaddad@apple.com>
323
324         Unreviewed, rolling out r212685.
325
326         This change broke the 32-bit Sierra build.
327
328         Reverted changeset:
329
330         "Resource Load Statistics: Add alternate classification
331         method"
332         https://bugs.webkit.org/show_bug.cgi?id=168347
333         http://trac.webkit.org/changeset/212685
334
335 2017-02-20  John Wilander  <wilander@apple.com>
336
337         Resource Load Statistics: Add alternate classification method
338         https://bugs.webkit.org/show_bug.cgi?id=168347
339         <rdar://problem/30352793>
340
341         Reviewed by Alex Christensen.
342
343         Added three testRunner functions to facilitate layout tests:
344         - setStatisticsSubframeUnderTopFrameOrigin()
345         - setStatisticsSubresourceUnderTopFrameOrigin()
346         - setStatisticsSubresourceUniqueRedirectTo()
347
348         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
349         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
350         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
351         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
352         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
353         * WebKitTestRunner/InjectedBundle/TestRunner.h:
354         * WebKitTestRunner/TestController.cpp:
355         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
356         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
357         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
358         * WebKitTestRunner/TestController.h:
359         * WebKitTestRunner/TestInvocation.cpp:
360         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
361
362 2017-02-20  Anders Carlsson  <andersca@apple.com>
363
364         Use the new drag code path when dragging links
365         https://bugs.webkit.org/show_bug.cgi?id=168612
366
367         Reviewed by Tim Horton.
368
369         If a type is not dynamic, just use the static UTI.
370
371         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
372         (-[LocalPasteboard writeObjects:]):
373
374 2017-02-17  Anders Carlsson  <andersca@apple.com>
375
376         Add a new drag code path and use it for dragging plain text
377         https://bugs.webkit.org/show_bug.cgi?id=168534
378
379         Reviewed by Geoffrey Garen.
380
381         Update the testing infrastructure to handle NSDraggingSession.
382
383         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
384         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m.
385         (-[LocalPasteboard writeObjects:]):
386         Implement this in terms of the legacy pasteboard API.
387
388         * DumpRenderTree/mac/EventSendingController.mm:
389         (drt_WebHTMLView_beginDraggingSessionWithItemsEventSource):
390         (+[EventSendingController initialize]):
391         Swizzle the drag method instead of adding a delegate method (like the old code does).
392
393 2017-02-20  Florian Bruhin  <git@the-compiler.org>
394
395         Handle EINTR during webkitpy server process select()
396         https://bugs.webkit.org/show_bug.cgi?id=168361
397
398         Reviewed by Michael Catanzaro.
399
400         Otherwise, on my machine, resizing the terminal run-webkit-tests is running in
401         makes it die.
402
403         * Scripts/webkitpy/port/server_process.py:
404         (ServerProcess._wait_for_data_and_update_buffers_using_select):
405
406 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
407
408         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu.
409
410         It can happen that the window onload event is dispatched after the load finished is received in the UI
411         process. Move the script to select the text to the body instead of using a window onload handler.
412
413         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
414         (testContextMenuDefaultMenu):
415
416 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
417
418         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
419         https://bugs.webkit.org/show_bug.cgi?id=167693
420
421         Reviewed by Sergio Villar Senin.
422
423         * Scripts/webkitperl/FeatureList.pm:
424         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
425         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
426         (TestWebKitAPI::computeNumberOfTracks):
427         (TestWebKitAPI::TEST):
428         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
429         (TestWebKitAPI::TEST):
430
431 2017-02-19  Commit Queue  <commit-queue@webkit.org>
432
433         Unreviewed, rolling out r212466.
434         https://bugs.webkit.org/show_bug.cgi?id=168577
435
436         causes crashes on AArch64 on linux, maybe it's causing crashes
437         on iOS too (Requested by pizlo on #webkit).
438
439         Reverted changeset:
440
441         "The collector thread should only start when the mutator
442         doesn't have heap access"
443         https://bugs.webkit.org/show_bug.cgi?id=167737
444         http://trac.webkit.org/changeset/212466
445
446 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
447
448         Fix failure from r212579.
449
450         Unreviewed build-fix.
451
452         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
453         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
454
455 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
456
457         EWS should run JavaScriptCore tests
458         https://bugs.webkit.org/show_bug.cgi?id=162458
459
460         Reviewed by Alexey Proskuryakov.
461
462         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
463         * QueueStatusServer/model/queuestatus.py:
464         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
465         * QueueStatusServer/handlers/statusbubble.py:
466         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
467         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
468         (MockSCM.__init__): Add _mockChangedFiles variable.
469         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
470         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
471         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
472         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
473         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
474         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
475         (MacPort.run_webkit_tests_command): Check for JSC.
476         * Scripts/webkitpy/common/config/ports_mock.py:
477         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
478         * Scripts/webkitpy/common/config/ports_unittest.py:
479         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
480         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
481         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
482         (AbstractTestResults.test_results): Stub.
483         (AbstractTestResults.failing_tests): Stub.
484         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
485         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
486         (JSCTestResults): Added.
487         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
488         (JSCTestResults.results_from_string): Use json library to parse results.
489         (JSCTestResults.__init__): Initialize members.
490         (JSCTestResults.equals): This enables unit testing.
491         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
492         (JSCTestResults.all_passed): Getter.
493         (JSCTestResults.failing_tests): Getter.
494         (JSCTestResults.did_exceed_test_failure_limit): Getter.
495         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
496         (JSCTestResultsTest): Class to test JSCTestResults.
497         (JSCTestResultsTest.test_results_from_string): Tests parsing.
498         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
499         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
500         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
501         * Scripts/webkitpy/port/base.py:
502         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
503         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
504         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
505         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
506         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
507         (MockPatchAnalysisTask.__init__): Sets attributes.
508         (MockPatchAnalysisTask._test): Override to not run command.
509         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
510         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
511         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
512         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
513         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
514         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
515         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
516         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
517         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
518         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
519         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
520         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
521         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
522         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
523         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
524         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
525         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
526         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
527         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
528         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
529         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
530         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
531         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
532         (JSCTestResultsReader): Reads results file.
533         (JSCTestResultsReader.__init__): Sets attributes.
534         (JSCTestResultsReader._read_file_contents): Reads file.
535         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
536         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
537         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
538         (PatchAnalysisTask._check_patch_relevance): Added.
539         (PatchAnalysisTask._build): Check for JSC.
540         (PatchAnalysisTask._build_without_patch): Check for JSC.
541         (PatchAnalysisTask._test): Check for JSC.
542         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
543         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
544         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
545         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
546         * Scripts/webkitpy/tool/commands/download.py:
547         (CheckPatchRelevance): Add check-patch-relevance command.
548         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
549         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
550         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
551         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
552         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
553         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
554         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
555         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
556         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
557         (TestEWS): Sample layout test EWS class used for unit testing.
558         (TestJSCEWS): Sample JSC EWS class used for unit testing.
559         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
560         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
561         (AbstractEarlyWarningSystemTest): Add _group variable.
562         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
563         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
564         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
565         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
566         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
567         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
568         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
569         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
570         * Scripts/webkitpy/tool/steps/build.py:
571         (Build.options): Check for JSC.
572         (Build.build): Check for JSC.
573         (Build.run): Check for JSC.
574         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
575         (CheckPatchRelevance): Added.
576         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
577         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
578         * Scripts/webkitpy/tool/steps/options.py:
579         (Options): Add --group command line option.
580         * Scripts/webkitpy/tool/steps/runtests.py:
581         (RunTests.options): Add group.
582         (RunTests.run): Check for JSC.
583         (RunTests._run_webkit_tests): Check for JSC.
584         (RunTests): Add _group attribute.
585         (RunTests._run_javascriptcore_tests): New.
586         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
587
588 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
589
590         Fix tools that were broken by Efl removal
591         https://bugs.webkit.org/show_bug.cgi?id=168496
592
593         Reviewed by Alexey Proskuryakov.
594
595         * QueueStatusServer/config/queues.py:
596         * Scripts/webkitpy/common/config/ews.json:
597         * TestResultServer/static-dashboards/builders.jsonp:
598         * TestResultServer/static-dashboards/flakiness_dashboard.js:
599         * TestResultServer/static-dashboards/loader_unittests.js:
600
601 2017-02-16  Lucas Forschler  <lforschler@apple.com>
602
603         https://bugs.webkit.org/show_bug.cgi?id=168442
604         Move the SVN checkout from http -> https.
605         Update unit tests.
606
607         Reviewed by Alexey Proskuryakov.
608
609         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
610         (CheckOutSource.__init__):
611         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
612         (SVNMirrorTest.get_SVNMirrorFromConfig):
613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
614
615 2017-02-16  Commit Queue  <commit-queue@webkit.org>
616
617         Unreviewed, rolling out r212514.
618         https://bugs.webkit.org/show_bug.cgi?id=168489
619
620         broke test runner (Requested by alexchristensen on #webkit).
621
622         Reverted changeset:
623
624         "Remove EFL-specific files in Tools."
625         http://trac.webkit.org/changeset/212514
626
627 2017-02-16  Alex Christensen  <achristensen@webkit.org>
628
629         Remove EFL-specific files in Tools.
630
631         Rubber-stamped by Anders Carlsson.
632
633         * ImageDiff/efl: Removed.
634         * ImageDiff/efl/ImageDiff.cpp: Removed.
635         * MiniBrowser/efl: Removed.
636         * MiniBrowser/efl/CMakeLists.txt: Removed.
637         * MiniBrowser/efl/main.c: Removed.
638         * Scripts/run-efl-tests: Removed.
639         * Scripts/update-webkitefl-libs: Removed.
640         * Scripts/webkitpy/port/efl.py: Removed.
641         * Scripts/webkitpy/port/efl_unittest.py: Removed.
642         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
643         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
644         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
645         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
646         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
647         * TestWebKitAPI/efl: Removed.
648         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
649         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
650         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
651         * TestWebKitAPI/efl/main.cpp: Removed.
652         * WebKitTestRunner/InjectedBundle/efl: Removed.
653         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
654         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
655         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
656         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
657         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
658         * WebKitTestRunner/efl: Removed.
659         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
660         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
661         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
662         * WebKitTestRunner/efl/main.cpp: Removed.
663         * efl: Removed.
664         * efl/install-dependencies: Removed.
665         * efl/jhbuild-optional.modules: Removed.
666         * efl/jhbuild.modules: Removed.
667         * efl/jhbuildrc: Removed.
668         * efl/patches: Removed.
669         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
670         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
671         * efl/patches/gst-libav.patch: Removed.
672         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
673         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
674         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
675         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
676
677 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
678
679         font-weight in @font-face can cause a font to be downloaded even when it's not used
680         https://bugs.webkit.org/show_bug.cgi?id=168114
681         <rdar://problem/30301317>
682
683         Reviewed by Darin Adler.
684
685         LastResort needs to be usable in tests.
686
687         * DumpRenderTree/mac/DumpRenderTree.mm:
688         (allowedFontFamilySet):
689         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
690         (WTR::allowedFontFamilySet):
691         * WebKitTestRunner/mac/TestControllerMac.mm:
692         (WTR::allowedFontFamilySet):
693
694 2017-02-16  Alex Christensen  <achristensen@webkit.org>
695
696         Remove old URL parser
697         https://bugs.webkit.org/show_bug.cgi?id=168483
698
699         Reviewed by Tim Horton.
700
701         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
702         (TestWebKitAPI::checkURL):
703         (TestWebKitAPI::checkRelativeURL):
704         (TestWebKitAPI::checkURLDifferences):
705         (TestWebKitAPI::checkRelativeURLDifferences):
706
707 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
708
709         [WK2] Add additional test infrastructure and unit tests for data interaction
710         https://bugs.webkit.org/show_bug.cgi?id=168439
711         <rdar://problem/30557942>
712
713         Reviewed by Tim Horton.
714
715         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
716         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
717         support data interaction from  See per-method descriptions below for more details.
718
719         * Configurations/TestWebKitAPI.xcconfig:
720
721         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
722
723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724
725         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
726         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
727
728         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
729         (-[TestWKWebView editorContainsImageElement]):
730         (-[TestWKWebView editorValue]):
731
732         New helper methods for querying information from the "editor" element in a test page.
733
734         (TestWebKitAPI::TEST):
735         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
736
737         Moves logic for capturing events during a simulated data interaction run from the test file to
738         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
739
740         * TestWebKitAPI/cocoa/TestWKWebView.h:
741         * TestWebKitAPI/cocoa/TestWKWebView.mm:
742         (-[TestMessageHandler removeMessage:]):
743         (-[TestWKWebView clearMessageHandlers:]):
744
745         Add the ability to clear message handlers from the TestWKWebView.
746
747         * TestWebKitAPI/ios/DataInteractionSimulator.h:
748         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
749         (dataInteractionEventNames):
750         (-[DataInteractionSimulator initWithWebView:]):
751         (-[DataInteractionSimulator _resetSimulatedState]):
752
753         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
754         simulating data interaction.
755
756         (-[DataInteractionSimulator observedEventNames]):
757
758         Returns a list of the names of events relevant to data interaction that were observed over the course of the
759         most recent run.
760
761         (-[DataInteractionSimulator runFrom:to:]):
762
763         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
764         to run the same data interaction for multiple simulated gestures.
765
766         (-[DataInteractionSimulator _advanceProgress]):
767         (-[DataInteractionSimulator _finishDataInteraction]):
768         (-[DataInteractionSimulator externalItemProvider]):
769         (-[DataInteractionSimulator setExternalItemProvider:]):
770
771         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
772         phase of a test run.
773
774         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
775         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
776         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
777         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
778
779         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
780         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
781         wherein the the web process might take longer than usual to process the request to start data interaction, and
782         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
783         the web process is received, which then causes no simulated delegate methods to be fired.
784
785         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
786         (-[DataInteractionSimulator run]): Deleted.
787
788 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
789
790         Remove unused test pages in TestWebKitAPI
791         https://bugs.webkit.org/show_bug.cgi?id=168462
792
793         Reviewed by Anders Carlsson.
794
795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
796         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
797         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
798         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
799         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
800         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
801
802 2017-02-16  Alex Christensen  <achristensen@webkit.org>
803
804         Special URLs without a host are invalid
805         https://bugs.webkit.org/show_bug.cgi?id=168461
806
807         Reviewed by Tim Horton.
808
809         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
810         (TestWebKitAPI::TEST_F):
811
812 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
813
814         The collector thread should only start when the mutator doesn't have heap access
815         https://bugs.webkit.org/show_bug.cgi?id=167737
816
817         Reviewed by Keith Miller.
818         
819         Make more tests collect continuously.
820
821         * Scripts/run-jsc-stress-tests:
822
823 2017-02-16  Tim Horton  <timothy_horton@apple.com>
824
825         WKWebView inside a UICollectionView flashes when items are inserted above it
826         https://bugs.webkit.org/show_bug.cgi?id=168376
827         <rdar://problem/29322051>
828
829         Reviewed by Simon Fraser.
830
831         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
832         (-[TestRunnerWKWebView _setStableStateOverride:]):
833         Update the one external caller of this internal method...
834
835         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
836         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
837         * DumpRenderTree/mac/UIScriptControllerMac.mm:
838         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
839         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
840         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
841         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
842         * TestRunnerShared/UIScriptContext/UIScriptController.h:
843         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
844         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
845         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
846         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
847         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
848         back after we dispatch a visible content rect update from the UI process
849         to the Web Content process, so any messages sent from the block will arrive
850         after the visible content rect update.
851
852 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
853
854         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
855         https://bugs.webkit.org/show_bug.cgi?id=168321
856
857         This bots should be added to the trunk build scheduler.
858         Unreviewed fix after r212429.
859
860         * BuildSlaveSupport/build.webkit.org-config/config.json:
861
862 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
863
864         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
865         https://bugs.webkit.org/show_bug.cgi?id=168321
866
867         Reviewed by Michael Catanzaro.
868
869         The additionalArgument --default-cmake-features is used both to
870         skip the JHBuild (InstallGtkDependencies) build step and to build
871         with the default features from the CMake config.
872
873         * BuildSlaveSupport/build.webkit.org-config/config.json:
874         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
875         (Factory.__init__):
876         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
877
878 2017-02-15  Lucas Forschler  <lforschler@apple.com>
879
880         https://bugs.webkit.org/show_bug.cgi?id=168386
881         Remove EFL from build.webkit.org
882
883         Reviewed by Alex Christensen
884
885         * BuildSlaveSupport/build.webkit.org-config/config.json:
886         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
887         (DeleteStaleBuildFiles.start):
888         (appendCustomBuildFlags):
889         (RunWebKitTests.start):
890         (RunBuiltinsTests):
891         (Factory.__init__):
892         (TestFactory.__init__):
893         (loadBuilderConfig):
894         (InstallEflDependencies): Deleted.
895         (RunEflAPITests): Deleted.
896         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
898         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
899         (BubbleQueueServer):
900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
902         (Analyzer.prototype._triggeringQueue):
903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
904         (WebKitBuildbot):
905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
906         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
907         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
908         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
909         (_should_file_trigger_build):
910
911 2017-02-15  Alex Christensen  <achristensen@webkit.org>
912
913         Unreviewed, rolling out r212169.
914
915         Broke iOS WebInspector
916
917         Reverted changeset:
918
919         "WebInspector: refactor RemoteInspector to move cocoa specific
920         code to their own files"
921         https://bugs.webkit.org/show_bug.cgi?id=166681
922         http://trac.webkit.org/changeset/212169
923
924 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
925
926         webkitpy: Fix DarwinPort._get_crash_log()
927         https://bugs.webkit.org/show_bug.cgi?id=168372
928         <rdar://problem/30535156>
929
930         Reviewed by Daniel Bates.
931
932         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
933         DarwinPort should return the expected return value for _get_crash_log.
934
935         * Scripts/webkitpy/port/darwin.py:
936         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
937
938 2017-02-15  Chris Dumez  <cdumez@apple.com>
939
940         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
941         https://bugs.webkit.org/show_bug.cgi?id=168291
942         <rdar://problem/30508593>
943
944         Reviewed by Tim Horton.
945
946         Drop overridePreference() implementation in iOS's UIScriptController
947         as it was only used for the minimum font size setting and this setting
948         is not exposed on iOS.
949
950         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
951         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
952         (WTR::UIScriptController::overridePreference):
953         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
954
955 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
956
957         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
958         https://bugs.webkit.org/show_bug.cgi?id=168329
959         <rdar://problem/30518832>
960
961         Reviewed by Daniel Bates.
962
963         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
964         never change given the same input arguments.  Memoize function for efficiency.
965
966         * Scripts/webkitpy/port/darwin.py: Add memoized import.
967         (DarwinPort):
968         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
969         
970
971 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
972
973         webkitpy: Remove unused import from darwin.py
974         https://bugs.webkit.org/show_bug.cgi?id=168371
975
976         Reviewed by Alex Christensen.
977
978         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
979
980 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
981
982         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
983         https://bugs.webkit.org/show_bug.cgi?id=168364
984
985         Reviewed by Michael Catanzaro.
986
987         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
988         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
989         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
990
991         Fixes: http/tests/security/credentials-from-different-domains.html
992                http/tests/xmlhttprequest/cross-origin-no-authorization.html
993
994         * gtk/jhbuild.modules:
995         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
996         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
997
998 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
999
1000         [GTK] Update cookie manager API to properly work with ephemeral sessions
1001         https://bugs.webkit.org/show_bug.cgi?id=168230
1002
1003         Reviewed by Michael Catanzaro.
1004
1005         Update unit tests and add new cases for the new API.
1006
1007         * MiniBrowser/gtk/main.c:
1008         (gotWebsiteDataCallback):
1009         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1010         (testCookieManagerEphemeral):
1011         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1012         (testWebContextEphemeral):
1013         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1014         (testWebViewEphemeral):
1015         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1016         (serverCallback):
1017         (testWebsiteDataEphemeral):
1018         (testWebsiteDataCookies):
1019         (beforeAll):
1020
1021 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1022
1023         [WK2] Support data interaction on links
1024         https://bugs.webkit.org/show_bug.cgi?id=168331
1025         <rdar://problem/30200837>
1026
1027         Reviewed by Tim Horton.
1028
1029         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
1030         editable area results in the link URL being inserted.
1031
1032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1033         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1034         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1035         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1036         (TestWebKitAPI::TEST):
1037
1038 2017-02-14  Jason Rinn  <jrinn@apple.com>
1039
1040         Add a test for new WebKit Cocoa API, _getContentsAsString.
1041         https://bugs.webkit.org/show_bug.cgi?id=168147
1042         <rdar://problem/30502539>
1043
1044         Reviewed by Tim Horton.
1045
1046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1047         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
1048         (TEST):
1049
1050 2017-02-14  Matt Rajca  <mrajca@apple.com>
1051
1052         Website policies: iframes should respect the autoplay policy of the top-level document
1053         https://bugs.webkit.org/show_bug.cgi?id=168333
1054
1055         Reviewed by Alex Christensen.
1056
1057         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
1058         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
1059         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1060         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1061         (TEST):
1062
1063 2017-02-14  Chris Dumez  <cdumez@apple.com>
1064
1065         HTML Form Validation bubble should take minimum font size setting into consideration
1066         https://bugs.webkit.org/show_bug.cgi?id=168271
1067         <rdar://problem/29869869>
1068
1069         Reviewed by Simon Fraser.
1070
1071         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
1072         font size of the validation bubble.
1073
1074         Add an overridePreference() method to UIScriptController. This is currently
1075         used to override the value of the minimumFontSize setting. testRunner's
1076         overridePreference() is not usable on WK2 because it does not update the
1077         value of the preference on the UIProcess side.
1078
1079         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1080         (WTR::UIScriptController::overridePreference):
1081         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1082         (WTR::UIScriptController::overridePreference):
1083         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1084         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1085         * WebKitTestRunner/TestController.cpp:
1086         (WTR::TestController::resetPreferencesToConsistentValues):
1087         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1088         (WTR::UIScriptController::overridePreference):
1089         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1090         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1091         (WTR::UIScriptController::overridePreference):
1092
1093 2017-02-14  Florian Bruhin  <git@the-compiler.org>
1094
1095         Use a set instead of a list for tests when parsing expectations
1096         https://bugs.webkit.org/show_bug.cgi?id=168304
1097
1098         In _collect_matching_tests, a lot of membership tests are done on a giant list
1099         of strings. By making it a set instead, we can make those much faster, and
1100         there's no reason for it to be a list.
1101
1102         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
1103         to 3s on my machine.
1104
1105         Reviewed by Ryosuke Niwa.
1106
1107         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1108         (TestExpectationParser.__init__):
1109         (TestExpectationParser._collect_matching_tests):
1110
1111 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
1112
1113         Unreviewed build-fix after r212297.
1114
1115         * Scripts/webkitpy/port/simulator_process.py:
1116         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
1117
1118 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1119
1120         [CMake] build-webkit should allow building with the default cmake configuration
1121         https://bugs.webkit.org/show_bug.cgi?id=168323
1122
1123         Reviewed by Michael Catanzaro.
1124
1125         Add a --default-cmake-features switch that makes the script pass
1126         no value for any of the features defined by build-webkit, that
1127         way the default values from the port cmake config will be used.
1128
1129         * Scripts/build-webkit:
1130         (cMakeArgsFromFeatures):
1131
1132 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
1133
1134         Unreviewed build-fix after r212297.
1135
1136         * Scripts/webkitpy/port/simulator_process.py:
1137         (SimulatorProcess.stop): Handle case where there is no process to kill.
1138
1139 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1140
1141         [CMake] build-webkit should print the cmake command executed
1142         https://bugs.webkit.org/show_bug.cgi?id=168318
1143
1144         Reviewed by Michael Catanzaro.
1145
1146         Run the cmake commands to configure or start the build through
1147         a wrapper that prints the command before executing it.
1148
1149         * Scripts/webkitdirs.pm:
1150         (systemVerbose):
1151         (generateBuildSystemFromCMakeProject):
1152         (buildCMakeGeneratedProject):
1153         (cleanCMakeGeneratedProject):
1154
1155 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
1156
1157         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
1158         https://bugs.webkit.org/show_bug.cgi?id=168150
1159
1160         Reviewed by Alexey Proskuryakov.
1161
1162         * Scripts/webkitpy/port/simulator_process.py:
1163         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
1164         (SimulatorProcess._kill): Move closing of app into stop().
1165         * Scripts/webkitpy/xcode/simulator.py:
1166         (Device.launch_app):
1167         (Device.terminate_app): Deleted.
1168
1169 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1170
1171         REGRESSION(r212192): [GTK] Broke downloads API tests
1172         https://bugs.webkit.org/show_bug.cgi?id=168193
1173
1174         Unreviewed. Update test expectations after r212192.
1175
1176         The suggested filename now includes a file extensions if the MIME type is known.
1177
1178         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1179         (testDownloadRemoteFile):
1180         (testDownloadMIMEType):
1181
1182 2017-02-14  Commit Queue  <commit-queue@webkit.org>
1183
1184         Unreviewed, rolling out r212237.
1185         https://bugs.webkit.org/show_bug.cgi?id=168298
1186
1187         This was a wrong fix (Requested by rniwa on #webkit).
1188
1189         Reverted changeset:
1190
1191         "Nwtr unexpectedly passes mismatch ref test if the hashes
1192         doesn't match but no diff"
1193         https://bugs.webkit.org/show_bug.cgi?id=168221
1194         http://trac.webkit.org/changeset/212237
1195
1196 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1197
1198         URLs with an invalid IPv4 address should be invalid
1199         https://bugs.webkit.org/show_bug.cgi?id=168260
1200
1201         Reviewed by Tim Horton.
1202
1203         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1204         (TestWebKitAPI::TEST_F):
1205         Update tests to reflect new correct behavior.
1206
1207 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
1208
1209         [WinCairo] Add Build Slave
1210         https://bugs.webkit.org/show_bug.cgi?id=168263
1211
1212         Reviewed by Lucas Forschler.
1213
1214         * BuildSlaveSupport/build.webkit.org-config/config.json:
1215
1216 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1217
1218         Fix the build after r212254
1219
1220         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1221         (-[DataInteractionSimulator _currentLocation]):
1222
1223 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1224
1225         [WK2] Add test infrastructure and unit tests for data interaction
1226         https://bugs.webkit.org/show_bug.cgi?id=168159
1227         <rdar://problem/30477634>
1228
1229         Reviewed by Tim Horton.
1230
1231         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
1232         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
1233         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
1234         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
1235         gesture has already been recognized) at regular intervals over the course of the test.
1236
1237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1238         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1239         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1240         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1241
1242         New test pages for data interaction.
1243
1244         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
1245         (TestWebKitAPI::runTestsExpectingToObserveEvents):
1246         (TestWebKitAPI::TEST):
1247         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1248         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1249         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
1250         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
1251         (-[MockLongPressGestureRecognizer initWithWindow:]):
1252         (-[MockLongPressGestureRecognizer locationInView:]):
1253         (-[MockLongPressGestureRecognizer state]):
1254         (-[MockLongPressGestureRecognizer numberOfTouches]):
1255         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
1256         (-[DataInteractionSimulator dealloc]):
1257         (-[DataInteractionSimulator run]):
1258
1259         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
1260         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
1261         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
1262
1263         (-[DataInteractionSimulator _advanceProgress]):
1264
1265         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
1266         completed, and calls _finishDataInteraction when progress is at 1.
1267
1268         (-[DataInteractionSimulator _finishDataInteraction]):
1269         (-[DataInteractionSimulator _currentLocation]):
1270         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
1271         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
1272         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
1273         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
1274         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
1275
1276 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1277
1278         Percent should be allowed in non-special URL hosts
1279         https://bugs.webkit.org/show_bug.cgi?id=168255
1280
1281         Reviewed by Tim Horton.
1282
1283         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1284         (TestWebKitAPI::TEST_F):
1285
1286 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1287
1288         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
1289         https://bugs.webkit.org/show_bug.cgi?id=168221
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         There is a logic error in comparing mismatch ref test images. In
1294         mismatch ref tests, it should be failed if two images has no diff.
1295         But, if the hashes are different, nwtr unexpectedly pass the
1296         mismatch ref test.
1297
1298         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1299         (SingleTestRunner._compare_output_with_reference): Fail the
1300         mismatch ref test if hashes of two images are equal. Invoke
1301         ImageDiff if the hashes don't match.
1302
1303 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
1304
1305         Update custom line breaking iterators to the latest version of Unicode
1306         https://bugs.webkit.org/show_bug.cgi?id=168182
1307
1308         Reviewed by Zalan Bujtas.
1309
1310         Treat the system's ICU as the source of truth to compare breaking positions against.
1311
1312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1313         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
1314         (generateJavaScriptForTest):
1315         (breakingLocationsFromICU):
1316         (testAFewStrings):
1317         (TEST):
1318         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
1319         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
1320
1321 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1322
1323         [GTK] Several failing WebViewEditor API tests
1324         https://bugs.webkit.org/show_bug.cgi?id=161608
1325
1326         Reviewed by Carlos Garcia Campos.
1327
1328         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
1329         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
1330         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
1331         except the first one, which is still broken due to unrelated bug #151654.
1332
1333         * Scripts/run-gtk-tests:
1334         (TestRunner):
1335         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1336
1337 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1338
1339         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
1340
1341         * Scripts/run-gtk-tests:
1342         (TestRunner):
1343
1344 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1345
1346         Unreviewed, skip flaky form-controls-associated-signal test
1347
1348         * Scripts/run-gtk-tests:
1349         (TestRunner):
1350
1351 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1352
1353         [GTK] Handle caps lock indicator in event modifiers
1354         https://bugs.webkit.org/show_bug.cgi?id=168186
1355
1356         Reviewed by Michael Catanzaro.
1357
1358         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1359         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
1360
1361 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
1362
1363         MiniBrowser WK1 fails to update URL for within-page navigations
1364         https://bugs.webkit.org/show_bug.cgi?id=168173
1365
1366         Reviewed by Tim Horton.
1367         
1368         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
1369         anchors updates the URL field.
1370
1371         * MiniBrowser/mac/WK1BrowserWindowController.m:
1372         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
1373
1374 2017-02-10  John Wilander  <wilander@apple.com>
1375
1376         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
1377         https://bugs.webkit.org/show_bug.cgi?id=167474
1378         <rdar://problem/24681808>
1379         <rdar://problem/24703286>
1380         <rdar://problem/30290270>
1381
1382         This patch adds test infrastructure to allow testing 
1383         of the various rules in place for data records removal.
1384
1385         Reviewed by Andy Estes.
1386
1387         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1388         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1389         (WTR::InjectedBundle::didReceiveMessageToPage):
1390             Callback mechanism to tell pages that a website data store
1391             scan has happened.
1392         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1393         (WTR::TestRunner::setStatisticsPrevalentResource):
1394         (WTR::TestRunner::isStatisticsPrevalentResource):
1395         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1396         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1397         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1398         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
1399         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
1400         (WTR::TestRunner::statisticsFireDataModificationHandler):
1401         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1402         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1403         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1404         (WTR::TestRunner::statisticsResetToConsistentState):
1405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1406         * WebKitTestRunner/TestController.cpp:
1407         (WTR::TestController::setStatisticsPrevalentResource):
1408         (WTR::TestController::isStatisticsPrevalentResource):
1409         (WTR::TestController::setStatisticsHasHadUserInteraction):
1410         (WTR::TestController::isStatisticsHasHadUserInteraction):
1411         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1412         (WTR::TestController::statisticsFireDataModificationHandler):
1413         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1414         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1415         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1416         (WTR::TestController::statisticsResetToConsistentState):
1417         * WebKitTestRunner/TestController.h:
1418             These are all configuration and test functions.
1419         * WebKitTestRunner/TestInvocation.cpp:
1420         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1421
1422 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1423
1424         REGRESSION(r182916) run-perf-tests never timeouts
1425         https://bugs.webkit.org/show_bug.cgi?id=167626
1426
1427         Reviewed by Ryosuke Niwa.
1428
1429         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1430         was beeing ignored because the driver was created with no_timeout=True
1431         unconditionally.
1432         This adds a new parameter --no-timeout (disabled by default), that
1433         allows to use the driver with the expected timeout values.
1434         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1435         are always controlled by the Python Driver.
1436
1437         * Scripts/webkitpy/performance_tests/perftest.py:
1438         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1439         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1440         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1441         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1442         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1443         (_run_tests_set): Pass the no-timeout parameter.
1444         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1445         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1446         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1447         (MainTest.test_parse_args): Test that the argument no-timeout.
1448
1449 2017-02-10  Daniel Bates  <dabates@apple.com>
1450
1451         Detach frame from document when entering page cache
1452         https://bugs.webkit.org/show_bug.cgi?id=166774
1453         <rdar://problem/29904368>
1454
1455         Reviewed by Chris Dumez.
1456
1457         * DumpRenderTree/mac/DumpRenderTree.mm:
1458         (resetWebPreferencesToConsistentValues):
1459         * DumpRenderTree/win/DumpRenderTree.cpp:
1460         (resetWebPreferencesToConsistentValues):
1461         * WebKitTestRunner/TestController.cpp:
1462         (WTR::TestController::resetPreferencesToConsistentValues):
1463
1464 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1465
1466         Infinite UI process hang under ensurePositionInformationIsUpToDate
1467         https://bugs.webkit.org/show_bug.cgi?id=168154
1468         <rdar://problem/30428673>
1469
1470         Reviewed by Simon Fraser.
1471
1472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1473         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1474         (recursiveFindHighlightLongPressRecognizer):
1475         (TEST):
1476         Add a somewhat nasty test that does an async interaction information update, but
1477         kills the Web process before it arrives, and then does a sync interaction
1478         information update, which will wait for the oustanding async interaction
1479         information update if we still think it's coming. Before the patch, this
1480         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1481
1482 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1483
1484         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1485         https://bugs.webkit.org/show_bug.cgi?id=168127
1486         rdar://problem/30467120
1487
1488         Reviewed by Tim Horton.
1489
1490         Reparent the web view before we try to fetch it via:
1491             [[[window contentView] subviews] objectAtIndex:0];
1492         which would throw an exception if the test unparented it.
1493
1494         * DumpRenderTree/mac/DumpRenderTree.mm:
1495         (resetWebViewToConsistentStateBeforeTesting):
1496         (runTest):
1497
1498 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1499
1500         [Resource Timing] Enable Resource Timing by default in Tests
1501         https://bugs.webkit.org/show_bug.cgi?id=168145
1502
1503         Reviewed by Ryosuke Niwa.
1504
1505         * DumpRenderTree/mac/DumpRenderTree.mm:
1506         (resetWebPreferencesToConsistentValues):
1507         * DumpRenderTree/win/DumpRenderTree.cpp:
1508         (resetWebPreferencesToConsistentValues):
1509         * WebKitTestRunner/TestController.cpp:
1510         (WTR::TestController::resetPreferencesToConsistentValues):
1511
1512 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1513
1514         Removing LayoutTestRelay
1515         https://bugs.webkit.org/show_bug.cgi?id=165927
1516
1517         Reviewed by Daniel Bates.
1518         Part 2
1519
1520         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1521         simulators through simctl (iOS 10 and later), use this functionality instead.
1522
1523         * BuildSlaveSupport/built-product-archive:
1524         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1525         Added a FIXME that we will need to implement similar archiving machinery once we build
1526         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1527         * BuildSlaveSupport/kill-old-processes:
1528         (main): Remove LayoutTestRelay from list of processes.
1529         * LayoutTestRelay: Removed LayoutTestRelay.
1530         * Makefile:
1531         * Scripts/build-layouttestrelay: Removed.
1532         * Scripts/build-webkit: Removed LayoutTestRelay references.
1533
1534 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1535
1536         [WebCrypto] Add WebCryptoAPI to watchlist
1537         https://bugs.webkit.org/show_bug.cgi?id=168138
1538
1539         Reviewed by Youenn Fablet.
1540
1541         * Scripts/webkitpy/common/config/watchlist:
1542
1543 2017-02-10  Brady Eidson  <beidson@apple.com>
1544
1545         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1546         https://bugs.webkit.org/show_bug.cgi?id=168124
1547
1548         Reviewed by Geoffrey Garen.
1549
1550         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1551         
1552         * MiniBrowser/mac/main.m:
1553         (main):
1554         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1555         (main):
1556         * TestWebKitAPI/ios/mainIOS.mm:
1557         (main):
1558         * TestWebKitAPI/mac/mainMac.mm:
1559         (main):
1560         * WebKitTestRunner/ios/mainIOS.mm:
1561         (main):
1562         * WebKitTestRunner/mac/main.mm:
1563         (setDefaultsToConsistentValuesForTesting):
1564
1565 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1566
1567         Fix El Capitan build.
1568
1569         * Scripts/build-webkit:
1570         Don't build libwebrtc anywhere for now.
1571
1572 2017-02-10  Andy Estes  <aestes@apple.com>
1573
1574         Move two MiniBrowserBundle settings out of the .pbxproj
1575         https://bugs.webkit.org/show_bug.cgi?id=168106
1576
1577         Reviewed by Tim Horton.
1578
1579         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1580         the project file. This removes the project file override.
1581
1582         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1583
1584         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1585         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1586
1587 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1588
1589         Fix 32-and-64-bit build on El Capitan.
1590
1591         * Scripts/build-webkit:
1592         Somebody's building with something like this:
1593         build-webkit ARCHS="i386 x86_64"
1594         We want this to also not build libwebrtc for now.
1595
1596 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1597
1598         Fix 32-bit build on El Capitan.
1599
1600         * Scripts/build-webkit:
1601         The bot uses ARCHS=i386 instead of --32-bit.
1602         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1603
1604 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1605
1606         Fix 32-bit build on El Capitan.
1607
1608         * Scripts/build-webkit:
1609         Don't build i386 libwebrtc.
1610
1611 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1612
1613         Unreviewed, rolling out r212040.
1614
1615         Broke build.  I'm not surprised
1616
1617         Reverted changeset:
1618
1619         "[WebRTC][Mac] Activate libwebrtc"
1620         https://bugs.webkit.org/show_bug.cgi?id=167293
1621         http://trac.webkit.org/changeset/212040
1622
1623 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1624
1625         Build libwebrtc on bots without using it yet
1626         https://bugs.webkit.org/show_bug.cgi?id=168062
1627
1628         Reviewed by Brent Fulgham.
1629
1630         * Scripts/build-webkit:
1631
1632 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1633
1634         Don't build libwebrtc.
1635
1636         * Scripts/build-webkit:
1637         Not ready yet.  It broke El Capitan and iOS.
1638
1639 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1640
1641         Build libwebrtc on bots without using it yet
1642         https://bugs.webkit.org/show_bug.cgi?id=168062
1643
1644         Reviewed by Brent Fulgham.
1645
1646         * Scripts/build-webkit:
1647
1648 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1649
1650         Rename isAppleMacWebKit to isAppleCocoaWebKit
1651         https://bugs.webkit.org/show_bug.cgi?id=168075
1652
1653         Reviewed by Geoffrey Garen.
1654
1655         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1656
1657         * Scripts/build-api-tests:
1658         * Scripts/build-dumprendertree:
1659         * Scripts/build-jsc:
1660         (buildMyProject):
1661         * Scripts/build-layouttestrelay:
1662         * Scripts/build-webkit:
1663         * Scripts/build-webkittestrunner:
1664         * Scripts/run-api-tests:
1665         (isSupportedPlatform):
1666         (runTest):
1667         (listAllTests):
1668         (prepareEnvironmentForRunningTestTool):
1669         * Scripts/run-content-extension-tester:
1670         * Scripts/run-javascriptcore-tests:
1671         * Scripts/run-minibrowser:
1672         * Scripts/show-pretty-diff:
1673         * Scripts/webkitdirs.pm:
1674         (determineBaseProductDir):
1675         (determineArchitecture):
1676         (determinePassedArchitecture):
1677         (safariPath):
1678         (builtDylibPathForName):
1679         (checkFrameworks):
1680         (isAppleWebKit):
1681         (isAppleCocoaWebKit):
1682         (determineNmPath):
1683         (launcherName):
1684         (wrapperPrefixIfNeeded):
1685         (isCMakeBuild):
1686         (mobileSafariBundle):
1687         (debugSafari):
1688         (runSafari):
1689         (runMiniBrowser):
1690         (debugMiniBrowser):
1691         (runWebKitTestRunner):
1692         (debugWebKitTestRunner):
1693         (isAppleMacWebKit): Deleted.
1694         * Scripts/webkitperl/FeatureList.pm:
1695
1696 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1697
1698         Revert r211991
1699         https://bugs.webkit.org/show_bug.cgi?id=168062
1700
1701         * Scripts/build-webkit:
1702         Not quite ready yet.
1703
1704 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1705
1706         Build libwebrtc on bots without using it yet
1707         https://bugs.webkit.org/show_bug.cgi?id=168062
1708
1709         Reviewed by Brent Fulgham.
1710
1711         * Scripts/build-webkit:
1712         Build libwebrtc on Mac when we build ANGLE.
1713
1714 2017-02-09  Youenn Fablet  <youenn@apple.com>
1715
1716         Improve W3C importer command line options
1717         https://bugs.webkit.org/show_bug.cgi?id=167448
1718
1719         Reviewed by Ryosuke Niwa.
1720
1721         Making the list of test paths to import the main arguments of the script.
1722         Allow passing the source directory to import as a -s option.
1723         Adding a warning when given test paths are skipped by default in ImportExpectations.
1724
1725         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1726         Link conversion rules do not change when imported tests are downloaded by the script.
1727
1728         * Scripts/webkitpy/w3c/test_importer.py:
1729         (main):
1730         (parse_args):
1731         (TestImporter.__init__):
1732         (TestImporter.do_import):
1733         (TestImporter):
1734         (TestImporter.check_imported_expectations):
1735
1736 2017-02-08  Chris Dumez  <cdumez@apple.com>
1737
1738         Update web-platform-tests resources
1739         https://bugs.webkit.org/show_bug.cgi?id=168026
1740
1741         Reviewed by Youenn Fablet.
1742
1743         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1744
1745         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1746         (WebPlatformTestServer._copy_webkit_test_files):
1747
1748 2017-02-08  Andy Estes  <aestes@apple.com>
1749
1750         Custom protocols should not continue loading after a network process crash
1751         https://bugs.webkit.org/show_bug.cgi?id=168028
1752         <rdar://problem/27607520>
1753
1754         Reviewed by Brady Eidson.
1755
1756         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1757         (processGroup):
1758         (-[CloseWhileStartingProtocol startLoading]):
1759         (-[CloseWhileStartingProtocol stopLoading]):
1760         (TestWebKitAPI::runTest):
1761         (TestWebKitAPI::TEST):
1762
1763 2017-02-08  Dan Bernstein  <mitz@apple.com>
1764
1765         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1766         https://bugs.webkit.org/show_bug.cgi?id=168031
1767
1768         Reviewed by Tim Horton.
1769
1770         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1771         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1772         (TEST):
1773         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1774         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1775
1776 2017-02-08  Chris Dumez  <cdumez@apple.com>
1777
1778         Use smaller tiles in windows that are not active to facilitate App Napping
1779         https://bugs.webkit.org/show_bug.cgi?id=167997
1780         <rdar://problem/30358835>
1781
1782         Reviewed by Simon Fraser.
1783
1784         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1785         (WTR::PlatformWebView::setWindowIsKey):
1786         Actually update windowIsKey state of NSWindow so the WebView
1787         properly updates its activity state.
1788
1789 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1790
1791         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1792         https://bugs.webkit.org/show_bug.cgi?id=167942
1793         <rdar://problem/30315079>
1794
1795         Reviewed by Tim Horton.
1796
1797         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1798         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1799         contenteditable in these cases.
1800
1801         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1802         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1803         performDragOperation:) directly.
1804
1805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1806         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1807         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1808         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1809         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1810         (-[DragSource draggingSourceOperationMaskForLocal:]):
1811         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1812         (-[DragInfo lastMousePosition]):
1813         (-[DragInfo setLastMousePosition:]):
1814         (-[DragInfo draggingDestinationWindow]):
1815         (-[DragInfo draggingSourceOperationMask]):
1816         (-[DragInfo draggingLocation]):
1817         (-[DragInfo draggedImageLocation]):
1818         (-[DragInfo draggedImage]):
1819         (-[DragInfo draggingPasteboard]):
1820         (-[DragInfo draggingSource]):
1821         (-[DragInfo draggingSequenceNumber]):
1822         (-[DragInfo slideDraggedImageTo:]):
1823         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1824         (-[DragInfo draggingFormation]):
1825         (-[DragInfo setDraggingFormation:]):
1826         (-[DragInfo animatesToDestination]):
1827         (-[DragInfo setAnimatesToDestination:]):
1828         (-[DragInfo numberOfValidItemsForDrop]):
1829         (-[DragInfo setNumberOfValidItemsForDrop:]):
1830         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1831         (-[DragInfo springLoadingHighlight]):
1832         (-[DragInfo resetSpringLoading]):
1833         (TestWebKitAPI::getTestImage):
1834         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1835         (TestWebKitAPI::TEST):
1836         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1837
1838 2017-02-08  Jer Noble  <jer.noble@apple.com>
1839
1840         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1841         https://bugs.webkit.org/show_bug.cgi?id=168007
1842
1843         Reviewed by Alex Christensen.
1844
1845         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1846         (didFinishLoadForFrame):
1847         (TestWebKitAPI::TEST):
1848
1849 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1850
1851         Unreviewed, rolling out r211873.
1852         https://bugs.webkit.org/show_bug.cgi?id=168001
1853
1854         It's in jhbuild for consistent layout tests (Requested by
1855         mcatanzaro on #webkit).
1856
1857         Reverted changeset:
1858
1859         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1860         https://bugs.webkit.org/show_bug.cgi?id=167993
1861         http://trac.webkit.org/changeset/211873
1862
1863 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1864
1865         [GTK] Add icu packages to Tools/gtk/install-dependencies
1866         https://bugs.webkit.org/show_bug.cgi?id=167993
1867
1868         Reviewed by Michael Catanzaro.
1869
1870         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1871         depending in the GNU/Linux distribution)
1872
1873 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1874
1875         Update flakiness dashboard configuration.
1876         https://bugs.webkit.org/show_bug.cgi?id=167957
1877
1878         Reviewed by Alexey Proskuryakov.
1879
1880         * TestResultServer/static-dashboards/builders.jsonp:
1881
1882 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1883
1884         Replace a bot that has an incorrect configuration.
1885         https://bugs.webkit.org/show_bug.cgi?id=167747
1886
1887         Rubber-stamped by Alexey Proskuryakov.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/config.json:
1890
1891 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1892
1893         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1894         https://bugs.webkit.org/show_bug.cgi?id=167927
1895
1896         Reviewed by Brent Fulgham.
1897
1898         Enable ComplexTextController API tests on the Win and GTK ports.
1899
1900         * TestWebKitAPI/PlatformGTK.cmake:
1901         * TestWebKitAPI/PlatformWin.cmake:
1902
1903 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1904
1905         File index appended to previous file in svn-create-patch with SVN 1.9
1906         https://bugs.webkit.org/show_bug.cgi?id=167903
1907         <rdar://problem/30387395>
1908
1909         Reviewed by Daniel Bates.
1910
1911         * Scripts/VCSUtils.pm:
1912         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1913         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1914         trailing newline character from the expected result before comparing it to the actual result.
1915
1916 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1917
1918         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1919         https://bugs.webkit.org/show_bug.cgi?id=167936
1920
1921         Reviewed by Michael Catanzaro.
1922
1923         * Scripts/webkitdirs.pm:
1924         (determineArchitecture):
1925         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1926         since r195083.
1927
1928 2017-02-07  Youenn Fablet  <youenn@apple.com>
1929
1930         Use a JSON file to define which WPT files/folders to import
1931         https://bugs.webkit.org/show_bug.cgi?id=167923
1932
1933         Reviewed by Alex Christensen.
1934
1935         * Scripts/webkitpy/w3c/test_downloader.py:
1936         (TestDownloader.__init__):
1937         (TestDownloader._init_paths_from_expectations):
1938         * Scripts/webkitpy/w3c/test_importer.py:
1939         (parse_args):
1940         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1941
1942 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1943
1944         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1945         https://bugs.webkit.org/show_bug.cgi?id=167916
1946
1947         Reviewed by Carlos Garcia Campos.
1948
1949         URL of mesa-11.0.6.tar.xz has been moved.
1950
1951         * gtk/jhbuild.modules: Fix the module path.
1952
1953 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1954
1955         Static Analyzer: Address some leaks in MiniBrowser
1956         https://bugs.webkit.org/show_bug.cgi?id=167897
1957
1958         Reviewed by Alexey Proskuryakov.
1959
1960         * MiniBrowser/mac/BrowserWindowController.m:
1961         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1962         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1963         (-[ExtensionManagerWindowController add:]):
1964         (-[ExtensionManagerWindowController remove:]):
1965         * MiniBrowser/mac/SettingsController.m:
1966         (-[SettingsController _populateMenu]):
1967         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1968         Address obvious leaks caught by the static analyzer.
1969
1970 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1971
1972         Migrate ComplexTextController to use platform-independent types
1973         https://bugs.webkit.org/show_bug.cgi?id=167833
1974
1975         Reviewed by Brent Fulgham.
1976
1977         Migrate tests away from platform-dependent types.
1978
1979         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1980         (TestWebKitAPI::TEST_F):
1981
1982 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1983
1984         Correct File Path Handling in SecurityOrigin and FileSystem
1985         https://bugs.webkit.org/show_bug.cgi?id=167894
1986         <rdar://problem/30380080>
1987
1988         Reviewed by Alexey Proskuryakov.
1989
1990         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1991         and perform same-volume checks using filesystem-compatible paths.        
1992         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1993         filesystem paths, and perform validation of same-volume checks.
1994         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1995         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1996         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1997         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1998
1999 2017-02-06  Jer Noble  <jer.noble@apple.com>
2000
2001         Playback stalls when a SourceBuffer append causes frame eviction
2002         https://bugs.webkit.org/show_bug.cgi?id=167834
2003
2004         Reviewed by Eric Carlson.
2005
2006         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
2007         for the WTF::MediaTime class.
2008
2009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2010         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2011         (TestWebKitAPI::TEST):
2012         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
2013         (WTF::operator<<):
2014         (TestWebKitAPI::TestSample::create):
2015         (TestWebKitAPI::TestSample::TestSample):
2016         (TestWebKitAPI::TEST_F):
2017
2018 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
2019
2020         Change capitalization in platform name after r211735.
2021
2022         Unreviewed dashboard fix.
2023
2024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2025         (WebKitBuildbot):
2026
2027 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
2028
2029         Move the Leaks bot to Sierra
2030         https://bugs.webkit.org/show_bug.cgi?id=167886
2031
2032         Reviewed by Daniel Bates.
2033
2034         * BuildSlaveSupport/build.webkit.org-config/config.json:
2035         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2037         (LeaksViewer._displayURLPrompt):
2038         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2039         (WebKitBuildbot):
2040
2041 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
2042
2043         Prevent app crash on launch during simctl install workaround
2044         https://bugs.webkit.org/show_bug.cgi?id=167685
2045
2046         Reviewed by Daniel Bates.
2047
2048         * Scripts/webkitpy/port/simulator_process.py:
2049         (SimulatorProcess.__init__): Pass environment to install.
2050         * Scripts/webkitpy/xcode/simulator.py:
2051         (Device.install_app): Accept environment, pass environment to launch.
2052
2053 2017-02-06  Alex Christensen  <achristensen@webkit.org>
2054
2055         Rebase API tests after r211638
2056         https://bugs.webkit.org/show_bug.cgi?id=167779
2057
2058         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2059         (TestWebKitAPI::TEST_F):
2060         URLs with non-special schemes and characters like % in the host now fail to parse,
2061         more like their special counterparts and according to spec.
2062
2063 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2064
2065         Unreviewed trivial fix after r211697.
2066         https://bugs.webkit.org/show_bug.cgi?id=167863
2067
2068         * Scripts/run-javascriptcore-tests:
2069         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
2070
2071 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
2072
2073         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
2074         https://bugs.webkit.org/show_bug.cgi?id=167850
2075
2076         Reviewed by Tim Horton.
2077
2078         * DumpRenderTree/TestRunner.cpp:
2079         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
2080
2081 2017-02-04  Andreas Kling  <akling@apple.com>
2082
2083         Plug some leaks in TestController and UIScriptContext.
2084         <https://webkit.org/b/167839>
2085
2086         Reviewed by Alexey Proskuryakov.
2087
2088         Fix a couple of the leaks seen on the leaks bot.
2089
2090         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2091         (UIScriptContext::runUIScript):
2092         * WebKitTestRunner/TestController.cpp:
2093         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
2094         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2095
2096 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
2097
2098         WK1 mouse events are missing movementX and movementY for pointerlock.
2099         https://bugs.webkit.org/show_bug.cgi?id=167775
2100         rdar://problem/30343810
2101
2102         Reviewed by Alexey Proskuryakov.
2103
2104         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
2105
2106         * DumpRenderTree/mac/EventSendingController.mm:
2107         (-[EventSendingController mouseMoveToX:Y:]):
2108         * WebKitTestRunner/mac/EventSenderProxy.mm:
2109         (WTR::EventSenderProxy::mouseMoveTo):
2110
2111 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
2112
2113         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
2114         https://bugs.webkit.org/show_bug.cgi?id=167774
2115
2116         Reviewed by Tim Horton.
2117
2118         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
2119         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
2120         web process are async, so the callback fires after the web process gets the new state.
2121
2122         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2123         (WTR::UIScriptController::removeViewFromWindow):
2124         (WTR::UIScriptController::addViewToWindow):
2125         * DumpRenderTree/mac/DumpRenderTree.mm:
2126         (createWebViewAndOffscreenWindow):
2127         (resetWebViewToConsistentStateBeforeTesting):
2128         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2129         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2130         (WTR::UIScriptController::removeViewFromWindow):
2131         (WTR::UIScriptController::addViewToWindow):
2132         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2133         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2134         (WTR::UIScriptController::removeViewFromWindow):
2135         (WTR::UIScriptController::addViewToWindow):
2136         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2137         * WebKitTestRunner/PlatformWebView.h:
2138         * WebKitTestRunner/TestController.cpp:
2139         (WTR::TestController::resetStateToConsistentValues):
2140         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2141         (WTR::PlatformWebView::removeFromWindow):
2142         (WTR::PlatformWebView::addToWindow):
2143         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2144         (WTR::UIScriptController::removeViewFromWindow):
2145         (WTR::UIScriptController::addViewToWindow):
2146         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2147         (WTR::PlatformWebView::removeFromWindow):
2148         (WTR::PlatformWebView::addToWindow):
2149         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2150         (WTR::UIScriptController::removeViewFromWindow):
2151         (WTR::UIScriptController::addViewToWindow):
2152
2153 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
2154
2155         Remove check for SkipSafariExecutableEntitlementChecks
2156         https://bugs.webkit.org/show_bug.cgi?id=167762
2157
2158         Reviewed by Dan Bernstein.
2159
2160         Follow-up fix: don't break internal behavior.
2161
2162         * Scripts/webkitdirs.pm:
2163         (safariPath):
2164         (executableHasEntitlements): Deleted.
2165         (safariPathFromSafariBundle): Deleted.
2166         (installedSafariPath): Deleted.
2167
2168 2017-02-03  Daniel Bates  <dabates@apple.com>
2169
2170         [Mac][WK2] Add SPI to override the Content Security Policy of a page
2171         https://bugs.webkit.org/show_bug.cgi?id=167810
2172         <rdar://problem/30102568>
2173
2174         Reviewed by Anders Carlsson.
2175
2176         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
2177
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
2180         (TEST):
2181         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
2182         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
2183         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
2184         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
2185
2186 2017-02-02  Alex Christensen  <achristensen@webkit.org>
2187
2188         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
2189         https://bugs.webkit.org/show_bug.cgi?id=167773
2190         <rdar://problem/30221102>
2191
2192         Reviewed by Ryosuke Niwa.
2193
2194         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2195         (TestWebKitAPI::TEST_F):
2196
2197 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
2198
2199         Remove check for SkipSafariExecutableEntitlementChecks
2200         https://bugs.webkit.org/show_bug.cgi?id=167762
2201         rdar://problem/22480673
2202
2203         Reviewed by Dan Bernstein.
2204
2205         * Scripts/webkitdirs.pm:
2206         (safariPathFromSafariBundle):
2207         (skipSafariExecutableEntitlementChecks): Deleted.
2208
2209 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
2210
2211         Undefined subroutine in svn-create-patch
2212         https://bugs.webkit.org/show_bug.cgi?id=167742
2213
2214         Unreviewed build-fix after r211543.
2215
2216         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
2217
2218 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2219
2220         Unreviewed. Fix jhbuild dependencies build.
2221
2222         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
2223         Patch updated.
2224
2225 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2226
2227         [EME][GStreamer] Fixed decryptor selection
2228         https://bugs.webkit.org/show_bug.cgi?id=167588
2229
2230         Reviewed by Žan Doberšek.
2231
2232         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
2233
2234         * gtk/jhbuild.modules: Added patches to gstreamer and
2235         gst-plugins-good packages.
2236         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2237         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2238
2239 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
2240
2241         Make run-benchmark script supports 'config' key in test plan.
2242         https://bugs.webkit.org/show_bug.cgi?id=167715
2243
2244         Reviewed by Ryosuke Niwa.
2245
2246         Add support for 'config' key in test paln.
2247         'config' key is a dictionary that specifies environment configurations while test is running.
2248         Specifies orientation to be portrait in MotionMark benchmark.
2249
2250         * Scripts/webkitpy/benchmark_runner/README.md:
2251         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2252         (BenchmarkRunner.__init__):
2253         (BenchmarkRunner._run_benchmark):
2254         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2255         (BrowserDriver.prepare_env):
2256         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2257         (LinuxBrowserDriver.prepare_env):
2258         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2259         (OSXBrowserDriver.prepare_env):
2260         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2261         (OSXSafariDriver.prepare_env):
2262         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2263
2264 2017-02-01  Daniel Bates  <dabates@apple.com>
2265
2266         REGRESSION (r210820): svn-create-patch does not emit property change only diff
2267         https://bugs.webkit.org/show_bug.cgi?id=167169
2268
2269         Reviewed by David Kilzer.
2270
2271         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
2272         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
2273         header from the output of "svn diff" on a file that was copied or moved.
2274
2275         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
2276         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
2277         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
2278         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
2279         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
2280         of a file with only a property change also does not contain any chunk range lines. Therefore
2281         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
2282         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
2283         we should directly test for the presence of a leading SVN diff header with an empty body and
2284         remove such lines from the diff.
2285
2286         * Scripts/VCSUtils.pm:
2287         (fixSVNPatchForAdditionWithHistory): Added.
2288         * Scripts/svn-create-patch:
2289         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
2290         we have a non empty patch for an added file with history (i.e. a copied or moved file).
2291         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
2292
2293 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
2294
2295         [Mac] Update CARingBuffer class
2296         https://bugs.webkit.org/show_bug.cgi?id=167656
2297
2298         Reviewed by Jer Noble.
2299
2300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2301         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
2302         (TestWebKitAPI::CARingBufferTest::SetUp):
2303         (TestWebKitAPI::CARingBufferTest::setup):
2304         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
2305         (TestWebKitAPI::CARingBufferTest::description):
2306         (TestWebKitAPI::CARingBufferTest::bufferList):
2307         (TestWebKitAPI::CARingBufferTest::ringBuffer):
2308         (TestWebKitAPI::CARingBufferTest::capacity):
2309         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
2310         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
2311         (TestWebKitAPI::TEST_F):
2312         (TestWebKitAPI::MixingTest::run):
2313
2314 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
2315
2316         [Mac] TestWebKitAPI includes system frameworks incorrectly
2317         https://bugs.webkit.org/show_bug.cgi?id=167703
2318         rdar://problem/30301498
2319
2320         Reviewed by Ryosuke Niwa.
2321
2322         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
2323         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
2324
2325         Also, reduced the number of subframework search paths, looks like we only need one now.
2326
2327         * TestWebKitAPI/Configurations/Base.xcconfig:
2328
2329 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
2330
2331         Correct "filesHaveSameVolume" predicate
2332         https://bugs.webkit.org/show_bug.cgi?id=167696
2333         <rdar://problem/30298722>
2334
2335         Reviewed by David Kilzer.
2336
2337         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
2338         percent-escaped path inputs.
2339
2340         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2341         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
2342         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
2343         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
2344         (TestWebKitAPI::TEST_F):
2345
2346 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2347
2348         Unreviewed. Fix coding style in MiniBrowser
2349
2350         * MiniBrowser/gtk/BrowserWindow.c:
2351         (editingCommandCallback):
2352         (insertImageCommandCallback):
2353         (insertLinkCommandCallback):
2354
2355 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2356
2357         [GTK] Add an API to add a custom tab into the print dialog
2358         https://bugs.webkit.org/show_bug.cgi?id=151998
2359
2360         Reviewed by Carlos Garcia Campos.
2361
2362         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
2363         that is testing a newly added API.
2364
2365         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2366         (testPrintCustomWidget):
2367         (beforeAll):
2368
2369 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
2370
2371         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
2372         https://bugs.webkit.org/show_bug.cgi?id=166529
2373
2374         Reviewed by Xabier Rodriguez-Calvar.
2375
2376         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
2377         New patch version accepted in GStreamer upstream.
2378
2379 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2380
2381         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
2382         https://bugs.webkit.org/show_bug.cgi?id=167498
2383
2384         Reviewed by Carlos Garcia Campos.
2385
2386         Depending on the distro version you can need either libxfont1-dev
2387         or libfont-dev to build with jhbuild.
2388
2389         * gtk/install-dependencies:
2390
2391 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2392
2393         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
2394         https://bugs.webkit.org/show_bug.cgi?id=167594
2395
2396         Unreviewed test gardening.
2397
2398         Disabling this test while we investigate the cause of a timeout on ios-simulator.
2399
2400         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2401         (TEST):
2402
2403 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
2404
2405         Move slow-running microbenchmarks out of JSTests/microbenchmarks
2406         https://bugs.webkit.org/show_bug.cgi?id=167676
2407
2408         Reviewed by Saam Barati.
2409
2410         * Scripts/run-javascriptcore-tests:
2411         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
2412
2413 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
2414
2415         Make Dump Render Tree not crash
2416         https://bugs.webkit.org/show_bug.cgi?id=167667
2417
2418         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
2419         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
2420         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
2421         This does not fix any tests, it just fixes the crash.
2422         
2423         Reviewed by Simon Fraser.
2424
2425         * DumpRenderTree/TestRunner.cpp:
2426         (TestRunner::callUIScriptCallback):
2427
2428 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2429
2430         Workaround for simctl install failing to report install failure
2431         https://bugs.webkit.org/show_bug.cgi?id=167654
2432
2433         Reviewed by Daniel Bates.
2434
2435         simctl install will sometimes report success even though install has failed.
2436         To workaround this bug, we attempt an app launch after install to ensure
2437         install has succeeded.
2438
2439         * Scripts/webkitpy/xcode/simulator.py:
2440         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2441         (Device.launch_app): Correct comment.
2442
2443 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2444
2445         Unreviewed webkitpy fix after r211405.
2446
2447         * Scripts/webkitpy/xcode/simulator.py:
2448         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2449
2450 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2451
2452         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2453
2454         * gtk/manifest.txt.in:
2455
2456 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2457
2458         AX: enable search predication for iOS
2459         https://bugs.webkit.org/show_bug.cgi?id=167558
2460         <rdar://problem/30251367>
2461
2462         Reviewed by Joanmarie Diggs.
2463
2464         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2465         (AccessibilityUIElement::uiElementForSearchPredicate):
2466         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2467         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2468         (searchPredicateParameterizedAttributeForSearchCriteria):
2469         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2470         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2471         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2472         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2473         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2474         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2475         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2476         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2477         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2478         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2479         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2480
2481 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2482
2483         Workaround for simctl launch bug
2484         https://bugs.webkit.org/show_bug.cgi?id=167613
2485
2486         Reviewed by Daniel Bates.
2487
2488         simctl launch will sometimes fail because of a race condition when many
2489         simulators are being run simultaneously. These failures will always have
2490         an exit code of 1. This change attempts to launch an app multiple times
2491         before reporting a failure to workaround this bug.
2492
2493         * Scripts/webkitpy/xcode/simulator.py:
2494         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2495
2496 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2497
2498         Commit queue fails to look at real name aliases for the reviewer
2499         https://bugs.webkit.org/show_bug.cgi?id=167422
2500
2501         Reviewed by Joseph Pecoraro.
2502
2503         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2504         (test_has_valid_reviewer): Added tests.
2505
2506         * Scripts/webkitpy/common/config/committers.py:
2507         (CommitterList._name_to_contributor_map):
2508         Made _name_to_contributor_map include alias names.
2509
2510         * Scripts/webkitpy/common/config/committers_unittest.py:
2511         (CommittersTest.test_contributors_by_fuzzy_match):
2512         Removed subtests that are now obsolete, as these matches are strict. It is not
2513         obvious if distance based fuzzy matching for names is useful at all, but we can
2514         look into that some other time.
2515
2516 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2517
2518         QueueStatusServer should have an explicit timeout for _fetch_url
2519         https://bugs.webkit.org/show_bug.cgi?id=167467
2520
2521         Reviewed by Alexey Proskuryakov.
2522
2523         * Scripts/webkitpy/common/net/statusserver.py:
2524         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2525
2526 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2527
2528         Add support for Trac instances that host multiple projects.
2529         https://bugs.webkit.org/show_bug.cgi?id=167524
2530
2531         Reviewed by Alexey Proskuryakov.
2532
2533         When multiple projects are hosted on a single Trac instance, the current
2534         behavior will retrieve changesets from all tracked projects.
2535         This patch teaches Trac.js to get project-specific changesets from Trac.
2536         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2537         when querying the Trac timeline.
2538
2539         To tell Trac to be aware of multi-project instances we leverage the 
2540         `options` parameter when creating a new instance: 
2541
2542             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2543
2544         If this option is not provided, the original behaviour will prevail.
2545         Additionally, add corresponding tests.
2546
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2548         (Trac): Reason about new optional parameter 'projectIdentifier'.
2549         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2550         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2551         replace default parameter `changeset=on` with `repo-projectname=on`.
2552         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2554         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2556         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2557         Add the following tests:
2558             test("revisionURL")
2559             test("revisionURL with Trac Identifier")
2560             test("_xmlTimelineURL")
2561             test("_xmlTimelineURL with Trac Identifier")
2562         (this.view._latestProductiveIteration): Fix missing ';'.
2563
2564 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2565
2566         Correct spacing regression on inter-element complex path shaping on some fonts
2567         https://bugs.webkit.org/show_bug.cgi?id=166013
2568
2569         Reviewed by Simon Fraser.
2570
2571         Unskip existing tests and make some new tests:
2572         - Testing complex text with no origins
2573         - Testing initial expansions
2574         - Testing the sign of vertical advances
2575
2576         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2577         (TestWebKitAPI::TEST_F):
2578
2579 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2580
2581         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2582         https://bugs.webkit.org/show_bug.cgi?id=167596
2583
2584         Reviewed by Daniel Bates.
2585
2586         We avoid needing a thin directory by invoking the zip program with
2587         the list of directories from the build directory to be zipped,
2588         and by using the zip feature to exclude files matching a pattern.
2589
2590         * BuildSlaveSupport/built-product-archive:
2591         (copyBuildFiles):
2592         (createZipFromList):
2593         (archiveBuiltProduct):
2594
2595 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2596
2597         Use simctl instead of LayoutTestRelay
2598         https://bugs.webkit.org/show_bug.cgi?id=165927
2599
2600         Reviewed by Daniel Bates.
2601
2602         Part 1
2603
2604         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2605         simulators through simctl (iOS 10 and later), use this functionality instead.
2606
2607         * Scripts/webkitpy/port/base.py:
2608         (Port.__init__): Added _test_runner_process_constructor.
2609         * Scripts/webkitpy/port/darwin.py:
2610         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2611         * Scripts/webkitpy/port/driver.py:
2612         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2613         (IOSSimulatorDriver): Deleted.
2614         * Scripts/webkitpy/port/driver_unittest.py:
2615         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2616         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2617         (DriverTest.test_start_actually_starts): Ditto.
2618         * Scripts/webkitpy/port/ios.py:
2619         (IOSSimulatorPort): Remove relay_name.
2620         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2621         (IOSSimulatorPort._create_simulators): Formatting change.
2622         (IOSSimulatorPort.relay_path): Deleted.
2623         (IOSSimulatorPort._check_relay): Deleted.
2624         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2625         (IOSSimulatorPort._build_relay): Deleted.
2626         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2627         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2628         * Scripts/webkitpy/port/ios_unittest.py:
2629         (iosTest.test_32bit): Update test.
2630         (iosTest.test_64bit): Update test.
2631         * Scripts/webkitpy/port/server_process.py:
2632         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2633         (ServerProcess._set_file_nonblocking): Added to share common code.
2634         * Scripts/webkitpy/port/server_process_mock.py:
2635         (MockServerProcess.__init__): Added argument worker_number.
2636         * Scripts/webkitpy/port/simulator_process.py: Added.
2637         (SimulatorProcess): Added.
2638         (SimulatorProcess.Popen): Added.
2639         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2640         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2641         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2642         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2643         (SimulatorProcess._reset): Added. Unlink fifos.
2644         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2645         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2646         * Scripts/webkitpy/xcode/simulator.py:
2647         (Device.__init__): Accept host to run install/launch/terminate.
2648         (Device.install_app): Install app to target Device.
2649         (Device.launch_app): Launch app on target Device.
2650         (Device.terminate_app): Shutdown app on target Device.
2651         (Simulator._parse_devices): Pass host to Device.
2652
2653 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2654
2655         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2656         https://bugs.webkit.org/show_bug.cgi?id=167411
2657
2658         Reviewed by Michael Catanzaro.
2659
2660         Disable the ARM iwMMXt fast path for pixman, because it triggers
2661         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2662
2663         * gtk/jhbuild.modules:
2664
2665 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2666
2667         [GTK] Add API to handle the accelerated compositing policy
2668         https://bugs.webkit.org/show_bug.cgi?id=167509
2669
2670         Reviewed by Michael Catanzaro.
2671
2672         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2673         as a special case. Also add test cases to the get/set API.
2674
2675         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2676         (hardwareAccelerationPolicyToString):
2677         (stringToHardwareAccelerationPolicy):
2678         (cellRendererChanged):
2679         (browserSettingsDialogConstructed):
2680         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2681         (testWebKitSettings):
2682
2683 2017-01-29  Andy Estes  <aestes@apple.com>
2684
2685         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2686         https://bugs.webkit.org/show_bug.cgi?id=167563
2687         <rdar://problem/30253207>
2688
2689         Reviewed by Andreas Kling.
2690
2691         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2692         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2693         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2694         (runTest):
2695         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2696         (TEST):
2697
2698 2017-01-29  Dan Bernstein  <mitz@apple.com>
2699
2700         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2701         https://bugs.webkit.org/show_bug.cgi?id=167565
2702
2703         Reviewed by Sam Weinig.
2704
2705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2706         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2707         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2708         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2709         (TEST):
2710         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2711         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2712         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2713         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2714
2715 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2716
2717         Add Link Preload as an off-by-default experimental feature menu item.
2718         https://bugs.webkit.org/show_bug.cgi?id=167201
2719
2720         Reviewed by Ryosuke Niwa.
2721
2722         * DumpRenderTree/mac/DumpRenderTree.mm:
2723         (resetWebPreferencesToConsistentValues):
2724         * DumpRenderTree/win/DumpRenderTree.cpp:
2725         (resetWebPreferencesToConsistentValues):
2726
2727 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2728
2729         Add User Timing Experimental Feature
2730         https://bugs.webkit.org/show_bug.cgi?id=167542
2731         <rdar://problem/22746307>
2732
2733         Reviewed by Ryosuke Niwa.
2734
2735         * DumpRenderTree/mac/DumpRenderTree.mm:
2736         (enableExperimentalFeatures):
2737         (resetWebPreferencesToConsistentValues):
2738         * DumpRenderTree/win/DumpRenderTree.cpp:
2739         (enableExperimentalFeatures):
2740
2741 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2742
2743         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2744         https://bugs.webkit.org/show_bug.cgi?id=167519
2745
2746         Reviewed by Ryosuke Niwa.
2747
2748         * QueueStatusServer/templates/statusbubble.html:
2749         To measure the bubbleContainer's width, it must not be wrapping based
2750         on its parent container. So when measuring the width temporarily set
2751         the parent to a very large width so as to not artificially wrap us.
2752         Restore the parent's width after measuring.
2753
2754 2017-01-27  Andy Estes  <aestes@apple.com>
2755
2756         [iOS] Add a test for _WKNSFileManagerExtras
2757         https://bugs.webkit.org/show_bug.cgi?id=167478
2758
2759         Reviewed by Andreas Kling.
2760
2761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2762         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2763         (expectAttributes):
2764         (TEST):
2765
2766 2017-01-27  Keith Miller  <keith_miller@apple.com>
2767
2768         run-benchmarks should make sure it passes the test url to the right application
2769         https://bugs.webkit.org/show_bug.cgi?id=167533
2770
2771         Reviewed by Joseph Pecoraro.
2772
2773         This fixes an issue when trying to run-benchmark script with the
2774         system default browser set to STP. Previously, it would run
2775         the test in STP rather than the provided build. Now, it should run
2776         in the provided build.
2777
2778         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2779         (OSXSafariDriver.launch_url):
2780
2781 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2782
2783         [Cocoa] Prepare ComplexTextController for unit testing
2784         https://bugs.webkit.org/show_bug.cgi?id=167493
2785
2786         Reviewed by Simon Fraser.
2787
2788         Addressing post-review comments from Simon Fraser.
2789
2790         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2791         (TestWebKitAPI::TEST_F):
2792
2793 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2794
2795         [Cocoa] Prepare ComplexTextController for unit testing
2796         https://bugs.webkit.org/show_bug.cgi?id=167493
2797
2798         Reviewed by Dean Jackson.
2799
2800         Create four unit tests.
2801
2802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2803         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2804         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2805         (TestWebKitAPI::TEST_F):
2806
2807 2017-01-26  Chris Dumez  <cdumez@apple.com>
2808
2809         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2810         https://bugs.webkit.org/show_bug.cgi?id=167421
2811         <rdar://problem/30188490>
2812
2813         Reviewed by Darin Adler.
2814
2815         Add a new setting allowing layout tests to enable PageCache in a window
2816         that has an opener, for convenience.
2817
2818         * DumpRenderTree/mac/DumpRenderTree.mm:
2819         (resetWebPreferencesToConsistentValues):
2820         * DumpRenderTree/win/DumpRenderTree.cpp:
2821         (resetWebPreferencesToConsistentValues):
2822         * WebKitTestRunner/TestController.cpp:
2823         (WTR::TestController::resetPreferencesToConsistentValues):
2824
2825 2017-01-26  Keith Miller  <keith_miller@apple.com>
2826
2827         classInfo should take a VM so it is not materialized from the object on each call
2828         https://bugs.webkit.org/show_bug.cgi?id=167424
2829
2830         Rubber Stamped by Michael Saboff.
2831
2832         Previously, classInfo() would get the VM from the target's
2833         MarkedBlock.  Most callers already have a VM on hand, so it is
2834         wasteful to compute the VM from the marked block every time. This
2835         patch refactors some of the most common callers of classInfo(),
2836         jsDynamicCast and inherits to take a VM as well.
2837
2838         * DumpRenderTree/TestRunner.cpp:
2839         (setAudioResultCallback):
2840
2841 2017-01-26  Jer Noble  <jer.noble@apple.com>
2842
2843         Autoplay muted videos stop playback of any streaming app in the background
2844         https://bugs.webkit.org/show_bug.cgi?id=163993
2845         <rdar://problem/29020431>
2846
2847         Reviewed by Eric Carlson.
2848
2849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2850         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2851         (TestWebKitAPI::TEST):
2852         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2853
2854 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2855
2856         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2857         https://bugs.webkit.org/show_bug.cgi?id=167466
2858
2859         Unreviewed test gardening.
2860
2861         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2862         (TEST):
2863
2864 2017-01-26  Matt Rajca  <mrajca@apple.com>
2865
2866         Notify clients when the user plays media otherwise prevented from autoplaying
2867         https://bugs.webkit.org/show_bug.cgi?id=167390
2868
2869         Reviewed by Alex Christensen.
2870
2871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2872         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2873         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2874         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2875         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2876         (TEST):
2877         * TestWebKitAPI/cocoa/TestWKWebView.h:
2878         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2879         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2880         (-[TestWKWebView waitForLoad]):
2881         (-[TestWKWebView mouseUpAtPoint:]):
2882         * WebKitTestRunner/TestController.cpp:
2883         (WTR::TestController::createOtherPage):
2884         (WTR::TestController::createWebViewWithOptions):
2885
2886 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2887
2888         Crash when setting custom scale factor.
2889         https://bugs.webkit.org/show_bug.cgi?id=167369
2890
2891         Reviewed by Sam Weinig.
2892
2893         Added API test.
2894
2895         * TestWebKitAPI/PlatformWin.cmake:
2896         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2897         (TestWebKitAPI::WebKitCreateInstance):
2898         (TestWebKitAPI::ScaleWebView::SetUp):
2899         (TestWebKitAPI::ScaleWebView::TearDown):
2900         (TestWebKitAPI::TEST_F):
2901
2902 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2903
2904         run-benchmark nests MotionMark results by the suite name twice
2905         https://bugs.webkit.org/show_bug.cgi?id=164948
2906
2907         Reviewed by Said Abou-Hallawa.
2908
2909         Use a single level MotionMark now that this is the name of the benchmark,
2910         and we no longer have tests that aren't part of the MotionMark suite.
2911
2912         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2913
2914 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2915
2916         Unreviewed, rolling out r211193.
2917
2918         This change broke internal builds.
2919
2920         Reverted changeset:
2921
2922         "Notify clients when the user plays media otherwise prevented
2923         from autoplaying"
2924         https://bugs.webkit.org/show_bug.cgi?id=167390
2925         http://trac.webkit.org/changeset/211193
2926
2927 2017-01-25  Matt Rajca  <mrajca@apple.com>
2928
2929         Notify clients when the user plays media otherwise prevented from autoplaying
2930         https://bugs.webkit.org/show_bug.cgi?id=167390
2931
2932         Reviewed by Alex Christensen.
2933
2934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2935         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2936         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2938         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2939         (TEST):
2940         * TestWebKitAPI/cocoa/TestWKWebView.h:
2941         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2942         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2943         (-[TestWKWebView waitForLoad]):
2944         (-[TestWKWebView mouseUpAtPoint:]):
2945         * WebKitTestRunner/TestController.cpp:
2946         (WTR::TestController::createOtherPage):
2947         (WTR::TestController::createWebViewWithOptions):
2948
2949 2017-01-25  Matt Rajca  <mrajca@apple.com>
2950
2951         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2952         https://bugs.webkit.org/show_bug.cgi?id=167385
2953
2954         Reviewed by Alex Christensen.
2955
2956         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2957         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2958         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2959         (TEST): Allow inline (rather than full screen) media playback on iOS.
2960
2961 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2962
2963         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2964         https://bugs.webkit.org/show_bug.cgi?id=167414
2965
2966         Reviewed by Michael Catanzaro.
2967
2968         Add a test case to check ephemeral web views don't write favicons to the database.
2969
2970         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2971         (ephemeralViewLoadChanged):
2972         (testPrivateBrowsing):
2973         (testFaviconDatabase):
2974
2975 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2976
2977         [GTK] Add a private browsing mode to MiniBrowser
2978         https://bugs.webkit.org/show_bug.cgi?id=167413
2979
2980         Reviewed by Michael Catanzaro.
2981
2982         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2983         private windows, even on non-private instances.
2984
2985         * MiniBrowser/gtk/BrowserWindow.c:
2986         (webViewTitleChanged): Add [Private] to title window for private windows.
2987         (webViewCreate): Pass web context to browser_window_new.
2988         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2989         (browserWindowFinalize): Disconnect web context signal handlers.
2990         (browser_window_init): Add shortcut for opening private window.
2991         (browser_window_new): It now receives the context and connect to download-started here.
2992         (browser_window_get_web_context): Return the context.
2993         * MiniBrowser/gtk/BrowserWindow.h:
2994         * MiniBrowser/gtk/main.c:
2995         (createBrowserTab): Create the web view for the window web context.
2996         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2997         (aboutDataHandleRequest): Ditto.
2998         (aboutURISchemeRequestCallback): Ditto.
2999         (main): Create ephemeral web context if private command line option is used.
3000
3001 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3002
3003         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
3004         https://bugs.webkit.org/show_bug.cgi?id=167409
3005
3006         Reviewed by Antti Koivisto.
3007
3008         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
3009         as well as tests for the newly added matchingElementInFlatTree.
3010
3011         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
3012         (TestWebKitAPI::runJavaScriptAlert):
3013         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
3014         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
3015         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
3016
3017 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3018
3019         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
3020         https://bugs.webkit.org/show_bug.cgi?id=167370
3021
3022         Reviewed by Michael Catanzaro.
3023
3024         Add several test cases of ephemeral web views.
3025
3026         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3027         (testWebViewAuthenticationStorage):
3028         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
3029         (ephemeralViewloadChanged):
3030         (testCookieManagerEphemeral):
3031         (beforeAll):
3032         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3033         (testWebKitSettings):
3034         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3035         (testWebContextEphemeral):
3036         (ephemeralViewloadChanged):
3037         (testWebContextProxySettings):
3038         (beforeAll):
3039         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3040         (ephemeralViewloadChanged):
3041         (testWebViewEphemeral):
3042         (beforeAll):
3043         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
3044         (ephemeralViewloadChanged):
3045         (testWebsiteDataEphemeral):
3046         (beforeAll):
3047
3048 2017-01-24  Alex Christensen  <achristensen@webkit.org>
3049
3050         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
3051         https://bugs.webkit.org/show_bug.cgi?id=167402
3052
3053         Reviewed by Ryosuke Niwa.
3054
3055         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3056         (TestWebKitAPI::TEST):
3057
3058 2017-01-24  Zalan Bujtas  <zalan@apple.com>
3059
3060         Add simple line layout toggle to MiniBrowser
3061         https://bugs.webkit.org/show_bug.cgi?id=167405
3062
3063         Reviewed by Andreas Kling.
3064
3065         * MiniBrowser/mac/SettingsController.h:
3066         * MiniBrowser/mac/SettingsController.m:
3067         (-[SettingsController _populateMenu]):
3068         (-[SettingsController validateMenuItem:]):
3069         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
3070         (-[SettingsController simpleLineLayoutEnabled]):
3071         * MiniBrowser/mac/WK1BrowserWindowController.m:
3072         (-[WK1BrowserWindowController didChangeSettings]):
3073         * MiniBrowser/mac/WK2BrowserWindowController.m:
3074         (-[WK2BrowserWindowController didChangeSettings]):
3075
3076 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
3077
3078         WKR does not include my nick when commit-queue lands my patch
3079         https://bugs.webkit.org/show_bug.cgi?id=167388
3080
3081         Reviewed by Ryosuke Niwa.
3082
3083         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3084         (NewCommitBot._summarize_commit_log):
3085         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3086         Perform nickname insertion before grabbing "Patch by" details.
3087         This way we can include the nickname with the full name.
3088
3089 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
3090
3091         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
3092         https://bugs.webkit.org/show_bug.cgi?id=167394
3093
3094         Reviewed by Ryosuke Niwa.
3095
3096         * Scripts/webkitperl/FeatureList.pm:
3097         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3098
3099 2017-01-24  Youenn Fablet  <youenn@apple.com>
3100
3101         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
3102         https://bugs.webkit.org/show_bug.cgi?id=167353
3103
3104         Reviewed by Alex Christensen.
3105
3106         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3107         (CMakeGenerator.initialize_targets):
3108
3109 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3110
3111         WKR should not confuse Miguel Gomez with Andres Gomez
3112         https://bugs.webkit.org/show_bug.cgi?id=167389
3113
3114         Reviewed by Lucas Forschler.
3115
3116         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
3117         "mAndres Gomez". Fix this.
3118
3119         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3120         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
3121         space on each side of the email address, so expect both spaces to be there before
3122         considering the email for replacement.
3123         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
3124
3125 2017-01-24  Matt Rajca  <mrajca@apple.com>
3126
3127         Pass down website autoplay policies to media elements
3128         https://bugs.webkit.org/show_bug.cgi?id=167355
3129
3130         Reviewed by Alex Christensen.
3131
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
3134         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
3135         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
3136         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3137         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3138         (TEST):
3139
3140 2017-01-24  Nan Wang  <n_wang@apple.com>
3141
3142         AX: Speak Selection does not work in an iframe
3143         https://bugs.webkit.org/show_bug.cgi?id=166794
3144         <rdar://problem/29913013>
3145
3146         Reviewed by Chris Fleizach.
3147
3148         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3149         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3150         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3151         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3152         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3153         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3154         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3155         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3156         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3157         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3158         (-[TestRunnerWKWebView dealloc]):
3159         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
3160         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
3161         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3162         (WTR::UIScriptController::retrieveSpeakSelectionContent):
3163         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
3164
3165 2017-01-24  Daniel Bates  <dabates@apple.com>
3166
3167         StringView.split() should use an iterator design pattern instead of allocating a Vector
3168         https://bugs.webkit.org/show_bug.cgi?id=163225
3169
3170         Reviewed by Darin Adler.
3171
3172         Add unit tests for StringView.split().
3173
3174         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3175         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
3176         used in the StringView.split() unit tests.
3177         (TestWebKitAPI::stringViewFromUTF8): Ditto.
3178         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
3179         object to a Vector of String objects.
3180         (TestWebKitAPI::TEST): Added the following tests:
3181             - WTF.StringViewSplitEmptyAndNullStrings
3182             - WTF.StringViewSplitBasic
3183             - WTF.StringViewSplitWithConsecutiveSeparators
3184
3185 2017-01-23  Anders Carlsson  <andersca@apple.com>
3186
3187         The Score Esports crashes on launch
3188         https://bugs.webkit.org/show_bug.cgi?id=167338
3189         rdar://problem/29948645
3190
3191         Reviewed by Dan Bernstein.
3192
3193         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3194         (TestWebKitAPI::TEST):
3195         Add a test.
3196
3197 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3198
3199         [GTK] Add API to WebKitWebsiteDataManager to handle website data
3200         https://bugs.webkit.org/show_bug.cgi?id=146589
3201
3202         Reviewed by Michael Catanzaro.
3203
3204         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
3205         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
3206
3207         * MiniBrowser/gtk/BrowserWindow.c:
3208         (webViewDecidePolicy):
3209         (newTabCallback):
3210         * MiniBrowser/gtk/main.c:
3211         (createBrowserTab):
3212         (aboutDataRequestFree):
3213         (aboutDataRequestNew):
3214         (aboutDataRequestForView):
3215         (websiteDataRemovedCallback):
3216         (websiteDataClearedCallback):
3217         (aboutDataScriptMessageReceivedCallback):
3218         (domainListFree):
3219         (aboutDataFillTable):
3220         (gotWebsiteDataCallback):
3221         (aboutDataHandleRequest):
3222         (aboutURISchemeRequestCallback):
3223         (main):
3224         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3225         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3226         (serverCallback):
3227         (beforeAll):
3228         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
3229         (serverCallback):
3230         (WebsiteDataTest::WebsiteDataTest):
3231         (WebsiteDataTest::~WebsiteDataTest):
3232         (WebsiteDataTest::fetch):
3233         (WebsiteDataTest::remove):
3234         (WebsiteDataTest::clear):
3235         (testWebsiteDataConfiguration):
3236         (testWebsiteDataCache):
3237         (testWebsiteDataStorage):
3238         (testWebsiteDataDatabases):
3239         (testWebsiteDataAppcache):
3240         (beforeAll):
3241         (afterAll):
3242
3243 2017-01-23  Commit Queue  <commit-queue@webkit.org>
3244
3245         Unreviewed, rolling out r211062.
3246         https://bugs.webkit.org/show_bug.cgi?id=167354
3247
3248         broke API tests (Requested by alexchristensen on #webkit).
3249
3250         Reverted changeset:
3251
3252         "Pass down website autoplay policies to media elements"
3253         https://bugs.webkit.org/show_bug.cgi?id=167132
3254         http://trac.webkit.org/changeset/211062
3255
3256 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3257
3258         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
3259         https://bugs.webkit.org/show_bug.cgi?id=167330
3260
3261         Reviewed by Tim Horton.
3262
3263         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3264         (TestWebKitAPI::TEST_F):
3265
3266 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3267
3268         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
3269         https://bugs.webkit.org/show_bug.cgi?id=167317
3270
3271         Reviewed by Sam Weinig.
3272
3273         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3274         (TestWebKitAPI::TEST_F):
3275
3276 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
3277
3278         svn-create-patch should emit properties when files are moved or copied
3279         https://bugs.webkit.org/show_bug.cgi?id=167264
3280
3281         Reviewed by Daniel Bates.
3282
3283         * Scripts/svn-create-patch:
3284         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
3285
3286 2017-01-23  Youenn Fablet  <youenn@apple.com>
3287
3288         [WebRTC] Filter libwebrtc link flags
3289         https://bugs.webkit.org/show_bug.cgi?id=167287
3290
3291         Reviewed by Alex Christensen.
3292
3293         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3294         (CMakeGenerator._compute_link_flags):
3295         (CMakeGenerator._compute_link_flags.keep_flag):
3296         (CMakeGenerator._generate_compile_target_options):
3297
3298 2017-01-23  Youenn Fablet  <youennf@gmail.com>
3299
3300         [WebRTC] Make VP8 optional in libwebrtc
3301         https://bugs.webkit.org/show_bug.cgi?id=167257
3302
3303         Reviewed by Darin Adler.
3304
3305         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3306         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
3307
3308 2017-01-23  Jer Noble  <jer.noble@apple.com>
3309
3310         Video details does not apear and missing scrubber in Control Center
3311         https://bugs.webkit.org/show_bug.cgi?id=167233
3312
3313         Reviewed by Alex Christensen.
3314
3315         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
3316         NowPlayingControlTests for iOS.
3317
3318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3319         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3320         (-[NowPlayingTestWebView setWindowVisible:]):
3321         (TestWebKitAPI::TEST):
3322         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
3323         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3324         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3325         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
3326         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
3327         (SOFT_LINK_CLASS):
3328         (-[TestMessageHandler addMessage:withHandler:]):
3329         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3330         (__simulated_forceClickAssociatedEventsMask):
3331         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3332         (-[TestWKWebViewHostWindow isKeyWindow]):
3333         (-[TestWKWebViewHostWindow makeKeyWindow]):
3334         (-[TestWKWebViewHostWindow resignKeyWindow]):
3335         (-[TestWKWebView initWithFrame:]):
3336         (-[TestWKWebView initWithFrame:configuration:]):
3337         (-[TestWKWebView _setUpTestWindow:]):
3338         (-[TestWKWebView performAfterReceivingMessage:action:]):
3339         (-[TestWKWebView loadTestPageNamed:]):
3340         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
3341         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3342         (-[TestWKWebView waitForMessage:]):
3343         (-[TestWKWebView performAfterLoading:]):
3344         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3345         (-[TestWKWebView typeCharacter:]):
3346
3347 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         Unreviewed. Bring back gtk-doc error messages after r209981.
3350
3351         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
3352         impossible to know what's wrong.
3353
3354         * gtk/gtkdoc.py:
3355         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
3356
3357 2017-01-20  Youenn Fablet  <youennf@gmail.com>
3358
3359         [WebRTC] Update build system to make G711 optional in libwebrtc
3360         https://bugs.webkit.org/show_bug.cgi?id=167256
3361
3362         Reviewed by Alex Christensen.
3363
3364         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3365         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
3366
3367 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3368
3369         Cleanup RuntimeEnabledFeatures
3370         https://bugs.webkit.org/show_bug.cgi?id=167228
3371
3372         Reviewed by Simon Fraser.
3373
3374         * DumpRenderTree/mac/DumpRenderTree.mm:
3375         (enableExperimentalFeatures):
3376         (resetWebPreferencesToConsistentValues):
3377         (setWebPreferencesForTestOptions):
3378         (resetWebViewToConsistentStateBeforeTesting):
3379         * DumpRenderTree/win/DumpRenderTree.cpp:
3380         (enableExperimentalFeatures):
3381         (resetWebPreferencesToConsistentValues):
3382         More closely match WebKitTestRunner initialization of preferences
3383         for experimental features.
3384
3385 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3386
3387         Build Fix for Windows DumpRenderTree after r210976
3388         https://bugs.webkit.org/show_bug.cgi?id=167115
3389
3390         * DumpRenderTree/win/DumpRenderTree.cpp:
3391         (resetWebPreferencesToConsistentValues):
3392
3393 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3394
3395         Remove outdated ENABLE(CSP_NEXT) build flag
3396         https://bugs.webkit.org/show_bug.cgi?id=167252
3397
3398         Reviewed by Brent Fulgham.
3399
3400         * Scripts/webkitperl/FeatureList.pm:
3401         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3402
3403 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3404
3405         Build Fix for Windows DumpRenderTree after r210976
3406
3407         * DumpRenderTree/win/DumpRenderTree.cpp:
3408         (resetWebPreferencesToConsistentValues):
3409
3410 2017-01-20  Antoine Quint  <graouts@apple.com>
3411
3412         Web Animations should be off by default and enabled as an experimental feature
3413         https://bugs.webkit.org/show_bug.cgi?id=167115
3414         <rdar://problem/30048963>
3415
3416         Reviewed by Joseph Pecoraro.
3417
3418         Turn Web Animations on in DRT.
3419
3420         * DumpRenderTree/mac/DumpRenderTree.mm:
3421         (resetWebPreferencesToConsistentValues):
3422         * DumpRenderTree/win/DumpRenderTree.cpp:
3423         (resetWebPreferencesToConsistentValues):
3424
3425 2017-01-20  Youenn Fablet  <youenn@apple.com>
3426
3427         [WebRTC] Add libwebrtc build infrastructure
3428         https://bugs.webkit.org/show_bug.cgi?id=167207
3429
3430         Reviewed by Alex Christensen.
3431
3432         Adding a script doing the libwebrtc project json to CMake file conversion.
3433
3434         * Scripts/generate-libwebrtc-cmake: Added.
3435         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3436         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3437
3438 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3439
3440         Mini Browser: Show tooltip for Experimental Features
3441         https://bugs.webkit.org/show_bug.cgi?id=167225
3442
3443         Reviewed by Alex Christensen.
3444
3445         * MiniBrowser/mac/SettingsController.m:
3446         (-[SettingsController _populateMenu]):
3447         Include the full details string as a tooltip.
3448
3449 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3450
3451         [Win] Test output results should not be written twice.
3452         https://bugs.webkit.org/show_bug.cgi?id=167197
3453
3454         Reviewed by Brent Fulgham.
3455
3456         Prevent test output from being written twice by returning early from
3457         the dump() function, if it already has been called.
3458         This patch also adds a missing newline to a test output line. 
3459         
3460         * DumpRenderTree/win/DumpRenderTree.cpp:
3461         (dump):
3462
3463 2017-01-20  Antoine Quint  <graouts@apple.com>
3464
3465         [Modern Media Controls] Turn modern media controls on by default
3466         https://bugs.webkit.org/show_bug.cgi?id=165668
3467
3468         Reviewed by Dean Jackson.
3469
3470         Enabled modern media controls by default in test runners.
3471
3472         * DumpRenderTree/TestOptions.h:
3473         * WebKitTestRunner/TestOptions.h:
3474
3475 2017-01-19  Chris Dumez  <cdumez@apple.com>
3476
3477         iterable<> should be enabled on WK1
3478         https://bugs.webkit.org/show_bug.cgi?id=167221
3479         <rdar://problem/30108531>
3480
3481         Reviewed by Youenn Fablet.
3482
3483         * DumpRenderTree/mac/DumpRenderTree.mm:
3484         (resetWebPreferencesToConsistentValues):
3485         * DumpRenderTree/win/DumpRenderTree.cpp:
3486         (resetWebPreferencesToConsistentValues):
3487         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3488         (WTR::InjectedBundle::beginTesting):
3489         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3490         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3492
3493 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3494
3495         Ensure status server logs go to log file
3496         https://bugs.webkit.org/show_bug.cgi?id=167210
3497
3498         Reviewed by Alexey Proskuryakov.
3499
3500         * Scripts/webkitpy/common/net/statusserver.py:
3501         (StatusServer.next_work_item): Change log level from debug to info in
3502         order to facilitate deubgging issues.
3503         (StatusServer.update_work_items): Same.
3504
3505 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3506
3507         Additional selection tests and interpolation fix
3508         https://bugs.webkit.org/show_bug.cgi?id=167171
3509
3510         Reviewed by Simon Fraser.
3511
3512         We weren't adding the final event when interpolating event streams.
3513
3514         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3515         (-[HIDEventGenerator interpolatedEvents:]):
3516
3517 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3518
3519         [Cocoa] Variation fonts are erroneously disabled on iOS
3520         https://bugs.webkit.org/show_bug.cgi?id=167172
3521
3522         Reviewed by Simon Fraser.
3523
3524         OpenSource builders don't seem to understand sdk=embedded*.
3525
3526         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3527
3528 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3529
3530         Unreviewed. Fix GTK+ unit tests failing since r210531.
3531
3532         Avoid using paths to files that don't actually exist.
3533
3534         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3535         (testWebKitConsoleMessageNetworkError):
3536         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3537         (testContextMenuDefaultMenu):
3538         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3539         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3540         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3541
3542 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3543
3544         [GTK] Provide API to set proxy settings
3545         https://bugs.webkit.org/show_bug.cgi?id=128674
3546
3547         Reviewed by Michael Catanzaro.
3548
3549         Add tests for new proxy settings API.
3550
3551         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3552         (serverCallback):
3553         (ProxyTest::ProxyTest):
3554         (ProxyTest::~ProxyTest):
3555         (ProxyTest::loadURIAndGetMainResourceData):
3556         (ProxyTest::proxyServerPortAsString):
3557         (testWebContextProxySettings):
3558         (beforeAll):
3559
3560 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3561
3562         Add back my old email address so old commits will still match it.
3563
3564         * Scripts/webkitpy/common/config/contributors.json:
3565
3566 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3567
3568         Remove my old email address from contributors.json and watchlist.
3569
3570         * Scripts/validate-committer-lists:
3571         (CommitterListFromGit): Change the mapping to the correct email.
3572         * Scripts/webkitpy/common/config/contributors.json:
3573         * Scripts/webkitpy/common/config/watchlist:
3574
3575 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3576
3577         Unreviewed, rolling out r210848.
3578
3579         This change introduced media-related LayoutTest failures and
3580         crashes on macOS.
3581
3582         Reverted changeset:
3583
3584         "[Modern Media Controls] Turn modern media controls on by
3585         default"
3586         https://bugs.webkit.org/show_bug.cgi?id=165668
3587         http://trac.webkit.org/changeset/210848
3588
3589 2017-01-18  Andreas Kling  <akling@apple.com>
3590
3591         Document::securityOrigin() should return a reference.
3592         <https://webkit.org/b/167124>
3593
3594         Reviewed by Sam Weinig.
3595
3596         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3597         (TestWebKitAPI::TEST_F):
3598
3599 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3600
3601         [Win] Clipboard tests are flaky.
3602         https://bugs.webkit.org/show_bug.cgi?id=167088
3603
3604         Reviewed by Brent Fulgham.
3605
3606         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3607         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3608
3609         * DumpRenderTree/win/DumpRenderTree.cpp:
3610         (main):
3611
3612 2017-01-18  Antoine Quint  <graouts@apple.com>
3613
3614         [Modern Media Controls] Turn modern media controls on by default
3615         https://bugs.webkit.org/show_bug.cgi?id=165668
3616
3617         Reviewed by Dean Jackson.
3618
3619         Enabled modern media controls by default in test runners. 
3620
3621         * DumpRenderTree/TestOptions.h:
3622         * WebKitTestRunner/TestOptions.h:
3623
3624 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3625
3626         Unreviewed, rolling out r210834
3627         https://bugs.webkit.org/show_bug.cgi?id=165668
3628
3629         It introduced dozens of test timeouts.
3630
3631         Reverted changeset:
3632         "[Modern Media Controls] Turn modern media controls on by default"
3633         https://bugs.webkit.org/show_bug.cgi?id=165668
3634         http://trac.webkit.org/changeset/210834
3635
3636 2017-01-17  Antoine Quint  <graouts@apple.com>
3637
3638         [Modern Media Controls] Turn modern media controls on by default
3639         https://bugs.webkit.org/show_bug.cgi?id=165668
3640
3641         Reviewed by Dean Jackson.
3642
3643         Enabled modern media controls by default in test runners. 
3644
3645         * DumpRenderTree/TestOptions.h:
3646         * WebKitTestRunner/TestOptions.h:
3647
3648 2017-01-17  Chris Dumez  <cdumez@apple.com>
3649
3650         Document title changed twice when setting document.title
3651         https://bugs.webkit.org/show_bug.cgi?id=167065
3652
3653         Reviewed by Darin Adler.
3654
3655         Add WebKit2GTK API test that was written by Michael Catanzaro.
3656
3657         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3658         (testWebViewTitleChange):
3659         (beforeAll):
3660
3661 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3662
3663         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3664         https://bugs.webkit.org/show_bug.cgi?id=116551
3665         <rdar://problem/13949830>
3666
3667         Reviewed by Alex Christensen.
3668
3669         * Scripts/webkitperl/FeatureList.pm:
3670         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3671         that is part of the existing WEB_TIMING feature.
3672
3673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3674
3675 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3676
3677         'webkit-patch post' no longer works with moved/copied files
3678         https://bugs.webkit.org/show_bug.cgi?id=166914
3679         <rdar://problem/29979707>
3680
3681         Reviewed by Daniel Bates.
3682
3683         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3684         file outputs only the "Index:" line with an empty body.  This workaround
3685         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3686         public email list tracking this bug is below.
3687         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3688         
3689
3690         * Scripts/svn-create-patch:
3691         (generateDiff): Ignore an "Index:" line with an empty body.
3692
3693 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3694
3695         Remove the REQUEST_ANIMATION_FRAME flag
3696         https://bugs.webkit.org/show_bug.cgi?id=156980
3697         <rdar://problem/25906849>
3698
3699         Reviewed by Simon Fraser.
3700
3701         * Scripts/webkitperl/FeatureList.pm:
3702         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3703
3704 2017-01-15  Sam Weinig  <sam@webkit.org>
3705
3706         Add the ability to use numbers in makeString()
3707         https://bugs.webkit.org/show_bug.cgi?id=167087
3708
3709         Reviewed by Darin Adler.
3710
3711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3712         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3713         Add tests for StringConcatenate, focusing on new numeric additions.
3714
3715 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3716
3717         Unreviewed, remove stale comment.
3718
3719         This test was fixed by r163173.
3720
3721         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3722
3723 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3724
3725         Annotate large string tests with largeHeap
3726         https://bugs.webkit.org/show_bug.cgi?id=167054
3727
3728         Reviewed by Filip Pizlo.
3729
3730         * Scripts/run-javascriptcore-tests:
3731         * Scripts/run-jsc-stress-tests:
3732
3733 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3734
3735         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3736         https://bugs.webkit.org/show_bug.cgi?id=167043
3737
3738         Reviewed by Darin Adler.
3739
3740         * Scripts/webkitperl/FeatureList.pm:
3741
3742 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3743
3744         Remove ENABLE(DETAILS_ELEMENT) guards
3745         https://bugs.webkit.org/show_bug.cgi?id=167042
3746
3747         Reviewed by Alex Christensen.
3748
3749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3750
3751 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3752
3753         26 MotionMark performance tests failing
3754         https://bugs.webkit.org/show_bug.cgi?id=166854
3755
3756         Reviewed by Ryosuke Niwa.
3757
3758         Unrelated change. This is the last place that we need to rename Animometer
3759         to MotionMark.
3760
3761         * Scripts/webkitpy/common/config/watchlist:
3762
3763 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3764
3765         run-jsc-benchmarks' echo should have -e option
3766         https://bugs.webkit.org/show_bug.cgi?id=167009
3767
3768         Reviewed by Sam Weinig.
3769
3770         echo requires `-e` option to use escape sequence.
3771         Without it, in some environment (in my Fedora 25), the escape sequence is not
3772         recognized and just dumped as `\c` etc.
3773
3774         * Scripts/run-jsc-benchmarks:
3775
3776 2017-01-12  Chris Dumez  <cdumez@apple.com>
3777
3778         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3779         https://bugs.webkit.org/show_bug.cgi?id=166995
3780
3781         Reviewed by Jer Noble.
3782
3783         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3784         as some people are having trouble building without it.
3785
3786         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3787
3788 2017-01-12  Sam Weinig  <sam@webkit.org>
3789
3790         Add the ability to filter the set of bindings tests you want to run
3791         https://bugs.webkit.org/show_bug.cgi?id=166977
3792
3793         Reviewed by Tim Horton.
3794
3795         Allows doing things like:
3796             run-bindings-tests TestObj* TestCEReactions*
3797         
3798         to run only those tests that match the patterns.
3799
3800         * Scripts/run-bindings-tests:
3801         (main):
3802         Switch to using optparse and pass the remaining args as the filters.
3803
3804         * Scripts/webkitpy/bindings/main.py:
3805         (BindingsTests.__init__):
3806         Store the pattens.
3807
3808         (BindingsTests.test_matches_patterns):
3809         Add helper predicate to determine if a test should be run. When no
3810         patterns are present, all tests should run.
3811
3812         (BindingsTests.run_tests):
3813         Filter tests using the passed in patterns.
3814
3815 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3816
3817         Followup fix after r210503.
3818         https://bugs.webkit.org/show_bug.cgi?id=166887
3819
3820         Reviewed by Alex Christensen.
3821
3822         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3823         duplicated file handle on Windows. This patch fixes the remaining call sites.
3824
3825         * DumpRenderTree/PixelDumpSupport.cpp:
3826         * DumpRenderTree/TestRunner.cpp:
3827         (TestRunner::waitToDumpWatchdogTimerFired):
3828         * DumpRenderTree/TestRunner.h:
3829         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3830         * DumpRenderTree/win/DumpRenderTree.cpp:
3831         * DumpRenderTree/win/DumpRenderTreeWin.h:
3832         * DumpRenderTree/win/TestRunnerWin.cpp:
3833         (TestRunner::setSpellCheckerLoggingEnabled):
3834
3835 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3836
3837         Add committer status for Megan
3838         https://bugs.webkit.org/show_bug.cgi?id=166954
3839
3840         Reviewed by Tim Horton.
3841
3842         Add committer status for Megan Gardner
3843
3844         * Scripts/webkitpy/common/config/contributors.json:
3845
3846 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3847
3848         Unreviewed test fix after r210599.
3849
3850         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3851         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3852
3853 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3854
3855         Unreviewed build fix after r210599.
3856
3857         Add missing files.
3858
3859         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3860         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3861
3862 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3863
3864         File scheme should not allow access of a resource on a different volume.
3865         https://bugs.webkit.org/show_bug.cgi?id=158552
3866         <rdar://problem/15307582>
3867
3868         Reviewed by Alex Christensen.
3869
3870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3871         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3872         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3873
3874 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3875
3876         Unreviewed, rolling out r210571.
3877
3878         This change broke the 32-bit macOS build and caused LayoutTest
3879         failures.
3880
3881         Reverted changeset:
3882
3883         "File scheme should not allow access of a resource on a
3884         different volume."
3885         https://bugs.webkit.org/show_bug.cgi?id=158552
3886         http://trac.webkit.org/changeset/210571
3887
3888 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3889
3890         [GTK] install-dependencies script misses gdb
3891         https://bugs.webkit.org/show_bug.cgi?id=166917
3892
3893         Reviewed by Michael Catanzaro.
3894
3895         gdb is needed for generating the crash logs.
3896
3897         * gtk/install-dependencies:
3898
3899 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3900
3901         [GTK] No way for applications to set notification permissions without waiting for permission request
3902         https://bugs.webkit.org/show_bug.cgi?id=163366
3903
3904         Reviewed by Carlos Garcia Campos.
3905
3906         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3907         (testWebViewNotification):
3908         (setInitialNotificationPermissionsAllowedCallback):
3909         (setInitialNotificationPermissionsDisallowedCallback):
3910         (testWebViewNotificationInitialPermissionAllowed):
3911         (testWebViewNotificationInitialPermissionDisallowed):
3912         (beforeAll):
3913         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3914         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3915         (WebViewTest::WebViewTest):
3916         (WebViewTest::initializeWebView):
3917         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3918
3919 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3920
3921         MobileMiniBrowser tests don't work by default
3922         https://bugs.webkit.org/show_bug.cgi?id=166910
3923
3924         Reviewed by Alex Christensen.
3925
3926         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3927         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3928
3929 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3930
3931         File scheme should not allow access of a resource on a different volume.
3932         https://bugs.webkit.org/show_bug.cgi?id=158552
3933         <rdar://problem/15307582>
3934
3935         Reviewed by Alex Christensen.
3936
3937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3938         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3939         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3940
3941 2017-01-10  Mark Lam  <mark.lam@apple.com>
3942
3943         Reverting run-jsc-stress-tests' $buildType to use string values.
3944         https://bugs.webkit.org/show_bug.cgi?id=166912
3945
3946         Rubber stamped by Filip Pizlo.
3947
3948         This is so that we can test for it in the tests e.g.
3949         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3950
3951         * Scripts/run-jsc-stress-tests:
3952
3953 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3954
3955         Temporarily add back the file removed in r210463 to unbreak internal bots.
3956
3957         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3958
3959 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3960
3961         svn-apply failed to apply a patch (deleting file with svn property)
3962         https://bugs.webkit.org/show_bug.cgi?id=165953
3963
3964         Reviewed by Daniel Bates.
3965
3966         * Scripts/VCSUtils.pm:
3967         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3968         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3969
3970 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3971
3972         Update flakiness dashboard configuration.
3973         https://bugs.webkit.org/show_bug.cgi?id=166869
3974
3975         Reviewed by Alexey Proskuryakov.
3976
3977         * TestResultServer/static-dashboards/builders.jsonp:
3978         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3979
3980 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3981
3982         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3983         https://bugs.webkit.org/show_bug.cgi?id=165232
3984
3985         Unreviewed follow-up patch after r210539 and r210523.
3986
3987         Instead of using that environment variable, the argument
3988         --display-server=xorg should be passed now.
3989
3990         The GTK+ performance bot was the only bot using this, and is
3991         already passing --display-server=xorg after r210539.
3992
3993         * Scripts/webkitpy/port/gtk.py:
3994         (GtkPort._driver_class):
3995
3996 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3997
3998         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3999         https://bugs.webkit.org/show_bug.cgi?id=166872
4000
4001         Reviewed by Michael Catanzaro.
4002
4003         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
4004         Define the required "--display-server=driver" in the bot additionalArguments config entry.
4005         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
4006         The step RunWebKitTests already has support for it.
4007
4008         * BuildSlaveSupport/build.webkit.org-config/config.json:
4009         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4010         (RunGtkAPITests.start):
4011         (RunAndUploadPerfTests.start):
4012         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4013
4014 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
4015
4016         Unreviewed, rolling out r210531.
4017
4018         This change broke the 32-bit macOS build and caused LayoutTest
4019         failures.
4020
4021         Reverted changeset:
4022
4023         "File scheme should not allow access of a resource on a
4024         different volume."
4025         https://bugs.webkit.org/show_bug.cgi?id=158552
4026         http://trac.webkit.org/changeset/210531
4027
4028 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
4029
4030         File scheme should not allow access of a resource on a different volume.
4031         https://bugs.webkit.org/show_bug.cgi?id=158552
4032         <rdar://problem/15307582>
4033
4034         Reviewed by Alex Christensen.
4035
4036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
4037         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
4038         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
4039
4040 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4041
4042         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
4043         https://bugs.webkit.org/show_bug.cgi?id=165232
4044
4045         Reviewed by Michael Catanzaro.
4046
4047         Add a new WaylandDriver to run the tests in the user current wayland session.
4048
4049         Also merge all the configuration options for selecting the display server inside one
4050         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
4051
4052         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
4053
4054         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
4055         (TestRunner._create_driver):
4056         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4057         (parse_args):
4058         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4059         (PerfTestsRunner._parse_args):
4060         * Scripts/webkitpy/port/gtk.py:
4061         (GtkPort.__init__):
4062         (GtkPort._driver_class):
4063         (GtkPort._search_paths):
4064         * Scripts/webkitpy/port/waylanddriver.py: Added.
4065         (WaylandDriver):
4066         (WaylandDriver.check_driver):
4067         (WaylandDriver._setup_environ_for_test):
4068         (WaylandDriver._start):
4069
4070 2017-01-09  Andy Estes  <aestes@apple.com>
4071
4072         [QuickLook] Add a layout test for webkit.org/b/135651
4073         https://bugs.webkit.org/show_bug.cgi?id=166855
4074
4075         Reviewed by Andreas Kling.
4076
4077         * DumpRenderTree/mac/FrameLoadDelegate.mm:
4078         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
4079         errors with code WebKitErrorCannotShowURL.
4080         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4081         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
4082         not specific to WebKit2 error codes.
4083
4084 2017-01-09  Antoine Quint  <graouts@apple.com>
4085
4086         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
4087         https://bugs.webkit.org/show_bug.cgi?id=166837
4088
4089         Reviewed by Alex Christensen.
4090
4091         We now correctly handle the --absolutePath argument in DumpRenderTree and use
4092         the provided value when trying to determine the path to the test file. Failing
4093         that, we use the computed URL or the raw path provided to cover all cases.
4094         
4095         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
4096         by applying this patch and seeing the number test failures dramatically reduced
4097         with WK1 due to the option to turn modern media controls off for older media controls
4098         tests.
4099
4100         * DumpRenderTree/DumpRenderTree.h:
4101         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4102         (parseInputLine):
4103         * DumpRenderTree/TestOptions.h:
4104         * DumpRenderTree/TestOptions.mm:
4105         (TestOptions::TestOptions):
4106         * DumpRenderTree/mac/DumpRenderTree.mm:
4107         (runTest):
4108
4109 2017-01-09  Milan Crha  <mcrha@redhat.com>
4110
4111         prepare-ChangeLog: Correct help string for --style option
4112         https://bugs.webkit.org/show_bug.cgi?id=166725
4113
4114         Reviewed by Alexey Proskuryakov.
4115
4116         * Scripts/prepare-ChangeLog:
4117         (main):
4118
4119 2017-01-09  Lucas Forschler  <lforschler@apple.com>
4120
4121         https://bugs.webkit.org/show_bug.cgi?id=166839
4122         Add php7 support for macOS.
4123         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
4124
4125         Reviewed by Alexey Proskuryakov.
4126
4127         * Scripts/webkitpy/port/base.py:
4128         (Port._is_darwin_php_version_7):
4129         (Port._debian_php_version):
4130         (Port):
4131         (Port._darwin_php_version):
4132         (Port._apache_config_file_name_for_platform):
4133
4134 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4135
4136         [GTK] Should support key and code properties on keyboard events
4137         https://bugs.webkit.org/show_bug.cgi?id=166759
4138
4139         Reviewed by Carlos Garcia Campos.
4140
4141         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4142         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
4143         on tests.
4144
4145 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
4146
4147         [Win] Some tests are flaky because certain DLLs are writing to stdout.
4148         https://bugs.webkit.org/show_bug.cgi?id=166760
4149
4150         Reviewed by Darin Adler.
4151
4152         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
4153         We can work around that by duplicating and redirecting stdout.
4154
4155         * DumpRenderTree/PixelDumpSupport.cpp:
4156         (dumpWebViewAsPixelsAndCompareWithExpected):
4157         (printPNG):
4158         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4159         (logEventProc):
4160         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
4161         (DRTDesktopNotificationPresenter::showDesktopNotification):
4162         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
4163         (DRTDesktopNotificationPresenter::requestNotificationPermission):
4164         * DumpRenderTree/win/DumpRenderTree.cpp:
4165         (dumpFrameScrollPosition):
4166         (dumpHistoryItem):
4167         (dumpBackForwardList):
4168         (dump):
4169         (runTest):
4170         (main):
4171         * DumpRenderTree/win/DumpRenderTreeWin.h:
4172         * DumpRenderTree/win/EditingDelegate.cpp:
4173         (EditingDelegate::shouldBeginEditingInDOMRange):
4174         (EditingDelegate::shouldEndEditingInDOMRange):
4175         (EditingDelegate::shouldInsertNode):
4176         (EditingDelegate::shouldInsertText):
4177         (EditingDelegate::shouldDeleteDOMRange):
4178         (EditingDelegate::shouldChangeSelectedDOMRange):
4179         (EditingDelegate::shouldApplyStyle):
4180         (EditingDelegate::shouldChangeTypingStyle):
4181         (EditingDelegate::doPlatformCommand):
4182         (EditingDelegate::webViewDidBeginEditing):
4183         (EditingDelegate::webViewDidChange):
4184         (EditingDelegate::webViewDidEndEditing):
4185         (EditingDelegate::webViewDidChangeTypingStyle):
4186         (EditingDelegate::webViewDidChangeSelection):
4187         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4188         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
4189         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
4190         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
4191         (FrameLoadDelegate::didFailProvisionalLoadWithError):
4192         (FrameLoadDelegate::didCommitLoadForFrame):
4193         (FrameLoadDelegate::didReceiveTitle):
4194         (FrameLoadDelegate::didFinishLoadForFrame):
4195         (FrameLoadDelegate::didFailLoadWithError):
4196         (FrameLoadDelegate::willPerformClientRedirectToURL):
4197         (FrameLoadDelegate::didCancelClientRedirectForFrame):
4198         (FrameLoadDelegate::windowScriptObjectAvailable):
4199         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
4200         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
4201         (FrameLoadDelegate::didDisplayInsecureContent):
4202         (FrameLoadDelegate::didRunInsecureContent):
4203         (FrameLoadDelegate::webViewProgressFinishedNotification):
4204         * DumpRenderTree/win/HistoryDelegate.cpp:
4205         (HistoryDelegate::didNavigateWithNavigationData):
4206         (HistoryDelegate::didPerformClientRedirectFromURL):
4207         (HistoryDelegate::didPerformServerRedirectFromURL):
4208         (HistoryDelegate::updateHistoryTitle):
4209         (HistoryDelegate::populateVisitedLinksForWebView):
4210         * DumpRenderTree/win/PolicyDelegate.cpp:
4211         (PolicyDelegate::decidePolicyForNavigationAction):
4212         (PolicyDelegate::unableToImplementPolicyWithError):
4213         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4214         (ResourceLoadDelegate::willSendRequest):
4215         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
4216         (ResourceLoadDelegate::didReceiveResponse):
4217         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
4218         (ResourceLoadDelegate::didFailLoadingWithError):
4219         * DumpRenderTree/win/TestRunnerWin.cpp:
4220         (TestRunner::addDisallowedURL):
4221         (TestRunner::originsWithApplicationCache):
4222         (TestRunner::setStorageDatabaseIdleInterval):
4223         (TestRunner::closeIdleLocalStorageDatabases):
4224         (TestRunner::copyDecodedHostName):
4225         (TestRunner::copyEncodedHostName):
4226         (TestRunner::numberOfPendingGeolocationPermissionRequests):
4227         (TestRunner::isGeolocationProviderActive):
4228         (TestRunner::pathToLocalResource):
4229         (TestRunner::setMockDeviceOrientation):
4230         (TestRunner::setMockGeolocationPosition):
4231         (TestRunner::setMockGeolocationPositionUnavailableError):
4232         (TestRunner::setSpatialNavigationEnabled):
4233         (TestRunner::setAutomaticLinkDetectionEnabled):
4234         (TestRunner::isCommandEnabled):
4235         (TestRunner::authenticateSession):
4236         (TestRunner::addChromeInputField):
4237         (TestRunner::removeChromeInputField):
4238         (TestRunner::focusWebView):
4239         (TestRunner::grantWebNotificationPermission):
4240         (TestRunner::denyWebNotificationPermission):
4241         (TestRunner::removeAllWebNotificationPermissions):
4242         (TestRunner::simulateWebNotificationClick):
4243         (TestRunner::imageCountInGeneralPasteboard):
4244         * DumpRenderTree/win/UIDelegate.cpp:
4245         (UIDelegate::runJavaScriptAlertPanelWithMessage):
4246         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
4247         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
4248         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
4249         (UIDelegate::webViewAddMessageToConsole):
4250         (UIDelegate::exceededDatabaseQuota):
4251         (UIDelegate::setStatusText):
4252         (UIDelegate::didPressMissingPluginButton):
4253
4254 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4255
4256         Add a setting to create editable MiniBrowser windows by default
4257         https://bugs.webkit.org/show_bug.cgi?id=166806
4258
4259         Reviewed by Beth Dakin.
4260
4261         * MiniBrowser/mac/AppDelegate.m:
4262         (-[BrowserAppDelegate createBrowserWindowController:]):
4263         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
4264         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
4265         * MiniBrowser/mac/SettingsController.h:
4266         * MiniBrowser/mac/SettingsController.m:
4267         (-[SettingsController _populateMenu]):
4268         (-[SettingsController validateMenuItem:]):
4269         (-[SettingsController toggleCreateEditorByDefault:]):
4270         (-[SettingsController createEditorByDefault]):
4271         Add a setting and update the key equivalents accordingly.
4272         Also make sure to make the right kind of window on launch.
4273
4274 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4275
4276         Fix the 32-bit build.
4277
4278         * MiniBrowser/mac/BrowserWindowController.h:
4279         * MiniBrowser/mac/BrowserWindowController.m:
4280
4281 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4282
4283         Fix the 32-bit build.
4284
4285         * MiniBrowser/mac/BrowserWindowController.m:
4286
4287 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4288
4289         Make it possible to drop HTML files on the MiniBrowser icon
4290         https://bugs.webkit.org/show_bug.cgi?id=166802
4291
4292         Reviewed by Simon Fraser.
4293
4294         * MiniBrowser/mac/AppDelegate.m:
4295         (-[BrowserAppDelegate application:openFile:]):
4296         * MiniBrowser/mac/Info.plist:
4297         If you're using an editable window, the usual trick of dropping on the
4298         window doesn't work anymore (it makes an <attachment> instead).
4299
4300 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4301
4302         MiniBrowser window gets smaller each time it is instantiated
4303         https://bugs.webkit.org/show_bug.cgi?id=166807
4304
4305         Reviewed by Andy Estes.
4306
4307         * MiniBrowser/mac/BrowserWindowController.m:
4308         (-[BrowserWindowController windowDidLoad]):
4309         * MiniBrowser/mac/BrowserWindow.xib:
4310         Turn on full-window content view support with IB, instead of waiting
4311         until after the views have been loaded. This seems to resolve the
4312         longstanding ever-shrinking-window problem.
4313