148c7dfc82aa2b1ac35cae5e63046438d5b4e00b
[WebKit-https.git] / Tools / ChangeLog
1 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] WebKitDOM objects leaking
4         https://bugs.webkit.org/show_bug.cgi?id=118788
5
6         Reviewed by Darin Adler and Sergio Villar Senin.
7
8         Update DOMObjectCache unit test to check that DOM objects are also
9         released when new contents are loaded in the web view, and the old
10         document is detached from the frame.
11
12         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
13         (testWebKitDOMObjectCache):
14         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
15         (runTest):
16
17 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
18
19         W3C test importer default import folder should be LayoutTests/imported/w3c
20         https://bugs.webkit.org/show_bug.cgi?id=142728
21
22         Reviewed by Bem Jones-Bey.
23
24         * Scripts/webkitpy/w3c/test_importer.py:
25         (parse_args): Updating the default destination option value to 'imported/w3c'.
26
27 2015-03-17  Philippe Normand  <pnormand@igalia.com>
28
29         [GTK] basic OpenWebRTC build support
30         https://bugs.webkit.org/show_bug.cgi?id=142393
31
32         Reviewed by Carlos Garcia Campos.
33
34         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
35         is not the upstream OpenWebRTC repository. This temporary fork
36         contains a few patches needed by WebKit for audio/video rendering.
37
38 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
39
40         [CMake][EFL] Build test tools only for developer mode
41         https://bugs.webkit.org/show_bug.cgi?id=142761
42
43         Reviewed by Csaba Osztrogonác.
44
45         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
46
47         * CMakeLists.txt:
48
49 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
50
51         Remove never used "useLayerOnTop" bindings generator argument
52         https://bugs.webkit.org/show_bug.cgi?id=142773
53
54         Reviewed by Darin Adler.
55
56         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
57         (new):
58
59 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
60
61         Enable ES6 classes by default
62         https://bugs.webkit.org/show_bug.cgi?id=142774
63
64         Reviewed by Gavin Barraclough.
65
66         * Scripts/webkitperl/FeatureList.pm:
67
68 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
69
70         Fix webkitpy tests after r181585.
71
72         Looks like "me" cannot be anyone's email, it's a special case.
73
74         * Scripts/webkitpy/common/config/contributors.json:
75
76 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
77
78         Add tolerance to WebAudio tests
79         https://bugs.webkit.org/show_bug.cgi?id=142676
80
81         Reviewed by Tim Horton.
82
83         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
84
85         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
86         (TestResultWriter.create_audio_diff_and_write_result):
87         * Scripts/webkitpy/layout_tests/models/test_failures.py:
88         (FailureAudio.write_failure):
89         * Scripts/webkitpy/port/base.py:
90         (Port.do_audio_results_differ):
91         Diff audio failures.
92
93         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
94         tests to use real parseable WAV data, and got rid of base64, which there didn't
95         seem to have been any reason for.
96
97 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
98
99         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
100         https://bugs.webkit.org/show_bug.cgi?id=142720
101
102         Reviewed by Myles C. Maxfield.
103
104         Activate system copies of Microsoft fonts for the current process, thus overriding
105         any other ones that could be preferred by the system otherwise.
106
107         * DumpRenderTree/mac/DumpRenderTree.mm:
108         (activateSystemCoreWebFonts):
109         (adjustFonts):
110         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
111         (WTR::activateSystemCoreWebFonts):
112         (WTR::activateFonts):
113
114 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
115
116         Created Streams API watchlist
117         https://bugs.webkit.org/show_bug.cgi?id=142684
118
119         Reviewed by Benjamin Poulain.
120
121         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
122         watchlist and added Benjamin, Youenn and me to it.
123
124 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
125
126         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
127         https://bugs.webkit.org/show_bug.cgi?id=142715
128
129         Reviewed by Brent Fulgham.
130
131         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
132         (TestWebKitAPI::TEST):
133
134 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
135
136         Change the exact attribute matching to be ASCII case-insensitive
137         https://bugs.webkit.org/show_bug.cgi?id=142609
138
139         Reviewed by Darin Adler.
140
141         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
142         * TestWebKitAPI/Tests/WTF/StringView.cpp:
143
144 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
145
146         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
147         https://bugs.webkit.org/show_bug.cgi?id=134764
148
149         Reviewed by Ryosuke Niwa.
150
151         TestDownloader is introduced to download W3C tests from the official
152         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
153         and https://github.com/w3c/csswg-test.git).
154         TestDownloader clones the repositories and checkouts revisions of the tests
155         defined in LayoutTests/imported/w3c/resources/TestRepositories.
156
157         Similarly to https://codereview.chromium.org/148173016,
158         TestDownloader copies part of the files based on the rules
159         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
160
161         TestDownloader is used by TestImporter when no source directory is provided.
162
163         * Scripts/webkitpy/w3c/test_downloader.py: Added.
164         (TestDownloader):
165         (TestDownloader.default_options):
166         (TestDownloader.load_test_repositories):
167         (TestDownloader.__init__):
168         (TestDownloader.checkout_test_repository):
169         (TestDownloader._init_paths_from_expectations):
170         (TestDownloader._add_test_suite_paths):
171         (TestDownloader._empty_directory):
172         (TestDownloader.copy_tests):
173         (TestDownloader.download_tests):
174         * Scripts/webkitpy/w3c/test_importer.py:
175         (main):
176         (parse_args):
177         (TestImporter.__init__):
178         (TestImporter.do_import):
179         (TestImporter.test_downloader):
180         (TestImporter.find_importable_tests.should_keep_subdir):
181         (TestImporter.should_convert_test_harness_links):
182         (TestImporter.import_tests):
183         (TestImporter.write_import_log):
184
185 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
186
187         [Mavericks] Test snapshots are 1600x1200 on Retina devices
188         https://bugs.webkit.org/show_bug.cgi?id=142630
189
190         Reviewed by Tim Horton.
191
192         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
193         Removed an ifdef that disabled the fix on Mavericks.
194
195 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
196
197         Remove isWK2 cruft from webkitdirs.pm after r170426
198         https://bugs.webkit.org/show_bug.cgi?id=142618
199
200         Reviewed by Daniel Bates.
201
202         * Scripts/webkitdirs.pm:
203         (isWK2): Deleted.
204
205 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
206
207         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
208         https://bugs.webkit.org/show_bug.cgi?id=138687
209
210         Reviewed by Carlos Garcia Campos.
211
212         Always change cookie policy from UI process, as changing it from WebProcess doesn't
213         affect other processes.
214
215         The implementation is imperfect, because the change happens asynchronously, but I
216         don't expect it to be a problem in practice.
217
218         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
219         (WTR::InjectedBundle::beginTesting):
220         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
221         (WTR::TestRunner::setAlwaysAcceptCookies):
222         * WebKitTestRunner/TestInvocation.cpp:
223         (WTR::TestInvocation::invoke):
224         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
225
226 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
227
228         [EFL] Enable building EFL 1.13 with NEON support
229         https://bugs.webkit.org/show_bug.cgi?id=142619
230
231         Reviewed by Gyuyoung Kim.
232
233         * efl/jhbuild.modules:
234
235 2015-03-11  Alex Christensen  <achristensen@webkit.org>
236
237         [Content Extensions] Add resource type and load type triggers.
238         https://bugs.webkit.org/show_bug.cgi?id=142422
239
240         Reviewed by Benjamin Poulain.
241
242         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
243         (TestWebKitAPI::testRequest):
244         (TestWebKitAPI::mainDocumentRequest):
245         (TestWebKitAPI::TEST_F):
246         (TestWebKitAPI::testURL): Deleted.
247
248 2015-03-10  Sam Weinig  <sam@webkit.org>
249
250         Allow adding a button in input elements for auto fill related functionality
251         <rdar://problem/19782066>
252         https://bugs.webkit.org/show_bug.cgi?id=142564
253
254         Reviewed by Anders Carlsson.
255
256         * WebKitTestRunner/TestController.cpp:
257         (WTR::TestController::createOtherPage):
258         (WTR::TestController::createWebViewWithOptions):
259         Update for new callback.
260
261 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
262
263         Add basic support for BOL and EOL assertions to the URL Filter parser
264         https://bugs.webkit.org/show_bug.cgi?id=142568
265
266         Reviewed by Alex Christensen.
267
268         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
269         (TestWebKitAPI::TEST_F):
270
271 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
272
273         [GTK] Add support for handling TLS errors to MiniBrowser
274         https://bugs.webkit.org/show_bug.cgi?id=142576
275
276         Reviewed by Sergio Villar Senin.
277
278         It's useful for testing TLS errors handling itself, but also to
279         allow ignoring TLS errors when testing.
280
281         * MiniBrowser/gtk/BrowserWindow.c:
282         (webViewLoadFailedWithTLSerrors):
283         (browserWindowConstructed):
284
285 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
286
287         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
288         https://bugs.webkit.org/show_bug.cgi?id=142569
289
290         Reviewed by David Hyatt.
291
292         Test Optional::valueOrCompute().
293
294         * TestWebKitAPI/Tests/WTF/Optional.cpp:
295         (TestWebKitAPI::TEST):
296
297 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
298
299         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
300         https://bugs.webkit.org/show_bug.cgi?id=126688
301
302         Reviewed by Gustavo Noronha Silva.
303
304         * CMakeLists.txt: Build testing tools only for developer builds,
305         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
306         * MiniBrowser/gtk/CMakeLists.txt: Only add
307         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
308         and add a rule to install the MiniBrowser.
309         * MiniBrowser/gtk/main.c:
310         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
311         builds.
312
313 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
314
315         Add some DateMath tests to TestWebKitAPI
316         https://bugs.webkit.org/show_bug.cgi?id=142565
317
318         Reviewed by Alexey Proskuryakov.
319
320         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
321         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
322         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
324         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
325
326 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
327
328         Regression(r181257): WTF_WorkQueue.Simple is flaky
329         https://bugs.webkit.org/show_bug.cgi?id=142560
330
331         Unreviewed attempt to improve test stability.
332
333         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
334         the WorkQueue a little later to redue flakiness.
335
336 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
337
338         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
339         https://bugs.webkit.org/show_bug.cgi?id=142555
340
341         Reviewed by Simon Fraser.
342
343         * DumpRenderTree/mac/DumpRenderTree.mm:
344         (setDefaultsToConsistentValuesForTesting):
345         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
346         (WTR::InjectedBundle::platformInitialize):
347
348 2015-03-10  Alex Christensen  <achristensen@webkit.org>
349
350         Use unsigned for HashSet size.
351         https://bugs.webkit.org/show_bug.cgi?id=142518
352
353         Reviewed by Benjamin Poulain.
354
355         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
356         (TestWebKitAPI::TEST):
357         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
358         (TestWebKitAPI::testInitialCapacity):
359         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
360         (TestWebKitAPI::TEST):
361
362 2015-03-10  Daniel Bates  <dabates@apple.com>
363
364         [iOS] Add WebKitSystemInterface for iOS 8.2
365         https://bugs.webkit.org/show_bug.cgi?id=142505
366
367         Rubber-stamped by Anders Carlsson.
368
369         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
370         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
371         copy-webkitlibraries-to-product-directory in r181286.
372
373         * Scripts/copy-webkitlibraries-to-product-directory:
374
375 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
376
377         Extend URL filter's Term definition to support groups/subpatterns
378         https://bugs.webkit.org/show_bug.cgi?id=142519
379
380         Reviewed by Alex Christensen.
381
382         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
383         (TestWebKitAPI::testURL):
384
385 2015-03-06  Jer Noble  <jer.noble@apple.com>
386
387         Add an option to run-webkit-tests to override the LayoutTests/ directory
388         https://bugs.webkit.org/show_bug.cgi?id=142418
389
390         Reviewed by David Kilzer.
391
392         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
393         directory. The base port will parse the options during initialization and store the override
394         location if present. layout_tests_dir() will return this overridden location if set.
395
396         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
397         (parse_args):
398         * Scripts/webkitpy/port/base.py:
399         (Port.__init__):
400         (Port.layout_tests_dir):
401
402 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
403
404         [CMake] Enable WorkQueue tests for CMake ports
405         https://bugs.webkit.org/show_bug.cgi?id=142473
406
407         Reviewed by Darin Adler.
408
409         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
410         the list of source files.
411         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
412         to the list of include directories for EFL.
413
414 2015-03-09  David Kilzer  <ddkilzer@apple.com>
415
416         Attempt to fix timeouts on iOS Simulator layout tests
417
418         * Scripts/webkitpy/port/ios.py:
419         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
420         Simulator end after the first 50 tests time out.  Some analysis
421         this past weekend shows that the 'Booted' status in the output
422         of `xcrun simctl list` is not sufficient (and watching the test
423         run shows that SpringBoard hasn't fully started to the point
424         where it's displaying icons on the home screen).  The workaround
425         until we have a better fix is to add an arbitrary timeout to let
426         SpringBoard finish launching.  In practice, 15 seconds is
427         probably enough, but 30 seconds should nearly always work.
428
429 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
430
431         Unreviewed. Add myself as a committer.
432
433         * Scripts/webkitpy/common/config/contributors.json:
434
435 2015-03-09  David Kilzer  <ddkilzer@apple.com>
436
437         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
438
439         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
440         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
441         an expectation that will fail if we hit the race condition.
442         This test is inherently racy and will deadlock if the first job
443         for queue2 takes the mutex lock before the second job for
444         queue1.
445
446 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
447
448         [Win] WTF::WorkQueue does not balance ref/deref properly
449         https://bugs.webkit.org/show_bug.cgi?id=142471
450
451         Reviewed by Antti Koivisto.
452
453         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
454         (TestWebKitAPI::TEST): Check that the refcount is correct.
455
456 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
457
458         Do not show passing test result on output of EFL layout test
459         https://bugs.webkit.org/show_bug.cgi?id=142380
460
461         Reviewed by Darin Adler.
462
463         To show passing tests has caused inconvenience when we detect problem tests
464         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
465         in order not to show passing tests in the output of EFL layout test.
466
467         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
468         (RunWebKitTests.start):
469
470 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
471
472         Unreviewed build fix.
473
474         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
475         (TestWebKitAPI::TEST): Remove two unused variables.
476
477 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
478
479         Add some WorkQueue tests to TestWebKitAPI
480         https://bugs.webkit.org/show_bug.cgi?id=142447
481
482         Reviewed by Sam Weinig.
483
484         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
485         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
487         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
488         (TestWebKitAPI::simpleTest):
489         (TestWebKitAPI::longTest):
490         (TestWebKitAPI::thirdTest):
491         (TestWebKitAPI::finishedTests):
492         (TestWebKitAPI::TEST):
493         (TestWebKitAPI::longTest2):
494
495 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
496
497         Remove willDestroyFrame in WKBundlePageLoaderClient
498         https://bugs.webkit.org/show_bug.cgi?id=142389
499
500         Reviewed by Anders Carlsson.
501
502         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
503         (WTR::InjectedBundlePage::InjectedBundlePage):
504
505 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
506
507         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
508         https://bugs.webkit.org/show_bug.cgi?id=142433
509
510         Reviewed by Darin Adler.
511
512         Include more TestWebKitAPI tests when building for Windows. Also
513         fix a build error in MetaAllocator.cpp caused by one of the
514         Microsoft headers #defining 'small'.
515
516         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
517         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
518         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
519
520 2015-03-06  Sam Weinig  <sam@webkit.org>
521
522         [Content Extensions] Move compiling of content extensions to the UIProcess
523         https://bugs.webkit.org/show_bug.cgi?id=142402
524
525         Reviewed by Benjamin Poulain.
526
527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
528         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
529         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
530         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
531         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
532         (TestWebKitAPI::TEST_F):
533         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
534         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
535         is now abstract).
536
537 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
538
539         [Win] Correct Windows build.
540
541         Rubberstamped by Michael Saboff
542
543         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
544         in the GOTO labels.
545
546 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
547
548         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
549         https://bugs.webkit.org/show_bug.cgi?id=142385
550
551         Reviewed by Sergio Villar Senin.
552
553         Use stack allocated GMainLoopSources to make sure they are
554         cancelled automatically if the test finishes before they have
555         been processed.
556
557         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
558         (testWebViewSyncRequestOnMaxConns):
559
560 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
561
562         Remove Mountain Lion libraries since ML isn't supported
563         https://bugs.webkit.org/show_bug.cgi?id=142332
564
565         Reviewed by Darin Adler.
566
567         * Scripts/copy-webkitlibraries-to-product-directory:
568
569 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
570
571         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
572         https://bugs.webkit.org/show_bug.cgi?id=142083
573
574         Reviewed by Simon Fraser.
575
576         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
577
578         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
579         (WebPlatformTestServer._copy_webkit_test_files):
580
581 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
582
583         setup-git-clone fails due to the failure to download python-irclib-0.4.8
584         https://bugs.webkit.org/show_bug.cgi?id=141946
585
586         Reviewed by Ryosuke Niwa.
587
588         Check in ircbot.py and irclib.py to avoid network problems in the future.
589
590         * Scripts/webkitpy/common/net/irc/ircbot.py:
591         * Scripts/webkitpy/thirdparty/__init__.py:
592         (AutoinstallImportHook.find_module):
593         (AutoinstallImportHook._install_irc): Deleted.
594         * Scripts/webkitpy/thirdparty/__init___unittest.py:
595         (ThirdpartyTest.test_imports):
596         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
597         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
598         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
599
600 2015-03-06  David Kilzer  <ddkilzer@apple.com>
601
602         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
603
604         See also fix to config.json in r181097.
605
606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
607         (WebKitBuildbot): Add missing "WK2" to the names of the perf
608         bots.
609
610 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
611
612         run-jsc-stress-tests should determine the architecture from ELF binaries
613         https://bugs.webkit.org/show_bug.cgi?id=142335
614
615         Reviewed by Darin Adler.
616
617         * Scripts/run-jsc-stress-tests:
618
619 2015-03-05  David Kilzer  <ddkilzer@apple.com>
620
621         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
622         <http://webkit.org/b/142226>
623
624         Reviewed by Darin Adler.
625
626         * Scripts/webkitpy/port/ios.py:
627         (IOSSimulatorPort.default_baseline_search_path): Switch the
628         TestExpectations order of ios-simulator-wk2 from this:
629           ios-simulator-wk2, wk2, ios-simulator
630         To this:
631           ios-simulator-wk2, ios-simualtor, wk2
632
633 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
634
635         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
636         https://bugs.webkit.org/show_bug.cgi?id=142370
637
638         Reviewed by Dean Jackson.
639
640         * Scripts/webkitdirs.pm:
641         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
642         logs, one for warnings, the other for errors.
643         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
644         into the standard BuildOutput.htm document.
645
646 2015-03-05  David Kilzer  <ddkilzer@apple.com>
647
648         Dashboard has trouble parsing iOS test output
649         <http://webkit.org/b/142364>
650
651         Reviewed by Alex Christensen.
652
653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
654         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
655         Add fallback path to build a regex using 'matchString' so that
656         it matches anywhere in the line.  In practice, 'matchString' is
657         a prefix for the label following the number.
658
659 2015-03-05  Alex Christensen  <achristensen@webkit.org>
660
661         Fix linker warnings in TestWebKitAPI.
662         https://bugs.webkit.org/show_bug.cgi?id=141912
663
664         Reviewed by David Kilzer.
665
666         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
667         Do not export TearDownTestCase or SetUpTestCase symbols.
668
669 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
670
671         [Win] Unreviewed EWS fix.
672
673         * Scripts/webkitdirs.pm:
674         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
675         the EWS output more usable.
676
677 2015-03-05  Chris Dumez  <cdumez@apple.com>
678
679         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
680         https://bugs.webkit.org/show_bug.cgi?id=142350
681
682         Reviewed by Michael Saboff and Benjamin Poulain.
683
684         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
685         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
686
687         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
688         (TestWebKitAPI::TEST):
689
690 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
691
692         [Win] Ensure build target directory exists when launching MSBuild
693         https://bugs.webkit.org/show_bug.cgi?id=142360
694
695         Reviewed by Dean Jackson.
696
697         Create the build output directory (if it doesn't exist) before
698         launching MSBuild so that it can immediately begin writing logs.
699
700         * Scripts/webkitdirs.pm:
701         (buildVisualStudioProject):
702
703 2015-03-05  Chris Dumez  <cdumez@apple.com>
704
705         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
706         https://bugs.webkit.org/show_bug.cgi?id=142325
707
708         Reviewed by Csaba Osztrogonác.
709
710         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
711         As a result, "--webkit-test-runner / -2" parameters are replaced by
712         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
713         than WebKitTestRunner.
714
715         * BuildSlaveSupport/build.webkit.org-config/config.json:
716         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
717         (RunWebKit1Tests):
718         (RunWebKit1Tests.start):
719         (RunWebKit1LeakTests):
720         (RunWebKit1LeakTests.start):
721         (RunAndUploadPerfTestsWebKit1):
722         (RunAndUploadPerfTestsWebKit1.start):
723         (TestFactory):
724         (TestWebKit1LeaksFactory):
725         (TestWebKit1LeaksFactory.__init__):
726         (TestWebKit1Factory):
727         (TestWebKit1AllButJSCFactory):
728         (TestAllButJSCFactory):
729         (BuildAndPerfTestWebKit1Factory):
730         (BuildAndPerfTestWebKit1Factory.__init__):
731         (BuildAndPerfTestFactory):
732         (BuildAndPerfTestFactory.__init__):
733         (DownloadAndPerfTestWebKit1Factory):
734         (DownloadAndPerfTestWebKit1Factory.__init__):
735         (DownloadAndPerfTestFactory):
736         (DownloadAndPerfTestFactory.__init__):
737         (RunWebKitLeakTests): Deleted.
738         (RunWebKitLeakTests.start): Deleted.
739         (RunWebKit2Tests): Deleted.
740         (RunWebKit2Tests.start): Deleted.
741         (RunAndUploadPerfTestsWebKit2): Deleted.
742         (RunAndUploadPerfTestsWebKit2.start): Deleted.
743         (TestLeaksFactory): Deleted.
744         (TestLeaksFactory.__init__): Deleted.
745         (TestWebKit2Factory): Deleted.
746         (TestWebKit2AndJSCFactory): Deleted.
747         (BuildAndPerfTestWebKit2Factory): Deleted.
748         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
749         (DownloadAndPerfTestWebKit2Factory): Deleted.
750         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
751         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
752         (parse_args):
753         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
754         (PerfTestsRunner._parse_args):
755         * Scripts/webkitpy/port/port_testcase.py:
756         (PortTestCase.test_build_driver):
757
758 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
759
760         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
761         https://bugs.webkit.org/show_bug.cgi?id=140845
762
763         Reviewed by David Kilzer.
764
765         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
766         and generate suitable build commands to drive a full build from our
767         existing solution files.
768
769         * Scripts/webkitdirs.pm:
770         (msBuildInstallDir): Added.
771         (determineConfigurationForVisualStudio): Revise to use MSBuild command
772         line arguments to drive the build.
773         (setupCygwinEnv): Warn user if MSBuild cannot be located.
774         (buildVisualStudioProject): Revise to use MSBuild command line arguments
775         to specify build architecture.
776         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
777         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
778         bother looking for CoreUI or SafariTheme build logs.
779
780 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
781
782         [buildbot] mastercfg_unittest.py should be runnable easily
783         https://bugs.webkit.org/show_bug.cgi?id=142219
784
785         Reviewed by Chris Dumez.
786
787         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
788         the last Twisted version works together with this buildbot version.
789
790         * Scripts/webkitpy/common/system/autoinstall.py:
791         (AutoInstaller): Added prepend_to_search_path argument to be able
792         to prefer autoinstalled package to system package.
793         (AutoInstaller.__init__):
794         (AutoInstaller._set_up_target_dir):
795         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
796         (AutoInstaller._prepare_package):
797         (AutoInstaller._extract_targz): Renamed to _extract_tar.
798         * Scripts/webkitpy/thirdparty/__init__.py:
799         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
800
801 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
802
803         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
804         https://bugs.webkit.org/show_bug.cgi?id=131162
805
806         Reviewed by Gyuyoung Kim.
807
808         * MiniBrowser/efl/main.c:
809         (on_download_request):
810         (on_download_finished):
811         (on_download_failed):
812         (window_create):
813         Adapt download callbacks to new callback mechanism
814
815 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
816
817         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
818
819         In r180927 we updated the libsoup version used by the jhbuild. In
820         this new version the sniffer uses image/x-icon instead of
821         image/vnd.microsoft.icon for blank.ico resource.
822
823         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
824         (testWebResourceMimeType):
825
826 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
827
828         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
829         https://bugs.webkit.org/show_bug.cgi?id=142244
830
831         Reviewed by Sergio Villar Senin.
832
833         Check that the SSL server doesn't process any request in case of
834         TLS errors when the policy is set to FAIL.
835
836         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
837         (testTLSErrorsPolicy):
838         (testTLSErrorsRedirect):
839         (testTLSErrorsHTTPAuth):
840         (testLoadFailedWithTLSErrors):
841         (testSubresourceLoadFailedWithTLSErrors):
842         (httpsServerCallback):
843
844 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
845
846         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
847         https://bugs.webkit.org/show_bug.cgi?id=141154
848
849         Reviewed by Jer Noble.
850
851         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
852
853         For the sake of completeness WebKitTestRunner should specify temporary
854         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
855
856         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
857         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
858         to get data storage paths. Only Mac port has an actual implementation of it.
859         However, WebKitTestRunner overrides them in favour of unique temporary dir
860         which is taken from libraryPathForTesting().
861
862         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
863         is not implemented for EFL and GTK ports it returns an empty string.
864         All default data folders besides MediaKeys are overridden in TestRunner
865         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
866         env variable.
867
868         GTK port does not enable encrypted keys by default so
869         WebMediaKeyStorageManager::initialize() code path is never triggered.
870
871         * WebKitTestRunner/TestController.cpp:
872         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
873         WebKit ports.
874
875 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
876
877         [buildbot] Add regression test to check which builder runs which tests
878         https://bugs.webkit.org/show_bug.cgi?id=142166
879
880         Reviewed by Alexey Proskuryakov.
881
882         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
883         (BuildStepsConstructorTest.createTest):
884         (BuildStepsTest):
885         (BuildStepsTest.generateTests):
886         (BuildStepsTest.createTest):
887         (BuildStepsTest.createTest.doTest):
888         (BuildStepsTest.test_unnecessary_expected_results):
889
890 2015-03-04  Commit Queue  <commit-queue@webkit.org>
891
892         Unreviewed, rolling out r181054.
893         https://bugs.webkit.org/show_bug.cgi?id=142320
894
895         Broke the api tests (Requested by sundiamonde on #webkit).
896
897         Reverted changeset:
898
899         "Fix linker warnings in TestWebKitAPI."
900         https://bugs.webkit.org/show_bug.cgi?id=141912
901         http://trac.webkit.org/changeset/181054
902
903 2015-03-04  Alex Christensen  <achristensen@webkit.org>
904
905         Fix linker warnings in TestWebKitAPI.
906         https://bugs.webkit.org/show_bug.cgi?id=141912
907
908         Reviewed by David Kilzer.
909
910         * TestWebKitAPI/Configurations/Base.xcconfig:
911         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
912
913 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
914
915         [Mac] Set SystemUIFontSelect in DRT and WKTR
916         https://bugs.webkit.org/show_bug.cgi?id=142303
917
918         Reviewed by Myles C. Maxfield.
919
920         * DumpRenderTree/mac/DumpRenderTree.mm:
921         (setDefaultsToConsistentValuesForTesting):
922         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
923         (WTR::InjectedBundle::platformInitialize):
924
925 2015-03-04  Chris Dumez  <cdumez@apple.com>
926
927         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
928         https://bugs.webkit.org/show_bug.cgi?id=142314
929         <rdar://problem/20046835>
930
931         Reviewed by Ryosuke Niwa.
932
933         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
934         to get WK2 code coverage.
935
936         * BuildSlaveSupport/build.webkit.org-config/config.json:
937
938 2015-03-04  Alex Christensen  <achristensen@webkit.org>
939
940         Move content extensions test to properly named directory.
941         https://bugs.webkit.org/show_bug.cgi?id=142299
942
943         Reviewed by Tim Horton.
944
945         * WebKitTestRunner/mac/TestControllerMac.mm:
946         (WTR::TestController::platformConfigureViewForTest):
947
948 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
949
950         W3C test importer should use filesystem instead of os.walk
951         https://bugs.webkit.org/show_bug.cgi?id=142085
952
953         Reviewed by Bem Jones-Bey.
954
955         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
956         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
957         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
958
959         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
960         Added a unit test to check that test importer is now black-box testable using a Mock system.
961
962         * Scripts/webkitpy/common/system/filesystem.py:
963         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
964         (FileSystem.dirs_under.filter_all):
965         * Scripts/webkitpy/common/system/filesystem_mock.py:
966         (MockFileSystem.dirs_under):
967         (MockFileSystem.dirs_under.filter_all):
968         (MockFileSystem.getsize):
969         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
970         (MockFileSystemTest.test_dirs_under):
971         (MockFileSystemTest.test_dirs_under.filter_dir):
972         * Scripts/webkitpy/common/system/filesystem_unittest.py:
973         (RealFileSystemTest.test_sep):
974         (RealFileSystemTest):
975         (RealFileSystemTest.test_dirs_under):
976         (RealFileSystemTest.test_dirs_under.filter_this_dir):
977         * Scripts/webkitpy/w3c/test_importer.py:
978         (TestImporter.do_import):
979         (TestImporter.find_importable_tests.should_keep_subdir):
980         (TestImporter.find_importable_tests):
981         (TestImporter.should_keep_subdir): Deleted.
982         (TestImporter.should_skip_file): Deleted.
983         * Scripts/webkitpy/w3c/test_importer_unittest.py:
984         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
985
986 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
987
988         [WebEditingTester] Add support for the find and replace bar
989         https://bugs.webkit.org/show_bug.cgi?id=142247
990
991         Reviewed by Enrica Casucci.
992
993         While it's not hooked up yet in WKWebView, adding support for the
994         find bar to WebEditingTester will help us implement that functionality.
995
996         * WebEditingTester/AppDelegate.h:
997         * WebEditingTester/AppDelegate.m:
998         (-[WebEditingAppDelegate performTextFinderAction:]):
999         * WebEditingTester/MainMenu.xib:
1000         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1001
1002         * WebEditingTester/WK2WebDocumentController.m:
1003         (-[WK2WebDocumentController awakeFromNib]):
1004         (-[WK2WebDocumentController performTextFinderAction:]):
1005         (-[WK2WebDocumentController findBarView]):
1006         (-[WK2WebDocumentController setFindBarView:]):
1007         (-[WK2WebDocumentController isFindBarVisible]):
1008         (-[WK2WebDocumentController setFindBarVisible:]):
1009         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1010         (-[WK2WebDocumentController layout]):
1011         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1012         pointing at the WKWebView (currently nothing will work, but the bar will
1013         show up). Install and uninstall the bar as needed.
1014
1015         * WebEditingTester/WebDocument.xib:
1016         Don't use a full-size content view. There's no need, and it makes find
1017         bar layout harder.
1018
1019         * WebEditingTester/WebDocumentController.h:
1020         * WebEditingTester/WebDocumentController.m:
1021         (-[WebDocumentController performTextFinderAction:]):
1022
1023 2015-03-03  Sam Weinig  <sam@webkit.org>
1024
1025         [Content Extensions] Split parsing and compiling of content extensions into their own files
1026         https://bugs.webkit.org/show_bug.cgi?id=142259
1027
1028         Reviewed by Anders Carlsson.
1029
1030         Add basic unit test for the content filter compiler.
1031
1032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1033         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1034         (WebCore::ContentExtensions::operator<<):
1035         (TestWebKitAPI::ContentFilterTest::SetUp):
1036         (TestWebKitAPI::TEST_F):
1037
1038 2015-03-04  Matthew Mirman  <mmirman@apple.com>
1039
1040         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1041         https://bugs.webkit.org/show_bug.cgi?id=142230
1042
1043         Reviewed by Csaba Osztrogonác.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1046         (TestFactory):
1047         (TestFactory.getProduct): Added
1048         (TestFactory.__init__): moved downloader to getProduct
1049         (BuildAndTestFactory):        
1050         (BuildAndTestFactory.getProduct): Added
1051         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1052         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
1053
1054 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
1055
1056         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1057         https://bugs.webkit.org/show_bug.cgi?id=142225
1058
1059         Reviewed by Carlos Garcia Campos.
1060
1061         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1062         (testWebViewWebContextLifetime):
1063         (beforeAll):
1064
1065 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1066
1067         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1068         <http://webkit.org/b/142243>
1069
1070         Reviewed by Alexey Proskuryakov.
1071
1072         * WebKitTestRunner/TestController.cpp:
1073         (WTR::TestController::webProcessName):
1074         (WTR::TestController::networkProcessName):
1075         - Return the same process name on iOS and Mac because they both
1076           use the same process name for local engineering builds.
1077
1078 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1079
1080         check-webkit-style: Add exception for FrameworkSoftLink.h header order
1081         <http://webkit.org/b/141872>
1082
1083         Reviewed by Alex Christensen.
1084
1085         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1086         semi-colons in various places and fix whitespace.
1087         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1088         constants.
1089         (_IncludeState.__init__): Add self._visited_soft_link_section
1090         boolean state variable.
1091         (_IncludeState.visited_soft_link_section): Getter for
1092         self._visited_soft_link_section.
1093         (_IncludeState.check_next_include_order): Update state machine
1094         for soft-link headers.  Add check that soft-link headers always
1095         appear last.
1096         (_classify_include): Add check for soft-link header type.
1097         (check_include_line): Return early if there is a soft-link
1098         header error.
1099
1100         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1101         (OrderOfIncludesTest.test_public_primary_header): Add tests for
1102         including soft-link headers.
1103         (OrderOfIncludesTest.test_classify_include): Add test for
1104         _SOFT_LINK_HEADER type.
1105
1106 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
1107
1108         build.webkit.org/dashboard: Don't repeatedly handle each test type
1109         https://bugs.webkit.org/show_bug.cgi?id=142211
1110
1111         Reviewed by Tim Horton and Matt Hanson.
1112
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1114         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1115         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1116         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1117         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1118         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1119         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1120         Removed functions that build a link to test step results. The buildbot provides
1121         these links in JSON.
1122
1123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1124         (BuildbotIteration): Put failing tests into an array, instead of named variables.
1125         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1126         We can easily add them to the map as needed.
1127         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1128         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1129         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1130         and then build a BuildbotTestResults object, which was strange.
1131         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1132
1133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1134         Corrected an unrelated assertion that was buggy, and kept firing.
1135
1136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1137         (BuildbotTestResults):
1138         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1139         (BuildbotTestResults.prototype._parseResults):
1140         (BuildbotTestResults.prototype.addFullLayoutTestResults):
1141         Moved the code for parsing JSON results for a single step here.
1142
1143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1144         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1145         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1146         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1147         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1148         (BuildbotTesterQueueView.prototype.update): Deleted.
1149         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1150         Updated for the new data structures. One behavior change is that we now display individual
1151         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1152         test failures, 3 platform api test failures".
1153
1154 2015-03-03  Matthew Mirman  <mmirman@apple.com>
1155
1156         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1157         https://bugs.webkit.org/show_bug.cgi?id=142094
1158
1159         Reviewed by Csaba Osztrogonác.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1162         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1163         (TestFactory):
1164         (TestFactory.__init__): Made running of JSC tests conditional.
1165         (TestAllButJSCFactory):
1166         (TestJSCFactory): Added.
1167         (TestJSCFactory.__init__):
1168         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1169
1170 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1171
1172         `build-webkit --help` is wrong about how to build for the iOS simulator
1173         <http://webkit.org/b/142223>
1174
1175         Reviewed by Csaba Osztrogonác.
1176
1177         * Scripts/build-webkit: Fix help.
1178
1179 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1180
1181         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1182
1183         * gtk/jhbuild.modules:
1184
1185 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1186
1187         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1188         https://bugs.webkit.org/show_bug.cgi?id=141508
1189
1190         Reviewed by Sergio Villar Senin.
1191
1192         Add a unit test to check that synchronous XHRs load even if the
1193         maximum connection limits are reached.
1194
1195         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1196         (testWebViewSyncRequestOnMaxConns):
1197         (serverCallback):
1198         (beforeAll):
1199         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
1200
1201 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
1202
1203         Update the name of ASan build step.
1204
1205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1206
1207 2015-03-02  Jer Noble  <jer.noble@apple.com>
1208
1209         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1210         https://bugs.webkit.org/show_bug.cgi?id=142121
1211
1212         Reviewed by Simon Fraser.
1213
1214         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
1215         that the initial and final screen rects for the web content are as expected.
1216
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
1219         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
1220         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1221         (runJavaScriptAlert):
1222         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1223         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1224         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
1225         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
1226         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1227         (TestWebKitAPI::TEST_F):
1228
1229 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1230
1231         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
1232
1233         Follow-up fix for:
1234
1235         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1236         <http://webkit.org/b/142145>
1237
1238         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1239         (-[LTRelayController _environmentVariables]): Fix think-o.
1240
1241 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1242
1243         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1244         <http://webkit.org/b/142145>
1245
1246         Reviewed by Simon Fraser.
1247
1248         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1249         (-[LTRelayController _environmentVariables]): Add.
1250         (-[LTRelayController launchApp]): Use -_environmentVariables.
1251
1252 2015-02-28  David Kilzer  <ddkilzer@apple.com>
1253
1254         [iOS] Stop running webkit-build-directory on every layout test
1255
1256         This was originally fixed by David Farler for Bug 135409 in
1257         r172602.
1258
1259         * Scripts/webkitpy/port/ios.py:
1260         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
1261         run webkit-build-directory every time it's called.
1262
1263 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1264
1265         W3C importer should use filesystem instead of shutil/host
1266         https://bugs.webkit.org/show_bug.cgi?id=142012
1267
1268         Reviewed by Bem Jones-Bey.
1269
1270         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
1271
1272         * Scripts/webkitpy/w3c/test_importer.py:
1273         (main):
1274         (TestImporter.do_import):
1275         (TestImporter.find_importable_tests):
1276         (TestImporter.import_tests):
1277         (TestImporter.remove_deleted_files):
1278         (TestImporter.write_import_log):
1279
1280 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1281
1282         W3C test importer should use filesystem to read and write files
1283         https://bugs.webkit.org/show_bug.cgi?id=142084
1284
1285         Reviewed by Bem Jones-Bey.
1286
1287         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
1288
1289         * Scripts/webkitpy/w3c/test_importer.py:
1290         (TestImporter.import_tests):
1291         (TestImporter.remove_deleted_files):
1292         (TestImporter.write_import_log):
1293
1294 2015-02-27  Sam Weinig  <sam@webkit.org>
1295
1296         Add WebKit2 SPI to create a DOM File object
1297         https://bugs.webkit.org/show_bug.cgi?id=142109
1298
1299         Reviewed by Tim Horton.
1300
1301         Add a test for WKBundleFileHandleRef.
1302
1303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1304         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
1305         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1306         (TestWebKitAPI::didFinishLoadForFrame):
1307         (TestWebKitAPI::TEST):
1308         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
1309         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
1310         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
1311
1312 2015-02-27  Michael Saboff  <msaboff@apple.com>
1313
1314         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
1315         https://bugs.webkit.org/show_bug.cgi?id=142112
1316
1317         Reviewed by Filip Pizlo.
1318
1319         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
1320         <someDir> as the library path.
1321
1322         * Scripts/run-jsc-benchmarks:
1323
1324 2015-02-27  Alex Christensen  <achristensen@webkit.org>
1325
1326         [WinCairo] Unreviewed build fix.
1327
1328         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1329         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
1330
1331 2015-02-27  Anders Carlsson  <andersca@apple.com>
1332
1333         Add infrastructure for handling website data in the network process
1334         https://bugs.webkit.org/show_bug.cgi?id=142092
1335
1336         Reviewed by Andreas Kling.
1337
1338         Add a menu item that will fetch all website data, delete the returned data records, and
1339         fetch all website data again so we can confirm that it's all empty.
1340
1341         * MiniBrowser/mac/WK2BrowserWindowController.m:
1342         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1343
1344 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1345
1346         [Win] Remove remaining SafariTheme cruft
1347         https://bugs.webkit.org/show_bug.cgi?id=142075
1348
1349         Reviewed by Anders Carlsson.
1350
1351         Remove reference to SafariTheme-switching preference.
1352
1353         * DumpRenderTree/win/DumpRenderTree.cpp:
1354         (resetWebPreferencesToConsistentValues):
1355         (prepareConsistentTestingEnvironment):
1356
1357 2015-02-26  Doug Russell  <d_russell@apple.com>
1358
1359         AX: Expose caret browsing preference to accessibility API
1360         https://bugs.webkit.org/show_bug.cgi?id=141862
1361
1362         Reviewed by Chris Fleizach.
1363
1364         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
1365         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
1366
1367         * DumpRenderTree/AccessibilityUIElement.cpp:
1368         (setBoolAttributeValueCallback):
1369         (selectedTextMarkerRangeCallback):
1370         (resetSelectedTextMarkerRangeCallback):
1371         (AccessibilityUIElement::setBoolAttributeValue):
1372         (AccessibilityUIElement::selectedTextMarkerRange):
1373         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1374         (AccessibilityUIElement::getJSClass):
1375         * DumpRenderTree/AccessibilityUIElement.h:
1376         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1377         (AccessibilityUIElement::setBoolAttributeValue):
1378         (AccessibilityUIElement::selectedTextMarkerRange):
1379         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1380         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1381         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1382         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1383         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1384         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1385         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1386         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1387         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1388         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1389         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1390
1391 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1392
1393         [Win] Remove WebKitExportGenerator project (and related)
1394         https://bugs.webkit.org/show_bug.cgi?id=142035
1395
1396         Reviewed by Dean Jackson.
1397
1398         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1399         build log from WebKitExportGenerator.
1400
1401 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1402
1403         [EFL] Bump EFL version to 1.13.0
1404         https://bugs.webkit.org/show_bug.cgi?id=141708
1405
1406         Reviewed by Gyuyoung Kim.
1407
1408         * efl/jhbuild.modules:
1409
1410 2015-02-26  Sam Weinig  <sam@webkit.org>
1411
1412         Check in missing WebEditingTester.xcconfig file.
1413
1414         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1415
1416 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1417
1418         [webkitpy] Remove skipped file related crufts
1419         https://bugs.webkit.org/show_bug.cgi?id=142046
1420
1421         Reviewed by Ryosuke Niwa.
1422
1423         * Scripts/webkitpy/port/base.py:
1424         (Port.skipped_layout_tests):
1425         (Port._tests_from_skipped_file_contents): Deleted.
1426         (Port): Deleted.
1427         (Port._expectations_from_skipped_files): Deleted.
1428         * Scripts/webkitpy/port/mac_unittest.py:
1429         (MacTest.test_default_timeout_ms):
1430         (MacTest): Deleted.
1431         (test_tests_from_skipped_file_contents): Deleted.
1432
1433 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1434
1435         [Win] Unreviewed WinCairo build fix after r180653.
1436
1437         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1438
1439         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1440         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1441         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1442         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1443         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1444
1445 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
1446
1447         [Win] Use WEBCORE_EXPORT instead of Definition file
1448         https://bugs.webkit.org/show_bug.cgi?id=141734
1449
1450         Reviewed by Alex Christensen.
1451
1452         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1453         Use a precompiled header so we can define our export macros properly.
1454         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1455         Visual studio automatic update stuff.
1456         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1457         Set up Precompiled Header use for project..
1458         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1459         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1460         declarations for building DumpRenderTree as a client of
1461         WebCore/WebKit.
1462
1463 2015-02-25  Mark Lam  <mark.lam@apple.com>
1464
1465         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1466         <https://webkit.org/b/141672>
1467
1468         Reviewed by Alexey Proskuryakov.
1469
1470         ASan does not like the fact that we memcpy the stack for GC scans.  So,
1471         we're working around this by using our own memcpy (asanUnsafeMemcpy)
1472         implementation that we can tell ASan to ignore.
1473
1474         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1475         which isn't effective for working around this issue. 
1476
1477         * asan/webkit-asan-ignore.txt:
1478
1479 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
1480
1481         CodeBlock crashes when dumping op_push_name_scope
1482         https://bugs.webkit.org/show_bug.cgi?id=141953
1483
1484         Reviewed by Filip Pizlo.
1485
1486         * Scripts/run-jsc-stress-tests:
1487
1488 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1489
1490         W3C test importer should use argparse instead of optparse
1491         https://bugs.webkit.org/show_bug.cgi?id=142013
1492
1493         Reviewed by Bem Jones-Bey.
1494
1495         * Scripts/webkitpy/w3c/test_importer.py:
1496         (main): Updating according argparse.
1497         (parse_args): Moving from optparse to argparse.
1498
1499 2015-02-25  Brady Eidson  <beidson@apple.com>
1500
1501         Get rid of TestInvocation::pathOrURL
1502         https://bugs.webkit.org/show_bug.cgi?id=142021
1503
1504         Reviewed by Tim Horton.
1505
1506         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1507         but most code that uses it expected an absolute path.
1508
1509         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1510
1511         * WebKitTestRunner/TestController.cpp:
1512         (WTR::TestController::updateWebViewSizeForTest):
1513         (WTR::TestController::updateWindowScaleForTest):
1514         (WTR::shouldUseFixedLayout):
1515         (WTR::TestController::updateLayoutTypeForTest):
1516
1517         * WebKitTestRunner/TestInvocation.cpp:
1518         (WTR::TestInvocation::TestInvocation):
1519         (WTR::TestInvocation::urlContains):
1520         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1521         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1522         (WTR::TestInvocation::invoke):
1523         (WTR::shouldLogFrameLoadDelegates): Deleted.
1524         (WTR::shouldLogHistoryClientCallbacks): Deleted.
1525         * WebKitTestRunner/TestInvocation.h:
1526         (WTR::TestInvocation::pathOrURL): Deleted.
1527
1528         * WebKitTestRunner/ios/TestControllerIOS.mm:
1529         (WTR::shouldMakeViewportFlexible):
1530         (WTR::TestController::platformConfigureViewForTest):
1531
1532         * WebKitTestRunner/mac/TestControllerMac.mm:
1533         (WTR::shouldUseThreadedScrolling):
1534         (WTR::TestController::platformConfigureViewForTest):
1535
1536 2015-02-25  Brady Eidson  <beidson@apple.com>
1537
1538         Layout test support for user content filters
1539         https://bugs.webkit.org/show_bug.cgi?id=142018
1540
1541         Reviewed by Tim Horton.
1542
1543         * WebKitTestRunner/TestController.cpp:
1544         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1545
1546         * WebKitTestRunner/mac/TestControllerMac.mm:
1547         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1548           file before loading the test itself.
1549
1550 2015-02-24  Sam Weinig  <sam@webkit.org>
1551
1552         Convert WebEditingTester to use xcconfig files
1553         https://bugs.webkit.org/show_bug.cgi?id=141879
1554
1555         Reviewed by Darin Adler.
1556
1557         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1558
1559         * WebEditingTester/Configurations: Added.
1560         * WebEditingTester/Configurations/Base.xcconfig: Added.
1561         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1562         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1563
1564 2015-02-24  Andy Estes  <aestes@apple.com>
1565
1566         Teach MiniBrowser how to disable per-window web processes
1567         https://bugs.webkit.org/show_bug.cgi?id=141988
1568
1569         Reviewed by Darin Adler.
1570
1571         * MiniBrowser/mac/AppDelegate.m:
1572         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1573         * MiniBrowser/mac/SettingsController.h:
1574         * MiniBrowser/mac/SettingsController.m:
1575         (-[SettingsController _populateMenu]): Added a new Settings menu item.
1576         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1577         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1578         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1579
1580 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
1581
1582         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1583         https://bugs.webkit.org/show_bug.cgi?id=141889
1584
1585         Reviewed by Darin Adler.
1586
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1588
1589 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1590
1591         REGRESSION(r179429): Can't type comments in Facebook
1592         https://bugs.webkit.org/show_bug.cgi?id=141859
1593
1594         Reviewed by Brent Fulgham.
1595
1596         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1597
1598         * DumpRenderTree/mac/DumpRenderTree.mm:
1599         (resetWebPreferencesToConsistentValues):
1600         * DumpRenderTree/win/DumpRenderTree.cpp:
1601         (resetWebPreferencesToConsistentValues):
1602         * WebKitTestRunner/TestController.cpp:
1603         (WTR::TestController::resetPreferencesToConsistentValues):
1604
1605 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1606
1607         Crash loading local file with WebPageProxy::loadAlternateHTMLString
1608         https://bugs.webkit.org/show_bug.cgi?id=141867
1609
1610         Reviewed by Anders Carlsson.
1611
1612         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1613         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1614         be shared with the new test.
1615         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1616         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1617         (testLoadAlternateHTMLForLocalPage):
1618         (beforeAll):
1619
1620 2015-02-24  David Kilzer  <ddkilzer@apple.com>
1621
1622         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1623         <http://webkit.org/b/141900>
1624
1625         Reviewed by Myles C. Maxfield.
1626
1627         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1628         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1629         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1630         - Rename to share code with iOS.
1631         - Add USE(APPKIT) around AppKit-specific headers and code.
1632         - Fix a check-webkit-style warning.
1633         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1634         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1635         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1636         - Remove ios/ActivateFontsIOS.mm.
1637         - Fix InjectedBundle/cocoa group to represent the directory on
1638           disk.  Includes a change to InjectedBundlePageCocoa.mm.
1639
1640 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1641
1642         Unreviewed, rolling out r180547 and r180550.
1643         https://bugs.webkit.org/show_bug.cgi?id=141957
1644
1645         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1646
1647         Reverted changesets:
1648
1649         "REGRESSION(r179429): Can't type comments in Facebook"
1650         https://bugs.webkit.org/show_bug.cgi?id=141859
1651         http://trac.webkit.org/changeset/180547
1652
1653         "Constructor returning null should construct an object instead
1654         of null"
1655         https://bugs.webkit.org/show_bug.cgi?id=141640
1656         http://trac.webkit.org/changeset/180550
1657
1658 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1659
1660         REGRESSION(r179429): Can't type comments in Facebook
1661         https://bugs.webkit.org/show_bug.cgi?id=141859
1662
1663         Reviewed by Geoffrey Garen.
1664
1665         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1666
1667         * DumpRenderTree/mac/DumpRenderTree.mm:
1668         (resetWebPreferencesToConsistentValues):
1669         * WebKitTestRunner/TestController.cpp:
1670         (WTR::TestController::resetPreferencesToConsistentValues):
1671
1672 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
1673
1674         [EFL] fix eo errors
1675         https://bugs.webkit.org/show_bug.cgi?id=141909
1676
1677         Reviewed by Gyuyoung Kim.
1678
1679         Fix eo errors that occur whenever minibrowser is launched.
1680         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1681         - elm_obj_win_resize_object_add's first parameter should be elm_win
1682
1683         * MiniBrowser/efl/main.c:
1684         (window_create):
1685
1686 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1687
1688         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1689
1690         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1691         (TestWebKitAPI::TEST):
1692
1693 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1694
1695         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1696         https://bugs.webkit.org/show_bug.cgi?id=141935
1697
1698         Reviewed by Myles C. Maxfield.
1699
1700         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1701         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1702         tests for assigning from nullptr.
1703
1704 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1705
1706         WTF::WeakPtr should have a 'forget' method.
1707         https://bugs.webkit.org/show_bug.cgi?id=141923
1708
1709         Reviewed by Myles C. Maxfield.
1710
1711         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1712         (TestWebKitAPI::TEST): Added 'Forget' tests case.
1713
1714 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1715
1716         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1717         https://bugs.webkit.org/show_bug.cgi?id=141920
1718
1719         Reviewed by Tim Horton.
1720
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1722         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1723         Do the same thing as we do for regular green bubbles.
1724
1725 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1726
1727         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1728         https://bugs.webkit.org/show_bug.cgi?id=141925
1729
1730         Reviewed by Tim Horton.
1731
1732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1733         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1734
1735 2015-02-23  Anders Carlsson  <andersca@apple.com>
1736
1737         Add API for fetching website data records to _WKWebsiteDataStore
1738         https://bugs.webkit.org/show_bug.cgi?id=141926
1739
1740         Reviewed by Beth Dakin.
1741
1742         * MiniBrowser/mac/MainMenu.xib:
1743         * MiniBrowser/mac/WK2BrowserWindowController.m:
1744         (-[WK2BrowserWindowController fetchWebsiteData:]):
1745         Add menu item to fetch and dump website data.
1746
1747 2015-02-23  David Kilzer  <ddkilzer@apple.com>
1748
1749         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1750         <http://webkit.org/b/141884>
1751
1752         Reviewed by Alexey Proskuryakov.
1753
1754         * Scripts/webkitpy/port/leakdetector.py:
1755         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1756         snowleopard, lion and older leaks.  Add known leak for
1757         mavericks, but check Port.operating_system before calling
1758         Port.is_mavericks.
1759         * Scripts/webkitpy/port/mac.py:
1760         (MacPort.is_snowleopard): Delete.
1761         (MacPort.is_lion): Delete.
1762         (MacPort.is_mavericks): Add.
1763
1764 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1765
1766         build.webkit.org/dashboard should filter out commits to other branches
1767         https://bugs.webkit.org/show_bug.cgi?id=140362
1768
1769         Reviewed by Tim Horton.
1770
1771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1772         (BuildbotQueue):
1773         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1774         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
1775         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1776         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
1777         (BuildbotQueueView.prototype.revisionContentForIteration):
1778         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
1779         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
1780         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
1781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1782         (Trac.prototype.get oldestRecordedRevisionNumber):
1783         (Trac.prototype.commitsOnBranch):
1784         (Trac.prototype._xmlTimelineURL):
1785         (Trac.prototype._convertCommitInfoElementToObject):
1786         (Trac.prototype._update):
1787         (Trac.prototype.startPeriodicUpdates):
1788         (Trac.prototype.loadMoreHistoricalData):
1789         (Trac.prototype.update): Deleted.
1790
1791 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1792
1793         Tests don't work on some bots: Failed to stop wptwk
1794         https://bugs.webkit.org/show_bug.cgi?id=141235
1795
1796         Reviewed by Ryosuke Niwa.
1797
1798         Logging of server subprocesses in launcher script.
1799         Killing of server subprocesses when stopping/before starting.
1800         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
1801
1802         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1803         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
1804         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1805         (WebPlatformTestServer.__init__):
1806         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
1807         (WebPlatformTestServer):
1808         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
1809         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
1810         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1811         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
1812         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
1813         (TestWebPlatformTestServer):
1814         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
1815
1816 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1817
1818         [WebEditingTester] Allow dropping HTML files on the app
1819         https://bugs.webkit.org/show_bug.cgi?id=141834
1820
1821         Reviewed by Simon Fraser.
1822
1823         * WebEditingTester/AppDelegate.m:
1824         (-[WebEditingAppDelegate openDocument:]):
1825         (-[WebEditingAppDelegate application:openFile:]):
1826         Implement application:openFile:, factoring file loading code out of openDocument.
1827
1828         * WebEditingTester/Info.plist:
1829         Register as an editor for HTML files.
1830
1831         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1832         Enrica is not an organization.
1833
1834 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1835
1836         [WebEditingTester] Expand "WK" to "WebKit" in a few places
1837         https://bugs.webkit.org/show_bug.cgi?id=141833
1838
1839         Reviewed by Anders Carlsson.
1840
1841         * WebEditingTester/AppDelegate.h:
1842         * WebEditingTester/AppDelegate.m:
1843         (-[WebEditingAppDelegate newEditor:]):
1844         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
1845         (-[WebEditingAppDelegate validateMenuItem:]):
1846         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1847         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
1848         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1849         (-[WebEditingAppDelegate showOperations:]): Deleted.
1850         * WebEditingTester/MainMenu.xib:
1851         The WK abbreviation is unnaturally grating in menu items for some reason.
1852
1853 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1854
1855         [WebEditingTester] Add a custom protocol for loading canned content
1856         https://bugs.webkit.org/show_bug.cgi?id=141830
1857
1858         Reviewed by Enrica Casucci.
1859
1860         Add a canned:// protocol handler, which can be used to emulate behaviors
1861         in WebKit client apps (like Mail) that use custom protocol handlers,
1862         which can have important effects on editing (mostly, the URLs are only
1863         valid inside of the client application, but not when copied/dragged out).
1864
1865         For now, we only support two canned files:
1866
1867             canned://dice is a PNG of dice (stolen from LayoutTests/)
1868             canned://text is the string "canned text" served as text/html
1869
1870         In the future we could support things like very large (generated) files,
1871         progressive loading, etc. to further simulate conditions in other apps.
1872
1873         * WebEditingTester/AppDelegate.m:
1874         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1875         Register the protocol with CFNetwork, and the scheme with WebKit2.
1876
1877         * WebEditingTester/Canned Content/dice.png: Added.
1878         * WebEditingTester/CannedContent.h: Added.
1879         * WebEditingTester/CannedContent.m: Added.
1880         (-[CannedContent initWithRequest:cachedResponse:client:]):
1881         (+[CannedContent canonicalRequestForRequest:]):
1882         (+[CannedContent canInitWithRequest:]):
1883         We only want to handle canned:// URLs.
1884
1885         (-[CannedContent startLoading]):
1886         For now, immediately load the two files we know about.
1887         Otherwise, immediately fail the load.
1888
1889         (-[CannedContent stopLoading]):
1890         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1891
1892 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1893
1894         [WebEditingTester] Implement an open panel
1895         https://bugs.webkit.org/show_bug.cgi?id=141829
1896
1897         Reviewed by Simon Fraser.
1898
1899         * WebEditingTester/AppDelegate.m:
1900         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
1901         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
1902         (-[WebEditingAppDelegate openDocument:]):
1903         Add an open panel (with radio buttons to pick which WebKit to open with).
1904         Loads the file as an HTML string.
1905
1906 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
1907
1908         [WebEditingTester] @properties, dot syntax, and remember the window position
1909         https://bugs.webkit.org/show_bug.cgi?id=141843
1910
1911         Reviewed by Tim Horton.
1912         
1913         Modernize a bit with more dot syntax, use @property for the web views,
1914         and give the main window an Autosave name so it remembers the widow position.
1915
1916         * WebEditingTester/WK1WebDocumentController.m:
1917         (-[WK1WebDocumentController awakeFromNib]):
1918         (-[WK1WebDocumentController loadHTMLString:]):
1919         * WebEditingTester/WK2WebDocumentController.m:
1920         (-[WK2WebDocumentController awakeFromNib]):
1921         * WebEditingTester/WebDocument.xib:
1922
1923 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1924
1925         [WebEditingTester] Hook up key equivalents for new window action
1926         https://bugs.webkit.org/show_bug.cgi?id=141828
1927
1928         Reviewed by Enrica Casucci.
1929
1930         * WebEditingTester/AppDelegate.h:
1931         * WebEditingTester/AppDelegate.m:
1932         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1933         (-[WebEditingAppDelegate newEditor:]):
1934         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
1935         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1936         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1937         (defaultConfiguration): Deleted.
1938         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1939         Move WKWebViewConfiguration setup into WK2WebDocumentController.
1940         Remove unused application termination code.
1941         Update new-window menu item key equivalents when launching and when
1942         changing the use-WebKit2-by-default setting.
1943         Make WebDocumentController subclasses all initialized the same way,
1944         and use that to factor out alloc/init.
1945         Rename loadContent to loadHTMLString for future use.
1946
1947         * WebEditingTester/MainMenu.xib:
1948         Add default key equivalents.
1949         Cmd-N will always make the default kind of window (controlled by the pref).
1950         Cmd-Opt-N will always make the other kind.
1951         The menu items are configured as alternates so they only show up if you
1952         press alt (just like in MiniBrowser).
1953
1954         * WebEditingTester/WK1WebDocumentController.m:
1955         (-[WK1WebDocumentController loadHTMLString:]):
1956         (-[WK1WebDocumentController loadContent]): Deleted.
1957         * WebEditingTester/WK2WebDocumentController.h:
1958         * WebEditingTester/WK2WebDocumentController.m:
1959         (defaultConfiguration):
1960         (-[WK2WebDocumentController awakeFromNib]):
1961         (-[WK2WebDocumentController loadHTMLString:]):
1962         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
1963         (-[WK2WebDocumentController dealloc]): Deleted.
1964         * WebEditingTester/WebDocumentController.h:
1965         * WebEditingTester/WebDocumentController.m:
1966         (-[WebDocumentController init]):
1967         (-[WebDocumentController initWithWindow:]):
1968         (+[WebDocumentController defaultEditingSource]):
1969         (-[WebDocumentController loadHTMLString:]):
1970         (-[WebDocumentController windowDidLoad]): Deleted.
1971         (-[WebDocumentController defaultEditingSource]): Deleted.
1972         (-[WebDocumentController applicationTerminating]): Deleted.
1973         (-[WebDocumentController loadContent]): Deleted.
1974
1975 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1976
1977         [WebEditingTester] ARC-ify WebEditingTester
1978         https://bugs.webkit.org/show_bug.cgi?id=141827
1979
1980         Reviewed by Sam Weinig.
1981
1982         * WebEditingTester/AppDelegate.m:
1983         (-[WebEditingAppDelegate showOperations:]):
1984         * WebEditingTester/EditingOperations.m:
1985         (editingOperations):
1986         * WebEditingTester/WK1WebDocumentController.m:
1987         (-[WK1WebDocumentController dealloc]): Deleted.
1988         * WebEditingTester/WK2WebDocumentController.m:
1989         (-[WK2WebDocumentController dealloc]): Deleted.
1990         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1991         Turn on ARC and remove a few retain/release/autorelease calls.
1992         We don't need to implement dealloc in either document controller
1993         because WebView and WKWebView's UIDelegate property does not hold a
1994         strong reference.
1995
1996 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1997
1998         [WebEditingTester] Factor out list of editing operations
1999         https://bugs.webkit.org/show_bug.cgi?id=141826
2000
2001         Reviewed by Sam Weinig.
2002
2003         * WebEditingTester/AppDelegate.m:
2004         (-[WebEditingAppDelegate showOperations:]):
2005         * WebEditingTester/EditingOperations.h: Added.
2006         * WebEditingTester/EditingOperations.m: Added.
2007         (editingOperations):
2008         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2009         Move EditingOperations array to its own file, and make it an NSArray
2010         instead of a C array. Adjust accordingly in showOperations:.
2011
2012 2015-02-20  Michael Saboff  <msaboff@apple.com>
2013
2014         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2015         https://bugs.webkit.org/show_bug.cgi?id=141676
2016
2017         Reviewed by Filip Pizlo.
2018
2019         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
2020         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
2021         large string expression that we want to eval.
2022
2023         * Scripts/run-jsc-stress-tests:
2024
2025 2015-02-19  Daniel Bates  <dabates@apple.com>
2026
2027         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2028         https://bugs.webkit.org/show_bug.cgi?id=141815
2029         <rdar://problem/19893933>
2030
2031         Reviewed by Simon Fraser.
2032
2033         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2034         was booted by iOS Simulator in a previous run of run-webkit-test.
2035
2036         * Scripts/webkitpy/port/ios.py:
2037         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2038         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2039         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2040
2041 2015-02-19  David Kilzer  <ddkilzer@apple.com>
2042
2043         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2044         <http://webkit.org/b/141799>
2045
2046         Reviewed by Alex Christensen.
2047
2048         * Scripts/webkitpy/style/checkers/cpp.py:
2049         (_IncludeState.check_next_include_order): Don't emit a warning
2050         if the primary header exists and the source file name ends with
2051         "SoftLink.cpp".  Add 'filename' argument to method.
2052         (check_include_line): Pass in 'filename'.
2053
2054         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2055         (OrderOfIncludesTest.test_check_next_include_order__no_config):
2056         (OrderOfIncludesTest.test_check_next_include_order__no_self):
2057         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2058         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2059         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2060         - Add test filename arguments for calls to
2061           check_next_include_order().
2062         (OrderOfIncludesTest.test_primary_header): Add test for a file
2063         name ending in "SoftLink.cpp".
2064
2065 2015-02-18  Enrica Casucci  <enrica@apple.com>
2066
2067         Add new tool to test editable Webviews.
2068         https://bugs.webkit.org/show_bug.cgi?id=141772
2069
2070         Reviewed by Tim Horton.
2071
2072         Adding WebEditingTester, a Cocoa application to
2073         test WK1 and Wk2 views in editable mode.
2074
2075         * WebEditingTester: Added.
2076         * WebEditingTester/AppDelegate.h: Added.
2077         * WebEditingTester/AppDelegate.m: Added.
2078         (-[WebEditingAppDelegate init]):
2079         (defaultConfiguration):
2080         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2081         (-[WebEditingAppDelegate applicationWillTerminate:]):
2082         (-[WebEditingAppDelegate newEditor:]):
2083         (-[WebEditingAppDelegate showOperations:]):
2084         (-[WebEditingAppDelegate useWebKit2ByDefault]):
2085         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2086         (-[WebEditingAppDelegate validateMenuItem:]):
2087         * WebEditingTester/Info.plist: Added.
2088         * WebEditingTester/MainMenu.xib: Added.
2089         * WebEditingTester/WK1WebDocumentController.h: Added.
2090         * WebEditingTester/WK1WebDocumentController.m: Added.
2091         (-[WK1WebDocumentController awakeFromNib]):
2092         (-[WK1WebDocumentController loadContent]):
2093         (-[WK1WebDocumentController dealloc]):
2094         (-[WK1WebDocumentController pasteAsMarkup:]):
2095         * WebEditingTester/WK2WebDocumentController.h: Added.
2096         * WebEditingTester/WK2WebDocumentController.m: Added.
2097         (-[WK2WebDocumentController initWithConfiguration:]):
2098         (-[WK2WebDocumentController pasteAsMarkup:]):
2099         (-[WK2WebDocumentController awakeFromNib]):
2100         (-[WK2WebDocumentController dealloc]):
2101         (-[WK2WebDocumentController loadContent]):
2102         * WebEditingTester/WebDocument.xib: Added.
2103         * WebEditingTester/WebDocumentController.h: Added.
2104         * WebEditingTester/WebDocumentController.m: Added.
2105         (-[WebDocumentController initWithWindow:]):
2106         (-[WebDocumentController windowDidLoad]):
2107         (-[WebDocumentController defaultEditingSource]):
2108         (-[WebDocumentController applicationTerminating]):
2109         (-[WebDocumentController loadContent]):
2110         * WebEditingTester/WebEditingTester.xcodeproj: Added.
2111         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2112         * WebEditingTester/main.m: Added.
2113         (main):
2114
2115 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
2116
2117         Run JSC tests on ARM EFL bots
2118         https://bugs.webkit.org/show_bug.cgi?id=141165
2119
2120         Reviewed by Alexey Proskuryakov.
2121
2122         * BuildSlaveSupport/build.webkit.org-config/config.json:
2123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2124         (RunJavaScriptCoreTests.countFailures):
2125         (RunRemoteJavaScriptCoreTests):
2126         (RunRemoteJavaScriptCoreTests.start):
2127         (BuildAndRemoteJSCTestsFactory):
2128         (BuildAndRemoteJSCTestsFactory.__init__):
2129
2130 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
2131
2132         Streamline unexported function build fixes
2133         https://bugs.webkit.org/show_bug.cgi?id=141761
2134
2135         Reviewed by Alex Christensen.
2136
2137         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2138         We don't need to ignore symbols that are not exported due to the .unexp file.
2139
2140 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
2141
2142         Remove more references to WebCore.exp.in
2143         https://bugs.webkit.org/show_bug.cgi?id=141747
2144
2145         Reviewed by Alexey Proskuryakov.
2146
2147         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2148         (ShouldBuildTest):
2149
2150 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
2151
2152         Windows test results should not fall back to mac-mountainlion after r180176
2153         https://bugs.webkit.org/show_bug.cgi?id=141719
2154
2155         Reviewed by Brent Fulgham.
2156
2157         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2158         (_should_file_trigger_build):
2159         * Scripts/webkitpy/port/win.py:
2160         (WinPort.default_baseline_search_path):
2161         * Scripts/webkitpy/port/win_unittest.py:
2162         (WinPortTest.test_baseline_search_path):
2163
2164 2015-02-17  Daniel Bates  <dabates@apple.com>
2165
2166         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2167         https://bugs.webkit.org/show_bug.cgi?id=141718
2168
2169         Reviewed by Alex Christensen.
2170
2171         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2172
2173         * Scripts/webkitpy/port/ios.py:
2174         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2175         Log a error and return False if we are unable to boot the simulator device so that the caller can take
2176         appropriate action, say exit(3) before running any layout tests.
2177         * Scripts/webkitpy/xcode/simulator.py:
2178         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2179         with the specified UDID.
2180         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2181         with the specified UDID can successfully boot and shut down. We make at most two attempts to
2182         boot and shut down the device, erasing the device between tries so as to restore the device
2183         to a known good state.
2184
2185 2015-02-17  Daniel Bates  <dabates@apple.com>
2186
2187         run_webkit_tests.py should not know about iOS Simulator details
2188         https://bugs.webkit.org/show_bug.cgi?id=141711
2189
2190         Reviewed by Alex Christensen.
2191
2192         Run_webkit_tests.py should only parse the iOS-specific command
2193         line options --runtime and --device-type. Let the port-specific
2194         logic in ios.py validate the parsed options and instantiate
2195         internal data structures.
2196
2197         Currently run_webkit_tests.py parses the iOS-specific command
2198         line options --runtime and --device-type, validates them, and
2199         instantiates internal data structures from the parsed strings.
2200         Instead the validation logic and instantiation of internal
2201         data structures should be handled by the iOS port object.
2202
2203         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2204         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
2205         and instantiate internal data structures for them.
2206         * Scripts/webkitpy/port/driver.py:
2207         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
2208         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
2209         respectively.
2210         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
2211         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
2212         object from --runtime, if specified. Otherwise, instantiates a Runtime
2213         object for the latest installed iphonesimulator SDK version.
2214         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
2215         object from --device-type, if specified. Otherwise, instantiates
2216         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
2217         machine, respectively.
2218         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
2219         runtime is available to use.
2220         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
2221         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
2222         * Scripts/webkitpy/xcode/simulator.py:
2223         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
2224         with a runtime identifier for the specified iOS version.
2225
2226 2015-02-17  Dana Burkart  <dburkart@apple.com>
2227
2228         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
2229         https://bugs.webkit.org/show_bug.cgi?id=141672
2230
2231         Reviewed by David Kilzer.
2232
2233         * asan/webkit-asan-ignore.txt:
2234
2235 2015-02-17  Alex Christensen  <achristensen@webkit.org>
2236
2237         Remove WebCore.exp.in and clean up.
2238         https://bugs.webkit.org/show_bug.cgi?id=141491
2239
2240         Reviewed by Andreas Kling.
2241
2242         * Scripts/sort-export-file: Removed.
2243         * Scripts/webkitpy/style/checker.py:
2244         (_all_categories):
2245         (FileType):
2246         (CheckerDispatcher._file_type):
2247         (CheckerDispatcher._create_checker):
2248         Don't check if the export files are sorted.
2249         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
2250         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
2251
2252 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2253
2254         Unreviewed. Fix GTK+ make distcheck.
2255
2256         Do not exclude bmalloc directory from the tarball.
2257
2258         * gtk/manifest.txt.in:
2259
2260 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2261
2262         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
2263
2264         I forgot to add the return of a bool function.
2265
2266         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2267         (WebKitDOMNodeTest::testDOMCache):
2268
2269 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2270
2271         [GTK] GObject DOM bindings object are cached forever
2272         https://bugs.webkit.org/show_bug.cgi?id=141558
2273
2274         Reviewed by Sergio Villar Senin.
2275
2276         Add checks for all DOM objects to ensure they are not leaked. Also
2277         add a dedicated test for the DOM Object Cache.
2278
2279         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2280         (WebKitDOMNodeFilterTest::testTreeWalker):
2281         (WebKitDOMNodeFilterTest::testNodeIterator):
2282         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2283         (WebKitDOMNodeTest::testHierarchyNavigation):
2284         (WebKitDOMNodeTest::testInsertion):
2285         (WebKitDOMNodeTest::testTagNames):
2286         (WebKitDOMNodeTest::testDOMCache):
2287         (registerTests):
2288         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2289         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2290         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2291         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2292         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2293         (testWebKitDOMObjectCache):
2294         (beforeAll):
2295         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2296         (documentLoadedCallback):
2297
2298 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2299
2300         [GTK] WebKitFrame objects are never released
2301         https://bugs.webkit.org/show_bug.cgi?id=141641
2302
2303         Reviewed by Martin Robinson.
2304
2305         Add a way to check GObjects leaks for WebProcess tests and check
2306         WebKitFrame objects are not leaked.
2307
2308         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2309         (WebKitFrameTest::testMainFrame):
2310         (WebKitFrameTest::testURI):
2311         (WebKitFrameTest::testJavaScriptContext):
2312         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2313         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
2314         (runTest):
2315         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2316
2317 2015-02-16  Tim Horton  <timothy_horton@apple.com>
2318
2319         Fix the MiniBrowser build with newer clang
2320
2321         * MiniBrowser/mac/SettingsController.m:
2322         (-[SettingsController _toggleBooleanDefault:]):
2323         * MiniBrowser/mac/WK1BrowserWindowController.m:
2324         (-[WK1BrowserWindowController windowWillClose:]):
2325         * MiniBrowser/mac/WK2BrowserWindowController.m:
2326         (-[WK2BrowserWindowController windowWillClose:]):
2327         NSApp is id and clang gets confused about which -delegate we're talking about.
2328
2329 2015-02-16  Antti Koivisto  <antti@apple.com>
2330
2331         Develop/Disable Caches does not properly disable disk cache
2332         https://bugs.webkit.org/show_bug.cgi?id=141636
2333
2334         Reviewed by Anders Carlsson.
2335
2336         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
2337         the network process too.
2338
2339         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
2340
2341         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2342         (WTR::InjectedBundle::beginTesting):
2343         (WTR::InjectedBundle::setCacheModel):
2344         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2345         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2346
2347             Forward to TestController.
2348
2349         (WTR::TestRunner::setCacheModel):
2350         * WebKitTestRunner/TestInvocation.cpp:
2351         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2352
2353 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
2354
2355         Unreviewed. Add myself as a committer.
2356
2357         * Scripts/webkitpy/common/config/contributors.json:
2358
2359 2015-02-15  David Kilzer  <ddkilzer@apple.com>
2360
2361         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
2362         <http://webkit.org/b/141607>
2363
2364         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
2365         externals in Source/WebCore/Configurations/WebCore.unexp when
2366         building with Xcode 5.x.
2367         (readXcode5SymbolsToIgnore): Add.
2368
2369 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
2370
2371         [EFL] fix Evas GL engine error.
2372         https://bugs.webkit.org/show_bug.cgi?id=141621
2373
2374         Reviewed by Gyuyoung Kim.
2375
2376         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2377
2378         * MiniBrowser/efl/main.c:
2379         (elm_main):
2380
2381 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
2382
2383         [buildbot] Enable run-api-tests on release Mac bots
2384         https://bugs.webkit.org/show_bug.cgi?id=141518
2385
2386         Reviewed by Darin Adler.
2387
2388         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2389         (RunUnitTests):
2390         (BuildFactory.__init__):
2391         (TestFactory.__init__):
2392         (BuildAndTestFactory.__init__):
2393         (RunUnitTests.start): Deleted.
2394         (unitTestsSupported): Deleted.
2395
2396 2015-02-13  Anders Carlsson  <andersca@apple.com>
2397
2398         Add a move constructor and move assignment operator to Deque
2399         https://bugs.webkit.org/show_bug.cgi?id=141571
2400
2401         Reviewed by Andreas Kling.
2402
2403         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2404         (TestWebKitAPI::TEST):
2405
2406 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2407
2408         run-jsc-stress-tests --remote should skip profiler tests
2409         https://bugs.webkit.org/show_bug.cgi?id=141470
2410
2411         Reviewed by Filip Pizlo.
2412
2413         * Scripts/run-jsc-stress-tests:
2414
2415 2015-02-13  Anders Carlsson  <andersca@apple.com>
2416
2417         Add an initializer list constructor to Deque
2418         https://bugs.webkit.org/show_bug.cgi?id=141565
2419
2420         Reviewed by Andreas Kling.
2421
2422         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2423         (TestWebKitAPI::TEST):
2424
2425 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2426
2427         [buildbot] Remove buildJSCTool cruft from master.cfg
2428         https://bugs.webkit.org/show_bug.cgi?id=141513
2429
2430         Reviewed by Alexey Proskuryakov.
2431
2432         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2433         (RunJavaScriptCoreTests):
2434         (RunJavaScriptCoreTests.start):
2435         (RunWebKitTests):
2436         (RunWebKitTests.start):
2437         (TestFactory.__init__):
2438         (TestLeaksFactory.__init__):
2439         (RunJavaScriptCoreTests.__init__): Deleted.
2440         (RunWebKitTests.__init__): Deleted.
2441
2442 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2443
2444         Unreviewed, remove empty directories.
2445
2446         * DumpRenderTree/gtk: Removed.
2447         * DumpRenderTree/gtk/fonts: Removed.
2448         * DumpRenderTree/unix: Removed.
2449         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2450         * GtkLauncher: Removed.
2451         * TestWebKitAPI/Tests/WebKitGtk: Removed.
2452         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2453         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2454         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2455
2456 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2457
2458         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2459         https://bugs.webkit.org/show_bug.cgi?id=141519
2460
2461         Reviewed by Alexey Proskuryakov.
2462
2463         * Scripts/build-webkittestrunner:
2464
2465 2015-02-12  Alex Christensen  <achristensen@webkit.org>
2466
2467         Removed empty directory.
2468
2469         * WinCELauncher: Removed.
2470
2471 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2472
2473         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2474         https://bugs.webkit.org/show_bug.cgi?id=141202
2475
2476         Reviewed by Darin Adler.
2477
2478         * Scripts/run-jsc-stress-tests:
2479
2480 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
2481
2482         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2483         https://bugs.webkit.org/show_bug.cgi?id=141517
2484
2485         Reviewed by Anders Carlsson.
2486
2487         We do not need to locate or use the DLL's that came with Safari, so stop
2488         failing when we cannot find them. Also remove some old Qt cruft from this
2489         script.
2490
2491         * BuildSlaveSupport/built-product-archive:
2492         (archiveBuiltProduct): 
2493         (extractBuiltProduct):
2494
2495 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
2496
2497         [Win] [64-bit] Work around MSVC2013 Runtime Bug
2498         https://bugs.webkit.org/show_bug.cgi?id=141498
2499         <rdar://problem/19803642>
2500
2501         Reviewed by Anders Carlsson.
2502
2503         Disable FMA3 instruction use in the MSVC math library to
2504         work around a VS2013 runtime crash. We can remove this
2505         workaround when we switch to VS2015.
2506
2507         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2508         disable FMA3 support.
2509         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2510         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2511         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2512         * Scripts/webkitperl/httpd.pm: Ditto.
2513         * TestWebKitAPI/win/main.cpp: Ditto.
2514         * WinLauncher/Common.cpp: Ditto.
2515         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2516
2517 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2518
2519         run-jsc-stress-tests should accept remote host config from JSON file
2520         https://bugs.webkit.org/show_bug.cgi?id=141509
2521
2522         Reviewed by Michael Saboff.
2523
2524         * Scripts/run-javascriptcore-tests:
2525         (runJSCStressTests):
2526         * Scripts/run-jsc-stress-tests:
2527
2528 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2529
2530         [GTK] Add API to allow overriding the default color chooser implementation
2531         https://bugs.webkit.org/show_bug.cgi?id=98935
2532
2533         Reviewed by Gustavo Noronha Silva.
2534
2535         Add a color chooser implementation for MiniBrowser using
2536         GtkPopover when the GTK+ version is recent enough.
2537         And a test case to check the new color chooser API.
2538
2539         * MiniBrowser/gtk/BrowserWindow.c:
2540         (colorChooserRGBAChanged):
2541         (popoverColorClosed):
2542         (colorChooserRequestFinished):
2543         (runColorChooserCallback):
2544         (browserWindowConstructed):
2545         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2546         (testWebViewColorChooserRequest):
2547         (beforeAll):
2548
2549 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2550
2551         Make run-jsc-stress-tests --remote work with make-based runner
2552         https://bugs.webkit.org/show_bug.cgi?id=141079
2553
2554         Reviewed by Darin Adler.
2555
2556         * Scripts/run-javascriptcore-tests:
2557         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2558         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2559         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2560         to avoid code duplication.
2561
2562 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2563
2564         run-jsc-stress tests should detect the number of processors on the remote machine too
2565         https://bugs.webkit.org/show_bug.cgi?id=141196
2566
2567         Reviewed by Darin Adler.
2568
2569         * Scripts/run-javascriptcore-tests:
2570         (runJSCStressTests): Pass through the --child-processes argument.
2571         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2572         to detect the number of local and remote processors with the same algorithm.
2573         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2574         same as $numProcessors.
2575
2576 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2577
2578         run-jsc-stress-tests should pass JSC_timeout to remote hosts
2579         https://bugs.webkit.org/show_bug.cgi?id=141164
2580
2581         Reviewed by Darin Adler.
2582
2583         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2584
2585         * Scripts/run-jsc-stress-tests:
2586
2587 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2588
2589         [GTK] Add default color chooser implementation using GtkColorChooserDialog
2590         https://bugs.webkit.org/show_bug.cgi?id=141392
2591
2592         Reviewed by Gustavo Noronha Silva.
2593
2594         Enable INPUT_TYPE_COLOR by default for GTK+ port.
2595
2596         * Scripts/webkitperl/FeatureList.pm:
2597
2598 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2599
2600         run-jsc-stress-tests shell test runner should run tests in fixed order
2601         https://bugs.webkit.org/show_bug.cgi?id=141383
2602
2603         Reviewed by Darin Adler.
2604
2605         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2606
2607 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
2608
2609         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2610         https://bugs.webkit.org/show_bug.cgi?id=140485
2611
2612         Reviewed by Anders Carlsson.
2613
2614         Implement takeFocus() as a way to set focus through accessibility wrappers.
2615
2616         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2617         (AccessibilityUIElement::takeFocus):
2618         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2619         (WTR::AccessibilityUIElement::takeFocus):
2620
2621 2015-02-08  Darin Adler  <darin@apple.com>
2622
2623         Remove the SVG instance tree
2624         https://bugs.webkit.org/show_bug.cgi?id=140602
2625
2626         Reviewed by Dean Jackson.
2627
2628         * Scripts/check-for-global-initializers: Removed special case for
2629         SVGElementInstance.o.
2630
2631 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2632
2633         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2634         <http://webkit.org/b/141365>
2635
2636         Reviewed by Daniel Bates.
2637
2638         * Scripts/webkitpy/xcode/simulator.py:
2639         (Simulator): Add unavailable_version_re precompiled regex.
2640         (Simulator._parse_devices): Check for unavailable versions and
2641         ignore them if found when parsing the output of
2642         `xcrun simctl list`.
2643         * Scripts/webkitpy/xcode/simulator_unittest.py:
2644         (test_unavailable_devices): Add test with output from
2645         `xcrun simctl list` with unavailable runtimes that fails before
2646         the fix.
2647
2648 2015-02-07  Chris Dumez  <cdumez@apple.com>
2649
2650         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2651         https://bugs.webkit.org/show_bug.cgi?id=141321
2652
2653         Reviewed by Darin Adler.
2654
2655         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2656
2657 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2658
2659         [iOS] Make Simulator class testable
2660         <http://webkit.org/b/141358>
2661
2662         Rubber-stamped by Darin Adler.
2663
2664         * Scripts/webkitpy/common/system/platforminfo.py:
2665         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2666         command to here from Simulator.refresh() in xcode/simulator.py
2667         so that the output of the command can be mocked.
2668
2669         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2670         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2671         to None.
2672         (MockPlatformInfo.xcode_simctl_list): Add method that returns
2673         self.expected_xcode_simctl_list expectation.
2674
2675         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2676         and license header.
2677         (Simulator.__init__): Add optional 'host' parameter to make it
2678         possible to pass in a mock object for testing.  Set self._host
2679         to 'host' parameter or create Host() object.
2680         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2681         method.
2682
2683         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2684         for current code.
2685         (SimulatorTest):
2686         (SimulatorTest.setUp):
2687         (SimulatorTest._set_expected_xcrun_simctl_list):
2688         (SimulatorTest.test_simulator_device_types):
2689         (test_invalid_device_types_header):
2690         (test_invalid_runtimes_header):
2691         (test_invalid_devices_header):
2692
2693 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
2694
2695         run-jsc-stress-tests --remote should use the default ssh port
2696         https://bugs.webkit.org/show_bug.cgi?id=141287
2697
2698         Reviewed by Darin Adler.
2699
2700         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2701
2702 2015-02-06  Dana Burkart  <dburkart@apple.com>
2703
2704         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2705         https://bugs.webkit.org/show_bug.cgi?id=141349
2706
2707         Reviewed by Alexey Proskuryakov.
2708
2709         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2710         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2711         (BuildbotTesterQueueView.prototype.update):
2712
2713 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
2714
2715         Report network process crashes during layout tests
2716         https://bugs.webkit.org/show_bug.cgi?id=139646
2717
2718         Reviewed by Anders Carlsson.
2719
2720         * WebKitTestRunner/TestController.cpp:
2721         (WTR::TestController::initialize):
2722         (WTR::TestController::networkProcessName):
2723         (WTR::TestController::networkProcessDidCrash):
2724         * WebKitTestRunner/TestController.h:
2725
2726 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2727
2728         run-jsc-stress-tests --remote should create remote directory before copying the bundle
2729         https://bugs.webkit.org/show_bug.cgi?id=141329
2730
2731         Reviewed by Michael Saboff.
2732
2733         * Scripts/run-jsc-stress-tests:
2734
2735 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2736
2737         [GTK] Remove WebKitWebView::close-notification signal
2738         https://bugs.webkit.org/show_bug.cgi?id=141330
2739
2740         Reviewed by Gustavo Noronha Silva.
2741
2742         Update notifications unit tests according to the API changes, and
2743         add a test case to check that onclose event is fired when a
2744         notification is closed by the user.
2745
2746         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2747         (testWebViewNotification):
2748
2749 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2750
2751         Dashboard doesn't consider building ASan a productive step
2752         https://bugs.webkit.org/show_bug.cgi?id=141312
2753
2754         Reviewed by Simon Fraser.
2755
2756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2757
2758 2015-02-05  Daniel Bates  <dabates@apple.com>
2759
2760         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2761         https://bugs.webkit.org/show_bug.cgi?id=141306
2762
2763         Reviewed by Alexey Proskuryakov.
2764
2765         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
2766         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
2767         existent runtime.
2768
2769         * Scripts/webkitpy/xcode/simulator.py:
2770         (Runtime.from_identifier):
2771
2772 2015-02-05  Daniel Bates  <dabates@apple.com>
2773
2774         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
2775         https://bugs.webkit.org/show_bug.cgi?id=139746
2776         <rdar://problem/19283658>
2777
2778         Reviewed by Alexey Proskuryakov.
2779
2780         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
2781         if the simulator device is not in state Booted.
2782
2783         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
2784         launching/relaunching the iOS Simulator app and a simulator app can only be installed
2785         on a device that is in the Booted state. LayoutTestRelay may run before the
2786         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
2787         We should defer executing LayoutTestRelay until the simulator device booted by
2788         iOS Simulator is in the Booted state.
2789
2790         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
2791         Simulator methods with the module name, simulator.
2792         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
2793         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
2794         before launching iOS Simulator to boot it.
2795         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
2796         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
2797         * Scripts/webkitpy/xcode/simulator.py:
2798         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
2799         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
2800         interested in the state of the device are more likely interested in the current state of the device as
2801         opposed to the state of the device when the Device object was created.
2802         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
2803         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
2804         from both this function and Simulator.device_state().
2805         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
2806         (Simulator.DeviceState): Added; class of constants.
2807         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
2808         device is in the specified state.
2809         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
2810         (Simulator.device_directory): Added.
2811         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
2812
2813 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2814
2815         Disable retries on Mac debug testers
2816         https://bugs.webkit.org/show_bug.cgi?id=141296
2817
2818         Reviewed by Simon Fraser.
2819
2820         * BuildSlaveSupport/build.webkit.org-config/config.json:
2821
2822 2015-02-05  Dan Bernstein  <mitz@apple.com>
2823
2824         Need a way to force $xcodeSDK in webkitdirs.pm
2825         https://bugs.webkit.org/show_bug.cgi?id=141291
2826
2827         Reviewed by Anders Carlsson.
2828
2829         * Scripts/webkitdirs.pm:
2830         (setXcodeSDK): Added.
2831
2832 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
2833
2834         [Streams API] Implement a barebone ReadableStream interface
2835         https://bugs.webkit.org/show_bug.cgi?id=141045
2836
2837         Reviewed by Benjamin Poulain.
2838
2839         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
2840
2841 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
2842
2843         filter-build-webkit: reduce more unfiltered output
2844         https://bugs.webkit.org/show_bug.cgi?id=141282
2845
2846         Reviewed by Daniel Bates.
2847
2848         * Scripts/filter-build-webkit:
2849         Report CompileDTraceScript and Preprocess lines as successful.
2850
2851 2015-02-04  Dana Burkart  <dburkart@apple.com>
2852
2853         Botwatcher's Dashboard is cramped
2854         https://bugs.webkit.org/show_bug.cgi?id=140273
2855
2856         Reviewed by Alexey Proskuryakov.
2857
2858         Add a heading key which will allow for arbitrary headings in builder queues.
2859
2860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2861         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2862         (BuildbotBuilderQueueView.prototype.update):
2863         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
2864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2865         (BuildbotIteration.prototype._parseData):
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2867         (BuildbotLeaksQueueView.prototype.update):
2868         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
2869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2870         (BuildbotPerformanceQueueView.prototype.update):
2871         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
2872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2873         (BuildbotQueue):
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2875         (BuildbotQueueView.prototype._unauthorizedAccess):
2876         (BuildbotQueueView.prototype._appendBuild):
2877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2878         (BuildbotTestResults):
2879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2880         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2881         (BuildbotTesterQueueView.prototype.update):
2882         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
2883
2884 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2885
2886         WKTR should not use -mainScreen to pick a color profile
2887         https://bugs.webkit.org/show_bug.cgi?id=141265
2888
2889         Reviewed by Tim Horton.
2890         
2891         -[NSScreen mainScreen] depends on the active window, so use the first screen
2892         (which is the one we put the window on anyway).
2893         
2894         Do some cleanup in DRT that makes the code look similar.
2895
2896         * DumpRenderTree/mac/DumpRenderTree.mm:
2897         (createWebViewAndOffscreenWindow):
2898         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2899         (WTR::PlatformWebView::PlatformWebView):
2900
2901 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2902
2903         LayoutTestHelper should set the color profile of all displays
2904         https://bugs.webkit.org/show_bug.cgi?id=141260
2905
2906         Reviewed by Tim Horton.
2907         
2908         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
2909         which is the screen with the active window. Make things more robust by changing
2910         the colorspace of all displays, not just the main screen, when running layout tests.
2911
2912         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
2913         * DumpRenderTree/mac/LayoutTestHelper.m: 
2914         (originalColorProfileURLs):
2915         (colorProfileURLForDisplay):
2916         (displayUUIDStrings):
2917         (saveDisplayColorProfiles):
2918         (setDisplayColorProfile):
2919         (restoreDisplayColorProfiles):
2920         (installLayoutTestColorProfile):
2921         (restoreUserColorProfile):
2922         (main):        
2923         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
2924         toll-free bridged, sadly). Use the map to restore all profiles on exit.
2925         Convert to use more Obj-C types.
2926
2927 2015-02-04  Daniel Bates  <dabates@apple.com>
2928
2929         test-webkitpy fails on Mac without iphoneos SDK
2930         https://bugs.webkit.org/show_bug.cgi?id=141255
2931         <rdar://problem/19619691>
2932
2933         I inadvertently committed the wrong exception message. Fix up the exception message
2934         to instruct a person to install the iOS SDK when it cannot be found.
2935
2936         * Scripts/webkitpy/port/ios.py:
2937         (IOSPort.determine_full_port_name):
2938
2939 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2940
2941         W3C test importer should sort the list of files when generating the w3c-import.log
2942         https://bugs.webkit.org/show_bug.cgi?id=141156
2943
2944         Reviewed by Bem Jones-Bey.
2945
2946         Sort explicitly the list of imported files written in the w3c-import.log.
2947         Removed logging of the import date.
2948
2949         * Scripts/webkitpy/w3c/test_importer.py:
2950         (TestImporter.write_import_log):
2951
2952 2015-02-04  Daniel Bates  <dabates@apple.com>
2953
2954         test-webkitpy fails on Mac without iphoneos SDK
2955         https://bugs.webkit.org/show_bug.cgi?id=141255
2956         <rdar://problem/19619691>
2957
2958         Reviewed by David Kilzer and Alexey Proskuryakov.
2959
2960         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
2961         should not require the iphoneos SDK to be installed to run the webkitpy tests.
2962
2963         * Scripts/webkitpy/common/system/platforminfo.py:
2964         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
2965         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
2966         to standard output if the SDK is installed to return the empty string if the SDK is
2967         not installed.
2968         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2969         (MockPlatformInfo.xcode_sdk_version): Added.
2970         * Scripts/webkitpy/port/ios.py:
2971         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
2972         to get the version of the iphoneos SDK, if installed.
2973
2974 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
2975
2976         run-webkit-tests doesn't always capture ASan violation reports
2977         https://bugs.webkit.org/show_bug.cgi?id=141231
2978
2979         Reviewed by Darin Adler.
2980
2981         * Scripts/webkitpy/port/driver.py:
2982         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
2983         by the driver already (as is the case with ASan violations, which are printed to
2984         stderr).
2985         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
2986         report.
2987         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
2988         a separate variable for reporting.
2989
2990 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2991
2992         [webkitpy] Add platform specific Skipped file mechanism for performance tests
2993         https://bugs.webkit.org/show_bug.cgi?id=141152
2994
2995         Reviewed by Csaba Osztrogonác.
2996
2997         Support a test-expectation-like syntax in performance tests' skipped files.
2998         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
2999
3000         * Scripts/webkitpy/port/base.py:
3001         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
3002
3003         * Scripts/webkitpy/port/base_unittest.py:
3004         (PortTest.test_skipped_perf_tests): Test the new syntax.
3005
3006 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
3007
3008         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
3009         https://bugs.webkit.org/show_bug.cgi?id=141236
3010
3011         Reviewed by Sam Weinig.
3012
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3014         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
3015
3016 2015-02-04  Chris Dumez  <cdumez@apple.com>
3017
3018         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
3019         https://bugs.webkit.org/show_bug.cgi?id=141192
3020
3021         Reviewed by Benjamin Poulain.
3022
3023         Add API tests for Vector::removeFirst(value) and
3024         Vector::removeAll(value).
3025
3026         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3027         (TestWebKitAPI::TEST):
3028
3029 2015-02-03  Tim Horton  <timothy_horton@apple.com>
3030
3031         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
3032         https://bugs.webkit.org/show_bug.cgi?id=141217
3033
3034         Reviewed by Sam Weinig.
3035
3036         * WebKitTestRunner/TestController.cpp:
3037         (WTR::copyWebCryptoMasterKey):
3038         (WTR::TestController::createOtherPage):
3039         (WTR::TestController::createWebViewWithOptions):
3040         (WTR::TestController::ensureViewSupportsOptions):
3041         (WTR::TestController::didCommitNavigation):
3042         (WTR::TestController::didFinishNavigation):
3043         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3044         (WTR::TestController::didReceiveAuthenticationChallenge):
3045         (WTR::TestController::decidePolicyForPluginLoad):
3046         (WTR::TestController::decidePolicyForNavigationAction):
3047         (WTR::TestController::decidePolicyForNavigationResponse):
3048         (WTR::TestController::didCommitLoadForFrame): Deleted.
3049         (WTR::TestController::didFinishLoadForFrame): Deleted.
3050         * WebKitTestRunner/TestController.h:
3051         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
3052
3053 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
3054
3055         Unreviewed. Add myself as a committer.
3056
3057         * Scripts/webkitpy/common/config/contributors.json:
3058
3059 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3060
3061         [Win] Unreviewed test fix.
3062
3063         * DumpRenderTree/win/PolicyDelegate.cpp:
3064         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
3065         so was not matching expected output.
3066
3067 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3068
3069         Unreviewed. Moving myself to the committer section at last.
3070
3071         * Scripts/webkitpy/common/config/contributors.json:
3072
3073 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3074
3075         [Win] Tests fail because DRT reports '(null)' instead of an empty string
3076         https://bugs.webkit.org/show_bug.cgi?id=141205
3077
3078         Reviewed by Anders Carlsson.
3079
3080         * DumpRenderTree/win/HistoryDelegate.cpp:
3081         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
3082         properly so that we match expected DumpRenderTree output.
3083
3084 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3085
3086         [GTK] TestWebKitAccessibility is not skipped
3087         https://bugs.webkit.org/show_bug.cgi?id=141179
3088
3089         Reviewed by Carlos Garcia Campos.
3090
3091         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
3092         skipped, and it apparently works reliably on the bots.
3093
3094         * Scripts/run-gtk-tests:
3095         (TestRunner):
3096
3097 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3098
3099         run-perf-tests: allow to specify a wrapper command.
3100         https://bugs.webkit.org/show_bug.cgi?id=141172
3101
3102         Reviewed by Ryosuke Niwa.
3103
3104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3105         (parse_args): Update text to indicate is also valid for WTR.
3106         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3107         (PerfTestsRunner._parse_args): Add wrapper command.
3108
3109 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3110
3111         [Win] Correct version parsing warning in update-webkit
3112         https://bugs.webkit.org/show_bug.cgi?id=141200
3113
3114         Reviewed by Anders Carlsson.
3115
3116         * Scripts/webkitdirs.pm:
3117         (setupAppleWinEnv): Strip out any specific version build level
3118         from the Cygwin version information.
3119   
3120
3121 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3122
3123         [Win] Attempt to improve the reliability of HTTP service
3124         https://bugs.webkit.org/show_bug.cgi?id=141191
3125
3126         Reviewed by Darin Adler.
3127
3128         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3129         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
3130         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
3131         when stopping the service doesn't do so on its own (for Windows runs).
3132
3133 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3134
3135         Web platform test server should not need to create __init__.py files
3136         https://bugs.webkit.org/show_bug.cgi?id=141030
3137
3138         Reviewed by Ryosuke Niwa.
3139
3140         W3C TestImporter ensures that copied __init__.py files are not empty.
3141         If needed, a comment is inserted in __init__.py files.
3142         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
3143
3144         * Scripts/webkitpy/common/system/filesystem.py:
3145         (FileSystem.getsize):
3146         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3147         (TestWebPlatformTestServer.test_start_cmd):
3148         (TestWebPlatformTestServer):
3149         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
3150         * Scripts/webkitpy/w3c/test_importer.py:
3151         (TestImporter.import_tests):
3152
3153 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3154
3155         Unreviewed. Moving myself to the committer section.
3156
3157         * Scripts/webkitpy/common/config/contributors.json:
3158
3159 2015-02-02  Saam Barati  <saambarati1@gmail.com>
3160
3161         Create tests for JSC's Control Flow Profiler
3162         https://bugs.webkit.org/show_bug.cgi?id=141123
3163
3164         Reviewed by Filip Pizlo.
3165
3166         * Scripts/run-javascriptcore-tests:
3167         (runJSCStressTests):
3168         * Scripts/run-jsc-stress-tests:
3169
3170 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
3171
3172         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
3173         https://bugs.webkit.org/show_bug.cgi?id=141158
3174
3175         Reviewed by Darin Adler.
3176
3177         * Scripts/run-jsc-stress-tests:
3178
3179 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3180
3181         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
3182         https://bugs.webkit.org/show_bug.cgi?id=141142
3183
3184         Reviewed by Carlos Garcia Campos.
3185
3186         * MiniBrowser/gtk/BrowserWindow.c:
3187         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
3188
3189 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3190
3191         Web platform test server is not always launching properly on Mac EWS bots
3192         https://bugs.webkit.org/show_bug.cgi?id=141141
3193
3194         Unreviewed.
3195
3196         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3197         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
3198
3199 2015-01-31  Sam Weinig  <sam@webkit.org>
3200
3201         Remove even more Mountain Lion support
3202         https://bugs.webkit.org/show_bug.cgi?id=141124
3203
3204         Reviewed by Alexey Proskuryakov.
3205
3206         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3207         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3208         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3209         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3210         * DumpRenderTree/mac/DumpRenderTree.mm:
3211         (activateTestingFonts):
3212         (prepareConsistentTestingEnvironment):
3213         * DumpRenderTree/mac/EventSendingController.mm:
3214         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3215         (-[EventSendingController contextClick]):
3216         * DumpRenderTree/mac/TextInputController.m:
3217         * LayoutTestRelay/Configurations/Base.xcconfig:
3218         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3219         * MiniBrowser/Configurations/Base.xcconfig:
3220         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3221         * MiniBrowser/mac/WK2BrowserWindowController.m:
3222         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3223         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3224         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3225         * TestWebKitAPI/Configurations/Base.xcconfig:
3226         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3227         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3228         (-[DownloadDelegate _downloadDidFinish:]):
3229         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3230         (TestWebKitAPI::TEST):
3231         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3232         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3233         * WebKitLauncher/Configurations/Base.xcconfig:
3234         * WebKitTestRunner/Configurations/Base.xcconfig:
3235         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3236         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3237         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3238         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3239         (WTR::activateFonts):
3240         * WebKitTestRunner/TestController.cpp:
3241         (WTR::TestController::initialize):
3242         (WTR::TestController::webProcessName):
3243         * WebKitTestRunner/mac/EventSenderProxy.mm:
3244         * asan/asan.xcconfig:
3245
3246 2015-01-31  Commit Queue  <commit-queue@webkit.org>
3247
3248         Unreviewed, rolling out r179408.
3249         https://bugs.webkit.org/show_bug.cgi?id=141117
3250
3251         This didn't fully fix the issue (Requested by anttik on
3252         #webkit).
3253
3254         Reverted changeset:
3255
3256         "OSObjectPtr does not work with dispatch_data_t on Maverics"
3257         https://bugs.webkit.org/show_bug.cgi?id=141081
3258         http://trac.webkit.org/changeset/179408
3259
3260 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3261
3262         https://trac.webkit.org/changeset/179439 breaks a python test
3263         https://bugs.webkit.org/show_bug.cgi?id=141114
3264
3265         Unreviewed.
3266
3267         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3268         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
3269
3270 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3271
3272         Import W3C web platform tests infrastructure
3273         https://bugs.webkit.org/show_bug.cgi?id=140934
3274
3275         Reviewed by Ryosuke Niwa.
3276
3277         Loading necessary web platform tests modules before launching server.
3278         Ensuring that some empty __init__.py files are present and create them if necessary. 
3279
3280         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3281         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3282
3283 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3284
3285         [Win] Another unreviewed test fix.
3286
3287         Correct copy/paste error in buildbot handling.
3288
3289         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3290         (LayoutTestApacheHttpd.__init__):
3291         (LayoutTestApacheHttpd._get_apache_config_file_path):
3292
3293 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3294
3295         [Win] Unreviewed test fix.
3296
3297         Correct path handling based on failures on test bots to get things running again.
3298
3299         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3300         (LayoutTestApacheHttpd.__init__):
3301         (LayoutTestApacheHttpd._get_apache_config_file_path):
3302
3303 2015-01-30  Chris Dumez  <cdumez@apple.com>
3304
3305         Unreviewed. Fix Windows build after r179409.
3306
3307         * DumpRenderTree/win/TestRunnerWin.cpp:
3308         (TestRunner::notifyDone):
3309         (TestRunner::queueLoad):
3310
3311 2015-01-30  Chris Dumez  <cdumez@apple.com>
3312
3313         Rename shared() static member functions to singleton() for singleton classes.
3314         https://bugs.webkit.org/show_bug.cgi?id=141088
3315
3316         Reviewed by Ryosuke Niwa and Benjamin Poulain.
3317
3318         Rename shared() static member functions to singleton() for singleton
3319         classes as per the recent coding style change.
3320
3321 2015-01-30  Antti Koivisto  <antti@apple.com>
3322
3323         OSObjectPtr does not work with dispatch_data_t on Maverics
3324         https://bugs.webkit.org/show_bug.cgi?id=141081
3325
3326         Reviewed by Pratik Solanki.
3327
3328         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
3329         (TestWebKitAPI::TEST):
3330
3331 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3332
3333         [Win] Switch to Apache on Windows
3334         https://bugs.webkit.org/show_bug.cgi?id=141060
3335
3336         Reviewed by Alexey Proskuryakov.
3337
3338         Update our scripts under Windows (and Cygwin) to locate and use
3339         the XAMPP installation of Apache for running tests.
3340
3341         * Scripts/run-webkit-httpd:
3342         * Scripts/webkitperl/httpd.pm:
3343         (getHTTPDPath):
3344         (getDefaultConfigForTestDirectory):
3345         (getHTTPDConfigPathForTestDirectory):
3346         * Scripts/webkitpy/common/system/executive_unittest.py:
3347         (ExecutiveTest.serial_test_kill_process):
3348         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3349         (LayoutTestApacheHttpd.__init__):
3350         (LayoutTestApacheHttpd._get_apache_config_file_path):
3351         (LayoutTestApacheHttpd._stop_running_server):
3352         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3353         (HttpServerBase._is_server_running_on_all_ports):
3354         * Scripts/webkitpy/port/base.py:
3355         (Port._apache_config_file_name_for_platform):
3356         * Scripts/webkitpy/port/port_testcase.py:
3357         (test_apache_config_file_name_for_platform):
3358         * Scripts/webkitpy/port/win.py:
3359         (WinPort.show_results_html_file):
3360         (WinPort._uses_apache):
3361         (WinPort):
3362         (WinPort._path_to_apache):
3363
3364 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
3365
3366         Built result takes too long to be compressed on bots
3367         https://bugs.webkit.org/show_bug.cgi?id=141056
3368
3369         Reviewed by Daniel Bates.
3370
3371         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
3372
3373         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
3374
3375 2015-01-29  Sam Weinig  <sam@webkit.org>
3376
3377         Remove support for screen font substitution
3378         https://bugs.webkit.org/show_bug.cgi?id=141038
3379
3380         Reviewed by Tim Horton.
3381
3382         * DumpRenderTree/win/DumpRenderTree.cpp:
3383         (resetWebPreferencesToConsistentValues):
3384         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
3385
3386 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3387
3388         Make run-jsc-stress-tests --remote work on Linux too
3389         https://bugs.webkit.org/show_bug.cgi?id=141000
3390
3391         Reviewed by Darin Adler.
3392
3393         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
3394         use bash/dash compatible signal names, use Linux/Mac compatible find options,
3395         use bash/dash compatible functions.
3396         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
3397
3398 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3399
3400         [buildbot] Simplify jscore-test buildstep
3401         https://bugs.webkit.org/show_bug.cgi?id=140821
3402
3403         Reviewed by Alexey Proskuryakov.
3404
3405         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3406         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
3407         (RunJavaScriptCoreTests.countFailures): Added.
3408         (RunJavaScriptCoreTests.commandComplete): Deleted.
3409         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
3410         (RunJavaScriptCoreTests.getText): Deleted.
3411         (RunJavaScriptCoreTests.getText2): Deleted.
3412         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
3413         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3414         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
3415         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3416         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
3417
3418 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3419
3420         Unreviewed, revert r179337, we don't need this dependency.
3421
3422         * efl/install-dependencies:
3423         * gtk/install-dependencies:
3424
3425 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
3426
3427         Unreviewed. Moving myself to the committer section.
3428
3429         * Scripts/webkitpy/common/config/contributors.json:
3430
3431 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
3432
3433         URTBF after r179326, added uuid-dev package as new dependency.
3434
3435         * efl/install-dependencies:
3436         * gtk/install-dependencies:
3437
3438 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
3439
3440         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
3441         https://bugs.webkit.org/show_bug.cgi?id=140673
3442
3443         Reviewed by Sam Weinig.
3444
3445         * Scripts/dtrace/trace-webkit2-messages.d: Added.
3446         Add a DTrace script that outputs a small blob of JSON per message.
3447
3448 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
3449
3450         Removed fastMallocForbid / fastMallocAllow
3451         https://bugs.webkit.org/show_bug.cgi?id=141012
3452
3453         Reviewed by Mark Hahnenberg.
3454
3455         Fixed a test bug I noticed while testing.
3456
3457         * DumpRenderTree/JavaScriptThreading.cpp:
3458         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
3459         accessing javaScriptThreads -- otherwise, you'll ASSERT.
3460
3461 2015-01-28  Dana Burkart  <dburkart@apple.com>
3462
3463         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
3464         https://bugs.webkit.org/show_bug.cgi?id=141015
3465
3466         Reviewed by Alexey Proskuryakov.
3467
3468         * asan/asan.xcconfig:
3469
3470 2015-01-28  Sam Weinig  <sam@webkit.org>
3471
3472         Fix the build.
3473
3474         * Scripts/copy-webkitlibraries-to-product-directory:
3475
3476 2015-01-28  Lucas Forschler  <lforschler@apple.com>
3477
3478         Increase the FileUpload block size in an attempt to improve network performance.
3479         
3480         Reviewed by Alexey Proskuryakov.
3481         
3482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3483         (UploadBuiltProduct.__init__):
3484
3485 2015-01-28  Dana Burkart  <dburkart@apple.com>
3486
3487         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
3488         https://bugs.webkit.org/show_bug.cgi?id=136765
3489
3490         Reviewed by Alexey Proskuryakov.
3491
3492         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3493         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3494         * LayoutTestRelay/Configurations/Base.xcconfig:
3495         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3496         * MiniBrowser/Configurations/Base.xcconfig:
3497         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3498         * TestWebKitAPI/Configurations/Base.xcconfig:
3499         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3500         * WebKitLauncher/Configurations/Base.xcconfig:
3501         * WebKitTestRunner/Configurations/Base.xcconfig:
3502         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3503
3504 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
3505
3506         AX: [ATK] Implement support for new AtkRole types for MathML
3507         https://bugs.webkit.org/show_bug.cgi?id=140916
3508
3509         Reviewed by Chris Fleizach.
3510
3511         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
3512         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
3513
3514 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3515
3516         [GTK] Stop removing color marks from unit tests output
3517         https://bugs.webkit.org/show_bug.cgi?id=140996
3518
3519         Reviewed by Philippe Normand.
3520
3521         Since r178236 google tests use a custom simplified output without
3522         any colors, so we don't need to handle the case of non ttys to
3523         remove the color marks.
3524
3525         * Scripts/run-gtk-tests:
3526         (TestRunner.__init__):
3527         (TestRunner._run_test_command.parse_line):
3528
3529 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3530
3531         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
3532         https://bugs.webkit.org/show_bug.cgi?id=131731
3533
3534         Reviewed by Žan Doberšek.
3535
3536         A web page loaded offscreen is in prerender state not hidden.
3537
3538         * Scripts/run-gtk-tests:
3539         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
3540         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3541         (testWebViewPageVisibility):
3542
3543 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3544
3545         Partially revert r178802.
3546
3547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
3548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
3549
3550 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3551
3552         build.webkit.org/dashboard asserts on some commits
3553         https://bugs.webkit.org/show_bug.cgi?id=140926
3554
3555         Reviewed by Tim Horton.
3556
3557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3558         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
3559
3560 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3561
3562         Make flakiness dashboard OS list actually match test_expectations.py
3563         https://bugs.webkit.org/show_bug.cgi?id=140969
3564
3565         Reviewed by Ryosuke Niwa.
3566
3567         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3568
3569 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
3570
3571         [Win] WinLauncher crashes on eleventh site visited
3572         https://bugs.webkit.org/show_bug.cgi?id=140960
3573
3574         Reviewed by Anders Carlsson.
3575
3576         * WinLauncher/WinLauncher.cpp:
3577         (WinLauncher::showLastVisitedSites): Don't access off the end of
3578         the history array.
3579
3580 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3581
3582         [Mac] Disable building Java applets by default
3583         https://bugs.webkit.org/show_bug.cgi?id=140957
3584         rdar://problem/19619529
3585
3586         Reviewed by Anders Carlsson.
3587
3588         It was actually already disabled unconditionally, by accident.
3589
3590         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
3591         * Scripts/webkitpy/port/mac.py:
3592         (MacPort._check_port_build):
3593         (MacPort._build_java_test_support):
3594
3595 2015-01-27  Daniel Bates  <dabates@apple.com>
3596
3597         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
3598         https://bugs.webkit.org/show_bug.cgi?id=140949
3599
3600         Reviewed by Alexey Proskuryakov.
3601
3602         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
3603         builders so that run-webkit-tests can lint the appropriate TestExpectation
3604         files.
3605
3606         * Scripts/webkitpy/port/builders.py:
3607         * Scripts/webkitpy/port/ios.py:
3608         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
3609         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
3610         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
3611         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
3612         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
3613         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
3614         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
3615
3616
3617 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3618
3619         Update bots on the flakiness dashboard
3620         https://bugs.webkit.org/show_bug.cgi?id=140956
3621
3622         Reviewed by Ryosuke Niwa.
3623
3624         * TestResultServer/static-dashboards/builders.jsonp:
3625         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3626
3627 2015-01-27  Daniel Bates  <dabates@apple.com>
3628
3629         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
3630         https://bugs.webkit.org/show_bug.cgi?id=140942
3631
3632         Reviewed by Alexey Proskuryakov.
3633
3634         The directory LayoutTests/platform/wk2 contains test expectations and test results that
3635         are applicable to all WebKit2 ports. We should make use of this information when
3636         running layout tests using iOS WebKit2.
3637
3638         Additionally, make use of the convenience function Port._wk2_port_name() for the name
3639         of the WebKit2 port instead of directly using string concatenation.
3640
3641         * Scripts/webkitpy/port/ios.py:
3642         (IOSSimulatorPort.default_baseline_search_path):
3643
3644 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
3645
3646         [Win] Disable FTL stress tests
3647         https://bugs.webkit.org/show_bug.cgi?id=140932
3648
3649         Reviewed by Brent Fulgham.
3650
3651         * Scripts/run-javascriptcore-tests:
3652
3653 2015-01-27  Daniel Bates  <dabates@apple.com>
3654
3655         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
3656         https://bugs.webkit.org/show_bug.cgi?id=140939
3657
3658         Reviewed by Eric Carlson.
3659
3660         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
3661
3662         * Scripts/webkitdirs.pm:
3663         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
3664         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
3665         and define a function called wanted.
3666
3667 2015-01-27  Daniel Bates  <dabates@apple.com>
3668
3669         Teach run-webkit-app --simulator how to install custom built app
3670         https://bugs.webkit.org/show_bug.cgi?id=140691
3671
3672         Fix inadvertent omission of directory test flag in expression to check for the
3673         existence of the iOS simulator device-specific directory for user installed apps.
3674
3675         * Scripts/webkitdirs.pm:
3676         (hasUserInstalledAppInSimulatorDevice):
3677
3678 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
3679
3680         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
3681         https://bugs.webkit.org/show_bug.cgi?id=87426
3682         <rdar://problem/11527899>
3683
3684         Reviewed by Darin Adler.
3685
3686         Revise COMPtr to work better with our HashMap implementation. Use
3687         modern loop syntax.
3688
3689         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3690         (AccessibilityController::~AccessibilityController):
3691         (AccessibilityController::winNotificationReceived):
3692         * DumpRenderTree/win/DumpRenderTree.cpp:
3693         (dumpBackForwardListForAllWindows):
3694
3695 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3696
3697         [Win] Enable JSC stress tests by default
3698         https://bugs.webkit.org/show_bug.cgi?id=128307
3699
3700         Reviewed by Brent Fulgham.
3701
3702         * Scripts/run-javascriptcore-tests:
3703
3704 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3705
3706         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
3707         arguments for build and test scripts
3708         https://bugs.webkit.org/show_bug.cgi?id=139748
3709
3710         Reviewed by Daniel Bates.
3711
3712         There was much confusion resulting from the multitude of aliases used to build/test for
3713         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
3714         tests directory.
3715
3716         This fixes an issue where run-api-tests and some other scripts failed when run with
3717         --simulator.
3718
3719         * Scripts/build-webkit:
3720         * Scripts/package-root:
3721         (usage):
3722         * Scripts/webkitdirs.pm:
3723         (argumentsForConfiguration):
3724         (determineXcodeSDK):
3725         * Scripts/webkitpy/port/factory.py:
3726         (platform_options):
3727
3728 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3729
3730         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
3731         https://bugs.webkit.org/show_bug.cgi?id=140203
3732         rdar://problem/19198492
3733
3734         Reviewed by Sam Weinig.
3735
3736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3737         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
3738         (TEST):
3739
3740 2015-01-26  David Kilzer  <ddkilzer@apple.com>
3741
3742         Add iOS EWS to build.webkit.org/dashboard
3743         <http://webkit.org/b/140627>
3744
3745         Reviewed by Alexey Proskuryakov.
3746
3747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
3748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
3749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3750         (BubbleQueueServer): Add ios-ews queue info.
3751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3752         Add iOS8Device platform.
3753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3754         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
3755         iOS device logo.
3756
3757 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
3758
3759         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
3760         https://bugs.webkit.org/show_bug.cgi?id=140896
3761
3762         Reviewed by Michael Saboff.
3763         
3764         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
3765         makes our script do this.
3766         
3767         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
3768         this would be harder given llvm's autoconf setup.
3769
3770         * Scripts/copy-webkitlibraries-to-product-directory:
3771
3772 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3773
3774         Update bot assignments.
3775
3776         * BuildSlaveSupport/build.webkit.org-config/config.json:
3777
3778 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3779
3780         Integrate WP python server into WebKit test framework
3781         https://bugs.webkit.org/show_bug.cgi?id=127094
3782
3783         Reviewed by Ryosuke Niwa.
3784
3785         This patch adds W3C web server (wptserver) as a new HTTP server.
3786         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
3787         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
3788
3789         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
3790         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
3791         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
3792
3793         * Scripts/webkitpy/common/system/executive_mock.py:
3794         (MockProcess.communicate):
3795         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
3796         (LayoutTestRunner.__init__):
3797         (LayoutTestRunner.run_tests):
3798         (LayoutTestRunner.start_servers):
3799         (LayoutTestRunner.stop_servers):
3800         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
3801         (LayoutTestRunnerTests._run_tests):
3802         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
3803         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
3804         (LayoutTestRunnerTests):
3805         (LayoutTestRunnerTests.test_servers_started):
3806         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
3807         (Manager.__init__):
3808         (Manager._is_http_test):
3809         (Manager._is_web_platform_test):
3810         (Manager._run_tests):
3811         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3812         (ManagerTest.test_needs_servers.get_wpt_doc_root):
3813         (ManagerTest.test_needs_servers.get_manager):
3814         (ManagerTest.test_needs_servers):
3815         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
3816         (parse_args):
3817         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
3818         (main):
3819         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
3820         (doc_root):
3821         (base_url):
3822         (WebPlatformTestServer):
3823         (WebPlatformTestServer.__init__):
3824         (WebPlatformTestServer._set_start_cmd):
3825         (WebPlatformTestServer._copy_webkit_test_files):
3826         (WebPlatformTestServer._clean_webkit_test_files):
3827         (WebPlatformTestServer._prepare_config):
3828         (WebPlatformTestServer._spawn_process):
3829         (WebPlatformTestServer._stop_running_server):
3830         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
3831         (TestWebPlatformTestServer):
3832         (TestWebPlatformTestServer.test_start_cmd):
3833         * Scripts/webkitpy/port/base.py:
3834         (Port.__init__):
3835         (Port.to.start_web_platform_test_server):
3836         (Port.to):
3837         (Port.to.web_platform_test_server_doc_root):
3838         (Port.to.web_platform_test_server_base_url):
3839         (Port.to.stop_web_platform_test_server):
3840         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
3841         (Driver.__init__):
3842         (Driver.is_web_platform_test):
3843         (Driver.test_to_uri):
3844         (Driver.uri_to_test):
3845         (Driver._command_from_driver_input):
3846         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
3847         (DriverTest.test_test_to_uri):
3848         (DriverTest.test_uri_to_test):
3849
3850 2015-01-26  Daniel Bates  <dabates@apple.com>
3851
3852         Teach run-webkit-app --simulator how to install custom built app
3853         https://bugs.webkit.org/show_bug.cgi?id=140691
3854
3855         Reviewed by David Kilzer.
3856
3857         We should teach run-webkit-app --simulator how to install a custom built app.
3858
3859         Currently run-webkit-app --simulator can only run a system app or an app that
3860         was installed using the simctl command line tool. For convenience we should
3861         teach run-webkit-app --simulator how to install a custom built app.
3862
3863         As a side effect of this change run-safari --simulator will install and run
3864         a custom built of MobileSafari (if it exists).
3865
3866         * Scripts/webkitdirs.pm:
3867         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
3868         Perl from the structure of the device.plist file.
3869         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
3870         file system check to determine the plist path for a Mac app bundle.
3871         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
3872         it will complain that it cannot find the file: "Domain ... does not exist".
3873         (appDisplayNameFromBundle): Ditto.
3874         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
3875         until a simulator device is the specified state.
3876         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
3877         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
3878         the specified device.
3879         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
3880         As implied by its name, this function will not return until the specified simulator
3881         device UDID is in the shutdown state.
3882         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
3883         device with the specified UDID.
3884         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
3885         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
3886         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
3887         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
3888         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
3889         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
3890         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
3891         (hasUserInstalledAppInSimulatorDevice): Added.
3892         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
3893         "Booted" state.
3894         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
3895         switching between a system installed app and a custom built version of the same app (e.g.
3896         custom build of MobileSafari) will erase all contents and settings in the simulator device.
3897         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
3898         as that was the only caller of this function.
3899         (bootedIOSSimulatorDevice): Deleted.
3900         (openIOSSimulator): Deleted.
3901
3902 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3903
3904         Update bot assignments.
3905
3906         * BuildSlaveSupport/build.webkit.org-config/config.json:
3907
3908 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3909
3910         Leaks bot shouldn't run JSC tests
3911         https://bugs.webkit.org/show_bug.cgi?id=140877
3912
3913         Reviewed by Darin Adler.
3914
3915         Shaves off 48 minutes of time.
3916
3917         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3918         (TestLeaksFactory): Slim down the leaks queue.
3919
3920         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3921         * Scripts/webkitpy/port/ios.py:
3922         (IOSSimulatorPort.print_leaks_summary):
3923         * Scripts/webkitpy/port/mac.py:
3924         (MacPort.print_leaks_summary):
3925         Don't yell when leaks are detected.
3926
3927 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3928
3929         Refactor run-javascriptcore-tests
3930         https://bugs.webkit.org/show_bug.cgi?id=140824
3931
3932         Reviewed by Darin Adler.
3933
3934         Separated mozilla, stress test code paths and
3935         determining skipped mozilla tests into subroutines.
3936
3937         * Scripts/run-javascriptcore-tests:
3938         (runMozillaTests):
3939         (runJSCStressTests):
3940         (defaultJsDriverArgsForMozillaTests):
3941
3942 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3943
3944         [buildbot] Fix grammar of TestWithFailureCount
3945         https://bugs.webkit.org/show_bug.cgi?id=140884
3946
3947         Reviewed by Alexey Proskuryakov.
3948
3949         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3950         (TestWithFailureCount):
3951         (TestWithFailureCount.commandComplete):
3952         (TestWithFailureCount.getText2):
3953         (RunUnitTests):
3954         (RunPythonTests):
3955         (RunPerlTests):
3956         (RunLLINTCLoopTests):
3957         (Run32bitJSCTests):
3958         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3959         (RunLLINTCLoopTestsTest.test_failure):
3960         (Run32bitJSCTestsTest.test_failure):
3961         (RunUnitTestsTest.assertFailures):
3962
3963 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3964
3965         Unreviewed. Moving myself to the committer section.
3966
3967         * Scripts/webkitpy/common/config/contributors.json:
3968
3969 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
3970
3971         [GTK] gtkdoc does not appear in DevHelp
3972         https://bugs.webkit.org/show_bug.cgi?id=139369
3973
3974         Reviewed by Philippe Normand.
3975
3976         * gtk/generate-gtkdoc: Create the generators in the main function
3977         and use them to get the local cross renference dependencies. Also
3978         pass the generator module name to webkitdom.write_doc_files().
3979         (get_gtkdoc_module_paths): Receive a list of local cross reference
3980         dependencies.
3981         (get_generator_for_config): Set the main_sgml_file property of the
3982         GtkDoc object from the configuration file.
3983         (generate_documentation): Generate the documentation for the given
3984         generator.
3985         (generate_documentation_for_config): Deleted.
3986         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
3987         * gtk/webkitdom.py:
3988         (write_doc_files): Receive the module name used to build the
3989         -sections.txt filename.
3990
3991 2015-01-26  Commit Queue  <commit-queue@webkit.org>
3992
3993         Unreviewed, rolling out r179107.
3994         https://bugs.webkit.org/show_bug.cgi?id=140880
3995
3996         The GCC in the bots doesn't support the AsyncTask
3997         implementation (Requested by KaL on #webkit).
3998
3999         Reverted changeset:
4000
4001         "[GTK] Enable IndexedDB"
4002         https://bugs.webkit.org/show_bug.cgi?id=98932
4003         http://trac.webkit.org/changeset/179107
4004
4005 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
4006
4007         [EFL] Bump libseccomp version to 2.1.1
4008         https://bugs.webkit.org/show_bug.cgi?id=140357
4009
4010         Reviewed by Gyuyoung Kim.
4011
4012         * efl/jhbuild.modules:
4013
4014 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
4015
4016         [GTK] Enable IndexedDB
4017         https://bugs.webkit.org/show_bug.cgi?id=98932
4018
4019         Reviewed by Žan Doberšek.
4020
4021         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
4022
4023 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
4024
4025         Would like leaks bot results at build.webkit.org/dashboard
4026         https://bugs.webkit.org/show_bug.cgi?id=122657
4027
4028         Reviewed by Darin Adler.
4029
4030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4031         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
4032         than necessary, could use the ones from buildbot in more places.
4033
4034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4035         (BuildbotQueue): Reflect configuration option for leaks queues.
4036
4037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4038         Add leaks queues to performance column. First, leaks are about performance indeed,
4039         and second, this is where we have some space to spare.
4040
4041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4042         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
4043         least a year.
4044
4045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4046         (table.queue-grid td): Moved height from queue-view - we can now have more than one
4047         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
4048         results - once the results are loaded, all rows are currently higher than that.
4049
4050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
4051         (.leaks-popover): Added.
4052
4053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
4054         Added.
4055
4056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
4057         Load BuildbotLeaksQueueView.js.
4058
4059 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
4060
4061         [Win] Add WebKit message loop interface.
4062         https://bugs.webkit.org/show_bug.cgi?id=140857
4063
4064         Reviewed by Brent Fulgham.
4065
4066         Added message loop interface which will run the message loop,
4067         and perform required tasks (like calling CFRunLoopRunInMode)
4068         on each iteration of the loop.
4069
4070         * WinLauncher/WinMain.cpp:
4071         (wWinMain): Use new message loop interface.
4072
4073 2015-01-24  Dan Bernstein  <mitz@apple.com>
4074
4075         update-webkit’s --internal option is unused
4076         https://bugs.webkit.org/show_bug.cgi?id=140861
4077
4078         Reviewed by Anders Carlsson.
4079
4080         * Scripts/update-webkit: Removed the option.
4081
4082 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
4083
4084         DumpRenderTree needs to run with Windows native controls on Windows
4085         https://bugs.webkit.org/show_bug.cgi?id=25592
4086
4087         Reviewed by Anders Carlsson.
4088
4089         * DumpRenderTree/win/DumpRenderTree.cpp:
4090         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
4091         (prepareConsistentTestingEnvironment): Ditto.
4092
4093 2015-01-23  David Kilzer  <ddkilzer@apple.com>
4094
4095         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
4096         <http://webkit.org/b/140787>
4097
4098         Reviewed by Daniel Bates.
4099
4100         * Scripts/webkitpy/port/ios.py:
4101         (IOSPort.determine_full_port_name): Instead of checking the type
4102         of the current host, test if /usr/bin/xcrun exists before trying
4103         to use it.
4104
4105 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
4106
4107         Fix the false positive build failures on the Windows buildbots
4108         https://bugs.webkit.org/show_bug.cgi?id=140819
4109
4110         Reviewed by Brent Fulgham.
4111
4112         Increase the build timeout (without producing output) to 2 hours for Windows bots,
4113         the default 20 minutes is enough for others since they produce output during the build.
4114
4115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4116         (BuildFactory.__init__):
4117
4118 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
4119
4120         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
4121         https://bugs.webkit.org/show_bug.cgi?id=140839
4122
4123         Reviewed by Dean Jackson.
4124
4125         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4126         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
4127         from the IA2Locale structure and pass it to DRT.
4128
4129 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
4130
4131         [Win] Update DRT Accessibility implementation to better match Mac.
4132         https://bugs.webkit.org/show_bug.cgi?id=140830
4133
4134         Reviewed by Dean Jackson.
4135
4136         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4137         (AccessibilityUIElement::titleUIElement):
4138         (AccessibilityUIElement::parentElement):
4139         (convertToDRTLabel):
4140         (AccessibilityUIElement::role):
4141         (AccessibilityUIElement::title):
4142         (AccessibilityUIElement::description):
4143         (AccessibilityUIElement::stringValue):
4144         (AccessibilityUIElement::helpText):
4145         (AccessibilityUIElement::isFocused):
4146
4147 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
4148
4149         REGRESSION: run-perf-tests --profiler= seems to have broken
4150         https://bugs.webkit.org/show_bug.cgi?id=113528
4151
4152         Reviewed by Daniel Bates.
4153
4154         The problem is that "perf --record" (or the equivalent call for
4155         other profilers) is never called whenever there is a wrapper
4156         option in the port. We should inject the profiler call first
4157         (should it exists) and then use the port wrapper.
4158
4159         * Scripts/webkitpy/port/driver.py:
4160         (Driver._command_wrapper):
4161         * Scripts/webkitpy/port/driver_unittest.py:
4162         (DriverTest.test_profiler_and_wrapper): New unit test.
4163
4164 2015-01-22  David Kilzer  <ddkilzer@apple.com>
4165
4166         configure-xcode-for-ios-development needs to import webkitdirs.pm
4167         <http://webkit.org/b/140704>
4168
4169         Fixes the following runtime error:
4170
4171             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
4172
4173         * Scripts/configure-xcode-for-ios-development: Add back code to
4174         import webkitdirs.pm for the exitStatus() method.  Not sure why
4175         I removed it before patch review.
4176
4177 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
4178
4179         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
4180         https://bugs.webkit.org/show_bug.cgi?id=140795
4181
4182         Reviewed by Jon Honeycutt.
4183
4184         * BuildSlaveSupport/build.webkit.org-config/config.json:
4185         r178847 accidentally remove the scheduler for this bot. Re-add it to the
4186         Yosemite scheduler.
4187
4188 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
4189
4190         [Win] Expose missing editing features through WebView interface
4191         https://bugs.webkit.org/show_bug.cgi?id=140773
4192         <rdar://problem/19565421>
4193
4194         Reviewed by Dean Jackson.
4195
4196         Connect the various WebView editing delegate methods to our
4197         test infrastructure. Also prefer _bstr_t to raw BSTR types
4198         to simplify life cycle management.
4199
4200         * DumpRenderTree/win/DumpRenderTree.cpp:
4201         (resetWebViewToConsistentStateBeforeTesting):
4202         * DumpRenderTree/win/EditingDelegate.cpp:
4203         (EditingDelegate::QueryInterface):
4204         (dumpPath):
4205         (dump):
4206         (EditingDelegate::shouldBeginEditingInDOMRange):
4207         (EditingDelegate::shouldEndEditingInDOMRange):
4208         (EditingDelegate::shouldInsertNode):
4209         (EditingDelegate::shouldInsertText):
4210         (EditingDelegate::shouldDeleteDOMRange):
4211         (EditingDelegate::shouldChangeSelectedDOMRange):
4212         (EditingDelegate::shouldApplyStyle):
4213         (EditingDelegate::shouldChangeTypingStyle):
4214         (EditingDelegate::doPlatformCommand):
4215         (EditingDelegate::webViewDidBeginEditing):
4216         (EditingDelegate::webViewDidChange):
4217         (EditingDelegate::webViewDidEndEditing):
4218         (EditingDelegate::webViewDidChangeTypingStyle):
4219         (EditingDelegate::webViewDidChangeSelection):
4220         (EditingDelegate::checkSpellingOfString):
4221         (EditingDelegate::onNotify):
4222         * DumpRenderTree/win/EditingDelegate.h:
4223
4224 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
4225
4226         Add a build flag for ES6 class syntax
4227         https://bugs.webkit.org/show_bug.cgi?id=140760
4228
4229         Reviewed by Michael Saboff.
4230
4231         * Scripts/webkitperl/FeatureList.pm:
4232
4233 2015-01-22  Daniel Bates  <dabates@apple.com>
4234
4235         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
4236         runtime in simctl output
4237         https://bugs.webkit.org/show_bug.cgi?id=140751
4238
4239         Reviewed by David Kilzer.
4240
4241         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
4242         with an error because it does not know how to parse the output of the simctl tool
4243         to identify an Apple Internal runtime.
4244
4245         * Scripts/webkitpy/xcode/simulator.py:
4246         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
4247         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
4248         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
4249         the runtime is an internal runtime.
4250         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
4251         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
4252         appropriate value.
4253         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
4254         it updates the appropriate Runtime object.
4255         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
4256         looking up a Runtime object for an internal runtime.
4257
4258 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
4259
4260         LeaksViewer doesn't show recent builds if there are less than 10
4261         https://bugs.webkit.org/show_bug.cgi?id=140716
4262
4263         Reviewed by Tim Horton.
4264
4265         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
4266
4267 2015-01-22  Lucas Forschler  <lforschler@apple.com>
4268
4269         Add Apple build slaves.
4270         Fixed text alignment for slave list.
4271         
4272         Unreviewed.
4273         
4274         * BuildSlaveSupport/build.webkit.org-config/config.json:
4275
4276 2015-01-21  Lucas Forschler  <lforschler@apple.com>
4277
4278         Teach build.webkit.org about bot308 and bot309.
4279         
4280         Unreviewed.
4281         
4282         * BuildSlaveSupport/build.webkit.org-config/config.json:
4283
4284 2015-01-21  Lucas Forschler  <lforschler@apple.com>
4285
4286         Add two Apple Mavericks slaves.
4287         
4288         Unreviewed.
4289         
4290         * BuildSlaveSupport/build.webkit.org-config/config.json:
4291
4292 2015-01-21  Daniel Bates  <dabates@apple.com>
4293
4294         Add iOS WebKit1 TestExpectation file
4295         https://bugs.webkit.org/show_bug.cgi?id=140739
4296
4297         Reviewed by David Kilzer.
4298
4299         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
4300         expectations in directory LayoutTests/platform/ios-simulator-wk1.
4301
4302         * Scripts/webkitpy/port/ios.py:
4303         (IOSSimulatorPort.default_baseline_search_path):
4304
4305 2015-01-21  David Kilzer  <ddkilzer@apple.com>
4306
4307         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
4308         <http://webkit.org/b/140704>
4309
4310         Reviewed by Daniel Bates.
4311
4312         * Scripts/configure-xcode-for-ios-development:
4313         - Update copyright.
4314         - Remove FIXME addressed by r178709.
4315         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
4316         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
4317         missing headers from iphonesimulator SDK to iphoneos SDK.
4318         (sdkDirectory): Add method that returns SDK directory.
4319         (sdkPlatformDirectory): Extract method from
4320  &nb