14753a5f1e9406ed1f64f94970b0d5f1ff8c8f81
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
2
3         Add myself to committers.py                 
4         https://bugs.webkit.org/show_bug.cgi?id=67696
5
6         Reviewed by Kent Tamura.
7
8         * Scripts/webkitpy/common/config/committers.py:
9
10 2011-09-07  Adam Barth  <abarth@webkit.org>
11
12         rebaseline button in garden-o-matic details view should work
13         https://bugs.webkit.org/show_bug.cgi?id=67738
14
15         Reviewed by Dimitri Glazkov.
16
17         This patch wires up the rebaseline button in garden-o-matic results
18         details view.  The button is current per-test, so there isn't a way to
19         rebaseline individual bots.  This is a place to start.  If we decide we
20         want per-bot rebaselining, we'll need to think of some better UI.
21
22         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
23         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
24         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
25         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
26
27 2011-09-07  Eric Seidel  <eric@webkit.org>
28
29         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
30         https://bugs.webkit.org/show_bug.cgi?id=67737
31
32         Reviewed by Adam Barth.
33
34         I got a little over-eager when deprecating host.port_factory in the previous commit.
35         Turns out that Host.port_factory was already the "modern" port/factory.py
36         it was just the Module object.  I un-deprecated the variable, and changed it from
37         being the module to being an actual PortFactory, passing it a host object.
38         I also taught PortFactory how to set user/executive/filesystem in the kwargs
39         when instantiating a new Port object.
40         This magically fixed the test_rebaseline test, since its now no longer talking
41         to the real filesystem.
42
43         * Scripts/webkitpy/common/host.py:
44         * Scripts/webkitpy/layout_tests/port/factory.py:
45         * Scripts/webkitpy/tool/commands/queries.py:
46         * Scripts/webkitpy/tool/mocktool.py:
47
48 2011-09-07  Eric Seidel  <eric@webkit.org>
49
50         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
51         https://bugs.webkit.org/show_bug.cgi?id=67734
52
53         Reviewed by Adam Barth.
54
55         Right now every place that creates a Port object has to be very careful
56         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
57         The correct fix is for port/factory.py (which creates most port objects)
58         to know how to pass these in automatically.  However, currently all port/factory.py
59         functions are free functions instead of being on an object.  This patch
60         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
61
62         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
63         pass along the proper scm/user/filesystem to the Port object.
64
65         * Scripts/webkitpy/common/host.py:
66         * Scripts/webkitpy/layout_tests/port/factory.py:
67         * Scripts/webkitpy/tool/commands/queries.py:
68         * Scripts/webkitpy/tool/mocktool.py:
69
70 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
71
72         Unreviewed, rolling out r94441.
73         http://trac.webkit.org/changeset/94441
74         https://bugs.webkit.org/show_bug.cgi?id=67731
75
76         "MacEWSes are backed up due to new machines not able to reach
77         git.webkit.org.  Disabling tests for now" (Requested by
78         eseidel2 on #webkit).
79
80         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
81
82 2011-09-07  Elliot Poger  <epoger@google.com>
83
84         filter test_expectations properly for chromium-mac vs chromium-cg-mac
85         https://bugs.webkit.org/show_bug.cgi?id=67324
86
87         Reviewed by Dirk Pranke.
88
89         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
90         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
91         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
92         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
93         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
94
95 2011-09-07  Eric Boren  <borenet@gmail.com>
96
97         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
98         https://bugs.webkit.org/show_bug.cgi?id=66800
99
100         Reviewed by Darin Fisher.
101
102         * DumpRenderTree/chromium/EventSender.cpp:
103         (EventSender::sendCurrentTouchEvent):
104
105 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
106
107         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
108         https://bugs.webkit.org/show_bug.cgi?id=67254
109
110         Reviewed by Csaba Osztrogonác.
111
112         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
113         derived from the running location of DumpRenderTree binary.
114
115         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
116         (LayoutTestController::pathToLocalResource):
117         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
118
119 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
120
121         REGRESSION(r94288) build-webkit doesn't work on Symbian
122         https://bugs.webkit.org/show_bug.cgi?id=67706
123
124         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
125         (buildQMakeProject):
126
127 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
128
129         REGRESSION(r94288) build-webkit doesn't work on Windows
130         https://bugs.webkit.org/show_bug.cgi?id=67646
131
132         Roll back r94655 with a small fix.
133
134         * Scripts/webkitdirs.pm:
135         (buildQMakeProject):
136
137 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
138
139         Unreviewed, rolling out r94635.
140         http://trac.webkit.org/changeset/94635
141         https://bugs.webkit.org/show_bug.cgi?id=67704
142
143         Linux Touch build is failing to compile this change.
144         (Requested by loislo on #webkit).
145
146         * DumpRenderTree/chromium/EventSender.cpp:
147         (EventSender::sendCurrentTouchEvent):
148
149 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
150
151         Unreviewed, rolling out r94655.
152         http://trac.webkit.org/changeset/94655
153         https://bugs.webkit.org/show_bug.cgi?id=67703
154
155         It broke Leopard debug bot (Requested by ossy on #webkit).
156
157         * Scripts/webkitdirs.pm:
158
159 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
160
161         REGRESSION(r94288) build-webkit doesn't work on Windows
162         https://bugs.webkit.org/show_bug.cgi?id=67646
163
164         Reviewed by Csaba Osztrogonác.
165
166         * Scripts/webkitdirs.pm:
167
168 2011-09-06  Eric Boren  <borenet@gmail.com>
169
170         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
171         https://bugs.webkit.org/show_bug.cgi?id=66800
172
173         Reviewed by Darin Fisher.
174
175         * DumpRenderTree/chromium/EventSender.cpp:
176         (EventSender::sendCurrentTouchEvent):
177
178 2011-09-06  Adam Barth  <abarth@webkit.org>
179
180         garden-o-matic details view should having working rebaseline and next/previous buttons
181         https://bugs.webkit.org/show_bug.cgi?id=67659
182
183         Reviewed by Dimitri Glazkov.
184
185         This patch wires up basic back/forward buttons that let you traverse
186         through the results we're examining in the details view.  This ended up
187         being more code than I expected, but I wanted to keep all the state
188         information in the DOM itself.
189
190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
193
194 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
195
196         fix MockFileSystem.glob(), refactor filesystem tests
197         https://bugs.webkit.org/show_bug.cgi?id=67462
198
199         Reviewed by Eric Seidel.
200
201         In debugging why my proposed change for MockFileSystem.glob()
202         in bug 66228 didn't work, I stumbled across two real bugs
203         that cancelled each other out for the unit tests. I fixed those
204         (glob shouldn't recurse into subdirs, and we weren't populating
205         self.dirs from self.files properly).
206
207         I have also created a "mixin" class for tests that can be shared
208         between the real filesystem and the mock filesystem - MockFileSystem
209         is being used enough it needs its own tests.
210
211         * Scripts/webkitpy/common/system/filesystem_mock.py:
212         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
213         * Scripts/webkitpy/common/system/filesystem_unittest.py:
214
215 2011-09-06  Anders Carlsson  <andersca@apple.com>
216
217         Move NPAPI headers in bridge to plugins
218         https://bugs.webkit.org/show_bug.cgi?id=67661
219
220         Update forwarding headers.
221
222         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
223         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
224
225 2011-09-06  Tony Chang  <tony@chromium.org>
226
227         [chromium] Check in 'build' for compiled binaries first
228         https://bugs.webkit.org/show_bug.cgi?id=67549
229
230         Reviewed by Dirk Pranke.
231
232         I'm working on moving the windows build output to a common location
233         rather than relative to the sln file.  Because of that, we need to
234         check those build locations first for DumpRenderTree.exe.
235
236         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
237
238 2011-09-06  Adam Barth  <abarth@webkit.org>
239
240         Use a hierarchial structure for the garden-o-matic results view
241         https://bugs.webkit.org/show_bug.cgi?id=67620
242
243         Reviewed by Dimitri Glazkov.
244
245         This patch re-organizes the results view to use a hierachial structure
246         for selection.  At the top-level are sections for each test.  Expanding
247         the test section shows a tab selector for builders.
248
249         This structure prepares us for wiring up various actions to this view.
250
251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
252         (.):
253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
254         ():
255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
256         (.):
257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
259         (.results-view>.toolbar):
260         (.results-view>.toolbar ul.actions):
261         (.results-view>.toolbar ul.actions li):
262         (.results-grid table):
263         (.results-grid table td, .results-view table th):
264         (.results-grid table th):
265         (.results-grid .text-result):
266         (.results-grid .image-result):
267
268 2011-09-06  Adam Barth  <abarth@webkit.org>
269
270         garden-o-matic's base.probe generates spam in the JavaScript console
271         https://bugs.webkit.org/show_bug.cgi?id=67622
272
273         Reviewed by Dimitri Glazkov.
274
275         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
276         instead of HTMLScriptElement to test whether results exist.  This
277         reduces the console.log spam and saves bandwidth because we can use a
278         HEAD request instead of a GET request.
279
280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
281
282 2011-09-05  Adam Barth  <abarth@webkit.org>
283
284         Add a tab to garden-o-matic for viewing expected failures
285         https://bugs.webkit.org/show_bug.cgi?id=67619
286
287         Reviewed by Dimitri Glazkov.
288
289         This patch adds a basic tab to garden-o-matic that shows all the tests
290         failing on the bots, including the expected failures.  This patch
291         mostly involves refactoring existing classes to allow new subclasses.
292
293         This view is useful for when gardeners mark tests as expected to fail
294         and then rebaseline them later.
295
296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
303
304 2011-09-05  Adam Barth  <abarth@webkit.org>
305
306         Fix global variable leak in garden-o-matic
307         https://bugs.webkit.org/show_bug.cgi?id=67617
308
309         Reviewed by Dimitri Glazkov.
310
311         Caught by running the unit tests with noglobals turned on.
312
313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
314
315 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
316
317         [Qt][WK2] Add pixel test support
318         https://bugs.webkit.org/show_bug.cgi?id=66283
319
320         Reviewed by Andreas Kling.
321
322         Implemented pixel result generation by reusing the logic
323         that we have in DumpRenderTree.
324         * WebKitTestRunner/qt/TestInvocationQt.cpp:
325         (WTR::dumpImage):
326         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
327
328 2011-09-04  Robin Dunn  <robin@alldunn.com>
329
330         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
331         https://bugs.webkit.org/show_bug.cgi?id=67577
332
333         Reviewed by Kevin Ollivier.
334
335         * waf/build/settings.py:
336
337 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
338
339         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
340
341         * waf/build/settings.py:
342
343 2011-09-03  Dan Bernstein  <mitz@apple.com>
344
345         32-bit build fix.
346
347         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
348         (TestWebKitAPI::Util::toSTD):
349
350 2011-09-03  Dan Bernstein  <mitz@apple.com>
351
352         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
353         https://bugs.webkit.org/show_bug.cgi?id=67559
354
355         Reviewed by Darin Adler.
356
357         * DumpRenderTree/mac/DumpRenderTree.mm:
358         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
359         the call to it.
360         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
362         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
363         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
364         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
365         (TestWebKitAPI::Util::toSTD): Added.
366
367 2011-09-03  Adam Barth  <abarth@webkit.org>
368
369         garden-o-matic results view should have a better results selector
370         https://bugs.webkit.org/show_bug.cgi?id=67542
371
372         Reviewed by Dimitri Glazkov.
373
374         This patch adds a basic grid-based results selector to the results
375         view.  Currently, this grid just shows how the tests fail on the
376         various bots.  A future patch will let you select which failure to view
377         and to mark the failures for rebaselining.
378
379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
381           - Add some more basic functions for manipulating dictionaries.
382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
385
386 2011-09-03  Adam Barth  <abarth@webkit.org>
387
388         garden-o-matic results view should show Actual and Expected results for text failures
389         https://bugs.webkit.org/show_bug.cgi?id=67536
390
391         Reviewed by Eric Seidel.
392
393         In the past, we didn't show actual and expected text results (we just
394         showed the diff) because we didn't have the awesome six-by-two results
395         grid.  Now that we do, we can move show these results.
396
397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
399           - Fixed some typos that were preventing these unit tests from running.
400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
401         (.):
402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
403           - Report -actual.txt and -expected.txt as possible results URLs.
404
405 2011-09-03  Adam Barth  <abarth@webkit.org>
406
407         garden-o-matic shows "ghost" failures that are already fixed
408         https://bugs.webkit.org/show_bug.cgi?id=67535
409
410         Reviewed by Eric Seidel.
411
412         About 10% of writes fail to stick on test-results.appspot.com.  This
413         patch causes us to fetch the full_results.json blob directly from
414         build.chromium.org rather than relying upon AppEngine.
415
416         Unforuntately, we still need to get historical information from
417         AppEngine.  That will take several patches to fix becuase I need to
418         change the bots to write the full_results.json file to the
419         build-specific directory in addition to the zip file.
420
421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
424
425 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
426
427         Unreviewed, rolling out r94458.
428         http://trac.webkit.org/changeset/94458
429         https://bugs.webkit.org/show_bug.cgi?id=67558
430
431         Caused appcache test to fail on various bots (Requested by
432         rniwa on #webkit).
433
434         * Scripts/webkitpy/layout_tests/port/webkit.py:
435         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
436
437 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
438
439         Unreviewed, rolling out r94453.
440         http://trac.webkit.org/changeset/94453
441         https://bugs.webkit.org/show_bug.cgi?id=67557
442
443         Caused appcache test to fail on various bots (Requested by
444         rniwa on #webkit).
445
446         * Scripts/webkitpy/layout_tests/port/webkit.py:
447
448 2011-09-02  Michael Saboff  <msaboff@apple.com>
449
450         Add JSC:RegExp functional tests
451         https://bugs.webkit.org/show_bug.cgi?id=67339
452
453         New perl script to build JavaScriptCore and run the RegExp tests.
454
455         Reviewed by Gavin Barraclough.
456
457         * Scripts/run-regexp-tests: Added.
458
459 2011-09-02  Michael Saboff  <msaboff@apple.com>
460
461         Add JSC:RegExp functional tests
462         https://bugs.webkit.org/show_bug.cgi?id=67339
463
464         New perl script to build JavaScriptCore and run the RegExp tests.
465
466         Reviewed by Gavin Barraclough.
467
468         * Scripts/run-regexp-tests: Added.
469
470 2011-09-02  Eric Seidel  <eric@webkit.org>
471
472         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
473         https://bugs.webkit.org/show_bug.cgi?id=67530
474
475         Unreviewed.  Fixing typo from previous commit.
476
477         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
478         which exercises the code I previously made a typo in.
479
480         * Scripts/webkitpy/layout_tests/port/webkit.py:
481         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
482
483 2011-09-02  Eric Seidel  <eric@webkit.org>
484
485         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
486         https://bugs.webkit.org/show_bug.cgi?id=67530
487
488         Reviewed by Adam Barth.
489
490         No functional change, just reshuffling code.
491
492         * Scripts/webkitpy/layout_tests/port/webkit.py:
493
494 2011-09-02  Darin Adler  <darin@apple.com>
495
496         Added Subversion ignore for .pyc generated files.
497
498         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
499         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
500         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
501
502 2011-09-02  Adam Barth  <abarth@webkit.org>
503
504         Enable testing on mac-ews
505         https://bugs.webkit.org/show_bug.cgi?id=67505
506
507         Reviewed by Eric Seidel.
508
509         This patch enables testing on the Mac EWS, which should help
510         contributors not turn the Mac bots red.
511
512         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
513
514 2011-09-01  Beth Dakin  <bdakin@apple.com>
515
516         https://bugs.webkit.org/show_bug.cgi?id=67451
517         Add a test for going back to a cached page after changing the device scale factor
518
519         Reviewed by Adam Roben.
520
521         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
523         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
524         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
525         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
526         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
527         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
528         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
529         (TestWebKitAPI::TEST_F):
530
531         Added new function to WebKitAgnosticTest to goBack. Separated 
532         waitForLoadToFinish() into its own function (instead of being a part of 
533         loadAndWaitUntilFinished()) so that it can be called from goBack as 
534         well. Also added initializeView() so we can set the cache model.
535         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
536         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
537         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
538         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
539         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
540         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
541         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
542         (TestWebKitAPI::WebKitAgnosticTest::goBack):
543         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
544
545 2011-09-02  Anders Carlsson  <andersca@apple.com>
546
547         Build fix.
548
549         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
550         (PrivateBrowsing::ScriptableObject::pluginTest):
551
552 2011-09-02  Anders Carlsson  <andersca@apple.com>
553
554         Move private browsing test to a PluginTest subclass
555         https://bugs.webkit.org/show_bug.cgi?id=67498
556
557         Reviewed by Darin Adler.
558
559         * DumpRenderTree/DumpRenderTree.gypi:
560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
561         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
562         (pluginGetProperty):
563         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
564         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
565         (PluginTest::NPP_SetValue):
566         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
567         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
568         (PrivateBrowsing::PrivateBrowsing):
569         (PrivateBrowsing::privateBrowsingEnabled):
570         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
571         (PrivateBrowsing::ScriptableObject::hasProperty):
572         (PrivateBrowsing::ScriptableObject::getProperty):
573         (PrivateBrowsing::ScriptableObject::pluginTest):
574         (PrivateBrowsing::NPP_New):
575         (PrivateBrowsing::NPP_GetValue):
576         (PrivateBrowsing::NPP_SetValue):
577         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
578         (NPP_New):
579         (NPP_SetValue):
580         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
581         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
582         * GNUmakefile.am:
583
584 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
585
586         [Qt] Build dependency problems
587         https://bugs.webkit.org/show_bug.cgi?id=38054
588
589         Trivial fix after r94288.
590
591         Rubber-stamped by Andras Becsi.
592
593         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
594         (buildQMakeProject):
595
596 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
597
598         Remove my old e-mail address and add my new one.
599
600         Rubber-stamped by Tor Arne Vestbø.
601
602         * Scripts/webkitpy/common/config/committers.py:
603
604 2011-09-02  Philippe Normand  <pnormand@igalia.com>
605
606         [GTK] run-gtk-tests leaves a zombie Xvfb process
607         https://bugs.webkit.org/show_bug.cgi?id=67389
608
609         Reviewed by Martin Robinson.
610
611         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
612         child process instead of doing shell redirection.
613
614 2011-09-01  Mark Rowe  <mrowe@apple.com>
615
616         Fix the build by adding some more missing return types.
617
618         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
619         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
620
621 2011-09-01  Eric Seidel  <eric@webkit.org>
622
623         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
624         https://bugs.webkit.org/show_bug.cgi?id=66228
625
626         Reviewed by Dirk Pranke.
627
628         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
629         The LeaksViewer tool globs for all *-leaks.txt files.
630         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
631
632         In order to test this I had to fix a limitation in our MockFileSystem.glob
633         method.  However, doing so uncovered a typo and bug in the integration tests.
634         I've disabled the offending integration tests.
635
636         * Scripts/webkitpy/common/system/filesystem_mock.py:
637         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
638         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
639
640 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
641
642         Adds a LayoutTestController method to make it possible to test
643         starting speech input via an API call.
644         https://bugs.webkit.org/show_bug.cgi?id=60170
645
646         Reviewed by Dimitri Glazkov.
647
648         * DumpRenderTree/LayoutTestController.h:
649         * DumpRenderTree/chromium/LayoutTestController.cpp:
650         (LayoutTestController::LayoutTestController):
651         (LayoutTestController::startSpeechInput):
652         * DumpRenderTree/chromium/LayoutTestController.h:
653         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
654         (LayoutTestController::startSpeechInput):
655         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
656         (LayoutTestController::startSpeechInput):
657         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
658         (LayoutTestController::startSpeechInput):
659         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
660         (LayoutTestController::startSpeechInput):
661         * DumpRenderTree/qt/LayoutTestControllerQt.h:
662         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
663         (LayoutTestController::startSpeechInput):
664         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
665         (LayoutTestController::startSpeechInput):
666
667 2011-09-01  Tim Horton  <hortont424@gmail.com>
668
669         Fix TestWebKitAPI build on clang-2.0
670
671         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
672
673 2011-09-01  Adam Barth  <abarth@webkit.org>
674
675         Remove unused "extension" parameter from rebaseline gardeningserver handler
676         https://bugs.webkit.org/show_bug.cgi?id=67384
677
678         Reviewed by James Robinson.
679
680         This parameter hasn't done anything in a while.
681
682         * Scripts/webkitpy/tool/commands/rebaseline.py:
683         * Scripts/webkitpy/tool/servers/gardeningserver.py:
684         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
685
686 2011-09-01  Eric Seidel  <eric@webkit.org>
687
688         Unreviewed.
689
690         Fix a typo in unittests.  Unfortunately fixing it
691         caused several assertions.  Just disabling the test
692         instead, since it was providing no value before due to the typo.
693
694         * Scripts/webkitpy/layout_tests/port/test.py:
695
696 2011-09-01  Adam Barth  <abarth@webkit.org>
697
698         Add a "rebaseline" button to the garden-o-matic summary page
699         https://bugs.webkit.org/show_bug.cgi?id=67382
700
701         Reviewed by Dimitri Glazkov.
702
703         As much as we might wish folks to not rebaseline entire test groups at
704         once, the truth is that doing so is a common operation.  Adding a
705         button for this operation is likely to make folks happy.
706
707         This patch also cleans up a bunch of plumbing surrounding failureInfo
708         objects.
709
710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
720
721 2011-09-01  Adam Barth  <abarth@webkit.org>
722
723         garden-o-matic should let the gardener assign blame for a group of test failures
724         https://bugs.webkit.org/show_bug.cgi?id=67379
725
726         Reviewed by Dimitri Glazkov.
727
728         If a group of test failures has a large revision range, the gardener
729         might wish to blame a specific revision for the failure.  Currently,
730         this only effect of assigning blame in this way is to hide the other
731         suspect commits.
732
733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
736
737 2011-09-01  Adam Barth  <abarth@webkit.org>
738
739         Hide garden-o-matic failure table until hover
740         https://bugs.webkit.org/show_bug.cgi?id=67376
741
742         Reviewed by Dimitri Glazkov.
743
744         This patch removes the failure table for build failures (because it
745         does not make sense) and hides the failure table for test groups until
746         the user hovers over the test failure block, reducing visual noise.
747
748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
751
752 2011-09-01  Adam Barth  <abarth@webkit.org>
753
754         Switch garden-o-matic from commitData.title to commitData.summary
755         https://bugs.webkit.org/show_bug.cgi?id=67375
756
757         Reviewed by Dimitri Glazkov.
758
759         commitData.title is a string provided by Trac, which isn't great in all
760         cases.  commitData.summary is my attempt to find the most important
761         one-line summary of the commit.  This patch switches garden-o-matic
762         over to summary.
763
764         Also, this patch tweaks a bunch of CSS to tighten up the summary page
765         and reduce visual noise.
766
767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
770
771 2011-09-01  Adam Barth  <abarth@webkit.org>
772
773         Group failing tests in garden-o-matic if there are more than three in a folder
774         https://bugs.webkit.org/show_bug.cgi?id=67373
775
776         Reviewed by Dimitri Glazkov.
777
778         Sometimes a failure will cause many tests in a given directory to fail.
779         When that happens, it's better to list the directory as a single item
780         (with a count) rather than spamming all the test names.
781
782         (This patch also updates a bunch of unit test expected results after my last commit.)
783
784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
789
790 2011-09-01  Adam Barth  <abarth@webkit.org>
791
792         Lower the visual noise from the failing builders display
793         https://bugs.webkit.org/show_bug.cgi?id=67369
794
795         Reviewed by Dimitri Glazkov.
796
797         This patch ensures that the "Building" row in the failing builders
798         display is always last and dims it by 50% to reduce visual noise.  This
799         lets the gardener focus on the actual failures.
800
801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
804
805 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
806
807         [Qt] Build dependency problems
808         https://bugs.webkit.org/show_bug.cgi?id=38054
809
810         Make clean build after the defines are changed.
811
812         Reviewed by Csaba Osztrogonác.
813
814         * Scripts/webkitdirs.pm:
815         (buildQMakeProject):
816
817 2011-08-31  Adam Barth  <abarth@webkit.org>
818
819         Move DumpRenderTree to WebKitPlatformSupport
820         https://bugs.webkit.org/show_bug.cgi?id=67331
821
822         Reviewed by Darin Fisher.
823
824         This patch update DumpRenderTree to account for the WebKitClient =>
825         WebKitPlatformSupport rename.
826
827         * DumpRenderTree/chromium/NotificationPresenter.cpp:
828         (NotificationPresenter::show):
829         * DumpRenderTree/chromium/Task.cpp:
830         (postTask):
831
832 2011-08-31  Eric Seidel  <eric@webkit.org>
833
834         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
835         https://bugs.webkit.org/show_bug.cgi?id=67314
836
837         Reviewed by Adam Barth.
838
839         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
840         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
841         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
842
843         I also moved a bunch of code into dashboard.css which belonged there.
844
845         * QueueStatusServer/handlers/activebots.py: Added.
846         * QueueStatusServer/main.py:
847         * QueueStatusServer/stylesheets/dashboard.css:
848         (.queue_bubble):
849         (.queue_name):
850         (.last_heard_from):
851         (.status_text):
852         (.alive):
853         (.behind):
854         (.dead):
855         * QueueStatusServer/templates/activebots.html: Added.
856         * QueueStatusServer/templates/dashboard.html:
857         * QueueStatusServer/templates/recentstatus.html:
858
859 2011-08-31  Oliver Hunt  <oliver@apple.com>
860
861         Move CheckedArithmeticOperations.cpp to the intended location
862
863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
864         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
865
866 2011-08-31  Elliot Poger  <epoger@google.com>
867
868         add unittest to validate the complete set of Chromium configurations
869         https://bugs.webkit.org/show_bug.cgi?id=67211
870
871         Reviewed by Adam Barth.
872
873         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
874
875 2011-08-31  Nico Weber  <thakis@chromium.org>
876
877         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
878         https://bugs.webkit.org/show_bug.cgi?id=67297
879
880         Reviewed by Tony Chang.
881
882         Explicitly disable smooth scrolling in chromium's DRT.
883
884         * DumpRenderTree/chromium/WebPreferences.cpp:
885         (WebPreferences::applyTo):
886
887 2011-08-31  Oliver Hunt  <oliver@apple.com>
888
889         Add Checked<> tests to windows build
890
891         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
892
893 2011-08-30  Oliver Hunt  <oliver@apple.com>
894
895         Add support for checked arithmetic
896         https://bugs.webkit.org/show_bug.cgi?id=67095
897
898         Reviewed by Sam Weinig.
899
900         Add test cases for Checked<>
901
902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
903         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
904
905 2011-08-31  Adam Barth  <abarth@webkit.org>
906
907         Move summary.html to garden-o-matic.html.
908
909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
911         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
913
914 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
915
916         [chromium] DRT linux should pass nativeKeyCode to plugins
917         https://bugs.webkit.org/show_bug.cgi?id=66679
918
919         Reviewed by Tony Chang.
920
921         * DumpRenderTree/chromium/EventSender.cpp:
922         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
923         (simulated) nativeKeyCode for the given input keyboard code.
924
925 2011-08-31  Adam Barth  <abarth@webkit.org>
926
927         Tighen up UI for garden-o-matic tab strip
928         https://bugs.webkit.org/show_bug.cgi?id=67266
929
930         Reviewed by Dimitri Glazkov.
931
932         This patch add CSS to move the tab strip to the edges of the page and
933         to remove some gratuitous border-radius.
934
935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
937
938 2011-08-31  Adam Barth  <abarth@webkit.org>
939
940         garden-o-matic results view shouldn't be horrifically ugly
941         https://bugs.webkit.org/show_bug.cgi?id=67264
942
943         Reviewed by Dimitri Glazkov.
944
945         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
946
947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
950
951 2011-08-31  Adam Barth  <abarth@webkit.org>
952
953         garden-o-matic needs a tabstrip
954         https://bugs.webkit.org/show_bug.cgi?id=67263
955
956         Reviewed by Dimitri Glazkov.
957
958         This patch adds a basic tabstrip to garden-o-matic.  The results
959         details view now opens in the "Results" tab, and the user can flip back
960         and forth between the Summary and the Results tab quickly.  There's
961         also a stub for a "Commits" tab, which is disabled.
962
963         This patch isn't the most beautiful in the world, but it gets the ball
964         rolling on a multi-modal UI.
965
966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
971
972 2011-08-31  Ai Makabi  <makabi@google.com>
973
974         Extract reference links from reftest test file.
975         https://bugs.webkit.org/show_bug.cgi?id=66838
976
977         Reviewed by Shinichiro Hamaji.
978
979         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
980         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
981         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
982
983 2011-08-03  Philippe Normand  <pnormand@igalia.com>
984
985         [webkitpy] missing log import in common/net/resultsjsonparser.py
986         https://bugs.webkit.org/show_bug.cgi?id=65606
987
988         Reviewed by Martin Robinson.
989
990         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
991
992 2011-08-30  Philippe Normand  <pnormand@igalia.com>
993
994         [stylechecker] complains about NULL usage in some gst_structure_ calls
995         https://bugs.webkit.org/show_bug.cgi?id=67194
996
997         Reviewed by Martin Robinson.
998
999         Don't warn about NULL in some gst_structure_ calls. 0 can't be
1000         used for these, a proper sentinel is required.
1001
1002         * Scripts/webkitpy/style/checkers/cpp.py:
1003         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1004
1005 2011-08-30  Adam Barth  <abarth@webkit.org>
1006
1007         Remove old-style UI from garden-o-matic
1008         https://bugs.webkit.org/show_bug.cgi?id=67257
1009
1010         Reviewed by Dimitri Glazkov.
1011
1012         This code is nowhere near as awesome as the new hotness.  Let's remove
1013         it so it doesn't weigh us down.
1014
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
1017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
1020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
1021
1022 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1023
1024         [WebSocket] update pywebsocket to 0.6b5.
1025         https://bugs.webkit.org/show_bug.cgi?id=66924
1026
1027         Reviewed by Kent Tamura.
1028
1029         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1030         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
1031         0.6b3 or later supports a closing handshake handler and it is useful to
1032         verify client's closing handshake implementation.
1033         0.6b4 supports AbortedByUserException. It is useful to eliminate
1034         unnecessary server warning messages on intended abnormal closures.
1035         0.6b5 supports Python 2.5.1 or Mac 10.5.
1036
1037         * Scripts/webkitpy/thirdparty/__init__.py:
1038         Update download URL and directory path.
1039
1040 2011-08-30  Dan Bernstein  <mitz@apple.com>
1041
1042         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
1043         https://bugs.webkit.org/show_bug.cgi?id=67230
1044
1045         Reviewed by Darin Adler.
1046
1047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1048         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
1049         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
1050         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
1051         (TestWebKitAPI::TEST):
1052
1053 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
1054
1055         Add MediaSource API to HTMLMediaElement
1056         https://bugs.webkit.org/show_bug.cgi?id=64731
1057
1058         Reviewed by Eric Carlson.
1059
1060         * Scripts/build-webkit:
1061
1062 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1063
1064         Emit last progress notification before calling dispatchDidFinishLoad
1065         https://bugs.webkit.org/show_bug.cgi?id=28851
1066
1067         Reviewed by Adam Barth.
1068
1069         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
1070         Chromium and GTK ports. The first two were simple changes.
1071
1072         Some refactoring was needed in GTK port to assure that the dumps are emitted
1073         correctly and the processing after the page load finished is in the right place.
1074
1075         To detect the load finished, we use the callback for the "load-status" notifier
1076         signal of the top loading frame. And we use the deprecated "load-finished" signal
1077         for dumping (if enabled) the progress finished expected output.
1078
1079         * DumpRenderTree/LayoutTestController.cpp:
1080         (LayoutTestController::LayoutTestController):
1081         (dumpProgressFinishedCallbackCallback):
1082         (LayoutTestController::staticFunctions):
1083         * DumpRenderTree/LayoutTestController.h:
1084         (LayoutTestController::dumpProgressFinishedCallback):
1085         (LayoutTestController::setDumpProgressFinishedCallback):
1086         * DumpRenderTree/chromium/LayoutTestController.cpp:
1087         (LayoutTestController::LayoutTestController):
1088         (LayoutTestController::dumpProgressFinishedCallback):
1089         (LayoutTestController::reset):
1090         * DumpRenderTree/chromium/LayoutTestController.h:
1091         (LayoutTestController::shouldDumpProgressFinishedCallback):
1092         (LayoutTestController::setShouldDumpProgressFinishedCallback):
1093         * DumpRenderTree/chromium/WebViewHost.cpp:
1094         (WebViewHost::didStopLoading):
1095         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1096         (webViewLoadFinished):
1097         (topLoadingFrameLoadFinished):
1098         (webFrameLoadStatusNotified):
1099         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1100         (LayoutTestController::reset):
1101         (LayoutTestController::dumpProgressFinishedCallback):
1102         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1103
1104 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
1105
1106         JavaScriptCore does not have a good mechanism for performance
1107         regression testing
1108         https://bugs.webkit.org/show_bug.cgi?id=67177
1109
1110         Reviewed by Darin Adler.
1111         
1112         Added a new script, which allows for testing one, two, or more VMs
1113         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
1114         are interleaved at random to minimize systematics.  The results
1115         that bencher prints includes all possible relevant information about
1116         how bencher was invoked.  Bencher can be easily used to measure
1117         performance changes down to fractions of a percent.
1118         
1119         Bencher also includes experimental support for running benchmarks in
1120         a DumpRenderTree release build.  This works in SunSpider and V8, but
1121         not yet in Kraken.  Running benchmarks in DumpRenderTree more
1122         closely mimics the performance when running in browser.
1123
1124         * Scripts/bencher: Added.
1125
1126 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
1127
1128         DumpRenderTree should begin each test with an empty cookie store
1129         https://bugs.webkit.org/show_bug.cgi?id=63545
1130         <rdar://problem/5666907>
1131
1132         Reviewed by Darin Adler.
1133
1134         * DumpRenderTree/mac/DumpRenderTree.mm:
1135         (resetDefaultsToConsistentValues):
1136         (setDefaultsToConsistentValuesForTesting):
1137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1138         (LayoutTestController::setAlwaysAcceptCookies):
1139         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1140         (WTR::InjectedBundle::beginTesting):
1141         Use new SPIs to manipulate sessions.
1142
1143 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1144
1145         Unreviewed, rolling out r94055 and r94057.
1146         http://trac.webkit.org/changeset/94055
1147         http://trac.webkit.org/changeset/94057
1148         https://bugs.webkit.org/show_bug.cgi?id=67191
1149
1150         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
1151
1152         * Scripts/webkitpy/thirdparty/__init__.py:
1153
1154 2011-08-30  Adam Barth  <abarth@webkit.org>
1155
1156         Chromium Android should not be a core builder
1157         https://bugs.webkit.org/show_bug.cgi?id=67184
1158
1159         Reviewed by Ryosuke Niwa.
1160
1161         This bot hasn't been consistently green yet because it has never actually run!
1162
1163         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1164         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1165
1166 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1167
1168         [WebSocket] update pywebsocket to 0.6b4.
1169         https://bugs.webkit.org/show_bug.cgi?id=66924
1170
1171         Reviewed by Kent Tamura.
1172
1173         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1174         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
1175         0.6b3 or later supports a closing handshake handler and it is useful to
1176         verify client's closing handshake implementation.
1177         0.6b4 supports AbortedByUserException. It is useful to eliminate
1178         unnecessary server warning messages on intended abnormal closures.
1179
1180         * Scripts/webkitpy/thirdparty/__init__.py:
1181         Update download URL and directory path.
1182
1183 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
1184
1185         sheriffbot "usage" help statements are wrong
1186         https://bugs.webkit.org/show_bug.cgi?id=67170
1187
1188         Reviewed by Adam Barth.
1189
1190         * Scripts/webkitpy/tool/bot/irc_command.py:
1191         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1192         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1193
1194 2011-08-29  Adam Barth  <abarth@webkit.org>
1195
1196         Add support for chomium-mac (non-CoreGraphics) baselines
1197         https://bugs.webkit.org/show_bug.cgi?id=67163
1198
1199         Reviewed by Eric Seidel.
1200
1201         This patch teaches the non-CG chromium-mac bots to look at non-CG
1202         baselines.  However, the patch still leaves CG as the default set of
1203         baselines.
1204
1205         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1206         * Scripts/webkitpy/common/config/build.py:
1207         * Scripts/webkitpy/common/config/build_unittest.py:
1208         * Scripts/webkitpy/layout_tests/port/builders.py:
1209         * Scripts/webkitpy/layout_tests/port/chromium.py:
1210         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1211         * Scripts/webkitpy/layout_tests/port/factory.py:
1212         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1213         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1214         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1215         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1216
1217 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
1218
1219         Small fix in chromium port of new-run-webkit-tests.
1220         https://bugs.webkit.org/show_bug.cgi?id=67078
1221
1222         Reviewed by Dirk Pranke.
1223
1224         * Scripts/webkitpy/layout_tests/port/chromium.py:
1225
1226 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1227
1228         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
1229         r93999.
1230         http://trac.webkit.org/changeset/93987
1231         http://trac.webkit.org/changeset/93992
1232         http://trac.webkit.org/changeset/93995
1233         http://trac.webkit.org/changeset/93998
1234         http://trac.webkit.org/changeset/93999
1235         https://bugs.webkit.org/show_bug.cgi?id=67147
1236
1237         Many failing tests (Requested by ap on #webkit).
1238
1239         * DumpRenderTree/mac/DumpRenderTree.mm:
1240         (setDefaultsToConsistentValuesForTesting):
1241         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1242         (WTR::InjectedBundle::beginTesting):
1243
1244 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
1245
1246         DumpRenderTree should begin each test with an empty cookie store
1247         https://bugs.webkit.org/show_bug.cgi?id=63545
1248         <rdar://problem/5666907>
1249
1250         Reviewed by Darin Adler.
1251
1252         * DumpRenderTree/mac/DumpRenderTree.mm:
1253         (setDefaultsToConsistentValuesForTesting):
1254         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1255         (WTR::InjectedBundle::beginTesting):
1256         Tell WebCore to use a temporary session, starting with a clean cookie store.
1257
1258 2011-08-23  Chris Marrin  <cmarrin@apple.com>
1259
1260         [mac] requestAnimationFrame support for mac port
1261         https://bugs.webkit.org/show_bug.cgi?id=59146
1262
1263         Reviewed by Simon Fraser.
1264
1265         Add support for request-animation-callback flag
1266
1267         * Scripts/build-webkit:
1268
1269 2011-08-27  Peter Beverloo  <peter@chromium.org>
1270
1271         Add a build bot for Chromium with OS(ANDROID)
1272         https://bugs.webkit.org/show_bug.cgi?id=66687
1273
1274         Reviewed by Adam Barth.
1275
1276         * BuildSlaveSupport/build.webkit.org-config/config.json:
1277
1278 2011-08-27  Peter Beverloo  <peter@chromium.org>
1279
1280         Update the master build bot configuration script to properly
1281         deal with the --chromium-android switch.
1282         https://bugs.webkit.org/show_bug.cgi?id=66687
1283
1284         The --chromium-android switch is needed when running
1285         update-webkit-chromium and build-webkit, as it'll tell the
1286         scripts to pull in the right dependencies and cross-compile
1287         WebKit using the Android NDK.
1288
1289         Reviewed by Adam Barth.
1290
1291         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1292
1293 2011-08-27  Peter Beverloo  <peter@chromium.org>
1294
1295         Teach the update and build scripts how to handle dependencies
1296         and cross-compiling rules for the Chromium port on OS(ANDROID).
1297         https://bugs.webkit.org/show_bug.cgi?id=66687
1298
1299         Reviewed by Adam Barth.
1300
1301         * Scripts/build-webkit:
1302         * Scripts/update-webkit:
1303         * Scripts/update-webkit-chromium:
1304         * Scripts/webkitdirs.pm:
1305         (argumentsForConfiguration):
1306         (isChromium):
1307         (isChromiumAndroid):
1308         (determineIsChromiumAndroid):
1309         (buildChromium):
1310
1311 2011-08-26  Adam Barth  <abarth@webkit.org>
1312
1313         garden-o-matic should let me know that I need to run the local server
1314         https://bugs.webkit.org/show_bug.cgi?id=66985
1315
1316         Reviewed by Dimitri Glazkov.
1317
1318         The patch triggers an alert dialog whenever the user tries to use a
1319         feature that requires the local server.
1320
1321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1324
1325 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1326
1327         garden-o-matic summary view should have pretty commit data information.
1328         https://bugs.webkit.org/show_bug.cgi?id=67069
1329
1330         Reviewed by Adam Barth.
1331
1332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
1333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
1334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
1336
1337 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1338
1339         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
1340         https://bugs.webkit.org/show_bug.cgi?id=67066
1341
1342         Reviewed by Adam Barth.
1343
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1346
1347 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
1348
1349         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
1350         https://bugs.webkit.org/show_bug.cgi?id=67041
1351
1352         Reviewed by Martin Robinson.
1353
1354         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
1355         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
1356         when the GTK+ port was being built.
1357
1358         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1359
1360 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1361
1362         Clean up and line up layout in garden-o-matic summary view.
1363         https://bugs.webkit.org/show_bug.cgi?id=67057
1364
1365         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
1366         2) Rearranged DOM structure a bit to accommodate recent changes;
1367         3) Added minimal CSS to line things up.
1368
1369         Reviewed by Adam Barth.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
1374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
1375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
1378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
1380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1381
1382 2011-08-26  Alice Liu  <alice.liu@apple.com>
1383
1384         https://bugs.webkit.org/show_bug.cgi?id=66823
1385         Add the request info to the WebPageProxy::CreateNewPage message
1386
1387         Reviewed by Anders Carlsson.
1388
1389         Update function declarations with additional parameter:
1390         * MiniBrowser/gtk/BrowserWindow.c:
1391         (createNewPage):
1392         * MiniBrowser/mac/BrowserWindowController.m:
1393         (createNewPage):
1394         * MiniBrowser/win/BrowserView.cpp:
1395         (createNewPage):
1396         * WebKitTestRunner/TestController.cpp:
1397         (WTR::TestController::createOtherPage):
1398         * WebKitTestRunner/TestController.h:
1399
1400 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
1401
1402         Make show-pretty-diff work on linux
1403         https://bugs.webkit.org/show_bug.cgi?id=67017
1404
1405         Reviewed by Adam Barth.
1406
1407         * Scripts/show-pretty-diff:
1408
1409 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1410
1411         Reorganize garden-o-matic CSS files to match JS-built views.
1412         https://bugs.webkit.org/show_bug.cgi?id=66998
1413
1414         Reviewed by Adam Barth.
1415
1416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
1417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
1419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1422
1423 2011-08-25  Adam Barth  <abarth@webkit.org>
1424
1425         garden-o-matic should be able to roll out patches
1426         https://bugs.webkit.org/show_bug.cgi?id=66982
1427
1428         Reviewed by Dimitri Glazkov.
1429
1430         This patch just wires the rollout event through the controller to the
1431         local server, which is already set up to perform rollouts.
1432
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1437
1438 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1439
1440         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
1441         https://bugs.webkit.org/show_bug.cgi?id=66951
1442
1443         Reviewed by Andreas Kling.
1444
1445         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
1446         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
1447
1448         * MiniBrowser/qt/BrowserView.cpp:
1449         (BrowserView::resizeEvent):
1450
1451 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1452
1453         garden-o-matic summary view should provide information on builders still in flight.
1454         https://bugs.webkit.org/show_bug.cgi?id=66992
1455
1456         Reviewed by Adam Barth.
1457
1458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
1459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1463
1464 2011-08-25  Adam Barth  <abarth@webkit.org>
1465
1466         webkit-patch rebaseline-expectations don't work when run outside the root
1467         https://bugs.webkit.org/show_bug.cgi?id=66966
1468
1469         Reviewed by Eric Seidel.
1470
1471         Turns out tool.path() used to be relative, which caused problems when
1472         running webkit-patch outside the root directory.  This patch makes it
1473         absolute.  I checked all callers, and they all appear to want this
1474         behavior.
1475
1476         It was unclear to me how to test this change because we only really
1477         have a testing strategy for webkitpy, not for the main script.
1478
1479         * Scripts/webkit-patch:
1480
1481 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1482
1483         garden-o-matic summary needs a mock view that could be used for working on styling
1484         https://bugs.webkit.org/show_bug.cgi?id=66971
1485
1486         Reviewed by Adam Barth.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
1489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
1490
1491 2011-08-25  Anders Carlsson  <andersca@apple.com>
1492
1493         Return the correct value for NPNVsupportsCarbonBool
1494         https://bugs.webkit.org/show_bug.cgi?id=66964
1495
1496         Add a test.
1497
1498         Reviewed by Adam Roben.
1499
1500         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1501         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
1502         (SupportsCarbonEventModel::SupportsCarbonEventModel):
1503         (SupportsCarbonEventModel::testConvert):
1504         (SupportsCarbonEventModel::runTest):
1505         (SupportsCarbonEventModel::NPP_New):
1506
1507 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1508
1509         garden-o-matic summary view should not be broken.
1510
1511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1512         (table.comparison): Added more specificity.
1513
1514 2011-08-25  Adam Barth  <abarth@webkit.org>
1515
1516         This command has been broken for a while.  This patch updates the
1517         callsite to the new API.
1518
1519         * Scripts/webkitpy/tool/commands/rebaseline.py:
1520
1521 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1522
1523         garden-o-matic needs a way to report where and how tests are failing in the summary view.
1524         https://bugs.webkit.org/show_bug.cgi?id=66955
1525
1526         Introduce FailureGrid, your one-stop failure-indicating destination. 
1527
1528         Reviewed by Adam Barth.
1529
1530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
1531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
1532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
1533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
1536
1537 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
1538
1539         Add myself to the committers list
1540         https://bugs.webkit.org/show_bug.cgi?id=66941
1541
1542         Reviewed by Andreas Kling.
1543
1544         * Scripts/webkitpy/common/config/committers.py:
1545
1546 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1547
1548         Unreviewed, rolling out r93767.
1549         http://trac.webkit.org/changeset/93767
1550         https://bugs.webkit.org/show_bug.cgi?id=66931
1551
1552         Broke Qt bot. (Requested by yutak on #webkit).
1553
1554         * Scripts/webkitpy/thirdparty/__init__.py:
1555
1556 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
1557
1558         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
1559         https://bugs.webkit.org/show_bug.cgi?id=66924
1560
1561         Reviewed by Kent Tamura.
1562
1563         * Scripts/webkitpy/thirdparty/__init__.py:
1564
1565 2011-08-24  Adam Barth  <abarth@webkit.org>
1566
1567         The user can't close the details view in garden-o-matic
1568         https://bugs.webkit.org/show_bug.cgi?id=66911
1569
1570         Reviewed by Dimitri Glazkov.
1571
1572         In addition to adding a close button, this patch changes the test
1573         selector to use a <select> element and refactors the test selector to
1574         share code with the builder selector.
1575
1576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1580
1581 2011-08-24  James Robinson  <jamesr@chromium.org>
1582
1583         [chromium] Stacktrace not in test output when a test crashes
1584         https://bugs.webkit.org/show_bug.cgi?id=66806
1585
1586         Reviewed by Dirk Pranke.
1587
1588         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
1589         trace.
1590
1591         * Scripts/webkitpy/layout_tests/port/chromium.py:
1592
1593 2011-08-24  Adam Barth  <abarth@webkit.org>
1594
1595         Remove empty directory.
1596
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
1598
1599 2011-08-24  Adam Barth  <abarth@webkit.org>
1600
1601         Finish writing up details-view in garden-o-matic
1602         https://bugs.webkit.org/show_bug.cgi?id=66891
1603
1604         Reviewed by Dimitri Glazkov.
1605
1606         This patch mostly just copies a bunch of CSS from main.css to
1607         summary.css.  Presumably we'll delete main.css soon.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1614
1615 2011-08-24  James Robinson  <jamesr@chromium.org>
1616
1617         Some compositing LayoutTests flakily crashing on Mac 10.6
1618         https://bugs.webkit.org/show_bug.cgi?id=66740
1619
1620         Reviewed by Adam Barth.
1621
1622         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
1623         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
1624         chromium configuration.
1625
1626         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1627         (NPP_Destroy):
1628
1629 2011-08-24  Anton D'Auria  <adauria@apple.com>
1630
1631         No review necessary.
1632
1633         Adding myself to list of committers.
1634
1635         * Scripts/webkitpy/common/config/committers.py:
1636
1637 2011-08-24  Avi Drissman  <avi@google.com>
1638
1639         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
1640         https://bugs.webkit.org/show_bug.cgi?id=66875
1641
1642         Reviewed by James Robinson.
1643
1644         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1645         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1646
1647 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1648
1649         Make notifications appear in time order again.
1650         https://bugs.webkit.org/show_bug.cgi?id=66815
1651
1652         Reviewed by Adam Barth.
1653
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
1656
1657 2011-08-23  James Robinson  <jamesr@chromium.org>
1658
1659         [chromium] Need a way to test lost compositor context recovery
1660         https://bugs.webkit.org/show_bug.cgi?id=66820
1661
1662         Reviewed by Kenneth Russell.
1663
1664         Exposes a LayoutTestController interface in chromium to simulate a
1665         lost compositor context.
1666
1667         * DumpRenderTree/chromium/LayoutTestController.cpp:
1668         (LayoutTestController::LayoutTestController):
1669         (LayoutTestController::loseCompositorContext):
1670         * DumpRenderTree/chromium/LayoutTestController.h:
1671
1672 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1673
1674         Change garden-o-matic frontend builder array to be a configuration map.
1675         https://bugs.webkit.org/show_bug.cgi?id=66816
1676
1677         Reviewed by Adam Barth.
1678
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
1680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
1682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
1684
1685 2011-08-23  Cary Clark  <caryclark@google.com>
1686
1687         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
1688         https://bugs.webkit.org/show_bug.cgi?id=66803
1689
1690         This fixes the WebKit Canaries, in particular avoids a crash on tests
1691         like css1/basic/comments.html.
1692
1693         Reviewed by James Robinson.
1694
1695         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1696         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1697         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
1698         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
1699         and treated it as if it were a CGContextRef.
1700
1701 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1702
1703         Fix mergeChangeLogs test on native windows
1704         https://bugs.webkit.org/show_bug.cgi?id=66797
1705
1706         Reviewed by Adam Roben.
1707
1708         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
1709         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
1710
1711         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1712         (writeTempFile):
1713
1714 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1715
1716         garden-o-matic relative time is wrong and updates too frequently.
1717         https://bugs.webkit.org/show_bug.cgi?id=66802
1718
1719         Reviewed by Adam Barth.
1720
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
1722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
1723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
1724
1725 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1726
1727         Add missing quotes around filenames in mergeChangeLogs
1728         https://bugs.webkit.org/show_bug.cgi?id=66794
1729
1730         Reviewed by Adam Roben.
1731
1732         * Scripts/VCSUtils.pm:
1733         (mergeChangeLogs):
1734
1735 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1736
1737         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
1738         https://bugs.webkit.org/show_bug.cgi?id=49080
1739
1740         Reviewed by Adam Roben.
1741
1742         Use the string form of pipe open instead (like we do at all other places).
1743
1744         * Scripts/VCSUtils.pm:
1745         (mergeChangeLogs):
1746
1747 2011-08-23  Adam Barth  <abarth@webkit.org>
1748
1749         garden-o-matic summary should be able to examine failures
1750         https://bugs.webkit.org/show_bug.cgi?id=66748
1751
1752         Reviewed by Dimitri Glazkov.
1753
1754         This patch refactors a bunch of code from summary.js to independent
1755         controllers in controllers.js.  This patch also contains the first
1756         iteration of binding the "examine" event to a the behavior showing the
1757         details view for the tests.  There's more work to do here to make this
1758         work properly (and elegantly), but this patch is a start.
1759
1760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1769
1770 2011-08-23  Adam Barth  <abarth@webkit.org>
1771
1772         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
1773         https://bugs.webkit.org/show_bug.cgi?id=66737
1774
1775         Reviewed by Steve Block.
1776
1777         This directory doesn't exist anymore now that the Android port shares
1778         more code with Chromium.
1779
1780         * Scripts/webkitpy/common/config/build.py:
1781
1782 2011-08-22  Eric Seidel  <eric@webkit.org>
1783
1784         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
1785         I won't have ssh access to the bot again for a couple days, so
1786         attempting to fix by changing this script.  If this doesn't
1787         work we'll just live with the it hung for now.
1788
1789         Unreviewed.
1790
1791         * EWSTools/start-queue.sh:
1792
1793 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1794
1795         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
1796         https://bugs.webkit.org/show_bug.cgi?id=66727
1797
1798         Reviewed by Adam Barth.
1799
1800         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
1801             in which case the serializer treats all expectations as unparsed.
1802         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
1803
1804 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1805
1806         Update unit test expectations after r93530.
1807
1808         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
1809         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1810
1811 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1812
1813         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
1814         https://bugs.webkit.org/show_bug.cgi?id=66705
1815
1816         Reviewed by Adam Barth.
1817
1818         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
1819         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
1820
1821 2011-08-22  James Robinson  <jamesr@chromium.org>
1822
1823         [chromium] Update builder names for chromium gpu bots due to CG switchover
1824         https://bugs.webkit.org/show_bug.cgi?id=66693
1825
1826         Reviewed by Dirk Pranke.
1827
1828         Update the port and builder names for the chromium mac gpu bots to
1829         account for the CG transition.
1830
1831         * Scripts/webkitpy/layout_tests/port/builders.py:
1832
1833 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
1834
1835         fix the GPU bot names on the layout test dashboard
1836         https://bugs.webkit.org/show_bug.cgi?id=66697
1837
1838         Reviewed by Dimitri Glazkov.
1839
1840         * TestResultServer/static-dashboards/builders.js:
1841
1842 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1843
1844         garden-o-matic's relative time display should be updated regularly.
1845         https://bugs.webkit.org/show_bug.cgi?id=66682
1846
1847         Reviewed by Adam Barth.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
1850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
1851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
1852
1853 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1854
1855         Pass --makeargs of build-webkit to chromium linux builder
1856         https://bugs.webkit.org/show_bug.cgi?id=66361
1857
1858         Reviewed by Tony Chang.
1859
1860         * Scripts/build-webkit:
1861         * Scripts/webkitdirs.pm:
1862         (buildChromiumMakefile):
1863         (buildChromium):
1864
1865 2011-08-22  Peter Beverloo  <peter@chromium.org>
1866
1867         Add myself to the contributor list.
1868         https://bugs.webkit.org/show_bug.cgi?id=66674
1869
1870         Reviewed by Tony Gentilcore.
1871
1872         * Scripts/webkitpy/common/config/committers.py:
1873
1874 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
1875
1876         [Qt] ImageDiff does not consider --tolerance
1877         https://bugs.webkit.org/show_bug.cgi?id=66299
1878
1879         Reviewed by Csaba Osztrogonác.
1880
1881         * DumpRenderTree/qt/ImageDiff.cpp:
1882         (main):
1883
1884 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
1885
1886         Update contributor list.
1887
1888         Reviewed by Zoltan Herczeg.
1889
1890         * Scripts/webkitpy/common/config/committers.py:
1891
1892 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1893
1894         [ORWT] Fix --reset-results --add-platform-exceptions combo
1895         https://bugs.webkit.org/show_bug.cgi?id=65464
1896
1897         Reviewed by Csaba Osztrogonác.
1898
1899         * Scripts/old-run-webkit-tests:
1900
1901 2011-08-20  Adam Barth  <abarth@webkit.org>
1902
1903         garden-o-matic summary.html should have UI for examining failures
1904         https://bugs.webkit.org/show_bug.cgi?id=66625
1905
1906         Reviewed by Dimitri Glazkov.
1907
1908         This patch introduces the notion of UI actions and converts our
1909         existing manual <button> manipulation with this new abstraction.  The
1910         patch also adds an Examine button to failure notifications.  In a
1911         future patch, I'll add a controller that wires this button up to
1912         something useful.
1913
1914         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
1917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
1918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1922
1923 2011-08-20  Adam Barth  <abarth@webkit.org>
1924
1925         garden-o-matic summary page should indiciate compile failures
1926         https://bugs.webkit.org/show_bug.cgi?id=66624
1927
1928         Reviewed by Dimitri Glazkov.
1929
1930         This patch creates a notification-based UI for build failures.  The new
1931         UI displays the same information that used to be displayed in the
1932         infobar.  There's lots of room for improvement in surfacing more
1933         information, but this is a start.
1934
1935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1938
1939 2011-08-19  James Robinson  <jamesr@chromium.org>
1940
1941         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
1942         https://bugs.webkit.org/show_bug.cgi?id=66606
1943
1944         Reviewed by Dirk Pranke.
1945
1946         The chromium GPU configuration does not (currently) contain any tests
1947         incompatible with --experimental-fully-parallel, and this flag is a
1948         significan speedup because of the directory canvas/philip/tests which
1949         contains 802 tests in the same directory. Setting this option by
1950         default on this configuration is a 2x speed in release, 44s to 22s,
1951         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
1952
1953         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1954         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1955         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1956
1957 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1958
1959         Unreviewed, rolling out r93426.
1960         http://trac.webkit.org/changeset/93426
1961         https://bugs.webkit.org/show_bug.cgi?id=66607
1962
1963         Broke the Mac build by not building gtest.framework anymore
1964         (Requested by andersca on #webkit).
1965
1966         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1967
1968 2011-08-19  James Robinson  <jamesr@chromium.org>
1969
1970         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
1971         https://bugs.webkit.org/show_bug.cgi?id=66603
1972
1973         Reviewed by Dirk Pranke.
1974
1975         The various ChromiumGpu ports should use the same child worker
1976         selection logic as other ports so they can run with full
1977         parallelization on multicore systems.
1978
1979         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1980         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1981
1982 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
1983
1984         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
1985         https://bugs.webkit.org/show_bug.cgi?id=66570
1986
1987         Reviewed by Mihai Parparita.
1988
1989         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1990         (WebThemeControlDRTWin::draw):
1991         (WebThemeControlDRTWin::drawTextField):
1992         (WebThemeControlDRTWin::drawProgressBar):
1993         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1994
1995 2011-08-18  Dmitry Lomov  <dslomov@google.com>
1996
1997         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
1998         https://bugs.webkit.org/show_bug.cgi?id=66521
1999
2000         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
2001
2002         Reviewed by David Levin.
2003
2004         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
2005
2006 2011-08-19  Adam Roben  <aroben@apple.com>
2007
2008         Add project file changes I left out in r93417
2009
2010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2011
2012 2011-08-19  Adam Roben  <aroben@apple.com>
2013
2014         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
2015
2016         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
2017         NSScreen
2018
2019         Reviewed by Anders Carlsson.
2020
2021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2022
2023         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2024         (-[SimpleObject setValue:]): Original implementation.
2025
2026         (TestWebKitAPI::setValue2):
2027         (TestWebKitAPI::setValue3):
2028         Swizzled implementations.
2029
2030         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
2031         instance method.
2032
2033         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
2034         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2035         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
2036         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
2037
2038 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
2039
2040         Fix _path_to_apache() error reporting
2041         https://bugs.webkit.org/show_bug.cgi?id=66486
2042
2043         Reviewed by Ryosuke Niwa.
2044
2045         * Scripts/webkitpy/layout_tests/port/webkit.py:
2046
2047 2011-08-19  Adam Roben  <aroben@apple.com>
2048
2049         Windows build fix after r93404
2050
2051         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
2052
2053 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
2054
2055         Add leandrogracia to the committers list
2056         https://bugs.webkit.org/show_bug.cgi?id=66552
2057
2058         Also fix line endings in file.
2059
2060         No reviewed required.
2061
2062         * Scripts/webkitpy/common/config/committers.py:
2063
2064 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
2065
2066         Fix compilation issue in WebKitTestRunner
2067         https://bugs.webkit.org/show_bug.cgi?id=66554
2068
2069         Reviewed by Martin Robinson.
2070
2071         * WebKitTestRunner/PixelDumpSupport.cpp:
2072
2073 2011-08-19  Adam Roben  <aroben@apple.com>
2074
2075         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
2076
2077         This will make it easier to write other WebKit-agnostic tests
2078
2079         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
2080         code in other WebKit-agnostic tests
2081
2082         Reviewed by Anders Carlsson.
2083
2084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2085
2086         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
2087         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
2088         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
2089         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
2090         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
2091         WebKitAgnosticTest handles for us.
2092         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
2093
2094         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
2095         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
2096         DynamicDeviceScaleFactor::runTest.
2097
2098         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
2099         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
2100         DynamicDeviceScaleFactor.WebKit.
2101         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
2102         DynamicDeviceScaleFactor.WebKit2.
2103
2104 2011-08-19  Adam Roben  <aroben@apple.com>
2105
2106         Clean up #includes in TestWebKitAPI
2107
2108         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
2109
2110         Reviewed by Anders Carlsson.
2111
2112         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
2113         files and WebKit/WebKit.h for ObjC files.
2114
2115         * TestWebKitAPI/InjectedBundleController.cpp:
2116         * TestWebKitAPI/JavaScriptTest.h:
2117         * TestWebKitAPI/PlatformUtilities.h:
2118         * TestWebKitAPI/PlatformWebView.h:
2119         * TestWebKitAPI/Test.h:
2120         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2121         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2122         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2123         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2124         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2125         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2126         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2127         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2128         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2129         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2130         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2131         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2132         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2133         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2134         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2135         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2136         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2137         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2138         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2139         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2140         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2141         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2142         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2143         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2144         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2145         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2146         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2147         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2148         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2149         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2150         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2151         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2152         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2153         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2154         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2155         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2156         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2157         * TestWebKitAPI/TestsController.cpp:
2158         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2159         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
2160         #includes since it is no longer a special header.
2161
2162 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
2163
2164         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
2165         https://bugs.webkit.org/show_bug.cgi?id=64886
2166
2167         Temporarily disable the http locking to work around the issue.
2168         I'm not actually sure if this is going to work or improve things
2169         much.
2170
2171         Reviewed by Ryosuke Niwa.
2172
2173         * Scripts/webkitpy/layout_tests/port/mac.py:
2174
2175 2011-08-18  Tony Chang  <tony@chromium.org>
2176
2177         add embedded png checksums to WebKitTestRunner
2178         https://bugs.webkit.org/show_bug.cgi?id=66494
2179
2180         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
2181         some code from DRT and adds it to the WebKitTestRunner.
2182
2183         Reviewed by Darin Adler.
2184
2185         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
2186         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
2187         * WebKitTestRunner/GNUmakefile.am: Add new files
2188         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
2189         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
2190         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
2191         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2192         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2193         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2194         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2195         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2196         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2197         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
2198
2199 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
2200
2201         https://bugs.webkit.org/show_bug.cgi?id=47240
2202
2203         Fixed a cygwin path problem in the chromium port of diff_image;
2204         Also made the return values of the diff_image function more consistent.
2205
2206         Reviewed by Dirk Pranke.
2207
2208         * Scripts/webkitpy/layout_tests/port/chromium.py:
2209
2210 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
2211
2212         [GTK] Fix compilation problems with deprecations in gtk+
2213         https://bugs.webkit.org/show_bug.cgi?id=66073
2214
2215         Reviewed by Martin Robinson.
2216
2217         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2218         (main): G_CONST_RETURN was deprecated
2219         * GtkLauncher/main.c:
2220         (createWindow): Added gtk_box_new conditional compilation for
2221         gtk+-3.
2222         * MiniBrowser/gtk/BrowserWindow.c:
2223         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
2224         are just supporting gtk+-3 for WebKit2.
2225
2226 2011-08-18  Anders Carlsson  <andersca@apple.com>
2227
2228         Fix libc++ C++0x build
2229         https://bugs.webkit.org/show_bug.cgi?id=66479
2230
2231         Reviewed by Adam Roben.
2232
2233         Add missing includes.
2234
2235         * DumpRenderTree/LayoutTestController.cpp:
2236         * DumpRenderTree/mac/CheckedMalloc.cpp:
2237
2238 2011-08-18  Adam Roben  <aroben@apple.com>
2239
2240         Test that WebKit updates style when a WebView is moved between differently-scaled windows
2241
2242         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2243         WebView is moved between windows with different backing scale factors
2244
2245         Reviewed by Anders Carlsson.
2246
2247         * TestWebKitAPI/JavaScriptTest.cpp:
2248         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
2249         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
2250         gtest's built-in error messages.
2251
2252         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
2253         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
2254         those overloads.
2255
2256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2257
2258         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
2259         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
2260         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
2261         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
2262         (TestWebKitAPI::setPageLoaderClient): Set up the client.
2263         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
2264         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
2265         SyntheticBackingScaleFactorWindow and returns it.
2266         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
2267         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
2268         window, is moved to a differently-scaled window, and is taken out of the window.
2269         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
2270         WebKit1 and WebKit2.
2271         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
2272
2273         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
2274
2275         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
2276         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
2277
2278         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
2279         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
2280         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
2281         initializer.
2282         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
2283
2284         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
2285         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
2286         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
2287
2288 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=66425
2291         check-webkit-style should detect incorrectly formatted file change descriptions.
2292         Description, if present, should be separated from colon with a space.
2293
2294         Reviewed by David Levin.
2295
2296         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
2297         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
2298
2299 2011-08-18  Adam Barth  <abarth@webkit.org>
2300
2301         webkit-patch pretty-diff should be shown in main help
2302         https://bugs.webkit.org/show_bug.cgi?id=66404
2303
2304         Reviewed by Dimitri Glazkov.
2305
2306         As requested by dglazkov.
2307
2308         * Scripts/webkitpy/tool/commands/prettydiff.py:
2309
2310 2011-08-17  Dmitry Lomov  <dslomov@google.com>
2311
2312         https://bugs.webkit.org/show_bug.cgi?id=66400
2313         Fix TestWebKitAPI build on Mac OS.
2314
2315         Reviewed by David Levin.
2316
2317         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
2318
2319 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2320
2321         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
2322         https://bugs.webkit.org/show_bug.cgi?id=66427
2323
2324         Reviewed by Adam Barth.
2325
2326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
2327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
2328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
2329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
2330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
2331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
2336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
2339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
2340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
2341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
2343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
2352         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
2353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
2354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
2355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
2356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
2357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
2360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
2375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
2418         ():
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
2421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
2425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
2439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
2440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
2441
2442 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
2443
2444         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
2445         https://bugs.webkit.org/show_bug.cgi?id=65877
2446
2447         Reviewed by Eric Seidel.
2448
2449         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2450
2451 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2452
2453         Remove base.keys and replace it with Object.keys.
2454         https://bugs.webkit.org/show_bug.cgi?id=66422
2455
2456         Reviewed by Adam Barth.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
2461
2462 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2463
2464         garden-o-matic Summary view should have items in descending chronological order.
2465         https://bugs.webkit.org/show_bug.cgi?id=66403
2466
2467         Reviewed by Adam Barth.
2468
2469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
2472
2473 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2474
2475         Fix a few errors in garden-o-matic frontend unit tests.
2476         https://bugs.webkit.org/show_bug.cgi?id=66421
2477
2478         Reviewed by Adam Barth.
2479
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
2483
2484 2011-08-17  Adam Barth  <abarth@webkit.org>
2485
2486         Update Tools to account for (CG) being added to Chromium builder names
2487         https://bugs.webkit.org/show_bug.cgi?id=66410
2488
2489         Reviewed by Adam Barth.
2490
2491         Some of these names will change back once we turn on Skia bots.
2492
2493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2496         * Scripts/webkitpy/layout_tests/port/builders.py:
2497         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2498         * TestResultServer/static-dashboards/builders.js:
2499         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2500
2501 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2502
2503         Wire up relative time to garden-o-matic summary view.
2504         https://bugs.webkit.org/show_bug.cgi?id=66343
2505
2506         Reviewed by Adam Barth.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
2513
2514 2011-08-17  Adam Roben  <aroben@apple.com>
2515
2516         Make run-api-tests run tests in alphabetical order
2517
2518         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
2519
2520         Reviewed by David Kilzer.
2521
2522         * Scripts/run-api-tests:
2523         (runAllTests):
2524         (runAllTestsInSuite):
2525         Sort the lists of tests and suites before iterating over them.
2526
2527 2011-08-17  Adam Barth  <abarth@webkit.org>
2528
2529         garden-o-matic should be able to rebaseline expected failures
2530         https://bugs.webkit.org/show_bug.cgi?id=66204
2531
2532         Reviewed by Dimitri Glazkov.
2533
2534         This patch introduces a new view for displaying expect, actual, and
2535         differences between results.  The new view also has a fledgling
2536         controller that handles some basic operations.  The new view is
2537         exercised by rebaseline.html, which lets you rebaselines expected
2538         failures, but the new view is not fully integrated into
2539         garden-o-matic.html
2540
2541         More patches will be required to make this stuff fully working, but
2542         this patch was already somewhat spiraling out of control.  Hopefully
2543         this patch will serve as a good starting point for further development.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
2546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
2548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
2556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
2557
2558 2011-08-16  Chang Shu  <cshu@webkit.org>
2559
2560         Support reset in WebCore::Internals
2561         https://bugs.webkit.org/show_bug.cgi?id=66307
2562
2563         Reviewed by Dimitri Glazkov.
2564
2565         Added call to resetInternalsObject in DRT.
2566
2567         * DumpRenderTree/chromium/TestShell.cpp:
2568         (TestShell::resetTestController):
2569         * DumpRenderTree/mac/DumpRenderTree.mm:
2570         (resetWebViewToConsistentStateBeforeTesting):
2571         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2572         (WebCore::WebPage::resetSettings):
2573
2574 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
2575
2576         Add a new build slave for the Qt port on Mac OS SnowLeopard.
2577         https://bugs.webkit.org/show_bug.cgi?id=66392
2578
2579         Modify the config file to include the new build slave.
2580
2581         Reviewed by Adam Roben.
2582
2583         * BuildSlaveSupport/build.webkit.org-config/config.json:
2584
2585 2011-08-17  Sam White  <samuel.white@rochester.edu>
2586
2587         AccessibilityObject levels are inconsistent
2588         https://bugs.webkit.org/show_bug.cgi?id=66180
2589         
2590         Added the ability to get numeric attribute values using numberAttributeValue. This
2591         function complements the existing stringAttributeValue and boolAttributeValue functions.
2592         The addition of numberAttributeValue was necessary because the stringAttributeValue
2593         function does a type check and will only return strings. This limitation made it
2594         impossible to get values for attributes that returned an NSNumber.
2595
2596         Reviewed by Chris Fleizach.
2597
2598         * DumpRenderTree/AccessibilityUIElement.cpp:
2599         (numberAttributeValueCallback):
2600         (AccessibilityUIElement::getJSClass):
2601         * DumpRenderTree/AccessibilityUIElement.h:
2602         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2603         (AccessibilityUIElement::numberAttributeValue):
2604         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2605         (AccessibilityUIElement::numberAttributeValue):
2606         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2607         (AccessibilityUIElement::numberAttributeValue):
2608
2609 2011-08-17  Adam Roben  <aroben@apple.com>
2610
2611         Tell Trac logs always to display all specified revisions in a single page
2612
2613         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
2614         revisions than that.
2615
2616         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
2617         relevant revisions
2618
2619         Reviewed by Daniel Bates.
2620
2621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2622         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
2623         a single page.
2624
2625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
2627         Updated tests for the above.
2628
2629 2011-08-17  Adam Roben  <aroben@apple.com>
2630
2631         Fix TestFailures's link to file a bug about TestFailures itself
2632
2633         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
2634         bug about itself is broken
2635
2636         Reviewed by Dan Bates.
2637
2638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2639         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
2640         the host from the path.
2641
2642 2011-08-17  Adam Roben  <aroben@apple.com>
2643
2644         Teach TestFailures to ignore unbelievably short test runs
2645
2646         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
2647         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
2648
2649         Reviewed by Dan Bates.
2650
2651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2652         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
2653         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
2654         that caused it not to run any tests at all (as happened for a while due to
2655         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
2656
2657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2658         Test for the above.
2659
2660         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2661         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
2662
2663 2011-08-16  Adam Barth  <abarth@webkit.org>
2664
2665         Add a CG qualifier similar to the GPU qualifier
2666         https://bugs.webkit.org/show_bug.cgi?id=66359
2667
2668         Reviewed by Eric Seidel.
2669
2670         Once we have a Skia configuration on Chromium Mac, we'll use this CG
2671         qualifier to note that expectations apply only to the CG configuration.
2672
2673         * Scripts/webkitpy/layout_tests/port/chromium.py:
2674         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2675
2676 2011-08-16  Eric Seidel  <eric@webkit.org>
2677
2678         REGRESSION(92717): WinPort needs to parse version information from port_name
2679         https://bugs.webkit.org/show_bug.cgi?id=66325
2680
2681         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
2682
2683         * Scripts/webkitpy/layout_tests/port/mac.py:
2684         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2685
2686 2011-08-16  Adam Barth  <abarth@webkit.org>
2687
2688         Change webkit-patch analyze-baselines to print in a more unix-friendly way
2689         https://bugs.webkit.org/show_bug.cgi?id=66349
2690
2691         Reviewed by James Robinson.
2692
2693         As requested by jamesr.
2694
2695         * Scripts/webkitpy/tool/commands/rebaseline.py:
2696
2697 2011-08-16  Eric Seidel  <eric@webkit.org>
2698
2699         REGRESSION(92717): WinPort needs to parse version information from port_name
2700         https://bugs.webkit.org/show_bug.cgi?id=66325
2701
2702         Reviewed by Adam Barth.
2703
2704         WinPort didn't have any port_name parsing logic.
2705         Seemed it was best to just share the logic from MacPort.
2706         Sharing the logic from MacPort seemed easiest with a shared superclass.
2707         Once I created ApplePort (the superclass) there was a bunch of logic to share.
2708         I found LeakDetector was just in the way when switching back and forth
2709         between win.py and mac.py so I moved it into its own file.
2710
2711         The only logic change here is that WinPort should now be
2712         able to parse port_name values like MacPort (and other ports)
2713         can.  The fact that ports do this in their constructors is
2714         wrong and a source of many bugs.  But at least now WinPort
2715         matches the status-quo.
2716
2717         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
2718         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
2719         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
2720         * Scripts/webkitpy/layout_tests/port/mac.py:
2721         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2722         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2723         * Scripts/webkitpy/layout_tests/port/win.py:
2724         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2725
2726 2011-08-16  Adam Barth  <abarth@webkit.org>
2727
2728         Add webkit-patch analyze-baselines, as requested by jamesr.
2729
2730         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2731         * Scripts/webkitpy/tool/commands/rebaseline.py:
2732
2733 2011-08-16  Adam Barth  <abarth@webkit.org>
2734
2735         Fold bulk-optimize-baselines into optimize-baselines
2736         https://bugs.webkit.org/show_bug.cgi?id=66345
2737
2738         Reviewed by James Robinson.
2739
2740         bulk-optimize-baselines is now a superset of optimize-baselines, so
2741         they can be combined.
2742
2743         * Scripts/webkitpy/tool/commands/rebaseline.py:
2744
2745 2011-08-16  Adam Barth  <abarth@webkit.org>
2746
2747         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
2748         https://bugs.webkit.org/show_bug.cgi?id=66334
2749
2750         Reviewed by Tony Chang.
2751
2752         This patch moves us closer to switching the Chromium port from
2753         CoreGraphics to Skia.  This patch teaches our tools that the current
2754         Chromium Mac configuration is actually chromium-cg-mac, which makes
2755         room for a future chromium-mac configuration that uses Skia.
2756
2757         Shortly after this patch lands, I'll do a server-side move of the
2758         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
2759         and chromium-cg-mac-leopard.
2760
2761         * BuildSlaveSupport/build.webkit.org-config/config.json:
2762         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2763         * Scripts/webkitpy/common/config/build.py:
2764         * Scripts/webkitpy/common/config/build_unittest.py:
2765         * Scripts/webkitpy/layout_tests/port/base.py:
2766         * Scripts/webkitpy/layout_tests/port/builders.py:
2767         * Scripts/webkitpy/layout_tests/port/chromium.py:
2768         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2769         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2770         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2771         * Scripts/webkitpy/layout_tests/port/factory.py:
2772         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2773         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2774         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2775         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2776         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2777         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2778         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2779
2780 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2781
2782         garden-o-matic frontend needs a friendly relative time description method.
2783         https://bugs.webkit.org/show_bug.cgi?id=66324
2784
2785         Reviewed by Adam Barth.
2786
2787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
2789         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
2790
2791 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2792
2793         Summary view should not add multiple entries for the same test failure.
2794         https://bugs.webkit.org/show_bug.cgi?id=66318
2795
2796         Reviewed by Adam Barth.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
2800             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
2801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2802
2803 2011-08-16  Adam Roben  <aroben@apple.com>
2804
2805         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
2806
2807         The basic strategy here is that once a test has failed or passed many times in a row we
2808         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
2809         in many fewer false positives than our current behavior.
2810
2811         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
2812         flaky, including tests that failed for a while but then were fixed
2813
2814         Reviewed by Dan Bates.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
2817         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
2818         number of non-too-many-failure builds we've seen.
2819         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
2820         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
2821         tests, keep track of how many times they have passed or failed in a row. If they pass or
2822         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
2823         considered flaky it doesn't matter how many times it passes or fails.)
2824
2825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
2826         Added tests for the above.
2827
2828 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2829
2830         garden-o-matic needs a summary view with actions for each problem.
2831         https://bugs.webkit.org/show_bug.cgi?id=66144
2832
2833         Reviewed by Adam Barth.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
2836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
2837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
2838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
2839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
2841
2842 2011-08-16  Dean Jackson  <dino@apple.com>
2843
2844         Adding Ted "hober" O'Connor as a non-committing contributor.
2845
2846         * Scripts/webkitpy/common/config/committers.py:
2847
2848 2011-08-16  Adam Roben  <aroben@apple.com>
2849
2850         Teach TestFailures how to interpret unfinished test runs
2851
2852         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
2853         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
2854
2855         Reviewed by David Kilzer.
2856
2857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2858         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
2859         rather than "isStarted" so that we don't count builds for which the test run never finished.
2860         Bumped the cache version to evict old, buggy cached data.
2861
2862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2863         Added a test for the above, and made a somewhat synthetic test more realistic by including
2864         more of the actual JSON data from build.webkit.org.
2865
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2867         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
2868         cached data.
2869
2870 2011-08-16  Adam Roben  <aroben@apple.com>
2871
2872         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
2873
2874         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
2875         should match Lion's behavior.
2876
2877         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
2878         but doesn't use Lion results
2879
2880         Reviewed by David Kilzer.
2881
2882         * Scripts/old-run-webkit-tests:
2883         (expectedDirectoryForTest):
2884         * Scripts/webkitpy/layout_tests/port/win.py:
2885         (WinPort.baseline_search_path):
2886         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2887         (WinPortTest.test_baseline_search_path):
2888         Replaced mac-snowleopard with mac-lion.
2889
2890         * Scripts/webkitpy/common/config/build.py:
2891         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
2892         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
2893         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
2894         will no longer look there for results.
2895
2896         * Scripts/webkitpy/common/config/build_unittest.py:
2897         (ShouldBuildTest.test_should_build): Tests for the above changes.
2898
2899 2011-08-16  Dean Jackson  <dino@apple.com>
2900
2901         Move me from contributor to reviewer.
2902
2903         * Scripts/webkitpy/common/config/committers.py:
2904
2905 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2906
2907         garden-o-matic frontend needs model.commitDataForRevisionRange function.
2908         https://bugs.webkit.org/show_bug.cgi?id=66252
2909
2910         Reviewed by Adam Barth.
2911
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
2913         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
2914
2915 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2916
2917         garden-o-matic frontend needs a generic way to track updates.
2918         https://bugs.webkit.org/show_bug.cgi?id=66245
2919
2920         Reviewed by Adam Barth.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
2923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2924
2925 2011-08-15  Adam Roben  <aroben@apple.com>
2926
2927         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
2928
2929         Failures now give output of the form: foo should be bar but is baz
2930
2931         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
2932         test is in TestWebKitAPI's output
2933
2934         Reviewed by David Levin.
2935
2936         * TestWebKitAPI/JavaScriptTest.cpp:
2937         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
2938         members.
2939         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
2940         object, rather than doing any testing of it here.
2941         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
2942         to use a pretty error message when the test fails.
2943
2944         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
2945         gtest-style macros that wrap it.
2946
2947         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
2948
2949         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2950         (TestWebKitAPI::TEST): Changed to use the new macros.
2951
2952         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2953         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
2954         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
2955         the test passes, though. Returning early seems to have been an unnecessary optimization.
2956
2957         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2958         (TestWebKitAPI::TEST): Changed to use the new macros.
2959
2960 2011-08-15  Eric Seidel  <eric@webkit.org>
2961
2962         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
2963
2964         Unreviewed.
2965
2966         * Scripts/run-webkit-tests:
2967         (usingLeaks):
2968         (useNewRunWebKitTests):
2969
2970 2011-08-14  Adam Barth  <abarth@webkit.org>
2971
2972         Switch results detail view over to new-style object-oriented UI widgets
2973         https://bugs.webkit.org/show_bug.cgi?id=66200
2974
2975         Reviewed by Dimitri Glazkov.
2976
2977         This patch replaces my goofy template-based UI for the results
2978         comparison screen with new object-oriented UI widgets.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
2986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2987
2988 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
2989
2990         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
2991         https://bugs.webkit.org/show_bug.cgi?id=66166
2992
2993         Also changed base.RequestTracker to:
2994         a) fire callback immediately if requestsInFlight is 0;
2995         b) not barf if callback is not supplied.
2996
2997         Reviewed by Adam Barth.
2998
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
3003
3004 2011-08-12  Mark Rowe  <mrowe@apple.com>
3005
3006         Be more forward-looking in the choice of compiler.
3007
3008         Rubber-stamped by Jon Honeycutt.
3009
3010         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3011         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
3012         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
3013         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3014
3015 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3016
3017         DRT: Add support for gesture events.
3018         https://bugs.webkit.org/show_bug.cgi?id=66105
3019
3020         Reviewed by Darin Fisher.
3021
3022         * DumpRenderTree/chromium/EventSender.cpp:
3023         (EventSender::EventSender):
3024         (EventSender::gestureScrollBegin):
3025         (EventSender::gestureScrollEnd):
3026         (EventSender::gestureTap):
3027         (EventSender::gestureEvent):
3028         * DumpRenderTree/chromium/EventSender.h:
3029
3030 2011-08-12  Andy Estes  <aestes@apple.com>
3031
3032         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
3033         https://bugs.webkit.org/show_bug.cgi?id=66158
3034
3035         Reviewed by Dan Bernstein.
3036
3037         * DumpRenderTree/LayoutTestController.cpp:
3038         (allowRoundingHacksCallback): The third argument is the 'this'
3039         JSObjectRef, not the second.
3040
3041 2011-08-12  Andy Estes  <aestes@apple.com>
3042
3043         Cancel in onbeforeunload dialog sometime causes a button to stop working.
3044         https://bugs.webkit.org/show_bug.cgi?id=26211
3045
3046         Reviewed by Alexey Proskuryakov.
3047
3048         Implement a new LayoutTestController method that a test can call to set
3049         the return value of DumpRenderTree's beforeunload UI delegate.
3050
3051         * DumpRenderTree/LayoutTestController.cpp:
3052         (LayoutTestController::LayoutTestController): Initialize
3053         m_shouldStayOnPageAfterHandlingBeforeUnload.
3054         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
3055         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
3056         (LayoutTestController::staticFunctions): Register
3057         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
3058         * DumpRenderTree/LayoutTestController.h: 
3059         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3060         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3061         * DumpRenderTree/chromium/LayoutTestController.cpp:
3062         (LayoutTestController::LayoutTestController): Initialize
3063         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
3064         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
3065         (LayoutTestController::reset): Reset
3066         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
3067         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3068         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
3069         from JavaScript.
3070         * DumpRenderTree/chromium/LayoutTestController.h:
3071         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3072         * DumpRenderTree/chromium/WebViewHost.cpp:
3073         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
3074         return the inverse of
3075         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
3076         * DumpRenderTree/mac/UIDelegate.mm:
3077         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
3078         * DumpRenderTree/win/UIDelegate.cpp:
3079         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3080         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3081         Define setShouldStayOnPageAfterHandlingBeforeUnload().
3082         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3083         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
3084         to the Test Controller telling it what value it should return in its
3085         onbeforeunload UI delegate.
3086         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3087         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3088         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3089         Call InjectedBundle::postNewBeforeUnloadReturnValue().
3090         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3091         * WebKitTestRunner/TestController.cpp:
3092         (WTR::TestController::TestController): Initialize
3093         m_beforeUnloadReturnValue to true.
3094         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
3095         the value of TestController::beforeUnloadReturnValue().
3096         (WTR::TestController::resetStateToConsistentValues): Reset
3097         m_beforeUnloadReturnValue to true.
3098         * WebKitTestRunner/TestController.h:
3099         (WTR::TestController::beforeUnloadReturnValue):
3100         (WTR::TestController::setBeforeUnloadReturnValue):
3101         * WebKitTestRunner/TestInvocation.cpp:
3102         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
3103         message posted from the injected bundle by retrieving the message body
3104         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
3105
3106 2011-08-12  Sam Weinig  <sam@webkit.org>
3107
3108         Move compiler specific macros to their own header
3109         https://bugs.webkit.org/show_bug.cgi?id=66119
3110
3111         Reviewed by Anders Carlsson.
3112
3113         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
3114
3115 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3116
3117         Add a way to extend DOM objects in garden-o-matic.
3118         https://bugs.webkit.org/show_bug.cgi?id=66096
3119
3120         Reviewed by Adam Barth.
3121
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
3123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
3124
3125 2011-08-11  MORITA Hajime  <morrita@google.com>
3126
3127         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
3128         https://bugs.webkit.org/show_bug.cgi?id=45438
3129
3130         Reviewed by Kent Tamura.
3131
3132         MockSpellCheck was assuming the input of spellCheckWord() is a word.
3133         But it can be a series of word. This change made spellCheckWord()
3134         understand simple word boundary which appears in tests.
3135         
3136         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3137         (MockSpellCheck::spellCheckWord):
3138
3139 2011-08-11  Mark Rowe  <mrowe@apple.com>
3140
3141         Rework some Makefile logic to remove a double-negative.
3142
3143         Reviewed by Jon Honeycutt.
3144
3145         * DumpRenderTree/mac/PerlSupport/Makefile:
3146
3147 2011-08-11  Anders Carlsson  <andersca@apple.com>
3148
3149         Add a FIXME.
3150
3151         * TestWebKitAPI/TestsController.cpp:
3152         (TestWebKitAPI::TestsController::TestsController):
3153
3154 2011-08-11  Anders Carlsson  <andersca@apple.com>
3155
3156         Initialize threading before running any tests
3157         https://bugs.webkit.org/show_bug.cgi?id=66112
3158
3159         Reviewed by Adam Barth.
3160
3161         * TestWebKitAPI/TestsController.cpp:
3162         (TestWebKitAPI::TestsController::TestsController):
3163
3164 2011-08-11  Adam Barth  <abarth@webkit.org>
3165
3166         Add unexpected-passes.html to TestFailures for marking tests as passing
3167         https://bugs.webkit.org/show_bug.cgi?id=66102
3168
3169         Reviewed by Dimitri Glazkov.
3170
3171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3173             - Move some code into the library so it can be shared.
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3177             - Add round-trip unit tests.
3178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
3180             - I'm not entirely sure this feature should remain a separate HTML
3181               file, but it seemed better than cluttering up the main HTML file
3182               with too much extra stuff.
3183         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3184         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3185             - The gardening server couldn't handle adding PASS expectations.  Now it can.
3186
3187 2011-08-11  Eric Seidel  <eric@webkit.org>
3188
3189         NRWT has wrong fallback order for Mac now that Lion exists
3190         https://bugs.webkit.org/show_bug.cgi?id=66093
3191
3192         Reviewed by Adam Barth.
3193
3194         ORWT used a different system for fallback orders than NRWT did.
3195         I moved win.py to match ORWT fallback orders in bug 64486.
3196         This bug moves mac.py to match ORWT fallback order
3197         and adds 'lion' as a supported OS version.
3198
3199         Because ChromiumMac shares OS version detection code with AppleMac
3200         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
3201
3202         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3203         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3204         * Scripts/webkitpy/layout_tests/port/mac.py:
3205         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3206         * Scripts/webkitpy/layout_tests/port/win.py:
3207
3208 2011-08-11  Adam Barth  <abarth@webkit.org>
3209
3210         Update test results now that we use absolute URLs.
3211
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
3213
3214 2011-08-11  Adam Barth  <abarth@webkit.org>
3215
3216         garden-o-matic should be able to determine when tests unexpectedly pass
3217         https://bugs.webkit.org/show_bug.cgi?id=66092
3218
3219         Reviewed by Dimitri Glazkov.
3220
3221         This patch just contains the library methods for extracting this
3222         information.  I'll add some UI in a subsequent patch.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
3226
3227 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3228
3229         New expectation entries should be placed next to existing ones.
3230         https://bugs.webkit.org/show_bug.cgi?id=66066
3231
3232         Reviewed by Adam Barth.
3233
3234         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
3235             which is computed as the last found reference to the same test.
3236         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
3237
3238 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3239
3240         Unreviewed, rolling out r92847.
3241         http://trac.webkit.org/changeset/92847
3242         https://bugs.webkit.org/show_bug.cgi?id=65986
3243
3244         Broke check-webkit-style
3245
3246         * Scripts/webkitpy/style/checker.py:
3247         * Scripts/webkitpy/style/checker_unittest.py:
3248
3249 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3250
3251         Unreviewed, rolling out r92847.
3252         http://trac.webkit.org/changeset/92847
3253         https://bugs.webkit.org/show_bug.cgi?id=65986
3254
3255         Broke check-webkit-style
3256
3257         * Scripts/webkitpy/style/checker.py:
3258         * Scripts/webkitpy/style/checker_unittest.py:
3259
3260 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
3261
3262         [Qt] autotests shouldn't require config.h in the style check
3263         https://bugs.webkit.org/show_bug.cgi?id=65986
3264
3265         Remove the include rules from the style-check for Qt tests.
3266         Since for the most part it's just a matter of using the
3267         API provided by QtWebKit, enforcing the WebCore set of rules
3268         only seems to make sense in the case of MIMESniffing.
3269
3270         Reviewed by Benjamin Poulain.
3271
3272         * Scripts/webkitpy/style/checker.py:
3273         * Scripts/webkitpy/style/checker_unittest.py:
3274
3275 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3276
3277         [WK2] Implement waitForPolicyDelegate
3278         https://bugs.webkit.org/show_bug.cgi?id=42330
3279
3280         Reviewed by Csaba Osztrogonác.
3281
3282         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3283         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3284         (WTR::navigationTypeToString):
3285         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3286         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3287         (WTR::LayoutTestController::LayoutTestController):
3288         (WTR::LayoutTestController::setCustomPolicyDelegate):
3289         (WTR::LayoutTestController::waitForPolicyDelegate):
3290         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3291         (WTR::LayoutTestController::isPolicyDelegateEnabled):
3292         (WTR::LayoutTestController::isPolicyDelegatePermissive):
3293
3294 2011-08-11  Adam Barth  <abarth@webkit.org>
3295
3296         rebaseline-expectations should use the release bots, not the debug
3297         bots.  The debug bots don't all run all the tests.  Also, delay
3298         updating test_expectations a long as possible to avoid clearing out
3299         lines that we'll need for other ports.
3300
3301         * Scripts/webkitpy/layout_tests/port/builders.py:
3302         * Scripts/webkitpy/tool/commands/rebaseline.py:
3303         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3304
3305 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3306
3307         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
3308         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
3309
3310         * BuildSlaveSupport/build.webkit.org-config/config.json:
3311
3312 2011-08-10  Eric Seidel  <eric@webkit.org>
3313
3314         new-run-webkit-test's WinPort has no fallback logic
3315         https://bugs.webkit.org/show_bug.cgi?id=64486
3316
3317         Unreviewed.
3318
3319         Turns out that we've long had a subtle bug whereby if you didn't
3320         already have DumpRenderTree built, we might end up running unsupported tests
3321         because the DumpRenderTree --print-supported-features check would silently fail.
3322
3323         When I moved the call from using popen to using Executive.run_command, this silent
3324         failure became noisy.  (Breaking some bots.)
3325
3326         This re-orders our steps so that we always build DRT before collecting expectations,
3327         as well as adds a warning message when DumpRenderTree can't be found.
3328
3329         * Scripts/webkitpy/layout_tests/port/webkit.py:
3330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3331
3332 2011-08-10  Eric Seidel  <eric@webkit.org>
3333
3334         new-run-webkit-test's WinPort has no fallback logic
3335         https://bugs.webkit.org/show_bug.cgi?id=64486
3336
3337         Unreviewed.  Fix test-webkitpy under Python 2.5.
3338
3339         * Scripts/webkitpy/layout_tests/port/win.py:
3340
3341 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
3342
3343         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
3344         https://bugs.webkit.org/show_bug.cgi?id=65875
3345
3346         Reviewed by Kenneth Rohde Christiansen.
3347
3348         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
3349
3350         This causes mouse events to be sent twice in some cases. We work around the problem
3351         by defining the first touch point to be a primary touch point (case which hit some
3352         weird condition in QWidget, skipping the generation of fake mouse events).
3353
3354         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3355         (MiniBrowserApplication::notify):
3356
3357 2011-08-10  David Hyatt  <hyatt@apple.com>
3358
3359         https://bugs.webkit.org/show_bug.cgi?id=66004
3360
3361         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
3362         the code on by default.
3363
3364         Reviewed by Adam Roben.
3365
3366         * BuildSlaveSupport/build.webkit.org-config/config.json:
3367         * Scripts/build-webkit:
3368
3369 2011-08-10  Oliver Hunt  <oliver@apple.com>
3370
3371         JSEvaluteScript does not return the correct object when given JSONP data
3372         https://bugs.webkit.org/show_bug.cgi?id=66003
3373
3374         Reviewed by Gavin Barraclough.
3375
3376         Add a test case.
3377
3378         * DumpRenderTree/mac/DumpRenderTree.mm:
3379         (testStringByEvaluatingJavaScriptFromString):
3380
3381 2011-08-10  Eric Seidel  <eric@webkit.org>
3382
3383         WIN: NRWT runs compositing tests on configurations that don't support compositing
3384         https://bugs.webkit.org/show_bug.cgi?id=64472
3385
3386         Reviewed by Adam Barth.
3387
3388         I think the code was just wrong.  It was never splitting the string
3389         into list pieces before.
3390         I've now tested the supported_features code and theoretically it
3391         should now work with Windows DRT.
3392
3393         I also made the list-lookup functions always return lists, to make
3394         it possible to clean up the list-transform code in the future
3395         (I opted not to do that cleanup in this patch, but at least now
3396         both types of feature lookup functions match return types.)
3397
3398         * Scripts/webkitpy/layout_tests/port/webkit.py:
3399         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3400
3401 2011-08-10  Eric Seidel  <eric@webkit.org>
3402
3403         Clean up ChromiumDriver a little
3404         https://bugs.webkit.org/show_bug.cgi?id=65995
3405
3406         Unreviewed.
3407
3408         Fix NRWT for chromium.  Silly python.
3409
3410         * Scripts/webkitpy/layout_tests/port/chromium.py:
3411
3412 2011-08-10  Eric Seidel  <eric@webkit.org>
3413
3414         Clean up ChromiumDriver a little
3415         https://bugs.webkit.org/show_bug.cgi?id=65995
3416
3417         Reviewed by Adam Barth.
3418
3419         - We no longer support threading, so remove threading specific code.
3420         - Add FIXMEs about using ServerProcess instead.
3421         - Condense option-mapping if-cascade into a for loop.
3422         - Unindent long if blocks by using early return.
3423         - Unwrap lines which are needlessly wrapped.
3424
3425         There should be no functional changes here, just code cleanup/dead-code removal.
3426
3427         * Scripts/webkitpy/layout_tests/port/chromium.py:
3428
3429 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3430
3431         Unmuddle construction options for TestConfiguration.
3432         https://bugs.webkit.org/show_bug.cgi?id=65988
3433
3434         The TestConfiguration instance is now constructed only using actual values.
3435         Port-based construction is split into a "from_port" class method.
3436
3437         Reviewed by Eric Seidel.
3438
3439         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
3440         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
3441         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3442         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
3443         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
3444
3445 2011-08-10  Eric Seidel  <eric@webkit.org>
3446
3447         Leaks bot shows python logging prefixes as part of summary display
3448         https://bugs.webkit.org/show_bug.cgi?id=65931
3449
3450         Reviewed by Adam Barth.
3451
3452         The big part of this change is adding a unittesting system for
3453         master.cfg, so mere-mortals can make changes to build.webkit.org
3454         with greatly-reduced risk of breaking the world.
3455
3456         Turns out that in typing up my trival logging fix I made 2 typos,
3457         so hopefully the hour spent getting master.cfg to load was worth it. :)
3458
3459         I also tried to make mastercfg_unittest run as part of test-webkitpy
3460         but right now test-webkitpy requires that unittest files be located in
3461         a module-name-compatible directory.  'build.webkit.org-config' is not
3462         a valid module name.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3465          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
3466            by using a new _strip_python_logging_prefix function.
3467          - Also fixed this function to file to work with a more modern
3468            simplejson version (which returns unicode objects instead of str objects)
3469            and filed a related bug with buildbot.net due to their handling of unicode builder names.
3470         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
3471          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
3472          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
3473         * Scripts/webkitpy/thirdparty/__init__.py:
3474          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
3475
3476 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
3477
3478         garden-o-matic should extrapolate failures given a set of known results
3479         https://bugs.webkit.org/show_bug.cgi?id=65882
3480
3481         Reviewed by Adam Barth.
3482
3483         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
3484         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
3485             adjusted all call sites.
3486         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
3487             makes wider net for specific failures.
3488         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
3489
3490 2011-08-10  Adam Barth  <abarth@webkit.org>
3491
3492         The URL we were computing for retrieving baselines was missing a slash
3493         character because our mocks had an extra slash character.  I've
3494         corrected both the code and the mock.
3495
3496         * Scripts/webkitpy/tool/commands/rebaseline.py:
3497         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3498         * Scripts/webkitpy/tool/mocktool.py:
3499
3500 2011-08-09  Adam Barth  <abarth@webkit.org>
3501
3502         Move the quote mark to the right place.
3503
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3505
3506 2011-08-09  Adam Barth  <abarth@webkit.org>
3507
3508         garden-o-matic should use huerstics to narrow regression range
3509         https://bugs.webkit.org/show_bug.cgi?id=65948
3510
3511         Reviewed by Dimitri Glazkov.
3512
3513         When analyzing a regression range, if one of the commit messages
3514         mentions the test in question, we now hueristically assume that
3515         revision caused the failure.  (I'm shamelessly stealing this idea from
3516         TestFailures.)
3517
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3519
3520 2011-07-13  Eric Seidel  <eric@webkit.org>
3521
3522         new-run-webkit-test's WinPort has no fallback logic
3523         https://bugs.webkit.org/show_bug.cgi?id=64486
3524
3525         Reviewed by Adam Roben.
3526
3527         I've tried to write a patch for bug 64439 twice now, and both times
3528         I've ended up re-writing half the port system.  So I'm breaking
3529         things up into smaller pieces, this being the first.
3530
3531         WinPort still does not have any port_name parsing, so when instantiated
3532         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
3533         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
3534
3535         Otherwise this should "just work" for windows.  I've not been able to test the
3536         version detection on my mac, but the unit tests show the code behaving as designed.
3537
3538         * Scripts/webkitpy/layout_tests/port/win.py:
3539         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
3540
3541 2011-08-09  Adam Barth  <abarth@webkit.org>
3542
3543         Teach build.webkit.org's garden-o-matic how to talk to the local server
3544         https://bugs.webkit.org/show_bug.cgi?id=65940
3545
3546         Reviewed by Dimitri Glazkov.
3547
3548         After this patch, the version of garden-o-matic on build.webkit.org is
3549         fully functional.  It can interact with the local server via CORS.
3550
3551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3554         * Scripts/webkitpy/tool/commands/gardenomatic.py:
3555         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3556
3557 2011-08-09  Adam Barth  <abarth@webkit.org>
3558
3559         Enable CORS for garden-o-matic
3560         https://bugs.webkit.org/show_bug.cgi?id=65936
3561
3562         Reviewed by Dimitri Glazkov.
3563
3564         This patch will allow the hosted instance of garden-o-matic to
3565         communicate with the local server.
3566
3567         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3568         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3569
3570 2011-08-09  Adam Barth  <abarth@webkit.org>
3571
3572         Upgrade jquery in TestFailures
3573         https://bugs.webkit.org/show_bug.cgi?id=65935
3574
3575         Reviewed by Dimitri Glazkov.
3576
3577         Upgrade to a newer version of jQuery with better support for CORS and CSP.
3578
3579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3582
3583 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3584
3585         Unreviewed, rolling out r92683.
3586         http://trac.webkit.org/changeset/92683
3587         https://bugs.webkit.org/show_bug.cgi?id=65921
3588
3589          "Breaks Qt --minimal build. Revert pending update of the Qt
3590         minimal configuration" (Requested by simathur on #webkit).
3591
3592         * QtTestBrowser/cookiejar.cpp:
3593         (TestBrowserCookieJar::TestBrowserCookieJar):
3594         * QtTestBrowser/launcherwindow.cpp:
3595         (LauncherWindow::createChrome):
3596         (LauncherWindow::setDiskCache):
3597         * QtTestBrowser/main.cpp:
3598         (LauncherApplication::handleUserOptions):
3599         * QtTestBrowser/webpage.cpp:
3600         (WebPage::openUrlInDefaultBrowser):
3601
3602 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
3603
3604         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
3605         https://bugs.webkit.org/show_bug.cgi?id=65880
3606
3607         Reviewed by Andreas Kling.
3608
3609         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
3610         check for their feature flags. Assume that any reasonable Qt build provides them. 
3611         * QtTestBrowser/cookiejar.cpp:
3612         (TestBrowserCookieJar::TestBrowserCookieJar):
3613         * QtTestBrowser/launcherwindow.cpp:
3614         (LauncherWindow::createChrome):
3615         (LauncherWindow::setDiskCache):
3616         * QtTestBrowser/main.cpp:
3617         (LauncherApplication::handleUserOptions):
3618         * QtTestBrowser/webpage.cpp:
3619         (WebPage::openUrlInDefaultBrowser):
3620
3621 2011-08-09  Adam Barth  <abarth@webkit.org>
3622
3623         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
3624         https://bugs.webkit.org/show_bug.cgi?id=65891
3625
3626         Reviewed by Eric Seidel.
3627
3628         The problem was that platform/chromium contained a bogus expectation
3629         file that needed to be removed, but by the time we got around to
3630         removing it, we'd already moved the correct baseline into its place.
3631         After this patch, we copy the gold results into memory before
3632         reshuffling things on disk (and we delete bad things before adding good
3633         things).
3634
3635         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3636         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3637
3638 2011-08-08  Adam Barth  <abarth@webkit.org>
3639
3640         Chromium Windows bots can't figure out what SVN revision they're running
3641         https://bugs.webkit.org/show_bug.cgi?id=65893
3642
3643         Reviewed by Eric Seidel.
3644
3645         The comment in _engage_awesome_windows_hacks explains why we're making
3646         this change.  It's ugly and rediculous, but this approach seems better
3647         than using shell=True when calling popen.
3648
3649         * Scripts/webkitpy/common/checkout/scm/svn.py:
3650         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3651
3652 2011-08-08  Adam Barth  <abarth@webkit.org>
3653
3654         Remove deduplicate-tests
3655         https://bugs.webkit.org/show_bug.cgi?id=65886
3656
3657         Reviewed by Tony Chang.
3658
3659         This script is redundant with "webkit-patch bulk-optimize-baselines",
3660         which can find many more duplicates than deduplicate-tests because
3661         bulk-optimize-baselines can move results around whereas
3662         deduplicate-tests can only remove results.
3663
3664         * Scripts/deduplicate-tests: Removed.
3665         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
3666         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
3667
3668 2011-08-08  Adam Barth  <abarth@webkit.org>
3669
3670         scm.delete should delete empty parent directories as well
3671         https://bugs.webkit.org/show_bug.cgi?id=65878
3672
3673         Reviewed by Eric Seidel.
3674
3675         This behavior makes SVN match GIT (which has no concept of empty
3676         directories).  This bug comes up a lot when optimizing baselines, which
3677         often create empty directories when we're able to optimize everything
3678         out of a given folder.
3679
3680         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3681         * Scripts/webkitpy/common/checkout/scm/svn.py:
3682
3683 2011-08-08  Lucas Forschler  <lforschler@apple.com>
3684
3685         Add triggers for Lion WK2 test bots.
3686
3687         Reviewed by Stephanie Lewis.
3688
3689         * BuildSlaveSupport/build.webkit.org-config/config.json:
3690
3691 2011-08-08  Adam Barth  <abarth@webkit.org>
3692
3693         bulk-optimize-baselines should take directories on the command line
3694         https://bugs.webkit.org/show_bug.cgi?id=65879
3695
3696         Reviewed by Dimitri Glazkov.
3697
3698         Passing lists of tests via stdin is a pain.  It's easier if the command
3699         takes a list of tests on the command line, like run-webkit-tests.
3700
3701         * Scripts/webkitpy/tool/commands/rebaseline.py:
3702
3703 2011-08-08  Adam Barth  <abarth@webkit.org>
3704
3705         Deprecate rebaseline-chromium-webkit-tests
3706         https://bugs.webkit.org/show_bug.cgi?id=65873
3707
3708         Reviewed by Dimitri Glazkov.
3709
3710         This script never worked correctly and now is redundant with more
3711         modern infrastructure for rebaselining tests.  This patch deprecates
3712         the script in order to flush out any issues with the new tools.  Once
3713         folks are happy with the new tools, we'll delete this script.
3714
3715         * Scripts/rebaseline-chromium-webkit-tests:
3716
3717 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
3718
3719         garden-o-matic should only touch expectations that need updating.
3720         https://bugs.webkit.org/show_bug.cgi?id=65876
3721
3722         Reviewed by Adam Barth.
3723
3724         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
3725             so that a caller could influence which lines to serialize from values.
3726         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
3727         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
3728         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
3729
3730 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
3731
3732         TestExpectationsEditor should return a list of updated expectations.
3733         https://bugs.webkit.org/show_bug.cgi?id=65872
3734
3735         Reviewed by Adam Barth.
3736
3737         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
3738         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
3739
3740 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
3741
3742         Fix SCM webkitpy unit test failures
3743         https://bugs.webkit.org/show_bug.cgi?id=65823
3744
3745         Reviewed by Eric Seidel.
3746
3747         * Scripts/webkitpy/common/checkout/scm/git.py:
3748         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3749
3750 2011-08-08  Eric Seidel  <eric@webkit.org>
3751
3752         Move the --leaks bot back over to NRWT now that I'm back
3753         from vacation and able to debug it.
3754
3755         Unreviewed.
3756
3757         * Scripts/run-webkit-tests:
3758         (usingWebKit2):
3759         (useNewRunWebKitTests):
3760
3761 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3762
3763         Wire up updating expectations in garden-o-matic.
3764         https://bugs.webkit.org/show_bug.cgi?id=65794
3765
3766         Reviewed by Adam Barth.
3767
3768         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
3769         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
3770         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
3771         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
3772
3773 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
3774
3775         webkit-patch doesn't get along with renamed files
3776         https://bugs.webkit.org/show_bug.cgi?id=48075
3777
3778         Possibly a bit heavy handed - I removed all instances of -C and
3779         changed every instance of -M with '--no-renames' in git.py. This
3780         forces git to not try to tell us about renames at all, which is
3781         ultimately the behaviour we want. The old file is shown deleted,
3782         then the new file is shown added, followed by any changes that
3783         occurred. Also gets rid of the problem where deleting one file
3784         and adding another file which has similar content would
3785         unexpectedly show up as a rename, and fall out of a diff.
3786
3787         Based on a patch by Wyatt Carss.
3788
3789         Reviewed by Eric Seidel.
3790
3791         * Scripts/webkitpy/common/checkout/scm/git.py:
3792
3793 2011-08-07  Sam White  <samuel.white@rochester.edu>
3794
3795         Add the ability to search the AccessibilityObject cache
3796         https://bugs.webkit.org/show_bug.cgi?id=64994
3797         
3798         Added testing support for AccessibilityObject cache searching. Currently,
3799         only the mac platform is full supported and has had API exposed. Other
3800         platforms have only have this new functionality stubbed. Full implementation
3801         is a job suited only for an accessibility expert of each respective platform.
3802
3803         Reviewed by Chris Fleizach.
3804
3805         * DumpRenderTree/AccessibilityUIElement.cpp:
3806         (uiElementForSearchPredicateCallback):
3807         (AccessibilityUIElement::getJSClass):
3808         * DumpRenderTree/AccessibilityUIElement.h:
3809         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3810         (AccessibilityUIElement::uiElementForSearchPredicate):
3811         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3812         (AccessibilityUIElement::uiElementForSearchPredicate):
3813         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3814         (AccessibilityUIElement::uiElementForSearchPredicate):
3815
3816 2011-08-06  Adam Barth  <abarth@webkit.org>
3817
3818         Remove dead code in webkitpy
3819         https://bugs.webkit.org/show_bug.cgi?id=65818
3820
3821         Reviewed by Dimitri Glazkov.
3822
3823         This code was added to support the rebaseline2 command six months ago,
3824         but the rebaseline2 command was never finished and no one else has used
3825         this code since it was landed.  This patch removes the dead code.  If
3826         we revive rebaseline2, then we can revert this patch and recover the
3827         code.  Until then, this code is just dead weight.
3828
3829         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3830         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3831         * Scripts/webkitpy/common/net/testoutput.py: Removed.
3832         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
3833         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
3834         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
3835         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
3836         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
3837         * Scripts/webkitpy/layout_tests/port/base.py:
3838         * Scripts/webkitpy/layout_tests/port/chromium.py:
3839         * Scripts/webkitpy/layout_tests/port/webkit.py:
3840
3841 2011-08-06  Adam Barth  <abarth@webkit.org>
3842
3843         webkit-patch optimize-baselines can't handle promotions to base results directory
3844         https://bugs.webkit.org/show_bug.cgi?id=65819
3845
3846         Reviewed by Dimitri Glazkov.
3847
3848         This bug came up when testing the optimizer on some editing baselines.
3849
3850         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3851         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3852
3853 2011-08-06  Adam Barth  <abarth@webkit.org>
3854
3855         Add a small command to optimize baselines in bulk.
3856
3857         * Scripts/webkitpy/tool/commands/rebaseline.py:
3858
3859 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3860
3861         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
3862
3863         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
3864
3865 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3866
3867         Garden-o-matic updateexpectations needs a unit test.
3868         https://bugs.webkit.org/show_bug.cgi?id=65780
3869
3870         Reviewed by Adam Barth.
3871
3872         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
3873
3874 2011-08-05  Anders Carlsson  <andersca@apple.com>
3875
3876         Future proof an Objective-C test
3877         https://bugs.webkit.org/show_bug.cgi?id=65788
3878
3879         Reviewed by Dan Bernstein.
3880
3881         Add isObjectInstanceOf to ObjCController.
3882
3883         * DumpRenderTree/mac/ObjCController.m:
3884         (+[ObjCController isSelectorExcludedFromWebScript:]):
3885         (+[ObjCController webScriptNameForSelector:]):
3886         (-[ObjCController isObject:instanceOf:]):
3887
3888 2011-08-05  Adam Barth  <abarth@webkit.org>
3889
3890         trac.js needs unittests
3891         https://bugs.webkit.org/show_bug.cgi?id=65673
3892
3893         Reviewed by Dimitri Glazkov.
3894
3895         This tests also have somewhat large fixtures.  I've trimmed the example
3896         XML down a bunch while still hitting interesting cases in the parsing.
3897
3898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
3900
3901 2011-08-05  Adam Barth  <abarth@webkit.org>
3902
3903         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
3904         https://bugs.webkit.org/show_bug.cgi?id=65759
3905
3906         Reviewed by Dimitri Glazkov.
3907
3908         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
3909         architecture, is poorly tested, and has a bunch of quirks.  This patch
3910         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
3911         top of more modern infrastructure.  In the process, we get more code
3912         re-use and better testing.
3913
3914         Once we're satisfied with this new implementation, we can delete the
3915         old implementation.
3916
3917         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3918         * Scripts/webkitpy/common/net/web.py:
3919         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3920         * Scripts/webkitpy/layout_tests/port/builders.py:
3921         * Scripts/webkitpy/layout_tests/port/chromium.py:
3922         * Scripts/webkitpy/layout_tests/port/factory.py:
3923         * Scripts/webkitpy/layout_tests/port/webkit.py:
3924         * Scripts/webkitpy/tool/commands/rebaseline.py:
3925         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3926
3927 2011-08-05  Anders Carlsson  <andersca@apple.com>
3928
3929         Remove PluginHalter
3930         https://bugs.webkit.org/show_bug.cgi?id=65729
3931
3932         Reviewed by Darin Adler.
3933
3934         Remove call to set the allowed plug-in run time.
3935
3936         * DumpRenderTree/mac/DumpRenderTree.mm:
3937         (resetDefaultsToConsistentValues):
3938
3939 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3940
3941         Unreviewed build fix for Qt-Minimal buildbot
3942
3943         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
3944         is disabled.
3945
3946         Rubber-stamped by Holger Freyther.
3947
3948         * QtTestBrowser/cookiejar.cpp:
3949         (TestBrowserCookieJar::TestBrowserCookieJar):
3950
3951 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3952
3953         [Qt] QtTestBrowser: Add support for saving cookies on disk
3954         https://bugs.webkit.org/show_bug.cgi?id=65328
3955
3956         Simple cookiejar that saves cookies on disk.
3957
3958         Added menu options to clear cookies (Edit->Clear cookies) and
3959         disable disk cookies (Settings->[ ]Save Cookies on Disk).
3960
3961         Option -no-disk-cookies is also available.
3962
3963         Reviewed by Andreas Kling.
3964
3965         * QtTestBrowser/QtTestBrowser.pro:
3966         * QtTestBrowser/cookiejar.cpp: Added.
3967         * QtTestBrowser/cookiejar.h: Added.
3968         * QtTestBrowser/launcherwindow.cpp:
3969         * QtTestBrowser/launcherwindow.h:
3970         * QtTestBrowser/main.cpp:
3971
3972 2011-08-04  Adam Barth  <abarth@webkit.org>
3973
3974         model.js needs some unit testing
3975         https://bugs.webkit.org/show_bug.cgi?id=65730
3976
3977         Reviewed by Dimitri Glazkov.
3978
3979         These tests do not cover all the functions exported by the model
3980         module.  We'll need to add the remaining ones in the future.
3981
3982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3984
3985 2011-08-04  Adam Barth  <abarth@webkit.org>
3986
3987         Another speculative fix for the "svn revision on Windows" problem.
3988
3989         * Scripts/webkitpy/common/checkout/scm/git.py:
3990
3991 2011-08-04  Mark Rowe  <mrowe@apple.com>
3992
3993         Future-proof Xcode configuration settings.
3994
3995         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3996         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3997         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3998         * MiniBrowser/Configurations/Base.xcconfig:
3999         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
4000         * MiniBrowser/Configurations/DebugRelease.xcconfig:
4001         * TestWebKitAPI/Configurations/Base.xcconfig:
4002         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
4003         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
4004         * WebKitTestRunner/Configurations/Base.xcconfig:
4005         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
4006         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4007
4008 2011-08-04  Adam Barth  <abarth@webkit.org>
4009
4010         Fancier debug logging.
4011
4012         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4013
4014 2011-08-04  David Levin  <levin@chromium.org>
4015
4016         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
4017         https://bugs.webkit.org/show_bug.cgi?id=65685
4018
4019         Reviewed by Dmitry Titov.
4020
4021         * DumpRenderTree/chromium/WebViewHost.cpp:
4022         (WebViewHost::WebViewHost): Intialize WTF threading before
4023         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
4024         but in some cases code may use WTF without creating WebViewImpl and
4025         WTF code functionality may call WTF::currentThread, which requires
4026         this initialization now.
4027
4028 2011-08-04  Adam Barth  <abarth@webkit.org>
4029
4030         An educated guess at causing the Windows bots on build.webkit.org to
4031         find the SVN revision number.
4032
4033         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4034         * Scripts/webkitpy/layout_tests/port/base.py:
4035
4036 2011-08-04  Adam Barth  <abarth@webkit.org>
4037
4038         More logging to help debug the "no SVN rev on Chromium Windows bots"
4039         bug.  My current theory is that we're trying to detect the SCM system
4040         in the wrong directory.
4041
4042         * Scripts/webkitpy/layout_tests/port/base.py:
4043
4044 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
4045
4046         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
4047         https://bugs.webkit.org/show_bug.cgi?id=65697
4048
4049         I neglected to realize that collecting test names is not necessary for this operation.
4050
4051         Reviewed by Adam Barth.
4052
4053         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
4054
4055 2011-08-04  Adam Barth  <abarth@webkit.org>
4056
4057         checkout_unittest.js should have better coverage of checkout.js
4058         https://bugs.webkit.org/show_bug.cgi?id=65671
4059
4060         Reviewed by Dimitri Glazkov.
4061
4062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
4063             - Remove unused functions.
4064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
4065             - Test remaining public functions in the checkout module.
4066
4067 2011-08-04  Dmitry Lomov  <dslomov@google.com>
4068
4069         https://bugs.webkit.org/show_bug.cgi?id=65706
4070         Run run-unit-tests on release mode test bots.
4071         Reenabling after 61812 is fixed.
4072
4073         Reviewed by Adam Roben.
4074
4075         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4076
4077 2011-08-04  Adam Barth  <abarth@webkit.org>
4078
4079         builders.js needs unit tests
4080         https://bugs.webkit.org/show_bug.cgi?id=65670
4081
4082         Reviewed by Dimitri Glazkov.
4083
4084         This test requires somewhat large test fixtures, but using real
4085         examples seemed better than trimming them down too much.
4086
4087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
4088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
4089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
4090             - Note: trac_unittests.js doesn't exist (yet!).
4091
4092 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
4093
4094         [Qt] Make navigation actions properly usable in QML.
4095         https://bugs.webkit.org/show_bug.cgi?id=65624
4096
4097         Fix compilation after the introduction of QWebNavigationController.
4098
4099         Reviewed by Benjamin Poulain.
4100
4101         * MiniBrowser/qt/BrowserView.cpp:
4102         (BrowserView::navigationAction):
4103
4104 2011-08-04  Adam Barth  <abarth@webkit.org>
4105
4106         Another subtle bug due to lack of testing in main.js.  :(
4107
4108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
4109
4110 2011-08-04  Adam Barth  <abarth@webkit.org>
4111
4112         Fix types.  Sadly, main.js has no test coverage.  (I need to think
4113         about how to test this part of the code.)
4114
4115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
4116
4117 2011-08-04  Adam Barth  <abarth@webkit.org>
4118
4119         bugzilla.js is missing unit tests
4120         https://bugs.webkit.org/show_bug.cgi?id=65656
4121
4122         Reviewed by Adam Roben.
4123
4124         Testing makes perfect.
4125
4126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
4127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
4128         (NetworkSimulator.prototype.runTest.get if):
4129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
4130
4131 2011-08-04  Adam Barth  <abarth@webkit.org>
4132
4133         Add missing license blocks to garden-o-matic
4134         https://bugs.webkit.org/show_bug.cgi?id=65654
4135
4136         Reviewed by Dimitri Glazkov.
4137
4138         This patch is entirely boilerplate.
4139
4140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
4141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
4142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
4143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
4144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
4145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
4146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
4147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
4149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
4150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
4151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
4152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
4153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
4154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
4155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
4156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
4157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
4158
4159 2011-08-04  Adam Barth  <abarth@webkit.org>
4160
4161         garden-o-matic needs a way to mock out the network
4162         https://bugs.webkit.org/show_bug.cgi?id=65653
4163
4164         Reviewed by Dimitri Glazkov.
4165
4166         This patch introduces the net module, which is a useful mock point for
4167         abstracting away the network.  Future patches will use this
4168         infrastructure to test some currently untested code.
4169
4170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
4171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
4172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
4173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
4174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
4175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
4177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
4178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
4179         (NetworkSimulator):
4180         (NetworkSimulator.prototype.scheduleCallback):
4181         (NetworkSimulator.prototype.runTest):
4182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
4183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
4184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
4185         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4186
4187 2011-08-03  Adam Barth  <abarth@webkit.org>
4188
4189         Use failureInfo more pervasively in garden-o-matic
4190         https://bugs.webkit.org/show_bug.cgi?id=65650
4191
4192         Reviewed by Dimitri Glazkov.
4193
4194         These three variable appears in concert together many places.  This
4195         patch unifies the remaining uses into being failureInfo objects, which
4196         saves some marshalling.
4197
4198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
4199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
4200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
4201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
4202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
4203
4204 2011-08-03  Adam Barth  <abarth@webkit.org>
4205
4206         garden-o-matic should be able to update expecations from the details pane
4207         https://bugs.webkit.org/show_bug.cgi?id=65648
4208
4209         Reviewed by Dimitri Glazkov.
4210
4211         The new button queues up the updates, which get executed all at once.
4212
4213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
4215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
4216
4217 2011-08-03  Adam Barth  <abarth@webk