[Win] run-webkit-tests is failing to run DRT and WTR without --architecture x86_64
[WebKit-https.git] / Tools / ChangeLog
1 2020-06-29  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [Win] run-webkit-tests is failing to run DRT and WTR without --architecture x86_64
4         https://bugs.webkit.org/show_bug.cgi?id=213688
5
6         Reviewed by Jonathan Bedard.
7
8         * Scripts/webkitpy/port/win.py:
9         (WinPort._port_flag_for_scripts):
10         (WinPort._build_path):
11         (WinPort._ntsd_location):
12         Replaced self.get_option('architecture') with self.architecture().
13
14 2020-06-29  Jonathan Bedard  <jbedard@apple.com>
15
16         run-javascriptcore-tests: Support Apple Silicon running x86 processes
17         https://bugs.webkit.org/show_bug.cgi?id=213487
18         <rdar://problem/64606667>
19
20         Unreviewed infrastructure fix.
21
22         * Scripts/webkitdirs.pm:
23         (architecturesForProducts): Return architecutre(), not determineArchitecture().
24
25 2020-06-29  Xabier Rodriguez Calvar  <calvaris@igalia.com>
26
27         [webkitpy] PHP7.4 support on Debian platforms
28         https://bugs.webkit.org/show_bug.cgi?id=213721
29
30         Reviewed by Carlos Garcia Campos.
31
32         * Scripts/webkitpy/port/base.py:
33         (Port._debian_php_version):
34
35 2020-06-29  Philippe Normand  <pnormand@igalia.com>
36
37         REGRESSION(r263625): [WPE][GTK] MiniBrowser output no longer includes stderr and stdout
38         https://bugs.webkit.org/show_bug.cgi?id=213696
39
40         Reviewed by Žan Doberšek.
41
42         This patch adds a new optional argument to Executive.run_command() to control stdout output.
43         By default the subprocess.PIPE value is used, to keep backward compatibility. Set the stdout
44         argument to None to display the output on the terminal tty.
45
46         The GTK and WPE run_minibrowser() implementations now use this new argument, along with
47         setting return_stderr to False to indicate we also want stderr displayed on the terminal
48         tty.
49
50         * Scripts/webkitpy/common/system/abstractexecutive.py:
51         (AbstractExecutive.run_command):
52         * Scripts/webkitpy/common/system/executive.py:
53         (Executive.run_command):
54         * Scripts/webkitpy/common/system/executive_mock.py:
55         (MockExecutive.run_command):
56         * Scripts/webkitpy/port/gtk.py:
57         (GtkPort.run_minibrowser):
58         * Scripts/webkitpy/port/wpe.py:
59         (WPEPort.run_minibrowser):
60
61 2020-06-29  Philippe Normand  <pnormand@igalia.com>
62
63         REGRESSION(r263625): run-minibrowser --debug/--release options gone
64         https://bugs.webkit.org/show_bug.cgi?id=213697
65
66         Reviewed by Žan Doberšek.
67
68         * Scripts/webkitpy/minibrowser/run_webkit_app.py:
69         (main): Explicitely skip the --target option. Previous code was also skipping --release and
70         --debug options because their `dest` is the same as with the --target option.
71
72 2020-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
73
74         [GTK][WPE] Add webkit_authentication_request_get_security_origin
75         https://bugs.webkit.org/show_bug.cgi?id=213596
76
77         Reviewed by Michael Catanzaro.
78
79         Update the unit tests to check the new API.
80
81         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
82         (testWebViewAuthenticationRequest):
83         (testWebViewAuthenticationProxy):
84         (testWebViewAuthenticationProxyHTTPS):
85
86 2020-06-28  Geoffrey Garen  <ggaren@apple.com>
87
88         Rename initializeThreading to initialize
89         https://bugs.webkit.org/show_bug.cgi?id=213674
90
91         Reviewed by Mark Lam.
92
93         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
94         (ApplicationManifestParserTest::SetUp):
95         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
96         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
97         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
98         (TestWebKitAPI::ContentExtensionTest::SetUp):
99         * TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
100         (TestWebKitAPI::TEST):
101         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
102         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
103         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
104         (WebKitTestServer::WebKitTestServer):
105         * WebKitTestRunner/TestController.cpp:
106         (WTR::TestController::initialize):
107
108 2020-06-27  Daniel Bates  <dabates@apple.com>
109
110         Revert r262654 because it caused <rdar://problem/64664156>.
111         Moreover it is no longer necessary as the embedding client
112         changes selection through a different SPI after focusing.
113
114         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
115         (TestWebKitAPI::TEST):
116
117 2020-06-27  Keith Miller  <keith_miller@apple.com>
118
119         compare-results should be able to parse multiple JSONs at once by merging them
120         https://bugs.webkit.org/show_bug.cgi?id=213685
121
122         Reviewed by Saam Barati.
123
124         This patch improves the compare-results script to enable it to
125         merge JSON output files. This is handy when running scripts by
126         hand where you'll get many a and b JSONs.  To do the merging this
127         patch moves the logic of merge-result-jsons into a shared library.
128
129         compare-results can take multiple files sequentally or by passing
130         the '-a'/'-b' flags multiple times. e.g. `/compare-results -a
131         OG-1.json -a OG-2.json -a OG-3.json -a OG-4.json -b MC-1.json
132         MC-2.json MC-3.json MC-4.json` will behave as you'd expect;
133         combining all the OG JSONs and the MC JSONs before computing the
134         result.
135
136         Lastly, the benchmark_results script now can handle duplicates of
137         an aggregator in the aggregator list. This is useful because
138         otherwise the logic of merging JSONs is significantly more
139         complicated.
140
141         * Scripts/compare-results:
142         (getOptions):
143         (main):
144         * Scripts/merge-result-jsons:
145         (readJSONFile):
146         (deepAppend): Deleted.
147         (mergeJSONs): Deleted.
148         * Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py: Copied from Tools/Scripts/merge-result-jsons.
149         (deepAppend):
150         (mergeJSONs):
151         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
152         (BenchmarkResults._aggregate_results_for_test):
153         (BenchmarkResults._lint_subtest_results):
154         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
155
156 2020-06-27  Jer Noble  <jer.noble@apple.com>
157
158         iOS Safari incorrectly reports "AppleCoreMedia" as UA string
159         https://bugs.webkit.org/show_bug.cgi?id=213245
160         <rdar://problem/64471582>
161
162         Reviewed by Youenn Fablet.
163
164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
165         * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
166         (TestWebKitAPI::parseUserAgent):
167         (TestWebKitAPI::TEST):
168
169 2020-06-27  Philippe Normand  <pnormand@igalia.com>
170
171         Migrate run-minibrowser to webkitpy
172         https://bugs.webkit.org/show_bug.cgi?id=213431
173
174         Reviewed by Jonathan Bedard.
175
176         The perl version was renamed to old-run-minibrowser and remains used by the Mac ports.
177         run-minibrowser is now a Python script hooking into webkitpy and the Port infrastructure.
178         Both WPE and GTK ports will now use the pure python implementation.
179
180         * Scripts/old-run-minibrowser: Copied from Tools/Scripts/run-minibrowser.
181         * Scripts/run-minibrowser:
182         * Scripts/webkitpy/minibrowser/run_minibrowser.py: Added.
183         (main):
184         (parse_args):
185         * Scripts/webkitpy/port/base.py:
186         (Port.run_minibrowser_arguments):
187         (Port):
188         (Port.run_minibrowser):
189         * Scripts/webkitpy/port/darwin.py:
190         (DarwinPort.environment_for_api_tests):
191         (DarwinPort):
192         (DarwinPort.run_minibrowser_arguments):
193         * Scripts/webkitpy/port/gtk.py:
194         (GtkPort.show_results_html_file):
195         (GtkPort.configuration_for_upload):
196         (GtkPort):
197         (GtkPort.run_minibrowser):
198         * Scripts/webkitpy/port/wpe.py:
199         (WPEPort.show_results_html_file):
200         (WPEPort.configuration_for_upload):
201         (WPEPort):
202         (WPEPort.run_minibrowser):
203
204 2020-06-27  Stephan Szabo  <stephan.szabo@sony.com>
205
206         [PlayStation] Update test runner for changes to Options and signing
207         https://bugs.webkit.org/show_bug.cgi?id=213650
208
209         Reviewed by Don Olmstead.
210
211         * Scripts/webkitdirs.pm: Update extension for PlayStation binary
212
213 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
214
215         [webkitpy] Allow callers to override the reported model (Part 1)
216         https://bugs.webkit.org/show_bug.cgi?id=213677
217         <rdar://problem/64834043>
218
219         Reviewed by Dewei Zhu.
220
221         * Scripts/webkitpy/port/base.py:
222         (Port.configuration_for_upload): Set the model based on --model.
223         * Scripts/webkitpy/port/factory.py:
224         (configuration_options): Add --model option, drive-by fix for --architecture.
225         * Scripts/webkitpy/port/mac.py:
226         (MacPort.configuration_for_upload): --model overrides detected model.
227
228 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
229
230         [webkitpy] Automatically detect hw architecture for supporting Apple Silicon
231         https://bugs.webkit.org/show_bug.cgi?id=213653
232         <rdar://problem/64817656>
233
234         Rubber-stamped by Aakash Jain.
235
236         * Scripts/webkitpy/common/config/ews.json: iOS has the correct defaults, no need to override them.
237         * Scripts/webkitpy/common/system/platforminfo.py:
238         (PlatformInfo):
239         (PlatformInfo.architecture): Retrieve the current system's architecture.
240         * Scripts/webkitpy/common/system/platforminfo_mock.py:
241         (MockPlatformInfo.__init__):
242         (MockPlatformInfo.architecture):
243         * Scripts/webkitpy/port/base.py:
244         (Port.__init__): Remove 'did_override_architecture', should be implied by architecture compared with DEFAULT_ARCHITECTURE.
245         (Port.architecture): Return the architecture specified by the user, if it exists.
246         (Port.set_architecture): Remove 'did_override_architecture'.
247         * Scripts/webkitpy/port/factory.py:
248         (configuration_options): Add --arm and --architecture flags.
249         * Scripts/webkitpy/port/mac.py:
250         (MacPort): Add arm64 to supported architectures.
251         (MacPort.architecture): Convert arm64e to arm64, check the host's architecture.
252         (MacPort._build_driver_flags): Always specify the build architecture since it may be x86_64 or arm64.
253         * Scripts/webkitpy/port/mac_unittest.py:
254         (MacTest.test_64bit):
255         (MacTest):
256         (MacTest.test_arm):
257         (MacTest.test_default):
258         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
259         (AbstractEarlyWarningSystem.run_command): Remove did_override_architecture.
260
261 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
262
263         [Big Sur] Handle baseline search path (Follow-up fix)
264         https://bugs.webkit.org/show_bug.cgi?id=213639
265         <rdar://problem/64789480>
266
267         Unreviewed follow-up fix.
268
269         * Scripts/webkitpy/port/mac.py:
270         (MacPort.default_baseline_search_path): Copy reference version by value, not by reference.
271
272 2020-06-26  Geoffrey Garen  <ggaren@apple.com>
273
274         Initializing the main thread should initialize the main run loop
275         https://bugs.webkit.org/show_bug.cgi?id=213637
276
277         Reviewed by Anders Carlsson.
278
279         Updated TestWebKitAPI to stop using RunLoop::initializeMain directly.
280
281         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
282         (TestWebKitAPI::TEST):
283         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
284         (TestWebKitAPI::TEST):
285         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
286         (TestWebKitAPI::TEST):
287         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
288         (ApplicationManifestParserTest::SetUp):
289         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
290         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
291         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
292         (TestWebKitAPI::ContentExtensionTest::SetUp):
293         * TestWebKitAPI/Tests/WebCore/DNS.cpp:
294         (TestWebKitAPI::TEST):
295         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
296         (TestWebKitAPI::TEST_F):
297         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
298         (initializeInAppBrowserPrivacyTestSettings):
299         * TestWebKitAPI/TestsController.cpp:
300         (TestWebKitAPI::TestsController::TestsController):
301         * WebKitTestRunner/TestController.cpp:
302         (TestController::initialize):
303
304 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
305
306         run-javascriptcore-tests: Support Apple Silicon running x86 processes
307         https://bugs.webkit.org/show_bug.cgi?id=213487
308         <rdar://problem/64606667>
309
310         Reviewed by Saam Barati.
311
312         * Scripts/run-javascriptcore-tests:
313         (configurationForUpload): Add --architecture flag.
314         (runTest): Run test suite with specific architecture.
315         (runJSCStressTests): Pass architecture to run-jsc-stress-tests.
316         * Scripts/run-jsc-stress-tests: Add --force-architecture flag.
317         * Scripts/webkitdirs.pm:
318         (determineNativeArchitecture): Add function to determine machine's native architecture.
319         (determineArchitecture): Leverage the nativeArchitecture instead of hard-coding simulator
320         architectures.
321         (architecturesForProducts): Determine the architectures supported by a given build.
322         (nativeArchitecture): Return nativeArchitecture.
323
324 2020-06-26  Sihui Liu  <sihui_liu@apple.com>
325
326         Text manipulation should observe adjacent elements with new renderer together
327         https://bugs.webkit.org/show_bug.cgi?id=213333
328
329         Reviewed by Geoffrey Garen.
330
331         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
332         (TestWebKitAPI::TEST):
333
334 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
335
336         [Big Sur] Handle baseline search path
337         https://bugs.webkit.org/show_bug.cgi?id=213639
338         <rdar://problem/64789480>
339
340         Rubber-stamped by Aakash Jain.
341
342         * Scripts/webkitpy/port/mac.py:
343         (MacPort):
344         (MacPort.default_baseline_search_path): Break infinite loop for major version bump.
345         * Scripts/webkitpy/port/mac_unittest.py:
346         (MacTest.test_big_sur_baseline_search_path): Test Big Sur baseline search path.
347
348 2020-06-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
349
350         generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
351         https://bugs.webkit.org/show_bug.cgi?id=213615
352
353         Reviewed by Žan Doberšek.
354
355         Raise an exception if the parameter passed as remote-config-file is not a file.
356
357         * Scripts/generate-jsc-bundle:
358         (main):
359
360 2020-06-26  Takashi Komori  <takashi.komori@sony.com>
361
362         Add myself to contributors.json
363
364         Unreviewed.
365
366         * Scripts/webkitpy/common/config/contributors.json:
367
368 2020-06-25  Ryan Haddad  <ryanhaddad@apple.com>
369
370         [Big Sur] Regression tests fail to run due to failed assert: self._os_version.major == 10
371         https://bugs.webkit.org/show_bug.cgi?id=213639
372
373         Reviewed by Jonathan Bedard.
374
375         * Scripts/webkitpy/port/mac.py:
376         (MacPort.__init__): Remove the assert since it is no longer valid.
377
378 2020-06-25  Commit Queue  <commit-queue@webkit.org>
379
380         Unreviewed, reverting r263537.
381         https://bugs.webkit.org/show_bug.cgi?id=213640
382
383         Broke watchOS and tvOS builds
384
385         Reverted changeset:
386
387         "iOS Safari incorrectly reports "AppleCoreMedia" as UA string"
388         https://bugs.webkit.org/show_bug.cgi?id=213245
389         https://trac.webkit.org/changeset/263537
390
391 2020-06-25  Alex Christensen  <achristensen@webkit.org>
392
393         REGRESSION(r256166, r260596) WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and Accept
394         https://bugs.webkit.org/show_bug.cgi?id=213626
395         <rdar://problem/62374208>
396
397         Reviewed by Darin Adler.
398
399         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
400         (TEST):
401
402 2020-06-25  Jer Noble  <jer.noble@apple.com>
403
404         iOS Safari incorrectly reports "AppleCoreMedia" as UA string
405         https://bugs.webkit.org/show_bug.cgi?id=213245
406         <rdar://problem/64471582>
407
408         Reviewed by Youenn Fablet.
409
410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
411         * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
412         (TestWebKitAPI::parseUserAgent):
413         (TestWebKitAPI::TEST):
414
415 2020-06-25  Daniel Bates  <dabates@apple.com>
416
417         [iOS] -_requestTextInputContextsInRect cannot find empty Quip spreadsheet title
418         https://bugs.webkit.org/show_bug.cgi?id=213564
419         <rdar://problem/59355847>
420
421         Reviewed by Simon Fraser.
422
423         Add some tests.
424
425         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
426         (TestWebKitAPI::TEST):
427
428 2020-06-25  Sam Weinig  <weinig@apple.com>
429
430         Add a new templated string type to help write more idiomatic parsing code
431         https://bugs.webkit.org/show_bug.cgi?id=213588
432
433         Reviewed by Darin Adler.
434
435         * TestWebKitAPI/CMakeLists.txt:
436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
437         * TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp: Added.
438         (TestWebKitAPI::TEST):
439         Added new tests for new class.
440
441 2020-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
442
443         Text manipulation should exclude text rendered using icon-only fonts
444         https://bugs.webkit.org/show_bug.cgi?id=213446
445         <rdar://problem/63734298>
446
447         Reviewed by Myles Maxfield.
448
449         Add a new API test.
450
451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
452         * TestWebKitAPI/Tests/WebKitCocoa/Ahem.ttf: Added.
453         * TestWebKitAPI/Tests/WebKitCocoa/SpaceOnly.otf: Added.
454         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
455         (TestWebKitAPI::TEST):
456
457 2020-06-25  Aakash Jain  <aakash_jain@apple.com>
458
459         [ews] Share more bots between EWS builder and testers
460         https://bugs.webkit.org/show_bug.cgi?id=213521
461
462         Reviewed by Jonathan Bedard.
463
464         * BuildSlaveSupport/ews-build/config.json:
465
466 2020-06-25  Aakash Jain  <aakash_jain@apple.com>
467
468         [ews] Improve handling of invalid changelog
469         https://bugs.webkit.org/show_bug.cgi?id=213609
470
471         Reviewed by Jonathan Bedard.
472
473         * Scripts/webkitpy/tool/steps/validatereviewer.py:
474         (ValidateReviewer.run):
475
476 2020-06-24  Alexey Proskuryakov  <ap@apple.com>
477
478         macOS Big Sur build fix.
479
480         Remove long obsolete checks for Mac OS X 10.6 that didn't respect the major version.
481
482         * MiniBrowser/Makefile:
483         * TestWebKitAPI/Makefile:
484         * WebKitTestRunner/Makefile:
485
486 2020-06-24  Alex Christensen  <achristensen@webkit.org>
487
488         REGRESSION(r262341) Use UTF-8 to decode CFURLRefs from IPC
489         https://bugs.webkit.org/show_bug.cgi?id=213565
490         <rdar://problem/64408924>
491
492         Reviewed by Darin Adler.
493
494         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
495         (TestWebKitAPI::TEST):
496
497 2020-06-24  Umar Iqbal  <uiqbal@apple.com>
498
499         We should resurrect the older patch that collects some statistics of web API calls
500         https://bugs.webkit.org/show_bug.cgi?id=213319
501
502         Reviewed by Brent Fulgham.
503         
504         + Enabled ENABLE_WEB_API_STATISTICS flag.
505         
506         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
507
508 2020-06-24  Andy Estes  <aestes@apple.com>
509
510         [iOS] Open element actions sometimes result in a hover instead of a click
511         https://bugs.webkit.org/show_bug.cgi?id=213530
512         <rdar://problem/64176707>
513
514         Reviewed by Darin Adler.
515
516         Added an API test.
517
518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
519         * TestWebKitAPI/Tests/ios/ElementActionTests.mm: Added.
520         * TestWebKitAPI/Tests/ios/link-with-hover-menu.html: Added.
521
522 2020-06-24  Caitlin Potter  <caitp@igalia.com>
523
524         [JSC] add microbenchmark for op_get_private_name
525         https://bugs.webkit.org/show_bug.cgi?id=213544
526
527         Reviewed by Yusuke Suzuki.
528
529         Add machinery to add --usePrivateClassFields flag in a family of
530         microbenchmarks.
531  
532         * Scripts/run-jsc-benchmarks:
533
534 2020-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
535
536         [GTK][WPE] Add API to allow applications to handle the HTTP authentication credential storage
537         https://bugs.webkit.org/show_bug.cgi?id=213177
538
539         Reviewed by Michael Catanzaro.
540
541         Update the authentication tests to check the new API.
542
543         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
544         (testWebViewAuthenticationCancel):
545         (testWebViewAuthenticationLoadCancelled):
546         (testWebViewAuthenticationFailure):
547         (testWebViewAuthenticationNoCredential):
548         (testWebViewAuthenticationEphemeral):
549         (testWebViewAuthenticationStorage):
550         (testWebViewAuthenticationSuccess):
551         (testWebViewAuthenticationEmptyRealm):
552         (serverCallback):
553         (beforeAll):
554
555 2020-06-23  Alex Christensen  <achristensen@webkit.org>
556
557         Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled
558         https://bugs.webkit.org/show_bug.cgi?id=213527
559
560         Reviewed by Geoffrey Garen.
561
562         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
563         (TEST):
564
565 2020-06-23  Jonathan Bedard  <jbedard@apple.com>
566
567         [Big Sur] Add 11.0 version to scripts
568         https://bugs.webkit.org/show_bug.cgi?id=213532
569         <rdar://problem/64663032>
570
571         Reviewed by Tim Horton.
572
573         * Scripts/run-javascriptcore-tests:
574         (configurationForUpload): Make version checks more explicit, add Big Sur.
575         * Scripts/webkitpy/common/version_name_map.py:
576         (VersionNameMap.__init__): Add Big Sur.
577         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
578         (TestExpectationParser): Ditto.
579
580 2020-06-23  Wenson Hsieh  <wenson_hsieh@apple.com>
581
582         REGRESSION (r244633): Mail flashes when copying text in an email
583         https://bugs.webkit.org/show_bug.cgi?id=213529
584         <rdar://problem/55025522>
585
586         Reviewed by Tim Horton.
587
588         Add an API test to verify that temporarily changing the height of the document before restoring it to the
589         original value does not cause intrinsic content size to be invalidated.
590
591         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
592         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
593         (-[AutoLayoutWKWebView setInvalidatedIntrinsicContentSizeBlock:]):
594         (-[AutoLayoutWKWebView invalidatedIntrinsicContentSizeBlock]):
595
596 2020-06-23  Diego Pino Garcia  <dpino@igalia.com>
597
598         [ews] Allow archiving 'jsc' product
599         https://bugs.webkit.org/show_bug.cgi?id=213518
600
601         Reviewed by Aakash Jain.
602
603         * BuildSlaveSupport/built-product-archive:
604         (archiveBuiltProduct):
605
606 2020-06-23  Alex Christensen  <achristensen@webkit.org>
607
608         Expose already-available WKNavigationAction.request.HTTPBody through the API
609         https://bugs.webkit.org/show_bug.cgi?id=179077
610
611         Reviewed by Brady Eidson.
612
613         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
614         (TEST):
615
616 2020-06-23  Alicia Boya García  <aboya@igalia.com>
617
618         [GStreamer] Add GStreamer patch to fix EWS glupload racy crash
619         https://bugs.webkit.org/show_bug.cgi?id=210498
620
621         Reviewed by Philippe Normand.
622
623         This WebKit patch backports a patch from GStreamer 1.17 that prevents
624         the crashes in the attached bug to our flatpak build.
625
626         * buildstream/elements/sdk/gst-plugins-base.bst:
627         * buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Added.
628
629 2020-06-23  Alicia Boya García  <aboya@igalia.com>
630
631         [flatpak] Ensure en_US.UTF-8 locale
632         https://bugs.webkit.org/show_bug.cgi?id=212459
633
634         Reviewed by Philippe Normand.
635
636         When developing WebKit we want as few system differences as possible
637         to make tests reproducible.
638
639         en_US.UTF-8 is indeed the only locale installed in our development
640         flatpak, but our scripts were not correctly clearing most locale
641         environment variables, which resulted in warnings when running some
642         tools (notably perl) when the user OS has a different locale.
643
644         This patch ensures all locale environment variables are cleared and
645         LANG is set to en_US.UTF-8. It also removes now redundant code from
646         flatpakutils.py.
647
648         * flatpak/flatpakutils.py:
649         (WebkitFlatpak.run_in_sandbox):
650         * flatpak/webkit-bwrap:
651
652 2020-06-23  Simon Fraser  <simon.fraser@apple.com>
653
654         [ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure
655         https://bugs.webkit.org/show_bug.cgi?id=213351
656         <rdar://problem/64502429>
657
658         Reviewed by Tim Horton.
659
660         The variadic CGEventCreateScrollWheelEvent() seems to have an issue that causes the resulting event
661         to rarely put the x value into the deltaY. Change to the non-variadic CGEventCreateScrollWheelEvent2()
662         to avoid this.
663
664         * DumpRenderTree/mac/EventSendingController.mm:
665         (-[EventSendingController mouseScrollByX:andY:continuously:]):
666         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
667         * WebKitTestRunner/mac/EventSenderProxy.mm:
668         (WTR::EventSenderProxy::mouseScrollBy):
669         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
670
671 2020-06-23  Diego Pino Garcia  <dpino@igalia.com>
672
673         [ews] Rename 'JSCTestsFactory' to 'JSCBuildAndTestsFactory'
674         https://bugs.webkit.org/show_bug.cgi?id=213503
675
676         Reviewed by Aakash Jain.
677
678         * BuildSlaveSupport/ews-build/config.json:
679         * BuildSlaveSupport/ews-build/factories.py:
680         (JSCBuildAndTestsFactory):
681         (JSCTestsFactory): Deleted.
682         (JSCTestsFactory.__init__): Deleted.
683         * BuildSlaveSupport/ews-build/loadConfig.py:
684
685 2020-06-23  Aakash Jain  <aakash_jain@apple.com>
686
687         [ews] Add JSC-Only builders for MIPS and ARMv7 architectures (follow-up fix)
688         https://bugs.webkit.org/show_bug.cgi?id=213366
689
690         Unreviewed follow-up fix.
691
692         Remove unused runTests parameter.
693         * BuildSlaveSupport/ews-build/factories.py:
694
695 2020-06-23  Philippe Normand  <pnormand@igalia.com>
696
697         [Flatpak SDK] relax restriction on build-webkit script name
698         https://bugs.webkit.org/show_bug.cgi?id=213432
699
700         Reviewed by Žan Doberšek.
701
702         * flatpak/flatpakutils.py:
703         (WebkitFlatpak.run_in_sandbox): Match the build-webkit string in the whole command-line
704         argument and thus allow alternative implementations of build-webkit. Also let the
705         MAX_CPU_LOAD env var in the sandbox.
706
707 2020-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
708
709         [GTK] MiniBrowser: set a base directory for website data and cache
710         https://bugs.webkit.org/show_bug.cgi?id=213368
711
712         Reviewed by Michael Catanzaro.
713
714         Stop using the default ones.
715
716         * MiniBrowser/gtk/main.c:
717         (activate):
718
719 2020-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
720
721         [GTK][WPE] Add API to configure and handle DOM cache to WebKitWebsiteDataManager
722         https://bugs.webkit.org/show_bug.cgi?id=213337
723
724         Reviewed by Adrian Perez de Castro.
725
726         Handle new website data in MiniBrowser and add a unit test.
727
728         * MiniBrowser/gtk/main.c:
729         (gotWebsiteDataCallback):
730         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
731         (testWebsiteDataConfiguration):
732         (testWebsiteDataDOMCache):
733         (beforeAll):
734         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
735         (Test::Test):
736
737 2020-06-22  Diego Pino Garcia  <dpino@igalia.com>
738
739         [ews] Add JSC-Only builders for MIPS and ARMv7 architectures
740         https://bugs.webkit.org/show_bug.cgi?id=213366
741
742         Reviewed by Aakash Jain.
743
744         In a follow-up patch the built product of these bots will be consumed
745         by the EWS JSC-Only testing bots.
746
747         * BuildSlaveSupport/ews-build/config.json:
748         * BuildSlaveSupport/ews-build/factories.py:
749         (JSCBuildFactory):
750         (JSCBuildFactory.__init__):
751         * BuildSlaveSupport/ews-build/factories_unittest.py:
752         (TestBuildFactory):
753         (TestBuildFactory.test_jsc_mipsel_factory):
754         (TestBuildFactory.test_jsc_armv7_factory):
755         * BuildSlaveSupport/ews-build/loadConfig.py:
756
757 2020-06-22  Fujii Hironori  <Hironori.Fujii@sony.com>
758
759         [Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing
760         https://bugs.webkit.org/show_bug.cgi?id=213452
761
762         Reviewed by Yusuke Suzuki.
763
764         If window.alert() was given an invalid UTF-16 sequence, Windows
765         DumpRenderTree output it without any conversions. It should output
766         "(null)" to match with WebKitTestRunner behavior.
767
768         * DumpRenderTree/win/UIDelegate.cpp:
769         (toMessage): Added
770         (UIDelegate::runJavaScriptAlertPanelWithMessage):
771         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
772         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
773         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
774         (UIDelegate::setStatusText):
775
776 2020-06-22  Jer Noble  <jer.noble@apple.com>
777
778         [ macOS iOS ] (r263321): TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.SleepDisabler.Reload are constant failures
779         https://bugs.webkit.org/show_bug.cgi?id=213475
780         <rdar://problem/64603555>
781
782         Reviewed by Eric Carlson.
783
784         Looks like the SleepDisabler can come and go while the TestWebKitAPI process is spinning, so make the
785         Reload and Load tests more deterministic by only checking SleepDisabler after getting a "playing" message
786         from the WebContent process.
787
788         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
789         (SleepDisabler::runAndWaitUntilPlaying):
790         (SleepDisabler::loadPlayingPage):
791         (TEST_F):
792
793 2020-06-22  Jonathan Bedard  <jbedard@apple.com>
794
795         resultsdbpy: Make architecture differences explicit
796         https://bugs.webkit.org/show_bug.cgi?id=213473
797         <rdar://problem/64602736>
798
799         Rubber-stamped by Aakash Jain.
800
801         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
802         (Configuration.prototype.toString):
803
804 2020-06-22  Tim Horton  <timothy_horton@apple.com>
805
806         Update macOS version macros
807         https://bugs.webkit.org/show_bug.cgi?id=213484
808
809         Reviewed by Alexey Proskuryakov.
810
811         * ContentExtensionTester/Configurations/Base.xcconfig:
812         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
813         * DumpRenderTree/mac/Configurations/Base.xcconfig:
814         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
815         * ImageDiff/cg/Configurations/Base.xcconfig:
816         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
817         * MiniBrowser/Configurations/Base.xcconfig:
818         * MiniBrowser/Configurations/DebugRelease.xcconfig:
819         * TestWebKitAPI/Configurations/Base.xcconfig:
820         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
821         * WebEditingTester/Configurations/Base.xcconfig:
822         * WebEditingTester/Configurations/DebugRelease.xcconfig:
823         * WebKitTestRunner/Configurations/Base.xcconfig:
824         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
825         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
826         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
827
828 2020-06-22  Tim Horton  <timothy_horton@apple.com>
829
830         API Test WeakLinking.WeakImport fails on arm64
831         https://bugs.webkit.org/show_bug.cgi?id=213477
832
833         Reviewed by Alexey Proskuryakov.
834
835         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
836         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:
837         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd:
838         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd:
839         Add this architecture to the TBD files.
840
841 2020-06-22  Jonathan Bedard  <jbedard@apple.com>
842
843         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x3)
844         https://bugs.webkit.org/show_bug.cgi?id=213402
845         <rdar://problem/64542588>
846
847         Reviewed by Alexey Proskuryakov.
848
849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
850         (WebKitBuildbot): 64 bit is more correct for watchOS embedded builds.
851
852 2020-06-22  Aakash Jain  <aakash_jain@apple.com>
853
854         [ews] Switch contributors.json url from trac to svn server
855         https://bugs.webkit.org/show_bug.cgi?id=213457
856
857         Reviewed by Jonathan Bedard.
858
859         * BuildSlaveSupport/ews-build/steps.py:
860         (ValidateCommiterAndReviewer):
861         (ValidateCommiterAndReviewer.load_contributors_from_trac):
862
863 2020-06-22  Philippe Normand  <pnormand@igalia.com>
864
865         [Flatpak SDK] Persist sccache auth token across flatpak updates
866         https://bugs.webkit.org/show_bug.cgi?id=213427
867
868         Reviewed by Žan Doberšek.
869
870         After a successful flatpak update check if an sccache auth token exists and reuse it when
871         updating the sccache config file.
872
873         * flatpak/flatpakutils.py:
874         (WebkitFlatpak.save_config):
875
876 2020-06-21  Yusuke Suzuki  <ysuzuki@apple.com>
877
878         [WTF] URL should support dataLog
879         https://bugs.webkit.org/show_bug.cgi?id=213450
880
881         Reviewed by Mark Lam.
882
883         Add test for URL::dump.
884
885         * TestWebKitAPI/Tests/WTF/URL.cpp:
886         (TestWebKitAPI::TEST_F):
887
888 2020-06-21  Philippe Normand  <pnormand@igalia.com>
889
890         [Flatpak] Nightly runner fails to extract zip files
891         https://bugs.webkit.org/show_bug.cgi?id=213445
892
893         Reviewed by Darin Adler.
894
895         * Scripts/webkit-flatpak-run-nightly: Ensure the buffered zip data is written to disk before
896         extraction.
897
898 2020-06-21  Jer Noble  <jer.noble@apple.com>
899
900         WebKit fails to leave audio routing arbitration during navigation, closing.
901         https://bugs.webkit.org/show_bug.cgi?id=213426
902         <rdar://problem/64395051>
903
904         Reviewed by Eric Carlson.
905
906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
907         * TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: Added.
908         (AudioRoutingArbitration::statusShouldBecomeEqualTo):
909         (TEST_F):
910
911 2020-06-20  Jer Noble  <jer.noble@apple.com>
912
913         REGRESSION(r259219): Sleep assertion remains active if WKWebView is closed or WebContent process crashes
914         https://bugs.webkit.org/show_bug.cgi?id=213434
915         <rdar://problem/57541662>
916
917         Reviewed by Eric Carlson.
918
919         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
920         (SleepDisabler::loadPlayingPage):
921         (SleepDisabler::hasSleepDisablerShouldBecomeEqualTo):
922         (TEST_F):
923
924 2020-06-20  Jonathan Bedard  <jbedard@apple.com>
925
926         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x2)
927         https://bugs.webkit.org/show_bug.cgi?id=213402
928         <rdar://problem/64542588>
929
930         Unreviewed test fix.
931
932         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Native Macs never
933         use 32 bit tool binaries.
934
935 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
936
937         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix)
938         https://bugs.webkit.org/show_bug.cgi?id=213402
939         <rdar://problem/64542588>
940
941         Unreviewed build-fix.
942
943         * BuildSlaveSupport/build.webkit.org-config/config.json: Use arm64_32 to build watchOS device.
944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
945         (WebKitBuildbot): watchOS device should be considered 32 bit.
946         * Scripts/configure-xcode-for-embedded-development: Force-copy MediaAccessibility.framework.
947         * Scripts/webkitdirs.pm:
948         (extractNonMacOSHostConfiguration): Native Macs never use 32 bit tool binaries.
949
950 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
951
952         Delete dead code for old ews api tests
953         https://bugs.webkit.org/show_bug.cgi?id=213421
954
955         Rubber-stamped by Alexey Proskuryakov.
956
957         * Scripts/webkitpy/common/config/ports.py:
958         (DeprecatedPort.run_api_tests_command): Deleted.
959         * Scripts/webkitpy/common/net/apitestresults.py: Removed.
960         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Removed.
961         * Scripts/webkitpy/port/base.py:
962         (Port.bindings_results_directory):
963         (Port.api_results_directory): Deleted.
964         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Removed.
965         * Scripts/webkitpy/tool/steps/runtests.py:
966         (RunTests._run_api_tests): Deleted.
967         * Scripts/webkitpy/tool/steps/steps_unittest.py:
968         (test_runtests_api_debug): Deleted.
969
970 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
971
972         Bring up watchOS/tvOS on build.webkit.org
973         https://bugs.webkit.org/show_bug.cgi?id=213402
974         <rdar://problem/64542588>
975
976         Unreviewed infrastructure fix.
977
978         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
979         (_should_file_trigger_build): Add tvOS and watchOS.
980         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
981         (ShouldBuildTest):
982         (ShouldBuildTest.test_should_build):
983
984 2020-06-19  Jiewen Tan  <jiewen_tan@apple.com>
985
986         [WebAuthn] Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients if the returned PIN from the client is not valid
987         https://bugs.webkit.org/show_bug.cgi?id=213404
988         <rdar://problem/64543894>
989
990         Reviewed by Brent Fulgham.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
993         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
994         (TestWebKitAPI::TEST):
995         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-fake-pin-invalid-error-retry.html: Added.
996
997 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
998
999         Bring up watchOS/tvOS on build.webkit.org
1000         https://bugs.webkit.org/show_bug.cgi?id=213402
1001         <rdar://problem/64542588>
1002
1003         Reviewed by Aakash Jain.
1004
1005         * BuildSlaveSupport/build.webkit.org-config/config.json: Add AppleTV and watchOS builders.
1006         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1007         (BuildFactory.__init__): Support AppleTV and watchOS.
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13.png: Added.
1009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13@2x.png: Added.
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator.png: Added.
1011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator@2x.png: Added.
1012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6.png: Added.
1013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6@2x.png: Added.
1014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6.png: Added.
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6@2x.png: Added.
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1019         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1020         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1021
1022 2020-06-19  Saam Barati  <sbarati@apple.com>
1023
1024         Have a memory monitor thread in jsc shell when running tests using --memory-limited
1025         https://bugs.webkit.org/show_bug.cgi?id=213389
1026
1027         Reviewed by Mark Lam.
1028
1029         * Scripts/run-jsc-stress-tests:
1030         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
1031         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
1032
1033 2020-06-19  Chris Fleizach  <cfleizach@apple.com>
1034
1035         AX: Make isolated tree enablement status dependent on client preference
1036         https://bugs.webkit.org/show_bug.cgi?id=213355
1037         <rdar://problem/64506577>
1038
1039         Reviewed by Zalan Bujtas.
1040
1041         * MiniBrowser/mac/AppDelegate.m:
1042         (-[BrowserAppDelegate defaultConfiguration]):
1043
1044 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
1045
1046         Improve handling of trac downtime by commit-queue
1047         https://bugs.webkit.org/show_bug.cgi?id=213377
1048
1049         Reviewed by Jonathan Bedard.
1050
1051         * BuildSlaveSupport/ews-build/steps.py: Load contributors.json from disk when loading from trac fails.
1052         (ValidateCommiterAndReviewer.load_contributors_from_disk):
1053         (ValidateCommiterAndReviewer.load_contributors_from_trac):
1054         (ValidateCommiterAndReviewer.load_contributors):
1055         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test
1056
1057 2020-06-19  Lauro Moura  <lmoura@igalia.com>
1058
1059         [WPE] Warn potential issues when creating WindowViewBackend
1060         https://bugs.webkit.org/show_bug.cgi?id=213326
1061
1062         Reviewed by Philippe Normand.
1063
1064         Make it easier to debug eventual GL issues when starting up MiniBrowser in
1065         windowed mode.
1066
1067         * wpe/backends/WindowViewBackend.cpp:
1068         (WPEToolingBackends::WaylandEGLConnection::singleton):
1069         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1070
1071 2020-06-19  Lauro Moura  <lmoura@igalia.com>
1072
1073         [webkitpy][WPE] Default to headless if _display_server is xfvb
1074         https://bugs.webkit.org/show_bug.cgi?id=213327
1075
1076         Reviewed by Philippe Normand.
1077
1078         Xvfb is used as the default display server for some scripts, and the
1079         equivalent for WPE is the headless one.
1080
1081         WTR and the API tests already create only HeadlessViewBackends, but the
1082         WebDriver tests create them through MiniBrowser, which requires the
1083         '--headless' parameter.
1084
1085         * Scripts/run-webdriver-tests: Do not override _display_server
1086         * Scripts/webkitpy/port/base.py:
1087         (Port.__init__): Define _display_server for all ports to avoid
1088         eventually needing to override it.
1089         * Scripts/webkitpy/port/wpe.py:
1090         (WPEPort.__init__): Default to 'headless' if _display_server is 'xvfb'
1091         * Scripts/webkitpy/w3c/wpt_runner.py:
1092         (main): Dot not override _display_server
1093
1094 2020-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1095
1096         Add support for fetching registrable domains with resource load statistics
1097         https://bugs.webkit.org/show_bug.cgi?id=213291
1098
1099         Reviewed by Adrian Perez de Castro.
1100
1101         Update GLib ITP unit test to check also fetch and remove.
1102
1103         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1104         (testWebsiteDataITP):
1105
1106 2020-06-19  Tomoki Imai  <Tomoki.Imai@sony.com>
1107
1108         Change my (Tomoki Imai's) status to committer
1109
1110         Unreviewed, just updating contributors.json for myself.
1111
1112         * Scripts/webkitpy/common/config/contributors.json:
1113
1114 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
1115
1116         Add SPI to preconnect to a server (Follow-up fix)
1117         https://bugs.webkit.org/show_bug.cgi?id=213109
1118         <rdar://problem/64184412>
1119
1120         Unreviewed build-fix.
1121
1122         * TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm: HTTPServer does not exist if HAVE(NETWORK_FRAMEWORK) is false.
1123
1124 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
1125
1126         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions (build-fix)
1127         https://bugs.webkit.org/show_bug.cgi?id=213183
1128         <rdar://problem/64273483>
1129
1130         Unreviewed build fix.
1131
1132         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1133         (webViewWithAutofocusedInput): bool may not be the same type as BOOL.
1134
1135 2020-06-18  Saam Barati  <sbarati@apple.com>
1136
1137         call skip when skipping JetStream2 wasm test
1138         https://bugs.webkit.org/show_bug.cgi?id=213354
1139
1140         Reviewed by Yusuke Suzuki.
1141
1142         So we can see the logging that we're skipping.
1143
1144         * Scripts/run-jsc-stress-tests:
1145
1146 2020-06-18  Joonghun Park  <jh718.park@samsung.com>
1147
1148     Unreviewed. Remove the build warning below since r262971.
1149     warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
1150
1151         * WebKitTestRunner/TestController.cpp:
1152         (WTR::getAllStorageAccessEntriesCallback):
1153
1154 2020-06-18  Ross Kirsling  <ross.kirsling@sony.com>
1155
1156         [Intl] Enable RelativeTimeFormat and Locale by default
1157         https://bugs.webkit.org/show_bug.cgi?id=213324
1158
1159         Reviewed by Yusuke Suzuki.
1160
1161         * Scripts/run-jsc-stress-tests:
1162         Remove feature flags.
1163
1164 2020-06-18  Andy Estes  <aestes@apple.com>
1165
1166         Unreviewed build fix after r263194
1167
1168         * WebKitTestRunner/ios/TestControllerIOS.mm:
1169         (WTR::TestController::platformResetStateToConsistentValues): Guarded code that mentions
1170         UIContextMenuInteraction with USE(UICONTEXTMENU).
1171
1172 2020-06-18  Ryan Haddad  <ryanhaddad@apple.com>
1173
1174         Unreviewed infrastructure fix, temporarily remove ews116 due to hardware failure tracked with rdar://64424245
1175
1176         * BuildSlaveSupport/ews-build/config.json:
1177
1178 2020-06-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1179
1180         [GTK][WPE] Add API to configure and handle service worker registrations to WebKitWebsiteDataManager
1181         https://bugs.webkit.org/show_bug.cgi?id=213290
1182
1183         Reviewed by Michael Catanzaro.
1184
1185         Handle new website data in MiniBrowser and add a unit test.
1186
1187         * MiniBrowser/gtk/main.c:
1188         (gotWebsiteDataCallback):
1189         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1190         (serverCallback):
1191         (testWebsiteDataConfiguration):
1192         (testWebsiteDataEphemeral):
1193         (testWebsiteDataITP):
1194         (testWebsiteDataServiceWorkerRegistrations):
1195         (beforeAll):
1196         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1197         (Test::Test):
1198
1199 2020-06-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1200
1201         RebaselineServer: "Rebaseline queue" button is placed behind the footer
1202         https://bugs.webkit.org/show_bug.cgi?id=213258
1203
1204         Reviewed by Zalan Bujtas.
1205
1206         * Scripts/webkitpy/tool/servers/data/rebaselineserver/index.html: Moved 'log' and 'queue' elements after 'footer' element.
1207         * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
1208         (#queue): Changed 'bottom' property from 3em to 4em.
1209
1210 2020-06-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1211
1212         [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
1213         https://bugs.webkit.org/show_bug.cgi?id=213320
1214         <rdar://problem/63831962>
1215
1216         Reviewed by Tim Horton.
1217
1218         Add a new API test to verify that preventing the "keypress" event for shift+tab in an SPI-editable web view
1219         causes us to avoid relinquishing focus.
1220
1221         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1222
1223 2020-06-17  Andy Estes  <aestes@apple.com>
1224
1225         REGRESSION (r258092): fast/forms/ios/file-upload-panel.html fails when HAVE(UICONTEXTMENU_LOCATION)
1226         https://bugs.webkit.org/show_bug.cgi?id=213314
1227         <rdar://problem/60339129>
1228
1229         Reviewed by Maciej Stachowiak.
1230
1231         fast/forms/ios/file-upload-panel.html sets the shouldHandleRunOpenPanel and
1232         shouldPresentPopovers test options to false so that WKTR will (a) not register a
1233         runOpenPanel UI delegate callback, causing WebKit to create a WKFileUploadPanel instead, and
1234         (b) swizzle two UIKit view controller presentation methods to prevent the document picker
1235         menu from being presented. The test merely wants the WKFileUploadPanel instance to exist in
1236         order to query its available actions, not for it to show UI.
1237
1238         In r258092, WKFileUploadPanel now sometimes uses a UIContextMenuInteraction instance to
1239         present the document picker menu, but -[UIContextMenuInteraction _presentMenuAtLocation:]
1240         fails due to WKTR's above-mentioned swizzling. When this failure occurs,
1241         UIContextMenuInteraction calls -contextMenuInteraction:willEndForConfiguration:animator: on
1242         its delegate (the WKFileUploadPanel), which dismisses the open panel before the test has had
1243         a chance to query the available actions.
1244
1245         Fixed this by swizzling -[UIContextMenuInteraction _presentMenuAtLocation:] when the
1246         shouldPresentPopovers test option is false.
1247
1248         * WebKitTestRunner/ios/TestControllerIOS.mm:
1249         (overridePresentMenuOrPopoverOrViewController): Renamed from
1250         overridePresentViewControllerOrPopover.
1251         (WTR::TestController::platformResetStateToConsistentValues): Swizzled
1252         -[UIContextMenuInteraction _presentMenuAtLocation:] with
1253         overridePresentMenuOrPopoverOrViewController when the shouldPresentPopovers test option is
1254         false.
1255         (overridePresentViewControllerOrPopover): Renamed to
1256         overridePresentMenuOrPopoverOrViewController.
1257
1258 2020-06-17  Sihui Liu  <sihui_liu@apple.com>
1259
1260         REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
1261         https://bugs.webkit.org/show_bug.cgi?id=213311
1262         <rdar://problem/64456413>
1263
1264         Reviewed by Wenson Hsieh.
1265
1266         TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long 
1267         enough to make sure TextManipulationController gets notified about the insertion and starts observing.
1268
1269         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1270         (TestWebKitAPI::TEST):
1271
1272 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1273
1274         Delete code for old ews bindings queue
1275         https://bugs.webkit.org/show_bug.cgi?id=213315
1276
1277         Rubber-stamped by Alexey Proskuryakov.
1278
1279         * Scripts/webkitpy/common/config/ews.json:
1280         * Scripts/webkitpy/common/config/ports.py:
1281         (DeprecatedPort.run_bindings_tests_command): Deleted.
1282         (WinPort.run_bindings_tests_command): Deleted.
1283         * Scripts/webkitpy/common/config/ports_mock.py:
1284         (MockPort.run_bindings_tests_command): Deleted.
1285         * Scripts/webkitpy/common/net/generictestresults.py: Removed.
1286         * Scripts/webkitpy/common/net/generictestresults_unittest.py: Removed.
1287         * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Removed.
1288         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1289         (PatchAnalysisTask._retry_bindings_tests): Deleted.
1290         * Scripts/webkitpy/tool/bot/retrylogic_unittest.py:
1291         (MockBindingsEarlyWarningSystem): Deleted.
1292         (MockBindingsEarlyWarningSystem.__init__): Deleted.
1293         (MockBindingsEarlyWarningSystem.test_results): Deleted.
1294         (BindingsEarlyWarningSystemTest): Deleted.
1295         (BindingsEarlyWarningSystemTest._results_indicate_all_passed): Deleted.
1296         (BindingsEarlyWarningSystemTest._create_task): Deleted.
1297         (BindingsEarlyWarningSystemTest.test_success_case): Deleted.
1298         (BindingsEarlyWarningSystemTest.test_test_failure): Deleted.
1299         (BindingsEarlyWarningSystemTest.test_fix): Deleted.
1300         (BindingsEarlyWarningSystemTest.test_ineffective_patch): Deleted.
1301         (BindingsEarlyWarningSystemTest.test_partially_effective_patch): Deleted.
1302         (BindingsEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Deleted.
1303         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1304         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1305         (TestBindingsEWS): Deleted.
1306         (AbstractEarlyWarningSystemTest.test_failing_bindings_tests_message): Deleted.
1307         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1308         * Scripts/webkitpy/tool/steps/runtests.py:
1309         (RunTests._run_bindings_tests): Deleted.
1310         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1311         (test_patch_relevant_bindings): Deleted.
1312         (test_runtests_api): Deleted.
1313
1314 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1315
1316         Delete code for old ews style queue
1317         https://bugs.webkit.org/show_bug.cgi?id=213297
1318
1319         Rubber-stamped by Alexey Proskuryakov.
1320
1321         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Removed.
1322         * Scripts/webkitpy/tool/commands/queues.py:
1323         (StyleQueue): Deleted.
1324         (StyleQueue.__init__): Deleted.
1325         (StyleQueue.review_patch): Deleted.
1326         (StyleQueue.run_command): Deleted.
1327         (StyleQueue.expected_failures): Deleted.
1328         (StyleQueue.refetch_patch): Deleted.
1329         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1330         (TestReviewQueue): Deleted.
1331
1332 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1333
1334         Delete code for old ews webkitpy queue
1335         https://bugs.webkit.org/show_bug.cgi?id=213299
1336
1337         Reviewed by Jonathan Bedard.
1338
1339         * Scripts/webkitpy/common/config/ews.json:
1340         * Scripts/webkitpy/common/net/generictestresults.py:
1341         (WebkitpyTestResults): Deleted.
1342         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1343         * Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Removed.
1344         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1345         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1346         (TestWebkitpyEWS): Deleted.
1347         (AbstractEarlyWarningSystemTest.test_failing_webkitpy_tests_message): Deleted.
1348         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1349         * Scripts/webkitpy/tool/steps/runtests.py:
1350         (RunTests._run_webkitpy_tests): Deleted.
1351         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1352         (test_runtests_webkitpy): Deleted.
1353         (test_patch_not_relevant_bindings): Deleted.
1354         (test_runtests_api_debug): Deleted.
1355
1356 2020-06-17  Keith Miller  <keith_miller@apple.com>
1357
1358         WebKitTestRunner should not crash on alert with invalid utf16 strings
1359         https://bugs.webkit.org/show_bug.cgi?id=213269
1360
1361         Reviewed by Simon Fraser.
1362
1363         * WebKitTestRunner/StringFunctions.h:
1364         (WTR::toWTFString):
1365
1366 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1367
1368         Delete old ews client side code - part 2
1369         https://bugs.webkit.org/show_bug.cgi?id=213262
1370
1371         Reviewed by Alexey Proskuryakov.
1372
1373         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1374         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1375         (PatchAnalysisTaskDelegate.command_passed): Deleted.
1376         (PatchAnalysisTaskDelegate.command_failed): Deleted.
1377         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1378         (AbstractEarlyWarningSystem.command_passed): Deleted.
1379         (AbstractEarlyWarningSystem.command_failed): Deleted.
1380         * Scripts/webkitpy/tool/commands/perfalizer.py:
1381         (PerfalizerTask.command_passed): Deleted.
1382         (PerfalizerTask.command_failed): Deleted.
1383         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1384         * Scripts/webkitpy/tool/commands/queues.py:
1385         (AbstractPatchQueue._next_patch): Deleted.
1386         (AbstractPatchQueue._did_error): Deleted.
1387         (AbstractPatchQueue._did_skip): Deleted.
1388         (AbstractPatchQueue._unlock_patch): Deleted.
1389         (StyleQueue.command_passed): Deleted.
1390         (StyleQueue.command_failed): Deleted.
1391
1392 2020-06-17  Paulo Matos  <pmatos@igalia.com>
1393
1394         Add new Igalia EWS workers for ARM/MIPS
1395         https://bugs.webkit.org/show_bug.cgi?id=212803
1396
1397         Reviewed by Aakash Jain.
1398
1399         * BuildSlaveSupport/ews-build/config.json:
1400
1401 2020-06-16  Mark Lam  <mark.lam@apple.com>
1402
1403         TestWebKitAPI.WebCore.WildcardStringMatching needs to initialize Options before accessing them.
1404         https://bugs.webkit.org/show_bug.cgi?id=213270
1405         <rdar://problem/64427499>
1406
1407         Reviewed by Yusuke Suzuki.
1408
1409         * TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
1410         (TestWebKitAPI::TEST):
1411
1412 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1413
1414         Text manipulation should not re-extract elements whose children have been manipulated
1415         https://bugs.webkit.org/show_bug.cgi?id=213276
1416         <rdar://problem/64193446>
1417
1418         Reviewed by Tim Horton.
1419
1420         Add a new API test where we start and complete text manipulation, and then hide and show the manipulated
1421         element. This test verifies that the new item callbacks are *not* called after element is shown again.
1422
1423         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1424         (TestWebKitAPI::TEST):
1425
1426 2020-06-16  Saam Barati  <sbarati@apple.com>
1427
1428         Fix two typos "signifcant" and "signficance". Should be "significant" and "significance"
1429
1430         * Scripts/compare-results:
1431         (displayStr):
1432         (computeMultipleHypothesesSignificance):
1433         (dumpBreakdowns):
1434         (writeCSV):
1435         (computeMultipleHypothesesSignficance): Deleted.
1436
1437 2020-06-16  Andres Gonzalez  <andresg_22@apple.com>
1438
1439         Fix for accessibility/textarea-selected-text-range.html in isolated tree mode.
1440         https://bugs.webkit.org/show_bug.cgi?id=213257
1441
1442         Reviewed by Chris Fleizach.
1443
1444         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1445         (WTR::setAttributeValue):
1446         (WTR::AccessibilityUIElement::selectedTextRange): Dispatch call into
1447         WebAccessibilityWrapper onto AX secondary thread to simulate isolated
1448         tree mode.
1449
1450 2020-06-16  Saam Barati  <sbarati@apple.com>
1451
1452         Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni
1453         https://bugs.webkit.org/show_bug.cgi?id=213219
1454
1455         Reviewed by Mark Lam.
1456
1457         My previous patch here used Bonferroni to do multiple hypotheses correction.
1458         Bonferroni does a good job at reducing false positive rate (type I error,
1459         saying something is significant when it's not, e.g, rejecting the null
1460         hypothesis when we shouldn't), but at the expense of also having a high
1461         false negative rate (type II error, saying something is not significant when
1462         it is, e.g, not rejecting the null hypothesis when we should).
1463         
1464         After doing a bit more reading, it seems like using a technique called False
1465         Discovery Rate (FDR) is better. It still does a good job at controlling type
1466         I error rate, but without sacrificing a high type II error rate. FDR is based
1467         on a technique for "estimating the proportion of wrongly rejected null hypotheses" [2].
1468         
1469         This patch uses Benjamini and Hochberg estimation of FDR, which relies
1470         on hypotheses being independent. We know subtests in a benchmark aren't
1471         fully independent variables, but it's a good enough approximation.
1472         
1473         You can read more about FDR:
1474         1. https://www.stat.berkeley.edu/~mgoldman/Section0402.pdf
1475         2. https://besjournals.onlinelibrary.wiley.com/doi/10.1111/j.2041-210X.2010.00061.x
1476         3. https://en.wikipedia.org/wiki/False_discovery_rate
1477
1478         * Scripts/compare-results:
1479         (displayStr):
1480         (computeMultipleHypothesesSignficance):
1481         (dumpBreakdowns):
1482         (writeCSV):
1483
1484 2020-06-16  David Kilzer  <ddkilzer@apple.com>
1485
1486         REGRESSION (r262994): Web Inspector is killed when context-clicking anywhere
1487         <https://webkit.org/b/213224>
1488         <rdar://problem/64383320>
1489
1490         Reviewed by Darin Adler.
1491
1492         * TestWebKitAPI/CMakeLists.txt:
1493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1494         - Add ContextMenuAction.cpp to build systems.
1495         * TestWebKitAPI/Tests/WebCore/ContextMenuAction.cpp: Add.
1496         (TestWebKitAPI::TEST):
1497         - Add TestWebKitAPI.WebCore.ContextMenuAction_IsValidEnum.
1498
1499 2020-06-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1500
1501         [Win] Mouse dragging tests are failing because WebKitTestRunner dispatches WM_MOUSELEAVE to the hidden WebView
1502         https://bugs.webkit.org/show_bug.cgi?id=213239
1503
1504         Reviewed by Don Olmstead.
1505
1506         There are two problems:
1507         1. Windows EventSenderProxy::mouseMoveTo doesn't set WPARAM of WM_MOUSEMOVE
1508         2. Unexpected WM_MOUSELEAVE discontinues the mouse dragging events
1509
1510         WPARAM of WM_MOUSEMOVE should represent pressed mouse buttons while dragging.
1511
1512         WM_MOUSELEAVE is unexpectedly dispatched because the mouse cursor
1513         is always out of the hidden WebView. The unexpected WM_MOUSELEAVE
1514         discontinues dragging events. WM_MOUSELEAVE shouldn't be
1515         dispatched in WebKitTestRunner. Ignore it.
1516
1517         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1518         (WTR::EventSenderProxy::mouseDown):
1519         (WTR::EventSenderProxy::mouseUp):
1520         (WTR::EventSenderProxy::mouseMoveTo): Set MK_LBUTTON to WPARAM of
1521         WM_MOUSEMOVE while dragging.
1522         * WebKitTestRunner/win/TestControllerWin.cpp:
1523         (WTR::runRunLoopUntil): Ignore WM_MOUSELEAVE.
1524
1525 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1526
1527         Text manipulation should handle nested item boundary elements
1528         https://bugs.webkit.org/show_bug.cgi?id=213251
1529         <rdar://problem/63371514>
1530
1531         Reviewed by Sihui Liu.
1532
1533         Add a new API test to exercise this scenario.
1534
1535         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1536
1537 2020-06-16  Charlie Turner  <cturner@igalia.com>
1538
1539         [GTK] Disable video autoplay
1540         https://bugs.webkit.org/show_bug.cgi?id=184845
1541
1542         Reviewed by Carlos Garcia Campos.
1543
1544         Update the various callsites for constructing a view to take into
1545         account the default policies. I chose the default as autoplay
1546         allow without sound, which is in keeping with WebCore's choice.
1547
1548         * MiniBrowser/gtk/BrowserWindow.c:
1549         (webViewDecidePolicy):
1550         (newTabCallback):
1551         (openPrivateWindow):
1552         (browser_window_get_or_create_web_view_for_automation):
1553         (browser_window_create_web_view_in_new_tab_for_automation):
1554         * MiniBrowser/gtk/main.c:
1555         (createBrowserTab):
1556         (main):
1557         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Add
1558         autoplay policy tests, and use modern class initializers.
1559         (testAutoplayPolicy):
1560         (beforeAll):
1561
1562 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1563
1564         [Flatpak SDK] Subversion perl bindings unusable
1565         https://bugs.webkit.org/show_bug.cgi?id=213241
1566
1567         Reviewed by Sergio Villar Senin.
1568
1569         * buildstream/elements/sdk/subversion.bst: The svn swig perl library wasn't correctly
1570         installed, leading to undefined symbols when importing it from the bindings. A new
1571         integration command now tests this.
1572
1573 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1574
1575         [Flatpak SDK] Update to Qt 5.15
1576         https://bugs.webkit.org/show_bug.cgi?id=213192
1577
1578         Reviewed by Sergio Villar Senin.
1579
1580         The new patch comes from the upstream KDE SDK: https://github.com/KDE/flatpak-kde-runtime/tree/qt5.15lts/patch
1581         
1582         * buildstream/elements/qt5/qtbase.bst:
1583         * buildstream/elements/qt5/qtdeclarative.bst:
1584         * buildstream/elements/qt5/qtquickcontrols.bst:
1585         * buildstream/elements/qt5/qtquickcontrols2.bst:
1586         * buildstream/elements/qt5/qtwayland.bst:
1587         * buildstream/elements/qt5/qtx11extras.bst:
1588         * buildstream/patches/qtbase-make-sure-to-correctly-construct-base-platform-theme.patch: Added.
1589         * buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Removed.
1590         * buildstream/project.conf:
1591
1592 2020-06-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         [GTK][WPE] Add API to configure and enable resource load statistics
1595         https://bugs.webkit.org/show_bug.cgi?id=177943
1596
1597         Reviewed by Michael Catanzaro.
1598
1599         Add --enable-itp command line version to MiniBrowser and unit tests to check the new API.
1600
1601         * MiniBrowser/gtk/main.c:
1602         (gotWebsiteDataCallback):
1603         (activate):
1604         * MiniBrowser/wpe/main.cpp:
1605         (main):
1606         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1607         (serverCallback):
1608         (testWebsiteDataConfiguration):
1609         (testWebsiteDataEphemeral):
1610         (testWebsiteDataITP):
1611         (beforeAll):
1612         * TestWebKitAPI/glib/TestExpectations.json:
1613         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1614         (Test::Test):
1615         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1616         (directoryChangedCallback):
1617         (WebViewTest::waitUntilFileChanged):
1618         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1619
1620 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1621
1622         REGRESSION(r263029): [Flatpak SDK] Broke initial SDK installation
1623
1624         Rubber-stamped by Žan Doberšek.
1625
1626         * flatpak/flatpakutils.py:
1627         (FlatpakObject.version): Gracefully return an empty version when the flatpak info command
1628         fails. This usually means the app has not been installed yet.
1629
1630 2020-06-15  Megan Gardner  <megan_gardner@apple.com>
1631
1632         Text form controls can scroll by 1px when value is the same length as size. No scrolling should happen.
1633         https://bugs.webkit.org/show_bug.cgi?id=212856
1634         <rdar://problem/63541707>
1635
1636         Reviewed by Zalan Bujtas.
1637
1638         Rebased to reflect new sizes.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1641         (TEST):
1642         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1643         (TestWebKitAPI::TEST):
1644
1645 2020-06-15  Jonathan Bedard  <jbedard@apple.com>
1646
1647         Follow-up fix: Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
1648         https://bugs.webkit.org/show_bug.cgi?id=213144
1649         <rdar://problem/64316743>
1650
1651         Unreviewed build fix.
1652
1653         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Guard didFinishNavigation declaration with HAVE(NETWORK_FRAMEWORK).
1654
1655 2020-06-15  Alex Christensen  <achristensen@webkit.org>
1656
1657         Provide alternatively-named SPI for user style sheets and scripts
1658         https://bugs.webkit.org/show_bug.cgi?id=213206
1659
1660         Reviewed by Brady Eidson.
1661
1662         * DumpRenderTree/mac/DumpRenderTree.mm:
1663         (fontAllowList):
1664         (createWebViewAndOffscreenWindow):
1665         (resetWebViewToConsistentStateBeforeTesting):
1666         (fontWhitelist): Deleted.
1667         * DumpRenderTree/mac/TestRunnerMac.mm:
1668         (TestRunner::addOriginAccessWhitelistEntry):
1669         (TestRunner::removeOriginAccessWhitelistEntry):
1670         (TestRunner::addUserScript):
1671         (TestRunner::addUserStyleSheet):
1672         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1673         (TEST):
1674         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
1675         (TEST):
1676         * WebKitTestRunner/mac/TestControllerMac.mm:
1677         (WTR::generateFontAllowList):
1678         (WTR::TestController::platformInitializeContext):
1679         (WTR::generateWhitelist): Deleted.
1680
1681 2020-06-15  Alex Christensen  <achristensen@webkit.org>
1682
1683         Add SPI to preconnect to a server
1684         https://bugs.webkit.org/show_bug.cgi?id=213109
1685         <rdar://problem/64184412>
1686
1687         Reviewed by Geoff Garen.
1688
1689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1690
1691 2020-06-15  Keith Miller  <keith_miller@apple.com>
1692
1693         Signal handlers should have a two phase installation.
1694         https://bugs.webkit.org/show_bug.cgi?id=213160
1695
1696         Reviewed by Mark Lam.
1697
1698         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1699         (TEST):
1700
1701 2020-06-15  Sihui Liu  <sihui_liu@apple.com>
1702
1703         Text manipulation does not observe newly displayed element inside previously observed content
1704         https://bugs.webkit.org/show_bug.cgi?id=213156
1705
1706         Reviewed by Darin Adler.
1707
1708         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1709         (TestWebKitAPI::TEST):
1710
1711 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1712
1713         [Flatpak SDK] Bump Subversion and enable Perl bindings
1714         https://bugs.webkit.org/show_bug.cgi?id=213189
1715
1716         Reviewed by Žan Doberšek.
1717
1718         * buildstream/elements/sdk-build-depends/swig.bst: Added.
1719         * buildstream/elements/sdk/subversion.bst: Enable Perl bindings so that git svn can be used within the sandbox.
1720
1721 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1722
1723         [Flatpak SDK] flatpak update still not displayed
1724         https://bugs.webkit.org/show_bug.cgi?id=213180
1725
1726         Reviewed by Žan Doberšek.
1727
1728         Added a new --version option to the script. We no longer gather the flatpak update command
1729         output to know if something was updated or not. Instead we get the version of the SDK prior
1730         to the update operation and compare that with the version after the update.
1731
1732         * flatpak/flatpakutils.py:
1733         (FlatpakObject.version):
1734         (WebkitFlatpak.load_from_args):
1735         (WebkitFlatpak.main):
1736
1737 2020-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1738
1739         [GTK][WPE] Add API to expose UIClient::requestStorageAccessConfirm
1740         https://bugs.webkit.org/show_bug.cgi?id=210422
1741
1742         Reviewed by Michael Catanzaro.
1743
1744         Handle WebKitWebsiteDataAccessPermissionRequest in MiniBrowser.
1745
1746         * MiniBrowser/gtk/BrowserTab.c:
1747         (decidePermissionRequest):
1748
1749 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1750
1751         [Flatpak SDK] Add libavif
1752         https://bugs.webkit.org/show_bug.cgi?id=212964
1753         <rdar://problem/64291035>
1754
1755         Reviewed by Žan Doberšek.
1756
1757         Because of the ABI bump of dav1d, which ffmpeg depends on, ffmpeg needs to be rebuilt. So
1758         this is a good opportunity to include it in the SDK and not rely on the ffmpeg-full
1759         extension anymore, because it doesn't provide debug symbols.
1760
1761         * buildstream/elements/flatpak/platform.bst:
1762         * buildstream/elements/flatpak/sdk.bst:
1763         * buildstream/elements/freedesktop-sdk.bst:
1764         * buildstream/elements/sdk-platform.bst:
1765         * buildstream/elements/sdk/ffmpeg.bst: Added.
1766         * buildstream/elements/sdk/gst-libav.bst:
1767         * buildstream/elements/sdk/libavif.bst: Added.
1768         * buildstream/elements/sdk/ruby-highline.bst: Remove the spec source, un-needed.
1769         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
1770         * buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Removed.
1771         * buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Removed.
1772         * buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Removed.
1773         * buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Removed.
1774         * buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Removed.
1775         * buildstream/project.conf:
1776         * flatpak/flatpakutils.py:
1777         (WebkitFlatpak._get_packages):
1778
1779 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1780
1781         [Flatpak SDK] Remove webkit-build-directory dependency from flatpakutils
1782         https://bugs.webkit.org/show_bug.cgi?id=213179
1783
1784         Reviewed by Žan Doberšek.
1785
1786         This makes webkit-flatpak usable without installing additional perl modules (version) on the host OS.
1787
1788         * flatpak/flatpakutils.py:
1789         (WebkitFlatpak.load_from_args): Make --release and --debug mutually exclusive, and default to Release builds.
1790         (WebkitFlatpak.__init__):
1791         (WebkitFlatpak.clean_args): No need to pull in webkitpy which pulls webkitdirs.pm only to
1792         determine the default configuration. Assume we use Release by default.
1793
1794 2020-06-15  Paulo Matos  <pmatos@igalia.com>
1795
1796         Properly propagate TZ to the remote test devices
1797         https://bugs.webkit.org/show_bug.cgi?id=212816
1798
1799         Reviewed by Philippe Normand.
1800
1801         * Scripts/run-jsc-stress-tests:
1802
1803 2020-06-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1804
1805         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
1806         https://bugs.webkit.org/show_bug.cgi?id=213183
1807         <rdar://problem/64273483>
1808
1809         Reviewed by Tim Horton.
1810
1811         On recent versions of the iOS SDK, iOS simulators that are not shown on-screen are treated as if the hardware
1812         keyboard is not available (that is, `+[UIIKeyboard isInHardwareKeyboardMode]` returns `NO`). When running API
1813         tests while `Simulator.app` is already launched, an iOS simulator is presented on-screen, whereas the simulator
1814         is not visible when running API tests without launching `Simulator.app` beforehand.
1815
1816         This discrepancy causes two iOS API tests to fail (i.e. `CaretSelectionRectAfterRestoringFirstResponder` and
1817         `RangedSelectionRectAfterRestoringFirstResponder`), due to the fact that `-[WKWebView becomeFirstResponder]` no
1818         longer causes an input session to begin.
1819
1820         Interestingly, these tests already attempt to circumvent this by using `webViewWithAutofocusedInput()`, which
1821         creates and loads a `WKWebView` with a single autofocusing input element, with a `_WKInputDelegate` that
1822         unconditionally allows input sessions to begin. However, this doesn't work as intended in these tests, because
1823         nothing keeps the delegate (a `TestInputDelegate`) alive past the scope of the call to
1824         `webViewWithAutofocusedInput()`. Since `[WKWebView _inputDelegate]` is a weak property, the input delegate
1825         simply disappears after we finish waiting for the load to finish (and the autofocused input element begins its
1826         input session). This causes us to erroneously fall back to default behavior (i.e.
1827         `_WKFocusStartsInputSessionPolicyAuto`) for subsequent calls to show the keyboard for the focused element, as is
1828         the case when these two API tests call `-becomeFirstResponder`. The end result is that the keyboard doesn't
1829         appear and text selection views are not created and laid out, but only when API tests are run without having
1830         launched the Simulator app beforehand.
1831
1832         To fix this, refactor `webViewWithAutofocusedInput()` into `webViewAndInputDelegateWithAutofocusedInput()`,
1833         which returns both the new `WKWebView` as well as the `TestInputDelegate` of the web view. The call site is then
1834         responsible for keeping the input delegate around for as long as it needs.
1835
1836         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1837         (webViewWithAutofocusedInput):
1838
1839         Drive-by fix: fix a potential stack smasher by using an Objective-C block when setting the input delegate's
1840         policy handler, and by using `__block` for the `doneWaiting` boolean flag. This is now a problem becuase this
1841         block may be invoked multiple times.
1842
1843         (webViewAndInputDelegateWithAutofocusedInput):
1844
1845 2020-06-13  Saam Barati  <sbarati@apple.com>
1846
1847         compare-results should have an option to print a breakdown and to save the breakdown as csv file
1848         https://bugs.webkit.org/show_bug.cgi?id=213140
1849
1850         Reviewed by Filip Pizlo.
1851
1852         In this patch, compare-results has a new --breakdown feature which will
1853         break down the results for -a and -b per subtest. It will also show you
1854         p values with a significance threshold determined using the Bonferroni
1855         correction for testing multiple hypotheses:
1856         https://en.wikipedia.org/wiki/Bonferroni_correction
1857         
1858         And there is also now a --csv option to generate a csv file containing
1859         the same per subtest breakdown.
1860         
1861         --breakdown will print out results like:
1862         
1863         ------------------------------------------------------------------------------------------------------------
1864         |               subtest                |     ms       |     ms       |  b / a   | pValue, alpha = 0.003125 |
1865         ------------------------------------------------------------------------------------------------------------
1866         | Elm-TodoMVC                          |616.625000    |583.625000    |0.946483  | 0.065002                 |
1867         | VueJS-TodoMVC                        |89.425000     |83.225000     |0.930668  | 0.039102                 |
1868         | EmberJS-TodoMVC                      |695.875000    |664.000000    |0.954194  | 0.088901                 |
1869         | Flight-TodoMVC                       |263.600000    |257.600000    |0.977238  | 0.249259                 |
1870         | BackboneJS-TodoMVC                   |213.025000    |201.550000    |0.946133  | 0.000636 (significant)   |
1871         | Preact-TodoMVC                       |48.800000     |47.550000     |0.974385  | 0.502768                 |
1872         | AngularJS-TodoMVC                    |745.300000    |704.275000    |0.944955  | 0.011779                 |
1873         | Inferno-TodoMVC                      |607.900000    |354.800000    |0.583649  | 0.000000 (significant)   |
1874         | Vanilla-ES2015-TodoMVC               |214.950000    |200.575000    |0.933124  | 0.005018                 |
1875         | Angular2-TypeScript-TodoMVC          |191.575000    |187.025000    |0.976250  | 0.542229                 |
1876         | VanillaJS-TodoMVC                    |162.075000    |160.375000    |0.989511  | 0.747186                 |
1877         | jQuery-TodoMVC                       |855.275000    |833.825000    |0.974920  | 0.103439                 |
1878         | EmberJS-Debug-TodoMVC                |2056.250000   |1952.050000   |0.949325  | 0.000003 (significant)   |
1879         | React-TodoMVC                        |475.225000    |428.950000    |0.902625  | 0.007566                 |
1880         | React-Redux-TodoMVC                  |791.100000    |736.675000    |0.931203  | 0.066091                 |
1881         | Vanilla-ES2015-Babel-Webpack-TodoMVC |208.050000    |202.000000    |0.970920  | 0.152470                 |
1882         ------------------------------------------------------------------------------------------------------------
1883
1884         * Scripts/compare-results:
1885         (readJSONFile):
1886         (speedometer2Breakdown):
1887         (jetStream2Breakdown):
1888         (motionMarkBreakdown):
1889         (plt5Breakdown):
1890         (displayStr):
1891         (dumpBreakdowns):
1892         (writeCSV):
1893         (detectMotionMark1_1):
1894         (detectMotionMark1_1_1):
1895         (motionMarkResults):
1896         (detectBenchmark):
1897         (getOptions):
1898         (main):
1899         (motionMark1_1Results): Deleted.
1900
1901 2020-06-13  Sam Weinig  <weinig@apple.com>
1902
1903         Extended Color: Experiment with strongly typed ColorComponents
1904         https://bugs.webkit.org/show_bug.cgi?id=212396
1905
1906         Reviewed by Darin Adler.
1907
1908         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
1909         (TestWebKitAPI::TEST):
1910         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
1911         (TestWebKitAPI::TEST):
1912         Update for changed names (e.g. toSRGBAComponentsLossy() -> toSRGBALossy())
1913         and use of explicit types.
1914
1915 2020-06-13  Diego Pino Garcia  <dpino@igalia.com>
1916
1917         Unreviewed, fix configuration setting of WPE Debug (Tests JS) bot
1918         https://bugs.webkit.org/show_bug.cgi?id=213164
1919
1920         The bot was meant to run as Debug.
1921
1922         * BuildSlaveSupport/build.webkit.org-config/config.json:
1923
1924 2020-06-12  Keith Miller  <keith_miller@apple.com>
1925
1926         Tests expecting a crash should use a signal handler in the JSC CLI process
1927         https://bugs.webkit.org/show_bug.cgi?id=212479
1928
1929         Reviewed by Yusuke Suzuki.
1930
1931         Crashing tests should now exit with status zero.
1932
1933         * Scripts/run-jsc-stress-tests:
1934         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
1935         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
1936         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
1937
1938 2020-06-12  Alex Christensen  <achristensen@webkit.org>
1939
1940         Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
1941         https://bugs.webkit.org/show_bug.cgi?id=213144
1942
1943         Reviewed by Geofferey Garen.
1944
1945         Most changes are straightforward moving to HTTPServer, which is more tolerant of different numbers of connections except these two:
1946
1947         The ResourceLoadDelegate.Challenge API test was checking the output of _WKResourceLoadDelegate.didReceiveChallenge
1948         by using a server trust challenge.  Now that preconnecting happens, the server trust evaluation would happen with a
1949         PreconnectTask, not the main resource load.  The WKNavigationDelegate still gets the challenge and there is no problem
1950         here, but in order to continue to test _WKResourceLoadDelegate.didReceiveChallenge I use a basic authentication challenge
1951         instead of a server trust evaluation.
1952
1953         The WebKit.FastServerTrust API test now has two failed attempts (one from the preconnect attempt, one from the main resource load attempt),
1954         but only when _strictTrustEvaluate is not available.
1955
1956         * TestWebKitAPI/TCPServer.cpp:
1957         (TestWebKitAPI::TCPServer::TCPServer):
1958         * TestWebKitAPI/TCPServer.h:
1959         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1960         (TEST):
1961         (TestWebKitAPI::TEST):
1962         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1963         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1964         * TestWebKitAPI/cocoa/HTTPServer.h:
1965         * TestWebKitAPI/cocoa/HTTPServer.mm:
1966         (TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
1967
1968 2020-06-12  Diego Pino Garcia  <dpino@igalia.com>
1969
1970         [buildbot] [GTK][WPE] Move WebDriver test to own bot
1971         https://bugs.webkit.org/show_bug.cgi?id=212527
1972
1973         Reviewed by Carlos Alberto Lopez Perez.
1974
1975         Move 'webdriver-test' step from GTK Release and GTK Debug test bots
1976         to separated bots.
1977
1978         For bots that require a Wayland display (WPE and GTK Wayland),
1979         'webdriver-test' step is run on the corresponding general test bot,
1980         since it's not possible at the moment to run tests that require a 
1981         Wayland display in a bot set as a container.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/config.json:
1984         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1985         (TestFactory.__init__):
1986         (TestWebDriverFactory):
1987         (TestWebDriverFactory.__init__):
1988         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1989
1990 2020-06-12  Takashi Komori  <Takashi.Komori@sony.com>
1991
1992         [Curl] Implement functions to use ResourceLoadStatistics.
1993         https://bugs.webkit.org/show_bug.cgi?id=207692
1994
1995         Reviewed by Don Olmstead.
1996
1997         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
1998
1999         Tests: http/tests/resourceLoadStatistics/
2000
2001         * WebKitTestRunner/TestController.cpp:
2002         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
2003         (WTR::getAllStorageAccessEntriesCallback):
2004         (WTR::TestController::getAllStorageAccessEntries):
2005
2006 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
2007
2008         Support building test runners for watchOS and tvOS
2009         https://bugs.webkit.org/show_bug.cgi?id=213128
2010         <rdar://problem/64298006>
2011
2012         Reviewed by Tim Horton.
2013
2014         * DumpRenderTree/mac/Configurations/Base.xcconfig: Link against framework stubs.
2015         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Apply iOS rules to all embedded sdks.
2016         * WebKitTestRunner/Configurations/Base.xcconfig: Link against framework stubs.
2017         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Apply iOS rules to all embedded sdks.
2018         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Use watchOS entitlements for tvOS.
2019
2020 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
2021
2022         TestWebKitAPI: Build for watchOS and tvOS
2023         https://bugs.webkit.org/show_bug.cgi?id=213127
2024         <rdar://problem/64297979>
2025
2026         Reviewed by Tim Horton.
2027
2028         * TestWebKitAPI/Configurations/Base.xcconfig: Link against framework stubs.
2029         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Apply iOS rules to all embedded sdks.
2030         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Ditto.
2031         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Link against framework stubs.
2032         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Apply iOS rules to all embedded sdks.
2033         * TestWebKitAPI/config.h: WatchOS uses SSL.
2034
2035 2020-06-12  Commit Queue  <commit-queue@webkit.org>
2036
2037         Unreviewed, reverting r262942.
2038         https://bugs.webkit.org/show_bug.cgi?id=213132
2039
2040         Broke gst-libav due to dav1d ABI bump
2041
2042         Reverted changeset:
2043
2044         "[Flatpak SDK] Add libavif"
2045         https://bugs.webkit.org/show_bug.cgi?id=212964
2046         https://trac.webkit.org/changeset/262942
2047
2048 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2049
2050         Unreviewed. Fix GTK WebDriver tests after r262938
2051
2052         Ensure a valid title for backforward items in MiniBrowser, using the URL when the title is empty.
2053
2054         * MiniBrowser/gtk/BrowserWindow.c:
2055         (browserWindowCreateBackForwardMenu):
2056
2057 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2058
2059         [Flatpak SDK] Update GTK4 to 3.98.5
2060
2061         Rubber-stamped by Carlos Alberto Lopez Perez.
2062
2063         * buildstream/elements/sdk/gtk.bst:
2064
2065 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2066
2067         [Flatpak SDK] Add libavif
2068         https://bugs.webkit.org/show_bug.cgi?id=212964
2069
2070         Reviewed by Carlos Alberto Lopez Perez.
2071
2072         * buildstream/elements/freedesktop-sdk.bst:
2073         * buildstream/elements/sdk-platform.bst:
2074         * buildstream/elements/sdk/libavif.bst: Added.
2075         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
2076
2077 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2078
2079         [Flatpak SDK] Add libkate
2080         https://bugs.webkit.org/show_bug.cgi?id=212865
2081
2082         Reviewed by Carlos Alberto Lopez Perez.
2083
2084         The GStreamer kate decoder is required for some media/track tests being re-enabled in bug
2085         120665.
2086
2087         * buildstream/elements/sdk-platform.bst:
2088         * buildstream/elements/sdk/gst-plugins-bad.bst:
2089         * buildstream/elements/sdk/libkate.bst: Added.
2090
2091 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2092
2093         [GTK4] Get MiniBrowser ready for GTK4
2094         https://bugs.webkit.org/show_bug.cgi?id=210276
2095
2096         Reviewed by Adrian Perez de Castro.
2097
2098         Port MiniBrowser to GTK4. BrowserSearchBar has been renamed as BrowserSearchBox, because in GTK GtkSearchBar is
2099         final class, so we derive from GtkBox and to be used as contents of a GtkSearchBar.
2100
2101         * MiniBrowser/gtk/BrowserCellRendererVariant.c:
2102         (browserCellRendererVariantCellRendererSnapshot):
2103         (browser_cell_renderer_variant_class_init):
2104         * MiniBrowser/gtk/BrowserCellRendererVariant.h:
2105         * MiniBrowser/gtk/BrowserSearchBar.c: Removed.
2106         * MiniBrowser/gtk/BrowserSearchBox.c: Added.
2107         (setFailedStyleForEntry):
2108         (doSearch):
2109         (searchNext):
2110         (searchPrevious):
2111         (searchEntryMenuIconPressedCallback):
2112         (searchEntryClearIconReleasedCallback):
2113         (searchEntryChangedCallback):
2114         (searchEntryActivatedCallback):
2115         (searchPreviousButtonCallback):
2116         (searchNextButtonCallback):
2117         (searchMenuCheckButtonToggledCallback):
2118         (findControllerFailedToFindTextCallback):
2119         (findControllerFoundTextCallback):
2120         (browserSearchBoxFinalize):
2121         (browserSearchBoxDispose):
2122         (browserSearchBoxSizeAllocate):
2123         (browser_search_box_class_init):
2124         (browser_search_box_new):
2125         (browser_search_box_get_entry):
2126         * MiniBrowser/gtk/BrowserSearchBox.h: Renamed from Tools/MiniBrowser/gtk/BrowserSearchBar.h.
2127         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2128         (browser_settings_dialog_init):
2129         (browser_settings_dialog_new):
2130         * MiniBrowser/gtk/BrowserSettingsDialog.h:
2131         * MiniBrowser/gtk/BrowserTab.c:
2132         (loadChanged):
2133         (createInfoBarQuestionMessage):
2134         (tlsErrorsDialogResponse):
2135         (loadFailedWithTLSerrors):
2136         (permissionRequestDialogResponse):
2137         (decidePermissionRequest):
2138         (colorChooserRequestFinished):
2139         (runColorChooserCallback):
2140         (tabCloseClicked):
2141         (browserTabConstructed):
2142         (browserTabIsSearchBarOpen):
2143         (browser_tab_start_search):
2144         (browser_tab_stop_search):
2145         (browser_tab_enter_fullscreen):
2146         (browser_tab_leave_fullscreen):
2147         * MiniBrowser/gtk/BrowserWindow.c:
2148         (settingsCallback):
2149         (resetEntryProgress):
2150         (webViewLoadProgressChanged):
2151         (browserWindowCreateBackForwardMenu):
2152         (browserWindowUpdateNavigationMenu):
2153         (navigationButtonPressed):
2154         (navigationButtonPressCallback):
2155         (scrollEventCallback):
2156         (webViewIsLoadingChanged):
2157         (searchCallback):
2158         (insertImageDialogResponse):
2159         (insertImageCommandCallback):
2160         (insertLinkDialogResponse):
2161         (insertLinkCommandCallback):
2162         (typingAttributesChanged):
2163         (browserWindowSaveSession):
2164         (browserWindowFinalize):
2165         (browserWindowDispose):
2166         (addToolbarButton):
2167         (browserWindowSwitchTab):
2168         (browserWindowTabAddedOrRemoved):
2169         (browserWindowBuildPopoverMenu):
2170         (browserWindowCloseRequest):
2171         (browserWindowDeleteEvent):
2172         (browser_window_class_init):
2173         (browser_window_append_view):
2174         (browser_window_set_background_color):
2175         * MiniBrowser/gtk/CMakeLists.txt:
2176
2177 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2178
2179         [GTK] MiniBrowser: stop using GtkToolbar
2180         https://bugs.webkit.org/show_bug.cgi?id=212898
2181
2182         Reviewed by Adrian Perez de Castro.
2183
2184         GtkToolbar iss no longer available in GTK4, use a GtkBox with buttons instead. Also use symbolic icons and move
2185         some of the actions to a gear menu.
2186
2187         * MiniBrowser/gtk/BrowserWindow.c:
2188         (browserWindowHistoryItemActivated):
2189         (browserWindowCreateBackForwardMenu):
2190         (browserWindowUpdateNavigationMenu):
2191         (navigationButtonPressCallback):
2192         (browserWindowCanZoomDefault):
2193         (browserWindowUpdateZoomActions):
2194         (webViewIsLoadingChanged):
2195         (addToolbarButton):
2196         (browserWindowBuildPopoverMenu):
2197         (resetStatusText): Deleted.
2198         (browserWindowHistoryItemSelected): Deleted.
2199         (browserWindowSetupEditorToolbarItem): Deleted.
2200
2201 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2202
2203         [GTK] MiniBrowser: stop using GtkToolbar for the search bar
2204         https://bugs.webkit.org/show_bug.cgi?id=212817
2205
2206         Reviewed by Adrian Perez de Castro.
2207
2208         Use a GtkSearchBar instead, because GtkToolbar is no longer available in GTK4. Also use a GtkPopover for the
2209         options menu instead of the GtkMenu.
2210
2211         * MiniBrowser/gtk/BrowserSearchBar.c:
2212         (setFailedStyleForEntry):
2213         (doSearch):
2214         (searchEntryMenuIconPressedCallback):
2215         (searchEntryChangedCallback):
2216         (searchMenuCheckButtonToggledCallback):
2217         (browserSearchBarFinalize):
2218         (browser_search_bar_new):
2219         (browser_search_bar_open):
2220         (browser_search_bar_close):
2221         (browser_search_bar_is_open):
2222         (searchCloseButtonClickedCallback): Deleted.
2223         (searchEntryClearIconReleasedCallback): Deleted.
2224         * MiniBrowser/gtk/BrowserSearchBar.h:
2225         * MiniBrowser/gtk/BrowserTab.c:
2226         (browser_tab_start_search):
2227         (browser_tab_stop_search):
2228
2229 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2230
2231         [GTK4] Make WebDriver work
2232         https://bugs.webkit.org/show_bug.cgi?id=212316
2233
2234         Reviewed by Adrian Perez de Castro.
2235
2236         Stop connecting to WebKitWebView::close signal twice for newaly created windows.
2237
2238         * MiniBrowser/gtk/BrowserWindow.c:
2239         (webViewCreate):
2240
2241 2020-06-11  Saam Barati  <sbarati@apple.com>
2242
2243         Skip wasm-js2 test on memory limited devices
2244         https://bugs.webkit.org/show_bug.cgi?id=213099
2245
2246         Reviewed by Yusuke Suzuki.
2247
2248         * Scripts/run-jsc-stress-tests:
2249
2250 2020-06-11  Alex Christensen  <achristensen@webkit.org>
2251
2252         Re-enable download resume tests
2253         https://bugs.webkit.org/show_bug.cgi?id=213098
2254         <rdar://problem/63512518>
2255
2256         Reviewed by Geoffrey Garen.
2257
2258         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2259
2260 2020-06-11  Commit Queue  <commit-queue@webkit.org>
2261
2262         Unreviewed, reverting r262696.
2263         https://bugs.webkit.org/show_bug.cgi?id=213097
2264
2265         It broke running JSC tests on watchOS
2266
2267         Reverted changeset:
2268
2269         "Allow run-jsc-stress-tests still run if some of the remote
2270         hosts are not available"
2271         https://bugs.webkit.org/show_bug.cgi?id=201426
2272         https://trac.webkit.org/changeset/262696
2273
2274 2020-06-11  Sihui Liu  <sihui_liu@apple.com>
2275
2276         REGRESSION (r262879): 3 TestWebKitAPI.TextManipulation tests are failing
2277         https://bugs.webkit.org/show_bug.cgi?id=213079
2278         <rdar://problem/64256870>
2279
2280         Reviewed by Wenson Hsieh.
2281
2282         Update a few tests after behavior change in r262879. From r262879, we no longer use visible positions of element
2283         to calculate range to observe. Instead, we use the first and end position in the element to decide the range. In
2284         previous implementation, the range can be extended to outside of the element, like some visible positon before 
2285         or after the element.
2286
2287         TextManipulation.StartTextManipulationFindNewlyDisplayedParagraph: Different elements would make separate ranges 
2288         because we create range with the boundaries of element. We can consider merging adjacent ranges later.
2289         TextManipulation.StartTextManipulationFindSameParagraphWithNewContent: The newly observing range only includes
2290         the newly inserted element now.
2291         TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem: The p element
2292         is not manipulated as it is the common ancestor of manipulated elements. And we want to make sure the newly
2293         inserted element is child of a manipulated element.
2294
2295         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2296         (TestWebKitAPI::TEST):
2297
2298 2020-06-11  Andy Estes  <aestes@apple.com>
2299
2300         [iOS] nullptr deref in FileInputType::iconLoaded when the input's type attribute is modified by a change event listener
2301         https://bugs.webkit.org/show_bug.cgi?id=208244
2302         <rdar://problem/41855350>
2303
2304         Reviewed by Wenson Hsieh.
2305
2306         * DumpRenderTree/TestRunner.cpp:
2307         (SetOpenPanelFilesMediaIconCallback):
2308         (TestRunner::staticFunctions):
2309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2310         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2311
2312 2020-06-11  Sergio Villar Senin  <svillar@igalia.com>
2313
2314         Unreviewed, updated libsoup dependency in jhbuild.
2315
2316         * wpe/jhbuild.modules:
2317
2318 2020-06-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2319
2320         [macOS]: The File Picker of the <input> file element should show the selection filter
2321         https://bugs.webkit.org/show_bug.cgi?id=212485
2322
2323         Reviewed by Darin Adler.
2324
2325         Create a view with an NSPopupButton for the file extensions filter. Set
2326         this view as the AccessoryView of the OpenPanel. Create a customized target
2327         for the NSPopupButton to respond to changing its selection.
2328
2329         * MiniBrowser/mac/WK2BrowserWindowController.m:
2330         (-[FileExtensionsPopupTarget initWithOpenPanel:allowedFileExtensions:]):
2331         (-[FileExtensionsPopupTarget popupAction:]):
2332         (-[FileExtensionsPopupTarget dealloc]):
2333         (-[WK2BrowserWindowController dealloc]):
2334         (-[WK2BrowserWindowController createFilterView:popupTarget:]):
2335         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2336
2337 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
2338
2339         Generalize configure-xcode-for-ios-development (Part 2)
2340         https://bugs.webkit.org/show_bug.cgi?id=207043
2341         <rdar://problem/63946933>
2342
2343         Reviewed by Darin Adler.
2344
2345         * EWSTools/start-queue-mac.sh: Use configure-xcode-for-embedded-development over configure-xcode-for-ios-development.
2346         * Scripts/configure-xcode-for-ios-development: Removed.
2347
2348 2020-06-10  Sihui Liu  <sihui_liu@apple.com>
2349
2350         Text manipulation does not observe inserted elements that are invisible
2351         https://bugs.webkit.org/show_bug.cgi?id=213057
2352         <rdar://problem/63768253>
2353
2354         Reviewed by Wenson Hsieh.
2355
2356         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2357         (TestWebKitAPI::TEST):
2358
2359 2020-06-10  Geoffrey Garen  <ggaren@apple.com>
2360
2361         Some style improvements to main thread code
2362         https://bugs.webkit.org/show_bug.cgi?id=213051
2363
2364         Reviewed by Darin Adler.
2365
2366         Updated for rename.
2367         
2368         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2369         (TestWebKitAPI::TEST):
2370         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2371         (TestWebKitAPI::TEST):
2372         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2373         (TestWebKitAPI::TEST):
2374         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2375         (ApplicationManifestParserTest::SetUp):
2376         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2377         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2378         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2379         (TestWebKitAPI::ContentExtensionTest::SetUp):
2380         * TestWebKitAPI/Tests/WebCore/DNS.cpp:
2381         (TestWebKitAPI::TEST):
2382         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2383         (TestWebKitAPI::TEST_F):
2384         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2385         (initializeInAppBrowserPrivacyTestSettings):
2386         * WebKitTestRunner/TestController.cpp:
2387         (WTR::TestController::initialize):
2388
2389 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
2390
2391         results.webkit.org: Health check should access redis and Cassandra
2392         https://bugs.webkit.org/show_bug.cgi?id=212899
2393         <rdar://problem/64118077>
2394
2395         Reviewed by Stephanie Lewis.
2396
2397         * resultsdbpy/resultsdbpy/example/main.py:
2398         (health): Check the health status of the model.
2399         * resultsdbpy/resultsdbpy/model/model.py:
2400         (Model.HealthTable):
2401         (Model.__init__): Construct a Cassandra table used to check the health of our Cassandra connection.
2402         (Model.healthy): Make both a read and write connection to our two database dependencies so that if
2403         our connection to those databases fails, an instance will be forced to restart.
2404         * resultsdbpy/resultsdbpy/model/model_unittest.py: Added.
2405         (ModelTest):
2406         (ModelTest.init_database):
2407         (ModelTest.test_health):
2408
2409 2020-06-10  Keith Miller  <keith_miller@apple.com>
2410
2411         run-jsc-stress-tests should skip tests marked as slow in quick mode.
2412         https://bugs.webkit.org/show_bug.cgi?id=213042
2413
2414         Reviewed by Yusuke Suzuki.
2415
2416         * Scripts/run-jsc-stress-tests:
2417
2418 2020-06-10  Antoine Quint  <graouts@webkit.org>
2419
2420         Subframes should not autosize independently
2421         https://bugs.webkit.org/show_bug.cgi?id=212984
2422         <rdar://problem/64175493>
2423
2424         Reviewed by Simon Fraser.
2425
2426         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2427         (TEST): Added test for <object>.
2428
2429 2020-06-09  Ryan Haddad  <ryanhaddad@apple.com>
2430
2431         [Mojave] Flaky API Test: TestWebKitAPI.WebKitLegacy.CrossPartitionFileSchemeAccess
2432         https://bugs.webkit.org/show_bug.cgi?id=206956
2433
2434         Unreviewed test gardening.
2435
2436         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Disable this test for Mojave.
2437
2438 2020-06-10  Alex Christensen  <achristensen@webkit.org>
2439
2440         Revert r259770
2441         https://bugs.webkit.org/show_bug.cgi?id=210097
2442         <rdar://problem/64175992>
2443
2444         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2445         (TEST):
2446
2447 2020-06-10  Commit Queue  <commit-queue@webkit.org>
2448
2449         Unreviewed, reverting r262807.
2450         https://bugs.webkit.org/show_bug.cgi?id=213019
2451
2452         It is breaking JSC queues (Requested by caiolima on #webkit).
2453
2454         Reverted changeset:
2455
2456         "Add a timeout monitor for JSC stress test"
2457         https://bugs.webkit.org/show_bug.cgi?id=211978
2458         https://trac.webkit.org/changeset/262807
2459
2460 2020-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2461
2462         Unreviewed, reverting r262791.
2463
2464         WinCairo WebKit1 is crashing.
2465
2466         Reverted changeset:
2467
2468         "[Curl] Implement functions to use ResourceLoadStatistics."
2469         https://bugs.webkit.org/show_bug.cgi?id=207692
2470         https://trac.webkit.org/changeset/262791
2471
2472 2020-06-09  Zhifei Fang  <zhifei_fang@apple.com>
2473
2474         Add a timeout monitor for JSC stress test
2475         https://bugs.webkit.org/show_bug.cgi?id=211978
2476
2477         Reviewed by Jonathan Bedard.
2478
2479         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Add timeout monitor inside the jsc stress test runner, it will kill the process in case of jsc timeout handler not working
2480
2481 2020-06-09  Tim Horton  <timothy_horton@apple.com>
2482
2483         WebKit.ShrinkToFit is failing on some bots
2484         https://bugs.webkit.org/show_bug.cgi?id=212932
2485         <rdar://problem/60972407>
2486
2487         Reviewed by Simon Fraser.
2488
2489         TestWebKitAPI was failing to stabilize the overlay scrollbar preference,
2490         because the only stabilization attempt was in the injected bundle 
2491         initialization code, and most tests (including ShrinkToFit) do not have
2492         an injected bundle.
2493
2494         Because this preference is manually propagated to the Web Content process,
2495         we can set the default in the volatile domain in the UI process at startup.
2496
2497         We can't move other preferences yet, because they are not manually propagated,
2498         and WebKit's NSUserDefault synchronization mechanism ignores defaults in the
2499         volatile domain (and the initial preference load reads from disk, not
2500         from the UI process, so it wouldn't find them anyway).
2501
2502         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2503         (TEST):
2504         Explain why the final value of the test is different than the starting value.
2505
2506         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2507         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2508         Leave a FIXME for future generations.
2509
2510         * TestWebKitAPI/mac/mainMac.mm:
2511         (main):
2512         Override overlay scrollbar preferences in the UI process, so it affects all tests.
2513
2514         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2515         This test is also affected by using non-overlay scrollbars; we now have less space, so take up more pages.
2516
2517 2020-06-09  Youenn Fablet  <youenn@apple.com>
2518
2519         BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit
2520         https://bugs.webkit.org/show_bug.cgi?id=212970
2521
2522         Reviewed by Eric Carlson.
2523
2524         Add an option to capture in UI process so that the same test can run on both MacOS and iOS.
2525         This eases the testing infra to be able to get audio capture unit state in WebProcess as is the case in iOS.
2526
2527         * WebKitTestRunner/TestController.cpp:
2528         (WTR::TestController::resetPreferencesToConsistentValues):
2529         (WTR::updateTestOptionsFromTestHeader):
2530         * WebKitTestRunner/TestOptions.h:
2531         (WTR::TestOptions::hasSameInitializationOptions const):
2532
2533 2020-06-09  Takashi Komori  <Takashi.Komori@sony.com>
2534
2535         [Curl] Implement functions to use ResourceLoadStatistics.
2536         https://bugs.webkit.org/show_bug.cgi?id=207692
2537
2538         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
2539
2540         Tests: http/tests/resourceLoadStatistics/
2541
2542         Reviewed by Don Olmstead.
2543
2544         * WebKitTestRunner/TestController.cpp:
2545         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
2546         (WTR::getAllStorageAccessEntriesCallback):
2547         (WTR::TestController::getAllStorageAccessEntries):
2548
2549 2020-06-09  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2550
2551         [Flatpak][GStreamer] enhance GST_ environment variable passing
2552         https://bugs.webkit.org/show_bug.cgi?id=212905
2553
2554         Reviewed by Philippe Normand.
2555
2556         Handle the passing of several GST environment variables,
2557         particularly GST_DEBUG, which, when using * symbol, python adds
2558         quotes, but they break the parsing in GStreamer.
2559
2560         Also the variables are handled by gst-env.py when using
2561         GST_BUILD_PATH, so they are filtered out when it's exported,
2562         avoiding duplication. But it GST_BUILD_PATH is not defined, the
2563         variables are passed to flatpak.
2564
2565         * flatpak/flatpakutils.py:
2566         (WebkitFlatpak.setup_gstbuild):
2567         (WebkitFlatpak.run_in_sandbox):
2568
2569 2020-06-09  Sihui Liu  <sihui_liu@apple.com>
2570
2571         TextManipulationController range of paragraph may be wrong after r262601
2572         https://bugs.webkit.org/show_bug.cgi?id=212874
2573
2574         Reviewed by Wenson Hsieh.
2575
2576         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2577         (TestWebKitAPI::TEST):
2578
2579 2020-06-08  Sihui Liu  <sihui_liu@apple.com>
2580
2581         TextManipulation should only convert text from Node's text content to tokens
2582         https://bugs.webkit.org/show_bug.cgi?id=212928
2583
2584         Reviewed by Wenson Hsieh.
2585
2586         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2587         (TestWebKitAPI::TEST):
2588
2589 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
2590
2591         [webkitpy] Check 'bug-search' returns a non null result before parsing
2592         https://bugs.webkit.org/show_bug.cgi?id=212906
2593
2594         Reviewed by Jonathan Bedard.
2595
2596         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2597         (BugzillaQueries._parse_result_count): Check quick-search query
2598         response is non-null and a non-empty text.
2599
2600 2020-06-08  Sam Weinig  <weinig@apple.com>
2601
2602         Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
2603         https://bugs.webkit.org/show_bug.cgi?id=212917
2604
2605         Reviewed by Darin Adler.
2606
2607         Addresses feedback from Darin.
2608
2609         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2610         (TestWebKitAPI::TEST):
2611
2612 2020-06-08  Sam Weinig  <weinig@apple.com>
2613
2614         Fix test results after r262733.
2615
2616         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2617         (TestWebKitAPI::TEST):
2618
2619 2020-06-08  David Kilzer  <ddkilzer@apple.com>
2620
2621         [IPC] Adopt enum class for DragOperation
2622         <https://webkit.org/b/212870>
2623         <rdar://problem/64069940>
2624
2625         Reviewed by Darin Adler.
2626
2627         * Scripts/do-webcore-rename:
2628         - Do DragOperation renames.
2629
2630 2020-06-08  Commit Queue  <commit-queue@webkit.org>
2631
2632         Unreviewed, reverting r262685.
2633         https://bugs.webkit.org/show_bug.cgi?id=212914
2634
2635         caused flakey crashes in an iOS test
2636
2637         Reverted changeset:
2638
2639         "Clear WebPageProxy event state between tests"
2640         https://bugs.webkit.org/show_bug.cgi?id=212864
2641         https://trac.webkit.org/changeset/262685
2642
2643 2020-06-08  Sam Weinig  <weinig@apple.com>
2644
2645         Extended Color: Unify rounding / clamping conversions between 0-1 float components and 0-255 byte components
2646         https://bugs.webkit.org/show_bug.cgi?id=212871
2647
2648         Reviewed by Simon Fraser.
2649
2650         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2651         (TestWebKitAPI::TEST):
2652         Switch to using makeSimpleColor(hslToSRGB(...)) directly.
2653
2654 2020-06-08  Sam Weinig  <weinig@apple.com>
2655
2656         Extended Color: Replace uses of differenceSquared() with luminance based computations
2657         https://bugs.webkit.org/show_bug.cgi?id=212872
2658
2659         Reviewed by Darin Adler.
2660
2661         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2662         (TestWebKitAPI::TEST):
2663         Add basic tests for Color::luminance(), ensuring white == 1, black == 0, and 
2664         darken() and lighten() creat colors with less than / greater than luminance.
2665
2666 2020-06-08  Per Arne Vollan  <pvollan@apple.com>
2667
2668         [Cocoa] CFPrefs synchronization does not always work for global preference changes
2669         https://bugs.webkit.org/show_bug.cgi?id=212783
2670
2671         Reviewed by Tim Horton.
2672
2673         Add API test, and add some synchronization to avoid flakiness.
2674
2675         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
2676         (-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
2677         (TEST):
2678         (sharedInstanceMethodOverride):
2679
2680 2020-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2681
2682         [iOS] Hit-testing on icloud.com is offset after closing a tab
2683         https://bugs.webkit.org/show_bug.cgi?id=212890
2684         <rdar://problem/58775297>
2685
2686         Reviewed by Simon Fraser.
2687
2688         Add a new API test to verify that the scroll position doesn't get stuck at -30px after shifting both the top
2689         content inset and top obscured inset by 30px. See WebKit ChangeLog for more details.
2690
2691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2692         * TestWebKitAPI/Tests/WebKitCocoa/overflow-hidden.html: Added.
2693         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2694         (-[ScrollViewDelegate scrollViewDidScroll:]):
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/ios/UIKitSPI.h:
2697
2698 2020-06-08  Philippe Normand  <pnormand@igalia.com>
2699
2700         [Flatpak SDK] Add flatpak-run-nightly
2701         https://bugs.webkit.org/show_bug.cgi?id=212882
2702
2703         Reviewed by Carlos Alberto Lopez Perez.
2704
2705         This new script is able to download WPE and GTK builds from the Igalia servers and run the
2706         corresponding binaries (like MiniBrowser, jsc) within the Flatpak SDK.
2707
2708         Unzipped builds will be saved in /tmp and can be reused in further runs (by providing the
2709         path with the -p argument).
2710
2711         Example:
2712         $ webkit-flatpak-run-nightly --wpe MiniBrowser https://webkit.org
2713         <SDK installs to ~/.cache/wk-nightly>
2714         Downloading build release_r262699_b33885.zip from https://wpewebkit-release.igalia.com/built-products/
2715         Extracting build to /tmp/wpewebkit-release-b33885
2716         <MiniBrowser starts>
2717
2718         $ webkit-flatpak-run-nightly --wpe -p /tmp/wpewebkit-release-b33885 jsc
2719         Looking for updates…
2720         Nothing to do.
2721         >>> 2+2
2722         4
2723
2724         * Scripts/webkit-flatpak-run-nightly: Added.
2725
2726 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
2727
2728         [webkitpy] Make 'webkit-path rebaseline' to not update expectations file by default
2729         https://bugs.webkit.org/show_bug.cgi?id=212835
2730
2731         Reviewed by Carlos Alberto Lopez Perez.
2732
2733         `webkit-patch rebaseline` let us add or update a test baseline
2734         from a test bot. By default, the command also updates the
2735         corresponding expectations file. This update is actually a brand-new
2736         generation of an expectations file based on the results of the bot,
2737         which in most cases messes up the current contents of the file.
2738
2739         This patch makes the default to not update the expectations file and
2740         adds a new option '--update-expectations' to explicitly request an
2741         update.
2742
2743         * Scripts/webkitpy/tool/commands/rebaseline.py:
2744         (AbstractRebaseliningCommand):
2745         (RebaselineTest.__init__):
2746         (RebaselineTest._rebaseline_tests):
2747         (RebaselineTest.execute):
2748         (AbstractParallelRebaselineCommand._rebaseline_commands):
2749         (RebaselineExpectations.__init__):
2750         (RebaselineExpectations.execute):
2751         (Rebaseline.__init__):
2752         (RebaselineTest._rebaseline_test_and_update_expectations): Deleted.
2753         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2754         (TestRebaselineTest.setUp):
2755
2756 2020-06-08  Youenn Fablet  <youenn@apple.com>
2757
2758         File URLs with hostnames are misleading
2759         https://bugs.webkit.org/show_bug.cgi?id=212739
2760         <rdar://problem/63754917>
2761
2762         Reviewed by Alex Christensen.
2763
2764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2765         * TestWebKitAPI/Tests/WebKit/open-window-with-file-url-with-host.html: Added.
2766         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2767         (TEST):
2768
2769 2020-06-07  Caio Lima  <ticaiolima@gmail.com>
2770
2771         Allow run-jsc-stress-tests still run if some of the remote hosts are not available
2772         https://bugs.webkit.org/show_bug.cgi?id=201426
2773
2774         Reviewed by Saam Barati.
2775
2776         This patch allows run-jsc-stress-tests to keep on running if some of
2777         the remote hosts are not available. To do this, we created a new
2778         function `checkAndPrepareRemoteHosts` that is responsible to check the
2779         connection and read/write permissions of given remote hosts list. It
2780         filters out every unavailable remote host.
2781         These checks and filter happen in the beginning of the script and is
2782         excuted only once, in the beggining of the script. It means that if
2783         some remote device becomes unavailable after the check and preparation
2784         is done, the script execution will be interupted.
2785
2786         * Scripts/run-jsc-stress-tests:
2787
2788 2020-06-07  Philippe Normand  <pnormand@igalia.com>
2789
2790         Remove ENABLE_VIDEO_TRACK ifdef guards
2791         https://bugs.webkit.org/show_bug.cgi?id=212568
2792
2793         Reviewed by Youenn Fablet.
2794
2795         * Scripts/webkitperl/FeatureList.pm:
2796         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2797
2798 2020-06-06  Simon Fraser  <simon.fraser@apple.com>
2799
2800         Clear WebPageProxy event state between tests
2801         https://bugs.webkit.org/show_bug.cgi?id=212864
2802
2803         Reviewed by Anders Carlsson.
2804
2805         Make sure that event state doesn't leak between tests via events queued in WebPageProxy.
2806
2807         * WebKitTestRunner/TestController.cpp:
2808         (WTR::TestController::resetStateToConsistentValues):
2809
2810 2020-06-06  Peng Liu  <peng.liu6@apple.com>
2811
2812         REGRESSION (r262456): [iOS Debug] TestWebKitAPI.WKWebViewCloseAllMediaPresentations.PictureInPicture is frequently timing out
2813         https://bugs.webkit.org/show_bug.cgi?id=212777
2814
2815         Unreviewed test gardening.
2816
2817         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2818         Disable the PictureInPicture test for old iOS devices.
2819
2820 2020-06-05  Ryan Haddad  <ryanhaddad@apple.com>
2821
2822         [iOS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2823         https://bugs.webkit.org/show_bug.cgi?id=208451
2824
2825         Unreviewed test gardening.
2826
2827         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable this test again because it is still failing on certain bots.
2828
2829 2020-06-05  Daniel Bates  <dabates@apple.com>
2830
2831         -_focusTextInputContext should reposition the caret if called for an already focused text input context
2832         https://bugs.webkit.org/show_bug.cgi?id=212830
2833         <rdar://problem/64032956>
2834
2835         Reviewed by Wenson Hsieh.
2836
2837         Re-purpose some existing tests to check for the new behavior.
2838
2839         In TextInteraction_FocusingAssistedElementShouldScrollToReveal, keep in mind that the caret position is
2840         changing: on iOS, calling input.focus() places the caret at the end of the field's content.
2841
2842         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2843         (TestWebKitAPI::TEST):
2844
2845 2020-06-05  Jonathan Bedard  <jbedard@apple.com>
2846
2847         Generalize configure-xcode-for-ios-development (Part 1)
2848         https://bugs.webkit.org/show_bug.cgi?id=207043
2849
2850         Rubber-stamped by David Kilzer.
2851
2852         Patch by Keith Rollin and Jonathan Bedard.
2853
2854         Replace configure-xcode-for-ios-development with a Python script that works for iOS,
2855         watchOS and tvOS.
2856
2857         * Scripts/configure-xcode-for-embedded-development: Added.
2858
2859 2020-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2860
2861         Text manipulation should exclude characters outside of the unicode private use area
2862         https://bugs.webkit.org/show_bug.cgi?id=212800
2863         <rdar://problem/63736417>
2864
2865         Reviewed by Sihui Liu.
2866
2867         Add a new API test to verify the new behavior when extracting PUA characters.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2870         (TestWebKitAPI::TEST):
2871
2872 2020-06-05  Dean Jackson  <dino@apple.com>
2873
2874         REGRESSION (r262366): [ Mac wk1 ] webgl/webgl-backing-store-size-update.html is failing
2875         https://bugs.webkit.org/show_bug.cgi?id=212647
2876         <rdar://problem/63882960>
2877
2878         Reviewed by Eric Carlson.
2879
2880         Drive-by comment from Simon. Remove some useless braces.
2881
2882         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm:
2883
2884 2020-06-05  Saam Barati  <sbarati@apple.com>
2885
2886         Try to reduce jetsams further on iOS devices running jsc stress tests
2887         https://bugs.webkit.org/show_bug.cgi?id=212786
2888
2889         Reviewed by Mark Lam.
2890
2891         * Scripts/run-jsc-stress-tests:
2892
2893 2020-06-05  Peng Liu  <peng.liu6@apple.com>
2894
2895         REGRESSION (r262456?): [macOS] media/picture-in-picture/picture-in-picture-api tests are flaky timeouts
2896         https://bugs.webkit.org/show_bug.cgi?id=212762
2897
2898         Reviewed by Eric Carlson.
2899
2900         Skip the Picture-in-Picture test if Picture-in-Picture is not supported and add playsinline attribute
2901         to the video element.
2902
2903         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2904         (TEST):
2905
2906 2020-06-05  Andy Estes  <aestes@apple.com>
2907
2908         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
2909         https://bugs.webkit.org/show_bug.cgi?id=212541
2910         <rdar://problem/63781452>
2911
2912         Reviewed by Darin Adler.
2913
2914         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
2915
2916         * Scripts/webkitperl/FeatureList.pm:
2917         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2918
2919 2020-06-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2920
2921         [GTK] MiniBrowser: use GAction API for actions and shortcuts in preparation for GTK4
2922         https://bugs.webkit.org/show_bug.cgi?id=212740
2923
2924         Reviewed by Adrian Perez de Castro.
2925
2926         Make MiniBrowser a GtkApplication and BrowserWindow a GtkApplicationWindow to easily install actions and shortcuts.
2927
2928         * MiniBrowser/gtk/BrowserMain.c: Removed.
2929         * MiniBrowser/gtk/BrowserMain.h: Removed.
2930         * MiniBrowser/gtk/BrowserSearchBar.c:
2931         (searchPreviousButtonCallback):
2932         (searchNextButtonCallback):
2933         * MiniBrowser/gtk/BrowserSearchBar.h:
2934         * MiniBrowser/gtk/BrowserTab.c:
2935         * MiniBrowser/gtk/BrowserTab.h:
2936         * MiniBrowser/gtk/BrowserWindow.c:
2937         (reloadOrStopCallback):
2938         (goBackCallback):
2939         (goForwardCallback):
2940         (settingsCallback):
2941         (browserWindowUpdateNavigationMenu):
2942         (browserWindowTryCloseCurrentWebView):
2943         (browserWindowTryClose):
2944         (webViewCreate):
2945         (browserWindowUpdateZoomActions):
2946         (webViewZoomLevelChanged):
2947         (zoomInCallback):
2948         (zoomOutCallback):
2949         (defaultZoomCallback):
2950         (searchCallback):
2951         (newTabCallback):
2952         (toggleWebInspector):
2953         (openPrivateWindow):
2954         (focusLocationBar):
2955         (reloadPage):
2956         (reloadPageIgnoringCache):
2957         (stopPageLoad):
2958         (loadHomePage):
2959         (toggleFullScreen):
2960         (printPage):
2961         (editingActionCallback):
2962         (typingAttributesChanged):
2963         (browserWindowFinalize):
2964         (browserWindowSetupEditorToolbarItem):
2965         (browserWindowSetupToolbarItem):
2966         (browserWindowDeleteEvent):
2967         (browser_window_new):
2968         (browser_window_append_view):
2969         (browser_window_get_or_create_web_view_for_automation):
2970         (browser_window_create_web_view_in_new_tab_for_automation):
2971         * MiniBrowser/gtk/BrowserWindow.h:
2972         * MiniBrowser/gtk/CMakeLists.txt:
2973         * MiniBrowser/gtk/main.c:
2974         (createWebViewForAutomationInWindowCallback):
2975         (createWebViewForAutomationInTabCallback):
2976         (automationStartedCallback):
2977         (startup):
2978         (activate):
2979         (main):
2980
2981 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
2982
2983         Text manipulation: first and last unit in a paragraph should not contain only excluded tokens
2984         https://bugs.webkit.org/show_bug.cgi?id=212759
2985
2986         Reviewed by Wenson Hsieh.
2987
2988         Modify existing test for changed behavior that leading and trailing excluded units are not included in paragraph
2989         now.
2990
2991         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2992         (TestWebKitAPI::TEST):
2993
2994 2020-06-04  Chris Dumez  <cdumez@apple.com>
2995
2996         UIProcess may crash after its prewarmed WebProcess gets terminated
2997         https://bugs.webkit.org/show_bug.cgi?id=212790
2998         <rdar://problem/63696191>
2999
3000         Reviewed by Geoffrey Garen.
3001
3002         Add API test coverage.
3003
3004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3005         (TEST):
3006
3007 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
3008
3009         REGRESSION: (r262398) Text manipulation crashes when content is added
3010         https://bugs.webkit.org/show_bug.cgi?id=212785
3011
3012         Reviewed by Ryosuke Niwa.
3013
3014         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3015         (TestWebKitAPI::TEST):
3016
3017 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3018
3019         Improve watchlist logic for comments on patches touching imported WPT tests.
3020         https://bugs.webkit.org/show_bug.cgi?id=212597
3021
3022         Reviewed by Youenn Fablet.
3023
3024         On r262295 I added a watchlist comment for patches touching the imported WPT tests.
3025         However, this is commenting on patches that are importing WPT tests.
3026
3027         To avoid this situations, this patch adds a new rule to detect if the changes modify
3028         any of the w3c-import.log files, and then changes the logic to make the comment only
3029         for patches that modify the WPT imported tests but not the w3c-import.log files.
3030
3031         In order to support this new logic, watchlist rule parsing is improved to support
3032         the "and" and "not" operators. Previously it only supported the "or" operator.
3033
3034         * Scripts/webkitpy/common/config/watchlist:
3035         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3036         (WatchListParser._rule_definitions_as_set):
3037         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3038         (WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion):
3039         (WatchListParserTest):
3040         (WatchListParserTest.test_cc_rule_with_complex_logic):
3041         * Scripts/webkitpy/common/watchlist/watchlistrule.py:
3042         (WatchListRule.__init__):
3043         (WatchListRule._match_test_definitions):
3044         (WatchListRule.match):
3045         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
3046         (WatchListRuleTest.test_complex_definition_or):
3047         (WatchListRuleTest):
3048         (WatchListRuleTest.test_complex_definition_and):
3049         (WatchListRuleTest.test_complex_definition_not):
3050         (WatchListRuleTest.test_complex_definition_combined):
3051
3052 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3053
3054         svn-apply command is too slow with big patches
3055         https://bugs.webkit.org/show_bug.cgi?id=212766
3056
3057         Reviewed by Darin Adler.
3058
3059         The script svn-apply was calling a "git add" or "svn add" command
3060         after adding each new file. This caused the git or svn command to
3061         re-check the internal SCM database each time they were called, and
3062         this was really slow when lot of new files are added.
3063         Instead of doing this, we queue the list of new files in memory,
3064         and at the end we call "git add" or "svn add" once (or a few times).
3065
3066         On top of that, another optimization is added for the case of git,
3067         to avoid calling scmKnowsOfFile() inside addDirectoriesIfNeeded(),
3068         which is a slow operation and gets called a lot (once per file).
3069         Doing that for git is totally unneeded, as the only thing we have
3070         to take care about, is of ensuring that the directory is created.
3071         See: https://wkb.ug/86973
3072
3073         This reduces the time spent in the large test patch that caused
3074         this issue (see bug):
3075          - Git: 8 hours (before) -> 8 minutes (now).
3076          - SVN: 25 minutes (before) -> 5 minutes (now).
3077
3078         * Scripts/svn-apply:
3079         (addDirectoriesIfNeeded):
3080         (handleBinaryChange):
3081         (handleGitBinaryChange):
3082         (patch):
3083         (scmRemove):
3084         (scmAddQueued):
3085         (scmCommitQueueAdded):
3086         (scmToggleExecutableBitQueued):
3087         (scmCommitQueueToggledExecutableBit):
3088
3089 2020-06-04  Jonathan Bedard  <jbedard@apple.com>
3090
3091         Add watchOS and tvOS to build-webkit
3092         https://bugs.webkit.org/show_bug.cgi?id=212719
3093         <rdar://problem/63951600>
3094
3095         Reviewed by Tim Horton.
3096
3097         * Scripts/build-webkit: Add tvOS and watchOS flags, generalize embedded if statements.
3098         * Scripts/webkitdirs.pm:
3099         (determineArchitecture): Add tvOS and watchOS architectures.
3100         (argumentsForConfiguration): Add tvOS and watchOS flags.
3101         (extractNonMacOSHostConfiguration): Ditto.
3102
3103 2020-06-04  Tim Horton  <timothy_horton@apple.com>
3104
3105         Work around broken system version macro
3106         https://bugs.webkit.org/show_bug.cgi?id=212726
3107
3108         Reviewed by Dan Bernstein.
3109
3110         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3111         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3112         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3113         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3114         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3115         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3116         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3117         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
3118
3119 2020-06-04  Andy Estes  <aestes@apple.com>
3120
3121         [watchOS] Re-enable content filtering in the simulator build
3122         https://bugs.webkit.org/show_bug.cgi?id=212711
3123         <rdar://problem/63938350>
3124
3125         Reviewed by Wenson Hsieh.
3126
3127         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3128
3129 2020-06-04  Philippe Normand  <pnormand@igalia.com>
3130
3131         [Flatpak SDK] Update definitions
3132         https://bugs.webkit.org/show_bug.cgi?id=212698
3133
3134         Reviewed by Žan Doberšek.
3135
3136         * buildstream/elements/freedesktop-sdk.bst: Update to FDO 19.08.11
3137         * buildstream/elements/sdk/gtk.bst: Update GTK4
3138         * buildstream/patches/fdo/0001-Pango-Bump-to-1.45-master.patch: Added. Needed for GTK4
3139         * buildstream/patches/fdo/0001-Add-Jack.patch: Removed. This will be used when we update to the 20.08 FDO SDK.
3140         * buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Removed. Ditto.
3141         * buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Removed. Ditto.
3142
3143 2020-06-03  Tadeu Zagallo  <tzagallo@apple.com>
3144
3145         Disable B3 hoistLoopInvariantValues by default
3146         https://bugs.webkit.org/show_bug.cgi?id=212511
3147         <rdar://problem/63813245>
3148
3149         Reviewed by Mark Lam.
3150
3151         Enable the B3 hoistLoopInvariantValues pass in one of our existing configurations to
3152         avoid bit rot since we'd like to re-enable it eventually.
3153
3154         * Scripts/run-jsc-stress-tests:
3155
3156 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3157
3158         [Text manipulation] Extract the value attribute in inputs of type "text" and "search"
3159         https://bugs.webkit.org/show_bug.cgi?id=212706
3160         <rdar://problem/63876969>
3161
3162         Reviewed by Tim Horton.
3163
3164         Add a new test case (similar to the existing test `StartTextManipulationExtractsValuesFromButtonInputs`) to
3165         verify that we extract text from the `value` of inputs of type "text" and "search".
3166
3167         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3168         (TestWebKitAPI::TEST):
3169
3170 2020-06-03  Michael Saboff  <msaboff@apple.com>
3171
3172         [iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug simulator builds
3173         https://bugs.webkit.org/show_bug.cgi?id=211650
3174
3175         Reviewed by Saam Barati.
3176
3177         The prior change to disable this test for Debug actually enabled it
3178         only for Debug IOS builds of any type, simulator or real HW.
3179
3180         This test has intermittently failed or timed out on Debug simulator
3181         builds for for almost a year.  We want to test Release builds as well as
3182         hardware builds. Therefore we should disable Debug simulator builds,
3183         and test all other variants.
3184
3185         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3186
3187 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3188
3189         dataTransfer.types is empty when handling the "dragstart" event
3190         https://bugs.webkit.org/show_bug.cgi?id=212685
3191         <rdar://problem/61368402>
3192
3193         Reviewed by Andy Estes.
3194
3195         Adds new API tests and test infrastructure to verify that DataTransfer types and data are accessible during
3196         the "dragstart" event. See below for more details.
3197
3198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3199         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3200         (-[TestWKWebView selectElementWithID:]):
3201         (-[DragAndDropSimulator dragFromElementWithID:to:]):
3202
3203         Add a few (very specialized) helper methods to assist with simulating drags over the various elements in the new
3204         drag and drop test harness page below (dragstart-data.html).
3205
3206         (runDragStartDataTestCase):
3207
3208         Test the following scenarios (split between three API tests) by dumping the resulting DataTransfer types and
3209         their data strings, and observing the results:
3210
3211         - Dragging a normal text selection.
3212         - Dragging a normal text selection, and then adding a URL string.
3213         - Dragging a normal text selection, and then adding a custom pasteboard type.
3214         - Dragging a normal text selection, but then replacing the data with just a URL string.
3215         - Dragging a normal text selection, but then replacing the data with just a custom data type.
3216         - Dragging an image element.
3217         - Dragging an image element, and then overriding the plain text data.
3218         - Dragging a link (anchor element).
3219         - Dragging a link, and then adding a custom type.
3220
3221         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-data.html: Added.
3222
3223         Add a new test harness to help test DataTransfer types when starting a drag. This test page can also be used as
3224         a manual test harness, by simply opening the test page, starting drags on the various elements and observing the
3225         output in the textarea.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
3228
3229         Tweak this test page to replace the DataTransfer with custom data (rather than simply append it) by calling
3230         `DataTransfer.clearData()` prior to writing the custom types.
3231
3232         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3233         * TestWebKitAPI/cocoa/TestWKWebView.h:
3234         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3235         (-[TestWKWebViewHostWindow initWithWebView:contentRect:styleMask:backing:defer:]):
3236
3237         Add a `__weak` reference on TestWKWebViewHostWindow back to the TestWKWebView, so that we can consult
3238         `-eventTimestamp` when synthesizing mouse events on macOS during API tests.
3239
3240         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
3241         (-[TestWKWebViewHostWindow _mouseUpAtPoint:clickCount:]):
3242         (-[TestWKWebViewHostWindow initWithWebView:frame:]):
3243         (-[TestWKWebView _setUpTestWindow:]):
3244         (-[TestWKWebView setEventTimestampOffset:]):
3245         (-[TestWKWebView eventTimestamp]):
3246
3247         Add a mechanism to offset synthetic event timestamps by a given time interval (i.e. the event timestamp offset).
3248
3249         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
3250         (-[TestWKWebView _mouseEventWithType:atLocation:]):
3251         (-[TestWKWebView typeCharacter:]):
3252         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3253         (-[DragAndDropSimulator runFrom:to:]):
3254
3255         While simulating drag and drop on macOS, use `-setEventTimestampOffset:` to "leap forward" in time, so that the
3256         150 millisecond delay when dragging a text selection doesn't prevent drags from beginning.
3257
3258 2020-06-03  Sihui Liu  <sihui_liu@apple.com>
3259
3260         Text manipulation sometimes fails to replace text in attributes
3261         https://bugs.webkit.org/show_bug.cgi?id=212701
3262
3263         Reviewed by Wenson Hsieh.
3264
3265         Modify TextManipulation.CompleteTextManipulationShouldReplaceTextContentWithMultipleTokens to cover text 
3266         manipulation for attributes.
3267
3268         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3269         (TestWebKitAPI::TEST):
3270
3271 2020-06-03  Diego Pino Garcia  <dpino@igalia.com>
3272
3273         [WPE] lint-test-expectations doesn't work when platform is WPE
3274         https://bugs.webkit.org/show_bug.cgi?id=212700
3275
3276         Reviewed by Carlos Alberto Lopez Perez.
3277
3278         When passing arguments '--wpe' or '--platform=wpe*',
3279         lint-test-expectations does nothing for WPE, despite currently 
3280         there are many lint errors in WPE's TestExpectations file.
3281
3282         As a side-effect of this patch, now `Tools/Scripts/webkit-path
3283         rebaseline` lists the WPE Release and Debug bots.
3284
3285         * Scripts/webkitpy/port/builders.py: Add WPE to the list of
3286         exact_matches and fuzzy_matches.
3287         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3288
3289 2020-06-03  Jonathan Bedard  <jbedard@apple.com>
3290
3291         Allow using web processes for service workers even though they loaded about URLs (Follow-up fix)
3292         https://bugs.webkit.org/show_bug.cgi?id=212464
3293
3294         Unreviewed build fix.
3295
3296         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: didFinishNavigation is now used unconditionally.
3297
3298 2020-06-02  Keith Rollin  <krollin@apple.com>
3299
3300         Revert FEATURES_DEFINES related changes
3301         https://bugs.webkit.org/show_bug.cgi?id=212664
3302         <rdar://problem/63893033>
3303
3304         Reviewed by Andy Estes.
3305
3306         Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to
3307         FEATURE_DEFINES and how the values there relate to those found in the
3308         Platform*.h files. Those changes break XCBuild (by removing the
3309         .xcfilelist related to UnifiedSources and the process for generating
3310         them), and so are being reverted.
3311
3312         * Scripts/webkitperl/FeatureList.pm:
3313         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3314         (WebCoreGenerator):
3315         (WebCoreGenerator._get_generate_unified_sources_script):
3316         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3317
3318 2020-06-02  Peng Liu  <peng.liu6@apple.com>
3319
3320         Stressing webkitSetPresentationMode leads to wrong inline video dimensions
3321         https://bugs.webkit.org/show_bug.cgi?id=202425
3322
3323         Reviewed by Eric Carlson.
3324
3325         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3326         (TEST):
3327
3328 2020-06-02  Youenn Fablet  <youenn@apple.com>
3329
3330         Allow using web processes for service workers even though they loaded about URLs
3331         https://bugs.webkit.org/show_bug.cgi?id=212464
3332
3333         Reviewed by Chris Dumez.
3334
3335         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3336
3337 2020-06-02  Diego Pino Garcia  <dpino@igalia.com>
3338
3339         [buildbot] [GTK][WPE] Move JavaScript related tests to own bot
3340         https://bugs.webkit.org/show_bug.cgi?id=212481
3341
3342         Reviewed by Carlos Alberto Lopez Perez.
3343
3344         Currently GTK and WPE tests bots run too many tests. This makes
3345         the total running time for each build very long.
3346
3347         This patch moves JavaScript related tests (jscore-test and
3348         test262-test) to a separated bot which will be triggered by the
3349         corresponding build bot of each platform.
3350
3351         * BuildSlaveSupport/build.webkit.org-config/config.json:
3352         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3353         (TestFactory.__init__):
3354         (TestJSFactory):
3355         (TestJSFactory.__init__):
3356         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3357
3358 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3359
3360         [GTK4] Make popup menus work
3361         https://bugs.webkit.org/show_bug.cgi?id=211178
3362
3363         Reviewed by Adrian Perez de Castro.
3364
3365         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3366         (WTR::PlatformWebView::dismissAllPopupMenus):
3367
3368 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3369
3370         [GTK4] Make it possible to run layout tests
3371         https://bugs.webkit.org/show_bug.cgi?id=212328
3372
3373         Reviewed by Carlos Alberto Lopez Perez.
3374
3375         Build WTR with GTK4.
3376
3377         * PlatformGTK.cmake:
3378         * Scripts/webkitdirs.pm:
3379         (builtDylibPathForName): Try with both 4 and 5 API versions.
3380         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3381         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3382         (WTR::PlatformWebView::PlatformWebView):
3383         (WTR::PlatformWebView::~PlatformWebView):
3384         (WTR::PlatformWebView::setWindowIsKey):
3385         (WTR::PlatformWebView::windowFrame):
3386         (WTR::PlatformWebView::setWindowFrame):
3387         (WTR::PlatformWebView::addToWindow):
3388         (WTR::PlatformWebView::removeFromWindow):
3389         (WTR::PlatformWebView::windowSnapshotImage):
3390         (WTR::PlatformWebView::dismissAllPopupMenus):
3391         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3392         (WTR::UIScriptControllerGtk::copyText):
3393
3394 2020-06-01  Noam Rosenthal  <noam@webkit.org>
3395
3396         Make unicode-bidi:isolate the default for an element with a dir attribute (instead of unicode-bidi:embed)
3397         https://bugs.webkit.org/show_bug.cgi?id=134630
3398
3399         Reviewed by Simon Fraser.
3400
3401         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
3402         (TEST):
3403                 Test was expecting unicode-bidi:embed, changed expectation.
3404
3405 2020-06-01  Sihui Liu  <sihui_liu@apple.com>
3406
3407         TextManipulationController should put one Node in only one paragraph
3408         https://bugs.webkit.org/show_bug.cgi?id=212548
3409
3410         Reviewed by Wenson Hsieh.
3411
3412         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3413         (TestWebKitAPI::TEST):
3414
3415 2020-06-01  Alex Christensen  <achristensen@webkit.org>
3416
3417         Make CustomDisplayName and DefaultDisplayName API tests fail instead of timing out when something changes
3418         https://bugs.webkit.org/show_bug.cgi?id=212480
3419
3420         This saves time when debugging and running all the tests.
3421
3422         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
3423         (TestWebKitAPI::checkUntilDisplayNameIs):
3424
3425 2020-06-01  Philippe Normand  <pnormand@igalia.com>
3426
3427         [Flatpak SDK] Install and update don't provide any terminal output
3428         https://bugs.webkit.org/show_bug.cgi?id=212579
3429
3430         Reviewed by Žan Doberšek.
3431
3432         The `show_output` option was removed from the process execution routines. We now assume the
3433         output will be displayed, unless the call-site asks `gather_output`. This change makes
3434         webkit-flatpak more chatty, which is nice during install/update operations.
3435
3436         * flatpak/flatpakutils.py:
3437         (run_sanitized):
3438         (FlatpakObject.flatpak):
3439         (FlatpakPackage.install):
3440         (FlatpakPackage.update):
3441         (WebkitFlatpak.setup_builddir):
3442         (WebkitFlatpak.run_in_sandbox):
3443
3444 2020-06-01  Chris Dumez  <cdumez@apple.com>
3445
3446         ASSERTION FAILURE (r220931): !m_function in ~CompletionHandler() after switch tabs
3447         https://bugs.webkit.org/show_bug.cgi?id=212537
3448         <rdar://problem/63766838>
3449
3450         Reviewed by Alex Christensen.
3451
3452         Add API test coverage.
3453
3454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3455         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspension.mm: Added.
3456         (TEST):
3457
3458 2020-06-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3459
3460         [EWS] Add a special case for running the layout test step without aborting in case of many failures for WPT tests
3461         https://bugs.webkit.org/show_bug.cgi?id=212381
3462
3463         Reviewed by Jonathan Bedard.
3464
3465         Add a special case for patches uploaded by the bugzilla user that would be used
3466         for prototyping a bot that helps automating the import of WPT tests. For patches
3467         uploaded by this user don't pass the parameters that make the step abort early in
3468         case of many errors, and only run the layout tests inside the WPT import directory.
3469
3470         * BuildSlaveSupport/ews-build/steps.py:
3471         (RunWebKitTests):
3472         (RunWebKitTests.start):
3473         * BuildSlaveSupport/ews-build/steps_unittest.py:
3474         (test_success):
3475         (test_warnings):
3476         (test_parse_results_json_regression):
3477         (test_parse_results_json_flakes):
3478         (test_parse_results_json_flakes_and_regressions):
3479         (test_parse_results_json_with_newlines):
3480         (test_unexpected_error):
3481         (test_failure):
3482         (test_success_wpt_import_bot):
3483         (TestRunWebKitTestsWithoutPatch.test_success):
3484         (TestRunWebKitTestsWithoutPatch.test_failure):
3485         (TestRunWebKit1Tests.test_success):
3486         (TestRunWebKit1Tests.test_failure):
3487
3488 2020-06-01  Sam Weinig  <weinig@apple.com>
3489
3490         Extended Color: Replace Color constructors taking numeric values with type specific factory functions
3491         https://bugs.webkit.org/show_bug.cgi?id=212576
3492
3493         Reviewed by Tim Horton.
3494
3495         Replaces all remaining implicit and explicit uses of the Color constructors taking numeric
3496         values with explicit calls to makeSimpleColor/makeSimpleColorFromFloats/makeExtendedColor,
3497         giving us a consistent way to create colors. Also addes use constexpr SimpleColors where possible.
3498
3499         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
3500         (TestWebKitAPI::TEST):
3501         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3502         (TestWebKitAPI::TEST):
3503         (TestWebKitAPI::makeColor):
3504         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
3505         (TestWebKitAPI::TEST):
3506         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
3507         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
3508
3509 2020-05-31  Dean Jackson  <dino@apple.com>
3510
3511         AutoTrader crashed while browsing search results
3512         https://bugs.webkit.org/show_bug.cgi?id=212461
3513         rdar://60733185
3514
3515         Reviewed by Sam Weinig.
3516
3517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3518         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm: Added.
3519         (-[WebGLPrepareDisplayOnWebThreadDelegate webViewDidFinishLoad:]):
3520         (-[WebGLPrepareDisplayOnWebThreadDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3521         (TestWebKitAPI::TEST):
3522         * TestWebKitAPI/Tests/WebKitLegacy/ios/webgl.html: Added.
3523
3524 2020-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3525
3526         Unreviewed. Fix GTK4 build with current GTK
3527
3528         * MiniBrowser/gtk/BrowserTab.c:
3529         (audioMutedChanged):
3530
3531 2020-05-30  Sam Weinig  <weinig@apple.com>
3532
3533         Extended Color: Additional color cleanups
3534         https://bugs.webkit.org/show_bug.cgi?id=212567
3535
3536         Reviewed by Simon Fraser.
3537
3538         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3539         (TestWebKitAPI::TEST):
3540         Update for rename from ExtendedColor::channels() to ExtendedColor::components()
3541
3542 2020-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3543
3544         [GTK] WebDriver: stop using GdkEvent API in preparation for GTK4
3545         https://bugs.webkit.org/show_bug.cgi?id=212465
3546
3547         Reviewed by Adrian Perez de Castro.
3548
3549         Update to the new webkitWebViewBaseSynthesizeKeyEvent() API.
3550
3551         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3552         (WTR::EventSenderProxy::keyDown):
3553
3554 2020-05-29  Alex Christensen  <achristensen@webkit.org>
3555
3556         Use correct encoding when converting a WTF::URL to CFURLRef
3557         https://bugs.webkit.org/show_bug.cgi?id=212486
3558
3559         Reviewed by Darin Adler.
3560
3561         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3562         (TestWebKitAPI::TEST):
3563
3564 2020-05-29  Andy Estes  <aestes@apple.com>
3565
3566         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
3567         https://bugs.webkit.org/show_bug.cgi?id=212541
3568
3569         Reviewed by Darin Adler.
3570
3571         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
3572
3573         * Scripts/webkitperl/FeatureList.pm:
3574         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3575
3576 2020-05-29  Jan-Michael Brummer  <jan.brummer@tabos.org>
3577
3578         [GTK][WPE] API for WebView audio mute support
3579         https://bugs.webkit.org/show_bug.cgi?id=176119
3580
3581         Reviewed by Michael Catanzaro.
3582
3583         * MiniBrowser/gtk/BrowserTab.c:
3584         (audioClicked):
3585         (audioMutedChanged):
3586         (browserTabConstructed):
3587         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3588         (testWebViewIsAudioMuted):
3589         (beforeAll):
3590
3591 2020-05-29  Darin Adler  <darin@apple.com>
3592
3593         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
3594         https://bugs.webkit.org/show_bug.cgi?id=212418
3595
3596         Rubber-stamped by Simon Fraser.
3597
3598         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add back ENABLE_CSS_CONIC_GRADIENTS,
3599         removed by accident.
3600
3601 2020-05-29  Pavel  <pavel.feldman@gmail.com>
3602
3603         [Win] Allow compiling with the TOUCH_EVENTS enabled
3604         https://bugs.webkit.org/show_bug.cgi?id=212528
3605
3606         Reviewed by Fujii Hironori.
3607
3608         Aligning Win with GTK, adding missing EventSenderProxy stubs.
3609         This allows compiling Win with TOUCH_EVENTS and unlocks event
3610         injection / processing by the automation drivers
3611
3612         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3613         (WTR::EventSenderProxy::addTouchPoint):
3614         (WTR::EventSenderProxy::updateTouchPoint):
3615         (WTR::EventSenderProxy::setTouchModifier):
3616         (WTR::EventSenderProxy::setTouchPointRadius):
3617         (WTR::EventSenderProxy::touchStart):
3618         (WTR::EventSenderProxy::touchMove):
3619         (WTR::EventSenderProxy::touchEnd):
3620         (WTR::EventSenderProxy::touchCancel):
3621         (WTR::EventSenderProxy::clearTouchPoints):
3622         (WTR::EventSenderProxy::releaseTouchPoint):
3623         (WTR::EventSenderProxy::cancelTouchPoint):
3624
3625 2020-05-27  Darin Adler  <darin@apple.com>
3626
3627         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
3628         https://bugs.webkit.org/show_bug.cgi?id=212418
3629
3630         Reviewed by Andy Estes.
3631
3632         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Removed 83 of the 119 things
3633         defined in this file. There are 36 more that are slightly more complex that we can
3634         remove carefully later.
3635
3636 2020-05-29  Darin Adler  <darin@apple.com>
3637
3638         Make generate-unified-sources.sh not depend on features being listed in FEATURE_DEFINES environment variable
3639         https://bugs.webkit.org/show_bug.cgi?id=212420
3640
3641         Reviewed by Andy Estes.
3642
3643         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3644         (WebCoreGenerator._get_generate_derived_sources_script): Removed the code
3645         to generate UnifiedSources-output.xcfilelist.
3646
3647 2020-05-29  Keith Rollin  <krollin@apple.com>
3648
3649         Revert switch to XCBuild
3650