139add0f9e784cfaacf93663cf4f1e7366550c39
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2
3         [webkitpy] Improve _parse_bug_description to recognize more descriptions
4         https://bugs.webkit.org/show_bug.cgi?id=130137
5
6         Reviewed by Csaba Osztrogonác.
7
8         * Scripts/webkitpy/common/checkout/changelog.py:
9         (ChangeLogEntry._parse_bug_description):
10         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
11         (test_parse_log_entries_from_changelog):
12         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
13         (CheckoutTest.test_commit_info_for_revision):
14
15 2014-03-24  Andy Estes  <aestes@apple.com>
16
17         Fix the iOS build of TestWebKitAPI.
18
19         * TestWebKitAPI/Configurations/Base.xcconfig:
20         * TestWebKitAPI/PlatformUtilities.h:
21
22 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
23
24         Fix prepare-ChangeLog after r166156.
25         https://bugs.webkit.org/show_bug.cgi?id=130674
26
27         Reviewed by Darin Adler.
28
29         * Scripts/prepare-ChangeLog:
30         (generateFunctionLists):
31         (extractLineRangeBeforeChange):
32
33 2014-03-24  Andy Estes  <aestes@apple.com>
34
35         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
36         https://bugs.webkit.org/show_bug.cgi?id=129322
37
38         Reviewed by Anders Carlsson.
39
40         Add an API test suite for _WKDownload.
41
42         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
43         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
44         (-[DownloadDelegate initWithSourceURL:]):
45         (-[DownloadDelegate sourceURL]):
46         (-[DownloadDelegate _downloadDidStart:]):
47         (-[DownloadDelegate _download:didReceiveResponse:]):
48         (-[DownloadDelegate _download:didReceiveData:]):
49         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
50         (-[DownloadDelegate _downloadDidFinish:]):
51         (TEST):
52         (runTestWithNavigationDelegate):
53         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
54         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
55
56 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
57
58         filter-build-webkit: reduce unfiltered output
59         https://bugs.webkit.org/show_bug.cgi?id=130485
60
61         Reviewed by Brent Fulgham.
62
63         * Scripts/filter-build-webkit:
64         (shouldIgnoreLine):
65
66 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
67
68         prepare-ChangeLog should list functions that have been removed too.
69         https://bugs.webkit.org/show_bug.cgi?id=130508
70
71         Reviewed by Darin Adler.
72
73         The prepare-ChangeLog does not list the deleted functions in the Changelog.
74         We have to read the functions and the line ranges of them from the source
75         before the change, then search for overlaps between them and the changed
76         line ranges from diff.
77
78         * Scripts/prepare-ChangeLog:
79         (originalFile): Get original source command.
80         (generateFunctionLists): Collect deleted functions too.
81         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
82         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
83         deleted functions ranges too.
84         (extractLineRange): Renamed to extractLineRangeAfterChange.
85
86 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
87
88         Move all EFL typedefs into EflTypedefs.h.
89         https://bugs.webkit.org/show_bug.cgi?id=130511
90
91         Reviewed by Gyuyoung Kim.
92
93         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
94         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
95         * WebKitTestRunner/PlatformWebView.h: Ditto.
96
97 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
98
99         Don't flush compositing layers within FrameView::willPaintContents()
100         https://bugs.webkit.org/show_bug.cgi?id=130627
101         <rdar://problem/16368869>
102
103         Reviewed by Sam Weinig.
104         
105         Fix DRT to correctly render tests with layers now that FrameView::paintContents
106         does not flush.
107         
108         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
109         into an explicit function called before dumping. 
110         
111         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
112         are flushed to CA. They will be pushed to the window by snapshotting.
113
114         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
115         Fix weird path to IOKit.framework.
116         * DumpRenderTree/mac/DumpRenderTree.mm:
117         (updateDisplay):
118         (dump):
119         * DumpRenderTree/mac/FrameLoadDelegate.mm:
120         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
121         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
122
123 2014-03-21  David Kilzer  <ddkilzer@apple.com>
124
125         fix-blink-patch: tool to fix up renamed directory paths in Blink
126         <http://webkit.org/b/130609>
127
128         Reviewed by Ryosuke Niwa.
129
130         Usage: cat blink.patch | fix-blink-patch | svn-apply
131
132         * Scripts/fix-blink-patch: Added.
133
134 2014-03-21  Darin Adler  <darin@apple.com>
135
136         Remove use of deprecatedCharacters in WebKit API tests
137         https://bugs.webkit.org/show_bug.cgi?id=130602
138
139         Reviewed by Antti Koivisto.
140
141         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
142         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
143         (TestWebKitAPI::expectEmpty): Use characters8.
144         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
145
146         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
147         Removed the test that is entirely about 16-bit conversion since that's basically a test of
148         the deprecatedCharacters function itself, which we are about to delete.
149
150 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
151
152         [webkitpy] Fix has_valid_reviewer()
153         https://bugs.webkit.org/show_bug.cgi?id=130589
154
155         Reviewed by Csaba Osztrogonác.
156
157         * Scripts/webkitpy/common/checkout/changelog.py:
158         (ChangeLogEntry.has_valid_reviewer):
159         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
160         (test_has_valid_reviewer):
161         * Scripts/webkitpy/common/config/committers.py:
162         (CommitterList._reviewer_only):
163         (CommitterList.committer_by_name):
164         (CommitterList.reviewer_by_email):
165         (CommitterList):
166         (CommitterList.reviewer_by_name):
167
168 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
169
170         Add cache support for jhbuild
171         https://bugs.webkit.org/show_bug.cgi?id=130588
172
173         Reviewed by Csaba Osztrogonác.
174
175         * jhbuild/jhbuildrc_common.py:
176         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
177
178 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
179
180         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
181         https://bugs.webkit.org/show_bug.cgi?id=130504
182
183         Reviewed by Martin Robinson.
184
185         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
186         CMake if not specified.
187         * Scripts/webkitdirs.pm:
188         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
189         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
190
191 2014-03-21  Andreas Kling  <akling@apple.com>
192
193         RetainPtr API test should use CFArray instead of CFString for testing.
194         <rdar://problem/16384899>
195
196         Unreviewed bot fix.
197
198         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
199         (TestWebKitAPI::TEST):
200         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
201         (TestWebKitAPI::TEST):
202
203 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
204
205         Move to using std::unique_ptr for EFL objects.
206         https://bugs.webkit.org/show_bug.cgi?id=129853
207
208         Reviewed by Gyuyoung Kim.
209
210         EflUniquePtr is a template alias of std::unique_ptr
211         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
212         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
213
214         * DumpRenderTree/efl/DumpRenderTree.cpp:
215         (main):
216         * ImageDiff/efl/ImageDiff.cpp:
217         (initEfl):
218         (main):
219
220 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
221
222         Unreviewed buildfix after r165983 for non Cocoa platforms
223
224         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
225
226         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
227         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
228         * WebKitTestRunner/TestController.cpp:
229
230 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
231
232         [GTK][CMake] Add support for building with Clang
233         https://bugs.webkit.org/show_bug.cgi?id=130260
234
235         Reviewed by Martin Robinson.
236
237         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
238         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
239         included GTest framework headers.
240         * gtk/generate-gtkdoc:
241         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
242         in case of using Clang since that is now set by the CMake rule.
243
244 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
245
246         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
247         https://bugs.webkit.org/show_bug.cgi?id=130476
248
249         Reviewed by Anders Carlsson.
250         
251         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
252
253         * MiniBrowser/mac/WK1BrowserWindowController.m:
254         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
255         Remove log.
256         * MiniBrowser/mac/WK2BrowserWindowController.m:
257         (-[WK2BrowserWindowController awakeFromNib]):
258         (-[WK2BrowserWindowController validateMenuItem:]):
259         (-[WK2BrowserWindowController reload:]):
260         Hook up reload.
261         (-[WK2BrowserWindowController toggleZoomMode:]):
262         (-[WK2BrowserWindowController resetZoom:]):
263         (-[WK2BrowserWindowController canResetZoom]):
264         (-[WK2BrowserWindowController currentZoomFactor]):
265         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
266         (-[WK2BrowserWindowController canZoomIn]):
267         (-[WK2BrowserWindowController canZoomOut]):
268
269 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
270
271         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
272         https://bugs.webkit.org/show_bug.cgi?id=130463
273
274         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
275
276 2014-03-18  Samuel White  <samuel_white@apple.com>
277
278         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
279         https://bugs.webkit.org/show_bug.cgi?id=130250
280
281         Reviewed by Chris Fleizach.
282
283         Added ability to toggle enhanced accessibility on and off to support tests that require it.
284
285         * DumpRenderTree/AccessibilityController.cpp:
286         (enableEnhancedAccessibilityCallback):
287         (getEnhancedAccessibilityEnabledCallback):
288         (AccessibilityController::getJSClass):
289         * DumpRenderTree/AccessibilityController.h:
290         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
291         (AccessibilityController::enableEnhancedAccessibility):
292         (AccessibilityController::enhancedAccessibilityEnabled):
293         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
294         (AccessibilityController::enableEnhancedAccessibility):
295         (AccessibilityController::enhancedAccessibilityEnabled):
296         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
297         (AccessibilityController::enableEnhancedAccessibility):
298         (AccessibilityController::enhancedAccessibilityEnabled):
299         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
300         (AccessibilityController::enableEnhancedAccessibility):
301         (AccessibilityController::enhancedAccessibilityEnabled):
302         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
303         (WTR::AccessibilityController::enableEnhancedAccessibility):
304         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
305         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
306         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
307
308 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
309
310         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
311         yet).
312
313         * Scripts/webkitpy/common/config/contributors.json:
314
315 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
316
317         Web Inspector: Remove stale ReportMemoryUsagePlugin
318         https://bugs.webkit.org/show_bug.cgi?id=130405
319
320         Reviewed by Andreas Kling.
321
322         This clang plugin looks like it was used for the old Inspector memory
323         instrumentation that was removed. So the tool can be removed.
324
325         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
326         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
327         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
328         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
329
330 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
331
332         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
333         https://bugs.webkit.org/show_bug.cgi?id=130220
334
335         Reviewed by Csaba Osztrogonác.
336
337         * Scripts/webkitpy/common/checkout/changelog.py:
338         (ChangeLog.set_reviewer):
339         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
340         (test_set_reviewer):
341
342 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
343
344         More FTL enabling.
345
346         Rubber stamped by Dan Bernstein.
347
348         * Tools/Scripts/build-webkit:
349
350 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
351
352         Renable pagination mode in WK2 MiniBrowser
353         https://bugs.webkit.org/show_bug.cgi?id=130374
354
355         Reviewed by Anders Carlsson.
356         
357         Put the implementation of togglePaginationMode: back, and correctly
358         enable the menu item.
359
360         * MiniBrowser/mac/WK2BrowserWindowController.m:
361         (-[WK2BrowserWindowController validateMenuItem:]):
362         (-[WK2BrowserWindowController isPaginated]):
363         (-[WK2BrowserWindowController togglePaginationMode:]):
364
365 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
366
367         Add --reset option to Tools/Scripts/set-webkit-configuration script
368         https://bugs.webkit.org/show_bug.cgi?id=130401
369
370         Reviewed by Csaba Osztrogonác.
371
372         * Scripts/set-webkit-configuration:
373
374 2014-03-18  Alberto Garcia  <berto@igalia.com>
375
376         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
377         https://bugs.webkit.org/show_bug.cgi?id=130388
378
379         Reviewed by Sergio Villar Senin.
380
381         * Scripts/webkitdirs.pm:
382         (shouldRemoveCMakeCache): make sure that the build directory
383         exists before attempting to create a file in it.
384
385 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
386
387         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
388         https://bugs.webkit.org/show_bug.cgi?id=130336
389
390         Reviewed by Gyuyoung Kim.
391
392         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
393         requires a space between literal and string macro [-Wliteral-suffix]'
394         warning treated as error.
395
396         This patch applies a solution from r162448 to the EFL port.
397
398         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
399         * efl/jhbuild.modules: Added appropriate patch section.
400
401 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
402
403         webkitpy test rebaseline.
404
405         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
406         (MainTest.test_default_args):
407
408 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
409
410         --profile should imply --test-runner-count=1 in run-perf-tests
411         https://bugs.webkit.org/show_bug.cgi?id=130375
412
413         Reviewed by Benjamin Poulain.
414
415         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
416
417         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
418         (PerfTestsRunner._parse_args): Use -1 as the default value.
419         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
420         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
421         should be 1.
422
423 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
424
425         Address some style nits.
426
427         * MiniBrowser/mac/WK2BrowserWindowController.m:
428
429 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
430
431         Add transparent window support back into MiniBrowser
432         https://bugs.webkit.org/show_bug.cgi?id=130363
433
434         Reviewed by Anders Carlsson.
435         
436         Re-enable transparent window support for WK2.
437
438         * MiniBrowser/mac/WK2BrowserWindowController.m:
439         (-[WK2BrowserWindowController validateMenuItem:]):
440         (-[WK2BrowserWindowController toggleTransparentWindow:]):
441
442 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
443
444         Fix the 32-bit build; make the open panel make a WK1 window.
445
446         * MiniBrowser/mac/AppDelegate.m:
447         (-[BrowserAppDelegate openDocument:]):
448
449 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
450
451         Convert MiniBrowser to use WKWebView API
452         https://bugs.webkit.org/show_bug.cgi?id=130061
453
454         Reviewed by Anders Carlsson.
455         
456         Convert the MiniBrowser WK2 window to use WebKit2 API as much
457         as possible.
458         
459         Some functionality was removed temporarily:
460             - text zoom, page zoom
461             - reload
462             - pagination mode
463             - transparent window
464             - dumping source
465             - window.open support
466             - beforeUnload panel
467             - find in page
468
469         * MiniBrowser/mac/AppDelegate.h:
470         * MiniBrowser/mac/AppDelegate.m:
471         (-[BrowserAppDelegate init]):
472         (-[BrowserAppDelegate newWindow:]):
473         (-[BrowserAppDelegate applicationWillTerminate:]):
474         (-[BrowserAppDelegate openDocument:]):
475         * MiniBrowser/mac/WK2BrowserWindowController.h:
476         * MiniBrowser/mac/WK2BrowserWindowController.m:
477         (-[WK2BrowserWindowController awakeFromNib]):
478         (-[WK2BrowserWindowController dealloc]):
479         (-[WK2BrowserWindowController fetch:]):
480         (-[WK2BrowserWindowController validateMenuItem:]):
481         (-[WK2BrowserWindowController reload:]):
482         (-[WK2BrowserWindowController goBack:]):
483         (-[WK2BrowserWindowController goForward:]):
484         (-[WK2BrowserWindowController toggleZoomMode:]):
485         (-[WK2BrowserWindowController resetZoom:]):
486         (-[WK2BrowserWindowController canResetZoom]):
487         (-[WK2BrowserWindowController dumpSourceToConsole:]):
488         (-[WK2BrowserWindowController togglePaginationMode:]):
489         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
490         (-[WK2BrowserWindowController windowShouldClose:]):
491         (-[WK2BrowserWindowController applicationTerminating]):
492         (-[WK2BrowserWindowController currentZoomFactor]):
493         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
494         (-[WK2BrowserWindowController toggleTransparentWindow:]):
495         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
496         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
497         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
498         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
499         (-[WK2BrowserWindowController find:]):
500         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
501         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
502         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
503         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
504         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
505         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
506         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
507         * WebKitTestRunner/PlatformWebView.h:
508         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
509         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
510
511 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
512
513         Use RunLoop objects through references instead of pointers
514         https://bugs.webkit.org/show_bug.cgi?id=130313
515
516         Reviewed by Andreas Kling.
517
518         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
519         return RunLoop reference instead of a pointer.
520
521         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
522         (loadedCallback):
523         (clickedCallback):
524
525 2014-03-17  Tim Horton  <timothy_horton@apple.com>
526
527         sort-export-file --help doesn't work (missing 'use')
528         https://bugs.webkit.org/show_bug.cgi?id=130338
529
530         Reviewed by Anders Carlsson.
531
532         * Scripts/sort-export-file:
533         Add a missing 'use', and fix a typo in an error message.
534
535 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
536
537         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
538         https://bugs.webkit.org/show_bug.cgi?id=130155
539
540         Reviewed by Philippe Normand.
541
542         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
543
544 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
545
546         [GTK] MiniBrowser fails to load injected bundle lib
547         https://bugs.webkit.org/show_bug.cgi?id=130332
548
549         Reviewed by Anders Carlsson.
550
551         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
552
553         * MiniBrowser/gtk/main.c:
554         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
555         process is spawn.
556
557 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
558
559         [EFL] Enable TOUCH_SLIDER macro
560         https://bugs.webkit.org/show_bug.cgi?id=130185
561
562         Reviewed by Gyuyoung Kim.
563
564         * Scripts/webkitperl/FeatureList.pm:
565
566 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
567
568         [GTK][CMake] Build with -fno-rtti
569         https://bugs.webkit.org/show_bug.cgi?id=130261
570
571         Reviewed by Martin Robinson.
572
573         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
574         defined to 0 to prevent typeid use in included GTest headers.
575
576 2014-03-16  Brian Burg  <bburg@apple.com>
577
578         Web Inspector: vended backend commands file should be generated as part of the build
579         https://bugs.webkit.org/show_bug.cgi?id=130110
580
581         Reviewed by Timothy Hatcher.
582
583         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
584
585 2014-03-16  Diego Pino García  <dpino@igalia.com>
586
587         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
588         https://bugs.webkit.org/show_bug.cgi?id=128999
589
590         Reviewed by Philippe Normand.
591
592         * MiniBrowser/gtk/BrowserWindow.c:
593         (reloadPage):
594         (reloadPageIgnoringCache):
595         (browser_window_init):
596
597 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
598
599         [GTK] Improve ninja detection in webkitdirs.pm
600         https://bugs.webkit.org/show_bug.cgi?id=129902
601
602         Reviewed by Daniel Bates.
603
604         * Scripts/webkitdirs.pm:
605         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
606         us to look for ninja-build as well.
607
608 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
609
610         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
611         https://bugs.webkit.org/show_bug.cgi?id=130276
612         <rdar://problem/16266927>
613         
614         Reviewed by Simon Fraser.
615
616         * BuildSlaveSupport/build-launcher-app:
617         * BuildSlaveSupport/build-launcher-dmg:
618         * DumpRenderTree/DumpRenderTree.h:
619         * DumpRenderTree/DumpRenderTreePrefix.h:
620         * DumpRenderTree/GCController.cpp:
621         * DumpRenderTree/GCController.h:
622         * DumpRenderTree/JavaScriptThreading.cpp:
623         * DumpRenderTree/JavaScriptThreading.h:
624         * DumpRenderTree/PixelDumpSupport.cpp:
625         * DumpRenderTree/PixelDumpSupport.h:
626         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
627         * DumpRenderTree/TestRunner.cpp:
628         * DumpRenderTree/TestRunner.h:
629         * DumpRenderTree/WorkQueue.cpp:
630         * DumpRenderTree/WorkQueue.h:
631         * DumpRenderTree/WorkQueueItem.h:
632         * DumpRenderTree/atk/AccessibilityCallbacks.h:
633         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
634         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
635         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
636         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
637         * DumpRenderTree/cg/PixelDumpSupportCG.h:
638         * DumpRenderTree/efl/EditingCallbacks.cpp:
639         * DumpRenderTree/efl/EditingCallbacks.h:
640         * DumpRenderTree/efl/EventSender.cpp:
641         * DumpRenderTree/efl/EventSender.h:
642         * DumpRenderTree/efl/GCControllerEfl.cpp:
643         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
644         * DumpRenderTree/efl/TestRunnerEfl.cpp:
645         * DumpRenderTree/gtk/DumpRenderTree.cpp:
646         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
647         * DumpRenderTree/gtk/EditingCallbacks.cpp:
648         * DumpRenderTree/gtk/EditingCallbacks.h:
649         * DumpRenderTree/gtk/EventSender.cpp:
650         * DumpRenderTree/gtk/EventSender.h:
651         * DumpRenderTree/gtk/GCControllerGtk.cpp:
652         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
653         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
654         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
655         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
656         * DumpRenderTree/gtk/TextInputController.cpp:
657         * DumpRenderTree/gtk/TextInputController.h:
658         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
659         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
660         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
661         * DumpRenderTree/mac/AppleScriptController.h:
662         * DumpRenderTree/mac/AppleScriptController.m:
663         * DumpRenderTree/mac/CheckedMalloc.cpp:
664         * DumpRenderTree/mac/CheckedMalloc.h:
665         * DumpRenderTree/mac/DumpRenderTree.mm:
666         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
667         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
668         * DumpRenderTree/mac/DumpRenderTreeMac.h:
669         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
670         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
671         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
672         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
673         * DumpRenderTree/mac/EditingDelegate.h:
674         * DumpRenderTree/mac/EditingDelegate.mm:
675         * DumpRenderTree/mac/EventSendingController.h:
676         * DumpRenderTree/mac/EventSendingController.mm:
677         * DumpRenderTree/mac/FrameLoadDelegate.h:
678         * DumpRenderTree/mac/FrameLoadDelegate.mm:
679         * DumpRenderTree/mac/GCControllerMac.mm:
680         * DumpRenderTree/mac/MockWebNotificationProvider.h:
681         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
682         * DumpRenderTree/mac/NavigationController.h:
683         * DumpRenderTree/mac/NavigationController.m:
684         * DumpRenderTree/mac/ObjCController.h:
685         * DumpRenderTree/mac/ObjCController.m:
686         * DumpRenderTree/mac/ObjCPlugin.h:
687         * DumpRenderTree/mac/ObjCPlugin.m:
688         * DumpRenderTree/mac/ObjCPluginFunction.h:
689         * DumpRenderTree/mac/ObjCPluginFunction.m:
690         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
691         * DumpRenderTree/mac/PolicyDelegate.h:
692         * DumpRenderTree/mac/PolicyDelegate.mm:
693         * DumpRenderTree/mac/ResourceLoadDelegate.h:
694         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
695         * DumpRenderTree/mac/TestRunnerMac.mm:
696         * DumpRenderTree/mac/TextInputController.h:
697         * DumpRenderTree/mac/TextInputController.m:
698         * DumpRenderTree/mac/UIDelegate.h:
699         * DumpRenderTree/mac/UIDelegate.mm:
700         * DumpRenderTree/mac/WorkQueueItemMac.mm:
701         * DumpRenderTree/win/DRTDataObject.cpp:
702         * DumpRenderTree/win/DRTDataObject.h:
703         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
704         * DumpRenderTree/win/DRTDropSource.cpp:
705         * DumpRenderTree/win/DRTDropSource.h:
706         * DumpRenderTree/win/DraggingInfo.h:
707         * DumpRenderTree/win/DumpRenderTree.cpp:
708         * DumpRenderTree/win/DumpRenderTreeWin.h:
709         * DumpRenderTree/win/EditingDelegate.cpp:
710         * DumpRenderTree/win/EditingDelegate.h:
711         * DumpRenderTree/win/EventSender.cpp:
712         * DumpRenderTree/win/EventSender.h:
713         * DumpRenderTree/win/FrameLoadDelegate.cpp:
714         * DumpRenderTree/win/FrameLoadDelegate.h:
715         * DumpRenderTree/win/GCControllerWin.cpp:
716         * DumpRenderTree/win/HistoryDelegate.cpp:
717         * DumpRenderTree/win/HistoryDelegate.h:
718         * DumpRenderTree/win/MD5.cpp:
719         * DumpRenderTree/win/MD5.h:
720         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
721         * DumpRenderTree/win/PolicyDelegate.cpp:
722         * DumpRenderTree/win/PolicyDelegate.h:
723         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
724         * DumpRenderTree/win/ResourceLoadDelegate.h:
725         * DumpRenderTree/win/TestRunnerWin.cpp:
726         * DumpRenderTree/win/TextInputController.cpp:
727         * DumpRenderTree/win/TextInputController.h:
728         * DumpRenderTree/win/TextInputControllerWin.cpp:
729         * DumpRenderTree/win/UIDelegate.cpp:
730         * DumpRenderTree/win/UIDelegate.h:
731         * DumpRenderTree/win/WorkQueueItemWin.cpp:
732         * EWebLauncher/main.c:
733         * GtkLauncher/main.c:
734         * ImageDiff/efl/ImageDiff.cpp:
735         * ImageDiff/gtk/ImageDiff.cpp:
736         * MiniBrowser/gtk/main.c:
737         * Scripts/SpacingHeuristics.pm:
738         * Scripts/VCSUtils.pm:
739         * Scripts/bisect-builds:
740         * Scripts/build-dumprendertree:
741         * Scripts/build-jsc:
742         * Scripts/build-webkit:
743         * Scripts/check-dom-results:
744         * Scripts/check-for-exit-time-destructors:
745         * Scripts/check-for-global-initializers:
746         * Scripts/commit-log-editor:
747         * Scripts/compare-timing-files:
748         * Scripts/debug-minibrowser:
749         * Scripts/debug-safari:
750         * Scripts/do-file-rename:
751         * Scripts/find-extra-includes:
752         * Scripts/generate-coverage-data:
753         * Scripts/make-script-test-wrappers:
754         * Scripts/malloc-tree:
755         * Scripts/old-run-webkit-tests:
756         * Scripts/parse-malloc-history:
757         * Scripts/report-include-statistics:
758         * Scripts/resolve-ChangeLogs:
759         * Scripts/run-bindings-tests:
760         * Scripts/run-iexploder-tests:
761         * Scripts/run-javascriptcore-tests:
762         * Scripts/run-jsc:
763         * Scripts/run-launcher:
764         * Scripts/run-leaks:
765         * Scripts/run-mangleme-tests:
766         * Scripts/run-minibrowser:
767         * Scripts/run-pageloadtest:
768         * Scripts/run-regexp-tests:
769         * Scripts/run-safari:
770         * Scripts/run-sunspider:
771         * Scripts/run-webkit-app:
772         * Scripts/sampstat:
773         * Scripts/set-webkit-configuration:
774         * Scripts/sort-Xcode-project-file:
775         * Scripts/sort-export-file:
776         * Scripts/split-file-by-class:
777         * Scripts/sunspider-compare-results:
778         * Scripts/svn-apply:
779         * Scripts/svn-create-patch:
780         * Scripts/svn-unapply:
781         * Scripts/test-webkit-scripts:
782         * Scripts/update-javascriptcore-test-results:
783         * Scripts/update-webkit:
784         * Scripts/update-webkit-auxiliary-libs:
785         * Scripts/update-webkit-dependency:
786         * Scripts/update-webkit-localizable-strings:
787         * Scripts/update-webkit-support-libs:
788         * Scripts/update-webkit-wincairo-libs:
789         * Scripts/webkit-build-directory:
790         * Scripts/webkitdirs.pm:
791         (installedSafariPath):
792         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
793         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
794         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
795         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
796         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
797         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
798         * Scripts/webkitperl/features.pm:
799         * Scripts/webkitperl/httpd.pm:
800         * Scripts/webkitpy/bindings/main.py:
801         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
802         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
803         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
804         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
805         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
806         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
807         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
808         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
809         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
810         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
811         * WebKitTestRunner/PixelDumpSupport.cpp:
812         * WebKitTestRunner/PixelDumpSupport.h:
813         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
814         * WinLauncher/WinLauncher.cpp:
815         * WinLauncher/WinLauncher.h:
816         * WinLauncher/stdafx.cpp:
817         * WinLauncher/stdafx.h:
818
819 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
820
821         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
822         https://bugs.webkit.org/show_bug.cgi?id=130265
823
824         Reviewed by Michael Saboff.
825
826         * Scripts/build-webkit:
827         * Scripts/copy-webkitlibraries-to-product-directory:
828
829 2014-03-14  Landry Breuil  <landry@openbsd.org>
830
831         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
832         Also allow to set MAKE in the environment.
833         https://bugs.webkit.org/show_bug.cgi?id=129991
834
835         Reviewed by Andreas Kling.
836
837         * Scripts/webkitdirs.pm:
838         (determineArchitecture):
839         (determineNumberOfCPUs):
840         (isBSD):
841         (buildAutotoolsProject):
842         * Scripts/webkitpy/common/system/platforminfo.py:
843         (PlatformInfo.__init__):
844         (PlatformInfo.is_openbsd):
845         (PlatformInfo):
846         (PlatformInfo.is_netbsd):
847         (PlatformInfo._determine_os_name):
848
849 2014-03-14  Dean Jackson  <dino@apple.com>
850
851         Remove libWebKitSystemInterfaceLion.a
852         https://bugs.webkit.org/show_bug.cgi?id=130254
853
854         Reviewed by Geoffrey Garen and Andreas Kling.
855
856         No need to copy the Lion libraries into the build.
857
858         * Scripts/copy-webkitlibraries-to-product-directory:
859
860 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
861
862         [EFL][MiniBrowser] Revise help messages of command line parameters
863         https://bugs.webkit.org/show_bug.cgi?id=130222
864
865         Reviewed by Csaba Osztrogonác.
866
867         Correct the default value description and make help messages to be consistent.
868
869         * MiniBrowser/efl/main.c:
870
871 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
872
873         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
874         https://bugs.webkit.org/show_bug.cgi?id=129612
875
876         Reviewed by Darin Adler.
877
878         For new code use static NeverDestroyed<T> instead.
879
880         * DumpRenderTree/JavaScriptThreading.cpp:
881         (javaScriptThreadsMutex):
882         (javaScriptThreads):
883         * DumpRenderTree/efl/EventSender.cpp:
884         (touchPointList):
885         (delayedEventQueue):
886         * DumpRenderTree/win/FrameLoadDelegate.cpp:
887         (delegatesWithDelayedWork):
888         * Scripts/check-for-exit-time-destructors:
889         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
890         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
891         (testsMap):
892
893 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
894
895         [EFL][WK2] Fix compilation warning in Minibrowser
896         https://bugs.webkit.org/show_bug.cgi?id=130132
897
898         Reviewed by Csaba Osztrogonác.
899
900         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
901
902         * MiniBrowser/efl/main.c:
903         (on_download_request):
904
905 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
906
907         FTL should support IsBlah
908         https://bugs.webkit.org/show_bug.cgi?id=130202
909
910         Reviewed by Geoffrey Garen.
911         
912         Running existing JSRegress tests with noInline gives us coverage for these
913         changes. Chances are, this will also give coverage for other interesting things
914         as well.
915
916         * Scripts/run-jsc-stress-tests:
917
918 2014-03-12  Brian Burg  <bburg@apple.com>
919
920         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
921         https://bugs.webkit.org/show_bug.cgi?id=129744
922
923         Reviewed by Timothy Hatcher.
924
925         * DumpRenderTree/TestRunner.cpp:
926         (evaluateInWebInspectorCallback):
927         * DumpRenderTree/TestRunner.h:
928         * DumpRenderTree/efl/TestRunnerEfl.cpp:
929         (TestRunner::evaluateInWebInspector):
930         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
931         (TestRunner::evaluateInWebInspector):
932         * DumpRenderTree/mac/TestRunnerMac.mm:
933         (TestRunner::evaluateInWebInspector):
934         * DumpRenderTree/win/TestRunnerWin.cpp:
935         (TestRunner::evaluateInWebInspector):
936         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
937         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
938         (WTR::TestRunner::evaluateInWebInspector):
939         * WebKitTestRunner/InjectedBundle/TestRunner.h:
940
941 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
942
943         [GTK] build-webkit shouldn't show error message when ninja isn't installed
944         https://bugs.webkit.org/show_bug.cgi?id=130129
945
946         Reviewed by Csaba Osztrogonác.
947
948         * Scripts/webkitdirs.pm:
949         (canUseNinja): Redirecting stderr to /dev/null
950
951 2014-03-13  Andres Gomez  <agomez@igalia.com>
952
953         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
954         https://bugs.webkit.org/show_bug.cgi?id=130092
955
956         Reviewed by Csaba Osztrogonác.
957
958         Added "python-dev" as dependency for deb based distros. It is
959         already present for rpm based distros. This dependency will allow
960         libxml2 to generate its python bindings, needed by gtk-doc.
961
962         * gtk/install-dependencies:
963
964 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
965
966         Unreviewed. Fix GTK+ cmake build after r165488.
967
968         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
969
970 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
971
972         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
973         https://bugs.webkit.org/show_bug.cgi?id=130014
974
975         Reviewed by Martin Robinson.
976
977         Include cmake or autotools config header.
978
979         * MiniBrowser/gtk/BrowserDownloadsBar.c:
980         * MiniBrowser/gtk/BrowserSearchBar.c:
981         * MiniBrowser/gtk/BrowserWindow.c:
982         * MiniBrowser/gtk/main.c:
983
984 2014-03-12  Commit Queue  <commit-queue@webkit.org>
985
986         Unreviewed, rolling out r165471.
987         https://bugs.webkit.org/show_bug.cgi?id=130139
988
989         Didn't really fix the issue and broke another bot (Requested
990         by mrobinson on #webkit).
991
992         Reverted changeset:
993
994         "[CMake] Newer versions of CMake cannot find older versions of
995         Freetype"
996         https://bugs.webkit.org/show_bug.cgi?id=130107
997         http://trac.webkit.org/changeset/165471
998
999 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1000
1001         It should be possible to build WebKit with FTL on iOS
1002         https://bugs.webkit.org/show_bug.cgi?id=130116
1003
1004         Reviewed by Dan Bernstein.
1005
1006         * Scripts/build-webkit:
1007         * Scripts/copy-webkitlibraries-to-product-directory:
1008
1009 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1010
1011         [Win] Remove use of QTSDK
1012         https://bugs.webkit.org/show_bug.cgi?id=130049
1013
1014         Reviewed by Darin Adler.
1015
1016         * DumpRenderTree/win/DumpRenderTree.cpp:
1017         (initialize): Remove QuickTime code.
1018         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1019         building QTMovieWin.
1020
1021 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1022
1023         [GTK][CMAKE] Too verbose build output
1024         https://bugs.webkit.org/show_bug.cgi?id=130076
1025
1026         Reviewed by Carlos Garcia Campos.
1027
1028         Instead of building with cmake --build which isn't smart about pretty printing and
1029         colors, we build with a script which calls the proper build command.
1030
1031         * Scripts/webkitdirs.pm:
1032         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1033         the CMake configuration pass.
1034
1035 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1036
1037         [CMake] Newer versions of CMake cannot find older versions of Freetype
1038         https://bugs.webkit.org/show_bug.cgi?id=130107
1039
1040         Reviewed by Gustavo Noronha Silva.
1041
1042         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1043         to CMake during jhbuild initialization.
1044
1045 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1046
1047         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1048         https://bugs.webkit.org/show_bug.cgi?id=129961
1049
1050         Reviewed by Simon Fraser.
1051
1052         Now scaled content can go through the window capturing mechanism too for compositing content.
1053         AppleMagnifiedMode is redundant.
1054
1055         * DumpRenderTree/mac/DumpRenderTree.mm:
1056         (setDefaultsToConsistentValuesForTesting):
1057         (runTest):
1058         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1059         (createBitmapContextFromWebView):
1060         * WebKitTestRunner/PlatformWebView.h:
1061         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1062         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1063         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1064         (WTR::PlatformWebView::didInitializeClients):
1065         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1066         (WTR::PlatformWebView::forceWindowFramesChanged):
1067         * WebKitTestRunner/mac/main.mm:
1068         (setDefaultsToConsistentValuesForTesting):
1069
1070 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1071
1072         Unreviewed. Add myself as a committer.
1073
1074         * Scripts/webkitpy/common/config/contributors.json:
1075
1076 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1077
1078         Unreviewed build fix on the EFL port when used lower version of ATK
1079
1080         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1081         (WTR::AccessibilityUIElement::y): Fixed typo.
1082
1083 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1084
1085         Some images are blank in the rebaseline server UI
1086         https://bugs.webkit.org/show_bug.cgi?id=130104
1087
1088         Reviewed by Tim Horton.
1089
1090         Let the server check for images in the 'retries' directory
1091         if it can't find an image otherwise.
1092
1093         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1094         (RebaselineHTTPRequestHandler.test_result):
1095
1096 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1097
1098         [GTK][CMake] --update-gtk has no effect
1099         https://bugs.webkit.org/show_bug.cgi?id=130088
1100
1101         Reviewed by Philippe Normand.
1102
1103         * Scripts/webkitdirs.pm:
1104         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1105         as an argument.
1106
1107 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1108
1109         Add "System Font" to the list of whitelisted DRT fonts
1110         https://bugs.webkit.org/show_bug.cgi?id=130046
1111
1112         Reviewed by Darin Adler.
1113
1114         * DumpRenderTree/mac/DumpRenderTree.mm:
1115         (allowedFontFamilySet):
1116         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1117
1118 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1119
1120         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1121         https://bugs.webkit.org/show_bug.cgi?id=130064
1122
1123         Reviewed by Philippe Normand.
1124
1125         * efl/jhbuildrc: Remove duplicated code.
1126         * gtk/jhbuildrc: Remove duplicated code.
1127         * jhbuild/jhbuildrc_common.py:
1128         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1129         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1130         and is apparently necessary for GTK+.
1131
1132 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1133
1134         check-webkit-style failed to complain about missing braces
1135         https://bugs.webkit.org/show_bug.cgi?id=34189
1136
1137         Reviewed by Ryosuke Niwa.
1138
1139         * Scripts/webkitpy/style/checkers/cpp.py:
1140         (check_braces):
1141         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1142         (WebKitStyleTest.test_braces):
1143
1144 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1145
1146         Remove Qt cruft from style checker.
1147         https://bugs.webkit.org/show_bug.cgi?id=130085
1148
1149         Reviewed by Csaba Osztrogonác.
1150
1151         There is no 'foreach' keyword in c++. That was a Qt feature
1152         added in: http://trac.webkit.org/changeset/46113
1153         Qt was removed from WebKit, so we should remove the checks
1154         of this keyword from check-webkit-style scripts.
1155
1156         * Scripts/webkitpy/style/checkers/cpp.py:
1157         (check_spacing_for_function_call):
1158         (check_spacing):
1159         (check_braces):
1160         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1161         (CppStyleTest.test_mismatching_spaces_in_parens):
1162         (CppStyleTest.test_spacing_for_fncall):
1163         (WebKitStyleTest.test_braces):
1164
1165 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1166
1167         [GTK] update-webkitgtk-libs needs itstool
1168         https://bugs.webkit.org/show_bug.cgi?id=130082
1169
1170         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1171         itstool is a dependency of building gtk-doc from version 1.19, so it should
1172         be added to Tools/gtk/install-dependencies script, too.
1173
1174         Reviewed by Philippe Normand.
1175
1176         * gtk/install-dependencies:
1177
1178 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1179
1180         webkitbot rollout ChangeLogs should be nicer
1181         https://bugs.webkit.org/show_bug.cgi?id=122654
1182
1183         Reviewed by Csaba Osztrogonác.
1184
1185         Added bug urls and descriptions of rolled out patches to the rollout changelog
1186         if they are present in the original changelog. Additionally removed the list of
1187         changed files and functions.
1188
1189         * Scripts/webkitpy/common/checkout/changelog.py:
1190         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1191         * Scripts/webkitpy/common/checkout/checkout.py:
1192         (Checkout._changelog_data_for_revision): Store bug description.
1193         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1194         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1195         (CheckoutTest.test_commit_info_for_revision):
1196         * Scripts/webkitpy/common/checkout/commitinfo.py:
1197         (CommitInfo.bug_description): Added.
1198         (CommitInfo.to_json):
1199         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1200         (CommitInfoTest.test_commit_info_creation):
1201         * Scripts/webkitpy/tool/commands/download.py:
1202         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1203         out patches for creating rollout changelog.
1204         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1205         caused the regression is stored in state["bug_blocked"] now.
1206         * Scripts/webkitpy/tool/commands/download_unittest.py:
1207         (test_prepare_rollout):
1208         (test_create_rollout_multiple_revision):
1209         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1210         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1211         rolled out patches to the changelog.
1212         (PrepareChangeLogForRevert.run):
1213         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1214         (UpdateChangeLogsForRevertTest):
1215         (test_message_for_revert):
1216         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1217         (ReopenBugAfterRollout.run):
1218
1219 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1220
1221         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1222         https://bugs.webkit.org/show_bug.cgi?id=130021
1223
1224         Reviewed by Mario Sanchez Prada.
1225
1226         Replace deprecated functions to use new API from ATK 2.11.90.
1227
1228         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1229         (AccessibilityUIElement::x):
1230         (AccessibilityUIElement::y):
1231         (AccessibilityUIElement::width):
1232         (AccessibilityUIElement::height):
1233         (AccessibilityUIElement::clickPointX):
1234         (AccessibilityUIElement::clickPointY):
1235         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1236         (WTR::AccessibilityUIElement::x):
1237         (WTR::AccessibilityUIElement::y):
1238         (WTR::AccessibilityUIElement::width):
1239         (WTR::AccessibilityUIElement::height):
1240         (WTR::AccessibilityUIElement::clickPointX):
1241         (WTR::AccessibilityUIElement::clickPointY):
1242
1243 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1244
1245         [ATK] Expose aria-posinset and aria-setsize through object attributes
1246         https://bugs.webkit.org/show_bug.cgi?id=130011
1247
1248         Reviewed by Chris Fleizach.
1249
1250         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1251
1252         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1253         (AccessibilityUIElement::numberAttributeValue):
1254         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1255         (WTR::AccessibilityUIElement::numberAttributeValue):
1256
1257 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1258
1259         [Win] Unreviewed build fix.
1260
1261         Some bad Windows code was committed at some point that prevents the Apple Windows port
1262         from finding its runtime dependencies reliably.
1263
1264         * win/DLLLauncher/DLLLauncherMain.cpp:
1265         (appleApplicationSupportDirectory): Restored this function.
1266         (modifyPath): Update to use appleApplicationSupportDirectory function.
1267
1268 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1269
1270         Let the user define the full address of the performance-site-server for uploading results
1271         https://bugs.webkit.org/show_bug.cgi?id=129819
1272
1273         Reviewed by Ryosuke Niwa.
1274
1275         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1276         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1277         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1278         protocol for now, in order to avoid breaking the perf bots.
1279
1280         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1281         (_upload_json):
1282         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1283         (MainTest.test_upload_json):
1284
1285 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1286
1287         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1288         https://bugs.webkit.org/show_bug.cgi?id=130023
1289
1290         Reviewed by Dean Jackson.
1291
1292         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1293         /SAFESEH flag to DLL launcher process.
1294
1295 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1296
1297         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1298         https://bugs.webkit.org/show_bug.cgi?id=129980
1299
1300         Reviewed by Carlos Garcia Campos.
1301
1302         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1303
1304 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1305
1306         [GTK] Remove the WebView source-mode WebKit1 test
1307         https://bugs.webkit.org/show_bug.cgi?id=129976
1308
1309         Reviewed by Carlos Garcia Campos.
1310
1311         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1312
1313 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1314
1315         Unreviewed build fix for GTKbuild after the switch to CMake
1316
1317         * gtk/common.py:
1318         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1319         test-only bot doesn't have any build files.
1320
1321 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1322
1323         [GTK] built-product-archive does not handle GTK+ CMake build
1324         https://bugs.webkit.org/show_bug.cgi?id=129941
1325
1326         * BuildSlaveSupport/built-product-archive:
1327         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1328         the CMake build.
1329
1330 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1331
1332         [GTK] Include CMake into install-dependencies script
1333         https://bugs.webkit.org/show_bug.cgi?id=129909
1334
1335         Reviewed by Martin Robinson.
1336
1337         As since r165267 buid-webkit uses CMake by default, the dependency
1338         with 'cmake' package should be introduced.
1339
1340         * gtk/install-dependencies: Ditto.
1341
1342 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1343
1344         REGRESSION(165267): Broke a webkitpy unit tests
1345         https://bugs.webkit.org/show_bug.cgi?id=129904
1346
1347         Reviewed by Jon Honeycutt.
1348
1349         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1350         (GtkPort._is_cmake_build):
1351
1352 2014-03-07  Andres Gomez  <agomez@igalia.com>
1353
1354         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1355         https://bugs.webkit.org/show_bug.cgi?id=129893
1356
1357         Reviewed by Martin Robinson.
1358
1359         Added "git-svn" as dependency for deb based distros and,
1360         additionally, "subversion" for rpm based distros.
1361
1362         * gtk/install-dependencies:
1363
1364 2014-03-07  Roger Fong  <roger_fong@apple.com>
1365
1366         Remove dummy setSystemWebGLLoadPolicy client method.
1367         https://bugs.webkit.org/show_bug.cgi?id=129873.
1368
1369         Reviewed by Dean Jackson.
1370
1371         * WebKitTestRunner/TestController.cpp:
1372         (WTR::TestController::createWebViewWithOptions):
1373
1374 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1375
1376         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1377         https://bugs.webkit.org/show_bug.cgi?id=129886
1378
1379         Reviewed by Mark Lam.
1380
1381         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1382         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1383         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1384         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1385         make it through when in non-verbose mode.
1386
1387 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1388
1389         [GTK] buid-webkit should use CMake by default
1390         https://bugs.webkit.org/show_bug.cgi?id=129855
1391
1392         Reviewed by Carlos Garcia Campos.
1393
1394         Make the CMake build the default GTK+ build when using build-webkit. This will
1395         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1396         so that we have --gtk and --gtkautotools.
1397
1398         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1399         * Scripts/webkitpy/port/gtk.py: Ditto.
1400
1401 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1402
1403         [CMake] [GTK] Build with ninja when it is available
1404         https://bugs.webkit.org/show_bug.cgi?id=129805
1405
1406         Reviewed by Philippe Normand.
1407
1408         * Scripts/webkitdirs.pm:
1409         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1410         if it's available on the system.
1411         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1412         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1413
1414 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1415
1416         If the FTL is build-time enabled then it should be run-time enabled.
1417
1418         Rubber stamped by Geoffrey Garen.
1419
1420         * Scripts/run-jsc-stress-tests:
1421
1422 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1423
1424         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1425         https://bugs.webkit.org/show_bug.cgi?id=129837
1426
1427         Reviewed by Michael Saboff.
1428
1429         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1430         The fix is to use find instead of ls like we do in shell-runner.sh.
1431
1432         * Scripts/run-jsc-stress-tests:
1433
1434 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1435
1436         filter-build-webkit should not strip .o
1437         https://bugs.webkit.org/show_bug.cgi?id=129614
1438
1439         Reviewed by Dean Jackson.
1440
1441         This makes it much easier to jump from the failing output at
1442         the end back up to the compile errors earlier in the output.
1443
1444         * Scripts/filter-build-webkit:
1445
1446 2014-03-06  Anders Carlsson  <andersca@apple.com>
1447
1448         Build WebKit2 before building WebKit
1449         https://bugs.webkit.org/show_bug.cgi?id=129831
1450         <rdar://problem/15920020>
1451
1452         Reviewed by Dan Bernstein.
1453
1454         * Scripts/build-webkit:
1455         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1456
1457 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1458
1459         make-3.82 fails to build on ARM/Linux
1460         https://bugs.webkit.org/show_bug.cgi?id=107926
1461
1462         Reviewed by Martin Robinson.
1463
1464         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1465         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1466         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1467         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1468
1469         * gtk/patches/make-3.82-arg-list-length.patch:
1470
1471 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         [GTK] Close the page when the view is disposed instead of when finalized
1474         https://bugs.webkit.org/show_bug.cgi?id=129783
1475
1476         Reviewed by Sergio Villar Senin.
1477
1478         Add test case but disabled for now because it's affetected by bug #129684.
1479
1480         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1481         (testProcessPerWebView):
1482
1483 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1484
1485         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1486         https://bugs.webkit.org/show_bug.cgi?id=129738
1487
1488         Reviewed by Sergio Villar Senin.
1489
1490         The problem is that we are calling g_object_unref() for the
1491         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1492         view only increases the reference counter when the settings is not
1493         the same it currently has. We should release our reference once.
1494
1495         * MiniBrowser/gtk/main.c:
1496         (createBrowserWindow):
1497         (main):
1498
1499 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1500
1501         [GTK][CMake] Tarball is created with wrong tarball paths
1502         https://bugs.webkit.org/show_bug.cgi?id=129496
1503
1504         Reviewed by Daniel Bates.
1505
1506         * gtk/make-dist.py:
1507         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1508         landing the original patch with some suggestions from the reviewer. With the
1509         checks corrected, the tarball path is constructed properly.
1510
1511 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1512
1513         Unreviewed. Update my email in contributors.json
1514
1515         * Scripts/webkitpy/common/config/contributors.json:
1516
1517 2014-03-05  Dean Jackson  <dino@apple.com>
1518
1519         [WebGL] Use WKSI to see what the system policy for WebGL is
1520         https://bugs.webkit.org/show_bug.cgi?id=129722
1521         <rdar://problem/15790542>
1522
1523         Reviewed by Tim Horton.
1524
1525         Dummy entry for setSystemWebGLLoadPolicy.
1526
1527         * WebKitTestRunner/TestController.cpp:
1528         (WTR::TestController::createWebViewWithOptions):
1529
1530 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1531
1532         [GTK][CMake] Generate documentation for the DOM bindings
1533         https://bugs.webkit.org/show_bug.cgi?id=126211
1534
1535         Reviewed by Carlos Garcia Campos.
1536
1537         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1538         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1539         * gtk/generate-webkitdom-doc-files: Removed.
1540         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1541         that it can be called by generate-gtkdoc.
1542
1543 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1544
1545         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1546         https://bugs.webkit.org/show_bug.cgi?id=129380
1547
1548         Reviewed by Philippe Normand.
1549
1550         * Scripts/webkitdirs.pm:
1551         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1552         skipping CMake execution.
1553
1554 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1555
1556         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1557         https://bugs.webkit.org/show_bug.cgi?id=129651
1558
1559         Reviewed by Philippe Normand.
1560
1561         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1562
1563 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1564
1565         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1566         https://bugs.webkit.org/show_bug.cgi?id=129637
1567
1568         Reviewed by Carlos Garcia Campos.
1569
1570         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1571         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1572         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1573         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1574         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1575         (TestFactory.__init__): Add the test for GTK+.
1576         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1577
1578 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1579
1580         [ATK] Expose missing functionalities of AtkTableCell to AT
1581         https://bugs.webkit.org/show_bug.cgi?id=129492
1582
1583         Reviewed by Mario Sanchez Prada.
1584
1585         Reducing some code by using new API of AtkTableCell.
1586
1587         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1588         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1589
1590 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1591
1592         Preparing to run layout tests on Wincairo.
1593         https://bugs.webkit.org/show_bug.cgi?id=129709
1594
1595         Reviewed by Brent Fulgham.
1596
1597         * Scripts/webkitdirs.pm:
1598         (setPathForRunningWebKitApp):
1599         Add GStreamer directory for WinCairo running layout tests.
1600         * win/DLLLauncher/DLLLauncherMain.cpp:
1601         (modifyPath):
1602         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1603
1604 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1605
1606         [GTK] Simplify the GObject DOM bindings API break check into one step
1607         https://bugs.webkit.org/show_bug.cgi?id=129571
1608
1609         Reviewed by Carlos Garcia Campos.
1610
1611         * GNUmakefile.am: Add the API break check to 'make check.'
1612         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1613         * gtk/check-gdom-symbols: Removed.
1614         * gtk/webkitdom.py: Added.
1615         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1616         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1617
1618 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1619
1620         Add Jeremy Jones to the contributors list as a contributor.
1621
1622         * Scripts/webkitpy/common/config/contributors.json:
1623
1624 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1625
1626         Unreviewed. Update contact email.
1627         https://bugs.webkit.org/show_bug.cgi?id=129610
1628
1629         * Scripts/webkitpy/common/config/contributors.json:
1630
1631 2014-03-02  Brian Burg  <bburg@apple.com>
1632
1633         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1634         https://bugs.webkit.org/show_bug.cgi?id=129460
1635
1636         Reviewed by Dan Bernstein.
1637
1638         Don't unconditionally open the inspector before running an inspector test.
1639         Instead, the test should request that the inspector open when it's ready.
1640
1641         This change was lost during a rebase, but is the same change made to
1642         DumpRenderTree.
1643
1644         * WebKitTestRunner/TestInvocation.cpp:
1645         (WTR::TestInvocation::invoke): 
1646
1647 2014-03-02  Darin Adler  <darin@apple.com>
1648
1649         Split TextIteratorBehavior into a separate header
1650         https://bugs.webkit.org/show_bug.cgi?id=129578
1651
1652         Reviewed by Sam Weinig.
1653
1654         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1655         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1656         task easy, but the remove is still a bit of a pain.
1657
1658 2014-03-02  Darin Adler  <darin@apple.com>
1659
1660         Sort Mac platform export files so they merge better
1661         https://bugs.webkit.org/show_bug.cgi?id=129581
1662
1663         Reviewed by Sam Weinig.
1664
1665         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1666         Mac export files in a "canonical" order for this project.
1667
1668 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1669
1670         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1671         https://bugs.webkit.org/show_bug.cgi?id=129438
1672
1673         Reviewed by Simon Fraser.
1674
1675         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1676         offscreen window. It makes testing subpixel rendering and positioning possible.
1677
1678         Both the offscreen window's and WebKit's scaling are set accordingly.
1679
1680         * DumpRenderTree/mac/DumpRenderTree.mm:
1681         (createWebViewAndOffscreenWindow): cleanup
1682         (destroyWebViewAndOffscreenWindow): cleanup
1683         (dumpRenderTree):
1684         (changeWindowScaleIfNeeded):
1685         (runTest):
1686         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1687         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1688         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1689         * WebKitTestRunner/PlatformWebView.h:
1690         * WebKitTestRunner/TestInvocation.cpp:
1691         (WTR::changeWindowScaleIfNeeded):
1692         (WTR::TestInvocation::invoke):
1693         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1694         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1695         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1696         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1697         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1698         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1699         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1700         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1701
1702 2014-02-28  Anders Carlsson  <andersca@apple.com>
1703
1704         Remove logging.
1705
1706         Reviewed by Dan Bernstein.
1707
1708         * MiniBrowser/mac/WK2BrowserWindowController.m:
1709         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1710
1711 2014-02-28  Daniel Bates  <dabates@apple.com>
1712
1713         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1714         https://bugs.webkit.org/show_bug.cgi?id=129163
1715
1716         Reviewed by David Kilzer.
1717
1718         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1719         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1720         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1721         bundle.
1722
1723         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1724         which is specified either explicitly when building with MAKE(1) or implicitly by
1725         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1726         the OS X SDK and toolchain since the built products are only applicable to OS X.
1727
1728         * DumpRenderTree/ios/PerlSupport/Makefile:
1729
1730 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1731
1732         Unreviewed, rolling out r164859.
1733         http://trac.webkit.org/changeset/164859
1734         https://bugs.webkit.org/show_bug.cgi?id=129483
1735
1736         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1737         #webkit).
1738
1739         * DumpRenderTree/mac/DumpRenderTree.mm:
1740         (createWebViewAndOffscreenWindow):
1741         (dumpRenderTree):
1742         (runTest):
1743         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1744         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1745         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1746         * WebKitTestRunner/PlatformWebView.h:
1747         * WebKitTestRunner/TestInvocation.cpp:
1748         (WTR::TestInvocation::invoke):
1749         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1750         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1751         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1752         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1753         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1754
1755 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1756
1757         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1758         https://bugs.webkit.org/show_bug.cgi?id=129438
1759
1760         Reviewed by Simon Fraser.
1761
1762         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1763         offscreen window. It makes testing subpixel rendering and positioning possible.
1764
1765         Both the offscreen window's and WebKit's scaling are set accordingly.
1766
1767         * DumpRenderTree/mac/DumpRenderTree.mm:
1768         (createWebViewAndOffscreenWindow): unrelated cleanup.
1769         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1770         (dumpRenderTree):
1771         (changeOffscreenWindowScaleIfNeeded):
1772         (runTest):
1773         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1774         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1775         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1776         * WebKitTestRunner/PlatformWebView.h:
1777         * WebKitTestRunner/TestInvocation.cpp:
1778         (WTR::changeOffscreenWindowScaleIfNeeded):
1779         (WTR::TestInvocation::invoke):
1780         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1781         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1782
1783 2014-02-27  Brian Burg  <bburg@apple.com>
1784
1785         Web Inspector: model tests should use a special Test.html inspector page
1786         https://bugs.webkit.org/show_bug.cgi?id=129190
1787
1788         Reviewed by Timothy Hatcher.
1789
1790         Remove code that immediately opens the Web Inspector based on the file path of the test.
1791         Instead, the test page should request that the inspector open inside its `test()` method.
1792
1793         This change is necessary because otherwise, the inspector would be opened too early for
1794         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1795         will get loaded instead of the minimal test page.
1796
1797         * DumpRenderTree/efl/DumpRenderTree.cpp:
1798         (createTestRunner):
1799         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1800         (runTest):
1801         * DumpRenderTree/mac/DumpRenderTree.mm:
1802         (runTest):
1803         * DumpRenderTree/win/DumpRenderTree.cpp:
1804         (runTest):
1805
1806 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1807
1808         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1809         https://bugs.webkit.org/show_bug.cgi?id=127076
1810
1811         Reviewed by Anders Carlsson.
1812
1813         Avoid match for :: as start of a member initialization list. Modify expression to match
1814         after a colon either non-colon character or end of line.
1815
1816         * Scripts/webkitpy/style/checkers/cpp.py:
1817         (check_member_initialization_list):
1818         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1819         (WebKitStyleTest.test_member_initialization_list):
1820
1821 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1822
1823         Unreviewed. Update my email addresses in contributors.json.
1824
1825         * Scripts/webkitpy/common/config/contributors.json:
1826
1827 2014-02-27  Alberto Garcia  <berto@igalia.com>
1828
1829         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1830         https://bugs.webkit.org/show_bug.cgi?id=128927
1831
1832         Reviewed by Philippe Normand.
1833
1834         Encode manually the data for sys.{stdout,stderr}.write.
1835
1836         * gtk/gtkdoc.py:
1837         (GTKDoc._run_command):
1838
1839 2014-02-27  Andres Gomez  <agomez@igalia.com>
1840
1841         Unreviewed. Add myself to watchlists
1842
1843         * Scripts/webkitpy/common/config/watchlist: Add myself to
1844         watchlists.
1845
1846 2014-02-27  Andres Gomez  <agomez@igalia.com>
1847
1848         Unreviewed, rolling out r164790.
1849         http://trac.webkit.org/changeset/164790
1850
1851         Revert r164790 because of erroneous commit log
1852
1853         * Scripts/webkitpy/common/config/watchlist:
1854
1855 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1856
1857         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1858         https://bugs.webkit.org/show_bug.cgi?id=129250
1859
1860         Reviewed by Mario Sanchez Prada.
1861
1862         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1863         Implementing methods so that we could test column/row headers represented as an array of cells.
1864
1865         * DumpRenderTree/AccessibilityUIElement.cpp:
1866         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1867         (AccessibilityUIElement::columnHeaders):
1868         (AccessibilityUIElement::rowHeaders):
1869         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1870         (AccessibilityUIElement::columnHeaders):
1871         (AccessibilityUIElement::rowHeaders):
1872         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1873         (WTR::AccessibilityUIElement::rowHeaders):
1874         (WTR::AccessibilityUIElement::columnHeaders):
1875         * efl/jhbuild.modules:
1876         * gtk/jhbuild.modules:
1877
1878 2014-02-27  Andres Gomez  <agomez@igalia.com>
1879
1880         Unreviewed. Add myself to watchlists
1881
1882         * Scripts/webkitpy/common/config/watchlist: Add myself to
1883         watchlists.
1884
1885 2014-02-27  Andres Gomez  <agomez@igalia.com>
1886
1887         Unreviewed. Add myself as a committer.
1888
1889         * Scripts/webkitpy/common/config/contributors.json:
1890
1891 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1892
1893         Unreviewed. Add Víctor Jáquez and myself to watchlists
1894
1895         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1896         myself to watchlists.
1897
1898 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1899
1900         Unreviewed. Add myself as a committer.
1901
1902         * Scripts/webkitpy/common/config/contributors.json:
1903
1904 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1905
1906         Unreviewed. Moved myself to the list of committers.
1907
1908         * Scripts/webkitpy/common/config/contributors.json:
1909
1910 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1911
1912         [GTK] Reduplicate common.top_level_path in scripts
1913         https://bugs.webkit.org/show_bug.cgi?id=129291
1914
1915         Reviewed by Philippe Normand.
1916
1917         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1918         path manipulation and weird dependencies on the jhbuild infrastructure.
1919
1920         * Scripts/run-gtk-tests: Use common again.
1921         (TestRunner._setup_testing_environment): Ditto.
1922         * gtk/check-gdom-symbols: Ditto.
1923         * gtk/common.py:
1924         (top_level_path): Re-add top_level_path..
1925         (get_build_path): Use the builtin top_level_path again.
1926         * gtk/find-make-dist-errors: Use common again.
1927         (get_missing_headers): Ditto.
1928         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1929
1930 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1931
1932         runscript: line 42: /bin/ls: Argument list too long
1933         https://bugs.webkit.org/show_bug.cgi?id=129376
1934
1935         Reviewed by Michael Saboff.
1936
1937         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1938         We should use find instead, which generates the list of files rather than expanding them all on 
1939         the command line and spitting them back out.
1940
1941         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1942
1943 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1944
1945         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1946         https://bugs.webkit.org/show_bug.cgi?id=129377
1947
1948         Reviewed by Csaba Osztrogonác.
1949
1950         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1951
1952 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1953
1954         [GTK] Re-enable gtk-doc in EWS
1955         https://bugs.webkit.org/show_bug.cgi?id=128369
1956
1957         Reviewed by Carlos Garcia Campos.
1958
1959         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1960
1961         * Scripts/webkitpy/common/config/ports.py:
1962         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1963         (GtkWK2Port.build_webkit_command): Ditto.
1964         * Scripts/webkitpy/common/config/ports_unittest.py:
1965         (DeprecatedPortTest.test_gtk_port): Ditto.
1966         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1967
1968 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1969
1970         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1971         https://bugs.webkit.org/show_bug.cgi?id=129319
1972
1973         Reviewed by Carlos Garcia Campos.
1974
1975         * gtk/generate-gtkdoc:
1976         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1977
1978 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1979
1980         Unreviewed. Add myself as a committer.
1981
1982         * Scripts/webkitpy/common/config/contributors.json:
1983
1984 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1985
1986         [CSS Grid Layout] Add ENABLE flag
1987         https://bugs.webkit.org/show_bug.cgi?id=129153
1988
1989         Reviewed by Simon Fraser.
1990
1991         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
1992         all ports for developer builds.
1993
1994         * Scripts/webkitperl/FeatureList.pm:
1995
1996 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1997
1998         Added myself as a committer.
1999
2000         Unreviewed.
2001
2002         * Scripts/webkitpy/common/config/contributors.json:
2003
2004 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2005
2006         Unreviewed. Moved myself to the list of committers.
2007
2008         * Scripts/webkitpy/common/config/contributors.json:
2009
2010 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2011
2012         Move myself to the committers list.
2013
2014         Unreviewed.
2015
2016         * Scripts/webkitpy/common/config/contributors.json:
2017
2018 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2019
2020         Unreviewed. Add myself as a committer.
2021
2022         * Scripts/webkitpy/common/config/contributors.json:
2023
2024 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2025
2026         Unreviewed, rolling out r164639.
2027         http://trac.webkit.org/changeset/164639
2028         https://bugs.webkit.org/show_bug.cgi?id=129302
2029
2030         gtk-doc still have problems in EWS (Requested by rego on
2031         #webkit).
2032
2033         * Scripts/webkitpy/common/config/ports.py:
2034         (GtkPort.build_webkit_command):
2035         (GtkWK2Port.build_webkit_command):
2036         * Scripts/webkitpy/common/config/ports_unittest.py:
2037         (DeprecatedPortTest.test_gtk_port):
2038         (DeprecatedPortTest.test_gtk_wk2_port):
2039
2040 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2041
2042         [GTK] Re-enable gtk-doc in EWS
2043         https://bugs.webkit.org/show_bug.cgi?id=128369
2044
2045         Reviewed by Carlos Garcia Campos.
2046
2047         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2048
2049         * Scripts/webkitpy/common/config/ports.py:
2050         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2051         (GtkWK2Port.build_webkit_command): Ditto.
2052         * Scripts/webkitpy/common/config/ports_unittest.py:
2053         (DeprecatedPortTest.test_gtk_port): Ditto.
2054         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2055
2056 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2057
2058         [GTK] Mark view source mode methods as deprecated
2059         https://bugs.webkit.org/show_bug.cgi?id=128920
2060
2061         Reviewed by Martin Robinson.
2062
2063         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2064         (beforeAll): Remove view mode test.
2065
2066 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2067
2068         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2069         https://bugs.webkit.org/show_bug.cgi?id=128417
2070
2071         Reviewed by Carlos Garcia Campos.
2072
2073         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2074         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2075         a makefile. This allows accepting a header list from the build system, which can be used
2076         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2077         have a corresponding header file on the header list. 
2078         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2079         source directories to gtkdoc-scan.
2080
2081 2014-02-24  Anders Carlsson  <andersca@apple.com>
2082
2083         Add a DefaultVisitedLinkProvider and route visited link actions through it
2084         https://bugs.webkit.org/show_bug.cgi?id=129285
2085
2086         Reviewed by Dan Bernstein.
2087
2088         * MiniBrowser/mac/AppDelegate.m:
2089         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2090         Set a shared history so we'll get visited link tracking.
2091
2092         * MiniBrowser/mac/WK1BrowserWindowController.m:
2093         (-[WK1BrowserWindowController awakeFromNib]):
2094         Set a group name.
2095
2096 2014-02-24  Dan Bernstein  <mitz@apple.com>
2097
2098         iOS build fix after r164577.
2099
2100         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2101         (AccessibilityUIElement::selectedChildrenCount):
2102         (AccessibilityUIElement::selectedChildAtIndex):
2103
2104 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2105
2106         [ASan] Remove methods from ignore list that no longer cause crashes
2107         <http://webkit.org/b/129257>
2108
2109         Reviewed by Anders Carlsson.
2110
2111         * asan/webkit-asan-ignore.txt: Remove old methods.
2112
2113 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2114
2115         Extract common parts from jhbuildrc files.
2116         https://bugs.webkit.org/show_bug.cgi?id=125986
2117
2118         Reviewed by Csaba Osztrogonác.
2119
2120         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2121
2122         * Scripts/run-gtk-tests:
2123         (TestRunner._setup_testing_environment):
2124         * efl/common.py: Removed.
2125         * efl/jhbuildrc:
2126         * gtk/check-gdom-symbols:
2127         * gtk/common.py:
2128         (binary_build_path):
2129         (get_build_path):
2130         * gtk/find-make-dist-errors:
2131         (get_missing_headers):
2132         * gtk/generate-gtkdoc:
2133         (get_webkit2_options):
2134         (get_webkit1_options.src_path):
2135         (get_webkit1_options):
2136         (get_webkitdom_options.src_path):
2137         (get_webkitdom_options):
2138         * gtk/generate-inspector-gresource-manifest.py:
2139         * gtk/jhbuildrc:
2140         * jhbuild/jhbuildrc_common.py: Added.
2141         (script_path):
2142         (top_level_path):
2143         (init):
2144
2145 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2146
2147         Unreviewed. Fix code indentation and spacing.
2148
2149         * Scripts/webkitpy/style/checkers/js.py:
2150         (SingleQuoteChecker.check):
2151
2152 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2153
2154         [ATK] Wrong selected element at a given index in a list box.
2155         https://bugs.webkit.org/show_bug.cgi?id=129039
2156
2157         Reviewed by Chris Fleizach.
2158
2159         Added missing implementation and proposed some new function for testing selection
2160         in a list boxes.
2161
2162         * DumpRenderTree/AccessibilityUIElement.cpp:
2163         (setSelectedChildAtIndexCallback):
2164         (removeSelectionAtIndexCallback):
2165         (AccessibilityUIElement::getJSClass):
2166         * DumpRenderTree/AccessibilityUIElement.h:
2167         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2168         (AccessibilityUIElement::selectedChildrenCount):
2169         (AccessibilityUIElement::selectedChildAtIndex):
2170         (AccessibilityUIElement::setSelectedChildAtIndex):
2171         (AccessibilityUIElement::removeSelectionAtIndex):
2172         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2173         (AccessibilityUIElement::selectedChildrenCount):
2174         (AccessibilityUIElement::selectedChildAtIndex):
2175         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2176         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2177         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2178         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2179         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2180         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2181         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2182         (WTR::AccessibilityUIElement::selectedChildrenCount):
2183         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2184         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2185
2186 2014-02-23  Diego Pino García  <dpino@igalia.com>
2187
2188         [GTK] Fix build after Web Inspector code reorganization (r164543)
2189         https://bugs.webkit.org/show_bug.cgi?id=129231
2190
2191         Reviewed by Dean Jackson.
2192
2193         * gtk/generate-inspector-gresource-manifest.py:
2194         Modify paths to Web Inspector code.
2195
2196 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2197
2198         [GTK] generate-gtkdoc should use argparse
2199         https://bugs.webkit.org/show_bug.cgi?id=128418
2200
2201         Reviewed by Carlos Garcia Campos.
2202
2203         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2204         to all functions, and guard the main routine with a __name__ == __main__ check.
2205
2206 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2207
2208         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2209         https://bugs.webkit.org/show_bug.cgi?id=129191
2210
2211         Reviewed by Anders Carlsson.
2212
2213         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2214         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2215         name of the directory is "lib" and not "libs". Instead we should use the CMake
2216         variable specifically assigned to this task.
2217
2218 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2219
2220         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2221         <http://webkit.org/b/129209>
2222
2223         Reviewed by Geoffrey Garen.
2224
2225         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2226         ignore list to make ASan builds usable again.  Follow-up
2227         investigation is tracked by <rdar://problem/16055903>.
2228
2229 2014-02-20  David Farler  <dfarler@apple.com>
2230
2231         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2232         https://bugs.webkit.org/show_bug.cgi?id=128622
2233
2234         Reviewed by Simon Fraser.
2235
2236         With this change, we now have layout tests running in both DumpRenderTree
2237         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2238         simulator.
2239
2240         * Scripts/old-run-webkit-tests:
2241         In general, make any specific reference to DumpRenderTree
2242         able to refer to WebKitTestRunner wherever possible:
2243         - Rename functions to remove DRT-specific naming.
2244         - Name FIFOs after the tool that is being used.
2245         -- Clean up FIFO creation code
2246         Other necessary changes:
2247         - Allow use of an ios-sim-wk2 platform.
2248         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2249         * WebKitTestRunner/TestController.cpp:
2250         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2251         (WTR::TestController::TestController):
2252         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2253         Copy the injected bundle into the app bundle.
2254
2255 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2256
2257         run-webkit-httpd fails to find httpd configuation file.
2258
2259         Reviewed by Ryosuke Niwa.
2260
2261         * Scripts/webkitperl/httpd.pm:
2262         (getHTTPDConfigPathForTestDirectory):
2263
2264 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2265
2266         Fix TimeRanges layering violations
2267         https://bugs.webkit.org/show_bug.cgi?id=128717
2268
2269         Reviewed by Jer Noble.
2270
2271         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2272         (TestWebKitAPI::TEST):
2273
2274 2014-02-21  Diego Pino García  <dpino@igalia.com>
2275
2276         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2277         https://bugs.webkit.org/show_bug.cgi?id=128422
2278
2279         Reviewed by Joseph Pecoraro.
2280
2281         * Scripts/webkitpy/style/checkers/js.py:
2282         (JSChecker.__init__):
2283         (JSChecker.check):
2284         (SingleQuoteChecker):
2285         (SingleQuoteChecker.__init__):
2286         (SingleQuoteChecker.check):
2287         * Scripts/webkitpy/style/checkers/js_unittest.py:
2288         (JSTestCase.assertError.error_for_test):
2289         (JSTestCase.assertError):
2290         (JSTestCase.test_no_error):
2291         (JSTestCase.test_error):
2292
2293 == Rolled over to ChangeLog-2014-02-20 ==