1 2014-06-17 Carlos Alberto Lopez Perez <clopez@igalia.com>
3 [GTK] Fix the handling of resize events after r169505.
4 https://bugs.webkit.org/show_bug.cgi?id=133517
6 Reviewed by Martin Robinson.
8 * Scripts/webkitpy/port/xvfbdriver.py:
9 (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
10 The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
11 need at least 900x640 pixels to pass.
12 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
13 (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
14 (XvfbDriverTest.test_start_pixel_tests): Update resolution.
15 (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
16 (XvfbDriverTest.test_start_next_worker): Update resolution.
17 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
18 (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
19 be requested over the main widget instead of the window.
20 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
22 (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
23 (WTR::PlatformWebView::setWindowFrame): Set the size and position
24 of the Window and the web view.
26 2014-06-17 Matthew Mirman <mmirman@apple.com>
28 Unreviewed. Added myself to list of contributors.
30 * Scripts/webkitpy/common/config/contributors.json: Added myself.
32 2014-06-17 Commit Queue <commit-queue@webkit.org>
34 Unreviewed, rolling out r170058.
35 https://bugs.webkit.org/show_bug.cgi?id=133993
37 Caused 4 webkitpy failures on the bots (Requested by bradee-oh
42 "[GTK] Fix the handling of resize events after r169505."
43 https://bugs.webkit.org/show_bug.cgi?id=133517
44 http://trac.webkit.org/changeset/170058
46 2014-06-17 Rebecca Hauck <rhauck@adobe.com>
48 Update import-w3c-tests to reflect current W3C test repo directory structure
49 https://bugs.webkit.org/show_bug.cgi?id=133460
51 Reviewed by Bem Jones-Bey.
53 Removed all references to test status, which are no longer reflected in the
54 directory names in the W3C CSS test repo. No tests are required for this
55 change, the existing tests pass.
57 * Scripts/webkitpy/w3c/test_importer.py:
59 (TestImporter.__init__):
60 (TestImporter.find_importable_tests):
61 (TestImporter.setup_destination_directory):
62 (TestImporter.write_import_log):
63 (TestImporter.update_test_status): Deleted.
65 2014-06-17 Carlos Alberto Lopez Perez <clopez@igalia.com>
67 [GTK] Fix the handling of resize events after r169505.
68 https://bugs.webkit.org/show_bug.cgi?id=133517
70 Reviewed by Martin Robinson.
72 * Scripts/webkitpy/port/xvfbdriver.py:
73 (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
74 The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
75 need at least 900x640 pixels to pass.
76 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
77 (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
78 be requested over the main widget instead of the window.
79 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
81 (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
82 (WTR::PlatformWebView::setWindowFrame): Set the size and position
83 of the Window and the web view.
85 2014-06-17 Dan Bernstein <mitz@apple.com>
87 String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
88 https://bugs.webkit.org/show_bug.cgi?id=133968
90 Reviewed by Anders Carlsson.
92 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
93 (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
94 share an impl() with the original.
96 2014-06-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
98 [EFL][WK2] Skip failing EFL API tests
99 https://bugs.webkit.org/show_bug.cgi?id=133981
101 Reviewed by Csaba Osztrogonác.
103 UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
105 * TestWebKitAPI/PlatformEfl.cmake:
107 2014-06-16 Ryuan Choi <ryuan.choi@samsung.com>
109 [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
110 https://bugs.webkit.org/show_bug.cgi?id=133962
112 Reviewed by Gyuyoung Kim.
114 Since we bumped EFL to 1.9, this workaround is unnecessary.
116 * MiniBrowser/efl/main.c:
117 (update_view_favicon):
119 2014-06-16 Gwang Yoon Hwang <yoon@igalia.com>
121 [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
122 https://bugs.webkit.org/show_bug.cgi?id=131472
124 Reviewed by Martin Robinson.
126 This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
128 * Scripts/webkitpy/port/xvfbdriver.py:
129 (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
130 when running WebKitTestRunner with the Xvfb driver.
131 * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
132 * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
134 * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
135 how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
136 calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
139 2014-06-16 Tanay C <tanay.c@samsung.com>
141 Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
142 https://bugs.webkit.org/show_bug.cgi?id=133792
144 Reviewed by Gyuyoung Kim.
146 * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
147 (show_file_entry_dialog):
150 2014-06-16 Mario Sanchez Prada <mario.prada@samsung.com>
152 [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
153 https://bugs.webkit.org/show_bug.cgi?id=133512
155 Reviewed by Chris Fleizach.
157 Added support for connecting to AtkSelection's 'selection-changed'
158 signal, and print it out as AXSelectedChildrenChanged in the tests.
160 Also removed some dead code, that became useless after r169487.
162 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
163 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
165 2014-06-15 Ryuan Choi <ryuan.choi@samsung.com>
167 [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
168 https://bugs.webkit.org/show_bug.cgi?id=133841
170 Reviewed by Gyuyoung Kim.
172 * MiniBrowser/efl/main.c:
175 2014-06-15 Dan Bernstein <mitz@apple.com>
177 Set the svn:ignore property on an Xcode project to ignore user and workspace data.
179 * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
181 2014-06-15 Anders Carlsson <andersca@apple.com>
185 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
186 (callRunJavaScriptBlockAndRelease):
187 (runJavaScriptInMainFrame):
190 2014-06-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
192 Create MSE and EME watchlist
193 https://bugs.webkit.org/show_bug.cgi?id=133810
195 Reviewed by Eric Carlson.
197 * Scripts/webkitpy/common/config/watchlist: Create MSEEME
198 definition and add Eric Carlson and myself to it.
200 2014-06-12 Carlos Garcia Campos <cgarcia@igalia.com>
202 [GTK] Remove all deprecated API from GObject DOM bindings
203 https://bugs.webkit.org/show_bug.cgi?id=133728
205 Reviewed by Martin Robinson.
208 (WebKitDOMDocGenerator): Remove all deleted classes from the list.
209 (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
211 2014-06-12 Simon Fraser <simon.fraser@apple.com>
213 [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
214 https://bugs.webkit.org/show_bug.cgi?id=133835
216 Reviewed by Tim Horton.
218 Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
220 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
221 (-[WebKitTestRunnerWindow initWithFrame:]):
222 (-[WebKitTestRunnerWindow setFrame:]):
224 2014-06-12 Carlos Alberto Lopez Perez <clopez@igalia.com>
226 [GTK] Performance tests should be always ran with WKTR.
227 https://bugs.webkit.org/show_bug.cgi?id=133780
229 Reviewed by Ryosuke Niwa.
231 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
232 (PerfTestsRunner.__init__): Enable webkit_test_runner when port
235 2014-06-12 Sergio Villar Senin <svillar@igalia.com>
237 [GTK] REGRESSION: application name is not correctly appended to the UA
238 https://bugs.webkit.org/show_bug.cgi?id=133793
240 Reviewed by Carlos Garcia Campos.
242 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
243 (testWebKitSettingsUserAgent):
245 2014-06-12 Sergio Villar Senin <svillar@igalia.com>
247 [GTK] Unsupported browser in www.icloud.com
248 https://bugs.webkit.org/show_bug.cgi?id=133403
250 Reviewed by Martin Robinson.
252 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
253 (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
254 quirk that was removed.
256 2014-06-11 Simon Fraser <simon.fraser@apple.com>
258 [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
259 https://bugs.webkit.org/show_bug.cgi?id=133779
261 Reviewed by Benjamin Poulain.
263 Tell the WebPage to use the testing viewport configuration from the injected bundle.
265 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
266 (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
267 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
268 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
271 2014-06-11 Simon Fraser <simon.fraser@apple.com>
273 WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
274 https://bugs.webkit.org/show_bug.cgi?id=133770
276 Reviewed by Anders Carlsson.
278 Push the per-test view configuration up to TestController, so that platforms
279 can modify the behavior. This also allows platform-specific changes (e.g.
280 for threaded scrolling) to made without #ifefs.
282 * WebKitTestRunner/TestController.cpp:
283 (WTR::TestController::updateWebViewSizeForTest):
284 (WTR::TestController::updateWindowScaleForTest):
285 (WTR::shouldUseFixedLayout):
286 (WTR::TestController::updateLayoutTypeForTest):
287 (WTR::TestController::platformConfigureViewForTest):
288 (WTR::TestController::configureViewForTest):
289 * WebKitTestRunner/TestController.h:
290 * WebKitTestRunner/TestInvocation.cpp:
291 (WTR::TestInvocation::invoke):
292 (WTR::sizeWebViewForCurrentTest): Deleted.
293 (WTR::changeWindowScaleIfNeeded): Deleted.
294 (WTR::shouldUseThreadedScrolling): Deleted.
295 (WTR::updateThreadedScrollingForCurrentTest): Deleted.
296 (WTR::shouldUseFixedLayout): Deleted.
297 (WTR::updateLayoutType): Deleted.
298 * WebKitTestRunner/TestInvocation.h:
299 (WTR::TestInvocation::pathOrURL):
300 * WebKitTestRunner/ios/TestControllerIOS.mm:
301 (WTR::shouldMakeViewportFlexible):
302 (WTR::TestController::platformConfigureViewForTest):
303 * WebKitTestRunner/mac/TestControllerMac.mm:
304 (WTR::shouldUseThreadedScrolling):
305 (WTR::TestController::platformConfigureViewForTest):
307 2014-06-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
309 [EFL] Add dependencies packages to efl install-dependencies file
310 https://bugs.webkit.org/show_bug.cgi?id=133720
312 Reviewed by Csaba Osztrogonác.
314 After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
315 install doxygen and libssl-dev because efl 1.9 depends on those libraries.
317 * efl/install-dependencies:
319 2014-06-11 Zoltan Horvath <zoltan@webkit.org>
321 Unreviewed. Moving myself to the list of reviewers.
323 * Scripts/webkitpy/common/config/contributors.json:
325 2014-06-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
327 [EFL] Drop to maintain EFL 32bit release bot
328 https://bugs.webkit.org/show_bug.cgi?id=133710
330 Reviewed by Csaba Osztrogonác.
332 * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
334 2014-06-11 Carlos Garcia Campos <cgarcia@igalia.com>
336 [GTK] Use a different user agent string depending on the site
337 https://bugs.webkit.org/show_bug.cgi?id=132681
339 Reviewed by Anders Carlsson.
341 Add a unit test to check user agent quirks.
343 * TestWebKitAPI/PlatformGTK.cmake:
344 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
345 (TestWebKitAPI::TEST):
346 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
347 (testWebKitSettings): Site specific quirks setting is now enabled
350 2014-06-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
352 Unreviewed, update my list of email addresses in contributors.json.
354 * Scripts/webkitpy/common/config/contributors.json:
356 2014-06-10 Simon Fraser <simon.fraser@apple.com>
358 Always switch to an sRGB screen color profile when running tests
359 https://bugs.webkit.org/show_bug.cgi?id=133712
361 Reviewed by Tim Horton.
363 Switch the screen color profile to sRGB when running tests, because even ref
364 tests need the screen to use the correct color profile.
366 * DumpRenderTree/mac/LayoutTestHelper.m:
367 (installLayoutTestColorProfile):
368 * Scripts/webkitpy/port/mac.py:
369 (MacPort.start_helper):
371 2014-06-10 Martin Hodovan <mhodovan@partner.samsung.com>
373 [EFL] Bump EFL libraries to 1.9
374 https://bugs.webkit.org/show_bug.cgi?id=125479
376 Reviewed by Gyuyoung Kim.
378 Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
379 and László Langó <llango.u-szeged@partner.samsung.com>.
381 * ImageDiff/CMakeLists.txt:
382 * MiniBrowser/efl/CMakeLists.txt:
383 * efl/install-dependencies:
384 * efl/jhbuild.modules:
387 2014-06-10 David Farler <dfarler@apple.com>
389 old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
390 https://bugs.webkit.org/show_bug.cgi?id=133663
392 Reviewed by David Kilzer.
394 * Scripts/old-run-webkit-tests:
395 (installAndLaunchDumpToolAppUsingNotification):
396 - Remove obsolete notification keys
397 - Key off of mandatory device UDID (a UUID)
398 - Create a device on demand via CoreSimulator if necessary
399 -- Grab the UDID from the created device plist.
400 * Scripts/webkitdirs.pm:
401 (iOSSimulatorDevicesPath): Added
402 (iOSSimulatorDevices): Added
403 (createiOSSimulatorDevice): Added
404 (deleteiOSSimulatorDevice): Added
406 2014-06-10 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
408 [GTK][gtkdoc] remove -Wcast-align
409 https://bugs.webkit.org/show_bug.cgi?id=133640
411 Apparently gcc warns that GParamSpec is not castable to
412 GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
413 though ARM hackers claim that those only need 4byte alignment. As long as gcc
414 behaves that way, this warning is not very useful, also they break the Debian
417 This patch appends the compiler flag -Wno-align-cast for the gtkdoc
418 scanner compilation, thus the compiler ignores the previous
421 Reviewed by Martin Robinson.
423 * gtk/generate-gtkdoc:
424 (get_generator_for_config):
426 2014-06-09 Alexey Proskuryakov <ap@apple.com>
428 Disable button animations in regression tests
429 https://bugs.webkit.org/show_bug.cgi?id=133647
430 <rdar://problem/16677530>
432 Reviewed by Tim Horton.
434 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
435 (WTR::InjectedBundle::platformInitialize):
437 2014-06-09 Simon Fraser <simon.fraser@apple.com>
439 Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
440 https://bugs.webkit.org/show_bug.cgi?id=133650
442 Reviewed by Tim Horton.
444 No point checking for a Windows-style path in Cocoa code.
446 * WebKitTestRunner/TestInvocation.cpp:
447 (WTR::shouldUseThreadedScrolling):
449 2014-06-09 Simon Fraser <simon.fraser@apple.com>
451 Fix more latched scrolling test flakiness and slowness
452 https://bugs.webkit.org/show_bug.cgi?id=133601
454 Reviewed by Brent Fulgham.
456 Latched scrolling tests were flakey for two reasons. First, the EventSender
457 wheel events were async from the web to the UI process, and the resulting
458 synthetic events also async from the UI to the web process. Make them sync
461 Secondly, the timer-based scrolling tree commit could result in the scrolling
462 tree (specifically the frame node's notion of the scrollable area and content
463 size) not being updated before the scrolling thread starts getting wheel events.
464 Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
466 Finally remove all the now-unnecessary timeouts from the tests.
468 * WebKitTestRunner/mac/EventSenderProxy.mm:
469 (WTR::EventSenderProxy::mouseMoveTo):
470 (WTR::EventSenderProxy::mouseScrollBy):
471 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
473 2014-06-09 Andrzej Badowski <a.badowski@samsung.com>
475 [EFL] Add parameter to MiniBrowser to disable web security
476 https://bugs.webkit.org/show_bug.cgi?id=121095
478 Reviewed by Gyuyoung Kim.
480 -w (--web-security) commandline allows to disable/enable web security (enabled by default).
481 The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
482 resources from other domains (cross-domain requests) such as access map location on another server.
483 Another possibility is to launch in a webkit browser local file tests that will refer to the links
484 in the http website loaded in an iframe. It will not be possible without deactivation of web security.
486 * MiniBrowser/efl/main.c:
490 2014-06-06 Simon Fraser <simon.fraser@apple.com>
494 * WebKitTestRunner/mac/EventSenderProxy.mm:
495 (WTR::EventSenderProxy::mouseMoveTo):
496 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
498 2014-06-06 Simon Fraser <simon.fraser@apple.com>
500 Fix builds on 10.8; -firstObject isn't declared on NSArray there.
502 * DumpRenderTree/mac/DumpRenderTree.mm:
503 (createWebViewAndOffscreenWindow):
504 * DumpRenderTree/mac/EventSendingController.mm:
505 (-[EventSendingController mouseScrollByX:andY:continuously:]):
506 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
507 * WebKitTestRunner/mac/EventSenderProxy.mm:
508 (WTR::EventSenderProxy::mouseScrollBy):
509 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
511 2014-06-06 Simon Fraser <simon.fraser@apple.com>
513 Latched scrolling tests are flakey on Mavericks
514 https://bugs.webkit.org/show_bug.cgi?id=133578
515 <rdar://problem/17180591>
517 Reviewed by Brent Fulgham.
519 The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
520 be wrong on machines with more than one screen. This is because we use
521 [NSScreen mainScreen] when computing the global coordinates of the events, but
522 [NSScreen mainScreen] returns the screen with the key window, not the first screen.
524 So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
525 add comments clarifying why the coordinate math works (which is not obvious given
526 the events have no target window).
528 Some scrolling tests also dispatched events outside the 800x600 test window, so
529 fix those tests, and add logging that will appear in test output when this happens.
531 * DumpRenderTree/mac/DumpRenderTree.mm:
532 (createWebViewAndOffscreenWindow):
533 * DumpRenderTree/mac/EventSendingController.mm:
534 (-[EventSendingController mouseScrollByX:andY:continuously:]):
535 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
536 * WebKitTestRunner/mac/EventSenderProxy.mm:
537 (WTR::EventSenderProxy::mouseMoveTo):
538 (WTR::EventSenderProxy::mouseScrollBy):
539 (WTR::EventSenderProxy::continuousMouseScrollBy):
540 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
542 2014-06-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
544 [GTK] run-perf-tests should run the tests inside the jhbuild shell.
545 https://bugs.webkit.org/show_bug.cgi?id=133533
547 Reviewed by Carlos Garcia Campos.
549 * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
550 (run): Remove the jhbuild-wrapper wrapper from here. It should be
551 on Scripts/webkitpy/port/gtk.py.
552 * Scripts/webkitpy/port/base.py:
553 (Port.set_option): Add a set_option(name, value) function to set
554 the optparse parameter "name" to the value "value", even if the
555 parameter "name" is already initialized.
556 * Scripts/webkitpy/port/gtk.py:
557 (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
558 If another wrapper is specified via the option "-l --wrapper=x",
559 then prepend the jhbuild-wrapper to the one specified.
561 2014-06-04 David Farler <dfarler@apple.com>
563 Build ASan WebKit for iOS Simulator
564 https://bugs.webkit.org/show_bug.cgi?id=133489
566 Reviewed by Darin Adler.
568 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
569 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
570 - Add missing ASan LDFLAGS.
571 * asan/asan.xcconfig:
572 - Split compiler-rt linker flags for OS X and iOS Simulator
574 2014-06-03 Yoav Weiss <yoav@yoav.ws>
576 Add myself (yoav@yoav.ws) to contributors.json
577 https://bugs.webkit.org/show_bug.cgi?id=133492
579 * Scripts/webkitpy/common/config/contributors.json:
581 2014-06-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
583 REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
584 https://bugs.webkit.org/show_bug.cgi?id=133149
586 Reviewed by Csaba Osztrogonác.
588 * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
590 2014-06-02 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
592 Add a verbose flag to binding tests
593 https://bugs.webkit.org/show_bug.cgi?id=122303
595 Reviewed by Csaba Osztrogonác.
598 - Add a verbose keyword argument to the BindingsTests constructor,
599 - Add --no-verbose option to the run-bindigs-test.
600 Verbose mode, which is on by default, prints positive results to stdout as before.
601 When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
603 Original patch from Matthew Hanson <matthew_hanson@apple.com>
605 * Scripts/run-bindings-tests:
607 * Scripts/webkitpy/bindings/main.py:
608 (BindingsTests.__init__):
609 (BindingsTests.detect_changes):
611 2014-06-01 Ryosuke Niwa <rniwa@webkit.org>
613 Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
614 https://bugs.webkit.org/show_bug.cgi?id=133455
616 Reviewed by Timothy Hatcher.
618 Since the perf. dashboard doesn't support following renamed benchmarks,
619 keep reporting Speedometer results as DoYouEvenBench results.
621 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
622 (_generate_results_dict):
624 2014-05-31 Darin Adler <darin@apple.com>
626 Viewport percentage tests that resize the viewport are flaky
627 https://bugs.webkit.org/show_bug.cgi?id=133351
629 Reviewed by Anders Carlsson.
631 * DumpRenderTree/mac/DumpRenderTree.mm:
632 (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
633 happens to be stored in the UI delegate object. This is part of resetting the
636 * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
637 a frame rectangle. The size is stored in the size of the web view itself.
638 * DumpRenderTree/mac/UIDelegate.mm:
639 (-[UIDelegate resetWindowOrigin]): Added.
640 (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
641 old version would store the frame, but not resize the web view!
642 (-[UIDelegate webViewFrame:]): Get the size from the web view.
644 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
645 (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
647 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
648 (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
651 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
652 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
653 window gets resized too, not just the web view.
654 (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
656 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
657 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
658 window gets resized too, not just the web view.
659 (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
661 2014-05-30 Michael Saboff <msaboff@apple.com>
663 Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
664 https://bugs.webkit.org/show_bug.cgi?id=133409
666 Reviewed by Filip Pizlo.
668 Handle creating a tarball the same way as running remote when processing
669 paths in prepareBundle.
671 * Scripts/run-jsc-stress-tests:
673 2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
675 [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
676 https://bugs.webkit.org/show_bug.cgi?id=132280
678 Reviewed by Chris Fleizach.
680 Remove implementation of logAccessibilityEvents() for ATK based
681 ports, as this has proved to be a flaky method of checking that
682 ATK events are being properly emitted. Instead, it's better to use
683 the addNotificationListener() functions and provide a JS callback
684 to check that the right events are being emmitted from the tests.
686 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
687 (WTR::AccessibilityController::logAccessibilityEvents): Replaced
688 with dummy implementation.
689 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
690 (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
692 2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
694 [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
695 https://bugs.webkit.org/show_bug.cgi?id=132280
697 Rubber stamped by Carlos Garcia Campos.
699 Fix two small issues with previous patch (r169483), that caused some tests to break.
701 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
702 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
704 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
705 (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
707 2014-05-30 Jarek Czekalski <jarekczek@poczta.onet.pl>
709 [ATK] Added new accessibility signal: text-caret-moved.
710 Make AccessibilityUIElement.setSelectedTextRange work
711 as atk_text_set_caret_offset when given offset == 0.
712 https://bugs.webkit.org/show_bug.cgi?id=132527
714 Reviewed by Mario Sanchez Prada.
716 text-caret-moved signal in accessibilityController is needed to
717 implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
718 as LayoutTests. Add the signal to the controller.
720 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
721 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
722 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
723 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
724 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
725 (setSelectedTextRange): Change return type to bool.
726 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
727 (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
728 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
729 (axObjectEventListener): Add notification name AXTextCaretMoved, allow
730 for extra arguments passed to handler and use it for text-caret-moved offset.
731 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
732 Connect callback to new listener for ATK:AtkText:text-caret-moved.
733 Refactor so that failures be reported.
734 Initialize atk interfaces before trying to connect to them, see
735 https://bugzilla.gnome.org/show_bug.cgi?id=729922
736 (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
737 Simplify code by using a vector in place of dozen variables.
738 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
739 Comment about not synchronizing with accessibilityController.
741 2014-05-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
743 [GTK] Add a WebKit2 Performance bot.
744 https://bugs.webkit.org/show_bug.cgi?id=132862
746 Reviewed by Csaba Osztrogonác.
748 This adds a GTK WebKit2 perf bot.
750 * BuildSlaveSupport/build.webkit.org-config/config.json:
752 2014-05-29 Dan Bernstein <mitz@apple.com>
754 Fixed the WebKitTestRunner build after r169452.
756 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
757 (WTR::InjectedBundle::initialize):
759 2014-05-28 Gwang Yoon Hwang <yoon@igalia.com>
761 Unreviewed. Update my email addresses in contributors.json.
763 * Scripts/webkitpy/common/config/contributors.json:
765 2014-05-27 Jon Honeycutt <jhoneycutt@apple.com>
767 Need an API test for bug #133193 (r169315)
768 <https://bugs.webkit.org/show_bug.cgi?id=133324>
770 This adds an API test that ensures that calling "stop loading" during a
771 "did fail provisional load" callback doesn't crash.
773 Reviewed by Andy Estes.
775 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
776 Add new files to project.
778 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
779 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
780 If the message is the "test done" message, record that.
781 (TestWebKitAPI::setInjectedBundleClient):
782 Register a function for the "did receive message from injected bundle"
784 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
785 Assert that we received the message from the injected bundle, and set
786 'done' to finish the test.
787 (TestWebKitAPI::TEST):
788 Create a WebView, register a page loader client for the "did fail
789 provisional load" callback, and load a non-existent resource.
791 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
792 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
793 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
794 Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
795 provisional load failed.
796 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
797 Register a page loader client for the "did fail provisional load"
799 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
800 Call WKBundlePageStopLoading() during the callback. This not crashing
801 is what we're ensuring with this test.
803 2014-05-28 Carlos Garcia Campos <cgarcia@igalia.com>
805 [GTK] Make it possible to build with FTL enabled
806 https://bugs.webkit.org/show_bug.cgi?id=133219
808 Reviewed by Philippe Normand.
810 * gtk/jhbuild-optional.modules: Add llvm from svn and build the
811 same revision than mac.
813 2014-05-27 Michael Saboff <msaboff@apple.com>
815 REGRESSION(r169265): sh: line 0: cd: ../.vm
816 https://bugs.webkit.org/show_bug.cgi?id=133242
818 Rubber stamped by Oliver Hunt.
820 Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
821 array since the command may contain character escapes that don't work with the
822 array form of system().
824 * Scripts/run-jsc-stress-tests:
826 2014-05-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
828 [EFL] Change download url of freetype6
829 https://bugs.webkit.org/show_bug.cgi?id=133303
831 Reviewed by Csaba Osztrogonác.
833 freetype6 tarball isn't downloaded in Korea. So, we need to
834 change the url for now.
836 * efl/jhbuild.modules:
838 2014-05-27 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
841 https://bugs.webkit.org/show_bug.cgi?id=132863
843 Reviewed by Csaba Osztrogonác.
845 * Scripts/webkitperl/FeatureList.pm:
847 2014-05-27 Alberto Garcia <berto@igalia.com>
849 Remove leftover comment from r165182.
851 Rubber stamped by Carlos Garcia Campos.
853 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
855 2014-05-26 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
857 [EFL] Add LLVM as optional jhbuild module for FTL developers
858 https://bugs.webkit.org/show_bug.cgi?id=133216
860 Reviewed by Gyuyoung Kim.
862 * efl/jhbuild.modules:
864 2014-05-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
866 Fix test failures on python test
867 https://bugs.webkit.org/show_bug.cgi?id=133297
869 Reviewed by Dirk Schulze.
871 2 tests are failing because of unbounded local variable reference in test_importer.py.
873 * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
874 (TestImporter.import_tests):
876 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
878 [GTK] GObject DOM bindings API break test fails in the tests bots
879 https://bugs.webkit.org/show_bug.cgi?id=133211
881 Reviewed by Martin Robinson.
883 When generating the built product archive on platform GTK, we need
884 to copy also the file gtkdoc-webkitdom.cfg and the directory
885 DerivedSources/webkitdom.
887 * BuildSlaveSupport/built-product-archive:
888 (archiveBuiltProduct):
890 2014-05-26 Commit Queue <commit-queue@webkit.org>
892 Unreviewed, rolling out r169122.
893 https://bugs.webkit.org/show_bug.cgi?id=133288
895 Broke CJK font fallback (Requested by ap on #webkit).
899 "[Mac] WebProcess doesn't follow localization of UI process
900 when run as a service"
901 https://bugs.webkit.org/show_bug.cgi?id=133126
902 http://trac.webkit.org/changeset/169122
904 2014-05-26 Carlos Garcia Campos <cgarcia@igalia.com>
906 [GTK] WebProcess leaked when closing pages with network process enabled
907 https://bugs.webkit.org/show_bug.cgi?id=129684
909 Reviewed by Anders Carlsson.
911 Enable the test to check that web processes finish when the web
914 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
916 2014-05-26 Carlos Garcia Campos <cgarcia@igalia.com>
918 REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
919 https://bugs.webkit.org/show_bug.cgi?id=133279
921 Reviewed by Philippe Normand.
923 generator.saw_warnings is only set by GTKDoc::generate(), so it
924 should only be used after generate.
926 * gtk/generate-gtkdoc:
927 (generate_documentation_for_config): Do not check
928 generator.saw_warnings again, simply return the value returned by
929 generate_doc() which is generator.saw_warnings. When rebasing,
930 returns always False since there aren't warnings.
932 2014-05-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
934 W3C test importer should catch exceptions coming from HTML/CSS conversion
935 https://bugs.webkit.org/show_bug.cgi?id=133176
937 Reviewed by Darin Adler.
939 Exceptions raised when converting HTML/CSS are caught.
940 Files for which conversion failed are still copied to the target directory.
941 Each individual conversion failure is logged.
942 Total conversion failure number is logged at the end of the import process.
944 * Scripts/webkitpy/w3c/test_importer.py:
945 (TestImporter.import_tests):
947 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
949 [GTK] Allow to run the tests on the native X display.
950 https://bugs.webkit.org/show_bug.cgi?id=133157
952 Reviewed by Benjamin Poulain.
954 This adds a new driver (xorgdriver) that runs the tests on the
955 X display referenced by the environment variable DISPLAY.
957 This new driver will be activated only if the environment variable
958 USE_NATIVE_XDISPLAY is defined. This can be used both for layout
959 tests and performance tests.
961 This patch also makes the script run-perf-tests to check the
962 system dependencies before starting the tests. Previously this
963 was not checked, and if the system dependencies were not met,
964 the script tried to execute the tests anyway, causing massive
965 failures. For example, if you had Xvfb not installed and you
966 wanted to use the Xvfb driver (the default on GTK and EFL),
967 run-perf-tests would not abort.
969 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
970 (PerfTestsRunner._parse_args): Check the system dependencies of
971 the driver before starting the tests.
972 * Scripts/webkitpy/port/driver.py:
973 (Driver): Implement generic check_driver method.
974 (Driver.check_driver):
975 (Driver.check_driver.implementation):
976 * Scripts/webkitpy/port/gtk.py:
977 (GtkPort._driver_class): Check for environment variable
978 USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
979 * Scripts/webkitpy/port/xorgdriver.py: Added.
980 (XorgDriver): Implement Xorg driver.
981 (XorgDriver.check_driver):
984 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
986 REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
987 https://bugs.webkit.org/show_bug.cgi?id=133215
989 Reviewed by Csaba Osztrogonác.
991 This reverts r166798.
993 * BuildSlaveSupport/kill-old-processes:
996 2014-05-26 Michał Pakuła vel Rutka <m.pakula@samsung.com>
998 [EFL] Turn on ENABLE_CSS_FILTERS in build script
999 https://bugs.webkit.org/show_bug.cgi?id=133278
1001 Reviewed by Gyuyoung Kim.
1003 * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
1005 2014-05-26 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1007 run-javascriptcore-tests warning fix on non Mac platforms
1008 https://bugs.webkit.org/show_bug.cgi?id=133260
1010 Reviewed by Darin Adler.
1012 * Scripts/webkitdirs.pm:
1013 (argumentsForConfiguration):
1015 2014-05-23 Michael Saboff <msaboff@apple.com>
1017 REGRESSION(r169265): sh: line 0: cd: ../.vm
1018 https://bugs.webkit.org/show_bug.cgi?id=133242
1020 Rubber stamped by Geoffrey Garen.
1022 Added missing shell escapes '\' required as part of previous fix.
1024 * Scripts/run-jsc-stress-tests:
1026 2014-05-23 Ryosuke Niwa <rniwa@webkit.org>
1028 Revert the erroneous change committed in r169286.
1030 * Scripts/webkitpy/performance_tests/perftest.py:
1031 (PerfTest._run_with_driver):
1033 2014-05-23 Geoffrey Garen <ggaren@apple.com>
1035 run-perf-tests should ignore whitespace lines when snarfing test output
1036 https://bugs.webkit.org/show_bug.cgi?id=133238
1038 Reviewed by Ryosuke Niwa.
1040 Required for PerformanceTests/Canvas/terrain.html.
1042 * Scripts/webkitpy/performance_tests/perftest.py:
1043 (PerfTest._run_with_driver):
1046 2014-05-23 Michael Saboff <msaboff@apple.com>
1048 REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
1049 https://bugs.webkit.org/show_bug.cgi?id=133223
1051 Reviewed by Geoffrey Garen.
1053 Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
1054 string before calling IO.popen() to work with older versions of ruby.
1055 Changed the remote path in runShellTestRunner to quote the command
1056 string we want to run via ssh so that it will work correctly with array
1057 to string conversion needed for popen.
1059 * Scripts/run-jsc-stress-tests:
1061 2014-05-23 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1063 Remove 'css-shaders' option from the build-webkit
1064 https://bugs.webkit.org/show_bug.cgi?id=133212
1066 Reviewed by Daniel Bates.
1068 Original CSS shaders removed in r162644.
1070 * Scripts/webkitperl/FeatureList.pm:
1072 2014-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
1074 [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
1075 https://bugs.webkit.org/show_bug.cgi?id=133209
1077 Reviewed by Sergio Villar Senin.
1079 Return FAILURE when the command failed to run.
1081 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1082 (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
1084 2014-05-23 Alberto Garcia <berto@igalia.com>
1086 [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
1087 https://bugs.webkit.org/show_bug.cgi?id=133210
1089 Reviewed by Carlos Garcia Campos.
1091 * gtk/install-dependencies:
1093 2014-05-22 Benjamin Poulain <bpoulain@apple.com>
1095 Add Yusuke Suzuki to the list of contributors (for real)
1099 * Scripts/webkitpy/common/config/contributors.json:
1101 2014-05-22 Benjamin Poulain <bpoulain@apple.com>
1103 Add Yusuke Suzuki to the list of contributors
1105 * Scripts/webkitpy/common/config/contributors.json:
1107 2014-05-22 Michael Saboff <msaboff@apple.com>
1109 Eliminate n/total progress update from run-jsc-stress-tests output to file
1110 https://bugs.webkit.org/show_bug.cgi?id=133191
1112 Reviewed by Geoffrey Garen.
1114 Changed progressMeter setting to be based on stdout being a tty instead of
1115 stdin. Unified the processing of output from the shell runner to match the
1116 same processing as is used by the makefile runner. As part of this, the
1117 shell runner script was simplified. It now forwards the output of each
1118 test_script just like the Makefile and doesn't provide its own progress.
1120 * Scripts/jsc-stress-test-helpers/shell-runner.sh:
1121 * Scripts/run-jsc-stress-tests:
1123 2014-05-22 Michael Saboff <msaboff@apple.com>
1125 Add option to run-jsc-stress-tests to use installed jsc
1126 https://bugs.webkit.org/show_bug.cgi?id=133102
1128 Reviewed by Geoffrey Garen.
1130 Added --no-copy option to not copy a JavaScriptCore framework, but use the one
1131 provied with the --jsc option.
1133 * Scripts/run-jsc-stress-tests:
1135 2014-05-21 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1137 [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
1138 https://bugs.webkit.org/show_bug.cgi?id=132907
1140 Reviewed by Gyuyoung Kim.
1142 We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
1143 in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
1145 * efl/install-dependencies:
1147 2014-05-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1149 REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
1150 https://bugs.webkit.org/show_bug.cgi?id=133145
1152 Reviewed by Csaba Osztrogonác.
1154 * Scripts/run-jsc-stress-tests:
1156 2014-05-20 Alexey Proskuryakov <ap@apple.com>
1158 [Mac] WebProcess doesn't follow localization of UI process when run as a service
1159 https://bugs.webkit.org/show_bug.cgi?id=133126
1160 <rdar://problem/13396515>
1161 <rdar://problem/16561084>
1163 Reviewed by Sam Weinig and Tim Horton.
1165 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1166 (WTR::InjectedBundle::platformInitialize): It was too late to override language
1167 here, and it's not necessary any more. Keeping the code for older OS versions in
1168 case it did have effect in some code paths.
1170 2014-05-19 David Farler <dfarler@apple.com>
1172 Move WebKitTestRunner to std::unique_ptr
1173 https://bugs.webkit.org/show_bug.cgi?id=133081
1175 Reviewed by Daniel Bates.
1177 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1178 (WTR::InjectedBundle::didCreatePage):
1179 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1180 * WebKitTestRunner/TestController.cpp:
1181 (WTR::TestController::initialize):
1182 (WTR::TestController::createWebViewWithOptions):
1183 (WTR::TestController::resetStateToConsistentValues):
1184 (WTR::TestController::runTest):
1185 * WebKitTestRunner/TestController.h:
1186 * WebKitTestRunner/TestInvocation.cpp:
1187 * WebKitTestRunner/TestInvocation.h:
1188 * WebKitTestRunner/WorkQueueManager.cpp:
1189 (WTR::WorkQueueManager::processWorkQueue):
1190 (WTR::WorkQueueManager::enqueue):
1191 * WebKitTestRunner/WorkQueueManager.h:
1193 2014-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
1195 [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
1196 https://bugs.webkit.org/show_bug.cgi?id=133119
1198 Reviewed by Sergio Villar Senin.
1200 Check that redirect response parameter of
1201 WebKitWebPage::send-request signal is NULL when not redirecting
1202 and a valid WebKitURIResponse object when redirecting.
1204 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1205 (testWebResourceSendRequest):
1207 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1208 (sendRequestCallback):
1210 2014-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
1212 REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
1213 https://bugs.webkit.org/show_bug.cgi?id=133117
1215 Reviewed by Philippe Normand.
1217 Bring back missing tests to the build.
1219 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1221 2014-05-19 Filip Pizlo <fpizlo@apple.com>
1223 Take care of some ARM64 test failures
1224 https://bugs.webkit.org/show_bug.cgi?id=133090
1226 Reviewed by Geoffrey Garen.
1228 * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1230 2014-05-19 David Kilzer <ddkilzer@apple.com>
1232 [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1233 <http://webkit.org/b/133089>
1235 Reviewed by Darin Adler.
1237 * Scripts/webkitdirs.pm:
1238 (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1239 specified on the command line, we would remove the '--sdk'
1240 arguments, but leave '--sim', potentially passing it along to
1241 xcodebuild causing a build failure. This happens when
1242 'old-run-webkit-tests --release --sim' invokes
1243 build-dumprendertree when DumpRenderTree hasn't been built yet.
1245 2014-05-19 David Farler <dfarler@apple.com>
1247 Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1248 https://bugs.webkit.org/show_bug.cgi?id=133086
1250 Reviewed by Daniel Bates.
1252 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1254 2014-05-19 David Kilzer <ddkilzer@apple.com>
1256 REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1257 <http://webkit.org/b/132954>
1259 * Scripts/webkitdirs.pm:
1260 (sharedCommandLineOptionsUsage): Remove the prototype for the
1261 subroutine. Older perls don't like the "+@" syntax.
1263 2014-05-19 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1265 run-javascriptcore-tests should sort the list of failing stress tests
1266 https://bugs.webkit.org/show_bug.cgi?id=132989
1268 Reviewed by Csaba Osztrogonác.
1270 * Scripts/run-javascriptcore-tests:
1272 2014-05-19 David Kilzer <ddkilzer@apple.com>
1274 webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1275 <http://webkit.org/b/132954>
1277 Reviewed by Darin Adler.
1279 Extract code into setupMacWebKitEnvironment() for setting up
1280 common environment variables so it may be shared. Sets
1281 __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1282 using guardmalloc to some scripts.
1284 Also adds support for parsing shared (common) command-line
1285 switches, initially just -g|--guard-malloc.
1287 * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1288 sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1289 (mountAndRunNightly): Call setupMacWebKitEnvironment(). Use a
1290 local copy of %ENV when launching Safari so we don't have to
1293 * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1294 sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1295 Check result of GetOptions() to catch invalid command-line
1297 (runTest): Use a local copy of %ENV when running tests so we
1298 don't have to restore variables.
1299 (prepareEnvironmentForRunningTestTool): Call
1300 setupMacWebKitEnvironment().
1302 * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1303 using sharedCommandLineOptions() and
1304 sharedCommandLineOptionsUsage(). Call
1305 setupMacWebKitEnvironment().
1307 * Scripts/webkitdirs.pm:
1308 (sharedCommandLineOptions): Return array of common switches to
1309 pass to Getopt::Long::GetOptions().
1310 (sharedCommandLineOptionsUsage): Return formatted string of
1311 common switches for printing usage help text.
1312 (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1314 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1315 (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1316 and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1317 (runMacWebKitApp): Call setupMacWebKitEnvironment(). Use a
1318 local copy of %ENV when launching Safari so we don't have to
1320 (execMacWebKitAppForDebugging): Call
1321 setupMacWebKitEnvironment().
1323 2014-05-18 Rik Cabanier <cabanier@adobe.com>
1325 support for navigator.hardwareConcurrency
1326 https://bugs.webkit.org/show_bug.cgi?id=132588
1328 Reviewed by Filip Pizlo.
1330 * Scripts/webkitperl/FeatureList.pm:
1332 2014-05-18 Anders Carlsson <andersca@apple.com>
1334 Implement Navigations for all methods declared returning one
1335 https://bugs.webkit.org/show_bug.cgi?id=133048
1336 <rdar://problem/16830064>
1338 Reviewed by Sam Weinig.
1340 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1343 * MiniBrowser/mac/WK2BrowserWindowController.m:
1344 (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1345 (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1346 (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1347 (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1348 (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1349 (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1350 Print out the navigations.
1352 2014-05-17 Zalan Bujtas <zalan@apple.com>
1354 Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1355 https://bugs.webkit.org/show_bug.cgi?id=133029
1357 Reviewed by Simon Fraser.
1359 Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1360 toggling it on a WK2 window needs restart.
1361 Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1362 the WebPreferences just to support this temporary toggle.
1364 * MiniBrowser/mac/BrowserWindowController.h:
1365 * MiniBrowser/mac/MainMenu.xib:
1366 * MiniBrowser/mac/WK1BrowserWindowController.m:
1367 (-[WK1BrowserWindowController validateMenuItem:]):
1368 (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1369 (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1370 * MiniBrowser/mac/WK2BrowserWindowController.m:
1371 (-[WK2BrowserWindowController validateMenuItem:]):
1372 (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1373 (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1375 2014-05-17 Anders Carlsson <andersca@apple.com>
1377 Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1378 https://bugs.webkit.org/show_bug.cgi?id=133033
1379 <rdar://problem/16830143>
1381 Reviewed by Sam Weinig.
1383 Set up the WebSQL and IndexedDB directories.
1385 * WebKitTestRunner/TestController.cpp:
1386 (WTR::TestController::initialize):
1388 2014-05-16 Martin Hock <mhock@apple.com>
1390 MemoryCache::addImageToCache should return the result of add().
1391 https://bugs.webkit.org/show_bug.cgi?id=132928
1392 <rdar://problem/16651547>
1394 Reviewed by Alexey Proskuryakov.
1396 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1397 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1398 * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1399 (TestWebKitAPI::TEST):
1401 2014-05-15 David Farler <dfarler@apple.com>
1403 old-run-webkit-tests: allow specifying a simulator app path
1404 https://bugs.webkit.org/show_bug.cgi?id=132975
1406 Reviewed by Anders Carlsson.
1408 * Scripts/old-run-webkit-tests:
1409 (openIPhoneSimulator):
1410 Add new --simulator-app command line parameter for specifying the
1411 absolute path to the simulator app to launch before starting a
1414 2014-05-16 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1416 [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1417 https://bugs.webkit.org/show_bug.cgi?id=131363
1419 Reviewed by Csaba Osztrogonác.
1421 * Scripts/webkitpy/common/checkout/checkout_mock.py:
1422 * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1424 * Scripts/webkitpy/tool/commands/download_unittest.py:
1425 (test_create_rollout_multiple_revision_with_one_resolved):
1426 (test_create_rollout_multiple_resolved):
1427 (test_rollout_two_revisions):
1428 (test_rollout_multiple_revisions):
1429 (test_rollout_multiple_revisions_with_a_missing_bug_id):
1430 * Scripts/webkitpy/tool/steps/createbug.py:
1432 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1433 (ReopenBugAfterRollout.run):
1435 2014-05-16 Martin Hodovan <mhodovan.u-szeged@partner.samsung.com>
1437 [WK2] Change the remaining framework includes from WebKit2 to WebKit
1438 https://bugs.webkit.org/show_bug.cgi?id=132956
1440 Reviewed by Sam Weinig.
1442 * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1443 * MiniBrowser/mac/AppDelegate.m:
1444 * MiniBrowser/mac/WK2BrowserWindowController.m:
1445 * TestWebKitAPI/InjectedBundleController.h:
1446 * TestWebKitAPI/InjectedBundleMain.cpp:
1447 * TestWebKitAPI/JavaScriptTest.cpp:
1448 * TestWebKitAPI/PlatformUtilities.h:
1449 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1450 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1451 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1452 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1453 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1454 (TestWebKitAPI::TEST):
1455 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1456 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1457 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1458 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1459 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1460 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1461 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1462 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1463 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1464 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1465 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1466 * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1467 * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1468 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1469 * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1470 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1471 * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1472 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1473 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1474 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1475 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1476 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1477 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1478 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1479 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1480 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1481 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1482 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1483 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1484 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1485 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1486 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1487 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1488 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1489 * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1490 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1491 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1492 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1493 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1494 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1495 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1496 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1497 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1498 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1499 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1500 * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1501 * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1502 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1503 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1504 * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1505 * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1506 * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1507 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1508 * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1509 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1510 * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1511 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1512 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1513 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1514 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1515 * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1516 * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1517 * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1518 * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1519 * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1520 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1521 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1522 * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1523 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1524 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1525 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1526 * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1527 * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1528 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1529 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1530 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1531 * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1532 * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1533 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1534 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1535 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1536 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1537 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1538 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1539 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1540 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1541 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1542 * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1543 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1544 * TestWebKitAPI/config.h:
1545 * TestWebKitAPI/efl/PlatformWebView.cpp:
1546 * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1547 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1548 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1549 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1550 * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1551 * WebKitTestRunner/EventSenderProxy.h:
1552 * WebKitTestRunner/GeolocationProviderMock.cpp:
1553 * WebKitTestRunner/GeolocationProviderMock.h:
1554 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1555 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1556 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1557 * WebKitTestRunner/InjectedBundle/GCController.cpp:
1558 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1559 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1560 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1561 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1562 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1563 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1564 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1565 * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1566 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1567 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1568 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1569 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1570 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1571 * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1572 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1573 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1574 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1575 * WebKitTestRunner/PlatformWebView.h:
1576 * WebKitTestRunner/StringFunctions.h:
1577 * WebKitTestRunner/TestController.cpp:
1578 * WebKitTestRunner/TestController.h:
1579 * WebKitTestRunner/TestInvocation.cpp:
1580 * WebKitTestRunner/TestInvocation.h:
1581 * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1582 * WebKitTestRunner/WebNotificationProvider.cpp:
1583 * WebKitTestRunner/WebNotificationProvider.h:
1584 * WebKitTestRunner/WorkQueueManager.cpp:
1585 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1586 * WebKitTestRunner/cg/TestInvocationCG.cpp:
1587 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1588 * WebKitTestRunner/config.h:
1589 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1590 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1591 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1592 * WebKitTestRunner/ios/TestControllerIOS.mm:
1593 * WebKitTestRunner/mac/EventSenderProxy.mm:
1594 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1595 * WebKitTestRunner/mac/TestControllerMac.mm:
1597 2014-05-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1599 [EFL][WK2] Skip failing unit tests
1600 https://bugs.webkit.org/show_bug.cgi?id=132979
1602 Reviewed by Daniel Bates.
1604 * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1606 2014-05-15 David Kilzer <ddkilzer@apple.com>
1608 [iOS] Support TestWebKitAPI in the iOS Simulator
1609 <http://webkit.org/b/129535>
1610 <rdar://problem/16203529>
1612 Reviewed by Daniel Bates.
1614 * Scripts/run-api-tests:
1617 - Extract common arguments into local variable.
1618 - Use xcrun to find the sim tool in order to invoke
1619 TestWebKitAPI properly in the iOS Simulator.
1621 * Scripts/webkitdirs.pm:
1622 (argumentsForConfiguration): Set --device or --sim as
1623 appropriate to fix buildTestTool() in run-api-tests.
1625 2014-05-15 Tim Horton <timothy_horton@apple.com>
1627 Fix a logging typo in copy-webkitlibraries-to-product-directory
1629 Reviewed by Dean Jackson.
1631 * Scripts/copy-webkitlibraries-to-product-directory:
1633 2014-05-15 David Kilzer <ddkilzer@apple.com>
1635 TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1636 <http://webkit.org/b/132959>
1638 Reviewed by Dan Bernstein.
1640 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1641 Cocoa directory to project and move URLExtras.mm into it.
1642 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1644 2014-05-15 Carlos Garcia Campos <cgarcia@igalia.com>
1646 [GTK] Compile all installed resources as GResources
1647 https://bugs.webkit.org/show_bug.cgi?id=131099
1649 Reviewed by Philippe Normand.
1651 * Scripts/webkitpy/port/gtk.py:
1652 (GtkPort.setup_environ_for_server): Removed now unneeded
1653 AUDIO_RESOURCES_PATH env var.
1655 2014-05-14 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1657 Remove CSS_STICKY_POSITION guards
1658 https://bugs.webkit.org/show_bug.cgi?id=132676
1660 Reviewed by Simon Fraser.
1662 * Scripts/webkitperl/FeatureList.pm:
1664 2014-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
1666 REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1667 https://bugs.webkit.org/show_bug.cgi?id=132686
1669 Reviewed by Philippe Normand.
1671 Bring back InputMethodFilter test to the build and compile it into
1672 a single binary TestWebCore with the other WebCore tests. Also
1673 move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1675 * Scripts/run-gtk-tests:
1676 (TestRunner): Remove WebCoreGtk from the list of test directories.
1677 * TestWebKitAPI/PlatformGTK.cmake:
1678 * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1680 2014-05-14 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1682 [EFL] Make XVFBDriver optional
1683 https://bugs.webkit.org/show_bug.cgi?id=131036
1685 Reviewed by Gyuyoung Kim.
1687 * Scripts/webkitpy/port/efl.py:
1688 (EflPort._driver_class):
1690 2014-05-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
1692 Flakiness dashboard contains outdated list of bots on builders.jsonp
1693 https://bugs.webkit.org/show_bug.cgi?id=132874
1695 Reviewed by Darin Adler.
1697 * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1698 file by changing to the directory Tools/TestResultServer and executing
1699 the script generate_builders_json.py
1701 2014-05-11 Anders Carlsson <andersca@apple.com>
1703 Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1704 https://bugs.webkit.org/show_bug.cgi?id=132809
1706 Reviewed by Dan Bernstein.
1708 * WebKitTestRunner/TestController.cpp:
1709 (WTR::TestController::initialize):
1710 Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1712 2014-05-12 Carlos Garcia Campos <cgarcia@igalia.com>
1714 REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1715 https://bugs.webkit.org/show_bug.cgi?id=132739
1717 Reviewed Anders Carlsson.
1719 * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1721 * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1723 2014-05-11 Anders Carlsson <andersca@apple.com>
1725 Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1726 https://bugs.webkit.org/show_bug.cgi?id=132806
1728 Reviewed by Beth Dakin.
1730 Migrate to WKContextConfiguration.
1732 * WebKitTestRunner/TestController.cpp:
1733 (WTR::TestController::initialize):
1735 2014-05-10 Carlos Garcia Campos <cgarcia@igalia.com>
1737 REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1738 https://bugs.webkit.org/show_bug.cgi?id=132685
1740 Reviewed by Martin Robinson.
1742 Use a single TestWebKit2 binary for all WebKit2 C API tests.
1744 * TestWebKitAPI/PlatformGTK.cmake:
1746 2014-05-09 Benjamin Poulain <benjamin@webkit.org>
1748 [iOS] Switch geolocation to an explicit authorization query model
1749 https://bugs.webkit.org/show_bug.cgi?id=132717
1751 Reviewed by Sam Weinig.
1753 * DumpRenderTree/mac/MockGeolocationProvider.mm:
1754 (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1755 (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1757 2014-05-09 David Farler <dfarler@apple.com>
1759 com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1760 https://bugs.webkit.org/show_bug.cgi?id=132718
1762 Reviewed by David Kilzer.
1764 The simulator may not be able to look up runtimes by SDK paths
1765 and instead will map SDK versions to runtimes instead. In
1766 com.apple.iphonesimulator.startSession notifications,
1767 'runtimeIdentifier' (SDK version string) is preferred over
1768 'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1769 when creating a new DRT or WKTR simulator session.
1771 IPhoneSimulatorNotification.pm filters out keys for this
1772 notification's userInfo with a hard-coded list. There's no harm
1773 in including extra key-value pairs in an NSNotification userInfo
1774 dictionary anyway and the simulator may again change its
1775 userInfo schema for this notification.
1777 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1778 (postStartSessionNotification):
1779 * Scripts/old-run-webkit-tests:
1780 (installAndLaunchDumpToolAppUsingNotification):
1782 2014-05-09 Anders Carlsson <andersca@apple.com>
1786 * Scripts/build-webkit:
1787 WebKit2 should always be built for OS X and iOS.
1789 2014-05-09 Anders Carlsson <andersca@apple.com>
1791 Follow-up build fix.
1793 * Scripts/build-webkit:
1794 WebKit2 should no longer be built before WebKit.
1796 2014-05-09 Anders Carlsson <andersca@apple.com>
1798 Rename WebKit2.framework to WebKit.framework
1799 https://bugs.webkit.org/show_bug.cgi?id=132743
1800 <rdar://problem/15920046>
1802 Reviewed by Dan Bernstein.
1804 * Scripts/check-for-inappropriate-files-in-framework:
1805 Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1806 Change WebKit2 to WebKit.
1808 * Scripts/check-for-webkit-framework-include-consistency:
1809 Change WebKit to WebKitLegacy.
1811 2014-05-09 Manuel Rego Casasnovas <rego@igalia.com>
1813 Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1814 https://bugs.webkit.org/show_bug.cgi?id=132732
1816 Reviewed by Alexey Proskuryakov.
1818 GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1820 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1821 (EWS): Remove GTK+ WK1 EWS.
1823 2014-05-09 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1825 Add new u-szeged contributors.
1827 Reviewed by Csaba Osztrogonác.
1829 * Scripts/webkitpy/common/config/contributors.json:
1831 2014-05-09 Carlos Garcia Campos <cgarcia@igalia.com>
1833 REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1834 https://bugs.webkit.org/show_bug.cgi?id=132736
1836 Reviewed by Philippe Normand.
1838 There are two problems, the path returned by common.library_build_path() is wrong when
1839 common.binary_build_path() has previously been called, and the test is still looking for
1840 the .la instead of .so
1842 * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1843 (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1844 of .la as extension of the injected bundle library.
1846 (binary_build_path): Remove unused global variable and add a new
1847 one for binary_build_dir instead of sharing the same global
1848 variable for library_build_path and binary_build_path.
1850 2014-05-08 Praveen R Jadhav <praveen.j@samsung.com>
1852 [EFL] Enable MEDIA_STREAM for EFL port
1853 https://bugs.webkit.org/show_bug.cgi?id=132648
1855 Reviewed by Gyuyoung Kim.
1857 Script modified to enable MEDIA_STREAM for EFL build.
1859 * Scripts/webkitperl/FeatureList.pm:
1861 2014-05-08 David Farler <dfarler@apple.com>
1863 old-run-webkit-tests: update strings for simulator devices and app name
1864 https://bugs.webkit.org/show_bug.cgi?id=132687
1866 Reviewed by Darin Adler.
1868 iPhone Retina (4-inch) -> iPhone 5
1869 iPhone Retina (4-inch 64-bit) -> iPhone 5s
1871 * Scripts/old-run-webkit-tests:
1872 (installAndLaunchDumpToolAppUsingNotification):
1873 (openIPhoneSimulator):
1874 (quitIPhoneSimulator):
1875 quit iOS Simulator, not iPhone Simulator.
1877 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1879 REGRESSION(r168471): Update the builder names on the scheduler list.
1880 https://bugs.webkit.org/show_bug.cgi?id=132699
1882 Reviewed by Martin Robinson.
1884 On r168471 I missed to update the builder names for the GTK build
1885 bots on the AnyBranchScheduler type scheduler list of bots.
1887 * BuildSlaveSupport/build.webkit.org-config/config.json:
1889 2014-05-08 Brady Eidson <beidson@apple.com>
1891 "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1892 <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1894 Reviewed by Tim Horton.
1896 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1897 (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1899 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1901 REGRESSION(r168471): Duplicate builddirs broke the build master.
1902 https://bugs.webkit.org/show_bug.cgi?id=132688
1904 Reviewed by Carlos Garcia Campos.
1906 Rename the builddirs of the new GTK bots introduced on r168471 to
1907 be unique. Otherwise the master will break.
1909 * BuildSlaveSupport/build.webkit.org-config/config.json:
1911 2014-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
1913 [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1914 https://bugs.webkit.org/show_bug.cgi?id=132674
1916 Reviewed by Philippe Normand.
1918 Only ignore mkdir failure when exception is raised because the
1919 file already exists and it's a directory.
1924 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1926 [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1927 https://bugs.webkit.org/show_bug.cgi?id=131358
1929 Reviewed by Carlos Garcia Campos.
1931 Current 64-bit GTK build bots (Release and Debug) not only test
1932 the build, but run all tests. Split each one of the bots in
1933 BuildOnly and TestWebKit2.
1935 This will allow us to have a better overview of the status of
1938 Original patch from Sergio Villar Senin <svillar@igalia.com>
1940 * BuildSlaveSupport/build.webkit.org-config/config.json:
1941 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1942 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1944 * Scripts/webkitpy/port/builders.py:
1945 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1946 (TestRebaselineTest.test_baseline_directory):
1947 * TestResultServer/static-dashboards/builders.jsonp:
1948 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1950 * TestResultServer/static-dashboards/loader_unittests.js:
1952 2014-05-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1954 [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1955 https://bugs.webkit.org/show_bug.cgi?id=126022
1957 Reviewed by Benjamin Poulain.
1959 Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1961 Added an unit test case to check if scroll position and scale are restored properly.
1963 * TestWebKitAPI/PlatformEfl.cmake:
1964 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1965 (TestWebKitAPI::didFinishLoadForFrame):
1966 (TestWebKitAPI::didChangeContentsPosition):
1967 (TestWebKitAPI::TEST):
1968 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1969 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1971 2014-05-07 Simon Fraser <simon.fraser@apple.com>
1973 WebKit1 is flashy when compositing layers come and go
1974 https://bugs.webkit.org/show_bug.cgi?id=132655
1975 <rdar://problem/16830981&16788846>
1977 Reviewed by Sam Weinig.
1979 Revert the change from r166117.
1981 * DumpRenderTree/mac/DumpRenderTree.mm:
1984 2014-05-07 Chris Fleizach <cfleizach@apple.com>
1986 AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1987 https://bugs.webkit.org/show_bug.cgi?id=132622
1989 Reviewed by Mario Sanchez Prada.
1991 * DumpRenderTree/AccessibilityUIElement.cpp:
1992 (selectTextWithCriteriaCallback):
1994 * DumpRenderTree/AccessibilityUIElement.h:
1995 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1996 (AccessibilityUIElement::selectTextWithCriteria):
1997 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1998 (AccessibilityUIElement::selectTextWithCriteria):
1999 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2000 (selectTextParameterizedAttributeForCriteria):
2001 (AccessibilityUIElement::selectTextWithCriteria):
2002 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2003 (AccessibilityUIElement::selectTextWithCriteria):
2004 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2005 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2006 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2007 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2008 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2009 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2010 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2011 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2012 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2013 (WTR::selectTextParameterizedAttributeForCriteria):
2014 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2016 2014-05-07 Carlos Garcia Campos <cgarcia@igalia.com>
2018 [SOUP] TLSErrors do not cause page load to fail when not ignored
2019 https://bugs.webkit.org/show_bug.cgi?id=121548
2021 Reviewed by Sergio Villar Senin.
2023 Add unit tests to check that the load fails with TLS errors in
2024 case of a redirection.
2026 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2027 (testTLSErrorsRedirect):
2028 (httpsServerCallback):
2031 2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
2033 [CSS Grid Layout] Remove runtime feature
2034 https://bugs.webkit.org/show_bug.cgi?id=132382
2036 Reviewed by Benjamin Poulain.
2038 Remove cssGridLayoutEnabled setting usage.
2040 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2041 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2042 * DumpRenderTree/efl/TestRunnerEfl.cpp:
2043 (TestRunner::overridePreference):
2044 * DumpRenderTree/mac/DumpRenderTree.mm:
2045 (resetWebPreferencesToConsistentValues):
2047 2014-05-06 David Kilzer <ddkilzer@apple.com>
2049 Add Makefile targets for copying static libraries (LLVM and WKSI)
2050 <http://webkit.org/b/132619>
2052 Reviewed by Mark Rowe.
2054 * Scripts/copy-webkitlibraries-to-product-directory: Set a
2055 sensible default for product directory if not specified on
2056 either the command-line or in the environment (by Xcode) by
2057 calling productDir() in webkitdirs.pm.
2059 2014-05-06 Brady Eidson <beidson@apple.com>
2061 Add WK2 SPI to prevent the previous back/forward item from remaining in the list
2062 <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
2064 Reviewed by Sam Weinig.
2066 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2068 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
2069 (TestWebKitAPI::itemURLLastComponentIsString):
2070 (TestWebKitAPI::didFinishLoadForFrame):
2071 (TestWebKitAPI::willGoToBackForwardListItem):
2072 (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
2073 (TestWebKitAPI::setPageLoaderClient):
2074 (TestWebKitAPI::TEST):
2075 * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
2076 * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
2078 * WebKitTestRunner/TestController.cpp:
2079 (WTR::TestController::createWebViewWithOptions): Update for new client layout.
2081 2014-05-06 Darin Adler <darin@apple.com>
2083 Try to fix iOS build.
2085 * DumpRenderTree/mac/TestRunnerMac.mm:
2086 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
2087 Updated since I changed testRunner into a pointer instead of a reference.
2088 Updated argument names to avoid conflict with field names.
2089 (-[APITestDelegateIPhone run]): Ditto.
2090 (-[APITestDelegateIPhone _cleanUp]): Ditto.
2092 2014-05-06 Commit Queue <commit-queue@webkit.org>
2094 Unreviewed, rolling out r168304.
2095 https://bugs.webkit.org/show_bug.cgi?id=132607
2097 Broke the build (Requested by KaL on #webkit).
2101 "[GTK][CMake] Unable to do make install"
2102 https://bugs.webkit.org/show_bug.cgi?id=130188
2103 http://trac.webkit.org/changeset/168304
2105 2014-05-04 Darin Adler <darin@apple.com>
2107 RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
2108 https://bugs.webkit.org/show_bug.cgi?id=80222
2110 Reviewed by Alexey Proskuryakov.
2112 * DumpRenderTree/mac/TestRunnerMac.mm:
2113 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
2114 do more work here so we don't use RetainPtr local variables.
2115 (-[APITestDelegateIPhone dealloc]): Added.
2116 (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
2117 created. Updated for changes to member names and types.
2118 (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
2119 updated for changes to member names and types. Changed to two word spelling.
2120 (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
2121 name of _cleanUp method.
2122 (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
2124 (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
2126 2014-05-05 Benjamin Poulain <benjamin@webkit.org>
2128 Clean up Image Document and tweak the layout and viewport
2129 https://bugs.webkit.org/show_bug.cgi?id=132552
2131 Reviewed by Anders Carlsson.
2133 * DumpRenderTree/mac/DumpRenderTree.mm:
2134 (resetWebPreferencesToConsistentValues):
2135 Update the default settings to have something consistent with WebKit2.
2137 2014-05-05 Martin Robinson <mrobinson@igalia.com>
2139 [GTK][CMake] Unable to do make install
2140 https://bugs.webkit.org/show_bug.cgi?id=130188
2142 Reviewed by Carlos Garcia Campos.
2144 * Scripts/webkitdirs.pm:
2145 (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
2146 will give an early signal that a change has broken the documentation.
2148 2014-05-05 Pratik Solanki <psolanki@apple.com>
2150 Update framework locations in package-root
2151 https://bugs.webkit.org/show_bug.cgi?id=132571
2153 Reviewed by Simon Fraser.
2155 * Scripts/package-root:
2157 2014-05-05 Ryuan Choi <ryuan.choi@samsung.com>
2159 [EFL][WK2] Refactor favicon database APIs
2160 https://bugs.webkit.org/show_bug.cgi?id=132519
2162 Reviewed by Gyuyoung Kim.
2164 * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
2165 (update_view_favicon):
2166 (on_icon_changed_cb):
2170 (on_view_favicon_changed): Deleted.
2172 2014-05-02 Mark Rowe <mrowe@apple.com>
2174 <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
2176 Reviewed by Dan Bernstein.
2178 * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
2179 when determining which LLVM archive to extract.
2181 2014-05-02 Jeremy Jones <jeremyj@apple.com>
2183 Add Jeremy as a committer.
2184 https://bugs.webkit.org/show_bug.cgi?id=132492
2186 Reviewed by Jer Noble.
2188 Add myself as a committer.
2190 * Scripts/webkitpy/common/config/contributors.json:
2192 2014-05-02 Jeremy Jones <jeremyj@apple.com>
2194 Add Jeremy as a committer.
2195 https://bugs.webkit.org/show_bug.cgi?id=132492
2197 Reviewed by Jer Noble.
2199 Add Jeremy Jones to the committers file.
2201 * Scripts/webkitpy/common/config/contributors.json:
2203 2014-05-02 Brian J. Burg <burg@cs.washington.edu>
2205 Hard to figure out how to run a single test with run-api-tests
2206 https://bugs.webkit.org/show_bug.cgi?id=116332
2208 Reviewed by Alexey Proskuryakov.
2210 * Scripts/run-api-tests: add two examples to the help message.
2212 2014-05-02 Simon Fraser <simon.fraser@apple.com>
2214 Fix several memory leaks found by code inspection
2215 https://bugs.webkit.org/show_bug.cgi?id=132472
2217 Reviewed by Geoffrey Garen.
2221 * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2222 (TestWebKitAPI::TEST):
2223 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2224 (WTR::InjectedBundlePage::willSendRequestForFrame):
2225 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2226 (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2228 2014-05-02 Filip Pizlo <fpizlo@apple.com>
2230 DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2231 https://bugs.webkit.org/show_bug.cgi?id=132446
2233 Reviewed by Mark Hahnenberg.
2235 Test the FTL by default now that it's enabled by default.
2237 * Scripts/run-javascriptcore-tests:
2239 2014-05-01 Ryuan Choi <ryuan.choi@samsung.com>
2241 [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2242 https://bugs.webkit.org/show_bug.cgi?id=132240
2244 Reviewed by Anders Carlsson.
2246 Removed ewk_view_setting_tiled_backingstore related code.
2248 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2249 (DumpRenderTreeChrome::createView):
2250 (shouldUseTiledBackingStore): Deleted.
2251 * EWebLauncher/main.c:
2253 (parseUserArguments):
2255 2014-05-01 Anders Carlsson <andersca@apple.com>
2257 window.testRunner.keepWebHistory() should update the UI process state
2258 https://bugs.webkit.org/show_bug.cgi?id=132440
2260 Reviewed by Dan Bernstein.
2262 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2263 (WTR::InjectedBundle::postSetAddsVisitedLinks):
2264 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2265 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2266 (WTR::TestRunner::keepWebHistory):
2267 * WebKitTestRunner/TestInvocation.cpp:
2268 (WTR::TestInvocation::invoke):
2269 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2271 2014-05-01 David Kilzer <ddkilzer@apple.com>
2273 Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2274 <http://webkit.org/b/132432>
2276 Reviewed by Tim Horton.
2278 * Scripts/webkitperl/FeatureList.pm: Remove support for
2279 --plugin-proxy-for-video switch.
2281 2014-04-30 Carlos Alberto Lopez Perez <clopez@igalia.com>
2283 Kernel sysctl interface hw.activecpu don't exists on Linux.
2284 https://bugs.webkit.org/show_bug.cgi?id=132286
2286 Reviewed by Filip Pizlo.
2288 * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2289 calling sysctl over hw.activecpu
2291 2014-04-30 Anders Carlsson <andersca@apple.com>
2293 Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2294 https://bugs.webkit.org/show_bug.cgi?id=132399
2295 <rdar://problem/15920046>
2297 Reviewed by Dan Bernstein.
2299 * Scripts/check-for-webkit-framework-include-consistency:
2300 Allos WAK headers in WebKitLegacy as well as WebKit.
2302 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2303 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2304 Update header imports.
2306 2014-04-30 Simon Fraser <simon.fraser@apple.com>
2308 [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2309 https://bugs.webkit.org/show_bug.cgi?id=131954
2311 Reviewed by Darin Adler.
2313 WebKitTestRunner was adding application-specific information to crash reports
2314 to log the test path, but only in the web process. Fix it to also do this
2315 for the UI process, for both iOS and OS X.
2317 Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2320 Factored crash reprorter-related code into CrashReporterInfo, and call it from
2321 a new TestController::platformWillRunTest() function on Mac and iOS.
2323 Also remove Xcode-added unit test junk from the project.
2325 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2326 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2327 * WebKitTestRunner/TestController.cpp:
2328 (WTR::TestController::runTest):
2329 * WebKitTestRunner/TestController.h:
2330 * WebKitTestRunner/TestInvocation.cpp:
2331 (WTR::TestInvocation::url):
2332 * WebKitTestRunner/TestInvocation.h:
2333 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2334 * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2335 * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2336 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2337 * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2338 * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2339 (WTR::testPathFromURL):
2340 (WTR::setCrashReportApplicationSpecificInformationToURL):
2341 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2342 (WTR::TestController::platformWillRunTest):
2343 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2344 (WTR::TestController::platformWillRunTest):
2345 * WebKitTestRunner/ios/TestControllerIOS.mm:
2346 (WTR::TestController::platformWillRunTest):
2347 (WTR::TestController::setHidden):
2348 * WebKitTestRunner/mac/TestControllerMac.mm:
2349 (WTR::TestController::platformWillRunTest):
2351 2014-04-30 Simon Fraser <simon.fraser@apple.com>
2353 Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2355 Reviewed by Tim Horton.
2357 * DumpRenderTree/mac/DumpRenderTree.mm:
2358 (resetWebPreferencesToConsistentValues):
2359 (prepareConsistentTestingEnvironment):
2361 2014-04-30 Anders Carlsson <andersca@apple.com>
2363 check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2364 https://bugs.webkit.org/show_bug.cgi?id=132397
2366 Reviewed by Dan Bernstein.
2368 * Scripts/check-for-inappropriate-macros-in-external-headers:
2370 2014-04-29 Martin Robinson <mrobinson@igalia.com>
2372 [GTK] Make it easier to run CMake for downstreams
2373 https://bugs.webkit.org/show_bug.cgi?id=132370
2375 Reviewed by Carlos Garcia Campos.
2377 * Scripts/webkitdirs.pm:
2378 (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2381 2014-04-29 Stephanie Lewis <slewis@apple.com>
2383 <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2385 Rubber stamped by Jessie Berlin.
2387 JSON.pm was removed from our tools setup.
2389 * Scripts/generate-coverage-data:
2391 2014-04-29 Filip Pizlo <fpizlo@apple.com>
2393 Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2394 https://bugs.webkit.org/show_bug.cgi?id=112840
2396 Rubber stamped by Geoffrey Garen.
2398 * Scripts/build-jsc: Enable it on Mac.
2399 * Scripts/build-webkit: Enable it on Mac.
2400 * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2402 2014-04-28 Sam Weinig <sam@webkit.org>
2404 REGRESSION (r167751): svn-create-patch is very slow
2405 https://bugs.webkit.org/show_bug.cgi?id=132300
2407 Reviewed by Alexey Proskuryakov.
2409 * Scripts/svn-create-patch:
2410 Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2411 by calling `svn-create-patch --style`.
2413 2014-04-29 Enrique Ocaña González <eocanha@igalia.com>
2415 Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2416 https://bugs.webkit.org/show_bug.cgi?id=132190
2418 Reviewed by Gustavo Noronha Silva.
2420 * Scripts/webkitdirs.pm:
2421 (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2422 if ninja is in the path.
2423 (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2424 to the previous ninja generator if not.
2426 2014-04-29 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
2428 check-webkit-style should understand --git-index
2429 https://bugs.webkit.org/show_bug.cgi?id=125364
2431 Reviewed by Csaba Osztrogonác.
2433 * Scripts/webkitpy/common/checkout/scm/git.py:
2434 (Git.create_patch): The command now supports the --cached option.
2435 * Scripts/webkitpy/style/main.py:
2436 (CheckWebKitStyle.main): Passing the --git-index option.
2437 * Scripts/webkitpy/style/optparser.py:
2438 (CommandOptionValues.__init__): The git-index option is switched off by default.
2439 (CommandOptionValues.__eq__): Equality check for the new option.
2440 (ArgumentParser._create_option_parser):Adding the --git-index option
2441 (ArgumentParser.parse):
2442 * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2443 (CommandOptionValuesTest.test_init):
2444 (CommandOptionValuesTest.test_eq):
2446 2014-04-28 Michael Saboff <msaboff@apple.com>
2448 Crash in platform/mac/accessibility/table-visible-rows.html
2449 https://bugs.webkit.org/show_bug.cgi?id=132146
2451 Reviewed by Filip Pizlo.
2453 Instead of creating a local JSValueRef array on the stack and passing that to
2454 JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2455 values using the JSObjectSetPropertyAtIndex() API.
2457 * DumpRenderTree/AccessibilityUIElement.cpp:
2458 (elementsForRangeCallback):
2459 (convertElementsToObjectArray):
2460 * DumpRenderTree/mac/TestRunnerMac.mm:
2462 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2463 (WTR::EventSendingController::contextClick):
2464 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2465 (WTR::stringArrayToJS):
2466 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2467 (WTR::convertElementsToObjectArray):
2469 2014-04-28 Filip Pizlo <fpizlo@apple.com>
2471 Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2472 "no-cjit" runs force the old-school threshold.
2474 Rubber stamped by Mark Hahnenberg.
2476 * Scripts/run-jsc-stress-tests:
2478 2014-04-28 Carlos Alberto Lopez Perez <clopez@igalia.com>
2480 [GTK] install-dependencies should also install ruby-json and ruby-highline
2481 https://bugs.webkit.org/show_bug.cgi?id=132292
2483 Reviewed by Philippe Normand.
2485 * gtk/install-dependencies: Install ruby json and highline packages.
2487 2014-04-27 Joonghun Park <jh718.park@samsung.com>
2489 [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2490 https://bugs.webkit.org/show_bug.cgi?id=132176
2492 Reviewed by Gyuyoung Kim.
2494 EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2495 and turn off indexedDB feature until the sqlite implementation is introduced.
2497 * Scripts/webkitperl/FeatureList.pm:
2499 2014-04-25 James Craig <jcraig@apple.com>
2501 Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2502 https://bugs.webkit.org/show_bug.cgi?id=132209
2504 Reviewed by Daniel Bates.
2506 Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2507 Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2509 * Scripts/prepare-ChangeLog:
2512 2014-04-25 Michael Saboff <msaboff@apple.com>
2514 Crash in platform/mac/accessibility/table-visible-rows.html
2515 https://bugs.webkit.org/show_bug.cgi?id=132146
2517 Reviewed by Mark Lam.
2519 Changed to use a local JSValueRef array temporary instead of a
2520 std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2521 JSValues are visited during garbage collection when the stack is scanned. Otherwise,
2522 the temporary values could be collected.
2524 * DumpRenderTree/AccessibilityUIElement.cpp:
2525 (convertElementsToObjectArray):
2526 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2527 (WTR::EventSendingController::contextClick):
2528 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2529 (WTR::convertElementsToObjectArray):
2531 2014-04-24 Eduardo Lima Mitev <elima@igalia.com>
2533 Unreviewed GTK gardening
2535 * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2538 2014-04-24 László Langó <llango.u-szeged@partner.samsung.com>
2540 prepare-ChangeLog reports as deleted methods that has not been removed.
2541 https://bugs.webkit.org/show_bug.cgi?id=131733
2543 Reviewed by Ryosuke Niwa.
2545 * Scripts/prepare-ChangeLog:
2546 (originalFile): Set merge base to origin/master by default.
2548 2014-04-23 James Craig <jcraig@apple.com>
2550 prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2551 https://bugs.webkit.org/show_bug.cgi?id=131115
2553 Reviewed by Daniel Bates.
2555 Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2557 * Scripts/commit-log-editor: Added --no-style.
2558 * Scripts/prepare-ChangeLog: Primary patch.
2559 (main): Primary patch.
2560 (createPatchCommand): Added --no-style.
2561 * Scripts/svn-create-patch: Primary patch.
2562 * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2563 * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2564 (SVN.create_patch): Added --no-style.
2566 2014-04-23 Anders Carlsson <andersca@apple.com>
2568 Try to fix iOS build.
2570 * DumpRenderTree/mac/DumpRenderTree.mm:
2572 2014-04-23 Alexey Proskuryakov <ap@apple.com>
2574 Eliminate internals.setMockScrollbarsEnabled()
2575 https://bugs.webkit.org/show_bug.cgi?id=132085
2577 Reviewed by Tim Horton.
2579 * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2580 No need to reset the preference, there is no way it can change.
2582 2014-04-23 James Craig <jcraig@apple.com>
2584 Unreviewed. Moving myself from Contributors to Committers list.
2586 * Scripts/webkitpy/common/config/contributors.json:
2588 2014-04-23 Tim Horton <timothy_horton@apple.com>
2590 Mock scrollbars don't always work in DumpRenderTree
2591 https://bugs.webkit.org/show_bug.cgi?id=132082
2593 Reviewed by Alexey Proskuryakov.
2595 * DumpRenderTree/mac/DumpRenderTree.mm:
2596 (prepareConsistentTestingEnvironment):
2597 Set the mock scrollbar setting before creating the WebView, as this setting
2598 cannot be dynamically changed, so any scrollbars that are created during
2599 WebView initialization and are not replaced before snapshotting will end
2600 up being platform scrollbars instead of mock ones.
2601 WebKitTestRunner already sets this preference before creating WKViews,
2602 so we're just matching its behavior.
2604 2014-04-23 Carlos Garcia Campos <cgarcia@igalia.com>
2606 [GTK] ShadowRoot API was removed in r164131
2607 https://bugs.webkit.org/show_bug.cgi?id=132059
2609 Reviewed by Gustavo Noronha Silva.
2611 Add WebKitDOMShadowRoot to the list of deleted classes to generate
2615 (WebKitDOMDocGenerator):
2617 2014-04-23 Lorenzo Tilve <ltilve@igalia.com>
2619 [GTK] run-webkit-tests script is failing to invoke run-launcher
2620 https://bugs.webkit.org/show_bug.cgi?id=132051
2622 Reviewed by Philippe Normand.
2624 After the WK1 support was dropped, if run-webkit-tests is executed
2625 without --no-show-results parameter, the launcher is being called
2626 using a -2 parameter that is it causing the run-launcher to break.
2628 * Scripts/webkitpy/port/gtk.py:
2629 (GtkPort.show_results_html_file):
2631 2014-04-22 Tim Horton <timothy_horton@apple.com>
2633 DumpRenderTree generates black snapshots on some platforms
2634 https://bugs.webkit.org/show_bug.cgi?id=132029
2635 <rdar://problem/16679363>
2637 Reviewed by Simon Fraser.
2639 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2640 (createBitmapContextFromWebView):
2641 DRT checks with the WebView to determine whether it can use the window's
2642 backing store directly or (because of compositing) needs to take a WindowServer
2643 snapshot. However, on some platforms and in some situations, the window can
2644 be layer backed without the WebView necessarily currently being composited.
2645 We should check with the window in addition to the WebView before going
2646 ahead and using its backing store.
2648 2014-04-22 Tim Horton <timothy_horton@apple.com>
2650 DumpRenderTree generates white snapshots on some platforms
2651 https://bugs.webkit.org/show_bug.cgi?id=132026
2652 <rdar://problem/16679363>
2654 Reviewed by Simon Fraser.
2656 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2657 Link DRT against QuartzCore.
2659 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2660 (createBitmapContextFromWebView):
2661 Force CoreAnimation to synchronously update layers in a more explicit
2662 way that doesn't depend on AppKit behavior. This is very similar to what
2663 WebKitTestRunner does (indirectly) during its force repaint.
2665 2014-04-22 Brent Fulgham <bfulgham@apple.com>
2667 [Win] Support Python 2.7 in Cygwin
2668 https://bugs.webkit.org/show_bug.cgi?id=132023
2670 Reviewed by Michael Saboff.
2672 * Scripts/webkitdirs.pm:
2673 (checkInstalledTools): Remove check for Python 2.7, since
2674 it now works properly.
2676 2014-04-22 Filip Pizlo <fpizlo@apple.com>
2678 Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2679 https://bugs.webkit.org/show_bug.cgi?id=130867
2680 <rdar://problem/16432456>
2682 Reviewed by Mark Hahnenberg.
2684 * Scripts/build-webkit:
2685 * Scripts/copy-webkitlibraries-to-product-directory:
2687 2014-04-22 Gustavo Noronha Silva <gns@gnome.org>
2689 [GTK] Fails to build documentation when output is redirected
2690 https://bugs.webkit.org/show_bug.cgi?id=131178
2692 Reviewed by Martin Robinson.
2694 * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2695 explicitly to avoid encoding issues when they are redirected.
2697 2014-04-22 ChangSeok Oh <changseok.oh@collabora.com>
2699 [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2700 https://bugs.webkit.org/show_bug.cgi?id=131911
2702 Reviewed by Martin Robinson.
2704 common.get_build_path returns release path even though Debug configuration
2705 is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2707 * gtk/ycm_extra_conf.py:
2708 (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2711 2014-04-21 Brent Fulgham <bfulgham@apple.com>
2713 Unreviewed build fix.
2715 * DumpRenderTree/mac/EventSendingController.mm:
2716 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2717 Correct a typo that prevented tests from working properly.
2719 2014-04-21 Martin Robinson <mrobinson@igalia.com>
2721 [GTK] Should have the ability to output composited contents during layout testing
2722 https://bugs.webkit.org/show_bug.cgi?id=131864
2724 Reviewed by Philippe Normand.
2726 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2727 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2728 to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2729 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2730 (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2732 2014-04-21 Sam Weinig <sam@webkit.org>
2734 Attempt to fix the tests.
2736 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2737 (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2738 Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2740 2014-04-21 Filip Pizlo <fpizlo@apple.com>
2742 Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2743 being the same as a "quick run", which is meant for genuinely slow tests).
2745 * Scripts/run-jsc-stress-tests:
2747 2014-04-21 Darin Adler <darin@apple.com>
2749 Add HashSet::takeAny
2750 https://bugs.webkit.org/show_bug.cgi?id=131928
2752 Reviewed by Benjamin Poulain.
2754 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2756 2014-04-20 Dan Bernstein <mitz@apple.com>
2758 Fixed a test timing out after r167572.
2760 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2761 (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2762 -webView:didFinishLoadingNavigation:.
2764 2014-04-20 Commit Queue <commit-queue@webkit.org>
2766 Unreviewed, rolling out r167510.
2767 https://bugs.webkit.org/show_bug.cgi?id=131915
2769 broke GTK Debug bot (Requested by philn on #webkit).
2773 "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2774 it when running layout tests"
2775 https://bugs.webkit.org/show_bug.cgi?id=131472
2776 http://trac.webkit.org/changeset/167510
2778 2014-04-18 Martin Robinson <mrobinson@igalia.com>
2780 [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2781 https://bugs.webkit.org/show_bug.cgi?id=131472
2783 Reviewed by Philippe Normand.
2785 * Scripts/webkitpy/port/gtk.py:
2786 (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2787 when running WebKitTestRunner with run-webkit-tests.
2788 * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2790 * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2791 how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2792 calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2795 2014-04-18 Alexey Proskuryakov <ap@apple.com>
2797 DownloadDecideDestinationCrash API test uses an incorrect value for path
2798 https://bugs.webkit.org/show_bug.cgi?id=131845
2799 <rdar://problem/15925560>
2801 Reviewed by Enrica Casucci.
2803 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2804 (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2806 2014-04-17 Alexey Proskuryakov <ap@apple.com>
2808 [Mac] AttributedStringTest API tests fail with async text input
2809 https://bugs.webkit.org/show_bug.cgi?id=131833
2811 Reviewed by Enrica Casucci.
2813 Don't run sync NSTextInputClient tests where we don't implement these calls.
2815 * TestWebKitAPI/Tests/mac/AttributedString.mm:
2816 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2817 (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2818 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2819 (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2820 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2821 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2823 2014-04-18 Philippe Normand <pnormand@igalia.com>
2825 Remove NETWORK_INFO support
2826 https://bugs.webkit.org/show_bug.cgi?id=131841
2828 Reviewed by Gyuyoung Kim.
2830 * Scripts/webkitperl/FeatureList.pm:
2832 2014-04-17 ChangSeok Oh <changseok.oh@collabora.com>
2834 [GTK] YouCompleteMe doesn't work for cmake build system.
2835 https://bugs.webkit.org/show_bug.cgi?id=131591
2837 Reviewed by Martin Robinson.
2839 Add cmake build system support for YouCompleteMe. It should work regardless of
2840 using make or ninja. In addition, autotools related code is removed since it's
2841 not used anymore in WebKit.
2843 * Scripts/webkitdirs.pm:
2844 (generateBuildSystemFromCMakeProject):
2845 * gtk/ycm_extra_conf.py:
2846 (transform_relative_paths_to_absolute_paths):
2849 2014-04-17 Anders Carlsson <andersca@apple.com>
2853 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2854 (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2855 (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2857 2014-04-17 Anders Carlsson <andersca@apple.com>
2859 Remove unused API enums
2860 https://bugs.webkit.org/show_bug.cgi?id=131836
2862 Reviewed by Tim Horton.
2864 * MiniBrowser/mac/WK2BrowserWindowController.m:
2865 (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2867 2014-04-16 Brent Fulgham <bfulgham@apple.com>
2869 [Win] A few final cleanups to the DataObject classes.
2870 https://bugs.webkit.org/show_bug.cgi?id=131784
2872 Reviewed by Anders Carlsson.
2874 * DumpRenderTree/win/DRTDataObject.cpp:
2875 (DRTDataObject::clearData): Use 'last()' method.
2876 * DumpRenderTree/win/UIDelegate.cpp:
2877 (DRTUndoStack::pop): Use 'takeLast()' method.
2879 2014-04-17 Andres Gomez <agomez@igalia.com>
2881 [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2882 https://bugs.webkit.org/show_bug.cgi?id=131365
2884 Reviewed by Brent Fulgham.
2886 The cygwin installer is now downloading the wanted versions for
2887 the local installation given to the setup wizard.
2889 * CygwinDownloader/cygwin-downloader.py:
2890 * CygwinDownloader/cygwin-downloader.zip:
2892 2014-04-17 Adrian Perez de Castro <aperez@igalia.com>
2894 [GTK] Make run-webkit-tests always use WKTR
2895 https://bugs.webkit.org/show_bug.cgi?id=131737
2897 Reviewed by Darin Adler.
2899 Now that the GTK+ port only has support for WebKit2, instruct
2900 run-webkit-tests to always use WKTR. This avoids needing to pass
2901 flag "-2" every time.
2903 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2904 (_set_up_derived_options): Always set webkit_test_runner when
2905 the platform is GTK+.
2907 2014-04-17 Brendan Long <b.long@cablelabs.com>
2909 [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2910 https://bugs.webkit.org/show_bug.cgi?id=131760
2912 Reviewed by Philippe Normand.
2914 * gtk/install-dependencies: Install ninja-build when it's available.
2916 2014-04-16 peavo@outlook.com <peavo@outlook.com>
2918 [Win] run-javascriptcore-tests fails to run.
2919 https://bugs.webkit.org/show_bug.cgi?id=131761
2921 Reviewed by Brent Fulgham.
2923 * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2925 2014-04-16 Andres Gomez <agomez@igalia.com>
2927 [Win] Pass default parameters to cygwin setup wizard
2928 https://bugs.webkit.org/show_bug.cgi?id=131361
2930 Reviewed by Brent Fulgham.
2932 Added some parameters to the cygwin setup wizard so the user
2933 doesn't really have to do any interaction.
2935 * CygwinDownloader/cygwin-downloader.py:
2936 * CygwinDownloader/cygwin-downloader.zip:
2938 2014-04-15 Brent Fulgham <bfulgham@apple.com>
2940 [Win] Eliminate use of deleteAllValues in Windows Files
2941 https://bugs.webkit.org/show_bug.cgi?id=131631
2943 Reviewed by Darin Adler.
2945 Switch to std::unique_ptr for memory lifetime. Get rid of
2946 deleteAllValues now that it is no longer needed. Use ranged
2947 for loops where possible.
2949 * DumpRenderTree/win/DRTDataObject.cpp:
2950 (WCEnumFormatEtc::WCEnumFormatEtc):
2951 (DRTDataObject::~DRTDataObject):
2952 (DRTDataObject::GetData):
2953 (DRTDataObject::QueryGetData):
2954 (DRTDataObject::SetData):
2955 (DRTDataObject::clearData):
2956 * DumpRenderTree/win/DRTDataObject.h:
2957 * DumpRenderTree/win/UIDelegate.cpp:
2958 (DRTUndoObject::DRTUndoObject):
2959 (DRTUndoObject::~DRTUndoObject):
2960 (DRTUndoStack::~DRTUndoStack):
2961 (DRTUndoStack::clear):
2962 (DRTUndoStack::pop):
2963 (DRTUndoManager::DRTUndoManager):
2964 (DRTUndoManager::redo):
2965 (DRTUndoManager::undo):
2966 (UIDelegate::UIDelegate):
2967 (UIDelegate::resetUndoManager):
2968 * DumpRenderTree/win/UIDelegate.h:
2970 2014-04-16 Carlos Alberto Lopez Perez <clopez@igalia.com>
2972 [GTK] Unreviewed GTK gardening.
2974 Update list of skipped unit tests:
2976 Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2978 Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2979 and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2981 * Scripts/run-gtk-tests:
2984 2014-04-16 Tim Horton <timothy_horton@apple.com>
2986 check-webkit-style doesn't check code style in .mm or .m files
2987 https://bugs.webkit.org/show_bug.cgi?id=131708
2989 Reviewed by Darin Adler.
2991 * Scripts/webkitpy/style/checker.py:
2992 * Scripts/webkitpy/style/checker_unittest.py:
2993 (CheckerDispatcherDispatchTest.test_cpp_paths):
2994 (CheckerDispatcherDispatchTest.test_text_paths):
2995 Check .mm and .m files as C++.
2997 * Scripts/webkitpy/style/checkers/cpp.py:
2999 Add an override for our ordinary "missing spaces around =" for @synthesize,
3000 which should look like "@synthesize propertyName=_varName;"
3002 Add an override for "missing space before {" for blocks' "^{".
3004 Don't follow the "extra space before [" rule for Objective-C, because
3005 it breaks this rule in a multitude of ways because of method calls.
3008 Don't complain about { not being on the end of the previous line if
3009 the previous line starts with "- (" or "+ (", which would indicate a
3010 Objective-C method definition.
3012 2014-04-16 Darin Adler <darin@apple.com>
3014 Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
3015 https://bugs.webkit.org/show_bug.cgi?id=131735
3017 Reviewed by Alexey Proskuryakov.
3019 * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
3020 Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
3021 is on the right. This can be confusing since our JavaScript test framework does it the opposite
3022 way, but gtest works better this way.
3024 2014-04-15 Hyowon Kim <hw1008.kim@samsung.com>
3026 [EFL] Fix problems with the pixel dump.
3027 https://bugs.webkit.org/show_bug.cgi?id=131265
3029 Reviewed by Gyuyoung Kim.
3031 Painting and compositing paths of WebKit-EFL were totally modified from r166768.
3032 However pixel dump codes still call deprecated functions like ewk_view_paint(),
3033 which causes that nothing is drawn.
3035 This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
3036 One of new functions is AcceleratedCompositingContext::extractImageData(),
3037 which replaces deprecated function calls. Besides the extractImageData() is invoked by
3038 ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
3040 * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3041 (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
3043 2014-04-15 Filip Pizlo <fpizlo@apple.com>
3045 Update LLVM export scrpt to handle the build directory being different from the
3048 Rubber stamped by Geoffrey Garen.
3050 * Scripts/export-llvm-build:
3052 2014-04-15 Ryosuke Niwa <rniwa@webkit.org>
3054 Update the hyperlink to waterfall views of perf bots on build.webkit.org
3055 https://bugs.webkit.org/show_bug.cgi?id=131695
3057 Reviewed by Antti Koivisto.
3061 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3063 2014-04-15 Carlos Garcia Campos <cgarcia@igalia.com>
3065 [GTK] Reduce the binary size by compressing the text based web inspector resources
3066 https://bugs.webkit.org/show_bug.cgi?id=121545
3068 Reviewed by Gustavo Noronha Silva.
3070 Compress text based files when compiling inspector resources. It
3071 reduces the binary size in 3MB.
3073 * gtk/generate-inspector-gresource-manifest.py:
3074 (find_all_files_in_directory):
3077 2014-04-14 Alexey Proskuryakov <ap@apple.com>
3079 Remove Gtk WebKit1 tester.
3081 Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
3082 results over and over as fast as it could.
3084 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3087 2014-04-14 Alexey Proskuryakov <ap@apple.com>
3089 Wrong link for webkitpy tests results in dashboard popover
3090 https://bugs.webkit.org/show_bug.cgi?id=131664
3092 Reviewed by Timothy Hatcher.
3094 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3095 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3098 2014-04-14 Alexey Proskuryakov <ap@apple.com>
3100 Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
3102 I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
3104 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3105 (CommitMessageForThisCommitTest):
3107 2014-04-14 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
3109 Fix commit-log-editor bug revealed by r165447
3110 https://bugs.webkit.org/show_bug.cgi?id=130676
3112 Reviewed by Csaba Osztrogonác.
3114 * Scripts/commit-log-editor:
3115 (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
3116 Add \n before the first block too, because the longest common prefix now ends with only one newline.
3117 (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
3118 now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
3120 2014-04-13 Darin Adler <darin@apple.com>
3122 userVisibleString should not try to "encode" host names
3123 https://bugs.webkit.org/show_bug.cgi?id=131587
3124 rdar://problem/14686849
3126 Reviewed by Alexey Proskuryakov.
3128 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
3130 * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
3131 Coverage is tiny at this point; we could add a lot more cases!
3133 2014-04-13 Jaehun Lim <ljaehun.lim@samsung.com>
3135 Use #include instead of #import
3136 https://bugs.webkit.org/show_bug.cgi?id=131604
3138 Reviewed by Darin Adler.
3140 Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
3142 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3144 2014-04-12 Filip Pizlo <fpizlo@apple.com>
3146 Make slow-stress tests run faster by running fewer VM variants.
3148 Rubber stamped by Geoffrey Garen.
3150 * Scripts/run-javascriptcore-tests:
3151 * Scripts/run-jsc-stress-tests:
3153 2014-04-10 Zan Dobersek <zdobersek@igalia.com>
3155 [CMake] Add missing WTF unit tests
3156 https://bugs.webkit.org/show_bug.cgi?id=131459
3158 Reviewed by Martin Robinson.
3160 * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
3161 that should be compiled into the TestWTF binary.
3163 2014-04-10 Brendan Long <b.long@cablelabs.com>
3165 [Gtk] run-launcher doesn't work by default
3166 https://bugs.webkit.org/show_bug.cgi?id=131494
3168 Reviewed by Philippe Normand.
3170 * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
3171 * Scripts/webkitdirs.pm:
3172 (launcherName): Same.
3173 * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
3175 (get_build_path.is_valid_build_directory): Same.
3176 * gtk/manifest.txt: Same.
3178 2014-04-09 Commit Queue <commit-queue@webkit.org>
3180 Unreviewed, rolling out r167046.
3181 https://bugs.webkit.org/show_bug.cgi?id=131479
3183 Caused 300+ failures on Mavericks WK1 tester (Requested by ap
3188 "Remove "System Font" from whitelisted DRT fonts and char
3190 https://bugs.webkit.org/show_bug.cgi?id=131411
3191 http://trac.webkit.org/changeset/167046
3193 2014-04-09 Myles C. Maxfield <mmaxfield@apple.com>
3195 Remove "System Font" from whitelisted DRT fonts and char width calculations
3196 https://bugs.webkit.org/show_bug.cgi?id=131411
3198 Reviewed by Tim Horton.
3200 Covered by existing tests.
3202 * DumpRenderTree/mac/DumpRenderTree.mm:
3203 (allowedFontFamilySet):
3205 2014-04-09 Myles C. Maxfield <mmaxfield@apple.com>
3207 systemHiddenFontFamilySet in DRT is unnecessary
3208 https://bugs.webkit.org/show_bug.cgi?id=131414
3210 Reviewed by Tim Horton.
3212 It doesn't seem to affect test results on my machine.
3214 * DumpRenderTree/mac/DumpRenderTree.mm:
3215 (drt_NSFontManager_availableFonts):
3216 (systemHiddenFontFamilySet): Deleted.
3218 2014-04-09 Brent Fulgham <bfulgham@apple.com>
3220 [Win] Unreviewed test fix: Don't double-release BSTR.
3222 * DumpRenderTree/win/DumpRenderTree.cpp:
3223 (dump): Remove unneeded call to SysFreeString now that we are
3224 using _bstr_t for this variable.
3226 2014-04-09 Brent Fulgham <bfulgham@apple.com>
3228 [Win] Various DumpRenderTree Fixes.
3229 https://bugs.webkit.org/show_bug.cgi?id=131446.
3231 Reviewed by Tim Horton.
3233 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3234 (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3235 (AccessibilityUIElement::description): Ditto.
3236 (AccessibilityUIElement::helpText): Ditto.
3237 (AccessibilityUIElement::intValue): Ditto.
3238 (AccessibilityUIElement::isPressActionSupported): Ditto.
3239 (AccessibilityUIElement::accessibilityValue): Ditto.
3240 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3241 (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3242 (DRTDesktopNotificationPresenter::AddRef): Ditto.
3243 (DRTDesktopNotificationPresenter::Release): Ditto.
3244 (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3245 (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3246 (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3247 (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3248 (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3249 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3250 * DumpRenderTree/win/DumpRenderTree.cpp:
3251 (dumpFrameScrollPosition): Ditto.
3252 (dumpFramesAsText): Ditto.
3253 (compareHistoryItems): Ditto.
3254 (dumpHistoryItem): Ditto.
3256 (resetDefaultsToConsistentValues): Ditto.
3257 (resetWebViewToConsistentStateBeforeTesting): Ditto.
3259 (createWebViewAndOffscreenWindow): Ditto.
3260 * DumpRenderTree/win/EditingDelegate.cpp:
3261 (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3262 (EditingDelegate::AddRef): Ditto.
3263 (EditingDelegate::Release): Ditto.
3264 (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3265 (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3266 (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3267 (EditingDelegate::shouldInsertNode): Ditto.
3268 (EditingDelegate::shouldInsertText): Ditto.
3269 (EditingDelegate::shouldDeleteDOMRange): Ditto.
3270 (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3271 (EditingDelegate::shouldApplyStyle): Ditto.
3272 (EditingDelegate::shouldChangeTypingStyle): Ditto.
3273 (EditingDelegate::doPlatformCommand): Ditto.
3274 (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3275 (EditingDelegate::webViewDidChange): Ditto.
3276 (EditingDelegate::webViewDidEndEditing): Ditto.
3277 (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3278 (EditingDelegate::webViewDidChangeSelection): Ditto.
3279 (EditingDelegate::checkSpellingOfString): Ditto.
3280 * DumpRenderTree/win/FrameLoadDelegate.cpp:
3281 (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3282 (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3283 (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3284 (FrameLoadDelegate::AddRef): Ditto.
3285 (FrameLoadDelegate::Release): Ditto.
3286 (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3287 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3288 (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3289 (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3290 (FrameLoadDelegate::didReceiveTitle): Ditto.
3291 (FrameLoadDelegate::didChangeIcons): Ditto.
3292 (delegatesWithDelayedWork): Ditto.
3293 (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3294 (FrameLoadDelegate::didFailLoadWithError): Ditto.
3295 (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3296 (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3297 (FrameLoadDelegate::willCloseFrame): Ditto.
3298 (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3299 (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3300 (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3301 (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3302 (FrameLoadDelegate::didRunInsecureContent): Ditto.
3303 * DumpRenderTree/win/FrameLoadDelegate.h:
3304 * DumpRenderTree/win/HistoryDelegate.cpp:
3305 (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3306 (HistoryDelegate::updateHistoryTitle): Ditto.
3307 (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3308 * DumpRenderTree/win/PolicyDelegate.cpp:
3310 (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3311 (PolicyDelegate::AddRef): Ditto.
3312 (PolicyDelegate::Release): Ditto.
3313 (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3314 (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3315 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3316 (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3317 (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3318 (ResourceLoadDelegate::AddRef): Ditto.
3319 (ResourceLoadDelegate::Release): Ditto.
3320 (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3321 (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3322 (ResourceLoadDelegate::willSendRequest): Ditto.
3323 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3324 (ResourceLoadDelegate::didReceiveResponse): Ditto.
3325 (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3326 (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3327 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3328 (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3329 (TestRunner::setUserStyleSheetLocation): Ditto.
3330 (TestRunner::execCommand): Ditto.
3331 (TestRunner::overridePreference): Ditto.
3332 (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3333 * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3334 (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3335 (TextInputController::insertText): Ditto.
3336 * DumpRenderTree/win/UIDelegate.cpp:
3337 (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3338 (UIDelegate::AddRef): Ditto.
3339 (UIDelegate::Release): Ditto.
3340 (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3341 (UIDelegate::trackCustomPopupMenu): Ditto.
3342 (UIDelegate::registerUndoWithTarget): Ditto.
3343 (UIDelegate::removeAllActionsWithTarget): Ditto.
3344 (UIDelegate::setActionTitle): Ditto.
3345 (UIDelegate::undo): Ditto.
3346 (UIDelegate::redo): Ditto.
3347 (UIDelegate::canUndo): Ditto.
3348 (UIDelegate::canRedo): Ditto.
3349 (UIDelegate::printFrame): Ditto.
3350 (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3351 (UIDelegate::webViewHeaderHeight): Ditto.
3352 (UIDelegate::webViewFooterHeight): Ditto.
3353 (UIDelegate::drawHeaderInRect): Ditto.
3354 (UIDelegate::drawFooterInRect): Ditto.
3355 (UIDelegate::webViewPrintingMarginRect): Ditto.
3356 (UIDelegate::canRunModal): Ditto.
3357 (UIDelegate::createModalDialog): Ditto.
3358 (UIDelegate::runModal): Ditto.
3359 (UIDelegate::isMenuBarVisible): Ditto.
3360 (UIDelegate::setMenuBarVisible): Ditto.
3361 (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3362 (UIDelegate::paintCustomScrollbar): Ditto.
3363 (UIDelegate::paintCustomScrollCorner): Ditto.
3364 (UIDelegate::setFrame): Ditto.
3365 (UIDelegate::webViewFrame): Ditto.
3366 (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3367 (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3368 (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3369 (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3370 (UIDelegate::webViewAddMessageToConsole): Ditto.
3371 (UIDelegate::doDragDrop): Ditto.
3372 (UIDelegate::webViewGetDlgCode): Ditto.
3373 (UIDelegate::createWebViewWithRequest): Ditto.
3374 (UIDelegate::webViewClose): Ditto.
3375 (UIDelegate::webViewFocus): Ditto.
3376 (UIDelegate::webViewUnfocus): Ditto.
3377 (UIDelegate::webViewPainted): Ditto.
3378 (UIDelegate::exceededDatabaseQuota): Ditto.
3379 (UIDelegate::embeddedViewWithArguments): Ditto.
3380 (UIDelegate::webViewClosing): Ditto.
3381 (UIDelegate::webViewSetCursor): Ditto.
3382 (UIDelegate::webViewDidInvalidate): Ditto.
3383 (UIDelegate::setStatusText): Ditto.
3384 (UIDelegate::desktopNotificationsDelegate): Ditto.
3385 (UIDelegate::drawBackground): Ditto.
3386 (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3387 (UIDelegate::didPressMissingPluginButton): Ditto.
3388 * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3389 (LoadItem::invoke): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3390 (LoadHTMLStringItem::invoke): Ditto.
3391 (ScriptItem::invoke): Ditto.
3393 2014-04-09 Gergo Balogh <gbalogh.u-szeged@partner.samsung.com>
3395 Stylechecker: False positive on inline asm code.
3396 https://bugs.webkit.org/show_bug.cgi?id=130570
3398 Reviewed by Csaba Osztrogonác.
3400 Disable stylechecking in asm blocks.
3402 * Scripts/webkitpy/style/checkers/cpp.py:
3405 (_InlineASMState.__init__):
3406 (_InlineASMState.process_line):
3407 (_InlineASMState.isInside):
3409 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3410 (WebKitStyleTest.test_member_initialization_list):
3412 2014-04-09 Carlos Garcia Campos <cgarcia@igalia.com>
3414 [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3415 https://bugs.webkit.org/show_bug.cgi?id=131029
3417 Reviewed by Philippe Normand.
3419 Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3420 tests and remove the getWebKit1TestResoucesDir() method.
3422 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3423 (testDownloadLocalFile): Use Test::getResourcesDir().
3424 (testDownloadLocalFileError): Ditto.
3425 (serverCallback): Ditto.
3426 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3427 (serverCallback): Ditto.
3428 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3429 (httpServerCallback): Ditto.
3430 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3431 (serverCallback): Ditto.
3432 * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3433 * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3434 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3435 (Test::getWebKit1TestResoucesDir): Deleted.
3437 2014-04-09 Alexey Proskuryakov <ap@apple.com>
3439 [WK2] HTTP authentication regression tests fail
3440 https://bugs.webkit.org/show_bug.cgi?id=81627
3441 <rdar://problem/11079296>
3443 Reviewed by Anders Carlsson.
3445 * WebKitTestRunner/TestController.h:
3446 * WebKitTestRunner/TestController.cpp:
3447 (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3448 to pageLoaderClient structure.
3449 (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3450 for password based authentication (we do get server trust challenges on some tests,
3451 which WKTR can't handle).
3452 When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3453 calls won't be made, at least on CFNetwork based platforms.
3454 (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3455 to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3456 make sense to associate auth requests with individual resources - there can be
3457 multiple resources loading at once from the same protection space, so WebKit1 API
3458 that had a resource identifier was inherently racy.
3460 2014-04-09 Ryuan Choi <ryuan.choi@samsung.com>
3462 [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3463 https://bugs.webkit.org/show_bug.cgi?id=131427
3465 Reviewed by Gyuyoung Kim.
3467 Since r166973, font path was changed.
3469 * DumpRenderTree/PlatformEfl.cmake:
3470 * WebKitTestRunner/PlatformEfl.cmake:
3472 2014-04-08 Geoffrey Garen <ggaren@apple.com>
3474 Fix the build-jsc build
3475 https://bugs.webkit.org/show_bug.cgi?id=131410
3477 Reviewed by Michael Saboff.
3479 * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3482 2014-04-08 Martin Robinson <mrobinson@igalia.com>
3484 [GTK] Remove WebKit1 unit tests
3485 https://bugs.webkit.org/show_bug.cgi?id=131359
3487 Reviewed by Anders Carlsson.
3489 Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3490 entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3491 they were inadvertently left in http://trac.webkit.org/changeset/166504.
3493 * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3494 * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3495 * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3496 * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3497 * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3498 * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3499 * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3500 * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3501 * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3502 * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3503 * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3504 * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3505 * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3506 * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3507 * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3508 * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3509 * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3510 * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3511 * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3512 * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3513 * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3514 * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3515 * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3516 * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3517 * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3518 * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3519 * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3520 * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3521 * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3522 * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3523 * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3524 * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3525 * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3526 * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3527 * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3528 * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3529 * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3530 * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3532 2014-04-08 Brent Fulgham <bfulgham@apple.com>
3534 Unreviewed gardening (Take 2): Prevent users from attempting
3535 to build with known invalid cURL.
3537 * Scripts/webkitdirs.pm:
3538 (checkInstalledTools): Check for 7.34.0 (the broken version), not
3539 7.33.0 (the known good version).
3541 2014-04-08 Martin Robinson <mrobinson@igalia.com>
3543 [GTK] Remove DumpRenderTree and GtkLauncher
3544 https://bugs.webkit.org/show_bug.cgi?id=131373
3546 Reviewed by Andreas Kling.
3548 Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3549 no longer necessary now that WebKit1 GTK+ will be removed.
3552 * DumpRenderTree/PlatformGTK.cmake: Removed.
3553 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3554 * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3555 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3556 * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3557 * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3558 * DumpRenderTree/gtk/EventSender.cpp: Removed.
3559 * DumpRenderTree/gtk/EventSender.h: Removed.
3560 * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3561 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3562 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3563 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3564 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3565 * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3566 * DumpRenderTree/gtk/TextInputController.h: Removed.
3567 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3568 * GtkLauncher/CMakeLists.txt: Removed.
3569 * GtkLauncher/LauncherInspectorWindow.c: Removed.
3570 * GtkLauncher/LauncherInspectorWindow.h: Removed.
3571 * GtkLauncher/main.c: Removed.
3572 * GtkLauncher/simple.svg: Removed.
3573 * GtkLauncher/text.html: Removed.
3574 * WebKitTestRunner/PlatformGTK.cmake:
3575 * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3576 * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3577 * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3579 2014-04-08 Mark Rowe <mrowe@apple.com>
3581 XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3582 <https://webkit.org/b/131388> / <rdar://problem/16291687>
3584 Reviewed by Alexey Proskuryakov.
3586 * Scripts/webkitdirs.pm:
3587 (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3588 (execMacWebKitAppForDebugging): Ditto.
3590 2014-04-08 Geoffrey Garen <ggaren@apple.com>
3592 Build bmalloc on iOS too
3593 https://bugs.webkit.org/show_bug.cgi?id=131381
3595 Reviewed by Andreas Kling.
3597 * Scripts/build-webkit:
3599 2014-04-08 Brent Fulgham <bfulgham@apple.com>
3601 Unreviewed gardening: Prevent users from attempting
3602 to build with known invalid cURL.
3604 * Scripts/webkitdirs.pm:
3605 (checkInstalledTools): Block build attempts with bad
3608 2014-04-07 Geoffrey Garen <ggaren@apple.com>
3610 Build bmalloc on Mac
3611 https://bugs.webkit.org/show_bug.cgi?id=131333
3613 Reviewed by Mark Rowe.
3615 * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3616 (Note: Just testing Mac is not good enough because in this
3617 script 'Mac' means 'Mac or iOS'.)
3619 2014-03-30 Filip Pizlo <fpizlo@apple.com>
3621 Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3622 https://bugs.webkit.org/show_bug.cgi?id=130951
3624 Reviewed by Geoffrey Garen.
3626 * Scripts/run-javascriptcore-tests:
3628 2014-04-06 Darin Adler <darin@apple.com>
3630 Rework CSS calc logic, fixing some reference count mistakes in Length
3631 https://bugs.webkit.org/show_bug.cgi?id=131280
3633 Reviewed by Andreas Kling.
3635 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3636 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3638 2014-04-04 Brian J. Burg <burg@cs.washington.edu>
3640 Enable WEB_REPLAY for PLATFORM(MAC)
3641 https://bugs.webkit.org/show_bug.cgi?id=130700
3643 Reviewed by Timothy Hatcher.
3645 * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3647 2014-04-05 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3649 [CMake] Include X11's include dirs in TestNetscapePlugin