13073c5cf042a81372b99d84c831e165c94173d4
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-24  Antti Koivisto  <antti@apple.com>
2
3         [PSON] Flash on back navigation on Mac
4         https://bugs.webkit.org/show_bug.cgi?id=193716
5         <rdar://problem/47148458>
6
7         Reviewed by Chris Dumez.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10
11         Closing of the previous page is delayed so waiting for didFinishNavigation is
12         not sufficient to guarantee we have received all the messages. Wait for them.
13
14 2019-01-24  Chris Dumez  <cdumez@apple.com>
15
16         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
17         https://bugs.webkit.org/show_bug.cgi?id=193761
18         <rdar://problem/47456405>
19
20         Reviewed by Alex Christensen.
21
22         Add API test coverage.
23
24         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
25
26 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
27
28         webkitpy: Missing PID in crashlog name should not be fatal
29         https://bugs.webkit.org/show_bug.cgi?id=193771
30
31         If we can't determine the PID of a crashlog, just ignore the crashlog instead
32         of raising an exception.
33
34         Reviewed by Lucas Forschler.
35
36         * Scripts/webkitpy/port/darwin.py:
37         (DarwinPort._merge_crash_logs):
38
39 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
40
41         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
42         https://bugs.webkit.org/show_bug.cgi?id=193746
43
44         Reviewed by Youenn Fablet.
45
46         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
47         so we'd best just not call it.
48
49         * Scripts/webkitpy/w3c/test_exporter.py:
50         (WebPlatformTestExporter.create_branch_with_patch):
51
52 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
53
54         Move FileSystem to WTF
55         https://bugs.webkit.org/show_bug.cgi?id=193602
56
57         Reviewed by Yusuke Suzuki.
58
59         * DumpRenderTree/win/DumpRenderTree.cpp:
60         * TestWebKitAPI/CMakeLists.txt:
61         * TestWebKitAPI/PlatformGTK.cmake:
62         * TestWebKitAPI/PlatformJSCOnly.cmake:
63         * TestWebKitAPI/PlatformPlayStation.cmake:
64         * TestWebKitAPI/PlatformWPE.cmake:
65         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
66         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
67         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
68         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
69         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
70         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
71         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
72         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
73         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
74         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
75
76 2019-01-24  Philippe Normand  <pnormand@igalia.com>
77
78         [WPE] Remove hard dependency on subprocess32 for the API tests
79
80         Rubber-stamped by Carlos Garcia Campos.
81
82         * glib/api_test_runner.py:
83         (TestRunner._run_test_qt): Lazily import subprocess32 and check
84         its presence only when running WPEQt tests.
85
86 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
87
88         [GLIB] Expose JavaScriptCore options in GLib public API
89         https://bugs.webkit.org/show_bug.cgi?id=188742
90
91         Reviewed by Michael Catanzaro.
92
93         Add a test for the new API.
94
95         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
96         (testsJSCOptions):
97         (main):
98
99 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
100
101         [GTK][WPE] Support JPEG 2000 images
102         https://bugs.webkit.org/show_bug.cgi?id=186272
103
104         Reviewed by Žan Doberšek.
105
106         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
107
108         * gtk/jhbuild.modules:
109         * wpe/jhbuild.modules:
110
111 2019-01-23  David Kilzer  <ddkilzer@apple.com>
112
113         check-webkit-style should warn when using soft-linking macros in a header
114         <https://webkit.org/b/193750>
115
116         Reviewed by Darin Adler.
117
118         * Scripts/webkitpy/style/checkers/cpp.py:
119         (check_language): Add softlink/header check by refactoring the
120         softlink/framework check.
121         (CppChecker): Enable softlink/header check by default.
122         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
123         (CppStyleTest.test_softlink_framework): Rename from
124         CppStyleTest.test_softlink() and change test framework name in
125         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
126         files. Set file_name for macros that only appear in headers.
127         (CppStyleTest.test_softlink_header): Add tests for using
128         soft-link macros in headers.
129
130 2019-01-23  Chris Dumez  <cdumez@apple.com>
131
132         Deprecate API to limit the maximum number of WebProcesses
133         https://bugs.webkit.org/show_bug.cgi?id=193725
134         <rdar://problem/47464879>
135
136         Reviewed by Geoff Garen.
137
138         Update existing API tests to stop using deprecated API.
139
140         * MiniBrowser/mac/AppDelegate.m:
141         (defaultConfiguration):
142         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
143         (TestWebKitAPI::TEST):
144         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
145         (TestWebKitAPI::TEST):
146         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
147         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
148         (TEST):
149         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
150         (TEST):
151
152 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
153
154         [ews-app] Rename ews model buildermappings to buildermapping
155         https://bugs.webkit.org/show_bug.cgi?id=193729
156
157         Reviewed by Lucas Forschler.
158
159         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
160         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
161         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
162
163 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
164
165         [ews-app] Rename ews model steps to step
166         https://bugs.webkit.org/show_bug.cgi?id=193697
167
168         Reviewed by Lucas Forschler.
169
170         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
171         (Step): Renamed Steps to Step.
172
173 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
174
175         Clean up IndexedDB files between tests
176         https://bugs.webkit.org/show_bug.cgi?id=192796
177         <rdar://problem/46824999>
178
179         Reviewed by Geoffrey Garen.
180
181         * DumpRenderTree/mac/DumpRenderTree.mm:
182         (runTest):
183         * WebKitTestRunner/TestController.cpp:
184         (WTR::TestController::resetStateToConsistentValues):
185         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
186         (WTR::RemoveAllIndexedDatabasesCallback):
187         (WTR::TestController::ClearIndexedDatabases):
188         * WebKitTestRunner/TestController.h:
189         * WebKitTestRunner/TestInvocation.cpp:
190         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
191
192 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
193
194         [ews-app] Rename ews model Builds to Build
195         https://bugs.webkit.org/show_bug.cgi?id=193695
196
197         Reviewed by Lucas Forschler.
198
199         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
200         (Build): Renamed Builds to Build.
201
202 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
203
204         webkitpy: Wait longer when launching WebKitTestRunner
205         https://bugs.webkit.org/show_bug.cgi?id=193734
206
207         Reviewed by Aakash Jain.
208
209         * Scripts/webkitpy/port/simulator_process.py:
210         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
211
212 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
213
214         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
215         https://bugs.webkit.org/show_bug.cgi?id=193182
216         <rdar://problem/47452154>
217
218         Reviewed by Tim Horton.
219
220         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
221         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
222         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
223
224         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
225         preventing later tests from recognizing gestures.
226
227         * WebKitTestRunner/ios/TestControllerIOS.mm:
228         (WTR::TestController::platformResetStateToConsistentValues):
229
230         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
231
232 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
233
234         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
235         https://bugs.webkit.org/show_bug.cgi?id=193722
236         <rdar://problem/47481475>
237
238         Reviewed by Lucas Forschler.
239
240         iPhone and iPad ports should both use the iOS config.
241
242         * Scripts/webkitpy/port/ios_simulator.py:
243         (IPhoneSimulatorPort.__init__):
244         (IPadSimulatorPort.__init__):
245
246 2019-01-23  Rob Buis  <rbuis@igalia.com>
247
248         Update MIME type parser
249         https://bugs.webkit.org/show_bug.cgi?id=180526
250
251         Reviewed by Frédéric Wang.
252
253         Add unit tests for both parse modes of ParsedContentType.
254
255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
256         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
257         (TestWebKitAPI::TEST):
258
259 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
260
261         [ews-app] fetch loop should not stop on network issues
262         https://bugs.webkit.org/show_bug.cgi?id=193666
263
264         Reviewed by Lucas Forschler.
265
266         * BuildSlaveSupport/ews-app/ews/fetcher.py:
267         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
268
269 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
270
271         [iOS] Multiple WKWebViewAutofillTests are flaky failures
272         https://bugs.webkit.org/show_bug.cgi?id=189165
273         <rdar://problem/47433765>
274
275         Reviewed by Tim Horton.
276
277         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
278         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
279         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
280         process in sufficient to ensure that any previous action that blurred the focused element in the web process
281         would make its way to the UI process by the time the layer tree commit is finished.
282
283         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
284         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
285         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
286         will fail because it asks for -_autofillContext too early.
287
288         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
289         is handled in the UI process.
290
291         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
292
293         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
294         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
295         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
296         input session.
297
298         (-[AutofillTestView textInputHasAutofillContext]):
299
300         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
301
302         * TestWebKitAPI/cocoa/TestWKWebView.h:
303         * TestWebKitAPI/cocoa/TestWKWebView.mm:
304         (nextInputSessionChangeCount):
305
306         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
307         This includes changing the focused element from one to another.
308
309         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
310         (-[TestWKWebView didStartFormControlInteraction]):
311         (-[TestWKWebView didEndFormControlInteraction]):
312         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
313
314         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
315         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
316         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
317         that doesn't require an input session to one that doesn't.
318
319 2019-01-22  David Kilzer  <ddkilzer@apple.com>
320
321         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
322         <https://webkit.org/b/193676>
323
324         Reviewed by Alexey Proskuryakov.
325
326         * Scripts/webkitpy/style/checkers/cpp.py:
327         (check_member_initialization_list):
328         - Don't report missing whitespace around colon if the colon at
329           the start of the line is formatted correctly.
330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
331         (WebKitStyleTest.test_member_initialization_list):
332         - Add a test for a missing permutation of existing tests.
333         - Add a test this false-positive.
334         - Add blank lines between subtests to make them easier to read.
335
336 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
337
338         [build.webkit.org] Unit-test failure after r237113
339         https://bugs.webkit.org/show_bug.cgi?id=193669
340
341         Reviewed by Michael Catanzaro.
342
343         * BuildSlaveSupport/build.webkit.org-config/factories.py:
344         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
345         multiple or zero flags.
346
347 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
348
349         Cache bytecode to disk
350         https://bugs.webkit.org/show_bug.cgi?id=192782
351         <rdar://problem/46084932>
352
353         Reviewed by Keith Miller.
354
355         Add test helper to execute bytecode-cache tests: it executes each test
356         twice, the first with JSC_diskCachePath set to a temporary directory
357         and second with JSC_forceDiskCache=true (in addition to the cache path)
358         to guarantee that only the disk cache is being used and no new
359         UnlinkedCodeBlocks are being created.
360
361         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
362         * Scripts/run-jsc-stress-tests:
363
364 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
365
366         [css-logical] Implement flow-relative margin, padding and border shorthands
367         https://bugs.webkit.org/show_bug.cgi?id=188697
368
369         Reviewed by Simon Fraser and Antti Koivisto.
370
371         * DumpRenderTree/TestOptions.cpp:
372         (TestOptions::TestOptions):
373         * DumpRenderTree/TestOptions.h:
374         * DumpRenderTree/mac/DumpRenderTree.mm:
375         (setWebPreferencesForTestOptions):
376         Allow tests to enable the CSSLogicalEnabled flag in WK1.
377
378         * Scripts/webkitpy/style/checkers/jsonchecker.py:
379         (JSONCSSPropertiesChecker.check_codegen_properties):
380         Allow CSS property definitions to have a 'runtime-flag' parameter which
381         disables the property when the specified runtime flag is disabled.
382
383 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
384
385         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
386         https://bugs.webkit.org/show_bug.cgi?id=193643
387
388         Reviewed by Michael Catanzaro.
389
390         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
391         * wpe/jhbuild.modules: Ditto.
392
393 2019-01-21  Zalan Bujtas  <zalan@apple.com>
394
395         [LFC][Floats] Take float top position into account when computing containing block height.
396         https://bugs.webkit.org/show_bug.cgi?id=193655
397
398         Reviewed by Antti Koivisto.
399
400         * LayoutReloaded/misc/LFC-passing-tests.txt:
401
402 2019-01-21  David Kilzer  <ddkilzer@apple.com>
403
404         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
405         <https://webkit.org/b/193645>
406         <rdar://problem/47421574>
407
408         Reviewed by Alex Christensen.
409
410         - Now checks for local soft-linking of all frameworks that have
411           their own *SoftLinking.{cpp,h,mm} files.
412         - Changes softlink/uikit warning to softlink/framework.
413
414         * Scripts/webkitpy/style/checkers/cpp.py:
415         (check_language):
416         (CppChecker):
417         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
418         (CppStyleTest):
419
420 2019-01-20  Saam Barati  <sbarati@apple.com>
421
422         Rollout r240210: It broke tests on iOS
423         https://bugs.webkit.org/show_bug.cgi?id=193640
424
425         Unreviewed.
426
427         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
428         * Scripts/run-jsc-stress-tests:
429
430 2019-01-20  chris fleizach  <cfleizach@apple.com>
431
432         AX: Support returning relative frames for accessibility
433         https://bugs.webkit.org/show_bug.cgi?id=193414
434         <rdar://problem/47268501>
435
436         Reviewed by Zalan Bujtas.
437
438         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
439         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
440         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
441         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
442         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
443         (WTR::attributesOfElement):
444         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
445
446 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
447
448         Unreviewed, add my new email address
449
450         * Scripts/webkitpy/common/config/contributors.json:
451
452 2019-01-19  Zalan Bujtas  <zalan@apple.com>
453
454         [LFC][BFC] <body>'s overflow property value is propagated to viewport
455         https://bugs.webkit.org/show_bug.cgi?id=193617
456
457         Reviewed by Antti Koivisto.
458
459         * LayoutReloaded/misc/LFC-passing-tests.txt:
460
461 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
462
463         Unreviewed, rolling out r240209.
464
465         Broke GTK/WPE injected bundle
466
467         Reverted changeset:
468
469         "AX: Support returning relative frames for accessibility"
470         https://bugs.webkit.org/show_bug.cgi?id=193414
471         https://trac.webkit.org/changeset/240209
472
473 2019-01-12  Dan Bernstein  <mitz@apple.com>
474
475         [Cocoa] Avoid importing directly from subumbrella frameworks
476         https://bugs.webkit.org/show_bug.cgi?id=186016
477         <rdar://problem/40591038>
478
479         Reviewed by Sam Weinig.
480
481         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
482           LaunchServices header.
483         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
484           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
485         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
486           when using SDKs earlier than 10.13.
487         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
488           and OTHER_CPLUSPLUSFLAGS.
489         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
490           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
491         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
492           LaunchServices header.
493
494 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
495
496         Cache bytecode to disk
497         https://bugs.webkit.org/show_bug.cgi?id=192782
498         <rdar://problem/46084932>
499
500         Reviewed by Keith Miller.
501
502         Add test helper to execute bytecode-cache tests: it executes each test
503         twice, the first with JSC_diskCachePath set to a temporary directory
504         and second with JSC_forceDiskCache=true (in addition to the cache path)
505         to guarantee that only the disk cache is being used and no new
506         UnlinkedCodeBlocks are being created.
507
508         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
509         * Scripts/run-jsc-stress-tests:
510
511 2019-01-20  chris fleizach  <cfleizach@apple.com>
512
513         AX: Support returning relative frames for accessibility
514         https://bugs.webkit.org/show_bug.cgi?id=193414
515         <rdar://problem/47268501>
516
517         Reviewed by Zalan Bujtas.
518
519         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
520         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
521         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
522         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
523         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
524         (WTR::attributesOfElement):
525         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
526
527 2019-01-20  Antoine Quint  <graouts@apple.com>
528
529         Add a POINTER_EVENTS feature flag
530         https://bugs.webkit.org/show_bug.cgi?id=193577
531         <rdar://problem/47408511>
532
533         Unreviewed. Also enable Pointer Events for iosmac.
534
535         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
536
537 2019-01-19  Zalan Bujtas  <zalan@apple.com>
538
539         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
540         https://bugs.webkit.org/show_bug.cgi?id=193613
541
542         Reviewed by Antti Koivisto.
543
544         * LayoutReloaded/misc/LFC-passing-tests.txt:
545
546 2019-01-19  Antoine Quint  <graouts@apple.com>
547
548         Add a POINTER_EVENTS feature flag
549         https://bugs.webkit.org/show_bug.cgi?id=193577
550
551         Reviewed by Dean Jackson.
552
553         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
554
555 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
556
557         Disable the run-jsc-stress-test remote host key check [second round].
558         https://bugs.webkit.org/show_bug.cgi?id=192988
559
560         Reviewed by Dewei Zhu.
561
562         * Scripts/run-jsc-stress-tests:
563
564 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
565
566         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
567         https://bugs.webkit.org/show_bug.cgi?id=193597
568
569         Reviewed by Lucas Forschler.
570
571         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
572
573 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
574
575         [build.webkit.org] api tests failures are incorrectly named as unit test failures
576         https://bugs.webkit.org/show_bug.cgi?id=193595
577
578         Reviewed by Lucas Forschler.
579
580         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
581         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
582         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
583
584 2019-01-18  Chris Dumez  <cdumez@apple.com>
585
586         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
587         https://bugs.webkit.org/show_bug.cgi?id=193588
588         <rdar://problem/47131566>
589
590         Reviewed by Alex Christensen.
591
592         Add layout test coverage.
593
594         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
595
596 2019-01-18  Jer Noble  <jer.noble@apple.com>
597
598         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
599         https://bugs.webkit.org/show_bug.cgi?id=189553
600
601         Reviewed by Tim Horton.
602
603         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
604
605         * ContentExtensionTester/Configurations/Base.xcconfig:
606         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
607         * DumpRenderTree/mac/Configurations/Base.xcconfig:
608         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
609         * ImageDiff/cg/Configurations/Base.xcconfig:
610         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
611         * MiniBrowser/Configurations/Base.xcconfig:
612         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
613         * MobileMiniBrowser/Configurations/Base.xcconfig:
614         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
615         * Scripts/webkitpy/style/checker.py:
616         (_all_categories):
617         (FileType):
618         (CheckerDispatcher._file_type):
619         (CheckerDispatcher._create_checker):
620         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
621         (SDKVariantChecker):
622         (SDKVariantChecker.__init__):
623         (SDKVariantChecker.check):
624         * TestWebKitAPI/Configurations/Base.xcconfig:
625         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
626         * WebEditingTester/Configurations/Base.xcconfig:
627         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
628         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
629         * WebKitTestRunner/Configurations/Base.xcconfig:
630         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
631         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
632         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
633
634 2019-01-18  David Kilzer  <ddkilzer@apple.com>
635
636         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
637         <https://webkit.org/b/193568>
638         <rdar://problem/47381130>
639
640         Reviewed by Alex Christensen.
641
642         Make sure no one re-introduces UIKit soft-linking by adding a
643         style rule.
644
645         * Scripts/webkitpy/style/checkers/cpp.py:
646         (check_language): Add softlink/uikit check.
647         (CppChecker): Enable softlink/uikit check.
648         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
649         (CppStyleTest): Add test for softlink/uikit.
650
651 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
652
653         [GTK] install-dependencies tool looks for libunistring-dev for dnf
654         https://bugs.webkit.org/show_bug.cgi?id=193584
655
656         Change "-dev" to "-devel".
657
658         Reviewed by Michael Catanzaro.
659
660         * gtk/install-dependencies:
661
662 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
663
664         webkitpy: Add iPhone and iPad ports
665         https://bugs.webkit.org/show_bug.cgi?id=193537
666         <rdar://problem/47353390>
667
668         Reviewed by Lucas Forschler.
669
670         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
671         ports. Note that this separation is optional, the --ios-simulator command remains.
672
673         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
674         (RunTest.test_device_type_test_division): Drive-by fix.
675         (RunTest.test_device_type_specific_listing): Ditto.
676         (RunTest.test_ipad_test_division):
677         (RunTest):
678         (RunTest.test_ipad_listing):
679         * Scripts/webkitpy/port/factory.py:
680         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
681         (PortFactory):
682         * Scripts/webkitpy/port/ios_simulator.py:
683         (IPhoneSimulatorPort):
684         (IPadSimulatorPort):
685
686 2019-01-18  Chris Dumez  <cdumez@apple.com>
687
688         Regression(PSON) Scroll position is not always restored properly when navigating back
689         https://bugs.webkit.org/show_bug.cgi?id=193578
690         <rdar://problem/47386331>
691
692         Reviewed by Tim Horton.
693
694         Add API test coverage.
695
696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
697
698 2019-01-18  Youenn Fablet  <youenn@apple.com>
699
700         Add a new SPI to request for cache storage quota increase
701         https://bugs.webkit.org/show_bug.cgi?id=193323
702
703         Reviewed by Alex Christensen.
704
705         Implement WebsiteDataStore quota delegate to handle quota requests.
706         By default, do not update quota.
707         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
708
709         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
710         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
711         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
712         * WebKitTestRunner/InjectedBundle/TestRunner.h:
713         * WebKitTestRunner/TestController.cpp:
714         (WTR::TestController::allowCacheStorageQuotaIncrease):
715         * WebKitTestRunner/TestController.h:
716         * WebKitTestRunner/TestInvocation.cpp:
717         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
718         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
719         (-[CacheStorageQuotaManager init]):
720         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
721         (WTR::initializeWebViewConfiguration):
722         (WTR::TestController::cocoaResetStateToConsistentValues):
723         (WTR::TestController::allowCacheStorageQuotaIncrease):
724
725 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
726
727         [ews-build] Pass owner to the triggered builds
728         https://bugs.webkit.org/show_bug.cgi?id=193574
729
730         Reviewed by Lucas Forschler.
731
732         * BuildSlaveSupport/ews-build/factories.py:
733         (BuildFactory.propertiesToPassToTriggers):
734
735 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
736
737         [ews-app] Send patch author as a build property
738         https://bugs.webkit.org/show_bug.cgi?id=193560
739
740         Reviewed by Lucas Forschler.
741
742         * BuildSlaveSupport/ews-app/ews/fetcher.py:
743         (BugzillaPatchFetcher.fetch):
744
745 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
746
747         webkitpy: Implement device type specific expected results (Follow-up fix)
748         https://bugs.webkit.org/show_bug.cgi?id=192162
749         <rdar://problem/46345449>
750
751         Unreviewed infrastructure fix.
752
753         * Scripts/webkitpy/layout_tests/controllers/manager.py:
754         (Manager.run): Don't boot a device if no tests are available to run on it.
755
756 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
757
758         webkitpy: Implement device type specific expected results (Follow-up fix)
759         https://bugs.webkit.org/show_bug.cgi?id=192162
760         <rdar://problem/46345449>
761
762         Unreviewed infrastructure fix.
763
764         * Scripts/webkitpy/api_tests/manager.py:
765         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
766
767 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
768
769         webkitpy: Implement device type specific expected results (Part 2)
770         https://bugs.webkit.org/show_bug.cgi?id=192162
771         <rdar://problem/46345449>
772
773         Rubber-stamped by Aakash Jain.
774
775         This change uses device_type to select a different set of TestExpectation files based on the type of device running
776         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
777         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
778
779         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
780         (LayoutTestFinder.find_tests): Pass device_type through.
781         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
782         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
783         * Scripts/webkitpy/layout_tests/controllers/manager.py:
784         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
785         (Manager._collect_tests): Pass device type to test finder.
786         (Manager._needs_web_platform_test):
787         (Manager._prepare_lists): Index _expectations by device type.
788         (Manager._test_input_for_file):
789         (Manager._test_is_slow): Ditto.
790         (Manager._test_should_dump_jsconsolelog_in_stderr):
791         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
792         (Manager._get_test_inputs):
793         (Manager._update_worker_count):
794         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
795         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
796         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
797         the one which runs the test.
798         (Manager._run_test_subset):
799         (Manager._run_tests): Index _expectations by current_device_type.
800         (Manager._print_expectation_line_for_test): Ditto.
801         (Manager._print_expectations_for_subset): Ditto.
802         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
803         Unlike run, this function will behave the same regardless of what devices are available.
804         (Manager._custom_device_for_test): Deleted.
805         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
806         (ManagerTest.test_uses_custom_device): Deleted.
807         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
808         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
809         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
810         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
811         all of the expectations.
812         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
813         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
814         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
815         (TestExpectations.__init__): Allow device_type to be passed through.
816         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
817         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
818         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
819         (summarize_results):
820         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
821         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
822         a test ran with, one must check all expectations to find the first non-skip expectation.
823         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
824         (RunTest.test_device_type_test_division):
825         (RunTest):
826         (RunTest.test_device_type_specific_listing):
827         * Scripts/webkitpy/port/base.py:
828         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
829         (Port.supported_device_types): The result of this function will change based on what devices are available.
830         * Scripts/webkitpy/port/device_port.py:
831         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
832         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
833         can be used.
834         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
835         any, or the DEFAULT_DEVICE_TYPES of the port.
836         * Scripts/webkitpy/port/ios.py:
837         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
838         * Scripts/webkitpy/port/ios_simulator.py:
839         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
840         * Scripts/webkitpy/port/watch.py:
841         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
842         * Scripts/webkitpy/port/watch_simulator.py:
843         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
844         * Scripts/webkitpy/xcode/device_type.py:
845         (DeviceType):
846         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
847
848 2019-01-18  Philippe Normand  <pnormand@igalia.com>
849
850         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
851         https://bugs.webkit.org/show_bug.cgi?id=193575
852
853         Reviewed by Michael Catanzaro.
854
855         Allow the script to run without explicit port argument because
856         it's specific to the WPE port anyway.
857
858         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
859         and simplify the rest of the code accordingly.
860
861 2019-01-18  Charlie Turner  <cturner@igalia.com>
862
863         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
864         https://bugs.webkit.org/show_bug.cgi?id=192229
865
866         Reviewed by Xabier Rodriguez-Calvar.
867
868         * MiniBrowser/wpe/main.cpp:
869         (main): Enable encrypted-media by default.
870
871 2019-01-18  Philippe Normand  <pnormand@igalia.com>
872
873         [Flatpak] Missing KeyboardInterrupt exception handler
874         https://bugs.webkit.org/show_bug.cgi?id=193570
875
876         Reviewed by Michael Catanzaro.
877
878         * flatpak/flatpakutils.py:
879         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
880
881 2019-01-18  Zalan Bujtas  <zalan@apple.com>
882
883         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
884         https://bugs.webkit.org/show_bug.cgi?id=193564
885
886         Reviewed by Antti Koivisto.
887
888         * LayoutReloaded/misc/LFC-passing-tests.txt:
889
890 2019-01-18  Zalan Bujtas  <zalan@apple.com>
891
892         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
893         https://bugs.webkit.org/show_bug.cgi?id=193562
894
895         Reviewed by Antti Koivisto.
896
897         * LayoutReloaded/misc/LFC-passing-tests.txt:
898
899 2019-01-18  Zalan Bujtas  <zalan@apple.com>
900
901         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
902         https://bugs.webkit.org/show_bug.cgi?id=193555
903
904         Reviewed by Antti Koivisto.
905
906         * LayoutReloaded/misc/LFC-passing-tests.txt:
907
908 2019-01-18  Philippe Normand  <pnormand@igalia.com>
909
910         [WPE] Add Qt extension
911         https://bugs.webkit.org/show_bug.cgi?id=191464
912
913         Reviewed by Carlos Garcia Campos.
914
915         MiniBrowser and API tests for the WPE Qt API. To run the
916         MiniBrowser a new script is introduced. Example invocation:
917
918         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
919
920         Also note-worthy is the introduction of the python2-subprocess32
921         dependency to run the GLib API tests.
922
923         * MiniBrowser/wpe/CMakeLists.txt:
924         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
925         * MiniBrowser/wpe/qt/main.cpp: Added.
926         (main):
927         * MiniBrowser/wpe/qt/main.qml: Added.
928         * MiniBrowser/wpe/qt/qml.qrc: Added.
929         * Scripts/run-gtk-tests:
930         (GtkTestRunner.is_google_test):
931         (GtkTestRunner):
932         (GtkTestRunner.is_qt_test):
933         * Scripts/run-qt-wpe-minibrowser: Added.
934         * Scripts/run-wpe-tests:
935         (WPETestRunner):
936         (WPETestRunner.is_google_test):
937         (WPETestRunner.is_qt_test):
938         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
939         (TestLoad::main):
940         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
941         (TestLoadHtml::main):
942         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
943         (TestLoadRequest::main):
944         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
945         (TestRunJavaScript::main):
946         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
947         (waitForSignal):
948         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
949         (LoadSpy::LoadSpy):
950         (LoadSpy::~LoadSpy):
951         (LoadSpy::onLoadingChanged):
952         (LoadStartedCatcher::LoadStartedCatcher):
953         (LoadStartedCatcher::~LoadStartedCatcher):
954         (LoadStartedCatcher::onLoadingChanged):
955         (waitForLoadSucceeded):
956         (waitForLoadFailed):
957         * TestWebKitAPI/glib/CMakeLists.txt:
958         * flatpak/flatpakutils.py:
959         (WebkitFlatpak.load_from_args):
960         (WebkitFlatpak.__init__):
961         (WebkitFlatpak.clean_args):
962         (WebkitFlatpak.run_in_sandbox):
963         * flatpak/org.webkit.CommonModules.yaml:
964         * flatpak/org.webkit.WPE.yaml:
965         * flatpak/org.webkit.WPEModules.yaml:
966         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
967         * flatpak/org.webkit.WebKit.yaml:
968         * glib/api_test_runner.py:
969         (TestRunner._run_test_qt):
970         (TestRunner.is_qt_test):
971         (TestRunner._run_test):
972
973 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
974
975         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
976         https://bugs.webkit.org/show_bug.cgi?id=193494
977         <rdar://problem/46859627>
978
979         Reviewed by Simon Fraser and Tim Horton.
980
981         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
982         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
983
984         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
985         (WTR::UIScriptController::contentOffsetX const):
986         (WTR::UIScriptController::contentOffsetY const):
987         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
988         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
989         (WTR::UIScriptController::contentOffsetX const):
990         (WTR::UIScriptController::contentOffsetY const):
991         * TestRunnerShared/UIScriptContext/UIScriptController.h:
992
993         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
994
995         * WebKitTestRunner/TestController.cpp:
996         (WTR::updateTestOptionsFromTestHeader):
997         * WebKitTestRunner/TestOptions.h:
998         (WTR::TestOptions::hasSameInitializationOptions const):
999         * WebKitTestRunner/ios/TestControllerIOS.mm:
1000         (WTR::TestController::platformResetStateToConsistentValues):
1001         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1002         (WTR::UIScriptController::contentOffsetX const):
1003         (WTR::UIScriptController::contentOffsetY const):
1004
1005 2019-01-17  Truitt Savell  <tsavell@apple.com>
1006
1007         Unreviewed, rolling out r240124.
1008
1009         This commit broke an internal build.
1010
1011         Reverted changeset:
1012
1013         "SDK_VARIANT build destinations should be separate from non-
1014         SDK_VARIANT builds"
1015         https://bugs.webkit.org/show_bug.cgi?id=189553
1016         https://trac.webkit.org/changeset/240124
1017
1018 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1019
1020         Fix string concatenation API test after r239920
1021         https://bugs.webkit.org/show_bug.cgi?id=193551
1022         <rdar://problem/47359304>
1023
1024         Reviewed by Youenn Fablet.
1025
1026         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1027         (TestWebKitAPI::TEST):
1028         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1029         in WebKit's build configuration like it apparently is on Linux.
1030
1031 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1032
1033         [ews-build] validate-patch should handle the case when bug_id is None
1034         https://bugs.webkit.org/show_bug.cgi?id=193547
1035
1036         Reviewed by Lucas Forschler.
1037
1038         * BuildSlaveSupport/ews-build/steps.py:
1039         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1040         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1041
1042 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1043
1044         [ews-build] Add patch author information in build
1045         https://bugs.webkit.org/show_bug.cgi?id=193465
1046
1047         Reviewed by Lucas Forschler.
1048
1049         * BuildSlaveSupport/ews-build/steps.py:
1050         (ValidatePatch._is_patch_obsolete):
1051
1052 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1053
1054         [ews-build] Pass bug_id to the triggered builds
1055         https://bugs.webkit.org/show_bug.cgi?id=193548
1056
1057         Reviewed by Lucas Forschler.
1058
1059         * BuildSlaveSupport/ews-build/factories.py:
1060         (BuildFactory.propertiesToPassToTriggers):
1061
1062 2019-01-17  Jer Noble  <jer.noble@apple.com>
1063
1064         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1065         https://bugs.webkit.org/show_bug.cgi?id=189553
1066
1067         Reviewed by Tim Horton.
1068
1069         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1070
1071         * ContentExtensionTester/Configurations/Base.xcconfig:
1072         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1073         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1074         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1075         * ImageDiff/cg/Configurations/Base.xcconfig:
1076         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1077         * MiniBrowser/Configurations/Base.xcconfig:
1078         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1079         * MobileMiniBrowser/Configurations/Base.xcconfig:
1080         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1081         * Scripts/webkitpy/style/checker.py:
1082         (_all_categories):
1083         (FileType):
1084         (CheckerDispatcher._file_type):
1085         (CheckerDispatcher._create_checker):
1086         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1087         (SDKVariantChecker):
1088         (SDKVariantChecker.__init__):
1089         (SDKVariantChecker.check):
1090         * TestWebKitAPI/Configurations/Base.xcconfig:
1091         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1092         * WebEditingTester/Configurations/Base.xcconfig:
1093         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1094         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1095         * WebKitTestRunner/Configurations/Base.xcconfig:
1096         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1097         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1098         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1099
1100 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1101
1102         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1103         https://bugs.webkit.org/show_bug.cgi?id=193534
1104
1105         Reviewed by Antti Koivisto.
1106
1107         * LayoutReloaded/misc/LFC-passing-tests.txt:
1108
1109 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1110
1111         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1112         https://bugs.webkit.org/show_bug.cgi?id=193528
1113
1114         Reviewed by Antti Koivisto.
1115
1116         * LayoutReloaded/misc/LFC-passing-tests.txt:
1117
1118 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1119
1120         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1121         https://bugs.webkit.org/show_bug.cgi?id=193520
1122
1123         Reviewed by Antti Koivisto.
1124
1125         * LayoutReloaded/misc/LFC-passing-tests.txt:
1126
1127 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1128
1129         [ews-build] unapply-patch step should not update source
1130         https://bugs.webkit.org/show_bug.cgi?id=193234
1131
1132         Reviewed by Lucas Forschler.
1133
1134         * BuildSlaveSupport/ews-build/steps.py:
1135         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1136         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1137
1138 2019-01-16  Youenn Fablet  <youenn@apple.com>
1139
1140         Add a new SPI for controlling getUserMedia
1141         https://bugs.webkit.org/show_bug.cgi?id=192793
1142
1143         Reviewed by Eric Carlson.
1144
1145         * MiniBrowser/mac/WK2BrowserWindowController.m:
1146         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1147         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1148         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1149         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1150         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1151         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1152         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1153         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1154         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1155         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1156         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1157         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1158         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1159         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1160
1161 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1162
1163         [LFC][BFC] Inflow non-replaced used width should not be negative.
1164         https://bugs.webkit.org/show_bug.cgi?id=193495
1165
1166         Reviewed by Antti Koivisto.
1167
1168         * LayoutReloaded/misc/LFC-passing-tests.txt:
1169
1170 2019-01-16  Chris Dumez  <cdumez@apple.com>
1171
1172         Regression(PSON) View becomes blank after click a cross-site download link
1173         https://bugs.webkit.org/show_bug.cgi?id=193361
1174         <rdar://problem/47099573>
1175
1176         Reviewed by Geoffrey Garen.
1177
1178         Add API test coverage.
1179
1180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1181         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1182
1183 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1184
1185         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1186         https://bugs.webkit.org/show_bug.cgi?id=193470
1187
1188         Reviewed by Antti Koivisto.
1189
1190         * LayoutReloaded/misc/LFC-passing-tests.txt:
1191
1192 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1193
1194         [LFC] Adjust margin box verification.
1195         https://bugs.webkit.org/show_bug.cgi?id=193482
1196
1197         Reviewed by Antti Koivisto.
1198
1199         * LayoutReloaded/misc/LFC-passing-tests.txt:
1200
1201 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1202
1203         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1204         https://bugs.webkit.org/show_bug.cgi?id=193451
1205
1206         Reviewed by Geoffrey Garen.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1209         (TEST):
1210         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1211         (runWebsiteDataStoreCustomPaths):
1212
1213 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1214
1215         webkitpy: Support boolean simctl isAvailable
1216         https://bugs.webkit.org/show_bug.cgi?id=193472
1217         <rdar://problem/47296150>
1218
1219         Reviewed by Ryosuke Niwa.
1220
1221         * Scripts/webkitpy/xcode/simulated_device.py:
1222         (SimulatedDeviceManager._create_runtimes):
1223         (SimulatedDeviceManager._create_device_with_runtime):
1224
1225 2019-01-15  Chris Dumez  <cdumez@apple.com>
1226
1227         Unreviewed, rolling out r239993, r239995, r239997, and
1228         r239999.
1229
1230         Caused assertions under
1231         ViewGestureController::disconnectFromProcess()
1232
1233         Reverted changesets:
1234
1235         "Regression(PSON) View becomes blank after click a cross-site
1236         download link"
1237         https://bugs.webkit.org/show_bug.cgi?id=193361
1238         https://trac.webkit.org/changeset/239993
1239
1240         "Unreviewed iOS build fix after r239993."
1241         https://trac.webkit.org/changeset/239995
1242
1243         "Fix iOS build after r239993"
1244         https://bugs.webkit.org/show_bug.cgi?id=193361
1245         https://trac.webkit.org/changeset/239997
1246
1247         "Unreviewed, revert part of r239997 as it is not needed to fix
1248         the build."
1249         https://trac.webkit.org/changeset/239999
1250
1251 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1252
1253         Cannot tab out of WKWebView on macOS
1254         https://bugs.webkit.org/show_bug.cgi?id=161448
1255         <rdar://problem/28100085>
1256
1257         Reviewed by Dean Jackson.
1258
1259         Add a test that tabbing into and out of WKWebView works correctly.
1260
1261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1262         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1263         (WebKit2_CommandBackForwardTest::SetUp):
1264         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1265         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1266         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1267         (-[FocusableView canBecomeKeyView]):
1268         (TEST):
1269         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1270         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1271         (-[OffscreenWindow initWithSize:]):
1272         (-[OffscreenWindow isKeyWindow]):
1273         (-[OffscreenWindow isVisible]):
1274         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1275         (TestWebKitAPI::PlatformWebView::initialize):
1276         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1277         (-[ActiveOffscreenWindow isVisible]): Deleted.
1278         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1279
1280 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1281
1282         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1283         https://bugs.webkit.org/show_bug.cgi?id=193459
1284
1285         Reviewed by Mark Lam.
1286
1287         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1288         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1289
1290 2019-01-15  Chris Dumez  <cdumez@apple.com>
1291
1292         Regression(PSON) View becomes blank after click a cross-site download link
1293         https://bugs.webkit.org/show_bug.cgi?id=193361
1294         <rdar://problem/47099573>
1295
1296         Reviewed by Geoff Garen.
1297
1298         Add API test coverage.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1301         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1302
1303 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1304
1305         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1306         https://bugs.webkit.org/show_bug.cgi?id=193448
1307
1308         Reviewed by Antti Koivisto.
1309
1310         * LayoutReloaded/misc/LFC-passing-tests.txt:
1311
1312 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1313
1314         webkitpy: Implement device type specific expected results (Part 1)
1315         https://bugs.webkit.org/show_bug.cgi?id=192162
1316
1317         Reviewed by Lucas Forschler.
1318
1319         Device type specific expected results covers two related ideas. The first (covered by this change)
1320         is where to search for -expected.* files. The second is which tests to run based on the
1321         TestExpectations.txt file.
1322
1323         After this change, the baseline search path will be determined by the type of device running a
1324         test. Device type will be passed into any function which picks a file based on the baseline search
1325         path.
1326
1327         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1328         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1329         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1330         (Manager.run): Print baseline search path for each round of devices.
1331         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1332         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1333         (SingleTestRunner._expected_driver_output): Ditto.
1334         (SingleTestRunner._driver_input): Ditto.
1335         * Scripts/webkitpy/layout_tests/views/printing.py:
1336         (Printer.print_config): Move printing of baseline search path to a separate function.
1337         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1338         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1339         (Testprinter.test_print_config):
1340         (Testprinter.test_print_baseline_search_path):
1341         * Scripts/webkitpy/port/base.py:
1342         (Port.baseline_search_path): Pass device_type through.
1343         (Port._expected_baselines_for_suffixes): Ditto.
1344         (Port.expected_baselines): Ditto.
1345         (Port.expected_filename): Ditto.
1346         (Port.expected_checksum): Ditto.
1347         (Port.expected_image): Ditto.
1348         (Port.expected_audio): Ditto.
1349         (Port.expected_text): Ditto.
1350         (Port.reference_files): Ditto.
1351         (Port.tests): Ditto.
1352         (Port._expanded_paths): Ditto.
1353         (Port.skipped_layout_tests): Ditto.
1354         (Port.expectations_dict): Ditto.
1355         (Port._port_specific_expectations_files): Ditto.
1356         (Port.expectations_files): Ditto.
1357         (Port.test_search_path): Ditto.
1358         (Port._tests_for_other_platforms): Ditto.
1359         * Scripts/webkitpy/port/base_unittest.py:
1360         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1361         (PortTest.test_nonexistant_expectations): Ditto.
1362         (test_ref_tests_platform_directory): Ditto.
1363         * Scripts/webkitpy/port/darwin.py:
1364         (DarwinPort._port_specific_expectations_files): Accept device_type.
1365         * Scripts/webkitpy/port/driver.py:
1366         (DriverProxy):
1367         (DriverProxy.host): Expose _target_host for device_type information.
1368         * Scripts/webkitpy/port/gtk.py:
1369         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1370         * Scripts/webkitpy/port/ios.py:
1371         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1372         * Scripts/webkitpy/port/mac.py:
1373         (MacPort. default_baseline_search_path): Ditto.
1374         * Scripts/webkitpy/port/port_testcase.py:
1375         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1376         * Scripts/webkitpy/port/test.py:
1377         * Scripts/webkitpy/port/watch.py:
1378         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1379         * Scripts/webkitpy/port/win.py:
1380         (WinPort.test_search_path): Accept, but do not use, device_type.
1381         * Scripts/webkitpy/port/wpe.py:
1382         (WPEPort._port_specific_expectations_files): Ditto.
1383         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1384         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1385
1386 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1387
1388         [LFC] Use the containing block's padding box to position out-of-flow elements.
1389         https://bugs.webkit.org/show_bug.cgi?id=193431
1390
1391         Reviewed by Antti Koivisto.
1392
1393         * LayoutReloaded/misc/LFC-passing-tests.txt:
1394
1395 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1396
1397         Move a test implementation file that got misplaced in the Xcode project
1398
1399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1400
1401 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1402
1403         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1404         r239913, and r239914.
1405         https://bugs.webkit.org/show_bug.cgi?id=193407
1406
1407         These revisions caused an internal failure (Requested by
1408         Truitt on #webkit).
1409
1410         Reverted changesets:
1411
1412         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1413         https://bugs.webkit.org/show_bug.cgi?id=186016
1414         https://trac.webkit.org/changeset/239901
1415
1416         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1417         https://trac.webkit.org/changeset/239909
1418
1419         "Tried to fix the build."
1420         https://trac.webkit.org/changeset/239910
1421
1422         "Fixed iOS builds after r239910."
1423         https://trac.webkit.org/changeset/239912
1424
1425         "More build fixing."
1426         https://trac.webkit.org/changeset/239913
1427
1428         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1429         https://trac.webkit.org/changeset/239914
1430
1431 2019-01-14  Mark Lam  <mark.lam@apple.com>
1432
1433         Re-enable ability to build --cloop builds.
1434         https://bugs.webkit.org/show_bug.cgi?id=192955
1435         <rdar://problem/46882363>
1436
1437         Reviewed by Saam barati and Keith Miller.
1438
1439         The --cloop build option was being ignored this whole time since r236381.
1440         This patch makes it possible to build CLoop builds again.
1441
1442         * Scripts/build-jsc:
1443         * Scripts/webkitperl/FeatureList.pm:
1444         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1445
1446 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1447
1448         webkitpy: Expose device_type from host-like objects
1449         https://bugs.webkit.org/show_bug.cgi?id=193406
1450         <rdar://problem/47262305>
1451
1452         Reviewed by Lucas Forschler.
1453
1454         Devices should expose device_type. As a result, all host objects should
1455         provide a device_type property, even if they do not yet define a device_type.
1456
1457         * Scripts/webkitpy/common/system/systemhost.py:
1458         (SystemHost):
1459         (SystemHost.device_type):
1460         * Scripts/webkitpy/common/system/systemhost_mock.py:
1461         (MockSystemHost):
1462         (MockSystemHost.device_type):
1463         * Scripts/webkitpy/port/device.py:
1464         (Device):
1465         (Device.device_type):
1466         * Scripts/webkitpy/xcode/simulated_device.py:
1467         (SimulatedDeviceManager._find_exisiting_device_for_request):
1468         (SimulatedDeviceManager._disambiguate_device_type):
1469         (SimulatedDeviceManager._does_fulfill_request):
1470         (SimulatedDeviceManager.device_count_for_type):
1471         (SimulatedDeviceManager.initialize_devices):
1472         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1473         (test_available_devices):
1474         (test_swapping_devices):
1475
1476 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1477
1478         webkitpy: Support alternate simctl device list output (Follow-up fix)
1479         https://bugs.webkit.org/show_bug.cgi?id=193362
1480         <rdar://problem/47122965>
1481
1482         Rubber-stamped by Lucas Forschler.
1483
1484         * Scripts/webkitpy/xcode/simulated_device.py:
1485         (SimulatedDeviceManager.populate_available_devices):
1486
1487 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1488
1489         [iOS] Expose SPI to access the current sentence boundary and selection state
1490         https://bugs.webkit.org/show_bug.cgi?id=193398
1491         <rdar://problem/45893108>
1492
1493         Reviewed by Dean Jackson.
1494
1495         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1496         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1497         expected.
1498
1499         * TestWebKitAPI/EditingTestHarness.h:
1500         * TestWebKitAPI/EditingTestHarness.mm:
1501         (-[EditingTestHarness moveBackward]):
1502         (-[EditingTestHarness moveForward]):
1503         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1504
1505         Add a couple of new helper methods on EditingTestHarness.
1506
1507         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1508         (-[SelectionChangeObserver initWithWebView:]):
1509         (-[SelectionChangeObserver webView]):
1510         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1511         (-[SelectionChangeObserver currentSelectionAttributes]):
1512
1513 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1514
1515         [LFC][BFC] Add basic box-sizing support.
1516         https://bugs.webkit.org/show_bug.cgi?id=193392
1517
1518         Reviewed by Antti Koivisto.
1519
1520         * LayoutReloaded/misc/LFC-passing-tests.txt:
1521
1522 2019-01-14  Charlie Turner  <cturner@igalia.com>
1523
1524         [WPE] API test gardening
1525         https://bugs.webkit.org/show_bug.cgi?id=193319
1526
1527         Reviewed by Michael Catanzaro.
1528
1529         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1530         passing tests.
1531
1532 2019-01-14  Charlie Turner  <cturner@igalia.com>
1533
1534         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1535         https://bugs.webkit.org/show_bug.cgi?id=192977
1536
1537         Reviewed by Carlos Garcia Campos.
1538
1539         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1540         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1541         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1542         (TestWebKitAPI::GStreamerTest::SetUp):
1543         (TestWebKitAPI::GStreamerTest::TearDown):
1544         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1545         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1546         (TestWebKitAPI::TEST_F):
1547
1548 2019-01-14  Charlie Turner  <cturner@igalia.com>
1549
1550         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1551         https://bugs.webkit.org/show_bug.cgi?id=193332
1552
1553         Reviewed by Michael Catanzaro.
1554
1555         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1556         defined as a char16_t, which changed in ICU 59, the
1557         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1558         unsigned short. This test is relying on the behaviour that
1559         UChar=unsigned short, which doesn't hold across platforms and ICU
1560         library versions. The full fix would be a special syntax for
1561         literal characters so that these ambiguities do not arise. That
1562         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1563         (TestWebKitAPI::TEST):
1564
1565 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1566
1567         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1568
1569         * Scripts/make-dist:
1570         (Distcheck.configure):
1571
1572 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1573
1574         [ews-build] Update macOS queue configurations
1575         https://bugs.webkit.org/show_bug.cgi?id=193365
1576         <rdar://problem/47221073>
1577
1578         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1579
1580         * BuildSlaveSupport/ews-build/config.json:
1581
1582 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1583
1584         [LFC] Adjust assert for statically positioned fixed elements
1585         https://bugs.webkit.org/show_bug.cgi?id=193385
1586
1587         Reviewed by Antti Koivisto.
1588
1589         * LayoutReloaded/misc/LFC-passing-tests.txt:
1590
1591 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1592
1593         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1594         https://bugs.webkit.org/show_bug.cgi?id=193387
1595
1596         Reviewed by Carlos Garcia Campos.
1597
1598         * MiniBrowser/wpe/main.cpp:
1599         (main):
1600
1601 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1602
1603         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1604         https://bugs.webkit.org/show_bug.cgi?id=191655
1605         rdar://problem/46074680
1606
1607         Reviewed by Megan Gardner.
1608
1609         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1610         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1611
1612 2019-01-12  Dan Bernstein  <mitz@apple.com>
1613
1614         [Cocoa] Avoid importing directly from subumbrella frameworks
1615         https://bugs.webkit.org/show_bug.cgi?id=186016
1616         <rdar://problem/40591038>
1617
1618         Reviewed by Sam Weinig.
1619
1620         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1621           LaunchServices header.
1622         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1623           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1624         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1625           when using SDKs earlier than 10.13.
1626         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1627           and OTHER_CPLUSPLUSFLAGS.
1628         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1629           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1630         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1631           LaunchServices header.
1632
1633 2019-01-11  John Wilander  <wilander@apple.com>
1634
1635         Compile out Web API Statistics Collection
1636         https://bugs.webkit.org/show_bug.cgi?id=193370
1637         <rdar://problem/45388584>
1638
1639         Reviewed by Brent Fulgham.
1640
1641         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1642             Defined ENABLE_WEB_API_STATISTICS, off by default.
1643
1644 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1645
1646         [WPE] Add gtk-doc
1647         https://bugs.webkit.org/show_bug.cgi?id=178900
1648
1649         Reviewed by Michael Catanzaro.
1650
1651         Add Tools/gtkdoc to manifest.txt.in files.
1652         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1653
1654         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1655         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1656
1657 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1658
1659         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1660         https://bugs.webkit.org/show_bug.cgi?id=193364
1661         <rdar://problem/47214117>
1662
1663         Reviewed by Tim Horton.
1664
1665         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1666         precise, whereas dragging near the middle of the textarea does.
1667
1668         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1669         (TestWebKitAPI::TEST):
1670
1671 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1672
1673         webkitpy: Support alternate simctl device list output
1674         https://bugs.webkit.org/show_bug.cgi?id=193362
1675         <rdar://problem/47122965>
1676
1677         Reviewed by Lucas Forschler.
1678
1679         * Scripts/webkitpy/xcode/simulated_device.py:
1680         (SimulatedDeviceManager.populate_available_devices):
1681
1682 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1683
1684         [ews-build] Update macOS queue configurations
1685         https://bugs.webkit.org/show_bug.cgi?id=193365
1686
1687         Reviewed by Lucas Forschler.
1688
1689         * BuildSlaveSupport/ews-build/config.json:
1690
1691 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1692
1693         webkitpy: Incorporate device type into baseline search path
1694         https://bugs.webkit.org/show_bug.cgi?id=193356
1695         <rdar://problem/47215515>
1696
1697         Reviewed by Lucas Forschler.
1698
1699         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1700
1701         * Scripts/webkitpy/port/base.py:
1702         (Port.default_baseline_search_path): Allow device type to be passed in.
1703         * Scripts/webkitpy/port/gtk.py:
1704         (GtkPort.default_baseline_search_path): Ignore device type.
1705         * Scripts/webkitpy/port/ios.py:
1706         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1707         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1708         * Scripts/webkitpy/port/ios_device_unittest.py:
1709         (IOSDeviceTest):
1710         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1711         (IOSSimulatorTest):
1712         * Scripts/webkitpy/port/mac.py:
1713         (MacPort.default_baseline_search_path): Ignore device type.
1714         * Scripts/webkitpy/port/watch.py:
1715         (WatchPort.default_baseline_search_path): Ditto.
1716         * Scripts/webkitpy/port/win.py:
1717         (WinPort.default_baseline_search_path): Ditto.
1718         (WinCairoPort.default_baseline_search_path): Ditto.
1719         * Scripts/webkitpy/port/wpe.py:
1720         (WPEPort.default_baseline_search_path): Ditto.
1721
1722 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1723
1724         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1725         https://bugs.webkit.org/show_bug.cgi?id=193352
1726         <rdar://problem/47210736>
1727
1728         Reviewed by Lucas Forschler.
1729
1730         * Scripts/webkitpy/layout_tests/views/printing.py:
1731         (Printer.print_config): Print list on only baseline search paths which exist. 
1732         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1733         (Testprinter.test_print_config):
1734
1735 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1736
1737         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1738         https://bugs.webkit.org/show_bug.cgi?id=193340
1739
1740         Reviewed by David Kilzer.
1741
1742         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1743         (WTR::InjectedBundle::didReceiveMessageToPage):
1744         Pull the strings out into a WKRetainPtr.
1745
1746         * WebKitTestRunner/WebNotificationProvider.cpp:
1747         (WTR::WebNotificationProvider::closeWebNotification):
1748         Adopt the created value into the WKRetainPtr.
1749
1750         * WebKitTestRunner/mac/TestControllerMac.mm:
1751         (WTR::generateWhitelist):
1752         Immediately adopt a created value to avoid potential mistakes.
1753
1754 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1755
1756         Enable DFG on ARM/Linux again
1757         https://bugs.webkit.org/show_bug.cgi?id=192496
1758
1759         Reviewed by Yusuke Suzuki.
1760
1761         After changing the bytecode format DFG was disabled on all 32-bit
1762         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1763         on ARM by default.
1764
1765         * Scripts/run-jsc-stress-tests:
1766
1767 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1768
1769         Unreviewed, fix #ifdef in API test added in r239851.
1770         https://bugs.webkit.org/show_bug.cgi?id=193327
1771         rdar://problem/47093222
1772
1773         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1774
1775 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1776
1777         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1778         https://bugs.webkit.org/show_bug.cgi?id=193109
1779         <rdar://problem/44807048>
1780
1781         Reviewed by Ryosuke Niwa.
1782
1783         Introduce and respect a test option to enable the UndoManager API.
1784
1785         * WebKitTestRunner/TestController.cpp:
1786         (WTR::updateTestOptionsFromTestHeader):
1787         * WebKitTestRunner/TestOptions.h:
1788         (WTR::TestOptions::hasSameInitializationOptions const):
1789         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1790         (WTR::TestController::platformCreateWebView):
1791
1792 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1793
1794         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1795         https://bugs.webkit.org/show_bug.cgi?id=193346
1796
1797         Reviewed by Antti Koivisto.
1798
1799         * LayoutReloaded/misc/LFC-passing-tests.txt:
1800
1801 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1802
1803         Unreviewed, fix typo that breaks dashboard link.
1804
1805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1806         (WebKitBuildbot):
1807
1808 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1809
1810         Update macOS queue configurations
1811         https://bugs.webkit.org/show_bug.cgi?id=193329
1812
1813         Reviewed by Alexey Proskuryakov.
1814
1815         * BuildSlaveSupport/build.webkit.org-config/config.json:
1816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1817         (BubbleQueueServer):
1818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1820         (WebKitBuildbot):
1821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1822         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1823         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1824
1825 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1826
1827         MiniBrowser should be able to navigate to about:blank
1828         https://bugs.webkit.org/show_bug.cgi?id=193345
1829
1830         Reviewed by Simon Fraser.
1831
1832         * MiniBrowser/mac/BrowserWindowController.m:
1833         (-[BrowserWindowController addProtocolIfNecessary:]):
1834         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1835
1836         * MiniBrowser/mac/WK1BrowserWindowController.m:
1837         (-[WK1BrowserWindowController fetch:]):
1838         * MiniBrowser/mac/WK2BrowserWindowController.m:
1839         (-[WK2BrowserWindowController fetch:]):
1840         Clean up the code that uses this to match style.
1841
1842 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1843
1844         Remove MiniBrowser custom "Process Swap" menu item which does not work
1845         https://bugs.webkit.org/show_bug.cgi?id=193344
1846
1847         Reviewed by Simon Fraser.
1848
1849         There is a menu item under the Experimental menu that does work.
1850
1851         * MiniBrowser/mac/AppDelegate.m:
1852         (defaultConfiguration):
1853         * MiniBrowser/mac/SettingsController.h:
1854         * MiniBrowser/mac/SettingsController.m:
1855         (-[SettingsController _populateMenu]):
1856         (-[SettingsController validateMenuItem:]):
1857         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1858         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1859
1860 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1861
1862         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1863         https://bugs.webkit.org/show_bug.cgi?id=193327
1864         rdar://problem/47093222
1865
1866         Reviewed by Tim Horton.
1867
1868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1869         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1870         (TestWebKitAPI::didFinishNavigation):
1871         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1872         (TestWebKitAPI::TEST):
1873         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1874         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1875         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1876         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1877         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1878
1879 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1880
1881         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1882         https://bugs.webkit.org/show_bug.cgi?id=193338
1883         <rdar://problem/46664774>
1884
1885         Reviewed by David Kilzer.
1886
1887         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1888         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1889
1890 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1891
1892         Unreviewed, rolling out r239825.
1893         https://bugs.webkit.org/show_bug.cgi?id=193330
1894
1895         Broke tests on armv7/linux bots (Requested by guijemont on
1896         #webkit).
1897
1898         Reverted changeset:
1899
1900         "Enable DFG on ARM/Linux again"
1901         https://bugs.webkit.org/show_bug.cgi?id=192496
1902         https://trac.webkit.org/changeset/239825
1903
1904 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1905
1906         Disable the run-jsc-stress-test remote host key check.
1907         https://bugs.webkit.org/show_bug.cgi?id=192988
1908
1909         Reviewed by Alexey Proskuryakov.
1910
1911         * Scripts/run-jsc-stress-tests:
1912
1913 2019-01-10  John Wilander  <wilander@apple.com>
1914
1915         Override the session configuration for cookieAcceptPolicy
1916         https://bugs.webkit.org/show_bug.cgi?id=190925
1917         <rdar://problem/45497382>
1918
1919         Reviewed by Alexey Proskuryakov and Alex Christensen.
1920
1921         Test infrastructure for setting a first-party-only cookie policy.
1922
1923         * DumpRenderTree/TestRunner.cpp:
1924         (setOnlyAcceptFirstPartyCookiesCallback):
1925         (TestRunner::staticFunctions):
1926         * DumpRenderTree/TestRunner.h:
1927         * DumpRenderTree/mac/TestRunnerMac.mm:
1928         (TestRunner::setOnlyAcceptFirstPartyCookies):
1929         * DumpRenderTree/win/TestRunnerWin.cpp:
1930         (TestRunner::setOnlyAcceptFirstPartyCookies):
1931         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1932         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1933         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1934         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1935         * WebKitTestRunner/TestInvocation.cpp:
1936         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1937
1938 2019-01-09  Matt Rajca  <mrajca@apple.com>
1939
1940         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1941         https://bugs.webkit.org/show_bug.cgi?id=193301
1942
1943         Reviewed by Jer Noble.
1944         
1945         Added API tests.
1946
1947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1948         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1949         (TEST):
1950         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1951
1952 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1953
1954         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1955         https://bugs.webkit.org/show_bug.cgi?id=193310
1956
1957         Reviewed by Antti Koivisto.
1958
1959         * LayoutReloaded/misc/LFC-passing-tests.txt:
1960
1961 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1962
1963         Enable DFG on ARM/Linux again
1964         https://bugs.webkit.org/show_bug.cgi?id=192496
1965
1966         Reviewed by Yusuke Suzuki.
1967
1968         After changing the bytecode format DFG was disabled on all 32-bit
1969         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1970         on ARM by default.
1971
1972         * Scripts/run-jsc-stress-tests:
1973
1974 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1975
1976         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
1977         https://bugs.webkit.org/show_bug.cgi?id=193271
1978
1979         Reviewed by Brent Fulgham.
1980
1981         BSTR is a special data structure created by SysAllocString, not a
1982         wchar_t null-terminated string.
1983
1984         * DumpRenderTree/win/TestRunnerWin.cpp:
1985         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
1986         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1987         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
1988         BSTR from wide string literals.
1989
1990 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
1991
1992         Tweak wording for build/version_check style checker error
1993         https://bugs.webkit.org/show_bug.cgi?id=193256
1994
1995         Reviewed by Tim Horton.
1996
1997         * Scripts/webkitpy/style/checkers/cpp.py:
1998         (check_os_version_checks):
1999         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2000         (WebKitStyleTest.test_os_version_checks):
2001
2002 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2003
2004         [ews-build] Add link to bug along with bug title
2005         https://bugs.webkit.org/show_bug.cgi?id=193293
2006
2007         Reviewed by Lucas Forschler.
2008
2009         * BuildSlaveSupport/ews-build/steps.py:
2010         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2011         (ConfigureBuild.add_bug_id_url): Deleted.
2012         (ConfigureBuild.getBugURL): Deleted.
2013
2014 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2015
2016         [ews-build] Use https for ews-build server
2017         https://bugs.webkit.org/show_bug.cgi?id=193193
2018
2019         Reviewed by Lucas Forschler.
2020
2021         * BuildSlaveSupport/ews-build/steps.py:
2022
2023 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2024
2025         [ews-build] Parse and display number of style failures
2026         https://bugs.webkit.org/show_bug.cgi?id=193280
2027
2028         Reviewed by Lucas Forschler.
2029
2030         * BuildSlaveSupport/ews-build/steps.py:
2031         (CheckStyle): Use TestWithFailureCount as base class.
2032         (CheckStyle.countFailures): Count the number of style failures.
2033
2034 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2035
2036         [ews-build] use patch_id instead of ewspatchid
2037         https://bugs.webkit.org/show_bug.cgi?id=193235
2038
2039         Reviewed by Lucas Forschler.
2040
2041         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2042         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2043         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2044
2045 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2046
2047         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2048         https://bugs.webkit.org/show_bug.cgi?id=192625
2049
2050         Reviewed by Antti Koivisto.
2051
2052         * LayoutReloaded/misc/LFC-passing-tests.txt:
2053
2054 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2055
2056         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2057         https://bugs.webkit.org/show_bug.cgi?id=192841
2058
2059         Reviewed by Carlos Garcia Campos.
2060
2061         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2062         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2063         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2064
2065         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2066
2067         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2068         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2069         (WebKitWebEditorTest::testSelectionChanged):
2070         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2071         (WebKitFrameTest::testMainFrame):
2072         (WebKitFrameTest::testURI):
2073         (WebKitFrameTest::testJavaScriptContext):
2074         (WebKitFrameTest::testJavaScriptValues):
2075         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2076         (testWebViewAuthenticationRequest):
2077         (testWebViewAuthenticationLoadCancelled):
2078         (testWebViewAuthenticationFailure):
2079         (testWebViewAuthenticationStorage):
2080         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2081         (testWebViewAuthenticationProxy):
2082         (testWebViewAuthenticationProxyHTTPS):
2083         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2084         (testAutomationSessionRequestSession):
2085         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2086         (testBackForwardListNavigation):
2087         (testWebKitWebViewSessionState):
2088         (testWebKitWebViewSessionStateWithFormData):
2089         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2090         (ConsoleMessageTest::consoleMessageReceivedCallback):
2091         (testWebKitConsoleMessageConsoleAPI):
2092         (testWebKitConsoleMessageJavaScriptException):
2093         (testWebKitConsoleMessageNetworkError):
2094         (testWebKitConsoleMessageSecurityError):
2095         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2096         (testCookieManagerAcceptPolicy):
2097         (testCookieManagerCookiesChanged):
2098         (testCookieManagerPersistentStorage):
2099         (testCookieManagerPersistentStorageDeleteAll):
2100         (testCookieManagerEphemeral):
2101         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2102         (testWebKitDOMElementAutoFill):
2103         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2104         (downloadLocalFileSuccessfully):
2105         (createFileAtDestination):
2106         (testDownloadOverwriteDestinationDisallowed):
2107         (testDownloadLocalFileError):
2108         (testDownloadRemoteFile):
2109         (testDownloadRemoteFileError):
2110         (testWebViewDownloadURI):
2111         (testPolicyResponseDownload):
2112         (testPolicyResponseDownloadCancel):
2113         (testDownloadMIMEType):
2114         (contextMenuCallback):
2115         (testContextMenuDownloadActions):
2116         (testBlobDownload):
2117         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2118         (testWebKitWebEditorSelectionChanged):
2119         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2120         (testWebKitFrameMainFrame):
2121         (testWebKitFrameURI):
2122         (testWebKitFrameJavaScriptContext):
2123         (testWebKitFrameJavaScriptValues):
2124         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2125         (LoadStopTrackingTest::loadFailed):
2126         (testWebViewTitle):
2127         (testURIRequestHTTPHeaders):
2128         (testURIRequestHTTPMethod):
2129         (testURIResponseHTTPHeaders):
2130         (testRedirectToDataURI):
2131         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2132         (testProcessPerWebView):
2133         (testWebProcessLimit):
2134         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2135         (testWebViewResources):
2136         (testWebResourceLoading):
2137         (testWebResourceSuggestedFilename):
2138         (testWebResourceGetData):
2139         (testWebResourceGetDataError):
2140         (testWebViewResourcesHistoryCache):
2141         (testWebResourceSendRequest):
2142         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2143         (testSSL):
2144         (testInsecureContent):
2145         (testTLSErrorsPolicy):
2146         (testTLSErrorsRedirect):
2147         (testTLSErrorsHTTPAuth):
2148         (testLoadFailedWithTLSErrors):
2149         (testSubresourceLoadFailedWithTLSErrors):
2150         (httpsServerCallback):
2151         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2152         (testWebViewCreateNavigationData):
2153         (testWebViewJavaScriptDialogs):
2154         (testWebViewWindowProperties):
2155         (testWebViewMouseTarget):
2156         (testWebViewFileChooserRequest):
2157         (testWebViewColorChooserRequest):
2158         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2159         (testWebExtensionGetTitle):
2160         (testDocumentLoadedSignal):
2161         (testWebKitWebViewProcessCrashed):
2162         (testWebExtensionWindowObjectCleared):
2163         (testWebExtensionIsolatedWorld):
2164         (permissionRequestCallback):
2165         (didAssociateFormControlsCallback):
2166         (testWebExtensionFormControlsAssociated):
2167         (FormSubmissionTest::FormSubmissionTest):
2168         (FormSubmissionTest::testFormSubmissionResult):
2169         (testWebExtensionFormSubmissionSteps):
2170         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2171         (testNotInitialized):
2172         (testClearDatabase):
2173         (testPrivateBrowsing):
2174         (testGetFavicon):
2175         (testWebViewFavicon):
2176         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2177         (testFindControllerTextFound):
2178         (testFindControllerTextNotFound):
2179         (testFindControllerMatchCount):
2180         (testFindControllerMaxMatchCount):
2181         (testFindControllerNext):
2182         (testFindControllerPrevious):
2183         (testFindControllerCountedMatches):
2184         (testFindControllerOptions):
2185         (testFindControllerHide):
2186         (testFindControllerInstance):
2187         (testFindControllerGetters):
2188         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2189         (testNavigationPolicy):
2190         (testResponsePolicy):
2191         (testNewWindowPolicy):
2192         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2193         (testSecurityOriginBasicConstructor):
2194         (testSecurityOriginURIConstructor):
2195         (testSecurityOriginDefaultPort):
2196         (testSecurityOriginFileURI):
2197         (testOpaqueSecurityOrigin):
2198         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2199         (testWebKitSettings):
2200         (testWebKitSettingsNewWithSettings):
2201         (testWebKitSettingsUserAgent):
2202         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2203         (testWebViewNewWithUserContentManager):
2204         (isStyleSheetInjectedForURLAtPath):
2205         (isScriptInjectedForURLAtPath):
2206         (testUserContentManagerInjectedStyleSheet):
2207         (testUserContentManagerInjectedScript):
2208         (UserScriptMessageTest::scriptMessageReceived):
2209         (UserScriptMessageTest::waitUntilMessageReceived):
2210         (UserScriptMessageTest::runJavaScriptFinished):
2211         (testUserContentManagerScriptMessageReceived):
2212         (testUserContentManagerScriptMessageInWorldReceived):
2213         (testUserContentManagerScriptMessageFromDOMBindings):
2214         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2215         (testWebContextDefault):
2216         (testWebContextEphemeral):
2217         (testWebContextGetPlugins):
2218         (testWebContextURIScheme):
2219         (testWebContextSpellChecker):
2220         (testWebContextLanguages):
2221         (consoleMessageReceivedCallback):
2222         (testWebContextSecurityFileXHR):
2223         (ProxyTest::ProxyTest):
2224         (testWebContextProxySettings):
2225         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2226         (testWebViewWebContext):
2227         (testWebViewWebBackend):
2228         (testWebViewEphemeral):
2229         (testWebViewCustomCharset):
2230         (testWebViewSettings):
2231         (testWebViewRunJavaScript):
2232         (testWebViewCanShowMIMEType):
2233         (testWebViewSubmitForm):
2234         (testWebViewSave):
2235         (testWebViewPageVisibility):
2236         (testWebViewSnapshot):
2237         (testWebViewNotification):
2238         (testWebViewNotificationInitialPermissionAllowed):
2239         (testWebViewNotificationInitialPermissionDisallowed):
2240         (testWebViewIsPlayingAudio):
2241         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2242         (WebsiteDataTest::WebsiteDataTest):
2243         (WebsiteDataTest::remove):
2244         (WebsiteDataTest::clear):
2245         (testWebsiteDataConfiguration):
2246         (testWebsiteDataEphemeral):
2247         (testWebsiteDataCache):
2248         (testWebsiteDataStorage):
2249         (testWebsiteDataDatabases):
2250         (testWebsiteDataAppcache):
2251         (testWebsiteDataCookies):
2252         (testWebsiteDataDeviceIdHashSalt):
2253         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2254         (emitDocumentLoaded):
2255         (emitURIChanged):
2256         (sendRequestCallback):
2257         (contextMenuCallback):
2258         (consoleMessageSentCallback):
2259         (emitFormControlsAssociated):
2260         (formControlsAssociatedCallback):
2261         (emitFormSubmissionEvent):
2262         (willSubmitFormCallback):
2263         (windowObjectCleared):
2264         (methodCallCallback):
2265         (registerGResource):
2266         (webkit_web_extension_initialize_with_user_data):
2267         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2268         (checkLeaks):
2269         (WebProcessTest::create):
2270         (runTest):
2271         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2272         (AutocleanupsTest::testWebProcessAutocleanups):
2273         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2274         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2275         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2276         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2277         (WebKitDOMDOMWindowTest::testSignals):
2278         (WebKitDOMDOMWindowTest::testDispatchEvent):
2279         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2280         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2281         (WebKitDOMNodeFilterTest::testTreeWalker):
2282         (WebKitDOMNodeFilterTest::testNodeIterator):
2283         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2284         (WebKitDOMNodeTest::testHierarchyNavigation):
2285         (WebKitDOMNodeTest::testInsertion):
2286         (WebKitDOMNodeTest::testTagNamesNodeList):
2287         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2288         (WebKitDOMNodeTest::testDOMCache):
2289         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2290         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2291         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2292         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2293         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2294         (testUIProcessAutocleanups):
2295         (testWebProcessAutocleanups):
2296         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2297         (testContextMenuPopulateMenu):
2298         (testContextMenuDismissed):
2299         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2300         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2301         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2302         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2303         (testWebKitDOMDOMWindowSignals):
2304         (testWebKitDOMDOMWindowDispatchEvent):
2305         (testWebKitDOMDOMWindowGetComputedStyle):
2306         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2307         (testWebKitDOMNodeHierarchyNavigation):
2308         (testWebKitDOMNodeInsertion):
2309         (testWebKitDOMNodeTagNamesNodeList):
2310         (testWebKitDOMNodeTagNamesHTMLCollection):
2311         (testWebKitDOMObjectCache):
2312         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2313         (testWebKitDOMNodeFilterTreeWalker):
2314         (testWebKitDOMNodeFilterNodeIterator):
2315         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2316         (testWebKitDOMXPathNSResolverNative):
2317         (testWebKitDOMXPathNSResolverCustom):
2318         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2319         (testInspectorDefault):
2320         (testInspectorManualAttachDetach):
2321         (testInspectorCustomContainerDestroyed):
2322         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2323         (startTestServer):
2324         (testInspectorServerPageList):
2325         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2326         (OptionMenuTest::showOptionMenuCallback):
2327         (OptionMenuTest::menuCloseCallback):
2328         (OptionMenuTest::close):
2329         (OptionMenuTest::activateItem):
2330         (OptionMenuTest::selectItem):
2331         (testOptionMenuSimple):
2332         (testOptionMenuGroups):
2333         (testOptionMenuActivate):
2334         (testOptionMenuSelect):
2335         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2336         (testPrintOperationPrintSettings):
2337         (webViewPrintCallback):
2338         (testPrintOperationPrint):
2339         (testPrintCustomWidget):
2340         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2341         (checkAtspiAccessible):
2342         (testAtspiBasicHierarchy):
2343         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2344         (testWebKitCheckVersion):
2345         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2346         (testWebViewEditorCutCopyPasteNonEditable):
2347         (testWebViewEditorCutCopyPasteEditable):
2348         (testWebViewEditorSelectAllNonEditable):
2349         (testWebViewEditorSelectAllEditable):
2350         (loadContentsAndTryToCutSelection):
2351         (testWebViewEditorNonEditable):
2352         (testWebViewEditorEditable):
2353         (testWebViewEditorEditorStateTypingAttributes):
2354         (testWebViewEditorInsertImage):
2355         (testWebViewEditorCreateLink):
2356         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2357         (loadChangedCallback):
2358         (loadFailedCallback):
2359         (loadFailedWithTLSErrorsCallback):
2360         (LoadTrackingTest::LoadTrackingTest):
2361         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2362         (registerGResource):
2363         (removeNonEmptyDirectory):
2364         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2365         (Test::adoptView):
2366         (Test::~Test):
2367         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2368         (WebKitTestBus::getOrCreateConnection):
2369         (WebKitTestBus::createProxy):
2370         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2371         (WebKitTestServer::getWebSocketURIForPath const):
2372         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2373         (WebViewTest::initializeWebView):
2374         (WebViewTest::loadURI):
2375         (WebViewTest::loadHtml):
2376         (WebViewTest::loadPlainText):
2377         (WebViewTest::loadBytes):
2378         (WebViewTest::loadRequest):
2379         (WebViewTest::loadAlternateHTML):
2380         (WebViewTest::goBack):
2381         (WebViewTest::goForward):
2382         (WebViewTest::goToBackForwardListItem):
2383         (resourceGetDataCallback):
2384         (WebViewTest::mainResourceData):
2385         (WebViewTest::javascriptResultToCString):
2386         (WebViewTest::javascriptResultToNumber):
2387         (WebViewTest::javascriptResultToBoolean):
2388         (WebViewTest::javascriptResultIsNull):
2389         (WebViewTest::javascriptResultIsUndefined):
2390         (onSnapshotReady):
2391         (WebViewTest::runWebProcessTest):
2392         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2393         (WebViewTest::platformInitializeWebView):
2394         (WebViewTest::showInWindow):
2395         (WebViewTest::showInWindowAndWaitUntilMapped):
2396         (WebViewTest::mouseMoveTo):
2397         (WebViewTest::emitPopupMenuSignal):
2398         (WebViewTest::keyStroke):
2399         (WebViewTest::doMouseButtonEvent):
2400
2401 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2402
2403         [WPE] API tests can't run in flatpak environment
2404         https://bugs.webkit.org/show_bug.cgi?id=193242
2405
2406         Reviewed by Michael Catanzaro.
2407
2408         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2409         flatpakutils so that it knows which port it's dealing with.
2410         * glib/common.py: Remove build_dir globals so that subsequent
2411         calls actually take args into account.
2412         (library_build_path):
2413         (binary_build_path):
2414
2415 2019-01-08  Dean Jackson  <dino@apple.com>
2416
2417         Blob references for System Previews don't get a correct file extension
2418         https://bugs.webkit.org/show_bug.cgi?id=193268
2419         <rdar://problem/47133037>
2420
2421         Reviewed by Tim Horton.
2422
2423         New test that a Blob download of a USDZ file gets named correctly.
2424
2425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2426         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2427         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2428         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2429         (TEST):
2430         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2431
2432 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2433
2434         [WebAuthN] Support U2F HID Authenticators on macOS
2435         https://bugs.webkit.org/show_bug.cgi?id=191535
2436         <rdar://problem/47102027>
2437
2438         Reviewed by Brent Fulgham.
2439
2440         This patch:
2441         1) adds support for U2F mocking mechanism;
2442         2) updates tests to reflect U2fCommandConstructor changes.
2443
2444         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2445         (TestWebKitAPI::TEST):
2446         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2447         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2448         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2449
2450 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2451
2452         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2453         https://bugs.webkit.org/show_bug.cgi?id=193229
2454         <rdar://problem/46717097>
2455
2456         Reviewed by Tim Horton.
2457
2458         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2459         prevents a drag from starting.
2460
2461         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2462         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2463
2464         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2465
2466 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2467   
2468         Layout test will generate a perf metric file to results dir.
2469         https://bugs.webkit.org/show_bug.cgi?id=192030
2470         <rdar://problem/32779516>
2471
2472         Reviewed by Aakash Jain.
2473
2474         Layout test running time will be collected to a perf metric file.
2475         For now, instead of outputing running time of all tests (which is huge),
2476         we aggregate them by test directories which are at most two level deep. 
2477
2478         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2479         (Manager._end_test_run):
2480         (Manager._output_perf_metrics):
2481         (Manager._print_expectation_line_for_test):
2482         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2483         (add_test_perf_metric):
2484         (test_perf_metrics):
2485         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2486         (JSONGeneratorTest.test_test_timings_trie):
2487         (JSONGeneratorTest):
2488         (JSONGeneratorTest.test_test_perf_metrics):
2489         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2490         (RebaselineTest.test_reset_results):
2491         (RebaselineTest.test_missing_results):
2492         (RebaselineTest.test_new_baseline):
2493
2494 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2495
2496         [WPE][GTK] Add php-json to install-dependencies
2497         https://bugs.webkit.org/show_bug.cgi?id=193233
2498
2499         Reviewed by Michael Catanzaro.
2500
2501         * gtk/install-dependencies:
2502         * wpe/install-dependencies:
2503
2504 2019-01-08  Chris Dumez  <cdumez@apple.com>
2505
2506         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2507         https://bugs.webkit.org/show_bug.cgi?id=193224
2508         <rdar://problem/47097726>
2509
2510         Reviewed by Alex Christensen.
2511
2512         Add API test coverage.
2513
2514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2515
2516 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2517
2518         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2519         <https://webkit.org/b/193222>
2520         <rdar://problem/46862309>
2521
2522         Reviewed by Joseph Pecoraro.
2523
2524         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2525         (WTR::executeCallback): Fix camel case of variable name.
2526         (WTR::EventSendingController::callAfterScrollingCompletes): If
2527         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2528         false, make sure to release the ScrollCompletionCallbackData
2529         object.  This fixes the leak.
2530
2531 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2532
2533         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2534         https://bugs.webkit.org/show_bug.cgi?id=193044
2535
2536         Reviewed by Daniel Bates.
2537
2538         WinCairo EWS bots are using Windows Perl. Binary files should be
2539         opened as binary mode.
2540
2541         * Scripts/svn-apply:
2542         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2543
2544 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2545
2546         [CMake] Add ENABLE_CSS_TYPED_OM option
2547         https://bugs.webkit.org/show_bug.cgi?id=193216
2548
2549         Reviewed by Michael Catanzaro.
2550
2551         * Scripts/webkitperl/FeatureList.pm:
2552
2553 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2554
2555         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2556         <https://webkit.org/b/193056>
2557
2558         Reviewed by Alex Christensen.
2559
2560         * Scripts/webkitpy/style/checker.py:
2561         - Ignore use of new runtime/retainptr check in
2562           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2563           contains tests to ensure RetainPtr<NSObject *> is compatible
2564           with RetainPtr<NSObject>.
2565
2566         * Scripts/webkitpy/style/checkers/cpp.py:
2567         (check_language):
2568         (CppChecker):
2569         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2570           was used instead of a single regex so that angle brackets
2571           could be matched up when checking the type contained within
2572           the RetainPtr<> type.
2573
2574         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2575         (CppStyleTest):
2576         - Add unit test for new runtime/retainptr check.
2577
2578         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2579         * TestWebKitAPI/EditingTestHarness.h:
2580         - Remove '*' from RetainPtr<> type.
2581
2582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2583         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2584           regressed in r201938.
2585
2586         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2587         (TestWebKitAPI::TEST):
2588         - Update tests to match RetainPtr.mm tests (except for the
2589           `*SimilarNSType` tests since there is no CF equivalent of
2590           RetainPtr<NSString> and RetainPtr<NSString *>).
2591
2592         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2593         (TestWebKitAPI::TEST):
2594         - Update tests to:
2595           - Not conflict by name with equivalent CF tests in
2596             RetainPtr.cpp.
2597           - Add test cases for RetainPtr<NSObject>,
2598             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2599           - Add `*SimilarNSType` tests for converting between
2600             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2601           - Change `0` to `nil` as appropriate.
2602           - Re-alphabetize the tests by name.
2603           - Add Optional<RetainPtr<>> tests.
2604           - Add retainPtr() tests.
2605
2606         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2607         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2608         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2609         (TEST):
2610         - Remove '*' from RetainPtr<> type.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2613         (TEST(WebKit, JITEnabled)):
2614         - Add missing WTFMove().  Apparently a temporary was being
2615           created before in the argument list due to mismatched
2616           RetainPtr<> types.
2617
2618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2619         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2620         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2621         (TestWebKitAPI::TEST):
2622         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2623         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2624         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2625         (WTR::resourcesDirectoryURL):
2626         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2627         (WTR::InjectedBundle::platformInitialize):
2628         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2629         - Remove '*' from RetainPtr<> type.
2630
2631 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2632
2633         A MediaTime timescale must never be zero
2634         https://bugs.webkit.org/show_bug.cgi?id=193156
2635         <rdar://problem/32504501>
2636
2637         Reviewed by Jer Noble.
2638
2639         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2640         (TestWebKitAPI::TEST): Add tests for zero timescale.
2641
2642 2019-01-07  Youenn Fablet  <youenn@apple.com>
2643
2644         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2645         https://bugs.webkit.org/show_bug.cgi?id=193175
2646
2647         Reviewed by Chris Dumez.
2648
2649         Updated API test as we bumped the SW schema to version 4.
2650
2651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2652         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2653         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2654         (TEST):
2655
2656 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2657
2658         [Win][Clang] Fix compilation warnings of MiniBrowser
2659         https://bugs.webkit.org/show_bug.cgi?id=193029
2660
2661         Reviewed by Ross Kirsling.
2662
2663         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2664         and m_URLBarFont. Reorder member variables to fix -Wreorder
2665         warning.
2666         * MiniBrowser/win/PageLoadTestClient.cpp:
2667         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2668         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2669         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2670         m_currentURLIndex.
2671         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2672         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2673         navigationClient with '{ }' to fix the missing field warning.
2674         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2675         (initDocStruct): Changed the argument type docname to const.
2676
2677 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2678
2679         [WebAuthN] Import U2F command/response converters from Chromium
2680         https://bugs.webkit.org/show_bug.cgi?id=193150
2681         <rdar://problem/47054028>
2682
2683         Reviewed by Brent Fulgham.
2684
2685         Adds API tests.
2686
2687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2688         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2689         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2690         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2691         (TestWebKitAPI::getTestAttestationObjectBytes):
2692         (TestWebKitAPI::getTestSignResponse):
2693         (TestWebKitAPI::getTestU2fRegisterResponse):
2694         (TestWebKitAPI::TEST):
2695         (TestWebKitAPI::convertToVector): Deleted.
2696         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2697         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2698         (TestWebKitAPI::constructMakeCredentialRequest):
2699         (TestWebKitAPI::constructGetAssertionRequest):
2700         (TestWebKitAPI::TEST):
2701
2702 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2703
2704         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2705         https://bugs.webkit.org/show_bug.cgi?id=193136
2706
2707         Reviewed by Michael Catanzaro.
2708
2709         * gtk/install-dependencies:
2710         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2711         they are needed by update-webkitgtk-libs.
2712
2713 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2714
2715         Unreviewed follow-up fix to r239650
2716         https://bugs.webkit.org/show_bug.cgi?id=193140
2717         <rdar://problem/47063037>
2718
2719         Typecast patch_id to string.
2720
2721         * BuildSlaveSupport/ews-build/steps.py:
2722         (ValidatePatch._is_patch_obsolete):
2723
2724 2019-01-04  Daniel Bates  <dabates@apple.com>
2725
2726         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2727         https://bugs.webkit.org/show_bug.cgi?id=193024
2728
2729         Reviewed by Jer Noble.
2730
2731         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2732         for the bitmask type WebEventFlags as an example.
2733
2734         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2735         that can be used to register summary and synthetic child formatters for a bitmask type.
2736         For example, consider the following enum and bitmask typedefs:
2737
2738         typedef enum {
2739             A = 1 << 0,
2740             B = 1 << 1,
2741             C = 1 << 2,
2742         } SpecialFlagValues;
2743         typedef unsigned SpecialFlags;
2744
2745         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2746         __lldb_init_module():
2747
2748             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2749                     1 << 0: "A",
2750                     1 << 1: "B",
2751                     1 << 2: "C",
2752             })
2753
2754         * lldb/lldb_webkit.py:
2755         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2756         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2757         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2758         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2759         A convenience function to dynamically creaste a synthetic formatter class and summary
2760         string function for the specified bitmask type and enumerator value to name map. This
2761         function register the dynamically created class and function with LLDB.
2762
2763         (__lldb_init_module):
2764         (FlagEnumerationProvider):
2765         (FlagEnumerationProvider._enumerator_value_to_name_map):
2766         (FlagEnumerationProvider._bitmask):
2767         (FlagEnumerationProvider._update):
2768         (FlagEnumerationProvider.has_children):
2769         (FlagEnumerationProvider.num_children):
2770         (FlagEnumerationProvider.get_child_index):
2771         (FlagEnumerationProvider.get_child_at_index):
2772         (FlagEnumerationProvider.update):
2773         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2774
2775         (WTFOptionSetProvider):
2776         (WTFOptionSetProvider._enumerator_value_to_name_map):
2777         (WTFOptionSetProvider._bitmask):
2778         (WTFOptionSetProvider._update):
2779         Write in terms of the base class.
2780
2781         (RawBitmaskProviderBase):
2782         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2783         (RawBitmaskProviderBase._bitmask):
2784         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2785         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2786         {
2787             1 << 0: "A",
2788             1 << 1: "B",
2789             1 << 2: "C",
2790         }
2791         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2792         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2793
2794         (WTFOptionSetProvider.has_children): Deleted.
2795         (WTFOptionSetProvider.num_children): Deleted.
2796         (WTFOptionSetProvider.get_child_index): Deleted.
2797         (WTFOptionSetProvider.get_child_at_index): Deleted.
2798         (WTFOptionSetProvider.update): Deleted.
2799
2800 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2801
2802         [ews-build] Add build step to validate the patch before processing it
2803         https://bugs.webkit.org/show_bug.cgi?id=193140
2804
2805         Reviewed by Lucas Forschler.
2806
2807         * BuildSlaveSupport/ews-build/factories.py:
2808         (Factory.__init__): Added ValidatePatch step.
2809         * BuildSlaveSupport/ews-build/steps.py:
2810         (ValidatePatch):
2811         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2812         (ValidatePatch.get_patch_json): Get patch json data.
2813         (ValidatePatch.get_bug_json): Get bug json data.
2814         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2815         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2816         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2817         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2818         (ValidatePatch.skip_build): Skip the build.
2819         (ValidatePatch.start):
2820
2821 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2822
2823         Progress towards fixing Mac CMake build
2824         https://bugs.webkit.org/show_bug.cgi?id=193105
2825
2826         Reviewed by Don Olmstead.
2827
2828         * TestWebKitAPI/PlatformMac.cmake:
2829
2830 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2831
2832         Fix API test after r239631
2833         https://bugs.webkit.org/show_bug.cgi?id=193118
2834
2835         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2836         (TestWebKitAPI::TEST):
2837         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2838         Do the same thing via the API to fix the test.
2839
2840 2019-01-04  Jer Noble  <jer.noble@apple.com>
2841
2842         [WebKitLegacy] Media playback pauses on scroll
2843         https://bugs.webkit.org/show_bug.cgi?id=192829
2844
2845         Reviewed by Eric Carlson.
2846
2847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2848         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2849         (TestWebKitAPI::TEST):
2850         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2851         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2852         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2853         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2854         (TestWebKitAPI::TEST):
2855
2856 2019-01-04  Chris Dumez  <cdumez@apple.com>
2857
2858         Add support for toggling device orientation API support per site
2859         https://bugs.webkit.org/show_bug.cgi?id=193143
2860         <rdar://problem/46605724>
2861
2862         Reviewed by Alex Christensen.
2863
2864         Add API test coverage.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2867         (-[DataMappingSchemeHandler setTaskHandler:]):
2868         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2869         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2870         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2871         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2872
2873 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2874
2875         [ews-build] use svn-apply script to apply the patches
2876         https://bugs.webkit.org/show_bug.cgi?id=193138
2877
2878         Reviewed by Lucas Forschler.
2879
2880         * BuildSlaveSupport/ews-build/factories.py:
2881         (Factory.__init__): Add the ApplyPatch step.
2882         * BuildSlaveSupport/ews-build/steps.py:
2883         (CheckOutSource): Added step name.
2884         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2885         (ApplyPatch): Build step to apply patch using svn-apply script.
2886         (UnApplyPatchIfRequired):
2887         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2888
2889 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2890
2891         Deprecate WKContextCreate
2892         https://bugs.webkit.org/show_bug.cgi?id=193118
2893
2894         Reviewed by Brady Eidson.
2895
2896         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2897         (WebKitBrowserWindow::WebKitBrowserWindow):
2898         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2899         (TestWebKitAPI::TEST):
2900         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2901         (TestWebKitAPI::TEST):
2902         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2903         (TestWebKitAPI::TEST):
2904         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2905         (TestWebKitAPI::TEST):
2906         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2907         (TestWebKitAPI::TEST):
2908         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2909         (TestWebKitAPI::TEST):
2910         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2911         (TestWebKitAPI::TEST):
2912         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2913         (TestWebKitAPI::TEST):
2914         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2915         (TestWebKitAPI::TEST):
2916         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2917         (TestWebKitAPI::TEST):
2918         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2919         (TestWebKitAPI::TEST):
2920         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2921         (TestWebKitAPI::TEST):
2922         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2923         (TestWebKitAPI::TEST):
2924         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2925         (TestWebKitAPI::TEST):
2926         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2927         (TestWebKitAPI::TEST):
2928         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2929         (TestWebKitAPI::TEST):
2930         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2931         (TestWebKitAPI::TEST):
2932         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2933         (TestWebKitAPI::TEST):
2934         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2935         (TestWebKitAPI::loadAlternateHTMLString):
2936         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2937         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2938         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2939         (TestWebKitAPI::buildAndPerformTest):
2940         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2941         (TestWebKitAPI::TEST):
2942         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2943         (TestWebKitAPI::TEST):
2944         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2945         (TestWebKitAPI::TEST):
2946         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2947         (TestWebKitAPI::TEST):
2948         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2949         (TestWebKitAPI::TEST):
2950         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2951         (TestWebKitAPI::TEST):
2952         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2953         (TestWebKitAPI::TEST):
2954         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2955         (TestWebKitAPI::TEST):
2956         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2957         (TestWebKitAPI::TEST):
2958         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2959         (TestWebKitAPI::TEST):
2960         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2961         (TestWebKitAPI::TEST):
2962         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2963         (TestWebKitAPI::TEST):
2964         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2965         (TestWebKitAPI::TEST):
2966         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2967         (TestWebKitAPI::TEST):
2968         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2969         (TestWebKitAPI::TEST):
2970         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2971         (TestWebKitAPI::TEST):
2972         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2973         (TestWebKitAPI::TEST):
2974         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2975         (TestWebKitAPI::TEST):
2976         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
2977         (TestWebKitAPI::TEST):
2978         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2979         (TestWebKitAPI::TEST):
2980         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2981         (TestWebKitAPI::TEST):
2982         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2983         (TestWebKitAPI::TEST):
2984         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2985         (TestWebKitAPI::TEST):
2986         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
2987         (TestWebKitAPI::TEST):
2988         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2989         (TestWebKitAPI::TEST):
2990         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2991         (TestWebKitAPI::TEST):
2992         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2993         (WebKit2_CommandBackForwardTestWKView::SetUp):
2994         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2995         (TestWebKitAPI::TEST):
2996         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2997         (TestWebKitAPI::TEST):
2998         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
2999         (TestWebKitAPI::TEST):
3000         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3001         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3002
3003 2019-01-03  Matt Rajca  <mrajca@apple.com>
3004
3005         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3006         https://bugs.webkit.org/show_bug.cgi?id=193128
3007         rdar://34554231
3008
3009         Reviewed by Jer Noble.
3010
3011         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3012         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3013         event along with a flag that indicates whether or not autoplay was actually prevented.
3014
3015         Tests: existing API tests were updated to reflect the new names. New API tests
3016         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3020         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3021         (TEST):
3022         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3023         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3024
3025 2019-01-04  Chris Dumez  <cdumez@apple.com>
3026
3027         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3028         https://bugs.webkit.org/show_bug.cgi?id=193120
3029
3030         Reviewed by Alex Christensen.
3031
3032         Add API test coverage.
3033
3034         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3035
3036 2019-01-04  Chris Dumez  <cdumez@apple.com>
3037
3038         Crash under WebProcessPool::addSuspendedPage()
3039         https://bugs.webkit.org/show_bug.cgi?id=193110
3040
3041         Reviewed by Youenn Fablet.
3042
3043         Add API test coverage.
3044
3045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3046
3047 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3048
3049         [ews-build] Check patch relevance before applying the patch
3050         https://bugs.webkit.org/show_bug.cgi?id=193102
3051
3052         Reviewed by Lucas Forschler.
3053
3054         * BuildSlaveSupport/ews-build/factories.py:
3055         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3056
3057 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3058
3059         [ews-build] Check patch relevance step should print patch id
3060         https://bugs.webkit.org/show_bug.cgi?id=193137
3061
3062         Reviewed by Lucas Forschler.
3063
3064         * BuildSlaveSupport/ews-build/steps.py:
3065         (CheckPatchRelevance.start): Update the status to include patch id.
3066
3067 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3068
3069         webkitpy: Increase simulator teardown timeout
3070         https://bugs.webkit.org/show_bug.cgi?id=193141
3071         <rdar://problem/46174217>
3072
3073         Rubber-stamped by Aakash Jain.
3074
3075         * Scripts/webkitpy/xcode/simulated_device.py:
3076         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3077
3078 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3079
3080         test262-runner misbehaves when test file YAML has a trailing space
3081         https://bugs.webkit.org/show_bug.cgi?id=193053
3082
3083         Reviewed by Yusuke Suzuki.
3084
3085         * Scripts/test262/Runner.pm:
3086         (parseData):
3087         Accept trailing space when parsing a test file's YAML block.
3088
3089 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3090
3091         UserMedia test should use WKPageNavigationClient
3092         https://bugs.webkit.org/show_bug.cgi?id=192913
3093
3094         Reviewed by Youenn Fablet.
3095
3096         The test currently uses the deprecated WKPageLoaderClient. It should use
3097         WKPageNavigationClient instead, which provides the same callback under a similar name.
3098
3099         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3100         (TestWebKitAPI::TEST):
3101
3102 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3103
3104         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3105         https://bugs.webkit.org/show_bug.cgi?id=192944
3106
3107         Reviewed by Tim Horton.
3108
3109         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3110         (TestWebKitAPI::TEST):
3111
3112 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3113
3114         Add support for using the current text selection as the find string on iOS
3115         https://bugs.webkit.org/show_bug.cgi?id=193034
3116         <rdar://problem/45138739>
3117
3118         Reviewed by Tim Horton.
3119
3120         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3121         _setStringForFind) works as expected.
3122
3123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3124         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3125
3126 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3127
3128         [ews-build] Use git on OpenSource EWS bots
3129         https://bugs.webkit.org/show_bug.cgi?id=193092
3130
3131         Reviewed by Lucas Forschler.
3132
3133         * BuildSlaveSupport/ews-build/steps.py:
3134         (CheckOutSource): Use git instead of svn.
3135         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3136
3137 2019-01-02  Daniel Bates  <dabates@apple.com>
3138
3139         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3140         https://bugs.webkit.org/show_bug.cgi?id=193023
3141
3142         Reviewed by Simon Fraser.
3143
3144         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3145         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3146         enumerator values. We should just remove this code.
3147
3148         * lldb/lldb_webkit.py:
3149         (WTFOptionSetProvider.has_children):
3150         (WTFOptionSetProvider.num_children):
3151         (WTFOptionSetProvider.get_child_index):
3152         (WTFOptionSetProvider.get_child_at_index):
3153
3154 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3155
3156         .ycm_extra_conf.py should handle XXXInlines.h
3157         https://bugs.webkit.org/show_bug.cgi?id=193055
3158
3159         Reviewed by Carlos Garcia Campos.
3160
3161         compile_commands.json database only records flags and options for cpp source files.
3162         So, when we open headers, this database does not have any information for that.
3163         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3164         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3165         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3166         we attempt to find XXX.cpp and use the configuration if it exists.
3167
3168         * gtk/ycm_extra_conf.py:
3169         (getImplementationFilename):
3170         (FlagsForFile):
3171
3172 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3173
3174         Unreviewed. Support PHP 7.3 in Debian.
3175
3176         Add 7.3 to the list of php versions supported in Debian.
3177
3178         * Scripts/webkitpy/port/base.py:
3179         (Port._debian_php_version):
3180
3181 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3182
3183         Resurrect Mac CMake build
3184         https://bugs.webkit.org/show_bug.cgi?id=192658
3185
3186         Reviewed by Yusuke Suzuki.
3187
3188         * DumpRenderTree/PlatformMac.cmake:
3189         * MiniBrowser/mac/CMakeLists.txt:
3190         * TestWebKitAPI/PlatformMac.cmake:
3191
3192 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3193
3194         [Tools] Remove references to Bison and Flex
3195         https://bugs.webkit.org/show_bug.cgi?id=193033
3196
3197         Reviewed by Michael Catanzaro.
3198
3199         The Bison and Flex tools are not needed anymore since r209883.
3200
3201         * CygwinDownloader/cygwin-downloader.py:
3202         * EWSTools/ubuntu-ews-packages:
3203         * Scripts/filter-build-webkit:
3204         (shouldIgnoreLine):
3205         * gtk/install-dependencies:
3206         * wpe/install-dependencies:
3207
3208 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3209
3210         WebDriver: warn about non existing tests when parsing expectations
3211         https://bugs.webkit.org/show_bug.cgi?id=192979
3212
3213         Reviewed by Michael Catanzaro.
3214
3215         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3216         renamed.
3217
3218         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3219         (WebDriverTestRunner.__init__):
3220
3221 2018-12-21  Chris Dumez  <cdumez@apple.com>
3222
3223         navigator.userAgent in service workers does not reflect customUserAgent set by client
3224         https://bugs.webkit.org/show_bug.cgi?id=192951
3225
3226         Reviewed by Youenn Fablet.
3227
3228         Extend API test coverage.
3229
3230         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3231         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3232         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3233         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3234         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3235
3236 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3237
3238         [WebAuthN] userPresence should always be true
3239         https://bugs.webkit.org/show_bug.cgi?id=192835
3240         <rdar://problem/46538788>
3241
3242         Reviewed by Brent Fulgham.
3243
3244         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3245         (TestWebKitAPI::TEST):
3246
3247 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3248
3249         Add support to run-benchmark to use non-default copies of the browser apps
3250         https://bugs.webkit.org/show_bug.cgi?id=192905
3251         rdar://problem/46845840
3252
3253         Reviewed by Dewei Zhu.
3254         
3255         Add support for a --browser-path argument to run-benchmark, which allows you to use
3256         a custom app bundle for a given browser (only implemented for Safari at present).
3257
3258         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3259         (BenchmarkRunner.__init__):
3260         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3261         (BrowserDriver.__init__):
3262         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3263         (BrowserDriverFactory.create):
3264         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3265         (OSXBrowserDriver._launch_process):
3266         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3267         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3268         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3269         (OSXChromeCanaryDriver.launch_url):
3270         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3271         (OSXFirefoxNightlyDriver.launch_url):
3272         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3273         (OSXSafariDriver.__init__):
3274         (OSXSafariDriver.launch_url):
3275         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3276         (parse_args):
3277         (run_benchmark_plan):
3278         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3279         (WebServerBenchmarkRunner.__init__):
3280         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3281         (FakeBenchmarkRunner.__init__):
3282
3283 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3284
3285         [WebAuthN] Import an APDU coder from Chromium
3286         https://bugs.webkit.org/show_bug.cgi?id=192949
3287         <rdar://problem/46879933>
3288
3289         Reviewed by Brent Fulgham.
3290
3291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3292         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3293         (TestWebKitAPI::TEST):
3294
3295 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3296
3297         Setting the file wrapper and content type of an attachment to a PDF should update its image
3298         https://bugs.webkit.org/show_bug.cgi?id=192984
3299         <rdar://problem/46798028>
3300
3301         Reviewed by Tim Horton.
3302
3303         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3304         PDF data correctly updates the image element.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3307
3308 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3309
3310         Add JSCOnly to bot dashboard
3311         https://bugs.webkit.org/show_bug.cgi?id=192964
3312
3313         Reviewed by Alexey Proskuryakov.
3314
3315         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3316         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3317         useful if they were not so secret, so add them.
3318
3319         There appear to be no build-only bots, so the first column is blank. And of course there are
3320         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3321         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3322         and there's plenty of room in the final column for all the bots.
3323
3324         I had a hard time picking a logo to use, because the JavaScript language does not have an
3325         official logo. But I believe I've found one that will be satisfactory.
3326
3327         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3328
3329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3332         (BubbleQueueServer):
3333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3335         (WebKitBuildbot):
3336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3337         (table.queue-grid tr.platform.linux-jsconly img.logo):
3338
3339 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3340
3341         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3342         https://bugs.webkit.org/show_bug.cgi?id=192821
3343
3344         Reviewed by Chris Dumez.
3345
3346         * DumpRenderTree/mac/DumpRenderTree.mm:
3347         (createWebViewAndOffscreenWindow):
3348         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3349
3350 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3351
3352         [Win][Clang] Fix compilation warnings of DumpRenderTree
3353         https://bugs.webkit.org/show_bug.cgi?id=192924
3354
3355         Reviewed by Alex Christensen.
3356
3357         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3358         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3359         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3360         * DumpRenderTree/win/DumpRenderTree.cpp:
3361         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3362         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3363         object to the argument of setDefaultTextEncodingName instead of a
3364         const string literal.
3365         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3366         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3367         (setCacheFolder): Deleted.
3368         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3369         * DumpRenderTree/win/EditingDelegate.cpp:
3370         (dump): Use %d for int.
3371         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3372         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3373         (BSTRFromString): Deleted unused function.
3374         * DumpRenderTree/win/TestRunnerWin.cpp:
3375         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3376         the arguemnt of setQuota instead of const string literal.
3377         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3378         (jsStringRefToWString): Deleted unused function.
3379
3380 2018-12-20  Chris Dumez  <cdumez@apple.com>
3381
3382         Add API test coverage for customUserAgent client setting and service workers
3383         https://bugs.webkit.org/show_bug.cgi?id=192952
3384
3385         Reviewed by Alex Christensen.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3388         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3389         (-[SWSchemes webView:startURLSchemeTask:]):
3390         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3391         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3392
3393 2018-12-20  Chris Dumez  <cdumez@apple.com>
3394
3395         Use Optional::hasValue() instead of Optional::has_value()
3396         https://bugs.webkit.org/show_bug.cgi?id=192948
3397
3398         Reviewed by Tim Horton.
3399
3400         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3401         (TestWebKitAPI::TEST):
3402         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3403         (TestWebKitAPI::TEST):
3404         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3405         (TestWebKitAPI::TEST_F):
3406
3407 2018-12-20  Chris Dumez  <cdumez@apple.com>
3408
3409         Add style script rule to check for uses of std::optional<>
3410         https://bugs.webkit.org/show_bug.cgi?id=192931
3411
3412         Reviewed by Tim Horton.
3413
3414         * Scripts/webkitpy/style/checkers/cpp.py:
3415         (check_wtf_optional):
3416         (check_style):
3417
3418 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3419
3420         [WebAuthN] Add a runtime flag for local authenticator
3421         https://bugs.webkit.org/show_bug.cgi?id=192792
3422         <rdar://problem/46798738>
3423
3424         Reviewed by Brent Fulgham.
3425
3426         * DumpRenderTree/TestOptions.cpp:
3427         (TestOptions::TestOptions):
3428         * DumpRenderTree/TestOptions.h:
3429         * DumpRenderTree/mac/DumpRenderTree.mm:
3430         (enableExperimentalFeatures):
3431         (setWebPreferencesForTestOptions):
3432         * WebKitTestRunner/TestController.cpp:
3433         (WTR::TestController::resetPreferencesToConsistentValues):
3434         (WTR::updateTestOptionsFromTestHeader):
3435         * WebKitTestRunner/TestOptions.h:
3436         (WTR::TestOptions::hasSameInitializationOptions const):
3437
3438 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3439
3440         webkitpy: Autoinstall package URLs have changed
3441         https://bugs.webkit.org/show_bug.cgi?id=192909
3442         <rdar://problem/46860359>
3443
3444         Rubber-stamped by Alexey Proskuryakov.
3445
3446         PyPi urls have been moved around, we need to update our auto-installed packages.
3447
3448         We should check for Selenium before asking PyPi for the latest version.
3449
3450         * Scripts/webkitpy/thirdparty/__init__.py:
3451         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3452         (AutoinstallImportHook._install_keyring): Ditto.
3453         (AutoinstallImportHook._install_pep8): Ditto.
3454         (AutoinstallImportHook._install_mozlog): Ditto.
3455         (AutoinstallImportHook._install_mozprocess): Ditto.
3456         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3457         (AutoinstallImportHook._install_pytest): Ditto.
3458         (AutoinstallImportHook._install_pylint): Ditto.
3459         (AutoinstallImportHook._install_buildbot): Ditto.
3460         (AutoinstallImportHook._install_coverage): Ditto.
3461         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3462         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3463         for new Selenium if the installed version isn't sufficient.
3464         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3465
3466 2018-12-20  Chris Dumez  <cdumez@apple.com>
3467
3468         Use Optional::valueOr() instead of Optional::value_or()
3469         https://bugs.webkit.org/show_bug.cgi?id=192933
3470
3471         Reviewed by Geoffrey Garen.
3472
3473         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3474         (TestWebKitAPI::checkURL):
3475         (TestWebKitAPI::checkRelativeURL):
3476         (TestWebKitAPI::checkURLDifferences):
3477         (TestWebKitAPI::checkRelativeURLDifferences):
3478         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3479         (TestWebKitAPI::checkURL):
3480
3481 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3482
3483         Unreviewed, rolling out r239417.
3484
3485         Introduced two API test failures on macOS.
3486
3487         Reverted changeset:
3488
3489         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3490         occlusion changes"
3491         https://bugs.webkit.org/show_bug.cgi?id=192821
3492         https://trac.webkit.org/changeset/239417
3493
3494 2018-12-20  Devin Rousso  <drousso@apple.com>
3495
3496         Web Inspector: UIString should take an optional key and description to aid localization
3497         https://bugs.webkit.org/show_bug.cgi?id=153962
3498         <rdar://problem/24542505>
3499
3500         Reviewed by Brian Burg.
3501
3502         * Scripts/extract-localizable-js-strings:
3503
3504 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3505
3506         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3507         https://bugs.webkit.org/show_bug.cgi?id=192923
3508         <rdar://problem/46859068>
3509
3510         Reviewed by Wenson Hsieh.
3511
3512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3513         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3514         Add a test ensuring that both parented and unparented WKWebViews can
3515         retrieve main resource data when loading a PDF.
3516
3517 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3518
3519         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3520         https://bugs.webkit.org/show_bug.cgi?id=192852
3521
3522         Reviewed by Michael Catanzaro.
3523
3524         EmojiOne font was replaced by Noto Color Emoji.
3525
3526         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3527         * gtk/jhbuild.modules:
3528         * wpe/jhbuild.modules:
3529
3530 2018-12-19  Chris Dumez  <cdumez@apple.com>
3531
3532         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3533         https://bugs.webkit.org/show_bug.cgi?id=192728
3534         <rdar://problem/46746779>
3535
3536         Reviewed by Geoff Garen.
3537
3538         * DumpRenderTree/*:
3539         * MiniBrowser/*:
3540         * TestRunnerShared/*:
3541         * TestWebKitAPI/*:
3542         * WebGPUAPIStructure/*:
3543         * WebKitTestRunner/*:
3544
3545 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3546
3547         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3548         https://bugs.webkit.org/show_bug.cgi?id=192821
3549
3550         Reviewed by Chris Dumez.
3551
3552         * DumpRenderTree/mac/DumpRenderTree.mm:
3553         (createWebViewAndOffscreenWindow):
3554
3555 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3556
3557         Navigations away from the SafeBrowsing interstitial show a flash of old content
3558         https://bugs.webkit.org/show_bug.cgi?id=192676
3559
3560         Reviewed by Chris Dumez.
3561
3562         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3563         (safeBrowsingView):
3564         (TEST):
3565         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3566
3567 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3568
3569         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3570         https://bugs.webkit.org/show_bug.cgi?id=192855
3571
3572         Reviewed by Michael Catanzaro.
3573
3574         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3575         (WTR::TestController::notifyDone): Use the WPE implementation.
3576         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3577         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3578         (WTR::TestController::platformRunUntil): Honor the condition flag.
3579
3580 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3581
3582         Allow clients to set the navigator platform
3583         https://bugs.webkit.org/show_bug.cgi?id=192735
3584
3585         Reviewed by Tim Horton.
3586
3587         Add a test for setting a custom navigator platform.
3588
3589         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3590         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3591         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3592
3593 2018-12-19  Truitt Savell  <tsavell@apple.com>
3594
3595         Unreviewed, rolling out r239358.
3596
3597         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3598         crash on Debug bots
3599
3600         Reverted changeset:
3601
3602         "Clean up IndexedDB files between tests"
3603         https://bugs.webkit.org/show_bug.cgi?id=192796
3604         https://trac.webkit.org/changeset/239358
3605
3606 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3607
3608         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3609         https://bugs.webkit.org/show_bug.cgi?id=192842
3610         <rdar://problem/46823586>
3611
3612         Reviewed by Tim Horton.
3613
3614         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3615         item provider when dragging a rich text selection.
3616
3617         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3618
3619 2018-12-18  David Quesada  <david_quesada@apple.com>
3620
3621         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3622         https://bugs.webkit.org/show_bug.cgi?id=192810
3623         <rdar://problem/46812536>
3624
3625         Reviewed by Alex Christensen.
3626
3627         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3628         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3629             After releasing our reference to the web view, wait until the next turn of the runloop
3630             before checking that the originatingWebView has been zeroed, since the web view might
3631             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3632             testing general memory management of WKWebViews, only that _WKDownload does not retain
3633             its web view via the 'originatingWebView' property.
3634
3635 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3636
3637         Clean up IndexedDB files between tests
3638         https://bugs.webkit.org/show_bug.cgi?id=192796
3639
3640         Reviewed by Geoffrey Garen.
3641
3642         * DumpRenderTree/mac/DumpRenderTree.mm:
3643         (runTest):
3644         * WebKitTestRunner/TestController.cpp:
3645         (WTR::TestController::resetStateToConsistentValues):
3646         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3647         (WTR::RemoveAllIndexedDatabasesCallback):
3648         (WTR::TestController::ClearIndexedDatabases):
3649         * WebKitTestRunner/TestController.h:
3650
3651 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3652
3653         Fix API test introduced in r239339 on iOS.
3654         https://bugs.webkit.org/show_bug.cgi?id=192675
3655
3656         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3657         (TEST):
3658         The iOS implementation of the safe browsing warning is a little different.
3659         It does some element creation when it is added to the window so it knows how big it is.
3660         To test these elements, we need to simulate adding it to the window.
3661         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3662
3663 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3664
3665         webkitpy: Ignore device type for test when using --force
3666         https://bugs.webkit.org/show_bug.cgi?id=192786
3667         <rdar://problem/46794894>
3668
3669         Reviewed by Daniel Bates.
3670
3671         It is sometimes the case that a contributor will wish to run a test on a specific device,
3672         despite expectations which indicate a test should not be run on that device.
3673
3674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3675         (parse_args):
3676         * Scripts/webkitpy/port/device_port.py:
3677         (DevicePort.default_child_processes): Strip device type information when using --force.
3678         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3679
3680 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3681
3682         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3683         https://bugs.webkit.org/show_bug.cgi?id=192675
3684
3685         Reviewed by Geoffrey Garen.
3686
3687         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3688         (goBack):
3689         (TEST):
3690         (visitUnsafeSite):
3691         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3692         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3693
3694 2018-12-18  Chris Dumez  <cdumez@apple.com>
3695
3696         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3697         https://bugs.webkit.org/show_bug.cgi?id=192772
3698
3699         Reviewed by Antti Koivisto.
3700
3701         Add API test coverage.
3702
3703         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3704
3705 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3706
3707         Unreviewed, JHBuild GTK build fix attempt
3708
3709         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3710         There's no ninja module either, it should be provided by the
3711         host system.
3712
3713 2018-12-17  Chris Dumez  <cdumez@apple.com>
3714
3715         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3716         https://bugs.webkit.org/show_bug.cgi?id=192789
3717         <rdar://problem/46755277>
3718
3719         Reviewed by Alex Christensen.
3720
3721         Add API test coverage.
3722
3723         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3724         (TEST):
3725
3726 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3727
3728         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3729         https://bugs.webkit.org/show_bug.cgi?id=192780
3730         rdar://problem/43394387
3731
3732         Reviewed by Tim Horton.
3733
3734         No need to set "AppleFontSmoothing" defaults for WK2.
3735
3736         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3737         (WTR::InjectedBundle::platformInitialize):
3738
3739 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3740
3741         webkitpy: Handle case where stdout and stderr don't accept unicode
3742         https://bugs.webkit.org/show_bug.cgi?id=192775
3743         <rdar://problem/46497303>
3744
3745         Reviewed by Stephanie Lewis.
3746
3747         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3748         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3749         characters with '?'.
3750         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3751         (RegularTest.test_stream_with_encoding):
3752
3753 2018-12-17  Daniel Bates  <dabates@apple.com>
3754
3755         Support concatenating StringView with other string types
3756         https://bugs.webkit.org/show_bug.cgi?id=177566
3757
3758         Reviewed by Darin Adler.
3759
3760         Add some tests to ensure we do not regress the number of allocations needed when performing
3761         string concatenation with string views.
3762
3763         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3764         (TestWebKitAPI::TEST):
3765
3766 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3767
3768         Unreviewed, rolling out r239265 and r239274.
3769         https://bugs.webkit.org/show_bug.cgi?id=192765
3770
3771         unorm_normalize is deprecated, and broke an internal build
3772         (Requested by Truitt on #webkit).
3773
3774         Reverted changesets:
3775
3776         "[GTK][WPE] Need a function to convert internal URI to display
3777         ("pretty") URI"
3778         https://bugs.webkit.org/show_bug.cgi?id=174816
3779         https://trac.webkit.org/changeset/239265
3780
3781         "Fix the Apple Internal Mac build with a newer SDK"
3782         https://trac.webkit.org/changeset/239274
3783
3784 2018-12-17  Daniel Bates  <dabates@apple.com>
3785
3786         Implement UIScriptController::toggleCapsLock() for iOS
3787         https://bugs.webkit.org/show_bug.cgi?id=191815
3788
3789         Reviewed by Andy Estes.
3790
3791         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3792
3793         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3794         * WebKitTestRunner/TestController.cpp:
3795         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3796         before running a test. This ensures that the caps lock state does not persist between
3797         tests should a test enable caps lock and not disable it.
3798         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3799         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3800         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3801         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3802         create the event. Also substituted NSString* for const String& as the data type for the first
3803         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3804         below.
3805         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3806         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3807
3808 2018-12-17  Daniel Bates  <dabates@apple.com>
3809
3810         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3811         https://bugs.webkit.org/show_bug.cgi?id=192633
3812
3813         Reviewed by Wenson Hsieh.
3814
3815         Update code to use the modern initializer.
3816
3817         * DumpRenderTree/mac/EventSendingController.mm:
3818         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3819
3820 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3821
3822         Unreviewed, rolling out r239254.
3823
3824         This broke the Windows 10 Debug build
3825
3826         Reverted changeset:
3827
3828         "Replace many uses of String::format with more type-safe
3829         alternatives"
3830         https://bugs.webkit.org/show_bug.cgi?id=192742
3831         https://trac.webkit.org/changeset/239254
3832
3833 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3834
3835         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3836         <https://webkit.org/b/192751>
3837         <rdar://problem/46771623>
3838
3839         Reviewed by Daniel Bates.
3840
3841         Change loop variables to const references to avoid unnecessary
3842         copies.
3843
3844         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3845         (-[LocalPasteboard pasteboardItems]):
3846
3847 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3848
3849         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3850         https://bugs.webkit.org/show_bug.cgi?id=174816
3851
3852         Reviewed by Michael Catanzaro.
3853
3854         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3855
3856         * TestWebKitAPI/CMakeLists.txt:
3857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3858         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3859         (TestWebKitAPI::TEST):
3860         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3861         (testURIForDisplayUnaffected):
3862         (testURIForDisplayAffected):
3863         (beforeAll):
3864         (afterAll):
3865         * TestWebKitAPI/glib/CMakeLists.txt:
3866
3867 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3868
3869         [WPE] Add API to notify about frame displayed view backend callback
3870         https://bugs.webkit.org/show_bug.cgi?id=192224
3871
3872         Reviewed by Michael Catanzaro.
3873
3874         Add a test case to check the new API.
3875
3876         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3877         (testWebViewFrameDisplayed):
3878         (beforeAll):
3879         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3880
3881 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3882
3883         Unreviewed build fix after r239253
3884
3885         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3886
3887 2018-12-15  Darin Adler  <darin@apple.com>
3888
3889         Use warning-ignoring macros more consistently and simply
3890         https://bugs.webkit.org/show_bug.cgi?id=192743
3891
3892         Reviewed by Mark Lam.
3893
3894         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3895         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3896         * DumpRenderTree/mac/TextInputControllerMac.m:
3897         (-[TextInputController interpretKeyEvents:withSender:]): Use
3898         IGNORE_WARNINGS_BEGIN/END.
3899         * WebKitTestRunner/mac/EventSenderProxy.mm:
3900         (WTR::EventSenderProxy::mouseForceClick): Use
3901         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3902         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3903         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3904         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3905         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3906
3907 2018-12-15  Darin Adler  <darin@apple.com>
3908
3909         Replace many uses of String::format with more type-safe alternatives
3910         https://bugs.webkit.org/show_bug.cgi?id=192742
3911
3912         Reviewed by Mark Lam.
3913
3914         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3915         (WTR::cacheTestRunnerCallback): Use makeString.
3916         * WebKitTestRunner/TestController.cpp:
3917         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3918         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3919
3920 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3921
3922         [WPE][GTK] Add libpsl to JHBuild module sets
3923         https://bugs.webkit.org/show_bug.cgi?id=192740
3924
3925         Reviewed by Michael Catanzaro.
3926
3927         * gtk/jhbuild.modules: Add libpsl module.
3928         * wpe/jhbuild.modules: Ditto.
3929
3930 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3931
3932         Add a style checker rule for Xcode version macros use
3933         https://bugs.webkit.org/show_bug.cgi?id=192703
3934
3935         Reviewed by Alex Christensen.
3936
3937         * Scripts/webkitpy/style/checkers/cpp.py:
3938         (check_os_version_checks):
3939         (process_line):
3940         (CppChecker):
3941         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3942         (WebKitStyleTest.test_os_version_checks):
3943
3944 2018-12-14  Chris Dumez  <cdumez@apple.com>
3945
3946         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3947         https://bugs.webkit.org/show_bug.cgi?id=192704
3948
3949         Reviewed by Geoffrey Garen.
3950
3951         Extend existing API test to reproduce the problem.
3952
3953         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3954
3955 2018-12-14  Chris Dumez  <cdumez@apple.com>
3956
3957         [PSON] WebsitePolicies are lost on process-swap
3958         https://bugs.webkit.org/show_bug.cgi?id=192694
3959         <rdar://problem/46715748>
3960
3961         Reviewed by Brady Eidson.
3962
3963         Extend existing API test to reproduce the issue.
3964
3965         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3966
3967 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3968
3969         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3970         https://bugs.webkit.org/show_bug.cgi?id=192678
3971
3972         Reviewed by Carlos Garcia Campos.
3973
3974         Update our ancient versions of libsoup and glib-networking.
3975
3976         * gtk/install-dependencies:
3977         * gtk/jhbuild.modules:
3978         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
3979         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
3980         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
3981         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3982         * wpe/install-dependencies:
3983         * wpe/jhbuild.modules:
3984         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3985
3986 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3987
3988         [WPE] Use new view state API from libwpe
3989         https://bugs.webkit.org/show_bug.cgi?id=191906
3990
3991         Reviewed by Žan Doberšek.
3992
3993         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3994         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
3995         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3996         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
3997         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3998         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3999         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4000         wpe_view_activity_state_focused state flags.
4001         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4002         * wpe/backends/HeadlessViewBackend.cpp:
4003         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4004         * wpe/backends/WindowViewBackend.cpp:
4005         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4006         received in configure callback.
4007         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4008
4009 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4010
4011         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4012         https://bugs.webkit.org/show_bug.cgi?id=192688
4013
4014         Reviewed by Ross Kirsling.
4015
4016         * win/DLLLauncher/DLLLauncherMain.cpp:
4017         (copyEnvironmentVariable): Moved.
4018         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4019         (applePathFromRegistry): Ditto.
4020         (appleApplicationSupportDirectory): Ditto.
4021         (prependPath): Ditto.
4022
4023 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4024
4025         Unreviewed. Changed my status to a reviewer.
4026
4027         * Scripts/webkitpy/common/config/contributors.json:
4028
4029 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4030
4031         [iOS] Support dropping contact card data (public.vcard) in editable content
4032         https://bugs.webkit.org/show_bug.cgi?id=192570
4033         <rdar://problem/35626913>
4034
4035         Reviewed by Tim Horton.
4036
4037         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4038
4039         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
4040         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
4041         additionally inserts a link).
4042
4043         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4044         (TestWebKitAPI::createMapItemForTesting):
4045         (TestWebKitAPI::createContactItemForTesting):
4046
4047         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
4048         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
4049         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
4050         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
4051         files.
4052
4053 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
4054
4055         Unreviewed -- update my status to "reviewer".
4056
4057         * Scripts/webkitpy/common/config/contributors.json:
4058
4059 2018-12-13  Youenn Fablet  <youenn@apple.com>
4060
4061         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
4062         https://bugs.webkit.org/show_bug.cgi?id=192657
4063
4064         Reviewed by Eric Carlson.
4065
4066         Add a test that loads a page registering ondevicechange,
4067         load another page in the same process, closes the first page.
4068         Ensure that the process does not crash in that case.
4069
4070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4071         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4072         (TestWebKitAPI::TEST):
4073         (TestWebKitAPI::didCrashCallback):
4074         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
4075
4076 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4077
4078         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
4079         https://bugs.webkit.org/show_bug.cgi?id=192643
4080
4081         Reviewed by Philippe Normand.
4082
4083         This problem happens with Arch Linux users which have libfdk-2.0.0
4084         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
4085
4086         The problem has already been solved upstream at
4087         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
4088
4089         Adding patches while this problem is not in a release yet.
4090
4091         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
4092         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
4093         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
4094
4095 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4096
4097         [FreeType] Add initial implementation of variation fonts
4098         https://bugs.webkit.org/show_bug.cgi?id=192151
4099
4100         Reviewed by Michael Catanzaro.
4101
4102         Add cairo patch to avoid crashes.
4103
4104         * gtk/jhbuild.modules:
4105         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4106
4107 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
4108
4109         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
4110         https://bugs.webkit.org/show_bug.cgi?id=192618
4111
4112         Reviewed by Alex Christensen.
4113
4114         * DumpRenderTree/win/DRTDataObject.cpp:
4115         * DumpRenderTree/win/DRTDataObject.h:
4116         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
4117         * DumpRenderTree/win/DRTDropSource.h:
4118         * DumpRenderTree/win/EditingDelegate.h:
4119         * DumpRenderTree/win/PolicyDelegate.h:
4120         * DumpRenderTree/win/UIDelegate.h:
4121
4122 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
4123
4124         Make TextInputController.legacyAttributedString take DOM nodes and offsets
4125         https://bugs.webkit.org/show_bug.cgi?id=192653
4126
4127         Reviewed by Wenson Hsieh.
4128
4129         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
4130         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
4131         shadow boundaries.
4132
4133         * DumpRenderTree/mac/TextInputControllerMac.m:
4134         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
4135         (+[TextInputController webScriptNameForSelector:]): Ditto.
4136         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
4137         start node and offset then end node and offset pairs.
4138
4139 2018-12-12  Alex Christensen  <achristensen@webkit.org>
4140
4141         Implement safe browsing in WebKit on WatchOS
4142         https://bugs.webkit.org/show_bug.cgi?id=192641
4143         <rdar://problem/46376188>
4144
4145         Reviewed by Geoff Garen.
4146
4147         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4148         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
4149         (safeBrowsingView):
4150         Add a test that the new delegate callback is called.
4151
4152 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4153
4154         Unreviewed manual rollout of r239100-r239102 and r239116
4155         https://bugs.webkit.org/show_bug.cgi?id=192151
4156         <rdar://problem/46655586>
4157
4158         * gtk/jhbuild.modules:
4159         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
4160
4161 2018-12-12  Commit Queue  <commit-queue@webkit.org>
4162
4163         Unreviewed, rolling out r239103.
4164         https://bugs.webkit.org/show_bug.cgi?id=192627
4165
4166         It broke the built because it depends on another patch that
4167         didn't land yet (Requested by KaL on #webkit).
4168
4169         Reverted changeset:
4170
4171         "[WPE] Add API to notify about frame displayed view backend
4172         callback"
4173         https://bugs.webkit.org/show_bug.cgi?id=192224
4174         https://trac.webkit.org/changeset/239103
4175
4176 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4177
4178         [WPE] Add API to notify about frame displayed view backend callback
4179         https://bugs.webkit.org/show_bug.cgi?id=192224
4180
4181         Reviewed by Michael Catanzaro.
4182
4183         Add a test case to check the new API.
4184
4185         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4186         (testWebViewFrameDisplayed):
4187         (beforeAll):
4188
4189 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4190
4191         [FreeType] Add initial implementation of variation fonts
4192         https://bugs.webkit.org/show_bug.cgi?id=192151
4193
4194         Reviewed by Michael Catanzaro.
4195
4196         Add cairo patch to avoid crashes.
4197
4198         * gtk/jhbuild.modules:
4199         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4200
4201 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
4202
4203         Implement feature flag for CSS Typed OM
4204         https://bugs.webkit.org/show_bug.cgi?id=192610
4205
4206         Reviewed by Ryosuke Niwa.
4207
4208         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4209
4210 2018-12-11  Chris Dumez  <cdumez@apple.com>
4211
4212         Unreviewed, fix bad check in API test added in r239080.
4213
4214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4215
4216 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
4217
4218         [Win][Clang] Fix warning -Wmissing-field-initializers
4219         https://bugs.webkit.org/show_bug.cgi?id=192584
4220
4221         Reviewed by Yusuke Suzuki.
4222
4223         Initialize a struct with '{ }' instead of '= {0}'.
4224
4225         * DumpRenderTree/win/DumpRenderTree.cpp:
4226         (runTest):
4227         * DumpRenderTree/win/EventSender.cpp:
4228         (makeMsg):
4229         (replaySavedEvents):
4230         (beginDragWithFilesCallback):
4231         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
4232         (createBitmapContextFromWebView):
4233         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
4234         (updateMenuItemForHistoryItem):
4235         * MiniBrowser/win/WinMain.cpp:
4236         (wWinMain):
4237         * TestWebKitAPI/win/HostWindow.cpp:
4238         (TestWebKitAPI::HostWindow::clientRect const):
4239         (TestWebKitAPI::HostWindow::registerWindowClass):
4240         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4241         (TestWebKitAPI::PlatformWebView::registerWindowClass):
4242         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4243         (WTR::registerWindowClass):
4244         (WTR::PlatformWebView::windowFrame):
4245         (WTR::PlatformWebView::windowSnapshotImage):
4246
4247 2018-12-11  Chris Dumez  <cdumez@apple.com>
4248
4249         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
4250         https://bugs.webkit.org/show_bug.cgi?id=192482
4251         <rdar://problem/46470145>
4252
4253         Reviewed by Antti Koivisto.
4254
4255         Add API test coverage.
4256
4257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4258
4259 2018-12-11  Andy Estes  <aestes@apple.com>
4260
4261         Introduce makeBlockPtr for lambdas
4262         https://bugs.webkit.org/show_bug.cgi?id=192594
4263
4264         Reviewed by Alex Christensen.
4265
4266         Adopted makeBlockPtr and added API tests.
4267
4268         * DumpRenderTree/TestRunner.cpp:
4269         (TestRunner::callUIScriptCallback):
4270         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
4271         (TestWebKitAPI::TEST):
4272         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4273         (-[DownloadProgressTestRunner init]):
4274         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
4275
4276 2018-12-11  Chris Dumez  <cdumez@apple.com>
4277
4278         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
4279         https://bugs.webkit.org/show_bug.cgi?id=192361
4280         <rdar://problem/46524903>
4281
4282         Reviewed by Alex Christensen.
4283
4284         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
4285         fixes the failures for me locally.
4286
4287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4288
4289 2018-12-11  Philippe Normand  <pnormand@igalia.com>
4290
4291         Unreviewed, WPE build fix after r239028
4292
4293         The FLATPAK_USER_DIR env var is not set early enough, leading to:
4294
4295         Traceback (most recent call last):
4296         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
4297           sys.exit(WebkitFlatpak.load_from_args().run())
4298         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
4299           if not self.clean_args():
4300         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
4301           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
4302         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
4303           raise KeyError(key)
4304         KeyError: 'FLATPAK_USER_DIR'
4305
4306         * flatpak/flatpakutils.py:
4307         (WebkitFlatpak.clean_args):
4308
4309 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
4310
4311         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
4312         https://bugs.webkit.org/show_bug.cgi?id=192573
4313
4314         Reviewed by Simon Fraser.
4315
4316         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4317
4318 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
4319
4320         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
4321         https://bugs.webkit.org/show_bug.cgi?id=192574
4322
4323         Reviewed by Michael Catanzaro.
4324