12c5454781639265ea37f876868a26045b15da87
[WebKit-https.git] / Tools / ChangeLog
1 2018-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         DataInteractionTests ContentEditableToTextarea and ContentEditableToContentEditable are failing on recent iOS 12
4         https://bugs.webkit.org/show_bug.cgi?id=186325
5         <rdar://problem/40527850>
6
7         Reviewed by Tim Horton.
8
9         Tweak these API tests so that they're robust against changes to how NSAttributedStrings are serialized in item
10         providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions of iOS, just verify that either rich
11         text type is present in the list of dragged type identifiers, and that the rich text type is placed at a higher
12         fidelity than plain text.
13
14         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
15         (checkRichTextTypePrecedesPlainTextType):
16         (TestWebKitAPI::TEST):
17         (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted.
18
19 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
20
21         Adjust compile and runtime flags to match shippable state of features
22         https://bugs.webkit.org/show_bug.cgi?id=186319
23         <rdar://problem/40352045>
24
25         Reviewed by Maciej Stachowiak, Jon Lee, and others.
26
27         This patch revises the compile time and runtime state for various features to match their
28         suitability for end-user releases.
29
30         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
31         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
32         Cocoa builds.
33         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
34         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
35
36 2018-06-05  Saam Barati  <sbarati@apple.com>
37
38         run-testmem should have a dry run option and an option to parse the stdout of executing the dry run
39         https://bugs.webkit.org/show_bug.cgi?id=186293
40
41         Reviewed by Mark Lam.
42
43         This makes it easier to execute run-testmem on a device that doesn't have ruby
44         on it. run-testmem now has a --dry option that will output commands to execute
45         in bash. To run on a device that doesn't have ruby, just put its output into
46         a bash script, and copy the PerformanceTests/testmem directory onto that device,
47         and execute the bash script. Running that bash script will give you raw output.
48         Make a file with that output and pass it into run-testmem using the --parse option.
49         run-testmem will parse the raw output and compute the benchmark score.
50
51         * Scripts/run-testmem:
52
53 2018-06-05  Youenn Fablet  <youenn@apple.com>
54
55         ServiceWorker registration should store any script fetched through importScripts
56         https://bugs.webkit.org/show_bug.cgi?id=182444
57         <rdar://problem/37164835>
58
59         Reviewed by Chris Dumez.
60
61         Add support to crash the storage process from Internals.
62
63         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
64         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
65         (WTR::TestRunner::terminateStorageProcess):
66         * WebKitTestRunner/InjectedBundle/TestRunner.h:
67         * WebKitTestRunner/TestController.cpp:
68         (WTR::TestController::terminateStorageProcess):
69         * WebKitTestRunner/TestController.h:
70         * WebKitTestRunner/TestInvocation.cpp:
71         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
72
73 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
74
75         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
76         https://bugs.webkit.org/show_bug.cgi?id=186286
77         <rdar://problem/40782992>
78
79         Reviewed by Dan Bernstein.
80
81         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
82         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
83         change this flag when preparing for a production release.
84
85         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to
86         determine whether experimental features should be enabled, and use it to properly define
87         the feature flag.
88
89 2018-06-05  Robin Morisset  <rmorisset@apple.com>
90
91         Add a grammar (in antlr4 format) to the WSL spec.
92         https://bugs.webkit.org/show_bug.cgi?id=186310
93
94         Rubberstamped by Filip Pizlo
95
96         It is just the raw rules, without much comments and no typesetting.
97         Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK)
98
99         It does not exactly match the parser of the current js implementation of WSL, it:
100         - Accepts negative literals
101         - Reserves keywords fallthrough/auto
102         - Refuses '_' as a valid identifier
103         - Accepts several capitalizations for Null/True/False
104         - Accepts variable declarations at the top-level
105         - Correctly parses ternary expressions
106         - Forbids empty extension list for protocols
107         - Does not allow a space between '[' and ']' in type suffixes
108         - Correctly parses nested generics
109         - Accepts a 'fallthrough;' statement (for switches)
110         - Refuses chained relational operator (e.g. x < y < z)
111         - Generally a completely different structure for parsing effectful expressions, although it probably accepts about the same language
112         - Currently only accepts literals and identifiers as constexpr (while the js parser accepts way too much, including '(x += 42)')
113         There are probably more differences that I missed. The js parser will probably have to be mostly rewritten to follow the spec more closely (and fix all the bugs).
114         I will try to see if it can be automatically derived from the antlr4 grammar.
115
116         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added.
117
118 2018-06-04  Frederic Wang  <fwang@igalia.com>
119
120         import-w3c-tests should rely on <meta name="flags"> to detect CSS manual tests
121         https://bugs.webkit.org/show_bug.cgi?id=186261
122
123         Reviewed by Youenn Fablet.
124
125         * Scripts/webkitpy/w3c/test_parser.py:
126         (TestParser.is_wpt_manualtest): Add code to detect whether a file is a manual test
127         from its <meta name="flags"> tags. This is based on SourceFile::content_is_css_manual from
128         the WPT repository.
129         * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whether files with
130         <meta name="flags"> are manual or non-manual according to CSS WG rules.
131
132 2018-06-04  Dan Bernstein  <mitz@apple.com>
133
134         Fixed building ImageDiff with the default build system in the Xcode 10 developer beta.
135
136         * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include
137           HaveInternalSDK.xcconfig, since it may not be preent.
138
139 2018-06-04  Dan Bernstein  <mitz@apple.com>
140
141         Fixed building TestWebKitAPI with a shared build directory with XCBuild, which is the
142         default build system in the Xcode 10 developer beta.
143
144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the reference to the
145           built libWTF.a to be relative to the built products directory.
146
147 2018-06-04  Chris Dumez  <cdumez@apple.com>
148
149         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
150         https://bugs.webkit.org/show_bug.cgi?id=186287
151         <rdar://problem/40783352>
152
153         Reviewed by Youenn Fablet.
154
155         * DumpRenderTree/mac/DumpRenderTree.mm:
156         (enableExperimentalFeatures):
157         * DumpRenderTree/win/DumpRenderTree.cpp:
158         (enableExperimentalFeatures):
159
160 2018-06-04  Daniel Bates  <dabates@apple.com>
161
162         Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
163         https://bugs.webkit.org/show_bug.cgi?id=186290
164
165         Reviewed by Aakash Jain.
166
167         Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
168         questionable we should fix a typo when calling this mocked function with argument since.
169
170         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
171         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
172
173 2018-06-04  Dan Bernstein  <mitz@apple.com>
174
175         Fixed building with the macOS Mojave seed SDK.
176
177         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
178
179 2018-06-04  Alexey Proskuryakov  <ap@apple.com>
180
181         Add Mojave support to WebKit tools
182         https://bugs.webkit.org/show_bug.cgi?id=186282
183
184         Reviewed by Daniel Bates.
185
186         Nightly build support will be added separately.
187
188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png: Added.
189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png: Added.
190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
192         Added dashboard support.
193
194         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
195         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
196         Trigger the right build queues on check-in.
197
198         * Scripts/webkitpy/common/version_name_map.py:
199         * Scripts/webkitpy/common/version_name_map_unittest.py:
200         The main version mapping class updated.
201
202         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
203         * Scripts/webkitpy/port/mac_unittest.py:
204         Updated for more platforms in unit tests.
205
206         * TestResultServer/static-dashboards/flakiness_dashboard.js:
207         Added the new platform to flakiness dashboard.
208
209 2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>
210
211         [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
212         https://bugs.webkit.org/show_bug.cgi?id=186279
213
214         Reviewed by Tim Horton.
215
216         Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).
217
218         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
219
220 2018-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
221
222         [Win][MiniBrowser] Remove gMiniBrowser global variable
223         https://bugs.webkit.org/show_bug.cgi?id=186134
224
225         Reviewed by Brent Fulgham.
226
227         It should not be assumed there is only one main window and one browser
228         window to support multiple windows properly. gMainWindow and
229         gMiniBrowser global variables should be removed. This change
230         removes gMiniBrowser.
231
232         * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable.
233         * MiniBrowser/win/Common.h: Ditto.
234         * MiniBrowser/win/MainWindow.cpp:
235         (MainWindow::init):
236         (MainWindow::WndProc):
237         (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar.
238         (MainWindow::cachesDialogProc): Renamed from Caches.
239         (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent.
240         (MainWindow::onURLBarEnter): Extracted from EditProc.
241         (BackButtonProc): Deleted.
242         (ForwardButtonProc): Deleted.
243         (Caches): Renamed to MainWindow::cachesDialogProc.
244         (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc.
245         * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a member variable of MainWindow.
246         * MiniBrowser/win/MiniBrowserLibResource.h:
247         * MiniBrowser/win/WinMain.cpp:
248         (wWinMain):
249
250 2018-06-02  Darin Adler  <darin@apple.com>
251
252         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
253         https://bugs.webkit.org/show_bug.cgi?id=186227
254
255         Reviewed by Dan Bernstein.
256
257         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
258         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
259         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
260
261         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing include.
262
263         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
264         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
265         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
266         (AccessibilityTextMarker::isEqual): Ditto.
267         (AccessibilityTextMarkerRange::isEqual): Ditto.
268
269         * DumpRenderTree/mac/DumpRenderTree.mm:
270         (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of NSAutoreleasePool.
271         (DumpRenderTreeMain): Ditto.
272         (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto.
273         (runTest): Ditto.
274
275         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
276         (copyFile): Use a std::pair to return both a URL and an error rather than using an
277         out argument for the NSError.
278         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
279         Updated for the above change.
280
281         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
282         (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging typecast.
283         (-[DumpRenderTreeWindow close]): Ditto.
284         * DumpRenderTree/mac/LayoutTestHelper.m:
285         (setDisplayColorProfile): Ditto.
286
287         * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include.
288
289         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
290         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
291         Add __bridge to a bridging typecast.
292         * DumpRenderTree/mac/TestRunnerMac.mm:
293         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto.
294         (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool instead of NSAutoreleasePool.
295
296         * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment.
297
298         * DumpRenderTree/mac/UIScriptControllerMac.mm:
299         (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridging typecast.
300         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto.
301         (WTR::UIScriptController::overridePreference): Ditto.
302         * DumpRenderTree/mac/WorkQueueItemMac.mm:
303         (LoadItem::invoke const): Ditto.
304         (LoadHTMLStringItem::invoke const): Ditto.
305         (ScriptItem::invoke const): Ditto.
306
307         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
308         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
309         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
310
311         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
312         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
313         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
314
315         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
316         (WTR::AccessibilityController::accessibleElementById): Add __bridge to a bridging typecast.
317         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
318         (-[NSString createJSStringRef]): Ditto.
319         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm:
320         (WTR::AccessibilityTextMarker::isEqual): Ditto.
321         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm:
322         (WTR::AccessibilityTextMarkerRange::isEqual): Ditto.
323         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
324         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
325         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto.
326         (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
327         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
328         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
329         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
330         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
331         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
332         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
333         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
334         (WTR::createJSStringRef): Ditto.
335         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
336         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
337         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
338         (WTR::AccessibilityUIElement::indexForTextMarker): Ditto.
339         (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto.
340         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
341         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
342         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
343         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
344         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
345         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
346         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
347         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
348         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
349         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
350         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
351         (WTR::initializeWebViewConfiguration): Ditto.
352         (WTR::TestController::platformContext): Ditto.
353         (WTR::TestController::platformPreferences): Ditto.
354         (WTR::TestController::platformAdjustContext): Ditto.
355         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
356         (WTR::PlatformWebView::PlatformWebView): Ditto.
357         * WebKitTestRunner/mac/TestControllerMac.mm:
358         (WTR::TestController::initializeInjectedBundlePath): Ditto.
359         (WTR::TestController::initializeTestPluginDirectory): Ditto.
360         (WTR::TestController::platformConfigureViewForTest): Ditto.
361
362         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
363         (WTR::nsString): Use CFBridgingRelease instead of autorelease.
364         (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to a bridging
365         typecast.
366
367         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing include.
368
369         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
370         (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging typecast.
371         (-[LocalPasteboard setString:forType:]): Ditto.
372
373         * WebKitTestRunner/mac/main.mm:
374         (main): Use @autoreleasepool instead of NSAutoreleasePool.
375
376 2018-06-02  Keith Miller  <keith_miller@apple.com>
377
378         run-jsc should pass the option to use dollar vm by default
379         https://bugs.webkit.org/show_bug.cgi?id=186170
380
381         Reviewed by Yusuke Suzuki.
382
383         * Scripts/run-jsc:
384
385 2018-06-02  Commit Queue  <commit-queue@webkit.org>
386
387         Unreviewed, rolling out r232421.
388         https://bugs.webkit.org/show_bug.cgi?id=186240
389
390         Breaks webkitpy tests (Requested by aakashjain on #webkit).
391
392         Reverted changeset:
393
394         "Add some tests for lldb_webkit.py"
395         https://bugs.webkit.org/show_bug.cgi?id=183744
396         https://trac.webkit.org/changeset/232421
397
398 2018-06-01  Daniel Bates  <dabates@apple.com>
399
400         Add some tests for lldb_webkit.py
401         https://bugs.webkit.org/show_bug.cgi?id=183744
402
403         Reviewed by Alexey Proskuryakov.
404
405         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
406         and WTF::String objects.
407
408         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
409         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
410         on Mac.
411
412         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
413         * Scripts/build-lldbwebkittester: Added.
414         (buildProjectOrDie):
415         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
416         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
417         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
418         the file and take advantage of Python's default error semantics to throw an exception
419         if the import fails instead of handling it ourself. This has the side effect that we
420         now always import the LLDB Python module even if this script is invoked with --help.
421         If this turns out to be a significant annoyance then we can look to dynamically import
422         the module as we did before this change.
423         (webkit_build_dir):
424         (main):
425         (developer_dir): Deleted.
426         (import_lldb): Deleted.
427         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
428         that fact that test-webkitpy does not support class and module fixtures. This is because
429         test-webkitpy currently implements parallelism by breaking down existing test classes
430         into individual test methods itself and having each worker run exactly one test method (via
431         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
432         setUpModule()/setUpClass() are called for each test method as opposed to once per test
433         class/test module.
434         (remove_dir): Ditto.
435         * Scripts/webkitpy/common/system/systemhost.py:
436         (SystemHost):
437         (SystemHost.path_to_lldb_python_directory): Added.
438         * Scripts/webkitpy/test/main.py:
439         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
440         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
441         lldbWebKitTester on Mac.
442         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
443         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
444         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
445         If we will run these tests then build lldbWebKitTester if it has not already been built as the
446         unit tests depend on this program.
447         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
448         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
449         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
450         * lldb/lldbWebKitTester/Makefile: Added.
451         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
452         * lldb/lldbWebKitTester/main.cpp: Added.
453         (breakForTestingSummaryProviders):
454         (utf16String):
455         (testSummaryProviders):
456         (main):
457         * lldb/lldb_webkit_unittest.py: Added.
458         (destroy_cached_debug_session):
459         (LLDBDebugSession):
460         (LLDBDebugSession.setup):
461         (LLDBDebugSession.tearDown):
462         (TestSummaryProviders):
463         (TestSummaryProviders.setUpClass):
464         (TestSummaryProviders._sbFrame):
465         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
466         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
467         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
468         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
469         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
470         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
471         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
472         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
473
474 2018-06-01  Frederic Wang  <fwang@igalia.com>
475
476         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
477         https://bugs.webkit.org/show_bug.cgi?id=186133
478
479         Reviewed by Youenn Fablet.
480
481         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
482         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
483
484 2018-05-31  Frederic Wang  <fwang@igalia.com>
485
486         export-w3c-test-changes should use the new location & name of the WPT repo
487         https://bugs.webkit.org/show_bug.cgi?id=186135
488
489         Reviewed by Youenn Fablet.
490
491         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
492         corresponding variables to use the new organization and repository name. It also refactors a
493         bit the code to reduce the amount of hardcoded strings.
494
495         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
496         final slash to WPT_GH_URL, so it can be used for repo URL too.
497         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
498         WPT_GH_URL.
499         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
500         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
501         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
502         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
503         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
504         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
505         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
506         (TestExporterTest.test_export): Update organization and repository names for the remote
507         branch and pull request.
508         (TestExporterTest.test_export_with_specific_branch): Update repository name.
509
510 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
511
512         Update expected results for BuildStepsConstructorTest
513         https://bugs.webkit.org/show_bug.cgi?id=186119
514
515         Reviewed by Alex Christensen.
516
517         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
518
519 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
520
521         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
522         https://bugs.webkit.org/show_bug.cgi?id=185831
523         <rdar://problem/40468716>
524
525         Reviewed by David Kilzer.
526
527         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
528         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
529         (TEST):
530
531 2018-05-31  Chris Dumez  <cdumez@apple.com>
532
533         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
534         https://bugs.webkit.org/show_bug.cgi?id=184893
535         <rdar://problem/39747271>
536
537         Reviewed by Wenson Hsieh.
538
539         Update test to wait until the view is the expected height instead of
540         calling waitForNextPresentationUpdate once and expect the view to
541         have the right height. This fixes the flakiness.
542
543         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
544         (TestWebKitAPI::waitUntilInnerHeightIs):
545         (TestWebKitAPI::TEST):
546
547 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
548
549         test262-runner should run in verbose mode in automation
550         https://bugs.webkit.org/show_bug.cgi?id=186115
551
552         Reviewed by Yusuke Suzuki.
553
554         This patch toggles the verbose mode in the build bot and reports every test file
555         in order to avoid the '1200 seconds without output' issue.
556         * BuildSlaveSupport/build.webkit.org-config/steps.py:
557         (RunTest262Tests):
558         * Scripts/test262/Runner.pm:
559         (processResult):
560
561 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
562
563         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
564         https://bugs.webkit.org/show_bug.cgi?id=186079
565
566         Reviewed by Alex Christensen.
567
568         This is a sub task of Bug 184770.
569
570         This change is partial. I'm going to remove global variables
571         gMainWindow and gMiniBrowser and convert more functions to
572         MainWindow's methods in follow-up patches.
573
574         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
575         * MiniBrowser/win/Common.cpp:
576         (menuItemIsChecked): Moved to MainWindow.cpp.
577         (turnOffOtherUserAgents): Ditto.
578         (EditProc): Ditto.
579         (BackButtonProc): Ditto.
580         (ForwardButtonProc): Ditto.
581         (About): Ditto.
582         (Caches): Ditto.
583         (CustomUserAgent): Ditto.
584         (AuthDialogProc): Ditto.
585         (DisplayAuthDialog): Converted to MainWindow's method.
586         (ToggleMenuItem): Ditto.
587         (loadURL): Ditto.
588         * MiniBrowser/win/Common.h:
589         * MiniBrowser/win/MainWindow.cpp:
590         (MainWindow::init): Call SetFocus at the end of the construction.
591         (MainWindow::WndProc):
592         (menuItemIsChecked): Moved from Common.cpp.
593         (turnOffOtherUserAgents): Ditto.
594         (EditProc): Ditto.
595         (BackButtonProc): Ditto.
596         (ForwardButtonProc): Ditto.
597         (About): Ditto.
598         (Caches): Ditto.
599         (CustomUserAgent): Ditto.
600         (authDialogProc): Ditto.
601         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
602         (MainWindow::toggleMenuItem): Ditto.
603         (MainWindow::loadURL): Ditto.
604         * MiniBrowser/win/MainWindow.h: Added method declarations.
605         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
606         * MiniBrowser/win/WinMain.cpp:
607         (wWinMain): Include Common.h instead of Common.cpp.
608
609 2018-05-30  Brady Eidson  <beidson@apple.com>
610
611         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
612         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
613
614         Reviewed by Andy Estes.
615
616         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
618         (WTR::TestRunner::setCustomUserAgent):
619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
620         * WebKitTestRunner/TestController.cpp:
621         (WTR::TestController::resetStateToConsistentValues):
622         * WebKitTestRunner/TestInvocation.cpp:
623         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
624
625 2018-05-30  Youenn Fablet  <youenn@apple.com>
626
627         Rename CrossOriginResourcePolicy same to same-origin
628         https://bugs.webkit.org/show_bug.cgi?id=186080
629
630         Reviewed by Chris Dumez.
631
632         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
633         (TestWebKitAPI::TEST):
634
635 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
636
637         [GTK] Unreviewed test gardening
638         https://bugs.webkit.org/show_bug.cgi?id=186098
639
640         Unreviewed gardening.
641
642         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
643
644 2018-05-29  Youenn Fablet  <youenn@apple.com>
645
646         Add a consistency check between URL and CFURL
647         https://bugs.webkit.org/show_bug.cgi?id=182444
648         <rdar://problem/37164835>
649
650         Reviewed by Geoff Garen.
651
652         DRT code expected a non null URL which is no longer the case now.
653         Updated DRT to remove that assumption.
654
655         * DumpRenderTree/TestRunner.cpp:
656         (TestRunner::redirectionDestinationForURL):
657         * DumpRenderTree/TestRunner.h:
658         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
659         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
660
661 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
662
663         Export changes to web-platform-test as part of the webkit-patch upload workflow
664         https://bugs.webkit.org/show_bug.cgi?id=184914
665
666         Reviewed by Youenn Fablet.
667
668         * Scripts/webkitpy/tool/commands/upload.py:
669         (Upload):
670         (CreateBug.execute):
671         (WPTChangeExport):
672         * Scripts/webkitpy/tool/steps/__init__.py:
673         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
674         (WPTChangeExport):
675         (WPTChangeExport.options):
676         (WPTChangeExport.run):
677         * Scripts/webkitpy/w3c/common.py:
678         * Scripts/webkitpy/w3c/test_exporter.py:
679         (WebPlatformTestExporter):
680         (WebPlatformTestExporter.__init__):
681         (WebPlatformTestExporter.username):
682         (WebPlatformTestExporter.token):
683         (WebPlatformTestExporter._github):
684         (WebPlatformTestExporter._wpt_fork_branch_github_url):
685         (WebPlatformTestExporter._wpt_fork_remote):
686         (WebPlatformTestExporter._wpt_fork_push_url):
687         (WebPlatformTestExporter._git):
688         (WebPlatformTestExporter._branch_name):
689         (WebPlatformTestExporter._public_branch_name):
690         (WebPlatformTestExporter._wpt_patch):
691         (WebPlatformTestExporter.has_wpt_changes):
692         (WebPlatformTestExporter._find_filename):
693         (WebPlatformTestExporter._is_ignored_file):
694         (WebPlatformTestExporter._strip_ignored_files_from_diff):
695         (WebPlatformTestExporter.write_git_patch_file):
696         (WebPlatformTestExporter._prompt_for_token):
697         (WebPlatformTestExporter._prompt_for_username):
698         (WebPlatformTestExporter._ensure_username_and_token):
699         (WebPlatformTestExporter._validate_and_save_token):
700         (WebPlatformTestExporter.create_branch_with_patch):
701         (WebPlatformTestExporter.push_to_wpt_fork):
702         (WebPlatformTestExporter.make_pull_request):
703         (WebPlatformTestExporter.delete_local_branch):
704         (WebPlatformTestExporter.create_upload_remote_if_needed):
705         (WebPlatformTestExporter.do_export):
706         (parse_args):
707         (TestExporter): Deleted.
708         (TestExporter.__init__): Deleted.
709         (TestExporter._ensure_wpt_repository): Deleted.
710         (TestExporter._fetch_wpt_repository): Deleted.
711         (TestExporter._ensure_new_branch_name): Deleted.
712         (TestExporter.download_and_commit_patch): Deleted.
713         (TestExporter.clean): Deleted.
714         (TestExporter.create_branch_with_patch): Deleted.
715         (TestExporter.push_to_wpt_fork): Deleted.
716         (TestExporter.make_pull_request): Deleted.
717         (TestExporter.create_wpt_pull_request): Deleted.
718         (TestExporter.delete_local_branch): Deleted.
719         (TestExporter.create_git_patch): Deleted.
720         (TestExporter.create_upload_remote): Deleted.
721         (TestExporter.do_export): Deleted.
722         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
723         (TestExporterTest.MockGit):
724         (TestExporterTest.MockGit.create_patch):
725         (TestExporterTest.test_export):
726         (TestExporterTest.test_export_with_specific_branch):
727         (TestExporterTest):
728         (TestExporterTest.test_export_interactive_mode):
729         (TestExporterTest.test_export_invalid_token):
730         (TestExporterTest.test_export_wrong_token):
731         (TestExporterTest.test_has_wpt_changes):
732         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
733         (TestExporterTest.test_ignore_changes_to_expected_file):
734
735 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
736
737         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
738         https://bugs.webkit.org/show_bug.cgi?id=186029
739
740         Reviewed by Alex Christensen.
741
742         This is a sub task of Bug 184770.
743
744         * MiniBrowser/win/Common.cpp:
745         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
746         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
747         (AbortProc): Moved to MiniBrowser.cpp.
748         (getPrinterDC): Ditto.
749         (initDocStruct): Ditto.
750         (PrintView): Ditto.
751         (ToggleMenuFlag): Ditto.
752         (setWindowText): Ditto.
753         (updateStatistics): Ditto.
754         * MiniBrowser/win/MainWindow.cpp:
755         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
756         * MiniBrowser/win/MiniBrowser.cpp:
757         (AbortProc): Moved from Common.cpp.
758         (getPrinterDC): Moved from Common.cpp.
759         (initDocStruct): Moved from Common.cpp.
760         (setWindowText): Moved from Common.cpp.
761         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
762         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
763         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
764         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
765         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
766
767 2018-05-29  Saam Barati  <sbarati@apple.com>
768
769         JSC should put bmalloc's scavenger into mini mode
770         https://bugs.webkit.org/show_bug.cgi?id=185988
771
772         Reviewed by Michael Saboff.
773
774         This patch makes it so that we turn off the JIT when running run-testmem
775         that way we make JSC use its mini mode.
776
777         * Scripts/run-testmem:
778
779 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
780
781         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
782         https://bugs.webkit.org/show_bug.cgi?id=185835
783         <rdar://problem/39142257>
784
785         Reviewed by Chris Dumez.
786
787         Add API test coverage.
788
789         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
790         (TEST):
791
792 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
793
794         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
795         https://bugs.webkit.org/show_bug.cgi?id=186042
796         <rdar://problem/40604182>
797
798         Reviewed by Tim Horton.
799
800         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
801         significant portion of the page has been painted before document load is finished.
802
803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
804         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
805         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
806         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
807         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
808         (-[RenderingProgressHandler initWithHandler:]):
809         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
810         (TEST):
811
812 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
813
814         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
815         https://bugs.webkit.org/show_bug.cgi?id=186040
816
817         The patch we merge contained a type and was merged in upstream GStreamer fixing that
818         (s/avalaible/available/).
819
820         Reviewed by Xabier Rodriguez-Calvar.
821
822         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
823
824 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
825
826         Add an API test to check process privilege when using Cookie API
827         https://bugs.webkit.org/show_bug.cgi?id=185406
828
829         Reviewed by Geoffrey Garen.
830
831         Add API test coverage.
832
833         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
834         (TEST):
835
836 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
837
838         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
839         https://bugs.webkit.org/show_bug.cgi?id=185948
840
841         Reviewed by Xabier Rodriguez-Calvar.
842
843         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
844         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
845         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
846         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
847
848         * gstreamer/jhbuild.modules:
849         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
850         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
851         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
852
853 2018-05-27  Dan Bernstein  <mitz@apple.com>
854
855         Reverted the changes made for https://webkit.org/b/186016
856
857         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
858
859 2018-05-27  Dan Bernstein  <mitz@apple.com>
860
861         [Cocoa] Avoid importing directly from subumbrella frameworks
862         https://bugs.webkit.org/show_bug.cgi?id=186016
863
864         Reviewed by Sam Weinig.
865
866         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
867           LaunchServices header.
868         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
869           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
870         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
871           when using SDKs earlier than 10.13.
872         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
873           and OTHER_CPLUSPLUSFLAGS.
874         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
875           HIToolbox header.
876         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
877           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
878         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
879           LaunchServices header.
880
881 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
882
883         [Win][MiniBrowser] Add MainWindow class
884         https://bugs.webkit.org/show_bug.cgi?id=185814
885
886         Reviewed by Per Arne Vollan.
887
888         This is a sub task of Bug 184770. Added a new class MainWindow to
889         represent the main window which will be shared among WK1 and WK2.
890
891         This change is partial so that it's easy to review this patch.
892         I'll move more functions into MainWindow.cpp, and remove more
893         global variables in forthcoming patches.
894
895         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
896         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
897         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
898         hForwardButtonWnd. Added a new global variable gMainWindow.
899         (WndProc): Moved to MainWindow.cpp.
900         (resizeSubViews): Ditto.
901         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
902         (ToggleMenuItem): Ditto.
903         (CustomUserAgent): Follow the global variables removal.
904         (DisplayAuthDialog): Ditto.
905         (loadURL): Ditto.
906         (WndProc): Renamed to MainWindow::WndProc.
907         * MiniBrowser/win/MainWindow.cpp: Added.
908         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
909         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
910         (MainWindow::resizeSubViews): Moved from Common.cpp.
911         (MainWindow::WndProc): Ditto.
912         * MiniBrowser/win/MainWindow.h: Added.
913         (MainWindow::hwnd):
914         (MainWindow::browserWindow):
915         * MiniBrowser/win/MiniBrowser.cpp:
916         (MiniBrowser::init):
917         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
918         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
919         * MiniBrowser/win/MiniBrowser.h:
920         * MiniBrowser/win/WinMain.cpp:
921         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
922         (MyRegisterClass): Moved to MainWindow.cpp.
923
924 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
925
926         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
927         https://bugs.webkit.org/show_bug.cgi?id=185969
928
929         Reviewed by Alex Christensen.
930
931         MiniBrowser::init takes URL argument, but it's used only for
932         loading default HTML if URL is not given.
933
934         - Add a new method MiniBrowser::loadHTMLString
935         - Remove loadHTMLString process from MiniBrowser::prepareViews
936
937         * MiniBrowser/win/MiniBrowser.cpp:
938         (MiniBrowser::init): Removed `requestedURL` argument.
939         (MiniBrowser::prepareViews): Ditto.
940         (MiniBrowser::loadHTMLString): New.
941         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
942         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
943         * MiniBrowser/win/WinMain.cpp:
944         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
945
946 2018-05-27  David Kilzer  <ddkilzer@apple.com>
947
948         svn-apply fails when a patch has an empty file
949         <https://webkit.org/b/29684>
950
951         Reviewed by Daniel Bates.
952
953         Prior to this change, applying the following patches resulted in:
954         - svn: add empty file     (failure)
955         - svn: delete empty file  (failure)
956         - svn: rename empty file  (failure)
957         - git: add empty file     (false-positive success)
958         - git: delete empty file  (success)
959         - git: rename empty file  (failure)
960
961         * Scripts/VCSUtils.pm:
962         (parseSvnDiffHeader): Handle the case when there is no patch
963         following the header.  If the file exists and is empty, that
964         means it's a deletion.  If the file does not exist, that means
965         it's an addition. Everything else is a fatal error.
966         * Scripts/svn-apply:
967         (patch):
968         - Only apply a patch for deletion if it has one or more text
969           chunks.
970         - Add a case to handle adding an empty file (an addition with no
971           text chunks), and verify the file doesn't exist yet.
972         - Any unhandled patch is a fatal error.
973         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
974         Add tests for adding an empty file and deleting an empty file.
975         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
976         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
977         test case.
978
979 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
980
981         Display detailed error logs when a script fails in EWS
982         https://bugs.webkit.org/show_bug.cgi?id=175696
983         <rdar://problem/34841885>
984
985         Reviewed by Darin Adler.
986
987         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
988         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
989         * Scripts/webkitpy/tool/commands/download.py: Ditto.
990         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
991         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
992         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
993
994 2018-05-25  Daniel Bates  <dabates@apple.com>
995
996         test-webkitpy messages logged using __main__ logger are not displayed
997         https://bugs.webkit.org/show_bug.cgi?id=185823
998
999         Rubber-stamped by Aakash Jain.
1000
1001         Configure the logger for __main__ so that messages that are logged before it parses its
1002         command line arguments are printed to standard error.
1003
1004         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
1005         not configure a stream to use for printing until after it parses its command line arguments
1006         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
1007         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
1008         earlier because the latter both configures a stream and filters logged messages based on
1009         the specified verbosity. Logged messaged from code in __main__ should not be subject to
1010         such filtering. So, we explicitly configure the __main__ logger.
1011
1012         * Scripts/webkitpy/test/main.py:
1013         (main):
1014
1015 2018-05-25  Saam Barati  <sbarati@apple.com>
1016
1017         Make JSC have a mini mode that kicks in when the JIT is disabled
1018         https://bugs.webkit.org/show_bug.cgi?id=185931
1019
1020         Reviewed by Mark Lam.
1021
1022         This renames a variable for clarity.
1023
1024         * Scripts/run-testmem:
1025
1026 2018-05-25  Alex Christensen  <achristensen@webkit.org>
1027
1028         URL::host should return a StringView to reduce allocations
1029         https://bugs.webkit.org/show_bug.cgi?id=185986
1030
1031         Reviewed by Geoff Garen.
1032
1033         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1034         (TestWebKitAPI::TEST_F):
1035         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1036         (TestWebKitAPI::eq):
1037         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
1038         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1039
1040 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
1041
1042         Minor improvements to wpt exporter.
1043         https://bugs.webkit.org/show_bug.cgi?id=185978
1044
1045         Reviewed by Youenn Fablet.
1046
1047         * Scripts/webkitpy/w3c/test_exporter.py:
1048         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
1049         (TestExporter.make_pull_request): Improve the description of the created PR.
1050         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
1051
1052 2018-05-25  Saam Barati  <sbarati@apple.com>
1053
1054         Have a memory test where we can validate JSCs mini memory mode
1055         https://bugs.webkit.org/show_bug.cgi?id=185932
1056
1057         Reviewed by Mark Lam.
1058
1059         This patch adds the run-testmem script. This runs the new testmem
1060         CLI against the contents in the testmem benchmark. The contents of testmem
1061         contain tests from ARES-6, Sunspider, Octane, and JetStream.
1062         
1063         One iteration of the benchmark comprises of running each testmem test for
1064         a certain number of iterations. We collect the peak memory usage, the memory
1065         usage after running all the iterations, and the time it takes to run all the
1066         iterations. We then run the entire benchmark 3 times over. For each test, we
1067         compute the arithmetic mean over each iteration for time, peak memory, and
1068         end memory. The benchmark then computes a time score and memory score.
1069         
1070         peak memory score = geomean({peak memory of each individual test})
1071         end memory score = geomean({end memory of each individual test})
1072         memory score = geomean({peak memory score, end memory score})
1073         time score = geomean({time score of each individual test})
1074         
1075         We want the memory score to weigh improvements to peak memory usage and
1076         memory usage at the end equally.
1077         
1078         We plan to tune this benchmark in JSC's mini mode by improving the memory
1079         score while ensuring the time score is not more than 10-15% regressed.
1080
1081         * Scripts/run-testmem: Added.
1082
1083 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
1084
1085         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1086         https://bugs.webkit.org/show_bug.cgi?id=185041
1087         <rdar://problem/34684214>
1088
1089         Reviewed by Geoffrey Garen.
1090
1091         Add API test coverage.
1092
1093         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1094         (TEST):
1095
1096 2018-05-24  Chris Dumez  <cdumez@apple.com>
1097
1098         Reduce copying of FontCascadeDescription objects by moving them around
1099         https://bugs.webkit.org/show_bug.cgi?id=185963
1100
1101         Reviewed by Simon Fraser.
1102
1103         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1104
1105         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1106         (TestWebKitAPI::TEST_F):
1107
1108 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1109
1110         WebDriver: implement maximize, minimize and fullscreen window commands
1111         https://bugs.webkit.org/show_bug.cgi?id=180398
1112
1113         Reviewed by Brian Burg.
1114
1115         * Scripts/webkitpy/port/xvfbdriver.py:
1116         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
1117
1118 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1119
1120         [GStreamer] Save some time disabling some compile options in the dependencies
1121         https://bugs.webkit.org/show_bug.cgi?id=185909
1122
1123         Reviewed by Philippe Normand.
1124
1125         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
1126         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
1127
1128 2018-05-23  Roy Reapor  <rreapor@apple.com>
1129
1130         Use Helvetica on build.webkit.org webpages
1131         https://bugs.webkit.org/show_bug.cgi?id=185894
1132
1133         Reviewed by Aakash Jain.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1138
1139 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
1140
1141         Add Buildbot configuration for Opensource EWS
1142         https://bugs.webkit.org/show_bug.cgi?id=185484
1143
1144         Rubber-stamped by Alexey Proskuryakov.
1145
1146         * BuildSlaveSupport/ews-build/config.json: Added, config file.
1147         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
1148         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
1149         (loadBuilderConfig): Loads the configuration.
1150         (checkValidWorker): Checks if the worker is valid.
1151         (checkValidBuilder): Checks if the builder is valid.
1152         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
1153         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
1154         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
1155         (getValidTags): Returns a list of valid tags.
1156         (getTagsForBuilder): Return a list of tags for given builder.
1157         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
1158         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
1159
1160 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
1161
1162         [GTK] Silence GCC 8 warnings
1163         https://bugs.webkit.org/show_bug.cgi?id=185556
1164
1165         Reviewed by Žan Doberšek.
1166
1167         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
1168         source and destination are always identical. But switching to snprintf avoids the warning.
1169
1170         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
1171         (FormValue::NPP_GetValue):
1172
1173 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
1174
1175         Unreviewed, rolling out r232112.
1176
1177         The tests added with this change  are failing on the bots.
1178
1179         Reverted changeset:
1180
1181         "test262/Runner.pm: add unit tests"
1182         https://bugs.webkit.org/show_bug.cgi?id=185783
1183         https://trac.webkit.org/changeset/232112
1184
1185 2018-05-23  Valerie R Young  <valerie@bocoup.com>
1186
1187         test262/Runner.pm: add unit tests
1188         https://bugs.webkit.org/show_bug.cgi?id=185783
1189
1190         Reviewed by Aakash Jain.
1191
1192         Add unit tests to be run by test-webkitperl
1193
1194         * Scripts/test262/Runner.pm:
1195         (main):
1196          - If harness files cannot be found in a custom, supplies test262 path,
1197            then sure the webkit test262 harness files.
1198          - Lazily create the test262-results directory.
1199          - If an expectation file is supplied via command line, save to the
1200            supplied location instead of the detault webkit location.
1201         (compileTest):
1202         (processResult):
1203         (getHarness):
1204         * Scripts/webkitperl/test262_unittest/README: Added.
1205         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
1206         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
1207         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
1208         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
1209         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
1210         (f):
1211         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
1212         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
1213         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
1214         (f):
1215         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
1216
1217 2018-05-22  Roy Reapor  <rreapor@apple.com>
1218
1219         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
1220         https://bugs.webkit.org/show_bug.cgi?id=185788
1221
1222         Reviewed by Aakash Jain.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
1227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1229         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1230         * TestResultServer/static-dashboards/run-unittests.html:
1231
1232 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1233
1234         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
1235         https://bugs.webkit.org/show_bug.cgi?id=185831
1236
1237         Reviewed by Chris Dumez.
1238
1239         Updated the test to prevent crash after assertion fails.
1240
1241         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1242         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1243
1244 2018-05-22  Chris Dumez  <cdumez@apple.com>
1245
1246         Regression(AsyncPolicyDelegates): Box.app login Window is blank
1247         https://bugs.webkit.org/show_bug.cgi?id=185832
1248         <rdar://problem/40307871>
1249
1250         Reviewed by Geoffrey Garen.
1251
1252         Add API test coverage.
1253
1254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1255         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
1256         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
1257         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1258         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
1259         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
1260         (TestWebKitAPI::TEST):
1261         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1262         (-[WKWebView _isBackground]):
1263
1264 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1265
1266         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
1267         https://bugs.webkit.org/show_bug.cgi?id=185715
1268
1269         Reviewed by Geoffrey Garen.
1270
1271         Add API test coverage.
1272
1273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1274         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
1275         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1276         (TEST):
1277
1278 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1279
1280         Unreviewed, added myself as a WebKit committer.
1281
1282         * Scripts/webkitpy/common/config/contributors.json:
1283
1284 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
1285
1286         Unreviewed, rolling out r232052.
1287
1288         Breaks internal builds.
1289
1290         Reverted changeset:
1291
1292         "Use more C++17"
1293         https://bugs.webkit.org/show_bug.cgi?id=185176
1294         https://trac.webkit.org/changeset/232052
1295
1296 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
1297
1298         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
1299         https://bugs.webkit.org/show_bug.cgi?id=185689
1300
1301         Reviewed by Philippe Normand.
1302
1303         And update the patches, removing the ones that have been merged upstream.
1304
1305         * gstreamer/jhbuild.modules:
1306         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
1307         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
1308         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
1309         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
1310         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
1311         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
1312         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
1313         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
1314
1315 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1316
1317         Use more C++17
1318         https://bugs.webkit.org/show_bug.cgi?id=185176
1319
1320         Reviewed by JF Bastien.
1321
1322         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1323         * ImageDiff/cg/Configurations/Base.xcconfig:
1324         * MiniBrowser/Configurations/Base.xcconfig:
1325         * MobileMiniBrowser/Configurations/Base.xcconfig:
1326         * TestWebKitAPI/Configurations/Base.xcconfig:
1327         * WebKitTestRunner/Configurations/Base.xcconfig:
1328
1329 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1330
1331         [WinCairo] Enable WebKit build by default
1332         https://bugs.webkit.org/show_bug.cgi?id=185141
1333
1334         Reviewed by Per Arne Vollan.
1335
1336         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
1337         WebKitForwardingHeaders because config.h includes a header of WK2.
1338
1339         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
1340         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
1341
1342 2018-05-21  Jer Noble  <jer.noble@apple.com>
1343
1344         Complete fix for enabling modern EME by default
1345         https://bugs.webkit.org/show_bug.cgi?id=185770
1346         <rdar://problem/40368220>
1347
1348         Reviewed by Eric Carlson.
1349
1350         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1351
1352 2018-05-18  Christopher Reid  <chris.reid@sony.com>
1353
1354         Unreviewed, add myself as a WebKit committer.
1355
1356         * Scripts/webkitpy/common/config/contributors.json:
1357
1358 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1359
1360         Unreviewed, rolling out r222967.
1361
1362         It's not ready yet
1363
1364         Reverted changeset:
1365
1366         "[GTK][WPE] Add API to configure and enable resource load
1367         statistics"
1368         https://bugs.webkit.org/show_bug.cgi?id=177943
1369         https://trac.webkit.org/changeset/222967
1370
1371 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1372
1373         [GTK] MiniBrowser crashes when loading twice quickly
1374         https://bugs.webkit.org/show_bug.cgi?id=185763
1375
1376         Reviewed by Michael Catanzaro.
1377
1378         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
1379         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
1380         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
1381         leaked, it will crash when scheduled if the window has already been destroyed.
1382
1383         * MiniBrowser/gtk/BrowserWindow.c:
1384         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
1385
1386 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
1387
1388         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
1389         https://bugs.webkit.org/show_bug.cgi?id=185624
1390         <rdar://problem/39111626>
1391
1392         Reviewed by Chris Dumez.
1393
1394         Modified expectation to make test more robust as cookies can be returned in different orders.
1395
1396         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1397         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1398         (TEST):
1399
1400 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1401
1402         Unreviewed, rolling out r231982.
1403         https://bugs.webkit.org/show_bug.cgi?id=185793
1404
1405         Caused layout test failures (Requested by realdawei on
1406         #webkit).
1407
1408         Reverted changeset:
1409
1410         "Complete fix for enabling modern EME by default"
1411         https://bugs.webkit.org/show_bug.cgi?id=185770
1412         https://trac.webkit.org/changeset/231982
1413
1414 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1415
1416         Handle failure to extend sandbox gracefully
1417         https://bugs.webkit.org/show_bug.cgi?id=185779
1418         <rdar://problem/40316349>
1419
1420         Unreviewed, fix test results.
1421
1422         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1423         (TEST_F):
1424
1425 2018-05-18  Jer Noble  <jer.noble@apple.com>
1426
1427         Complete fix for enabling modern EME by default
1428         https://bugs.webkit.org/show_bug.cgi?id=185770
1429         <rdar://problem/40368220>
1430
1431         Reviewed by Eric Carlson.
1432
1433         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1434
1435 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1436
1437         Handle failure to extend sandbox gracefully
1438         https://bugs.webkit.org/show_bug.cgi?id=185779
1439         <rdar://problem/40316349>
1440
1441         Reviewed by Brent Fulgham.
1442
1443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1444         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
1445         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
1446         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1447         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1448         (MediaCaptureSimulateFailedSandbox::SetUp):
1449         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
1450         (TEST_F):
1451         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
1452
1453 2018-05-18  Daniel Bates  <dabates@apple.com>
1454
1455         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
1456         https://bugs.webkit.org/show_bug.cgi?id=185774
1457
1458         Reviewed by Andy Estes.
1459
1460         For now, the script debug-safari is not supported for WebKit for iOS. To
1461         fix this we differentiate between the Apple Mac port and Apple embedded
1462         ports.
1463
1464         * Scripts/webkitdirs.pm:
1465         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1466         (isAppleMacWebKit): Added.
1467         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
1468         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1469         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
1470         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1471         (runSafari): Ditto.
1472         (runMiniBrowser): Ditto.
1473         (debugMiniBrowser): Ditto.
1474         (runWebKitTestRunner): Ditto.
1475         (debugWebKitTestRunner): Ditto.
1476
1477 2018-05-18  Antoine Quint  <graouts@apple.com>
1478
1479         [Web Animations] Turn Web Animations with CSS integration on for test runners
1480         https://bugs.webkit.org/show_bug.cgi?id=184819
1481         <rdar://problem/39597337>
1482
1483         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
1484
1485         * DumpRenderTree/TestOptions.cpp:
1486         (TestOptions::TestOptions):
1487         * DumpRenderTree/TestOptions.h:
1488         * DumpRenderTree/mac/DumpRenderTree.mm:
1489         (runTest):
1490         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
1491         * WebKitTestRunner/TestController.cpp:
1492         (WTR::TestController::resetPreferencesToConsistentValues):
1493         (WTR::updateTestOptionsFromTestHeader):
1494         * WebKitTestRunner/TestOptions.cpp:
1495         (WTR::TestOptions::TestOptions):
1496         (WTR::isLegacyAnimationEngineTestPath): Deleted.
1497         * WebKitTestRunner/TestOptions.h:
1498
1499 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1500
1501         [Win][MiniBrowser] Create MainWindow even in transparent mode
1502         https://bugs.webkit.org/show_bug.cgi?id=185597
1503
1504         Reviewed by Per Arne Vollan.
1505
1506         The current implementations doesn't create the MainWindow in
1507         transparent mode. The screenshot is in Bug 58300.
1508
1509         There were three problems:
1510         - Can't control the WebView. ie. going backward and forward.
1511         - Can't quit the program.
1512         - It makes implementation complicated.
1513
1514         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
1515         even in the transparent mode.
1516         * MiniBrowser/win/WinMain.cpp:
1517         (wWinMain): Create the main window even in the transparent mode.
1518
1519 2018-05-18  Antoine Quint  <graouts@apple.com>
1520
1521         [Web Animations] Turn Web Animations with CSS integration on for test runners
1522         https://bugs.webkit.org/show_bug.cgi?id=184819
1523         <rdar://problem/39597337>
1524
1525         Reviewed by Jon Lee.
1526
1527         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
1528         integration flag on.
1529
1530         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
1531         comment directly at the top of the file since test runners now set the flag on by default
1532         and a dedicated directory exists for tests that need to run with this flag off.
1533
1534         * DumpRenderTree/TestOptions.cpp:
1535         (TestOptions::TestOptions):
1536         * DumpRenderTree/TestOptions.h:
1537         * DumpRenderTree/mac/DumpRenderTree.mm:
1538         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
1539         (runTest):
1540         * WebKitTestRunner/TestController.cpp:
1541         (WTR::TestController::resetPreferencesToConsistentValues):
1542         (WTR::updateTestOptionsFromTestHeader):
1543         * WebKitTestRunner/TestOptions.cpp:
1544         (WTR::isLegacyAnimationEngineTestPath):
1545         (WTR::TestOptions::TestOptions):
1546         * WebKitTestRunner/TestOptions.h:
1547
1548 2018-05-17  Nan Wang  <n_wang@apple.com>
1549
1550         AX: [macOS] Expose the primary screen height through AX API
1551         https://bugs.webkit.org/show_bug.cgi?id=185742
1552
1553         Reviewed by Chris Fleizach.
1554
1555         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1556         (attributesOfElement):
1557         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1558         (WTR::attributesOfElement):
1559
1560 2018-05-17  Commit Queue  <commit-queue@webkit.org>
1561
1562         Unreviewed, rolling out r231912.
1563         https://bugs.webkit.org/show_bug.cgi?id=185750
1564
1565         It is prompting the user when there is no WPT changes
1566         (Requested by bmac on #webkit).
1567
1568         Reverted changeset:
1569
1570         "Export changes to web-platform-test as part of the webkit-
1571         patch upload workflow"
1572         https://bugs.webkit.org/show_bug.cgi?id=184914
1573         https://trac.webkit.org/changeset/231912
1574
1575 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1576
1577         test262/Runner.pm: expand $INC to find webkitdirs.pm
1578         https://bugs.webkit.org/show_bug.cgi?id=185739
1579
1580         Reviewed by Michael Saboff.
1581
1582         * Scripts/test262/Runner.pm:
1583         (getBuildPath):
1584
1585 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1586
1587         [WPE] Implement and enable FULLSCREEN_API
1588         https://bugs.webkit.org/show_bug.cgi?id=185676
1589
1590         Reviewed by Žan Doberšek.
1591
1592         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1593         (testWebViewFullScreen):
1594
1595 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
1596
1597         Export changes to web-platform-test as part of the webkit-patch upload workflow
1598         https://bugs.webkit.org/show_bug.cgi?id=184914
1599
1600         Reviewed by Youenn Fablet.
1601
1602         * Scripts/webkitpy/tool/commands/upload.py:
1603         (Upload):
1604         (CreateBug.execute):
1605         (WPTChangeExport):
1606         * Scripts/webkitpy/tool/steps/__init__.py:
1607         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1608         (WPTChangeExport):
1609         (WPTChangeExport.options):
1610         (WPTChangeExport.run):
1611         * Scripts/webkitpy/w3c/common.py:
1612         * Scripts/webkitpy/w3c/test_exporter.py:
1613         (WebPlatformTestExporter):
1614         (WebPlatformTestExporter.__init__):
1615         (WebPlatformTestExporter.username):
1616         (WebPlatformTestExporter.token):
1617         (WebPlatformTestExporter._github):
1618         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1619         (WebPlatformTestExporter._wpt_fork_remote):
1620         (WebPlatformTestExporter._wpt_fork_push_url):
1621         (WebPlatformTestExporter._git):
1622         (WebPlatformTestExporter._branch_name):
1623         (WebPlatformTestExporter._public_branch_name):
1624         (WebPlatformTestExporter.has_wpt_changes):
1625         (WebPlatformTestExporter._create_patch):
1626         (WebPlatformTestExporter.create_git_patch):
1627         (WebPlatformTestExporter._prompt_for_token):
1628         (WebPlatformTestExporter._prompt_for_username):
1629         (WebPlatformTestExporter._ensure_username_and_token):
1630         (WebPlatformTestExporter._validate_and_save_token):
1631         (WebPlatformTestExporter.push_to_wpt_fork):
1632         (WebPlatformTestExporter.make_pull_request):
1633         (WebPlatformTestExporter.delete_local_branch):
1634         (parse_args):
1635         (TestExporter): Deleted.
1636         (TestExporter.__init__): Deleted.
1637         (TestExporter._ensure_wpt_repository): Deleted.
1638         (TestExporter._fetch_wpt_repository): Deleted.
1639         (TestExporter._ensure_new_branch_name): Deleted.
1640         (TestExporter.download_and_commit_patch): Deleted.
1641         (TestExporter.clean): Deleted.
1642         (TestExporter.create_branch_with_patch): Deleted.
1643         (TestExporter.push_to_wpt_fork): Deleted.
1644         (TestExporter.make_pull_request): Deleted.
1645         (TestExporter.create_wpt_pull_request): Deleted.
1646         (TestExporter.delete_local_branch): Deleted.
1647         (TestExporter.create_git_patch): Deleted.
1648         (TestExporter.create_upload_remote_if_needed): Deleted.
1649         (TestExporter.do_export): Deleted.
1650         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1651         (TestExporterTest.test_export):
1652         (TestExporterTest.test_export_with_specific_branch):
1653         (TestExporterTest):
1654         (TestExporterTest.test_export_interactive_mode):
1655         (TestExporterTest.test_export_invalid_token):
1656         (TestExporterTest.test_export_wrong_token):
1657
1658 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1659
1660         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
1661         https://bugs.webkit.org/show_bug.cgi?id=185650
1662
1663         Reviewed by Michael Saboff.
1664
1665         First, use jsc from CLI arg, then try to use webkit-build-directory,
1666         if that doesn't work, look for jsc in the $PATH
1667
1668         * Scripts/test262/Runner.pm:
1669         (processCLI):
1670         (getBuildPath):
1671         (runTest):
1672
1673 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1674
1675         Test262-Runner: Adds a --timeout option
1676         https://bugs.webkit.org/show_bug.cgi?id=185696
1677
1678         Reviewed by Michael Saboff.
1679
1680         The timeout option is used to set a timeout execution in ms for each test run in JSC.
1681         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
1682         * Scripts/test262/Runner.pm:
1683         (processCLI):
1684         (runTest):
1685
1686 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1687
1688         Test262-Runner: Set timer for each test run
1689         https://bugs.webkit.org/show_bug.cgi?id=185692
1690
1691         Reviewed by Michael Saboff.
1692
1693         Sets a high resolution timer for each execution call of JSC, reporting
1694         the time in the results report to allow identifying slow tests.
1695         * Scripts/test262/Runner.pm:
1696         (main):
1697         (processFile):
1698         (runTest):
1699         (processResult):
1700
1701 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
1702
1703         Add support for Intl NumberFormat formatToParts
1704         https://bugs.webkit.org/show_bug.cgi?id=185375
1705
1706         Reviewed by Yusuke Suzuki.
1707
1708         Add flag for NumberFormat formatToParts.
1709
1710         * Scripts/webkitperl/FeatureList.pm:
1711         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1712
1713 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1714
1715         [Win] Use C++17 in MSVC
1716         https://bugs.webkit.org/show_bug.cgi?id=185232
1717
1718         Reviewed by Alex Christensen.
1719
1720         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
1721         conflicts with ::byte defined in Windows' header.
1722
1723         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1724         (WindowedPluginTest::WindowedPluginTest):
1725         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1726         (logEventProc):
1727         (stringEvent):
1728         (AccessibilityController::winNotificationReceived):
1729         * DumpRenderTree/win/TextInputController.cpp:
1730         (markedRangeCallback):
1731         (firstRectForCharacterRangeCallback):
1732         (selectedRangeCallback):
1733         * DumpRenderTree/win/TextInputController.h:
1734         * DumpRenderTree/win/TextInputControllerWin.cpp:
1735         (TextInputController::markedRange):
1736         (TextInputController::firstRectForCharacterRange):
1737         (TextInputController::selectedRange):
1738
1739 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
1740
1741         Session cookies aren't reliably set when using default WKWebSiteDataStore
1742         https://bugs.webkit.org/show_bug.cgi?id=185624
1743         <rdar://problem/39111626>
1744
1745         Reviewed by Geoffrey Garen.
1746
1747         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
1748
1749         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1750         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1751         (TEST):
1752
1753 2018-05-16  Valerie R Young  <valerie@bocoup.com>
1754
1755         test262/Runner.pm: save to supplied expectation file if supplied
1756         https://bugs.webkit.org/show_bug.cgi?id=185660
1757
1758         Reviewed by Michael Saboff.
1759
1760         * Scripts/test262/Runner.pm:
1761         (processCLI):
1762         (main):
1763
1764 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
1765
1766         Unreviewed, rolling out r231763.
1767
1768         The test added with this change is failing an assertion.
1769
1770         Reverted changeset:
1771
1772         "NSEvent event trackers don't work from WebKitTestRunner"
1773         https://bugs.webkit.org/show_bug.cgi?id=185383
1774         https://trac.webkit.org/changeset/231763
1775
1776 2018-05-15  David Kilzer  <ddkilzer@apple.com>
1777
1778         TestWebKitAPI: Fix warnings found by new clang compiler
1779         <https://webkit.org/b/185631>
1780
1781         Reviewed by Michael Catanzaro.
1782
1783         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1784         (TestWebKitAPI::TEST):
1785         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1786         (TestWebKitAPI::TEST):
1787         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1788         (TestWebKitAPI::TEST):
1789         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1790         (TestWebKitAPI::TEST):
1791         - Add #pragma statements to ignore the new
1792           -Wself-assign-overloaded warning and to ignore
1793           this as an unknown warning on older clang versions.  We want
1794           to keep these self assigments as this code is designed to test
1795           that use case.
1796
1797         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1798         (TestWebKitAPI::didFindStringMatches):
1799         - Replace the "rect = rect;" statement that was used to avoid an
1800           unused variable warning with two expectations.
1801
1802         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1803         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
1804         - Switch from -integerValue to -unsignedIntegerValue when
1805           comparing against _WKRectEdgeAll since it's an enum declared
1806           as an NSUInteger.
1807
1808 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1809
1810         Unreviewed, rolling out r230749
1811
1812         This did not work as desired.
1813
1814         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1815         (TestWebKitAPI::TEST):
1816
1817 2018-05-15  Antoine Quint  <graouts@apple.com>
1818
1819         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1820         https://bugs.webkit.org/show_bug.cgi?id=185647
1821
1822         Reviewed by Dean Jackson.
1823
1824         Rename the Web Animations CSS integration flag.
1825
1826         * DumpRenderTree/TestOptions.cpp:
1827         (TestOptions::TestOptions):
1828         * DumpRenderTree/TestOptions.h:
1829         * DumpRenderTree/mac/DumpRenderTree.mm:
1830         (setWebPreferencesForTestOptions):
1831         * WebKitTestRunner/TestController.cpp:
1832         (WTR::TestController::resetPreferencesToConsistentValues):
1833         (WTR::updateTestOptionsFromTestHeader):
1834         * WebKitTestRunner/TestOptions.h:
1835         (WTR::TestOptions::hasSameInitializationOptions const):
1836
1837 2018-05-14  Brady Eidson  <beidson@apple.com>
1838
1839         Add an API test to guard against regressions while re-entering setDefersLoading:.
1840         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
1841
1842         Reviewed by Chris Dumez.
1843
1844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1845         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
1846         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
1847         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
1848         (-[DefersScheme initWithBytes:]):
1849         (-[DefersScheme webView:startURLSchemeTask:]):
1850         (-[DefersScheme webView:stopURLSchemeTask:]):
1851         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
1852         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1853         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
1854         (-[DoubleDefersLoadingPlugIn dealloc]):
1855
1856 2018-05-14  Daniel Bates  <dabates@apple.com>
1857
1858         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
1859         https://bugs.webkit.org/show_bug.cgi?id=185599
1860         <rdar://problem/22493890>
1861
1862         Reviewed by Simon Fraser.
1863
1864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1865         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
1866         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
1867         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
1868         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
1869         (TestWebKitAPI::TEST):
1870         * TestWebKitAPI/ios/set-timeout-function.html: Added.
1871
1872 2018-05-14  Valerie R Young  <valerie@bocoup.com>
1873
1874         test262/Runner.pm: small bugs in CLI and error codes
1875         https://bugs.webkit.org/show_bug.cgi?id=185629
1876
1877         Reviewed by Michael Saboff.
1878
1879         Fix two commandline args with use '-f', correct
1880         error code of failures.
1881
1882         * Scripts/test262/Runner.pm:
1883         (processCLI):
1884         (main):
1885
1886 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
1887
1888         Disable API tests that time out after pointer poisioning was disabled.
1889         https://bugs.webkit.org/show_bug.cgi?id=185586
1890
1891         Unreviewed test gardening.
1892
1893         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1894         (TestWebKitAPI::TEST):
1895         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1896         (TestWebKitAPI::TEST):
1897         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1898         (TestWebKitAPI::TEST):
1899         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1900         (TestWebKitAPI::TEST):
1901
1902 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
1903
1904         Test262-Runner: Fix RegExp for capturing tests metadata"
1905         https://bugs.webkit.org/show_bug.cgi?id=185622
1906
1907         Reviewed by Michael Saboff.
1908
1909         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
1910         both LF and CRLF forms.
1911
1912         The fix also allows the runner to capture the proper results from two specific files using CR and
1913         CRLF line terminators. They are updated in the expectations file.
1914         * Scripts/test262/Runner.pm:
1915         (parseData):
1916
1917 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
1918
1919         NSEvent event trackers don't work from WebKitTestRunner
1920         https://bugs.webkit.org/show_bug.cgi?id=185383
1921         rdar://problem/40025045
1922
1923         Reviewed by Simon Fraser.
1924
1925         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
1926         NSEvent swipe tracking is used for webkit swipe navigation.
1927
1928         * WebKitTestRunner/mac/EventSenderProxy.mm:
1929         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1930
1931 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
1932
1933         Test262 Runner should search for the Debug JSC by default
1934         https://bugs.webkit.org/show_bug.cgi?id=185562
1935
1936         Reviewed by Michael Saboff.
1937
1938         The Test262 Runner is now searching for the Debug build of JSC by
1939         default, not the Release build.
1940
1941         This fix allows a similar call from the previous runner, making
1942         it compatible with the current build bot configuration parameters.
1943
1944         This patch also adds some minor improvements the verbose mode output.
1945
1946         * Scripts/test262/Runner.pm:
1947         (processCLI):
1948         (main):
1949         (getBuildPath):
1950         (processResult):
1951
1952 2018-05-11  Charles Vazac  <cvazac@gmail.com>
1953
1954         Runtime feature flag for Server-Timing
1955         https://bugs.webkit.org/show_bug.cgi?id=184758
1956
1957         Reviewed by Youenn Fablet.
1958
1959         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
1960         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
1961
1962 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1963
1964         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
1965         https://bugs.webkit.org/show_bug.cgi?id=185418
1966
1967         Reviewed by Alex Christensen.
1968
1969         All WK1 related code should be moved into MiniBrowser for the preparation
1970         of Bug 184770.
1971
1972         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
1973
1974         * MiniBrowser/win/Common.cpp:
1975         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
1976         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
1977         * MiniBrowser/win/Common.h: Added.
1978         * MiniBrowser/win/MiniBrowser.cpp:
1979         (MiniBrowser::init): Moved the initilization code from wWinMain.
1980         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
1981         * MiniBrowser/win/MiniBrowser.h:
1982         (MiniBrowser::setCacheFolder): Changed to a private method.
1983         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
1984         * MiniBrowser/win/WinMain.cpp:
1985         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
1986
1987 2018-05-11  Brady Eidson  <beidson@apple.com>
1988
1989         Make sure history navigations reuse the existing process when necessary.
1990         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
1991
1992         Reviewed by Ryosuke Niwa.
1993
1994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1995
1996 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1997
1998         [JSC][GLIB] Add introspectable alternatives to functions using vargars
1999         https://bugs.webkit.org/show_bug.cgi?id=185508
2000
2001         Reviewed by Michael Catanzaro.
2002
2003         Add test cases for the new API.
2004
2005         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2006         (testJSCFunction):
2007         (testJSCObject):
2008
2009 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
2010
2011         [Build Bot] Restore configuration options to the Test262 Runner
2012
2013         During the switch from the previous Test262 runner to the new one,
2014         a call for an extra configurations options got removed.
2015
2016         This call is important to inform the script to find the debug or
2017         release build of JSC. It's being restored in this patch.
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=185513
2020
2021         Reviewed by Yusuke Suzuki.
2022
2023         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2024         (RunTest262Tests):
2025
2026 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
2027
2028         REGRESSION (r230998): Cannot stream API test output
2029         https://bugs.webkit.org/show_bug.cgi?id=185090
2030
2031         Reviewed by Ryosuke Niwa.
2032
2033         Change run-api-tests so that the stdout and stderr of a test will be printed
2034         before it's result. If -v is passed, the output of single test runs will be
2035         streamed. 
2036
2037         * Scripts/webkitpy/api_tests/run_api_tests.py:
2038         (run): Use print_timestamps flag.
2039         (parse_args): Add timestamps option to print timestamps in the log.
2040         * Scripts/webkitpy/api_tests/runner.py:
2041         (Runner): Add running status.
2042         (Runner.__init__): Add number of workers and a flag to detect if a newline
2043         is needed at the beginning of a log line.
2044         (Runner.run): Turn off most logging coming from server process since it is
2045         not constructive for API tests.
2046         (Runner.handle): Add new log message to stream stdout and stderr instead of
2047         caching values until the test run finished.
2048         (_Worker._run_single_test): Log stdout and stderr in real time.
2049         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
2050         the test.
2051         (_Worker.post): Provide a post with explicitly enumerated argument names.
2052         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2053         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
2054         (MeteredStream.write): Allow for verbose logging without timestamps.
2055         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2056         (RegularTest): Add print_timestamps flag.
2057         (RegularTest.setUp):
2058         (RegularTest.test_logging_not_included):
2059         (VerboseTest.test_log_args):
2060         (VerboseWithOutTimestamp):
2061         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
2062
2063 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
2064
2065         build-webkit can erroneously warn about Xcode being too old
2066         https://bugs.webkit.org/show_bug.cgi?id=185533
2067
2068         Reviewed by Dan Bernstein.
2069
2070         Don't assume the version number is always a single digit.
2071
2072         * Scripts/webkitdirs.pm:
2073         (determineXcodeVersion):
2074
2075 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
2076
2077         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
2078         https://bugs.webkit.org/show_bug.cgi?id=185528
2079
2080         Reviewed by Lucas Forschler.
2081
2082         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2083         (TestFactory.__init__):
2084         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2085         (InstallWinCairoDependencies):
2086
2087 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2088
2089         Fix some -Wstring-op-truncation warnings
2090         https://bugs.webkit.org/show_bug.cgi?id=185496
2091
2092         Reviewed by Alex Christensen.
2093
2094         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
2095         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
2096         set the last bucket to NUL.
2097
2098         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2099         (TestWebKitAPI::testAtomicStringNumber):
2100         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2101         (TestWebKitAPI::testStringNumberFixedPrecision):
2102         (TestWebKitAPI::testStringNumberFixedWidth):
2103         (TestWebKitAPI::testStringNumber):
2104
2105 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2106
2107         [Win][MiniBrowser] Add a separate WndProc for the layered window
2108         https://bugs.webkit.org/show_bug.cgi?id=185460
2109
2110         Reviewed by Brent Fulgham.
2111
2112         All WK1 related code should be moved into MiniBrowser for the
2113         preparation of Bug 184770.
2114
2115         The layered window was using WndProc of the main window. The
2116         layered window is specific only for WK1. the main window will be
2117         shared among WK1 and WK2.
2118
2119         This change add a new WndProc for the layer window.
2120
2121         * MiniBrowser/win/Common.cpp:
2122         (WndProc): Removed code for the layered windows.
2123         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
2124         * MiniBrowser/win/MiniBrowser.cpp:
2125         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
2126         (viewWndProc): New WndProc for the layered windows.
2127         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
2128         * MiniBrowser/win/MiniBrowser.h:
2129         (MiniBrowser::hwnd):
2130         * MiniBrowser/win/WinMain.cpp:
2131         (wWinMain): Added m_viewWnd.
2132
2133 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
2134
2135         Support --verbose in run-javascriptcore-tests
2136         https://bugs.webkit.org/show_bug.cgi?id=185492
2137
2138         Reviewed by Daniel Bates.
2139
2140         * Scripts/run-javascriptcore-tests:
2141         (runJSCStressTests):
2142
2143 2018-05-10  Valerie R Young  <valerie@bocoup.com>
2144
2145         test262/Runner.pm: --failing-files uses results file not expectations
2146         https://bugs.webkit.org/show_bug.cgi?id=185395
2147
2148         Reviewed by Michael Saboff.
2149
2150         --failing-files arg now uses results file to find failing tests
2151         to rerun. It will look in the test262-results directory from whereever
2152         the script is run, or a results.yaml file can be supplied via command
2153         line argument.
2154         --expectations arg added for suppling expectation file.
2155
2156         * Scripts/test262/Runner.pm:
2157         (processCLI):
2158         (main):
2159         (loadImportFile):
2160         (findAllFailing):
2161
2162 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2163
2164         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
2165         https://bugs.webkit.org/show_bug.cgi?id=185506
2166
2167         Reviewed by Philippe Normand.
2168
2169         Useful for testing and debugging.
2170
2171         * MiniBrowser/gtk/main.c:
2172         (main):
2173
2174 2018-05-09  Chris Dumez  <cdumez@apple.com>
2175
2176         Unreviewed Windows build fix after r231622.
2177
2178         * DumpRenderTree/win/DumpRenderTree.cpp:
2179         (enableExperimentalFeatures):
2180
2181 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
2182
2183         Update WebKit.WebsiteDataStoreCustomPaths after r231536
2184         https://bugs.webkit.org/show_bug.cgi?id=185486
2185         <rdar://problem/37214391>
2186
2187         Reviewed by Chris Dumez.
2188
2189         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
2190
2191         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2192         (TEST):
2193
2194 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2195
2196         Test262-Runner: Improve the verbose output
2197         https://bugs.webkit.org/show_bug.cgi?id=185491
2198
2199         Reviewed by Michael Saboff.
2200
2201         * Scripts/test262/Import.pm:
2202         (transferFiles):
2203         * Scripts/test262/Runner.pm:
2204         (processResult):
2205
2206 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2207
2208         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
2209         https://bugs.webkit.org/show_bug.cgi?id=185488
2210
2211         Reviewed by Michael Saboff.
2212
2213         * Scripts/test262/Runner.pm:
2214         (processCLI):
2215         (getBuildPath):
2216         (runTest):
2217
2218 2018-05-09  Richard Houle  <rhoule@apple.com>
2219
2220         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
2221         https://bugs.webkit.org/show_bug.cgi?id=185260
2222         <rdar://problem/39290394>
2223
2224         Reviewed by Tim Horton.
2225
2226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2227         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
2228         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
2229         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
2230         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2231         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2232
2233 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
2234
2235         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2236         https://bugs.webkit.org/show_bug.cgi?id=185481
2237
2238         Reviewed by Philippe Normand.
2239
2240         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2241
2242         * Scripts/webkitpy/port/gtk.py:
2243         (GtkPort.setup_environ_for_server):
2244
2245 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2246
2247         Set build.webkit.org to use the new Test262-runner
2248         https://bugs.webkit.org/show_bug.cgi?id=184933
2249
2250         Reviewed by Aakash Jain.
2251
2252         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2253         (RunTest262Tests):
2254         (RunTest262Tests.countFailures):
2255         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2256
2257 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2258
2259         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
2260         https://bugs.webkit.org/show_bug.cgi?id=185461
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
2265
2266         * gtk/jhbuild.modules:
2267
2268 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2269
2270         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
2271
2272         * wpe/manifest.txt.in: Distribute the NEWS.
2273
2274 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2275
2276         [WPE] Build cleanly with GCC 8 and ICU 60
2277         https://bugs.webkit.org/show_bug.cgi?id=185462
2278
2279         Reviewed by Carlos Alberto Lopez Perez.
2280
2281         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
2282         sure why this was never noticed until now or why the bots are OK.
2283         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2284         * gtk/patches/glib-cast-function-type.patch: Added.
2285         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2286         * wpe/patches/glib-cast-function-type.patch: Added.
2287
2288 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2289
2290         [JSC][GTK][JSCONLY] Use capstone disassembler
2291         https://bugs.webkit.org/show_bug.cgi?id=185283
2292
2293         Reviewed by Michael Catanzaro.
2294
2295         * gtk/manifest.txt.in:
2296         * wpe/manifest.txt.in:
2297
2298 2018-05-09  Antti Koivisto  <antti@apple.com>
2299
2300         Add OptionSet::operator& and operator bool
2301         https://bugs.webkit.org/show_bug.cgi?id=185306
2302
2303         Reviewed by Anders Carlsson.
2304
2305         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2306         (TestWebKitAPI::TEST):
2307
2308 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2309
2310         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
2311         https://bugs.webkit.org/show_bug.cgi?id=185340
2312
2313         Reviewed by Tim Horton.
2314
2315         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
2316         non-empty text in a contenteditable.
2317
2318         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2319         (TestWebKitAPI::TEST):
2320
2321 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2322
2323         test262/Runner.pm: create results dir for results of test262 run
2324         https://bugs.webkit.org/show_bug.cgi?id=185392
2325
2326         Reviewed by Michael Saboff.
2327
2328         New directory test262-results created from where ever script is
2329         called.
2330
2331         * Scripts/test262/Runner.pm:
2332         (processCLI):
2333
2334 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2335
2336         test262/Runner.pm: lower number of processes per core
2337         https://bugs.webkit.org/show_bug.cgi?id=185426
2338
2339         Reviewed by Michael Saboff.
2340
2341         * Scripts/test262/Runner.pm:
2342         (getProcesses):
2343
2344 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
2345
2346         Test262-Runner: Add base Perl UnicodeData
2347         https://bugs.webkit.org/show_bug.cgi?id=185444
2348
2349         Reviewed by Michael Saboff.
2350
2351         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
2352         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
2353
2354 2018-05-08  Daniel Bates  <dabates@apple.com>
2355
2356         Add tests to ensure that the Strong Password appearance is removed on form reset
2357         https://bugs.webkit.org/show_bug.cgi?id=185440
2358
2359         Reviewed by Ryosuke Niwa.
2360
2361         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
2362         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2363         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2364         (TEST):
2365
2366 2018-05-08  Daniel Bates  <dabates@apple.com>
2367
2368         Resign Strong Password appearance when text field value changes
2369         https://bugs.webkit.org/show_bug.cgi?id=185433
2370         <rdar://problem/39958508>
2371
2372         Reviewed by Ryosuke Niwa.
2373
2374         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2375         when the field has the Strong Password button and its value changes.
2376
2377         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2378         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2379         (TEST):
2380
2381 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2382
2383         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2384         https://bugs.webkit.org/show_bug.cgi?id=185365
2385
2386         Reviewed by Saam Barati.
2387         
2388         Make it possible to measure compile times.
2389         
2390         Rolling back in after fixing cloop builds.
2391
2392         * Scripts/run-jsc-benchmarks:
2393
2394 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2395
2396         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
2397         https://bugs.webkit.org/show_bug.cgi?id=185414
2398
2399         Reviewed by Tim Horton.
2400
2401         Adjust a test expectation to check that the resulting DOM contains an attachment element,
2402         anchor element, and another attachment element in that order. This ensures that the test
2403         still passes, even after the anchor element is followed by a line break.
2404
2405         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2406         (TestWebKitAPI::TEST):
2407
2408 2018-05-08  Commit Queue  <commit-queue@webkit.org>
2409
2410         Unreviewed, rolling out r231491.
2411         https://bugs.webkit.org/show_bug.cgi?id=185434
2412
2413         Setting the Created key on a cookie does not work yet, due a
2414         bug in CFNetwork (Requested by ggaren on #webkit).
2415
2416         Reverted changeset:
2417
2418         "[WKHTTPCookieStore getAllCookies] returns inconsistent
2419         creation time"
2420         https://bugs.webkit.org/show_bug.cgi?id=185041
2421         https://trac.webkit.org/changeset/231491
2422
2423 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2424
2425         test262/Runner.pm: move input files to JSTests/test262
2426         https://bugs.webkit.org/show_bug.cgi?id=185389
2427
2428         Reviewed by Michael Saboff.
2429
2430         * Scripts/test262/Runner.pm:
2431         (processCLI):
2432
2433 2018-05-08  Chris Dumez  <cdumez@apple.com>
2434
2435         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
2436
2437         * Scripts/webkitpy/performance_tests/perftest.py:
2438         (PerfTest):
2439
2440 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
2441
2442         Unreviewed, rolling out r231468.
2443
2444         Broke the CLoop build
2445
2446         Reverted changeset:
2447
2448         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
2449         any abstract values"
2450         https://bugs.webkit.org/show_bug.cgi?id=185365
2451         https://trac.webkit.org/changeset/231468
2452
2453 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
2454
2455         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
2456         https://bugs.webkit.org/show_bug.cgi?id=185041
2457         <rdar://problem/34684214>
2458
2459         Reviewed by Geoffrey Garen.
2460
2461         Add API test Coverage.
2462
2463         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2464         (TEST):
2465
2466 2018-05-08  Chris Dumez  <cdumez@apple.com>
2467
2468         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2469
2470         * Scripts/webkitpy/performance_tests/perftest.py:
2471         (PerfTest):
2472
2473 2018-05-08  Chris Dumez  <cdumez@apple.com>
2474
2475         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2476
2477         * Scripts/webkitpy/performance_tests/perftest.py:
2478         (PerfTest):
2479
2480 2018-05-07  Chris Dumez  <cdumez@apple.com>
2481
2482         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2483
2484         * Scripts/webkitpy/performance_tests/perftest.py:
2485         (PerfTest):
2486
2487 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2488
2489         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2490         https://bugs.webkit.org/show_bug.cgi?id=185365
2491
2492         Reviewed by Saam Barati.
2493         
2494         Make it possible to measure compile times.
2495
2496         * Scripts/run-jsc-benchmarks:
2497
2498 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
2499
2500         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
2501         https://bugs.webkit.org/show_bug.cgi?id=185390
2502
2503         Reviewed by Michael Saboff.
2504
2505         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
2506
2507 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
2508
2509         Check for com.apple.datamigrator before declaring simulators booted
2510         https://bugs.webkit.org/show_bug.cgi?id=185315
2511         <rdar://problem/39986261>
2512
2513         Reviewed by David Kilzer.
2514
2515         * Scripts/webkitdirs.pm:
2516         (waitUntilProcessNotRunning): Wait until a process is not found.
2517         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
2518         a simulator booted.
2519         * Scripts/webkitpy/common/system/executive_mock.py:
2520         (MockExecutive2.__init__): Define _running_pids.
2521         * Scripts/webkitpy/xcode/simulated_device.py:
2522         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
2523         declaring that devices have been booted, increase the timeout since data migration will frequently
2524         take longer than 60 seconds, especially with multiple simulators booting.
2525         (SimulatedDeviceManager.swap): Ditto.
2526         (SimulatedDeviceManager):
2527         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
2528         processes running.
2529
2530 2018-05-07  Daniel Bates  <dabates@apple.com>
2531
2532         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
2533         https://bugs.webkit.org/show_bug.cgi?id=185054
2534         <rdar://problem/39773209>
2535
2536         Reviewed by Ryosuke Niwa.
2537
2538         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
2539
2540         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
2541         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
2542         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
2543         tests for the port.
2544
2545         * Scripts/webkitpy/port/mac.py:
2546         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
2547         have Apple Additions.
2548         * Scripts/webkitpy/port/mac_unittest.py:
2549         (MacTest.test_factory_with_future_version): Added.
2550         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
2551         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
2552         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
2553         is absent.
2554
2555 2018-05-07  Brian Burg  <bburg@apple.com>
2556
2557         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2558         https://bugs.webkit.org/show_bug.cgi?id=184861
2559         <rdar://problem/39153768>
2560
2561         Reviewed by Timothy Hatcher.
2562
2563         Add a new test that checks whether a new process is used for navigation when
2564         an Inspector is shown. Also check that the behavior reverts to normal after
2565         the Inspector has been closed.
2566
2567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2568
2569 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2570
2571         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
2572         https://bugs.webkit.org/show_bug.cgi?id=185289
2573         <rdar://problem/35756912>
2574
2575         Reviewed by Tim Horton and Darin Adler.
2576
2577         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
2578         sessions.
2579
2580         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2581         (TestWebKitAPI::TEST):
2582
2583 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2584
2585         Deprecate legacy WebView and friends
2586         https://bugs.webkit.org/show_bug.cgi?id=185279
2587         rdar://problem/33268700
2588
2589         Reviewed by Tim Horton.
2590
2591         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
2592         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
2593
2594 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2595
2596         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
2597         https://bugs.webkit.org/show_bug.cgi?id=185314
2598
2599         Reviewed by Michael Saboff.
2600
2601         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
2602
2603 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
2604
2605         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
2606         https://bugs.webkit.org/show_bug.cgi?id=184196
2607         <rdar://problem/39054481>
2608
2609         Reviewed by Tim Horton.
2610
2611         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
2612         earlier than 11.3. Also re-enables these tests.
2613
2614         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2615         (TestWebKitAPI::TEST):
2616         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
2617         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
2618
2619 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
2620
2621         Text shaping in the simple path is flipped in the y direction
2622         https://bugs.webkit.org/show_bug.cgi?id=185062
2623         <rdar://problem/39778678>
2624
2625         Reviewed by Simon Fraser.
2626
2627         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
2628
2629         * Scripts/webkitpy/common/config/contributors.json:
2630
2631 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2632
2633         Test262-Runner: place the processCLI inside the main call
2634         https://bugs.webkit.org/show_bug.cgi?id=185304
2635
2636         Reviewed by Michael Saboff.
2637
2638         * Scripts/test262/Runner.pm:
2639         (main):
2640
2641 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2642
2643         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
2644         https://bugs.webkit.org/show_bug.cgi?id=174730
2645
2646         Reviewed by Michael Catanzaro.
2647
2648         Update unit tests to check that User-Agent header is included in HTTP download requests.
2649
2650         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2651         (testDownloadRemoteFile):
2652         (testWebViewDownloadURI):
2653         (testPolicyResponseDownload):
2654         (testPolicyResponseDownloadCancel):
2655         (testDownloadMIMEType):
2656         (testContextMenuDownloadActions):
2657
2658 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
2659
2660         [WinCairo] Test archive must use Python zipfile, just like build product.
2661         https://bugs.webkit.org/show_bug.cgi?id=185265
2662
2663         Reviewed by Per Arne Vollan.
2664
2665         * BuildSlaveSupport/test-result-archive:
2666         (archive_test_results):
2667         Copy over Win32-oriented archiving logic from built-product-archive.
2668
2669 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
2670
2671         cleanup modules usage for the Test262-Runner
2672         https://bugs.webkit.org/show_bug.cgi?id=185263
2673
2674         Reviewed by Michael Saboff.
2675
2676         * Scripts/test262-runner:
2677         * Scripts/test262/Runner.pm:
2678         (processCLI):
2679
2680 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2681
2682         test262/Runner.pm: minor fixes
2683         https://bugs.webkit.org/show_bug.cgi?id=185250
2684
2685         Reviewed by Michael Saboff.
2686
2687         Add comments, change output and fix bug: unintended interpolation
2688         of filename when running jsc.
2689
2690         * Scripts/test262/Runner.pm:
2691         (processCLI):
2692         (main):
2693         (runTest):
2694
2695 2018-05-03  Chris Dumez  <cdumez@apple.com>
2696
2697         Load hangs if the WebProcess fails to launch
2698         https://bugs.webkit.org/show_bug.cgi?id=185225
2699         <rdar://problem/38249058>
2700
2701         Reviewed by Geoff Garen.
2702
2703         Add API test coverage.
2704
2705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2706         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
2707         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
2708         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
2709         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2710         (TEST):
2711
2712 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
2713
2714         [WinCairo] Add JSC test bots
2715         https://bugs.webkit.org/show_bug.cgi?id=185234
2716
2717         Reviewed by Per Arne Vollan.
2718
2719         * BuildSlaveSupport/build.webkit.org-config/config.json:
2720         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2721         (RunJavaScriptCoreTests.start):
2722
2723 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2724
2725         WebKit should send fake macOS user agent to docs.google.com
2726         https://bugs.webkit.org/show_bug.cgi?id=185165
2727
2728         Reviewed by Carlos Garcia Campos.
2729
2730         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2731         (TestWebKitAPI::TEST):
2732
2733 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2734
2735         test262/Runner.pm: performance improvements
2736         https://bugs.webkit.org/show_bug.cgi?id=185202
2737
2738         Reviewed by Michael Saboff.
2739
2740         Batch the tests by the number of processes, and give each process
2741         a file to save results to to avoid threading. Do not parallelize
2742         when running small sets of tests.
2743
2744         * Scripts/test262/Runner.pm:
2745         (processCLI):
2746         (main):
2747         (processFile):
2748         (processResult):
2749
2750 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
2751
2752         Unreviewed, rolling out r231253.
2753
2754         The API test added with this change is crashing on the bots.
2755
2756         Reverted changeset:
2757
2758         "Web Inspector: opt out of process swap on navigation if a Web
2759         Inspector frontend is connected"
2760         https://bugs.webkit.org/show_bug.cgi?id=184861
2761         https://trac.webkit.org/changeset/231253
2762
2763 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2764
2765         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
2766         https://bugs.webkit.org/show_bug.cgi?id=183348
2767
2768         Reviewed by Michael Catanzaro.
2769
2770         Add a test case to reproduce the crash.
2771
2772         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2773         (testWebViewCloseQuickly):
2774         (beforeAll):
2775
2776 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
2777
2778         Can't copy and paste URLs that have no title into Mail (macOS)
2779         https://bugs.webkit.org/show_bug.cgi?id=185205
2780         <rdar://problem/36352406>
2781
2782         Reviewed by Tim Horton.
2783
2784         Added test to verify behavior when copying and pasting a URL without a title.
2785
2786         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2787         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2788         (TestWebKitAPI::TEST):
2789
2790 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2791
2792         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
2793         https://bugs.webkit.org/show_bug.cgi?id=184699
2794
2795         Unreviewed follow-up fix after r231230.
2796
2797         * Scripts/generate-jsc-bundle:
2798         (generate_wrapper_script): Quote the arguments passed to jsc.
2799
2800 2018-05-02  Brian Burg  <bburg@apple.com>
2801
2802         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2803         https://bugs.webkit.org/show_bug.cgi?id=184861
2804         <rdar://problem/39153768>
2805
2806         Reviewed by Ryosuke Niwa.
2807
2808         Add a new test that checks whether a new process is used for navigation when
2809         an Inspector is shown. Also check that the behavior reverts to normal after
2810         the Inspector has been closed.
2811
2812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2813
2814 2018-05-02  Valerie R Young  <valerie@bocoup.com>
2815
2816         test262/Runner.pm: save summary to file
2817         https://bugs.webkit.org/show_bug.cgi?id=185200
2818
2819         Reviewed by Michael Saboff.
2820
2821         * Scripts/test262/Runner.pm:
2822         (processCLI):
2823         (main):
2824         (summarizeResults):
2825
2826 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2827
2828         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
2829         https://bugs.webkit.org/show_bug.cgi?id=184699
2830
2831         Reviewed by Gustavo Noronha Silva.
2832
2833         This adds a new step for the GTK 64-bit release build bot and the
2834         GTK 32-bit release build&test bot.
2835
2836         This step will be run as one of the lasts ones (after the product
2837         is built) and will execute the script generate-jsc-bundle.
2838         This script will take care of creating a JSC bundle and uploading
2839         it to a server defined on a configuration file that has to be
2840         deployed on the bots with the required server data and credentials
2841         for this upload.
2842
2843         In this case, the built products should then be accessible at
2844         <https://webkitgtk.org/jsc-built-products>. But the implementation
2845         is not tied to any specific server. All the details about where
2846         to upload the file is done in configuration file that is kept
2847         private on each bot outside of the WebKit source tree.
2848
2849         The script also supports generating a JSC bundle locally and not
2850         uploading it anywhere. This is the default mode of running.
2851         The remote upload will only be activated if a --remote-config-file
2852         parameter is passed (which is done from the buildbot config)
2853
2854         * BuildSlaveSupport/build.webkit.org-config/config.json:
2855         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2856         (BuildFactory):
2857         (BuildFactory.__init__):
2858         (TestFactory):
2859         (TestFactory.__init__):
2860         (BuildAndGenerateJSCBundleFactory):
2861         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
2862         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2863         (GenerateJSCBundle):
2864         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2865         * Scripts/generate-jsc-bundle: Added.
2866         (ldd_get_libs_and_interpreter):
2867         (generate_readme):
2868         (generate_wrapper_script):
2869         (copy_and_remove_rpath):
2870         (createJSCBundle):
2871         (sha256sum):
2872         (uploadJSCBundle):
2873         (main):
2874
2875 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
2876
2877         PSON: Make WebKitTestRunner work with process swap on navigation turned on
2878         https://bugs.webkit.org/show_bug.cgi?id=185111
2879
2880         Reviewed by Chris Dumez.
2881
2882         Add the basic support for running layout tests with process-swap-on-navigation turned on.
2883
2884         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
2885         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
2886
2887         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
2888         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
2889         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
2890         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
2891
2892         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2893         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
2894         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
2895         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
2896         beginTesting with BegingTestingMode::Resume when this boolean is set.
2897         (WTR::InjectedBundle::didReceiveMessageToPage):
2898         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
2899         bundle after a process swap on navigation.
2900         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2901         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2902         (WTR::InjectedBundlePage::dump):
2903         (WTR::InjectedBundlePage::frameDidChangeLocation):
2904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2905         (WTR::TestRunner::TestRunner):
2906         (WTR::TestRunner::shouldDumpPixels const): Added.
2907         (WTR::TestRunner::setDumpPixels): Added.
2908         (WTR::TestRunner::dumpAsText):
2909         (WTR::TestRunner::whatToDump const): Added.
2910         (WTR::TestRunner::setWhatToDump): Added.
2911         (WTR::TestRunner::waitUntilDone):
2912         (WTR::TestRunner::setWaitUntilDone): Added.
2913         (WTR::TestRunner::shouldWaitUntilDone): Added.
2914         (WTR::TestRunner::notifyDone):
2915         (WTR::TestRunner::forceImmediateCompletion):
2916         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
2917         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
2918         (WTR::TestRunner::setAudioResult):
2919         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2920         (WTR::TestRunner::dumpChildFramesAsText):
2921         (WTR::TestRunner::dumpDOMAsWebArchive):
2922         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
2923         (WTR::TestRunner::whatToDump const): Moved to cpp.
2924         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
2925         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
2926         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
2927         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
2928         * WebKitTestRunner/TestInvocation.cpp:
2929         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
2930         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
2931         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
2932         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
2933         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
2934         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
2935         started as a result of a process swap on navigation (m_startedTesting is true).
2936         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
2937         support initializing the injected bundle in a process swapped after navigation and set/get messages for
2938         the states which must persist across process swaps within a test.
2939         * WebKitTestRunner/TestInvocation.h:
2940         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2941         * Tools/WebKitTestRunner/WhatToDump.h:
2942         (WTR::WhatToDump): Added.
2943
2944 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
2945
2946         Auto save the results for Test262
2947         https://bugs.webkit.org/show_bug.cgi?id=184926
2948
2949         Reviewed by Michael Saboff.
2950
2951         * Scripts/test262/Runner.pm:
2952         (processCLI):
2953         (main):
2954         (parseError):
2955         (processResult):
2956         (summarizeResults):
2957         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
2958
2959 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
2960
2961         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
2962         https://bugs.webkit.org/show_bug.cgi?id=185164
2963
2964         Reviewed by David Kilzer.
2965
2966         * Scripts/webkitpy/common/system/executive.py:
2967         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
2968         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
2969
2970 2018-05-01  Chris Dumez  <cdumez@apple.com>
2971
2972         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
2973         https://bugs.webkit.org/show_bug.cgi?id=184918
2974         <rdar://problem/39705516>
2975
2976         Reviewed by Wenson Hsieh.
2977
2978         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
2979         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
2980         asynchronously because we ask the client if it is OK to do the load and the policy
2981         delegates are asynchronous nowadays.
2982
2983         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2984         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
2985         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2986         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2987         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
2988         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
2989         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
2990
2991 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
2992
2993         [WinCairo] Align buildbot test stages with AppleWin.
2994         https://bugs.webkit.org/show_bug.cgi?id=185094
2995
2996         Reviewed by Brent Fulgham.
2997
2998         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2999         (TestFactory.__init__):
3000         Do run API tests, don't run dashboard tests.
3001
3002         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3003         (RunUnitTests):
3004         Call run-api-tests with Python, not Perl (bugfix for r230998).
3005
3006         * Scripts/webkitpy/port/win.py:
3007         (WinPort.environment_for_api_tests):
3008         Retrieve necessary Windows environment variables.
3009
3010 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3011
3012         [MediaStream] remove WK1 support
3013         https://bugs.webkit.org/show_bug.cgi?id=185136
3014
3015         Reviewed by Youenn Fablet.
3016
3017         * DumpRenderTree/mac/UIDelegate.mm:
3018         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
3019
3020 2018-05-01  Chris Dumez  <cdumez@apple.com>
3021
3022         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
3023         https://bugs.webkit.org/show_bug.cgi?id=185157
3024
3025         Reviewed by Geoffrey Garen.
3026
3027         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
3028         common configuration and should therefore be the configuration we test by default.
3029
3030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3031         (WTR::InjectedBundlePage::decidePolicyForResponse):
3032
3033 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3034
3035         WebAssembly: add support for stream APIs - JavaScript API
3036         https://bugs.webkit.org/show_bug.cgi?id=183442
3037
3038         Reviewed by Yusuke Suzuki and JF Bastien.
3039
3040         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3041
3042 2018-04-30  Mark Lam  <mark.lam@apple.com>
3043
3044         Apply PtrTags to the MetaAllocator and friends.
3045         https://bugs.webkit.org/show_bug.cgi?id=185110
3046         <rdar://problem/39533895>
3047
3048         Reviewed by Saam Barati.
3049
3050         Update the test to match MetaAllocator changes in WTF.
3051
3052         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3053         (TestWebKitAPI::TEST_F):
3054         (WTF::tagForPtr):
3055         (WTF::ptrTagName):
3056
3057 2018-04-30  Alex Christensen  <achristensen@webkit.org>
3058
3059         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
3060         https://bugs.webkit.org/show_bug.cgi?id=180955
3061
3062         Reviewed by Andy Estes.
3063
3064         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
3065         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
3066         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
3067
3068 2018-04-30  JF Bastien  <jfbastien@apple.com>
3069
3070         Use some C++17 features
3071         https://bugs.webkit.org/show_bug.cgi?id=185135
3072
3073         Reviewed by Alex Christensen.
3074
3075         * DumpRenderTree/PlatformMac.cmake:
3076         * gtk/ycm_extra_conf.py:
3077         (FlagsForFile):
3078
3079 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3080
3081         Use WordLock instead of std::mutex for Threading
3082         https://bugs.webkit.org/show_bug.cgi?id=185121
3083
3084         Reviewed by Geoffrey Garen.
3085
3086         * TestWebKitAPI/Tests/WTF/Signals.cpp:
3087         (TEST):
3088
3089 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3090
3091         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
3092         https://bugs.webkit.org/show_bug.cgi?id=185103
3093
3094         Reviewed by Carlos Garcia Campos.
3095
3096         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3097         (TestWebKitAPI::TEST):
3098
3099 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
3100
3101         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
3102         https://bugs.webkit.org/show_bug.cgi?id=185052
3103
3104         Reviewed by Geoffrey Garen.
3105
3106         Modified API test to provide correct test cases for HTTPOnly flag.
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3109         (TEST):
3110
3111 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
3112
3113         Token misspelled "tocken" in error message string
3114         https://bugs.webkit.org/show_bug.cgi?id=185030
3115
3116         Reviewed by Saam Barati.
3117
3118         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
3119
3120 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
3121
3122         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
3123         https://bugs.webkit.org/show_bug.cgi?id=185049
3124
3125         Reviewed by Keith Miller.
3126
3127         * Scripts/run-javascriptcore-tests:
3128         (runJSCStressTests):
3129         * Scripts/run-jsc-stress-tests:
3130
3131 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3132
3133         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
3134         https://bugs.webkit.org/show_bug.cgi?id=185066
3135
3136         Reviewed by Youenn Fablet.
3137
3138         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
3139         WebKit should not swap WebContent process in this case.
3140
3141         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3142         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3143         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3144
3145 2018-04-27  Nan Wang  <n_wang@apple.com>
3146
3147         AX: Accessibility needs to know which part of the content view is visible on iOS
3148         https://bugs.webkit.org/show_bug.cgi?id=185085
3149         <rdar://problem/39801363>
3150
3151         Reviewed by Chris Fleizach.
3152
3153         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3154         (WTR::AccessibilityUIElement::stringAttributeValue):
3155
3156 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3157
3158         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
3159         https://bugs.webkit.org/show_bug.cgi?id=185050
3160         <rdar://problem/39624038>
3161
3162         Reviewed by Tim Horton.
3163
3164         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
3165         tested by the layout test added in this patch.
3166
3167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3168         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
3169
3170 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
3171
3172         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
3173         https://bugs.webkit.org/show_bug.cgi?id=185061
3174
3175         Reviewed by Aakash Jain.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3178         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
3179         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
3180
3181 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3182
3183         Add release bots for WinCairo.
3184         https://bugs.webkit.org/show_bug.cgi?id=185042
3185
3186         Reviewed by Lucas Forschler.
3187
3188         * BuildSlaveSupport/build.webkit.org-config/config.json:
3189         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
3190
3191 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
3192
3193         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
3194         https://bugs.webkit.org/show_bug.cgi?id=184938
3195         <rdar://problem/34737395>
3196
3197         Reviewed by Geoffrey Garen.
3198
3199         Add API test coverage.
3200
3201         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3202         (TEST):
3203
3204 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3205
3206         WinCairo test bots should run JSC tests with options for Windows command prompt.
3207         https://bugs.webkit.org/show_bug.cgi?id=185019
3208
3209         Reviewed by Per Arne Vollan.
3210
3211         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3212         (RunJavaScriptCoreTests.start):
3213
3214 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3215
3216         WinCairo WKL Debug Test bot is not using DRT.
3217         https://bugs.webkit.org/show_bug.cgi?id=185009
3218
3219         Reviewed by Per Arne Vollan.
3220
3221         * BuildSlaveSupport/build.webkit.org-config/config.json:
3222
3223 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3224
3225         Disable content filtering in minimal simulator mode
3226         https://bugs.webkit.org/show_bug.cgi?id=185027
3227         <rdar://problem/39736091>
3228
3229         Reviewed by Jer Noble.
3230
3231         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3232
3233 2018-04-26  Brady Eidson  <beidson@apple.com>
3234
3235         Add a setting for keeping around all processes and always reusing them per-origin.
3236         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
3237
3238         Reviewed by Andy Estes.
3239
3240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3241
3242 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3243
3244         [INTL] Implement Intl.PluralRules
3245         https://bugs.webkit.org/show_bug.cgi?id=184312
3246
3247         Reviewed by JF Bastien.
3248
3249         Added Intl.PluralRules feature flag.
3250
3251         * Scripts/webkitperl/FeatureList.pm:
3252         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3253
3254 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3255
3256         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
3257         https://bugs.webkit.org/show_bug.cgi?id=184643
3258
3259         Reviewed by Žan Doberšek.
3260
3261         Add missing INCLUDE_DIRS in many places.
3262
3263         Adapt to single-header WPE includes.
3264
3265         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
3266
3267         * TestWebKitAPI/PlatformWPE.cmake:
3268         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3269         (testWebViewWebBackend):
3270         * TestWebKitAPI/glib/PlatformWPE.cmake:
3271         * WebKitTestRunner/EventSenderProxy.h:
3272         * WebKitTestRunner/PlatformWPE.cmake:
3273         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3274         * wpe/HeadlessViewBackend/CMakeLists.txt:
3275         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3276         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3277         * wpe/jhbuild.modules:
3278
3279 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
3280
3281         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
3282         https://bugs.webkit.org/show_bug.cgi?id=184982
3283
3284         Rubber-stamped by Aakash Jain.
3285
3286         Correctly count the number of API test failures.
3287
3288         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3289         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
3290         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3291         * Scripts/webkitpy/api_tests/manager.py:
3292         (Manager.run): Disabled tests are not run.
3293
3294 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3295
3296         Remove access to keychain from the WebContent process
3297         https://bugs.webkit.org/show_bug.cgi?id=184428
3298         <rdar://problem/13150903>
3299
3300         Reviewed by Brent Fulgham.
3301
3302         This patch does the followings:
3303         1. Added an API test for this patch.
3304         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
3305
3306         * DumpRenderTree/mac/UIDelegate.mm:
3307         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
3308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3309         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
3310         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
3311         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
3312         (TestWebKitAPI::TEST_F):
3313         * WebKitTestRunner/TestController.cpp:
3314         (WTR::copySignedPublicKeyAndChallengeString):
3315         (WTR::TestController::createOtherPage):
3316         (WTR::TestController::createWebViewWithOptions):
3317
3318 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3319
3320         [Extra zoom mode] The search field on www.bing.com is missing label text
3321         https://bugs.webkit.org/show_bug.cgi?id=184975
3322         <rdar://problem/39723081>
3323
3324         Reviewed by Tim Horton.
3325
3326         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
3327         focused element in extra zoom mode.
3328
3329         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3330         (WTR::UIScriptController::formInputLabel const):
3331         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3332         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3333         (WTR::UIScriptController::formInputLabel const):
3334         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3335         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3336         (WTR::UIScriptController::formInputLabel const):
3337
3338 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3339
3340         [WPE] Should load injected bundle from builddir in developer builds
3341         https://bugs.webkit.org/show_bug.cgi?id=184983
3342
3343         Reviewed by Carlos Alberto Lopez Perez.
3344
3345         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
3346
3347         * Scripts/run-minibrowser:
3348
3349 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3350
3351         [WPE] libgstggtk.so broken in jhbuild environment
3352         https://bugs.webkit.org/show_bug.cgi?id=184984
3353
3354         Reviewed by Carlos Alberto Lopez Perez.
3355
3356         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
3357         gst-plugins-good.
3358
3359         * wpe/jhbuild.modules:
3360
3361 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3362
3363         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
3364         https://bugs.webkit.org/show_bug.cgi?id=184962
3365
3366         Reviewed by Youenn Fablet.
3367
3368         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
3369
3370         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3371         (ProcessSwap.SameOriginBlobNavigation): Added.
3372         (ProcessSwap.CrossOriginBlobNavigation): Added.
3373         (ProcessSwap.NavigateToAboutBlank): Added.
3374         (ProcessSwap.NavigateToDataURL): Added.
3375
3376 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3377
3378         [WPE] Remove deprecated functions and properties from the API
3379         https://bugs.webkit.org/show_bug.cgi?id=179295
3380
3381         Reviewed by Žan Doberšek.
3382
3383         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3384         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
3385         to rewrite LoadTrackingTest to not require the web view at construction time.
3386         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3387         (testWebKitSettings): Don't test private browsing setting, which is gone.
3388         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
3389
3390 2018-04-25  Andy Estes  <aestes@apple.com>
3391
3392         [Mac] Number of drop items is always 0 when performing a DHTML drag
3393         https://bugs.webkit.org/show_bug.cgi?id=184943
3394
3395         Reviewed by Ryosuke Niwa.
3396
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3399         (-[DragInfo numberOfValidItemsForDrop]):
3400         (-[DragInfo setNumberOfValidItemsForDrop:]):
3401         (TestWebKitAPI::TEST):
3402         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
3403
3404 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
3405
3406         API test harness should be Python
3407         https://bugs.webkit.org/show_bug.cgi?id=181043
3408         <rdar://problem/36164410>
3409
3410         Reviewed by David Kilzer.
3411
3412         Run API tests from a Python script rather than Perl. The Python API tests have
3413         the same structure as the layout tests.
3414
3415         * Scripts/run-api-tests: Changed from Perl to Python.
3416         * Scripts/webkitpy/api_tests: Added.
3417         * Scripts/webkitpy/api_tests/__init__.py: Added.
3418         * Scripts/webkitpy/api_tests/manager.py: Added.
3419         (Manager):
3420         (Manager.__init__):
3421         (Manager._test_list_from_output): Construct a list of tests from the output of
3422         TestWTF and TestWebKitAPI.
3423         (Manager._find_test_subset): Given a list of all possible tests and command line
3424         arguments, return a list of tests which match the provided arguments.
3425         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
3426         to determine which tests will be run.
3427         (Manager._print_test_result): Formatted print of a test with it's output.
3428         (Manager._print_tests_result_with_status): Print all tests and output for tests
3429         which ran with a specified exit status.
3430         (Manager.run): Collect all tests, run them and then print results from the run.
3431         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
3432         (main): Parse arguments, construct a port, early exit for illegal ports and
3433         then run tests.
3434         (run): Setup logging and printing before using the Manager to run tests.
3435         (parse_args): Use argparse to define all options used by run-api-tests.
3436         * Scripts/webkitpy/api_tests/runner.py: Added.
3437         (Runner):
3438         (Runner.__init__):
3439         (Runner._shard_tests): Split tests so that each suite runs together.
3440         (Runner.command_for_port): Run a command on the device specified by the given
3441         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
3442         this function would be entirely replaced by the server_process factory owned
3443         by the port object.
3444         (Runner.run): Run all shards in the message_pool.
3445         (Runner.handle): Handle reports from child processes.
3446         (Runner.result_map_by_status): Return a mapping of tests to output for tests
3447         which exit with a specific status.
3448         (_Worker):
3449         (_Worker.__init__):
3450         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
3451         (_Worker._run_single_test): Runs a single test in a single child process.
3452         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
3453         child process. If this technique fails, the remaining tests are run singly.
3454         (_Worker.handle): Run the specified shard.
3455         * Scripts/webkitpy/port/base.py:
3456         (Port):
3457         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
3458         (Port.environment_for_api_tests): Return the environment needed to run
3459         the TestWebKitAPI binary.
3460         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
3461         used when running API tests.
3462         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
3463         * Scripts/webkitpy/port/mac.py:
3464         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
3465         * Scripts/webkitpy/port/server_process.py: 
3466         (ServerProcess.pop_all_buffered_stdout):
3467
3468 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3469
3470         Incorrect number of WebDriver test failures shown in the bots
3471         https://bugs.webkit.org/show_bug.cgi?id=184959
3472
3473         Reviewed by Michael Catanzaro.
3474
3475         The regular expression we are using to get the number of failures from the log is matching a particular test
3476         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
3477         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
3478
3479         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3480         (RunWebDriverTests.commandComplete):
3481
3482 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3483
3484         [GTK] Implement MouseEvent.buttons
3485         https://bugs.webkit.org/show_bug.cgi?id=184913
3486
3487         Reviewed by Žan Doberšek.
3488
3489         Include the mouse buttons state in WTR synthesized events.
3490
3491         * WebKitTestRunner/EventSenderProxy.h:
3492         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3493         (WTR::EventSenderProxy::EventSenderProxy):
3494         (WTR::EventSenderProxy::createMouseButtonEvent):
3495         (WTR::EventSenderProxy::mouseDown):
3496         (WTR::EventSenderProxy::mouseUp):
3497         (WTR::EventSenderProxy::mouseMoveTo):
3498
3499 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
3500
3501         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
3502         https://bugs.webkit.org/show_bug.cgi?id=184954
3503
3504         Reviewed by Michael Catanzaro.
3505
3506         * BuildSlaveSupport/build.webkit.org-config/config.json:
3507
3508 2018-04-24  Saam Barati  <sbarati@apple.com>
3509
3510         Keep around a pre-warmed process when doing process swap on navigation
3511         https://bugs.webkit.org/show_bug.cgi?id=184765
3512         <rdar://problem/39685099>
3513
3514         Reviewed by Ryosuke Niwa and Brady Eidson.
3515
3516         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3517
3518 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
3519
3520         [build.webkit.org] unit-tests fail when passwords.json is missing
3521         https://bugs.webkit.org/show_bug.cgi?id=180390
3522
3523         Reviewed by Carlos Alberto Lopez Perez.
3524
3525         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3526         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
3527         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3528         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
3529         (BuildBotConfigLoader._mock_open): Deleted.
3530         (BuildBotConfigLoader.load_config): Deleted.
3531
3532 2018-04-24  John Wilander  <wilander@apple.com>
3533
3534         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
3535         https://bugs.webkit.org/show_bug.cgi?id=184560
3536         <rdar://problem/38901344>
3537
3538         Reviewed by Youenn Fablet and Daniel Bates.
3539
3540         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
3541         We consume the From-Origin response header and only load the resource if:
3542         - The header is non-existent, empty, or invalid.
3543         - The header specifies 'same' and the resource's origin matches the originating
3544           document's origin and the origins up the frame tree.
3545         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
3546           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
3547
3548         This feature is experimental and off by default.
3549
3550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3551         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
3552         (TestWebKitAPI::TEST):
3553             Tests for From-Origin header parsing.
3554
3555 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3556
3557         Unreviewed. Update W3C WebDriver imported tests.
3558
3559         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3560         (WebDriverW3CExecutor.__init__):
3561
3562 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
3563
3564         [WPE] Remove libgbm dependency
3565         https://bugs.webkit.org/show_bug.cgi?id=184906
3566
3567         Reviewed by Carlos Garcia Campos.
3568
3569         Stop searching for libgbm, using its compiler flags for the
3570         HeadlessViewBackend compilation and linking against the .so object.
3571         This is not necessary anymore after r230562 switched to a different
3572         backend implementation for testing.
3573
3574         * wpe/HeadlessViewBackend/CMakeLists.txt:
3575         * wpe/install-dependencies:
3576
3577 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3578
3579         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
3580         https://bugs.webkit.org/show_bug.cgi?id=184816
3581
3582         Reviewed by Michael Catanzaro.
3583
3584         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
3585         timeout.
3586
3587         * TestWebKitAPI/glib/TestExpectations.json:
3588         * glib/api_test_runner.py:
3589         (TestRunner._run_test_glib.is_slow_test):
3590         (TestRunner._run_test_glib):
3591         * glib/glib_test_runner.py:
3592         (GLibTestRunner.__init__):
3593         (GLibTestRunner._stop_timeout):
3594         (GLibTestRunner._subtest_start):
3595         (GLibTestRunner._subtest_end):
3596
3597 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3598
3599         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
3600         https://bugs.webkit.org/show_bug.cgi?id=184901
3601         <rdar://problem/39664797>
3602
3603         Reviewed by Tim Horton.
3604
3605         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
3606         interacting with the UI. See WebKit ChangeLogs for more detail.
3607
3608         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3609         (WTR::UIScriptController::setTimePickerValue):
3610         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3611         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3612         (WTR::UIScriptController::setTimePickerValue):
3613         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3614         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3615         (WTR::UIScriptController::setTimePickerValue):
3616
3617 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3618
3619         [LayoutFormattingContext] Initial commit.
3620         https://bugs.webkit.org/show_bug.cgi?id=184896
3621
3622         Reviewed by Antti Koivisto.
3623
3624         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3625
3626 2018-04-23  Chris Dumez  <cdumez@apple.com>
3627
3628         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
3629         https://bugs.webkit.org/show_bug.cgi?id=184801
3630
3631         Reviewed by Geoffrey Garen.
3632
3633         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
3634         This is a more common configuration and therefore should be the default testing configuration.
3635
3636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3637         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3638         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
3639         is now asked for the policy decision.
3640
3641 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
3642
3643         [GTK][WPE] Add Debug bots (build and tests) for WPE
3644         https://bugs.webkit.org/show_bug.cgi?id=184887
3645
3646         Reviewed by Carlos Alberto Lopez Perez.
3647
3648         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
3649         wpe-linux-bot-4
3650
3651         Both bots have already the credentials ready to authenticated against
3652         build.webkit.org. They provides the bots for the "debug" configuration over
3653         the "WPE" platform and building for the "x86_64" architecture:
3654         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
3655
3656         * BuildSlaveSupport/build.webkit.org-config/config.json:
3657         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3658
3659 2018-04-23  Chris Dumez  <cdumez@apple.com>
3660
3661         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
3662         https://bugs.webkit.org/show_bug.cgi?id=184848
3663         <rdar://problem/39145306>
3664
3665         Reviewed by Brady Eidson.
3666
3667         Add API test coverage.
3668
3669         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3670         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3671         (TEST):
3672
3673 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
3674
3675         [GTK][WPE] TestSSL fails due to additional TLS errors returned
3676         https://bugs.webkit.org/show_bug.cgi?id=184860
3677
3678         Reviewed by Carlos Garcia Campos.
3679
3680         Add script and config file for regenerating the test certificate.
3681         Regenerate it. TestSSL no longer fails on my machine.
3682
3683         I do see a ton of network process crashes and JavaScript errors, none of
3684         which prevent the test from passing, but this commit only claims to fix
3685         the certificate validation portion of the test.
3686
3687         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
3688         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
3689         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
3690
3691 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3692
3693         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
3694         https://bugs.webkit.org/show_bug.cgi?id=184815
3695
3696         Reviewed by Michael Catanzaro.
3697
3698         This is because in the test we are calling both join and detach. We should only call join.
3699
3700         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3701         (testsJSCVirtualMachine):
3702
3703 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3704
3705         [GLIB] Test /jsc/prototypes crashes in debug
3706         https://bugs.webkit.org/show_bug.cgi?id=184814
3707
3708         Reviewed by Michael Catanzaro.
3709
3710         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
3711
3712         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3713         (barCreate):
3714         (barFree):
3715
3716 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3717
3718         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
3719         https://bugs.webkit.org/show_bug.cgi?id=184804
3720
3721         Reviewed by Carlos Garcia Campos.
3722
3723         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3724         (WebSocketTest::WebSocketTest):
3725         (WebSocketTest::~WebSocketTest):
3726         (WebSocketTest::serverWebSocketCallback):
3727         (WebSocketTest::webSocketTestResultCallback):
3728         (WebSocketTest::connectToServerAndWaitForEvents):
3729         (testWebSocketTLSErrors):
3730         (beforeAll):
3731
3732 2018-04-20  Chris Dumez  <cdumez@apple.com>
3733
3734         Unreviewed, update 2 more API tests after r230876.
3735
3736         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3737         (TEST):
3738         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
3739         (TestWebKitAPI::TEST):
3740
3741 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3742
3743         Adjust geolocation feature flag
3744         https://bugs.webkit.org/show_bug.cgi?id=184856
3745
3746         Reviewed by Wenson Hsieh.
3747
3748         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3749
3750 2018-04-20  Chris Dumez  <cdumez@apple.com>
3751
3752         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
3753         https://bugs.webkit.org/show_bug.cgi?id=184210
3754         <rdar://problem/39072354>
3755
3756         Reviewed by Wenson Hsieh.
3757
3758         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
3759         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
3760         Add viewport meta tags.
3761
3762         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3763         (-[WKWebView _test_waitForDidFinishNavigation]):
3764         Update _test_waitForDidFinishNavigation to wait for the next presentation update
3765         to make iOS API tests happy without having to modify each of them.
3766
3767 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3768
3769         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
3770
3771         https://bugs.webkit.org/show_bug.cgi?id=184849
3772         rdar://problem/39386405
3773
3774         Reviewed by Brian Burg.
3775
3776         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
3777         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
3778         CGColor pointer from NSColor each time.
3779
3780 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3781
3782         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
3783         https://bugs.webkit.org/show_bug.cgi?id=184822
3784         <rdar://problem/38807319>
3785
3786         Reviewed by Tim Horton.
3787
3788         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
3789         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
3790         SPI. See other ChangeLogs for more detail.
3791
3792         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3793         (WTR::UIScriptController::enterText):
3794         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3795
3796         Add UIScriptController support for simulating text entry in the currently focused element.
3797
3798         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3799         (WTR::UIScriptController::enterText):
3800         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3802
3803         Add TestRunner bindings for registering injected bundle form client callbacks.
3804
3805         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3806         (WTR::handleTextDidChangeInTextField):
3807         (WTR::handleTextFieldDidBeginEditing):
3808         (WTR::handleTextFieldDidEndEditing):
3809         (WTR::InjectedBundle::didCreatePage):
3810
3811         Set the injected bundle form editor client.
3812
3813         (WTR::InjectedBundle::setUpInjectedBundleClients):
3814         (WTR::InjectedBundle::textDidChangeInTextField):
3815         (WTR::InjectedBundle::textFieldDidBeginEditing):
3816         (WTR::InjectedBundle::textFieldDidEndEditing):
3817         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3818         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3819         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
3820         (WTR::TestRunner::textDidChangeInTextFieldCallback):
3821         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
3822         (WTR::TestRunner::textFieldDidBeginEditingCallback):
3823         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
3824         (WTR::TestRunner::textFieldDidEndEditingCallback):
3825         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3826         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3827         (WTR::UIScriptController::enterText):
3828
3829 2018-04-20  Youenn Fablet  <youenn@apple.com>
3830
3831         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
3832         https://bugs.webkit.org/show_bug.cgi?id=184369
3833
3834         Reviewed by Chris Dumez.
3835
3836         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3837         (TEST):
3838
3839 2018-04-20  Daniel Bates  <dabates@apple.com>
3840
3841         Remove Strong Password decoration when text field type changes
3842         https://bugs.webkit.org/show_bug.cgi?id=184795
3843         <rdar://problem/38325108>
3844
3845         Reviewed by Antti Koivisto.
3846
3847         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
3848         when the field has the Strong Password button and its type changes.
3849
3850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3851         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
3852         (didResignInputElementStrongPasswordAppearance):
3853         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
3854         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3855         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
3856         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3857         (TEST):
3858
3859 2018-04-20  Brady Eidson  <beidson@apple.com>
3860
3861         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
3862         https://bugs.webkit.org/show_bug.cgi?id=184807
3863
3864         Reviewed by Chris Dumez.
3865
3866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3867         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
3868
3869 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3870
3871         Unreviewed. Mark TestJSC as slow in debug.
3872
3873         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
3874
3875         * TestWebKitAPI/glib/TestExpectations.json:
3876
3877 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3878
3879         [GTK] Local cross references are broken in API documentation
3880         https://bugs.webkit.org/show_bug.cgi?id=184771
3881
3882         Reviewed by Michael Catanzaro.
3883
3884         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
3885         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
3886         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
3887         the cases.
3888
3889         * gtk/gtkdoc.py:
3890         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
3891         anything here.
3892         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
3893         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
3894         which gtkdoc-fixxref always uses absolute paths.
3895         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
3896
3897 2018-04-19  Brady Eidson  <beidson@apple.com>
3898
3899         Make back forward cache work with process swapping.
3900         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
3901
3902         Reviewed by Chris Dumez.
3903
3904         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3905
3906 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3907
3908         Enable Objective-C weak references
3909         <https://webkit.org/b/184789>
3910         <rdar://problem/39571716>
3911
3912         Reviewed by Dan Bernstein.
3913
3914         * ContentExtensionTester/Configurations/Base.xcconfig:
3915         (CLANG_ENABLE_OBJC_WEAK): Enable.
3916         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3917         (CLANG_ENABLE_OBJC_WEAK): Enable.
3918         * ImageDiff/cg/Configurations/Base.xcconfig:
3919         (CLANG_ENABLE_OBJC_WEAK): Enable.
3920         * MiniBrowser/Configurations/Base.xcconfig:
3921         (CLANG_ENABLE_OBJC_WEAK): Enable.
3922         * TestWebKitAPI/Configurations/Base.xcconfig:
3923         (CLANG_ENABLE_OBJC_WEAK): Enable.
3924         * WebEditingTester/Configurations/Base.xcconfig:
3925         (CLANG_ENABLE_OBJC_ARC): Re-order.
3926         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
3927         end of file.
3928         (CLANG_ENABLE_OBJC_WEAK): Enable.
3929         * WebKitTestRunner/Configurations/Base.xcconfig:
3930         (CLANG_ENABLE_OBJC_WEAK): Enable.
3931
3932 2018-04-19  Chris Dumez  <cdumez@apple.com>
3933
3934         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
3935         https://bugs.webkit.org/show_bug.cgi?id=184209
3936         <rdar://problem/39145306>
3937
3938         Reviewed by Ryosuke Niwa.
3939
3940         Add API test coverage.
3941
3942         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3943         (TEST):
3944
3945 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3946
3947         [WinCairo][EWS] Build bot should clean user temp directory each time.
3948         https://bugs.webkit.org/show_bug.cgi?id=184761
3949
3950         Reviewed by Lucas Forschler.
3951
3952         * EWSTools/Start-Queue.ps1:
3953         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
3954
3955 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3956
3957         Buildbots using Python zipfile should enable compression
3958         https://bugs.webkit.org/show_bug.cgi?id=184759
3959
3960         Reviewed by Lucas Forschler.
3961
3962         * BuildSlaveSupport/built-product-archive:
3963         (createZipManually):
3964         Default is to archive without compressing, so tell it to compress as well. 
3965
3966 2018-04-18  Nan Wang  <n_wang@apple.com>
3967
3968         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
3969         https://bugs.webkit.org/show_bug.cgi?id=184742
3970
3971         Reviewed by Chris Fleizach.
3972
3973         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3974         (AccessibilityUIElement::increment):
3975         (AccessibilityUIElement::decrement):
3976         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3977         (WTR::AccessibilityUIElement::asyncIncrement):
3978         (WTR::AccessibilityUIElement::asyncDecrement):
3979         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3980         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3981         (WTR::AccessibilityUIElement::increment):
3982         (WTR::AccessibilityUIElement::decrement):
3983         (WTR::AccessibilityUIElement::asyncIncrement):
3984         (WTR::AccessibilityUIElement::asyncDecrement):
3985
3986 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3987
3988         Fix archive step for WinCairo build bot.
3989         https://bugs.webkit.org/show_bug.cgi?id=184715
3990
3991         Reviewed by Lucas Forschler.
3992
3993         * BuildSlaveSupport/built-product-archive:
3994         (archiveBuiltProduct):
3995         (extractBuiltProduct):
3996
3997 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
3998
3999         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
4000         https://bugs.webkit.org/show_bug.cgi?id=184570
4001         <rdar://problem/34807323>
4002
4003         Reviewed by Chris Dumez.
4004
4005         Add API test coverage.
4006
4007         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
4008         (TEST):
4009
4010 2018-04-18  Chris Dumez  <cdumez@apple.com>
4011
4012         Add support for converting a local window to a remote window
4013         https://bugs.webkit.org/show_bug.cgi?id=184515
4014         <rdar://problem/39011318>
4015
4016         Reviewed by Ryosuke Niwa.
4017
4018         * MiniBrowser/mac/AppDelegate.m:
4019         (defaultConfiguration):
4020         * MiniBrowser/mac/SettingsController.h:
4021         * MiniBrowser/mac/SettingsController.m:
4022         (-[SettingsController _populateMenu]):
4023         (-[SettingsController validateMenuItem:]):
4024         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
4025         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
4026         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
4027
4028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4029         Turn on process swap on cross-origin window.open() for corresponding test and update
4030         test to expect that a new WebProcess is created.
4031
4032         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4033         (WTR::InjectedBundlePage::decidePolicyForResponse):
4034         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
4035         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
4036         In this new process, we have constructed a InjectedBundlePage for the page but we
4037         have not initialized the InjectedBundle members such as testRunner.
4038
4039         * WebKitTestRunner/TestController.cpp:
4040         (WTR::TestController::createWebViewWithOptions):
4041         (WTR::updateTestOptionsFromTestHeader):
4042         * WebKitTestRunner/TestOptions.h:
4043         (WTR::TestOptions::hasSameInitializationOptions const):
4044         Add a way for layout tests to turn on process swap on navigation via a test header.
4045
4046 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
4047
4048         Unreviewed, reland r230697, r230720, and r230724.
4049         https://bugs.webkit.org/show_bug.cgi?id=184600
4050
4051         * Scripts/run-jsc-stress-tests:
4052
4053 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4054
4055         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
4056         https://bugs.webkit.org/show_bug.cgi?id=184687
4057
4058         Reviewed by Michael Catanzaro.
4059
4060         Add test cases for the new API.
4061
4062         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4063         (fooCreate):
4064         (fooFree):
4065         (fooGetProperty):
4066         (fooSetProperty):
4067         (testJSCPromises):
4068         (testJSCGarbageCollector):
4069         (testsJSCVirtualMachine):
4070         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4071         (windowObjectClearedCallback):
4072
4073 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4074
4075         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
4076         https://bugs.webkit.org/show_bug.cgi?id=184635
4077         <rdar://problem/39440642>
4078
4079         Reviewed by Tim Horton.
4080
4081         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
4082         dismissing or presenting fullscreen input view controllers in extra zoom mode.
4083
4084         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4085         (-[TestRunnerWKWebView initWithFrame:configuration:]):
4086         (-[TestRunnerWKWebView dealloc]):
4087         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
4088         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
4089         (-[TestRunnerWKWebView _keyboardDidShow:]):
4090         (-[TestRunnerWKWebView _keyboardDidHide:]):
4091         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
4092         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
4093
4094 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
4095
4096         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
4097         https://bugs.webkit.org/show_bug.cgi?id=184573
4098
4099         Reviewed by Carlos Alberto Lopez Perez.
4100
4101         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4102         (TestWebKitAPI::TEST):
4103
4104 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4105
4106         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
4107         https://bugs.webkit.org/show_bug.cgi?id=184524
4108
4109         Reviewed by Alex Christensen.
4110
4111         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
4112
4113         * TestWebKitAPI/PlatformWebView.h:
4114         * TestWebKitAPI/PlatformWin.cmake:
4115         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
4116         (TestWebKitAPI::InjectedBundleController::platformInitialize):
4117         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
4118         (TestWebKitAPI::Util::moduleDirectory):
4119         (TestWebKitAPI::Util::createInjectedBundlePath):
4120         (TestWebKitAPI::Util::createURLForResource):
4121         (TestWebKitAPI::Util::URLForNonExistentResource):
4122         (TestWebKitAPI::Util::isKeyDown):
4123         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
4124         (TestWebKitAPI::PlatformWebView::registerWindowClass):
4125         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4126         (TestWebKitAPI::PlatformWebView::initialize):
4127         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
4128         (TestWebKitAPI::PlatformWebView::page const):
4129         (TestWebKitAPI::PlatformWebView::resizeTo):
4130         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
4131         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
4132         (TestWebKitAPI::PlatformWebView::simulateRightClick):
4133         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
4134         (TestWebKitAPI::PlatformWebView::wndProc):
4135         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
4136         (TestWebKitAPI::Util::run):
4137         (TestWebKitAPI::Util::spinRunLoop):
4138         (TestWebKitAPI::Util::sleep):
4139
4140 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
4141
4142         Fix hasher tests for system with 32 bit longs
4143         https://bugs.webkit.org/show_bug.cgi?id=184708
4144         <rdar://problem/39459977>
4145
4146         Reviewed by Mark Lam.
4147
4148         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
4149
4150         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
4151         (TestWebKitAPI::TEST):
4152
4153 2018-04-17  Commit Queue  <commit-queue@webkit.org>
4154
4155         Unreviewed, rolling out r230697, r230720, and r230724.
4156         https://bugs.webkit.org/show_bug.cgi?id=184717
4157
4158         These caused multiple failures on the Test262 testers.
4159         (Requested by mlewis13 on #webkit).
4160
4161         Reverted changesets:
4162
4163         "[WebAssembly][Modules] Prototype wasm import"
4164         https://bugs.webkit.org/show_bug.cgi?id=184600
4165         https://trac.webkit.org/changeset/230697
4166
4167         "[WebAssembly][Modules] Implement function import from wasm
4168         modules"
4169         https://bugs.webkit.org/show_bug.cgi?id=184689
4170         https://trac.webkit.org/changeset/230720
4171
4172         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
4173         https://bugs.webkit.org/show_bug.cgi?id=184703
4174         https://trac.webkit.org/changeset/230724
4175
4176 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
4177
4178         Unreviewed rollout of r230632. Regression in memory usage.
4179
4180         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
4181
4182         * DumpRenderTree/TestOptions.h:
4183         * DumpRenderTree/mac/DumpRenderTree.mm:
4184         (runTest):
4185         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
4186         * WebKitTestRunner/TestController.cpp:
4187         (WTR::TestController::resetPreferencesToConsistentValues):
4188         * WebKitTestRunner/TestOptions.cpp:
4189         (WTR::TestOptions::TestOptions):
4190         (WTR::isLegacyAnimationEngineTestPath): Deleted.
4191         * WebKitTestRunner/TestOptions.h:
4192
4193 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
4194
4195         [JSC] Rename runWebAssembly to runWebAssemblySuite
4196         https://bugs.webkit.org/show_bug.cgi?id=184703
4197
4198         Reviewed by JF Bastien.
4199
4200         * Scripts/run-jsc-stress-tests:
4201
4202 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
4203
4204         [WebAssembly][Modules] Implement function import from wasm modules
4205         https://bugs.webkit.org/show_bug.cgi?id=184689
4206
4207         Reviewed by JF Bastien.
4208
4209         Add runWebAssemblyDirect, which runs wasm file directly.
4210
4211         * Scripts/run-jsc-stress-tests:
4212
4213 2018-04-17  Saam Barati  <sbarati@apple.com>
4214
4215         Add system trace points for process launch and for initializeWebProcess
4216         https://bugs.webkit.org/show_bug.cgi?id=184669
4217
4218         Reviewed by Simon Fraser.
4219
4220         * Tracing/SystemTracePoints.plist:
4221
4222 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
4223
4224         Add debug bots for WinCairo.
4225         https://bugs.webkit.org/show_bug.cgi?id=184663
4226
4227         Reviewed by Lucas Forschler.
4228
4229         * BuildSlaveSupport/build.webkit.org-config/config.json:
4230         Add a debug build bot and two debug test bots.
4231
4232         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
4233         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4234         Add a WinCairo category to build.webkit.org.
4235
4236 2018-04-17  Zalan Bujtas  <zalan@apple.com>
4237
4238         [LayoutReloaded] Set inline-block box position.
4239         https://bugs.webkit.org/show_bug.cgi?id=184690
4240
4241         Reviewed by Antti Koivisto.
4242
4243         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4244         (InlineFormattingContext.prototype._handleInlineBlock):
4245         * LayoutReloaded/Utils.js:
4246         (Utils._dumpBox):
4247         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
4248
4249 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4250
4251         [GLIB] Add API to clear JSCContext uncaught exception
4252         https://bugs.webkit.org/show_bug.cgi?id=184685
4253
4254         Reviewed by Žan Doberšek.
4255
4256         Add test cases for the new API.
4257
4258         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4259         (testJSCExceptions):
4260
4261 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4262
4263         [GLIB] Add API to query, delete and enumerate properties
4264         https://bugs.webkit.org/show_bug.cgi?id=184647
4265
4266         Reviewed by Michael Catanzaro.
4267
4268         Add test cases for the new API.
4269
4270         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4271         (testJSCObject):
4272         (testJSCClass):
4273         (testJSCPrototypes):
4274
4275 2018-04-16  Zalan Bujtas  <zalan@apple.com>
4276
4277         [LayoutReloaded] Add support for replaced box.
4278         https://bugs.webkit.org/show_bug.cgi?id=184680
4279
4280         Reviewed by Antti Koivisto.
4281
4282         Basic support for inline replaced.
4283
4284         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4285         (InlineFormattingContext.prototype._handleInlineBox):
4286         (InlineFormattingContext.prototype._handleInlineBlock):
4287         (InlineFormattingContext.prototype._handleReplaced):
4288         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
4289         (Line.prototype.lastLineBox):
4290         (Line.prototype.addInlineBox):
4291         (Line.prototype.addInlineContainerBox): Deleted.
4292         * LayoutReloaded/TreeBuilder.js:
4293         (TreeBuilder.prototype._createAndAttachBox):
4294         * LayoutReloaded/Utils.js:
4295         (Utils._dumpBox):